litmus-rt.git/drivers/scsi/libsas, branch tracing-devel

[SCSI] libsas: do not set res = 0 in sas_ex_discover_dev()

2009-11-06T19:10:42+00:00

We should not set res to 0 in function sas_ex_discover_dev  in order to let
it discover it further when wide port hotplug in .

Signed-off-by: Tom Peng 
Signed-off-by: Jack Wang 
Signed-off-by: James Bottomley

[SCSI] libsas: fix wide port hotplug issues

2009-07-30T14:54:39+00:00

Hotplug of phys which form wide ports simply does not work at the moment.  Fix
this by adding checks at the hotplug points to see if the attached sas address
of the phy already exists (in which case it's part of a wide port) and act
accordingly.

Signed-off-by: Tom Peng 
Signed-off-by: Jack Wang 
Signed-off-by: Lindar Liu 
Signed-off-by: Kevin Ao 
[jejb: tidied up coding, fixed an error case and made TRUE/FALSE lower
 case to fix a ppc64 compile error in linux-next]
Signed-off-by: James Bottomley

[SCSI] libsas: reuse the original port when hotplugging phys in wide ports

2009-07-16T17:50:44+00:00

There's a hotplug problem in the way libsas allocates ports: it loops over the
available ports first trying to add to an existing for a wide port and
otherwise allocating the next free port.  This scheme only works if the port
array is packed from zero, which fails if a port gets hot unplugged and the
array becomes sparse.  In that case, a new port is formed even if there's a
wide port it should be part of.  Fix this by creating two loops over all the
ports:  the first to see if the phy should be part of a wide port and the
second to form a new port in an empty port slot.

Signed-off-by: Tom Peng 
Signed-off-by: Jack Wang 
Signed-off-by: Lindar Liu 
Cc: Stable Tree 
Signed-off-by: James Bottomley

block: set rq->resid_len to blk_rq_bytes() on issue

2009-05-19T09:36:08+00:00

In commit c3a4d78c580de4edc9ef0f7c59812fb02ceb037f, while introducing
rq->resid_len, the default value of residue count was changed from
full count to zero.  The conversion was done under the assumption that
when a request fails residue count wasn't defined.  However, Boaz and
James pointed out that this wasn't true and the residue count should
be preserved for failed requests too.

This patchset restores the original behavior by setting rq->resid_len
to blk_rq_bytes(rq) on request start and restoring explicit clearing
in affected drivers.  While at it, take advantage of the fact that
rq->resid_len is set to full count where applicable.

* ide-cd: rq->resid_len cleared on pc success

* mptsas: req->resid_len cleared on success

* sas_expander: rsp/req->resid_len cleared on success

* mpt2sas_transport: req->resid_len cleared on success

* ide-cd, ide-tape, mptsas, sas_host_smp, mpt2sas_transport, ub: take
  advantage of initial full count to simplify code

Boaz Harrosh spotted bug in resid_len initialization.  Fixed as
suggested.

Signed-off-by: Tejun Heo 
Acked-by: Borislav Petkov 
Cc: Boaz Harrosh 
Cc: James Bottomley 
Cc: Pete Zaitcev 
Cc: Bartlomiej Zolnierkiewicz 
Cc: Sergei Shtylyov 
Cc: Eric Moore 
Cc: Darrick J. Wong 
Signed-off-by: Jens Axboe

block: cleanup rq->data_len usages

2009-05-11T07:50:55+00:00

With recent unification of fields, it's now guaranteed that
rq->data_len always equals blk_rq_bytes().  Convert all non-IDE direct
users to accessors.  IDE will be converted in a separate patch.

Boaz: spotted incorrect data_len/resid_len conversion in osd.

[ Impact: convert direct rq->data_len usages to blk_rq_bytes() ]

Signed-off-by: Tejun Heo 
Acked-by: Sergei Shtylyov 
Cc: Pete Zaitcev 
Cc: Eric Moore 
Cc: Markus Lidel 
Cc: Darrick J. Wong 
Cc: James Bottomley 
Cc: Eric Moore 
Cc: Boaz Harrosh 
Cc: FUJITA Tomonori 
Signed-off-by: Jens Axboe

block: add rq->resid_len

2009-05-11T07:50:53+00:00

rq->data_len served two purposes - the length of data buffer on issue
and the residual count on completion.  This duality creates some
headaches.

First of all, block layer and low level drivers can't really determine
what rq->data_len contains while a request is executing.  It could be
the total request length or it coulde be anything else one of the
lower layers is using to keep track of residual count.  This
complicates things because blk_rq_bytes() and thus
[__]blk_end_request_all() relies on rq->data_len for PC commands.
Drivers which want to report residual count should first cache the
total request length, update rq->data_len and then complete the
request with the cached data length.

Secondly, it makes requests default to reporting full residual count,
ie. reporting that no data transfer occurred.  The residual count is
an exception not the norm; however, the driver should clear
rq->data_len to zero to signify the normal cases while leaving it
alone means no data transfer occurred at all.  This reverse default
behavior complicates code unnecessarily and renders block PC on some
drivers (ide-tape/floppy) unuseable.

This patch adds rq->resid_len which is used only for residual count.

While at it, remove now unnecessasry blk_rq_bytes() caching in
ide_pc_intr() as rq->data_len is not changed anymore.

Boaz	: spotted missing conversion in osd
Sergei	: spotted too early conversion to blk_rq_bytes() in ide-tape

[ Impact: cleanup residual count handling, report 0 resid by default ]

Signed-off-by: Tejun Heo 
Cc: James Bottomley 
Cc: Bartlomiej Zolnierkiewicz 
Cc: Borislav Petkov 
Cc: Sergei Shtylyov 
Cc: Mike Miller 
Cc: Eric Moore 
Cc: Alan Stern 
Cc: FUJITA Tomonori 
Cc: Doug Gilbert 
Cc: Mike Miller 
Cc: Eric Moore 
Cc: Darrick J. Wong 
Cc: Pete Zaitcev 
Cc: Boaz Harrosh 
Signed-off-by: Jens Axboe

[libata] get-identity ioctl: Fix use of invalid memory pointer

2009-01-16T15:17:09+00:00

for SAS drivers.

Caught by Ke Wei (and team?) at Marvell.

Also, move the ata_scsi_ioctl export to libata-scsi.c, as that seems to be the
general trend.

Acked-by: James Bottomley 
Signed-off-by: Jeff Garzik

[SCSI] libsas: fix test for negative unsigned and typos

2009-01-02T18:16:38+00:00

unsigned req->data_len cannot be negative, and fix =-/-= typo

Signed-off-by: Roel Kluin 
Signed-off-by: James Bottomley

[SCSI] struct device - replace bus_id with dev_name(), dev_set_name()

2009-01-02T16:22:16+00:00

[jejb: limit ioctl to returning 20 characters to avoid overrun
       on long device names and add a few more conversions]
Signed-off-by: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: James Bottomley

Merge branch 'for-2.6.28' of git://git.kernel.dk/linux-2.6-block

2008-10-10T17:52:45+00:00

* 'for-2.6.28' of git://git.kernel.dk/linux-2.6-block: (132 commits)
  doc/cdrom: Trvial documentation error, file not present
  block_dev: fix kernel-doc in new functions
  block: add some comments around the bio read-write flags
  block: mark bio_split_pool static
  block: Find bio sector offset given idx and offset
  block: gendisk integrity wrapper
  block: Switch blk_integrity_compare from bdev to gendisk
  block: Fix double put in blk_integrity_unregister
  block: Introduce integrity data ownership flag
  block: revert part of d7533ad0e132f92e75c1b2eb7c26387b25a583c1
  bio.h: Remove unused conditional code
  block: remove end_{queued|dequeued}_request()
  block: change elevator to use __blk_end_request()
  gdrom: change to use __blk_end_request()
  memstick: change to use __blk_end_request()
  virtio_blk: change to use __blk_end_request()
  blktrace: use BLKTRACE_BDEV_SIZE as the name size for setup structure
  block: add lld busy state exporting interface
  block: Fix blk_start_queueing() to not kick a stopped queue
  include blktrace_api.h in headers_install
  ...