litmus-rt.git/drivers/net/ixgb, branch wip-default-clustering

e100/e1000/igb/ixgb*: Add missing read memory barrier

2010-08-09T03:02:45+00:00

Based on patches from Sonny Rao and Milton Miller...

Combined the patches to fix up clean_tx_irq and clean_rx_irq.

The PowerPC architecture does not require loads to independent bytes
to be ordered without adding an explicit barrier.

In ixgbe_clean_rx_irq we load the status bit then load the packet data.
With packet split disabled if these loads go out of order we get a
stale packet, but we will notice the bad sequence numbers and drop it.

The problem occurs with packet split enabled where the TCP/IP header
and data are in different descriptors. If the reads go out of order
we may have data that doesn't match the TCP/IP header. Since we use
hardware checksumming this bad data is never verified and it makes it
all the way to the application.

This bug was found during stress testing and adding this barrier has
been shown to fix it.  The bug can manifest as a data integrity issue
(bad payload data) or as a BUG in skb_pull().

This was a nasty bug to hunt down, if people agree with the fix I think
it's a candidate for stable.

Previously Submitted to e1000-devel only for ixgbe

http://marc.info/?l=e1000-devel&m=126593062701537&w=3

We've now seen this problem hit with other device drivers (e1000e mostly)
So I'm resubmitting with fixes for other Intel Device Drivers with
similar issues.

CC: Milton Miller 
CC: Anton Blanchard 
CC: Sonny Rao 
CC: stable 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

ixgb and e1000: Use new function for copybreak tests

2010-05-14T10:06:19+00:00

There appears to be an off-by-1 defect in the maximum packet size
copied when copybreak is speified in these modules.

The copybreak module params are specified as:
"Maximum size of packet that is copied to a new buffer on receive"

The tests are changed from "< copybreak" to "<= copybreak"
and moved into new static functions for readability.

Signed-off-by: Joe Perches 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

drivers/net: Remove unnecessary returns from void function()s

2010-05-14T07:19:28+00:00

This patch removes from drivers/net/ all the unnecessary
return; statements that precede the last closing brace of
void functions.

It does not remove the returns that are immediately
preceded by a label as gcc doesn't like that.

It also does not remove null void functions with return.

Done via:
$ grep -rP --include=*.[ch] -l "return;\n}" net/ | \
  xargs perl -i -e 'local $/ ; while (<>) { s/\n[ \t\n]+return;\n}/\n}/g; print; }'

with some cleanups by hand.

Compile tested x86 allmodconfig only.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

ixgb: use DMA API instead of PCI DMA functions

2010-04-27T23:29:51+00:00

Signed-off-by: Nicholas Nunley 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

ixgb: Use pr_ and netdev_

2010-04-27T19:53:30+00:00

Convert DEBUGOUTx to pr_debug
Convert DEBUGFUNC to more commonly used ENTER
Convert mac address output to %pM
Use #define pr_fmt
Convert a few printks to pr_
Improve ixgb_mc_addr_list_update: use a temporary for current mc address
Use etherdevice.h functions for mac address testing

Signed-off-by: Joe Perches 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

net: convert multicast list to list_head

2010-04-03T21:22:15+00:00

Converts the list and the core manipulating with it to be the same as uc_list.

+uses two functions for adding/removing mc address (normal and "global"
 variant) instead of a function parameter.
+removes dev_mcast.c completely.
+exposes netdev_hw_addr_list_* macros along with __hw_addr_* functions for
 manipulation with lists on a sandbox (used in bonding and 80211 drivers)

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: convert multiple drivers to use netdev_for_each_mc_addr, part4

2010-02-22T23:45:52+00:00

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

drivers/net/ixgb: Use netif_printk macros

2010-02-16T23:45:42+00:00

Convert private DPRINTK macro uses to netif_ equivalents
Remove #define DPRINTK

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

net: use netdev_mc_count and netdev_mc_empty when appropriate

2010-02-12T19:38:58+00:00

This patch replaces dev->mc_count in all drivers (hopefully I didn't miss
anything). Used spatch and did small tweaks and conding style changes when
it was suitable.

Jirka

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6

2010-01-23T08:31:06+00:00