litmus-rt.git/drivers/infiniband/core, branch test

IB/cma: Fix broken AF_IB UD support

2015-05-20T20:15:56+00:00

Support for using UD and AF_IB is currently broken.  The
IB_CM_SIDR_REQ_RECEIVED message is not handled properly in
cma_save_net_info() and we end up falling into code that will try and
process the request as ipv4/ipv6, which will end up failing.

The resolution is to add a check for the SIDR_REQ and call
cma_save_ib_info() with a NULL path record.  Change cma_save_ib_info()
to copy the src sib info from the listen_id when the path record is NULL.

Reported-by: Hari Shankar 
Signed-off-by: Matt Finlay 
Acked-by: Sean Hefty 
Signed-off-by: Doug Ledford

ib/cm: Change reject message type when destroying cm_id

2015-05-20T16:41:38+00:00

Problem reported by: Ted Kim :

We have a case where a Linux system and a non-Linux system are
trying to interoperate.  The Linux host is the active side and
starts the connection establishment, but later decides to not go
through with the connection setup and does rdma_destroy_id().

The rdma_destroy_id() eventually works its way down to cm_destroy_id()
in core/cm.c, where a REJ is sent. The non-Linux system
has some trouble recognizing the REJ because of:

A. CM states which can't receive the REJ
B. Some issues about REJ formatting (missing comm ID)

ISSUE A: That part of the spec says, a Consumer Reject REJ can be
sent for a connection abort, but it goes further
and says: can send a REJ message with a "Consumer Reject"
Reason code if they are in a CM state (i.e. REP
Rcvd, MRA(REP) Sent, REQ Rcvd, MRA Sent) that allows
a REJ to be sent (lines 35-38).

Of the states listed there in that sentence, it would
seem to limit the active side to using the Consumer Reject
(for the abort case) in just the REP-Rcvd and MRA-REP-Sent
states. That is basically only after the active side
sees a REP (or alternatively goes down the state transitions
to timeout in which case a Timeout REJ is sent).

As a fix, in cm-destroy-id() move the IB-CM-MRA-REQ-RCVD case
to the same as REQ-SENT.  Essentially, make a REJ sent after
getting an MRA on active side a timeout rather than Consumer-
Reject, which is arguably more correct with the CM state
diagrams previous to getting a REP.

Signed-off-by: Ted Kim 
Signed-off-by: Sean Hefty

RDMA/core: Fix for parsing netlink string attribute

2015-05-12T17:03:04+00:00

The string iwpm_ulib_name is recorded in a nlmsg as a netlink attribute.
Without this fix parsing of the nlmsg by the userspace port mapper service fails
because of unknown attribute length, causing the port mapper service not to
register the client, which has sent the nlmsg.

Signed-off-by: Tatyana Nikolova 
Cc:  #v3.16
Reviewed-By: Jason Gunthorpe 
Signed-off-by: Doug Ledford

IB/core: Fix unaligned accesses

2015-05-05T17:21:27+00:00

Addresses the following kernel logs seen during boot of sparc systems:

Kernel unaligned access at TPC[103bce50] cm_find_listen+0x34/0xf8 [ib_cm]
Kernel unaligned access at TPC[103bce50] cm_find_listen+0x34/0xf8 [ib_cm]
Kernel unaligned access at TPC[103bce50] cm_find_listen+0x34/0xf8 [ib_cm]
Kernel unaligned access at TPC[103bce50] cm_find_listen+0x34/0xf8 [ib_cm]
Kernel unaligned access at TPC[103bce50] cm_find_listen+0x34/0xf8 [ib_cm]

Signed-off-by: David Ahern 
Signed-off-by: Doug Ledford

IB/core: change rdma_gid2ip into void function as it always return zero

2015-05-05T17:21:27+00:00

Signed-off-by: Honggang Li 
Acked-by: Sean Hefty 
Signed-off-by: Doug Ledford

IB/core: dma unmap optimizations

2015-05-05T13:18:02+00:00

While unmapping an ODP writable page, the dirty bit of the page is set. In
order to do so, the head of the compound page is found.
Currently, the compound head is found even on non-writable pages, where it is
never used, leading to unnecessary cpu barrier that impacts performance.

This patch moves the search for the compound head to be done only when needed.

Signed-off-by: Guy Shapiro 
Acked-by: Shachar Raindel 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Doug Ledford

IB/core: dma map/unmap locking optimizations

2015-05-05T13:18:02+00:00

Currently, while mapping or unmapping pages for ODP, the umem mutex is locked
and unlocked once for each page. Such lock/unlock operation take few tens to
hundreds of nsecs. This makes a significant impact when mapping or unmapping few
MBs of memory.

To avoid this, the mutex should be locked only once per operation, and not per
page.

Signed-off-by: Guy Shapiro 
Acked-by: Shachar Raindel 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Doug Ledford

RDMA/core: Enable the iWarp Port Mapper to provide the actual address of the connecting peer to its clients

2015-05-05T13:18:01+00:00

Add functionality to enable the port mapper on the passive side to provide to its
clients the actual (non-mapped) ip/tcp address information of the connecting peer

1) Adding remote_info_cb() to process the address info of the connecting peer
   The address info is provided by the user space port mapper service when
   the connection is initiated by the peer
2) Adding a hash list to store the remote address info
3) Adding functionality to add/remove the remote address info
   After the info has been provided to the port mapper client,
   it is removed from the hash list

Signed-off-by: Tatyana Nikolova 
Reviewed-by: Steve Wise 
Signed-off-by: Doug Ledford

RDMA/CMA: Canonize IPv4 on IPV6 sockets properly

2015-05-05T13:18:01+00:00

When accepting a new IPv4 connect to an IPv6 socket, the CMA tries to
canonize the address family to IPv4, but does not properly process
the listening sockaddr to get the listening port, and does not properly
set the address family of the canonized sockaddr.

Fixes: e51060f08a61 ("IB: IP address based RDMA connection manager")

Cc: 
Reported-By: Yotam Kenneth 
Signed-off-by: Jason Gunthorpe 
Tested-by: Haggai Eran 
Signed-off-by: Doug Ledford

Merge branches 'cve-fixup', 'ipoib', 'iser', 'misc-4.1', 'or-mlx4' and 'srp' into for-4.1

2015-04-15T20:24:49+00:00