litmus-rt.git/drivers/base, branch v2.6.33

class: Free the class private data in class_release

2010-02-16T23:43:00+00:00

Fix a memory leak by freeing the memory allocated in __class_register
for the class private data.

Signed-off-by: Laurent Pinchart 
Acked-by: Artem Bityutskiy 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

Revert "sysdev: fix prototype for memory_sysdev_class show/store functions"

2010-01-20T23:02:13+00:00

This reverts commit 8ff410daa009c4b44be445ded5b0cec00abc0426

It should not have been sent to Linus's tree yet, as it depends
on changes that are queued up in my driver-core for the .34 kernel
merge.

Cc: Wu Fengguang 
Cc: Andi Kleen 
Cc: "Zheng, Shaohui" 
Cc: Andrew Morton 
Cc: Linus Torvalds
Signed-off-by: Greg Kroah-Hartman

driver-core: fix devtmpfs crash on s390

2010-01-20T23:02:05+00:00

On Mon, Jan 18, 2010 at 05:26:20PM +0530, Sachin Sant wrote:
> Hello Heiko,
>
> Today while trying to boot next-20100118 i came across
> the following Oops :
>
> Brought up 4 CPUs
> Unable to handle kernel pointer dereference at virtual kernel address 0000000000
> 543000
> Oops: 0004 #1 SMP
> Modules linked in:
> CPU: 0 Not tainted 2.6.33-rc4-autotest-next-20100118-5-default #1
> Process swapper (pid: 1, task: 00000000fd792038, ksp: 00000000fd797a30)
> Krnl PSW : 0704200180000000 00000000001eb0b8 (shmem_parse_options+0xc0/0x328)
>           R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:0 CC:2 PM:0 EA:3
> Krnl GPRS: 000000000054388a 000000000000003d 0000000000543836 000000000000003d
>           0000000000000000 0000000000483f28 0000000000536112 00000000fd797d00
>           00000000fd4ba100 0000000000000100 0000000000483978 0000000000543832
>           0000000000000000 0000000000465958 00000000001eb0b0 00000000fd797c58
> Krnl Code: 00000000001eb0aa: c0e5000994f1       brasl   %r14,31da8c
>           00000000001eb0b0: b9020022           ltgr    %r2,%r2
>           00000000001eb0b4: a784010b           brc     8,1eb2ca
>          >00000000001eb0b8: 92002000           mvi     0(%r2),0
>           00000000001eb0bc: a7080000           lhi     %r0,0
>           00000000001eb0c0: 41902001           la      %r9,1(%r2)
>           00000000001eb0c4: b9040016           lgr     %r1,%r6
>           00000000001eb0c8: b904002b           lgr     %r2,%r11
> Call Trace:
> (<00000000fd797c50> 0xfd797c50)
> <00000000001eb5da> shmem_fill_super+0x13a/0x25c
> <0000000000228cfa> get_sb_single+0xbe/0xdc
> <000000000034ffc0> dev_get_sb+0x2c/0x38
> <000000000066c602> devtmpfs_init+0x46/0xc0
> <000000000066c53e> driver_init+0x22/0x60
> <000000000064d40a> kernel_init+0x24e/0x3d0
> <000000000010a7ea> kernel_thread_starter+0x6/0xc
> <000000000010a7e4> kernel_thread_starter+0x0/0xc
>
> I never tried to boot a kernel with DEVTMPFS enabled on a s390 box.
> So am wondering if this is supported or not ? If you think this
> is supported i will send a mail to community on this.

There is nothing arch specific to devtmpfs. This part crashes because the
kernel tries to modify the data read-only section which is write protected
on s390.

Signed-off-by: Heiko Carstens 
Acked-by: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

sysdev: fix prototype for memory_sysdev_class show/store functions

2010-01-16T20:15:39+00:00

The function prototype mismatches in call stack:

                [] print_block_size+0x58/0x60
                [] sysdev_class_show+0x1f/0x30
                [] sysfs_read_file+0xcb/0x1f0
                [] vfs_read+0xc8/0x180

Due to prototype mismatch, print_block_size() will sprintf() into
*attribute instead of *buf, hence user space will read the initial
zeros from *buf:
	$ hexdump /sys/devices/system/memory/block_size_bytes
	0000000 0000 0000 0000 0000
	0000008

After patch:
	cat /sys/devices/system/memory/block_size_bytes
	0x8000000

This complements commits c29af9636 and 4a0b2b4dbe.

Signed-off-by: Wu Fengguang 
Cc: Andi Kleen 
Cc: Greg Kroah-Hartman 
Cc: "Zheng, Shaohui" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

memory-hotplug: add 0x prefix to HEX block_size_bytes

2010-01-16T20:15:39+00:00

Signed-off-by: Wu Fengguang 
Cc: Andi Kleen 
Cc: Greg KH 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

power: fix kernel-doc notation

2010-01-11T17:34:06+00:00

Warning(drivers/base/power/main.c:453): No description found for parameter 'dev'
Warning(drivers/base/power/main.c:453): No description found for parameter 'cb'
Warning(drivers/base/power/main.c:719): No description found for parameter 'dev'
Warning(drivers/base/power/main.c:719): No description found for parameter 'state'
Warning(drivers/base/power/main.c:719): No description found for parameter 'cb'

Signed-off-by: Randy Dunlap 
Cc: Rafael J. Wysocki 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

devtmpfs: unlock mutex in case of string allocation error

2009-12-23T19:23:44+00:00

Reported-by: Kirill A. Shutemov 
Signed-off-by: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

Driver core: export platform_device_register_data as a GPL symbol

2009-12-23T19:23:44+00:00

This allows MFD's to register/bind drivers for their sub devices while
still being compiled as a module.

Signed-off-by: Michael Hennerich 
Signed-off-by: Mike Frysinger 
Signed-off-by: Greg Kroah-Hartman

driver core: Prevent reference to freed memory on error path

2009-12-23T19:23:44+00:00

priv is drv->p. So only free drv->p after we've finished using priv.

Found using a static code analysis tool

Signed-off-by: Phil Carmody 
Signed-off-by: Greg Kroah-Hartman

Driver-core: Fix bogus 0 error return in device_add()

2009-12-23T19:23:44+00:00

If device_add() is called with a device which does not have dev->p set
up, then device_private_init() is called. If that succeeds, then the
error variable is set to 0. Now if the dev_name(dev) check further
down fails, then device_add() correctly terminates, but returns 0.
That of course lets the driver progress. If later another driver uses
this half set up device as parent then device_add() of the child
device explodes and renders sysfs completely unusable.

Set the error to -EINVAL if dev_name() check fails.

Signed-off-by: Thomas Gleixner 
Cc: Kay Sievers 
Cc: "Hans J. Koch" 
Signed-off-by: Greg Kroah-Hartman