litmus-rt.git/arch/x86/kernel/cpu/microcode, branch test

x86/microcode/amd: Drop the pci_ids.h dependency

2015-03-31T07:54:32+00:00

This file doesn't use any macros from pci_ids.h anymore, drop the include.

Signed-off-by: Michael S. Tsirkin 
Signed-off-by: Borislav Petkov 
Cc: Andreas Herrmann 
Cc: H. Peter Anvin 
Cc: Thomas Gleixner 
Link: http://lkml.kernel.org/r/1427635734-24786-80-git-send-email-mst@redhat.com
Signed-off-by: Ingo Molnar

x86/microcode/intel: Fix printing of microcode blobs in show_saved_mc()

2015-03-02T19:32:34+00:00

When doing

  echo 1 > /sys/devices/system/cpu/microcode/reload

in order to reload microcode, I get:

  microcode: Total microcode saved: 1
  BUG: using smp_processor_id() in preemptible [00000000] code: bash/2606
  caller is debug_smp_processor_id+0x17/0x20
  CPU: 1 PID: 2606 Comm: bash Not tainted 3.19.0-rc7+ #9
  Hardware name: LENOVO 2320CTO/2320CTO, BIOS G2ET86WW (2.06 ) 11/13/2012
   ffffffff81a4266d ffff8802131db808 ffffffff81666588 0000000000000007
   0000000000000001 ffff8802131db838 ffffffff812e6eef ffff8802131db868
   00000000000306a9 0000000000000010 0000000000000015 ffff8802131db848
  Call Trace:
   dump_stack
   check_preemption_disabled
   debug_smp_processor_id
   show_saved_mc
   ? save_microcode.constprop.8
   save_mc_for_early
   ? print_context_stack
   ? dump_trace
   ? __bfs
   ? mark_held_locks
   ? get_page_from_freelist
   ? trace_hardirqs_on_caller
   ? trace_hardirqs_on
   ? __alloc_pages_nodemask
   ? __get_vm_area_node
   ? map_vm_area
   ? __vmalloc_node_range
   ? generic_load_microcode
   generic_load_microcode
   ? microcode_fini_cpu
   request_microcode_fw
   reload_store
   dev_attr_store
   sysfs_kf_write
   kernfs_fop_write
   vfs_write
   ? sysret_check
   SyS_write
   system_call_fastpath
  microcode: CPU1: sig=0x306a9, pf=0x10, rev=0x15
  microcode: mc_saved[0]: sig=0x306a9, pf=0x12, rev=0x1b, toal size=0x3000, date = 2014-05-29

because we're using smp_processor_id() in preemtible context. And we
don't really need to use it there because the microcode container we're
dumping is global and CPU-specific info is irrelevant.

While at it, make pr_* stuff use "microcode: " prefix for easier
grepping and document how to enable the DEBUG build.

Signed-off-by: Borislav Petkov

x86/microcode/intel: Check scan_microcode()'s retval

2015-03-02T19:32:20+00:00

... and do not attempt to load anything in case of error.

Signed-off-by: Borislav Petkov

x86/microcode/intel: Sanitize microcode_pointer()

2015-03-02T19:32:16+00:00

Shorten variable names and rename it to what it does.

No functionality change.

Signed-off-by: Borislav Petkov

x86/microcode/intel: Move mc arg last in get_matching_{microcode|sig}

2015-03-02T19:32:13+00:00

... arguments list so that it comes more natural for those functions to
have the signature, processor flags and revision together, before the
rest of the args.

No functionality change.

Signed-off-by: Borislav Petkov

x86/microcode/intel: Simplify generic_load_microcode_early()

2015-03-02T19:32:10+00:00

* remove state variable and out label
* get rid of completely unused mc_size
* shorten variable names
* get rid of local variables
* don't do assignments in local var declarations for less cluttered code
* finally rename it to the shorter and perfectly fine load_microcode_early()

No functionality change.

Signed-off-by: Borislav Petkov

x86/microcode: Consolidate family,model, ... code

2015-03-02T19:32:07+00:00

... to the header. Split the family acquiring function into a
main one, doing CPUID and a helper which computes the extended
family and is used in multiple places. Get rid of the locally-grown
get_x86_{family,model}().

While at it, rename local variables to something more descriptive and
vertically align assignments for better readability.

There should be no functionality change resulting from this patch.

Signed-off-by: Borislav Petkov

x86/microcode/intel: Rename update_match_revision()

2015-03-02T19:32:03+00:00

... to revision_is_newer() and push it up into the header and make it an
inline function.

Signed-off-by: Borislav Petkov

x86/microcode/intel: Sanitize _save_mc()

2015-03-02T19:32:00+00:00

Shorten local variable names for better readability and flatten loop
indentation levels.

No functionality change.

Signed-off-by: Borislav Petkov

x86/microcode/intel: Make _save_mc() return the updated saved count

2015-03-02T19:31:56+00:00

... of microcode patches instead of handing in a pointer which is used
for I/O in an otherwise void function.

Signed-off-by: Borislav Petkov