29 files changed, 85 insertions, 88 deletions

diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index cda936b77d2..1583c5ef963 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -810,6 +810,7 @@ static int vlan_ioctl_handler(void __user *arg)
                 err = -EINVAL;
                 break;
         case GET_VLAN_REALDEV_NAME_CMD:
+                err = 0;
                 vlan_dev_get_realdev_name(dev, args.u.device2);
                 if (copy_to_user(arg, &args,
                                  sizeof(struct vlan_ioctl_args))) {
@@ -818,6 +819,7 @@ static int vlan_ioctl_handler(void __user *arg)
                 break;
 
         case GET_VLAN_VID_CMD:
+                err = 0;
                 vlan_dev_get_vid(dev, &vid);
                 args.u.VID = vid;
                 if (copy_to_user(arg, &args,
diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c
index 420bbb9955e..5c18595b761 100644
--- a/net/bridge/br_input.c
+++ b/net/bridge/br_input.c
@@ -112,9 +112,9 @@ static int br_handle_local_finish(struct sk_buff *skb)
  */
 static inline int is_link_local(const unsigned char *dest)
 {
-        const u16 *a = (const u16 *) dest;
-        static const u16 *const b = (const u16 *const ) br_group_address;
-        static const u16 m = __constant_cpu_to_be16(0xfff0);
+        __be16 *a = (__be16 *)dest;
+        static const __be16 *b = (const __be16 *)br_group_address;
+        static const __be16 m = __constant_cpu_to_be16(0xfff0);
 
         return ((a[0] ^ b[0]) | (a[1] ^ b[1]) | ((a[2] ^ b[2]) & m)) == 0;
 }
diff --git a/net/bridge/netfilter/ebt_log.c b/net/bridge/netfilter/ebt_log.c
index 031bfa4a51f..457815fb558 100644
--- a/net/bridge/netfilter/ebt_log.c
+++ b/net/bridge/netfilter/ebt_log.c
@@ -9,7 +9,6 @@
  *
  */
 
-#include <linux/in.h>
 #include <linux/netfilter_bridge/ebtables.h>
 #include <linux/netfilter_bridge/ebt_log.h>
 #include <linux/netfilter.h>
@@ -196,10 +195,8 @@ static int __init ebt_log_init(void)
         ret = ebt_register_watcher(&log);
         if (ret < 0)
                 return ret;
-        ret = nf_log_register(PF_BRIDGE, &ebt_log_logger);
-        if (ret < 0 && ret != -EEXIST)
-                ebt_unregister_watcher(&log);
-        return ret;
+        nf_log_register(PF_BRIDGE, &ebt_log_logger);
+        return 0;
 }
 
 static void __exit ebt_log_fini(void)
diff --git a/net/bridge/netfilter/ebt_ulog.c b/net/bridge/netfilter/ebt_ulog.c
index 9411db62591..204c968fa86 100644
--- a/net/bridge/netfilter/ebt_ulog.c
+++ b/net/bridge/netfilter/ebt_ulog.c
@@ -36,7 +36,6 @@
 #include <linux/timer.h>
 #include <linux/netlink.h>
 #include <linux/netdevice.h>
-#include <linux/module.h>
 #include <linux/netfilter_bridge/ebtables.h>
 #include <linux/netfilter_bridge/ebt_ulog.h>
 #include <net/sock.h>
@@ -308,12 +307,8 @@ static int __init ebt_ulog_init(void)
         else if ((ret = ebt_register_watcher(&ulog)))
                 sock_release(ebtulognl->sk_socket);
 
-        if (nf_log_register(PF_BRIDGE, &ebt_ulog_logger) < 0) {
-                printk(KERN_WARNING "ebt_ulog: not logging via ulog "
-                       "since somebody else already registered for PF_BRIDGE\n");
-                /* we cannot make module load fail here, since otherwise
-                 * ebtables userspace would abort */
-        }
+        if (ret == 0)
+                nf_log_register(PF_BRIDGE, &ebt_ulog_logger);
 
         return ret;
 }
diff --git a/net/ipv4/netfilter/ipt_LOG.c b/net/ipv4/netfilter/ipt_LOG.c
index 5937ad150b9..127a5e89bf1 100644
--- a/net/ipv4/netfilter/ipt_LOG.c
+++ b/net/ipv4/netfilter/ipt_LOG.c
@@ -479,10 +479,8 @@ static int __init ipt_log_init(void)
         ret = xt_register_target(&ipt_log_reg);
         if (ret < 0)
                 return ret;
-        ret = nf_log_register(PF_INET, &ipt_log_logger);
-        if (ret < 0 && ret != -EEXIST)
-                xt_unregister_target(&ipt_log_reg);
-        return ret;
+        nf_log_register(PF_INET, &ipt_log_logger);
+        return 0;
 }
 
 static void __exit ipt_log_fini(void)
diff --git a/net/ipv4/netfilter/nf_nat_core.c b/net/ipv4/netfilter/nf_nat_core.c
index e848d8d6292..deab27facba 100644
--- a/net/ipv4/netfilter/nf_nat_core.c
+++ b/net/ipv4/netfilter/nf_nat_core.c
@@ -77,7 +77,8 @@ static inline unsigned int
 hash_by_src(const struct nf_conntrack_tuple *tuple)
 {
         /* Original src, to ensure we map it consistently if poss. */
-        return jhash_3words((__force u32)tuple->src.u3.ip, tuple->src.u.all,
+        return jhash_3words((__force u32)tuple->src.u3.ip,
+                            (__force u32)tuple->src.u.all,
                             tuple->dst.protonum, 0) % nf_nat_htable_size;
 }
 
diff --git a/net/ipv4/netfilter/nf_nat_rule.c b/net/ipv4/netfilter/nf_nat_rule.c
index 0f45427e5fd..76ec59ae524 100644
--- a/net/ipv4/netfilter/nf_nat_rule.c
+++ b/net/ipv4/netfilter/nf_nat_rule.c
@@ -192,7 +192,7 @@ alloc_null_binding_confirmed(struct nf_conn *ct, unsigned int hooknum)
                 = (HOOK2MANIP(hooknum) == IP_NAT_MANIP_SRC
                    ? ct->tuplehash[IP_CT_DIR_REPLY].tuple.dst.u3.ip
                    : ct->tuplehash[IP_CT_DIR_REPLY].tuple.src.u3.ip);
-        u_int16_t all
+        __be16 all
                 = (HOOK2MANIP(hooknum) == IP_NAT_MANIP_SRC
                    ? ct->tuplehash[IP_CT_DIR_REPLY].tuple.dst.u.all
                    : ct->tuplehash[IP_CT_DIR_REPLY].tuple.src.u.all);
diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c
index df30976f6df..ca774d8e3be 100644
--- a/net/ipv6/ip6_tunnel.c
+++ b/net/ipv6/ip6_tunnel.c
@@ -385,7 +385,7 @@ parse_tlv_tnl_enc_lim(struct sk_buff *skb, __u8 * raw)
 
 static int
 ip6_tnl_err(struct sk_buff *skb, __u8 ipproto, struct inet6_skb_parm *opt,
-            int *type, int *code, int *msg, __be32 *info, int offset)
+            int *type, int *code, int *msg, __u32 *info, int offset)
 {
         struct ipv6hdr *ipv6h = (struct ipv6hdr *) skb->data;
         struct ip6_tnl *t;
@@ -435,7 +435,7 @@ ip6_tnl_err(struct sk_buff *skb, __u8 ipproto, struct inet6_skb_parm *opt,
                 if ((*code) == ICMPV6_HDR_FIELD)
                         teli = parse_tlv_tnl_enc_lim(skb, skb->data);
 
-                if (teli && teli == ntohl(*info) - 2) {
+                if (teli && teli == *info - 2) {
                         tel = (struct ipv6_tlv_tnl_enc_lim *) &skb->data[teli];
                         if (tel->encap_limit == 0) {
                                 if (net_ratelimit())
@@ -452,7 +452,7 @@ ip6_tnl_err(struct sk_buff *skb, __u8 ipproto, struct inet6_skb_parm *opt,
                 }
                 break;
         case ICMPV6_PKT_TOOBIG:
-                mtu = ntohl(*info) - offset;
+                mtu = *info - offset;
                 if (mtu < IPV6_MIN_MTU)
                         mtu = IPV6_MIN_MTU;
                 t->dev->mtu = mtu;
@@ -478,12 +478,12 @@ out:
 
 static int
 ip4ip6_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
-           int type, int code, int offset, __u32 info)
+           int type, int code, int offset, __be32 info)
 {
         int rel_msg = 0;
         int rel_type = type;
         int rel_code = code;
-        __u32 rel_info = info;
+        __u32 rel_info = ntohl(info);
         int err;
         struct sk_buff *skb2;
         struct iphdr *eiph;
@@ -564,10 +564,9 @@ ip4ip6_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
                         goto out;
 
                 skb2->dst->ops->update_pmtu(skb2->dst, rel_info);
-                rel_info = htonl(rel_info);
         }
 
-        icmp_send(skb2, rel_type, rel_code, rel_info);
+        icmp_send(skb2, rel_type, rel_code, htonl(rel_info));
 
 out:
         kfree_skb(skb2);
@@ -576,12 +575,12 @@ out:
 
 static int
 ip6ip6_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
-           int type, int code, int offset, __u32 info)
+           int type, int code, int offset, __be32 info)
 {
         int rel_msg = 0;
         int rel_type = type;
         int rel_code = code;
-        __u32 rel_info = info;
+        __u32 rel_info = ntohl(info);
         int err;
 
         err = ip6_tnl_err(skb, IPPROTO_IPV6, opt, &rel_type, &rel_code,
diff --git a/net/ipv6/netfilter/ip6t_LOG.c b/net/ipv6/netfilter/ip6t_LOG.c
index b05327ebd33..6ab99001dcc 100644
--- a/net/ipv6/netfilter/ip6t_LOG.c
+++ b/net/ipv6/netfilter/ip6t_LOG.c
@@ -493,10 +493,8 @@ static int __init ip6t_log_init(void)
         ret = xt_register_target(&ip6t_log_reg);
         if (ret < 0)
                 return ret;
-        ret = nf_log_register(PF_INET6, &ip6t_logger);
-        if (ret < 0 && ret != -EEXIST)
-                xt_unregister_target(&ip6t_log_reg);
-        return ret;
+        nf_log_register(PF_INET6, &ip6t_logger);
+        return 0;
 }
 
 static void __exit ip6t_log_fini(void)
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index d67fb1ef751..f10f3689d67 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -633,6 +633,7 @@ static int tcp_v6_md5_do_del(struct sock *sk, struct in6_addr *peer)
                         if (tp->md5sig_info->entries6 == 0) {
                                 kfree(tp->md5sig_info->keys6);
                                 tp->md5sig_info->keys6 = NULL;
+                                tp->md5sig_info->alloced6 = 0;
 
                                 tcp_free_md5sig_pool();
 
diff --git a/net/iucv/iucv.c b/net/iucv/iucv.c
index ad5150b8dfa..983058d432d 100644
--- a/net/iucv/iucv.c
+++ b/net/iucv/iucv.c
@@ -479,7 +479,8 @@ static void iucv_setmask_mp(void)
                 /* Enable all cpus with a declared buffer. */
                 if (cpu_isset(cpu, iucv_buffer_cpumask) &&
                     !cpu_isset(cpu, iucv_irq_cpumask))
-                        smp_call_function_on(iucv_allow_cpu, NULL, 0, 1, cpu);
+                        smp_call_function_single(cpu, iucv_allow_cpu,
+                                                 NULL, 0, 1);
         preempt_enable();
 }
 
@@ -497,7 +498,7 @@ static void iucv_setmask_up(void)
         cpumask = iucv_irq_cpumask;
         cpu_clear(first_cpu(iucv_irq_cpumask), cpumask);
         for_each_cpu_mask(cpu, cpumask)
-                smp_call_function_on(iucv_block_cpu, NULL, 0, 1, cpu);
+                smp_call_function_single(cpu, iucv_block_cpu, NULL, 0, 1);
 }
 
 /**
@@ -522,7 +523,7 @@ static int iucv_enable(void)
         rc = -EIO;
         preempt_disable();
         for_each_online_cpu(cpu)
-                smp_call_function_on(iucv_declare_cpu, NULL, 0, 1, cpu);
+                smp_call_function_single(cpu, iucv_declare_cpu, NULL, 0, 1);
         preempt_enable();
         if (cpus_empty(iucv_buffer_cpumask))
                 /* No cpu could declare an iucv buffer. */
@@ -578,7 +579,7 @@ static int __cpuinit iucv_cpu_notify(struct notifier_block *self,
         case CPU_ONLINE_FROZEN:
         case CPU_DOWN_FAILED:
         case CPU_DOWN_FAILED_FROZEN:
-                smp_call_function_on(iucv_declare_cpu, NULL, 0, 1, cpu);
+                smp_call_function_single(cpu, iucv_declare_cpu, NULL, 0, 1);
                 break;
         case CPU_DOWN_PREPARE:
         case CPU_DOWN_PREPARE_FROZEN:
@@ -587,10 +588,10 @@ static int __cpuinit iucv_cpu_notify(struct notifier_block *self,
                 if (cpus_empty(cpumask))
                         /* Can't offline last IUCV enabled cpu. */
                         return NOTIFY_BAD;
-                smp_call_function_on(iucv_retrieve_cpu, NULL, 0, 1, cpu);
+                smp_call_function_single(cpu, iucv_retrieve_cpu, NULL, 0, 1);
                 if (cpus_empty(iucv_irq_cpumask))
-                        smp_call_function_on(iucv_allow_cpu, NULL, 0, 1,
-                                             first_cpu(iucv_buffer_cpumask));
+                        smp_call_function_single(first_cpu(iucv_buffer_cpumask),
+                                                 iucv_allow_cpu, NULL, 0, 1);
                 break;
         }
         return NOTIFY_OK;
diff --git a/net/key/af_key.c b/net/key/af_key.c
index 0f8304b0246..7b0a95abe93 100644
--- a/net/key/af_key.c
+++ b/net/key/af_key.c
@@ -2540,7 +2540,7 @@ static int pfkey_migrate(struct sock *sk, struct sk_buff *skb,
         sel.proto = pfkey_proto_to_xfrm(sa->sadb_address_proto);
         sel.sport = ((struct sockaddr_in *)(sa + 1))->sin_port;
         if (sel.sport)
-                sel.sport_mask = ~0;
+                sel.sport_mask = htons(0xffff);
 
         /* set destination address info of selector */
         sa = ext_hdrs[SADB_EXT_ADDRESS_DST - 1],
@@ -2549,7 +2549,7 @@ static int pfkey_migrate(struct sock *sk, struct sk_buff *skb,
         sel.proto = pfkey_proto_to_xfrm(sa->sadb_address_proto);
         sel.dport = ((struct sockaddr_in *)(sa + 1))->sin_port;
         if (sel.dport)
-                sel.dport_mask = ~0;
+                sel.dport_mask = htons(0xffff);
 
         rq = (struct sadb_x_ipsecrequest *)(pol + 1);
 
diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c
index aa086c83af8..0fe11889ce1 100644
--- a/net/netfilter/nf_conntrack_core.c
+++ b/net/netfilter/nf_conntrack_core.c
@@ -79,7 +79,8 @@ static u_int32_t __hash_conntrack(const struct nf_conntrack_tuple *tuple,
         a = jhash2(tuple->src.u3.all, ARRAY_SIZE(tuple->src.u3.all),
                    (tuple->src.l3num << 16) | tuple->dst.protonum);
         b = jhash2(tuple->dst.u3.all, ARRAY_SIZE(tuple->dst.u3.all),
-                   (tuple->src.u.all << 16) | tuple->dst.u.all);
+                   ((__force __u16)tuple->src.u.all << 16) |
+                    (__force __u16)tuple->dst.u.all);
 
         return jhash_2words(a, b, rnd) % size;
 }
diff --git a/net/netfilter/nf_conntrack_expect.c b/net/netfilter/nf_conntrack_expect.c
index 1aa6229ca99..eb6695dcd73 100644
--- a/net/netfilter/nf_conntrack_expect.c
+++ b/net/netfilter/nf_conntrack_expect.c
@@ -80,7 +80,7 @@ static unsigned int nf_ct_expect_dst_hash(const struct nf_conntrack_tuple *tuple
 
         return jhash2(tuple->dst.u3.all, ARRAY_SIZE(tuple->dst.u3.all),
                       (((tuple->dst.protonum ^ tuple->src.l3num) << 16) |
-                       tuple->dst.u.all) ^ nf_ct_expect_hash_rnd) %
+                       (__force __u16)tuple->dst.u.all) ^ nf_ct_expect_hash_rnd) %
                nf_ct_expect_hsize;
 }
 
@@ -259,8 +259,8 @@ void nf_ct_expect_init(struct nf_conntrack_expect *exp, int family,
         }
 
         if (src) {
-                exp->tuple.src.u.all = (__force u16)*src;
-                exp->mask.src.u.all = 0xFFFF;
+                exp->tuple.src.u.all = *src;
+                exp->mask.src.u.all = htons(0xFFFF);
         } else {
                 exp->tuple.src.u.all = 0;
                 exp->mask.src.u.all = 0;
@@ -272,7 +272,7 @@ void nf_ct_expect_init(struct nf_conntrack_expect *exp, int family,
                 memset((void *)&exp->tuple.dst.u3 + len, 0x00,
                        sizeof(exp->tuple.dst.u3) - len);
 
-        exp->tuple.dst.u.all = (__force u16)*dst;
+        exp->tuple.dst.u.all = *dst;
 }
 EXPORT_SYMBOL_GPL(nf_ct_expect_init);
 
diff --git a/net/netfilter/nf_conntrack_helper.c b/net/netfilter/nf_conntrack_helper.c
index ca10df40784..96aa637c093 100644
--- a/net/netfilter/nf_conntrack_helper.c
+++ b/net/netfilter/nf_conntrack_helper.c
@@ -39,7 +39,7 @@ static int nf_ct_helper_vmalloc;
 static unsigned int helper_hash(const struct nf_conntrack_tuple *tuple)
 {
         return (((tuple->src.l3num << 8) | tuple->dst.protonum) ^
-                tuple->src.u.all) % nf_ct_helper_hsize;
+                (__force __u16)tuple->src.u.all) % nf_ct_helper_hsize;
 }
 
 struct nf_conntrack_helper *
diff --git a/net/netfilter/nf_conntrack_proto_tcp.c b/net/netfilter/nf_conntrack_proto_tcp.c
index 87ad3ccf8af..eb3fe740146 100644
--- a/net/netfilter/nf_conntrack_proto_tcp.c
+++ b/net/netfilter/nf_conntrack_proto_tcp.c
@@ -8,7 +8,6 @@
 
 #include <linux/types.h>
 #include <linux/timer.h>
-#include <linux/netfilter.h>
 #include <linux/module.h>
 #include <linux/in.h>
 #include <linux/tcp.h>
diff --git a/net/netfilter/nf_conntrack_proto_udp.c b/net/netfilter/nf_conntrack_proto_udp.c
index 13d94a02572..2a2fd1a764e 100644
--- a/net/netfilter/nf_conntrack_proto_udp.c
+++ b/net/netfilter/nf_conntrack_proto_udp.c
@@ -9,7 +9,6 @@
 #include <linux/types.h>
 #include <linux/timer.h>
 #include <linux/module.h>
-#include <linux/netfilter.h>
 #include <linux/udp.h>
 #include <linux/seq_file.h>
 #include <linux/skbuff.h>
diff --git a/net/netfilter/nf_conntrack_proto_udplite.c b/net/netfilter/nf_conntrack_proto_udplite.c
index 93e747b5396..b906b413997 100644
--- a/net/netfilter/nf_conntrack_proto_udplite.c
+++ b/net/netfilter/nf_conntrack_proto_udplite.c
@@ -10,7 +10,6 @@
 #include <linux/types.h>
 #include <linux/timer.h>
 #include <linux/module.h>
-#include <linux/netfilter.h>
 #include <linux/udp.h>
 #include <linux/seq_file.h>
 #include <linux/skbuff.h>
diff --git a/net/netfilter/xt_connlimit.c b/net/netfilter/xt_connlimit.c
index 3335dd5be96..06cff1d1369 100644
--- a/net/netfilter/xt_connlimit.c
+++ b/net/netfilter/xt_connlimit.c
@@ -42,13 +42,13 @@ struct xt_connlimit_data {
 static u_int32_t connlimit_rnd;
 static bool connlimit_rnd_inited;
 
-static inline unsigned int connlimit_iphash(u_int32_t addr)
+static inline unsigned int connlimit_iphash(__be32 addr)
 {
         if (unlikely(!connlimit_rnd_inited)) {
                 get_random_bytes(&connlimit_rnd, sizeof(connlimit_rnd));
                 connlimit_rnd_inited = true;
         }
-        return jhash_1word(addr, connlimit_rnd) & 0xFF;
+        return jhash_1word((__force __u32)addr, connlimit_rnd) & 0xFF;
 }
 
 static inline unsigned int
@@ -66,7 +66,7 @@ connlimit_iphash6(const union nf_conntrack_address *addr,
         for (i = 0; i < ARRAY_SIZE(addr->ip6); ++i)
                 res.ip6[i] = addr->ip6[i] & mask->ip6[i];
 
-        return jhash2(res.ip6, ARRAY_SIZE(res.ip6), connlimit_rnd) & 0xFF;
+        return jhash2((u32 *)res.ip6, ARRAY_SIZE(res.ip6), connlimit_rnd) & 0xFF;
 }
 
 static inline bool already_closed(const struct nf_conn *conn)
diff --git a/net/netfilter/xt_physdev.c b/net/netfilter/xt_physdev.c
index f47cab7a696..a4bab043a6d 100644
--- a/net/netfilter/xt_physdev.c
+++ b/net/netfilter/xt_physdev.c
@@ -13,7 +13,6 @@
 #include <linux/netfilter_bridge.h>
 #include <linux/netfilter/xt_physdev.h>
 #include <linux/netfilter/x_tables.h>
-#include <linux/netfilter_bridge.h>
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Bart De Schuymer <bdschuym@pandora.be>");
diff --git a/net/netfilter/xt_u32.c b/net/netfilter/xt_u32.c
index 04b677ae8da..74f9b14c012 100644
--- a/net/netfilter/xt_u32.c
+++ b/net/netfilter/xt_u32.c
@@ -21,6 +21,7 @@ static bool u32_match_it(const struct xt_u32 *data,
         unsigned int nnums;
         unsigned int nvals;
         unsigned int i;
+        __be32 n;
         u_int32_t pos;
         u_int32_t val;
         u_int32_t at;
@@ -38,9 +39,9 @@ static bool u32_match_it(const struct xt_u32 *data,
                 if (skb->len < 4 || pos > skb->len - 4);
                         return false;
 
-                ret   = skb_copy_bits(skb, pos, &val, sizeof(val));
+                ret   = skb_copy_bits(skb, pos, &n, sizeof(n));
                 BUG_ON(ret < 0);
-                val   = ntohl(val);
+                val   = ntohl(n);
                 nnums = ct->nnums;
 
                 /* Inner loop runs over "&", "<<", ">>" and "@" operands */
@@ -65,10 +66,10 @@ static bool u32_match_it(const struct xt_u32 *data,
                                     pos > skb->len - at - 4)
                                         return false;
 
-                                ret = skb_copy_bits(skb, at + pos, &val,
-                                                    sizeof(val));
+                                ret = skb_copy_bits(skb, at + pos, &n,
+                                                    sizeof(n));
                                 BUG_ON(ret < 0);
-                                val = ntohl(val);
+                                val = ntohl(n);
                                 break;
                         }
                 }
diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c
index e146531faf1..8c11ca4a212 100644
--- a/net/netlink/genetlink.c
+++ b/net/netlink/genetlink.c
@@ -184,7 +184,7 @@ int genl_register_mc_group(struct genl_family *family,
         }
 
         err = netlink_change_ngroups(genl_sock,
-                                     sizeof(unsigned long) * NETLINK_GENERIC);
+                                     mc_groups_longs * BITS_PER_LONG);
         if (err)
                 goto out;
 
@@ -196,10 +196,22 @@ int genl_register_mc_group(struct genl_family *family,
         genl_ctrl_event(CTRL_CMD_NEWMCAST_GRP, grp);
  out:
         genl_unlock();
-        return 0;
+        return err;
 }
 EXPORT_SYMBOL(genl_register_mc_group);
 
+static void __genl_unregister_mc_group(struct genl_family *family,
+                                       struct genl_multicast_group *grp)
+{
+        BUG_ON(grp->family != family);
+        netlink_clear_multicast_users(genl_sock, grp->id);
+        clear_bit(grp->id, mc_groups);
+        list_del(&grp->list);
+        genl_ctrl_event(CTRL_CMD_DELMCAST_GRP, grp);
+        grp->id = 0;
+        grp->family = NULL;
+}
+
 /**
  * genl_unregister_mc_group - unregister a multicast group
  *
@@ -217,14 +229,8 @@ EXPORT_SYMBOL(genl_register_mc_group);
 void genl_unregister_mc_group(struct genl_family *family,
                               struct genl_multicast_group *grp)
 {
-        BUG_ON(grp->family != family);
         genl_lock();
-        netlink_clear_multicast_users(genl_sock, grp->id);
-        clear_bit(grp->id, mc_groups);
-        list_del(&grp->list);
-        genl_ctrl_event(CTRL_CMD_DELMCAST_GRP, grp);
-        grp->id = 0;
-        grp->family = NULL;
+        __genl_unregister_mc_group(family, grp);
         genl_unlock();
 }
 
@@ -232,8 +238,10 @@ static void genl_unregister_mc_groups(struct genl_family *family)
 {
         struct genl_multicast_group *grp, *tmp;
 
+        genl_lock();
         list_for_each_entry_safe(grp, tmp, &family->mcast_groups, list)
-                genl_unregister_mc_group(family, grp);
+                __genl_unregister_mc_group(family, grp);
+        genl_unlock();
 }
 
 /**
diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c
index 16a68df4e36..c58fa0d1be2 100644
--- a/net/rxrpc/af_rxrpc.c
+++ b/net/rxrpc/af_rxrpc.c
@@ -787,7 +787,7 @@ static int __init af_rxrpc_init(void)
 
         BUILD_BUG_ON(sizeof(struct rxrpc_skb_priv) > sizeof(dummy_skb->cb));
 
-        rxrpc_epoch = htonl(xtime.tv_sec);
+        rxrpc_epoch = htonl(get_seconds());
 
         ret = -ENOMEM;
         rxrpc_call_jar = kmem_cache_create(
diff --git a/net/rxrpc/ar-connection.c b/net/rxrpc/ar-connection.c
index 482750efc23..d6667f7bc85 100644
--- a/net/rxrpc/ar-connection.c
+++ b/net/rxrpc/ar-connection.c
@@ -71,7 +71,7 @@ struct rxrpc_conn_bundle *rxrpc_get_bundle(struct rxrpc_sock *rx,
         struct rb_node *p, *parent, **pp;
 
         _enter("%p{%x},%x,%hx,",
-               rx, key_serial(key), trans->debug_id, ntohl(service_id));
+               rx, key_serial(key), trans->debug_id, ntohs(service_id));
 
         if (rx->trans == trans && rx->bundle) {
                 atomic_inc(&rx->bundle->usage);
@@ -791,7 +791,7 @@ void rxrpc_put_connection(struct rxrpc_connection *conn)
 
         ASSERTCMP(atomic_read(&conn->usage), >, 0);
 
-        conn->put_time = xtime.tv_sec;
+        conn->put_time = get_seconds();
         if (atomic_dec_and_test(&conn->usage)) {
                 _debug("zombie");
                 rxrpc_queue_delayed_work(&rxrpc_connection_reap, 0);
@@ -835,7 +835,7 @@ void rxrpc_connection_reaper(struct work_struct *work)
 
         _enter("");
 
-        now = xtime.tv_sec;
+        now = get_seconds();
         earliest = ULONG_MAX;
 
         write_lock_bh(&rxrpc_connection_lock);
diff --git a/net/rxrpc/ar-transport.c b/net/rxrpc/ar-transport.c
index d43d78f1930..bb282a6a19f 100644
--- a/net/rxrpc/ar-transport.c
+++ b/net/rxrpc/ar-transport.c
@@ -183,7 +183,7 @@ void rxrpc_put_transport(struct rxrpc_transport *trans)
 
         ASSERTCMP(atomic_read(&trans->usage), >, 0);
 
-        trans->put_time = xtime.tv_sec;
+        trans->put_time = get_seconds();
         if (unlikely(atomic_dec_and_test(&trans->usage)))
                 _debug("zombie");
                 /* let the reaper determine the timeout to avoid a race with
@@ -219,7 +219,7 @@ static void rxrpc_transport_reaper(struct work_struct *work)
 
         _enter("");
 
-        now = xtime.tv_sec;
+        now = get_seconds();
         earliest = ULONG_MAX;
 
         /* extract all the transports that have been dead too long */
diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c
index 5ec705144e1..ac3cabdca78 100644
--- a/net/rxrpc/rxkad.c
+++ b/net/rxrpc/rxkad.c
@@ -916,7 +916,7 @@ static int rxkad_decrypt_ticket(struct rxrpc_connection *conn,
                 issue = be32_to_cpu(stamp);
         }
         p += 4;
-        now = xtime.tv_sec;
+        now = get_seconds();
         _debug("KIV ISSUE: %lx [%lx]", issue, now);
 
         /* check the ticket is in date */
diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
index 490697542fc..dc2f41e9f57 100644
--- a/net/sunrpc/auth_gss/svcauth_gss.c
+++ b/net/sunrpc/auth_gss/svcauth_gss.c
@@ -769,11 +769,12 @@ svcauth_gss_register_pseudoflavor(u32 pseudoflavor, char * name)
         new->h.flavour = &svcauthops_gss;
         new->pseudoflavor = pseudoflavor;
 
+        stat = 0;
         test = auth_domain_lookup(name, &new->h);
-        if (test != &new->h) { /* XXX Duplicate registration? */
-                auth_domain_put(&new->h);
-                /* dangling ref-count... */
-                goto out;
+        if (test != &new->h) { /* Duplicate registration */
+                auth_domain_put(test);
+                kfree(new->h.name);
+                goto out_free_dom;
         }
         return 0;
 
diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
index 64b9b8c743c..12ff5da8160 100644
--- a/net/sunrpc/svcsock.c
+++ b/net/sunrpc/svcsock.c
@@ -131,13 +131,13 @@ static char *__svc_print_addr(struct sockaddr *addr, char *buf, size_t len)
         case AF_INET:
                 snprintf(buf, len, "%u.%u.%u.%u, port=%u",
                         NIPQUAD(((struct sockaddr_in *) addr)->sin_addr),
-                        htons(((struct sockaddr_in *) addr)->sin_port));
+                        ntohs(((struct sockaddr_in *) addr)->sin_port));
                 break;
 
         case AF_INET6:
                 snprintf(buf, len, "%x:%x:%x:%x:%x:%x:%x:%x, port=%u",
                         NIP6(((struct sockaddr_in6 *) addr)->sin6_addr),
-                        htons(((struct sockaddr_in6 *) addr)->sin6_port));
+                        ntohs(((struct sockaddr_in6 *) addr)->sin6_port));
                 break;
 
         default:
diff --git a/net/tipc/msg.h b/net/tipc/msg.h
index 35d5ba1d4f4..ce265983637 100644
--- a/net/tipc/msg.h
+++ b/net/tipc/msg.h
@@ -72,10 +72,8 @@ static inline void msg_set_bits(struct tipc_msg *m, u32 w,
                                 u32 pos, u32 mask, u32 val)
 {
         val = (val & mask) << pos;
-        val = htonl(val);
-        mask = htonl(mask << pos);
-        m->hdr[w] &= ~mask;
-        m->hdr[w] |= val;
+        m->hdr[w] &= ~htonl(mask << pos);
+        m->hdr[w] |= htonl(val);
 }
 
 /*