aboutsummaryrefslogtreecommitdiffstats
path: root/net/bridge/br_if.c
diff options
context:
space:
mode:
Diffstat (limited to 'net/bridge/br_if.c')
-rw-r--r--net/bridge/br_if.c15
1 files changed, 12 insertions, 3 deletions
diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
index d9d1e2bac1d..dce8f0009a1 100644
--- a/net/bridge/br_if.c
+++ b/net/bridge/br_if.c
@@ -148,6 +148,8 @@ static void del_nbp(struct net_bridge_port *p)
148 148
149 netdev_rx_handler_unregister(dev); 149 netdev_rx_handler_unregister(dev);
150 150
151 netdev_set_master(dev, NULL);
152
151 br_multicast_del_port(p); 153 br_multicast_del_port(p);
152 154
153 kobject_uevent(&p->kobj, KOBJ_REMOVE); 155 kobject_uevent(&p->kobj, KOBJ_REMOVE);
@@ -365,7 +367,7 @@ int br_min_mtu(const struct net_bridge *br)
365void br_features_recompute(struct net_bridge *br) 367void br_features_recompute(struct net_bridge *br)
366{ 368{
367 struct net_bridge_port *p; 369 struct net_bridge_port *p;
368 unsigned long features, mask; 370 u32 features, mask;
369 371
370 features = mask = br->feature_mask; 372 features = mask = br->feature_mask;
371 if (list_empty(&br->port_list)) 373 if (list_empty(&br->port_list))
@@ -379,7 +381,7 @@ void br_features_recompute(struct net_bridge *br)
379 } 381 }
380 382
381done: 383done:
382 br->dev->features = netdev_fix_features(features, NULL); 384 br->dev->features = netdev_fix_features(br->dev, features);
383} 385}
384 386
385/* called with RTNL */ 387/* called with RTNL */
@@ -429,10 +431,14 @@ int br_add_if(struct net_bridge *br, struct net_device *dev)
429 if (br_netpoll_info(br) && ((err = br_netpoll_enable(p)))) 431 if (br_netpoll_info(br) && ((err = br_netpoll_enable(p))))
430 goto err3; 432 goto err3;
431 433
432 err = netdev_rx_handler_register(dev, br_handle_frame, p); 434 err = netdev_set_master(dev, br->dev);
433 if (err) 435 if (err)
434 goto err3; 436 goto err3;
435 437
438 err = netdev_rx_handler_register(dev, br_handle_frame, p);
439 if (err)
440 goto err4;
441
436 dev->priv_flags |= IFF_BRIDGE_PORT; 442 dev->priv_flags |= IFF_BRIDGE_PORT;
437 443
438 dev_disable_lro(dev); 444 dev_disable_lro(dev);
@@ -455,6 +461,9 @@ int br_add_if(struct net_bridge *br, struct net_device *dev)
455 kobject_uevent(&p->kobj, KOBJ_ADD); 461 kobject_uevent(&p->kobj, KOBJ_ADD);
456 462
457 return 0; 463 return 0;
464
465err4:
466 netdev_set_master(dev, NULL);
458err3: 467err3:
459 sysfs_remove_link(br->ifobj, p->dev->name); 468 sysfs_remove_link(br->ifobj, p->dev->name);
460err2: 469err2: