18 files changed, 90 insertions, 101 deletions

diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index f74a62d46ee..ac44af165b2 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -283,8 +283,8 @@ static struct iscsi_np *iscsit_get_np(
                         sock_in6 = (struct sockaddr_in6 *)sockaddr;
                         sock_in6_e = (struct sockaddr_in6 *)&np->np_sockaddr;
 
-                        if (!memcmp((void *)&sock_in6->sin6_addr.in6_u,
-                                    (void *)&sock_in6_e->sin6_addr.in6_u,
+                        if (!memcmp(&sock_in6->sin6_addr.in6_u,
+                                    &sock_in6_e->sin6_addr.in6_u,
                                     sizeof(struct in6_addr)))
                                 ip_match = 1;
 
@@ -1224,7 +1224,7 @@ static void iscsit_do_crypto_hash_buf(
 
         crypto_hash_init(hash);
 
-        sg_init_one(&sg, (u8 *)buf, payload_length);
+        sg_init_one(&sg, buf, payload_length);
         crypto_hash_update(hash, &sg, payload_length);
 
         if (padding) {
@@ -1602,7 +1602,7 @@ static int iscsit_handle_nop_out(
                 /*
                  * Attach ping data to struct iscsi_cmd->buf_ptr.
                  */
-                cmd->buf_ptr = (void *)ping_data;
+                cmd->buf_ptr = ping_data;
                 cmd->buf_ptr_size = payload_length;
 
                 pr_debug("Got %u bytes of NOPOUT ping"
@@ -3196,7 +3196,7 @@ static int iscsit_build_sendtargets_response(struct iscsi_cmd *cmd)
                         end_of_buf = 1;
                         goto eob;
                 }
-                memcpy((void *)payload + payload_len, buf, len);
+                memcpy(payload + payload_len, buf, len);
                 payload_len += len;
 
                 spin_lock(&tiqn->tiqn_tpg_lock);
@@ -3228,7 +3228,7 @@ static int iscsit_build_sendtargets_response(struct iscsi_cmd *cmd)
                                         end_of_buf = 1;
                                         goto eob;
                                 }
-                                memcpy((void *)payload + payload_len, buf, len);
+                                memcpy(payload + payload_len, buf, len);
                                 payload_len += len;
                         }
                         spin_unlock(&tpg->tpg_np_lock);
@@ -3485,7 +3485,7 @@ int iscsi_target_tx_thread(void *arg)
         struct iscsi_conn *conn;
         struct iscsi_queue_req *qr = NULL;
         struct se_cmd *se_cmd;
-        struct iscsi_thread_set *ts = (struct iscsi_thread_set *)arg;
+        struct iscsi_thread_set *ts = arg;
         /*
          * Allow ourselves to be interrupted by SIGINT so that a
          * connection recovery / failure event can be triggered externally.
@@ -3774,7 +3774,7 @@ int iscsi_target_rx_thread(void *arg)
         u8 buffer[ISCSI_HDR_LEN], opcode;
         u32 checksum = 0, digest = 0;
         struct iscsi_conn *conn = NULL;
-        struct iscsi_thread_set *ts = (struct iscsi_thread_set *)arg;
+        struct iscsi_thread_set *ts = arg;
         struct kvec iov;
         /*
          * Allow ourselves to be interrupted by SIGINT so that a
diff --git a/drivers/target/iscsi/iscsi_target_auth.c b/drivers/target/iscsi/iscsi_target_auth.c
index 1cd6ce373b8..92a2526f0a2 100644
--- a/drivers/target/iscsi/iscsi_target_auth.c
+++ b/drivers/target/iscsi/iscsi_target_auth.c
@@ -82,7 +82,7 @@ static void chap_gen_challenge(
         unsigned int *c_len)
 {
         unsigned char challenge_asciihex[CHAP_CHALLENGE_LENGTH * 2 + 1];
-        struct iscsi_chap *chap = (struct iscsi_chap *) conn->auth_protocol;
+        struct iscsi_chap *chap = conn->auth_protocol;
 
         memset(challenge_asciihex, 0, CHAP_CHALLENGE_LENGTH * 2 + 1);
 
@@ -120,7 +120,7 @@ static struct iscsi_chap *chap_server_open(
         if (!conn->auth_protocol)
                 return NULL;
 
-        chap = (struct iscsi_chap *) conn->auth_protocol;
+        chap = conn->auth_protocol;
         /*
          * We only support MD5 MDA presently.
          */
@@ -172,7 +172,7 @@ static int chap_server_compute_md5(
         unsigned char client_digest[MD5_SIGNATURE_SIZE];
         unsigned char server_digest[MD5_SIGNATURE_SIZE];
         unsigned char chap_n[MAX_CHAP_N_SIZE], chap_r[MAX_RESPONSE_LENGTH];
-        struct iscsi_chap *chap = (struct iscsi_chap *) conn->auth_protocol;
+        struct iscsi_chap *chap = conn->auth_protocol;
         struct crypto_hash *tfm;
         struct hash_desc desc;
         struct scatterlist sg;
@@ -246,7 +246,7 @@ static int chap_server_compute_md5(
                 goto out;
         }
 
-        sg_init_one(&sg, (void *)&chap->id, 1);
+        sg_init_one(&sg, &chap->id, 1);
         ret = crypto_hash_update(&desc, &sg, 1);
         if (ret < 0) {
                 pr_err("crypto_hash_update() failed for id\n");
@@ -254,7 +254,7 @@ static int chap_server_compute_md5(
                 goto out;
         }
 
-        sg_init_one(&sg, (void *)&auth->password, strlen(auth->password));
+        sg_init_one(&sg, &auth->password, strlen(auth->password));
         ret = crypto_hash_update(&desc, &sg, strlen(auth->password));
         if (ret < 0) {
                 pr_err("crypto_hash_update() failed for password\n");
@@ -262,7 +262,7 @@ static int chap_server_compute_md5(
                 goto out;
         }
 
-        sg_init_one(&sg, (void *)chap->challenge, CHAP_CHALLENGE_LENGTH);
+        sg_init_one(&sg, chap->challenge, CHAP_CHALLENGE_LENGTH);
         ret = crypto_hash_update(&desc, &sg, CHAP_CHALLENGE_LENGTH);
         if (ret < 0) {
                 pr_err("crypto_hash_update() failed for challenge\n");
@@ -304,11 +304,11 @@ static int chap_server_compute_md5(
                 goto out;
         }
 
+        /* FIXME: What happens when simple_strtoul() return 256, 257, etc.? */
         if (type == HEX)
-                id = (unsigned char)simple_strtoul((char *)&identifier[2],
-                                        &endptr, 0);
+                id = simple_strtoul(&identifier[2], &endptr, 0);
         else
-                id = (unsigned char)simple_strtoul(identifier, &endptr, 0);
+                id = simple_strtoul(identifier, &endptr, 0);
         /*
          * RFC 1994 says Identifier is no more than octet (8 bits).
          */
@@ -351,7 +351,7 @@ static int chap_server_compute_md5(
                 goto out;
         }
 
-        sg_init_one(&sg, (void *)&id, 1);
+        sg_init_one(&sg, &id, 1);
         ret = crypto_hash_update(&desc, &sg, 1);
         if (ret < 0) {
                 pr_err("crypto_hash_update() failed for id\n");
@@ -359,7 +359,7 @@ static int chap_server_compute_md5(
                 goto out;
         }
 
-        sg_init_one(&sg, (void *)auth->password_mutual,
+        sg_init_one(&sg, auth->password_mutual,
                                 strlen(auth->password_mutual));
         ret = crypto_hash_update(&desc, &sg, strlen(auth->password_mutual));
         if (ret < 0) {
@@ -371,7 +371,7 @@ static int chap_server_compute_md5(
         /*
          * Convert received challenge to binary hex.
          */
-        sg_init_one(&sg, (void *)challenge_binhex, challenge_len);
+        sg_init_one(&sg, challenge_binhex, challenge_len);
         ret = crypto_hash_update(&desc, &sg, challenge_len);
         if (ret < 0) {
                 pr_err("crypto_hash_update() failed for ma challenge\n");
@@ -414,7 +414,7 @@ static int chap_got_response(
         char *nr_out_ptr,
         unsigned int *nr_out_len)
 {
-        struct iscsi_chap *chap = (struct iscsi_chap *) conn->auth_protocol;
+        struct iscsi_chap *chap = conn->auth_protocol;
 
         switch (chap->digest_type) {
         case CHAP_DIGEST_MD5:
@@ -437,7 +437,7 @@ u32 chap_main_loop(
         int *in_len,
         int *out_len)
 {
-        struct iscsi_chap *chap = (struct iscsi_chap *) conn->auth_protocol;
+        struct iscsi_chap *chap = conn->auth_protocol;
 
         if (!chap) {
                 chap = chap_server_open(conn, auth, in_text, out_text, out_len);
diff --git a/drivers/target/iscsi/iscsi_target_configfs.c b/drivers/target/iscsi/iscsi_target_configfs.c
index c04d389a2ff..3468caab47a 100644
--- a/drivers/target/iscsi/iscsi_target_configfs.c
+++ b/drivers/target/iscsi/iscsi_target_configfs.c
@@ -52,8 +52,7 @@ struct iscsi_portal_group *lio_get_tpg_from_tpg_item(
 {
         struct se_portal_group *se_tpg = container_of(to_config_group(item),
                                         struct se_portal_group, tpg_group);
-        struct iscsi_portal_group *tpg =
-                        (struct iscsi_portal_group *)se_tpg->se_tpg_fabric_ptr;
+        struct iscsi_portal_group *tpg = se_tpg->se_tpg_fabric_ptr;
         int ret;
 
         if (!tpg) {
@@ -1221,7 +1220,7 @@ struct se_portal_group *lio_target_tiqn_addtpg(
 
         ret = core_tpg_register(
                         &lio_target_fabric_configfs->tf_ops,
-                        wwn, &tpg->tpg_se_tpg, (void *)tpg,
+                        wwn, &tpg->tpg_se_tpg, tpg,
                         TRANSPORT_TPG_TYPE_NORMAL);
         if (ret < 0)
                 return NULL;
diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c
index d74e278ec8f..373b0cc6abd 100644
--- a/drivers/target/iscsi/iscsi_target_login.c
+++ b/drivers/target/iscsi/iscsi_target_login.c
@@ -143,7 +143,7 @@ int iscsi_check_for_session_reinstatement(struct iscsi_conn *conn)
         list_for_each_entry_safe(se_sess, se_sess_tmp, &se_tpg->tpg_sess_list,
                         sess_list) {
 
-                sess_p = (struct iscsi_session *)se_sess->fabric_sess_ptr;
+                sess_p = se_sess->fabric_sess_ptr;
                 spin_lock(&sess_p->conn_lock);
                 if (atomic_read(&sess_p->session_fall_back_to_erl0) ||
                     atomic_read(&sess_p->session_logout) ||
@@ -151,9 +151,9 @@ int iscsi_check_for_session_reinstatement(struct iscsi_conn *conn)
                         spin_unlock(&sess_p->conn_lock);
                         continue;
                 }
-                if (!memcmp((void *)sess_p->isid, (void *)conn->sess->isid, 6) &&
-                   (!strcmp((void *)sess_p->sess_ops->InitiatorName,
-                            (void *)initiatorname_param->value) &&
+                if (!memcmp(sess_p->isid, conn->sess->isid, 6) &&
+                   (!strcmp(sess_p->sess_ops->InitiatorName,
+                            initiatorname_param->value) &&
                    (sess_p->sess_ops->SessionType == sessiontype))) {
                         atomic_set(&sess_p->session_reinstatement, 1);
                         spin_unlock(&sess_p->conn_lock);
@@ -229,7 +229,7 @@ static int iscsi_login_zero_tsih_s1(
 
         iscsi_login_set_conn_values(sess, conn, pdu->cid);
         sess->init_task_tag     = pdu->itt;
-        memcpy((void *)&sess->isid, (void *)pdu->isid, 6);
+        memcpy(&sess->isid, pdu->isid, 6);
         sess->exp_cmd_sn        = pdu->cmdsn;
         INIT_LIST_HEAD(&sess->sess_conn_list);
         INIT_LIST_HEAD(&sess->sess_ooo_cmdsn_list);
@@ -440,8 +440,7 @@ static int iscsi_login_non_zero_tsih_s2(
                     atomic_read(&sess_p->session_logout) ||
                    (sess_p->time2retain_timer_flags & ISCSI_TF_EXPIRED))
                         continue;
-                if (!memcmp((const void *)sess_p->isid,
-                     (const void *)pdu->isid, 6) &&
+                if (!memcmp(sess_p->isid, pdu->isid, 6) &&
                      (sess_p->tsih == pdu->tsih)) {
                         iscsit_inc_session_usage_count(sess_p);
                         iscsit_stop_time2retain_timer(sess_p);
@@ -654,7 +653,7 @@ static int iscsi_post_login_handler(
 
         spin_lock_bh(&se_tpg->session_lock);
         __transport_register_session(&sess->tpg->tpg_se_tpg,
-                        se_sess->se_node_acl, se_sess, (void *)sess);
+                        se_sess->se_node_acl, se_sess, sess);
         pr_debug("Moving to TARG_SESS_STATE_LOGGED_IN.\n");
         sess->session_state = TARG_SESS_STATE_LOGGED_IN;
 
@@ -811,7 +810,7 @@ int iscsi_target_setup_login_socket(
          * Setup the np->np_sockaddr from the passed sockaddr setup
          * in iscsi_target_configfs.c code..
          */
-        memcpy((void *)&np->np_sockaddr, (void *)sockaddr,
+        memcpy(&np->np_sockaddr, sockaddr,
                         sizeof(struct __kernel_sockaddr_storage));
 
         if (sockaddr->ss_family == AF_INET6)
@@ -821,6 +820,7 @@ int iscsi_target_setup_login_socket(
         /*
          * Set SO_REUSEADDR, and disable Nagel Algorithm with TCP_NODELAY.
          */
+        /* FIXME: Someone please explain why this is endian-safe */
         opt = 1;
         if (np->np_network_transport == ISCSI_TCP) {
                 ret = kernel_setsockopt(sock, IPPROTO_TCP, TCP_NODELAY,
@@ -832,6 +832,7 @@ int iscsi_target_setup_login_socket(
                 }
         }
 
+        /* FIXME: Someone please explain why this is endian-safe */
         ret = kernel_setsockopt(sock, SOL_SOCKET, SO_REUSEADDR,
                         (char *)&opt, sizeof(opt));
         if (ret < 0) {
@@ -1206,7 +1207,7 @@ out:
 
 int iscsi_target_login_thread(void *arg)
 {
-        struct iscsi_np *np = (struct iscsi_np *)arg;
+        struct iscsi_np *np = arg;
         int ret;
 
         allow_signal(SIGINT);
diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c
index 53eea5c827f..e89fa745725 100644
--- a/drivers/target/iscsi/iscsi_target_nego.c
+++ b/drivers/target/iscsi/iscsi_target_nego.c
@@ -732,7 +732,7 @@ static void iscsi_initiatorname_tolower(
         u32 iqn_size = strlen(param_buf), i;
 
         for (i = 0; i < iqn_size; i++) {
-                c = (char *)&param_buf[i];
+                c = &param_buf[i];
                 if (!isupper(*c))
                         continue;
 
diff --git a/drivers/target/iscsi/iscsi_target_nodeattrib.c b/drivers/target/iscsi/iscsi_target_nodeattrib.c
index ac047d8a7a1..b3c699c4fe8 100644
--- a/drivers/target/iscsi/iscsi_target_nodeattrib.c
+++ b/drivers/target/iscsi/iscsi_target_nodeattrib.c
@@ -134,7 +134,7 @@ extern int iscsit_na_nopin_timeout(
                 spin_lock_bh(&se_nacl->nacl_sess_lock);
                 se_sess = se_nacl->nacl_sess;
                 if (se_sess) {
-                        sess = (struct iscsi_session *)se_sess->fabric_sess_ptr;
+                        sess = se_sess->fabric_sess_ptr;
 
                         spin_lock(&sess->conn_lock);
                         list_for_each_entry(conn, &sess->sess_conn_list,
diff --git a/drivers/target/iscsi/iscsi_target_stat.c b/drivers/target/iscsi/iscsi_target_stat.c
index 5a1aac0ec7d..421d6947dc6 100644
--- a/drivers/target/iscsi/iscsi_target_stat.c
+++ b/drivers/target/iscsi/iscsi_target_stat.c
@@ -745,7 +745,7 @@ static ssize_t iscsi_stat_sess_show_attr_node(
         spin_lock_bh(&se_nacl->nacl_sess_lock);
         se_sess = se_nacl->nacl_sess;
         if (se_sess) {
-                sess = (struct iscsi_session *)se_sess->fabric_sess_ptr;
+                sess = se_sess->fabric_sess_ptr;
                 if (sess)
                         ret = snprintf(page, PAGE_SIZE, "%u\n",
                                 sess->sess_ops->SessionType ? 0 : ISCSI_NODE_INDEX);
@@ -769,7 +769,7 @@ static ssize_t iscsi_stat_sess_show_attr_indx(
         spin_lock_bh(&se_nacl->nacl_sess_lock);
         se_sess = se_nacl->nacl_sess;
         if (se_sess) {
-                sess = (struct iscsi_session *)se_sess->fabric_sess_ptr;
+                sess = se_sess->fabric_sess_ptr;
                 if (sess)
                         ret = snprintf(page, PAGE_SIZE, "%u\n",
                                         sess->session_index);
@@ -793,7 +793,7 @@ static ssize_t iscsi_stat_sess_show_attr_cmd_pdus(
         spin_lock_bh(&se_nacl->nacl_sess_lock);
         se_sess = se_nacl->nacl_sess;
         if (se_sess) {
-                sess = (struct iscsi_session *)se_sess->fabric_sess_ptr;
+                sess = se_sess->fabric_sess_ptr;
                 if (sess)
                         ret = snprintf(page, PAGE_SIZE, "%u\n", sess->cmd_pdus);
         }
@@ -816,7 +816,7 @@ static ssize_t iscsi_stat_sess_show_attr_rsp_pdus(
         spin_lock_bh(&se_nacl->nacl_sess_lock);
         se_sess = se_nacl->nacl_sess;
         if (se_sess) {
-                sess = (struct iscsi_session *)se_sess->fabric_sess_ptr;
+                sess = se_sess->fabric_sess_ptr;
                 if (sess)
                         ret = snprintf(page, PAGE_SIZE, "%u\n", sess->rsp_pdus);
         }
@@ -839,7 +839,7 @@ static ssize_t iscsi_stat_sess_show_attr_txdata_octs(
         spin_lock_bh(&se_nacl->nacl_sess_lock);
         se_sess = se_nacl->nacl_sess;
         if (se_sess) {
-                sess = (struct iscsi_session *)se_sess->fabric_sess_ptr;
+                sess = se_sess->fabric_sess_ptr;
                 if (sess)
                         ret = snprintf(page, PAGE_SIZE, "%llu\n",
                                 (unsigned long long)sess->tx_data_octets);
@@ -863,7 +863,7 @@ static ssize_t iscsi_stat_sess_show_attr_rxdata_octs(
         spin_lock_bh(&se_nacl->nacl_sess_lock);
         se_sess = se_nacl->nacl_sess;
         if (se_sess) {
-                sess = (struct iscsi_session *)se_sess->fabric_sess_ptr;
+                sess = se_sess->fabric_sess_ptr;
                 if (sess)
                         ret = snprintf(page, PAGE_SIZE, "%llu\n",
                                 (unsigned long long)sess->rx_data_octets);
@@ -887,7 +887,7 @@ static ssize_t iscsi_stat_sess_show_attr_conn_digest_errors(
         spin_lock_bh(&se_nacl->nacl_sess_lock);
         se_sess = se_nacl->nacl_sess;
         if (se_sess) {
-                sess = (struct iscsi_session *)se_sess->fabric_sess_ptr;
+                sess = se_sess->fabric_sess_ptr;
                 if (sess)
                         ret = snprintf(page, PAGE_SIZE, "%u\n",
                                         sess->conn_digest_errors);
@@ -911,7 +911,7 @@ static ssize_t iscsi_stat_sess_show_attr_conn_timeout_errors(
         spin_lock_bh(&se_nacl->nacl_sess_lock);
         se_sess = se_nacl->nacl_sess;
         if (se_sess) {
-                sess = (struct iscsi_session *)se_sess->fabric_sess_ptr;
+                sess = se_sess->fabric_sess_ptr;
                 if (sess)
                         ret = snprintf(page, PAGE_SIZE, "%u\n",
                                         sess->conn_timeout_errors);
diff --git a/drivers/target/iscsi/iscsi_target_tpg.c b/drivers/target/iscsi/iscsi_target_tpg.c
index cfbcf6e4877..879d8d0fa3f 100644
--- a/drivers/target/iscsi/iscsi_target_tpg.c
+++ b/drivers/target/iscsi/iscsi_target_tpg.c
@@ -70,7 +70,7 @@ int iscsit_load_discovery_tpg(void)
 
         ret = core_tpg_register(
                         &lio_target_fabric_configfs->tf_ops,
-                        NULL, &tpg->tpg_se_tpg, (void *)tpg,
+                        NULL, &tpg->tpg_se_tpg, tpg,
                         TRANSPORT_TPG_TYPE_DISCOVERY);
         if (ret < 0) {
                 kfree(tpg);
diff --git a/drivers/target/iscsi/iscsi_target_util.c b/drivers/target/iscsi/iscsi_target_util.c
index c1daea19085..a05ca1c4f01 100644
--- a/drivers/target/iscsi/iscsi_target_util.c
+++ b/drivers/target/iscsi/iscsi_target_util.c
@@ -287,7 +287,7 @@ struct iscsi_cmd *iscsit_allocate_se_cmd_for_tmr(
         }
 
         se_cmd->se_tmr_req = core_tmr_alloc_req(se_cmd,
-                                (void *)cmd->tmr_req, tcm_function,
+                                cmd->tmr_req, tcm_function,
                                 GFP_KERNEL);
         if (!se_cmd->se_tmr_req)
                 goto out;
@@ -1064,7 +1064,7 @@ static void iscsit_handle_nopin_response_timeout(unsigned long data)
         if (tiqn) {
                 spin_lock_bh(&tiqn->sess_err_stats.lock);
                 strcpy(tiqn->sess_err_stats.last_sess_fail_rem_name,
-                                (void *)conn->sess->sess_ops->InitiatorName);
+                                conn->sess->sess_ops->InitiatorName);
                 tiqn->sess_err_stats.last_sess_failure_type =
                                 ISCSI_SESS_ERR_CXN_TIMEOUT;
                 tiqn->sess_err_stats.cxn_timeout_errors++;
diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c
index d427a290e18..572d27a6b7a 100644
--- a/drivers/target/loopback/tcm_loop.c
+++ b/drivers/target/loopback/tcm_loop.c
@@ -559,8 +559,7 @@ static char *tcm_loop_get_fabric_name(void)
 
 static u8 tcm_loop_get_fabric_proto_ident(struct se_portal_group *se_tpg)
 {
-        struct tcm_loop_tpg *tl_tpg =
-                        (struct tcm_loop_tpg *)se_tpg->se_tpg_fabric_ptr;
+        struct tcm_loop_tpg *tl_tpg = se_tpg->se_tpg_fabric_ptr;
         struct tcm_loop_hba *tl_hba = tl_tpg->tl_hba;
         /*
          * tl_proto_id is set at tcm_loop_configfs.c:tcm_loop_make_scsi_hba()
@@ -587,8 +586,7 @@ static u8 tcm_loop_get_fabric_proto_ident(struct se_portal_group *se_tpg)
 
 static char *tcm_loop_get_endpoint_wwn(struct se_portal_group *se_tpg)
 {
-        struct tcm_loop_tpg *tl_tpg =
-                (struct tcm_loop_tpg *)se_tpg->se_tpg_fabric_ptr;
+        struct tcm_loop_tpg *tl_tpg = se_tpg->se_tpg_fabric_ptr;
         /*
          * Return the passed NAA identifier for the SAS Target Port
          */
@@ -597,8 +595,7 @@ static char *tcm_loop_get_endpoint_wwn(struct se_portal_group *se_tpg)
 
 static u16 tcm_loop_get_tag(struct se_portal_group *se_tpg)
 {
-        struct tcm_loop_tpg *tl_tpg =
-                (struct tcm_loop_tpg *)se_tpg->se_tpg_fabric_ptr;
+        struct tcm_loop_tpg *tl_tpg = se_tpg->se_tpg_fabric_ptr;
         /*
          * This Tag is used when forming SCSI Name identifier in EVPD=1 0x83
          * to represent the SCSI Target Port.
@@ -618,8 +615,7 @@ static u32 tcm_loop_get_pr_transport_id(
         int *format_code,
         unsigned char *buf)
 {
-        struct tcm_loop_tpg *tl_tpg =
-                        (struct tcm_loop_tpg *)se_tpg->se_tpg_fabric_ptr;
+        struct tcm_loop_tpg *tl_tpg = se_tpg->se_tpg_fabric_ptr;
         struct tcm_loop_hba *tl_hba = tl_tpg->tl_hba;
 
         switch (tl_hba->tl_proto_id) {
@@ -648,8 +644,7 @@ static u32 tcm_loop_get_pr_transport_id_len(
         struct t10_pr_registration *pr_reg,
         int *format_code)
 {
-        struct tcm_loop_tpg *tl_tpg =
-                        (struct tcm_loop_tpg *)se_tpg->se_tpg_fabric_ptr;
+        struct tcm_loop_tpg *tl_tpg = se_tpg->se_tpg_fabric_ptr;
         struct tcm_loop_hba *tl_hba = tl_tpg->tl_hba;
 
         switch (tl_hba->tl_proto_id) {
@@ -682,8 +677,7 @@ static char *tcm_loop_parse_pr_out_transport_id(
         u32 *out_tid_len,
         char **port_nexus_ptr)
 {
-        struct tcm_loop_tpg *tl_tpg =
-                        (struct tcm_loop_tpg *)se_tpg->se_tpg_fabric_ptr;
+        struct tcm_loop_tpg *tl_tpg = se_tpg->se_tpg_fabric_ptr;
         struct tcm_loop_hba *tl_hba = tl_tpg->tl_hba;
 
         switch (tl_hba->tl_proto_id) {
diff --git a/drivers/target/target_core_cdb.c b/drivers/target/target_core_cdb.c
index 59219509d88..5c60d0a97a5 100644
--- a/drivers/target/target_core_cdb.c
+++ b/drivers/target/target_core_cdb.c
@@ -116,11 +116,9 @@ target_emulate_inquiry_std(struct se_cmd *cmd)
                 goto out;
         }
 
-        snprintf((unsigned char *)&buf[8], 8, "LIO-ORG");
-        snprintf((unsigned char *)&buf[16], 16, "%s",
-                 &dev->se_sub_dev->t10_wwn.model[0]);
-        snprintf((unsigned char *)&buf[32], 4, "%s",
-                 &dev->se_sub_dev->t10_wwn.revision[0]);
+        snprintf(&buf[8], 8, "LIO-ORG");
+        snprintf(&buf[16], 16, "%s", dev->se_sub_dev->t10_wwn.model);
+        snprintf(&buf[32], 4, "%s", dev->se_sub_dev->t10_wwn.revision);
         buf[4] = 31; /* Set additional length to 31 */
 
 out:
@@ -139,8 +137,7 @@ target_emulate_evpd_80(struct se_cmd *cmd, unsigned char *buf)
                         SDF_EMULATED_VPD_UNIT_SERIAL) {
                 u32 unit_serial_len;
 
-                unit_serial_len =
-                        strlen(&dev->se_sub_dev->t10_wwn.unit_serial[0]);
+                unit_serial_len = strlen(dev->se_sub_dev->t10_wwn.unit_serial);
                 unit_serial_len++; /* For NULL Terminator */
 
                 if (((len + 4) + unit_serial_len) > cmd->data_length) {
@@ -149,8 +146,8 @@ target_emulate_evpd_80(struct se_cmd *cmd, unsigned char *buf)
                         buf[3] = (len & 0xff);
                         return 0;
                 }
-                len += sprintf((unsigned char *)&buf[4], "%s",
-                        &dev->se_sub_dev->t10_wwn.unit_serial[0]);
+                len += sprintf(&buf[4], "%s",
+                        dev->se_sub_dev->t10_wwn.unit_serial);
                 len++; /* Extra Byte for NULL Terminator */
                 buf[3] = len;
         }
@@ -280,14 +277,13 @@ check_t10_vend_desc:
                         len += (prod_len + unit_serial_len);
                         goto check_port;
                 }
-                id_len += sprintf((unsigned char *)&buf[off+12],
-                                "%s:%s", prod,
+                id_len += sprintf(&buf[off+12], "%s:%s", prod,
                                 &dev->se_sub_dev->t10_wwn.unit_serial[0]);
         }
         buf[off] = 0x2; /* ASCII */
         buf[off+1] = 0x1; /* T10 Vendor ID */
         buf[off+2] = 0x0;
-        memcpy((unsigned char *)&buf[off+4], "LIO-ORG", 8);
+        memcpy(&buf[off+4], "LIO-ORG", 8);
         /* Extra Byte for NULL Terminator */
         id_len++;
         /* Identifier Length */
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index 37b2b3d03c6..eb62371611f 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -1629,7 +1629,7 @@ static struct config_item_type target_core_dev_pr_cit = {
 
 static ssize_t target_core_show_dev_info(void *p, char *page)
 {
-        struct se_subsystem_dev *se_dev = (struct se_subsystem_dev *)p;
+        struct se_subsystem_dev *se_dev = p;
         struct se_hba *hba = se_dev->se_dev_hba;
         struct se_subsystem_api *t = hba->transport;
         int bl = 0;
@@ -1657,7 +1657,7 @@ static ssize_t target_core_store_dev_control(
         const char *page,
         size_t count)
 {
-        struct se_subsystem_dev *se_dev = (struct se_subsystem_dev *)p;
+        struct se_subsystem_dev *se_dev = p;
         struct se_hba *hba = se_dev->se_dev_hba;
         struct se_subsystem_api *t = hba->transport;
 
@@ -1680,7 +1680,7 @@ static struct target_core_configfs_attribute target_core_attr_dev_control = {
 
 static ssize_t target_core_show_dev_alias(void *p, char *page)
 {
-        struct se_subsystem_dev *se_dev = (struct se_subsystem_dev *)p;
+        struct se_subsystem_dev *se_dev = p;
 
         if (!(se_dev->su_dev_flags & SDF_USING_ALIAS))
                 return 0;
@@ -1693,7 +1693,7 @@ static ssize_t target_core_store_dev_alias(
         const char *page,
         size_t count)
 {
-        struct se_subsystem_dev *se_dev = (struct se_subsystem_dev *)p;
+        struct se_subsystem_dev *se_dev = p;
         struct se_hba *hba = se_dev->se_dev_hba;
         ssize_t read_bytes;
 
@@ -1726,7 +1726,7 @@ static struct target_core_configfs_attribute target_core_attr_dev_alias = {
 
 static ssize_t target_core_show_dev_udev_path(void *p, char *page)
 {
-        struct se_subsystem_dev *se_dev = (struct se_subsystem_dev *)p;
+        struct se_subsystem_dev *se_dev = p;
 
         if (!(se_dev->su_dev_flags & SDF_USING_UDEV_PATH))
                 return 0;
@@ -1739,7 +1739,7 @@ static ssize_t target_core_store_dev_udev_path(
         const char *page,
         size_t count)
 {
-        struct se_subsystem_dev *se_dev = (struct se_subsystem_dev *)p;
+        struct se_subsystem_dev *se_dev = p;
         struct se_hba *hba = se_dev->se_dev_hba;
         ssize_t read_bytes;
 
@@ -1775,7 +1775,7 @@ static ssize_t target_core_store_dev_enable(
         const char *page,
         size_t count)
 {
-        struct se_subsystem_dev *se_dev = (struct se_subsystem_dev *)p;
+        struct se_subsystem_dev *se_dev = p;
         struct se_device *dev;
         struct se_hba *hba = se_dev->se_dev_hba;
         struct se_subsystem_api *t = hba->transport;
@@ -1820,7 +1820,7 @@ static struct target_core_configfs_attribute target_core_attr_dev_enable = {
 static ssize_t target_core_show_alua_lu_gp(void *p, char *page)
 {
         struct se_device *dev;
-        struct se_subsystem_dev *su_dev = (struct se_subsystem_dev *)p;
+        struct se_subsystem_dev *su_dev = p;
         struct config_item *lu_ci;
         struct t10_alua_lu_gp *lu_gp;
         struct t10_alua_lu_gp_member *lu_gp_mem;
@@ -1858,7 +1858,7 @@ static ssize_t target_core_store_alua_lu_gp(
         size_t count)
 {
         struct se_device *dev;
-        struct se_subsystem_dev *su_dev = (struct se_subsystem_dev *)p;
+        struct se_subsystem_dev *su_dev = p;
         struct se_hba *hba = su_dev->se_dev_hba;
         struct t10_alua_lu_gp *lu_gp = NULL, *lu_gp_new = NULL;
         struct t10_alua_lu_gp_member *lu_gp_mem;
diff --git a/drivers/target/target_core_fabric_lib.c b/drivers/target/target_core_fabric_lib.c
index 32d7feb405e..283a36e464e 100644
--- a/drivers/target/target_core_fabric_lib.c
+++ b/drivers/target/target_core_fabric_lib.c
@@ -399,7 +399,7 @@ char *iscsi_parse_pr_out_transport_id(
                 add_len = ((buf[2] >> 8) & 0xff);
                 add_len |= (buf[3] & 0xff);
 
-                tid_len = strlen((char *)&buf[4]);
+                tid_len = strlen(&buf[4]);
                 tid_len += 4; /* Add four bytes for iSCSI Transport ID header */
                 tid_len += 1; /* Add one byte for NULL terminator */
                 padding = ((-tid_len) & 3);
@@ -420,11 +420,11 @@ char *iscsi_parse_pr_out_transport_id(
          * format.
          */
         if (format_code == 0x40) {
-                p = strstr((char *)&buf[4], ",i,0x");
+                p = strstr(&buf[4], ",i,0x");
                 if (!p) {
                         pr_err("Unable to locate \",i,0x\" seperator"
                                 " for Initiator port identifier: %s\n",
-                                (char *)&buf[4]);
+                                &buf[4]);
                         return NULL;
                 }
                 *p = '\0'; /* Terminate iSCSI Name */
diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c
index 91bf11a0ab1..7ed58e2df79 100644
--- a/drivers/target/target_core_file.c
+++ b/drivers/target/target_core_file.c
@@ -85,7 +85,7 @@ static void fd_detach_hba(struct se_hba *hba)
 static void *fd_allocate_virtdevice(struct se_hba *hba, const char *name)
 {
         struct fd_dev *fd_dev;
-        struct fd_host *fd_host = (struct fd_host *) hba->hba_ptr;
+        struct fd_host *fd_host = hba->hba_ptr;
 
         fd_dev = kzalloc(sizeof(struct fd_dev), GFP_KERNEL);
         if (!fd_dev) {
@@ -113,8 +113,8 @@ static struct se_device *fd_create_virtdevice(
         struct se_device *dev;
         struct se_dev_limits dev_limits;
         struct queue_limits *limits;
-        struct fd_dev *fd_dev = (struct fd_dev *) p;
-        struct fd_host *fd_host = (struct fd_host *) hba->hba_ptr;
+        struct fd_dev *fd_dev = p;
+        struct fd_host *fd_host = hba->hba_ptr;
         mm_segment_t old_fs;
         struct file *file;
         struct inode *inode = NULL;
@@ -239,7 +239,7 @@ fail:
  */
 static void fd_free_device(void *p)
 {
-        struct fd_dev *fd_dev = (struct fd_dev *) p;
+        struct fd_dev *fd_dev = p;
 
         if (fd_dev->fd_file) {
                 filp_close(fd_dev->fd_file, NULL);
@@ -558,7 +558,7 @@ out:
 
 static ssize_t fd_check_configfs_dev_params(struct se_hba *hba, struct se_subsystem_dev *se_dev)
 {
-        struct fd_dev *fd_dev = (struct fd_dev *) se_dev->se_dev_su_ptr;
+        struct fd_dev *fd_dev = se_dev->se_dev_su_ptr;
 
         if (!(fd_dev->fbd_flags & FBDF_HAS_PATH)) {
                 pr_err("Missing fd_dev_name=\n");
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index 3c1a7aa658a..cc8e6b58ef2 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -464,7 +464,7 @@ static ssize_t iblock_show_configfs_dev_params(
         if (bd) {
                 bl += sprintf(b + bl, "Major: %d Minor: %d  %s\n",
                         MAJOR(bd->bd_dev), MINOR(bd->bd_dev), (!bd->bd_contains) ?
-                        "" : (bd->bd_holder == (struct iblock_dev *)ibd) ?
+                        "" : (bd->bd_holder == ibd) ?
                         "CLAIMED: IBLOCK" : "CLAIMED: OS");
         } else {
                 bl += sprintf(b + bl, "Major: 0 Minor: 0\n");
diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c
index bb44ed4d027..b73a399cdd5 100644
--- a/drivers/target/target_core_pscsi.c
+++ b/drivers/target/target_core_pscsi.c
@@ -104,7 +104,7 @@ static void pscsi_detach_hba(struct se_hba *hba)
 
 static int pscsi_pmode_enable_hba(struct se_hba *hba, unsigned long mode_flag)
 {
-        struct pscsi_hba_virt *phv = (struct pscsi_hba_virt *)hba->hba_ptr;
+        struct pscsi_hba_virt *phv = hba->hba_ptr;
         struct Scsi_Host *sh = phv->phv_lld_host;
         /*
          * Release the struct Scsi_Host
@@ -405,7 +405,7 @@ static struct se_device *pscsi_create_type_disk(
         __releases(sh->host_lock)
 {
         struct se_device *dev;
-        struct pscsi_hba_virt *phv = (struct pscsi_hba_virt *)pdv->pdv_se_hba->hba_ptr;
+        struct pscsi_hba_virt *phv = pdv->pdv_se_hba->hba_ptr;
         struct Scsi_Host *sh = sd->host;
         struct block_device *bd;
         u32 dev_flags = 0;
@@ -453,7 +453,7 @@ static struct se_device *pscsi_create_type_rom(
         __releases(sh->host_lock)
 {
         struct se_device *dev;
-        struct pscsi_hba_virt *phv = (struct pscsi_hba_virt *)pdv->pdv_se_hba->hba_ptr;
+        struct pscsi_hba_virt *phv = pdv->pdv_se_hba->hba_ptr;
         struct Scsi_Host *sh = sd->host;
         u32 dev_flags = 0;
 
@@ -488,7 +488,7 @@ static struct se_device *pscsi_create_type_other(
         __releases(sh->host_lock)
 {
         struct se_device *dev;
-        struct pscsi_hba_virt *phv = (struct pscsi_hba_virt *)pdv->pdv_se_hba->hba_ptr;
+        struct pscsi_hba_virt *phv = pdv->pdv_se_hba->hba_ptr;
         struct Scsi_Host *sh = sd->host;
         u32 dev_flags = 0;
 
@@ -509,10 +509,10 @@ static struct se_device *pscsi_create_virtdevice(
         struct se_subsystem_dev *se_dev,
         void *p)
 {
-        struct pscsi_dev_virt *pdv = (struct pscsi_dev_virt *)p;
+        struct pscsi_dev_virt *pdv = p;
         struct se_device *dev;
         struct scsi_device *sd;
-        struct pscsi_hba_virt *phv = (struct pscsi_hba_virt *)hba->hba_ptr;
+        struct pscsi_hba_virt *phv = hba->hba_ptr;
         struct Scsi_Host *sh = phv->phv_lld_host;
         int legacy_mode_enable = 0;
 
@@ -1143,7 +1143,7 @@ static unsigned char *pscsi_get_sense_buffer(struct se_task *task)
 {
         struct pscsi_plugin_task *pt = PSCSI_TASK(task);
 
-        return (unsigned char *)&pt->pscsi_sense[0];
+        return pt->pscsi_sense;
 }
 
 /*      pscsi_get_device_rev():
diff --git a/drivers/target/target_core_stat.c b/drivers/target/target_core_stat.c
index 6d8a90464f2..f8c2d2cc343 100644
--- a/drivers/target/target_core_stat.c
+++ b/drivers/target/target_core_stat.c
@@ -1755,8 +1755,7 @@ static ssize_t target_stat_scsi_att_intr_port_show_attr_port_ident(
         /* scsiAttIntrPortName+scsiAttIntrPortIdentifier */
         memset(buf, 0, 64);
         if (tpg->se_tpg_tfo->sess_get_initiator_sid != NULL)
-                tpg->se_tpg_tfo->sess_get_initiator_sid(se_sess,
-                                (unsigned char *)&buf[0], 64);
+                tpg->se_tpg_tfo->sess_get_initiator_sid(se_sess, buf, 64);
 
         ret = snprintf(page, PAGE_SIZE, "%s+i+%s\n", nacl->initiatorname, buf);
         spin_unlock_irq(&nacl->nacl_sess_lock);
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index 511836eb295..122925686de 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -4161,7 +4161,7 @@ check_cond:
 
 static int transport_clear_lun_thread(void *p)
 {
-        struct se_lun *lun = (struct se_lun *)p;
+        struct se_lun *lun = p;
 
         __transport_clear_lun_from_sessions(lun);
         complete(&lun->lun_shutdown_comp);
@@ -4580,7 +4580,7 @@ static int transport_processing_thread(void *param)
 {
         int ret;
         struct se_cmd *cmd;
-        struct se_device *dev = (struct se_device *) param;
+        struct se_device *dev = param;
 
         while (!kthread_should_stop()) {
                 ret = wait_event_interruptible(dev->dev_queue_obj.thread_wq,