1 files changed, 54 insertions, 19 deletions

diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index fd930618c28..23e04fb038b 100644
--- a/drivers/usb/host/pci-quirks.c
+++ b/drivers/usb/host/pci-quirks.c
@@ -35,6 +35,9 @@
 #define OHCI_INTRSTATUS         0x0c
 #define OHCI_INTRENABLE         0x10
 #define OHCI_INTRDISABLE        0x14
+#define OHCI_FMINTERVAL         0x34
+#define OHCI_HCFS               (3 << 6)        /* hc functional state */
+#define OHCI_HCR                (1 << 0)        /* host controller reset */
 #define OHCI_OCR                (1 << 3)        /* ownership change request */
 #define OHCI_CTRL_RWC           (1 << 9)        /* remote wakeup connected */
 #define OHCI_CTRL_IR            (1 << 8)        /* interrupt routing */
@@ -463,6 +466,8 @@ static void __devinit quirk_usb_handoff_ohci(struct pci_dev *pdev)
 {
         void __iomem *base;
         u32 control;
+        u32 fminterval;
+        int cnt;
 
         if (!mmio_resource_enabled(pdev, 0))
                 return;
@@ -495,32 +500,63 @@ static void __devinit quirk_usb_handoff_ohci(struct pci_dev *pdev)
         }
 #endif
 
-        /* reset controller, preserving RWC (and possibly IR) */
-        writel(control & OHCI_CTRL_MASK, base + OHCI_CONTROL);
+        /* disable interrupts */
+        writel((u32) ~0, base + OHCI_INTRDISABLE);
 
-        /*
-         * disable interrupts
-         */
-        writel(~(u32)0, base + OHCI_INTRDISABLE);
-        writel(~(u32)0, base + OHCI_INTRSTATUS);
+        /* Reset the USB bus, if the controller isn't already in RESET */
+        if (control & OHCI_HCFS) {
+                /* Go into RESET, preserving RWC (and possibly IR) */
+                writel(control & OHCI_CTRL_MASK, base + OHCI_CONTROL);
+                readl(base + OHCI_CONTROL);
+
+                /* drive bus reset for at least 50 ms (7.1.7.5) */
+                msleep(50);
+        }
+
+        /* software reset of the controller, preserving HcFmInterval */
+        fminterval = readl(base + OHCI_FMINTERVAL);
+        writel(OHCI_HCR, base + OHCI_CMDSTATUS);
 
+        /* reset requires max 10 us delay */
+        for (cnt = 30; cnt > 0; --cnt) {        /* ... allow extra time */
+                if ((readl(base + OHCI_CMDSTATUS) & OHCI_HCR) == 0)
+                        break;
+                udelay(1);
+        }
+        writel(fminterval, base + OHCI_FMINTERVAL);
+
+        /* Now the controller is safely in SUSPEND and nothing can wake it up */
         iounmap(base);
 }
 
+static const struct dmi_system_id __devinitconst ehci_dmi_nohandoff_table[] = {
+        {
+                /*  Pegatron Lucid (ExoPC) */
+                .matches = {
+                        DMI_MATCH(DMI_BOARD_NAME, "EXOPG06411"),
+                        DMI_MATCH(DMI_BIOS_VERSION, "Lucid-CE-133"),
+                },
+        },
+        {
+                /*  Pegatron Lucid (Ordissimo AIRIS) */
+                .matches = {
+                        DMI_MATCH(DMI_BOARD_NAME, "M11JB"),
+                        DMI_MATCH(DMI_BIOS_VERSION, "Lucid-GE-133"),
+                },
+        },
+        { }
+};
+
 static void __devinit ehci_bios_handoff(struct pci_dev *pdev,
                                         void __iomem *op_reg_base,
                                         u32 cap, u8 offset)
 {
         int try_handoff = 1, tried_handoff = 0;
 
-        /* The Pegatron Lucid (ExoPC) tablet sporadically waits for 90
-         * seconds trying the handoff on its unused controller.  Skip
-         * it. */
+        /* The Pegatron Lucid tablet sporadically waits for 98 seconds trying
+         * the handoff on its unused controller.  Skip it. */
         if (pdev->vendor == 0x8086 && pdev->device == 0x283a) {
-                const char *dmi_bn = dmi_get_system_info(DMI_BOARD_NAME);
-                const char *dmi_bv = dmi_get_system_info(DMI_BIOS_VERSION);
-                if (dmi_bn && !strcmp(dmi_bn, "EXOPG06411") &&
-                    dmi_bv && !strcmp(dmi_bv, "Lucid-CE-133"))
+                if (dmi_check_system(ehci_dmi_nohandoff_table))
                         try_handoff = 0;
         }
 
@@ -584,7 +620,7 @@ static void __devinit quirk_usb_disable_ehci(struct pci_dev *pdev)
         void __iomem *base, *op_reg_base;
         u32     hcc_params, cap, val;
         u8      offset, cap_length;
-        int     wait_time, delta, count = 256/4;
+        int     wait_time, count = 256/4;
 
         if (!mmio_resource_enabled(pdev, 0))
                 return;
@@ -630,11 +666,10 @@ static void __devinit quirk_usb_disable_ehci(struct pci_dev *pdev)
                 writel(val, op_reg_base + EHCI_USBCMD);
 
                 wait_time = 2000;
-                delta = 100;
                 do {
                         writel(0x3f, op_reg_base + EHCI_USBSTS);
-                        udelay(delta);
-                        wait_time -= delta;
+                        udelay(100);
+                        wait_time -= 100;
                         val = readl(op_reg_base + EHCI_USBSTS);
                         if ((val == ~(u32)0) || (val & EHCI_USBSTS_HALTED)) {
                                 break;
@@ -775,7 +810,7 @@ static void __devinit quirk_usb_handoff_xhci(struct pci_dev *pdev)
 
         /* If the BIOS owns the HC, signal that the OS wants it, and wait */
         if (val & XHCI_HC_BIOS_OWNED) {
-                writel(val & XHCI_HC_OS_OWNED, base + ext_cap_offset);
+                writel(val | XHCI_HC_OS_OWNED, base + ext_cap_offset);
 
                 /* Wait for 5 seconds with 10 microsecond polling interval */
                 timeout = handshake(base + ext_cap_offset, XHCI_HC_BIOS_OWNED,