3 files changed, 80 insertions, 36 deletions

diff --git a/drivers/pnp/pnpacpi/rsparser.c b/drivers/pnp/pnpacpi/rsparser.c
index 100e4d9372f..bbf3edd85be 100644
--- a/drivers/pnp/pnpacpi/rsparser.c
+++ b/drivers/pnp/pnpacpi/rsparser.c
@@ -509,15 +509,15 @@ static __init void pnpacpi_parse_dma_option(struct pnp_dev *dev,
                                             struct acpi_resource_dma *p)
 {
         int i;
-        unsigned char map = 0, flags;
+        unsigned char map = 0, flags = 0;
 
         if (p->channel_count == 0)
-                return;
+                flags |= IORESOURCE_DISABLED;
 
         for (i = 0; i < p->channel_count; i++)
                 map |= 1 << p->channels[i];
 
-        flags = dma_flags(dev, p->type, p->bus_master, p->transfer);
+        flags |= dma_flags(dev, p->type, p->bus_master, p->transfer);
         pnp_register_dma_resource(dev, option_flags, map, flags);
 }
 
@@ -527,17 +527,17 @@ static __init void pnpacpi_parse_irq_option(struct pnp_dev *dev,
 {
         int i;
         pnp_irq_mask_t map;
-        unsigned char flags;
+        unsigned char flags = 0;
 
         if (p->interrupt_count == 0)
-                return;
+                flags |= IORESOURCE_DISABLED;
 
         bitmap_zero(map.bits, PNP_IRQ_NR);
         for (i = 0; i < p->interrupt_count; i++)
                 if (p->interrupts[i])
                         __set_bit(p->interrupts[i], map.bits);
 
-        flags = irq_flags(p->triggering, p->polarity, p->sharable);
+        flags |= irq_flags(p->triggering, p->polarity, p->sharable);
         pnp_register_irq_resource(dev, option_flags, &map, flags);
 }
 
@@ -547,10 +547,10 @@ static __init void pnpacpi_parse_ext_irq_option(struct pnp_dev *dev,
 {
         int i;
         pnp_irq_mask_t map;
-        unsigned char flags;
+        unsigned char flags = 0;
 
         if (p->interrupt_count == 0)
-                return;
+                flags |= IORESOURCE_DISABLED;
 
         bitmap_zero(map.bits, PNP_IRQ_NR);
         for (i = 0; i < p->interrupt_count; i++) {
@@ -564,7 +564,7 @@ static __init void pnpacpi_parse_ext_irq_option(struct pnp_dev *dev,
                 }
         }
 
-        flags = irq_flags(p->triggering, p->polarity, p->sharable);
+        flags |= irq_flags(p->triggering, p->polarity, p->sharable);
         pnp_register_irq_resource(dev, option_flags, &map, flags);
 }
 
@@ -575,10 +575,10 @@ static __init void pnpacpi_parse_port_option(struct pnp_dev *dev,
         unsigned char flags = 0;
 
         if (io->address_length == 0)
-                return;
+                flags |= IORESOURCE_DISABLED;
 
         if (io->io_decode == ACPI_DECODE_16)
-                flags = IORESOURCE_IO_16BIT_ADDR;
+                flags |= IORESOURCE_IO_16BIT_ADDR;
         pnp_register_port_resource(dev, option_flags, io->minimum, io->maximum,
                                    io->alignment, io->address_length, flags);
 }
@@ -587,11 +587,13 @@ static __init void pnpacpi_parse_fixed_port_option(struct pnp_dev *dev,
                                         unsigned int option_flags,
                                         struct acpi_resource_fixed_io *io)
 {
+        unsigned char flags = 0;
+
         if (io->address_length == 0)
-                return;
+                flags |= IORESOURCE_DISABLED;
 
         pnp_register_port_resource(dev, option_flags, io->address, io->address,
-                                   0, io->address_length, IORESOURCE_IO_FIXED);
+                                   0, io->address_length, flags | IORESOURCE_IO_FIXED);
 }
 
 static __init void pnpacpi_parse_mem24_option(struct pnp_dev *dev,
@@ -601,10 +603,10 @@ static __init void pnpacpi_parse_mem24_option(struct pnp_dev *dev,
         unsigned char flags = 0;
 
         if (p->address_length == 0)
-                return;
+                flags |= IORESOURCE_DISABLED;
 
         if (p->write_protect == ACPI_READ_WRITE_MEMORY)
-                flags = IORESOURCE_MEM_WRITEABLE;
+                flags |= IORESOURCE_MEM_WRITEABLE;
         pnp_register_mem_resource(dev, option_flags, p->minimum, p->maximum,
                                   p->alignment, p->address_length, flags);
 }
@@ -616,10 +618,10 @@ static __init void pnpacpi_parse_mem32_option(struct pnp_dev *dev,
         unsigned char flags = 0;
 
         if (p->address_length == 0)
-                return;
+                flags |= IORESOURCE_DISABLED;
 
         if (p->write_protect == ACPI_READ_WRITE_MEMORY)
-                flags = IORESOURCE_MEM_WRITEABLE;
+                flags |= IORESOURCE_MEM_WRITEABLE;
         pnp_register_mem_resource(dev, option_flags, p->minimum, p->maximum,
                                   p->alignment, p->address_length, flags);
 }
@@ -631,10 +633,10 @@ static __init void pnpacpi_parse_fixed_mem32_option(struct pnp_dev *dev,
         unsigned char flags = 0;
 
         if (p->address_length == 0)
-                return;
+                flags |= IORESOURCE_DISABLED;
 
         if (p->write_protect == ACPI_READ_WRITE_MEMORY)
-                flags = IORESOURCE_MEM_WRITEABLE;
+                flags |= IORESOURCE_MEM_WRITEABLE;
         pnp_register_mem_resource(dev, option_flags, p->address, p->address,
                                   0, p->address_length, flags);
 }
@@ -655,18 +657,18 @@ static __init void pnpacpi_parse_address_option(struct pnp_dev *dev,
         }
 
         if (p->address_length == 0)
-                return;
+                flags |= IORESOURCE_DISABLED;
 
         if (p->resource_type == ACPI_MEMORY_RANGE) {
                 if (p->info.mem.write_protect == ACPI_READ_WRITE_MEMORY)
-                        flags = IORESOURCE_MEM_WRITEABLE;
+                        flags |= IORESOURCE_MEM_WRITEABLE;
                 pnp_register_mem_resource(dev, option_flags, p->minimum,
                                           p->minimum, 0, p->address_length,
                                           flags);
         } else if (p->resource_type == ACPI_IO_RANGE)
                 pnp_register_port_resource(dev, option_flags, p->minimum,
                                            p->minimum, 0, p->address_length,
-                                           IORESOURCE_IO_FIXED);
+                                           flags | IORESOURCE_IO_FIXED);
 }
 
 static __init void pnpacpi_parse_ext_address_option(struct pnp_dev *dev,
@@ -677,18 +679,18 @@ static __init void pnpacpi_parse_ext_address_option(struct pnp_dev *dev,
         unsigned char flags = 0;
 
         if (p->address_length == 0)
-                return;
+                flags |= IORESOURCE_DISABLED;
 
         if (p->resource_type == ACPI_MEMORY_RANGE) {
                 if (p->info.mem.write_protect == ACPI_READ_WRITE_MEMORY)
-                        flags = IORESOURCE_MEM_WRITEABLE;
+                        flags |= IORESOURCE_MEM_WRITEABLE;
                 pnp_register_mem_resource(dev, option_flags, p->minimum,
                                           p->minimum, 0, p->address_length,
                                           flags);
         } else if (p->resource_type == ACPI_IO_RANGE)
                 pnp_register_port_resource(dev, option_flags, p->minimum,
                                            p->minimum, 0, p->address_length,
-                                           IORESOURCE_IO_FIXED);
+                                           flags | IORESOURCE_IO_FIXED);
 }
 
 struct acpipnp_parse_option_s {
@@ -1018,7 +1020,7 @@ static void pnpacpi_encode_io(struct pnp_dev *dev,
                 io->minimum = p->start;
                 io->maximum = p->end;
                 io->alignment = 0;      /* Correct? */
-                io->address_length = p->end - p->start + 1;
+                io->address_length = resource_size(p);
         } else {
                 io->minimum = 0;
                 io->address_length = 0;
@@ -1036,7 +1038,7 @@ static void pnpacpi_encode_fixed_io(struct pnp_dev *dev,
 
         if (pnp_resource_enabled(p)) {
                 fixed_io->address = p->start;
-                fixed_io->address_length = p->end - p->start + 1;
+                fixed_io->address_length = resource_size(p);
         } else {
                 fixed_io->address = 0;
                 fixed_io->address_length = 0;
@@ -1059,7 +1061,7 @@ static void pnpacpi_encode_mem24(struct pnp_dev *dev,
                 memory24->minimum = p->start;
                 memory24->maximum = p->end;
                 memory24->alignment = 0;
-                memory24->address_length = p->end - p->start + 1;
+                memory24->address_length = resource_size(p);
         } else {
                 memory24->minimum = 0;
                 memory24->address_length = 0;
@@ -1083,7 +1085,7 @@ static void pnpacpi_encode_mem32(struct pnp_dev *dev,
                 memory32->minimum = p->start;
                 memory32->maximum = p->end;
                 memory32->alignment = 0;
-                memory32->address_length = p->end - p->start + 1;
+                memory32->address_length = resource_size(p);
         } else {
                 memory32->minimum = 0;
                 memory32->alignment = 0;
@@ -1106,7 +1108,7 @@ static void pnpacpi_encode_fixed_mem32(struct pnp_dev *dev,
                     p->flags & IORESOURCE_MEM_WRITEABLE ?
                     ACPI_READ_WRITE_MEMORY : ACPI_READ_ONLY_MEMORY;
                 fixed_memory32->address = p->start;
-                fixed_memory32->address_length = p->end - p->start + 1;
+                fixed_memory32->address_length = resource_size(p);
         } else {
                 fixed_memory32->address = 0;
                 fixed_memory32->address_length = 0;
diff --git a/drivers/pnp/pnpbios/rsparser.c b/drivers/pnp/pnpbios/rsparser.c
index cb1f47bfee9..cca2f9f9f3e 100644
--- a/drivers/pnp/pnpbios/rsparser.c
+++ b/drivers/pnp/pnpbios/rsparser.c
@@ -505,7 +505,7 @@ static void pnpbios_encode_mem(struct pnp_dev *dev, unsigned char *p,
 
         if (pnp_resource_enabled(res)) {
                 base = res->start;
-                len = res->end - res->start + 1;
+                len = resource_size(res);
         } else {
                 base = 0;
                 len = 0;
@@ -529,7 +529,7 @@ static void pnpbios_encode_mem32(struct pnp_dev *dev, unsigned char *p,
 
         if (pnp_resource_enabled(res)) {
                 base = res->start;
-                len = res->end - res->start + 1;
+                len = resource_size(res);
         } else {
                 base = 0;
                 len = 0;
@@ -559,7 +559,7 @@ static void pnpbios_encode_fixed_mem32(struct pnp_dev *dev, unsigned char *p,
 
         if (pnp_resource_enabled(res)) {
                 base = res->start;
-                len = res->end - res->start + 1;
+                len = resource_size(res);
         } else {
                 base = 0;
                 len = 0;
@@ -617,7 +617,7 @@ static void pnpbios_encode_port(struct pnp_dev *dev, unsigned char *p,
 
         if (pnp_resource_enabled(res)) {
                 base = res->start;
-                len = res->end - res->start + 1;
+                len = resource_size(res);
         } else {
                 base = 0;
                 len = 0;
@@ -636,11 +636,11 @@ static void pnpbios_encode_fixed_port(struct pnp_dev *dev, unsigned char *p,
                                       struct resource *res)
 {
         unsigned long base = res->start;
-        unsigned long len = res->end - res->start + 1;
+        unsigned long len = resource_size(res);
 
         if (pnp_resource_enabled(res)) {
                 base = res->start;
-                len = res->end - res->start + 1;
+                len = resource_size(res);
         } else {
                 base = 0;
                 len = 0;
diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c
index dfbd5a6cc58..258fef272ea 100644
--- a/drivers/pnp/quirks.c
+++ b/drivers/pnp/quirks.c
@@ -295,6 +295,45 @@ static void quirk_system_pci_resources(struct pnp_dev *dev)
         }
 }
 
+#ifdef CONFIG_AMD_NB
+
+#include <asm/amd_nb.h>
+
+static void quirk_amd_mmconfig_area(struct pnp_dev *dev)
+{
+        resource_size_t start, end;
+        struct pnp_resource *pnp_res;
+        struct resource *res;
+        struct resource mmconfig_res, *mmconfig;
+
+        mmconfig = amd_get_mmconfig_range(&mmconfig_res);
+        if (!mmconfig)
+                return;
+
+        list_for_each_entry(pnp_res, &dev->resources, list) {
+                res = &pnp_res->res;
+                if (res->end < mmconfig->start || res->start > mmconfig->end ||
+                    (res->start == mmconfig->start && res->end == mmconfig->end))
+                        continue;
+
+                dev_info(&dev->dev, FW_BUG
+                         "%pR covers only part of AMD MMCONFIG area %pR; adding more reservations\n",
+                         res, mmconfig);
+                if (mmconfig->start < res->start) {
+                        start = mmconfig->start;
+                        end = res->start - 1;
+                        pnp_add_mem_resource(dev, start, end, 0);
+                }
+                if (mmconfig->end > res->end) {
+                        start = res->end + 1;
+                        end = mmconfig->end;
+                        pnp_add_mem_resource(dev, start, end, 0);
+                }
+                break;
+        }
+}
+#endif
+
 /*
  *  PnP Quirks
  *  Cards or devices that need some tweaking due to incomplete resource info
@@ -322,6 +361,9 @@ static struct pnp_fixup pnp_fixups[] = {
         /* PnP resources that might overlap PCI BARs */
         {"PNP0c01", quirk_system_pci_resources},
         {"PNP0c02", quirk_system_pci_resources},
+#ifdef CONFIG_AMD_NB
+        {"PNP0c01", quirk_amd_mmconfig_area},
+#endif
         {""}
 };