1 files changed, 6 insertions, 11 deletions

diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
index 083d6715335..e7d2496a473 100644
--- a/drivers/net/ethernet/nxp/lpc_eth.c
+++ b/drivers/net/ethernet/nxp/lpc_eth.c
@@ -52,7 +52,6 @@
 
 #define MODNAME "lpc-eth"
 #define DRV_VERSION "1.00"
-#define PHYDEF_ADDR 0x00
 
 #define ENET_MAXF_SIZE 1536
 #define ENET_RX_DESC 48
@@ -416,9 +415,6 @@ static bool use_iram_for_net(struct device *dev)
 #define TXDESC_CONTROL_LAST             (1 << 30)
 #define TXDESC_CONTROL_INT              (1 << 31)
 
-static int lpc_eth_hard_start_xmit(struct sk_buff *skb,
-                                   struct net_device *ndev);
-
 /*
  * Structure of a TX/RX descriptors and RX status
  */
@@ -440,7 +436,7 @@ struct netdata_local {
         spinlock_t              lock;
         void __iomem            *net_base;
         u32                     msg_enable;
-        struct sk_buff          *skb[ENET_TX_DESC];
+        unsigned int            skblen[ENET_TX_DESC];
         unsigned int            last_tx_idx;
         unsigned int            num_used_tx_buffs;
         struct mii_bus          *mii_bus;
@@ -903,12 +899,11 @@ err_out:
 static void __lpc_handle_xmit(struct net_device *ndev)
 {
         struct netdata_local *pldat = netdev_priv(ndev);
-        struct sk_buff *skb;
         u32 txcidx, *ptxstat, txstat;
 
         txcidx = readl(LPC_ENET_TXCONSUMEINDEX(pldat->net_base));
         while (pldat->last_tx_idx != txcidx) {
-                skb = pldat->skb[pldat->last_tx_idx];
+                unsigned int skblen = pldat->skblen[pldat->last_tx_idx];
 
                 /* A buffer is available, get buffer status */
                 ptxstat = &pldat->tx_stat_v[pldat->last_tx_idx];
@@ -945,9 +940,8 @@ static void __lpc_handle_xmit(struct net_device *ndev)
                 } else {
                         /* Update stats */
                         ndev->stats.tx_packets++;
-                        ndev->stats.tx_bytes += skb->len;
+                        ndev->stats.tx_bytes += skblen;
                 }
-                dev_kfree_skb_irq(skb);
 
                 txcidx = readl(LPC_ENET_TXCONSUMEINDEX(pldat->net_base));
         }
@@ -1132,7 +1126,7 @@ static int lpc_eth_hard_start_xmit(struct sk_buff *skb, struct net_device *ndev)
         memcpy(pldat->tx_buff_v + txidx * ENET_MAXF_SIZE, skb->data, len);
 
         /* Save the buffer and increment the buffer counter */
-        pldat->skb[txidx] = skb;
+        pldat->skblen[txidx] = len;
         pldat->num_used_tx_buffs++;
 
         /* Start transmit */
@@ -1147,6 +1141,7 @@ static int lpc_eth_hard_start_xmit(struct sk_buff *skb, struct net_device *ndev)
 
         spin_unlock_irq(&pldat->lock);
 
+        dev_kfree_skb(skb);
         return NETDEV_TX_OK;
 }
 
@@ -1442,7 +1437,7 @@ static int lpc_eth_drv_probe(struct platform_device *pdev)
                         res->start);
         netdev_dbg(ndev, "IO address size      :%d\n",
                         res->end - res->start + 1);
-        netdev_err(ndev, "IO address (mapped)  :0x%p\n",
+        netdev_dbg(ndev, "IO address (mapped)  :0x%p\n",
                         pldat->net_base);
         netdev_dbg(ndev, "IRQ number           :%d\n", ndev->irq);
         netdev_dbg(ndev, "DMA buffer size      :%d\n", pldat->dma_buff_size);