1 files changed, 27 insertions, 16 deletions

diff --git a/drivers/media/video/s5p-fimc/fimc-mdevice.c b/drivers/media/video/s5p-fimc/fimc-mdevice.c
index cc337b1de91..615c862f036 100644
--- a/drivers/media/video/s5p-fimc/fimc-mdevice.c
+++ b/drivers/media/video/s5p-fimc/fimc-mdevice.c
@@ -220,6 +220,7 @@ static struct v4l2_subdev *fimc_md_register_sensor(struct fimc_md *fmd,
         sd = v4l2_i2c_new_subdev_board(&fmd->v4l2_dev, adapter,
                                        s_info->pdata->board_info, NULL);
         if (IS_ERR_OR_NULL(sd)) {
+                i2c_put_adapter(adapter);
                 v4l2_err(&fmd->v4l2_dev, "Failed to acquire subdev\n");
                 return NULL;
         }
@@ -234,12 +235,15 @@ static struct v4l2_subdev *fimc_md_register_sensor(struct fimc_md *fmd,
 static void fimc_md_unregister_sensor(struct v4l2_subdev *sd)
 {
         struct i2c_client *client = v4l2_get_subdevdata(sd);
+        struct i2c_adapter *adapter;
 
         if (!client)
                 return;
         v4l2_device_unregister_subdev(sd);
+        adapter = client->adapter;
         i2c_unregister_device(client);
-        i2c_put_adapter(client->adapter);
+        if (adapter)
+                i2c_put_adapter(adapter);
 }
 
 static int fimc_md_register_sensor_entities(struct fimc_md *fmd)
@@ -381,20 +385,28 @@ static void fimc_md_unregister_entities(struct fimc_md *fmd)
 
 static int fimc_md_register_video_nodes(struct fimc_md *fmd)
 {
+        struct video_device *vdev;
         int i, ret = 0;
 
         for (i = 0; i < FIMC_MAX_DEVS && !ret; i++) {
                 if (!fmd->fimc[i])
                         continue;
 
-                if (fmd->fimc[i]->m2m.vfd)
-                        ret = video_register_device(fmd->fimc[i]->m2m.vfd,
-                                                    VFL_TYPE_GRABBER, -1);
-                if (ret)
-                        break;
-                if (fmd->fimc[i]->vid_cap.vfd)
-                        ret = video_register_device(fmd->fimc[i]->vid_cap.vfd,
-                                                    VFL_TYPE_GRABBER, -1);
+                vdev = fmd->fimc[i]->m2m.vfd;
+                if (vdev) {
+                        ret = video_register_device(vdev, VFL_TYPE_GRABBER, -1);
+                        if (ret)
+                                break;
+                        v4l2_info(&fmd->v4l2_dev, "Registered %s as /dev/%s\n",
+                                  vdev->name, video_device_node_name(vdev));
+                }
+
+                vdev = fmd->fimc[i]->vid_cap.vfd;
+                if (vdev == NULL)
+                        continue;
+                ret = video_register_device(vdev, VFL_TYPE_GRABBER, -1);
+                v4l2_info(&fmd->v4l2_dev, "Registered %s as /dev/%s\n",
+                          vdev->name, video_device_node_name(vdev));
         }
 
         return ret;
@@ -502,7 +514,7 @@ static int fimc_md_create_links(struct fimc_md *fmd)
                         if (WARN(csis == NULL,
                                  "MIPI-CSI interface specified "
                                  "but s5p-csis module is not loaded!\n"))
-                                continue;
+                                return -EINVAL;
 
                         ret = media_entity_create_link(&sensor->entity, 0,
                                               &csis->entity, CSIS_PAD_SINK,
@@ -742,9 +754,6 @@ static int __devinit fimc_md_probe(struct platform_device *pdev)
         struct fimc_md *fmd;
         int ret;
 
-        if (WARN(!pdev->dev.platform_data, "Platform data not specified!\n"))
-                return -EINVAL;
-
         fmd = kzalloc(sizeof(struct fimc_md), GFP_KERNEL);
         if (!fmd)
                 return -ENOMEM;
@@ -782,9 +791,11 @@ static int __devinit fimc_md_probe(struct platform_device *pdev)
         if (ret)
                 goto err3;
 
-        ret = fimc_md_register_sensor_entities(fmd);
-        if (ret)
-                goto err3;
+        if (pdev->dev.platform_data) {
+                ret = fimc_md_register_sensor_entities(fmd);
+                if (ret)
+                        goto err3;
+        }
         ret = fimc_md_create_links(fmd);
         if (ret)
                 goto err3;