aboutsummaryrefslogtreecommitdiffstats
path: root/fs/nfsd/nfs4callback.c
diff options
context:
space:
mode:
authorJ. Bruce Fields <bfields@redhat.com>2010-10-19 19:36:51 -0400
committerJ. Bruce Fields <bfields@redhat.com>2010-10-21 10:12:02 -0400
commit8323c3b2a6b6543919d5ebdddc7d52f192126161 (patch)
tree35976d6ba2f1917f569e44056c43f2bf724af7ef /fs/nfsd/nfs4callback.c
parent792c95dd519c54d6b0fd6401b3da7ea67b0d6b72 (diff)
nfsd4: move minorversion to client
The minorversion seems more a property of the client than the callback channel. Some time we should probably also enforce consistent minorversion usage from the client; for now, this is just a cosmetic change. Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd/nfs4callback.c')
-rw-r--r--fs/nfsd/nfs4callback.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index d38ee3c55a0..67bcd2c7262 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -496,7 +496,7 @@ int setup_callback_client(struct nfs4_client *clp, struct nfs4_cb_conn *conn)
496 496
497 if (!clp->cl_principal && (clp->cl_flavor >= RPC_AUTH_GSS_KRB5)) 497 if (!clp->cl_principal && (clp->cl_flavor >= RPC_AUTH_GSS_KRB5))
498 return -EINVAL; 498 return -EINVAL;
499 if (conn->cb_minorversion) { 499 if (clp->cl_minorversion) {
500 args.bc_xprt = conn->cb_xprt; 500 args.bc_xprt = conn->cb_xprt;
501 args.prognumber = clp->cl_cb_session->se_cb_prog; 501 args.prognumber = clp->cl_cb_session->se_cb_prog;
502 args.protocol = XPRT_TRANSPORT_BC_TCP; 502 args.protocol = XPRT_TRANSPORT_BC_TCP;
@@ -620,7 +620,7 @@ static void nfsd4_cb_prepare(struct rpc_task *task, void *calldata)
620 struct nfsd4_callback *cb = calldata; 620 struct nfsd4_callback *cb = calldata;
621 struct nfs4_delegation *dp = container_of(cb, struct nfs4_delegation, dl_recall); 621 struct nfs4_delegation *dp = container_of(cb, struct nfs4_delegation, dl_recall);
622 struct nfs4_client *clp = dp->dl_client; 622 struct nfs4_client *clp = dp->dl_client;
623 u32 minorversion = clp->cl_cb_conn.cb_minorversion; 623 u32 minorversion = clp->cl_minorversion;
624 int status = 0; 624 int status = 0;
625 625
626 cb->cb_minorversion = minorversion; 626 cb->cb_minorversion = minorversion;
@@ -645,9 +645,9 @@ static void nfsd4_cb_done(struct rpc_task *task, void *calldata)
645 struct nfs4_client *clp = dp->dl_client; 645 struct nfs4_client *clp = dp->dl_client;
646 646
647 dprintk("%s: minorversion=%d\n", __func__, 647 dprintk("%s: minorversion=%d\n", __func__,
648 clp->cl_cb_conn.cb_minorversion); 648 clp->cl_minorversion);
649 649
650 if (clp->cl_cb_conn.cb_minorversion) { 650 if (clp->cl_minorversion) {
651 /* No need for lock, access serialized in nfsd4_cb_prepare */ 651 /* No need for lock, access serialized in nfsd4_cb_prepare */
652 ++clp->cl_cb_session->se_cb_seq_nr; 652 ++clp->cl_cb_session->se_cb_seq_nr;
653 clear_bit(0, &clp->cl_cb_slot_busy); 653 clear_bit(0, &clp->cl_cb_slot_busy);