diff options
author | Liu Bo <bo.li.liu@oracle.com> | 2012-11-05 07:42:08 -0500 |
---|---|---|
committer | Josef Bacik <jbacik@fusionio.com> | 2012-12-12 17:15:25 -0500 |
commit | 37c4146d2208ba7e4463e8dd95a1bf9e3d865280 (patch) | |
tree | dcd62a0b6b30338be75cd2acfe5cbbcbfe726c3a /fs/btrfs/extent-tree.c | |
parent | 6c1500f22a7be3a24ad3dffcdbf04be3f676521b (diff) |
Btrfs: fix a deadlock in aborting transaction due to ENOSPC
When committing a transaction, we may bail out of running delayed refs
due to ENOSPC, and then abort the current transaction to flip into readonly.
But we'll hit a deadlock on ref head's lock since we forget to release
its lock and other cleanup stuff.
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>
Diffstat (limited to 'fs/btrfs/extent-tree.c')
-rw-r--r-- | fs/btrfs/extent-tree.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 0bcb9543da6..f8a358aee06 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c | |||
@@ -2297,6 +2297,9 @@ static noinline int run_clustered_refs(struct btrfs_trans_handle *trans, | |||
2297 | kfree(extent_op); | 2297 | kfree(extent_op); |
2298 | 2298 | ||
2299 | if (ret) { | 2299 | if (ret) { |
2300 | list_del_init(&locked_ref->cluster); | ||
2301 | mutex_unlock(&locked_ref->mutex); | ||
2302 | |||
2300 | printk(KERN_DEBUG "btrfs: run_delayed_extent_op returned %d\n", ret); | 2303 | printk(KERN_DEBUG "btrfs: run_delayed_extent_op returned %d\n", ret); |
2301 | spin_lock(&delayed_refs->lock); | 2304 | spin_lock(&delayed_refs->lock); |
2302 | return ret; | 2305 | return ret; |
@@ -2339,6 +2342,10 @@ static noinline int run_clustered_refs(struct btrfs_trans_handle *trans, | |||
2339 | count++; | 2342 | count++; |
2340 | 2343 | ||
2341 | if (ret) { | 2344 | if (ret) { |
2345 | if (locked_ref) { | ||
2346 | list_del_init(&locked_ref->cluster); | ||
2347 | mutex_unlock(&locked_ref->mutex); | ||
2348 | } | ||
2342 | printk(KERN_DEBUG "btrfs: run_one_delayed_ref returned %d\n", ret); | 2349 | printk(KERN_DEBUG "btrfs: run_one_delayed_ref returned %d\n", ret); |
2343 | spin_lock(&delayed_refs->lock); | 2350 | spin_lock(&delayed_refs->lock); |
2344 | return ret; | 2351 | return ret; |