diff options
Diffstat (limited to 'drivers/net/b44.c')
-rw-r--r-- | drivers/net/b44.c | 35 |
1 files changed, 16 insertions, 19 deletions
diff --git a/drivers/net/b44.c b/drivers/net/b44.c index a7e4ba5a580..e891ea2ecc3 100644 --- a/drivers/net/b44.c +++ b/drivers/net/b44.c | |||
@@ -1421,7 +1421,7 @@ static int b44_open(struct net_device *dev) | |||
1421 | 1421 | ||
1422 | b44_check_phy(bp); | 1422 | b44_check_phy(bp); |
1423 | 1423 | ||
1424 | err = request_irq(dev->irq, b44_interrupt, SA_SHIRQ, dev->name, dev); | 1424 | err = request_irq(dev->irq, b44_interrupt, IRQF_SHARED, dev->name, dev); |
1425 | if (unlikely(err < 0)) { | 1425 | if (unlikely(err < 0)) { |
1426 | b44_chip_reset(bp); | 1426 | b44_chip_reset(bp); |
1427 | b44_free_rings(bp); | 1427 | b44_free_rings(bp); |
@@ -2012,7 +2012,7 @@ static int b44_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol) | |||
2012 | return 0; | 2012 | return 0; |
2013 | } | 2013 | } |
2014 | 2014 | ||
2015 | static struct ethtool_ops b44_ethtool_ops = { | 2015 | static const struct ethtool_ops b44_ethtool_ops = { |
2016 | .get_drvinfo = b44_get_drvinfo, | 2016 | .get_drvinfo = b44_get_drvinfo, |
2017 | .get_settings = b44_get_settings, | 2017 | .get_settings = b44_get_settings, |
2018 | .set_settings = b44_set_settings, | 2018 | .set_settings = b44_set_settings, |
@@ -2120,13 +2120,14 @@ static int __devinit b44_init_one(struct pci_dev *pdev, | |||
2120 | 2120 | ||
2121 | err = pci_enable_device(pdev); | 2121 | err = pci_enable_device(pdev); |
2122 | if (err) { | 2122 | if (err) { |
2123 | printk(KERN_ERR PFX "Cannot enable PCI device, " | 2123 | dev_err(&pdev->dev, "Cannot enable PCI device, " |
2124 | "aborting.\n"); | 2124 | "aborting.\n"); |
2125 | return err; | 2125 | return err; |
2126 | } | 2126 | } |
2127 | 2127 | ||
2128 | if (!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM)) { | 2128 | if (!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM)) { |
2129 | printk(KERN_ERR PFX "Cannot find proper PCI device " | 2129 | dev_err(&pdev->dev, |
2130 | "Cannot find proper PCI device " | ||
2130 | "base address, aborting.\n"); | 2131 | "base address, aborting.\n"); |
2131 | err = -ENODEV; | 2132 | err = -ENODEV; |
2132 | goto err_out_disable_pdev; | 2133 | goto err_out_disable_pdev; |
@@ -2134,8 +2135,8 @@ static int __devinit b44_init_one(struct pci_dev *pdev, | |||
2134 | 2135 | ||
2135 | err = pci_request_regions(pdev, DRV_MODULE_NAME); | 2136 | err = pci_request_regions(pdev, DRV_MODULE_NAME); |
2136 | if (err) { | 2137 | if (err) { |
2137 | printk(KERN_ERR PFX "Cannot obtain PCI resources, " | 2138 | dev_err(&pdev->dev, |
2138 | "aborting.\n"); | 2139 | "Cannot obtain PCI resources, aborting.\n"); |
2139 | goto err_out_disable_pdev; | 2140 | goto err_out_disable_pdev; |
2140 | } | 2141 | } |
2141 | 2142 | ||
@@ -2143,15 +2144,13 @@ static int __devinit b44_init_one(struct pci_dev *pdev, | |||
2143 | 2144 | ||
2144 | err = pci_set_dma_mask(pdev, (u64) B44_DMA_MASK); | 2145 | err = pci_set_dma_mask(pdev, (u64) B44_DMA_MASK); |
2145 | if (err) { | 2146 | if (err) { |
2146 | printk(KERN_ERR PFX "No usable DMA configuration, " | 2147 | dev_err(&pdev->dev, "No usable DMA configuration, aborting.\n"); |
2147 | "aborting.\n"); | ||
2148 | goto err_out_free_res; | 2148 | goto err_out_free_res; |
2149 | } | 2149 | } |
2150 | 2150 | ||
2151 | err = pci_set_consistent_dma_mask(pdev, (u64) B44_DMA_MASK); | 2151 | err = pci_set_consistent_dma_mask(pdev, (u64) B44_DMA_MASK); |
2152 | if (err) { | 2152 | if (err) { |
2153 | printk(KERN_ERR PFX "No usable DMA configuration, " | 2153 | dev_err(&pdev->dev, "No usable DMA configuration, aborting.\n"); |
2154 | "aborting.\n"); | ||
2155 | goto err_out_free_res; | 2154 | goto err_out_free_res; |
2156 | } | 2155 | } |
2157 | 2156 | ||
@@ -2160,7 +2159,7 @@ static int __devinit b44_init_one(struct pci_dev *pdev, | |||
2160 | 2159 | ||
2161 | dev = alloc_etherdev(sizeof(*bp)); | 2160 | dev = alloc_etherdev(sizeof(*bp)); |
2162 | if (!dev) { | 2161 | if (!dev) { |
2163 | printk(KERN_ERR PFX "Etherdev alloc failed, aborting.\n"); | 2162 | dev_err(&pdev->dev, "Etherdev alloc failed, aborting.\n"); |
2164 | err = -ENOMEM; | 2163 | err = -ENOMEM; |
2165 | goto err_out_free_res; | 2164 | goto err_out_free_res; |
2166 | } | 2165 | } |
@@ -2181,8 +2180,7 @@ static int __devinit b44_init_one(struct pci_dev *pdev, | |||
2181 | 2180 | ||
2182 | bp->regs = ioremap(b44reg_base, b44reg_len); | 2181 | bp->regs = ioremap(b44reg_base, b44reg_len); |
2183 | if (bp->regs == 0UL) { | 2182 | if (bp->regs == 0UL) { |
2184 | printk(KERN_ERR PFX "Cannot map device registers, " | 2183 | dev_err(&pdev->dev, "Cannot map device registers, aborting.\n"); |
2185 | "aborting.\n"); | ||
2186 | err = -ENOMEM; | 2184 | err = -ENOMEM; |
2187 | goto err_out_free_dev; | 2185 | goto err_out_free_dev; |
2188 | } | 2186 | } |
@@ -2212,8 +2210,8 @@ static int __devinit b44_init_one(struct pci_dev *pdev, | |||
2212 | 2210 | ||
2213 | err = b44_get_invariants(bp); | 2211 | err = b44_get_invariants(bp); |
2214 | if (err) { | 2212 | if (err) { |
2215 | printk(KERN_ERR PFX "Problem fetching invariants of chip, " | 2213 | dev_err(&pdev->dev, |
2216 | "aborting.\n"); | 2214 | "Problem fetching invariants of chip, aborting.\n"); |
2217 | goto err_out_iounmap; | 2215 | goto err_out_iounmap; |
2218 | } | 2216 | } |
2219 | 2217 | ||
@@ -2233,8 +2231,7 @@ static int __devinit b44_init_one(struct pci_dev *pdev, | |||
2233 | 2231 | ||
2234 | err = register_netdev(dev); | 2232 | err = register_netdev(dev); |
2235 | if (err) { | 2233 | if (err) { |
2236 | printk(KERN_ERR PFX "Cannot register net device, " | 2234 | dev_err(&pdev->dev, "Cannot register net device, aborting.\n"); |
2237 | "aborting.\n"); | ||
2238 | goto err_out_iounmap; | 2235 | goto err_out_iounmap; |
2239 | } | 2236 | } |
2240 | 2237 | ||
@@ -2322,7 +2319,7 @@ static int b44_resume(struct pci_dev *pdev) | |||
2322 | if (!netif_running(dev)) | 2319 | if (!netif_running(dev)) |
2323 | return 0; | 2320 | return 0; |
2324 | 2321 | ||
2325 | if (request_irq(dev->irq, b44_interrupt, SA_SHIRQ, dev->name, dev)) | 2322 | if (request_irq(dev->irq, b44_interrupt, IRQF_SHARED, dev->name, dev)) |
2326 | printk(KERN_ERR PFX "%s: request_irq failed\n", dev->name); | 2323 | printk(KERN_ERR PFX "%s: request_irq failed\n", dev->name); |
2327 | 2324 | ||
2328 | spin_lock_irq(&bp->lock); | 2325 | spin_lock_irq(&bp->lock); |
@@ -2357,7 +2354,7 @@ static int __init b44_init(void) | |||
2357 | dma_desc_align_mask = ~(dma_desc_align_size - 1); | 2354 | dma_desc_align_mask = ~(dma_desc_align_size - 1); |
2358 | dma_desc_sync_size = max_t(unsigned int, dma_desc_align_size, sizeof(struct dma_desc)); | 2355 | dma_desc_sync_size = max_t(unsigned int, dma_desc_align_size, sizeof(struct dma_desc)); |
2359 | 2356 | ||
2360 | return pci_module_init(&b44_driver); | 2357 | return pci_register_driver(&b44_driver); |
2361 | } | 2358 | } |
2362 | 2359 | ||
2363 | static void __exit b44_cleanup(void) | 2360 | static void __exit b44_cleanup(void) |