diff options
| -rw-r--r-- | drivers/rtc/rtc-at32ap700x.c | 19 | ||||
| -rw-r--r-- | drivers/rtc/rtc-at91rm9200.c | 20 | ||||
| -rw-r--r-- | drivers/rtc/rtc-at91sam9.c | 20 | ||||
| -rw-r--r-- | drivers/rtc/rtc-bfin.c | 21 | ||||
| -rw-r--r-- | drivers/rtc/rtc-ds1286.c | 41 | ||||
| -rw-r--r-- | drivers/rtc/rtc-ds1305.c | 43 | ||||
| -rw-r--r-- | drivers/rtc/rtc-ds1307.c | 49 | ||||
| -rw-r--r-- | drivers/rtc/rtc-ds1374.c | 37 | ||||
| -rw-r--r-- | drivers/rtc/rtc-m41t80.c | 30 | ||||
| -rw-r--r-- | drivers/rtc/rtc-m48t59.c | 21 | ||||
| -rw-r--r-- | drivers/rtc/rtc-mrst.c | 31 | ||||
| -rw-r--r-- | drivers/rtc/rtc-mv.c | 20 | ||||
| -rw-r--r-- | drivers/rtc/rtc-omap.c | 28 | ||||
| -rw-r--r-- | drivers/rtc/rtc-rs5c372.c | 48 | ||||
| -rw-r--r-- | drivers/rtc/rtc-sa1100.c | 22 | ||||
| -rw-r--r-- | drivers/rtc/rtc-sh.c | 11 | ||||
| -rw-r--r-- | drivers/rtc/rtc-test.c | 21 | ||||
| -rw-r--r-- | drivers/rtc/rtc-vr41xx.c | 38 |
18 files changed, 223 insertions, 297 deletions
diff --git a/drivers/rtc/rtc-at32ap700x.c b/drivers/rtc/rtc-at32ap700x.c index b2752b6e7a2..e725d51e773 100644 --- a/drivers/rtc/rtc-at32ap700x.c +++ b/drivers/rtc/rtc-at32ap700x.c | |||
| @@ -134,36 +134,29 @@ static int at32_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm) | |||
| 134 | return ret; | 134 | return ret; |
| 135 | } | 135 | } |
| 136 | 136 | ||
| 137 | static int at32_rtc_ioctl(struct device *dev, unsigned int cmd, | 137 | static int at32_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) |
| 138 | unsigned long arg) | ||
| 139 | { | 138 | { |
| 140 | struct rtc_at32ap700x *rtc = dev_get_drvdata(dev); | 139 | struct rtc_at32ap700x *rtc = dev_get_drvdata(dev); |
| 141 | int ret = 0; | 140 | int ret = 0; |
| 142 | 141 | ||
| 143 | spin_lock_irq(&rtc->lock); | 142 | spin_lock_irq(&rtc->lock); |
| 144 | 143 | ||
| 145 | switch (cmd) { | 144 | if(enabled) { |
| 146 | case RTC_AIE_ON: | ||
| 147 | if (rtc_readl(rtc, VAL) > rtc->alarm_time) { | 145 | if (rtc_readl(rtc, VAL) > rtc->alarm_time) { |
| 148 | ret = -EINVAL; | 146 | ret = -EINVAL; |
| 149 | break; | 147 | goto out; |
| 150 | } | 148 | } |
| 151 | rtc_writel(rtc, CTRL, rtc_readl(rtc, CTRL) | 149 | rtc_writel(rtc, CTRL, rtc_readl(rtc, CTRL) |
| 152 | | RTC_BIT(CTRL_TOPEN)); | 150 | | RTC_BIT(CTRL_TOPEN)); |
| 153 | rtc_writel(rtc, ICR, RTC_BIT(ICR_TOPI)); | 151 | rtc_writel(rtc, ICR, RTC_BIT(ICR_TOPI)); |
| 154 | rtc_writel(rtc, IER, RTC_BIT(IER_TOPI)); | 152 | rtc_writel(rtc, IER, RTC_BIT(IER_TOPI)); |
| 155 | break; | 153 | } else { |
| 156 | case RTC_AIE_OFF: | ||
| 157 | rtc_writel(rtc, CTRL, rtc_readl(rtc, CTRL) | 154 | rtc_writel(rtc, CTRL, rtc_readl(rtc, CTRL) |
| 158 | & ~RTC_BIT(CTRL_TOPEN)); | 155 | & ~RTC_BIT(CTRL_TOPEN)); |
| 159 | rtc_writel(rtc, IDR, RTC_BIT(IDR_TOPI)); | 156 | rtc_writel(rtc, IDR, RTC_BIT(IDR_TOPI)); |
| 160 | rtc_writel(rtc, ICR, RTC_BIT(ICR_TOPI)); | 157 | rtc_writel(rtc, ICR, RTC_BIT(ICR_TOPI)); |
| 161 | break; | ||
| 162 | default: | ||
| 163 | ret = -ENOIOCTLCMD; | ||
| 164 | break; | ||
| 165 | } | 158 | } |
| 166 | 159 | out: | |
| 167 | spin_unlock_irq(&rtc->lock); | 160 | spin_unlock_irq(&rtc->lock); |
| 168 | 161 | ||
| 169 | return ret; | 162 | return ret; |
| @@ -195,11 +188,11 @@ static irqreturn_t at32_rtc_interrupt(int irq, void *dev_id) | |||
| 195 | } | 188 | } |
| 196 | 189 | ||
| 197 | static struct rtc_class_ops at32_rtc_ops = { | 190 | static struct rtc_class_ops at32_rtc_ops = { |
| 198 | .ioctl = at32_rtc_ioctl, | ||
| 199 | .read_time = at32_rtc_readtime, | 191 | .read_time = at32_rtc_readtime, |
| 200 | .set_time = at32_rtc_settime, | 192 | .set_time = at32_rtc_settime, |
| 201 | .read_alarm = at32_rtc_readalarm, | 193 | .read_alarm = at32_rtc_readalarm, |
| 202 | .set_alarm = at32_rtc_setalarm, | 194 | .set_alarm = at32_rtc_setalarm, |
| 195 | .alarm_irq_enable = at32_rtc_alarm_irq_enable, | ||
| 203 | }; | 196 | }; |
| 204 | 197 | ||
| 205 | static int __init at32_rtc_probe(struct platform_device *pdev) | 198 | static int __init at32_rtc_probe(struct platform_device *pdev) |
diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c index bc8bbca9a2e..26d1cf5d19a 100644 --- a/drivers/rtc/rtc-at91rm9200.c +++ b/drivers/rtc/rtc-at91rm9200.c | |||
| @@ -195,13 +195,6 @@ static int at91_rtc_ioctl(struct device *dev, unsigned int cmd, | |||
| 195 | 195 | ||
| 196 | /* important: scrub old status before enabling IRQs */ | 196 | /* important: scrub old status before enabling IRQs */ |
| 197 | switch (cmd) { | 197 | switch (cmd) { |
| 198 | case RTC_AIE_OFF: /* alarm off */ | ||
| 199 | at91_sys_write(AT91_RTC_IDR, AT91_RTC_ALARM); | ||
| 200 | break; | ||
| 201 | case RTC_AIE_ON: /* alarm on */ | ||
| 202 | at91_sys_write(AT91_RTC_SCCR, AT91_RTC_ALARM); | ||
| 203 | at91_sys_write(AT91_RTC_IER, AT91_RTC_ALARM); | ||
| 204 | break; | ||
| 205 | case RTC_UIE_OFF: /* update off */ | 198 | case RTC_UIE_OFF: /* update off */ |
| 206 | at91_sys_write(AT91_RTC_IDR, AT91_RTC_SECEV); | 199 | at91_sys_write(AT91_RTC_IDR, AT91_RTC_SECEV); |
| 207 | break; | 200 | break; |
| @@ -217,6 +210,18 @@ static int at91_rtc_ioctl(struct device *dev, unsigned int cmd, | |||
| 217 | return ret; | 210 | return ret; |
| 218 | } | 211 | } |
| 219 | 212 | ||
| 213 | static int at91_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) | ||
| 214 | { | ||
| 215 | pr_debug("%s(): cmd=%08x\n", __func__, enabled); | ||
| 216 | |||
| 217 | if (enabled) { | ||
| 218 | at91_sys_write(AT91_RTC_SCCR, AT91_RTC_ALARM); | ||
| 219 | at91_sys_write(AT91_RTC_IER, AT91_RTC_ALARM); | ||
| 220 | } else | ||
| 221 | at91_sys_write(AT91_RTC_IDR, AT91_RTC_ALARM); | ||
| 222 | |||
| 223 | return 0; | ||
| 224 | } | ||
| 220 | /* | 225 | /* |
| 221 | * Provide additional RTC information in /proc/driver/rtc | 226 | * Provide additional RTC information in /proc/driver/rtc |
| 222 | */ | 227 | */ |
| @@ -270,6 +275,7 @@ static const struct rtc_class_ops at91_rtc_ops = { | |||
| 270 | .read_alarm = at91_rtc_readalarm, | 275 | .read_alarm = at91_rtc_readalarm, |
| 271 | .set_alarm = at91_rtc_setalarm, | 276 | .set_alarm = at91_rtc_setalarm, |
| 272 | .proc = at91_rtc_proc, | 277 | .proc = at91_rtc_proc, |
| 278 | .alarm_irq_enable = at91_rtc_alarm_irq_enable, | ||
| 273 | }; | 279 | }; |
| 274 | 280 | ||
| 275 | /* | 281 | /* |
diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c index f677e0710ca..c36749e4c92 100644 --- a/drivers/rtc/rtc-at91sam9.c +++ b/drivers/rtc/rtc-at91sam9.c | |||
| @@ -229,12 +229,6 @@ static int at91_rtc_ioctl(struct device *dev, unsigned int cmd, | |||
| 229 | dev_dbg(dev, "ioctl: cmd=%08x, arg=%08lx, mr %08x\n", cmd, arg, mr); | 229 | dev_dbg(dev, "ioctl: cmd=%08x, arg=%08lx, mr %08x\n", cmd, arg, mr); |
| 230 | 230 | ||
| 231 | switch (cmd) { | 231 | switch (cmd) { |
| 232 | case RTC_AIE_OFF: /* alarm off */ | ||
| 233 | rtt_writel(rtc, MR, mr & ~AT91_RTT_ALMIEN); | ||
| 234 | break; | ||
| 235 | case RTC_AIE_ON: /* alarm on */ | ||
| 236 | rtt_writel(rtc, MR, mr | AT91_RTT_ALMIEN); | ||
| 237 | break; | ||
| 238 | case RTC_UIE_OFF: /* update off */ | 232 | case RTC_UIE_OFF: /* update off */ |
| 239 | rtt_writel(rtc, MR, mr & ~AT91_RTT_RTTINCIEN); | 233 | rtt_writel(rtc, MR, mr & ~AT91_RTT_RTTINCIEN); |
| 240 | break; | 234 | break; |
| @@ -249,6 +243,19 @@ static int at91_rtc_ioctl(struct device *dev, unsigned int cmd, | |||
| 249 | return ret; | 243 | return ret; |
| 250 | } | 244 | } |
| 251 | 245 | ||
| 246 | static int at91_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) | ||
| 247 | { | ||
| 248 | struct sam9_rtc *rtc = dev_get_drvdata(dev); | ||
| 249 | u32 mr = rtt_readl(rtc, MR); | ||
| 250 | |||
| 251 | dev_dbg(dev, "alarm_irq_enable: enabled=%08x, mr %08x\n", enabled, mr); | ||
| 252 | if (enabled) | ||
| 253 | rtt_writel(rtc, MR, mr | AT91_RTT_ALMIEN); | ||
| 254 | else | ||
| 255 | rtt_writel(rtc, MR, mr & ~AT91_RTT_ALMIEN); | ||
| 256 | return 0; | ||
| 257 | } | ||
| 258 | |||
| 252 | /* | 259 | /* |
| 253 | * Provide additional RTC information in /proc/driver/rtc | 260 | * Provide additional RTC information in /proc/driver/rtc |
| 254 | */ | 261 | */ |
| @@ -302,6 +309,7 @@ static const struct rtc_class_ops at91_rtc_ops = { | |||
| 302 | .read_alarm = at91_rtc_readalarm, | 309 | .read_alarm = at91_rtc_readalarm, |
| 303 | .set_alarm = at91_rtc_setalarm, | 310 | .set_alarm = at91_rtc_setalarm, |
| 304 | .proc = at91_rtc_proc, | 311 | .proc = at91_rtc_proc, |
| 312 | .alarm_irq_enabled = at91_rtc_alarm_irq_enable, | ||
| 305 | }; | 313 | }; |
| 306 | 314 | ||
| 307 | /* | 315 | /* |
diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c index b4b6087f223..17971d93354 100644 --- a/drivers/rtc/rtc-bfin.c +++ b/drivers/rtc/rtc-bfin.c | |||
| @@ -259,15 +259,6 @@ static int bfin_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long ar | |||
| 259 | bfin_rtc_int_clear(~RTC_ISTAT_SEC); | 259 | bfin_rtc_int_clear(~RTC_ISTAT_SEC); |
| 260 | break; | 260 | break; |
| 261 | 261 | ||
| 262 | case RTC_AIE_ON: | ||
| 263 | dev_dbg_stamp(dev); | ||
| 264 | bfin_rtc_int_set_alarm(rtc); | ||
| 265 | break; | ||
| 266 | case RTC_AIE_OFF: | ||
| 267 | dev_dbg_stamp(dev); | ||
| 268 | bfin_rtc_int_clear(~(RTC_ISTAT_ALARM | RTC_ISTAT_ALARM_DAY)); | ||
| 269 | break; | ||
| 270 | |||
| 271 | default: | 262 | default: |
| 272 | dev_dbg_stamp(dev); | 263 | dev_dbg_stamp(dev); |
| 273 | ret = -ENOIOCTLCMD; | 264 | ret = -ENOIOCTLCMD; |
| @@ -276,6 +267,17 @@ static int bfin_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long ar | |||
| 276 | return ret; | 267 | return ret; |
| 277 | } | 268 | } |
| 278 | 269 | ||
| 270 | static int bfin_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) | ||
| 271 | { | ||
| 272 | struct bfin_rtc *rtc = dev_get_drvdata(dev); | ||
| 273 | |||
| 274 | dev_dbg_stamp(dev); | ||
| 275 | if (enabled) | ||
| 276 | bfin_rtc_int_set_alarm(rtc); | ||
| 277 | else | ||
| 278 | bfin_rtc_int_clear(~(RTC_ISTAT_ALARM | RTC_ISTAT_ALARM_DAY)); | ||
| 279 | } | ||
| 280 | |||
| 279 | static int bfin_rtc_read_time(struct device *dev, struct rtc_time *tm) | 281 | static int bfin_rtc_read_time(struct device *dev, struct rtc_time *tm) |
| 280 | { | 282 | { |
| 281 | struct bfin_rtc *rtc = dev_get_drvdata(dev); | 283 | struct bfin_rtc *rtc = dev_get_drvdata(dev); |
| @@ -362,6 +364,7 @@ static struct rtc_class_ops bfin_rtc_ops = { | |||
| 362 | .read_alarm = bfin_rtc_read_alarm, | 364 | .read_alarm = bfin_rtc_read_alarm, |
| 363 | .set_alarm = bfin_rtc_set_alarm, | 365 | .set_alarm = bfin_rtc_set_alarm, |
| 364 | .proc = bfin_rtc_proc, | 366 | .proc = bfin_rtc_proc, |
| 367 | .alarm_irq_enable = bfin_rtc_alarm_irq_enable, | ||
| 365 | }; | 368 | }; |
| 366 | 369 | ||
| 367 | static int __devinit bfin_rtc_probe(struct platform_device *pdev) | 370 | static int __devinit bfin_rtc_probe(struct platform_device *pdev) |
diff --git a/drivers/rtc/rtc-ds1286.c b/drivers/rtc/rtc-ds1286.c index bf430f9091e..60ce6960082 100644 --- a/drivers/rtc/rtc-ds1286.c +++ b/drivers/rtc/rtc-ds1286.c | |||
| @@ -40,6 +40,26 @@ static inline void ds1286_rtc_write(struct ds1286_priv *priv, u8 data, int reg) | |||
| 40 | __raw_writel(data, &priv->rtcregs[reg]); | 40 | __raw_writel(data, &priv->rtcregs[reg]); |
| 41 | } | 41 | } |
| 42 | 42 | ||
| 43 | |||
| 44 | static int ds1286_alarm_irq_enable(struct device *dev, unsigned int enabled) | ||
| 45 | { | ||
| 46 | struct ds1286_priv *priv = dev_get_drvdata(dev); | ||
| 47 | unsigned long flags; | ||
| 48 | unsigned char val; | ||
| 49 | |||
| 50 | /* Allow or mask alarm interrupts */ | ||
| 51 | spin_lock_irqsave(&priv->lock, flags); | ||
| 52 | val = ds1286_rtc_read(priv, RTC_CMD); | ||
| 53 | if (enabled) | ||
| 54 | val &= ~RTC_TDM; | ||
| 55 | else | ||
| 56 | val |= RTC_TDM; | ||
| 57 | ds1286_rtc_write(priv, val, RTC_CMD); | ||
| 58 | spin_unlock_irqrestore(&priv->lock, flags); | ||
| 59 | |||
| 60 | return 0; | ||
| 61 | } | ||
| 62 | |||
| 43 | #ifdef CONFIG_RTC_INTF_DEV | 63 | #ifdef CONFIG_RTC_INTF_DEV |
| 44 | 64 | ||
| 45 | static int ds1286_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) | 65 | static int ds1286_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) |
| @@ -49,22 +69,6 @@ static int ds1286_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) | |||
| 49 | unsigned char val; | 69 | unsigned char val; |
| 50 | 70 | ||
| 51 | switch (cmd) { | 71 | switch (cmd) { |
| 52 | case RTC_AIE_OFF: | ||
| 53 | /* Mask alarm int. enab. bit */ | ||
| 54 | spin_lock_irqsave(&priv->lock, flags); | ||
| 55 | val = ds1286_rtc_read(priv, RTC_CMD); | ||
| 56 | val |= RTC_TDM; | ||
| 57 | ds1286_rtc_write(priv, val, RTC_CMD); | ||
| 58 | spin_unlock_irqrestore(&priv->lock, flags); | ||
| 59 | break; | ||
| 60 | case RTC_AIE_ON: | ||
| 61 | /* Allow alarm interrupts. */ | ||
| 62 | spin_lock_irqsave(&priv->lock, flags); | ||
| 63 | val = ds1286_rtc_read(priv, RTC_CMD); | ||
| 64 | val &= ~RTC_TDM; | ||
| 65 | ds1286_rtc_write(priv, val, RTC_CMD); | ||
| 66 | spin_unlock_irqrestore(&priv->lock, flags); | ||
| 67 | break; | ||
| 68 | case RTC_WIE_OFF: | 72 | case RTC_WIE_OFF: |
| 69 | /* Mask watchdog int. enab. bit */ | 73 | /* Mask watchdog int. enab. bit */ |
| 70 | spin_lock_irqsave(&priv->lock, flags); | 74 | spin_lock_irqsave(&priv->lock, flags); |
| @@ -316,12 +320,13 @@ static int ds1286_set_alarm(struct device *dev, struct rtc_wkalrm *alm) | |||
| 316 | } | 320 | } |
| 317 | 321 | ||
| 318 | static const struct rtc_class_ops ds1286_ops = { | 322 | static const struct rtc_class_ops ds1286_ops = { |
| 319 | .ioctl = ds1286_ioctl, | 323 | .ioctl = ds1286_ioctl, |
| 320 | .proc = ds1286_proc, | 324 | .proc = ds1286_proc, |
| 321 | .read_time = ds1286_read_time, | 325 | .read_time = ds1286_read_time, |
| 322 | .set_time = ds1286_set_time, | 326 | .set_time = ds1286_set_time, |
| 323 | .read_alarm = ds1286_read_alarm, | 327 | .read_alarm = ds1286_read_alarm, |
| 324 | .set_alarm = ds1286_set_alarm, | 328 | .set_alarm = ds1286_set_alarm, |
| 329 | .alarm_irq_enable = ds1286_alarm_irq_enable, | ||
| 325 | }; | 330 | }; |
| 326 | 331 | ||
| 327 | static int __devinit ds1286_probe(struct platform_device *pdev) | 332 | static int __devinit ds1286_probe(struct platform_device *pdev) |
diff --git a/drivers/rtc/rtc-ds1305.c b/drivers/rtc/rtc-ds1305.c index 077af1d7b9e..57fbcc149ba 100644 --- a/drivers/rtc/rtc-ds1305.c +++ b/drivers/rtc/rtc-ds1305.c | |||
| @@ -139,49 +139,32 @@ static u8 hour2bcd(bool hr12, int hour) | |||
| 139 | * Interface to RTC framework | 139 | * Interface to RTC framework |
| 140 | */ | 140 | */ |
| 141 | 141 | ||
| 142 | #ifdef CONFIG_RTC_INTF_DEV | 142 | static int ds1305_alarm_irq_enable(struct device *dev, unsigned int enabled) |
| 143 | |||
| 144 | /* | ||
| 145 | * Context: caller holds rtc->ops_lock (to protect ds1305->ctrl) | ||
| 146 | */ | ||
| 147 | static int ds1305_ioctl(struct device *dev, unsigned cmd, unsigned long arg) | ||
| 148 | { | 143 | { |
| 149 | struct ds1305 *ds1305 = dev_get_drvdata(dev); | 144 | struct ds1305 *ds1305 = dev_get_drvdata(dev); |
| 150 | u8 buf[2]; | 145 | u8 buf[2]; |
| 151 | int status = -ENOIOCTLCMD; | 146 | long err = -EINVAL; |
| 152 | 147 | ||
| 153 | buf[0] = DS1305_WRITE | DS1305_CONTROL; | 148 | buf[0] = DS1305_WRITE | DS1305_CONTROL; |
| 154 | buf[1] = ds1305->ctrl[0]; | 149 | buf[1] = ds1305->ctrl[0]; |
| 155 | 150 | ||
| 156 | switch (cmd) { | 151 | if (enabled) { |
| 157 | case RTC_AIE_OFF: | ||
| 158 | status = 0; | ||
| 159 | if (!(buf[1] & DS1305_AEI0)) | ||
| 160 | goto done; | ||
| 161 | buf[1] &= ~DS1305_AEI0; | ||
| 162 | break; | ||
| 163 | |||
| 164 | case RTC_AIE_ON: | ||
| 165 | status = 0; | ||
| 166 | if (ds1305->ctrl[0] & DS1305_AEI0) | 152 | if (ds1305->ctrl[0] & DS1305_AEI0) |
| 167 | goto done; | 153 | goto done; |
| 168 | buf[1] |= DS1305_AEI0; | 154 | buf[1] |= DS1305_AEI0; |
| 169 | break; | 155 | } else { |
| 170 | } | 156 | if (!(buf[1] & DS1305_AEI0)) |
| 171 | if (status == 0) { | 157 | goto done; |
| 172 | status = spi_write_then_read(ds1305->spi, buf, sizeof buf, | 158 | buf[1] &= ~DS1305_AEI0; |
| 173 | NULL, 0); | ||
| 174 | if (status >= 0) | ||
| 175 | ds1305->ctrl[0] = buf[1]; | ||
| 176 | } | 159 | } |
| 177 | 160 | err = spi_write_then_read(ds1305->spi, buf, sizeof buf, NULL, 0); | |
| 161 | if (err >= 0) | ||
| 162 | ds1305->ctrl[0] = buf[1]; | ||
| 178 | done: | 163 | done: |
| 179 | return status; | 164 | return err; |
| 165 | |||
| 180 | } | 166 | } |
| 181 | 167 | ||
| 182 | #else | ||
| 183 | #define ds1305_ioctl NULL | ||
| 184 | #endif | ||
| 185 | 168 | ||
| 186 | /* | 169 | /* |
| 187 | * Get/set of date and time is pretty normal. | 170 | * Get/set of date and time is pretty normal. |
| @@ -460,12 +443,12 @@ done: | |||
| 460 | #endif | 443 | #endif |
| 461 | 444 | ||
| 462 | static const struct rtc_class_ops ds1305_ops = { | 445 | static const struct rtc_class_ops ds1305_ops = { |
| 463 | .ioctl = ds1305_ioctl, | ||
| 464 | .read_time = ds1305_get_time, | 446 | .read_time = ds1305_get_time, |
| 465 | .set_time = ds1305_set_time, | 447 | .set_time = ds1305_set_time, |
| 466 | .read_alarm = ds1305_get_alarm, | 448 | .read_alarm = ds1305_get_alarm, |
| 467 | .set_alarm = ds1305_set_alarm, | 449 | .set_alarm = ds1305_set_alarm, |
| 468 | .proc = ds1305_proc, | 450 | .proc = ds1305_proc, |
| 451 | .alarm_irq_enable = ds1305_alarm_irq_enable, | ||
| 469 | }; | 452 | }; |
| 470 | 453 | ||
| 471 | static void ds1305_work(struct work_struct *work) | 454 | static void ds1305_work(struct work_struct *work) |
diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index 0d559b6416d..4724ba3acf1 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c | |||
| @@ -495,50 +495,27 @@ static int ds1337_set_alarm(struct device *dev, struct rtc_wkalrm *t) | |||
| 495 | return 0; | 495 | return 0; |
| 496 | } | 496 | } |
| 497 | 497 | ||
| 498 | static int ds1307_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) | 498 | static int ds1307_alarm_irq_enable(struct device *dev, unsigned int enabled) |
| 499 | { | 499 | { |
| 500 | struct i2c_client *client = to_i2c_client(dev); | 500 | struct i2c_client *client = to_i2c_client(dev); |
| 501 | struct ds1307 *ds1307 = i2c_get_clientdata(client); | 501 | struct ds1307 *ds1307 = i2c_get_clientdata(client); |
| 502 | int ret; | 502 | int ret; |
| 503 | 503 | ||
| 504 | switch (cmd) { | 504 | if (!test_bit(HAS_ALARM, &ds1307->flags)) |
| 505 | case RTC_AIE_OFF: | 505 | return -ENOTTY; |
| 506 | if (!test_bit(HAS_ALARM, &ds1307->flags)) | ||
| 507 | return -ENOTTY; | ||
| 508 | |||
| 509 | ret = i2c_smbus_read_byte_data(client, DS1337_REG_CONTROL); | ||
| 510 | if (ret < 0) | ||
| 511 | return ret; | ||
| 512 | |||
| 513 | ret &= ~DS1337_BIT_A1IE; | ||
| 514 | |||
| 515 | ret = i2c_smbus_write_byte_data(client, | ||
| 516 | DS1337_REG_CONTROL, ret); | ||
| 517 | if (ret < 0) | ||
| 518 | return ret; | ||
| 519 | |||
| 520 | break; | ||
| 521 | |||
| 522 | case RTC_AIE_ON: | ||
| 523 | if (!test_bit(HAS_ALARM, &ds1307->flags)) | ||
| 524 | return -ENOTTY; | ||
| 525 | 506 | ||
| 526 | ret = i2c_smbus_read_byte_data(client, DS1337_REG_CONTROL); | 507 | ret = i2c_smbus_read_byte_data(client, DS1337_REG_CONTROL); |
| 527 | if (ret < 0) | 508 | if (ret < 0) |
| 528 | return ret; | 509 | return ret; |
| 529 | 510 | ||
| 511 | if (enabled) | ||
| 530 | ret |= DS1337_BIT_A1IE; | 512 | ret |= DS1337_BIT_A1IE; |
| 513 | else | ||
| 514 | ret &= ~DS1337_BIT_A1IE; | ||
| 531 | 515 | ||
| 532 | ret = i2c_smbus_write_byte_data(client, | 516 | ret = i2c_smbus_write_byte_data(client, DS1337_REG_CONTROL, ret); |
| 533 | DS1337_REG_CONTROL, ret); | 517 | if (ret < 0) |
| 534 | if (ret < 0) | 518 | return ret; |
| 535 | return ret; | ||
| 536 | |||
| 537 | break; | ||
| 538 | |||
| 539 | default: | ||
| 540 | return -ENOIOCTLCMD; | ||
| 541 | } | ||
| 542 | 519 | ||
| 543 | return 0; | 520 | return 0; |
| 544 | } | 521 | } |
| @@ -548,7 +525,7 @@ static const struct rtc_class_ops ds13xx_rtc_ops = { | |||
| 548 | .set_time = ds1307_set_time, | 525 | .set_time = ds1307_set_time, |
| 549 | .read_alarm = ds1337_read_alarm, | 526 | .read_alarm = ds1337_read_alarm, |
| 550 | .set_alarm = ds1337_set_alarm, | 527 | .set_alarm = ds1337_set_alarm, |
| 551 | .ioctl = ds1307_ioctl, | 528 | .alarm_irq_enable = ds1307_alarm_irq_enable, |
| 552 | }; | 529 | }; |
| 553 | 530 | ||
| 554 | /*----------------------------------------------------------------------*/ | 531 | /*----------------------------------------------------------------------*/ |
diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c index 47fb6357c34..d834a63ec4b 100644 --- a/drivers/rtc/rtc-ds1374.c +++ b/drivers/rtc/rtc-ds1374.c | |||
| @@ -307,42 +307,25 @@ unlock: | |||
| 307 | mutex_unlock(&ds1374->mutex); | 307 | mutex_unlock(&ds1374->mutex); |
| 308 | } | 308 | } |
| 309 | 309 | ||
| 310 | static int ds1374_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) | 310 | static int ds1374_alarm_irq_enable(struct device *dev, unsigned int enabled) |
| 311 | { | 311 | { |
| 312 | struct i2c_client *client = to_i2c_client(dev); | 312 | struct i2c_client *client = to_i2c_client(dev); |
| 313 | struct ds1374 *ds1374 = i2c_get_clientdata(client); | 313 | struct ds1374 *ds1374 = i2c_get_clientdata(client); |
| 314 | int ret = -ENOIOCTLCMD; | 314 | int ret; |
| 315 | 315 | ||
| 316 | mutex_lock(&ds1374->mutex); | 316 | mutex_lock(&ds1374->mutex); |
| 317 | 317 | ||
| 318 | switch (cmd) { | 318 | ret = i2c_smbus_read_byte_data(client, DS1374_REG_CR); |
| 319 | case RTC_AIE_OFF: | 319 | if (ret < 0) |
| 320 | ret = i2c_smbus_read_byte_data(client, DS1374_REG_CR); | 320 | goto out; |
| 321 | if (ret < 0) | ||
| 322 | goto out; | ||
| 323 | |||
| 324 | ret &= ~DS1374_REG_CR_WACE; | ||
| 325 | |||
| 326 | ret = i2c_smbus_write_byte_data(client, DS1374_REG_CR, ret); | ||
| 327 | if (ret < 0) | ||
| 328 | goto out; | ||
| 329 | |||
| 330 | break; | ||
| 331 | |||
| 332 | case RTC_AIE_ON: | ||
| 333 | ret = i2c_smbus_read_byte_data(client, DS1374_REG_CR); | ||
| 334 | if (ret < 0) | ||
| 335 | goto out; | ||
| 336 | 321 | ||
| 322 | if (enabled) { | ||
| 337 | ret |= DS1374_REG_CR_WACE | DS1374_REG_CR_AIE; | 323 | ret |= DS1374_REG_CR_WACE | DS1374_REG_CR_AIE; |
| 338 | ret &= ~DS1374_REG_CR_WDALM; | 324 | ret &= ~DS1374_REG_CR_WDALM; |
| 339 | 325 | } else { | |
| 340 | ret = i2c_smbus_write_byte_data(client, DS1374_REG_CR, ret); | 326 | ret &= ~DS1374_REG_CR_WACE; |
| 341 | if (ret < 0) | ||
| 342 | goto out; | ||
| 343 | |||
| 344 | break; | ||
| 345 | } | 327 | } |
| 328 | ret = i2c_smbus_write_byte_data(client, DS1374_REG_CR, ret); | ||
| 346 | 329 | ||
| 347 | out: | 330 | out: |
| 348 | mutex_unlock(&ds1374->mutex); | 331 | mutex_unlock(&ds1374->mutex); |
| @@ -354,7 +337,7 @@ static const struct rtc_class_ops ds1374_rtc_ops = { | |||
| 354 | .set_time = ds1374_set_time, | 337 | .set_time = ds1374_set_time, |
| 355 | .read_alarm = ds1374_read_alarm, | 338 | .read_alarm = ds1374_read_alarm, |
| 356 | .set_alarm = ds1374_set_alarm, | 339 | .set_alarm = ds1374_set_alarm, |
| 357 | .ioctl = ds1374_ioctl, | 340 | .alarm_irq_enable = ds1374_alarm_irq_enable, |
| 358 | }; | 341 | }; |
| 359 | 342 | ||
| 360 | static int ds1374_probe(struct i2c_client *client, | 343 | static int ds1374_probe(struct i2c_client *client, |
diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c index 5a8daa35806..69fe664a222 100644 --- a/drivers/rtc/rtc-m41t80.c +++ b/drivers/rtc/rtc-m41t80.c | |||
| @@ -213,41 +213,27 @@ static int m41t80_rtc_set_time(struct device *dev, struct rtc_time *tm) | |||
| 213 | return m41t80_set_datetime(to_i2c_client(dev), tm); | 213 | return m41t80_set_datetime(to_i2c_client(dev), tm); |
| 214 | } | 214 | } |
| 215 | 215 | ||
| 216 | #if defined(CONFIG_RTC_INTF_DEV) || defined(CONFIG_RTC_INTF_DEV_MODULE) | 216 | static int m41t80_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) |
| 217 | static int | ||
| 218 | m41t80_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) | ||
| 219 | { | 217 | { |
| 220 | struct i2c_client *client = to_i2c_client(dev); | 218 | struct i2c_client *client = to_i2c_client(dev); |
| 221 | int rc; | 219 | int rc; |
| 222 | 220 | ||
| 223 | switch (cmd) { | ||
| 224 | case RTC_AIE_OFF: | ||
| 225 | case RTC_AIE_ON: | ||
| 226 | break; | ||
| 227 | default: | ||
| 228 | return -ENOIOCTLCMD; | ||
| 229 | } | ||
| 230 | |||
| 231 | rc = i2c_smbus_read_byte_data(client, M41T80_REG_ALARM_MON); | 221 | rc = i2c_smbus_read_byte_data(client, M41T80_REG_ALARM_MON); |
| 232 | if (rc < 0) | 222 | if (rc < 0) |
| 233 | goto err; | 223 | goto err; |
| 234 | switch (cmd) { | 224 | |
| 235 | case RTC_AIE_OFF: | 225 | if (enabled) |
| 236 | rc &= ~M41T80_ALMON_AFE; | ||
| 237 | break; | ||
| 238 | case RTC_AIE_ON: | ||
| 239 | rc |= M41T80_ALMON_AFE; | 226 | rc |= M41T80_ALMON_AFE; |
| 240 | break; | 227 | else |
| 241 | } | 228 | rc &= ~M41T80_ALMON_AFE; |
| 229 | |||
| 242 | if (i2c_smbus_write_byte_data(client, M41T80_REG_ALARM_MON, rc) < 0) | 230 | if (i2c_smbus_write_byte_data(client, M41T80_REG_ALARM_MON, rc) < 0) |
| 243 | goto err; | 231 | goto err; |
| 232 | |||
| 244 | return 0; | 233 | return 0; |
| 245 | err: | 234 | err: |
| 246 | return -EIO; | 235 | return -EIO; |
| 247 | } | 236 | } |
| 248 | #else | ||
| 249 | #define m41t80_rtc_ioctl NULL | ||
| 250 | #endif | ||
| 251 | 237 | ||
| 252 | static int m41t80_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *t) | 238 | static int m41t80_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *t) |
| 253 | { | 239 | { |
| @@ -374,7 +360,7 @@ static struct rtc_class_ops m41t80_rtc_ops = { | |||
| 374 | .read_alarm = m41t80_rtc_read_alarm, | 360 | .read_alarm = m41t80_rtc_read_alarm, |
| 375 | .set_alarm = m41t80_rtc_set_alarm, | 361 | .set_alarm = m41t80_rtc_set_alarm, |
| 376 | .proc = m41t80_rtc_proc, | 362 | .proc = m41t80_rtc_proc, |
| 377 | .ioctl = m41t80_rtc_ioctl, | 363 | .alarm_irq_enable = m41t80_rtc_alarm_irq_enable, |
| 378 | }; | 364 | }; |
| 379 | 365 | ||
| 380 | #if defined(CONFIG_RTC_INTF_SYSFS) || defined(CONFIG_RTC_INTF_SYSFS_MODULE) | 366 | #if defined(CONFIG_RTC_INTF_SYSFS) || defined(CONFIG_RTC_INTF_SYSFS_MODULE) |
diff --git a/drivers/rtc/rtc-m48t59.c b/drivers/rtc/rtc-m48t59.c index a99a0b554eb..3978f4caf72 100644 --- a/drivers/rtc/rtc-m48t59.c +++ b/drivers/rtc/rtc-m48t59.c | |||
| @@ -263,30 +263,21 @@ static int m48t59_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm) | |||
| 263 | /* | 263 | /* |
| 264 | * Handle commands from user-space | 264 | * Handle commands from user-space |
| 265 | */ | 265 | */ |
| 266 | static int m48t59_rtc_ioctl(struct device *dev, unsigned int cmd, | 266 | static int m48t59_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) |
| 267 | unsigned long arg) | ||
| 268 | { | 267 | { |
| 269 | struct platform_device *pdev = to_platform_device(dev); | 268 | struct platform_device *pdev = to_platform_device(dev); |
| 270 | struct m48t59_plat_data *pdata = pdev->dev.platform_data; | 269 | struct m48t59_plat_data *pdata = pdev->dev.platform_data; |
| 271 | struct m48t59_private *m48t59 = platform_get_drvdata(pdev); | 270 | struct m48t59_private *m48t59 = platform_get_drvdata(pdev); |
| 272 | unsigned long flags; | 271 | unsigned long flags; |
| 273 | int ret = 0; | ||
| 274 | 272 | ||
| 275 | spin_lock_irqsave(&m48t59->lock, flags); | 273 | spin_lock_irqsave(&m48t59->lock, flags); |
| 276 | switch (cmd) { | 274 | if (enabled) |
| 277 | case RTC_AIE_OFF: /* alarm interrupt off */ | ||
| 278 | M48T59_WRITE(0x00, M48T59_INTR); | ||
| 279 | break; | ||
| 280 | case RTC_AIE_ON: /* alarm interrupt on */ | ||
| 281 | M48T59_WRITE(M48T59_INTR_AFE, M48T59_INTR); | 275 | M48T59_WRITE(M48T59_INTR_AFE, M48T59_INTR); |
| 282 | break; | 276 | else |
| 283 | default: | 277 | M48T59_WRITE(0x00, M48T59_INTR); |
| 284 | ret = -ENOIOCTLCMD; | ||
| 285 | break; | ||
| 286 | } | ||
| 287 | spin_unlock_irqrestore(&m48t59->lock, flags); | 278 | spin_unlock_irqrestore(&m48t59->lock, flags); |
| 288 | 279 | ||
| 289 | return ret; | 280 | return 0; |
| 290 | } | 281 | } |
| 291 | 282 | ||
| 292 | static int m48t59_rtc_proc(struct device *dev, struct seq_file *seq) | 283 | static int m48t59_rtc_proc(struct device *dev, struct seq_file *seq) |
| @@ -330,12 +321,12 @@ static irqreturn_t m48t59_rtc_interrupt(int irq, void *dev_id) | |||
| 330 | } | 321 | } |
| 331 | 322 | ||
| 332 | static const struct rtc_class_ops m48t59_rtc_ops = { | 323 | static const struct rtc_class_ops m48t59_rtc_ops = { |
| 333 | .ioctl = m48t59_rtc_ioctl, | ||
| 334 | .read_time = m48t59_rtc_read_time, | 324 | .read_time = m48t59_rtc_read_time, |
| 335 | .set_time = m48t59_rtc_set_time, | 325 | .set_time = m48t59_rtc_set_time, |
| 336 | .read_alarm = m48t59_rtc_readalarm, | 326 | .read_alarm = m48t59_rtc_readalarm, |
| 337 | .set_alarm = m48t59_rtc_setalarm, | 327 | .set_alarm = m48t59_rtc_setalarm, |
| 338 | .proc = m48t59_rtc_proc, | 328 | .proc = m48t59_rtc_proc, |
| 329 | .alarm_irq_enable = m48t59_rtc_alarm_irq_enable, | ||
| 339 | }; | 330 | }; |
| 340 | 331 | ||
| 341 | static const struct rtc_class_ops m48t02_rtc_ops = { | 332 | static const struct rtc_class_ops m48t02_rtc_ops = { |
diff --git a/drivers/rtc/rtc-mrst.c b/drivers/rtc/rtc-mrst.c index bcd0cf63eb1..1db62db8469 100644 --- a/drivers/rtc/rtc-mrst.c +++ b/drivers/rtc/rtc-mrst.c | |||
| @@ -255,42 +255,21 @@ static int mrst_irq_set_state(struct device *dev, int enabled) | |||
| 255 | return 0; | 255 | return 0; |
| 256 | } | 256 | } |
| 257 | 257 | ||
| 258 | #if defined(CONFIG_RTC_INTF_DEV) || defined(CONFIG_RTC_INTF_DEV_MODULE) | ||
| 259 | |||
| 260 | /* Currently, the vRTC doesn't support UIE ON/OFF */ | 258 | /* Currently, the vRTC doesn't support UIE ON/OFF */ |
| 261 | static int | 259 | static int mrst_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) |
| 262 | mrst_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) | ||
| 263 | { | 260 | { |
| 264 | struct mrst_rtc *mrst = dev_get_drvdata(dev); | 261 | struct mrst_rtc *mrst = dev_get_drvdata(dev); |
| 265 | unsigned long flags; | 262 | unsigned long flags; |
| 266 | 263 | ||
| 267 | switch (cmd) { | ||
| 268 | case RTC_AIE_OFF: | ||
| 269 | case RTC_AIE_ON: | ||
| 270 | if (!mrst->irq) | ||
| 271 | return -EINVAL; | ||
| 272 | break; | ||
| 273 | default: | ||
| 274 | /* PIE ON/OFF is handled by mrst_irq_set_state() */ | ||
| 275 | return -ENOIOCTLCMD; | ||
| 276 | } | ||
| 277 | |||
| 278 | spin_lock_irqsave(&rtc_lock, flags); | 264 | spin_lock_irqsave(&rtc_lock, flags); |
| 279 | switch (cmd) { | 265 | if (enabled) |
| 280 | case RTC_AIE_OFF: /* alarm off */ | ||
| 281 | mrst_irq_disable(mrst, RTC_AIE); | ||
| 282 | break; | ||
| 283 | case RTC_AIE_ON: /* alarm on */ | ||
| 284 | mrst_irq_enable(mrst, RTC_AIE); | 266 | mrst_irq_enable(mrst, RTC_AIE); |
| 285 | break; | 267 | else |
| 286 | } | 268 | mrst_irq_disable(mrst, RTC_AIE); |
| 287 | spin_unlock_irqrestore(&rtc_lock, flags); | 269 | spin_unlock_irqrestore(&rtc_lock, flags); |
| 288 | return 0; | 270 | return 0; |
| 289 | } | 271 | } |
| 290 | 272 | ||
| 291 | #else | ||
| 292 | #define mrst_rtc_ioctl NULL | ||
| 293 | #endif | ||
| 294 | 273 | ||
| 295 | #if defined(CONFIG_RTC_INTF_PROC) || defined(CONFIG_RTC_INTF_PROC_MODULE) | 274 | #if defined(CONFIG_RTC_INTF_PROC) || defined(CONFIG_RTC_INTF_PROC_MODULE) |
| 296 | 275 | ||
| @@ -317,13 +296,13 @@ static int mrst_procfs(struct device *dev, struct seq_file *seq) | |||
| 317 | #endif | 296 | #endif |
| 318 | 297 | ||
| 319 | static const struct rtc_class_ops mrst_rtc_ops = { | 298 | static const struct rtc_class_ops mrst_rtc_ops = { |
| 320 | .ioctl = mrst_rtc_ioctl, | ||
| 321 | .read_time = mrst_read_time, | 299 | .read_time = mrst_read_time, |
| 322 | .set_time = mrst_set_time, | 300 | .set_time = mrst_set_time, |
| 323 | .read_alarm = mrst_read_alarm, | 301 | .read_alarm = mrst_read_alarm, |
| 324 | .set_alarm = mrst_set_alarm, | 302 | .set_alarm = mrst_set_alarm, |
| 325 | .proc = mrst_procfs, | 303 | .proc = mrst_procfs, |
| 326 | .irq_set_state = mrst_irq_set_state, | 304 | .irq_set_state = mrst_irq_set_state, |
| 305 | .alarm_irq_enable = mrst_rtc_alarm_irq_enable, | ||
| 327 | }; | 306 | }; |
| 328 | 307 | ||
| 329 | static struct mrst_rtc mrst_rtc; | 308 | static struct mrst_rtc mrst_rtc; |
diff --git a/drivers/rtc/rtc-mv.c b/drivers/rtc/rtc-mv.c index bcca4729855..60627a76451 100644 --- a/drivers/rtc/rtc-mv.c +++ b/drivers/rtc/rtc-mv.c | |||
| @@ -169,25 +169,19 @@ static int mv_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alm) | |||
| 169 | return 0; | 169 | return 0; |
| 170 | } | 170 | } |
| 171 | 171 | ||
| 172 | static int mv_rtc_ioctl(struct device *dev, unsigned int cmd, | 172 | static int mv_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) |
| 173 | unsigned long arg) | ||
| 174 | { | 173 | { |
| 175 | struct platform_device *pdev = to_platform_device(dev); | 174 | struct platform_device *pdev = to_platform_device(dev); |
| 176 | struct rtc_plat_data *pdata = platform_get_drvdata(pdev); | 175 | struct rtc_plat_data *pdata = platform_get_drvdata(pdev); |
| 177 | void __iomem *ioaddr = pdata->ioaddr; | 176 | void __iomem *ioaddr = pdata->ioaddr; |
| 178 | 177 | ||
| 179 | if (pdata->irq < 0) | 178 | if (pdata->irq < 0) |
| 180 | return -ENOIOCTLCMD; /* fall back into rtc-dev's emulation */ | 179 | return -EINVAL; /* fall back into rtc-dev's emulation */ |
| 181 | switch (cmd) { | 180 | |
| 182 | case RTC_AIE_OFF: | 181 | if (enabled) |
| 183 | writel(0, ioaddr + RTC_ALARM_INTERRUPT_MASK_REG_OFFS); | ||
| 184 | break; | ||
| 185 | case RTC_AIE_ON: | ||
| 186 | writel(1, ioaddr + RTC_ALARM_INTERRUPT_MASK_REG_OFFS); | 182 | writel(1, ioaddr + RTC_ALARM_INTERRUPT_MASK_REG_OFFS); |
| 187 | break; | 183 | else |
| 188 | default: | 184 | writel(0, ioaddr + RTC_ALARM_INTERRUPT_MASK_REG_OFFS); |
| 189 | return -ENOIOCTLCMD; | ||
| 190 | } | ||
| 191 | return 0; | 185 | return 0; |
| 192 | } | 186 | } |
| 193 | 187 | ||
| @@ -216,7 +210,7 @@ static const struct rtc_class_ops mv_rtc_alarm_ops = { | |||
| 216 | .set_time = mv_rtc_set_time, | 210 | .set_time = mv_rtc_set_time, |
| 217 | .read_alarm = mv_rtc_read_alarm, | 211 | .read_alarm = mv_rtc_read_alarm, |
| 218 | .set_alarm = mv_rtc_set_alarm, | 212 | .set_alarm = mv_rtc_set_alarm, |
| 219 | .ioctl = mv_rtc_ioctl, | 213 | .alarm_irq_enable = mv_rtc_alarm_irq_enable, |
| 220 | }; | 214 | }; |
| 221 | 215 | ||
| 222 | static int __devinit mv_rtc_probe(struct platform_device *pdev) | 216 | static int __devinit mv_rtc_probe(struct platform_device *pdev) |
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index e72b523c79a..b4dbf3a319b 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers/rtc/rtc-omap.c | |||
| @@ -143,8 +143,6 @@ omap_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) | |||
| 143 | u8 reg; | 143 | u8 reg; |
| 144 | 144 | ||
| 145 | switch (cmd) { | 145 | switch (cmd) { |
| 146 | case RTC_AIE_OFF: | ||
| 147 | case RTC_AIE_ON: | ||
| 148 | case RTC_UIE_OFF: | 146 | case RTC_UIE_OFF: |
| 149 | case RTC_UIE_ON: | 147 | case RTC_UIE_ON: |
| 150 | break; | 148 | break; |
| @@ -156,13 +154,6 @@ omap_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) | |||
| 156 | rtc_wait_not_busy(); | 154 | rtc_wait_not_busy(); |
| 157 | reg = rtc_read(OMAP_RTC_INTERRUPTS_REG); | 155 | reg = rtc_read(OMAP_RTC_INTERRUPTS_REG); |
| 158 | switch (cmd) { | 156 | switch (cmd) { |
| 159 | /* AIE = Alarm Interrupt Enable */ | ||
| 160 | case RTC_AIE_OFF: | ||
| 161 | reg &= ~OMAP_RTC_INTERRUPTS_IT_ALARM; | ||
| 162 | break; | ||
| 163 | case RTC_AIE_ON: | ||
| 164 | reg |= OMAP_RTC_INTERRUPTS_IT_ALARM; | ||
| 165 | break; | ||
| 166 | /* UIE = Update Interrupt Enable (1/second) */ | 157 | /* UIE = Update Interrupt Enable (1/second) */ |
| 167 | case RTC_UIE_OFF: | 158 | case RTC_UIE_OFF: |
| 168 | reg &= ~OMAP_RTC_INTERRUPTS_IT_TIMER; | 159 | reg &= ~OMAP_RTC_INTERRUPTS_IT_TIMER; |
| @@ -182,6 +173,24 @@ omap_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) | |||
| 182 | #define omap_rtc_ioctl NULL | 173 | #define omap_rtc_ioctl NULL |
| 183 | #endif | 174 | #endif |
| 184 | 175 | ||
| 176 | static int omap_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) | ||
| 177 | { | ||
| 178 | u8 reg; | ||
| 179 | |||
| 180 | local_irq_disable(); | ||
| 181 | rtc_wait_not_busy(); | ||
| 182 | reg = rtc_read(OMAP_RTC_INTERRUPTS_REG); | ||
| 183 | if (enabled) | ||
| 184 | reg |= OMAP_RTC_INTERRUPTS_IT_ALARM; | ||
| 185 | else | ||
| 186 | reg &= ~OMAP_RTC_INTERRUPTS_IT_ALARM; | ||
| 187 | rtc_wait_not_busy(); | ||
| 188 | rtc_write(reg, OMAP_RTC_INTERRUPTS_REG); | ||
| 189 | local_irq_enable(); | ||
| 190 | |||
| 191 | return 0; | ||
| 192 | } | ||
| 193 | |||
| 185 | /* this hardware doesn't support "don't care" alarm fields */ | 194 | /* this hardware doesn't support "don't care" alarm fields */ |
| 186 | static int tm2bcd(struct rtc_time *tm) | 195 | static int tm2bcd(struct rtc_time *tm) |
| 187 | { | 196 | { |
| @@ -309,6 +318,7 @@ static struct rtc_class_ops omap_rtc_ops = { | |||
| 309 | .set_time = omap_rtc_set_time, | 318 | .set_time = omap_rtc_set_time, |
| 310 | .read_alarm = omap_rtc_read_alarm, | 319 | .read_alarm = omap_rtc_read_alarm, |
| 311 | .set_alarm = omap_rtc_set_alarm, | 320 | .set_alarm = omap_rtc_set_alarm, |
| 321 | .alarm_irq_enable = omap_rtc_alarm_irq_enable, | ||
| 312 | }; | 322 | }; |
| 313 | 323 | ||
| 314 | static int omap_rtc_alarm; | 324 | static int omap_rtc_alarm; |
diff --git a/drivers/rtc/rtc-rs5c372.c b/drivers/rtc/rtc-rs5c372.c index dd14e202c2c..6aaa1550e3b 100644 --- a/drivers/rtc/rtc-rs5c372.c +++ b/drivers/rtc/rtc-rs5c372.c | |||
| @@ -299,14 +299,6 @@ rs5c_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) | |||
| 299 | if (rs5c->type == rtc_rs5c372a | 299 | if (rs5c->type == rtc_rs5c372a |
| 300 | && (buf & RS5C372A_CTRL1_SL1)) | 300 | && (buf & RS5C372A_CTRL1_SL1)) |
| 301 | return -ENOIOCTLCMD; | 301 | return -ENOIOCTLCMD; |
| 302 | case RTC_AIE_OFF: | ||
| 303 | case RTC_AIE_ON: | ||
| 304 | /* these irq management calls only make sense for chips | ||
| 305 | * which are wired up to an IRQ. | ||
| 306 | */ | ||
| 307 | if (!rs5c->has_irq) | ||
| 308 | return -ENOIOCTLCMD; | ||
| 309 | break; | ||
| 310 | default: | 302 | default: |
| 311 | return -ENOIOCTLCMD; | 303 | return -ENOIOCTLCMD; |
| 312 | } | 304 | } |
| @@ -317,12 +309,6 @@ rs5c_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) | |||
| 317 | 309 | ||
| 318 | addr = RS5C_ADDR(RS5C_REG_CTRL1); | 310 | addr = RS5C_ADDR(RS5C_REG_CTRL1); |
| 319 | switch (cmd) { | 311 | switch (cmd) { |
| 320 | case RTC_AIE_OFF: /* alarm off */ | ||
| 321 | buf &= ~RS5C_CTRL1_AALE; | ||
| 322 | break; | ||
| 323 | case RTC_AIE_ON: /* alarm on */ | ||
| 324 | buf |= RS5C_CTRL1_AALE; | ||
| 325 | break; | ||
| 326 | case RTC_UIE_OFF: /* update off */ | 312 | case RTC_UIE_OFF: /* update off */ |
| 327 | buf &= ~RS5C_CTRL1_CT_MASK; | 313 | buf &= ~RS5C_CTRL1_CT_MASK; |
| 328 | break; | 314 | break; |
| @@ -347,6 +333,39 @@ rs5c_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) | |||
| 347 | #endif | 333 | #endif |
| 348 | 334 | ||
| 349 | 335 | ||
| 336 | static int rs5c_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) | ||
| 337 | { | ||
| 338 | struct i2c_client *client = to_i2c_client(dev); | ||
| 339 | struct rs5c372 *rs5c = i2c_get_clientdata(client); | ||
| 340 | unsigned char buf; | ||
| 341 | int status, addr; | ||
| 342 | |||
| 343 | buf = rs5c->regs[RS5C_REG_CTRL1]; | ||
| 344 | |||
| 345 | if (!rs5c->has_irq) | ||
| 346 | return -EINVAL; | ||
| 347 | |||
| 348 | status = rs5c_get_regs(rs5c); | ||
| 349 | if (status < 0) | ||
| 350 | return status; | ||
| 351 | |||
| 352 | addr = RS5C_ADDR(RS5C_REG_CTRL1); | ||
| 353 | if (enabled) | ||
| 354 | buf |= RS5C_CTRL1_AALE; | ||
| 355 | else | ||
| 356 | buf &= ~RS5C_CTRL1_AALE; | ||
| 357 | |||
| 358 | if (i2c_smbus_write_byte_data(client, addr, buf) < 0) { | ||
| 359 | printk(KERN_WARNING "%s: can't update alarm\n", | ||
| 360 | rs5c->rtc->name); | ||
| 361 | status = -EIO; | ||
| 362 | } else | ||
| 363 | rs5c->regs[RS5C_REG_CTRL1] = buf; | ||
| 364 | |||
| 365 | return status; | ||
| 366 | } | ||
| 367 | |||
| 368 | |||
| 350 | /* NOTE: Since RTC_WKALM_{RD,SET} were originally defined for EFI, | 369 | /* NOTE: Since RTC_WKALM_{RD,SET} were originally defined for EFI, |
| 351 | * which only exposes a polled programming interface; and since | 370 | * which only exposes a polled programming interface; and since |
| 352 | * these calls map directly to those EFI requests; we don't demand | 371 | * these calls map directly to those EFI requests; we don't demand |
| @@ -466,6 +485,7 @@ static const struct rtc_class_ops rs5c372_rtc_ops = { | |||
| 466 | .set_time = rs5c372_rtc_set_time, | 485 | .set_time = rs5c372_rtc_set_time, |
| 467 | .read_alarm = rs5c_read_alarm, | 486 | .read_alarm = rs5c_read_alarm, |
| 468 | .set_alarm = rs5c_set_alarm, | 487 | .set_alarm = rs5c_set_alarm, |
| 488 | .alarm_irq_enable = rs5c_rtc_alarm_irq_enable, | ||
| 469 | }; | 489 | }; |
| 470 | 490 | ||
| 471 | #if defined(CONFIG_RTC_INTF_SYSFS) || defined(CONFIG_RTC_INTF_SYSFS_MODULE) | 491 | #if defined(CONFIG_RTC_INTF_SYSFS) || defined(CONFIG_RTC_INTF_SYSFS_MODULE) |
diff --git a/drivers/rtc/rtc-sa1100.c b/drivers/rtc/rtc-sa1100.c index 88ea52b8647..5dfe5ffcb0d 100644 --- a/drivers/rtc/rtc-sa1100.c +++ b/drivers/rtc/rtc-sa1100.c | |||
| @@ -314,16 +314,6 @@ static int sa1100_rtc_ioctl(struct device *dev, unsigned int cmd, | |||
| 314 | unsigned long arg) | 314 | unsigned long arg) |
| 315 | { | 315 | { |
| 316 | switch (cmd) { | 316 | switch (cmd) { |
| 317 | case RTC_AIE_OFF: | ||
| 318 | spin_lock_irq(&sa1100_rtc_lock); | ||
| 319 | RTSR &= ~RTSR_ALE; | ||
| 320 | spin_unlock_irq(&sa1100_rtc_lock); | ||
| 321 | return 0; | ||
| 322 | case RTC_AIE_ON: | ||
| 323 | spin_lock_irq(&sa1100_rtc_lock); | ||
| 324 | RTSR |= RTSR_ALE; | ||
| 325 | spin_unlock_irq(&sa1100_rtc_lock); | ||
| 326 | return 0; | ||
| 327 | case RTC_UIE_OFF: | 317 | case RTC_UIE_OFF: |
| 328 | spin_lock_irq(&sa1100_rtc_lock); | 318 | spin_lock_irq(&sa1100_rtc_lock); |
| 329 | RTSR &= ~RTSR_HZE; | 319 | RTSR &= ~RTSR_HZE; |
| @@ -338,6 +328,17 @@ static int sa1100_rtc_ioctl(struct device *dev, unsigned int cmd, | |||
| 338 | return -ENOIOCTLCMD; | 328 | return -ENOIOCTLCMD; |
| 339 | } | 329 | } |
| 340 | 330 | ||
| 331 | static int sa1100_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) | ||
| 332 | { | ||
| 333 | spin_lock_irq(&sa1100_rtc_lock); | ||
| 334 | if (enabled) | ||
| 335 | RTSR |= RTSR_ALE; | ||
| 336 | else | ||
| 337 | RTSR &= ~RTSR_ALE; | ||
| 338 | spin_unlock_irq(&sa1100_rtc_lock); | ||
| 339 | return 0; | ||
| 340 | } | ||
| 341 | |||
| 341 | static int sa1100_rtc_read_time(struct device *dev, struct rtc_time *tm) | 342 | static int sa1100_rtc_read_time(struct device *dev, struct rtc_time *tm) |
| 342 | { | 343 | { |
| 343 | rtc_time_to_tm(RCNR, tm); | 344 | rtc_time_to_tm(RCNR, tm); |
| @@ -410,6 +411,7 @@ static const struct rtc_class_ops sa1100_rtc_ops = { | |||
| 410 | .proc = sa1100_rtc_proc, | 411 | .proc = sa1100_rtc_proc, |
| 411 | .irq_set_freq = sa1100_irq_set_freq, | 412 | .irq_set_freq = sa1100_irq_set_freq, |
| 412 | .irq_set_state = sa1100_irq_set_state, | 413 | .irq_set_state = sa1100_irq_set_state, |
| 414 | .alarm_irq_enable = sa1100_rtc_alarm_irq_enable, | ||
| 413 | }; | 415 | }; |
| 414 | 416 | ||
| 415 | static int sa1100_rtc_probe(struct platform_device *pdev) | 417 | static int sa1100_rtc_probe(struct platform_device *pdev) |
diff --git a/drivers/rtc/rtc-sh.c b/drivers/rtc/rtc-sh.c index 06e41ed9323..93314a9e7fa 100644 --- a/drivers/rtc/rtc-sh.c +++ b/drivers/rtc/rtc-sh.c | |||
| @@ -350,10 +350,6 @@ static int sh_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) | |||
| 350 | unsigned int ret = 0; | 350 | unsigned int ret = 0; |
| 351 | 351 | ||
| 352 | switch (cmd) { | 352 | switch (cmd) { |
| 353 | case RTC_AIE_OFF: | ||
| 354 | case RTC_AIE_ON: | ||
| 355 | sh_rtc_setaie(dev, cmd == RTC_AIE_ON); | ||
| 356 | break; | ||
| 357 | case RTC_UIE_OFF: | 353 | case RTC_UIE_OFF: |
| 358 | rtc->periodic_freq &= ~PF_OXS; | 354 | rtc->periodic_freq &= ~PF_OXS; |
| 359 | sh_rtc_setcie(dev, 0); | 355 | sh_rtc_setcie(dev, 0); |
| @@ -369,6 +365,12 @@ static int sh_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) | |||
| 369 | return ret; | 365 | return ret; |
| 370 | } | 366 | } |
| 371 | 367 | ||
| 368 | static int sh_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) | ||
| 369 | { | ||
| 370 | sh_rtc_setaie(dev, enabled); | ||
| 371 | return 0; | ||
| 372 | } | ||
| 373 | |||
| 372 | static int sh_rtc_read_time(struct device *dev, struct rtc_time *tm) | 374 | static int sh_rtc_read_time(struct device *dev, struct rtc_time *tm) |
| 373 | { | 375 | { |
| 374 | struct platform_device *pdev = to_platform_device(dev); | 376 | struct platform_device *pdev = to_platform_device(dev); |
| @@ -604,6 +606,7 @@ static struct rtc_class_ops sh_rtc_ops = { | |||
| 604 | .irq_set_state = sh_rtc_irq_set_state, | 606 | .irq_set_state = sh_rtc_irq_set_state, |
| 605 | .irq_set_freq = sh_rtc_irq_set_freq, | 607 | .irq_set_freq = sh_rtc_irq_set_freq, |
| 606 | .proc = sh_rtc_proc, | 608 | .proc = sh_rtc_proc, |
| 609 | .alarm_irq_enable = sh_rtc_alarm_irq_enable, | ||
| 607 | }; | 610 | }; |
| 608 | 611 | ||
| 609 | static int __init sh_rtc_probe(struct platform_device *pdev) | 612 | static int __init sh_rtc_probe(struct platform_device *pdev) |
diff --git a/drivers/rtc/rtc-test.c b/drivers/rtc/rtc-test.c index 51725f7755b..a82d6fe9707 100644 --- a/drivers/rtc/rtc-test.c +++ b/drivers/rtc/rtc-test.c | |||
| @@ -50,24 +50,9 @@ static int test_rtc_proc(struct device *dev, struct seq_file *seq) | |||
| 50 | return 0; | 50 | return 0; |
| 51 | } | 51 | } |
| 52 | 52 | ||
| 53 | static int test_rtc_ioctl(struct device *dev, unsigned int cmd, | 53 | static int test_rtc_alarm_irq_enable(struct device *dev, unsigned int enable) |
| 54 | unsigned long arg) | ||
| 55 | { | 54 | { |
| 56 | /* We do support interrupts, they're generated | 55 | return 0; |
| 57 | * using the sysfs interface. | ||
| 58 | */ | ||
| 59 | switch (cmd) { | ||
| 60 | case RTC_PIE_ON: | ||
| 61 | case RTC_PIE_OFF: | ||
| 62 | case RTC_UIE_ON: | ||
| 63 | case RTC_UIE_OFF: | ||
| 64 | case RTC_AIE_ON: | ||
| 65 | case RTC_AIE_OFF: | ||
| 66 | return 0; | ||
| 67 | |||
| 68 | default: | ||
| 69 | return -ENOIOCTLCMD; | ||
| 70 | } | ||
| 71 | } | 56 | } |
| 72 | 57 | ||
| 73 | static const struct rtc_class_ops test_rtc_ops = { | 58 | static const struct rtc_class_ops test_rtc_ops = { |
| @@ -76,7 +61,7 @@ static const struct rtc_class_ops test_rtc_ops = { | |||
| 76 | .read_alarm = test_rtc_read_alarm, | 61 | .read_alarm = test_rtc_read_alarm, |
| 77 | .set_alarm = test_rtc_set_alarm, | 62 | .set_alarm = test_rtc_set_alarm, |
| 78 | .set_mmss = test_rtc_set_mmss, | 63 | .set_mmss = test_rtc_set_mmss, |
| 79 | .ioctl = test_rtc_ioctl, | 64 | .alarm_irq_enable = test_rtc_alarm_irq_enable, |
| 80 | }; | 65 | }; |
| 81 | 66 | ||
| 82 | static ssize_t test_irq_show(struct device *dev, | 67 | static ssize_t test_irq_show(struct device *dev, |
diff --git a/drivers/rtc/rtc-vr41xx.c b/drivers/rtc/rtc-vr41xx.c index c3244244e8c..769190ac6d1 100644 --- a/drivers/rtc/rtc-vr41xx.c +++ b/drivers/rtc/rtc-vr41xx.c | |||
| @@ -240,26 +240,6 @@ static int vr41xx_rtc_irq_set_state(struct device *dev, int enabled) | |||
| 240 | static int vr41xx_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) | 240 | static int vr41xx_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) |
| 241 | { | 241 | { |
| 242 | switch (cmd) { | 242 | switch (cmd) { |
| 243 | case RTC_AIE_ON: | ||
| 244 | spin_lock_irq(&rtc_lock); | ||
| 245 | |||
| 246 | if (!alarm_enabled) { | ||
| 247 | enable_irq(aie_irq); | ||
| 248 | alarm_enabled = 1; | ||
| 249 | } | ||
| 250 | |||
| 251 | spin_unlock_irq(&rtc_lock); | ||
| 252 | break; | ||
| 253 | case RTC_AIE_OFF: | ||
| 254 | spin_lock_irq(&rtc_lock); | ||
| 255 | |||
| 256 | if (alarm_enabled) { | ||
| 257 | disable_irq(aie_irq); | ||
| 258 | alarm_enabled = 0; | ||
| 259 | } | ||
| 260 | |||
| 261 | spin_unlock_irq(&rtc_lock); | ||
| 262 | break; | ||
| 263 | case RTC_EPOCH_READ: | 243 | case RTC_EPOCH_READ: |
| 264 | return put_user(epoch, (unsigned long __user *)arg); | 244 | return put_user(epoch, (unsigned long __user *)arg); |
| 265 | case RTC_EPOCH_SET: | 245 | case RTC_EPOCH_SET: |
| @@ -275,6 +255,24 @@ static int vr41xx_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long | |||
| 275 | return 0; | 255 | return 0; |
| 276 | } | 256 | } |
| 277 | 257 | ||
| 258 | static int vr41xx_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) | ||
| 259 | { | ||
| 260 | spin_lock_irq(&rtc_lock); | ||
| 261 | if (enabled) { | ||
| 262 | if (!alarm_enabled) { | ||
| 263 | enable_irq(aie_irq); | ||
| 264 | alarm_enabled = 1; | ||
| 265 | } | ||
| 266 | } else { | ||
| 267 | if (alarm_enabled) { | ||
| 268 | disable_irq(aie_irq); | ||
| 269 | alarm_enabled = 0; | ||
| 270 | } | ||
| 271 | } | ||
| 272 | spin_unlock_irq(&rtc_lock); | ||
| 273 | return 0; | ||
| 274 | } | ||
| 275 | |||
| 278 | static irqreturn_t elapsedtime_interrupt(int irq, void *dev_id) | 276 | static irqreturn_t elapsedtime_interrupt(int irq, void *dev_id) |
| 279 | { | 277 | { |
| 280 | struct platform_device *pdev = (struct platform_device *)dev_id; | 278 | struct platform_device *pdev = (struct platform_device *)dev_id; |
