aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/wireless/p54/p54.h1
-rw-r--r--drivers/net/wireless/p54/p54common.c18
-rw-r--r--drivers/net/wireless/rtl8187.h1
-rw-r--r--drivers/net/wireless/rtl8187_dev.c18
4 files changed, 9 insertions, 29 deletions
diff --git a/drivers/net/wireless/p54/p54.h b/drivers/net/wireless/p54/p54.h
index 8da4d302059..1da96fe5024 100644
--- a/drivers/net/wireless/p54/p54.h
+++ b/drivers/net/wireless/p54/p54.h
@@ -67,7 +67,6 @@ struct p54_common {
67 int (*open)(struct ieee80211_hw *dev); 67 int (*open)(struct ieee80211_hw *dev);
68 void (*stop)(struct ieee80211_hw *dev); 68 void (*stop)(struct ieee80211_hw *dev);
69 int mode; 69 int mode;
70 u16 seqno;
71 u16 rx_mtu; 70 u16 rx_mtu;
72 u8 headroom; 71 u8 headroom;
73 u8 tailroom; 72 u8 tailroom;
diff --git a/drivers/net/wireless/p54/p54common.c b/drivers/net/wireless/p54/p54common.c
index f8cdd88e010..7c37d3fc1e2 100644
--- a/drivers/net/wireless/p54/p54common.c
+++ b/drivers/net/wireless/p54/p54common.c
@@ -856,19 +856,6 @@ static int p54_tx(struct ieee80211_hw *dev, struct sk_buff *skb)
856 if (padding) 856 if (padding)
857 txhdr->align[0] = padding; 857 txhdr->align[0] = padding;
858 858
859 /* FIXME: The sequence that follows is needed for this driver to
860 * work with mac80211 since "mac80211: fix TX sequence numbers".
861 * As with the temporary code in rt2x00, changes will be needed
862 * to get proper sequence numbers on beacons. In addition, this
863 * patch places the sequence number in the hardware state, which
864 * limits us to a single virtual state.
865 */
866 if (info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ) {
867 if (info->flags & IEEE80211_TX_CTL_FIRST_FRAGMENT)
868 priv->seqno += 0x10;
869 ieee80211hdr->seq_ctrl &= cpu_to_le16(IEEE80211_SCTL_FRAG);
870 ieee80211hdr->seq_ctrl |= cpu_to_le16(priv->seqno);
871 }
872 /* modifies skb->cb and with it info, so must be last! */ 859 /* modifies skb->cb and with it info, so must be last! */
873 p54_assign_address(dev, skb, hdr, skb->len); 860 p54_assign_address(dev, skb, hdr, skb->len);
874 861
@@ -1392,6 +1379,11 @@ struct ieee80211_hw *p54_init_common(size_t priv_data_len)
1392 IEEE80211_HW_SIGNAL_DBM | 1379 IEEE80211_HW_SIGNAL_DBM |
1393 IEEE80211_HW_NOISE_DBM; 1380 IEEE80211_HW_NOISE_DBM;
1394 1381
1382 /*
1383 * XXX: when this driver gets support for any mode that
1384 * requires beacons (AP, MESH, IBSS) then it must
1385 * implement IEEE80211_TX_CTL_ASSIGN_SEQ.
1386 */
1395 dev->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION); 1387 dev->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
1396 1388
1397 dev->channel_change_time = 1000; /* TODO: find actual value */ 1389 dev->channel_change_time = 1000; /* TODO: find actual value */
diff --git a/drivers/net/wireless/rtl8187.h b/drivers/net/wireless/rtl8187.h
index e82bb4d289e..33725d0978b 100644
--- a/drivers/net/wireless/rtl8187.h
+++ b/drivers/net/wireless/rtl8187.h
@@ -100,7 +100,6 @@ struct rtl8187_priv {
100 struct usb_device *udev; 100 struct usb_device *udev;
101 u32 rx_conf; 101 u32 rx_conf;
102 u16 txpwr_base; 102 u16 txpwr_base;
103 u16 seqno;
104 u8 asic_rev; 103 u8 asic_rev;
105 u8 is_rtl8187b; 104 u8 is_rtl8187b;
106 enum { 105 enum {
diff --git a/drivers/net/wireless/rtl8187_dev.c b/drivers/net/wireless/rtl8187_dev.c
index 2c69ab37c65..16f2fe2d849 100644
--- a/drivers/net/wireless/rtl8187_dev.c
+++ b/drivers/net/wireless/rtl8187_dev.c
@@ -241,20 +241,6 @@ static int rtl8187_tx(struct ieee80211_hw *dev, struct sk_buff *skb)
241 ep = epmap[skb_get_queue_mapping(skb)]; 241 ep = epmap[skb_get_queue_mapping(skb)];
242 } 242 }
243 243
244 /* FIXME: The sequence that follows is needed for this driver to
245 * work with mac80211 since "mac80211: fix TX sequence numbers".
246 * As with the temporary code in rt2x00, changes will be needed
247 * to get proper sequence numbers on beacons. In addition, this
248 * patch places the sequence number in the hardware state, which
249 * limits us to a single virtual state.
250 */
251 if (info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ) {
252 if (info->flags & IEEE80211_TX_CTL_FIRST_FRAGMENT)
253 priv->seqno += 0x10;
254 ieee80211hdr->seq_ctrl &= cpu_to_le16(IEEE80211_SCTL_FRAG);
255 ieee80211hdr->seq_ctrl |= cpu_to_le16(priv->seqno);
256 }
257
258 info->driver_data[0] = dev; 244 info->driver_data[0] = dev;
259 info->driver_data[1] = urb; 245 info->driver_data[1] = urb;
260 246
@@ -1187,6 +1173,10 @@ static int __devinit rtl8187_probe(struct usb_interface *intf,
1187 dev->max_signal = 65; 1173 dev->max_signal = 65;
1188 } 1174 }
1189 1175
1176 /*
1177 * XXX: Once this driver supports anything that requires
1178 * beacons it must implement IEEE80211_TX_CTL_ASSIGN_SEQ.
1179 */
1190 dev->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION); 1180 dev->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
1191 1181
1192 if ((id->driver_info == DEVICE_RTL8187) && priv->is_rtl8187b) 1182 if ((id->driver_info == DEVICE_RTL8187) && priv->is_rtl8187b)