6 files changed, 76 insertions, 441 deletions

diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 8a8fa4d2d6a..6c0f1712f55 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -99,22 +99,6 @@ config TOUCHSCREEN_BITSY
           To compile this driver as a module, choose M here: the
           module will be called h3600_ts_input.
 
-config TOUCHSCREEN_CORGI
-        tristate "SharpSL (Corgi and Spitz series) touchscreen driver (DEPRECATED)"
-        depends on PXA_SHARPSL
-        select CORGI_SSP_DEPRECATED
-        help
-          Say Y here to enable the driver for the touchscreen on the
-          Sharp SL-C7xx and SL-Cxx00 series of PDAs.
-
-          If unsure, say N.
-
-          To compile this driver as a module, choose M here: the
-          module will be called corgi_ts.
-
-          NOTE: this driver is deprecated, try enable SPI and generic
-          ADS7846-based touchscreen driver.
-
 config TOUCHSCREEN_DA9034
         tristate "Touchscreen support for Dialog Semiconductor DA9034"
         depends on PMIC_DA903X
@@ -158,8 +142,8 @@ config TOUCHSCREEN_FUJITSU
           module will be called fujitsu-ts.
 
 config TOUCHSCREEN_S3C2410
-        tristate "Samsung S3C2410 touchscreen input driver"
-        depends on ARCH_S3C2410
+        tristate "Samsung S3C2410/generic touchscreen input driver"
+        depends on ARCH_S3C2410 || SAMSUNG_DEV_TS
         select S3C24XX_ADC
         help
           Say Y here if you have the s3c2410 touchscreen.
diff --git a/drivers/input/touchscreen/Makefile b/drivers/input/touchscreen/Makefile
index 7fef7d5cca2..41145d074de 100644
--- a/drivers/input/touchscreen/Makefile
+++ b/drivers/input/touchscreen/Makefile
@@ -12,7 +12,6 @@ obj-$(CONFIG_TOUCHSCREEN_AD7879)	+= ad7879.o
 obj-$(CONFIG_TOUCHSCREEN_ADS7846)       += ads7846.o
 obj-$(CONFIG_TOUCHSCREEN_ATMEL_TSADCC)  += atmel_tsadcc.o
 obj-$(CONFIG_TOUCHSCREEN_BITSY)         += h3600_ts_input.o
-obj-$(CONFIG_TOUCHSCREEN_CORGI)         += corgi_ts.o
 obj-$(CONFIG_TOUCHSCREEN_DYNAPRO)       += dynapro.o
 obj-$(CONFIG_TOUCHSCREEN_GUNZE)         += gunze.o
 obj-$(CONFIG_TOUCHSCREEN_EETI)          += eeti_ts.o
diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c
index e019d53d1ab..0d2d7e54b46 100644
--- a/drivers/input/touchscreen/ad7877.c
+++ b/drivers/input/touchscreen/ad7877.c
@@ -156,9 +156,14 @@ struct ser_req {
         u16                     reset;
         u16                     ref_on;
         u16                     command;
-        u16                     sample;
         struct spi_message      msg;
         struct spi_transfer     xfer[6];
+
+        /*
+         * DMA (thus cache coherency maintenance) requires the
+         * transfer buffers to live in their own cache lines.
+         */
+        u16 sample ____cacheline_aligned;
 };
 
 struct ad7877 {
@@ -182,8 +187,6 @@ struct ad7877 {
         u8                      averaging;
         u8                      pen_down_acc_interval;
 
-        u16                     conversion_data[AD7877_NR_SENSE];
-
         struct spi_transfer     xfer[AD7877_NR_SENSE + 2];
         struct spi_message      msg;
 
@@ -195,6 +198,12 @@ struct ad7877 {
         spinlock_t              lock;
         struct timer_list       timer;          /* P: lock */
         unsigned                pending:1;      /* P: lock */
+
+        /*
+         * DMA (thus cache coherency maintenance) requires the
+         * transfer buffers to live in their own cache lines.
+         */
+        u16 conversion_data[AD7877_NR_SENSE] ____cacheline_aligned;
 };
 
 static int gpio3;
diff --git a/drivers/input/touchscreen/corgi_ts.c b/drivers/input/touchscreen/corgi_ts.c
deleted file mode 100644
index 94a1919d439..00000000000
--- a/drivers/input/touchscreen/corgi_ts.c
+++ /dev/null
@@ -1,385 +0,0 @@
-/*
- *  Touchscreen driver for Sharp SL-C7xx and SL-Cxx00 models
- *
- *  Copyright (c) 2004-2005 Richard Purdie
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- */
-
-
-#include <linux/delay.h>
-#include <linux/platform_device.h>
-#include <linux/init.h>
-#include <linux/input.h>
-#include <linux/interrupt.h>
-#include <linux/module.h>
-#include <linux/slab.h>
-#include <linux/irq.h>
-
-#include <mach/sharpsl.h>
-#include <mach/hardware.h>
-#include <mach/pxa2xx-gpio.h>
-
-
-#define PWR_MODE_ACTIVE         0
-#define PWR_MODE_SUSPEND        1
-
-#define X_AXIS_MAX              3830
-#define X_AXIS_MIN              150
-#define Y_AXIS_MAX              3830
-#define Y_AXIS_MIN              190
-#define PRESSURE_MIN            0
-#define PRESSURE_MAX            15000
-
-struct ts_event {
-        short pressure;
-        short x;
-        short y;
-};
-
-struct corgi_ts {
-        struct input_dev *input;
-        struct timer_list timer;
-        struct ts_event tc;
-        int pendown;
-        int power_mode;
-        int irq_gpio;
-        struct corgits_machinfo *machinfo;
-};
-
-#ifdef CONFIG_PXA25x
-#define CCNT(a)         asm volatile ("mrc p14, 0, %0, C1, C0, 0" : "=r"(a))
-#define PMNC_GET(x)     asm volatile ("mrc p14, 0, %0, C0, C0, 0" : "=r"(x))
-#define PMNC_SET(x)     asm volatile ("mcr p14, 0, %0, C0, C0, 0" : : "r"(x))
-#endif
-#ifdef CONFIG_PXA27x
-#define CCNT(a)         asm volatile ("mrc p14, 0, %0, C1, C1, 0" : "=r"(a))
-#define PMNC_GET(x)     asm volatile ("mrc p14, 0, %0, C0, C1, 0" : "=r"(x))
-#define PMNC_SET(x)     asm volatile ("mcr p14, 0, %0, C0, C1, 0" : : "r"(x))
-#endif
-
-/* ADS7846 Touch Screen Controller bit definitions */
-#define ADSCTRL_PD0             (1u << 0)       /* PD0 */
-#define ADSCTRL_PD1             (1u << 1)       /* PD1 */
-#define ADSCTRL_DFR             (1u << 2)       /* SER/DFR */
-#define ADSCTRL_MOD             (1u << 3)       /* Mode */
-#define ADSCTRL_ADR_SH  4       /* Address setting */
-#define ADSCTRL_STS             (1u << 7)       /* Start Bit */
-
-/* External Functions */
-extern unsigned int get_clk_frequency_khz(int info);
-
-static unsigned long calc_waittime(struct corgi_ts *corgi_ts)
-{
-        unsigned long hsync_invperiod = corgi_ts->machinfo->get_hsync_invperiod();
-
-        if (hsync_invperiod)
-                return get_clk_frequency_khz(0)*1000/hsync_invperiod;
-        else
-                return 0;
-}
-
-static int sync_receive_data_send_cmd(struct corgi_ts *corgi_ts, int doRecive, int doSend,
-                unsigned int address, unsigned long wait_time)
-{
-        unsigned long timer1 = 0, timer2, pmnc = 0;
-        int pos = 0;
-
-        if (wait_time && doSend) {
-                PMNC_GET(pmnc);
-                if (!(pmnc & 0x01))
-                        PMNC_SET(0x01);
-
-                /* polling HSync */
-                corgi_ts->machinfo->wait_hsync();
-                /* get CCNT */
-                CCNT(timer1);
-        }
-
-        if (doRecive)
-                pos = corgi_ssp_ads7846_get();
-
-        if (doSend) {
-                int cmd = ADSCTRL_PD0 | ADSCTRL_PD1 | (address << ADSCTRL_ADR_SH) | ADSCTRL_STS;
-                /* dummy command */
-                corgi_ssp_ads7846_put(cmd);
-                corgi_ssp_ads7846_get();
-
-                if (wait_time) {
-                        /* Wait after HSync */
-                        CCNT(timer2);
-                        if (timer2-timer1 > wait_time) {
-                                /* too slow - timeout, try again */
-                                corgi_ts->machinfo->wait_hsync();
-                                /* get CCNT */
-                                CCNT(timer1);
-                                /* Wait after HSync */
-                                CCNT(timer2);
-                        }
-                        while (timer2 - timer1 < wait_time)
-                                CCNT(timer2);
-                }
-                corgi_ssp_ads7846_put(cmd);
-                if (wait_time && !(pmnc & 0x01))
-                        PMNC_SET(pmnc);
-        }
-        return pos;
-}
-
-static int read_xydata(struct corgi_ts *corgi_ts)
-{
-        unsigned int x, y, z1, z2;
-        unsigned long flags, wait_time;
-
-        /* critical section */
-        local_irq_save(flags);
-        corgi_ssp_ads7846_lock();
-        wait_time = calc_waittime(corgi_ts);
-
-        /* Y-axis */
-        sync_receive_data_send_cmd(corgi_ts, 0, 1, 1u, wait_time);
-
-        /* Y-axis */
-        sync_receive_data_send_cmd(corgi_ts, 1, 1, 1u, wait_time);
-
-        /* X-axis */
-        y = sync_receive_data_send_cmd(corgi_ts, 1, 1, 5u, wait_time);
-
-        /* Z1 */
-        x = sync_receive_data_send_cmd(corgi_ts, 1, 1, 3u, wait_time);
-
-        /* Z2 */
-        z1 = sync_receive_data_send_cmd(corgi_ts, 1, 1, 4u, wait_time);
-        z2 = sync_receive_data_send_cmd(corgi_ts, 1, 0, 4u, wait_time);
-
-        /* Power-Down Enable */
-        corgi_ssp_ads7846_put((1u << ADSCTRL_ADR_SH) | ADSCTRL_STS);
-        corgi_ssp_ads7846_get();
-
-        corgi_ssp_ads7846_unlock();
-        local_irq_restore(flags);
-
-        if (x== 0 || y == 0 || z1 == 0 || (x * (z2 - z1) / z1) >= 15000) {
-                corgi_ts->tc.pressure = 0;
-                return 0;
-        }
-
-        corgi_ts->tc.x = x;
-        corgi_ts->tc.y = y;
-        corgi_ts->tc.pressure = (x * (z2 - z1)) / z1;
-        return 1;
-}
-
-static void new_data(struct corgi_ts *corgi_ts)
-{
-        struct input_dev *dev = corgi_ts->input;
-
-        if (corgi_ts->power_mode != PWR_MODE_ACTIVE)
-                return;
-
-        if (!corgi_ts->tc.pressure && corgi_ts->pendown == 0)
-                return;
-
-        input_report_abs(dev, ABS_X, corgi_ts->tc.x);
-        input_report_abs(dev, ABS_Y, corgi_ts->tc.y);
-        input_report_abs(dev, ABS_PRESSURE, corgi_ts->tc.pressure);
-        input_report_key(dev, BTN_TOUCH, corgi_ts->pendown);
-        input_sync(dev);
-}
-
-static void ts_interrupt_main(struct corgi_ts *corgi_ts, int isTimer)
-{
-        if ((GPLR(IRQ_TO_GPIO(corgi_ts->irq_gpio)) & GPIO_bit(IRQ_TO_GPIO(corgi_ts->irq_gpio))) == 0) {
-                /* Disable Interrupt */
-                set_irq_type(corgi_ts->irq_gpio, IRQ_TYPE_NONE);
-                if (read_xydata(corgi_ts)) {
-                        corgi_ts->pendown = 1;
-                        new_data(corgi_ts);
-                }
-                mod_timer(&corgi_ts->timer, jiffies + HZ / 100);
-        } else {
-                if (corgi_ts->pendown == 1 || corgi_ts->pendown == 2) {
-                        mod_timer(&corgi_ts->timer, jiffies + HZ / 100);
-                        corgi_ts->pendown++;
-                        return;
-                }
-
-                if (corgi_ts->pendown) {
-                        corgi_ts->tc.pressure = 0;
-                        new_data(corgi_ts);
-                }
-
-                /* Enable Falling Edge */
-                set_irq_type(corgi_ts->irq_gpio, IRQ_TYPE_EDGE_FALLING);
-                corgi_ts->pendown = 0;
-        }
-}
-
-static void corgi_ts_timer(unsigned long data)
-{
-        struct corgi_ts *corgits_data = (struct corgi_ts *) data;
-
-        ts_interrupt_main(corgits_data, 1);
-}
-
-static irqreturn_t ts_interrupt(int irq, void *dev_id)
-{
-        struct corgi_ts *corgits_data = dev_id;
-
-        ts_interrupt_main(corgits_data, 0);
-        return IRQ_HANDLED;
-}
-
-#ifdef CONFIG_PM
-static int corgits_suspend(struct platform_device *dev, pm_message_t state)
-{
-        struct corgi_ts *corgi_ts = platform_get_drvdata(dev);
-
-        if (corgi_ts->pendown) {
-                del_timer_sync(&corgi_ts->timer);
-                corgi_ts->tc.pressure = 0;
-                new_data(corgi_ts);
-                corgi_ts->pendown = 0;
-        }
-        corgi_ts->power_mode = PWR_MODE_SUSPEND;
-
-        corgi_ssp_ads7846_putget((1u << ADSCTRL_ADR_SH) | ADSCTRL_STS);
-
-        return 0;
-}
-
-static int corgits_resume(struct platform_device *dev)
-{
-        struct corgi_ts *corgi_ts = platform_get_drvdata(dev);
-
-        corgi_ssp_ads7846_putget((4u << ADSCTRL_ADR_SH) | ADSCTRL_STS);
-        /* Enable Falling Edge */
-        set_irq_type(corgi_ts->irq_gpio, IRQ_TYPE_EDGE_FALLING);
-        corgi_ts->power_mode = PWR_MODE_ACTIVE;
-
-        return 0;
-}
-#else
-#define corgits_suspend         NULL
-#define corgits_resume          NULL
-#endif
-
-static int __devinit corgits_probe(struct platform_device *pdev)
-{
-        struct corgi_ts *corgi_ts;
-        struct input_dev *input_dev;
-        int err = -ENOMEM;
-
-        corgi_ts = kzalloc(sizeof(struct corgi_ts), GFP_KERNEL);
-        input_dev = input_allocate_device();
-        if (!corgi_ts || !input_dev)
-                goto fail1;
-
-        platform_set_drvdata(pdev, corgi_ts);
-
-        corgi_ts->machinfo = pdev->dev.platform_data;
-        corgi_ts->irq_gpio = platform_get_irq(pdev, 0);
-
-        if (corgi_ts->irq_gpio < 0) {
-                err = -ENODEV;
-                goto fail1;
-        }
-
-        corgi_ts->input = input_dev;
-
-        init_timer(&corgi_ts->timer);
-        corgi_ts->timer.data = (unsigned long) corgi_ts;
-        corgi_ts->timer.function = corgi_ts_timer;
-
-        input_dev->name = "Corgi Touchscreen";
-        input_dev->phys = "corgits/input0";
-        input_dev->id.bustype = BUS_HOST;
-        input_dev->id.vendor = 0x0001;
-        input_dev->id.product = 0x0002;
-        input_dev->id.version = 0x0100;
-        input_dev->dev.parent = &pdev->dev;
-
-        input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
-        input_dev->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
-        input_set_abs_params(input_dev, ABS_X, X_AXIS_MIN, X_AXIS_MAX, 0, 0);
-        input_set_abs_params(input_dev, ABS_Y, Y_AXIS_MIN, Y_AXIS_MAX, 0, 0);
-        input_set_abs_params(input_dev, ABS_PRESSURE, PRESSURE_MIN, PRESSURE_MAX, 0, 0);
-
-        pxa_gpio_mode(IRQ_TO_GPIO(corgi_ts->irq_gpio) | GPIO_IN);
-
-        /* Initiaize ADS7846 Difference Reference mode */
-        corgi_ssp_ads7846_putget((1u << ADSCTRL_ADR_SH) | ADSCTRL_STS);
-        mdelay(5);
-        corgi_ssp_ads7846_putget((3u << ADSCTRL_ADR_SH) | ADSCTRL_STS);
-        mdelay(5);
-        corgi_ssp_ads7846_putget((4u << ADSCTRL_ADR_SH) | ADSCTRL_STS);
-        mdelay(5);
-        corgi_ssp_ads7846_putget((5u << ADSCTRL_ADR_SH) | ADSCTRL_STS);
-        mdelay(5);
-
-        if (request_irq(corgi_ts->irq_gpio, ts_interrupt, IRQF_DISABLED, "ts", corgi_ts)) {
-                err = -EBUSY;
-                goto fail1;
-        }
-
-        err = input_register_device(corgi_ts->input);
-        if (err)
-                goto fail2;
-
-        corgi_ts->power_mode = PWR_MODE_ACTIVE;
-
-        /* Enable Falling Edge */
-        set_irq_type(corgi_ts->irq_gpio, IRQ_TYPE_EDGE_FALLING);
-
-        return 0;
-
- fail2: free_irq(corgi_ts->irq_gpio, corgi_ts);
- fail1: input_free_device(input_dev);
-        kfree(corgi_ts);
-        return err;
-}
-
-static int __devexit corgits_remove(struct platform_device *pdev)
-{
-        struct corgi_ts *corgi_ts = platform_get_drvdata(pdev);
-
-        free_irq(corgi_ts->irq_gpio, corgi_ts);
-        del_timer_sync(&corgi_ts->timer);
-        corgi_ts->machinfo->put_hsync();
-        input_unregister_device(corgi_ts->input);
-        kfree(corgi_ts);
-
-        return 0;
-}
-
-static struct platform_driver corgits_driver = {
-        .probe          = corgits_probe,
-        .remove         = __devexit_p(corgits_remove),
-        .suspend        = corgits_suspend,
-        .resume         = corgits_resume,
-        .driver         = {
-                .name   = "corgi-ts",
-                .owner  = THIS_MODULE,
-        },
-};
-
-static int __init corgits_init(void)
-{
-        return platform_driver_register(&corgits_driver);
-}
-
-static void __exit corgits_exit(void)
-{
-        platform_driver_unregister(&corgits_driver);
-}
-
-module_init(corgits_init);
-module_exit(corgits_exit);
-
-MODULE_AUTHOR("Richard Purdie <rpurdie@rpsys.net>");
-MODULE_DESCRIPTION("Corgi TouchScreen Driver");
-MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:corgi-ts");
diff --git a/drivers/input/touchscreen/eeti_ts.c b/drivers/input/touchscreen/eeti_ts.c
index 204b8a1a601..75f8b73010f 100644
--- a/drivers/input/touchscreen/eeti_ts.c
+++ b/drivers/input/touchscreen/eeti_ts.c
@@ -124,14 +124,25 @@ static irqreturn_t eeti_ts_isr(int irq, void *dev_id)
         return IRQ_HANDLED;
 }
 
-static int eeti_ts_open(struct input_dev *dev)
+static void eeti_ts_start(struct eeti_ts_priv *priv)
 {
-        struct eeti_ts_priv *priv = input_get_drvdata(dev);
-
         enable_irq(priv->irq);
 
         /* Read the events once to arm the IRQ */
         eeti_ts_read(&priv->work);
+}
+
+static void eeti_ts_stop(struct eeti_ts_priv *priv)
+{
+        disable_irq(priv->irq);
+        cancel_work_sync(&priv->work);
+}
+
+static int eeti_ts_open(struct input_dev *dev)
+{
+        struct eeti_ts_priv *priv = input_get_drvdata(dev);
+
+        eeti_ts_start(priv);
 
         return 0;
 }
@@ -140,8 +151,7 @@ static void eeti_ts_close(struct input_dev *dev)
 {
         struct eeti_ts_priv *priv = input_get_drvdata(dev);
 
-        disable_irq(priv->irq);
-        cancel_work_sync(&priv->work);
+        eeti_ts_stop(priv);
 }
 
 static int __devinit eeti_ts_probe(struct i2c_client *client,
@@ -153,10 +163,12 @@ static int __devinit eeti_ts_probe(struct i2c_client *client,
         unsigned int irq_flags;
         int err = -ENOMEM;
 
-        /* In contrast to what's described in the datasheet, there seems
+        /*
+         * In contrast to what's described in the datasheet, there seems
          * to be no way of probing the presence of that device using I2C
          * commands. So we need to blindly believe it is there, and wait
-         * for interrupts to occur. */
+         * for interrupts to occur.
+         */
 
         priv = kzalloc(sizeof(*priv), GFP_KERNEL);
         if (!priv) {
@@ -212,9 +224,11 @@ static int __devinit eeti_ts_probe(struct i2c_client *client,
                 goto err2;
         }
 
-        /* Disable the irq for now. It will be enabled once the input device
-         * is opened. */
-        disable_irq(priv->irq);
+        /*
+         * Disable the device for now. It will be enabled once the
+         * input device is opened.
+         */
+        eeti_ts_stop(priv);
 
         device_init_wakeup(&client->dev, 0);
         return 0;
@@ -235,6 +249,12 @@ static int __devexit eeti_ts_remove(struct i2c_client *client)
         struct eeti_ts_priv *priv = i2c_get_clientdata(client);
 
         free_irq(priv->irq, priv);
+        /*
+         * eeti_ts_stop() leaves IRQ disabled. We need to re-enable it
+         * so that device still works if we reload the driver.
+         */
+        enable_irq(priv->irq);
+
         input_unregister_device(priv->input);
         i2c_set_clientdata(client, NULL);
         kfree(priv);
@@ -246,6 +266,14 @@ static int __devexit eeti_ts_remove(struct i2c_client *client)
 static int eeti_ts_suspend(struct i2c_client *client, pm_message_t mesg)
 {
         struct eeti_ts_priv *priv = i2c_get_clientdata(client);
+        struct input_dev *input_dev = priv->input;
+
+        mutex_lock(&input_dev->mutex);
+
+        if (input_dev->users)
+                eeti_ts_stop(priv);
+
+        mutex_unlock(&input_dev->mutex);
 
         if (device_may_wakeup(&client->dev))
                 enable_irq_wake(priv->irq);
@@ -256,10 +284,18 @@ static int eeti_ts_suspend(struct i2c_client *client, pm_message_t mesg)
 static int eeti_ts_resume(struct i2c_client *client)
 {
         struct eeti_ts_priv *priv = i2c_get_clientdata(client);
+        struct input_dev *input_dev = priv->input;
 
         if (device_may_wakeup(&client->dev))
                 disable_irq_wake(priv->irq);
 
+        mutex_lock(&input_dev->mutex);
+
+        if (input_dev->users)
+                eeti_ts_start(priv);
+
+        mutex_unlock(&input_dev->mutex);
+
         return 0;
 }
 #else
diff --git a/drivers/input/touchscreen/s3c2410_ts.c b/drivers/input/touchscreen/s3c2410_ts.c
index 98a7d127948..e0b7c834111 100644
--- a/drivers/input/touchscreen/s3c2410_ts.c
+++ b/drivers/input/touchscreen/s3c2410_ts.c
@@ -37,9 +37,7 @@
 
 #include <plat/adc.h>
 #include <plat/regs-adc.h>
-
-#include <mach/regs-gpio.h>
-#include <mach/ts.h>
+#include <plat/ts.h>
 
 #define TSC_SLEEP  (S3C2410_ADCTSC_PULL_UP_DISABLE | S3C2410_ADCTSC_XY_PST(0))
 
@@ -57,6 +55,8 @@
                          S3C2410_ADCTSC_AUTO_PST | \
                          S3C2410_ADCTSC_XY_PST(0))
 
+#define FEAT_PEN_IRQ    (1 << 0)        /* HAS ADCCLRINTPNDNUP */
+
 /* Per-touchscreen data. */
 
 /**
@@ -71,6 +71,7 @@
  * @irq_tc: The interrupt number for pen up/down interrupt
  * @count: The number of samples collected.
  * @shift: The log2 of the maximum count to read in one go.
+ * @features: The features supported by the TSADC MOdule.
  */
 struct s3c2410ts {
         struct s3c_adc_client *client;
@@ -83,26 +84,12 @@ struct s3c2410ts {
         int irq_tc;
         int count;
         int shift;
+        int features;
 };
 
 static struct s3c2410ts ts;
 
 /**
- * s3c2410_ts_connect - configure gpio for s3c2410 systems
- *
- * Configure the GPIO for the S3C2410 system, where we have external FETs
- * connected to the device (later systems such as the S3C2440 integrate
- * these into the device).
-*/
-static inline void s3c2410_ts_connect(void)
-{
-        s3c2410_gpio_cfgpin(S3C2410_GPG(12), S3C2410_GPG12_XMON);
-        s3c2410_gpio_cfgpin(S3C2410_GPG(13), S3C2410_GPG13_nXPON);
-        s3c2410_gpio_cfgpin(S3C2410_GPG(14), S3C2410_GPG14_YMON);
-        s3c2410_gpio_cfgpin(S3C2410_GPG(15), S3C2410_GPG15_nYPON);
-}
-
-/**
  * get_down - return the down state of the pen
  * @data0: The data read from ADCDAT0 register.
  * @data1: The data read from ADCDAT1 register.
@@ -188,6 +175,11 @@ static irqreturn_t stylus_irq(int irq, void *dev_id)
         else
                 dev_info(ts.dev, "%s: count=%d\n", __func__, ts.count);
 
+        if (ts.features & FEAT_PEN_IRQ) {
+                /* Clear pen down/up interrupt */
+                writel(0x0, ts.io + S3C64XX_ADCCLRINTPNDNUP);
+        }
+
         return IRQ_HANDLED;
 }
 
@@ -296,9 +288,9 @@ static int __devinit s3c2410ts_probe(struct platform_device *pdev)
                 goto err_clk;
         }
 
-        /* Configure the touchscreen external FETs on the S3C2410 */
-        if (!platform_get_device_id(pdev)->driver_data)
-                s3c2410_ts_connect();
+        /* inititalise the gpio */
+        if (info->cfg_gpio)
+                info->cfg_gpio(to_platform_device(ts.dev));
 
         ts.client = s3c_adc_register(pdev, s3c24xx_ts_select,
                                      s3c24xx_ts_conversion, 1);
@@ -334,6 +326,7 @@ static int __devinit s3c2410ts_probe(struct platform_device *pdev)
         ts.input->id.version = 0x0102;
 
         ts.shift = info->oversampling_shift;
+        ts.features = platform_get_device_id(pdev)->driver_data;
 
         ret = request_irq(ts.irq_tc, stylus_irq, IRQF_DISABLED,
                           "s3c2410_ts_pen", ts.input);
@@ -420,15 +413,14 @@ static struct dev_pm_ops s3c_ts_pmops = {
 #endif
 
 static struct platform_device_id s3cts_driver_ids[] = {
-        { "s3c2410-ts", 0 },
-        { "s3c2440-ts", 1 },
+        { "s3c64xx-ts", FEAT_PEN_IRQ },
         { }
 };
 MODULE_DEVICE_TABLE(platform, s3cts_driver_ids);
 
 static struct platform_driver s3c_ts_driver = {
         .driver         = {
-                .name   = "s3c24xx-ts",
+                .name   = "samsung-ts",
                 .owner  = THIS_MODULE,
 #ifdef CONFIG_PM
                 .pm     = &s3c_ts_pmops,