8 files changed, 91 insertions, 49 deletions

diff --git a/drivers/i2c/busses/i2c-amd756.c b/drivers/i2c/busses/i2c-amd756.c
index 2fa43183d37..43508d61eb7 100644
--- a/drivers/i2c/busses/i2c-amd756.c
+++ b/drivers/i2c/busses/i2c-amd756.c
@@ -290,7 +290,7 @@ static u32 amd756_func(struct i2c_adapter *adapter)
 {
         return I2C_FUNC_SMBUS_QUICK | I2C_FUNC_SMBUS_BYTE |
             I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA |
-            I2C_FUNC_SMBUS_BLOCK_DATA | I2C_FUNC_SMBUS_PROC_CALL;
+            I2C_FUNC_SMBUS_BLOCK_DATA;
 }
 
 static const struct i2c_algorithm smbus_algorithm = {
diff --git a/drivers/i2c/busses/i2c-au1550.c b/drivers/i2c/busses/i2c-au1550.c
index 491718fe46b..cae9dc89d88 100644
--- a/drivers/i2c/busses/i2c-au1550.c
+++ b/drivers/i2c/busses/i2c-au1550.c
@@ -335,7 +335,7 @@ i2c_au1550_probe(struct platform_device *pdev)
                 goto out_mem;
         }
 
-        priv->psc_base = r->start;
+        priv->psc_base = CKSEG1ADDR(r->start);
         priv->xfer_timeout = 200;
         priv->ack_timeout = 200;
 
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
index 18beb0ad7bf..a076129de7e 100644
--- a/drivers/i2c/busses/i2c-mpc.c
+++ b/drivers/i2c/busses/i2c-mpc.c
@@ -99,7 +99,7 @@ static int i2c_wait(struct mpc_i2c *i2c, unsigned timeout, int writing)
         u32 x;
         int result = 0;
 
-        if (i2c->irq == 0)
+        if (i2c->irq == NO_IRQ)
         {
                 while (!(readb(i2c->base + MPC_I2C_SR) & CSR_MIF)) {
                         schedule();
@@ -329,10 +329,9 @@ static int fsl_i2c_probe(struct platform_device *pdev)
                 return -ENOMEM;
 
         i2c->irq = platform_get_irq(pdev, 0);
-        if (i2c->irq < 0) {
-                result = -ENXIO;
-                goto fail_get_irq;
-        }
+        if (i2c->irq < 0)
+                i2c->irq = NO_IRQ; /* Use polling */
+
         i2c->flags = pdata->device_flags;
         init_waitqueue_head(&i2c->queue);
 
@@ -344,7 +343,7 @@ static int fsl_i2c_probe(struct platform_device *pdev)
                 goto fail_map;
         }
 
-        if (i2c->irq != 0)
+        if (i2c->irq != NO_IRQ)
                 if ((result = request_irq(i2c->irq, mpc_i2c_isr,
                                           IRQF_SHARED, "i2c-mpc", i2c)) < 0) {
                         printk(KERN_ERR
@@ -367,12 +366,11 @@ static int fsl_i2c_probe(struct platform_device *pdev)
         return result;
 
       fail_add:
-        if (i2c->irq != 0)
+        if (i2c->irq != NO_IRQ)
                 free_irq(i2c->irq, i2c);
       fail_irq:
         iounmap(i2c->base);
       fail_map:
-      fail_get_irq:
         kfree(i2c);
         return result;
 };
@@ -384,7 +382,7 @@ static int fsl_i2c_remove(struct platform_device *pdev)
         i2c_del_adapter(&i2c->adap);
         platform_set_drvdata(pdev, NULL);
 
-        if (i2c->irq != 0)
+        if (i2c->irq != NO_IRQ)
                 free_irq(i2c->irq, i2c);
 
         iounmap(i2c->base);
diff --git a/drivers/i2c/busses/i2c-nforce2.c b/drivers/i2c/busses/i2c-nforce2.c
index 3dac920e53e..43c9f8df950 100644
--- a/drivers/i2c/busses/i2c-nforce2.c
+++ b/drivers/i2c/busses/i2c-nforce2.c
@@ -50,6 +50,7 @@
 #include <linux/init.h>
 #include <linux/i2c.h>
 #include <linux/delay.h>
+#include <linux/dmi.h>
 #include <asm/io.h>
 
 MODULE_LICENSE("GPL");
@@ -109,6 +110,18 @@ struct nforce2_smbus {
 /* Misc definitions */
 #define MAX_TIMEOUT     100
 
+/* We disable the second SMBus channel on these boards */
+static struct dmi_system_id __devinitdata nforce2_dmi_blacklist2[] = {
+        {
+                .ident = "DFI Lanparty NF4 Expert",
+                .matches = {
+                        DMI_MATCH(DMI_BOARD_VENDOR, "DFI Corp,LTD"),
+                        DMI_MATCH(DMI_BOARD_NAME, "LP UT NF4 Expert"),
+                },
+        },
+        { }
+};
+
 static struct pci_driver nforce2_driver;
 
 static void nforce2_abort(struct i2c_adapter *adap)
@@ -367,10 +380,17 @@ static int __devinit nforce2_probe(struct pci_dev *dev, const struct pci_device_
                 smbuses[0].base = 0;    /* to have a check value */
         }
         /* SMBus adapter 2 */
-        res2 = nforce2_probe_smb(dev, 5, NFORCE_PCI_SMB2, &smbuses[1], "SMB2");
-        if (res2 < 0) {
-                dev_err(&dev->dev, "Error probing SMB2.\n");
-                smbuses[1].base = 0;    /* to have a check value */
+        if (dmi_check_system(nforce2_dmi_blacklist2)) {
+                dev_err(&dev->dev, "Disabling SMB2 for safety reasons.\n");
+                res2 = -EPERM;
+                smbuses[1].base = 0;
+        } else {
+                res2 = nforce2_probe_smb(dev, 5, NFORCE_PCI_SMB2, &smbuses[1],
+                                         "SMB2");
+                if (res2 < 0) {
+                        dev_err(&dev->dev, "Error probing SMB2.\n");
+                        smbuses[1].base = 0;    /* to have a check value */
+                }
         }
         if ((res1 < 0) && (res2 < 0)) {
                 /* we did not find even one of the SMBuses, so we give up */
diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
index fdc9ad805e3..ac916596858 100644
--- a/drivers/i2c/busses/i2c-piix4.c
+++ b/drivers/i2c/busses/i2c-piix4.c
@@ -104,10 +104,31 @@ MODULE_PARM_DESC(force_addr,
 static int piix4_transaction(void);
 
 static unsigned short piix4_smba;
+static int srvrworks_csb5_delay;
 static struct pci_driver piix4_driver;
 static struct i2c_adapter piix4_adapter;
 
-static struct dmi_system_id __devinitdata piix4_dmi_table[] = {
+static struct dmi_system_id __devinitdata piix4_dmi_blacklist[] = {
+        {
+                .ident = "Sapphire AM2RD790",
+                .matches = {
+                        DMI_MATCH(DMI_BOARD_VENDOR, "SAPPHIRE Inc."),
+                        DMI_MATCH(DMI_BOARD_NAME, "PC-AM2RD790"),
+                },
+        },
+        {
+                .ident = "DFI Lanparty UT 790FX",
+                .matches = {
+                        DMI_MATCH(DMI_BOARD_VENDOR, "DFI Inc."),
+                        DMI_MATCH(DMI_BOARD_NAME, "LP UT 790FX"),
+                },
+        },
+        { }
+};
+
+/* The IBM entry is in a separate table because we only check it
+   on Intel-based systems */
+static struct dmi_system_id __devinitdata piix4_dmi_ibm[] = {
         {
                 .ident = "IBM",
                 .matches = { DMI_MATCH(DMI_SYS_VENDOR, "IBM"), },
@@ -122,8 +143,20 @@ static int __devinit piix4_setup(struct pci_dev *PIIX4_dev,
 
         dev_info(&PIIX4_dev->dev, "Found %s device\n", pci_name(PIIX4_dev));
 
+        if ((PIIX4_dev->vendor == PCI_VENDOR_ID_SERVERWORKS) &&
+            (PIIX4_dev->device == PCI_DEVICE_ID_SERVERWORKS_CSB5))
+                srvrworks_csb5_delay = 1;
+
+        /* On some motherboards, it was reported that accessing the SMBus
+           caused severe hardware problems */
+        if (dmi_check_system(piix4_dmi_blacklist)) {
+                dev_err(&PIIX4_dev->dev,
+                        "Accessing the SMBus on this system is unsafe!\n");
+                return -EPERM;
+        }
+
         /* Don't access SMBus on IBM systems which get corrupted eeproms */
-        if (dmi_check_system(piix4_dmi_table) &&
+        if (dmi_check_system(piix4_dmi_ibm) &&
                         PIIX4_dev->vendor == PCI_VENDOR_ID_INTEL) {
                 dev_err(&PIIX4_dev->dev, "IBM system detected; this module "
                         "may corrupt your serial eeprom! Refusing to load "
@@ -230,10 +263,14 @@ static int piix4_transaction(void)
         outb_p(inb(SMBHSTCNT) | 0x040, SMBHSTCNT);
 
         /* We will always wait for a fraction of a second! (See PIIX4 docs errata) */
-        do {
+        if (srvrworks_csb5_delay) /* Extra delay for SERVERWORKS_CSB5 */
+                msleep(2);
+        else
+                msleep(1);
+
+        while ((timeout++ < MAX_TIMEOUT) &&
+               ((temp = inb_p(SMBHSTSTS)) & 0x01))
                 msleep(1);
-                temp = inb_p(SMBHSTSTS);
-        } while ((temp & 0x01) && (timeout++ < MAX_TIMEOUT));
 
         /* If the SMBus is still busy, we give up */
         if (timeout >= MAX_TIMEOUT) {
diff --git a/drivers/i2c/busses/i2c-sibyte.c b/drivers/i2c/busses/i2c-sibyte.c
index 8fbbdb4c2f3..114634da6c6 100644
--- a/drivers/i2c/busses/i2c-sibyte.c
+++ b/drivers/i2c/busses/i2c-sibyte.c
@@ -132,14 +132,14 @@ static const struct i2c_algorithm i2c_sibyte_algo = {
 /*
  * registering functions to load algorithms at runtime
  */
-int __init i2c_sibyte_add_bus(struct i2c_adapter *i2c_adap, int speed)
+static int __init i2c_sibyte_add_bus(struct i2c_adapter *i2c_adap, int speed)
 {
         struct i2c_algo_sibyte_data *adap = i2c_adap->algo_data;
 
-        /* register new adapter to i2c module... */
+        /* Register new adapter to i2c module... */
         i2c_adap->algo = &i2c_sibyte_algo;
 
-        /* Set the frequency to 100 kHz */
+        /* Set the requested frequency. */
         csr_out32(speed, SMB_CSR(adap,R_SMB_FREQ));
         csr_out32(0, SMB_CSR(adap,R_SMB_CONTROL));
 
diff --git a/drivers/i2c/chips/max6875.c b/drivers/i2c/chips/max6875.c
index fb7ea5637ec..cf507b3f60f 100644
--- a/drivers/i2c/chips/max6875.c
+++ b/drivers/i2c/chips/max6875.c
@@ -207,9 +207,6 @@ static int max6875_detect(struct i2c_adapter *adapter, int address, int kind)
         fake_client->flags = 0;
         strlcpy(fake_client->name, "max6875 subclient", I2C_NAME_SIZE);
 
-        /* Prevent 24RF08 corruption (in case of user error) */
-        i2c_smbus_write_quick(real_client, 0);
-
         if ((err = i2c_attach_client(real_client)) != 0)
                 goto exit_kfree2;
 
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 26384daccb9..d0175f4f8fc 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -74,10 +74,7 @@ static int i2c_device_match(struct device *dev, struct device_driver *drv)
         if (driver->id_table)
                 return i2c_match_id(driver->id_table, client) != NULL;
 
-        /* new style drivers use the same kind of driver matching policy
-         * as platform devices or SPI:  compare device and driver IDs.
-         */
-        return strcmp(client->driver_name, drv->name) == 0;
+        return 0;
 }
 
 #ifdef  CONFIG_HOTPLUG
@@ -91,14 +88,9 @@ static int i2c_device_uevent(struct device *dev, struct kobj_uevent_env *env)
         if (dev->driver)
                 return 0;
 
-        if (client->driver_name[0]) {
-                if (add_uevent_var(env, "MODALIAS=%s", client->driver_name))
-                        return -ENOMEM;
-        } else {
-                if (add_uevent_var(env, "MODALIAS=%s%s",
-                                   I2C_MODULE_PREFIX, client->name))
-                        return -ENOMEM;
-        }
+        if (add_uevent_var(env, "MODALIAS=%s%s",
+                           I2C_MODULE_PREFIX, client->name))
+                return -ENOMEM;
         dev_dbg(dev, "uevent\n");
         return 0;
 }
@@ -206,9 +198,7 @@ static ssize_t show_client_name(struct device *dev, struct device_attribute *att
 static ssize_t show_modalias(struct device *dev, struct device_attribute *attr, char *buf)
 {
         struct i2c_client *client = to_i2c_client(dev);
-        return client->driver_name[0]
-                ? sprintf(buf, "%s\n", client->driver_name)
-                : sprintf(buf, "%s%s\n", I2C_MODULE_PREFIX, client->name);
+        return sprintf(buf, "%s%s\n", I2C_MODULE_PREFIX, client->name);
 }
 
 static struct device_attribute i2c_dev_attrs[] = {
@@ -282,8 +272,6 @@ i2c_new_device(struct i2c_adapter *adap, struct i2c_board_info const *info)
         client->addr = info->addr;
         client->irq = info->irq;
 
-        strlcpy(client->driver_name, info->driver_name,
-                sizeof(client->driver_name));
         strlcpy(client->name, info->type, sizeof(client->name));
 
         /* a new style driver may be bound to this device when we
@@ -327,6 +315,11 @@ void i2c_unregister_device(struct i2c_client *client)
 EXPORT_SYMBOL_GPL(i2c_unregister_device);
 
 
+static const struct i2c_device_id dummy_id[] = {
+        { "dummy", 0 },
+        { },
+};
+
 static int dummy_probe(struct i2c_client *client,
                        const struct i2c_device_id *id)
 {
@@ -342,13 +335,13 @@ static struct i2c_driver dummy_driver = {
         .driver.name    = "dummy",
         .probe          = dummy_probe,
         .remove         = dummy_remove,
+        .id_table       = dummy_id,
 };
 
 /**
  * i2c_new_dummy - return a new i2c device bound to a dummy driver
  * @adapter: the adapter managing the device
  * @address: seven bit address to be used
- * @type: optional label used for i2c_client.name
  * Context: can sleep
  *
  * This returns an I2C client bound to the "dummy" driver, intended for use
@@ -364,15 +357,12 @@ static struct i2c_driver dummy_driver = {
  * i2c_unregister_device(); or NULL to indicate an error.
  */
 struct i2c_client *
-i2c_new_dummy(struct i2c_adapter *adapter, u16 address, const char *type)
+i2c_new_dummy(struct i2c_adapter *adapter, u16 address)
 {
         struct i2c_board_info info = {
-                .driver_name    = "dummy",
-                .addr           = address,
+                I2C_BOARD_INFO("dummy", address),
         };
 
-        if (type)
-                strlcpy(info.type, type, sizeof info.type);
         return i2c_new_device(adapter, &info);
 }
 EXPORT_SYMBOL_GPL(i2c_new_dummy);