1 files changed, 111 insertions, 128 deletions

diff --git a/arch/frv/kernel/signal.c b/arch/frv/kernel/signal.c
index d4ccc0728df..679c1d5cc95 100644
--- a/arch/frv/kernel/signal.c
+++ b/arch/frv/kernel/signal.c
@@ -35,74 +35,22 @@ struct fdpic_func_descriptor {
         unsigned long   GOT;
 };
 
-asmlinkage int do_signal(struct pt_regs *regs, sigset_t *oldset);
-
 /*
  * Atomically swap in the new signal mask, and wait for a signal.
  */
 asmlinkage int sys_sigsuspend(int history0, int history1, old_sigset_t mask)
 {
-        sigset_t saveset;
-
         mask &= _BLOCKABLE;
         spin_lock_irq(&current->sighand->siglock);
-        saveset = current->blocked;
+        current->saved_sigmask = current->blocked;
         siginitset(&current->blocked, mask);
         recalc_sigpending();
         spin_unlock_irq(&current->sighand->siglock);
 
-        __frame->gr8 = -EINTR;
-        while (1) {
-                current->state = TASK_INTERRUPTIBLE;
-                schedule();
-                if (do_signal(__frame, &saveset))
-                        /* return the signal number as the return value of this function
-                         * - this is an utterly evil hack. syscalls should not invoke do_signal()
-                         *   as entry.S sets regs->gr8 to the return value of the system call
-                         * - we can't just use sigpending() as we'd have to discard SIG_IGN signals
-                         *   and call waitpid() if SIGCHLD needed discarding
-                         * - this only works on the i386 because it passes arguments to the signal
-                         *   handler on the stack, and the return value in EAX is effectively
-                         *   discarded
-                         */
-                        return __frame->gr8;
-        }
-}
-
-asmlinkage int sys_rt_sigsuspend(sigset_t __user *unewset, size_t sigsetsize)
-{
-        sigset_t saveset, newset;
-
-        /* XXX: Don't preclude handling different sized sigset_t's.  */
-        if (sigsetsize != sizeof(sigset_t))
-                return -EINVAL;
-
-        if (copy_from_user(&newset, unewset, sizeof(newset)))
-                return -EFAULT;
-        sigdelsetmask(&newset, ~_BLOCKABLE);
-
-        spin_lock_irq(&current->sighand->siglock);
-        saveset = current->blocked;
-        current->blocked = newset;
-        recalc_sigpending();
-        spin_unlock_irq(&current->sighand->siglock);
-
-        __frame->gr8 = -EINTR;
-        while (1) {
-                current->state = TASK_INTERRUPTIBLE;
-                schedule();
-                if (do_signal(__frame, &saveset))
-                        /* return the signal number as the return value of this function
-                         * - this is an utterly evil hack. syscalls should not invoke do_signal()
-                         *   as entry.S sets regs->gr8 to the return value of the system call
-                         * - we can't just use sigpending() as we'd have to discard SIG_IGN signals
-                         *   and call waitpid() if SIGCHLD needed discarding
-                         * - this only works on the i386 because it passes arguments to the signal
-                         *   handler on the stack, and the return value in EAX is effectively
-                         *   discarded
-                         */
-                        return __frame->gr8;
-        }
+        current->state = TASK_INTERRUPTIBLE;
+        schedule();
+        set_thread_flag(TIF_RESTORE_SIGMASK);
+        return -ERESTARTNOHAND;
 }
 
 asmlinkage int sys_sigaction(int sig,
@@ -276,13 +224,12 @@ static int setup_sigcontext(struct sigcontext __user *sc, unsigned long mask)
  * Determine which stack to use..
  */
 static inline void __user *get_sigframe(struct k_sigaction *ka,
-                                        struct pt_regs *regs,
                                         size_t frame_size)
 {
         unsigned long sp;
 
         /* Default to using normal stack */
-        sp = regs->sp;
+        sp = __frame->sp;
 
         /* This is the X/Open sanctioned signal stack switching.  */
         if (ka->sa.sa_flags & SA_ONSTACK) {
@@ -291,18 +238,19 @@ static inline void __user *get_sigframe(struct k_sigaction *ka,
         }
 
         return (void __user *) ((sp - frame_size) & ~7UL);
+
 } /* end get_sigframe() */
 
 /*****************************************************************************/
 /*
  *
  */
-static void setup_frame(int sig, struct k_sigaction *ka, sigset_t *set, struct pt_regs * regs)
+static int setup_frame(int sig, struct k_sigaction *ka, sigset_t *set)
 {
         struct sigframe __user *frame;
         int rsig;
 
-        frame = get_sigframe(ka, regs, sizeof(*frame));
+        frame = get_sigframe(ka, sizeof(*frame));
 
         if (!access_ok(VERIFY_WRITE, frame, sizeof(*frame)))
                 goto give_sigsegv;
@@ -346,47 +294,51 @@ static void setup_frame(int sig, struct k_sigaction *ka, sigset_t *set, struct p
         }
 
         /* set up registers for signal handler */
-        regs->sp   = (unsigned long) frame;
-        regs->lr   = (unsigned long) &frame->retcode;
-        regs->gr8  = sig;
+        __frame->sp   = (unsigned long) frame;
+        __frame->lr   = (unsigned long) &frame->retcode;
+        __frame->gr8  = sig;
 
         if (get_personality & FDPIC_FUNCPTRS) {
                 struct fdpic_func_descriptor __user *funcptr =
                         (struct fdpic_func_descriptor *) ka->sa.sa_handler;
-                __get_user(regs->pc, &funcptr->text);
-                __get_user(regs->gr15, &funcptr->GOT);
+                __get_user(__frame->pc, &funcptr->text);
+                __get_user(__frame->gr15, &funcptr->GOT);
         } else {
-                regs->pc   = (unsigned long) ka->sa.sa_handler;
-                regs->gr15 = 0;
+                __frame->pc   = (unsigned long) ka->sa.sa_handler;
+                __frame->gr15 = 0;
         }
 
         set_fs(USER_DS);
 
+        /* the tracer may want to single-step inside the handler */
+        if (test_thread_flag(TIF_SINGLESTEP))
+                ptrace_notify(SIGTRAP);
+
 #if DEBUG_SIG
         printk("SIG deliver %d (%s:%d): sp=%p pc=%lx ra=%p\n",
-                sig, current->comm, current->pid, frame, regs->pc, frame->pretcode);
+               sig, current->comm, current->pid, frame, __frame->pc,
+               frame->pretcode);
 #endif
 
-        return;
+        return 0;
 
 give_sigsegv:
-        if (sig == SIGSEGV)
-                ka->sa.sa_handler = SIG_DFL;
-
         force_sig(SIGSEGV, current);
+        return -EFAULT;
+
 } /* end setup_frame() */
 
 /*****************************************************************************/
 /*
  *
  */
-static void setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
-                           sigset_t *set, struct pt_regs * regs)
+static int setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
+                          sigset_t *set)
 {
         struct rt_sigframe __user *frame;
         int rsig;
 
-        frame = get_sigframe(ka, regs, sizeof(*frame));
+        frame = get_sigframe(ka, sizeof(*frame));
 
         if (!access_ok(VERIFY_WRITE, frame, sizeof(*frame)))
                 goto give_sigsegv;
@@ -409,7 +361,7 @@ static void setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
         if (__put_user(0, &frame->uc.uc_flags) ||
             __put_user(0, &frame->uc.uc_link) ||
             __put_user((void*)current->sas_ss_sp, &frame->uc.uc_stack.ss_sp) ||
-            __put_user(sas_ss_flags(regs->sp), &frame->uc.uc_stack.ss_flags) ||
+            __put_user(sas_ss_flags(__frame->sp), &frame->uc.uc_stack.ss_flags) ||
             __put_user(current->sas_ss_size, &frame->uc.uc_stack.ss_size))
                 goto give_sigsegv;
 
@@ -440,34 +392,38 @@ static void setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
         }
 
         /* Set up registers for signal handler */
-        regs->sp  = (unsigned long) frame;
-        regs->lr   = (unsigned long) &frame->retcode;
-        regs->gr8 = sig;
-        regs->gr9 = (unsigned long) &frame->info;
+        __frame->sp  = (unsigned long) frame;
+        __frame->lr   = (unsigned long) &frame->retcode;
+        __frame->gr8 = sig;
+        __frame->gr9 = (unsigned long) &frame->info;
 
         if (get_personality & FDPIC_FUNCPTRS) {
                 struct fdpic_func_descriptor *funcptr =
                         (struct fdpic_func_descriptor __user *) ka->sa.sa_handler;
-                __get_user(regs->pc, &funcptr->text);
-                __get_user(regs->gr15, &funcptr->GOT);
+                __get_user(__frame->pc, &funcptr->text);
+                __get_user(__frame->gr15, &funcptr->GOT);
         } else {
-                regs->pc   = (unsigned long) ka->sa.sa_handler;
-                regs->gr15 = 0;
+                __frame->pc   = (unsigned long) ka->sa.sa_handler;
+                __frame->gr15 = 0;
         }
 
         set_fs(USER_DS);
 
+        /* the tracer may want to single-step inside the handler */
+        if (test_thread_flag(TIF_SINGLESTEP))
+                ptrace_notify(SIGTRAP);
+
 #if DEBUG_SIG
         printk("SIG deliver %d (%s:%d): sp=%p pc=%lx ra=%p\n",
-                sig, current->comm, current->pid, frame, regs->pc, frame->pretcode);
+               sig, current->comm, current->pid, frame, __frame->pc,
+               frame->pretcode);
 #endif
 
-        return;
+        return 0;
 
 give_sigsegv:
-        if (sig == SIGSEGV)
-                ka->sa.sa_handler = SIG_DFL;
         force_sig(SIGSEGV, current);
+        return -EFAULT;
 
 } /* end setup_rt_frame() */
 
@@ -475,43 +431,51 @@ give_sigsegv:
 /*
  * OK, we're invoking a handler
  */
-static void handle_signal(unsigned long sig, siginfo_t *info,
-                          struct k_sigaction *ka, sigset_t *oldset,
-                          struct pt_regs *regs)
+static int handle_signal(unsigned long sig, siginfo_t *info,
+                         struct k_sigaction *ka, sigset_t *oldset)
 {
+        int ret;
+
         /* Are we from a system call? */
-        if (in_syscall(regs)) {
+        if (in_syscall(__frame)) {
                 /* If so, check system call restarting.. */
-                switch (regs->gr8) {
+                switch (__frame->gr8) {
                 case -ERESTART_RESTARTBLOCK:
                 case -ERESTARTNOHAND:
-                        regs->gr8 = -EINTR;
+                        __frame->gr8 = -EINTR;
                         break;
 
                 case -ERESTARTSYS:
                         if (!(ka->sa.sa_flags & SA_RESTART)) {
-                                regs->gr8 = -EINTR;
+                                __frame->gr8 = -EINTR;
                                 break;
                         }
+
                         /* fallthrough */
                 case -ERESTARTNOINTR:
-                        regs->gr8 = regs->orig_gr8;
-                        regs->pc -= 4;
+                        __frame->gr8 = __frame->orig_gr8;
+                        __frame->pc -= 4;
                 }
         }
 
         /* Set up the stack frame */
         if (ka->sa.sa_flags & SA_SIGINFO)
-                setup_rt_frame(sig, ka, info, oldset, regs);
+                ret = setup_rt_frame(sig, ka, info, oldset);
         else
-                setup_frame(sig, ka, oldset, regs);
+                ret = setup_frame(sig, ka, oldset);
+
+        if (ret == 0) {
+                spin_lock_irq(&current->sighand->siglock);
+                sigorsets(&current->blocked, &current->blocked,
+                          &ka->sa.sa_mask);
+                if (!(ka->sa.sa_flags & SA_NODEFER))
+                        sigaddset(&current->blocked, sig);
+                recalc_sigpending();
+                spin_unlock_irq(&current->sighand->siglock);
+        }
+
+        return ret;
 
-        spin_lock_irq(&current->sighand->siglock);
-        sigorsets(&current->blocked, &current->blocked, &ka->sa.sa_mask);
-        if (!(ka->sa.sa_flags & SA_NODEFER))
-                sigaddset(&current->blocked, sig);
-        recalc_sigpending();
-        spin_unlock_irq(&current->sighand->siglock);
 } /* end handle_signal() */
 
 /*****************************************************************************/
@@ -520,10 +484,11 @@ static void handle_signal(unsigned long sig, siginfo_t *info,
  * want to handle. Thus you cannot kill init even with a SIGKILL even by
  * mistake.
  */
-int do_signal(struct pt_regs *regs, sigset_t *oldset)
+static void do_signal(void)
 {
         struct k_sigaction ka;
         siginfo_t info;
+        sigset_t *oldset;
         int signr;
 
         /*
@@ -532,45 +497,63 @@ int do_signal(struct pt_regs *regs, sigset_t *oldset)
          * kernel mode. Just return without doing anything
          * if so.
          */
-        if (!user_mode(regs))
-                return 1;
+        if (!user_mode(__frame))
+                return;
 
         if (try_to_freeze())
                 goto no_signal;
 
-        if (!oldset)
+        if (test_thread_flag(TIF_RESTORE_SIGMASK))
+                oldset = &current->saved_sigmask;
+        else
                 oldset = &current->blocked;
 
-        signr = get_signal_to_deliver(&info, &ka, regs, NULL);
+        signr = get_signal_to_deliver(&info, &ka, __frame, NULL);
         if (signr > 0) {
-                handle_signal(signr, &info, &ka, oldset, regs);
-                return 1;
+                if (handle_signal(signr, &info, &ka, oldset) == 0) {
+                        /* a signal was successfully delivered; the saved
+                         * sigmask will have been stored in the signal frame,
+                         * and will be restored by sigreturn, so we can simply
+                         * clear the TIF_RESTORE_SIGMASK flag */
+                        if (test_thread_flag(TIF_RESTORE_SIGMASK))
+                                clear_thread_flag(TIF_RESTORE_SIGMASK);
+                }
+
+                return;
         }
 
- no_signal:
+no_signal:
         /* Did we come from a system call? */
-        if (regs->syscallno >= 0) {
+        if (__frame->syscallno >= 0) {
                 /* Restart the system call - no handlers present */
-                if (regs->gr8 == -ERESTARTNOHAND ||
-                    regs->gr8 == -ERESTARTSYS ||
-                    regs->gr8 == -ERESTARTNOINTR) {
-                        regs->gr8 = regs->orig_gr8;
-                        regs->pc -= 4;
-                }
+                switch (__frame->gr8) {
+                case -ERESTARTNOHAND:
+                case -ERESTARTSYS:
+                case -ERESTARTNOINTR:
+                        __frame->gr8 = __frame->orig_gr8;
+                        __frame->pc -= 4;
+                        break;
 
-                if (regs->gr8 == -ERESTART_RESTARTBLOCK){
-                        regs->gr8 = __NR_restart_syscall;
-                        regs->pc -= 4;
+                case -ERESTART_RESTARTBLOCK:
+                        __frame->gr8 = __NR_restart_syscall;
+                        __frame->pc -= 4;
+                        break;
                 }
         }
 
-        return 0;
+        /* if there's no signal to deliver, we just put the saved sigmask
+         * back */
+        if (test_thread_flag(TIF_RESTORE_SIGMASK)) {
+                clear_thread_flag(TIF_RESTORE_SIGMASK);
+                sigprocmask(SIG_SETMASK, &current->saved_sigmask, NULL);
+        }
+
 } /* end do_signal() */
 
 /*****************************************************************************/
 /*
  * notification of userspace execution resumption
- * - triggered by current->work.notify_resume
+ * - triggered by the TIF_WORK_MASK flags
  */
 asmlinkage void do_notify_resume(__u32 thread_info_flags)
 {
@@ -579,7 +562,7 @@ asmlinkage void do_notify_resume(__u32 thread_info_flags)
                 clear_thread_flag(TIF_SINGLESTEP);
 
         /* deal with pending signal delivery */
-        if (thread_info_flags & _TIF_SIGPENDING)
-                do_signal(__frame, NULL);
+        if (thread_info_flags & (_TIF_SIGPENDING | _TIF_RESTORE_SIGMASK))
+                do_signal();
 
 } /* end do_notify_resume() */