aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--drivers/md/dm-log.c16
-rw-r--r--drivers/md/dm-raid1.c12
2 files changed, 14 insertions, 14 deletions
diff --git a/drivers/md/dm-log.c b/drivers/md/dm-log.c
index 691cb9c22b5..40ed70df673 100644
--- a/drivers/md/dm-log.c
+++ b/drivers/md/dm-log.c
@@ -360,6 +360,17 @@ static int read_header(struct log_c *log)
360 return 0; 360 return 0;
361} 361}
362 362
363static int _check_region_size(struct dm_target *ti, uint32_t region_size)
364{
365 if (region_size < 2 || region_size > ti->len)
366 return 0;
367
368 if (!is_power_of_2(region_size))
369 return 0;
370
371 return 1;
372}
373
363/*---------------------------------------------------------------- 374/*----------------------------------------------------------------
364 * core log constructor/destructor 375 * core log constructor/destructor
365 * 376 *
@@ -395,8 +406,9 @@ static int create_log_context(struct dm_dirty_log *log, struct dm_target *ti,
395 } 406 }
396 } 407 }
397 408
398 if (sscanf(argv[0], "%u", &region_size) != 1) { 409 if (sscanf(argv[0], "%u", &region_size) != 1 ||
399 DMWARN("invalid region size string"); 410 !_check_region_size(ti, region_size)) {
411 DMWARN("invalid region size %s", argv[0]);
400 return -EINVAL; 412 return -EINVAL;
401 } 413 }
402 414
diff --git a/drivers/md/dm-raid1.c b/drivers/md/dm-raid1.c
index 250f401668d..4d6bc101962 100644
--- a/drivers/md/dm-raid1.c
+++ b/drivers/md/dm-raid1.c
@@ -808,12 +808,6 @@ static void free_context(struct mirror_set *ms, struct dm_target *ti,
808 kfree(ms); 808 kfree(ms);
809} 809}
810 810
811static inline int _check_region_size(struct dm_target *ti, uint32_t size)
812{
813 return !(size % (PAGE_SIZE >> 9) || !is_power_of_2(size) ||
814 size > ti->len);
815}
816
817static int get_mirror(struct mirror_set *ms, struct dm_target *ti, 811static int get_mirror(struct mirror_set *ms, struct dm_target *ti,
818 unsigned int mirror, char **argv) 812 unsigned int mirror, char **argv)
819{ 813{
@@ -872,12 +866,6 @@ static struct dm_dirty_log *create_dirty_log(struct dm_target *ti,
872 return NULL; 866 return NULL;
873 } 867 }
874 868
875 if (!_check_region_size(ti, dl->type->get_region_size(dl))) {
876 ti->error = "Invalid region size";
877 dm_dirty_log_destroy(dl);
878 return NULL;
879 }
880
881 return dl; 869 return dl;
882} 870}
883 871