diff options
author | Christoph Hellwig <hch@infradead.org> | 2009-03-03 14:48:37 -0500 |
---|---|---|
committer | Felix Blyakher <felixb@sgi.com> | 2009-03-04 08:31:55 -0500 |
commit | b79631330a653f568a2ac4eb4a32474c80e3fe77 (patch) | |
tree | 4e8f3311b90005d8ff514828786172a353471502 /fs/xfs/linux-2.6/xfs_super.c | |
parent | ed93ec3907f063268ced18728d0653f6199d100c (diff) |
xfs: only issues a cache flush on unmount if barriers are enabled
Currently we unconditionally issue a flush from xfs_free_buftarg, but
since 2.6.29-rc1 this gives a warning in the style of
end_request: I/O error, dev vdb, sector 0
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: Felix Blyakher <felixb@sgi.com>
Diffstat (limited to 'fs/xfs/linux-2.6/xfs_super.c')
-rw-r--r-- | fs/xfs/linux-2.6/xfs_super.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/xfs_super.c index bc1e64708e2..8483b35821e 100644 --- a/fs/xfs/linux-2.6/xfs_super.c +++ b/fs/xfs/linux-2.6/xfs_super.c | |||
@@ -733,15 +733,15 @@ xfs_close_devices( | |||
733 | { | 733 | { |
734 | if (mp->m_logdev_targp && mp->m_logdev_targp != mp->m_ddev_targp) { | 734 | if (mp->m_logdev_targp && mp->m_logdev_targp != mp->m_ddev_targp) { |
735 | struct block_device *logdev = mp->m_logdev_targp->bt_bdev; | 735 | struct block_device *logdev = mp->m_logdev_targp->bt_bdev; |
736 | xfs_free_buftarg(mp->m_logdev_targp); | 736 | xfs_free_buftarg(mp, mp->m_logdev_targp); |
737 | xfs_blkdev_put(logdev); | 737 | xfs_blkdev_put(logdev); |
738 | } | 738 | } |
739 | if (mp->m_rtdev_targp) { | 739 | if (mp->m_rtdev_targp) { |
740 | struct block_device *rtdev = mp->m_rtdev_targp->bt_bdev; | 740 | struct block_device *rtdev = mp->m_rtdev_targp->bt_bdev; |
741 | xfs_free_buftarg(mp->m_rtdev_targp); | 741 | xfs_free_buftarg(mp, mp->m_rtdev_targp); |
742 | xfs_blkdev_put(rtdev); | 742 | xfs_blkdev_put(rtdev); |
743 | } | 743 | } |
744 | xfs_free_buftarg(mp->m_ddev_targp); | 744 | xfs_free_buftarg(mp, mp->m_ddev_targp); |
745 | } | 745 | } |
746 | 746 | ||
747 | /* | 747 | /* |
@@ -810,9 +810,9 @@ xfs_open_devices( | |||
810 | 810 | ||
811 | out_free_rtdev_targ: | 811 | out_free_rtdev_targ: |
812 | if (mp->m_rtdev_targp) | 812 | if (mp->m_rtdev_targp) |
813 | xfs_free_buftarg(mp->m_rtdev_targp); | 813 | xfs_free_buftarg(mp, mp->m_rtdev_targp); |
814 | out_free_ddev_targ: | 814 | out_free_ddev_targ: |
815 | xfs_free_buftarg(mp->m_ddev_targp); | 815 | xfs_free_buftarg(mp, mp->m_ddev_targp); |
816 | out_close_rtdev: | 816 | out_close_rtdev: |
817 | if (rtdev) | 817 | if (rtdev) |
818 | xfs_blkdev_put(rtdev); | 818 | xfs_blkdev_put(rtdev); |