diff options
author | Steven Whitehouse <swhiteho@redhat.com> | 2011-05-09 08:36:10 -0400 |
---|---|---|
committer | Steven Whitehouse <swhiteho@redhat.com> | 2011-05-09 11:44:29 -0400 |
commit | 94fb763b1a76a2000ad21f3119b05c90040acaf0 (patch) | |
tree | 72cb7fd210b8bb58e52403ba8c7fb35e93e2a5cc /fs/gfs2 | |
parent | 3d6ecb7d16fd4248fce58387a982a0756ad3fcc2 (diff) |
GFS2: Remove gfs2_dinode_print() function
This function was intended for debugging purposes, but it is not very
useful. If we want to know what is on disk then all we need is a
block number and gfs2_edit can give us much better information about
what is there. Otherwise, if we are interested in what is stored in
the in-core inode, it doesn't help us out there either.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2')
-rw-r--r-- | fs/gfs2/inode.c | 24 | ||||
-rw-r--r-- | fs/gfs2/inode.h | 1 | ||||
-rw-r--r-- | fs/gfs2/ops_inode.c | 3 | ||||
-rw-r--r-- | fs/gfs2/super.c | 3 |
4 files changed, 3 insertions, 28 deletions
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index a8c14c9985e..7c2121fe10d 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c | |||
@@ -329,8 +329,7 @@ static int gfs2_dinode_in(struct gfs2_inode *ip, const void *buf) | |||
329 | 329 | ||
330 | return 0; | 330 | return 0; |
331 | corrupt: | 331 | corrupt: |
332 | if (gfs2_consist_inode(ip)) | 332 | gfs2_consist_inode(ip); |
333 | gfs2_dinode_print(ip); | ||
334 | return -EIO; | 333 | return -EIO; |
335 | } | 334 | } |
336 | 335 | ||
@@ -901,24 +900,3 @@ void gfs2_dinode_out(const struct gfs2_inode *ip, void *buf) | |||
901 | str->di_mtime_nsec = cpu_to_be32(ip->i_inode.i_mtime.tv_nsec); | 900 | str->di_mtime_nsec = cpu_to_be32(ip->i_inode.i_mtime.tv_nsec); |
902 | str->di_ctime_nsec = cpu_to_be32(ip->i_inode.i_ctime.tv_nsec); | 901 | str->di_ctime_nsec = cpu_to_be32(ip->i_inode.i_ctime.tv_nsec); |
903 | } | 902 | } |
904 | |||
905 | void gfs2_dinode_print(const struct gfs2_inode *ip) | ||
906 | { | ||
907 | printk(KERN_INFO " no_formal_ino = %llu\n", | ||
908 | (unsigned long long)ip->i_no_formal_ino); | ||
909 | printk(KERN_INFO " no_addr = %llu\n", | ||
910 | (unsigned long long)ip->i_no_addr); | ||
911 | printk(KERN_INFO " i_size = %llu\n", | ||
912 | (unsigned long long)i_size_read(&ip->i_inode)); | ||
913 | printk(KERN_INFO " blocks = %llu\n", | ||
914 | (unsigned long long)gfs2_get_inode_blocks(&ip->i_inode)); | ||
915 | printk(KERN_INFO " i_goal = %llu\n", | ||
916 | (unsigned long long)ip->i_goal); | ||
917 | printk(KERN_INFO " i_diskflags = 0x%.8X\n", ip->i_diskflags); | ||
918 | printk(KERN_INFO " i_height = %u\n", ip->i_height); | ||
919 | printk(KERN_INFO " i_depth = %u\n", ip->i_depth); | ||
920 | printk(KERN_INFO " i_entries = %u\n", ip->i_entries); | ||
921 | printk(KERN_INFO " i_eattr = %llu\n", | ||
922 | (unsigned long long)ip->i_eattr); | ||
923 | } | ||
924 | |||
diff --git a/fs/gfs2/inode.h b/fs/gfs2/inode.h index f9b8289deec..7ed60aa1b61 100644 --- a/fs/gfs2/inode.h +++ b/fs/gfs2/inode.h | |||
@@ -115,7 +115,6 @@ extern int gfs2_permission(struct inode *inode, int mask, unsigned int flags); | |||
115 | extern int gfs2_setattr_simple(struct gfs2_inode *ip, struct iattr *attr); | 115 | extern int gfs2_setattr_simple(struct gfs2_inode *ip, struct iattr *attr); |
116 | extern struct inode *gfs2_lookup_simple(struct inode *dip, const char *name); | 116 | extern struct inode *gfs2_lookup_simple(struct inode *dip, const char *name); |
117 | extern void gfs2_dinode_out(const struct gfs2_inode *ip, void *buf); | 117 | extern void gfs2_dinode_out(const struct gfs2_inode *ip, void *buf); |
118 | extern void gfs2_dinode_print(const struct gfs2_inode *ip); | ||
119 | 118 | ||
120 | extern const struct inode_operations gfs2_file_iops; | 119 | extern const struct inode_operations gfs2_file_iops; |
121 | extern const struct inode_operations gfs2_dir_iops; | 120 | extern const struct inode_operations gfs2_dir_iops; |
diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c index 6b8c2bdb5a0..2607c2c6de2 100644 --- a/fs/gfs2/ops_inode.c +++ b/fs/gfs2/ops_inode.c | |||
@@ -754,8 +754,7 @@ static int gfs2_rename(struct inode *odir, struct dentry *odentry, | |||
754 | 754 | ||
755 | if (S_ISDIR(nip->i_inode.i_mode)) { | 755 | if (S_ISDIR(nip->i_inode.i_mode)) { |
756 | if (nip->i_entries < 2) { | 756 | if (nip->i_entries < 2) { |
757 | if (gfs2_consist_inode(nip)) | 757 | gfs2_consist_inode(nip); |
758 | gfs2_dinode_print(nip); | ||
759 | error = -EIO; | 758 | error = -EIO; |
760 | goto out_gunlock; | 759 | goto out_gunlock; |
761 | } | 760 | } |
diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index 58fe3a4ac82..3061ac64f81 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c | |||
@@ -1341,8 +1341,7 @@ static int gfs2_dinode_dealloc(struct gfs2_inode *ip) | |||
1341 | int error; | 1341 | int error; |
1342 | 1342 | ||
1343 | if (gfs2_get_inode_blocks(&ip->i_inode) != 1) { | 1343 | if (gfs2_get_inode_blocks(&ip->i_inode) != 1) { |
1344 | if (gfs2_consist_inode(ip)) | 1344 | gfs2_consist_inode(ip); |
1345 | gfs2_dinode_print(ip); | ||
1346 | return -EIO; | 1345 | return -EIO; |
1347 | } | 1346 | } |
1348 | 1347 | ||