diff options
author | Tejun Heo <htejun@gmail.com> | 2008-01-23 10:05:14 -0500 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-04-17 15:44:16 -0400 |
commit | b558edddb1c42c70a30cfe494984d4be409f7b2b (patch) | |
tree | b03275d15675a519de7d4edde709892f885a5fa0 /drivers/ata/libata-eh.c | |
parent | 8cebf274dd1c955a6e03385a85fd6569ce445946 (diff) |
libata: kill ata_ehi_schedule_probe()
ata_ehi_schedule_probe() was created to hide details of link-resuming
reset magic. Now that all the softreset workarounds are gone,
scheduling probe is very simple - set probe_mask and request RESET.
Kill ata_ehi_schedule_probe() and open code it. This also increases
consistency as ata_ehi_schedule_probe() couldn't cover individual
device probings so they were open-coded even when the helper existed.
While at it, define ATA_ALL_DEVICES as mask of all possible devices on
a link and always use it when requesting probe on link level for
simplicity and consistency. Setting extra bits in the probe_mask
doesn't hurt anybody.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Diffstat (limited to 'drivers/ata/libata-eh.c')
-rw-r--r-- | drivers/ata/libata-eh.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index e6584fa7f45..0d0a2c0ab9e 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c | |||
@@ -1746,7 +1746,7 @@ static void ata_eh_link_autopsy(struct ata_link *link) | |||
1746 | ata_eh_analyze_serror(link); | 1746 | ata_eh_analyze_serror(link); |
1747 | } else if (rc != -EOPNOTSUPP) { | 1747 | } else if (rc != -EOPNOTSUPP) { |
1748 | /* SError read failed, force reset and probing */ | 1748 | /* SError read failed, force reset and probing */ |
1749 | ata_ehi_schedule_probe(&ehc->i); | 1749 | ehc->i.probe_mask |= ATA_ALL_DEVICES; |
1750 | ehc->i.action |= ATA_EH_RESET; | 1750 | ehc->i.action |= ATA_EH_RESET; |
1751 | ehc->i.err_mask |= AC_ERR_OTHER; | 1751 | ehc->i.err_mask |= AC_ERR_OTHER; |
1752 | } | 1752 | } |