14 files changed, 67 insertions, 63 deletions

diff --git a/net/sunrpc/auth_generic.c b/net/sunrpc/auth_generic.c
index 75762f346975..6ed6f201b022 100644
--- a/net/sunrpc/auth_generic.c
+++ b/net/sunrpc/auth_generic.c
@@ -160,8 +160,8 @@ generic_match(struct auth_cred *acred, struct rpc_cred *cred, int flags)
         if (gcred->acred.group_info->ngroups != acred->group_info->ngroups)
                 goto out_nomatch;
         for (i = 0; i < gcred->acred.group_info->ngroups; i++) {
-                if (GROUP_AT(gcred->acred.group_info, i) !=
-                                GROUP_AT(acred->group_info, i))
+                if (!gid_eq(GROUP_AT(gcred->acred.group_info, i),
+                                GROUP_AT(acred->group_info, i)))
                         goto out_nomatch;
         }
 out_match:
diff --git a/net/sunrpc/auth_gss/gss_krb5_mech.c b/net/sunrpc/auth_gss/gss_krb5_mech.c
index 8eff8c32d1b9..d3611f11a8df 100644
--- a/net/sunrpc/auth_gss/gss_krb5_mech.c
+++ b/net/sunrpc/auth_gss/gss_krb5_mech.c
@@ -624,7 +624,7 @@ gss_import_v2_context(const void *p, const void *end, struct krb5_ctx *ctx,
         ctx->seq_send = ctx->seq_send64;
         if (ctx->seq_send64 != ctx->seq_send) {
                 dprintk("%s: seq_send64 %lx, seq_send %x overflow?\n", __func__,
-                        (long unsigned)ctx->seq_send64, ctx->seq_send);
+                        (unsigned long)ctx->seq_send64, ctx->seq_send);
                 p = ERR_PTR(-EINVAL);
                 goto out_err;
         }
diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
index 1600cfb1618c..28b62dbb6d1e 100644
--- a/net/sunrpc/auth_gss/svcauth_gss.c
+++ b/net/sunrpc/auth_gss/svcauth_gss.c
@@ -41,6 +41,7 @@
 #include <linux/types.h>
 #include <linux/module.h>
 #include <linux/pagemap.h>
+#include <linux/user_namespace.h>
 
 #include <linux/sunrpc/auth_gss.h>
 #include <linux/sunrpc/gss_err.h>
@@ -470,9 +471,13 @@ static int rsc_parse(struct cache_detail *cd,
                 status = -EINVAL;
                 for (i=0; i<N; i++) {
                         gid_t gid;
+                        kgid_t kgid;
                         if (get_int(&mesg, &gid))
                                 goto out;
-                        GROUP_AT(rsci.cred.cr_group_info, i) = gid;
+                        kgid = make_kgid(&init_user_ns, gid);
+                        if (!gid_valid(kgid))
+                                goto out;
+                        GROUP_AT(rsci.cred.cr_group_info, i) = kgid;
                 }
 
                 /* mech name */
diff --git a/net/sunrpc/auth_unix.c b/net/sunrpc/auth_unix.c
index e50502d8ceb7..52c5abdee211 100644
--- a/net/sunrpc/auth_unix.c
+++ b/net/sunrpc/auth_unix.c
@@ -12,6 +12,7 @@
 #include <linux/module.h>
 #include <linux/sunrpc/clnt.h>
 #include <linux/sunrpc/auth.h>
+#include <linux/user_namespace.h>
 
 #define NFS_NGROUPS     16
 
@@ -78,8 +79,11 @@ unx_create_cred(struct rpc_auth *auth, struct auth_cred *acred, int flags)
                 groups = NFS_NGROUPS;
 
         cred->uc_gid = acred->gid;
-        for (i = 0; i < groups; i++)
-                cred->uc_gids[i] = GROUP_AT(acred->group_info, i);
+        for (i = 0; i < groups; i++) {
+                gid_t gid;
+                gid = from_kgid(&init_user_ns, GROUP_AT(acred->group_info, i));
+                cred->uc_gids[i] = gid;
+        }
         if (i < NFS_NGROUPS)
                 cred->uc_gids[i] = NOGROUP;
 
@@ -126,9 +130,12 @@ unx_match(struct auth_cred *acred, struct rpc_cred *rcred, int flags)
                 groups = acred->group_info->ngroups;
         if (groups > NFS_NGROUPS)
                 groups = NFS_NGROUPS;
-        for (i = 0; i < groups ; i++)
-                if (cred->uc_gids[i] != GROUP_AT(acred->group_info, i))
+        for (i = 0; i < groups ; i++) {
+                gid_t gid;
+                gid = from_kgid(&init_user_ns, GROUP_AT(acred->group_info, i));
+                if (cred->uc_gids[i] != gid)
                         return 0;
+        }
         if (groups < NFS_NGROUPS &&
             cred->uc_gids[groups] != NOGROUP)
                 return 0;
diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
index de0b0f39d9d8..47ad2666fdf6 100644
--- a/net/sunrpc/cache.c
+++ b/net/sunrpc/cache.c
@@ -1273,7 +1273,7 @@ static void *c_start(struct seq_file *m, loff_t *pos)
         __acquires(cd->hash_lock)
 {
         loff_t n = *pos;
-        unsigned hash, entry;
+        unsigned int hash, entry;
         struct cache_head *ch;
         struct cache_detail *cd = ((struct handle*)m->private)->cd;
 
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index 25302c802460..f56f045778ae 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -127,9 +127,7 @@ static struct dentry *rpc_setup_pipedir_sb(struct super_block *sb,
 {
         static uint32_t clntid;
         char name[15];
-        struct qstr q = {
-                .name = name,
-        };
+        struct qstr q = { .name = name };
         struct dentry *dir, *dentry;
         int error;
 
diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c
index 88945d0f7594..04040476082e 100644
--- a/net/sunrpc/rpc_pipe.c
+++ b/net/sunrpc/rpc_pipe.c
@@ -1057,12 +1057,9 @@ static const struct rpc_filelist files[] = {
 struct dentry *rpc_d_lookup_sb(const struct super_block *sb,
                                const unsigned char *dir_name)
 {
-        struct qstr dir = {
-                .name = dir_name,
-                .len = strlen(dir_name),
-                .hash = full_name_hash(dir_name, strlen(dir_name)),
-        };
+        struct qstr dir = QSTR_INIT(dir_name, strlen(dir_name));
 
+        dir.hash = full_name_hash(dir.name, dir.len);
         return d_lookup(sb->s_root, &dir);
 }
 EXPORT_SYMBOL_GPL(rpc_d_lookup_sb);
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index 4153846984ac..017c0117d154 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c
@@ -1041,23 +1041,21 @@ static void svc_unregister(const struct svc_serv *serv, struct net *net)
  * Printk the given error with the address of the client that caused it.
  */
 static __printf(2, 3)
-int svc_printk(struct svc_rqst *rqstp, const char *fmt, ...)
+void svc_printk(struct svc_rqst *rqstp, const char *fmt, ...)
 {
+        struct va_format vaf;
         va_list args;
-        int     r;
         char    buf[RPC_MAX_ADDRBUFLEN];
 
-        if (!net_ratelimit())
-                return 0;
+        va_start(args, fmt);
 
-        printk(KERN_WARNING "svc: %s: ",
-                svc_print_addr(rqstp, buf, sizeof(buf)));
+        vaf.fmt = fmt;
+        vaf.va = &args;
 
-        va_start(args, fmt);
-        r = vprintk(fmt, args);
-        va_end(args);
+        net_warn_ratelimited("svc: %s: %pV",
+                             svc_print_addr(rqstp, buf, sizeof(buf)), &vaf);
 
-        return r;
+        va_end(args);
 }
 
 /*
diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
index 4bda09d7e1a4..b98ee3514912 100644
--- a/net/sunrpc/svc_xprt.c
+++ b/net/sunrpc/svc_xprt.c
@@ -544,14 +544,11 @@ static void svc_check_conn_limits(struct svc_serv *serv)
                 struct svc_xprt *xprt = NULL;
                 spin_lock_bh(&serv->sv_lock);
                 if (!list_empty(&serv->sv_tempsocks)) {
-                        if (net_ratelimit()) {
-                                /* Try to help the admin */
-                                printk(KERN_NOTICE "%s: too many open  "
-                                       "connections, consider increasing %s\n",
-                                       serv->sv_name, serv->sv_maxconn ?
-                                       "the max number of connections." :
-                                       "the number of threads.");
-                        }
+                        /* Try to help the admin */
+                        net_notice_ratelimited("%s: too many open connections, consider increasing the %s\n",
+                                               serv->sv_name, serv->sv_maxconn ?
+                                               "max number of connections" :
+                                               "number of threads");
                         /*
                          * Always select the oldest connection. It's not fair,
                          * but so is life
diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c
index 521d8f7dc833..71ec8530ec8c 100644
--- a/net/sunrpc/svcauth_unix.c
+++ b/net/sunrpc/svcauth_unix.c
@@ -14,6 +14,7 @@
 #include <net/sock.h>
 #include <net/ipv6.h>
 #include <linux/kernel.h>
+#include <linux/user_namespace.h>
 #define RPCDBG_FACILITY RPCDBG_AUTH
 
 #include <linux/sunrpc/clnt.h>
@@ -530,11 +531,15 @@ static int unix_gid_parse(struct cache_detail *cd,
 
         for (i = 0 ; i < gids ; i++) {
                 int gid;
+                kgid_t kgid;
                 rv = get_int(&mesg, &gid);
                 err = -EINVAL;
                 if (rv)
                         goto out;
-                GROUP_AT(ug.gi, i) = gid;
+                kgid = make_kgid(&init_user_ns, gid);
+                if (!gid_valid(kgid))
+                        goto out;
+                GROUP_AT(ug.gi, i) = kgid;
         }
 
         ugp = unix_gid_lookup(cd, uid);
@@ -563,6 +568,7 @@ static int unix_gid_show(struct seq_file *m,
                          struct cache_detail *cd,
                          struct cache_head *h)
 {
+        struct user_namespace *user_ns = current_user_ns();
         struct unix_gid *ug;
         int i;
         int glen;
@@ -580,7 +586,7 @@ static int unix_gid_show(struct seq_file *m,
 
         seq_printf(m, "%u %d:", ug->uid, glen);
         for (i = 0; i < glen; i++)
-                seq_printf(m, " %d", GROUP_AT(ug->gi, i));
+                seq_printf(m, " %d", from_kgid_munged(user_ns, GROUP_AT(ug->gi, i)));
         seq_printf(m, "\n");
         return 0;
 }
@@ -831,8 +837,12 @@ svcauth_unix_accept(struct svc_rqst *rqstp, __be32 *authp)
         cred->cr_group_info = groups_alloc(slen);
         if (cred->cr_group_info == NULL)
                 return SVC_CLOSE;
-        for (i = 0; i < slen; i++)
-                GROUP_AT(cred->cr_group_info, i) = svc_getnl(argv);
+        for (i = 0; i < slen; i++) {
+                kgid_t kgid = make_kgid(&init_user_ns, svc_getnl(argv));
+                if (!gid_valid(kgid))
+                        goto badcred;
+                GROUP_AT(cred->cr_group_info, i) = kgid;
+        }
         if (svc_getu32(argv) != htonl(RPC_AUTH_NULL) || svc_getu32(argv) != 0) {
                 *authp = rpc_autherr_badverf;
                 return SVC_DENIED;
diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
index 824d32fb3121..a6de09de5d21 100644
--- a/net/sunrpc/svcsock.c
+++ b/net/sunrpc/svcsock.c
@@ -617,11 +617,8 @@ static int svc_udp_recvfrom(struct svc_rqst *rqstp)
         rqstp->rq_prot = IPPROTO_UDP;
 
         if (!svc_udp_get_dest_address(rqstp, cmh)) {
-                if (net_ratelimit())
-                        printk(KERN_WARNING
-                                "svc: received unknown control message %d/%d; "
-                                "dropping RPC reply datagram\n",
-                                        cmh->cmsg_level, cmh->cmsg_type);
+                net_warn_ratelimited("svc: received unknown control message %d/%d; dropping RPC reply datagram\n",
+                                     cmh->cmsg_level, cmh->cmsg_type);
                 skb_free_datagram_locked(svsk->sk_sk, skb);
                 return 0;
         }
@@ -871,18 +868,17 @@ static struct svc_xprt *svc_tcp_accept(struct svc_xprt *xprt)
                 if (err == -ENOMEM)
                         printk(KERN_WARNING "%s: no more sockets!\n",
                                serv->sv_name);
-                else if (err != -EAGAIN && net_ratelimit())
-                        printk(KERN_WARNING "%s: accept failed (err %d)!\n",
-                                   serv->sv_name, -err);
+                else if (err != -EAGAIN)
+                        net_warn_ratelimited("%s: accept failed (err %d)!\n",
+                                             serv->sv_name, -err);
                 return NULL;
         }
         set_bit(XPT_CONN, &svsk->sk_xprt.xpt_flags);
 
         err = kernel_getpeername(newsock, sin, &slen);
         if (err < 0) {
-                if (net_ratelimit())
-                        printk(KERN_WARNING "%s: peername failed (err %d)!\n",
-                                   serv->sv_name, -err);
+                net_warn_ratelimited("%s: peername failed (err %d)!\n",
+                                     serv->sv_name, -err);
                 goto failed;            /* aborted connection or whatever */
         }
 
@@ -1012,19 +1008,15 @@ static int svc_tcp_recv_record(struct svc_sock *svsk, struct svc_rqst *rqstp)
                          *  bit set in the fragment length header.
                          *  But apparently no known nfs clients send fragmented
                          *  records. */
-                        if (net_ratelimit())
-                                printk(KERN_NOTICE "RPC: multiple fragments "
-                                        "per record not supported\n");
+                        net_notice_ratelimited("RPC: multiple fragments per record not supported\n");
                         goto err_delete;
                 }
 
                 svsk->sk_reclen &= RPC_FRAGMENT_SIZE_MASK;
                 dprintk("svc: TCP record, %d bytes\n", svsk->sk_reclen);
                 if (svsk->sk_reclen > serv->sv_max_mesg) {
-                        if (net_ratelimit())
-                                printk(KERN_NOTICE "RPC: "
-                                        "fragment too large: 0x%08lx\n",
-                                        (unsigned long)svsk->sk_reclen);
+                        net_notice_ratelimited("RPC: fragment too large: 0x%08lx\n",
+                                               (unsigned long)svsk->sk_reclen);
                         goto err_delete;
                 }
         }
@@ -1556,7 +1548,7 @@ static struct svc_xprt *svc_create_socket(struct svc_serv *serv,
                                         (char *)&val, sizeof(val));
 
         if (type == SOCK_STREAM)
-                sock->sk->sk_reuse = 1;         /* allow address reuse */
+                sock->sk->sk_reuse = SK_CAN_REUSE; /* allow address reuse */
         error = kernel_bind(sock, sin, len);
         if (error < 0)
                 goto bummer;
diff --git a/net/sunrpc/timer.c b/net/sunrpc/timer.c
index dd824341c349..08881d0c9672 100644
--- a/net/sunrpc/timer.c
+++ b/net/sunrpc/timer.c
@@ -34,7 +34,7 @@
 void rpc_init_rtt(struct rpc_rtt *rt, unsigned long timeo)
 {
         unsigned long init = 0;
-        unsigned i;
+        unsigned int i;
 
         rt->timeo = timeo;
 
@@ -57,7 +57,7 @@ EXPORT_SYMBOL_GPL(rpc_init_rtt);
  * NB: When computing the smoothed RTT and standard deviation,
  *     be careful not to produce negative intermediate results.
  */
-void rpc_update_rtt(struct rpc_rtt *rt, unsigned timer, long m)
+void rpc_update_rtt(struct rpc_rtt *rt, unsigned int timer, long m)
 {
         long *srtt, *sdrtt;
 
@@ -106,7 +106,7 @@ EXPORT_SYMBOL_GPL(rpc_update_rtt);
  * read, write, commit     - A+4D
  * other                   - timeo
  */
-unsigned long rpc_calc_rto(struct rpc_rtt *rt, unsigned timer)
+unsigned long rpc_calc_rto(struct rpc_rtt *rt, unsigned int timer)
 {
         unsigned long res;
 
diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
index b97a3dd9a60a..fddcccfcdf76 100644
--- a/net/sunrpc/xdr.c
+++ b/net/sunrpc/xdr.c
@@ -1204,7 +1204,7 @@ xdr_process_buf(struct xdr_buf *buf, unsigned int offset, unsigned int len,
                 int (*actor)(struct scatterlist *, void *), void *data)
 {
         int i, ret = 0;
-        unsigned page_len, thislen, page_offset;
+        unsigned int page_len, thislen, page_offset;
         struct scatterlist      sg[1];
 
         sg_init_table(sg, 1);
diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c
index d7ccd7923eab..3c83035cdaa9 100644
--- a/net/sunrpc/xprt.c
+++ b/net/sunrpc/xprt.c
@@ -783,7 +783,7 @@ static void xprt_update_rtt(struct rpc_task *task)
 {
         struct rpc_rqst *req = task->tk_rqstp;
         struct rpc_rtt *rtt = task->tk_client->cl_rtt;
-        unsigned timer = task->tk_msg.rpc_proc->p_timer;
+        unsigned int timer = task->tk_msg.rpc_proc->p_timer;
         long m = usecs_to_jiffies(ktime_to_us(req->rq_rtt));
 
         if (timer) {