1 files changed, 15 insertions, 10 deletions

diff --git a/drivers/infiniband/hw/qib/qib_qsfp.c b/drivers/infiniband/hw/qib/qib_qsfp.c
index 3374a52232c1..e06c4ed383f1 100644
--- a/drivers/infiniband/hw/qib/qib_qsfp.c
+++ b/drivers/infiniband/hw/qib/qib_qsfp.c
@@ -273,18 +273,12 @@ int qib_refresh_qsfp_cache(struct qib_pportdata *ppd, struct qib_qsfp_cache *cp)
         int ret;
         int idx;
         u16 cks;
-        u32 mask;
         u8 peek[4];
 
         /* ensure sane contents on invalid reads, for cable swaps */
         memset(cp, 0, sizeof(*cp));
 
-        mask = QSFP_GPIO_MOD_PRS_N;
-        if (ppd->hw_pidx)
-                mask <<= QSFP_GPIO_PORT2_SHIFT;
-
-        ret = ppd->dd->f_gpio_mod(ppd->dd, 0, 0, 0);
-        if (ret & mask) {
+        if (!qib_qsfp_mod_present(ppd)) {
                 ret = -ENODEV;
                 goto bail;
         }
@@ -444,6 +438,19 @@ const char * const qib_qsfp_devtech[16] = {
 
 static const char *pwr_codes = "1.5W2.0W2.5W3.5W";
 
+int qib_qsfp_mod_present(struct qib_pportdata *ppd)
+{
+        u32 mask;
+        int ret;
+
+        mask = QSFP_GPIO_MOD_PRS_N <<
+                (ppd->hw_pidx * QSFP_GPIO_PORT2_SHIFT);
+        ret = ppd->dd->f_gpio_mod(ppd->dd, 0, 0, 0);
+
+        return !((ret & mask) >>
+                 ((ppd->hw_pidx * QSFP_GPIO_PORT2_SHIFT) + 3));
+}
+
 /*
  * Initialize structures that control access to QSFP. Called once per port
  * on cards that support QSFP.
@@ -452,7 +459,6 @@ void qib_qsfp_init(struct qib_qsfp_data *qd,
                    void (*fevent)(struct work_struct *))
 {
         u32 mask, highs;
-        int pins;
 
         struct qib_devdata *dd = qd->ppd->dd;
 
@@ -480,8 +486,7 @@ void qib_qsfp_init(struct qib_qsfp_data *qd,
                 mask <<= QSFP_GPIO_PORT2_SHIFT;
 
         /* Do not try to wait here. Better to let event handle it */
-        pins = dd->f_gpio_mod(dd, 0, 0, 0);
-        if (pins & mask)
+        if (!qib_qsfp_mod_present(qd->ppd))
                 goto bail;
         /* We see a module, but it may be unwise to look yet. Just schedule */
         qd->t_insert = get_jiffies_64();