aboutsummaryrefslogtreecommitdiffstats
path: root/fs/gfs2
diff options
context:
space:
mode:
authorSteven Whitehouse <swhiteho@redhat.com>2011-09-20 07:16:11 -0400
committerSteven Whitehouse <swhiteho@redhat.com>2011-10-21 07:39:52 -0400
commit9ae32429fe036fcfce036ec57b28fc59f3911976 (patch)
treea331589e14fef9f8149fc3e1f00baab7d60260fe /fs/gfs2
parent891a8e9335176b7eb9adc5e34f555ee5e1da47c6 (diff)
GFS2: Remove two unused variables
The two variables being initialised in gfs2_inplace_reserve to track the file & line number of the caller are never used, so we might as well remove them. If something does go wrong, then a stack trace is probably more useful anyway. Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2')
-rw-r--r--fs/gfs2/incore.h4
-rw-r--r--fs/gfs2/rgrp.c14
-rw-r--r--fs/gfs2/rgrp.h6
3 files changed, 4 insertions, 20 deletions
diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
index 6429aa4339ff..7389dfdcc9ef 100644
--- a/fs/gfs2/incore.h
+++ b/fs/gfs2/incore.h
@@ -246,7 +246,6 @@ struct gfs2_glock {
246 246
247struct gfs2_alloc { 247struct gfs2_alloc {
248 /* Quota stuff */ 248 /* Quota stuff */
249
250 struct gfs2_quota_data *al_qd[2*MAXQUOTAS]; 249 struct gfs2_quota_data *al_qd[2*MAXQUOTAS];
251 struct gfs2_holder al_qd_ghs[2*MAXQUOTAS]; 250 struct gfs2_holder al_qd_ghs[2*MAXQUOTAS];
252 unsigned int al_qd_num; 251 unsigned int al_qd_num;
@@ -255,9 +254,6 @@ struct gfs2_alloc {
255 u32 al_alloced; /* Filled in by gfs2_alloc_*() */ 254 u32 al_alloced; /* Filled in by gfs2_alloc_*() */
256 255
257 /* Filled in by gfs2_inplace_reserve() */ 256 /* Filled in by gfs2_inplace_reserve() */
258
259 unsigned int al_line;
260 char *al_file;
261 struct gfs2_holder al_rgd_gh; 257 struct gfs2_holder al_rgd_gh;
262}; 258};
263 259
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 1daf8a78c733..96bd6d759f29 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -1024,14 +1024,13 @@ static int get_local_rgrp(struct gfs2_inode *ip, u64 *last_unlinked)
1024} 1024}
1025 1025
1026/** 1026/**
1027 * gfs2_inplace_reserve_i - Reserve space in the filesystem 1027 * gfs2_inplace_reserve - Reserve space in the filesystem
1028 * @ip: the inode to reserve space for 1028 * @ip: the inode to reserve space for
1029 * 1029 *
1030 * Returns: errno 1030 * Returns: errno
1031 */ 1031 */
1032 1032
1033int gfs2_inplace_reserve_i(struct gfs2_inode *ip, 1033int gfs2_inplace_reserve(struct gfs2_inode *ip)
1034 char *file, unsigned int line)
1035{ 1034{
1036 struct gfs2_sbd *sdp = GFS2_SB(&ip->i_inode); 1035 struct gfs2_sbd *sdp = GFS2_SB(&ip->i_inode);
1037 struct gfs2_alloc *al = ip->i_alloc; 1036 struct gfs2_alloc *al = ip->i_alloc;
@@ -1057,14 +1056,7 @@ int gfs2_inplace_reserve_i(struct gfs2_inode *ip,
1057 gfs2_log_flush(sdp, NULL); 1056 gfs2_log_flush(sdp, NULL);
1058 } while (tries++ < 3); 1057 } while (tries++ < 3);
1059 1058
1060 if (error) 1059 return error;
1061 return error;
1062
1063 /* no error, so we have the rgrp set in the inode's allocation. */
1064 al->al_file = file;
1065 al->al_line = line;
1066
1067 return 0;
1068} 1060}
1069 1061
1070/** 1062/**
diff --git a/fs/gfs2/rgrp.h b/fs/gfs2/rgrp.h
index 0e886d830784..cf5c50180192 100644
--- a/fs/gfs2/rgrp.h
+++ b/fs/gfs2/rgrp.h
@@ -36,11 +36,7 @@ static inline void gfs2_alloc_put(struct gfs2_inode *ip)
36 ip->i_alloc = NULL; 36 ip->i_alloc = NULL;
37} 37}
38 38
39extern int gfs2_inplace_reserve_i(struct gfs2_inode *ip, 39extern int gfs2_inplace_reserve(struct gfs2_inode *ip);
40 char *file, unsigned int line);
41#define gfs2_inplace_reserve(ip) \
42 gfs2_inplace_reserve_i((ip), __FILE__, __LINE__)
43
44extern void gfs2_inplace_release(struct gfs2_inode *ip); 40extern void gfs2_inplace_release(struct gfs2_inode *ip);
45 41
46extern int gfs2_alloc_block(struct gfs2_inode *ip, u64 *bn, unsigned int *n); 42extern int gfs2_alloc_block(struct gfs2_inode *ip, u64 *bn, unsigned int *n);