diff options
author | Matt Fleming <matt.fleming@intel.com> | 2012-01-10 18:11:17 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-01-10 19:30:54 -0500 |
commit | 5e6292c0f28f03dfdb8ea3d685f0b838a23bfba4 (patch) | |
tree | 8684833680054ab48f9da2bbc36c93e3d00a3391 /arch/x86/kernel/signal.c | |
parent | f350b1778f1b7713ef54fbc7e079e09e2fe098b9 (diff) |
signal: add block_sigmask() for adding sigmask to current->blocked
Abstract the code sequence for adding a signal handler's sa_mask to
current->blocked because the sequence is identical for all architectures.
Furthermore, in the past some architectures actually got this code wrong,
so introduce a wrapper that all architectures can use.
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/x86/kernel/signal.c')
-rw-r--r-- | arch/x86/kernel/signal.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c index 54ddaeb221c1..46a01bdc27e2 100644 --- a/arch/x86/kernel/signal.c +++ b/arch/x86/kernel/signal.c | |||
@@ -682,7 +682,6 @@ static int | |||
682 | handle_signal(unsigned long sig, siginfo_t *info, struct k_sigaction *ka, | 682 | handle_signal(unsigned long sig, siginfo_t *info, struct k_sigaction *ka, |
683 | struct pt_regs *regs) | 683 | struct pt_regs *regs) |
684 | { | 684 | { |
685 | sigset_t blocked; | ||
686 | int ret; | 685 | int ret; |
687 | 686 | ||
688 | /* Are we from a system call? */ | 687 | /* Are we from a system call? */ |
@@ -733,10 +732,7 @@ handle_signal(unsigned long sig, siginfo_t *info, struct k_sigaction *ka, | |||
733 | */ | 732 | */ |
734 | regs->flags &= ~X86_EFLAGS_TF; | 733 | regs->flags &= ~X86_EFLAGS_TF; |
735 | 734 | ||
736 | sigorsets(&blocked, ¤t->blocked, &ka->sa.sa_mask); | 735 | block_sigmask(ka, sig); |
737 | if (!(ka->sa.sa_flags & SA_NODEFER)) | ||
738 | sigaddset(&blocked, sig); | ||
739 | set_current_blocked(&blocked); | ||
740 | 736 | ||
741 | tracehook_signal_handler(sig, info, ka, regs, | 737 | tracehook_signal_handler(sig, info, ka, regs, |
742 | test_thread_flag(TIF_SINGLESTEP)); | 738 | test_thread_flag(TIF_SINGLESTEP)); |