1 files changed, 34 insertions, 27 deletions

diff --git a/tools/perf/tests/vmlinux-kallsyms.c b/tools/perf/tests/vmlinux-kallsyms.c
index e63abab7d5a1..a5082331f246 100644
--- a/tools/perf/tests/vmlinux-kallsyms.c
+++ b/tools/perf/tests/vmlinux-kallsyms.c
@@ -8,14 +8,6 @@
 #include "debug.h"
 #include "machine.h"
 
-static int vmlinux_matches_kallsyms_filter(struct map *map __maybe_unused,
-                                           struct symbol *sym)
-{
-        bool *visited = symbol__priv(sym);
-        *visited = true;
-        return 0;
-}
-
 #define UM(x) kallsyms_map->unmap_ip(kallsyms_map, (x))
 
 int test__vmlinux_matches_kallsyms(int subtest __maybe_unused)
@@ -28,6 +20,7 @@ int test__vmlinux_matches_kallsyms(int subtest __maybe_unused)
         enum map_type type = MAP__FUNCTION;
         struct maps *maps = &vmlinux.kmaps.maps[type];
         u64 mem_start, mem_end;
+        bool header_printed;
 
         /*
          * Step 1:
@@ -61,7 +54,7 @@ int test__vmlinux_matches_kallsyms(int subtest __maybe_unused)
          * be compacted against the list of modules found in the "vmlinux"
          * code and with the one got from /proc/modules from the "kallsyms" code.
          */
-        if (__machine__load_kallsyms(&kallsyms, "/proc/kallsyms", type, true, NULL) <= 0) {
+        if (__machine__load_kallsyms(&kallsyms, "/proc/kallsyms", type, true) <= 0) {
                 pr_debug("dso__load_kallsyms ");
                 goto out;
         }
@@ -99,8 +92,7 @@ int test__vmlinux_matches_kallsyms(int subtest __maybe_unused)
          * maps__reloc_vmlinux will notice and set proper ->[un]map_ip routines
          * to fixup the symbols.
          */
-        if (machine__load_vmlinux_path(&vmlinux, type,
-                                       vmlinux_matches_kallsyms_filter) <= 0) {
+        if (machine__load_vmlinux_path(&vmlinux, type) <= 0) {
                 pr_debug("Couldn't find a vmlinux that matches the kernel running on this machine, skipping test\n");
                 err = TEST_SKIP;
                 goto out;
@@ -126,7 +118,7 @@ int test__vmlinux_matches_kallsyms(int subtest __maybe_unused)
                 mem_end = vmlinux_map->unmap_ip(vmlinux_map, sym->end);
 
                 first_pair = machine__find_kernel_symbol(&kallsyms, type,
-                                                         mem_start, NULL, NULL);
+                                                         mem_start, NULL);
                 pair = first_pair;
 
                 if (pair && UM(pair->start) == mem_start) {
@@ -143,7 +135,7 @@ next_pair:
                                  */
                                 s64 skew = mem_end - UM(pair->end);
                                 if (llabs(skew) >= page_size)
-                                        pr_debug("%#" PRIx64 ": diff end addr for %s v: %#" PRIx64 " k: %#" PRIx64 "\n",
+                                        pr_debug("WARN: %#" PRIx64 ": diff end addr for %s v: %#" PRIx64 " k: %#" PRIx64 "\n",
                                                  mem_start, sym->name, mem_end,
                                                  UM(pair->end));
 
@@ -154,22 +146,23 @@ next_pair:
                                  * kallsyms.
                                  */
                                 continue;
-
                         } else {
-                                pair = machine__find_kernel_symbol_by_name(&kallsyms, type, sym->name, NULL, NULL);
+                                pair = machine__find_kernel_symbol_by_name(&kallsyms, type, sym->name, NULL);
                                 if (pair) {
                                         if (UM(pair->start) == mem_start)
                                                 goto next_pair;
 
-                                        pr_debug("%#" PRIx64 ": diff name v: %s k: %s\n",
+                                        pr_debug("WARN: %#" PRIx64 ": diff name v: %s k: %s\n",
                                                  mem_start, sym->name, pair->name);
                                 } else {
-                                        pr_debug("%#" PRIx64 ": diff name v: %s k: %s\n",
+                                        pr_debug("WARN: %#" PRIx64 ": diff name v: %s k: %s\n",
                                                  mem_start, sym->name, first_pair->name);
                                 }
+
+                                continue;
                         }
                 } else
-                        pr_debug("%#" PRIx64 ": %s not on kallsyms\n",
+                        pr_debug("ERR : %#" PRIx64 ": %s not on kallsyms\n",
                                  mem_start, sym->name);
 
                 err = -1;
@@ -178,7 +171,7 @@ next_pair:
         if (!verbose)
                 goto out;
 
-        pr_info("Maps only in vmlinux:\n");
+        header_printed = false;
 
         for (map = maps__first(maps); map; map = map__next(map)) {
                 struct map *
@@ -192,13 +185,18 @@ next_pair:
                                                 (map->dso->kernel ?
                                                         map->dso->short_name :
                                                         map->dso->name));
-                if (pair)
+                if (pair) {
                         pair->priv = 1;
-                else
+                } else {
+                        if (!header_printed) {
+                                pr_info("WARN: Maps only in vmlinux:\n");
+                                header_printed = true;
+                        }
                         map__fprintf(map, stderr);
+                }
         }
 
-        pr_info("Maps in vmlinux with a different name in kallsyms:\n");
+        header_printed = false;
 
         for (map = maps__first(maps); map; map = map__next(map)) {
                 struct map *pair;
@@ -211,24 +209,33 @@ next_pair:
                         continue;
 
                 if (pair->start == mem_start) {
-                        pair->priv = 1;
-                        pr_info(" %" PRIx64 "-%" PRIx64 " %" PRIx64 " %s in kallsyms as",
+                        if (!header_printed) {
+                                pr_info("WARN: Maps in vmlinux with a different name in kallsyms:\n");
+                                header_printed = true;
+                        }
+
+                        pr_info("WARN: %" PRIx64 "-%" PRIx64 " %" PRIx64 " %s in kallsyms as",
                                 map->start, map->end, map->pgoff, map->dso->name);
                         if (mem_end != pair->end)
-                                pr_info(":\n*%" PRIx64 "-%" PRIx64 " %" PRIx64,
+                                pr_info(":\nWARN: *%" PRIx64 "-%" PRIx64 " %" PRIx64,
                                         pair->start, pair->end, pair->pgoff);
                         pr_info(" %s\n", pair->dso->name);
                         pair->priv = 1;
                 }
         }
 
-        pr_info("Maps only in kallsyms:\n");
+        header_printed = false;
 
         maps = &kallsyms.kmaps.maps[type];
 
         for (map = maps__first(maps); map; map = map__next(map)) {
-                if (!map->priv)
+                if (!map->priv) {
+                        if (!header_printed) {
+                                pr_info("WARN: Maps only in kallsyms:\n");
+                                header_printed = true;
+                        }
                         map__fprintf(map, stderr);
+                }
         }
 out:
         machine__exit(&kallsyms);