diff options
Diffstat (limited to 'scripts/checkpatch.pl')
-rwxr-xr-x | scripts/checkpatch.pl | 70 |
1 files changed, 35 insertions, 35 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 894f8c616573..37d8b91ac198 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
@@ -5554,46 +5554,46 @@ sub process { | |||
5554 | } | 5554 | } |
5555 | 5555 | ||
5556 | # Check for memcpy(foo, bar, ETH_ALEN) that could be ether_addr_copy(foo, bar) | 5556 | # Check for memcpy(foo, bar, ETH_ALEN) that could be ether_addr_copy(foo, bar) |
5557 | if ($^V && $^V ge 5.10.0 && | 5557 | # if ($^V && $^V ge 5.10.0 && |
5558 | defined $stat && | 5558 | # defined $stat && |
5559 | $stat =~ /^\+(?:.*?)\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) { | 5559 | # $stat =~ /^\+(?:.*?)\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) { |
5560 | if (WARN("PREFER_ETHER_ADDR_COPY", | 5560 | # if (WARN("PREFER_ETHER_ADDR_COPY", |
5561 | "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)\n" . "$here\n$stat\n") && | 5561 | # "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)\n" . "$here\n$stat\n") && |
5562 | $fix) { | 5562 | # $fix) { |
5563 | $fixed[$fixlinenr] =~ s/\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/ether_addr_copy($2, $7)/; | 5563 | # $fixed[$fixlinenr] =~ s/\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/ether_addr_copy($2, $7)/; |
5564 | } | 5564 | # } |
5565 | } | 5565 | # } |
5566 | 5566 | ||
5567 | # Check for memcmp(foo, bar, ETH_ALEN) that could be ether_addr_equal*(foo, bar) | 5567 | # Check for memcmp(foo, bar, ETH_ALEN) that could be ether_addr_equal*(foo, bar) |
5568 | if ($^V && $^V ge 5.10.0 && | 5568 | # if ($^V && $^V ge 5.10.0 && |
5569 | defined $stat && | 5569 | # defined $stat && |
5570 | $stat =~ /^\+(?:.*?)\bmemcmp\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) { | 5570 | # $stat =~ /^\+(?:.*?)\bmemcmp\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) { |
5571 | WARN("PREFER_ETHER_ADDR_EQUAL", | 5571 | # WARN("PREFER_ETHER_ADDR_EQUAL", |
5572 | "Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()\n" . "$here\n$stat\n") | 5572 | # "Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()\n" . "$here\n$stat\n") |
5573 | } | 5573 | # } |
5574 | 5574 | ||
5575 | # check for memset(foo, 0x0, ETH_ALEN) that could be eth_zero_addr | 5575 | # check for memset(foo, 0x0, ETH_ALEN) that could be eth_zero_addr |
5576 | # check for memset(foo, 0xFF, ETH_ALEN) that could be eth_broadcast_addr | 5576 | # check for memset(foo, 0xFF, ETH_ALEN) that could be eth_broadcast_addr |
5577 | if ($^V && $^V ge 5.10.0 && | 5577 | # if ($^V && $^V ge 5.10.0 && |
5578 | defined $stat && | 5578 | # defined $stat && |
5579 | $stat =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) { | 5579 | # $stat =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) { |
5580 | 5580 | # | |
5581 | my $ms_val = $7; | 5581 | # my $ms_val = $7; |
5582 | 5582 | # | |
5583 | if ($ms_val =~ /^(?:0x|)0+$/i) { | 5583 | # if ($ms_val =~ /^(?:0x|)0+$/i) { |
5584 | if (WARN("PREFER_ETH_ZERO_ADDR", | 5584 | # if (WARN("PREFER_ETH_ZERO_ADDR", |
5585 | "Prefer eth_zero_addr over memset()\n" . "$here\n$stat\n") && | 5585 | # "Prefer eth_zero_addr over memset()\n" . "$here\n$stat\n") && |
5586 | $fix) { | 5586 | # $fix) { |
5587 | $fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_zero_addr($2)/; | 5587 | # $fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_zero_addr($2)/; |
5588 | } | 5588 | # } |
5589 | } elsif ($ms_val =~ /^(?:0xff|255)$/i) { | 5589 | # } elsif ($ms_val =~ /^(?:0xff|255)$/i) { |
5590 | if (WARN("PREFER_ETH_BROADCAST_ADDR", | 5590 | # if (WARN("PREFER_ETH_BROADCAST_ADDR", |
5591 | "Prefer eth_broadcast_addr() over memset()\n" . "$here\n$stat\n") && | 5591 | # "Prefer eth_broadcast_addr() over memset()\n" . "$here\n$stat\n") && |
5592 | $fix) { | 5592 | # $fix) { |
5593 | $fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_broadcast_addr($2)/; | 5593 | # $fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_broadcast_addr($2)/; |
5594 | } | 5594 | # } |
5595 | } | 5595 | # } |
5596 | } | 5596 | # } |
5597 | 5597 | ||
5598 | # typecasts on min/max could be min_t/max_t | 5598 | # typecasts on min/max could be min_t/max_t |
5599 | if ($^V && $^V ge 5.10.0 && | 5599 | if ($^V && $^V ge 5.10.0 && |