2 files changed, 15 insertions, 32 deletions

diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
index 37317149f918..4dea2e0681d1 100644
--- a/net/dsa/dsa.c
+++ b/net/dsa/dsa.c
@@ -501,12 +501,10 @@ static struct net_device *dev_to_net_device(struct device *dev)
 #ifdef CONFIG_OF
 static int dsa_of_setup_routing_table(struct dsa_platform_data *pd,
                                         struct dsa_chip_data *cd,
-                                        int chip_index,
+                                        int chip_index, int port_index,
                                         struct device_node *link)
 {
-        int ret;
         const __be32 *reg;
-        int link_port_addr;
         int link_sw_addr;
         struct device_node *parent_sw;
         int len;
@@ -519,6 +517,10 @@ static int dsa_of_setup_routing_table(struct dsa_platform_data *pd,
         if (!reg || (len != sizeof(*reg) * 2))
                 return -EINVAL;
 
+        /*
+         * Get the destination switch number from the second field of its 'reg'
+         * property, i.e. for "reg = <0x19 1>" sw_addr is '1'.
+         */
         link_sw_addr = be32_to_cpup(reg + 1);
 
         if (link_sw_addr >= pd->nr_chips)
@@ -535,20 +537,9 @@ static int dsa_of_setup_routing_table(struct dsa_platform_data *pd,
                 memset(cd->rtable, -1, pd->nr_chips * sizeof(s8));
         }
 
-        reg = of_get_property(link, "reg", NULL);
-        if (!reg) {
-                ret = -EINVAL;
-                goto out;
-        }
-
-        link_port_addr = be32_to_cpup(reg);
-
-        cd->rtable[link_sw_addr] = link_port_addr;
+        cd->rtable[link_sw_addr] = port_index;
 
         return 0;
-out:
-        kfree(cd->rtable);
-        return ret;
 }
 
 static void dsa_of_free_platform_data(struct dsa_platform_data *pd)
@@ -603,7 +594,7 @@ static int dsa_of_probe(struct platform_device *pdev)
 
         pdev->dev.platform_data = pd;
         pd->netdev = &ethernet_dev->dev;
-        pd->nr_chips = of_get_child_count(np);
+        pd->nr_chips = of_get_available_child_count(np);
         if (pd->nr_chips > DSA_MAX_SWITCHES)
                 pd->nr_chips = DSA_MAX_SWITCHES;
 
@@ -658,7 +649,7 @@ static int dsa_of_probe(struct platform_device *pdev)
                         if (!strcmp(port_name, "dsa") && link &&
                                         pd->nr_chips > 1) {
                                 ret = dsa_of_setup_routing_table(pd, cd,
-                                                chip_index, link);
+                                                chip_index, port_index, link);
                                 if (ret)
                                         goto out_free_chip;
                         }
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 589aafd01fc5..f23deadf42a0 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -521,10 +521,13 @@ static int dsa_slave_phy_setup(struct dsa_slave_priv *p,
         struct device_node *phy_dn, *port_dn;
         bool phy_is_fixed = false;
         u32 phy_flags = 0;
-        int ret;
+        int mode, ret;
 
         port_dn = cd->port_dn[p->port];
-        p->phy_interface = of_get_phy_mode(port_dn);
+        mode = of_get_phy_mode(port_dn);
+        if (mode < 0)
+                mode = PHY_INTERFACE_MODE_NA;
+        p->phy_interface = mode;
 
         phy_dn = of_parse_phandle(port_dn, "phy-handle", 0);
         if (of_phy_is_fixed_link(port_dn)) {
@@ -559,6 +562,8 @@ static int dsa_slave_phy_setup(struct dsa_slave_priv *p,
                 if (!p->phy)
                         return -ENODEV;
 
+                /* Use already configured phy mode */
+                p->phy_interface = p->phy->interface;
                 phy_connect_direct(slave_dev, p->phy, dsa_slave_adjust_link,
                                    p->phy_interface);
         } else {
@@ -676,18 +681,5 @@ dsa_slave_create(struct dsa_switch *ds, struct device *parent,
 
         netif_carrier_off(slave_dev);
 
-        if (p->phy != NULL) {
-                if (ds->drv->get_phy_flags)
-                        p->phy->dev_flags |= ds->drv->get_phy_flags(ds, port);
-
-                phy_attach(slave_dev, dev_name(&p->phy->dev),
-                           PHY_INTERFACE_MODE_GMII);
-
-                p->phy->autoneg = AUTONEG_ENABLE;
-                p->phy->speed = 0;
-                p->phy->duplex = 0;
-                p->phy->advertising = p->phy->supported | ADVERTISED_Autoneg;
-        }
-
         return slave_dev;
 }