1 files changed, 33 insertions, 47 deletions

diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
index 1eba07feb34a..fa4daba8db55 100644
--- a/net/dsa/dsa.c
+++ b/net/dsa/dsa.c
@@ -21,8 +21,10 @@
 #include <linux/of_mdio.h>
 #include <linux/of_platform.h>
 #include <linux/of_net.h>
+#include <linux/of_gpio.h>
 #include <linux/sysfs.h>
 #include <linux/phy_fixed.h>
+#include <linux/gpio/consumer.h>
 #include "dsa_priv.h"
 
 char dsa_driver_version[] = "0.1";
@@ -437,7 +439,7 @@ static void dsa_switch_destroy(struct dsa_switch *ds)
                 if (of_phy_is_fixed_link(port_dn)) {
                         phydev = of_phy_find_device(port_dn);
                         if (phydev) {
-                                int addr = phydev->addr;
+                                int addr = phydev->mdio.addr;
 
                                 phy_device_free(phydev);
                                 of_node_put(port_dn);
@@ -454,8 +456,7 @@ static void dsa_switch_destroy(struct dsa_switch *ds)
                 if (!ds->ports[port])
                         continue;
 
-                unregister_netdev(ds->ports[port]);
-                free_netdev(ds->ports[port]);
+                dsa_slave_destroy(ds->ports[port]);
         }
 
         mdiobus_unregister(ds->slave_mii_bus);
@@ -506,33 +507,6 @@ static int dsa_switch_resume(struct dsa_switch *ds)
 }
 #endif
 
-
-/* link polling *************************************************************/
-static void dsa_link_poll_work(struct work_struct *ugly)
-{
-        struct dsa_switch_tree *dst;
-        int i;
-
-        dst = container_of(ugly, struct dsa_switch_tree, link_poll_work);
-
-        for (i = 0; i < dst->pd->nr_chips; i++) {
-                struct dsa_switch *ds = dst->ds[i];
-
-                if (ds != NULL && ds->drv->poll_link != NULL)
-                        ds->drv->poll_link(ds);
-        }
-
-        mod_timer(&dst->link_poll_timer, round_jiffies(jiffies + HZ));
-}
-
-static void dsa_link_poll_timer(unsigned long _dst)
-{
-        struct dsa_switch_tree *dst = (void *)_dst;
-
-        schedule_work(&dst->link_poll_work);
-}
-
-
 /* platform driver init and cleanup *****************************************/
 static int dev_is_class(struct device *dev, void *class)
 {
@@ -688,6 +662,9 @@ static int dsa_of_probe(struct device *dev)
         const char *port_name;
         int chip_index, port_index;
         const unsigned int *sw_addr, *port_reg;
+        int gpio;
+        enum of_gpio_flags of_flags;
+        unsigned long flags;
         u32 eeprom_len;
         int ret;
 
@@ -766,6 +743,19 @@ static int dsa_of_probe(struct device *dev)
                         put_device(cd->host_dev);
                         cd->host_dev = &mdio_bus_switch->dev;
                 }
+                gpio = of_get_named_gpio_flags(child, "reset-gpios", 0,
+                                               &of_flags);
+                if (gpio_is_valid(gpio)) {
+                        flags = (of_flags == OF_GPIO_ACTIVE_LOW ?
+                                 GPIOF_ACTIVE_LOW : 0);
+                        ret = devm_gpio_request_one(dev, gpio, flags,
+                                                    "switch_reset");
+                        if (ret)
+                                goto out_free_chip;
+
+                        cd->reset = gpio_to_desc(gpio);
+                        gpiod_direction_output(cd->reset, 0);
+                }
 
                 for_each_available_child_of_node(child, port) {
                         port_reg = of_get_property(port, "reg", NULL);
@@ -859,8 +849,6 @@ static int dsa_setup_dst(struct dsa_switch_tree *dst, struct net_device *dev,
                 }
 
                 dst->ds[i] = ds;
-                if (ds->drv->poll_link != NULL)
-                        dst->link_poll_needed = 1;
 
                 ++configured;
         }
@@ -879,15 +867,6 @@ static int dsa_setup_dst(struct dsa_switch_tree *dst, struct net_device *dev,
         wmb();
         dev->dsa_ptr = (void *)dst;
 
-        if (dst->link_poll_needed) {
-                INIT_WORK(&dst->link_poll_work, dsa_link_poll_work);
-                init_timer(&dst->link_poll_timer);
-                dst->link_poll_timer.data = (unsigned long)dst;
-                dst->link_poll_timer.function = dsa_link_poll_timer;
-                dst->link_poll_timer.expires = round_jiffies(jiffies + HZ);
-                add_timer(&dst->link_poll_timer);
-        }
-
         return 0;
 }
 
@@ -939,8 +918,10 @@ static int dsa_probe(struct platform_device *pdev)
         platform_set_drvdata(pdev, dst);
 
         ret = dsa_setup_dst(dst, dev, &pdev->dev, pd);
-        if (ret)
+        if (ret) {
+                dev_put(dev);
                 goto out;
+        }
 
         return 0;
 
@@ -954,17 +935,14 @@ static void dsa_remove_dst(struct dsa_switch_tree *dst)
 {
         int i;
 
-        if (dst->link_poll_needed)
-                del_timer_sync(&dst->link_poll_timer);
-
-        flush_work(&dst->link_poll_work);
-
         for (i = 0; i < dst->pd->nr_chips; i++) {
                 struct dsa_switch *ds = dst->ds[i];
 
                 if (ds)
                         dsa_switch_destroy(ds);
         }
+
+        dev_put(dst->master_netdev);
 }
 
 static int dsa_remove(struct platform_device *pdev)
@@ -1010,6 +988,14 @@ static int dsa_suspend(struct device *d)
         struct dsa_switch_tree *dst = platform_get_drvdata(pdev);
         int i, ret = 0;
 
+        dst->master_netdev->dsa_ptr = NULL;
+
+        /* If we used a tagging format that doesn't have an ethertype
+         * field, make sure that all packets from this point get sent
+         * without the tag and go through the regular receive path.
+         */
+        wmb();
+
         for (i = 0; i < dst->pd->nr_chips; i++) {
                 struct dsa_switch *ds = dst->ds[i];