diff options
Diffstat (limited to 'lib')
-rw-r--r-- | lib/Kconfig | 5 | ||||
-rw-r--r-- | lib/Kconfig.debug | 60 | ||||
-rw-r--r-- | lib/Makefile | 2 | ||||
-rw-r--r-- | lib/bitmap.c | 30 | ||||
-rw-r--r-- | lib/cpumask.c | 9 | ||||
-rw-r--r-- | lib/div64.c | 2 | ||||
-rw-r--r-- | lib/dma-debug.c | 2 | ||||
-rw-r--r-- | lib/find_bit.c | 193 | ||||
-rw-r--r-- | lib/find_last_bit.c | 36 | ||||
-rw-r--r-- | lib/find_next_bit.c | 285 | ||||
-rw-r--r-- | lib/ioremap.c | 53 | ||||
-rw-r--r-- | lib/iov_iter.c | 83 | ||||
-rw-r--r-- | lib/kobject.c | 7 | ||||
-rw-r--r-- | lib/lockref.c | 2 | ||||
-rw-r--r-- | lib/lru_cache.c | 9 | ||||
-rw-r--r-- | lib/lz4/lz4_decompress.c | 18 | ||||
-rw-r--r-- | lib/rhashtable.c | 1022 | ||||
-rw-r--r-- | lib/sha1.c | 1 | ||||
-rw-r--r-- | lib/string.c | 2 | ||||
-rw-r--r-- | lib/string_helpers.c | 261 | ||||
-rw-r--r-- | lib/test-hexdump.c | 8 | ||||
-rw-r--r-- | lib/test-string_helpers.c | 40 | ||||
-rw-r--r-- | lib/test_rhashtable.c | 58 | ||||
-rw-r--r-- | lib/vsprintf.c | 352 |
24 files changed, 1152 insertions, 1388 deletions
diff --git a/lib/Kconfig b/lib/Kconfig index 87da53bb1fef..f5440221d929 100644 --- a/lib/Kconfig +++ b/lib/Kconfig | |||
@@ -18,9 +18,8 @@ config HAVE_ARCH_BITREVERSE | |||
18 | default n | 18 | default n |
19 | depends on BITREVERSE | 19 | depends on BITREVERSE |
20 | help | 20 | help |
21 | This option provides an config for the architecture which have instruction | 21 | This option enables the use of hardware bit-reversal instructions on |
22 | can do bitreverse operation, we use the hardware instruction if the architecture | 22 | architectures which support such operations. |
23 | have this capability. | ||
24 | 23 | ||
25 | config RATIONAL | 24 | config RATIONAL |
26 | bool | 25 | bool |
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index c5cefb3c009c..17670573dda8 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug | |||
@@ -865,6 +865,19 @@ config SCHED_STACK_END_CHECK | |||
865 | data corruption or a sporadic crash at a later stage once the region | 865 | data corruption or a sporadic crash at a later stage once the region |
866 | is examined. The runtime overhead introduced is minimal. | 866 | is examined. The runtime overhead introduced is minimal. |
867 | 867 | ||
868 | config DEBUG_TIMEKEEPING | ||
869 | bool "Enable extra timekeeping sanity checking" | ||
870 | help | ||
871 | This option will enable additional timekeeping sanity checks | ||
872 | which may be helpful when diagnosing issues where timekeeping | ||
873 | problems are suspected. | ||
874 | |||
875 | This may include checks in the timekeeping hotpaths, so this | ||
876 | option may have a (very small) performance impact to some | ||
877 | workloads. | ||
878 | |||
879 | If unsure, say N. | ||
880 | |||
868 | config TIMER_STATS | 881 | config TIMER_STATS |
869 | bool "Collect kernel timers statistics" | 882 | bool "Collect kernel timers statistics" |
870 | depends on DEBUG_KERNEL && PROC_FS | 883 | depends on DEBUG_KERNEL && PROC_FS |
@@ -1180,16 +1193,7 @@ config DEBUG_CREDENTIALS | |||
1180 | menu "RCU Debugging" | 1193 | menu "RCU Debugging" |
1181 | 1194 | ||
1182 | config PROVE_RCU | 1195 | config PROVE_RCU |
1183 | bool "RCU debugging: prove RCU correctness" | 1196 | def_bool PROVE_LOCKING |
1184 | depends on PROVE_LOCKING | ||
1185 | default n | ||
1186 | help | ||
1187 | This feature enables lockdep extensions that check for correct | ||
1188 | use of RCU APIs. This is currently under development. Say Y | ||
1189 | if you want to debug RCU usage or help work on the PROVE_RCU | ||
1190 | feature. | ||
1191 | |||
1192 | Say N if you are unsure. | ||
1193 | 1197 | ||
1194 | config PROVE_RCU_REPEATEDLY | 1198 | config PROVE_RCU_REPEATEDLY |
1195 | bool "RCU debugging: don't disable PROVE_RCU on first splat" | 1199 | bool "RCU debugging: don't disable PROVE_RCU on first splat" |
@@ -1257,6 +1261,30 @@ config RCU_TORTURE_TEST_RUNNABLE | |||
1257 | Say N here if you want the RCU torture tests to start only | 1261 | Say N here if you want the RCU torture tests to start only |
1258 | after being manually enabled via /proc. | 1262 | after being manually enabled via /proc. |
1259 | 1263 | ||
1264 | config RCU_TORTURE_TEST_SLOW_INIT | ||
1265 | bool "Slow down RCU grace-period initialization to expose races" | ||
1266 | depends on RCU_TORTURE_TEST | ||
1267 | help | ||
1268 | This option makes grace-period initialization block for a | ||
1269 | few jiffies between initializing each pair of consecutive | ||
1270 | rcu_node structures. This helps to expose races involving | ||
1271 | grace-period initialization, in other words, it makes your | ||
1272 | kernel less stable. It can also greatly increase grace-period | ||
1273 | latency, especially on systems with large numbers of CPUs. | ||
1274 | This is useful when torture-testing RCU, but in almost no | ||
1275 | other circumstance. | ||
1276 | |||
1277 | Say Y here if you want your system to crash and hang more often. | ||
1278 | Say N if you want a sane system. | ||
1279 | |||
1280 | config RCU_TORTURE_TEST_SLOW_INIT_DELAY | ||
1281 | int "How much to slow down RCU grace-period initialization" | ||
1282 | range 0 5 | ||
1283 | default 3 | ||
1284 | help | ||
1285 | This option specifies the number of jiffies to wait between | ||
1286 | each rcu_node structure initialization. | ||
1287 | |||
1260 | config RCU_CPU_STALL_TIMEOUT | 1288 | config RCU_CPU_STALL_TIMEOUT |
1261 | int "RCU CPU stall timeout in seconds" | 1289 | int "RCU CPU stall timeout in seconds" |
1262 | depends on RCU_STALL_COMMON | 1290 | depends on RCU_STALL_COMMON |
@@ -1732,6 +1760,18 @@ config TEST_UDELAY | |||
1732 | 1760 | ||
1733 | If unsure, say N. | 1761 | If unsure, say N. |
1734 | 1762 | ||
1763 | config MEMTEST | ||
1764 | bool "Memtest" | ||
1765 | depends on HAVE_MEMBLOCK | ||
1766 | ---help--- | ||
1767 | This option adds a kernel parameter 'memtest', which allows memtest | ||
1768 | to be set. | ||
1769 | memtest=0, mean disabled; -- default | ||
1770 | memtest=1, mean do 1 test pattern; | ||
1771 | ... | ||
1772 | memtest=17, mean do 17 test patterns. | ||
1773 | If you are unsure how to answer this question, answer N. | ||
1774 | |||
1735 | source "samples/Kconfig" | 1775 | source "samples/Kconfig" |
1736 | 1776 | ||
1737 | source "lib/Kconfig.kgdb" | 1777 | source "lib/Kconfig.kgdb" |
diff --git a/lib/Makefile b/lib/Makefile index 58f74d2dd396..da6116b21555 100644 --- a/lib/Makefile +++ b/lib/Makefile | |||
@@ -25,7 +25,7 @@ obj-y += lockref.o | |||
25 | obj-y += bcd.o div64.o sort.o parser.o halfmd4.o debug_locks.o random32.o \ | 25 | obj-y += bcd.o div64.o sort.o parser.o halfmd4.o debug_locks.o random32.o \ |
26 | bust_spinlocks.o kasprintf.o bitmap.o scatterlist.o \ | 26 | bust_spinlocks.o kasprintf.o bitmap.o scatterlist.o \ |
27 | gcd.o lcm.o list_sort.o uuid.o flex_array.o iov_iter.o clz_ctz.o \ | 27 | gcd.o lcm.o list_sort.o uuid.o flex_array.o iov_iter.o clz_ctz.o \ |
28 | bsearch.o find_last_bit.o find_next_bit.o llist.o memweight.o kfifo.o \ | 28 | bsearch.o find_bit.o llist.o memweight.o kfifo.o \ |
29 | percpu-refcount.o percpu_ida.o rhashtable.o reciprocal_div.o | 29 | percpu-refcount.o percpu_ida.o rhashtable.o reciprocal_div.o |
30 | obj-y += string_helpers.o | 30 | obj-y += string_helpers.o |
31 | obj-$(CONFIG_TEST_STRING_HELPERS) += test-string_helpers.o | 31 | obj-$(CONFIG_TEST_STRING_HELPERS) += test-string_helpers.o |
diff --git a/lib/bitmap.c b/lib/bitmap.c index d456f4c15a9f..64c0926f5dd8 100644 --- a/lib/bitmap.c +++ b/lib/bitmap.c | |||
@@ -42,36 +42,6 @@ | |||
42 | * for the best explanations of this ordering. | 42 | * for the best explanations of this ordering. |
43 | */ | 43 | */ |
44 | 44 | ||
45 | int __bitmap_empty(const unsigned long *bitmap, unsigned int bits) | ||
46 | { | ||
47 | unsigned int k, lim = bits/BITS_PER_LONG; | ||
48 | for (k = 0; k < lim; ++k) | ||
49 | if (bitmap[k]) | ||
50 | return 0; | ||
51 | |||
52 | if (bits % BITS_PER_LONG) | ||
53 | if (bitmap[k] & BITMAP_LAST_WORD_MASK(bits)) | ||
54 | return 0; | ||
55 | |||
56 | return 1; | ||
57 | } | ||
58 | EXPORT_SYMBOL(__bitmap_empty); | ||
59 | |||
60 | int __bitmap_full(const unsigned long *bitmap, unsigned int bits) | ||
61 | { | ||
62 | unsigned int k, lim = bits/BITS_PER_LONG; | ||
63 | for (k = 0; k < lim; ++k) | ||
64 | if (~bitmap[k]) | ||
65 | return 0; | ||
66 | |||
67 | if (bits % BITS_PER_LONG) | ||
68 | if (~bitmap[k] & BITMAP_LAST_WORD_MASK(bits)) | ||
69 | return 0; | ||
70 | |||
71 | return 1; | ||
72 | } | ||
73 | EXPORT_SYMBOL(__bitmap_full); | ||
74 | |||
75 | int __bitmap_equal(const unsigned long *bitmap1, | 45 | int __bitmap_equal(const unsigned long *bitmap1, |
76 | const unsigned long *bitmap2, unsigned int bits) | 46 | const unsigned long *bitmap2, unsigned int bits) |
77 | { | 47 | { |
diff --git a/lib/cpumask.c b/lib/cpumask.c index b6513a9f2892..5ab1553fd076 100644 --- a/lib/cpumask.c +++ b/lib/cpumask.c | |||
@@ -37,10 +37,11 @@ EXPORT_SYMBOL(__next_cpu_nr); | |||
37 | int cpumask_next_and(int n, const struct cpumask *src1p, | 37 | int cpumask_next_and(int n, const struct cpumask *src1p, |
38 | const struct cpumask *src2p) | 38 | const struct cpumask *src2p) |
39 | { | 39 | { |
40 | while ((n = cpumask_next(n, src1p)) < nr_cpu_ids) | 40 | struct cpumask tmp; |
41 | if (cpumask_test_cpu(n, src2p)) | 41 | |
42 | break; | 42 | if (cpumask_and(&tmp, src1p, src2p)) |
43 | return n; | 43 | return cpumask_next(n, &tmp); |
44 | return nr_cpu_ids; | ||
44 | } | 45 | } |
45 | EXPORT_SYMBOL(cpumask_next_and); | 46 | EXPORT_SYMBOL(cpumask_next_and); |
46 | 47 | ||
diff --git a/lib/div64.c b/lib/div64.c index 4382ad77777e..19ea7ed4b948 100644 --- a/lib/div64.c +++ b/lib/div64.c | |||
@@ -127,7 +127,7 @@ EXPORT_SYMBOL(div64_u64_rem); | |||
127 | * by the book 'Hacker's Delight'. The original source and full proof | 127 | * by the book 'Hacker's Delight'. The original source and full proof |
128 | * can be found here and is available for use without restriction. | 128 | * can be found here and is available for use without restriction. |
129 | * | 129 | * |
130 | * 'http://www.hackersdelight.org/HDcode/newCode/divDouble.c.txt' | 130 | * 'http://www.hackersdelight.org/hdcodetxt/divDouble.c.txt' |
131 | */ | 131 | */ |
132 | #ifndef div64_u64 | 132 | #ifndef div64_u64 |
133 | u64 div64_u64(u64 dividend, u64 divisor) | 133 | u64 div64_u64(u64 dividend, u64 divisor) |
diff --git a/lib/dma-debug.c b/lib/dma-debug.c index 9722bd2dbc9b..ae4b65e17e64 100644 --- a/lib/dma-debug.c +++ b/lib/dma-debug.c | |||
@@ -361,7 +361,7 @@ static struct dma_debug_entry *bucket_find_contain(struct hash_bucket **bucket, | |||
361 | unsigned int range = 0; | 361 | unsigned int range = 0; |
362 | 362 | ||
363 | while (range <= max_range) { | 363 | while (range <= max_range) { |
364 | entry = __hash_bucket_find(*bucket, &index, containing_match); | 364 | entry = __hash_bucket_find(*bucket, ref, containing_match); |
365 | 365 | ||
366 | if (entry) | 366 | if (entry) |
367 | return entry; | 367 | return entry; |
diff --git a/lib/find_bit.c b/lib/find_bit.c new file mode 100644 index 000000000000..18072ea9c20e --- /dev/null +++ b/lib/find_bit.c | |||
@@ -0,0 +1,193 @@ | |||
1 | /* bit search implementation | ||
2 | * | ||
3 | * Copyright (C) 2004 Red Hat, Inc. All Rights Reserved. | ||
4 | * Written by David Howells (dhowells@redhat.com) | ||
5 | * | ||
6 | * Copyright (C) 2008 IBM Corporation | ||
7 | * 'find_last_bit' is written by Rusty Russell <rusty@rustcorp.com.au> | ||
8 | * (Inspired by David Howell's find_next_bit implementation) | ||
9 | * | ||
10 | * Rewritten by Yury Norov <yury.norov@gmail.com> to decrease | ||
11 | * size and improve performance, 2015. | ||
12 | * | ||
13 | * This program is free software; you can redistribute it and/or | ||
14 | * modify it under the terms of the GNU General Public License | ||
15 | * as published by the Free Software Foundation; either version | ||
16 | * 2 of the License, or (at your option) any later version. | ||
17 | */ | ||
18 | |||
19 | #include <linux/bitops.h> | ||
20 | #include <linux/bitmap.h> | ||
21 | #include <linux/export.h> | ||
22 | #include <linux/kernel.h> | ||
23 | |||
24 | #if !defined(find_next_bit) || !defined(find_next_zero_bit) | ||
25 | |||
26 | /* | ||
27 | * This is a common helper function for find_next_bit and | ||
28 | * find_next_zero_bit. The difference is the "invert" argument, which | ||
29 | * is XORed with each fetched word before searching it for one bits. | ||
30 | */ | ||
31 | static unsigned long _find_next_bit(const unsigned long *addr, | ||
32 | unsigned long nbits, unsigned long start, unsigned long invert) | ||
33 | { | ||
34 | unsigned long tmp; | ||
35 | |||
36 | if (!nbits || start >= nbits) | ||
37 | return nbits; | ||
38 | |||
39 | tmp = addr[start / BITS_PER_LONG] ^ invert; | ||
40 | |||
41 | /* Handle 1st word. */ | ||
42 | tmp &= BITMAP_FIRST_WORD_MASK(start); | ||
43 | start = round_down(start, BITS_PER_LONG); | ||
44 | |||
45 | while (!tmp) { | ||
46 | start += BITS_PER_LONG; | ||
47 | if (start >= nbits) | ||
48 | return nbits; | ||
49 | |||
50 | tmp = addr[start / BITS_PER_LONG] ^ invert; | ||
51 | } | ||
52 | |||
53 | return min(start + __ffs(tmp), nbits); | ||
54 | } | ||
55 | #endif | ||
56 | |||
57 | #ifndef find_next_bit | ||
58 | /* | ||
59 | * Find the next set bit in a memory region. | ||
60 | */ | ||
61 | unsigned long find_next_bit(const unsigned long *addr, unsigned long size, | ||
62 | unsigned long offset) | ||
63 | { | ||
64 | return _find_next_bit(addr, size, offset, 0UL); | ||
65 | } | ||
66 | EXPORT_SYMBOL(find_next_bit); | ||
67 | #endif | ||
68 | |||
69 | #ifndef find_next_zero_bit | ||
70 | unsigned long find_next_zero_bit(const unsigned long *addr, unsigned long size, | ||
71 | unsigned long offset) | ||
72 | { | ||
73 | return _find_next_bit(addr, size, offset, ~0UL); | ||
74 | } | ||
75 | EXPORT_SYMBOL(find_next_zero_bit); | ||
76 | #endif | ||
77 | |||
78 | #ifndef find_first_bit | ||
79 | /* | ||
80 | * Find the first set bit in a memory region. | ||
81 | */ | ||
82 | unsigned long find_first_bit(const unsigned long *addr, unsigned long size) | ||
83 | { | ||
84 | unsigned long idx; | ||
85 | |||
86 | for (idx = 0; idx * BITS_PER_LONG < size; idx++) { | ||
87 | if (addr[idx]) | ||
88 | return min(idx * BITS_PER_LONG + __ffs(addr[idx]), size); | ||
89 | } | ||
90 | |||
91 | return size; | ||
92 | } | ||
93 | EXPORT_SYMBOL(find_first_bit); | ||
94 | #endif | ||
95 | |||
96 | #ifndef find_first_zero_bit | ||
97 | /* | ||
98 | * Find the first cleared bit in a memory region. | ||
99 | */ | ||
100 | unsigned long find_first_zero_bit(const unsigned long *addr, unsigned long size) | ||
101 | { | ||
102 | unsigned long idx; | ||
103 | |||
104 | for (idx = 0; idx * BITS_PER_LONG < size; idx++) { | ||
105 | if (addr[idx] != ~0UL) | ||
106 | return min(idx * BITS_PER_LONG + ffz(addr[idx]), size); | ||
107 | } | ||
108 | |||
109 | return size; | ||
110 | } | ||
111 | EXPORT_SYMBOL(find_first_zero_bit); | ||
112 | #endif | ||
113 | |||
114 | #ifndef find_last_bit | ||
115 | unsigned long find_last_bit(const unsigned long *addr, unsigned long size) | ||
116 | { | ||
117 | if (size) { | ||
118 | unsigned long val = BITMAP_LAST_WORD_MASK(size); | ||
119 | unsigned long idx = (size-1) / BITS_PER_LONG; | ||
120 | |||
121 | do { | ||
122 | val &= addr[idx]; | ||
123 | if (val) | ||
124 | return idx * BITS_PER_LONG + __fls(val); | ||
125 | |||
126 | val = ~0ul; | ||
127 | } while (idx--); | ||
128 | } | ||
129 | return size; | ||
130 | } | ||
131 | EXPORT_SYMBOL(find_last_bit); | ||
132 | #endif | ||
133 | |||
134 | #ifdef __BIG_ENDIAN | ||
135 | |||
136 | /* include/linux/byteorder does not support "unsigned long" type */ | ||
137 | static inline unsigned long ext2_swab(const unsigned long y) | ||
138 | { | ||
139 | #if BITS_PER_LONG == 64 | ||
140 | return (unsigned long) __swab64((u64) y); | ||
141 | #elif BITS_PER_LONG == 32 | ||
142 | return (unsigned long) __swab32((u32) y); | ||
143 | #else | ||
144 | #error BITS_PER_LONG not defined | ||
145 | #endif | ||
146 | } | ||
147 | |||
148 | #if !defined(find_next_bit_le) || !defined(find_next_zero_bit_le) | ||
149 | static unsigned long _find_next_bit_le(const unsigned long *addr, | ||
150 | unsigned long nbits, unsigned long start, unsigned long invert) | ||
151 | { | ||
152 | unsigned long tmp; | ||
153 | |||
154 | if (!nbits || start >= nbits) | ||
155 | return nbits; | ||
156 | |||
157 | tmp = addr[start / BITS_PER_LONG] ^ invert; | ||
158 | |||
159 | /* Handle 1st word. */ | ||
160 | tmp &= ext2_swab(BITMAP_FIRST_WORD_MASK(start)); | ||
161 | start = round_down(start, BITS_PER_LONG); | ||
162 | |||
163 | while (!tmp) { | ||
164 | start += BITS_PER_LONG; | ||
165 | if (start >= nbits) | ||
166 | return nbits; | ||
167 | |||
168 | tmp = addr[start / BITS_PER_LONG] ^ invert; | ||
169 | } | ||
170 | |||
171 | return min(start + __ffs(ext2_swab(tmp)), nbits); | ||
172 | } | ||
173 | #endif | ||
174 | |||
175 | #ifndef find_next_zero_bit_le | ||
176 | unsigned long find_next_zero_bit_le(const void *addr, unsigned | ||
177 | long size, unsigned long offset) | ||
178 | { | ||
179 | return _find_next_bit_le(addr, size, offset, ~0UL); | ||
180 | } | ||
181 | EXPORT_SYMBOL(find_next_zero_bit_le); | ||
182 | #endif | ||
183 | |||
184 | #ifndef find_next_bit_le | ||
185 | unsigned long find_next_bit_le(const void *addr, unsigned | ||
186 | long size, unsigned long offset) | ||
187 | { | ||
188 | return _find_next_bit_le(addr, size, offset, 0UL); | ||
189 | } | ||
190 | EXPORT_SYMBOL(find_next_bit_le); | ||
191 | #endif | ||
192 | |||
193 | #endif /* __BIG_ENDIAN */ | ||
diff --git a/lib/find_last_bit.c b/lib/find_last_bit.c index 91ca09fbf6f9..3e3be40c6a6e 100644 --- a/lib/find_last_bit.c +++ b/lib/find_last_bit.c | |||
@@ -4,6 +4,9 @@ | |||
4 | * Written by Rusty Russell <rusty@rustcorp.com.au> | 4 | * Written by Rusty Russell <rusty@rustcorp.com.au> |
5 | * (Inspired by David Howell's find_next_bit implementation) | 5 | * (Inspired by David Howell's find_next_bit implementation) |
6 | * | 6 | * |
7 | * Rewritten by Yury Norov <yury.norov@gmail.com> to decrease | ||
8 | * size and improve performance, 2015. | ||
9 | * | ||
7 | * This program is free software; you can redistribute it and/or | 10 | * This program is free software; you can redistribute it and/or |
8 | * modify it under the terms of the GNU General Public License | 11 | * modify it under the terms of the GNU General Public License |
9 | * as published by the Free Software Foundation; either version | 12 | * as published by the Free Software Foundation; either version |
@@ -11,37 +14,26 @@ | |||
11 | */ | 14 | */ |
12 | 15 | ||
13 | #include <linux/bitops.h> | 16 | #include <linux/bitops.h> |
17 | #include <linux/bitmap.h> | ||
14 | #include <linux/export.h> | 18 | #include <linux/export.h> |
15 | #include <asm/types.h> | 19 | #include <linux/kernel.h> |
16 | #include <asm/byteorder.h> | ||
17 | 20 | ||
18 | #ifndef find_last_bit | 21 | #ifndef find_last_bit |
19 | 22 | ||
20 | unsigned long find_last_bit(const unsigned long *addr, unsigned long size) | 23 | unsigned long find_last_bit(const unsigned long *addr, unsigned long size) |
21 | { | 24 | { |
22 | unsigned long words; | 25 | if (size) { |
23 | unsigned long tmp; | 26 | unsigned long val = BITMAP_LAST_WORD_MASK(size); |
24 | 27 | unsigned long idx = (size-1) / BITS_PER_LONG; | |
25 | /* Start at final word. */ | ||
26 | words = size / BITS_PER_LONG; | ||
27 | 28 | ||
28 | /* Partial final word? */ | 29 | do { |
29 | if (size & (BITS_PER_LONG-1)) { | 30 | val &= addr[idx]; |
30 | tmp = (addr[words] & (~0UL >> (BITS_PER_LONG | 31 | if (val) |
31 | - (size & (BITS_PER_LONG-1))))); | 32 | return idx * BITS_PER_LONG + __fls(val); |
32 | if (tmp) | ||
33 | goto found; | ||
34 | } | ||
35 | 33 | ||
36 | while (words) { | 34 | val = ~0ul; |
37 | tmp = addr[--words]; | 35 | } while (idx--); |
38 | if (tmp) { | ||
39 | found: | ||
40 | return words * BITS_PER_LONG + __fls(tmp); | ||
41 | } | ||
42 | } | 36 | } |
43 | |||
44 | /* Not found */ | ||
45 | return size; | 37 | return size; |
46 | } | 38 | } |
47 | EXPORT_SYMBOL(find_last_bit); | 39 | EXPORT_SYMBOL(find_last_bit); |
diff --git a/lib/find_next_bit.c b/lib/find_next_bit.c deleted file mode 100644 index 0cbfc0b4398f..000000000000 --- a/lib/find_next_bit.c +++ /dev/null | |||
@@ -1,285 +0,0 @@ | |||
1 | /* find_next_bit.c: fallback find next bit implementation | ||
2 | * | ||
3 | * Copyright (C) 2004 Red Hat, Inc. All Rights Reserved. | ||
4 | * Written by David Howells (dhowells@redhat.com) | ||
5 | * | ||
6 | * This program is free software; you can redistribute it and/or | ||
7 | * modify it under the terms of the GNU General Public License | ||
8 | * as published by the Free Software Foundation; either version | ||
9 | * 2 of the License, or (at your option) any later version. | ||
10 | */ | ||
11 | |||
12 | #include <linux/bitops.h> | ||
13 | #include <linux/export.h> | ||
14 | #include <asm/types.h> | ||
15 | #include <asm/byteorder.h> | ||
16 | |||
17 | #define BITOP_WORD(nr) ((nr) / BITS_PER_LONG) | ||
18 | |||
19 | #ifndef find_next_bit | ||
20 | /* | ||
21 | * Find the next set bit in a memory region. | ||
22 | */ | ||
23 | unsigned long find_next_bit(const unsigned long *addr, unsigned long size, | ||
24 | unsigned long offset) | ||
25 | { | ||
26 | const unsigned long *p = addr + BITOP_WORD(offset); | ||
27 | unsigned long result = offset & ~(BITS_PER_LONG-1); | ||
28 | unsigned long tmp; | ||
29 | |||
30 | if (offset >= size) | ||
31 | return size; | ||
32 | size -= result; | ||
33 | offset %= BITS_PER_LONG; | ||
34 | if (offset) { | ||
35 | tmp = *(p++); | ||
36 | tmp &= (~0UL << offset); | ||
37 | if (size < BITS_PER_LONG) | ||
38 | goto found_first; | ||
39 | if (tmp) | ||
40 | goto found_middle; | ||
41 | size -= BITS_PER_LONG; | ||
42 | result += BITS_PER_LONG; | ||
43 | } | ||
44 | while (size & ~(BITS_PER_LONG-1)) { | ||
45 | if ((tmp = *(p++))) | ||
46 | goto found_middle; | ||
47 | result += BITS_PER_LONG; | ||
48 | size -= BITS_PER_LONG; | ||
49 | } | ||
50 | if (!size) | ||
51 | return result; | ||
52 | tmp = *p; | ||
53 | |||
54 | found_first: | ||
55 | tmp &= (~0UL >> (BITS_PER_LONG - size)); | ||
56 | if (tmp == 0UL) /* Are any bits set? */ | ||
57 | return result + size; /* Nope. */ | ||
58 | found_middle: | ||
59 | return result + __ffs(tmp); | ||
60 | } | ||
61 | EXPORT_SYMBOL(find_next_bit); | ||
62 | #endif | ||
63 | |||
64 | #ifndef find_next_zero_bit | ||
65 | /* | ||
66 | * This implementation of find_{first,next}_zero_bit was stolen from | ||
67 | * Linus' asm-alpha/bitops.h. | ||
68 | */ | ||
69 | unsigned long find_next_zero_bit(const unsigned long *addr, unsigned long size, | ||
70 | unsigned long offset) | ||
71 | { | ||
72 | const unsigned long *p = addr + BITOP_WORD(offset); | ||
73 | unsigned long result = offset & ~(BITS_PER_LONG-1); | ||
74 | unsigned long tmp; | ||
75 | |||
76 | if (offset >= size) | ||
77 | return size; | ||
78 | size -= result; | ||
79 | offset %= BITS_PER_LONG; | ||
80 | if (offset) { | ||
81 | tmp = *(p++); | ||
82 | tmp |= ~0UL >> (BITS_PER_LONG - offset); | ||
83 | if (size < BITS_PER_LONG) | ||
84 | goto found_first; | ||
85 | if (~tmp) | ||
86 | goto found_middle; | ||
87 | size -= BITS_PER_LONG; | ||
88 | result += BITS_PER_LONG; | ||
89 | } | ||
90 | while (size & ~(BITS_PER_LONG-1)) { | ||
91 | if (~(tmp = *(p++))) | ||
92 | goto found_middle; | ||
93 | result += BITS_PER_LONG; | ||
94 | size -= BITS_PER_LONG; | ||
95 | } | ||
96 | if (!size) | ||
97 | return result; | ||
98 | tmp = *p; | ||
99 | |||
100 | found_first: | ||
101 | tmp |= ~0UL << size; | ||
102 | if (tmp == ~0UL) /* Are any bits zero? */ | ||
103 | return result + size; /* Nope. */ | ||
104 | found_middle: | ||
105 | return result + ffz(tmp); | ||
106 | } | ||
107 | EXPORT_SYMBOL(find_next_zero_bit); | ||
108 | #endif | ||
109 | |||
110 | #ifndef find_first_bit | ||
111 | /* | ||
112 | * Find the first set bit in a memory region. | ||
113 | */ | ||
114 | unsigned long find_first_bit(const unsigned long *addr, unsigned long size) | ||
115 | { | ||
116 | const unsigned long *p = addr; | ||
117 | unsigned long result = 0; | ||
118 | unsigned long tmp; | ||
119 | |||
120 | while (size & ~(BITS_PER_LONG-1)) { | ||
121 | if ((tmp = *(p++))) | ||
122 | goto found; | ||
123 | result += BITS_PER_LONG; | ||
124 | size -= BITS_PER_LONG; | ||
125 | } | ||
126 | if (!size) | ||
127 | return result; | ||
128 | |||
129 | tmp = (*p) & (~0UL >> (BITS_PER_LONG - size)); | ||
130 | if (tmp == 0UL) /* Are any bits set? */ | ||
131 | return result + size; /* Nope. */ | ||
132 | found: | ||
133 | return result + __ffs(tmp); | ||
134 | } | ||
135 | EXPORT_SYMBOL(find_first_bit); | ||
136 | #endif | ||
137 | |||
138 | #ifndef find_first_zero_bit | ||
139 | /* | ||
140 | * Find the first cleared bit in a memory region. | ||
141 | */ | ||
142 | unsigned long find_first_zero_bit(const unsigned long *addr, unsigned long size) | ||
143 | { | ||
144 | const unsigned long *p = addr; | ||
145 | unsigned long result = 0; | ||
146 | unsigned long tmp; | ||
147 | |||
148 | while (size & ~(BITS_PER_LONG-1)) { | ||
149 | if (~(tmp = *(p++))) | ||
150 | goto found; | ||
151 | result += BITS_PER_LONG; | ||
152 | size -= BITS_PER_LONG; | ||
153 | } | ||
154 | if (!size) | ||
155 | return result; | ||
156 | |||
157 | tmp = (*p) | (~0UL << size); | ||
158 | if (tmp == ~0UL) /* Are any bits zero? */ | ||
159 | return result + size; /* Nope. */ | ||
160 | found: | ||
161 | return result + ffz(tmp); | ||
162 | } | ||
163 | EXPORT_SYMBOL(find_first_zero_bit); | ||
164 | #endif | ||
165 | |||
166 | #ifdef __BIG_ENDIAN | ||
167 | |||
168 | /* include/linux/byteorder does not support "unsigned long" type */ | ||
169 | static inline unsigned long ext2_swabp(const unsigned long * x) | ||
170 | { | ||
171 | #if BITS_PER_LONG == 64 | ||
172 | return (unsigned long) __swab64p((u64 *) x); | ||
173 | #elif BITS_PER_LONG == 32 | ||
174 | return (unsigned long) __swab32p((u32 *) x); | ||
175 | #else | ||
176 | #error BITS_PER_LONG not defined | ||
177 | #endif | ||
178 | } | ||
179 | |||
180 | /* include/linux/byteorder doesn't support "unsigned long" type */ | ||
181 | static inline unsigned long ext2_swab(const unsigned long y) | ||
182 | { | ||
183 | #if BITS_PER_LONG == 64 | ||
184 | return (unsigned long) __swab64((u64) y); | ||
185 | #elif BITS_PER_LONG == 32 | ||
186 | return (unsigned long) __swab32((u32) y); | ||
187 | #else | ||
188 | #error BITS_PER_LONG not defined | ||
189 | #endif | ||
190 | } | ||
191 | |||
192 | #ifndef find_next_zero_bit_le | ||
193 | unsigned long find_next_zero_bit_le(const void *addr, unsigned | ||
194 | long size, unsigned long offset) | ||
195 | { | ||
196 | const unsigned long *p = addr; | ||
197 | unsigned long result = offset & ~(BITS_PER_LONG - 1); | ||
198 | unsigned long tmp; | ||
199 | |||
200 | if (offset >= size) | ||
201 | return size; | ||
202 | p += BITOP_WORD(offset); | ||
203 | size -= result; | ||
204 | offset &= (BITS_PER_LONG - 1UL); | ||
205 | if (offset) { | ||
206 | tmp = ext2_swabp(p++); | ||
207 | tmp |= (~0UL >> (BITS_PER_LONG - offset)); | ||
208 | if (size < BITS_PER_LONG) | ||
209 | goto found_first; | ||
210 | if (~tmp) | ||
211 | goto found_middle; | ||
212 | size -= BITS_PER_LONG; | ||
213 | result += BITS_PER_LONG; | ||
214 | } | ||
215 | |||
216 | while (size & ~(BITS_PER_LONG - 1)) { | ||
217 | if (~(tmp = *(p++))) | ||
218 | goto found_middle_swap; | ||
219 | result += BITS_PER_LONG; | ||
220 | size -= BITS_PER_LONG; | ||
221 | } | ||
222 | if (!size) | ||
223 | return result; | ||
224 | tmp = ext2_swabp(p); | ||
225 | found_first: | ||
226 | tmp |= ~0UL << size; | ||
227 | if (tmp == ~0UL) /* Are any bits zero? */ | ||
228 | return result + size; /* Nope. Skip ffz */ | ||
229 | found_middle: | ||
230 | return result + ffz(tmp); | ||
231 | |||
232 | found_middle_swap: | ||
233 | return result + ffz(ext2_swab(tmp)); | ||
234 | } | ||
235 | EXPORT_SYMBOL(find_next_zero_bit_le); | ||
236 | #endif | ||
237 | |||
238 | #ifndef find_next_bit_le | ||
239 | unsigned long find_next_bit_le(const void *addr, unsigned | ||
240 | long size, unsigned long offset) | ||
241 | { | ||
242 | const unsigned long *p = addr; | ||
243 | unsigned long result = offset & ~(BITS_PER_LONG - 1); | ||
244 | unsigned long tmp; | ||
245 | |||
246 | if (offset >= size) | ||
247 | return size; | ||
248 | p += BITOP_WORD(offset); | ||
249 | size -= result; | ||
250 | offset &= (BITS_PER_LONG - 1UL); | ||
251 | if (offset) { | ||
252 | tmp = ext2_swabp(p++); | ||
253 | tmp &= (~0UL << offset); | ||
254 | if (size < BITS_PER_LONG) | ||
255 | goto found_first; | ||
256 | if (tmp) | ||
257 | goto found_middle; | ||
258 | size -= BITS_PER_LONG; | ||
259 | result += BITS_PER_LONG; | ||
260 | } | ||
261 | |||
262 | while (size & ~(BITS_PER_LONG - 1)) { | ||
263 | tmp = *(p++); | ||
264 | if (tmp) | ||
265 | goto found_middle_swap; | ||
266 | result += BITS_PER_LONG; | ||
267 | size -= BITS_PER_LONG; | ||
268 | } | ||
269 | if (!size) | ||
270 | return result; | ||
271 | tmp = ext2_swabp(p); | ||
272 | found_first: | ||
273 | tmp &= (~0UL >> (BITS_PER_LONG - size)); | ||
274 | if (tmp == 0UL) /* Are any bits set? */ | ||
275 | return result + size; /* Nope. */ | ||
276 | found_middle: | ||
277 | return result + __ffs(tmp); | ||
278 | |||
279 | found_middle_swap: | ||
280 | return result + __ffs(ext2_swab(tmp)); | ||
281 | } | ||
282 | EXPORT_SYMBOL(find_next_bit_le); | ||
283 | #endif | ||
284 | |||
285 | #endif /* __BIG_ENDIAN */ | ||
diff --git a/lib/ioremap.c b/lib/ioremap.c index 0c9216c48762..86c8911b0e3a 100644 --- a/lib/ioremap.c +++ b/lib/ioremap.c | |||
@@ -13,6 +13,43 @@ | |||
13 | #include <asm/cacheflush.h> | 13 | #include <asm/cacheflush.h> |
14 | #include <asm/pgtable.h> | 14 | #include <asm/pgtable.h> |
15 | 15 | ||
16 | #ifdef CONFIG_HAVE_ARCH_HUGE_VMAP | ||
17 | static int __read_mostly ioremap_pud_capable; | ||
18 | static int __read_mostly ioremap_pmd_capable; | ||
19 | static int __read_mostly ioremap_huge_disabled; | ||
20 | |||
21 | static int __init set_nohugeiomap(char *str) | ||
22 | { | ||
23 | ioremap_huge_disabled = 1; | ||
24 | return 0; | ||
25 | } | ||
26 | early_param("nohugeiomap", set_nohugeiomap); | ||
27 | |||
28 | void __init ioremap_huge_init(void) | ||
29 | { | ||
30 | if (!ioremap_huge_disabled) { | ||
31 | if (arch_ioremap_pud_supported()) | ||
32 | ioremap_pud_capable = 1; | ||
33 | if (arch_ioremap_pmd_supported()) | ||
34 | ioremap_pmd_capable = 1; | ||
35 | } | ||
36 | } | ||
37 | |||
38 | static inline int ioremap_pud_enabled(void) | ||
39 | { | ||
40 | return ioremap_pud_capable; | ||
41 | } | ||
42 | |||
43 | static inline int ioremap_pmd_enabled(void) | ||
44 | { | ||
45 | return ioremap_pmd_capable; | ||
46 | } | ||
47 | |||
48 | #else /* !CONFIG_HAVE_ARCH_HUGE_VMAP */ | ||
49 | static inline int ioremap_pud_enabled(void) { return 0; } | ||
50 | static inline int ioremap_pmd_enabled(void) { return 0; } | ||
51 | #endif /* CONFIG_HAVE_ARCH_HUGE_VMAP */ | ||
52 | |||
16 | static int ioremap_pte_range(pmd_t *pmd, unsigned long addr, | 53 | static int ioremap_pte_range(pmd_t *pmd, unsigned long addr, |
17 | unsigned long end, phys_addr_t phys_addr, pgprot_t prot) | 54 | unsigned long end, phys_addr_t phys_addr, pgprot_t prot) |
18 | { | 55 | { |
@@ -43,6 +80,14 @@ static inline int ioremap_pmd_range(pud_t *pud, unsigned long addr, | |||
43 | return -ENOMEM; | 80 | return -ENOMEM; |
44 | do { | 81 | do { |
45 | next = pmd_addr_end(addr, end); | 82 | next = pmd_addr_end(addr, end); |
83 | |||
84 | if (ioremap_pmd_enabled() && | ||
85 | ((next - addr) == PMD_SIZE) && | ||
86 | IS_ALIGNED(phys_addr + addr, PMD_SIZE)) { | ||
87 | if (pmd_set_huge(pmd, phys_addr + addr, prot)) | ||
88 | continue; | ||
89 | } | ||
90 | |||
46 | if (ioremap_pte_range(pmd, addr, next, phys_addr + addr, prot)) | 91 | if (ioremap_pte_range(pmd, addr, next, phys_addr + addr, prot)) |
47 | return -ENOMEM; | 92 | return -ENOMEM; |
48 | } while (pmd++, addr = next, addr != end); | 93 | } while (pmd++, addr = next, addr != end); |
@@ -61,6 +106,14 @@ static inline int ioremap_pud_range(pgd_t *pgd, unsigned long addr, | |||
61 | return -ENOMEM; | 106 | return -ENOMEM; |
62 | do { | 107 | do { |
63 | next = pud_addr_end(addr, end); | 108 | next = pud_addr_end(addr, end); |
109 | |||
110 | if (ioremap_pud_enabled() && | ||
111 | ((next - addr) == PUD_SIZE) && | ||
112 | IS_ALIGNED(phys_addr + addr, PUD_SIZE)) { | ||
113 | if (pud_set_huge(pud, phys_addr + addr, prot)) | ||
114 | continue; | ||
115 | } | ||
116 | |||
64 | if (ioremap_pmd_range(pud, addr, next, phys_addr + addr, prot)) | 117 | if (ioremap_pmd_range(pud, addr, next, phys_addr + addr, prot)) |
65 | return -ENOMEM; | 118 | return -ENOMEM; |
66 | } while (pud++, addr = next, addr != end); | 119 | } while (pud++, addr = next, addr != end); |
diff --git a/lib/iov_iter.c b/lib/iov_iter.c index 9d96e283520c..75232ad0a5e7 100644 --- a/lib/iov_iter.c +++ b/lib/iov_iter.c | |||
@@ -317,6 +317,32 @@ int iov_iter_fault_in_readable(struct iov_iter *i, size_t bytes) | |||
317 | } | 317 | } |
318 | EXPORT_SYMBOL(iov_iter_fault_in_readable); | 318 | EXPORT_SYMBOL(iov_iter_fault_in_readable); |
319 | 319 | ||
320 | /* | ||
321 | * Fault in one or more iovecs of the given iov_iter, to a maximum length of | ||
322 | * bytes. For each iovec, fault in each page that constitutes the iovec. | ||
323 | * | ||
324 | * Return 0 on success, or non-zero if the memory could not be accessed (i.e. | ||
325 | * because it is an invalid address). | ||
326 | */ | ||
327 | int iov_iter_fault_in_multipages_readable(struct iov_iter *i, size_t bytes) | ||
328 | { | ||
329 | size_t skip = i->iov_offset; | ||
330 | const struct iovec *iov; | ||
331 | int err; | ||
332 | struct iovec v; | ||
333 | |||
334 | if (!(i->type & (ITER_BVEC|ITER_KVEC))) { | ||
335 | iterate_iovec(i, bytes, v, iov, skip, ({ | ||
336 | err = fault_in_multipages_readable(v.iov_base, | ||
337 | v.iov_len); | ||
338 | if (unlikely(err)) | ||
339 | return err; | ||
340 | 0;})) | ||
341 | } | ||
342 | return 0; | ||
343 | } | ||
344 | EXPORT_SYMBOL(iov_iter_fault_in_multipages_readable); | ||
345 | |||
320 | void iov_iter_init(struct iov_iter *i, int direction, | 346 | void iov_iter_init(struct iov_iter *i, int direction, |
321 | const struct iovec *iov, unsigned long nr_segs, | 347 | const struct iovec *iov, unsigned long nr_segs, |
322 | size_t count) | 348 | size_t count) |
@@ -766,3 +792,60 @@ const void *dup_iter(struct iov_iter *new, struct iov_iter *old, gfp_t flags) | |||
766 | flags); | 792 | flags); |
767 | } | 793 | } |
768 | EXPORT_SYMBOL(dup_iter); | 794 | EXPORT_SYMBOL(dup_iter); |
795 | |||
796 | int import_iovec(int type, const struct iovec __user * uvector, | ||
797 | unsigned nr_segs, unsigned fast_segs, | ||
798 | struct iovec **iov, struct iov_iter *i) | ||
799 | { | ||
800 | ssize_t n; | ||
801 | struct iovec *p; | ||
802 | n = rw_copy_check_uvector(type, uvector, nr_segs, fast_segs, | ||
803 | *iov, &p); | ||
804 | if (n < 0) { | ||
805 | if (p != *iov) | ||
806 | kfree(p); | ||
807 | *iov = NULL; | ||
808 | return n; | ||
809 | } | ||
810 | iov_iter_init(i, type, p, nr_segs, n); | ||
811 | *iov = p == *iov ? NULL : p; | ||
812 | return 0; | ||
813 | } | ||
814 | EXPORT_SYMBOL(import_iovec); | ||
815 | |||
816 | #ifdef CONFIG_COMPAT | ||
817 | #include <linux/compat.h> | ||
818 | |||
819 | int compat_import_iovec(int type, const struct compat_iovec __user * uvector, | ||
820 | unsigned nr_segs, unsigned fast_segs, | ||
821 | struct iovec **iov, struct iov_iter *i) | ||
822 | { | ||
823 | ssize_t n; | ||
824 | struct iovec *p; | ||
825 | n = compat_rw_copy_check_uvector(type, uvector, nr_segs, fast_segs, | ||
826 | *iov, &p); | ||
827 | if (n < 0) { | ||
828 | if (p != *iov) | ||
829 | kfree(p); | ||
830 | *iov = NULL; | ||
831 | return n; | ||
832 | } | ||
833 | iov_iter_init(i, type, p, nr_segs, n); | ||
834 | *iov = p == *iov ? NULL : p; | ||
835 | return 0; | ||
836 | } | ||
837 | #endif | ||
838 | |||
839 | int import_single_range(int rw, void __user *buf, size_t len, | ||
840 | struct iovec *iov, struct iov_iter *i) | ||
841 | { | ||
842 | if (len > MAX_RW_COUNT) | ||
843 | len = MAX_RW_COUNT; | ||
844 | if (unlikely(!access_ok(!rw, buf, len))) | ||
845 | return -EFAULT; | ||
846 | |||
847 | iov->iov_base = buf; | ||
848 | iov->iov_len = len; | ||
849 | iov_iter_init(i, rw, iov, 1, len); | ||
850 | return 0; | ||
851 | } | ||
diff --git a/lib/kobject.c b/lib/kobject.c index 03d4ab349fa7..3b841b97fccd 100644 --- a/lib/kobject.c +++ b/lib/kobject.c | |||
@@ -576,8 +576,13 @@ void kobject_del(struct kobject *kobj) | |||
576 | */ | 576 | */ |
577 | struct kobject *kobject_get(struct kobject *kobj) | 577 | struct kobject *kobject_get(struct kobject *kobj) |
578 | { | 578 | { |
579 | if (kobj) | 579 | if (kobj) { |
580 | if (!kobj->state_initialized) | ||
581 | WARN(1, KERN_WARNING "kobject: '%s' (%p): is not " | ||
582 | "initialized, yet kobject_get() is being " | ||
583 | "called.\n", kobject_name(kobj), kobj); | ||
580 | kref_get(&kobj->kref); | 584 | kref_get(&kobj->kref); |
585 | } | ||
581 | return kobj; | 586 | return kobj; |
582 | } | 587 | } |
583 | 588 | ||
diff --git a/lib/lockref.c b/lib/lockref.c index ecb9a665ec19..494994bf17c8 100644 --- a/lib/lockref.c +++ b/lib/lockref.c | |||
@@ -18,7 +18,7 @@ | |||
18 | #define CMPXCHG_LOOP(CODE, SUCCESS) do { \ | 18 | #define CMPXCHG_LOOP(CODE, SUCCESS) do { \ |
19 | struct lockref old; \ | 19 | struct lockref old; \ |
20 | BUILD_BUG_ON(sizeof(old) != 8); \ | 20 | BUILD_BUG_ON(sizeof(old) != 8); \ |
21 | old.lock_count = ACCESS_ONCE(lockref->lock_count); \ | 21 | old.lock_count = READ_ONCE(lockref->lock_count); \ |
22 | while (likely(arch_spin_value_unlocked(old.lock.rlock.raw_lock))) { \ | 22 | while (likely(arch_spin_value_unlocked(old.lock.rlock.raw_lock))) { \ |
23 | struct lockref new = old, prev = old; \ | 23 | struct lockref new = old, prev = old; \ |
24 | CODE \ | 24 | CODE \ |
diff --git a/lib/lru_cache.c b/lib/lru_cache.c index 852c81e3ba9a..028f5d996eef 100644 --- a/lib/lru_cache.c +++ b/lib/lru_cache.c | |||
@@ -247,10 +247,11 @@ size_t lc_seq_printf_stats(struct seq_file *seq, struct lru_cache *lc) | |||
247 | * progress) and "changed", when this in fact lead to an successful | 247 | * progress) and "changed", when this in fact lead to an successful |
248 | * update of the cache. | 248 | * update of the cache. |
249 | */ | 249 | */ |
250 | return seq_printf(seq, "\t%s: used:%u/%u " | 250 | seq_printf(seq, "\t%s: used:%u/%u hits:%lu misses:%lu starving:%lu locked:%lu changed:%lu\n", |
251 | "hits:%lu misses:%lu starving:%lu locked:%lu changed:%lu\n", | 251 | lc->name, lc->used, lc->nr_elements, |
252 | lc->name, lc->used, lc->nr_elements, | 252 | lc->hits, lc->misses, lc->starving, lc->locked, lc->changed); |
253 | lc->hits, lc->misses, lc->starving, lc->locked, lc->changed); | 253 | |
254 | return 0; | ||
254 | } | 255 | } |
255 | 256 | ||
256 | static struct hlist_head *lc_hash_slot(struct lru_cache *lc, unsigned int enr) | 257 | static struct hlist_head *lc_hash_slot(struct lru_cache *lc, unsigned int enr) |
diff --git a/lib/lz4/lz4_decompress.c b/lib/lz4/lz4_decompress.c index f0f5c5c3de12..26cc6029b280 100644 --- a/lib/lz4/lz4_decompress.c +++ b/lib/lz4/lz4_decompress.c | |||
@@ -47,6 +47,11 @@ | |||
47 | 47 | ||
48 | #include "lz4defs.h" | 48 | #include "lz4defs.h" |
49 | 49 | ||
50 | static const int dec32table[] = {0, 3, 2, 3, 0, 0, 0, 0}; | ||
51 | #if LZ4_ARCH64 | ||
52 | static const int dec64table[] = {0, 0, 0, -1, 0, 1, 2, 3}; | ||
53 | #endif | ||
54 | |||
50 | static int lz4_uncompress(const char *source, char *dest, int osize) | 55 | static int lz4_uncompress(const char *source, char *dest, int osize) |
51 | { | 56 | { |
52 | const BYTE *ip = (const BYTE *) source; | 57 | const BYTE *ip = (const BYTE *) source; |
@@ -56,10 +61,6 @@ static int lz4_uncompress(const char *source, char *dest, int osize) | |||
56 | BYTE *cpy; | 61 | BYTE *cpy; |
57 | unsigned token; | 62 | unsigned token; |
58 | size_t length; | 63 | size_t length; |
59 | size_t dec32table[] = {0, 3, 2, 3, 0, 0, 0, 0}; | ||
60 | #if LZ4_ARCH64 | ||
61 | size_t dec64table[] = {0, 0, 0, -1, 0, 1, 2, 3}; | ||
62 | #endif | ||
63 | 64 | ||
64 | while (1) { | 65 | while (1) { |
65 | 66 | ||
@@ -116,7 +117,7 @@ static int lz4_uncompress(const char *source, char *dest, int osize) | |||
116 | /* copy repeated sequence */ | 117 | /* copy repeated sequence */ |
117 | if (unlikely((op - ref) < STEPSIZE)) { | 118 | if (unlikely((op - ref) < STEPSIZE)) { |
118 | #if LZ4_ARCH64 | 119 | #if LZ4_ARCH64 |
119 | size_t dec64 = dec64table[op - ref]; | 120 | int dec64 = dec64table[op - ref]; |
120 | #else | 121 | #else |
121 | const int dec64 = 0; | 122 | const int dec64 = 0; |
122 | #endif | 123 | #endif |
@@ -177,11 +178,6 @@ static int lz4_uncompress_unknownoutputsize(const char *source, char *dest, | |||
177 | BYTE * const oend = op + maxoutputsize; | 178 | BYTE * const oend = op + maxoutputsize; |
178 | BYTE *cpy; | 179 | BYTE *cpy; |
179 | 180 | ||
180 | size_t dec32table[] = {0, 3, 2, 3, 0, 0, 0, 0}; | ||
181 | #if LZ4_ARCH64 | ||
182 | size_t dec64table[] = {0, 0, 0, -1, 0, 1, 2, 3}; | ||
183 | #endif | ||
184 | |||
185 | /* Main Loop */ | 181 | /* Main Loop */ |
186 | while (ip < iend) { | 182 | while (ip < iend) { |
187 | 183 | ||
@@ -249,7 +245,7 @@ static int lz4_uncompress_unknownoutputsize(const char *source, char *dest, | |||
249 | /* copy repeated sequence */ | 245 | /* copy repeated sequence */ |
250 | if (unlikely((op - ref) < STEPSIZE)) { | 246 | if (unlikely((op - ref) < STEPSIZE)) { |
251 | #if LZ4_ARCH64 | 247 | #if LZ4_ARCH64 |
252 | size_t dec64 = dec64table[op - ref]; | 248 | int dec64 = dec64table[op - ref]; |
253 | #else | 249 | #else |
254 | const int dec64 = 0; | 250 | const int dec64 = 0; |
255 | #endif | 251 | #endif |
diff --git a/lib/rhashtable.c b/lib/rhashtable.c index b5344ef4c684..4898442b837f 100644 --- a/lib/rhashtable.c +++ b/lib/rhashtable.c | |||
@@ -1,13 +1,13 @@ | |||
1 | /* | 1 | /* |
2 | * Resizable, Scalable, Concurrent Hash Table | 2 | * Resizable, Scalable, Concurrent Hash Table |
3 | * | 3 | * |
4 | * Copyright (c) 2015 Herbert Xu <herbert@gondor.apana.org.au> | ||
4 | * Copyright (c) 2014-2015 Thomas Graf <tgraf@suug.ch> | 5 | * Copyright (c) 2014-2015 Thomas Graf <tgraf@suug.ch> |
5 | * Copyright (c) 2008-2014 Patrick McHardy <kaber@trash.net> | 6 | * Copyright (c) 2008-2014 Patrick McHardy <kaber@trash.net> |
6 | * | 7 | * |
7 | * Based on the following paper: | ||
8 | * https://www.usenix.org/legacy/event/atc11/tech/final_files/Triplett.pdf | ||
9 | * | ||
10 | * Code partially derived from nft_hash | 8 | * Code partially derived from nft_hash |
9 | * Rewritten with rehash code from br_multicast plus single list | ||
10 | * pointer as suggested by Josh Triplett | ||
11 | * | 11 | * |
12 | * This program is free software; you can redistribute it and/or modify | 12 | * This program is free software; you can redistribute it and/or modify |
13 | * it under the terms of the GNU General Public License version 2 as | 13 | * it under the terms of the GNU General Public License version 2 as |
@@ -27,121 +27,18 @@ | |||
27 | #include <linux/err.h> | 27 | #include <linux/err.h> |
28 | 28 | ||
29 | #define HASH_DEFAULT_SIZE 64UL | 29 | #define HASH_DEFAULT_SIZE 64UL |
30 | #define HASH_MIN_SIZE 4UL | 30 | #define HASH_MIN_SIZE 4U |
31 | #define BUCKET_LOCKS_PER_CPU 128UL | 31 | #define BUCKET_LOCKS_PER_CPU 128UL |
32 | 32 | ||
33 | /* Base bits plus 1 bit for nulls marker */ | 33 | static u32 head_hashfn(struct rhashtable *ht, |
34 | #define HASH_RESERVED_SPACE (RHT_BASE_BITS + 1) | ||
35 | |||
36 | enum { | ||
37 | RHT_LOCK_NORMAL, | ||
38 | RHT_LOCK_NESTED, | ||
39 | }; | ||
40 | |||
41 | /* The bucket lock is selected based on the hash and protects mutations | ||
42 | * on a group of hash buckets. | ||
43 | * | ||
44 | * A maximum of tbl->size/2 bucket locks is allocated. This ensures that | ||
45 | * a single lock always covers both buckets which may both contains | ||
46 | * entries which link to the same bucket of the old table during resizing. | ||
47 | * This allows to simplify the locking as locking the bucket in both | ||
48 | * tables during resize always guarantee protection. | ||
49 | * | ||
50 | * IMPORTANT: When holding the bucket lock of both the old and new table | ||
51 | * during expansions and shrinking, the old bucket lock must always be | ||
52 | * acquired first. | ||
53 | */ | ||
54 | static spinlock_t *bucket_lock(const struct bucket_table *tbl, u32 hash) | ||
55 | { | ||
56 | return &tbl->locks[hash & tbl->locks_mask]; | ||
57 | } | ||
58 | |||
59 | static void *rht_obj(const struct rhashtable *ht, const struct rhash_head *he) | ||
60 | { | ||
61 | return (void *) he - ht->p.head_offset; | ||
62 | } | ||
63 | |||
64 | static u32 rht_bucket_index(const struct bucket_table *tbl, u32 hash) | ||
65 | { | ||
66 | return hash & (tbl->size - 1); | ||
67 | } | ||
68 | |||
69 | static u32 obj_raw_hashfn(const struct rhashtable *ht, const void *ptr) | ||
70 | { | ||
71 | u32 hash; | ||
72 | |||
73 | if (unlikely(!ht->p.key_len)) | ||
74 | hash = ht->p.obj_hashfn(ptr, ht->p.hash_rnd); | ||
75 | else | ||
76 | hash = ht->p.hashfn(ptr + ht->p.key_offset, ht->p.key_len, | ||
77 | ht->p.hash_rnd); | ||
78 | |||
79 | return hash >> HASH_RESERVED_SPACE; | ||
80 | } | ||
81 | |||
82 | static u32 key_hashfn(struct rhashtable *ht, const void *key, u32 len) | ||
83 | { | ||
84 | return ht->p.hashfn(key, len, ht->p.hash_rnd) >> HASH_RESERVED_SPACE; | ||
85 | } | ||
86 | |||
87 | static u32 head_hashfn(const struct rhashtable *ht, | ||
88 | const struct bucket_table *tbl, | 34 | const struct bucket_table *tbl, |
89 | const struct rhash_head *he) | 35 | const struct rhash_head *he) |
90 | { | 36 | { |
91 | return rht_bucket_index(tbl, obj_raw_hashfn(ht, rht_obj(ht, he))); | 37 | return rht_head_hashfn(ht, tbl, he, ht->p); |
92 | } | 38 | } |
93 | 39 | ||
94 | #ifdef CONFIG_PROVE_LOCKING | 40 | #ifdef CONFIG_PROVE_LOCKING |
95 | static void debug_dump_buckets(const struct rhashtable *ht, | ||
96 | const struct bucket_table *tbl) | ||
97 | { | ||
98 | struct rhash_head *he; | ||
99 | unsigned int i, hash; | ||
100 | |||
101 | for (i = 0; i < tbl->size; i++) { | ||
102 | pr_warn(" [Bucket %d] ", i); | ||
103 | rht_for_each_rcu(he, tbl, i) { | ||
104 | hash = head_hashfn(ht, tbl, he); | ||
105 | pr_cont("[hash = %#x, lock = %p] ", | ||
106 | hash, bucket_lock(tbl, hash)); | ||
107 | } | ||
108 | pr_cont("\n"); | ||
109 | } | ||
110 | |||
111 | } | ||
112 | |||
113 | static void debug_dump_table(struct rhashtable *ht, | ||
114 | const struct bucket_table *tbl, | ||
115 | unsigned int hash) | ||
116 | { | ||
117 | struct bucket_table *old_tbl, *future_tbl; | ||
118 | |||
119 | pr_emerg("BUG: lock for hash %#x in table %p not held\n", | ||
120 | hash, tbl); | ||
121 | |||
122 | rcu_read_lock(); | ||
123 | future_tbl = rht_dereference_rcu(ht->future_tbl, ht); | ||
124 | old_tbl = rht_dereference_rcu(ht->tbl, ht); | ||
125 | if (future_tbl != old_tbl) { | ||
126 | pr_warn("Future table %p (size: %zd)\n", | ||
127 | future_tbl, future_tbl->size); | ||
128 | debug_dump_buckets(ht, future_tbl); | ||
129 | } | ||
130 | |||
131 | pr_warn("Table %p (size: %zd)\n", old_tbl, old_tbl->size); | ||
132 | debug_dump_buckets(ht, old_tbl); | ||
133 | |||
134 | rcu_read_unlock(); | ||
135 | } | ||
136 | |||
137 | #define ASSERT_RHT_MUTEX(HT) BUG_ON(!lockdep_rht_mutex_is_held(HT)) | 41 | #define ASSERT_RHT_MUTEX(HT) BUG_ON(!lockdep_rht_mutex_is_held(HT)) |
138 | #define ASSERT_BUCKET_LOCK(HT, TBL, HASH) \ | ||
139 | do { \ | ||
140 | if (unlikely(!lockdep_rht_bucket_is_held(TBL, HASH))) { \ | ||
141 | debug_dump_table(HT, TBL, HASH); \ | ||
142 | BUG(); \ | ||
143 | } \ | ||
144 | } while (0) | ||
145 | 42 | ||
146 | int lockdep_rht_mutex_is_held(struct rhashtable *ht) | 43 | int lockdep_rht_mutex_is_held(struct rhashtable *ht) |
147 | { | 44 | { |
@@ -151,30 +48,18 @@ EXPORT_SYMBOL_GPL(lockdep_rht_mutex_is_held); | |||
151 | 48 | ||
152 | int lockdep_rht_bucket_is_held(const struct bucket_table *tbl, u32 hash) | 49 | int lockdep_rht_bucket_is_held(const struct bucket_table *tbl, u32 hash) |
153 | { | 50 | { |
154 | spinlock_t *lock = bucket_lock(tbl, hash); | 51 | spinlock_t *lock = rht_bucket_lock(tbl, hash); |
155 | 52 | ||
156 | return (debug_locks) ? lockdep_is_held(lock) : 1; | 53 | return (debug_locks) ? lockdep_is_held(lock) : 1; |
157 | } | 54 | } |
158 | EXPORT_SYMBOL_GPL(lockdep_rht_bucket_is_held); | 55 | EXPORT_SYMBOL_GPL(lockdep_rht_bucket_is_held); |
159 | #else | 56 | #else |
160 | #define ASSERT_RHT_MUTEX(HT) | 57 | #define ASSERT_RHT_MUTEX(HT) |
161 | #define ASSERT_BUCKET_LOCK(HT, TBL, HASH) | ||
162 | #endif | 58 | #endif |
163 | 59 | ||
164 | 60 | ||
165 | static struct rhash_head __rcu **bucket_tail(struct bucket_table *tbl, u32 n) | 61 | static int alloc_bucket_locks(struct rhashtable *ht, struct bucket_table *tbl, |
166 | { | 62 | gfp_t gfp) |
167 | struct rhash_head __rcu **pprev; | ||
168 | |||
169 | for (pprev = &tbl->buckets[n]; | ||
170 | !rht_is_a_nulls(rht_dereference_bucket(*pprev, tbl, n)); | ||
171 | pprev = &rht_dereference_bucket(*pprev, tbl, n)->next) | ||
172 | ; | ||
173 | |||
174 | return pprev; | ||
175 | } | ||
176 | |||
177 | static int alloc_bucket_locks(struct rhashtable *ht, struct bucket_table *tbl) | ||
178 | { | 63 | { |
179 | unsigned int i, size; | 64 | unsigned int i, size; |
180 | #if defined(CONFIG_PROVE_LOCKING) | 65 | #if defined(CONFIG_PROVE_LOCKING) |
@@ -191,12 +76,13 @@ static int alloc_bucket_locks(struct rhashtable *ht, struct bucket_table *tbl) | |||
191 | 76 | ||
192 | if (sizeof(spinlock_t) != 0) { | 77 | if (sizeof(spinlock_t) != 0) { |
193 | #ifdef CONFIG_NUMA | 78 | #ifdef CONFIG_NUMA |
194 | if (size * sizeof(spinlock_t) > PAGE_SIZE) | 79 | if (size * sizeof(spinlock_t) > PAGE_SIZE && |
80 | gfp == GFP_KERNEL) | ||
195 | tbl->locks = vmalloc(size * sizeof(spinlock_t)); | 81 | tbl->locks = vmalloc(size * sizeof(spinlock_t)); |
196 | else | 82 | else |
197 | #endif | 83 | #endif |
198 | tbl->locks = kmalloc_array(size, sizeof(spinlock_t), | 84 | tbl->locks = kmalloc_array(size, sizeof(spinlock_t), |
199 | GFP_KERNEL); | 85 | gfp); |
200 | if (!tbl->locks) | 86 | if (!tbl->locks) |
201 | return -ENOMEM; | 87 | return -ENOMEM; |
202 | for (i = 0; i < size; i++) | 88 | for (i = 0; i < size; i++) |
@@ -215,153 +101,181 @@ static void bucket_table_free(const struct bucket_table *tbl) | |||
215 | kvfree(tbl); | 101 | kvfree(tbl); |
216 | } | 102 | } |
217 | 103 | ||
104 | static void bucket_table_free_rcu(struct rcu_head *head) | ||
105 | { | ||
106 | bucket_table_free(container_of(head, struct bucket_table, rcu)); | ||
107 | } | ||
108 | |||
218 | static struct bucket_table *bucket_table_alloc(struct rhashtable *ht, | 109 | static struct bucket_table *bucket_table_alloc(struct rhashtable *ht, |
219 | size_t nbuckets) | 110 | size_t nbuckets, |
111 | gfp_t gfp) | ||
220 | { | 112 | { |
221 | struct bucket_table *tbl = NULL; | 113 | struct bucket_table *tbl = NULL; |
222 | size_t size; | 114 | size_t size; |
223 | int i; | 115 | int i; |
224 | 116 | ||
225 | size = sizeof(*tbl) + nbuckets * sizeof(tbl->buckets[0]); | 117 | size = sizeof(*tbl) + nbuckets * sizeof(tbl->buckets[0]); |
226 | if (size <= (PAGE_SIZE << PAGE_ALLOC_COSTLY_ORDER)) | 118 | if (size <= (PAGE_SIZE << PAGE_ALLOC_COSTLY_ORDER) || |
227 | tbl = kzalloc(size, GFP_KERNEL | __GFP_NOWARN | __GFP_NORETRY); | 119 | gfp != GFP_KERNEL) |
228 | if (tbl == NULL) | 120 | tbl = kzalloc(size, gfp | __GFP_NOWARN | __GFP_NORETRY); |
121 | if (tbl == NULL && gfp == GFP_KERNEL) | ||
229 | tbl = vzalloc(size); | 122 | tbl = vzalloc(size); |
230 | if (tbl == NULL) | 123 | if (tbl == NULL) |
231 | return NULL; | 124 | return NULL; |
232 | 125 | ||
233 | tbl->size = nbuckets; | 126 | tbl->size = nbuckets; |
234 | 127 | ||
235 | if (alloc_bucket_locks(ht, tbl) < 0) { | 128 | if (alloc_bucket_locks(ht, tbl, gfp) < 0) { |
236 | bucket_table_free(tbl); | 129 | bucket_table_free(tbl); |
237 | return NULL; | 130 | return NULL; |
238 | } | 131 | } |
239 | 132 | ||
133 | INIT_LIST_HEAD(&tbl->walkers); | ||
134 | |||
135 | get_random_bytes(&tbl->hash_rnd, sizeof(tbl->hash_rnd)); | ||
136 | |||
240 | for (i = 0; i < nbuckets; i++) | 137 | for (i = 0; i < nbuckets; i++) |
241 | INIT_RHT_NULLS_HEAD(tbl->buckets[i], ht, i); | 138 | INIT_RHT_NULLS_HEAD(tbl->buckets[i], ht, i); |
242 | 139 | ||
243 | return tbl; | 140 | return tbl; |
244 | } | 141 | } |
245 | 142 | ||
246 | /** | 143 | static struct bucket_table *rhashtable_last_table(struct rhashtable *ht, |
247 | * rht_grow_above_75 - returns true if nelems > 0.75 * table-size | 144 | struct bucket_table *tbl) |
248 | * @ht: hash table | ||
249 | * @new_size: new table size | ||
250 | */ | ||
251 | static bool rht_grow_above_75(const struct rhashtable *ht, size_t new_size) | ||
252 | { | 145 | { |
253 | /* Expand table when exceeding 75% load */ | 146 | struct bucket_table *new_tbl; |
254 | return atomic_read(&ht->nelems) > (new_size / 4 * 3) && | ||
255 | (!ht->p.max_shift || atomic_read(&ht->shift) < ht->p.max_shift); | ||
256 | } | ||
257 | 147 | ||
258 | /** | 148 | do { |
259 | * rht_shrink_below_30 - returns true if nelems < 0.3 * table-size | 149 | new_tbl = tbl; |
260 | * @ht: hash table | 150 | tbl = rht_dereference_rcu(tbl->future_tbl, ht); |
261 | * @new_size: new table size | 151 | } while (tbl); |
262 | */ | ||
263 | static bool rht_shrink_below_30(const struct rhashtable *ht, size_t new_size) | ||
264 | { | ||
265 | /* Shrink table beneath 30% load */ | ||
266 | return atomic_read(&ht->nelems) < (new_size * 3 / 10) && | ||
267 | (atomic_read(&ht->shift) > ht->p.min_shift); | ||
268 | } | ||
269 | 152 | ||
270 | static void lock_buckets(struct bucket_table *new_tbl, | 153 | return new_tbl; |
271 | struct bucket_table *old_tbl, unsigned int hash) | ||
272 | __acquires(old_bucket_lock) | ||
273 | { | ||
274 | spin_lock_bh(bucket_lock(old_tbl, hash)); | ||
275 | if (new_tbl != old_tbl) | ||
276 | spin_lock_bh_nested(bucket_lock(new_tbl, hash), | ||
277 | RHT_LOCK_NESTED); | ||
278 | } | 154 | } |
279 | 155 | ||
280 | static void unlock_buckets(struct bucket_table *new_tbl, | 156 | static int rhashtable_rehash_one(struct rhashtable *ht, unsigned int old_hash) |
281 | struct bucket_table *old_tbl, unsigned int hash) | ||
282 | __releases(old_bucket_lock) | ||
283 | { | 157 | { |
284 | if (new_tbl != old_tbl) | 158 | struct bucket_table *old_tbl = rht_dereference(ht->tbl, ht); |
285 | spin_unlock_bh(bucket_lock(new_tbl, hash)); | 159 | struct bucket_table *new_tbl = rhashtable_last_table(ht, |
286 | spin_unlock_bh(bucket_lock(old_tbl, hash)); | 160 | rht_dereference_rcu(old_tbl->future_tbl, ht)); |
161 | struct rhash_head __rcu **pprev = &old_tbl->buckets[old_hash]; | ||
162 | int err = -ENOENT; | ||
163 | struct rhash_head *head, *next, *entry; | ||
164 | spinlock_t *new_bucket_lock; | ||
165 | unsigned int new_hash; | ||
166 | |||
167 | rht_for_each(entry, old_tbl, old_hash) { | ||
168 | err = 0; | ||
169 | next = rht_dereference_bucket(entry->next, old_tbl, old_hash); | ||
170 | |||
171 | if (rht_is_a_nulls(next)) | ||
172 | break; | ||
173 | |||
174 | pprev = &entry->next; | ||
175 | } | ||
176 | |||
177 | if (err) | ||
178 | goto out; | ||
179 | |||
180 | new_hash = head_hashfn(ht, new_tbl, entry); | ||
181 | |||
182 | new_bucket_lock = rht_bucket_lock(new_tbl, new_hash); | ||
183 | |||
184 | spin_lock_nested(new_bucket_lock, SINGLE_DEPTH_NESTING); | ||
185 | head = rht_dereference_bucket(new_tbl->buckets[new_hash], | ||
186 | new_tbl, new_hash); | ||
187 | |||
188 | if (rht_is_a_nulls(head)) | ||
189 | INIT_RHT_NULLS_HEAD(entry->next, ht, new_hash); | ||
190 | else | ||
191 | RCU_INIT_POINTER(entry->next, head); | ||
192 | |||
193 | rcu_assign_pointer(new_tbl->buckets[new_hash], entry); | ||
194 | spin_unlock(new_bucket_lock); | ||
195 | |||
196 | rcu_assign_pointer(*pprev, next); | ||
197 | |||
198 | out: | ||
199 | return err; | ||
287 | } | 200 | } |
288 | 201 | ||
289 | /** | 202 | static void rhashtable_rehash_chain(struct rhashtable *ht, |
290 | * Unlink entries on bucket which hash to different bucket. | 203 | unsigned int old_hash) |
291 | * | ||
292 | * Returns true if no more work needs to be performed on the bucket. | ||
293 | */ | ||
294 | static bool hashtable_chain_unzip(struct rhashtable *ht, | ||
295 | const struct bucket_table *new_tbl, | ||
296 | struct bucket_table *old_tbl, | ||
297 | size_t old_hash) | ||
298 | { | 204 | { |
299 | struct rhash_head *he, *p, *next; | 205 | struct bucket_table *old_tbl = rht_dereference(ht->tbl, ht); |
300 | unsigned int new_hash, new_hash2; | 206 | spinlock_t *old_bucket_lock; |
301 | |||
302 | ASSERT_BUCKET_LOCK(ht, old_tbl, old_hash); | ||
303 | 207 | ||
304 | /* Old bucket empty, no work needed. */ | 208 | old_bucket_lock = rht_bucket_lock(old_tbl, old_hash); |
305 | p = rht_dereference_bucket(old_tbl->buckets[old_hash], old_tbl, | ||
306 | old_hash); | ||
307 | if (rht_is_a_nulls(p)) | ||
308 | return false; | ||
309 | 209 | ||
310 | new_hash = head_hashfn(ht, new_tbl, p); | 210 | spin_lock_bh(old_bucket_lock); |
311 | ASSERT_BUCKET_LOCK(ht, new_tbl, new_hash); | 211 | while (!rhashtable_rehash_one(ht, old_hash)) |
212 | ; | ||
213 | old_tbl->rehash++; | ||
214 | spin_unlock_bh(old_bucket_lock); | ||
215 | } | ||
312 | 216 | ||
313 | /* Advance the old bucket pointer one or more times until it | 217 | static int rhashtable_rehash_attach(struct rhashtable *ht, |
314 | * reaches a node that doesn't hash to the same bucket as the | 218 | struct bucket_table *old_tbl, |
315 | * previous node p. Call the previous node p; | 219 | struct bucket_table *new_tbl) |
316 | */ | 220 | { |
317 | rht_for_each_continue(he, p->next, old_tbl, old_hash) { | 221 | /* Protect future_tbl using the first bucket lock. */ |
318 | new_hash2 = head_hashfn(ht, new_tbl, he); | 222 | spin_lock_bh(old_tbl->locks); |
319 | ASSERT_BUCKET_LOCK(ht, new_tbl, new_hash2); | ||
320 | 223 | ||
321 | if (new_hash != new_hash2) | 224 | /* Did somebody beat us to it? */ |
322 | break; | 225 | if (rcu_access_pointer(old_tbl->future_tbl)) { |
323 | p = he; | 226 | spin_unlock_bh(old_tbl->locks); |
227 | return -EEXIST; | ||
324 | } | 228 | } |
325 | rcu_assign_pointer(old_tbl->buckets[old_hash], p->next); | ||
326 | 229 | ||
327 | /* Find the subsequent node which does hash to the same | 230 | /* Make insertions go into the new, empty table right away. Deletions |
328 | * bucket as node P, or NULL if no such node exists. | 231 | * and lookups will be attempted in both tables until we synchronize. |
329 | */ | 232 | */ |
330 | INIT_RHT_NULLS_HEAD(next, ht, old_hash); | 233 | rcu_assign_pointer(old_tbl->future_tbl, new_tbl); |
331 | if (!rht_is_a_nulls(he)) { | ||
332 | rht_for_each_continue(he, he->next, old_tbl, old_hash) { | ||
333 | if (head_hashfn(ht, new_tbl, he) == new_hash) { | ||
334 | next = he; | ||
335 | break; | ||
336 | } | ||
337 | } | ||
338 | } | ||
339 | 234 | ||
340 | /* Set p's next pointer to that subsequent node pointer, | 235 | /* Ensure the new table is visible to readers. */ |
341 | * bypassing the nodes which do not hash to p's bucket | 236 | smp_wmb(); |
342 | */ | ||
343 | rcu_assign_pointer(p->next, next); | ||
344 | 237 | ||
345 | p = rht_dereference_bucket(old_tbl->buckets[old_hash], old_tbl, | 238 | spin_unlock_bh(old_tbl->locks); |
346 | old_hash); | ||
347 | 239 | ||
348 | return !rht_is_a_nulls(p); | 240 | return 0; |
349 | } | 241 | } |
350 | 242 | ||
351 | static void link_old_to_new(struct rhashtable *ht, struct bucket_table *new_tbl, | 243 | static int rhashtable_rehash_table(struct rhashtable *ht) |
352 | unsigned int new_hash, struct rhash_head *entry) | ||
353 | { | 244 | { |
354 | ASSERT_BUCKET_LOCK(ht, new_tbl, new_hash); | 245 | struct bucket_table *old_tbl = rht_dereference(ht->tbl, ht); |
246 | struct bucket_table *new_tbl; | ||
247 | struct rhashtable_walker *walker; | ||
248 | unsigned int old_hash; | ||
249 | |||
250 | new_tbl = rht_dereference(old_tbl->future_tbl, ht); | ||
251 | if (!new_tbl) | ||
252 | return 0; | ||
253 | |||
254 | for (old_hash = 0; old_hash < old_tbl->size; old_hash++) | ||
255 | rhashtable_rehash_chain(ht, old_hash); | ||
256 | |||
257 | /* Publish the new table pointer. */ | ||
258 | rcu_assign_pointer(ht->tbl, new_tbl); | ||
259 | |||
260 | spin_lock(&ht->lock); | ||
261 | list_for_each_entry(walker, &old_tbl->walkers, list) | ||
262 | walker->tbl = NULL; | ||
263 | spin_unlock(&ht->lock); | ||
355 | 264 | ||
356 | rcu_assign_pointer(*bucket_tail(new_tbl, new_hash), entry); | 265 | /* Wait for readers. All new readers will see the new |
266 | * table, and thus no references to the old table will | ||
267 | * remain. | ||
268 | */ | ||
269 | call_rcu(&old_tbl->rcu, bucket_table_free_rcu); | ||
270 | |||
271 | return rht_dereference(new_tbl->future_tbl, ht) ? -EAGAIN : 0; | ||
357 | } | 272 | } |
358 | 273 | ||
359 | /** | 274 | /** |
360 | * rhashtable_expand - Expand hash table while allowing concurrent lookups | 275 | * rhashtable_expand - Expand hash table while allowing concurrent lookups |
361 | * @ht: the hash table to expand | 276 | * @ht: the hash table to expand |
362 | * | 277 | * |
363 | * A secondary bucket array is allocated and the hash entries are migrated | 278 | * A secondary bucket array is allocated and the hash entries are migrated. |
364 | * while keeping them on both lists until the end of the RCU grace period. | ||
365 | * | 279 | * |
366 | * This function may only be called in a context where it is safe to call | 280 | * This function may only be called in a context where it is safe to call |
367 | * synchronize_rcu(), e.g. not within a rcu_read_lock() section. | 281 | * synchronize_rcu(), e.g. not within a rcu_read_lock() section. |
@@ -372,89 +286,32 @@ static void link_old_to_new(struct rhashtable *ht, struct bucket_table *new_tbl, | |||
372 | * It is valid to have concurrent insertions and deletions protected by per | 286 | * It is valid to have concurrent insertions and deletions protected by per |
373 | * bucket locks or concurrent RCU protected lookups and traversals. | 287 | * bucket locks or concurrent RCU protected lookups and traversals. |
374 | */ | 288 | */ |
375 | int rhashtable_expand(struct rhashtable *ht) | 289 | static int rhashtable_expand(struct rhashtable *ht) |
376 | { | 290 | { |
377 | struct bucket_table *new_tbl, *old_tbl = rht_dereference(ht->tbl, ht); | 291 | struct bucket_table *new_tbl, *old_tbl = rht_dereference(ht->tbl, ht); |
378 | struct rhash_head *he; | 292 | int err; |
379 | unsigned int new_hash, old_hash; | ||
380 | bool complete = false; | ||
381 | 293 | ||
382 | ASSERT_RHT_MUTEX(ht); | 294 | ASSERT_RHT_MUTEX(ht); |
383 | 295 | ||
384 | new_tbl = bucket_table_alloc(ht, old_tbl->size * 2); | 296 | old_tbl = rhashtable_last_table(ht, old_tbl); |
297 | |||
298 | new_tbl = bucket_table_alloc(ht, old_tbl->size * 2, GFP_KERNEL); | ||
385 | if (new_tbl == NULL) | 299 | if (new_tbl == NULL) |
386 | return -ENOMEM; | 300 | return -ENOMEM; |
387 | 301 | ||
388 | atomic_inc(&ht->shift); | 302 | err = rhashtable_rehash_attach(ht, old_tbl, new_tbl); |
389 | 303 | if (err) | |
390 | /* Make insertions go into the new, empty table right away. Deletions | 304 | bucket_table_free(new_tbl); |
391 | * and lookups will be attempted in both tables until we synchronize. | ||
392 | * The synchronize_rcu() guarantees for the new table to be picked up | ||
393 | * so no new additions go into the old table while we relink. | ||
394 | */ | ||
395 | rcu_assign_pointer(ht->future_tbl, new_tbl); | ||
396 | synchronize_rcu(); | ||
397 | |||
398 | /* For each new bucket, search the corresponding old bucket for the | ||
399 | * first entry that hashes to the new bucket, and link the end of | ||
400 | * newly formed bucket chain (containing entries added to future | ||
401 | * table) to that entry. Since all the entries which will end up in | ||
402 | * the new bucket appear in the same old bucket, this constructs an | ||
403 | * entirely valid new hash table, but with multiple buckets | ||
404 | * "zipped" together into a single imprecise chain. | ||
405 | */ | ||
406 | for (new_hash = 0; new_hash < new_tbl->size; new_hash++) { | ||
407 | old_hash = rht_bucket_index(old_tbl, new_hash); | ||
408 | lock_buckets(new_tbl, old_tbl, new_hash); | ||
409 | rht_for_each(he, old_tbl, old_hash) { | ||
410 | if (head_hashfn(ht, new_tbl, he) == new_hash) { | ||
411 | link_old_to_new(ht, new_tbl, new_hash, he); | ||
412 | break; | ||
413 | } | ||
414 | } | ||
415 | unlock_buckets(new_tbl, old_tbl, new_hash); | ||
416 | cond_resched(); | ||
417 | } | ||
418 | |||
419 | /* Unzip interleaved hash chains */ | ||
420 | while (!complete && !ht->being_destroyed) { | ||
421 | /* Wait for readers. All new readers will see the new | ||
422 | * table, and thus no references to the old table will | ||
423 | * remain. | ||
424 | */ | ||
425 | synchronize_rcu(); | ||
426 | |||
427 | /* For each bucket in the old table (each of which | ||
428 | * contains items from multiple buckets of the new | ||
429 | * table): ... | ||
430 | */ | ||
431 | complete = true; | ||
432 | for (old_hash = 0; old_hash < old_tbl->size; old_hash++) { | ||
433 | lock_buckets(new_tbl, old_tbl, old_hash); | ||
434 | |||
435 | if (hashtable_chain_unzip(ht, new_tbl, old_tbl, | ||
436 | old_hash)) | ||
437 | complete = false; | ||
438 | |||
439 | unlock_buckets(new_tbl, old_tbl, old_hash); | ||
440 | cond_resched(); | ||
441 | } | ||
442 | } | ||
443 | 305 | ||
444 | rcu_assign_pointer(ht->tbl, new_tbl); | 306 | return err; |
445 | synchronize_rcu(); | ||
446 | |||
447 | bucket_table_free(old_tbl); | ||
448 | return 0; | ||
449 | } | 307 | } |
450 | EXPORT_SYMBOL_GPL(rhashtable_expand); | ||
451 | 308 | ||
452 | /** | 309 | /** |
453 | * rhashtable_shrink - Shrink hash table while allowing concurrent lookups | 310 | * rhashtable_shrink - Shrink hash table while allowing concurrent lookups |
454 | * @ht: the hash table to shrink | 311 | * @ht: the hash table to shrink |
455 | * | 312 | * |
456 | * This function may only be called in a context where it is safe to call | 313 | * This function shrinks the hash table to fit, i.e., the smallest |
457 | * synchronize_rcu(), e.g. not within a rcu_read_lock() section. | 314 | * size would not cause it to expand right away automatically. |
458 | * | 315 | * |
459 | * The caller must ensure that no concurrent resizing occurs by holding | 316 | * The caller must ensure that no concurrent resizing occurs by holding |
460 | * ht->mutex. | 317 | * ht->mutex. |
@@ -465,395 +322,146 @@ EXPORT_SYMBOL_GPL(rhashtable_expand); | |||
465 | * It is valid to have concurrent insertions and deletions protected by per | 322 | * It is valid to have concurrent insertions and deletions protected by per |
466 | * bucket locks or concurrent RCU protected lookups and traversals. | 323 | * bucket locks or concurrent RCU protected lookups and traversals. |
467 | */ | 324 | */ |
468 | int rhashtable_shrink(struct rhashtable *ht) | 325 | static int rhashtable_shrink(struct rhashtable *ht) |
469 | { | 326 | { |
470 | struct bucket_table *new_tbl, *tbl = rht_dereference(ht->tbl, ht); | 327 | struct bucket_table *new_tbl, *old_tbl = rht_dereference(ht->tbl, ht); |
471 | unsigned int new_hash; | 328 | unsigned int size; |
329 | int err; | ||
472 | 330 | ||
473 | ASSERT_RHT_MUTEX(ht); | 331 | ASSERT_RHT_MUTEX(ht); |
474 | 332 | ||
475 | new_tbl = bucket_table_alloc(ht, tbl->size / 2); | 333 | size = roundup_pow_of_two(atomic_read(&ht->nelems) * 3 / 2); |
476 | if (new_tbl == NULL) | 334 | if (size < ht->p.min_size) |
477 | return -ENOMEM; | 335 | size = ht->p.min_size; |
478 | |||
479 | rcu_assign_pointer(ht->future_tbl, new_tbl); | ||
480 | synchronize_rcu(); | ||
481 | |||
482 | /* Link the first entry in the old bucket to the end of the | ||
483 | * bucket in the new table. As entries are concurrently being | ||
484 | * added to the new table, lock down the new bucket. As we | ||
485 | * always divide the size in half when shrinking, each bucket | ||
486 | * in the new table maps to exactly two buckets in the old | ||
487 | * table. | ||
488 | */ | ||
489 | for (new_hash = 0; new_hash < new_tbl->size; new_hash++) { | ||
490 | lock_buckets(new_tbl, tbl, new_hash); | ||
491 | |||
492 | rcu_assign_pointer(*bucket_tail(new_tbl, new_hash), | ||
493 | tbl->buckets[new_hash]); | ||
494 | ASSERT_BUCKET_LOCK(ht, tbl, new_hash + new_tbl->size); | ||
495 | rcu_assign_pointer(*bucket_tail(new_tbl, new_hash), | ||
496 | tbl->buckets[new_hash + new_tbl->size]); | ||
497 | 336 | ||
498 | unlock_buckets(new_tbl, tbl, new_hash); | 337 | if (old_tbl->size <= size) |
499 | cond_resched(); | 338 | return 0; |
500 | } | ||
501 | 339 | ||
502 | /* Publish the new, valid hash table */ | 340 | if (rht_dereference(old_tbl->future_tbl, ht)) |
503 | rcu_assign_pointer(ht->tbl, new_tbl); | 341 | return -EEXIST; |
504 | atomic_dec(&ht->shift); | ||
505 | 342 | ||
506 | /* Wait for readers. No new readers will have references to the | 343 | new_tbl = bucket_table_alloc(ht, size, GFP_KERNEL); |
507 | * old hash table. | 344 | if (new_tbl == NULL) |
508 | */ | 345 | return -ENOMEM; |
509 | synchronize_rcu(); | ||
510 | 346 | ||
511 | bucket_table_free(tbl); | 347 | err = rhashtable_rehash_attach(ht, old_tbl, new_tbl); |
348 | if (err) | ||
349 | bucket_table_free(new_tbl); | ||
512 | 350 | ||
513 | return 0; | 351 | return err; |
514 | } | 352 | } |
515 | EXPORT_SYMBOL_GPL(rhashtable_shrink); | ||
516 | 353 | ||
517 | static void rht_deferred_worker(struct work_struct *work) | 354 | static void rht_deferred_worker(struct work_struct *work) |
518 | { | 355 | { |
519 | struct rhashtable *ht; | 356 | struct rhashtable *ht; |
520 | struct bucket_table *tbl; | 357 | struct bucket_table *tbl; |
521 | struct rhashtable_walker *walker; | 358 | int err = 0; |
522 | 359 | ||
523 | ht = container_of(work, struct rhashtable, run_work); | 360 | ht = container_of(work, struct rhashtable, run_work); |
524 | mutex_lock(&ht->mutex); | 361 | mutex_lock(&ht->mutex); |
525 | if (ht->being_destroyed) | ||
526 | goto unlock; | ||
527 | 362 | ||
528 | tbl = rht_dereference(ht->tbl, ht); | 363 | tbl = rht_dereference(ht->tbl, ht); |
364 | tbl = rhashtable_last_table(ht, tbl); | ||
529 | 365 | ||
530 | list_for_each_entry(walker, &ht->walkers, list) | 366 | if (rht_grow_above_75(ht, tbl)) |
531 | walker->resize = true; | ||
532 | |||
533 | if (rht_grow_above_75(ht, tbl->size)) | ||
534 | rhashtable_expand(ht); | 367 | rhashtable_expand(ht); |
535 | else if (rht_shrink_below_30(ht, tbl->size)) | 368 | else if (ht->p.automatic_shrinking && rht_shrink_below_30(ht, tbl)) |
536 | rhashtable_shrink(ht); | 369 | rhashtable_shrink(ht); |
537 | unlock: | ||
538 | mutex_unlock(&ht->mutex); | ||
539 | } | ||
540 | 370 | ||
541 | static void __rhashtable_insert(struct rhashtable *ht, struct rhash_head *obj, | 371 | err = rhashtable_rehash_table(ht); |
542 | struct bucket_table *tbl, | ||
543 | const struct bucket_table *old_tbl, u32 hash) | ||
544 | { | ||
545 | bool no_resize_running = tbl == old_tbl; | ||
546 | struct rhash_head *head; | ||
547 | 372 | ||
548 | hash = rht_bucket_index(tbl, hash); | 373 | mutex_unlock(&ht->mutex); |
549 | head = rht_dereference_bucket(tbl->buckets[hash], tbl, hash); | ||
550 | |||
551 | ASSERT_BUCKET_LOCK(ht, tbl, hash); | ||
552 | |||
553 | if (rht_is_a_nulls(head)) | ||
554 | INIT_RHT_NULLS_HEAD(obj->next, ht, hash); | ||
555 | else | ||
556 | RCU_INIT_POINTER(obj->next, head); | ||
557 | |||
558 | rcu_assign_pointer(tbl->buckets[hash], obj); | ||
559 | 374 | ||
560 | atomic_inc(&ht->nelems); | 375 | if (err) |
561 | if (no_resize_running && rht_grow_above_75(ht, tbl->size)) | ||
562 | schedule_work(&ht->run_work); | 376 | schedule_work(&ht->run_work); |
563 | } | 377 | } |
564 | 378 | ||
565 | /** | 379 | static bool rhashtable_check_elasticity(struct rhashtable *ht, |
566 | * rhashtable_insert - insert object into hash table | 380 | struct bucket_table *tbl, |
567 | * @ht: hash table | 381 | unsigned int hash) |
568 | * @obj: pointer to hash head inside object | ||
569 | * | ||
570 | * Will take a per bucket spinlock to protect against mutual mutations | ||
571 | * on the same bucket. Multiple insertions may occur in parallel unless | ||
572 | * they map to the same bucket lock. | ||
573 | * | ||
574 | * It is safe to call this function from atomic context. | ||
575 | * | ||
576 | * Will trigger an automatic deferred table resizing if the size grows | ||
577 | * beyond the watermark indicated by grow_decision() which can be passed | ||
578 | * to rhashtable_init(). | ||
579 | */ | ||
580 | void rhashtable_insert(struct rhashtable *ht, struct rhash_head *obj) | ||
581 | { | 382 | { |
582 | struct bucket_table *tbl, *old_tbl; | 383 | unsigned int elasticity = ht->elasticity; |
583 | unsigned hash; | 384 | struct rhash_head *head; |
584 | |||
585 | rcu_read_lock(); | ||
586 | |||
587 | tbl = rht_dereference_rcu(ht->future_tbl, ht); | ||
588 | old_tbl = rht_dereference_rcu(ht->tbl, ht); | ||
589 | hash = obj_raw_hashfn(ht, rht_obj(ht, obj)); | ||
590 | 385 | ||
591 | lock_buckets(tbl, old_tbl, hash); | 386 | rht_for_each(head, tbl, hash) |
592 | __rhashtable_insert(ht, obj, tbl, old_tbl, hash); | 387 | if (!--elasticity) |
593 | unlock_buckets(tbl, old_tbl, hash); | 388 | return true; |
594 | 389 | ||
595 | rcu_read_unlock(); | 390 | return false; |
596 | } | 391 | } |
597 | EXPORT_SYMBOL_GPL(rhashtable_insert); | ||
598 | 392 | ||
599 | /** | 393 | int rhashtable_insert_rehash(struct rhashtable *ht) |
600 | * rhashtable_remove - remove object from hash table | ||
601 | * @ht: hash table | ||
602 | * @obj: pointer to hash head inside object | ||
603 | * | ||
604 | * Since the hash chain is single linked, the removal operation needs to | ||
605 | * walk the bucket chain upon removal. The removal operation is thus | ||
606 | * considerable slow if the hash table is not correctly sized. | ||
607 | * | ||
608 | * Will automatically shrink the table via rhashtable_expand() if the | ||
609 | * shrink_decision function specified at rhashtable_init() returns true. | ||
610 | * | ||
611 | * The caller must ensure that no concurrent table mutations occur. It is | ||
612 | * however valid to have concurrent lookups if they are RCU protected. | ||
613 | */ | ||
614 | bool rhashtable_remove(struct rhashtable *ht, struct rhash_head *obj) | ||
615 | { | 394 | { |
616 | struct bucket_table *tbl, *new_tbl, *old_tbl; | 395 | struct bucket_table *old_tbl; |
617 | struct rhash_head __rcu **pprev; | 396 | struct bucket_table *new_tbl; |
618 | struct rhash_head *he, *he2; | 397 | struct bucket_table *tbl; |
619 | unsigned int hash, new_hash; | 398 | unsigned int size; |
620 | bool ret = false; | 399 | int err; |
621 | 400 | ||
622 | rcu_read_lock(); | ||
623 | old_tbl = rht_dereference_rcu(ht->tbl, ht); | 401 | old_tbl = rht_dereference_rcu(ht->tbl, ht); |
624 | tbl = new_tbl = rht_dereference_rcu(ht->future_tbl, ht); | 402 | tbl = rhashtable_last_table(ht, old_tbl); |
625 | new_hash = obj_raw_hashfn(ht, rht_obj(ht, obj)); | ||
626 | |||
627 | lock_buckets(new_tbl, old_tbl, new_hash); | ||
628 | restart: | ||
629 | hash = rht_bucket_index(tbl, new_hash); | ||
630 | pprev = &tbl->buckets[hash]; | ||
631 | rht_for_each(he, tbl, hash) { | ||
632 | if (he != obj) { | ||
633 | pprev = &he->next; | ||
634 | continue; | ||
635 | } | ||
636 | |||
637 | ASSERT_BUCKET_LOCK(ht, tbl, hash); | ||
638 | |||
639 | if (old_tbl->size > new_tbl->size && tbl == old_tbl && | ||
640 | !rht_is_a_nulls(obj->next) && | ||
641 | head_hashfn(ht, tbl, obj->next) != hash) { | ||
642 | rcu_assign_pointer(*pprev, (struct rhash_head *) rht_marker(ht, hash)); | ||
643 | } else if (unlikely(old_tbl->size < new_tbl->size && tbl == new_tbl)) { | ||
644 | rht_for_each_continue(he2, obj->next, tbl, hash) { | ||
645 | if (head_hashfn(ht, tbl, he2) == hash) { | ||
646 | rcu_assign_pointer(*pprev, he2); | ||
647 | goto found; | ||
648 | } | ||
649 | } | ||
650 | |||
651 | rcu_assign_pointer(*pprev, (struct rhash_head *) rht_marker(ht, hash)); | ||
652 | } else { | ||
653 | rcu_assign_pointer(*pprev, obj->next); | ||
654 | } | ||
655 | |||
656 | found: | ||
657 | ret = true; | ||
658 | break; | ||
659 | } | ||
660 | |||
661 | /* The entry may be linked in either 'tbl', 'future_tbl', or both. | ||
662 | * 'future_tbl' only exists for a short period of time during | ||
663 | * resizing. Thus traversing both is fine and the added cost is | ||
664 | * very rare. | ||
665 | */ | ||
666 | if (tbl != old_tbl) { | ||
667 | tbl = old_tbl; | ||
668 | goto restart; | ||
669 | } | ||
670 | |||
671 | unlock_buckets(new_tbl, old_tbl, new_hash); | ||
672 | |||
673 | if (ret) { | ||
674 | bool no_resize_running = new_tbl == old_tbl; | ||
675 | |||
676 | atomic_dec(&ht->nelems); | ||
677 | if (no_resize_running && rht_shrink_below_30(ht, new_tbl->size)) | ||
678 | schedule_work(&ht->run_work); | ||
679 | } | ||
680 | |||
681 | rcu_read_unlock(); | ||
682 | 403 | ||
683 | return ret; | 404 | size = tbl->size; |
684 | } | ||
685 | EXPORT_SYMBOL_GPL(rhashtable_remove); | ||
686 | |||
687 | struct rhashtable_compare_arg { | ||
688 | struct rhashtable *ht; | ||
689 | const void *key; | ||
690 | }; | ||
691 | |||
692 | static bool rhashtable_compare(void *ptr, void *arg) | ||
693 | { | ||
694 | struct rhashtable_compare_arg *x = arg; | ||
695 | struct rhashtable *ht = x->ht; | ||
696 | |||
697 | return !memcmp(ptr + ht->p.key_offset, x->key, ht->p.key_len); | ||
698 | } | ||
699 | |||
700 | /** | ||
701 | * rhashtable_lookup - lookup key in hash table | ||
702 | * @ht: hash table | ||
703 | * @key: pointer to key | ||
704 | * | ||
705 | * Computes the hash value for the key and traverses the bucket chain looking | ||
706 | * for a entry with an identical key. The first matching entry is returned. | ||
707 | * | ||
708 | * This lookup function may only be used for fixed key hash table (key_len | ||
709 | * parameter set). It will BUG() if used inappropriately. | ||
710 | * | ||
711 | * Lookups may occur in parallel with hashtable mutations and resizing. | ||
712 | */ | ||
713 | void *rhashtable_lookup(struct rhashtable *ht, const void *key) | ||
714 | { | ||
715 | struct rhashtable_compare_arg arg = { | ||
716 | .ht = ht, | ||
717 | .key = key, | ||
718 | }; | ||
719 | |||
720 | BUG_ON(!ht->p.key_len); | ||
721 | |||
722 | return rhashtable_lookup_compare(ht, key, &rhashtable_compare, &arg); | ||
723 | } | ||
724 | EXPORT_SYMBOL_GPL(rhashtable_lookup); | ||
725 | |||
726 | /** | ||
727 | * rhashtable_lookup_compare - search hash table with compare function | ||
728 | * @ht: hash table | ||
729 | * @key: the pointer to the key | ||
730 | * @compare: compare function, must return true on match | ||
731 | * @arg: argument passed on to compare function | ||
732 | * | ||
733 | * Traverses the bucket chain behind the provided hash value and calls the | ||
734 | * specified compare function for each entry. | ||
735 | * | ||
736 | * Lookups may occur in parallel with hashtable mutations and resizing. | ||
737 | * | ||
738 | * Returns the first entry on which the compare function returned true. | ||
739 | */ | ||
740 | void *rhashtable_lookup_compare(struct rhashtable *ht, const void *key, | ||
741 | bool (*compare)(void *, void *), void *arg) | ||
742 | { | ||
743 | const struct bucket_table *tbl, *old_tbl; | ||
744 | struct rhash_head *he; | ||
745 | u32 hash; | ||
746 | 405 | ||
747 | rcu_read_lock(); | 406 | if (rht_grow_above_75(ht, tbl)) |
407 | size *= 2; | ||
408 | /* More than two rehashes (not resizes) detected. */ | ||
409 | else if (WARN_ON(old_tbl != tbl && old_tbl->size == size)) | ||
410 | return -EBUSY; | ||
748 | 411 | ||
749 | old_tbl = rht_dereference_rcu(ht->tbl, ht); | 412 | new_tbl = bucket_table_alloc(ht, size, GFP_ATOMIC); |
750 | tbl = rht_dereference_rcu(ht->future_tbl, ht); | 413 | if (new_tbl == NULL) |
751 | hash = key_hashfn(ht, key, ht->p.key_len); | 414 | return -ENOMEM; |
752 | restart: | ||
753 | rht_for_each_rcu(he, tbl, rht_bucket_index(tbl, hash)) { | ||
754 | if (!compare(rht_obj(ht, he), arg)) | ||
755 | continue; | ||
756 | rcu_read_unlock(); | ||
757 | return rht_obj(ht, he); | ||
758 | } | ||
759 | 415 | ||
760 | if (unlikely(tbl != old_tbl)) { | 416 | err = rhashtable_rehash_attach(ht, tbl, new_tbl); |
761 | tbl = old_tbl; | 417 | if (err) { |
762 | goto restart; | 418 | bucket_table_free(new_tbl); |
763 | } | 419 | if (err == -EEXIST) |
764 | rcu_read_unlock(); | 420 | err = 0; |
421 | } else | ||
422 | schedule_work(&ht->run_work); | ||
765 | 423 | ||
766 | return NULL; | 424 | return err; |
767 | } | 425 | } |
768 | EXPORT_SYMBOL_GPL(rhashtable_lookup_compare); | 426 | EXPORT_SYMBOL_GPL(rhashtable_insert_rehash); |
769 | 427 | ||
770 | /** | 428 | int rhashtable_insert_slow(struct rhashtable *ht, const void *key, |
771 | * rhashtable_lookup_insert - lookup and insert object into hash table | 429 | struct rhash_head *obj, |
772 | * @ht: hash table | 430 | struct bucket_table *tbl) |
773 | * @obj: pointer to hash head inside object | ||
774 | * | ||
775 | * Locks down the bucket chain in both the old and new table if a resize | ||
776 | * is in progress to ensure that writers can't remove from the old table | ||
777 | * and can't insert to the new table during the atomic operation of search | ||
778 | * and insertion. Searches for duplicates in both the old and new table if | ||
779 | * a resize is in progress. | ||
780 | * | ||
781 | * This lookup function may only be used for fixed key hash table (key_len | ||
782 | * parameter set). It will BUG() if used inappropriately. | ||
783 | * | ||
784 | * It is safe to call this function from atomic context. | ||
785 | * | ||
786 | * Will trigger an automatic deferred table resizing if the size grows | ||
787 | * beyond the watermark indicated by grow_decision() which can be passed | ||
788 | * to rhashtable_init(). | ||
789 | */ | ||
790 | bool rhashtable_lookup_insert(struct rhashtable *ht, struct rhash_head *obj) | ||
791 | { | 431 | { |
792 | struct rhashtable_compare_arg arg = { | 432 | struct rhash_head *head; |
793 | .ht = ht, | 433 | unsigned int hash; |
794 | .key = rht_obj(ht, obj) + ht->p.key_offset, | 434 | int err; |
795 | }; | ||
796 | 435 | ||
797 | BUG_ON(!ht->p.key_len); | 436 | tbl = rhashtable_last_table(ht, tbl); |
437 | hash = head_hashfn(ht, tbl, obj); | ||
438 | spin_lock_nested(rht_bucket_lock(tbl, hash), SINGLE_DEPTH_NESTING); | ||
798 | 439 | ||
799 | return rhashtable_lookup_compare_insert(ht, obj, &rhashtable_compare, | 440 | err = -EEXIST; |
800 | &arg); | 441 | if (key && rhashtable_lookup_fast(ht, key, ht->p)) |
801 | } | 442 | goto exit; |
802 | EXPORT_SYMBOL_GPL(rhashtable_lookup_insert); | ||
803 | 443 | ||
804 | /** | 444 | err = -EAGAIN; |
805 | * rhashtable_lookup_compare_insert - search and insert object to hash table | 445 | if (rhashtable_check_elasticity(ht, tbl, hash) || |
806 | * with compare function | 446 | rht_grow_above_100(ht, tbl)) |
807 | * @ht: hash table | 447 | goto exit; |
808 | * @obj: pointer to hash head inside object | ||
809 | * @compare: compare function, must return true on match | ||
810 | * @arg: argument passed on to compare function | ||
811 | * | ||
812 | * Locks down the bucket chain in both the old and new table if a resize | ||
813 | * is in progress to ensure that writers can't remove from the old table | ||
814 | * and can't insert to the new table during the atomic operation of search | ||
815 | * and insertion. Searches for duplicates in both the old and new table if | ||
816 | * a resize is in progress. | ||
817 | * | ||
818 | * Lookups may occur in parallel with hashtable mutations and resizing. | ||
819 | * | ||
820 | * Will trigger an automatic deferred table resizing if the size grows | ||
821 | * beyond the watermark indicated by grow_decision() which can be passed | ||
822 | * to rhashtable_init(). | ||
823 | */ | ||
824 | bool rhashtable_lookup_compare_insert(struct rhashtable *ht, | ||
825 | struct rhash_head *obj, | ||
826 | bool (*compare)(void *, void *), | ||
827 | void *arg) | ||
828 | { | ||
829 | struct bucket_table *new_tbl, *old_tbl; | ||
830 | u32 new_hash; | ||
831 | bool success = true; | ||
832 | 448 | ||
833 | BUG_ON(!ht->p.key_len); | 449 | err = 0; |
834 | 450 | ||
835 | rcu_read_lock(); | 451 | head = rht_dereference_bucket(tbl->buckets[hash], tbl, hash); |
836 | old_tbl = rht_dereference_rcu(ht->tbl, ht); | ||
837 | new_tbl = rht_dereference_rcu(ht->future_tbl, ht); | ||
838 | new_hash = obj_raw_hashfn(ht, rht_obj(ht, obj)); | ||
839 | 452 | ||
840 | lock_buckets(new_tbl, old_tbl, new_hash); | 453 | RCU_INIT_POINTER(obj->next, head); |
841 | 454 | ||
842 | if (rhashtable_lookup_compare(ht, rht_obj(ht, obj) + ht->p.key_offset, | 455 | rcu_assign_pointer(tbl->buckets[hash], obj); |
843 | compare, arg)) { | ||
844 | success = false; | ||
845 | goto exit; | ||
846 | } | ||
847 | 456 | ||
848 | __rhashtable_insert(ht, obj, new_tbl, old_tbl, new_hash); | 457 | atomic_inc(&ht->nelems); |
849 | 458 | ||
850 | exit: | 459 | exit: |
851 | unlock_buckets(new_tbl, old_tbl, new_hash); | 460 | spin_unlock(rht_bucket_lock(tbl, hash)); |
852 | rcu_read_unlock(); | ||
853 | 461 | ||
854 | return success; | 462 | return err; |
855 | } | 463 | } |
856 | EXPORT_SYMBOL_GPL(rhashtable_lookup_compare_insert); | 464 | EXPORT_SYMBOL_GPL(rhashtable_insert_slow); |
857 | 465 | ||
858 | /** | 466 | /** |
859 | * rhashtable_walk_init - Initialise an iterator | 467 | * rhashtable_walk_init - Initialise an iterator |
@@ -887,11 +495,9 @@ int rhashtable_walk_init(struct rhashtable *ht, struct rhashtable_iter *iter) | |||
887 | if (!iter->walker) | 495 | if (!iter->walker) |
888 | return -ENOMEM; | 496 | return -ENOMEM; |
889 | 497 | ||
890 | INIT_LIST_HEAD(&iter->walker->list); | ||
891 | iter->walker->resize = false; | ||
892 | |||
893 | mutex_lock(&ht->mutex); | 498 | mutex_lock(&ht->mutex); |
894 | list_add(&iter->walker->list, &ht->walkers); | 499 | iter->walker->tbl = rht_dereference(ht->tbl, ht); |
500 | list_add(&iter->walker->list, &iter->walker->tbl->walkers); | ||
895 | mutex_unlock(&ht->mutex); | 501 | mutex_unlock(&ht->mutex); |
896 | 502 | ||
897 | return 0; | 503 | return 0; |
@@ -907,7 +513,8 @@ EXPORT_SYMBOL_GPL(rhashtable_walk_init); | |||
907 | void rhashtable_walk_exit(struct rhashtable_iter *iter) | 513 | void rhashtable_walk_exit(struct rhashtable_iter *iter) |
908 | { | 514 | { |
909 | mutex_lock(&iter->ht->mutex); | 515 | mutex_lock(&iter->ht->mutex); |
910 | list_del(&iter->walker->list); | 516 | if (iter->walker->tbl) |
517 | list_del(&iter->walker->list); | ||
911 | mutex_unlock(&iter->ht->mutex); | 518 | mutex_unlock(&iter->ht->mutex); |
912 | kfree(iter->walker); | 519 | kfree(iter->walker); |
913 | } | 520 | } |
@@ -928,13 +535,21 @@ EXPORT_SYMBOL_GPL(rhashtable_walk_exit); | |||
928 | * by calling rhashtable_walk_next. | 535 | * by calling rhashtable_walk_next. |
929 | */ | 536 | */ |
930 | int rhashtable_walk_start(struct rhashtable_iter *iter) | 537 | int rhashtable_walk_start(struct rhashtable_iter *iter) |
538 | __acquires(RCU) | ||
931 | { | 539 | { |
540 | struct rhashtable *ht = iter->ht; | ||
541 | |||
542 | mutex_lock(&ht->mutex); | ||
543 | |||
544 | if (iter->walker->tbl) | ||
545 | list_del(&iter->walker->list); | ||
546 | |||
932 | rcu_read_lock(); | 547 | rcu_read_lock(); |
933 | 548 | ||
934 | if (iter->walker->resize) { | 549 | mutex_unlock(&ht->mutex); |
935 | iter->slot = 0; | 550 | |
936 | iter->skip = 0; | 551 | if (!iter->walker->tbl) { |
937 | iter->walker->resize = false; | 552 | iter->walker->tbl = rht_dereference_rcu(ht->tbl, ht); |
938 | return -EAGAIN; | 553 | return -EAGAIN; |
939 | } | 554 | } |
940 | 555 | ||
@@ -956,13 +571,11 @@ EXPORT_SYMBOL_GPL(rhashtable_walk_start); | |||
956 | */ | 571 | */ |
957 | void *rhashtable_walk_next(struct rhashtable_iter *iter) | 572 | void *rhashtable_walk_next(struct rhashtable_iter *iter) |
958 | { | 573 | { |
959 | const struct bucket_table *tbl; | 574 | struct bucket_table *tbl = iter->walker->tbl; |
960 | struct rhashtable *ht = iter->ht; | 575 | struct rhashtable *ht = iter->ht; |
961 | struct rhash_head *p = iter->p; | 576 | struct rhash_head *p = iter->p; |
962 | void *obj = NULL; | 577 | void *obj = NULL; |
963 | 578 | ||
964 | tbl = rht_dereference_rcu(ht->tbl, ht); | ||
965 | |||
966 | if (p) { | 579 | if (p) { |
967 | p = rht_dereference_bucket_rcu(p->next, tbl, iter->slot); | 580 | p = rht_dereference_bucket_rcu(p->next, tbl, iter->slot); |
968 | goto next; | 581 | goto next; |
@@ -988,17 +601,20 @@ next: | |||
988 | iter->skip = 0; | 601 | iter->skip = 0; |
989 | } | 602 | } |
990 | 603 | ||
991 | iter->p = NULL; | 604 | /* Ensure we see any new tables. */ |
605 | smp_rmb(); | ||
992 | 606 | ||
993 | out: | 607 | iter->walker->tbl = rht_dereference_rcu(tbl->future_tbl, ht); |
994 | if (iter->walker->resize) { | 608 | if (iter->walker->tbl) { |
995 | iter->p = NULL; | ||
996 | iter->slot = 0; | 609 | iter->slot = 0; |
997 | iter->skip = 0; | 610 | iter->skip = 0; |
998 | iter->walker->resize = false; | ||
999 | return ERR_PTR(-EAGAIN); | 611 | return ERR_PTR(-EAGAIN); |
1000 | } | 612 | } |
1001 | 613 | ||
614 | iter->p = NULL; | ||
615 | |||
616 | out: | ||
617 | |||
1002 | return obj; | 618 | return obj; |
1003 | } | 619 | } |
1004 | EXPORT_SYMBOL_GPL(rhashtable_walk_next); | 620 | EXPORT_SYMBOL_GPL(rhashtable_walk_next); |
@@ -1010,16 +626,39 @@ EXPORT_SYMBOL_GPL(rhashtable_walk_next); | |||
1010 | * Finish a hash table walk. | 626 | * Finish a hash table walk. |
1011 | */ | 627 | */ |
1012 | void rhashtable_walk_stop(struct rhashtable_iter *iter) | 628 | void rhashtable_walk_stop(struct rhashtable_iter *iter) |
629 | __releases(RCU) | ||
1013 | { | 630 | { |
1014 | rcu_read_unlock(); | 631 | struct rhashtable *ht; |
632 | struct bucket_table *tbl = iter->walker->tbl; | ||
633 | |||
634 | if (!tbl) | ||
635 | goto out; | ||
636 | |||
637 | ht = iter->ht; | ||
638 | |||
639 | spin_lock(&ht->lock); | ||
640 | if (tbl->rehash < tbl->size) | ||
641 | list_add(&iter->walker->list, &tbl->walkers); | ||
642 | else | ||
643 | iter->walker->tbl = NULL; | ||
644 | spin_unlock(&ht->lock); | ||
645 | |||
1015 | iter->p = NULL; | 646 | iter->p = NULL; |
647 | |||
648 | out: | ||
649 | rcu_read_unlock(); | ||
1016 | } | 650 | } |
1017 | EXPORT_SYMBOL_GPL(rhashtable_walk_stop); | 651 | EXPORT_SYMBOL_GPL(rhashtable_walk_stop); |
1018 | 652 | ||
1019 | static size_t rounded_hashtable_size(struct rhashtable_params *params) | 653 | static size_t rounded_hashtable_size(const struct rhashtable_params *params) |
1020 | { | 654 | { |
1021 | return max(roundup_pow_of_two(params->nelem_hint * 4 / 3), | 655 | return max(roundup_pow_of_two(params->nelem_hint * 4 / 3), |
1022 | 1UL << params->min_shift); | 656 | (unsigned long)params->min_size); |
657 | } | ||
658 | |||
659 | static u32 rhashtable_jhash2(const void *key, u32 length, u32 seed) | ||
660 | { | ||
661 | return jhash2(key, length, seed); | ||
1023 | } | 662 | } |
1024 | 663 | ||
1025 | /** | 664 | /** |
@@ -1052,7 +691,7 @@ static size_t rounded_hashtable_size(struct rhashtable_params *params) | |||
1052 | * struct rhash_head node; | 691 | * struct rhash_head node; |
1053 | * }; | 692 | * }; |
1054 | * | 693 | * |
1055 | * u32 my_hash_fn(const void *data, u32 seed) | 694 | * u32 my_hash_fn(const void *data, u32 len, u32 seed) |
1056 | * { | 695 | * { |
1057 | * struct test_obj *obj = data; | 696 | * struct test_obj *obj = data; |
1058 | * | 697 | * |
@@ -1065,47 +704,74 @@ static size_t rounded_hashtable_size(struct rhashtable_params *params) | |||
1065 | * .obj_hashfn = my_hash_fn, | 704 | * .obj_hashfn = my_hash_fn, |
1066 | * }; | 705 | * }; |
1067 | */ | 706 | */ |
1068 | int rhashtable_init(struct rhashtable *ht, struct rhashtable_params *params) | 707 | int rhashtable_init(struct rhashtable *ht, |
708 | const struct rhashtable_params *params) | ||
1069 | { | 709 | { |
1070 | struct bucket_table *tbl; | 710 | struct bucket_table *tbl; |
1071 | size_t size; | 711 | size_t size; |
1072 | 712 | ||
1073 | size = HASH_DEFAULT_SIZE; | 713 | size = HASH_DEFAULT_SIZE; |
1074 | 714 | ||
1075 | if ((params->key_len && !params->hashfn) || | 715 | if ((!params->key_len && !params->obj_hashfn) || |
1076 | (!params->key_len && !params->obj_hashfn)) | 716 | (params->obj_hashfn && !params->obj_cmpfn)) |
1077 | return -EINVAL; | 717 | return -EINVAL; |
1078 | 718 | ||
1079 | if (params->nulls_base && params->nulls_base < (1U << RHT_BASE_SHIFT)) | 719 | if (params->nulls_base && params->nulls_base < (1U << RHT_BASE_SHIFT)) |
1080 | return -EINVAL; | 720 | return -EINVAL; |
1081 | 721 | ||
1082 | params->min_shift = max_t(size_t, params->min_shift, | ||
1083 | ilog2(HASH_MIN_SIZE)); | ||
1084 | |||
1085 | if (params->nelem_hint) | 722 | if (params->nelem_hint) |
1086 | size = rounded_hashtable_size(params); | 723 | size = rounded_hashtable_size(params); |
1087 | 724 | ||
1088 | memset(ht, 0, sizeof(*ht)); | 725 | memset(ht, 0, sizeof(*ht)); |
1089 | mutex_init(&ht->mutex); | 726 | mutex_init(&ht->mutex); |
727 | spin_lock_init(&ht->lock); | ||
1090 | memcpy(&ht->p, params, sizeof(*params)); | 728 | memcpy(&ht->p, params, sizeof(*params)); |
1091 | INIT_LIST_HEAD(&ht->walkers); | 729 | |
730 | if (params->min_size) | ||
731 | ht->p.min_size = roundup_pow_of_two(params->min_size); | ||
732 | |||
733 | if (params->max_size) | ||
734 | ht->p.max_size = rounddown_pow_of_two(params->max_size); | ||
735 | |||
736 | ht->p.min_size = max(ht->p.min_size, HASH_MIN_SIZE); | ||
737 | |||
738 | /* The maximum (not average) chain length grows with the | ||
739 | * size of the hash table, at a rate of (log N)/(log log N). | ||
740 | * The value of 16 is selected so that even if the hash | ||
741 | * table grew to 2^32 you would not expect the maximum | ||
742 | * chain length to exceed it unless we are under attack | ||
743 | * (or extremely unlucky). | ||
744 | * | ||
745 | * As this limit is only to detect attacks, we don't need | ||
746 | * to set it to a lower value as you'd need the chain | ||
747 | * length to vastly exceed 16 to have any real effect | ||
748 | * on the system. | ||
749 | */ | ||
750 | if (!params->insecure_elasticity) | ||
751 | ht->elasticity = 16; | ||
1092 | 752 | ||
1093 | if (params->locks_mul) | 753 | if (params->locks_mul) |
1094 | ht->p.locks_mul = roundup_pow_of_two(params->locks_mul); | 754 | ht->p.locks_mul = roundup_pow_of_two(params->locks_mul); |
1095 | else | 755 | else |
1096 | ht->p.locks_mul = BUCKET_LOCKS_PER_CPU; | 756 | ht->p.locks_mul = BUCKET_LOCKS_PER_CPU; |
1097 | 757 | ||
1098 | tbl = bucket_table_alloc(ht, size); | 758 | ht->key_len = ht->p.key_len; |
759 | if (!params->hashfn) { | ||
760 | ht->p.hashfn = jhash; | ||
761 | |||
762 | if (!(ht->key_len & (sizeof(u32) - 1))) { | ||
763 | ht->key_len /= sizeof(u32); | ||
764 | ht->p.hashfn = rhashtable_jhash2; | ||
765 | } | ||
766 | } | ||
767 | |||
768 | tbl = bucket_table_alloc(ht, size, GFP_KERNEL); | ||
1099 | if (tbl == NULL) | 769 | if (tbl == NULL) |
1100 | return -ENOMEM; | 770 | return -ENOMEM; |
1101 | 771 | ||
1102 | atomic_set(&ht->nelems, 0); | 772 | atomic_set(&ht->nelems, 0); |
1103 | atomic_set(&ht->shift, ilog2(tbl->size)); | ||
1104 | RCU_INIT_POINTER(ht->tbl, tbl); | ||
1105 | RCU_INIT_POINTER(ht->future_tbl, tbl); | ||
1106 | 773 | ||
1107 | if (!ht->p.hash_rnd) | 774 | RCU_INIT_POINTER(ht->tbl, tbl); |
1108 | get_random_bytes(&ht->p.hash_rnd, sizeof(ht->p.hash_rnd)); | ||
1109 | 775 | ||
1110 | INIT_WORK(&ht->run_work, rht_deferred_worker); | 776 | INIT_WORK(&ht->run_work, rht_deferred_worker); |
1111 | 777 | ||
@@ -1114,21 +780,53 @@ int rhashtable_init(struct rhashtable *ht, struct rhashtable_params *params) | |||
1114 | EXPORT_SYMBOL_GPL(rhashtable_init); | 780 | EXPORT_SYMBOL_GPL(rhashtable_init); |
1115 | 781 | ||
1116 | /** | 782 | /** |
1117 | * rhashtable_destroy - destroy hash table | 783 | * rhashtable_free_and_destroy - free elements and destroy hash table |
1118 | * @ht: the hash table to destroy | 784 | * @ht: the hash table to destroy |
785 | * @free_fn: callback to release resources of element | ||
786 | * @arg: pointer passed to free_fn | ||
787 | * | ||
788 | * Stops an eventual async resize. If defined, invokes free_fn for each | ||
789 | * element to releasal resources. Please note that RCU protected | ||
790 | * readers may still be accessing the elements. Releasing of resources | ||
791 | * must occur in a compatible manner. Then frees the bucket array. | ||
1119 | * | 792 | * |
1120 | * Frees the bucket array. This function is not rcu safe, therefore the caller | 793 | * This function will eventually sleep to wait for an async resize |
1121 | * has to make sure that no resizing may happen by unpublishing the hashtable | 794 | * to complete. The caller is responsible that no further write operations |
1122 | * and waiting for the quiescent cycle before releasing the bucket array. | 795 | * occurs in parallel. |
1123 | */ | 796 | */ |
1124 | void rhashtable_destroy(struct rhashtable *ht) | 797 | void rhashtable_free_and_destroy(struct rhashtable *ht, |
798 | void (*free_fn)(void *ptr, void *arg), | ||
799 | void *arg) | ||
1125 | { | 800 | { |
1126 | ht->being_destroyed = true; | 801 | const struct bucket_table *tbl; |
802 | unsigned int i; | ||
1127 | 803 | ||
1128 | cancel_work_sync(&ht->run_work); | 804 | cancel_work_sync(&ht->run_work); |
1129 | 805 | ||
1130 | mutex_lock(&ht->mutex); | 806 | mutex_lock(&ht->mutex); |
1131 | bucket_table_free(rht_dereference(ht->tbl, ht)); | 807 | tbl = rht_dereference(ht->tbl, ht); |
808 | if (free_fn) { | ||
809 | for (i = 0; i < tbl->size; i++) { | ||
810 | struct rhash_head *pos, *next; | ||
811 | |||
812 | for (pos = rht_dereference(tbl->buckets[i], ht), | ||
813 | next = !rht_is_a_nulls(pos) ? | ||
814 | rht_dereference(pos->next, ht) : NULL; | ||
815 | !rht_is_a_nulls(pos); | ||
816 | pos = next, | ||
817 | next = !rht_is_a_nulls(pos) ? | ||
818 | rht_dereference(pos->next, ht) : NULL) | ||
819 | free_fn(rht_obj(ht, pos), arg); | ||
820 | } | ||
821 | } | ||
822 | |||
823 | bucket_table_free(tbl); | ||
1132 | mutex_unlock(&ht->mutex); | 824 | mutex_unlock(&ht->mutex); |
1133 | } | 825 | } |
826 | EXPORT_SYMBOL_GPL(rhashtable_free_and_destroy); | ||
827 | |||
828 | void rhashtable_destroy(struct rhashtable *ht) | ||
829 | { | ||
830 | return rhashtable_free_and_destroy(ht, NULL, NULL); | ||
831 | } | ||
1134 | EXPORT_SYMBOL_GPL(rhashtable_destroy); | 832 | EXPORT_SYMBOL_GPL(rhashtable_destroy); |
diff --git a/lib/sha1.c b/lib/sha1.c index 1df191e04a24..5a56dfd7b99d 100644 --- a/lib/sha1.c +++ b/lib/sha1.c | |||
@@ -198,3 +198,4 @@ void sha_init(__u32 *buf) | |||
198 | buf[3] = 0x10325476; | 198 | buf[3] = 0x10325476; |
199 | buf[4] = 0xc3d2e1f0; | 199 | buf[4] = 0xc3d2e1f0; |
200 | } | 200 | } |
201 | EXPORT_SYMBOL(sha_init); | ||
diff --git a/lib/string.c b/lib/string.c index ce81aaec3839..a5792019193c 100644 --- a/lib/string.c +++ b/lib/string.c | |||
@@ -607,7 +607,7 @@ EXPORT_SYMBOL(memset); | |||
607 | void memzero_explicit(void *s, size_t count) | 607 | void memzero_explicit(void *s, size_t count) |
608 | { | 608 | { |
609 | memset(s, 0, count); | 609 | memset(s, 0, count); |
610 | OPTIMIZER_HIDE_VAR(s); | 610 | barrier(); |
611 | } | 611 | } |
612 | EXPORT_SYMBOL(memzero_explicit); | 612 | EXPORT_SYMBOL(memzero_explicit); |
613 | 613 | ||
diff --git a/lib/string_helpers.c b/lib/string_helpers.c index 8f8c4417f228..c98ae818eb4e 100644 --- a/lib/string_helpers.c +++ b/lib/string_helpers.c | |||
@@ -4,6 +4,7 @@ | |||
4 | * Copyright 31 August 2008 James Bottomley | 4 | * Copyright 31 August 2008 James Bottomley |
5 | * Copyright (C) 2013, Intel Corporation | 5 | * Copyright (C) 2013, Intel Corporation |
6 | */ | 6 | */ |
7 | #include <linux/bug.h> | ||
7 | #include <linux/kernel.h> | 8 | #include <linux/kernel.h> |
8 | #include <linux/math64.h> | 9 | #include <linux/math64.h> |
9 | #include <linux/export.h> | 10 | #include <linux/export.h> |
@@ -14,7 +15,8 @@ | |||
14 | 15 | ||
15 | /** | 16 | /** |
16 | * string_get_size - get the size in the specified units | 17 | * string_get_size - get the size in the specified units |
17 | * @size: The size to be converted | 18 | * @size: The size to be converted in blocks |
19 | * @blk_size: Size of the block (use 1 for size in bytes) | ||
18 | * @units: units to use (powers of 1000 or 1024) | 20 | * @units: units to use (powers of 1000 or 1024) |
19 | * @buf: buffer to format to | 21 | * @buf: buffer to format to |
20 | * @len: length of buffer | 22 | * @len: length of buffer |
@@ -24,14 +26,14 @@ | |||
24 | * at least 9 bytes and will always be zero terminated. | 26 | * at least 9 bytes and will always be zero terminated. |
25 | * | 27 | * |
26 | */ | 28 | */ |
27 | void string_get_size(u64 size, const enum string_size_units units, | 29 | void string_get_size(u64 size, u64 blk_size, const enum string_size_units units, |
28 | char *buf, int len) | 30 | char *buf, int len) |
29 | { | 31 | { |
30 | static const char *const units_10[] = { | 32 | static const char *const units_10[] = { |
31 | "B", "kB", "MB", "GB", "TB", "PB", "EB" | 33 | "B", "kB", "MB", "GB", "TB", "PB", "EB", "ZB", "YB" |
32 | }; | 34 | }; |
33 | static const char *const units_2[] = { | 35 | static const char *const units_2[] = { |
34 | "B", "KiB", "MiB", "GiB", "TiB", "PiB", "EiB" | 36 | "B", "KiB", "MiB", "GiB", "TiB", "PiB", "EiB", "ZiB", "YiB" |
35 | }; | 37 | }; |
36 | static const char *const *const units_str[] = { | 38 | static const char *const *const units_str[] = { |
37 | [STRING_UNITS_10] = units_10, | 39 | [STRING_UNITS_10] = units_10, |
@@ -42,31 +44,57 @@ void string_get_size(u64 size, const enum string_size_units units, | |||
42 | [STRING_UNITS_2] = 1024, | 44 | [STRING_UNITS_2] = 1024, |
43 | }; | 45 | }; |
44 | int i, j; | 46 | int i, j; |
45 | u32 remainder = 0, sf_cap; | 47 | u32 remainder = 0, sf_cap, exp; |
46 | char tmp[8]; | 48 | char tmp[8]; |
49 | const char *unit; | ||
47 | 50 | ||
48 | tmp[0] = '\0'; | 51 | tmp[0] = '\0'; |
49 | i = 0; | 52 | i = 0; |
50 | if (size >= divisor[units]) { | 53 | if (!size) |
51 | while (size >= divisor[units]) { | 54 | goto out; |
52 | remainder = do_div(size, divisor[units]); | ||
53 | i++; | ||
54 | } | ||
55 | 55 | ||
56 | sf_cap = size; | 56 | while (blk_size >= divisor[units]) { |
57 | for (j = 0; sf_cap*10 < 1000; j++) | 57 | remainder = do_div(blk_size, divisor[units]); |
58 | sf_cap *= 10; | 58 | i++; |
59 | } | ||
59 | 60 | ||
60 | if (j) { | 61 | exp = divisor[units] / (u32)blk_size; |
61 | remainder *= 1000; | 62 | if (size >= exp) { |
62 | remainder /= divisor[units]; | 63 | remainder = do_div(size, divisor[units]); |
63 | snprintf(tmp, sizeof(tmp), ".%03u", remainder); | 64 | remainder *= blk_size; |
64 | tmp[j+1] = '\0'; | 65 | i++; |
65 | } | 66 | } else { |
67 | remainder *= size; | ||
68 | } | ||
69 | |||
70 | size *= blk_size; | ||
71 | size += remainder / divisor[units]; | ||
72 | remainder %= divisor[units]; | ||
73 | |||
74 | while (size >= divisor[units]) { | ||
75 | remainder = do_div(size, divisor[units]); | ||
76 | i++; | ||
66 | } | 77 | } |
67 | 78 | ||
79 | sf_cap = size; | ||
80 | for (j = 0; sf_cap*10 < 1000; j++) | ||
81 | sf_cap *= 10; | ||
82 | |||
83 | if (j) { | ||
84 | remainder *= 1000; | ||
85 | remainder /= divisor[units]; | ||
86 | snprintf(tmp, sizeof(tmp), ".%03u", remainder); | ||
87 | tmp[j+1] = '\0'; | ||
88 | } | ||
89 | |||
90 | out: | ||
91 | if (i >= ARRAY_SIZE(units_2)) | ||
92 | unit = "UNK"; | ||
93 | else | ||
94 | unit = units_str[units][i]; | ||
95 | |||
68 | snprintf(buf, len, "%u%s %s", (u32)size, | 96 | snprintf(buf, len, "%u%s %s", (u32)size, |
69 | tmp, units_str[units][i]); | 97 | tmp, unit); |
70 | } | 98 | } |
71 | EXPORT_SYMBOL(string_get_size); | 99 | EXPORT_SYMBOL(string_get_size); |
72 | 100 | ||
@@ -239,29 +267,21 @@ int string_unescape(char *src, char *dst, size_t size, unsigned int flags) | |||
239 | } | 267 | } |
240 | EXPORT_SYMBOL(string_unescape); | 268 | EXPORT_SYMBOL(string_unescape); |
241 | 269 | ||
242 | static int escape_passthrough(unsigned char c, char **dst, size_t *osz) | 270 | static bool escape_passthrough(unsigned char c, char **dst, char *end) |
243 | { | 271 | { |
244 | char *out = *dst; | 272 | char *out = *dst; |
245 | 273 | ||
246 | if (*osz < 1) | 274 | if (out < end) |
247 | return -ENOMEM; | 275 | *out = c; |
248 | 276 | *dst = out + 1; | |
249 | *out++ = c; | 277 | return true; |
250 | |||
251 | *dst = out; | ||
252 | *osz -= 1; | ||
253 | |||
254 | return 1; | ||
255 | } | 278 | } |
256 | 279 | ||
257 | static int escape_space(unsigned char c, char **dst, size_t *osz) | 280 | static bool escape_space(unsigned char c, char **dst, char *end) |
258 | { | 281 | { |
259 | char *out = *dst; | 282 | char *out = *dst; |
260 | unsigned char to; | 283 | unsigned char to; |
261 | 284 | ||
262 | if (*osz < 2) | ||
263 | return -ENOMEM; | ||
264 | |||
265 | switch (c) { | 285 | switch (c) { |
266 | case '\n': | 286 | case '\n': |
267 | to = 'n'; | 287 | to = 'n'; |
@@ -279,26 +299,25 @@ static int escape_space(unsigned char c, char **dst, size_t *osz) | |||
279 | to = 'f'; | 299 | to = 'f'; |
280 | break; | 300 | break; |
281 | default: | 301 | default: |
282 | return 0; | 302 | return false; |
283 | } | 303 | } |
284 | 304 | ||
285 | *out++ = '\\'; | 305 | if (out < end) |
286 | *out++ = to; | 306 | *out = '\\'; |
307 | ++out; | ||
308 | if (out < end) | ||
309 | *out = to; | ||
310 | ++out; | ||
287 | 311 | ||
288 | *dst = out; | 312 | *dst = out; |
289 | *osz -= 2; | 313 | return true; |
290 | |||
291 | return 1; | ||
292 | } | 314 | } |
293 | 315 | ||
294 | static int escape_special(unsigned char c, char **dst, size_t *osz) | 316 | static bool escape_special(unsigned char c, char **dst, char *end) |
295 | { | 317 | { |
296 | char *out = *dst; | 318 | char *out = *dst; |
297 | unsigned char to; | 319 | unsigned char to; |
298 | 320 | ||
299 | if (*osz < 2) | ||
300 | return -ENOMEM; | ||
301 | |||
302 | switch (c) { | 321 | switch (c) { |
303 | case '\\': | 322 | case '\\': |
304 | to = '\\'; | 323 | to = '\\'; |
@@ -310,71 +329,78 @@ static int escape_special(unsigned char c, char **dst, size_t *osz) | |||
310 | to = 'e'; | 329 | to = 'e'; |
311 | break; | 330 | break; |
312 | default: | 331 | default: |
313 | return 0; | 332 | return false; |
314 | } | 333 | } |
315 | 334 | ||
316 | *out++ = '\\'; | 335 | if (out < end) |
317 | *out++ = to; | 336 | *out = '\\'; |
337 | ++out; | ||
338 | if (out < end) | ||
339 | *out = to; | ||
340 | ++out; | ||
318 | 341 | ||
319 | *dst = out; | 342 | *dst = out; |
320 | *osz -= 2; | 343 | return true; |
321 | |||
322 | return 1; | ||
323 | } | 344 | } |
324 | 345 | ||
325 | static int escape_null(unsigned char c, char **dst, size_t *osz) | 346 | static bool escape_null(unsigned char c, char **dst, char *end) |
326 | { | 347 | { |
327 | char *out = *dst; | 348 | char *out = *dst; |
328 | 349 | ||
329 | if (*osz < 2) | ||
330 | return -ENOMEM; | ||
331 | |||
332 | if (c) | 350 | if (c) |
333 | return 0; | 351 | return false; |
334 | 352 | ||
335 | *out++ = '\\'; | 353 | if (out < end) |
336 | *out++ = '0'; | 354 | *out = '\\'; |
355 | ++out; | ||
356 | if (out < end) | ||
357 | *out = '0'; | ||
358 | ++out; | ||
337 | 359 | ||
338 | *dst = out; | 360 | *dst = out; |
339 | *osz -= 2; | 361 | return true; |
340 | |||
341 | return 1; | ||
342 | } | 362 | } |
343 | 363 | ||
344 | static int escape_octal(unsigned char c, char **dst, size_t *osz) | 364 | static bool escape_octal(unsigned char c, char **dst, char *end) |
345 | { | 365 | { |
346 | char *out = *dst; | 366 | char *out = *dst; |
347 | 367 | ||
348 | if (*osz < 4) | 368 | if (out < end) |
349 | return -ENOMEM; | 369 | *out = '\\'; |
350 | 370 | ++out; | |
351 | *out++ = '\\'; | 371 | if (out < end) |
352 | *out++ = ((c >> 6) & 0x07) + '0'; | 372 | *out = ((c >> 6) & 0x07) + '0'; |
353 | *out++ = ((c >> 3) & 0x07) + '0'; | 373 | ++out; |
354 | *out++ = ((c >> 0) & 0x07) + '0'; | 374 | if (out < end) |
375 | *out = ((c >> 3) & 0x07) + '0'; | ||
376 | ++out; | ||
377 | if (out < end) | ||
378 | *out = ((c >> 0) & 0x07) + '0'; | ||
379 | ++out; | ||
355 | 380 | ||
356 | *dst = out; | 381 | *dst = out; |
357 | *osz -= 4; | 382 | return true; |
358 | |||
359 | return 1; | ||
360 | } | 383 | } |
361 | 384 | ||
362 | static int escape_hex(unsigned char c, char **dst, size_t *osz) | 385 | static bool escape_hex(unsigned char c, char **dst, char *end) |
363 | { | 386 | { |
364 | char *out = *dst; | 387 | char *out = *dst; |
365 | 388 | ||
366 | if (*osz < 4) | 389 | if (out < end) |
367 | return -ENOMEM; | 390 | *out = '\\'; |
368 | 391 | ++out; | |
369 | *out++ = '\\'; | 392 | if (out < end) |
370 | *out++ = 'x'; | 393 | *out = 'x'; |
371 | *out++ = hex_asc_hi(c); | 394 | ++out; |
372 | *out++ = hex_asc_lo(c); | 395 | if (out < end) |
396 | *out = hex_asc_hi(c); | ||
397 | ++out; | ||
398 | if (out < end) | ||
399 | *out = hex_asc_lo(c); | ||
400 | ++out; | ||
373 | 401 | ||
374 | *dst = out; | 402 | *dst = out; |
375 | *osz -= 4; | 403 | return true; |
376 | |||
377 | return 1; | ||
378 | } | 404 | } |
379 | 405 | ||
380 | /** | 406 | /** |
@@ -426,19 +452,17 @@ static int escape_hex(unsigned char c, char **dst, size_t *osz) | |||
426 | * it if needs. | 452 | * it if needs. |
427 | * | 453 | * |
428 | * Return: | 454 | * Return: |
429 | * The amount of the characters processed to the destination buffer, or | 455 | * The total size of the escaped output that would be generated for |
430 | * %-ENOMEM if the size of buffer is not enough to put an escaped character is | 456 | * the given input and flags. To check whether the output was |
431 | * returned. | 457 | * truncated, compare the return value to osz. There is room left in |
432 | * | 458 | * dst for a '\0' terminator if and only if ret < osz. |
433 | * Even in the case of error @dst pointer will be updated to point to the byte | ||
434 | * after the last processed character. | ||
435 | */ | 459 | */ |
436 | int string_escape_mem(const char *src, size_t isz, char **dst, size_t osz, | 460 | int string_escape_mem(const char *src, size_t isz, char *dst, size_t osz, |
437 | unsigned int flags, const char *esc) | 461 | unsigned int flags, const char *esc) |
438 | { | 462 | { |
439 | char *out = *dst, *p = out; | 463 | char *p = dst; |
464 | char *end = p + osz; | ||
440 | bool is_dict = esc && *esc; | 465 | bool is_dict = esc && *esc; |
441 | int ret = 0; | ||
442 | 466 | ||
443 | while (isz--) { | 467 | while (isz--) { |
444 | unsigned char c = *src++; | 468 | unsigned char c = *src++; |
@@ -458,55 +482,26 @@ int string_escape_mem(const char *src, size_t isz, char **dst, size_t osz, | |||
458 | (is_dict && !strchr(esc, c))) { | 482 | (is_dict && !strchr(esc, c))) { |
459 | /* do nothing */ | 483 | /* do nothing */ |
460 | } else { | 484 | } else { |
461 | if (flags & ESCAPE_SPACE) { | 485 | if (flags & ESCAPE_SPACE && escape_space(c, &p, end)) |
462 | ret = escape_space(c, &p, &osz); | 486 | continue; |
463 | if (ret < 0) | 487 | |
464 | break; | 488 | if (flags & ESCAPE_SPECIAL && escape_special(c, &p, end)) |
465 | if (ret > 0) | 489 | continue; |
466 | continue; | 490 | |
467 | } | 491 | if (flags & ESCAPE_NULL && escape_null(c, &p, end)) |
468 | 492 | continue; | |
469 | if (flags & ESCAPE_SPECIAL) { | ||
470 | ret = escape_special(c, &p, &osz); | ||
471 | if (ret < 0) | ||
472 | break; | ||
473 | if (ret > 0) | ||
474 | continue; | ||
475 | } | ||
476 | |||
477 | if (flags & ESCAPE_NULL) { | ||
478 | ret = escape_null(c, &p, &osz); | ||
479 | if (ret < 0) | ||
480 | break; | ||
481 | if (ret > 0) | ||
482 | continue; | ||
483 | } | ||
484 | 493 | ||
485 | /* ESCAPE_OCTAL and ESCAPE_HEX always go last */ | 494 | /* ESCAPE_OCTAL and ESCAPE_HEX always go last */ |
486 | if (flags & ESCAPE_OCTAL) { | 495 | if (flags & ESCAPE_OCTAL && escape_octal(c, &p, end)) |
487 | ret = escape_octal(c, &p, &osz); | ||
488 | if (ret < 0) | ||
489 | break; | ||
490 | continue; | 496 | continue; |
491 | } | 497 | |
492 | if (flags & ESCAPE_HEX) { | 498 | if (flags & ESCAPE_HEX && escape_hex(c, &p, end)) |
493 | ret = escape_hex(c, &p, &osz); | ||
494 | if (ret < 0) | ||
495 | break; | ||
496 | continue; | 499 | continue; |
497 | } | ||
498 | } | 500 | } |
499 | 501 | ||
500 | ret = escape_passthrough(c, &p, &osz); | 502 | escape_passthrough(c, &p, end); |
501 | if (ret < 0) | ||
502 | break; | ||
503 | } | 503 | } |
504 | 504 | ||
505 | *dst = p; | 505 | return p - dst; |
506 | |||
507 | if (ret < 0) | ||
508 | return ret; | ||
509 | |||
510 | return p - out; | ||
511 | } | 506 | } |
512 | EXPORT_SYMBOL(string_escape_mem); | 507 | EXPORT_SYMBOL(string_escape_mem); |
diff --git a/lib/test-hexdump.c b/lib/test-hexdump.c index daf29a390a89..9846ff7428b3 100644 --- a/lib/test-hexdump.c +++ b/lib/test-hexdump.c | |||
@@ -18,26 +18,26 @@ static const unsigned char data_b[] = { | |||
18 | 18 | ||
19 | static const unsigned char data_a[] = ".2.{....p..$}.4...1.....L...C..."; | 19 | static const unsigned char data_a[] = ".2.{....p..$}.4...1.....L...C..."; |
20 | 20 | ||
21 | static const char *test_data_1_le[] __initconst = { | 21 | static const char * const test_data_1_le[] __initconst = { |
22 | "be", "32", "db", "7b", "0a", "18", "93", "b2", | 22 | "be", "32", "db", "7b", "0a", "18", "93", "b2", |
23 | "70", "ba", "c4", "24", "7d", "83", "34", "9b", | 23 | "70", "ba", "c4", "24", "7d", "83", "34", "9b", |
24 | "a6", "9c", "31", "ad", "9c", "0f", "ac", "e9", | 24 | "a6", "9c", "31", "ad", "9c", "0f", "ac", "e9", |
25 | "4c", "d1", "19", "99", "43", "b1", "af", "0c", | 25 | "4c", "d1", "19", "99", "43", "b1", "af", "0c", |
26 | }; | 26 | }; |
27 | 27 | ||
28 | static const char *test_data_2_le[] __initconst = { | 28 | static const char *test_data_2_le[] __initdata = { |
29 | "32be", "7bdb", "180a", "b293", | 29 | "32be", "7bdb", "180a", "b293", |
30 | "ba70", "24c4", "837d", "9b34", | 30 | "ba70", "24c4", "837d", "9b34", |
31 | "9ca6", "ad31", "0f9c", "e9ac", | 31 | "9ca6", "ad31", "0f9c", "e9ac", |
32 | "d14c", "9919", "b143", "0caf", | 32 | "d14c", "9919", "b143", "0caf", |
33 | }; | 33 | }; |
34 | 34 | ||
35 | static const char *test_data_4_le[] __initconst = { | 35 | static const char *test_data_4_le[] __initdata = { |
36 | "7bdb32be", "b293180a", "24c4ba70", "9b34837d", | 36 | "7bdb32be", "b293180a", "24c4ba70", "9b34837d", |
37 | "ad319ca6", "e9ac0f9c", "9919d14c", "0cafb143", | 37 | "ad319ca6", "e9ac0f9c", "9919d14c", "0cafb143", |
38 | }; | 38 | }; |
39 | 39 | ||
40 | static const char *test_data_8_le[] __initconst = { | 40 | static const char *test_data_8_le[] __initdata = { |
41 | "b293180a7bdb32be", "9b34837d24c4ba70", | 41 | "b293180a7bdb32be", "9b34837d24c4ba70", |
42 | "e9ac0f9cad319ca6", "0cafb1439919d14c", | 42 | "e9ac0f9cad319ca6", "0cafb1439919d14c", |
43 | }; | 43 | }; |
diff --git a/lib/test-string_helpers.c b/lib/test-string_helpers.c index ab0d30e1e18f..8e376efd88a4 100644 --- a/lib/test-string_helpers.c +++ b/lib/test-string_helpers.c | |||
@@ -260,16 +260,28 @@ static __init const char *test_string_find_match(const struct test_string_2 *s2, | |||
260 | return NULL; | 260 | return NULL; |
261 | } | 261 | } |
262 | 262 | ||
263 | static __init void | ||
264 | test_string_escape_overflow(const char *in, int p, unsigned int flags, const char *esc, | ||
265 | int q_test, const char *name) | ||
266 | { | ||
267 | int q_real; | ||
268 | |||
269 | q_real = string_escape_mem(in, p, NULL, 0, flags, esc); | ||
270 | if (q_real != q_test) | ||
271 | pr_warn("Test '%s' failed: flags = %u, osz = 0, expected %d, got %d\n", | ||
272 | name, flags, q_test, q_real); | ||
273 | } | ||
274 | |||
263 | static __init void test_string_escape(const char *name, | 275 | static __init void test_string_escape(const char *name, |
264 | const struct test_string_2 *s2, | 276 | const struct test_string_2 *s2, |
265 | unsigned int flags, const char *esc) | 277 | unsigned int flags, const char *esc) |
266 | { | 278 | { |
267 | int q_real = 512; | 279 | size_t out_size = 512; |
268 | char *out_test = kmalloc(q_real, GFP_KERNEL); | 280 | char *out_test = kmalloc(out_size, GFP_KERNEL); |
269 | char *out_real = kmalloc(q_real, GFP_KERNEL); | 281 | char *out_real = kmalloc(out_size, GFP_KERNEL); |
270 | char *in = kmalloc(256, GFP_KERNEL); | 282 | char *in = kmalloc(256, GFP_KERNEL); |
271 | char *buf = out_real; | ||
272 | int p = 0, q_test = 0; | 283 | int p = 0, q_test = 0; |
284 | int q_real; | ||
273 | 285 | ||
274 | if (!out_test || !out_real || !in) | 286 | if (!out_test || !out_real || !in) |
275 | goto out; | 287 | goto out; |
@@ -301,29 +313,19 @@ static __init void test_string_escape(const char *name, | |||
301 | q_test += len; | 313 | q_test += len; |
302 | } | 314 | } |
303 | 315 | ||
304 | q_real = string_escape_mem(in, p, &buf, q_real, flags, esc); | 316 | q_real = string_escape_mem(in, p, out_real, out_size, flags, esc); |
305 | 317 | ||
306 | test_string_check_buf(name, flags, in, p, out_real, q_real, out_test, | 318 | test_string_check_buf(name, flags, in, p, out_real, q_real, out_test, |
307 | q_test); | 319 | q_test); |
320 | |||
321 | test_string_escape_overflow(in, p, flags, esc, q_test, name); | ||
322 | |||
308 | out: | 323 | out: |
309 | kfree(in); | 324 | kfree(in); |
310 | kfree(out_real); | 325 | kfree(out_real); |
311 | kfree(out_test); | 326 | kfree(out_test); |
312 | } | 327 | } |
313 | 328 | ||
314 | static __init void test_string_escape_nomem(void) | ||
315 | { | ||
316 | char *in = "\eb \\C\007\"\x90\r]"; | ||
317 | char out[64], *buf = out; | ||
318 | int rc = -ENOMEM, ret; | ||
319 | |||
320 | ret = string_escape_str_any_np(in, &buf, strlen(in), NULL); | ||
321 | if (ret == rc) | ||
322 | return; | ||
323 | |||
324 | pr_err("Test 'escape nomem' failed: got %d instead of %d\n", ret, rc); | ||
325 | } | ||
326 | |||
327 | static int __init test_string_helpers_init(void) | 329 | static int __init test_string_helpers_init(void) |
328 | { | 330 | { |
329 | unsigned int i; | 331 | unsigned int i; |
@@ -342,8 +344,6 @@ static int __init test_string_helpers_init(void) | |||
342 | for (i = 0; i < (ESCAPE_ANY_NP | ESCAPE_HEX) + 1; i++) | 344 | for (i = 0; i < (ESCAPE_ANY_NP | ESCAPE_HEX) + 1; i++) |
343 | test_string_escape("escape 1", escape1, i, TEST_STRING_2_DICT_1); | 345 | test_string_escape("escape 1", escape1, i, TEST_STRING_2_DICT_1); |
344 | 346 | ||
345 | test_string_escape_nomem(); | ||
346 | |||
347 | return -EINVAL; | 347 | return -EINVAL; |
348 | } | 348 | } |
349 | module_init(test_string_helpers_init); | 349 | module_init(test_string_helpers_init); |
diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c index 67c7593d1dd6..b2957540d3c7 100644 --- a/lib/test_rhashtable.c +++ b/lib/test_rhashtable.c | |||
@@ -38,6 +38,15 @@ struct test_obj { | |||
38 | struct rhash_head node; | 38 | struct rhash_head node; |
39 | }; | 39 | }; |
40 | 40 | ||
41 | static const struct rhashtable_params test_rht_params = { | ||
42 | .nelem_hint = TEST_HT_SIZE, | ||
43 | .head_offset = offsetof(struct test_obj, node), | ||
44 | .key_offset = offsetof(struct test_obj, value), | ||
45 | .key_len = sizeof(int), | ||
46 | .hashfn = jhash, | ||
47 | .nulls_base = (3U << RHT_BASE_SHIFT), | ||
48 | }; | ||
49 | |||
41 | static int __init test_rht_lookup(struct rhashtable *ht) | 50 | static int __init test_rht_lookup(struct rhashtable *ht) |
42 | { | 51 | { |
43 | unsigned int i; | 52 | unsigned int i; |
@@ -47,7 +56,7 @@ static int __init test_rht_lookup(struct rhashtable *ht) | |||
47 | bool expected = !(i % 2); | 56 | bool expected = !(i % 2); |
48 | u32 key = i; | 57 | u32 key = i; |
49 | 58 | ||
50 | obj = rhashtable_lookup(ht, &key); | 59 | obj = rhashtable_lookup_fast(ht, &key, test_rht_params); |
51 | 60 | ||
52 | if (expected && !obj) { | 61 | if (expected && !obj) { |
53 | pr_warn("Test failed: Could not find key %u\n", key); | 62 | pr_warn("Test failed: Could not find key %u\n", key); |
@@ -80,7 +89,7 @@ static void test_bucket_stats(struct rhashtable *ht, bool quiet) | |||
80 | rcu_cnt = cnt = 0; | 89 | rcu_cnt = cnt = 0; |
81 | 90 | ||
82 | if (!quiet) | 91 | if (!quiet) |
83 | pr_info(" [%#4x/%zu]", i, tbl->size); | 92 | pr_info(" [%#4x/%u]", i, tbl->size); |
84 | 93 | ||
85 | rht_for_each_entry_rcu(obj, pos, tbl, i, node) { | 94 | rht_for_each_entry_rcu(obj, pos, tbl, i, node) { |
86 | cnt++; | 95 | cnt++; |
@@ -133,7 +142,11 @@ static int __init test_rhashtable(struct rhashtable *ht) | |||
133 | obj->ptr = TEST_PTR; | 142 | obj->ptr = TEST_PTR; |
134 | obj->value = i * 2; | 143 | obj->value = i * 2; |
135 | 144 | ||
136 | rhashtable_insert(ht, &obj->node); | 145 | err = rhashtable_insert_fast(ht, &obj->node, test_rht_params); |
146 | if (err) { | ||
147 | kfree(obj); | ||
148 | goto error; | ||
149 | } | ||
137 | } | 150 | } |
138 | 151 | ||
139 | rcu_read_lock(); | 152 | rcu_read_lock(); |
@@ -141,30 +154,6 @@ static int __init test_rhashtable(struct rhashtable *ht) | |||
141 | test_rht_lookup(ht); | 154 | test_rht_lookup(ht); |
142 | rcu_read_unlock(); | 155 | rcu_read_unlock(); |
143 | 156 | ||
144 | for (i = 0; i < TEST_NEXPANDS; i++) { | ||
145 | pr_info(" Table expansion iteration %u...\n", i); | ||
146 | mutex_lock(&ht->mutex); | ||
147 | rhashtable_expand(ht); | ||
148 | mutex_unlock(&ht->mutex); | ||
149 | |||
150 | rcu_read_lock(); | ||
151 | pr_info(" Verifying lookups...\n"); | ||
152 | test_rht_lookup(ht); | ||
153 | rcu_read_unlock(); | ||
154 | } | ||
155 | |||
156 | for (i = 0; i < TEST_NEXPANDS; i++) { | ||
157 | pr_info(" Table shrinkage iteration %u...\n", i); | ||
158 | mutex_lock(&ht->mutex); | ||
159 | rhashtable_shrink(ht); | ||
160 | mutex_unlock(&ht->mutex); | ||
161 | |||
162 | rcu_read_lock(); | ||
163 | pr_info(" Verifying lookups...\n"); | ||
164 | test_rht_lookup(ht); | ||
165 | rcu_read_unlock(); | ||
166 | } | ||
167 | |||
168 | rcu_read_lock(); | 157 | rcu_read_lock(); |
169 | test_bucket_stats(ht, true); | 158 | test_bucket_stats(ht, true); |
170 | rcu_read_unlock(); | 159 | rcu_read_unlock(); |
@@ -173,10 +162,10 @@ static int __init test_rhashtable(struct rhashtable *ht) | |||
173 | for (i = 0; i < TEST_ENTRIES; i++) { | 162 | for (i = 0; i < TEST_ENTRIES; i++) { |
174 | u32 key = i * 2; | 163 | u32 key = i * 2; |
175 | 164 | ||
176 | obj = rhashtable_lookup(ht, &key); | 165 | obj = rhashtable_lookup_fast(ht, &key, test_rht_params); |
177 | BUG_ON(!obj); | 166 | BUG_ON(!obj); |
178 | 167 | ||
179 | rhashtable_remove(ht, &obj->node); | 168 | rhashtable_remove_fast(ht, &obj->node, test_rht_params); |
180 | kfree(obj); | 169 | kfree(obj); |
181 | } | 170 | } |
182 | 171 | ||
@@ -195,20 +184,11 @@ static struct rhashtable ht; | |||
195 | 184 | ||
196 | static int __init test_rht_init(void) | 185 | static int __init test_rht_init(void) |
197 | { | 186 | { |
198 | struct rhashtable_params params = { | ||
199 | .nelem_hint = TEST_HT_SIZE, | ||
200 | .head_offset = offsetof(struct test_obj, node), | ||
201 | .key_offset = offsetof(struct test_obj, value), | ||
202 | .key_len = sizeof(int), | ||
203 | .hashfn = jhash, | ||
204 | .max_shift = 1, /* we expand/shrink manually here */ | ||
205 | .nulls_base = (3U << RHT_BASE_SHIFT), | ||
206 | }; | ||
207 | int err; | 187 | int err; |
208 | 188 | ||
209 | pr_info("Running resizable hashtable tests...\n"); | 189 | pr_info("Running resizable hashtable tests...\n"); |
210 | 190 | ||
211 | err = rhashtable_init(&ht, ¶ms); | 191 | err = rhashtable_init(&ht, &test_rht_params); |
212 | if (err < 0) { | 192 | if (err < 0) { |
213 | pr_warn("Test failed: Unable to initialize hashtable: %d\n", | 193 | pr_warn("Test failed: Unable to initialize hashtable: %d\n", |
214 | err); | 194 | err); |
diff --git a/lib/vsprintf.c b/lib/vsprintf.c index b235c96167d3..da39c608a28c 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c | |||
@@ -17,6 +17,7 @@ | |||
17 | */ | 17 | */ |
18 | 18 | ||
19 | #include <stdarg.h> | 19 | #include <stdarg.h> |
20 | #include <linux/clk-provider.h> | ||
20 | #include <linux/module.h> /* for KSYM_SYMBOL_LEN */ | 21 | #include <linux/module.h> /* for KSYM_SYMBOL_LEN */ |
21 | #include <linux/types.h> | 22 | #include <linux/types.h> |
22 | #include <linux/string.h> | 23 | #include <linux/string.h> |
@@ -32,6 +33,7 @@ | |||
32 | 33 | ||
33 | #include <asm/page.h> /* for PAGE_SIZE */ | 34 | #include <asm/page.h> /* for PAGE_SIZE */ |
34 | #include <asm/sections.h> /* for dereference_function_descriptor() */ | 35 | #include <asm/sections.h> /* for dereference_function_descriptor() */ |
36 | #include <asm/byteorder.h> /* cpu_to_le16 */ | ||
35 | 37 | ||
36 | #include <linux/string_helpers.h> | 38 | #include <linux/string_helpers.h> |
37 | #include "kstrtox.h" | 39 | #include "kstrtox.h" |
@@ -121,142 +123,145 @@ int skip_atoi(const char **s) | |||
121 | return i; | 123 | return i; |
122 | } | 124 | } |
123 | 125 | ||
124 | /* Decimal conversion is by far the most typical, and is used | 126 | /* |
125 | * for /proc and /sys data. This directly impacts e.g. top performance | 127 | * Decimal conversion is by far the most typical, and is used for |
126 | * with many processes running. We optimize it for speed | 128 | * /proc and /sys data. This directly impacts e.g. top performance |
127 | * using ideas described at <http://www.cs.uiowa.edu/~jones/bcd/divide.html> | 129 | * with many processes running. We optimize it for speed by emitting |
128 | * (with permission from the author, Douglas W. Jones). | 130 | * two characters at a time, using a 200 byte lookup table. This |
131 | * roughly halves the number of multiplications compared to computing | ||
132 | * the digits one at a time. Implementation strongly inspired by the | ||
133 | * previous version, which in turn used ideas described at | ||
134 | * <http://www.cs.uiowa.edu/~jones/bcd/divide.html> (with permission | ||
135 | * from the author, Douglas W. Jones). | ||
136 | * | ||
137 | * It turns out there is precisely one 26 bit fixed-point | ||
138 | * approximation a of 64/100 for which x/100 == (x * (u64)a) >> 32 | ||
139 | * holds for all x in [0, 10^8-1], namely a = 0x28f5c29. The actual | ||
140 | * range happens to be somewhat larger (x <= 1073741898), but that's | ||
141 | * irrelevant for our purpose. | ||
142 | * | ||
143 | * For dividing a number in the range [10^4, 10^6-1] by 100, we still | ||
144 | * need a 32x32->64 bit multiply, so we simply use the same constant. | ||
145 | * | ||
146 | * For dividing a number in the range [100, 10^4-1] by 100, there are | ||
147 | * several options. The simplest is (x * 0x147b) >> 19, which is valid | ||
148 | * for all x <= 43698. | ||
129 | */ | 149 | */ |
130 | 150 | ||
131 | #if BITS_PER_LONG != 32 || BITS_PER_LONG_LONG != 64 | 151 | static const u16 decpair[100] = { |
132 | /* Formats correctly any integer in [0, 999999999] */ | 152 | #define _(x) (__force u16) cpu_to_le16(((x % 10) | ((x / 10) << 8)) + 0x3030) |
153 | _( 0), _( 1), _( 2), _( 3), _( 4), _( 5), _( 6), _( 7), _( 8), _( 9), | ||
154 | _(10), _(11), _(12), _(13), _(14), _(15), _(16), _(17), _(18), _(19), | ||
155 | _(20), _(21), _(22), _(23), _(24), _(25), _(26), _(27), _(28), _(29), | ||
156 | _(30), _(31), _(32), _(33), _(34), _(35), _(36), _(37), _(38), _(39), | ||
157 | _(40), _(41), _(42), _(43), _(44), _(45), _(46), _(47), _(48), _(49), | ||
158 | _(50), _(51), _(52), _(53), _(54), _(55), _(56), _(57), _(58), _(59), | ||
159 | _(60), _(61), _(62), _(63), _(64), _(65), _(66), _(67), _(68), _(69), | ||
160 | _(70), _(71), _(72), _(73), _(74), _(75), _(76), _(77), _(78), _(79), | ||
161 | _(80), _(81), _(82), _(83), _(84), _(85), _(86), _(87), _(88), _(89), | ||
162 | _(90), _(91), _(92), _(93), _(94), _(95), _(96), _(97), _(98), _(99), | ||
163 | #undef _ | ||
164 | }; | ||
165 | |||
166 | /* | ||
167 | * This will print a single '0' even if r == 0, since we would | ||
168 | * immediately jump to out_r where two 0s would be written but only | ||
169 | * one of them accounted for in buf. This is needed by ip4_string | ||
170 | * below. All other callers pass a non-zero value of r. | ||
171 | */ | ||
133 | static noinline_for_stack | 172 | static noinline_for_stack |
134 | char *put_dec_full9(char *buf, unsigned q) | 173 | char *put_dec_trunc8(char *buf, unsigned r) |
135 | { | 174 | { |
136 | unsigned r; | 175 | unsigned q; |
137 | 176 | ||
138 | /* | 177 | /* 1 <= r < 10^8 */ |
139 | * Possible ways to approx. divide by 10 | 178 | if (r < 100) |
140 | * (x * 0x1999999a) >> 32 x < 1073741829 (multiply must be 64-bit) | 179 | goto out_r; |
141 | * (x * 0xcccd) >> 19 x < 81920 (x < 262149 when 64-bit mul) | 180 | |
142 | * (x * 0x6667) >> 18 x < 43699 | 181 | /* 100 <= r < 10^8 */ |
143 | * (x * 0x3334) >> 17 x < 16389 | 182 | q = (r * (u64)0x28f5c29) >> 32; |
144 | * (x * 0x199a) >> 16 x < 16389 | 183 | *((u16 *)buf) = decpair[r - 100*q]; |
145 | * (x * 0x0ccd) >> 15 x < 16389 | 184 | buf += 2; |
146 | * (x * 0x0667) >> 14 x < 2739 | 185 | |
147 | * (x * 0x0334) >> 13 x < 1029 | 186 | /* 1 <= q < 10^6 */ |
148 | * (x * 0x019a) >> 12 x < 1029 | 187 | if (q < 100) |
149 | * (x * 0x00cd) >> 11 x < 1029 shorter code than * 0x67 (on i386) | 188 | goto out_q; |
150 | * (x * 0x0067) >> 10 x < 179 | 189 | |
151 | * (x * 0x0034) >> 9 x < 69 same | 190 | /* 100 <= q < 10^6 */ |
152 | * (x * 0x001a) >> 8 x < 69 same | 191 | r = (q * (u64)0x28f5c29) >> 32; |
153 | * (x * 0x000d) >> 7 x < 69 same, shortest code (on i386) | 192 | *((u16 *)buf) = decpair[q - 100*r]; |
154 | * (x * 0x0007) >> 6 x < 19 | 193 | buf += 2; |
155 | * See <http://www.cs.uiowa.edu/~jones/bcd/divide.html> | 194 | |
156 | */ | 195 | /* 1 <= r < 10^4 */ |
157 | r = (q * (uint64_t)0x1999999a) >> 32; | 196 | if (r < 100) |
158 | *buf++ = (q - 10 * r) + '0'; /* 1 */ | 197 | goto out_r; |
159 | q = (r * (uint64_t)0x1999999a) >> 32; | 198 | |
160 | *buf++ = (r - 10 * q) + '0'; /* 2 */ | 199 | /* 100 <= r < 10^4 */ |
161 | r = (q * (uint64_t)0x1999999a) >> 32; | 200 | q = (r * 0x147b) >> 19; |
162 | *buf++ = (q - 10 * r) + '0'; /* 3 */ | 201 | *((u16 *)buf) = decpair[r - 100*q]; |
163 | q = (r * (uint64_t)0x1999999a) >> 32; | 202 | buf += 2; |
164 | *buf++ = (r - 10 * q) + '0'; /* 4 */ | 203 | out_q: |
165 | r = (q * (uint64_t)0x1999999a) >> 32; | 204 | /* 1 <= q < 100 */ |
166 | *buf++ = (q - 10 * r) + '0'; /* 5 */ | 205 | r = q; |
167 | /* Now value is under 10000, can avoid 64-bit multiply */ | 206 | out_r: |
168 | q = (r * 0x199a) >> 16; | 207 | /* 1 <= r < 100 */ |
169 | *buf++ = (r - 10 * q) + '0'; /* 6 */ | 208 | *((u16 *)buf) = decpair[r]; |
170 | r = (q * 0xcd) >> 11; | 209 | buf += r < 10 ? 1 : 2; |
171 | *buf++ = (q - 10 * r) + '0'; /* 7 */ | ||
172 | q = (r * 0xcd) >> 11; | ||
173 | *buf++ = (r - 10 * q) + '0'; /* 8 */ | ||
174 | *buf++ = q + '0'; /* 9 */ | ||
175 | return buf; | 210 | return buf; |
176 | } | 211 | } |
177 | #endif | ||
178 | 212 | ||
179 | /* Similar to above but do not pad with zeros. | 213 | #if BITS_PER_LONG == 64 && BITS_PER_LONG_LONG == 64 |
180 | * Code can be easily arranged to print 9 digits too, but our callers | ||
181 | * always call put_dec_full9() instead when the number has 9 decimal digits. | ||
182 | */ | ||
183 | static noinline_for_stack | 214 | static noinline_for_stack |
184 | char *put_dec_trunc8(char *buf, unsigned r) | 215 | char *put_dec_full8(char *buf, unsigned r) |
185 | { | 216 | { |
186 | unsigned q; | 217 | unsigned q; |
187 | 218 | ||
188 | /* Copy of previous function's body with added early returns */ | 219 | /* 0 <= r < 10^8 */ |
189 | while (r >= 10000) { | 220 | q = (r * (u64)0x28f5c29) >> 32; |
190 | q = r + '0'; | 221 | *((u16 *)buf) = decpair[r - 100*q]; |
191 | r = (r * (uint64_t)0x1999999a) >> 32; | 222 | buf += 2; |
192 | *buf++ = q - 10*r; | ||
193 | } | ||
194 | |||
195 | q = (r * 0x199a) >> 16; /* r <= 9999 */ | ||
196 | *buf++ = (r - 10 * q) + '0'; | ||
197 | if (q == 0) | ||
198 | return buf; | ||
199 | r = (q * 0xcd) >> 11; /* q <= 999 */ | ||
200 | *buf++ = (q - 10 * r) + '0'; | ||
201 | if (r == 0) | ||
202 | return buf; | ||
203 | q = (r * 0xcd) >> 11; /* r <= 99 */ | ||
204 | *buf++ = (r - 10 * q) + '0'; | ||
205 | if (q == 0) | ||
206 | return buf; | ||
207 | *buf++ = q + '0'; /* q <= 9 */ | ||
208 | return buf; | ||
209 | } | ||
210 | 223 | ||
211 | /* There are two algorithms to print larger numbers. | 224 | /* 0 <= q < 10^6 */ |
212 | * One is generic: divide by 1000000000 and repeatedly print | 225 | r = (q * (u64)0x28f5c29) >> 32; |
213 | * groups of (up to) 9 digits. It's conceptually simple, | 226 | *((u16 *)buf) = decpair[q - 100*r]; |
214 | * but requires a (unsigned long long) / 1000000000 division. | 227 | buf += 2; |
215 | * | ||
216 | * Second algorithm splits 64-bit unsigned long long into 16-bit chunks, | ||
217 | * manipulates them cleverly and generates groups of 4 decimal digits. | ||
218 | * It so happens that it does NOT require long long division. | ||
219 | * | ||
220 | * If long is > 32 bits, division of 64-bit values is relatively easy, | ||
221 | * and we will use the first algorithm. | ||
222 | * If long long is > 64 bits (strange architecture with VERY large long long), | ||
223 | * second algorithm can't be used, and we again use the first one. | ||
224 | * | ||
225 | * Else (if long is 32 bits and long long is 64 bits) we use second one. | ||
226 | */ | ||
227 | 228 | ||
228 | #if BITS_PER_LONG != 32 || BITS_PER_LONG_LONG != 64 | 229 | /* 0 <= r < 10^4 */ |
230 | q = (r * 0x147b) >> 19; | ||
231 | *((u16 *)buf) = decpair[r - 100*q]; | ||
232 | buf += 2; | ||
229 | 233 | ||
230 | /* First algorithm: generic */ | 234 | /* 0 <= q < 100 */ |
235 | *((u16 *)buf) = decpair[q]; | ||
236 | buf += 2; | ||
237 | return buf; | ||
238 | } | ||
231 | 239 | ||
232 | static | 240 | static noinline_for_stack |
233 | char *put_dec(char *buf, unsigned long long n) | 241 | char *put_dec(char *buf, unsigned long long n) |
234 | { | 242 | { |
235 | if (n >= 100*1000*1000) { | 243 | if (n >= 100*1000*1000) |
236 | while (n >= 1000*1000*1000) | 244 | buf = put_dec_full8(buf, do_div(n, 100*1000*1000)); |
237 | buf = put_dec_full9(buf, do_div(n, 1000*1000*1000)); | 245 | /* 1 <= n <= 1.6e11 */ |
238 | if (n >= 100*1000*1000) | 246 | if (n >= 100*1000*1000) |
239 | return put_dec_full9(buf, n); | 247 | buf = put_dec_full8(buf, do_div(n, 100*1000*1000)); |
240 | } | 248 | /* 1 <= n < 1e8 */ |
241 | return put_dec_trunc8(buf, n); | 249 | return put_dec_trunc8(buf, n); |
242 | } | 250 | } |
243 | 251 | ||
244 | #else | 252 | #elif BITS_PER_LONG == 32 && BITS_PER_LONG_LONG == 64 |
245 | |||
246 | /* Second algorithm: valid only for 64-bit long longs */ | ||
247 | 253 | ||
248 | /* See comment in put_dec_full9 for choice of constants */ | 254 | static void |
249 | static noinline_for_stack | 255 | put_dec_full4(char *buf, unsigned r) |
250 | void put_dec_full4(char *buf, unsigned q) | ||
251 | { | 256 | { |
252 | unsigned r; | 257 | unsigned q; |
253 | r = (q * 0xccd) >> 15; | 258 | |
254 | buf[0] = (q - 10 * r) + '0'; | 259 | /* 0 <= r < 10^4 */ |
255 | q = (r * 0xcd) >> 11; | 260 | q = (r * 0x147b) >> 19; |
256 | buf[1] = (r - 10 * q) + '0'; | 261 | *((u16 *)buf) = decpair[r - 100*q]; |
257 | r = (q * 0xcd) >> 11; | 262 | buf += 2; |
258 | buf[2] = (q - 10 * r) + '0'; | 263 | /* 0 <= q < 100 */ |
259 | buf[3] = r + '0'; | 264 | *((u16 *)buf) = decpair[q]; |
260 | } | 265 | } |
261 | 266 | ||
262 | /* | 267 | /* |
@@ -264,9 +269,9 @@ void put_dec_full4(char *buf, unsigned q) | |||
264 | * The approximation x/10000 == (x * 0x346DC5D7) >> 43 | 269 | * The approximation x/10000 == (x * 0x346DC5D7) >> 43 |
265 | * holds for all x < 1,128,869,999. The largest value this | 270 | * holds for all x < 1,128,869,999. The largest value this |
266 | * helper will ever be asked to convert is 1,125,520,955. | 271 | * helper will ever be asked to convert is 1,125,520,955. |
267 | * (d1 in the put_dec code, assuming n is all-ones). | 272 | * (second call in the put_dec code, assuming n is all-ones). |
268 | */ | 273 | */ |
269 | static | 274 | static noinline_for_stack |
270 | unsigned put_dec_helper4(char *buf, unsigned x) | 275 | unsigned put_dec_helper4(char *buf, unsigned x) |
271 | { | 276 | { |
272 | uint32_t q = (x * (uint64_t)0x346DC5D7) >> 43; | 277 | uint32_t q = (x * (uint64_t)0x346DC5D7) >> 43; |
@@ -293,6 +298,8 @@ char *put_dec(char *buf, unsigned long long n) | |||
293 | d2 = (h ) & 0xffff; | 298 | d2 = (h ) & 0xffff; |
294 | d3 = (h >> 16); /* implicit "& 0xffff" */ | 299 | d3 = (h >> 16); /* implicit "& 0xffff" */ |
295 | 300 | ||
301 | /* n = 2^48 d3 + 2^32 d2 + 2^16 d1 + d0 | ||
302 | = 281_4749_7671_0656 d3 + 42_9496_7296 d2 + 6_5536 d1 + d0 */ | ||
296 | q = 656 * d3 + 7296 * d2 + 5536 * d1 + ((uint32_t)n & 0xffff); | 303 | q = 656 * d3 + 7296 * d2 + 5536 * d1 + ((uint32_t)n & 0xffff); |
297 | q = put_dec_helper4(buf, q); | 304 | q = put_dec_helper4(buf, q); |
298 | 305 | ||
@@ -322,7 +329,8 @@ char *put_dec(char *buf, unsigned long long n) | |||
322 | */ | 329 | */ |
323 | int num_to_str(char *buf, int size, unsigned long long num) | 330 | int num_to_str(char *buf, int size, unsigned long long num) |
324 | { | 331 | { |
325 | char tmp[sizeof(num) * 3]; | 332 | /* put_dec requires 2-byte alignment of the buffer. */ |
333 | char tmp[sizeof(num) * 3] __aligned(2); | ||
326 | int idx, len; | 334 | int idx, len; |
327 | 335 | ||
328 | /* put_dec() may work incorrectly for num = 0 (generate "", not "0") */ | 336 | /* put_dec() may work incorrectly for num = 0 (generate "", not "0") */ |
@@ -340,11 +348,11 @@ int num_to_str(char *buf, int size, unsigned long long num) | |||
340 | return len; | 348 | return len; |
341 | } | 349 | } |
342 | 350 | ||
343 | #define ZEROPAD 1 /* pad with zero */ | 351 | #define SIGN 1 /* unsigned/signed, must be 1 */ |
344 | #define SIGN 2 /* unsigned/signed long */ | 352 | #define LEFT 2 /* left justified */ |
345 | #define PLUS 4 /* show plus */ | 353 | #define PLUS 4 /* show plus */ |
346 | #define SPACE 8 /* space if plus */ | 354 | #define SPACE 8 /* space if plus */ |
347 | #define LEFT 16 /* left justified */ | 355 | #define ZEROPAD 16 /* pad with zero, must be 16 == '0' - ' ' */ |
348 | #define SMALL 32 /* use lowercase in hex (must be 32 == 0x20) */ | 356 | #define SMALL 32 /* use lowercase in hex (must be 32 == 0x20) */ |
349 | #define SPECIAL 64 /* prefix hex with "0x", octal with "0" */ | 357 | #define SPECIAL 64 /* prefix hex with "0x", octal with "0" */ |
350 | 358 | ||
@@ -383,10 +391,8 @@ static noinline_for_stack | |||
383 | char *number(char *buf, char *end, unsigned long long num, | 391 | char *number(char *buf, char *end, unsigned long long num, |
384 | struct printf_spec spec) | 392 | struct printf_spec spec) |
385 | { | 393 | { |
386 | /* we are called with base 8, 10 or 16, only, thus don't need "G..." */ | 394 | /* put_dec requires 2-byte alignment of the buffer. */ |
387 | static const char digits[16] = "0123456789ABCDEF"; /* "GHIJKLMNOPQRSTUVWXYZ"; */ | 395 | char tmp[3 * sizeof(num)] __aligned(2); |
388 | |||
389 | char tmp[66]; | ||
390 | char sign; | 396 | char sign; |
391 | char locase; | 397 | char locase; |
392 | int need_pfx = ((spec.flags & SPECIAL) && spec.base != 10); | 398 | int need_pfx = ((spec.flags & SPECIAL) && spec.base != 10); |
@@ -422,12 +428,7 @@ char *number(char *buf, char *end, unsigned long long num, | |||
422 | /* generate full string in tmp[], in reverse order */ | 428 | /* generate full string in tmp[], in reverse order */ |
423 | i = 0; | 429 | i = 0; |
424 | if (num < spec.base) | 430 | if (num < spec.base) |
425 | tmp[i++] = digits[num] | locase; | 431 | tmp[i++] = hex_asc_upper[num] | locase; |
426 | /* Generic code, for any base: | ||
427 | else do { | ||
428 | tmp[i++] = (digits[do_div(num,base)] | locase); | ||
429 | } while (num != 0); | ||
430 | */ | ||
431 | else if (spec.base != 10) { /* 8 or 16 */ | 432 | else if (spec.base != 10) { /* 8 or 16 */ |
432 | int mask = spec.base - 1; | 433 | int mask = spec.base - 1; |
433 | int shift = 3; | 434 | int shift = 3; |
@@ -435,7 +436,7 @@ char *number(char *buf, char *end, unsigned long long num, | |||
435 | if (spec.base == 16) | 436 | if (spec.base == 16) |
436 | shift = 4; | 437 | shift = 4; |
437 | do { | 438 | do { |
438 | tmp[i++] = (digits[((unsigned char)num) & mask] | locase); | 439 | tmp[i++] = (hex_asc_upper[((unsigned char)num) & mask] | locase); |
439 | num >>= shift; | 440 | num >>= shift; |
440 | } while (num); | 441 | } while (num); |
441 | } else { /* base 10 */ | 442 | } else { /* base 10 */ |
@@ -447,7 +448,7 @@ char *number(char *buf, char *end, unsigned long long num, | |||
447 | spec.precision = i; | 448 | spec.precision = i; |
448 | /* leading space padding */ | 449 | /* leading space padding */ |
449 | spec.field_width -= spec.precision; | 450 | spec.field_width -= spec.precision; |
450 | if (!(spec.flags & (ZEROPAD+LEFT))) { | 451 | if (!(spec.flags & (ZEROPAD | LEFT))) { |
451 | while (--spec.field_width >= 0) { | 452 | while (--spec.field_width >= 0) { |
452 | if (buf < end) | 453 | if (buf < end) |
453 | *buf = ' '; | 454 | *buf = ' '; |
@@ -475,7 +476,8 @@ char *number(char *buf, char *end, unsigned long long num, | |||
475 | } | 476 | } |
476 | /* zero or space padding */ | 477 | /* zero or space padding */ |
477 | if (!(spec.flags & LEFT)) { | 478 | if (!(spec.flags & LEFT)) { |
478 | char c = (spec.flags & ZEROPAD) ? '0' : ' '; | 479 | char c = ' ' + (spec.flags & ZEROPAD); |
480 | BUILD_BUG_ON(' ' + ZEROPAD != '0'); | ||
479 | while (--spec.field_width >= 0) { | 481 | while (--spec.field_width >= 0) { |
480 | if (buf < end) | 482 | if (buf < end) |
481 | *buf = c; | 483 | *buf = c; |
@@ -783,11 +785,19 @@ char *hex_string(char *buf, char *end, u8 *addr, struct printf_spec spec, | |||
783 | if (spec.field_width > 0) | 785 | if (spec.field_width > 0) |
784 | len = min_t(int, spec.field_width, 64); | 786 | len = min_t(int, spec.field_width, 64); |
785 | 787 | ||
786 | for (i = 0; i < len && buf < end - 1; i++) { | 788 | for (i = 0; i < len; ++i) { |
787 | buf = hex_byte_pack(buf, addr[i]); | 789 | if (buf < end) |
790 | *buf = hex_asc_hi(addr[i]); | ||
791 | ++buf; | ||
792 | if (buf < end) | ||
793 | *buf = hex_asc_lo(addr[i]); | ||
794 | ++buf; | ||
788 | 795 | ||
789 | if (buf < end && separator && i != len - 1) | 796 | if (separator && i != len - 1) { |
790 | *buf++ = separator; | 797 | if (buf < end) |
798 | *buf = separator; | ||
799 | ++buf; | ||
800 | } | ||
791 | } | 801 | } |
792 | 802 | ||
793 | return buf; | 803 | return buf; |
@@ -942,7 +952,7 @@ char *ip4_string(char *p, const u8 *addr, const char *fmt) | |||
942 | break; | 952 | break; |
943 | } | 953 | } |
944 | for (i = 0; i < 4; i++) { | 954 | for (i = 0; i < 4; i++) { |
945 | char temp[3]; /* hold each IP quad in reverse order */ | 955 | char temp[4] __aligned(2); /* hold each IP quad in reverse order */ |
946 | int digits = put_dec_trunc8(temp, addr[index]) - temp; | 956 | int digits = put_dec_trunc8(temp, addr[index]) - temp; |
947 | if (leading_zeros) { | 957 | if (leading_zeros) { |
948 | if (digits < 3) | 958 | if (digits < 3) |
@@ -1233,8 +1243,12 @@ char *escaped_string(char *buf, char *end, u8 *addr, struct printf_spec spec, | |||
1233 | 1243 | ||
1234 | len = spec.field_width < 0 ? 1 : spec.field_width; | 1244 | len = spec.field_width < 0 ? 1 : spec.field_width; |
1235 | 1245 | ||
1236 | /* Ignore the error. We print as many characters as we can */ | 1246 | /* |
1237 | string_escape_mem(addr, len, &buf, end - buf, flags, NULL); | 1247 | * string_escape_mem() writes as many characters as it can to |
1248 | * the given buffer, and returns the total size of the output | ||
1249 | * had the buffer been big enough. | ||
1250 | */ | ||
1251 | buf += string_escape_mem(addr, len, buf, buf < end ? end - buf : 0, flags, NULL); | ||
1238 | 1252 | ||
1239 | return buf; | 1253 | return buf; |
1240 | } | 1254 | } |
@@ -1322,6 +1336,30 @@ char *address_val(char *buf, char *end, const void *addr, | |||
1322 | return number(buf, end, num, spec); | 1336 | return number(buf, end, num, spec); |
1323 | } | 1337 | } |
1324 | 1338 | ||
1339 | static noinline_for_stack | ||
1340 | char *clock(char *buf, char *end, struct clk *clk, struct printf_spec spec, | ||
1341 | const char *fmt) | ||
1342 | { | ||
1343 | if (!IS_ENABLED(CONFIG_HAVE_CLK) || !clk) | ||
1344 | return string(buf, end, NULL, spec); | ||
1345 | |||
1346 | switch (fmt[1]) { | ||
1347 | case 'r': | ||
1348 | return number(buf, end, clk_get_rate(clk), spec); | ||
1349 | |||
1350 | case 'n': | ||
1351 | default: | ||
1352 | #ifdef CONFIG_COMMON_CLK | ||
1353 | return string(buf, end, __clk_get_name(clk), spec); | ||
1354 | #else | ||
1355 | spec.base = 16; | ||
1356 | spec.field_width = sizeof(unsigned long) * 2 + 2; | ||
1357 | spec.flags |= SPECIAL | SMALL | ZEROPAD; | ||
1358 | return number(buf, end, (unsigned long)clk, spec); | ||
1359 | #endif | ||
1360 | } | ||
1361 | } | ||
1362 | |||
1325 | int kptr_restrict __read_mostly; | 1363 | int kptr_restrict __read_mostly; |
1326 | 1364 | ||
1327 | /* | 1365 | /* |
@@ -1404,6 +1442,11 @@ int kptr_restrict __read_mostly; | |||
1404 | * (default assumed to be phys_addr_t, passed by reference) | 1442 | * (default assumed to be phys_addr_t, passed by reference) |
1405 | * - 'd[234]' For a dentry name (optionally 2-4 last components) | 1443 | * - 'd[234]' For a dentry name (optionally 2-4 last components) |
1406 | * - 'D[234]' Same as 'd' but for a struct file | 1444 | * - 'D[234]' Same as 'd' but for a struct file |
1445 | * - 'C' For a clock, it prints the name (Common Clock Framework) or address | ||
1446 | * (legacy clock framework) of the clock | ||
1447 | * - 'Cn' For a clock, it prints the name (Common Clock Framework) or address | ||
1448 | * (legacy clock framework) of the clock | ||
1449 | * - 'Cr' For a clock, it prints the current rate of the clock | ||
1407 | * | 1450 | * |
1408 | * Note: The difference between 'S' and 'F' is that on ia64 and ppc64 | 1451 | * Note: The difference between 'S' and 'F' is that on ia64 and ppc64 |
1409 | * function pointers are really function descriptors, which contain a | 1452 | * function pointers are really function descriptors, which contain a |
@@ -1548,6 +1591,8 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr, | |||
1548 | return address_val(buf, end, ptr, spec, fmt); | 1591 | return address_val(buf, end, ptr, spec, fmt); |
1549 | case 'd': | 1592 | case 'd': |
1550 | return dentry_name(buf, end, ptr, spec, fmt); | 1593 | return dentry_name(buf, end, ptr, spec, fmt); |
1594 | case 'C': | ||
1595 | return clock(buf, end, ptr, spec, fmt); | ||
1551 | case 'D': | 1596 | case 'D': |
1552 | return dentry_name(buf, end, | 1597 | return dentry_name(buf, end, |
1553 | ((const struct file *)ptr)->f_path.dentry, | 1598 | ((const struct file *)ptr)->f_path.dentry, |
@@ -1738,29 +1783,21 @@ qualifier: | |||
1738 | if (spec->qualifier == 'L') | 1783 | if (spec->qualifier == 'L') |
1739 | spec->type = FORMAT_TYPE_LONG_LONG; | 1784 | spec->type = FORMAT_TYPE_LONG_LONG; |
1740 | else if (spec->qualifier == 'l') { | 1785 | else if (spec->qualifier == 'l') { |
1741 | if (spec->flags & SIGN) | 1786 | BUILD_BUG_ON(FORMAT_TYPE_ULONG + SIGN != FORMAT_TYPE_LONG); |
1742 | spec->type = FORMAT_TYPE_LONG; | 1787 | spec->type = FORMAT_TYPE_ULONG + (spec->flags & SIGN); |
1743 | else | ||
1744 | spec->type = FORMAT_TYPE_ULONG; | ||
1745 | } else if (_tolower(spec->qualifier) == 'z') { | 1788 | } else if (_tolower(spec->qualifier) == 'z') { |
1746 | spec->type = FORMAT_TYPE_SIZE_T; | 1789 | spec->type = FORMAT_TYPE_SIZE_T; |
1747 | } else if (spec->qualifier == 't') { | 1790 | } else if (spec->qualifier == 't') { |
1748 | spec->type = FORMAT_TYPE_PTRDIFF; | 1791 | spec->type = FORMAT_TYPE_PTRDIFF; |
1749 | } else if (spec->qualifier == 'H') { | 1792 | } else if (spec->qualifier == 'H') { |
1750 | if (spec->flags & SIGN) | 1793 | BUILD_BUG_ON(FORMAT_TYPE_UBYTE + SIGN != FORMAT_TYPE_BYTE); |
1751 | spec->type = FORMAT_TYPE_BYTE; | 1794 | spec->type = FORMAT_TYPE_UBYTE + (spec->flags & SIGN); |
1752 | else | ||
1753 | spec->type = FORMAT_TYPE_UBYTE; | ||
1754 | } else if (spec->qualifier == 'h') { | 1795 | } else if (spec->qualifier == 'h') { |
1755 | if (spec->flags & SIGN) | 1796 | BUILD_BUG_ON(FORMAT_TYPE_USHORT + SIGN != FORMAT_TYPE_SHORT); |
1756 | spec->type = FORMAT_TYPE_SHORT; | 1797 | spec->type = FORMAT_TYPE_USHORT + (spec->flags & SIGN); |
1757 | else | ||
1758 | spec->type = FORMAT_TYPE_USHORT; | ||
1759 | } else { | 1798 | } else { |
1760 | if (spec->flags & SIGN) | 1799 | BUILD_BUG_ON(FORMAT_TYPE_UINT + SIGN != FORMAT_TYPE_INT); |
1761 | spec->type = FORMAT_TYPE_INT; | 1800 | spec->type = FORMAT_TYPE_UINT + (spec->flags & SIGN); |
1762 | else | ||
1763 | spec->type = FORMAT_TYPE_UINT; | ||
1764 | } | 1801 | } |
1765 | 1802 | ||
1766 | return ++fmt - start; | 1803 | return ++fmt - start; |
@@ -1800,6 +1837,11 @@ qualifier: | |||
1800 | * %*pE[achnops] print an escaped buffer | 1837 | * %*pE[achnops] print an escaped buffer |
1801 | * %*ph[CDN] a variable-length hex string with a separator (supports up to 64 | 1838 | * %*ph[CDN] a variable-length hex string with a separator (supports up to 64 |
1802 | * bytes of the input) | 1839 | * bytes of the input) |
1840 | * %pC output the name (Common Clock Framework) or address (legacy clock | ||
1841 | * framework) of a clock | ||
1842 | * %pCn output the name (Common Clock Framework) or address (legacy clock | ||
1843 | * framework) of a clock | ||
1844 | * %pCr output the current rate of a clock | ||
1803 | * %n is ignored | 1845 | * %n is ignored |
1804 | * | 1846 | * |
1805 | * ** Please update Documentation/printk-formats.txt when making changes ** | 1847 | * ** Please update Documentation/printk-formats.txt when making changes ** |