1 files changed, 26 insertions, 25 deletions

diff --git a/include/linux/ntb.h b/include/linux/ntb.h
index c308964777eb..181d16601dd9 100644
--- a/include/linux/ntb.h
+++ b/include/linux/ntb.h
@@ -71,6 +71,7 @@ struct pci_dev;
  * @NTB_TOPO_B2B_USD:   On primary side of local ntb upstream of remote ntb.
  * @NTB_TOPO_B2B_DSD:   On primary side of local ntb downstream of remote ntb.
  * @NTB_TOPO_SWITCH:    Connected via a switch which supports ntb.
+ * @NTB_TOPO_CROSSLINK: Connected via two symmetric switchecs
  */
 enum ntb_topo {
         NTB_TOPO_NONE = -1,
@@ -79,6 +80,7 @@ enum ntb_topo {
         NTB_TOPO_B2B_USD,
         NTB_TOPO_B2B_DSD,
         NTB_TOPO_SWITCH,
+        NTB_TOPO_CROSSLINK,
 };
 
 static inline int ntb_topo_is_b2b(enum ntb_topo topo)
@@ -94,12 +96,13 @@ static inline int ntb_topo_is_b2b(enum ntb_topo topo)
 static inline char *ntb_topo_string(enum ntb_topo topo)
 {
         switch (topo) {
-        case NTB_TOPO_NONE:     return "NTB_TOPO_NONE";
-        case NTB_TOPO_PRI:      return "NTB_TOPO_PRI";
-        case NTB_TOPO_SEC:      return "NTB_TOPO_SEC";
-        case NTB_TOPO_B2B_USD:  return "NTB_TOPO_B2B_USD";
-        case NTB_TOPO_B2B_DSD:  return "NTB_TOPO_B2B_DSD";
-        case NTB_TOPO_SWITCH:   return "NTB_TOPO_SWITCH";
+        case NTB_TOPO_NONE:             return "NTB_TOPO_NONE";
+        case NTB_TOPO_PRI:              return "NTB_TOPO_PRI";
+        case NTB_TOPO_SEC:              return "NTB_TOPO_SEC";
+        case NTB_TOPO_B2B_USD:          return "NTB_TOPO_B2B_USD";
+        case NTB_TOPO_B2B_DSD:          return "NTB_TOPO_B2B_DSD";
+        case NTB_TOPO_SWITCH:           return "NTB_TOPO_SWITCH";
+        case NTB_TOPO_CROSSLINK:        return "NTB_TOPO_CROSSLINK";
         }
         return "NTB_TOPO_INVALID";
 }
@@ -250,7 +253,7 @@ static inline int ntb_ctx_ops_is_valid(const struct ntb_ctx_ops *ops)
  * @msg_set_mask:       See ntb_msg_set_mask().
  * @msg_clear_mask:     See ntb_msg_clear_mask().
  * @msg_read:           See ntb_msg_read().
- * @msg_write:          See ntb_msg_write().
+ * @peer_msg_write:     See ntb_peer_msg_write().
  */
 struct ntb_dev_ops {
         int (*port_number)(struct ntb_dev *ntb);
@@ -321,8 +324,8 @@ struct ntb_dev_ops {
         int (*msg_clear_sts)(struct ntb_dev *ntb, u64 sts_bits);
         int (*msg_set_mask)(struct ntb_dev *ntb, u64 mask_bits);
         int (*msg_clear_mask)(struct ntb_dev *ntb, u64 mask_bits);
-        int (*msg_read)(struct ntb_dev *ntb, int midx, int *pidx, u32 *msg);
-        int (*msg_write)(struct ntb_dev *ntb, int midx, int pidx, u32 msg);
+        u32 (*msg_read)(struct ntb_dev *ntb, int *pidx, int midx);
+        int (*peer_msg_write)(struct ntb_dev *ntb, int pidx, int midx, u32 msg);
 };
 
 static inline int ntb_dev_ops_is_valid(const struct ntb_dev_ops *ops)
@@ -384,7 +387,7 @@ static inline int ntb_dev_ops_is_valid(const struct ntb_dev_ops *ops)
                 /* !ops->msg_set_mask == !ops->msg_count        && */
                 /* !ops->msg_clear_mask == !ops->msg_count      && */
                 !ops->msg_read == !ops->msg_count               &&
-                !ops->msg_write == !ops->msg_count              &&
+                !ops->peer_msg_write == !ops->msg_count         &&
                 1;
 }
 
@@ -764,7 +767,7 @@ static inline int ntb_mw_get_align(struct ntb_dev *ntb, int pidx, int widx,
                                    resource_size_t *size_align,
                                    resource_size_t *size_max)
 {
-        if (!(ntb_link_is_up(ntb, NULL, NULL) & (1 << pidx)))
+        if (!(ntb_link_is_up(ntb, NULL, NULL) & BIT_ULL(pidx)))
                 return -ENOTCONN;
 
         return ntb->ops->mw_get_align(ntb, pidx, widx, addr_align, size_align,
@@ -1459,31 +1462,29 @@ static inline int ntb_msg_clear_mask(struct ntb_dev *ntb, u64 mask_bits)
 }
 
 /**
- * ntb_msg_read() - read message register with specified index
+ * ntb_msg_read() - read inbound message register with specified index
  * @ntb:        NTB device context.
- * @midx:       Message register index
  * @pidx:       OUT - Port index of peer device a message retrieved from
- * @msg:        OUT - Data
+ * @midx:       Message register index
  *
  * Read data from the specified message register. Source port index of a
  * message is retrieved as well.
  *
- * Return: Zero on success, otherwise a negative error number.
+ * Return: The value of the inbound message register.
  */
-static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
-                               u32 *msg)
+static inline u32 ntb_msg_read(struct ntb_dev *ntb, int *pidx, int midx)
 {
         if (!ntb->ops->msg_read)
-                return -EINVAL;
+                return ~(u32)0;
 
-        return ntb->ops->msg_read(ntb, midx, pidx, msg);
+        return ntb->ops->msg_read(ntb, pidx, midx);
 }
 
 /**
- * ntb_msg_write() - write data to the specified message register
+ * ntb_peer_msg_write() - write data to the specified peer message register
  * @ntb:        NTB device context.
- * @midx:       Message register index
  * @pidx:       Port index of peer device a message being sent to
+ * @midx:       Message register index
  * @msg:        Data to send
  *
  * Send data to a specified peer device using the defined message register.
@@ -1492,13 +1493,13 @@ static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
  *
  * Return: Zero on success, otherwise a negative error number.
  */
-static inline int ntb_msg_write(struct ntb_dev *ntb, int midx, int pidx,
-                                u32 msg)
+static inline int ntb_peer_msg_write(struct ntb_dev *ntb, int pidx, int midx,
+                                     u32 msg)
 {
-        if (!ntb->ops->msg_write)
+        if (!ntb->ops->peer_msg_write)
                 return -EINVAL;
 
-        return ntb->ops->msg_write(ntb, midx, pidx, msg);
+        return ntb->ops->peer_msg_write(ntb, pidx, midx, msg);
 }
 
 #endif