diff options
Diffstat (limited to 'fs')
40 files changed, 281 insertions, 178 deletions
diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c index 5e376bb93419..8defc6b3f9a2 100644 --- a/fs/bfs/inode.c +++ b/fs/bfs/inode.c | |||
| @@ -40,7 +40,7 @@ struct inode *bfs_iget(struct super_block *sb, unsigned long ino) | |||
| 40 | int block, off; | 40 | int block, off; |
| 41 | 41 | ||
| 42 | inode = iget_locked(sb, ino); | 42 | inode = iget_locked(sb, ino); |
| 43 | if (IS_ERR(inode)) | 43 | if (!inode) |
| 44 | return ERR_PTR(-ENOMEM); | 44 | return ERR_PTR(-ENOMEM); |
| 45 | if (!(inode->i_state & I_NEW)) | 45 | if (!(inode->i_state & I_NEW)) |
| 46 | return inode; | 46 | return inode; |
| @@ -1045,12 +1045,22 @@ static int __bio_copy_iov(struct bio *bio, struct bio_vec *iovecs, | |||
| 1045 | int bio_uncopy_user(struct bio *bio) | 1045 | int bio_uncopy_user(struct bio *bio) |
| 1046 | { | 1046 | { |
| 1047 | struct bio_map_data *bmd = bio->bi_private; | 1047 | struct bio_map_data *bmd = bio->bi_private; |
| 1048 | int ret = 0; | 1048 | struct bio_vec *bvec; |
| 1049 | int ret = 0, i; | ||
| 1049 | 1050 | ||
| 1050 | if (!bio_flagged(bio, BIO_NULL_MAPPED)) | 1051 | if (!bio_flagged(bio, BIO_NULL_MAPPED)) { |
| 1051 | ret = __bio_copy_iov(bio, bmd->iovecs, bmd->sgvecs, | 1052 | /* |
| 1052 | bmd->nr_sgvecs, bio_data_dir(bio) == READ, | 1053 | * if we're in a workqueue, the request is orphaned, so |
| 1053 | 0, bmd->is_our_pages); | 1054 | * don't copy into a random user address space, just free. |
| 1055 | */ | ||
| 1056 | if (current->mm) | ||
| 1057 | ret = __bio_copy_iov(bio, bmd->iovecs, bmd->sgvecs, | ||
| 1058 | bmd->nr_sgvecs, bio_data_dir(bio) == READ, | ||
| 1059 | 0, bmd->is_our_pages); | ||
| 1060 | else if (bmd->is_our_pages) | ||
| 1061 | bio_for_each_segment_all(bvec, bio, i) | ||
| 1062 | __free_page(bvec->bv_page); | ||
| 1063 | } | ||
| 1054 | bio_free_map_data(bmd); | 1064 | bio_free_map_data(bmd); |
| 1055 | bio_put(bio); | 1065 | bio_put(bio); |
| 1056 | return ret; | 1066 | return ret; |
diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c index 45e57cc38200..fc6f4f3a1a9d 100644 --- a/fs/cifs/cifsencrypt.c +++ b/fs/cifs/cifsencrypt.c | |||
| @@ -43,17 +43,18 @@ cifs_crypto_shash_md5_allocate(struct TCP_Server_Info *server) | |||
| 43 | server->secmech.md5 = crypto_alloc_shash("md5", 0, 0); | 43 | server->secmech.md5 = crypto_alloc_shash("md5", 0, 0); |
| 44 | if (IS_ERR(server->secmech.md5)) { | 44 | if (IS_ERR(server->secmech.md5)) { |
| 45 | cifs_dbg(VFS, "could not allocate crypto md5\n"); | 45 | cifs_dbg(VFS, "could not allocate crypto md5\n"); |
| 46 | return PTR_ERR(server->secmech.md5); | 46 | rc = PTR_ERR(server->secmech.md5); |
| 47 | server->secmech.md5 = NULL; | ||
| 48 | return rc; | ||
| 47 | } | 49 | } |
| 48 | 50 | ||
| 49 | size = sizeof(struct shash_desc) + | 51 | size = sizeof(struct shash_desc) + |
| 50 | crypto_shash_descsize(server->secmech.md5); | 52 | crypto_shash_descsize(server->secmech.md5); |
| 51 | server->secmech.sdescmd5 = kmalloc(size, GFP_KERNEL); | 53 | server->secmech.sdescmd5 = kmalloc(size, GFP_KERNEL); |
| 52 | if (!server->secmech.sdescmd5) { | 54 | if (!server->secmech.sdescmd5) { |
| 53 | rc = -ENOMEM; | ||
| 54 | crypto_free_shash(server->secmech.md5); | 55 | crypto_free_shash(server->secmech.md5); |
| 55 | server->secmech.md5 = NULL; | 56 | server->secmech.md5 = NULL; |
| 56 | return rc; | 57 | return -ENOMEM; |
| 57 | } | 58 | } |
| 58 | server->secmech.sdescmd5->shash.tfm = server->secmech.md5; | 59 | server->secmech.sdescmd5->shash.tfm = server->secmech.md5; |
| 59 | server->secmech.sdescmd5->shash.flags = 0x0; | 60 | server->secmech.sdescmd5->shash.flags = 0x0; |
| @@ -421,7 +422,7 @@ find_domain_name(struct cifs_ses *ses, const struct nls_table *nls_cp) | |||
| 421 | if (blobptr + attrsize > blobend) | 422 | if (blobptr + attrsize > blobend) |
| 422 | break; | 423 | break; |
| 423 | if (type == NTLMSSP_AV_NB_DOMAIN_NAME) { | 424 | if (type == NTLMSSP_AV_NB_DOMAIN_NAME) { |
| 424 | if (!attrsize) | 425 | if (!attrsize || attrsize >= CIFS_MAX_DOMAINNAME_LEN) |
| 425 | break; | 426 | break; |
| 426 | if (!ses->domainName) { | 427 | if (!ses->domainName) { |
| 427 | ses->domainName = | 428 | ses->domainName = |
| @@ -591,6 +592,7 @@ CalcNTLMv2_response(const struct cifs_ses *ses, char *ntlmv2_hash) | |||
| 591 | 592 | ||
| 592 | static int crypto_hmacmd5_alloc(struct TCP_Server_Info *server) | 593 | static int crypto_hmacmd5_alloc(struct TCP_Server_Info *server) |
| 593 | { | 594 | { |
| 595 | int rc; | ||
| 594 | unsigned int size; | 596 | unsigned int size; |
| 595 | 597 | ||
| 596 | /* check if already allocated */ | 598 | /* check if already allocated */ |
| @@ -600,7 +602,9 @@ static int crypto_hmacmd5_alloc(struct TCP_Server_Info *server) | |||
| 600 | server->secmech.hmacmd5 = crypto_alloc_shash("hmac(md5)", 0, 0); | 602 | server->secmech.hmacmd5 = crypto_alloc_shash("hmac(md5)", 0, 0); |
| 601 | if (IS_ERR(server->secmech.hmacmd5)) { | 603 | if (IS_ERR(server->secmech.hmacmd5)) { |
| 602 | cifs_dbg(VFS, "could not allocate crypto hmacmd5\n"); | 604 | cifs_dbg(VFS, "could not allocate crypto hmacmd5\n"); |
| 603 | return PTR_ERR(server->secmech.hmacmd5); | 605 | rc = PTR_ERR(server->secmech.hmacmd5); |
| 606 | server->secmech.hmacmd5 = NULL; | ||
| 607 | return rc; | ||
| 604 | } | 608 | } |
| 605 | 609 | ||
| 606 | size = sizeof(struct shash_desc) + | 610 | size = sizeof(struct shash_desc) + |
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index 4bdd547dbf6f..85ea98d139fc 100644 --- a/fs/cifs/cifsfs.c +++ b/fs/cifs/cifsfs.c | |||
| @@ -147,18 +147,17 @@ cifs_read_super(struct super_block *sb) | |||
| 147 | goto out_no_root; | 147 | goto out_no_root; |
| 148 | } | 148 | } |
| 149 | 149 | ||
| 150 | if (cifs_sb_master_tcon(cifs_sb)->nocase) | ||
| 151 | sb->s_d_op = &cifs_ci_dentry_ops; | ||
| 152 | else | ||
| 153 | sb->s_d_op = &cifs_dentry_ops; | ||
| 154 | |||
| 150 | sb->s_root = d_make_root(inode); | 155 | sb->s_root = d_make_root(inode); |
| 151 | if (!sb->s_root) { | 156 | if (!sb->s_root) { |
| 152 | rc = -ENOMEM; | 157 | rc = -ENOMEM; |
| 153 | goto out_no_root; | 158 | goto out_no_root; |
| 154 | } | 159 | } |
| 155 | 160 | ||
| 156 | /* do that *after* d_make_root() - we want NULL ->d_op for root here */ | ||
| 157 | if (cifs_sb_master_tcon(cifs_sb)->nocase) | ||
| 158 | sb->s_d_op = &cifs_ci_dentry_ops; | ||
| 159 | else | ||
| 160 | sb->s_d_op = &cifs_dentry_ops; | ||
| 161 | |||
| 162 | #ifdef CONFIG_CIFS_NFSD_EXPORT | 161 | #ifdef CONFIG_CIFS_NFSD_EXPORT |
| 163 | if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_SERVER_INUM) { | 162 | if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_SERVER_INUM) { |
| 164 | cifs_dbg(FYI, "export ops supported\n"); | 163 | cifs_dbg(FYI, "export ops supported\n"); |
diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h index 1fdc37041057..52ca861ed35e 100644 --- a/fs/cifs/cifsglob.h +++ b/fs/cifs/cifsglob.h | |||
| @@ -44,6 +44,7 @@ | |||
| 44 | #define MAX_TREE_SIZE (2 + MAX_SERVER_SIZE + 1 + MAX_SHARE_SIZE + 1) | 44 | #define MAX_TREE_SIZE (2 + MAX_SERVER_SIZE + 1 + MAX_SHARE_SIZE + 1) |
| 45 | #define MAX_SERVER_SIZE 15 | 45 | #define MAX_SERVER_SIZE 15 |
| 46 | #define MAX_SHARE_SIZE 80 | 46 | #define MAX_SHARE_SIZE 80 |
| 47 | #define CIFS_MAX_DOMAINNAME_LEN 256 /* max domain name length */ | ||
| 47 | #define MAX_USERNAME_SIZE 256 /* reasonable maximum for current servers */ | 48 | #define MAX_USERNAME_SIZE 256 /* reasonable maximum for current servers */ |
| 48 | #define MAX_PASSWORD_SIZE 512 /* max for windows seems to be 256 wide chars */ | 49 | #define MAX_PASSWORD_SIZE 512 /* max for windows seems to be 256 wide chars */ |
| 49 | 50 | ||
| @@ -369,6 +370,9 @@ struct smb_version_operations { | |||
| 369 | void (*generate_signingkey)(struct TCP_Server_Info *server); | 370 | void (*generate_signingkey)(struct TCP_Server_Info *server); |
| 370 | int (*calc_signature)(struct smb_rqst *rqst, | 371 | int (*calc_signature)(struct smb_rqst *rqst, |
| 371 | struct TCP_Server_Info *server); | 372 | struct TCP_Server_Info *server); |
| 373 | int (*query_mf_symlink)(const unsigned char *path, char *pbuf, | ||
| 374 | unsigned int *pbytes_read, struct cifs_sb_info *cifs_sb, | ||
| 375 | unsigned int xid); | ||
| 372 | }; | 376 | }; |
| 373 | 377 | ||
| 374 | struct smb_version_values { | 378 | struct smb_version_values { |
diff --git a/fs/cifs/cifsproto.h b/fs/cifs/cifsproto.h index f7e584d047e2..b29a012bed33 100644 --- a/fs/cifs/cifsproto.h +++ b/fs/cifs/cifsproto.h | |||
| @@ -497,5 +497,7 @@ void cifs_writev_complete(struct work_struct *work); | |||
| 497 | struct cifs_writedata *cifs_writedata_alloc(unsigned int nr_pages, | 497 | struct cifs_writedata *cifs_writedata_alloc(unsigned int nr_pages, |
| 498 | work_func_t complete); | 498 | work_func_t complete); |
| 499 | void cifs_writedata_release(struct kref *refcount); | 499 | void cifs_writedata_release(struct kref *refcount); |
| 500 | 500 | int open_query_close_cifs_symlink(const unsigned char *path, char *pbuf, | |
| 501 | unsigned int *pbytes_read, struct cifs_sb_info *cifs_sb, | ||
| 502 | unsigned int xid); | ||
| 501 | #endif /* _CIFSPROTO_H */ | 503 | #endif /* _CIFSPROTO_H */ |
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index fa68813396b5..d67c550c4980 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c | |||
| @@ -1675,7 +1675,8 @@ cifs_parse_mount_options(const char *mountdata, const char *devname, | |||
| 1675 | if (string == NULL) | 1675 | if (string == NULL) |
| 1676 | goto out_nomem; | 1676 | goto out_nomem; |
| 1677 | 1677 | ||
| 1678 | if (strnlen(string, 256) == 256) { | 1678 | if (strnlen(string, CIFS_MAX_DOMAINNAME_LEN) |
| 1679 | == CIFS_MAX_DOMAINNAME_LEN) { | ||
| 1679 | printk(KERN_WARNING "CIFS: domain name too" | 1680 | printk(KERN_WARNING "CIFS: domain name too" |
| 1680 | " long\n"); | 1681 | " long\n"); |
| 1681 | goto cifs_parse_mount_err; | 1682 | goto cifs_parse_mount_err; |
| @@ -2276,8 +2277,8 @@ cifs_put_smb_ses(struct cifs_ses *ses) | |||
| 2276 | 2277 | ||
| 2277 | #ifdef CONFIG_KEYS | 2278 | #ifdef CONFIG_KEYS |
| 2278 | 2279 | ||
| 2279 | /* strlen("cifs:a:") + INET6_ADDRSTRLEN + 1 */ | 2280 | /* strlen("cifs:a:") + CIFS_MAX_DOMAINNAME_LEN + 1 */ |
| 2280 | #define CIFSCREDS_DESC_SIZE (7 + INET6_ADDRSTRLEN + 1) | 2281 | #define CIFSCREDS_DESC_SIZE (7 + CIFS_MAX_DOMAINNAME_LEN + 1) |
| 2281 | 2282 | ||
| 2282 | /* Populate username and pw fields from keyring if possible */ | 2283 | /* Populate username and pw fields from keyring if possible */ |
| 2283 | static int | 2284 | static int |
diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 1e57f36ea1b2..7e36ae34e947 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c | |||
| @@ -647,6 +647,7 @@ cifs_reopen_file(struct cifsFileInfo *cfile, bool can_flush) | |||
| 647 | oflags, &oplock, &cfile->fid.netfid, xid); | 647 | oflags, &oplock, &cfile->fid.netfid, xid); |
| 648 | if (rc == 0) { | 648 | if (rc == 0) { |
| 649 | cifs_dbg(FYI, "posix reopen succeeded\n"); | 649 | cifs_dbg(FYI, "posix reopen succeeded\n"); |
| 650 | oparms.reconnect = true; | ||
| 650 | goto reopen_success; | 651 | goto reopen_success; |
| 651 | } | 652 | } |
| 652 | /* | 653 | /* |
diff --git a/fs/cifs/link.c b/fs/cifs/link.c index b83c3f5646bd..562044f700e5 100644 --- a/fs/cifs/link.c +++ b/fs/cifs/link.c | |||
| @@ -305,67 +305,89 @@ CIFSCouldBeMFSymlink(const struct cifs_fattr *fattr) | |||
| 305 | } | 305 | } |
| 306 | 306 | ||
| 307 | int | 307 | int |
| 308 | CIFSCheckMFSymlink(struct cifs_fattr *fattr, | 308 | open_query_close_cifs_symlink(const unsigned char *path, char *pbuf, |
| 309 | const unsigned char *path, | 309 | unsigned int *pbytes_read, struct cifs_sb_info *cifs_sb, |
| 310 | struct cifs_sb_info *cifs_sb, unsigned int xid) | 310 | unsigned int xid) |
| 311 | { | 311 | { |
| 312 | int rc; | 312 | int rc; |
| 313 | int oplock = 0; | 313 | int oplock = 0; |
| 314 | __u16 netfid = 0; | 314 | __u16 netfid = 0; |
| 315 | struct tcon_link *tlink; | 315 | struct tcon_link *tlink; |
| 316 | struct cifs_tcon *pTcon; | 316 | struct cifs_tcon *ptcon; |
| 317 | struct cifs_io_parms io_parms; | 317 | struct cifs_io_parms io_parms; |
| 318 | u8 *buf; | ||
| 319 | char *pbuf; | ||
| 320 | unsigned int bytes_read = 0; | ||
| 321 | int buf_type = CIFS_NO_BUFFER; | 318 | int buf_type = CIFS_NO_BUFFER; |
| 322 | unsigned int link_len = 0; | ||
| 323 | FILE_ALL_INFO file_info; | 319 | FILE_ALL_INFO file_info; |
| 324 | 320 | ||
| 325 | if (!CIFSCouldBeMFSymlink(fattr)) | ||
| 326 | /* it's not a symlink */ | ||
| 327 | return 0; | ||
| 328 | |||
| 329 | tlink = cifs_sb_tlink(cifs_sb); | 321 | tlink = cifs_sb_tlink(cifs_sb); |
| 330 | if (IS_ERR(tlink)) | 322 | if (IS_ERR(tlink)) |
| 331 | return PTR_ERR(tlink); | 323 | return PTR_ERR(tlink); |
| 332 | pTcon = tlink_tcon(tlink); | 324 | ptcon = tlink_tcon(tlink); |
| 333 | 325 | ||
| 334 | rc = CIFSSMBOpen(xid, pTcon, path, FILE_OPEN, GENERIC_READ, | 326 | rc = CIFSSMBOpen(xid, ptcon, path, FILE_OPEN, GENERIC_READ, |
| 335 | CREATE_NOT_DIR, &netfid, &oplock, &file_info, | 327 | CREATE_NOT_DIR, &netfid, &oplock, &file_info, |
| 336 | cifs_sb->local_nls, | 328 | cifs_sb->local_nls, |
| 337 | cifs_sb->mnt_cifs_flags & | 329 | cifs_sb->mnt_cifs_flags & |
| 338 | CIFS_MOUNT_MAP_SPECIAL_CHR); | 330 | CIFS_MOUNT_MAP_SPECIAL_CHR); |
| 339 | if (rc != 0) | 331 | if (rc != 0) { |
| 340 | goto out; | 332 | cifs_put_tlink(tlink); |
| 333 | return rc; | ||
| 334 | } | ||
| 341 | 335 | ||
| 342 | if (file_info.EndOfFile != cpu_to_le64(CIFS_MF_SYMLINK_FILE_SIZE)) { | 336 | if (file_info.EndOfFile != cpu_to_le64(CIFS_MF_SYMLINK_FILE_SIZE)) { |
| 343 | CIFSSMBClose(xid, pTcon, netfid); | 337 | CIFSSMBClose(xid, ptcon, netfid); |
| 338 | cifs_put_tlink(tlink); | ||
| 344 | /* it's not a symlink */ | 339 | /* it's not a symlink */ |
| 345 | goto out; | 340 | return rc; |
| 346 | } | 341 | } |
| 347 | 342 | ||
| 348 | buf = kmalloc(CIFS_MF_SYMLINK_FILE_SIZE, GFP_KERNEL); | ||
| 349 | if (!buf) { | ||
| 350 | rc = -ENOMEM; | ||
| 351 | goto out; | ||
| 352 | } | ||
| 353 | pbuf = buf; | ||
| 354 | io_parms.netfid = netfid; | 343 | io_parms.netfid = netfid; |
| 355 | io_parms.pid = current->tgid; | 344 | io_parms.pid = current->tgid; |
| 356 | io_parms.tcon = pTcon; | 345 | io_parms.tcon = ptcon; |
| 357 | io_parms.offset = 0; | 346 | io_parms.offset = 0; |
| 358 | io_parms.length = CIFS_MF_SYMLINK_FILE_SIZE; | 347 | io_parms.length = CIFS_MF_SYMLINK_FILE_SIZE; |
| 359 | 348 | ||
| 360 | rc = CIFSSMBRead(xid, &io_parms, &bytes_read, &pbuf, &buf_type); | 349 | rc = CIFSSMBRead(xid, &io_parms, pbytes_read, &pbuf, &buf_type); |
| 361 | CIFSSMBClose(xid, pTcon, netfid); | 350 | CIFSSMBClose(xid, ptcon, netfid); |
| 362 | if (rc != 0) { | 351 | cifs_put_tlink(tlink); |
| 363 | kfree(buf); | 352 | return rc; |
| 353 | } | ||
| 354 | |||
| 355 | |||
| 356 | int | ||
| 357 | CIFSCheckMFSymlink(struct cifs_fattr *fattr, | ||
| 358 | const unsigned char *path, | ||
| 359 | struct cifs_sb_info *cifs_sb, unsigned int xid) | ||
| 360 | { | ||
| 361 | int rc = 0; | ||
| 362 | u8 *buf = NULL; | ||
| 363 | unsigned int link_len = 0; | ||
| 364 | unsigned int bytes_read = 0; | ||
| 365 | struct cifs_tcon *ptcon; | ||
| 366 | |||
| 367 | if (!CIFSCouldBeMFSymlink(fattr)) | ||
| 368 | /* it's not a symlink */ | ||
| 369 | return 0; | ||
| 370 | |||
| 371 | buf = kmalloc(CIFS_MF_SYMLINK_FILE_SIZE, GFP_KERNEL); | ||
| 372 | if (!buf) { | ||
| 373 | rc = -ENOMEM; | ||
| 364 | goto out; | 374 | goto out; |
| 365 | } | 375 | } |
| 366 | 376 | ||
| 377 | ptcon = tlink_tcon(cifs_sb_tlink(cifs_sb)); | ||
| 378 | if ((ptcon->ses) && (ptcon->ses->server->ops->query_mf_symlink)) | ||
| 379 | rc = ptcon->ses->server->ops->query_mf_symlink(path, buf, | ||
| 380 | &bytes_read, cifs_sb, xid); | ||
| 381 | else | ||
| 382 | goto out; | ||
| 383 | |||
| 384 | if (rc != 0) | ||
| 385 | goto out; | ||
| 386 | |||
| 387 | if (bytes_read == 0) /* not a symlink */ | ||
| 388 | goto out; | ||
| 389 | |||
| 367 | rc = CIFSParseMFSymlink(buf, bytes_read, &link_len, NULL); | 390 | rc = CIFSParseMFSymlink(buf, bytes_read, &link_len, NULL); |
| 368 | kfree(buf); | ||
| 369 | if (rc == -EINVAL) { | 391 | if (rc == -EINVAL) { |
| 370 | /* it's not a symlink */ | 392 | /* it's not a symlink */ |
| 371 | rc = 0; | 393 | rc = 0; |
| @@ -381,7 +403,7 @@ CIFSCheckMFSymlink(struct cifs_fattr *fattr, | |||
| 381 | fattr->cf_mode |= S_IFLNK | S_IRWXU | S_IRWXG | S_IRWXO; | 403 | fattr->cf_mode |= S_IFLNK | S_IRWXU | S_IRWXG | S_IRWXO; |
| 382 | fattr->cf_dtype = DT_LNK; | 404 | fattr->cf_dtype = DT_LNK; |
| 383 | out: | 405 | out: |
| 384 | cifs_put_tlink(tlink); | 406 | kfree(buf); |
| 385 | return rc; | 407 | return rc; |
| 386 | } | 408 | } |
| 387 | 409 | ||
diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c index ab8778469394..69d2c826a23b 100644 --- a/fs/cifs/readdir.c +++ b/fs/cifs/readdir.c | |||
| @@ -111,6 +111,14 @@ cifs_prime_dcache(struct dentry *parent, struct qstr *name, | |||
| 111 | return; | 111 | return; |
| 112 | } | 112 | } |
| 113 | 113 | ||
| 114 | /* | ||
| 115 | * If we know that the inode will need to be revalidated immediately, | ||
| 116 | * then don't create a new dentry for it. We'll end up doing an on | ||
| 117 | * the wire call either way and this spares us an invalidation. | ||
| 118 | */ | ||
| 119 | if (fattr->cf_flags & CIFS_FATTR_NEED_REVAL) | ||
| 120 | return; | ||
| 121 | |||
| 114 | dentry = d_alloc(parent, name); | 122 | dentry = d_alloc(parent, name); |
| 115 | if (!dentry) | 123 | if (!dentry) |
| 116 | return; | 124 | return; |
diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c index 79358e341fd2..08dd37bb23aa 100644 --- a/fs/cifs/sess.c +++ b/fs/cifs/sess.c | |||
| @@ -197,7 +197,7 @@ static void unicode_domain_string(char **pbcc_area, struct cifs_ses *ses, | |||
| 197 | bytes_ret = 0; | 197 | bytes_ret = 0; |
| 198 | } else | 198 | } else |
| 199 | bytes_ret = cifs_strtoUTF16((__le16 *) bcc_ptr, ses->domainName, | 199 | bytes_ret = cifs_strtoUTF16((__le16 *) bcc_ptr, ses->domainName, |
| 200 | 256, nls_cp); | 200 | CIFS_MAX_DOMAINNAME_LEN, nls_cp); |
| 201 | bcc_ptr += 2 * bytes_ret; | 201 | bcc_ptr += 2 * bytes_ret; |
| 202 | bcc_ptr += 2; /* account for null terminator */ | 202 | bcc_ptr += 2; /* account for null terminator */ |
| 203 | 203 | ||
| @@ -255,8 +255,8 @@ static void ascii_ssetup_strings(char **pbcc_area, struct cifs_ses *ses, | |||
| 255 | 255 | ||
| 256 | /* copy domain */ | 256 | /* copy domain */ |
| 257 | if (ses->domainName != NULL) { | 257 | if (ses->domainName != NULL) { |
| 258 | strncpy(bcc_ptr, ses->domainName, 256); | 258 | strncpy(bcc_ptr, ses->domainName, CIFS_MAX_DOMAINNAME_LEN); |
| 259 | bcc_ptr += strnlen(ses->domainName, 256); | 259 | bcc_ptr += strnlen(ses->domainName, CIFS_MAX_DOMAINNAME_LEN); |
| 260 | } /* else we will send a null domain name | 260 | } /* else we will send a null domain name |
| 261 | so the server will default to its own domain */ | 261 | so the server will default to its own domain */ |
| 262 | *bcc_ptr = 0; | 262 | *bcc_ptr = 0; |
diff --git a/fs/cifs/smb1ops.c b/fs/cifs/smb1ops.c index 6457690731a2..60943978aec3 100644 --- a/fs/cifs/smb1ops.c +++ b/fs/cifs/smb1ops.c | |||
| @@ -944,6 +944,7 @@ struct smb_version_operations smb1_operations = { | |||
| 944 | .mand_lock = cifs_mand_lock, | 944 | .mand_lock = cifs_mand_lock, |
| 945 | .mand_unlock_range = cifs_unlock_range, | 945 | .mand_unlock_range = cifs_unlock_range, |
| 946 | .push_mand_locks = cifs_push_mandatory_locks, | 946 | .push_mand_locks = cifs_push_mandatory_locks, |
| 947 | .query_mf_symlink = open_query_close_cifs_symlink, | ||
| 947 | }; | 948 | }; |
| 948 | 949 | ||
| 949 | struct smb_version_values smb1_values = { | 950 | struct smb_version_values smb1_values = { |
diff --git a/fs/cifs/smb2transport.c b/fs/cifs/smb2transport.c index 301b191270b9..4f2300d020c7 100644 --- a/fs/cifs/smb2transport.c +++ b/fs/cifs/smb2transport.c | |||
| @@ -42,6 +42,7 @@ | |||
| 42 | static int | 42 | static int |
| 43 | smb2_crypto_shash_allocate(struct TCP_Server_Info *server) | 43 | smb2_crypto_shash_allocate(struct TCP_Server_Info *server) |
| 44 | { | 44 | { |
| 45 | int rc; | ||
| 45 | unsigned int size; | 46 | unsigned int size; |
| 46 | 47 | ||
| 47 | if (server->secmech.sdeschmacsha256 != NULL) | 48 | if (server->secmech.sdeschmacsha256 != NULL) |
| @@ -50,7 +51,9 @@ smb2_crypto_shash_allocate(struct TCP_Server_Info *server) | |||
| 50 | server->secmech.hmacsha256 = crypto_alloc_shash("hmac(sha256)", 0, 0); | 51 | server->secmech.hmacsha256 = crypto_alloc_shash("hmac(sha256)", 0, 0); |
| 51 | if (IS_ERR(server->secmech.hmacsha256)) { | 52 | if (IS_ERR(server->secmech.hmacsha256)) { |
| 52 | cifs_dbg(VFS, "could not allocate crypto hmacsha256\n"); | 53 | cifs_dbg(VFS, "could not allocate crypto hmacsha256\n"); |
| 53 | return PTR_ERR(server->secmech.hmacsha256); | 54 | rc = PTR_ERR(server->secmech.hmacsha256); |
| 55 | server->secmech.hmacsha256 = NULL; | ||
| 56 | return rc; | ||
| 54 | } | 57 | } |
| 55 | 58 | ||
| 56 | size = sizeof(struct shash_desc) + | 59 | size = sizeof(struct shash_desc) + |
| @@ -87,7 +90,9 @@ smb3_crypto_shash_allocate(struct TCP_Server_Info *server) | |||
| 87 | server->secmech.sdeschmacsha256 = NULL; | 90 | server->secmech.sdeschmacsha256 = NULL; |
| 88 | crypto_free_shash(server->secmech.hmacsha256); | 91 | crypto_free_shash(server->secmech.hmacsha256); |
| 89 | server->secmech.hmacsha256 = NULL; | 92 | server->secmech.hmacsha256 = NULL; |
| 90 | return PTR_ERR(server->secmech.cmacaes); | 93 | rc = PTR_ERR(server->secmech.cmacaes); |
| 94 | server->secmech.cmacaes = NULL; | ||
| 95 | return rc; | ||
| 91 | } | 96 | } |
| 92 | 97 | ||
| 93 | size = sizeof(struct shash_desc) + | 98 | size = sizeof(struct shash_desc) + |
diff --git a/fs/dcache.c b/fs/dcache.c index 87bdb5329c3c..83cfb834db03 100644 --- a/fs/dcache.c +++ b/fs/dcache.c | |||
| @@ -2724,6 +2724,17 @@ char *dynamic_dname(struct dentry *dentry, char *buffer, int buflen, | |||
| 2724 | return memcpy(buffer, temp, sz); | 2724 | return memcpy(buffer, temp, sz); |
| 2725 | } | 2725 | } |
| 2726 | 2726 | ||
| 2727 | char *simple_dname(struct dentry *dentry, char *buffer, int buflen) | ||
| 2728 | { | ||
| 2729 | char *end = buffer + buflen; | ||
| 2730 | /* these dentries are never renamed, so d_lock is not needed */ | ||
| 2731 | if (prepend(&end, &buflen, " (deleted)", 11) || | ||
| 2732 | prepend_name(&end, &buflen, &dentry->d_name) || | ||
| 2733 | prepend(&end, &buflen, "/", 1)) | ||
| 2734 | end = ERR_PTR(-ENAMETOOLONG); | ||
| 2735 | return end; | ||
| 2736 | } | ||
| 2737 | |||
| 2727 | /* | 2738 | /* |
| 2728 | * Write full pathname from the root of the filesystem into the buffer. | 2739 | * Write full pathname from the root of the filesystem into the buffer. |
| 2729 | */ | 2740 | */ |
diff --git a/fs/efs/inode.c b/fs/efs/inode.c index f3913eb2c474..d15ccf20f1b3 100644 --- a/fs/efs/inode.c +++ b/fs/efs/inode.c | |||
| @@ -57,7 +57,7 @@ struct inode *efs_iget(struct super_block *super, unsigned long ino) | |||
| 57 | struct inode *inode; | 57 | struct inode *inode; |
| 58 | 58 | ||
| 59 | inode = iget_locked(super, ino); | 59 | inode = iget_locked(super, ino); |
| 60 | if (IS_ERR(inode)) | 60 | if (!inode) |
| 61 | return ERR_PTR(-ENOMEM); | 61 | return ERR_PTR(-ENOMEM); |
| 62 | if (!(inode->i_state & I_NEW)) | 62 | if (!(inode->i_state & I_NEW)) |
| 63 | return inode; | 63 | return inode; |
| @@ -608,7 +608,7 @@ static int shift_arg_pages(struct vm_area_struct *vma, unsigned long shift) | |||
| 608 | return -ENOMEM; | 608 | return -ENOMEM; |
| 609 | 609 | ||
| 610 | lru_add_drain(); | 610 | lru_add_drain(); |
| 611 | tlb_gather_mmu(&tlb, mm, 0); | 611 | tlb_gather_mmu(&tlb, mm, old_start, old_end); |
| 612 | if (new_end > old_start) { | 612 | if (new_end > old_start) { |
| 613 | /* | 613 | /* |
| 614 | * when the old and new regions overlap clear from new_end. | 614 | * when the old and new regions overlap clear from new_end. |
| @@ -625,7 +625,7 @@ static int shift_arg_pages(struct vm_area_struct *vma, unsigned long shift) | |||
| 625 | free_pgd_range(&tlb, old_start, old_end, new_end, | 625 | free_pgd_range(&tlb, old_start, old_end, new_end, |
| 626 | vma->vm_next ? vma->vm_next->vm_start : USER_PGTABLES_CEILING); | 626 | vma->vm_next ? vma->vm_next->vm_start : USER_PGTABLES_CEILING); |
| 627 | } | 627 | } |
| 628 | tlb_finish_mmu(&tlb, new_end, old_end); | 628 | tlb_finish_mmu(&tlb, old_start, old_end); |
| 629 | 629 | ||
| 630 | /* | 630 | /* |
| 631 | * Shrink the vma to just the new range. Always succeeds. | 631 | * Shrink the vma to just the new range. Always succeeds. |
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index b577e45425b0..0ab26fbf3380 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h | |||
| @@ -2086,6 +2086,7 @@ extern int ext4_sync_inode(handle_t *, struct inode *); | |||
| 2086 | extern void ext4_dirty_inode(struct inode *, int); | 2086 | extern void ext4_dirty_inode(struct inode *, int); |
| 2087 | extern int ext4_change_inode_journal_flag(struct inode *, int); | 2087 | extern int ext4_change_inode_journal_flag(struct inode *, int); |
| 2088 | extern int ext4_get_inode_loc(struct inode *, struct ext4_iloc *); | 2088 | extern int ext4_get_inode_loc(struct inode *, struct ext4_iloc *); |
| 2089 | extern int ext4_inode_attach_jinode(struct inode *inode); | ||
| 2089 | extern int ext4_can_truncate(struct inode *inode); | 2090 | extern int ext4_can_truncate(struct inode *inode); |
| 2090 | extern void ext4_truncate(struct inode *); | 2091 | extern void ext4_truncate(struct inode *); |
| 2091 | extern int ext4_punch_hole(struct inode *inode, loff_t offset, loff_t length); | 2092 | extern int ext4_punch_hole(struct inode *inode, loff_t offset, loff_t length); |
diff --git a/fs/ext4/ext4_jbd2.c b/fs/ext4/ext4_jbd2.c index 72a3600aedbd..17ac112ab101 100644 --- a/fs/ext4/ext4_jbd2.c +++ b/fs/ext4/ext4_jbd2.c | |||
| @@ -255,10 +255,10 @@ int __ext4_handle_dirty_metadata(const char *where, unsigned int line, | |||
| 255 | set_buffer_prio(bh); | 255 | set_buffer_prio(bh); |
| 256 | if (ext4_handle_valid(handle)) { | 256 | if (ext4_handle_valid(handle)) { |
| 257 | err = jbd2_journal_dirty_metadata(handle, bh); | 257 | err = jbd2_journal_dirty_metadata(handle, bh); |
| 258 | if (err) { | 258 | /* Errors can only happen if there is a bug */ |
| 259 | /* Errors can only happen if there is a bug */ | 259 | if (WARN_ON_ONCE(err)) { |
| 260 | handle->h_err = err; | 260 | ext4_journal_abort_handle(where, line, __func__, bh, |
| 261 | __ext4_journal_stop(where, line, handle); | 261 | handle, err); |
| 262 | } | 262 | } |
| 263 | } else { | 263 | } else { |
| 264 | if (inode) | 264 | if (inode) |
diff --git a/fs/ext4/file.c b/fs/ext4/file.c index 6f4cc567c382..319c9d26279a 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c | |||
| @@ -219,7 +219,6 @@ static int ext4_file_open(struct inode * inode, struct file * filp) | |||
| 219 | { | 219 | { |
| 220 | struct super_block *sb = inode->i_sb; | 220 | struct super_block *sb = inode->i_sb; |
| 221 | struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb); | 221 | struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb); |
| 222 | struct ext4_inode_info *ei = EXT4_I(inode); | ||
| 223 | struct vfsmount *mnt = filp->f_path.mnt; | 222 | struct vfsmount *mnt = filp->f_path.mnt; |
| 224 | struct path path; | 223 | struct path path; |
| 225 | char buf[64], *cp; | 224 | char buf[64], *cp; |
| @@ -259,22 +258,10 @@ static int ext4_file_open(struct inode * inode, struct file * filp) | |||
| 259 | * Set up the jbd2_inode if we are opening the inode for | 258 | * Set up the jbd2_inode if we are opening the inode for |
| 260 | * writing and the journal is present | 259 | * writing and the journal is present |
| 261 | */ | 260 | */ |
| 262 | if (sbi->s_journal && !ei->jinode && (filp->f_mode & FMODE_WRITE)) { | 261 | if (filp->f_mode & FMODE_WRITE) { |
| 263 | struct jbd2_inode *jinode = jbd2_alloc_inode(GFP_KERNEL); | 262 | int ret = ext4_inode_attach_jinode(inode); |
| 264 | 263 | if (ret < 0) | |
| 265 | spin_lock(&inode->i_lock); | 264 | return ret; |
| 266 | if (!ei->jinode) { | ||
| 267 | if (!jinode) { | ||
| 268 | spin_unlock(&inode->i_lock); | ||
| 269 | return -ENOMEM; | ||
| 270 | } | ||
| 271 | ei->jinode = jinode; | ||
| 272 | jbd2_journal_init_jbd_inode(ei->jinode, inode); | ||
| 273 | jinode = NULL; | ||
| 274 | } | ||
| 275 | spin_unlock(&inode->i_lock); | ||
| 276 | if (unlikely(jinode != NULL)) | ||
| 277 | jbd2_free_inode(jinode); | ||
| 278 | } | 265 | } |
| 279 | return dquot_file_open(inode, filp); | 266 | return dquot_file_open(inode, filp); |
| 280 | } | 267 | } |
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index dd32a2eacd0d..c2ca04e67a4f 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c | |||
| @@ -3533,6 +3533,18 @@ int ext4_punch_hole(struct inode *inode, loff_t offset, loff_t length) | |||
| 3533 | offset; | 3533 | offset; |
| 3534 | } | 3534 | } |
| 3535 | 3535 | ||
| 3536 | if (offset & (sb->s_blocksize - 1) || | ||
| 3537 | (offset + length) & (sb->s_blocksize - 1)) { | ||
| 3538 | /* | ||
| 3539 | * Attach jinode to inode for jbd2 if we do any zeroing of | ||
| 3540 | * partial block | ||
| 3541 | */ | ||
| 3542 | ret = ext4_inode_attach_jinode(inode); | ||
| 3543 | if (ret < 0) | ||
| 3544 | goto out_mutex; | ||
| 3545 | |||
| 3546 | } | ||
| 3547 | |||
| 3536 | first_block_offset = round_up(offset, sb->s_blocksize); | 3548 | first_block_offset = round_up(offset, sb->s_blocksize); |
| 3537 | last_block_offset = round_down((offset + length), sb->s_blocksize) - 1; | 3549 | last_block_offset = round_down((offset + length), sb->s_blocksize) - 1; |
| 3538 | 3550 | ||
| @@ -3601,6 +3613,31 @@ out_mutex: | |||
| 3601 | return ret; | 3613 | return ret; |
| 3602 | } | 3614 | } |
| 3603 | 3615 | ||
| 3616 | int ext4_inode_attach_jinode(struct inode *inode) | ||
| 3617 | { | ||
| 3618 | struct ext4_inode_info *ei = EXT4_I(inode); | ||
| 3619 | struct jbd2_inode *jinode; | ||
| 3620 | |||
| 3621 | if (ei->jinode || !EXT4_SB(inode->i_sb)->s_journal) | ||
| 3622 | return 0; | ||
| 3623 | |||
| 3624 | jinode = jbd2_alloc_inode(GFP_KERNEL); | ||
| 3625 | spin_lock(&inode->i_lock); | ||
| 3626 | if (!ei->jinode) { | ||
| 3627 | if (!jinode) { | ||
| 3628 | spin_unlock(&inode->i_lock); | ||
| 3629 | return -ENOMEM; | ||
| 3630 | } | ||
| 3631 | ei->jinode = jinode; | ||
| 3632 | jbd2_journal_init_jbd_inode(ei->jinode, inode); | ||
| 3633 | jinode = NULL; | ||
| 3634 | } | ||
| 3635 | spin_unlock(&inode->i_lock); | ||
| 3636 | if (unlikely(jinode != NULL)) | ||
| 3637 | jbd2_free_inode(jinode); | ||
| 3638 | return 0; | ||
| 3639 | } | ||
| 3640 | |||
| 3604 | /* | 3641 | /* |
| 3605 | * ext4_truncate() | 3642 | * ext4_truncate() |
| 3606 | * | 3643 | * |
| @@ -3661,6 +3698,12 @@ void ext4_truncate(struct inode *inode) | |||
| 3661 | return; | 3698 | return; |
| 3662 | } | 3699 | } |
| 3663 | 3700 | ||
| 3701 | /* If we zero-out tail of the page, we have to create jinode for jbd2 */ | ||
| 3702 | if (inode->i_size & (inode->i_sb->s_blocksize - 1)) { | ||
| 3703 | if (ext4_inode_attach_jinode(inode) < 0) | ||
| 3704 | return; | ||
| 3705 | } | ||
| 3706 | |||
| 3664 | if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)) | 3707 | if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)) |
| 3665 | credits = ext4_writepage_trans_blocks(inode); | 3708 | credits = ext4_writepage_trans_blocks(inode); |
| 3666 | else | 3709 | else |
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index 9491ac0590f7..c0427e2f6648 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c | |||
| @@ -77,8 +77,10 @@ static void swap_inode_data(struct inode *inode1, struct inode *inode2) | |||
| 77 | memswap(ei1->i_data, ei2->i_data, sizeof(ei1->i_data)); | 77 | memswap(ei1->i_data, ei2->i_data, sizeof(ei1->i_data)); |
| 78 | memswap(&ei1->i_flags, &ei2->i_flags, sizeof(ei1->i_flags)); | 78 | memswap(&ei1->i_flags, &ei2->i_flags, sizeof(ei1->i_flags)); |
| 79 | memswap(&ei1->i_disksize, &ei2->i_disksize, sizeof(ei1->i_disksize)); | 79 | memswap(&ei1->i_disksize, &ei2->i_disksize, sizeof(ei1->i_disksize)); |
| 80 | memswap(&ei1->i_es_tree, &ei2->i_es_tree, sizeof(ei1->i_es_tree)); | 80 | ext4_es_remove_extent(inode1, 0, EXT_MAX_BLOCKS); |
| 81 | memswap(&ei1->i_es_lru_nr, &ei2->i_es_lru_nr, sizeof(ei1->i_es_lru_nr)); | 81 | ext4_es_remove_extent(inode2, 0, EXT_MAX_BLOCKS); |
| 82 | ext4_es_lru_del(inode1); | ||
| 83 | ext4_es_lru_del(inode2); | ||
| 82 | 84 | ||
| 83 | isize = i_size_read(inode1); | 85 | isize = i_size_read(inode1); |
| 84 | i_size_write(inode1, i_size_read(inode2)); | 86 | i_size_write(inode1, i_size_read(inode2)); |
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 36b141e420b7..b59373b625e9 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c | |||
| @@ -1359,7 +1359,7 @@ static const struct mount_opts { | |||
| 1359 | {Opt_delalloc, EXT4_MOUNT_DELALLOC, | 1359 | {Opt_delalloc, EXT4_MOUNT_DELALLOC, |
| 1360 | MOPT_EXT4_ONLY | MOPT_SET | MOPT_EXPLICIT}, | 1360 | MOPT_EXT4_ONLY | MOPT_SET | MOPT_EXPLICIT}, |
| 1361 | {Opt_nodelalloc, EXT4_MOUNT_DELALLOC, | 1361 | {Opt_nodelalloc, EXT4_MOUNT_DELALLOC, |
| 1362 | MOPT_EXT4_ONLY | MOPT_CLEAR | MOPT_EXPLICIT}, | 1362 | MOPT_EXT4_ONLY | MOPT_CLEAR}, |
| 1363 | {Opt_journal_checksum, EXT4_MOUNT_JOURNAL_CHECKSUM, | 1363 | {Opt_journal_checksum, EXT4_MOUNT_JOURNAL_CHECKSUM, |
| 1364 | MOPT_EXT4_ONLY | MOPT_SET}, | 1364 | MOPT_EXT4_ONLY | MOPT_SET}, |
| 1365 | {Opt_journal_async_commit, (EXT4_MOUNT_JOURNAL_ASYNC_COMMIT | | 1365 | {Opt_journal_async_commit, (EXT4_MOUNT_JOURNAL_ASYNC_COMMIT | |
| @@ -3483,7 +3483,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
| 3483 | } | 3483 | } |
| 3484 | if (test_opt(sb, DIOREAD_NOLOCK)) { | 3484 | if (test_opt(sb, DIOREAD_NOLOCK)) { |
| 3485 | ext4_msg(sb, KERN_ERR, "can't mount with " | 3485 | ext4_msg(sb, KERN_ERR, "can't mount with " |
| 3486 | "both data=journal and delalloc"); | 3486 | "both data=journal and dioread_nolock"); |
| 3487 | goto failed_mount; | 3487 | goto failed_mount; |
| 3488 | } | 3488 | } |
| 3489 | if (test_opt(sb, DELALLOC)) | 3489 | if (test_opt(sb, DELALLOC)) |
| @@ -4727,6 +4727,21 @@ static int ext4_remount(struct super_block *sb, int *flags, char *data) | |||
| 4727 | goto restore_opts; | 4727 | goto restore_opts; |
| 4728 | } | 4728 | } |
| 4729 | 4729 | ||
| 4730 | if (test_opt(sb, DATA_FLAGS) == EXT4_MOUNT_JOURNAL_DATA) { | ||
| 4731 | if (test_opt2(sb, EXPLICIT_DELALLOC)) { | ||
| 4732 | ext4_msg(sb, KERN_ERR, "can't mount with " | ||
| 4733 | "both data=journal and delalloc"); | ||
| 4734 | err = -EINVAL; | ||
| 4735 | goto restore_opts; | ||
| 4736 | } | ||
| 4737 | if (test_opt(sb, DIOREAD_NOLOCK)) { | ||
| 4738 | ext4_msg(sb, KERN_ERR, "can't mount with " | ||
| 4739 | "both data=journal and dioread_nolock"); | ||
| 4740 | err = -EINVAL; | ||
| 4741 | goto restore_opts; | ||
| 4742 | } | ||
| 4743 | } | ||
| 4744 | |||
| 4730 | if (sbi->s_mount_flags & EXT4_MF_FS_ABORTED) | 4745 | if (sbi->s_mount_flags & EXT4_MF_FS_ABORTED) |
| 4731 | ext4_abort(sb, "Abort forced by user"); | 4746 | ext4_abort(sb, "Abort forced by user"); |
| 4732 | 4747 | ||
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index 9435384562a2..544a809819c3 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c | |||
| @@ -1838,14 +1838,14 @@ int __init gfs2_glock_init(void) | |||
| 1838 | 1838 | ||
| 1839 | glock_workqueue = alloc_workqueue("glock_workqueue", WQ_MEM_RECLAIM | | 1839 | glock_workqueue = alloc_workqueue("glock_workqueue", WQ_MEM_RECLAIM | |
| 1840 | WQ_HIGHPRI | WQ_FREEZABLE, 0); | 1840 | WQ_HIGHPRI | WQ_FREEZABLE, 0); |
| 1841 | if (IS_ERR(glock_workqueue)) | 1841 | if (!glock_workqueue) |
| 1842 | return PTR_ERR(glock_workqueue); | 1842 | return -ENOMEM; |
| 1843 | gfs2_delete_workqueue = alloc_workqueue("delete_workqueue", | 1843 | gfs2_delete_workqueue = alloc_workqueue("delete_workqueue", |
| 1844 | WQ_MEM_RECLAIM | WQ_FREEZABLE, | 1844 | WQ_MEM_RECLAIM | WQ_FREEZABLE, |
| 1845 | 0); | 1845 | 0); |
| 1846 | if (IS_ERR(gfs2_delete_workqueue)) { | 1846 | if (!gfs2_delete_workqueue) { |
| 1847 | destroy_workqueue(glock_workqueue); | 1847 | destroy_workqueue(glock_workqueue); |
| 1848 | return PTR_ERR(gfs2_delete_workqueue); | 1848 | return -ENOMEM; |
| 1849 | } | 1849 | } |
| 1850 | 1850 | ||
| 1851 | register_shrinker(&glock_shrinker); | 1851 | register_shrinker(&glock_shrinker); |
diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index 5f2e5224c51c..e2e0a90396e7 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2/glops.c | |||
| @@ -47,7 +47,8 @@ static void gfs2_ail_error(struct gfs2_glock *gl, const struct buffer_head *bh) | |||
| 47 | * None of the buffers should be dirty, locked, or pinned. | 47 | * None of the buffers should be dirty, locked, or pinned. |
| 48 | */ | 48 | */ |
| 49 | 49 | ||
| 50 | static void __gfs2_ail_flush(struct gfs2_glock *gl, bool fsync) | 50 | static void __gfs2_ail_flush(struct gfs2_glock *gl, bool fsync, |
| 51 | unsigned int nr_revokes) | ||
| 51 | { | 52 | { |
| 52 | struct gfs2_sbd *sdp = gl->gl_sbd; | 53 | struct gfs2_sbd *sdp = gl->gl_sbd; |
| 53 | struct list_head *head = &gl->gl_ail_list; | 54 | struct list_head *head = &gl->gl_ail_list; |
| @@ -57,7 +58,9 @@ static void __gfs2_ail_flush(struct gfs2_glock *gl, bool fsync) | |||
| 57 | 58 | ||
| 58 | gfs2_log_lock(sdp); | 59 | gfs2_log_lock(sdp); |
| 59 | spin_lock(&sdp->sd_ail_lock); | 60 | spin_lock(&sdp->sd_ail_lock); |
| 60 | list_for_each_entry_safe(bd, tmp, head, bd_ail_gl_list) { | 61 | list_for_each_entry_safe_reverse(bd, tmp, head, bd_ail_gl_list) { |
| 62 | if (nr_revokes == 0) | ||
| 63 | break; | ||
| 61 | bh = bd->bd_bh; | 64 | bh = bd->bd_bh; |
| 62 | if (bh->b_state & b_state) { | 65 | if (bh->b_state & b_state) { |
| 63 | if (fsync) | 66 | if (fsync) |
| @@ -65,6 +68,7 @@ static void __gfs2_ail_flush(struct gfs2_glock *gl, bool fsync) | |||
| 65 | gfs2_ail_error(gl, bh); | 68 | gfs2_ail_error(gl, bh); |
| 66 | } | 69 | } |
| 67 | gfs2_trans_add_revoke(sdp, bd); | 70 | gfs2_trans_add_revoke(sdp, bd); |
| 71 | nr_revokes--; | ||
| 68 | } | 72 | } |
| 69 | GLOCK_BUG_ON(gl, !fsync && atomic_read(&gl->gl_ail_count)); | 73 | GLOCK_BUG_ON(gl, !fsync && atomic_read(&gl->gl_ail_count)); |
| 70 | spin_unlock(&sdp->sd_ail_lock); | 74 | spin_unlock(&sdp->sd_ail_lock); |
| @@ -91,7 +95,7 @@ static void gfs2_ail_empty_gl(struct gfs2_glock *gl) | |||
| 91 | WARN_ON_ONCE(current->journal_info); | 95 | WARN_ON_ONCE(current->journal_info); |
| 92 | current->journal_info = &tr; | 96 | current->journal_info = &tr; |
| 93 | 97 | ||
| 94 | __gfs2_ail_flush(gl, 0); | 98 | __gfs2_ail_flush(gl, 0, tr.tr_revokes); |
| 95 | 99 | ||
| 96 | gfs2_trans_end(sdp); | 100 | gfs2_trans_end(sdp); |
| 97 | gfs2_log_flush(sdp, NULL); | 101 | gfs2_log_flush(sdp, NULL); |
| @@ -101,15 +105,19 @@ void gfs2_ail_flush(struct gfs2_glock *gl, bool fsync) | |||
| 101 | { | 105 | { |
| 102 | struct gfs2_sbd *sdp = gl->gl_sbd; | 106 | struct gfs2_sbd *sdp = gl->gl_sbd; |
| 103 | unsigned int revokes = atomic_read(&gl->gl_ail_count); | 107 | unsigned int revokes = atomic_read(&gl->gl_ail_count); |
| 108 | unsigned int max_revokes = (sdp->sd_sb.sb_bsize - sizeof(struct gfs2_log_descriptor)) / sizeof(u64); | ||
| 104 | int ret; | 109 | int ret; |
| 105 | 110 | ||
| 106 | if (!revokes) | 111 | if (!revokes) |
| 107 | return; | 112 | return; |
| 108 | 113 | ||
| 109 | ret = gfs2_trans_begin(sdp, 0, revokes); | 114 | while (revokes > max_revokes) |
| 115 | max_revokes += (sdp->sd_sb.sb_bsize - sizeof(struct gfs2_meta_header)) / sizeof(u64); | ||
| 116 | |||
| 117 | ret = gfs2_trans_begin(sdp, 0, max_revokes); | ||
| 110 | if (ret) | 118 | if (ret) |
| 111 | return; | 119 | return; |
| 112 | __gfs2_ail_flush(gl, fsync); | 120 | __gfs2_ail_flush(gl, fsync, max_revokes); |
| 113 | gfs2_trans_end(sdp); | 121 | gfs2_trans_end(sdp); |
| 114 | gfs2_log_flush(sdp, NULL); | 122 | gfs2_log_flush(sdp, NULL); |
| 115 | } | 123 | } |
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index bbb2715171cd..64915eeae5a7 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c | |||
| @@ -594,7 +594,7 @@ static int gfs2_create_inode(struct inode *dir, struct dentry *dentry, | |||
| 594 | } | 594 | } |
| 595 | gfs2_glock_dq_uninit(ghs); | 595 | gfs2_glock_dq_uninit(ghs); |
| 596 | if (IS_ERR(d)) | 596 | if (IS_ERR(d)) |
| 597 | return PTR_RET(d); | 597 | return PTR_ERR(d); |
| 598 | return error; | 598 | return error; |
| 599 | } else if (error != -ENOENT) { | 599 | } else if (error != -ENOENT) { |
| 600 | goto fail_gunlock; | 600 | goto fail_gunlock; |
| @@ -1750,6 +1750,10 @@ static ssize_t gfs2_getxattr(struct dentry *dentry, const char *name, | |||
| 1750 | struct gfs2_holder gh; | 1750 | struct gfs2_holder gh; |
| 1751 | int ret; | 1751 | int ret; |
| 1752 | 1752 | ||
| 1753 | /* For selinux during lookup */ | ||
| 1754 | if (gfs2_glock_is_locked_by_me(ip->i_gl)) | ||
| 1755 | return generic_getxattr(dentry, name, data, size); | ||
| 1756 | |||
| 1753 | gfs2_holder_init(ip->i_gl, LM_ST_SHARED, LM_FLAG_ANY, &gh); | 1757 | gfs2_holder_init(ip->i_gl, LM_ST_SHARED, LM_FLAG_ANY, &gh); |
| 1754 | ret = gfs2_glock_nq(&gh); | 1758 | ret = gfs2_glock_nq(&gh); |
| 1755 | if (ret == 0) { | 1759 | if (ret == 0) { |
diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c index e04d0e09ee7b..7b0f5043cf24 100644 --- a/fs/gfs2/main.c +++ b/fs/gfs2/main.c | |||
| @@ -155,7 +155,7 @@ static int __init init_gfs2_fs(void) | |||
| 155 | goto fail_wq; | 155 | goto fail_wq; |
| 156 | 156 | ||
| 157 | gfs2_control_wq = alloc_workqueue("gfs2_control", | 157 | gfs2_control_wq = alloc_workqueue("gfs2_control", |
| 158 | WQ_NON_REENTRANT | WQ_UNBOUND | WQ_FREEZABLE, 0); | 158 | WQ_UNBOUND | WQ_FREEZABLE, 0); |
| 159 | if (!gfs2_control_wq) | 159 | if (!gfs2_control_wq) |
| 160 | goto fail_recovery; | 160 | goto fail_recovery; |
| 161 | 161 | ||
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index a3f868ae3fd4..d19b30ababf1 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c | |||
| @@ -463,6 +463,14 @@ static struct inode *hugetlbfs_get_root(struct super_block *sb, | |||
| 463 | return inode; | 463 | return inode; |
| 464 | } | 464 | } |
| 465 | 465 | ||
| 466 | /* | ||
| 467 | * Hugetlbfs is not reclaimable; therefore its i_mmap_mutex will never | ||
| 468 | * be taken from reclaim -- unlike regular filesystems. This needs an | ||
| 469 | * annotation because huge_pmd_share() does an allocation under | ||
| 470 | * i_mmap_mutex. | ||
| 471 | */ | ||
| 472 | struct lock_class_key hugetlbfs_i_mmap_mutex_key; | ||
| 473 | |||
| 466 | static struct inode *hugetlbfs_get_inode(struct super_block *sb, | 474 | static struct inode *hugetlbfs_get_inode(struct super_block *sb, |
| 467 | struct inode *dir, | 475 | struct inode *dir, |
| 468 | umode_t mode, dev_t dev) | 476 | umode_t mode, dev_t dev) |
| @@ -474,6 +482,8 @@ static struct inode *hugetlbfs_get_inode(struct super_block *sb, | |||
| 474 | struct hugetlbfs_inode_info *info; | 482 | struct hugetlbfs_inode_info *info; |
| 475 | inode->i_ino = get_next_ino(); | 483 | inode->i_ino = get_next_ino(); |
| 476 | inode_init_owner(inode, dir, mode); | 484 | inode_init_owner(inode, dir, mode); |
| 485 | lockdep_set_class(&inode->i_mapping->i_mmap_mutex, | ||
| 486 | &hugetlbfs_i_mmap_mutex_key); | ||
| 477 | inode->i_mapping->a_ops = &hugetlbfs_aops; | 487 | inode->i_mapping->a_ops = &hugetlbfs_aops; |
| 478 | inode->i_mapping->backing_dev_info =&hugetlbfs_backing_dev_info; | 488 | inode->i_mapping->backing_dev_info =&hugetlbfs_backing_dev_info; |
| 479 | inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; | 489 | inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; |
| @@ -916,14 +926,8 @@ static int get_hstate_idx(int page_size_log) | |||
| 916 | return h - hstates; | 926 | return h - hstates; |
| 917 | } | 927 | } |
| 918 | 928 | ||
| 919 | static char *hugetlb_dname(struct dentry *dentry, char *buffer, int buflen) | ||
| 920 | { | ||
| 921 | return dynamic_dname(dentry, buffer, buflen, "/%s (deleted)", | ||
| 922 | dentry->d_name.name); | ||
| 923 | } | ||
| 924 | |||
| 925 | static struct dentry_operations anon_ops = { | 929 | static struct dentry_operations anon_ops = { |
| 926 | .d_dname = hugetlb_dname | 930 | .d_dname = simple_dname |
| 927 | }; | 931 | }; |
| 928 | 932 | ||
| 929 | /* | 933 | /* |
diff --git a/fs/namespace.c b/fs/namespace.c index 7b1ca9ba0b0a..a45ba4f267fe 100644 --- a/fs/namespace.c +++ b/fs/namespace.c | |||
| @@ -1429,7 +1429,7 @@ struct vfsmount *collect_mounts(struct path *path) | |||
| 1429 | CL_COPY_ALL | CL_PRIVATE); | 1429 | CL_COPY_ALL | CL_PRIVATE); |
| 1430 | namespace_unlock(); | 1430 | namespace_unlock(); |
| 1431 | if (IS_ERR(tree)) | 1431 | if (IS_ERR(tree)) |
| 1432 | return NULL; | 1432 | return ERR_CAST(tree); |
| 1433 | return &tree->mnt; | 1433 | return &tree->mnt; |
| 1434 | } | 1434 | } |
| 1435 | 1435 | ||
diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c index dc9a913784ab..2d8be51f90dc 100644 --- a/fs/nilfs2/segbuf.c +++ b/fs/nilfs2/segbuf.c | |||
| @@ -345,8 +345,7 @@ static void nilfs_end_bio_write(struct bio *bio, int err) | |||
| 345 | 345 | ||
| 346 | if (err == -EOPNOTSUPP) { | 346 | if (err == -EOPNOTSUPP) { |
| 347 | set_bit(BIO_EOPNOTSUPP, &bio->bi_flags); | 347 | set_bit(BIO_EOPNOTSUPP, &bio->bi_flags); |
| 348 | bio_put(bio); | 348 | /* to be detected by nilfs_segbuf_submit_bio() */ |
| 349 | /* to be detected by submit_seg_bio() */ | ||
| 350 | } | 349 | } |
| 351 | 350 | ||
| 352 | if (!uptodate) | 351 | if (!uptodate) |
| @@ -377,12 +376,12 @@ static int nilfs_segbuf_submit_bio(struct nilfs_segment_buffer *segbuf, | |||
| 377 | bio->bi_private = segbuf; | 376 | bio->bi_private = segbuf; |
| 378 | bio_get(bio); | 377 | bio_get(bio); |
| 379 | submit_bio(mode, bio); | 378 | submit_bio(mode, bio); |
| 379 | segbuf->sb_nbio++; | ||
| 380 | if (bio_flagged(bio, BIO_EOPNOTSUPP)) { | 380 | if (bio_flagged(bio, BIO_EOPNOTSUPP)) { |
| 381 | bio_put(bio); | 381 | bio_put(bio); |
| 382 | err = -EOPNOTSUPP; | 382 | err = -EOPNOTSUPP; |
| 383 | goto failed; | 383 | goto failed; |
| 384 | } | 384 | } |
| 385 | segbuf->sb_nbio++; | ||
| 386 | bio_put(bio); | 385 | bio_put(bio); |
| 387 | 386 | ||
| 388 | wi->bio = NULL; | 387 | wi->bio = NULL; |
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index 79736a28d84f..2abf97b2a592 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c | |||
| @@ -1757,7 +1757,7 @@ try_again: | |||
| 1757 | goto out; | 1757 | goto out; |
| 1758 | } else if (ret == 1) { | 1758 | } else if (ret == 1) { |
| 1759 | clusters_need = wc->w_clen; | 1759 | clusters_need = wc->w_clen; |
| 1760 | ret = ocfs2_refcount_cow(inode, filp, di_bh, | 1760 | ret = ocfs2_refcount_cow(inode, di_bh, |
| 1761 | wc->w_cpos, wc->w_clen, UINT_MAX); | 1761 | wc->w_cpos, wc->w_clen, UINT_MAX); |
| 1762 | if (ret) { | 1762 | if (ret) { |
| 1763 | mlog_errno(ret); | 1763 | mlog_errno(ret); |
diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index eb760d8acd50..30544ce8e9f7 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c | |||
| @@ -2153,11 +2153,9 @@ int ocfs2_empty_dir(struct inode *inode) | |||
| 2153 | { | 2153 | { |
| 2154 | int ret; | 2154 | int ret; |
| 2155 | struct ocfs2_empty_dir_priv priv = { | 2155 | struct ocfs2_empty_dir_priv priv = { |
| 2156 | .ctx.actor = ocfs2_empty_dir_filldir | 2156 | .ctx.actor = ocfs2_empty_dir_filldir, |
| 2157 | }; | 2157 | }; |
| 2158 | 2158 | ||
| 2159 | memset(&priv, 0, sizeof(priv)); | ||
| 2160 | |||
| 2161 | if (ocfs2_dir_indexed(inode)) { | 2159 | if (ocfs2_dir_indexed(inode)) { |
| 2162 | ret = ocfs2_empty_dir_dx(inode, &priv); | 2160 | ret = ocfs2_empty_dir_dx(inode, &priv); |
| 2163 | if (ret) | 2161 | if (ret) |
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index 41000f223ca4..3261d71319ee 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c | |||
| @@ -370,7 +370,7 @@ static int ocfs2_cow_file_pos(struct inode *inode, | |||
| 370 | if (!(ext_flags & OCFS2_EXT_REFCOUNTED)) | 370 | if (!(ext_flags & OCFS2_EXT_REFCOUNTED)) |
| 371 | goto out; | 371 | goto out; |
| 372 | 372 | ||
| 373 | return ocfs2_refcount_cow(inode, NULL, fe_bh, cpos, 1, cpos+1); | 373 | return ocfs2_refcount_cow(inode, fe_bh, cpos, 1, cpos+1); |
| 374 | 374 | ||
| 375 | out: | 375 | out: |
| 376 | return status; | 376 | return status; |
| @@ -899,7 +899,7 @@ static int ocfs2_zero_extend_get_range(struct inode *inode, | |||
| 899 | zero_clusters = last_cpos - zero_cpos; | 899 | zero_clusters = last_cpos - zero_cpos; |
| 900 | 900 | ||
| 901 | if (needs_cow) { | 901 | if (needs_cow) { |
| 902 | rc = ocfs2_refcount_cow(inode, NULL, di_bh, zero_cpos, | 902 | rc = ocfs2_refcount_cow(inode, di_bh, zero_cpos, |
| 903 | zero_clusters, UINT_MAX); | 903 | zero_clusters, UINT_MAX); |
| 904 | if (rc) { | 904 | if (rc) { |
| 905 | mlog_errno(rc); | 905 | mlog_errno(rc); |
| @@ -2078,7 +2078,7 @@ static int ocfs2_prepare_inode_for_refcount(struct inode *inode, | |||
| 2078 | 2078 | ||
| 2079 | *meta_level = 1; | 2079 | *meta_level = 1; |
| 2080 | 2080 | ||
| 2081 | ret = ocfs2_refcount_cow(inode, file, di_bh, cpos, clusters, UINT_MAX); | 2081 | ret = ocfs2_refcount_cow(inode, di_bh, cpos, clusters, UINT_MAX); |
| 2082 | if (ret) | 2082 | if (ret) |
| 2083 | mlog_errno(ret); | 2083 | mlog_errno(ret); |
| 2084 | out: | 2084 | out: |
diff --git a/fs/ocfs2/journal.h b/fs/ocfs2/journal.h index 96f9ac237e86..0a992737dcaf 100644 --- a/fs/ocfs2/journal.h +++ b/fs/ocfs2/journal.h | |||
| @@ -537,7 +537,7 @@ static inline int ocfs2_calc_extend_credits(struct super_block *sb, | |||
| 537 | extent_blocks = 1 + 1 + le16_to_cpu(root_el->l_tree_depth); | 537 | extent_blocks = 1 + 1 + le16_to_cpu(root_el->l_tree_depth); |
| 538 | 538 | ||
| 539 | return bitmap_blocks + sysfile_bitmap_blocks + extent_blocks + | 539 | return bitmap_blocks + sysfile_bitmap_blocks + extent_blocks + |
| 540 | ocfs2_quota_trans_credits(sb) + bits_wanted; | 540 | ocfs2_quota_trans_credits(sb); |
| 541 | } | 541 | } |
| 542 | 542 | ||
| 543 | static inline int ocfs2_calc_symlink_credits(struct super_block *sb) | 543 | static inline int ocfs2_calc_symlink_credits(struct super_block *sb) |
diff --git a/fs/ocfs2/move_extents.c b/fs/ocfs2/move_extents.c index f1fc172175b6..452068b45749 100644 --- a/fs/ocfs2/move_extents.c +++ b/fs/ocfs2/move_extents.c | |||
| @@ -69,7 +69,7 @@ static int __ocfs2_move_extent(handle_t *handle, | |||
| 69 | u64 ino = ocfs2_metadata_cache_owner(context->et.et_ci); | 69 | u64 ino = ocfs2_metadata_cache_owner(context->et.et_ci); |
| 70 | u64 old_blkno = ocfs2_clusters_to_blocks(inode->i_sb, p_cpos); | 70 | u64 old_blkno = ocfs2_clusters_to_blocks(inode->i_sb, p_cpos); |
| 71 | 71 | ||
| 72 | ret = ocfs2_duplicate_clusters_by_page(handle, context->file, cpos, | 72 | ret = ocfs2_duplicate_clusters_by_page(handle, inode, cpos, |
| 73 | p_cpos, new_p_cpos, len); | 73 | p_cpos, new_p_cpos, len); |
| 74 | if (ret) { | 74 | if (ret) { |
| 75 | mlog_errno(ret); | 75 | mlog_errno(ret); |
diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c index 9f6b96a09615..a70d604593b6 100644 --- a/fs/ocfs2/refcounttree.c +++ b/fs/ocfs2/refcounttree.c | |||
| @@ -49,7 +49,6 @@ | |||
| 49 | 49 | ||
| 50 | struct ocfs2_cow_context { | 50 | struct ocfs2_cow_context { |
| 51 | struct inode *inode; | 51 | struct inode *inode; |
| 52 | struct file *file; | ||
| 53 | u32 cow_start; | 52 | u32 cow_start; |
| 54 | u32 cow_len; | 53 | u32 cow_len; |
| 55 | struct ocfs2_extent_tree data_et; | 54 | struct ocfs2_extent_tree data_et; |
| @@ -66,7 +65,7 @@ struct ocfs2_cow_context { | |||
| 66 | u32 *num_clusters, | 65 | u32 *num_clusters, |
| 67 | unsigned int *extent_flags); | 66 | unsigned int *extent_flags); |
| 68 | int (*cow_duplicate_clusters)(handle_t *handle, | 67 | int (*cow_duplicate_clusters)(handle_t *handle, |
| 69 | struct file *file, | 68 | struct inode *inode, |
| 70 | u32 cpos, u32 old_cluster, | 69 | u32 cpos, u32 old_cluster, |
| 71 | u32 new_cluster, u32 new_len); | 70 | u32 new_cluster, u32 new_len); |
| 72 | }; | 71 | }; |
| @@ -2922,14 +2921,12 @@ static int ocfs2_clear_cow_buffer(handle_t *handle, struct buffer_head *bh) | |||
| 2922 | } | 2921 | } |
| 2923 | 2922 | ||
| 2924 | int ocfs2_duplicate_clusters_by_page(handle_t *handle, | 2923 | int ocfs2_duplicate_clusters_by_page(handle_t *handle, |
| 2925 | struct file *file, | 2924 | struct inode *inode, |
| 2926 | u32 cpos, u32 old_cluster, | 2925 | u32 cpos, u32 old_cluster, |
| 2927 | u32 new_cluster, u32 new_len) | 2926 | u32 new_cluster, u32 new_len) |
| 2928 | { | 2927 | { |
| 2929 | int ret = 0, partial; | 2928 | int ret = 0, partial; |
| 2930 | struct inode *inode = file_inode(file); | 2929 | struct super_block *sb = inode->i_sb; |
| 2931 | struct ocfs2_caching_info *ci = INODE_CACHE(inode); | ||
| 2932 | struct super_block *sb = ocfs2_metadata_cache_get_super(ci); | ||
| 2933 | u64 new_block = ocfs2_clusters_to_blocks(sb, new_cluster); | 2930 | u64 new_block = ocfs2_clusters_to_blocks(sb, new_cluster); |
| 2934 | struct page *page; | 2931 | struct page *page; |
| 2935 | pgoff_t page_index; | 2932 | pgoff_t page_index; |
| @@ -2978,13 +2975,6 @@ int ocfs2_duplicate_clusters_by_page(handle_t *handle, | |||
| 2978 | if (PAGE_CACHE_SIZE <= OCFS2_SB(sb)->s_clustersize) | 2975 | if (PAGE_CACHE_SIZE <= OCFS2_SB(sb)->s_clustersize) |
| 2979 | BUG_ON(PageDirty(page)); | 2976 | BUG_ON(PageDirty(page)); |
| 2980 | 2977 | ||
| 2981 | if (PageReadahead(page)) { | ||
| 2982 | page_cache_async_readahead(mapping, | ||
| 2983 | &file->f_ra, file, | ||
| 2984 | page, page_index, | ||
| 2985 | readahead_pages); | ||
| 2986 | } | ||
| 2987 | |||
| 2988 | if (!PageUptodate(page)) { | 2978 | if (!PageUptodate(page)) { |
| 2989 | ret = block_read_full_page(page, ocfs2_get_block); | 2979 | ret = block_read_full_page(page, ocfs2_get_block); |
| 2990 | if (ret) { | 2980 | if (ret) { |
| @@ -3004,7 +2994,8 @@ int ocfs2_duplicate_clusters_by_page(handle_t *handle, | |||
| 3004 | } | 2994 | } |
| 3005 | } | 2995 | } |
| 3006 | 2996 | ||
| 3007 | ocfs2_map_and_dirty_page(inode, handle, from, to, | 2997 | ocfs2_map_and_dirty_page(inode, |
| 2998 | handle, from, to, | ||
| 3008 | page, 0, &new_block); | 2999 | page, 0, &new_block); |
| 3009 | mark_page_accessed(page); | 3000 | mark_page_accessed(page); |
| 3010 | unlock: | 3001 | unlock: |
| @@ -3020,12 +3011,11 @@ unlock: | |||
| 3020 | } | 3011 | } |
| 3021 | 3012 | ||
| 3022 | int ocfs2_duplicate_clusters_by_jbd(handle_t *handle, | 3013 | int ocfs2_duplicate_clusters_by_jbd(handle_t *handle, |
| 3023 | struct file *file, | 3014 | struct inode *inode, |
| 3024 | u32 cpos, u32 old_cluster, | 3015 | u32 cpos, u32 old_cluster, |
| 3025 | u32 new_cluster, u32 new_len) | 3016 | u32 new_cluster, u32 new_len) |
| 3026 | { | 3017 | { |
| 3027 | int ret = 0; | 3018 | int ret = 0; |
| 3028 | struct inode *inode = file_inode(file); | ||
| 3029 | struct super_block *sb = inode->i_sb; | 3019 | struct super_block *sb = inode->i_sb; |
| 3030 | struct ocfs2_caching_info *ci = INODE_CACHE(inode); | 3020 | struct ocfs2_caching_info *ci = INODE_CACHE(inode); |
| 3031 | int i, blocks = ocfs2_clusters_to_blocks(sb, new_len); | 3021 | int i, blocks = ocfs2_clusters_to_blocks(sb, new_len); |
| @@ -3150,7 +3140,7 @@ static int ocfs2_replace_clusters(handle_t *handle, | |||
| 3150 | 3140 | ||
| 3151 | /*If the old clusters is unwritten, no need to duplicate. */ | 3141 | /*If the old clusters is unwritten, no need to duplicate. */ |
| 3152 | if (!(ext_flags & OCFS2_EXT_UNWRITTEN)) { | 3142 | if (!(ext_flags & OCFS2_EXT_UNWRITTEN)) { |
| 3153 | ret = context->cow_duplicate_clusters(handle, context->file, | 3143 | ret = context->cow_duplicate_clusters(handle, context->inode, |
| 3154 | cpos, old, new, len); | 3144 | cpos, old, new, len); |
| 3155 | if (ret) { | 3145 | if (ret) { |
| 3156 | mlog_errno(ret); | 3146 | mlog_errno(ret); |
| @@ -3428,35 +3418,12 @@ static int ocfs2_replace_cow(struct ocfs2_cow_context *context) | |||
| 3428 | return ret; | 3418 | return ret; |
| 3429 | } | 3419 | } |
| 3430 | 3420 | ||
| 3431 | static void ocfs2_readahead_for_cow(struct inode *inode, | ||
| 3432 | struct file *file, | ||
| 3433 | u32 start, u32 len) | ||
| 3434 | { | ||
| 3435 | struct address_space *mapping; | ||
| 3436 | pgoff_t index; | ||
| 3437 | unsigned long num_pages; | ||
| 3438 | int cs_bits = OCFS2_SB(inode->i_sb)->s_clustersize_bits; | ||
| 3439 | |||
| 3440 | if (!file) | ||
| 3441 | return; | ||
| 3442 | |||
| 3443 | mapping = file->f_mapping; | ||
| 3444 | num_pages = (len << cs_bits) >> PAGE_CACHE_SHIFT; | ||
| 3445 | if (!num_pages) | ||
| 3446 | num_pages = 1; | ||
| 3447 | |||
| 3448 | index = ((loff_t)start << cs_bits) >> PAGE_CACHE_SHIFT; | ||
| 3449 | page_cache_sync_readahead(mapping, &file->f_ra, file, | ||
| 3450 | index, num_pages); | ||
| 3451 | } | ||
| 3452 | |||
| 3453 | /* | 3421 | /* |
| 3454 | * Starting at cpos, try to CoW write_len clusters. Don't CoW | 3422 | * Starting at cpos, try to CoW write_len clusters. Don't CoW |
| 3455 | * past max_cpos. This will stop when it runs into a hole or an | 3423 | * past max_cpos. This will stop when it runs into a hole or an |
| 3456 | * unrefcounted extent. | 3424 | * unrefcounted extent. |
| 3457 | */ | 3425 | */ |
| 3458 | static int ocfs2_refcount_cow_hunk(struct inode *inode, | 3426 | static int ocfs2_refcount_cow_hunk(struct inode *inode, |
| 3459 | struct file *file, | ||
| 3460 | struct buffer_head *di_bh, | 3427 | struct buffer_head *di_bh, |
| 3461 | u32 cpos, u32 write_len, u32 max_cpos) | 3428 | u32 cpos, u32 write_len, u32 max_cpos) |
| 3462 | { | 3429 | { |
| @@ -3485,8 +3452,6 @@ static int ocfs2_refcount_cow_hunk(struct inode *inode, | |||
| 3485 | 3452 | ||
| 3486 | BUG_ON(cow_len == 0); | 3453 | BUG_ON(cow_len == 0); |
| 3487 | 3454 | ||
| 3488 | ocfs2_readahead_for_cow(inode, file, cow_start, cow_len); | ||
| 3489 | |||
| 3490 | context = kzalloc(sizeof(struct ocfs2_cow_context), GFP_NOFS); | 3455 | context = kzalloc(sizeof(struct ocfs2_cow_context), GFP_NOFS); |
| 3491 | if (!context) { | 3456 | if (!context) { |
| 3492 | ret = -ENOMEM; | 3457 | ret = -ENOMEM; |
| @@ -3508,7 +3473,6 @@ static int ocfs2_refcount_cow_hunk(struct inode *inode, | |||
| 3508 | context->ref_root_bh = ref_root_bh; | 3473 | context->ref_root_bh = ref_root_bh; |
| 3509 | context->cow_duplicate_clusters = ocfs2_duplicate_clusters_by_page; | 3474 | context->cow_duplicate_clusters = ocfs2_duplicate_clusters_by_page; |
| 3510 | context->get_clusters = ocfs2_di_get_clusters; | 3475 | context->get_clusters = ocfs2_di_get_clusters; |
| 3511 | context->file = file; | ||
| 3512 | 3476 | ||
| 3513 | ocfs2_init_dinode_extent_tree(&context->data_et, | 3477 | ocfs2_init_dinode_extent_tree(&context->data_et, |
| 3514 | INODE_CACHE(inode), di_bh); | 3478 | INODE_CACHE(inode), di_bh); |
| @@ -3537,7 +3501,6 @@ out: | |||
| 3537 | * clusters between cpos and cpos+write_len are safe to modify. | 3501 | * clusters between cpos and cpos+write_len are safe to modify. |
| 3538 | */ | 3502 | */ |
| 3539 | int ocfs2_refcount_cow(struct inode *inode, | 3503 | int ocfs2_refcount_cow(struct inode *inode, |
| 3540 | struct file *file, | ||
| 3541 | struct buffer_head *di_bh, | 3504 | struct buffer_head *di_bh, |
| 3542 | u32 cpos, u32 write_len, u32 max_cpos) | 3505 | u32 cpos, u32 write_len, u32 max_cpos) |
| 3543 | { | 3506 | { |
| @@ -3557,7 +3520,7 @@ int ocfs2_refcount_cow(struct inode *inode, | |||
| 3557 | num_clusters = write_len; | 3520 | num_clusters = write_len; |
| 3558 | 3521 | ||
| 3559 | if (ext_flags & OCFS2_EXT_REFCOUNTED) { | 3522 | if (ext_flags & OCFS2_EXT_REFCOUNTED) { |
| 3560 | ret = ocfs2_refcount_cow_hunk(inode, file, di_bh, cpos, | 3523 | ret = ocfs2_refcount_cow_hunk(inode, di_bh, cpos, |
| 3561 | num_clusters, max_cpos); | 3524 | num_clusters, max_cpos); |
| 3562 | if (ret) { | 3525 | if (ret) { |
| 3563 | mlog_errno(ret); | 3526 | mlog_errno(ret); |
diff --git a/fs/ocfs2/refcounttree.h b/fs/ocfs2/refcounttree.h index 7754608c83a4..6422bbcdb525 100644 --- a/fs/ocfs2/refcounttree.h +++ b/fs/ocfs2/refcounttree.h | |||
| @@ -53,7 +53,7 @@ int ocfs2_prepare_refcount_change_for_del(struct inode *inode, | |||
| 53 | int *credits, | 53 | int *credits, |
| 54 | int *ref_blocks); | 54 | int *ref_blocks); |
| 55 | int ocfs2_refcount_cow(struct inode *inode, | 55 | int ocfs2_refcount_cow(struct inode *inode, |
| 56 | struct file *filep, struct buffer_head *di_bh, | 56 | struct buffer_head *di_bh, |
| 57 | u32 cpos, u32 write_len, u32 max_cpos); | 57 | u32 cpos, u32 write_len, u32 max_cpos); |
| 58 | 58 | ||
| 59 | typedef int (ocfs2_post_refcount_func)(struct inode *inode, | 59 | typedef int (ocfs2_post_refcount_func)(struct inode *inode, |
| @@ -85,11 +85,11 @@ int ocfs2_refcount_cow_xattr(struct inode *inode, | |||
| 85 | u32 cpos, u32 write_len, | 85 | u32 cpos, u32 write_len, |
| 86 | struct ocfs2_post_refcount *post); | 86 | struct ocfs2_post_refcount *post); |
| 87 | int ocfs2_duplicate_clusters_by_page(handle_t *handle, | 87 | int ocfs2_duplicate_clusters_by_page(handle_t *handle, |
| 88 | struct file *file, | 88 | struct inode *inode, |
| 89 | u32 cpos, u32 old_cluster, | 89 | u32 cpos, u32 old_cluster, |
| 90 | u32 new_cluster, u32 new_len); | 90 | u32 new_cluster, u32 new_len); |
| 91 | int ocfs2_duplicate_clusters_by_jbd(handle_t *handle, | 91 | int ocfs2_duplicate_clusters_by_jbd(handle_t *handle, |
| 92 | struct file *file, | 92 | struct inode *inode, |
| 93 | u32 cpos, u32 old_cluster, | 93 | u32 cpos, u32 old_cluster, |
| 94 | u32 new_cluster, u32 new_len); | 94 | u32 new_cluster, u32 new_len); |
| 95 | int ocfs2_cow_sync_writeback(struct super_block *sb, | 95 | int ocfs2_cow_sync_writeback(struct super_block *sb, |
diff --git a/fs/proc/fd.c b/fs/proc/fd.c index 75f2890abbd8..0ff80f9b930f 100644 --- a/fs/proc/fd.c +++ b/fs/proc/fd.c | |||
| @@ -230,8 +230,6 @@ static int proc_readfd_common(struct file *file, struct dir_context *ctx, | |||
| 230 | 230 | ||
| 231 | if (!dir_emit_dots(file, ctx)) | 231 | if (!dir_emit_dots(file, ctx)) |
| 232 | goto out; | 232 | goto out; |
| 233 | if (!dir_emit_dots(file, ctx)) | ||
| 234 | goto out; | ||
| 235 | files = get_files_struct(p); | 233 | files = get_files_struct(p); |
| 236 | if (!files) | 234 | if (!files) |
| 237 | goto out; | 235 | goto out; |
diff --git a/fs/proc/generic.c b/fs/proc/generic.c index 94441a407337..737e15615b04 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c | |||
| @@ -271,7 +271,7 @@ int proc_readdir_de(struct proc_dir_entry *de, struct file *file, | |||
| 271 | de = next; | 271 | de = next; |
| 272 | } while (de); | 272 | } while (de); |
| 273 | spin_unlock(&proc_subdir_lock); | 273 | spin_unlock(&proc_subdir_lock); |
| 274 | return 0; | 274 | return 1; |
| 275 | } | 275 | } |
| 276 | 276 | ||
| 277 | int proc_readdir(struct file *file, struct dir_context *ctx) | 277 | int proc_readdir(struct file *file, struct dir_context *ctx) |
diff --git a/fs/proc/root.c b/fs/proc/root.c index 229e366598da..e0a790da726d 100644 --- a/fs/proc/root.c +++ b/fs/proc/root.c | |||
| @@ -205,7 +205,9 @@ static struct dentry *proc_root_lookup(struct inode * dir, struct dentry * dentr | |||
| 205 | static int proc_root_readdir(struct file *file, struct dir_context *ctx) | 205 | static int proc_root_readdir(struct file *file, struct dir_context *ctx) |
| 206 | { | 206 | { |
| 207 | if (ctx->pos < FIRST_PROCESS_ENTRY) { | 207 | if (ctx->pos < FIRST_PROCESS_ENTRY) { |
| 208 | proc_readdir(file, ctx); | 208 | int error = proc_readdir(file, ctx); |
| 209 | if (unlikely(error <= 0)) | ||
| 210 | return error; | ||
| 209 | ctx->pos = FIRST_PROCESS_ENTRY; | 211 | ctx->pos = FIRST_PROCESS_ENTRY; |
| 210 | } | 212 | } |
| 211 | 213 | ||
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index dbf61f6174f0..107d026f5d6e 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c | |||
| @@ -730,8 +730,16 @@ static inline void clear_soft_dirty(struct vm_area_struct *vma, | |||
| 730 | * of how soft-dirty works. | 730 | * of how soft-dirty works. |
| 731 | */ | 731 | */ |
| 732 | pte_t ptent = *pte; | 732 | pte_t ptent = *pte; |
| 733 | ptent = pte_wrprotect(ptent); | 733 | |
| 734 | ptent = pte_clear_flags(ptent, _PAGE_SOFT_DIRTY); | 734 | if (pte_present(ptent)) { |
| 735 | ptent = pte_wrprotect(ptent); | ||
| 736 | ptent = pte_clear_flags(ptent, _PAGE_SOFT_DIRTY); | ||
| 737 | } else if (is_swap_pte(ptent)) { | ||
| 738 | ptent = pte_swp_clear_soft_dirty(ptent); | ||
| 739 | } else if (pte_file(ptent)) { | ||
| 740 | ptent = pte_file_clear_soft_dirty(ptent); | ||
| 741 | } | ||
| 742 | |||
| 735 | set_pte_at(vma->vm_mm, addr, pte, ptent); | 743 | set_pte_at(vma->vm_mm, addr, pte, ptent); |
| 736 | #endif | 744 | #endif |
| 737 | } | 745 | } |
| @@ -752,14 +760,15 @@ static int clear_refs_pte_range(pmd_t *pmd, unsigned long addr, | |||
| 752 | pte = pte_offset_map_lock(vma->vm_mm, pmd, addr, &ptl); | 760 | pte = pte_offset_map_lock(vma->vm_mm, pmd, addr, &ptl); |
| 753 | for (; addr != end; pte++, addr += PAGE_SIZE) { | 761 | for (; addr != end; pte++, addr += PAGE_SIZE) { |
| 754 | ptent = *pte; | 762 | ptent = *pte; |
| 755 | if (!pte_present(ptent)) | ||
| 756 | continue; | ||
| 757 | 763 | ||
| 758 | if (cp->type == CLEAR_REFS_SOFT_DIRTY) { | 764 | if (cp->type == CLEAR_REFS_SOFT_DIRTY) { |
| 759 | clear_soft_dirty(vma, addr, pte); | 765 | clear_soft_dirty(vma, addr, pte); |
| 760 | continue; | 766 | continue; |
| 761 | } | 767 | } |
| 762 | 768 | ||
| 769 | if (!pte_present(ptent)) | ||
| 770 | continue; | ||
| 771 | |||
| 763 | page = vm_normal_page(vma, addr, ptent); | 772 | page = vm_normal_page(vma, addr, ptent); |
| 764 | if (!page) | 773 | if (!page) |
| 765 | continue; | 774 | continue; |
| @@ -859,7 +868,7 @@ typedef struct { | |||
| 859 | } pagemap_entry_t; | 868 | } pagemap_entry_t; |
| 860 | 869 | ||
| 861 | struct pagemapread { | 870 | struct pagemapread { |
| 862 | int pos, len; | 871 | int pos, len; /* units: PM_ENTRY_BYTES, not bytes */ |
| 863 | pagemap_entry_t *buffer; | 872 | pagemap_entry_t *buffer; |
| 864 | bool v2; | 873 | bool v2; |
| 865 | }; | 874 | }; |
| @@ -867,7 +876,7 @@ struct pagemapread { | |||
| 867 | #define PAGEMAP_WALK_SIZE (PMD_SIZE) | 876 | #define PAGEMAP_WALK_SIZE (PMD_SIZE) |
| 868 | #define PAGEMAP_WALK_MASK (PMD_MASK) | 877 | #define PAGEMAP_WALK_MASK (PMD_MASK) |
| 869 | 878 | ||
| 870 | #define PM_ENTRY_BYTES sizeof(u64) | 879 | #define PM_ENTRY_BYTES sizeof(pagemap_entry_t) |
| 871 | #define PM_STATUS_BITS 3 | 880 | #define PM_STATUS_BITS 3 |
| 872 | #define PM_STATUS_OFFSET (64 - PM_STATUS_BITS) | 881 | #define PM_STATUS_OFFSET (64 - PM_STATUS_BITS) |
| 873 | #define PM_STATUS_MASK (((1LL << PM_STATUS_BITS) - 1) << PM_STATUS_OFFSET) | 882 | #define PM_STATUS_MASK (((1LL << PM_STATUS_BITS) - 1) << PM_STATUS_OFFSET) |
| @@ -930,8 +939,10 @@ static void pte_to_pagemap_entry(pagemap_entry_t *pme, struct pagemapread *pm, | |||
| 930 | flags = PM_PRESENT; | 939 | flags = PM_PRESENT; |
| 931 | page = vm_normal_page(vma, addr, pte); | 940 | page = vm_normal_page(vma, addr, pte); |
| 932 | } else if (is_swap_pte(pte)) { | 941 | } else if (is_swap_pte(pte)) { |
| 933 | swp_entry_t entry = pte_to_swp_entry(pte); | 942 | swp_entry_t entry; |
| 934 | 943 | if (pte_swp_soft_dirty(pte)) | |
| 944 | flags2 |= __PM_SOFT_DIRTY; | ||
| 945 | entry = pte_to_swp_entry(pte); | ||
| 935 | frame = swp_type(entry) | | 946 | frame = swp_type(entry) | |
| 936 | (swp_offset(entry) << MAX_SWAPFILES_SHIFT); | 947 | (swp_offset(entry) << MAX_SWAPFILES_SHIFT); |
| 937 | flags = PM_SWAP; | 948 | flags = PM_SWAP; |
| @@ -1116,8 +1127,8 @@ static ssize_t pagemap_read(struct file *file, char __user *buf, | |||
| 1116 | goto out_task; | 1127 | goto out_task; |
| 1117 | 1128 | ||
| 1118 | pm.v2 = soft_dirty_cleared; | 1129 | pm.v2 = soft_dirty_cleared; |
| 1119 | pm.len = PM_ENTRY_BYTES * (PAGEMAP_WALK_SIZE >> PAGE_SHIFT); | 1130 | pm.len = (PAGEMAP_WALK_SIZE >> PAGE_SHIFT); |
| 1120 | pm.buffer = kmalloc(pm.len, GFP_TEMPORARY); | 1131 | pm.buffer = kmalloc(pm.len * PM_ENTRY_BYTES, GFP_TEMPORARY); |
| 1121 | ret = -ENOMEM; | 1132 | ret = -ENOMEM; |
| 1122 | if (!pm.buffer) | 1133 | if (!pm.buffer) |
| 1123 | goto out_task; | 1134 | goto out_task; |
