1 files changed, 10 insertions, 14 deletions

diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index b571fee677d5..b235215ac138 100644
--- a/fs/f2fs/recovery.c
+++ b/fs/f2fs/recovery.c
@@ -42,7 +42,7 @@ static int recover_dentry(struct page *ipage, struct inode *inode)
 {
         struct f2fs_node *raw_node = (struct f2fs_node *)kmap(ipage);
         struct f2fs_inode *raw_inode = &(raw_node->i);
-        struct dentry dent, parent;
+        struct qstr name;
         struct f2fs_dir_entry *de;
         struct page *page;
         struct inode *dir;
@@ -57,17 +57,15 @@ static int recover_dentry(struct page *ipage, struct inode *inode)
                 goto out;
         }
 
-        parent.d_inode = dir;
-        dent.d_parent = &parent;
-        dent.d_name.len = le32_to_cpu(raw_inode->i_namelen);
-        dent.d_name.name = raw_inode->i_name;
+        name.len = le32_to_cpu(raw_inode->i_namelen);
+        name.name = raw_inode->i_name;
 
-        de = f2fs_find_entry(dir, &dent.d_name, &page);
+        de = f2fs_find_entry(dir, &name, &page);
         if (de) {
                 kunmap(page);
                 f2fs_put_page(page, 0);
         } else {
-                f2fs_add_link(&dent, inode);
+                err = __f2fs_add_link(dir, &name, inode);
         }
         iput(dir);
 out:
@@ -151,7 +149,6 @@ static int find_fsync_dnodes(struct f2fs_sb_info *sbi, struct list_head *head)
                                 goto out;
                         }
 
-                        INIT_LIST_HEAD(&entry->list);
                         list_add_tail(&entry->list, head);
                         entry->blkaddr = blkaddr;
                 }
@@ -174,10 +171,9 @@ out:
 static void destroy_fsync_dnodes(struct f2fs_sb_info *sbi,
                                         struct list_head *head)
 {
-        struct list_head *this;
-        struct fsync_inode_entry *entry;
-        list_for_each(this, head) {
-                entry = list_entry(this, struct fsync_inode_entry, list);
+        struct fsync_inode_entry *entry, *tmp;
+
+        list_for_each_entry_safe(entry, tmp, head, list) {
                 iput(entry->inode);
                 list_del(&entry->list);
                 kmem_cache_free(fsync_entry_slab, entry);
@@ -228,7 +224,7 @@ static void check_index_in_prev_nodes(struct f2fs_sb_info *sbi,
         f2fs_put_page(node_page, 1);
 
         /* Deallocate previous index in the node page */
-        inode = f2fs_iget_nowait(sbi->sb, ino);
+        inode = f2fs_iget(sbi->sb, ino);
         if (IS_ERR(inode))
                 return;
 
@@ -375,5 +371,5 @@ void recover_fsync_data(struct f2fs_sb_info *sbi)
 out:
         destroy_fsync_dnodes(sbi, &inode_list);
         kmem_cache_destroy(fsync_entry_slab);
-        write_checkpoint(sbi, false, false);
+        write_checkpoint(sbi, false);
 }