1 files changed, 24 insertions, 13 deletions

diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index 0d19a6d61a71..970a30e155cb 100644
--- a/drivers/usb/phy/phy-msm-usb.c
+++ b/drivers/usb/phy/phy-msm-usb.c
@@ -1599,6 +1599,8 @@ static int msm_otg_read_dt(struct platform_device *pdev, struct msm_otg *motg)
                                                 &motg->id.nb);
                 if (ret < 0) {
                         dev_err(&pdev->dev, "register ID notifier failed\n");
+                        extcon_unregister_notifier(motg->vbus.extcon,
+                                                   EXTCON_USB, &motg->vbus.nb);
                         return ret;
                 }
 
@@ -1660,15 +1662,6 @@ static int msm_otg_probe(struct platform_device *pdev)
         if (!motg)
                 return -ENOMEM;
 
-        pdata = dev_get_platdata(&pdev->dev);
-        if (!pdata) {
-                if (!np)
-                        return -ENXIO;
-                ret = msm_otg_read_dt(pdev, motg);
-                if (ret)
-                        return ret;
-        }
-
         motg->phy.otg = devm_kzalloc(&pdev->dev, sizeof(struct usb_otg),
                                      GFP_KERNEL);
         if (!motg->phy.otg)
@@ -1710,6 +1703,15 @@ static int msm_otg_probe(struct platform_device *pdev)
         if (!motg->regs)
                 return -ENOMEM;
 
+        pdata = dev_get_platdata(&pdev->dev);
+        if (!pdata) {
+                if (!np)
+                        return -ENXIO;
+                ret = msm_otg_read_dt(pdev, motg);
+                if (ret)
+                        return ret;
+        }
+
         /*
          * NOTE: The PHYs can be multiplexed between the chipidea controller
          * and the dwc3 controller, using a single bit. It is important that
@@ -1717,8 +1719,10 @@ static int msm_otg_probe(struct platform_device *pdev)
          */
         if (motg->phy_number) {
                 phy_select = devm_ioremap_nocache(&pdev->dev, USB2_PHY_SEL, 4);
-                if (!phy_select)
-                        return -ENOMEM;
+                if (!phy_select) {
+                        ret = -ENOMEM;
+                        goto unregister_extcon;
+                }
                 /* Enable second PHY with the OTG port */
                 writel(0x1, phy_select);
         }
@@ -1728,7 +1732,8 @@ static int msm_otg_probe(struct platform_device *pdev)
         motg->irq = platform_get_irq(pdev, 0);
         if (motg->irq < 0) {
                 dev_err(&pdev->dev, "platform_get_irq failed\n");
-                return motg->irq;
+                ret = motg->irq;
+                goto unregister_extcon;
         }
 
         regs[0].supply = "vddcx";
@@ -1737,7 +1742,7 @@ static int msm_otg_probe(struct platform_device *pdev)
 
         ret = devm_regulator_bulk_get(motg->phy.dev, ARRAY_SIZE(regs), regs);
         if (ret)
-                return ret;
+                goto unregister_extcon;
 
         motg->vddcx = regs[0].consumer;
         motg->v3p3  = regs[1].consumer;
@@ -1834,6 +1839,12 @@ disable_clks:
         clk_disable_unprepare(motg->clk);
         if (!IS_ERR(motg->core_clk))
                 clk_disable_unprepare(motg->core_clk);
+unregister_extcon:
+        extcon_unregister_notifier(motg->id.extcon,
+                                   EXTCON_USB_HOST, &motg->id.nb);
+        extcon_unregister_notifier(motg->vbus.extcon,
+                                   EXTCON_USB, &motg->vbus.nb);
+
         return ret;
 }