1 files changed, 7 insertions, 18 deletions

diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index d98c33cb64f9..c688efa95e29 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -204,8 +204,8 @@ static bool spi_imx_can_dma(struct spi_master *master, struct spi_device *spi,
 {
         struct spi_imx_data *spi_imx = spi_master_get_devdata(master);
 
-        if (spi_imx->dma_is_inited &&
-            transfer->len > spi_imx->wml * sizeof(u32))
+        if (spi_imx->dma_is_inited && transfer->len >= spi_imx->wml &&
+            (transfer->len % spi_imx->wml) == 0)
                 return true;
         return false;
 }
@@ -919,8 +919,6 @@ static int spi_imx_dma_transfer(struct spi_imx_data *spi_imx,
         struct dma_async_tx_descriptor *desc_tx = NULL, *desc_rx = NULL;
         int ret;
         unsigned long timeout;
-        u32 dma;
-        int left;
         struct spi_master *master = spi_imx->bitbang.master;
         struct sg_table *tx = &transfer->tx_sg, *rx = &transfer->rx_sg;
 
@@ -929,7 +927,7 @@ static int spi_imx_dma_transfer(struct spi_imx_data *spi_imx,
                                         tx->sgl, tx->nents, DMA_MEM_TO_DEV,
                                         DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
                 if (!desc_tx)
-                        goto no_dma;
+                        goto tx_nodma;
 
                 desc_tx->callback = spi_imx_dma_tx_callback;
                 desc_tx->callback_param = (void *)spi_imx;
@@ -941,7 +939,7 @@ static int spi_imx_dma_transfer(struct spi_imx_data *spi_imx,
                                         rx->sgl, rx->nents, DMA_DEV_TO_MEM,
                                         DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
                 if (!desc_rx)
-                        goto no_dma;
+                        goto rx_nodma;
 
                 desc_rx->callback = spi_imx_dma_rx_callback;
                 desc_rx->callback_param = (void *)spi_imx;
@@ -954,13 +952,6 @@ static int spi_imx_dma_transfer(struct spi_imx_data *spi_imx,
         /* Trigger the cspi module. */
         spi_imx->dma_finished = 0;
 
-        dma = readl(spi_imx->base + MX51_ECSPI_DMA);
-        dma = dma & (~MX51_ECSPI_DMA_RXT_WML_MASK);
-        /* Change RX_DMA_LENGTH trigger dma fetch tail data */
-        left = transfer->len % spi_imx->wml;
-        if (left)
-                writel(dma | (left << MX51_ECSPI_DMA_RXT_WML_OFFSET),
-                                spi_imx->base + MX51_ECSPI_DMA);
         /*
          * Set these order to avoid potential RX overflow. The overflow may
          * happen if we enable SPI HW before starting RX DMA due to rescheduling
@@ -992,10 +983,6 @@ static int spi_imx_dma_transfer(struct spi_imx_data *spi_imx,
                         spi_imx->devtype_data->reset(spi_imx);
                         dmaengine_terminate_all(master->dma_rx);
                 }
-                dma &= ~MX51_ECSPI_DMA_RXT_WML_MASK;
-                writel(dma |
-                       spi_imx->wml << MX51_ECSPI_DMA_RXT_WML_OFFSET,
-                       spi_imx->base + MX51_ECSPI_DMA);
         }
 
         spi_imx->dma_finished = 1;
@@ -1008,7 +995,9 @@ static int spi_imx_dma_transfer(struct spi_imx_data *spi_imx,
 
         return ret;
 
-no_dma:
+rx_nodma:
+        dmaengine_terminate_all(master->dma_tx);
+tx_nodma:
         pr_warn_once("%s %s: DMA not available, falling back to PIO\n",
                      dev_driver_string(&master->dev),
                      dev_name(&master->dev));