1 files changed, 8 insertions, 4 deletions

diff --git a/drivers/infiniband/hw/hfi1/fault.c b/drivers/infiniband/hw/hfi1/fault.c
index 93613e5def9b..986c12153e62 100644
--- a/drivers/infiniband/hw/hfi1/fault.c
+++ b/drivers/infiniband/hw/hfi1/fault.c
@@ -141,12 +141,14 @@ static ssize_t fault_opcodes_write(struct file *file, const char __user *buf,
         if (!data)
                 return -ENOMEM;
         copy = min(len, datalen - 1);
-        if (copy_from_user(data, buf, copy))
-                return -EFAULT;
+        if (copy_from_user(data, buf, copy)) {
+                ret = -EFAULT;
+                goto free_data;
+        }
 
         ret = debugfs_file_get(file->f_path.dentry);
         if (unlikely(ret))
-                return ret;
+                goto free_data;
         ptr = data;
         token = ptr;
         for (ptr = data; *ptr; ptr = end + 1, token = ptr) {
@@ -195,6 +197,7 @@ static ssize_t fault_opcodes_write(struct file *file, const char __user *buf,
         ret = len;
 
         debugfs_file_put(file->f_path.dentry);
+free_data:
         kfree(data);
         return ret;
 }
@@ -214,7 +217,7 @@ static ssize_t fault_opcodes_read(struct file *file, char __user *buf,
                 return -ENOMEM;
         ret = debugfs_file_get(file->f_path.dentry);
         if (unlikely(ret))
-                return ret;
+                goto free_data;
         bit = find_first_bit(fault->opcodes, bitsize);
         while (bit < bitsize) {
                 zero = find_next_zero_bit(fault->opcodes, bitsize, bit);
@@ -232,6 +235,7 @@ static ssize_t fault_opcodes_read(struct file *file, char __user *buf,
         data[size - 1] = '\n';
         data[size] = '\0';
         ret = simple_read_from_buffer(buf, len, pos, data, size);
+free_data:
         kfree(data);
         return ret;
 }