186 files changed, 5226 insertions, 3013 deletions

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
index a024217896fd..a370101d923f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
@@ -530,7 +530,8 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,
                 r = ttm_eu_reserve_buffers(&p->ticket, &p->validated, true,
                                            &duplicates);
                 if (unlikely(r != 0)) {
-                        DRM_ERROR("ttm_eu_reserve_buffers failed.\n");
+                        if (r != -ERESTARTSYS)
+                                DRM_ERROR("ttm_eu_reserve_buffers failed.\n");
                         goto error_free_pages;
                 }
 
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 6958d4af017f..9e16e975f31a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -1981,6 +1981,7 @@ int amdgpu_device_suspend(struct drm_device *dev, bool suspend, bool fbcon)
          */
         amdgpu_bo_evict_vram(adev);
 
+        amdgpu_atombios_scratch_regs_save(adev);
         pci_save_state(dev->pdev);
         if (suspend) {
                 /* Shut down the device */
@@ -2032,6 +2033,7 @@ int amdgpu_device_resume(struct drm_device *dev, bool resume, bool fbcon)
                         return r;
                 }
         }
+        amdgpu_atombios_scratch_regs_restore(adev);
 
         /* post card */
         if (!amdgpu_card_posted(adev) || !resume) {
@@ -2290,8 +2292,6 @@ int amdgpu_gpu_reset(struct amdgpu_device *adev)
         }
 
         if (need_full_reset) {
-                /* save scratch */
-                amdgpu_atombios_scratch_regs_save(adev);
                 r = amdgpu_suspend(adev);
 
 retry:
@@ -2301,8 +2301,9 @@ retry:
                         amdgpu_display_stop_mc_access(adev, &save);
                         amdgpu_wait_for_idle(adev, AMD_IP_BLOCK_TYPE_GMC);
                 }
-
+                amdgpu_atombios_scratch_regs_save(adev);
                 r = amdgpu_asic_reset(adev);
+                amdgpu_atombios_scratch_regs_restore(adev);
                 /* post card */
                 amdgpu_atom_asic_init(adev->mode_info.atom_context);
 
@@ -2310,8 +2311,6 @@ retry:
                         dev_info(adev->dev, "GPU reset succeeded, trying to resume\n");
                         r = amdgpu_resume(adev);
                 }
-                /* restore scratch */
-                amdgpu_atombios_scratch_regs_restore(adev);
         }
         if (!r) {
                 amdgpu_irq_gpu_reset_resume_helper(adev);
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
index 57552c79ec58..97928d7281f6 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
@@ -68,6 +68,7 @@ int amdgpu_fence_slab_init(void)
 
 void amdgpu_fence_slab_fini(void)
 {
+        rcu_barrier();
         kmem_cache_destroy(amdgpu_fence_slab);
 }
 /*
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
index 278708f5a744..9fa809876339 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
@@ -239,6 +239,7 @@ int amdgpu_irq_init(struct amdgpu_device *adev)
         if (r) {
                 adev->irq.installed = false;
                 flush_work(&adev->hotplug_work);
+                cancel_work_sync(&adev->reset_work);
                 return r;
         }
 
@@ -264,6 +265,7 @@ void amdgpu_irq_fini(struct amdgpu_device *adev)
                 if (adev->irq.msi_enabled)
                         pci_disable_msi(adev->pdev);
                 flush_work(&adev->hotplug_work);
+                cancel_work_sync(&adev->reset_work);
         }
 
         for (i = 0; i < AMDGPU_MAX_IRQ_SRC_ID; ++i) {
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
index 78392671046a..55c413a55a40 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
@@ -489,10 +489,8 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file
                 /* return all clocks in KHz */
                 dev_info.gpu_counter_freq = amdgpu_asic_get_xclk(adev) * 10;
                 if (adev->pm.dpm_enabled) {
-                        dev_info.max_engine_clock =
-                                adev->pm.dpm.dyn_state.max_clock_voltage_on_ac.sclk * 10;
-                        dev_info.max_memory_clock =
-                                adev->pm.dpm.dyn_state.max_clock_voltage_on_ac.mclk * 10;
+                        dev_info.max_engine_clock = amdgpu_dpm_get_sclk(adev, false) * 10;
+                        dev_info.max_memory_clock = amdgpu_dpm_get_mclk(adev, false) * 10;
                 } else {
                         dev_info.max_engine_clock = adev->pm.default_sclk * 10;
                         dev_info.max_memory_clock = adev->pm.default_mclk * 10;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index f0a0513ef4c2..1479d09bd4dd 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -766,6 +766,10 @@ static const char *amdgpu_vram_names[] = {
 
 int amdgpu_bo_init(struct amdgpu_device *adev)
 {
+        /* reserve PAT memory space to WC for VRAM */
+        arch_io_reserve_memtype_wc(adev->mc.aper_base,
+                                   adev->mc.aper_size);
+
         /* Add an MTRR for the VRAM */
         adev->mc.vram_mtrr = arch_phys_wc_add(adev->mc.aper_base,
                                               adev->mc.aper_size);
@@ -781,6 +785,7 @@ void amdgpu_bo_fini(struct amdgpu_device *adev)
 {
         amdgpu_ttm_fini(adev);
         arch_phys_wc_del(adev->mc.vram_mtrr);
+        arch_io_free_memtype_wc(adev->mc.aper_base, adev->mc.aper_size);
 }
 
 int amdgpu_bo_fbdev_mmap(struct amdgpu_bo *bo,
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index e480263387e1..337c5b31d18d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -1775,5 +1775,6 @@ void amdgpu_vm_manager_fini(struct amdgpu_device *adev)
                 dma_fence_put(adev->vm_manager.ids[i].first);
                 amdgpu_sync_free(&adev->vm_manager.ids[i].active);
                 dma_fence_put(id->flushed_updates);
+                dma_fence_put(id->last_flush);
         }
 }
diff --git a/drivers/gpu/drm/amd/amdgpu/ci_dpm.c b/drivers/gpu/drm/amd/amdgpu/ci_dpm.c
index e9b1964d4e61..1caff75ab9fc 100644
--- a/drivers/gpu/drm/amd/amdgpu/ci_dpm.c
+++ b/drivers/gpu/drm/amd/amdgpu/ci_dpm.c
@@ -4083,7 +4083,7 @@ static int ci_enable_uvd_dpm(struct amdgpu_device *adev, bool enable)
                                                           pi->dpm_level_enable_mask.mclk_dpm_enable_mask);
                 }
         } else {
-                if (pi->last_mclk_dpm_enable_mask & 0x1) {
+                if (pi->uvd_enabled) {
                         pi->uvd_enabled = false;
                         pi->dpm_level_enable_mask.mclk_dpm_enable_mask |= 1;
                         amdgpu_ci_send_msg_to_smc_with_parameter(adev,
@@ -6308,6 +6308,8 @@ static int ci_dpm_sw_fini(void *handle)
 {
         struct amdgpu_device *adev = (struct amdgpu_device *)handle;
 
+        flush_work(&adev->pm.dpm.thermal.work);
+
         mutex_lock(&adev->pm.mutex);
         amdgpu_pm_sysfs_fini(adev);
         ci_dpm_fini(adev);
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
index 199d3f7235d6..679dd7320279 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
@@ -3068,10 +3068,6 @@ static int dce_v10_0_hw_fini(void *handle)
 
 static int dce_v10_0_suspend(void *handle)
 {
-        struct amdgpu_device *adev = (struct amdgpu_device *)handle;
-
-        amdgpu_atombios_scratch_regs_save(adev);
-
         return dce_v10_0_hw_fini(handle);
 }
 
@@ -3082,8 +3078,6 @@ static int dce_v10_0_resume(void *handle)
 
         ret = dce_v10_0_hw_init(handle);
 
-        amdgpu_atombios_scratch_regs_restore(adev);
-
         /* turn on the BL */
         if (adev->mode_info.bl_encoder) {
                 u8 bl_level = amdgpu_display_backlight_get_level(adev,
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
index ecd000e35981..807dfedb3610 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
@@ -3132,10 +3132,6 @@ static int dce_v11_0_hw_fini(void *handle)
 
 static int dce_v11_0_suspend(void *handle)
 {
-        struct amdgpu_device *adev = (struct amdgpu_device *)handle;
-
-        amdgpu_atombios_scratch_regs_save(adev);
-
         return dce_v11_0_hw_fini(handle);
 }
 
@@ -3146,8 +3142,6 @@ static int dce_v11_0_resume(void *handle)
 
         ret = dce_v11_0_hw_init(handle);
 
-        amdgpu_atombios_scratch_regs_restore(adev);
-
         /* turn on the BL */
         if (adev->mode_info.bl_encoder) {
                 u8 bl_level = amdgpu_display_backlight_get_level(adev,
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
index 44547f951d92..57423332bf75 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
@@ -2403,10 +2403,6 @@ static int dce_v6_0_hw_fini(void *handle)
 
 static int dce_v6_0_suspend(void *handle)
 {
-        struct amdgpu_device *adev = (struct amdgpu_device *)handle;
-
-        amdgpu_atombios_scratch_regs_save(adev);
-
         return dce_v6_0_hw_fini(handle);
 }
 
@@ -2417,8 +2413,6 @@ static int dce_v6_0_resume(void *handle)
 
         ret = dce_v6_0_hw_init(handle);
 
-        amdgpu_atombios_scratch_regs_restore(adev);
-
         /* turn on the BL */
         if (adev->mode_info.bl_encoder) {
                 u8 bl_level = amdgpu_display_backlight_get_level(adev,
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
index 979aedf4b74d..6f7656d525e2 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
@@ -2913,10 +2913,6 @@ static int dce_v8_0_hw_fini(void *handle)
 
 static int dce_v8_0_suspend(void *handle)
 {
-        struct amdgpu_device *adev = (struct amdgpu_device *)handle;
-
-        amdgpu_atombios_scratch_regs_save(adev);
-
         return dce_v8_0_hw_fini(handle);
 }
 
@@ -2927,8 +2923,6 @@ static int dce_v8_0_resume(void *handle)
 
         ret = dce_v8_0_hw_init(handle);
 
-        amdgpu_atombios_scratch_regs_restore(adev);
-
         /* turn on the BL */
         if (adev->mode_info.bl_encoder) {
                 u8 bl_level = amdgpu_display_backlight_get_level(adev,
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index 86a7ca5d8511..23f1bc94ad3e 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
@@ -640,7 +640,6 @@ static const u32 stoney_mgcg_cgcg_init[] =
         mmCP_MEM_SLP_CNTL, 0xffffffff, 0x00020201,
         mmRLC_MEM_SLP_CNTL, 0xffffffff, 0x00020201,
         mmCGTS_SM_CTRL_REG, 0xffffffff, 0x96940200,
-        mmATC_MISC_CG, 0xffffffff, 0x000c0200,
 };
 
 static void gfx_v8_0_set_ring_funcs(struct amdgpu_device *adev);
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
index 74d7cc3f7e8c..f7372d32b8e7 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
@@ -100,6 +100,7 @@ static const u32 cz_mgcg_cgcg_init[] =
 
 static const u32 stoney_mgcg_cgcg_init[] =
 {
+        mmATC_MISC_CG, 0xffffffff, 0x000c0200,
         mmMC_MEM_POWER_LS, 0xffffffff, 0x00000104
 };
 
diff --git a/drivers/gpu/drm/amd/amdgpu/kv_dpm.c b/drivers/gpu/drm/amd/amdgpu/kv_dpm.c
index b6f2e50636a9..61172d4a0657 100644
--- a/drivers/gpu/drm/amd/amdgpu/kv_dpm.c
+++ b/drivers/gpu/drm/amd/amdgpu/kv_dpm.c
@@ -3063,6 +3063,8 @@ static int kv_dpm_sw_fini(void *handle)
 {
         struct amdgpu_device *adev = (struct amdgpu_device *)handle;
 
+        flush_work(&adev->pm.dpm.thermal.work);
+
         mutex_lock(&adev->pm.mutex);
         amdgpu_pm_sysfs_fini(adev);
         kv_dpm_fini(adev);
diff --git a/drivers/gpu/drm/amd/amdgpu/si_dpm.c b/drivers/gpu/drm/amd/amdgpu/si_dpm.c
index 917213396787..f0f2f6c9718e 100644
--- a/drivers/gpu/drm/amd/amdgpu/si_dpm.c
+++ b/drivers/gpu/drm/amd/amdgpu/si_dpm.c
@@ -3479,6 +3479,49 @@ static void si_apply_state_adjust_rules(struct amdgpu_device *adev,
         int i;
         struct si_dpm_quirk *p = si_dpm_quirk_list;
 
+        /* limit all SI kickers */
+        if (adev->asic_type == CHIP_PITCAIRN) {
+                if ((adev->pdev->revision == 0x81) ||
+                    (adev->pdev->device == 0x6810) ||
+                    (adev->pdev->device == 0x6811) ||
+                    (adev->pdev->device == 0x6816) ||
+                    (adev->pdev->device == 0x6817) ||
+                    (adev->pdev->device == 0x6806))
+                        max_mclk = 120000;
+        } else if (adev->asic_type == CHIP_VERDE) {
+                if ((adev->pdev->revision == 0x81) ||
+                    (adev->pdev->revision == 0x83) ||
+                    (adev->pdev->revision == 0x87) ||
+                    (adev->pdev->device == 0x6820) ||
+                    (adev->pdev->device == 0x6821) ||
+                    (adev->pdev->device == 0x6822) ||
+                    (adev->pdev->device == 0x6823) ||
+                    (adev->pdev->device == 0x682A) ||
+                    (adev->pdev->device == 0x682B)) {
+                        max_sclk = 75000;
+                        max_mclk = 80000;
+                }
+        } else if (adev->asic_type == CHIP_OLAND) {
+                if ((adev->pdev->revision == 0xC7) ||
+                    (adev->pdev->revision == 0x80) ||
+                    (adev->pdev->revision == 0x81) ||
+                    (adev->pdev->revision == 0x83) ||
+                    (adev->pdev->device == 0x6604) ||
+                    (adev->pdev->device == 0x6605)) {
+                        max_sclk = 75000;
+                        max_mclk = 80000;
+                }
+        } else if (adev->asic_type == CHIP_HAINAN) {
+                if ((adev->pdev->revision == 0x81) ||
+                    (adev->pdev->revision == 0x83) ||
+                    (adev->pdev->revision == 0xC3) ||
+                    (adev->pdev->device == 0x6664) ||
+                    (adev->pdev->device == 0x6665) ||
+                    (adev->pdev->device == 0x6667)) {
+                        max_sclk = 75000;
+                        max_mclk = 80000;
+                }
+        }
         /* Apply dpm quirks */
         while (p && p->chip_device != 0) {
                 if (adev->pdev->vendor == p->chip_vendor &&
@@ -3491,22 +3534,6 @@ static void si_apply_state_adjust_rules(struct amdgpu_device *adev,
                 }
                 ++p;
         }
-        /* limit mclk on all R7 370 parts for stability */
-        if (adev->pdev->device == 0x6811 &&
-            adev->pdev->revision == 0x81)
-                max_mclk = 120000;
-        /* limit sclk/mclk on Jet parts for stability */
-        if (adev->pdev->device == 0x6665 &&
-            adev->pdev->revision == 0xc3) {
-                max_sclk = 75000;
-                max_mclk = 80000;
-        }
-        /* Limit clocks for some HD8600 parts */
-        if (adev->pdev->device == 0x6660 &&
-            adev->pdev->revision == 0x83) {
-                max_sclk = 75000;
-                max_mclk = 80000;
-        }
 
         if (rps->vce_active) {
                 rps->evclk = adev->pm.dpm.vce_states[adev->pm.dpm.vce_level].evclk;
@@ -7779,6 +7806,8 @@ static int si_dpm_sw_fini(void *handle)
 {
         struct amdgpu_device *adev = (struct amdgpu_device *)handle;
 
+        flush_work(&adev->pm.dpm.thermal.work);
+
         mutex_lock(&adev->pm.mutex);
         amdgpu_pm_sysfs_fini(adev);
         si_dpm_fini(adev);
diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
index 5ed2930a8568..39f03f137a56 100644
--- a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
@@ -52,6 +52,8 @@
 #define VCE_V3_0_STACK_SIZE     (64 * 1024)
 #define VCE_V3_0_DATA_SIZE      ((16 * 1024 * AMDGPU_MAX_VCE_HANDLES) + (52 * 1024))
 
+#define FW_52_8_3       ((52 << 24) | (8 << 16) | (3 << 8))
+
 static void vce_v3_0_mc_resume(struct amdgpu_device *adev, int idx);
 static void vce_v3_0_set_ring_funcs(struct amdgpu_device *adev);
 static void vce_v3_0_set_irq_funcs(struct amdgpu_device *adev);
@@ -382,6 +384,10 @@ static int vce_v3_0_sw_init(void *handle)
         if (r)
                 return r;
 
+        /* 52.8.3 required for 3 ring support */
+        if (adev->vce.fw_version < FW_52_8_3)
+                adev->vce.num_rings = 2;
+
         r = amdgpu_vce_resume(adev);
         if (r)
                 return r;
diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
index 25c0a71b257d..52d0a83e6ad1 100644
--- a/drivers/gpu/drm/amd/amdgpu/vi.c
+++ b/drivers/gpu/drm/amd/amdgpu/vi.c
@@ -988,7 +988,7 @@ static int vi_common_early_init(void *handle)
                         AMD_CG_SUPPORT_SDMA_MGCG |
                         AMD_CG_SUPPORT_SDMA_LS |
                         AMD_CG_SUPPORT_VCE_MGCG;
-                adev->pg_flags |= AMD_PG_SUPPORT_GFX_PG |
+                adev->pg_flags = AMD_PG_SUPPORT_GFX_PG |
                         AMD_PG_SUPPORT_GFX_SMG |
                         AMD_PG_SUPPORT_GFX_PIPELINE |
                         AMD_PG_SUPPORT_UVD |
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
index 1167205057b3..2ba7937d2545 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
@@ -716,7 +716,7 @@ int phm_get_voltage_evv_on_sclk(struct pp_hwmgr *hwmgr, uint8_t voltage_type,
                         *voltage = 1150;
         } else {
                 ret = atomctrl_get_voltage_evv_on_sclk_ai(hwmgr, voltage_type, sclk, id, &vol);
-                *voltage = (uint16_t)vol/100;
+                *voltage = (uint16_t)(vol/100);
         }
         return ret;
 }
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c b/drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c
index 1126bd4f74dc..0894527d932f 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c
@@ -1320,7 +1320,8 @@ int atomctrl_get_voltage_evv_on_sclk_ai(struct pp_hwmgr *hwmgr, uint8_t voltage_
         if (0 != result)
                 return result;
 
-        *voltage = le32_to_cpu(((GET_EVV_VOLTAGE_INFO_OUTPUT_PARAMETER_V1_3 *)(&get_voltage_info_param_space))->ulVoltageLevel);
+        *voltage = le32_to_cpu(((GET_EVV_VOLTAGE_INFO_OUTPUT_PARAMETER_V1_3 *)
+                                (&get_voltage_info_param_space))->ulVoltageLevel);
 
         return result;
 }
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/process_pptables_v1_0.c b/drivers/gpu/drm/amd/powerplay/hwmgr/process_pptables_v1_0.c
index baf0f3d4c2f0..c45bd2560468 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/process_pptables_v1_0.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/process_pptables_v1_0.c
@@ -1201,12 +1201,15 @@ static uint32_t make_classification_flags(struct pp_hwmgr *hwmgr,
 static int ppt_get_num_of_vce_state_table_entries_v1_0(struct pp_hwmgr *hwmgr)
 {
         const ATOM_Tonga_POWERPLAYTABLE *pp_table = get_powerplay_table(hwmgr);
-        const ATOM_Tonga_VCE_State_Table *vce_state_table =
-                                (ATOM_Tonga_VCE_State_Table *)(((unsigned long)pp_table) + le16_to_cpu(pp_table->usVCEStateTableOffset));
+        const ATOM_Tonga_VCE_State_Table *vce_state_table;
 
-        if (vce_state_table == NULL)
+
+        if (pp_table == NULL)
                 return 0;
 
+        vce_state_table = (void *)pp_table +
+                        le16_to_cpu(pp_table->usVCEStateTableOffset);
+
         return vce_state_table->ucNumEntries;
 }
 
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
index 073e0bfa22a0..9e49f2777143 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
@@ -1168,8 +1168,8 @@ static int smu7_enable_dpm_tasks(struct pp_hwmgr *hwmgr)
 
         tmp_result = (!smum_is_dpm_running(hwmgr)) ? 0 : -1;
         PP_ASSERT_WITH_CODE(tmp_result == 0,
-                        "DPM is already running right now, no need to enable DPM!",
-                        return 0);
+                        "DPM is already running",
+                        );
 
         if (smu7_voltage_control(hwmgr)) {
                 tmp_result = smu7_enable_voltage_control(hwmgr);
@@ -2141,15 +2141,18 @@ static int smu7_patch_acp_vddc(struct pp_hwmgr *hwmgr,
 }
 
 static int smu7_patch_limits_vddc(struct pp_hwmgr *hwmgr,
-                                     struct phm_clock_and_voltage_limits *tab)
+                                  struct phm_clock_and_voltage_limits *tab)
 {
+        uint32_t vddc, vddci;
         struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);
 
         if (tab) {
-                smu7_patch_ppt_v0_with_vdd_leakage(hwmgr, (uint32_t *)&tab->vddc,
-                                                        &data->vddc_leakage);
-                smu7_patch_ppt_v0_with_vdd_leakage(hwmgr, (uint32_t *)&tab->vddci,
-                                                        &data->vddci_leakage);
+                smu7_patch_ppt_v0_with_vdd_leakage(hwmgr, &vddc,
+                                                   &data->vddc_leakage);
+                tab->vddc = vddc;
+                smu7_patch_ppt_v0_with_vdd_leakage(hwmgr, &vddci,
+                                                   &data->vddci_leakage);
+                tab->vddci = vddci;
         }
 
         return 0;
diff --git a/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c b/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
index 5364e6a7ec8f..09b2cf6ccfa4 100644
--- a/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
+++ b/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
@@ -646,6 +646,7 @@ void amd_sched_fini(struct amd_gpu_scheduler *sched)
 {
         if (sched->thread)
                 kthread_stop(sched->thread);
+        rcu_barrier();
         if (atomic_dec_and_test(&sched_fence_slab_ref))
                 kmem_cache_destroy(sched_fence_slab);
 }
diff --git a/drivers/gpu/drm/amd/scheduler/sched_fence.c b/drivers/gpu/drm/amd/scheduler/sched_fence.c
index c26fa298fe9e..91530e25aaff 100644
--- a/drivers/gpu/drm/amd/scheduler/sched_fence.c
+++ b/drivers/gpu/drm/amd/scheduler/sched_fence.c
@@ -107,7 +107,7 @@ static void amd_sched_fence_free(struct rcu_head *rcu)
 }
 
 /**
- * amd_sched_fence_release - callback that fence can be freed
+ * amd_sched_fence_release_scheduled - callback that fence can be freed
  *
  * @fence: fence
  *
@@ -122,7 +122,7 @@ static void amd_sched_fence_release_scheduled(struct dma_fence *f)
 }
 
 /**
- * amd_sched_fence_release_scheduled - drop extra reference
+ * amd_sched_fence_release_finished - drop extra reference
  *
  * @f: fence
  *
diff --git a/drivers/gpu/drm/ast/ast_ttm.c b/drivers/gpu/drm/ast/ast_ttm.c
index 7134fdf49210..2a1368fac1d1 100644
--- a/drivers/gpu/drm/ast/ast_ttm.c
+++ b/drivers/gpu/drm/ast/ast_ttm.c
@@ -268,6 +268,8 @@ int ast_mm_init(struct ast_private *ast)
                 return ret;
         }
 
+        arch_io_reserve_memtype_wc(pci_resource_start(dev->pdev, 0),
+                                   pci_resource_len(dev->pdev, 0));
         ast->fb_mtrr = arch_phys_wc_add(pci_resource_start(dev->pdev, 0),
                                         pci_resource_len(dev->pdev, 0));
 
@@ -276,11 +278,15 @@ int ast_mm_init(struct ast_private *ast)
 
 void ast_mm_fini(struct ast_private *ast)
 {
+        struct drm_device *dev = ast->dev;
+
         ttm_bo_device_release(&ast->ttm.bdev);
 
         ast_ttm_global_release(ast);
 
         arch_phys_wc_del(ast->fb_mtrr);
+        arch_io_free_memtype_wc(pci_resource_start(dev->pdev, 0),
+                                pci_resource_len(dev->pdev, 0));
 }
 
 void ast_ttm_placement(struct ast_bo *bo, int domain)
diff --git a/drivers/gpu/drm/cirrus/cirrus_ttm.c b/drivers/gpu/drm/cirrus/cirrus_ttm.c
index de52b20800e1..d6da848f7c6f 100644
--- a/drivers/gpu/drm/cirrus/cirrus_ttm.c
+++ b/drivers/gpu/drm/cirrus/cirrus_ttm.c
@@ -268,6 +268,9 @@ int cirrus_mm_init(struct cirrus_device *cirrus)
                 return ret;
         }
 
+        arch_io_reserve_memtype_wc(pci_resource_start(dev->pdev, 0),
+                                   pci_resource_len(dev->pdev, 0));
+
         cirrus->fb_mtrr = arch_phys_wc_add(pci_resource_start(dev->pdev, 0),
                                            pci_resource_len(dev->pdev, 0));
 
@@ -277,6 +280,8 @@ int cirrus_mm_init(struct cirrus_device *cirrus)
 
 void cirrus_mm_fini(struct cirrus_device *cirrus)
 {
+        struct drm_device *dev = cirrus->dev;
+
         if (!cirrus->mm_inited)
                 return;
 
@@ -286,6 +291,8 @@ void cirrus_mm_fini(struct cirrus_device *cirrus)
 
         arch_phys_wc_del(cirrus->fb_mtrr);
         cirrus->fb_mtrr = 0;
+        arch_io_free_memtype_wc(pci_resource_start(dev->pdev, 0),
+                                pci_resource_len(dev->pdev, 0));
 }
 
 void cirrus_ttm_placement(struct cirrus_bo *bo, int domain)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index c32fb3c1d6f0..1d6ab371cd52 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -416,18 +416,21 @@ drm_atomic_replace_property_blob_from_id(struct drm_crtc *crtc,
                                          ssize_t expected_size,
                                          bool *replaced)
 {
-        struct drm_device *dev = crtc->dev;
         struct drm_property_blob *new_blob = NULL;
 
         if (blob_id != 0) {
-                new_blob = drm_property_lookup_blob(dev, blob_id);
+                new_blob = drm_property_lookup_blob(crtc->dev, blob_id);
                 if (new_blob == NULL)
                         return -EINVAL;
-                if (expected_size > 0 && expected_size != new_blob->length)
+
+                if (expected_size > 0 && expected_size != new_blob->length) {
+                        drm_property_unreference_blob(new_blob);
                         return -EINVAL;
+                }
         }
 
         drm_atomic_replace_property_blob(blob, new_blob, replaced);
+        drm_property_unreference_blob(new_blob);
 
         return 0;
 }
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
index 75ad01d595fd..50077961228a 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -595,10 +595,6 @@ drm_atomic_helper_check_planes(struct drm_device *dev,
         struct drm_plane_state *plane_state;
         int i, ret = 0;
 
-        ret = drm_atomic_normalize_zpos(dev, state);
-        if (ret)
-                return ret;
-
         for_each_plane_in_state(state, plane, plane_state, i) {
                 const struct drm_plane_helper_funcs *funcs;
 
diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index 04e457117980..aa644487749c 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -914,6 +914,7 @@ static void drm_dp_destroy_port(struct kref *kref)
                 /* no need to clean up vcpi
                  * as if we have no connector we never setup a vcpi */
                 drm_dp_port_teardown_pdt(port, port->pdt);
+                port->pdt = DP_PEER_DEVICE_NONE;
         }
         kfree(port);
 }
@@ -1159,7 +1160,9 @@ static void drm_dp_add_port(struct drm_dp_mst_branch *mstb,
                         drm_dp_put_port(port);
                         goto out;
                 }
-                if (port->port_num >= DP_MST_LOGICAL_PORT_0) {
+                if ((port->pdt == DP_PEER_DEVICE_DP_LEGACY_CONV ||
+                     port->pdt == DP_PEER_DEVICE_SST_SINK) &&
+                    port->port_num >= DP_MST_LOGICAL_PORT_0) {
                         port->cached_edid = drm_get_edid(port->connector, &port->aux.ddc);
                         drm_mode_connector_set_tile_property(port->connector);
                 }
@@ -2919,6 +2922,7 @@ static void drm_dp_destroy_connector_work(struct work_struct *work)
                 mgr->cbs->destroy_connector(mgr, port->connector);
 
                 drm_dp_port_teardown_pdt(port, port->pdt);
+                port->pdt = DP_PEER_DEVICE_NONE;
 
                 if (!port->input && port->vcpi.vcpi > 0) {
                         drm_dp_mst_reset_vcpi_slots(mgr, port);
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 83dbae0fabcf..36797c465edc 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -131,7 +131,12 @@ int drm_fb_helper_single_add_all_connectors(struct drm_fb_helper *fb_helper)
         return 0;
 fail:
         for (i = 0; i < fb_helper->connector_count; i++) {
-                kfree(fb_helper->connector_info[i]);
+                struct drm_fb_helper_connector *fb_helper_connector =
+                        fb_helper->connector_info[i];
+
+                drm_connector_unreference(fb_helper_connector->connector);
+
+                kfree(fb_helper_connector);
                 fb_helper->connector_info[i] = NULL;
         }
         fb_helper->connector_count = 0;
@@ -600,6 +605,24 @@ int drm_fb_helper_blank(int blank, struct fb_info *info)
 }
 EXPORT_SYMBOL(drm_fb_helper_blank);
 
+static void drm_fb_helper_modeset_release(struct drm_fb_helper *helper,
+                                          struct drm_mode_set *modeset)
+{
+        int i;
+
+        for (i = 0; i < modeset->num_connectors; i++) {
+                drm_connector_unreference(modeset->connectors[i]);
+                modeset->connectors[i] = NULL;
+        }
+        modeset->num_connectors = 0;
+
+        drm_mode_destroy(helper->dev, modeset->mode);
+        modeset->mode = NULL;
+
+        /* FIXME should hold a ref? */
+        modeset->fb = NULL;
+}
+
 static void drm_fb_helper_crtc_free(struct drm_fb_helper *helper)
 {
         int i;
@@ -609,10 +632,12 @@ static void drm_fb_helper_crtc_free(struct drm_fb_helper *helper)
                 kfree(helper->connector_info[i]);
         }
         kfree(helper->connector_info);
+
         for (i = 0; i < helper->crtc_count; i++) {
-                kfree(helper->crtc_info[i].mode_set.connectors);
-                if (helper->crtc_info[i].mode_set.mode)
-                        drm_mode_destroy(helper->dev, helper->crtc_info[i].mode_set.mode);
+                struct drm_mode_set *modeset = &helper->crtc_info[i].mode_set;
+
+                drm_fb_helper_modeset_release(helper, modeset);
+                kfree(modeset->connectors);
         }
         kfree(helper->crtc_info);
 }
@@ -641,7 +666,9 @@ static void drm_fb_helper_dirty_work(struct work_struct *work)
         clip->x2 = clip->y2 = 0;
         spin_unlock_irqrestore(&helper->dirty_lock, flags);
 
-        helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, &clip_copy, 1);
+        /* call dirty callback only when it has been really touched */
+        if (clip_copy.x1 < clip_copy.x2 && clip_copy.y1 < clip_copy.y2)
+                helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, &clip_copy, 1);
 }
 
 /**
@@ -2085,7 +2112,6 @@ static void drm_setup_crtcs(struct drm_fb_helper *fb_helper)
         struct drm_fb_helper_crtc **crtcs;
         struct drm_display_mode **modes;
         struct drm_fb_offset *offsets;
-        struct drm_mode_set *modeset;
         bool *enabled;
         int width, height;
         int i;
@@ -2133,45 +2159,35 @@ static void drm_setup_crtcs(struct drm_fb_helper *fb_helper)
 
         /* need to set the modesets up here for use later */
         /* fill out the connector<->crtc mappings into the modesets */
-        for (i = 0; i < fb_helper->crtc_count; i++) {
-                modeset = &fb_helper->crtc_info[i].mode_set;
-                modeset->num_connectors = 0;
-                modeset->fb = NULL;
-        }
+        for (i = 0; i < fb_helper->crtc_count; i++)
+                drm_fb_helper_modeset_release(fb_helper,
+                                              &fb_helper->crtc_info[i].mode_set);
 
         for (i = 0; i < fb_helper->connector_count; i++) {
                 struct drm_display_mode *mode = modes[i];
                 struct drm_fb_helper_crtc *fb_crtc = crtcs[i];
                 struct drm_fb_offset *offset = &offsets[i];
-                modeset = &fb_crtc->mode_set;
+                struct drm_mode_set *modeset = &fb_crtc->mode_set;
 
                 if (mode && fb_crtc) {
+                        struct drm_connector *connector =
+                                fb_helper->connector_info[i]->connector;
+
                         DRM_DEBUG_KMS("desired mode %s set on crtc %d (%d,%d)\n",
                                       mode->name, fb_crtc->mode_set.crtc->base.id, offset->x, offset->y);
+
                         fb_crtc->desired_mode = mode;
                         fb_crtc->x = offset->x;
                         fb_crtc->y = offset->y;
-                        if (modeset->mode)
-                                drm_mode_destroy(dev, modeset->mode);
                         modeset->mode = drm_mode_duplicate(dev,
                                                            fb_crtc->desired_mode);
-                        modeset->connectors[modeset->num_connectors++] = fb_helper->connector_info[i]->connector;
+                        drm_connector_reference(connector);
+                        modeset->connectors[modeset->num_connectors++] = connector;
                         modeset->fb = fb_helper->fb;
                         modeset->x = offset->x;
                         modeset->y = offset->y;
                 }
         }
-
-        /* Clear out any old modes if there are no more connected outputs. */
-        for (i = 0; i < fb_helper->crtc_count; i++) {
-                modeset = &fb_helper->crtc_info[i].mode_set;
-                if (modeset->num_connectors == 0) {
-                        BUG_ON(modeset->fb);
-                        if (modeset->mode)
-                                drm_mode_destroy(dev, modeset->mode);
-                        modeset->mode = NULL;
-                }
-        }
 out:
         kfree(crtcs);
         kfree(modes);
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index 4a21a745c373..463d6fd56756 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -263,6 +263,26 @@ int exynos_atomic_commit(struct drm_device *dev, struct drm_atomic_state *state,
         return 0;
 }
 
+int exynos_atomic_check(struct drm_device *dev,
+                        struct drm_atomic_state *state)
+{
+        int ret;
+
+        ret = drm_atomic_helper_check_modeset(dev, state);
+        if (ret)
+                return ret;
+
+        ret = drm_atomic_normalize_zpos(dev, state);
+        if (ret)
+                return ret;
+
+        ret = drm_atomic_helper_check_planes(dev, state);
+        if (ret)
+                return ret;
+
+        return ret;
+}
+
 static int exynos_drm_open(struct drm_device *dev, struct drm_file *file)
 {
         struct drm_exynos_file_private *file_priv;
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h
index d215149e737b..80c4d5b81689 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.h
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h
@@ -301,6 +301,7 @@ static inline int exynos_dpi_bind(struct drm_device *dev,
 
 int exynos_atomic_commit(struct drm_device *dev, struct drm_atomic_state *state,
                          bool nonblock);
+int exynos_atomic_check(struct drm_device *dev, struct drm_atomic_state *state);
 
 
 extern struct platform_driver fimd_driver;
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c
index 40ce841eb952..23cce0a3f5fc 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fb.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c
@@ -190,7 +190,7 @@ dma_addr_t exynos_drm_fb_dma_addr(struct drm_framebuffer *fb, int index)
 static const struct drm_mode_config_funcs exynos_drm_mode_config_funcs = {
         .fb_create = exynos_user_fb_create,
         .output_poll_changed = exynos_drm_output_poll_changed,
-        .atomic_check = drm_atomic_helper_check,
+        .atomic_check = exynos_atomic_check,
         .atomic_commit = exynos_atomic_commit,
 };
 
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
index 98df09c2b388..9672b579f950 100644
--- a/drivers/gpu/drm/imx/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/imx-drm-core.c
@@ -357,8 +357,8 @@ static int imx_drm_bind(struct device *dev)
         int ret;
 
         drm = drm_dev_alloc(&imx_drm_driver, dev);
-        if (!drm)
-                return -ENOMEM;
+        if (IS_ERR(drm))
+                return PTR_ERR(drm);
 
         imxdrm = devm_kzalloc(dev, sizeof(*imxdrm), GFP_KERNEL);
         if (!imxdrm) {
@@ -436,9 +436,11 @@ static int imx_drm_bind(struct device *dev)
 
 err_fbhelper:
         drm_kms_helper_poll_fini(drm);
+#if IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION)
         if (imxdrm->fbhelper)
                 drm_fbdev_cma_fini(imxdrm->fbhelper);
 err_unbind:
+#endif
         component_unbind_all(drm->dev, drm);
 err_vblank:
         drm_vblank_cleanup(drm);
diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c
index ce22d0a0ddc8..d5864ed4d772 100644
--- a/drivers/gpu/drm/imx/ipuv3-plane.c
+++ b/drivers/gpu/drm/imx/ipuv3-plane.c
@@ -103,11 +103,11 @@ drm_plane_state_to_vbo(struct drm_plane_state *state)
                (state->src_x >> 16) / 2 - eba;
 }
 
-static void ipu_plane_atomic_set_base(struct ipu_plane *ipu_plane,
-                                      struct drm_plane_state *old_state)
+static void ipu_plane_atomic_set_base(struct ipu_plane *ipu_plane)
 {
         struct drm_plane *plane = &ipu_plane->base;
         struct drm_plane_state *state = plane->state;
+        struct drm_crtc_state *crtc_state = state->crtc->state;
         struct drm_framebuffer *fb = state->fb;
         unsigned long eba, ubo, vbo;
         int active;
@@ -117,7 +117,7 @@ static void ipu_plane_atomic_set_base(struct ipu_plane *ipu_plane,
         switch (fb->pixel_format) {
         case DRM_FORMAT_YUV420:
         case DRM_FORMAT_YVU420:
-                if (old_state->fb)
+                if (!drm_atomic_crtc_needs_modeset(crtc_state))
                         break;
 
                 /*
@@ -149,7 +149,7 @@ static void ipu_plane_atomic_set_base(struct ipu_plane *ipu_plane,
                 break;
         }
 
-        if (old_state->fb) {
+        if (!drm_atomic_crtc_needs_modeset(crtc_state)) {
                 active = ipu_idmac_get_current_buffer(ipu_plane->ipu_ch);
                 ipu_cpmem_set_buffer(ipu_plane->ipu_ch, !active, eba);
                 ipu_idmac_select_buffer(ipu_plane->ipu_ch, !active);
@@ -259,6 +259,7 @@ static int ipu_plane_atomic_check(struct drm_plane *plane,
         struct drm_framebuffer *fb = state->fb;
         struct drm_framebuffer *old_fb = old_state->fb;
         unsigned long eba, ubo, vbo, old_ubo, old_vbo;
+        int hsub, vsub;
 
         /* Ok to disable */
         if (!fb)
@@ -355,7 +356,9 @@ static int ipu_plane_atomic_check(struct drm_plane *plane,
                 if ((ubo > 0xfffff8) || (vbo > 0xfffff8))
                         return -EINVAL;
 
-                if (old_fb) {
+                if (old_fb &&
+                    (old_fb->pixel_format == DRM_FORMAT_YUV420 ||
+                     old_fb->pixel_format == DRM_FORMAT_YVU420)) {
                         old_ubo = drm_plane_state_to_ubo(old_state);
                         old_vbo = drm_plane_state_to_vbo(old_state);
                         if (ubo != old_ubo || vbo != old_vbo)
@@ -370,6 +373,16 @@ static int ipu_plane_atomic_check(struct drm_plane *plane,
 
                 if (old_fb && old_fb->pitches[1] != fb->pitches[1])
                         crtc_state->mode_changed = true;
+
+                /*
+                 * The x/y offsets must be even in case of horizontal/vertical
+                 * chroma subsampling.
+                 */
+                hsub = drm_format_horz_chroma_subsampling(fb->pixel_format);
+                vsub = drm_format_vert_chroma_subsampling(fb->pixel_format);
+                if (((state->src_x >> 16) & (hsub - 1)) ||
+                    ((state->src_y >> 16) & (vsub - 1)))
+                        return -EINVAL;
         }
 
         return 0;
@@ -392,7 +405,7 @@ static void ipu_plane_atomic_update(struct drm_plane *plane,
                 struct drm_crtc_state *crtc_state = state->crtc->state;
 
                 if (!drm_atomic_crtc_needs_modeset(crtc_state)) {
-                        ipu_plane_atomic_set_base(ipu_plane, old_state);
+                        ipu_plane_atomic_set_base(ipu_plane);
                         return;
                 }
         }
@@ -424,6 +437,7 @@ static void ipu_plane_atomic_update(struct drm_plane *plane,
                         ipu_dp_set_global_alpha(ipu_plane->dp, false, 0, false);
                         break;
                 default:
+                        ipu_dp_set_global_alpha(ipu_plane->dp, true, 0, true);
                         break;
                 }
         }
@@ -437,7 +451,7 @@ static void ipu_plane_atomic_update(struct drm_plane *plane,
         ipu_cpmem_set_high_priority(ipu_plane->ipu_ch);
         ipu_idmac_set_double_buffer(ipu_plane->ipu_ch, 1);
         ipu_cpmem_set_stride(ipu_plane->ipu_ch, state->fb->pitches[0]);
-        ipu_plane_atomic_set_base(ipu_plane, old_state);
+        ipu_plane_atomic_set_base(ipu_plane);
         ipu_plane_enable(ipu_plane);
 }
 
diff --git a/drivers/gpu/drm/mgag200/mgag200_ttm.c b/drivers/gpu/drm/mgag200/mgag200_ttm.c
index 83272b456329..5e20220ef4c6 100644
--- a/drivers/gpu/drm/mgag200/mgag200_ttm.c
+++ b/drivers/gpu/drm/mgag200/mgag200_ttm.c
@@ -267,6 +267,9 @@ int mgag200_mm_init(struct mga_device *mdev)
                 return ret;
         }
 
+        arch_io_reserve_memtype_wc(pci_resource_start(dev->pdev, 0),
+                                   pci_resource_len(dev->pdev, 0));
+
         mdev->fb_mtrr = arch_phys_wc_add(pci_resource_start(dev->pdev, 0),
                                          pci_resource_len(dev->pdev, 0));
 
@@ -275,10 +278,14 @@ int mgag200_mm_init(struct mga_device *mdev)
 
 void mgag200_mm_fini(struct mga_device *mdev)
 {
+        struct drm_device *dev = mdev->dev;
+
         ttm_bo_device_release(&mdev->ttm.bdev);
 
         mgag200_ttm_global_release(mdev);
 
+        arch_io_free_memtype_wc(pci_resource_start(dev->pdev, 0),
+                                pci_resource_len(dev->pdev, 0));
         arch_phys_wc_del(mdev->fb_mtrr);
         mdev->fb_mtrr = 0;
 }
diff --git a/drivers/gpu/drm/nouveau/dispnv04/overlay.c b/drivers/gpu/drm/nouveau/dispnv04/overlay.c
index ec444eac6258..a79514d440b3 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/overlay.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/overlay.c
@@ -33,7 +33,7 @@
 #include "nouveau_connector.h"
 #include "nouveau_display.h"
 #include "nvreg.h"
-
+#include "disp.h"
 
 struct nouveau_plane {
         struct drm_plane base;
diff --git a/drivers/gpu/drm/nouveau/include/nvif/cl5070.h b/drivers/gpu/drm/nouveau/include/nvif/cl5070.h
index d15c296b5f33..ae49dfd1f97b 100644
--- a/drivers/gpu/drm/nouveau/include/nvif/cl5070.h
+++ b/drivers/gpu/drm/nouveau/include/nvif/cl5070.h
@@ -34,6 +34,8 @@ struct nv50_disp_mthd_v1 {
 #define NV50_DISP_MTHD_V1_SOR_HDMI_PWR                                     0x22
 #define NV50_DISP_MTHD_V1_SOR_LVDS_SCRIPT                                  0x23
 #define NV50_DISP_MTHD_V1_SOR_DP_PWR                                       0x24
+#define NV50_DISP_MTHD_V1_SOR_DP_MST_LINK                                  0x25
+#define NV50_DISP_MTHD_V1_SOR_DP_MST_VCPI                                  0x26
 #define NV50_DISP_MTHD_V1_PIOR_PWR                                         0x30
         __u8  method;
         __u16 hasht;
@@ -90,6 +92,21 @@ struct nv50_disp_sor_dp_pwr_v0 {
         __u8  pad02[6];
 };
 
+struct nv50_disp_sor_dp_mst_link_v0 {
+        __u8  version;
+        __u8  state;
+        __u8  pad02[6];
+};
+
+struct nv50_disp_sor_dp_mst_vcpi_v0 {
+        __u8  version;
+        __u8  pad01[1];
+        __u8  start_slot;
+        __u8  num_slots;
+        __u16 pbn;
+        __u16 aligned_pbn;
+};
+
 struct nv50_disp_pior_pwr_v0 {
         __u8  version;
         __u8  state;
diff --git a/drivers/gpu/drm/nouveau/include/nvif/object.h b/drivers/gpu/drm/nouveau/include/nvif/object.h
index 8d815967767f..9e58b305b020 100644
--- a/drivers/gpu/drm/nouveau/include/nvif/object.h
+++ b/drivers/gpu/drm/nouveau/include/nvif/object.h
@@ -66,6 +66,35 @@ void nvif_object_unmap(struct nvif_object *);
 
 #define nvif_mthd(a,b,c,d) nvif_object_mthd((a), (b), (c), (d))
 
+struct nvif_mclass {
+        s32 oclass;
+        int version;
+};
+
+#define nvif_mclass(o,m) ({                                                    \
+        struct nvif_object *object = (o);                                      \
+        struct nvif_sclass *sclass;                                            \
+        const typeof(m[0]) *mclass = (m);                                      \
+        int ret = -ENODEV;                                                     \
+        int cnt, i, j;                                                         \
+                                                                               \
+        cnt = nvif_object_sclass_get(object, &sclass);                         \
+        if (cnt >= 0) {                                                        \
+                for (i = 0; ret < 0 && mclass[i].oclass; i++) {                \
+                        for (j = 0; j < cnt; j++) {                            \
+                                if (mclass[i].oclass  == sclass[j].oclass &&   \
+                                    mclass[i].version >= sclass[j].minver &&   \
+                                    mclass[i].version <= sclass[j].maxver) {   \
+                                        ret = i;                               \
+                                        break;                                 \
+                                }                                              \
+                        }                                                      \
+                }                                                              \
+                nvif_object_sclass_put(&sclass);                               \
+        }                                                                      \
+        ret;                                                                   \
+})
+
 /*XXX*/
 #include <core/object.h>
 #define nvxx_object(a) ({                                                      \
diff --git a/drivers/gpu/drm/nouveau/include/nvkm/subdev/fb.h b/drivers/gpu/drm/nouveau/include/nvkm/subdev/fb.h
index 3a410275fa71..65ce79a85d37 100644
--- a/drivers/gpu/drm/nouveau/include/nvkm/subdev/fb.h
+++ b/drivers/gpu/drm/nouveau/include/nvkm/subdev/fb.h
@@ -93,6 +93,7 @@ int gk104_fb_new(struct nvkm_device *, int, struct nvkm_fb **);
 int gk20a_fb_new(struct nvkm_device *, int, struct nvkm_fb **);
 int gm107_fb_new(struct nvkm_device *, int, struct nvkm_fb **);
 int gm200_fb_new(struct nvkm_device *, int, struct nvkm_fb **);
+int gm20b_fb_new(struct nvkm_device *, int, struct nvkm_fb **);
 int gp100_fb_new(struct nvkm_device *, int, struct nvkm_fb **);
 int gp104_fb_new(struct nvkm_device *, int, struct nvkm_fb **);
 
@@ -156,4 +157,6 @@ struct nvkm_ram_func {
         int (*prog)(struct nvkm_ram *);
         void (*tidy)(struct nvkm_ram *);
 };
+
+extern const u8 gf100_pte_storage_type_map[256];
 #endif
diff --git a/drivers/gpu/drm/nouveau/nouveau_acpi.c b/drivers/gpu/drm/nouveau/nouveau_acpi.c
index dc57b628e074..193573d191e5 100644
--- a/drivers/gpu/drm/nouveau/nouveau_acpi.c
+++ b/drivers/gpu/drm/nouveau/nouveau_acpi.c
@@ -240,7 +240,8 @@ static bool nouveau_pr3_present(struct pci_dev *pdev)
         if (!parent_adev)
                 return false;
 
-        return acpi_has_method(parent_adev->handle, "_PR3");
+        return parent_adev->power.flags.power_resources &&
+                acpi_has_method(parent_adev->handle, "_PR3");
 }
 
 static void nouveau_dsm_pci_probe(struct pci_dev *pdev, acpi_handle *dhandle_out,
diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
index a1570b109434..23ffe8571a99 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bios.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
@@ -333,6 +333,9 @@ get_fp_strap(struct drm_device *dev, struct nvbios *bios)
         if (bios->major_version < 5 && bios->data[0x48] & 0x4)
                 return NVReadVgaCrtc5758(dev, 0, 0xf) & 0xf;
 
+        if (drm->device.info.family >= NV_DEVICE_INFO_V0_MAXWELL)
+                return nvif_rd32(device, 0x001800) & 0x0000000f;
+        else
         if (drm->device.info.family >= NV_DEVICE_INFO_V0_TESLA)
                 return (nvif_rd32(device, NV_PEXTDEV_BOOT_0) >> 24) & 0xf;
         else
diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
index c1084088f9e4..947c200655b4 100644
--- a/drivers/gpu/drm/nouveau/nouveau_connector.c
+++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
@@ -30,6 +30,7 @@
 #include <linux/vga_switcheroo.h>
 
 #include <drm/drmP.h>
+#include <drm/drm_atomic_helper.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_crtc_helper.h>
 
@@ -47,6 +48,301 @@
 #include <nvif/cl0046.h>
 #include <nvif/event.h>
 
+struct drm_display_mode *
+nouveau_conn_native_mode(struct drm_connector *connector)
+{
+        const struct drm_connector_helper_funcs *helper = connector->helper_private;
+        struct nouveau_drm *drm = nouveau_drm(connector->dev);
+        struct drm_device *dev = connector->dev;
+        struct drm_display_mode *mode, *largest = NULL;
+        int high_w = 0, high_h = 0, high_v = 0;
+
+        list_for_each_entry(mode, &connector->probed_modes, head) {
+                mode->vrefresh = drm_mode_vrefresh(mode);
+                if (helper->mode_valid(connector, mode) != MODE_OK ||
+                    (mode->flags & DRM_MODE_FLAG_INTERLACE))
+                        continue;
+
+                /* Use preferred mode if there is one.. */
+                if (mode->type & DRM_MODE_TYPE_PREFERRED) {
+                        NV_DEBUG(drm, "native mode from preferred\n");
+                        return drm_mode_duplicate(dev, mode);
+                }
+
+                /* Otherwise, take the resolution with the largest width, then
+                 * height, then vertical refresh
+                 */
+                if (mode->hdisplay < high_w)
+                        continue;
+
+                if (mode->hdisplay == high_w && mode->vdisplay < high_h)
+                        continue;
+
+                if (mode->hdisplay == high_w && mode->vdisplay == high_h &&
+                    mode->vrefresh < high_v)
+                        continue;
+
+                high_w = mode->hdisplay;
+                high_h = mode->vdisplay;
+                high_v = mode->vrefresh;
+                largest = mode;
+        }
+
+        NV_DEBUG(drm, "native mode from largest: %dx%d@%d\n",
+                      high_w, high_h, high_v);
+        return largest ? drm_mode_duplicate(dev, largest) : NULL;
+}
+
+int
+nouveau_conn_atomic_get_property(struct drm_connector *connector,
+                                 const struct drm_connector_state *state,
+                                 struct drm_property *property, u64 *val)
+{
+        struct nouveau_conn_atom *asyc = nouveau_conn_atom(state);
+        struct nouveau_display *disp = nouveau_display(connector->dev);
+        struct drm_device *dev = connector->dev;
+
+        if (property == dev->mode_config.scaling_mode_property)
+                *val = asyc->scaler.mode;
+        else if (property == disp->underscan_property)
+                *val = asyc->scaler.underscan.mode;
+        else if (property == disp->underscan_hborder_property)
+                *val = asyc->scaler.underscan.hborder;
+        else if (property == disp->underscan_vborder_property)
+                *val = asyc->scaler.underscan.vborder;
+        else if (property == disp->dithering_mode)
+                *val = asyc->dither.mode;
+        else if (property == disp->dithering_depth)
+                *val = asyc->dither.depth;
+        else if (property == disp->vibrant_hue_property)
+                *val = asyc->procamp.vibrant_hue;
+        else if (property == disp->color_vibrance_property)
+                *val = asyc->procamp.color_vibrance;
+        else
+                return -EINVAL;
+
+        return 0;
+}
+
+int
+nouveau_conn_atomic_set_property(struct drm_connector *connector,
+                                 struct drm_connector_state *state,
+                                 struct drm_property *property, u64 val)
+{
+        struct drm_device *dev = connector->dev;
+        struct nouveau_conn_atom *asyc = nouveau_conn_atom(state);
+        struct nouveau_display *disp = nouveau_display(dev);
+
+        if (property == dev->mode_config.scaling_mode_property) {
+                switch (val) {
+                case DRM_MODE_SCALE_NONE:
+                        /* We allow 'None' for EDID modes, even on a fixed
+                         * panel (some exist with support for lower refresh
+                         * rates, which people might want to use for power-
+                         * saving purposes).
+                         *
+                         * Non-EDID modes will force the use of GPU scaling
+                         * to the native mode regardless of this setting.
+                         */
+                        switch (connector->connector_type) {
+                        case DRM_MODE_CONNECTOR_LVDS:
+                        case DRM_MODE_CONNECTOR_eDP:
+                                /* ... except prior to G80, where the code
+                                 * doesn't support such things.
+                                 */
+                                if (disp->disp.oclass < NV50_DISP)
+                                        return -EINVAL;
+                                break;
+                        default:
+                                break;
+                        }
+                case DRM_MODE_SCALE_FULLSCREEN:
+                case DRM_MODE_SCALE_CENTER:
+                case DRM_MODE_SCALE_ASPECT:
+                        break;
+                default:
+                        return -EINVAL;
+                }
+
+                if (asyc->scaler.mode != val) {
+                        asyc->scaler.mode = val;
+                        asyc->set.scaler = true;
+                }
+        } else
+        if (property == disp->underscan_property) {
+                if (asyc->scaler.underscan.mode != val) {
+                        asyc->scaler.underscan.mode = val;
+                        asyc->set.scaler = true;
+                }
+        } else
+        if (property == disp->underscan_hborder_property) {
+                if (asyc->scaler.underscan.hborder != val) {
+                        asyc->scaler.underscan.hborder = val;
+                        asyc->set.scaler = true;
+                }
+        } else
+        if (property == disp->underscan_vborder_property) {
+                if (asyc->scaler.underscan.vborder != val) {
+                        asyc->scaler.underscan.vborder = val;
+                        asyc->set.scaler = true;
+                }
+        } else
+        if (property == disp->dithering_mode) {
+                if (asyc->dither.mode != val) {
+                        asyc->dither.mode = val;
+                        asyc->set.dither = true;
+                }
+        } else
+        if (property == disp->dithering_depth) {
+                if (asyc->dither.mode != val) {
+                        asyc->dither.depth = val;
+                        asyc->set.dither = true;
+                }
+        } else
+        if (property == disp->vibrant_hue_property) {
+                if (asyc->procamp.vibrant_hue != val) {
+                        asyc->procamp.vibrant_hue = val;
+                        asyc->set.procamp = true;
+                }
+        } else
+        if (property == disp->color_vibrance_property) {
+                if (asyc->procamp.color_vibrance != val) {
+                        asyc->procamp.color_vibrance = val;
+                        asyc->set.procamp = true;
+                }
+        } else {
+                return -EINVAL;
+        }
+
+        return 0;
+}
+
+void
+nouveau_conn_atomic_destroy_state(struct drm_connector *connector,
+                                  struct drm_connector_state *state)
+{
+        struct nouveau_conn_atom *asyc = nouveau_conn_atom(state);
+        __drm_atomic_helper_connector_destroy_state(&asyc->state);
+        kfree(asyc);
+}
+
+struct drm_connector_state *
+nouveau_conn_atomic_duplicate_state(struct drm_connector *connector)
+{
+        struct nouveau_conn_atom *armc = nouveau_conn_atom(connector->state);
+        struct nouveau_conn_atom *asyc;
+        if (!(asyc = kmalloc(sizeof(*asyc), GFP_KERNEL)))
+                return NULL;
+        __drm_atomic_helper_connector_duplicate_state(connector, &asyc->state);
+        asyc->dither = armc->dither;
+        asyc->scaler = armc->scaler;
+        asyc->procamp = armc->procamp;
+        asyc->set.mask = 0;
+        return &asyc->state;
+}
+
+void
+nouveau_conn_reset(struct drm_connector *connector)
+{
+        struct nouveau_conn_atom *asyc;
+
+        if (WARN_ON(!(asyc = kzalloc(sizeof(*asyc), GFP_KERNEL))))
+                return;
+
+        if (connector->state)
+                __drm_atomic_helper_connector_destroy_state(connector->state);
+        __drm_atomic_helper_connector_reset(connector, &asyc->state);
+        asyc->dither.mode = DITHERING_MODE_AUTO;
+        asyc->dither.depth = DITHERING_DEPTH_AUTO;
+        asyc->scaler.mode = DRM_MODE_SCALE_NONE;
+        asyc->scaler.underscan.mode = UNDERSCAN_OFF;
+        asyc->procamp.color_vibrance = 150;
+        asyc->procamp.vibrant_hue = 90;
+
+        if (nouveau_display(connector->dev)->disp.oclass < NV50_DISP) {
+                switch (connector->connector_type) {
+                case DRM_MODE_CONNECTOR_LVDS:
+                        /* See note in nouveau_conn_atomic_set_property(). */
+                        asyc->scaler.mode = DRM_MODE_SCALE_FULLSCREEN;
+                        break;
+                default:
+                        break;
+                }
+        }
+}
+
+void
+nouveau_conn_attach_properties(struct drm_connector *connector)
+{
+        struct drm_device *dev = connector->dev;
+        struct nouveau_conn_atom *armc = nouveau_conn_atom(connector->state);
+        struct nouveau_display *disp = nouveau_display(dev);
+
+        /* Init DVI-I specific properties. */
+        if (connector->connector_type == DRM_MODE_CONNECTOR_DVII)
+                drm_object_attach_property(&connector->base, dev->mode_config.
+                                           dvi_i_subconnector_property, 0);
+
+        /* Add overscan compensation options to digital outputs. */
+        if (disp->underscan_property &&
+            (connector->connector_type == DRM_MODE_CONNECTOR_DVID ||
+             connector->connector_type == DRM_MODE_CONNECTOR_DVII ||
+             connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
+             connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort)) {
+                drm_object_attach_property(&connector->base,
+                                           disp->underscan_property,
+                                           UNDERSCAN_OFF);
+                drm_object_attach_property(&connector->base,
+                                           disp->underscan_hborder_property, 0);
+                drm_object_attach_property(&connector->base,
+                                           disp->underscan_vborder_property, 0);
+        }
+
+        /* Add hue and saturation options. */
+        if (disp->vibrant_hue_property)
+                drm_object_attach_property(&connector->base,
+                                           disp->vibrant_hue_property,
+                                           armc->procamp.vibrant_hue);
+        if (disp->color_vibrance_property)
+                drm_object_attach_property(&connector->base,
+                                           disp->color_vibrance_property,
+                                           armc->procamp.color_vibrance);
+
+        /* Scaling mode property. */
+        switch (connector->connector_type) {
+        case DRM_MODE_CONNECTOR_TV:
+                break;
+        case DRM_MODE_CONNECTOR_VGA:
+                if (disp->disp.oclass < NV50_DISP)
+                        break; /* Can only scale on DFPs. */
+                /* Fall-through. */
+        default:
+                drm_object_attach_property(&connector->base, dev->mode_config.
+                                           scaling_mode_property,
+                                           armc->scaler.mode);
+                break;
+        }
+
+        /* Dithering properties. */
+        switch (connector->connector_type) {
+        case DRM_MODE_CONNECTOR_TV:
+        case DRM_MODE_CONNECTOR_VGA:
+                break;
+        default:
+                if (disp->dithering_mode) {
+                        drm_object_attach_property(&connector->base,
+                                                   disp->dithering_mode,
+                                                   armc->dither.mode);
+                }
+                if (disp->dithering_depth) {
+                        drm_object_attach_property(&connector->base,
+                                                   disp->dithering_depth,
+                                                   armc->dither.depth);
+                }
+                break;
+        }
+}
+
 MODULE_PARM_DESC(tv_disable, "Disable TV-out detection");
 int nouveau_tv_disable = 0;
 module_param_named(tv_disable, nouveau_tv_disable, int, 0400);
@@ -151,7 +447,9 @@ nouveau_connector_ddc_detect(struct drm_connector *connector)
 
                 if (nv_encoder->dcb->type == DCB_OUTPUT_DP) {
                         int ret = nouveau_dp_detect(nv_encoder);
-                        if (ret == 0)
+                        if (ret == NOUVEAU_DP_MST)
+                                return NULL;
+                        if (ret == NOUVEAU_DP_SST)
                                 break;
                 } else
                 if ((vga_switcheroo_handler_flags() &
@@ -465,199 +763,39 @@ static int
 nouveau_connector_set_property(struct drm_connector *connector,
                                struct drm_property *property, uint64_t value)
 {
-        struct nouveau_display *disp = nouveau_display(connector->dev);
+        struct nouveau_conn_atom *asyc = nouveau_conn_atom(connector->state);
         struct nouveau_connector *nv_connector = nouveau_connector(connector);
         struct nouveau_encoder *nv_encoder = nv_connector->detected_encoder;
         struct drm_encoder *encoder = to_drm_encoder(nv_encoder);
-        struct drm_device *dev = connector->dev;
-        struct nouveau_crtc *nv_crtc;
         int ret;
 
-        nv_crtc = NULL;
-        if (connector->encoder && connector->encoder->crtc)
-                nv_crtc = nouveau_crtc(connector->encoder->crtc);
-
-        /* Scaling mode */
-        if (property == dev->mode_config.scaling_mode_property) {
-                bool modeset = false;
-
-                switch (value) {
-                case DRM_MODE_SCALE_NONE:
-                        /* We allow 'None' for EDID modes, even on a fixed
-                         * panel (some exist with support for lower refresh
-                         * rates, which people might want to use for power
-                         * saving purposes).
-                         *
-                         * Non-EDID modes will force the use of GPU scaling
-                         * to the native mode regardless of this setting.
-                         */
-                        switch (nv_connector->type) {
-                        case DCB_CONNECTOR_LVDS:
-                        case DCB_CONNECTOR_LVDS_SPWG:
-                        case DCB_CONNECTOR_eDP:
-                                /* ... except prior to G80, where the code
-                                 * doesn't support such things.
-                                 */
-                                if (disp->disp.oclass < NV50_DISP)
-                                        return -EINVAL;
-                                break;
-                        default:
-                                break;
-                        }
-                        break;
-                case DRM_MODE_SCALE_FULLSCREEN:
-                case DRM_MODE_SCALE_CENTER:
-                case DRM_MODE_SCALE_ASPECT:
-                        break;
-                default:
-                        return -EINVAL;
-                }
-
-                /* Changing between GPU and panel scaling requires a full
-                 * modeset
-                 */
-                if ((nv_connector->scaling_mode == DRM_MODE_SCALE_NONE) ||
-                    (value == DRM_MODE_SCALE_NONE))
-                        modeset = true;
-                nv_connector->scaling_mode = value;
-
-                if (!nv_crtc)
-                        return 0;
-
-                if (modeset || !nv_crtc->set_scale) {
-                        ret = drm_crtc_helper_set_mode(&nv_crtc->base,
-                                                        &nv_crtc->base.mode,
-                                                        nv_crtc->base.x,
-                                                        nv_crtc->base.y, NULL);
-                        if (!ret)
-                                return -EINVAL;
-                } else {
-                        ret = nv_crtc->set_scale(nv_crtc, true);
-                        if (ret)
-                                return ret;
-                }
-
-                return 0;
-        }
-
-        /* Underscan */
-        if (property == disp->underscan_property) {
-                if (nv_connector->underscan != value) {
-                        nv_connector->underscan = value;
-                        if (!nv_crtc || !nv_crtc->set_scale)
-                                return 0;
-
-                        return nv_crtc->set_scale(nv_crtc, true);
-                }
-
-                return 0;
-        }
-
-        if (property == disp->underscan_hborder_property) {
-                if (nv_connector->underscan_hborder != value) {
-                        nv_connector->underscan_hborder = value;
-                        if (!nv_crtc || !nv_crtc->set_scale)
-                                return 0;
-
-                        return nv_crtc->set_scale(nv_crtc, true);
-                }
-
-                return 0;
-        }
-
-        if (property == disp->underscan_vborder_property) {
-                if (nv_connector->underscan_vborder != value) {
-                        nv_connector->underscan_vborder = value;
-                        if (!nv_crtc || !nv_crtc->set_scale)
-                                return 0;
-
-                        return nv_crtc->set_scale(nv_crtc, true);
-                }
-
-                return 0;
-        }
+        if (connector->dev->mode_config.funcs->atomic_commit)
+                return drm_atomic_helper_connector_set_property(connector, property, value);
 
-        /* Dithering */
-        if (property == disp->dithering_mode) {
-                nv_connector->dithering_mode = value;
-                if (!nv_crtc || !nv_crtc->set_dither)
-                        return 0;
-
-                return nv_crtc->set_dither(nv_crtc, true);
-        }
-
-        if (property == disp->dithering_depth) {
-                nv_connector->dithering_depth = value;
-                if (!nv_crtc || !nv_crtc->set_dither)
-                        return 0;
-
-                return nv_crtc->set_dither(nv_crtc, true);
-        }
-
-        if (nv_crtc && nv_crtc->set_color_vibrance) {
-                /* Hue */
-                if (property == disp->vibrant_hue_property) {
-                        nv_crtc->vibrant_hue = value - 90;
-                        return nv_crtc->set_color_vibrance(nv_crtc, true);
-                }
-                /* Saturation */
-                if (property == disp->color_vibrance_property) {
-                        nv_crtc->color_vibrance = value - 100;
-                        return nv_crtc->set_color_vibrance(nv_crtc, true);
-                }
+        ret = connector->funcs->atomic_set_property(&nv_connector->base,
+                                                    &asyc->state,
+                                                    property, value);
+        if (ret) {
+                if (nv_encoder && nv_encoder->dcb->type == DCB_OUTPUT_TV)
+                        return get_slave_funcs(encoder)->set_property(
+                                encoder, connector, property, value);
+                return ret;
         }
 
-        if (nv_encoder && nv_encoder->dcb->type == DCB_OUTPUT_TV)
-                return get_slave_funcs(encoder)->set_property(
-                        encoder, connector, property, value);
-
-        return -EINVAL;
-}
-
-static struct drm_display_mode *
-nouveau_connector_native_mode(struct drm_connector *connector)
-{
-        const struct drm_connector_helper_funcs *helper = connector->helper_private;
-        struct nouveau_drm *drm = nouveau_drm(connector->dev);
-        struct nouveau_connector *nv_connector = nouveau_connector(connector);
-        struct drm_device *dev = connector->dev;
-        struct drm_display_mode *mode, *largest = NULL;
-        int high_w = 0, high_h = 0, high_v = 0;
+        nv_connector->scaling_mode = asyc->scaler.mode;
+        nv_connector->dithering_mode = asyc->dither.mode;
 
-        list_for_each_entry(mode, &nv_connector->base.probed_modes, head) {
-                mode->vrefresh = drm_mode_vrefresh(mode);
-                if (helper->mode_valid(connector, mode) != MODE_OK ||
-                    (mode->flags & DRM_MODE_FLAG_INTERLACE))
-                        continue;
-
-                /* Use preferred mode if there is one.. */
-                if (mode->type & DRM_MODE_TYPE_PREFERRED) {
-                        NV_DEBUG(drm, "native mode from preferred\n");
-                        return drm_mode_duplicate(dev, mode);
-                }
-
-                /* Otherwise, take the resolution with the largest width, then
-                 * height, then vertical refresh
-                 */
-                if (mode->hdisplay < high_w)
-                        continue;
-
-                if (mode->hdisplay == high_w && mode->vdisplay < high_h)
-                        continue;
-
-                if (mode->hdisplay == high_w && mode->vdisplay == high_h &&
-                    mode->vrefresh < high_v)
-                        continue;
-
-                high_w = mode->hdisplay;
-                high_h = mode->vdisplay;
-                high_v = mode->vrefresh;
-                largest = mode;
+        if (connector->encoder && connector->encoder->crtc) {
+                ret = drm_crtc_helper_set_mode(connector->encoder->crtc,
+                                              &connector->encoder->crtc->mode,
+                                               connector->encoder->crtc->x,
+                                               connector->encoder->crtc->y,
+                                               NULL);
+                if (!ret)
+                        return -EINVAL;
         }
 
-        NV_DEBUG(drm, "native mode from largest: %dx%d@%d\n",
-                      high_w, high_h, high_v);
-        return largest ? drm_mode_duplicate(dev, largest) : NULL;
+        return 0;
 }
 
 struct moderec {
@@ -805,8 +943,7 @@ nouveau_connector_get_modes(struct drm_connector *connector)
          * the list of modes.
          */
         if (!nv_connector->native_mode)
-                nv_connector->native_mode =
-                        nouveau_connector_native_mode(connector);
+                nv_connector->native_mode = nouveau_conn_native_mode(connector);
         if (ret == 0 && nv_connector->native_mode) {
                 struct drm_display_mode *mode;
 
@@ -934,56 +1071,42 @@ nouveau_connector_helper_funcs = {
         .best_encoder = nouveau_connector_best_encoder,
 };
 
+static int
+nouveau_connector_dpms(struct drm_connector *connector, int mode)
+{
+        if (connector->dev->mode_config.funcs->atomic_commit)
+                return drm_atomic_helper_connector_dpms(connector, mode);
+        return drm_helper_connector_dpms(connector, mode);
+}
+
 static const struct drm_connector_funcs
 nouveau_connector_funcs = {
-        .dpms = drm_helper_connector_dpms,
+        .dpms = nouveau_connector_dpms,
+        .reset = nouveau_conn_reset,
         .detect = nouveau_connector_detect,
-        .destroy = nouveau_connector_destroy,
+        .force = nouveau_connector_force,
         .fill_modes = drm_helper_probe_single_connector_modes,
         .set_property = nouveau_connector_set_property,
-        .force = nouveau_connector_force
+        .destroy = nouveau_connector_destroy,
+        .atomic_duplicate_state = nouveau_conn_atomic_duplicate_state,
+        .atomic_destroy_state = nouveau_conn_atomic_destroy_state,
+        .atomic_set_property = nouveau_conn_atomic_set_property,
+        .atomic_get_property = nouveau_conn_atomic_get_property,
 };
 
 static const struct drm_connector_funcs
 nouveau_connector_funcs_lvds = {
-        .dpms = drm_helper_connector_dpms,
+        .dpms = nouveau_connector_dpms,
+        .reset = nouveau_conn_reset,
         .detect = nouveau_connector_detect_lvds,
-        .destroy = nouveau_connector_destroy,
+        .force = nouveau_connector_force,
         .fill_modes = drm_helper_probe_single_connector_modes,
         .set_property = nouveau_connector_set_property,
-        .force = nouveau_connector_force
-};
-
-static int
-nouveau_connector_dp_dpms(struct drm_connector *connector, int mode)
-{
-        struct nouveau_encoder *nv_encoder = NULL;
-
-        if (connector->encoder)
-                nv_encoder = nouveau_encoder(connector->encoder);
-        if (nv_encoder && nv_encoder->dcb &&
-            nv_encoder->dcb->type == DCB_OUTPUT_DP) {
-                if (mode == DRM_MODE_DPMS_ON) {
-                        u8 data = DP_SET_POWER_D0;
-                        nvkm_wraux(nv_encoder->aux, DP_SET_POWER, &data, 1);
-                        usleep_range(1000, 2000);
-                } else {
-                        u8 data = DP_SET_POWER_D3;
-                        nvkm_wraux(nv_encoder->aux, DP_SET_POWER, &data, 1);
-                }
-        }
-
-        return drm_helper_connector_dpms(connector, mode);
-}
-
-static const struct drm_connector_funcs
-nouveau_connector_funcs_dp = {
-        .dpms = nouveau_connector_dp_dpms,
-        .detect = nouveau_connector_detect,
         .destroy = nouveau_connector_destroy,
-        .fill_modes = drm_helper_probe_single_connector_modes,
-        .set_property = nouveau_connector_set_property,
-        .force = nouveau_connector_force
+        .atomic_duplicate_state = nouveau_conn_atomic_duplicate_state,
+        .atomic_destroy_state = nouveau_conn_atomic_destroy_state,
+        .atomic_set_property = nouveau_conn_atomic_set_property,
+        .atomic_get_property = nouveau_conn_atomic_get_property,
 };
 
 static int
@@ -995,19 +1118,20 @@ nouveau_connector_hotplug(struct nvif_notify *notify)
         struct nouveau_drm *drm = nouveau_drm(connector->dev);
         const struct nvif_notify_conn_rep_v0 *rep = notify->data;
         const char *name = connector->name;
+        struct nouveau_encoder *nv_encoder;
 
         if (rep->mask & NVIF_NOTIFY_CONN_V0_IRQ) {
+                NV_DEBUG(drm, "service %s\n", name);
+                if ((nv_encoder = find_encoder(connector, DCB_OUTPUT_DP)))
+                        nv50_mstm_service(nv_encoder->dp.mstm);
         } else {
                 bool plugged = (rep->mask != NVIF_NOTIFY_CONN_V0_UNPLUG);
 
                 NV_DEBUG(drm, "%splugged %s\n", plugged ? "" : "un", name);
-
-                mutex_lock(&drm->dev->mode_config.mutex);
-                if (plugged)
-                        drm_helper_connector_dpms(connector, DRM_MODE_DPMS_ON);
-                else
-                        drm_helper_connector_dpms(connector, DRM_MODE_DPMS_OFF);
-                mutex_unlock(&drm->dev->mode_config.mutex);
+                if ((nv_encoder = find_encoder(connector, DCB_OUTPUT_DP))) {
+                        if (!plugged)
+                                nv50_mstm_remove(nv_encoder->dp.mstm);
+                }
 
                 drm_helper_hpd_irq_event(connector->dev);
         }
@@ -1188,7 +1312,7 @@ nouveau_connector_create(struct drm_device *dev, int index)
                         return ERR_PTR(ret);
                 }
 
-                funcs = &nouveau_connector_funcs_dp;
+                funcs = &nouveau_connector_funcs;
                 break;
         default:
                 funcs = &nouveau_connector_funcs;
@@ -1202,38 +1326,10 @@ nouveau_connector_create(struct drm_device *dev, int index)
         drm_connector_init(dev, connector, funcs, type);
         drm_connector_helper_add(connector, &nouveau_connector_helper_funcs);
 
-        /* Init DVI-I specific properties */
-        if (nv_connector->type == DCB_CONNECTOR_DVI_I)
-                drm_object_attach_property(&connector->base, dev->mode_config.dvi_i_subconnector_property, 0);
+        connector->funcs->reset(connector);
+        nouveau_conn_attach_properties(connector);
 
-        /* Add overscan compensation options to digital outputs */
-        if (disp->underscan_property &&
-            (type == DRM_MODE_CONNECTOR_DVID ||
-             type == DRM_MODE_CONNECTOR_DVII ||
-             type == DRM_MODE_CONNECTOR_HDMIA ||
-             type == DRM_MODE_CONNECTOR_DisplayPort)) {
-                drm_object_attach_property(&connector->base,
-                                              disp->underscan_property,
-                                              UNDERSCAN_OFF);
-                drm_object_attach_property(&connector->base,
-                                              disp->underscan_hborder_property,
-                                              0);
-                drm_object_attach_property(&connector->base,
-                                              disp->underscan_vborder_property,
-                                              0);
-        }
-
-        /* Add hue and saturation options */
-        if (disp->vibrant_hue_property)
-                drm_object_attach_property(&connector->base,
-                                              disp->vibrant_hue_property,
-                                              90);
-        if (disp->color_vibrance_property)
-                drm_object_attach_property(&connector->base,
-                                              disp->color_vibrance_property,
-                                              150);
-
-        /* default scaling mode */
+        /* Default scaling mode */
         switch (nv_connector->type) {
         case DCB_CONNECTOR_LVDS:
         case DCB_CONNECTOR_LVDS_SPWG:
@@ -1250,23 +1346,6 @@ nouveau_connector_create(struct drm_device *dev, int index)
                 break;
         }
 
-        /* scaling mode property */
-        switch (nv_connector->type) {
-        case DCB_CONNECTOR_TV_0:
-        case DCB_CONNECTOR_TV_1:
-        case DCB_CONNECTOR_TV_3:
-                break;
-        case DCB_CONNECTOR_VGA:
-                if (disp->disp.oclass < NV50_DISP)
-                        break; /* can only scale on DFPs */
-                /* fall-through */
-        default:
-                drm_object_attach_property(&connector->base, dev->mode_config.
-                                           scaling_mode_property,
-                                           nv_connector->scaling_mode);
-                break;
-        }
-
         /* dithering properties */
         switch (nv_connector->type) {
         case DCB_CONNECTOR_TV_0:
@@ -1275,20 +1354,7 @@ nouveau_connector_create(struct drm_device *dev, int index)
         case DCB_CONNECTOR_VGA:
                 break;
         default:
-                if (disp->dithering_mode) {
-                        nv_connector->dithering_mode = DITHERING_MODE_AUTO;
-                        drm_object_attach_property(&connector->base,
-                                                   disp->dithering_mode,
-                                                   nv_connector->
-                                                   dithering_mode);
-                }
-                if (disp->dithering_depth) {
-                        nv_connector->dithering_depth = DITHERING_DEPTH_AUTO;
-                        drm_object_attach_property(&connector->base,
-                                                   disp->dithering_depth,
-                                                   nv_connector->
-                                                   dithering_depth);
-                }
+                nv_connector->dithering_mode = DITHERING_MODE_AUTO;
                 break;
         }
 
diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.h b/drivers/gpu/drm/nouveau/nouveau_connector.h
index 7446ee66ea04..096983c42a1f 100644
--- a/drivers/gpu/drm/nouveau/nouveau_connector.h
+++ b/drivers/gpu/drm/nouveau/nouveau_connector.h
@@ -35,30 +35,6 @@
 
 struct nvkm_i2c_port;
 
-enum nouveau_underscan_type {
-        UNDERSCAN_OFF,
-        UNDERSCAN_ON,
-        UNDERSCAN_AUTO,
-};
-
-/* the enum values specifically defined here match nv50/nvd0 hw values, and
- * the code relies on this
- */
-enum nouveau_dithering_mode {
-        DITHERING_MODE_OFF = 0x00,
-        DITHERING_MODE_ON = 0x01,
-        DITHERING_MODE_DYNAMIC2X2 = 0x10 | DITHERING_MODE_ON,
-        DITHERING_MODE_STATIC2X2 = 0x18 | DITHERING_MODE_ON,
-        DITHERING_MODE_TEMPORAL = 0x20 | DITHERING_MODE_ON,
-        DITHERING_MODE_AUTO
-};
-
-enum nouveau_dithering_depth {
-        DITHERING_DEPTH_6BPC = 0x00,
-        DITHERING_DEPTH_8BPC = 0x02,
-        DITHERING_DEPTH_AUTO
-};
-
 struct nouveau_connector {
         struct drm_connector base;
         enum dcb_connector_type type;
@@ -70,12 +46,7 @@ struct nouveau_connector {
         struct drm_dp_aux aux;
 
         int dithering_mode;
-        int dithering_depth;
         int scaling_mode;
-        bool scaling_full;
-        enum nouveau_underscan_type underscan;
-        u32 underscan_hborder;
-        u32 underscan_vborder;
 
         struct nouveau_encoder *detected_encoder;
         struct edid *edid;
@@ -109,5 +80,74 @@ nouveau_connector_create(struct drm_device *, int index);
 extern int nouveau_tv_disable;
 extern int nouveau_ignorelid;
 extern int nouveau_duallink;
+extern int nouveau_hdmimhz;
+
+#include <drm/drm_crtc.h>
+#define nouveau_conn_atom(p)                                                   \
+        container_of((p), struct nouveau_conn_atom, state)
+
+struct nouveau_conn_atom {
+        struct drm_connector_state state;
+
+        struct {
+                /* The enum values specifically defined here match nv50/gf119
+                 * hw values, and the code relies on this.
+                 */
+                enum {
+                        DITHERING_MODE_OFF = 0x00,
+                        DITHERING_MODE_ON = 0x01,
+                        DITHERING_MODE_DYNAMIC2X2 = 0x10 | DITHERING_MODE_ON,
+                        DITHERING_MODE_STATIC2X2 = 0x18 | DITHERING_MODE_ON,
+                        DITHERING_MODE_TEMPORAL = 0x20 | DITHERING_MODE_ON,
+                        DITHERING_MODE_AUTO
+                } mode;
+                enum {
+                        DITHERING_DEPTH_6BPC = 0x00,
+                        DITHERING_DEPTH_8BPC = 0x02,
+                        DITHERING_DEPTH_AUTO
+                } depth;
+        } dither;
+
+        struct {
+                int mode;       /* DRM_MODE_SCALE_* */
+                struct {
+                        enum {
+                                UNDERSCAN_OFF,
+                                UNDERSCAN_ON,
+                                UNDERSCAN_AUTO,
+                        } mode;
+                        u32 hborder;
+                        u32 vborder;
+                } underscan;
+                bool full;
+        } scaler;
+
+        struct {
+                int color_vibrance;
+                int vibrant_hue;
+        } procamp;
+
+        union {
+                struct {
+                        bool dither:1;
+                        bool scaler:1;
+                        bool procamp:1;
+                };
+                u8 mask;
+        } set;
+};
 
+void nouveau_conn_attach_properties(struct drm_connector *);
+void nouveau_conn_reset(struct drm_connector *);
+struct drm_connector_state *
+nouveau_conn_atomic_duplicate_state(struct drm_connector *);
+void nouveau_conn_atomic_destroy_state(struct drm_connector *,
+                                       struct drm_connector_state *);
+int nouveau_conn_atomic_set_property(struct drm_connector *,
+                                     struct drm_connector_state *,
+                                     struct drm_property *, u64);
+int nouveau_conn_atomic_get_property(struct drm_connector *,
+                                     const struct drm_connector_state *,
+                                     struct drm_property *, u64 *);
+struct drm_display_mode *nouveau_conn_native_mode(struct drm_connector *);
 #endif /* __NOUVEAU_CONNECTOR_H__ */
diff --git a/drivers/gpu/drm/nouveau/nouveau_crtc.h b/drivers/gpu/drm/nouveau/nouveau_crtc.h
index 863f10b8d818..050fcf30a0d2 100644
--- a/drivers/gpu/drm/nouveau/nouveau_crtc.h
+++ b/drivers/gpu/drm/nouveau/nouveau_crtc.h
@@ -38,8 +38,6 @@ struct nouveau_crtc {
         uint32_t dpms_saved_fp_control;
         uint32_t fp_users;
         int saturation;
-        int color_vibrance;
-        int vibrant_hue;
         int sharpness;
         int last_dpms;
 
@@ -54,7 +52,6 @@ struct nouveau_crtc {
 
         struct {
                 struct nouveau_bo *nvbo;
-                bool visible;
                 uint32_t offset;
                 void (*set_offset)(struct nouveau_crtc *, uint32_t offset);
                 void (*set_pos)(struct nouveau_crtc *, int x, int y);
@@ -70,10 +67,6 @@ struct nouveau_crtc {
                 int depth;
         } lut;
 
-        int (*set_dither)(struct nouveau_crtc *crtc, bool update);
-        int (*set_scale)(struct nouveau_crtc *crtc, bool update);
-        int (*set_color_vibrance)(struct nouveau_crtc *crtc, bool update);
-
         void (*save)(struct drm_crtc *crtc);
         void (*restore)(struct drm_crtc *crtc);
 };
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
index afbf557b23d4..75c90a8da18a 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -25,6 +25,8 @@
  */
 
 #include <drm/drmP.h>
+#include <drm/drm_atomic.h>
+#include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc_helper.h>
 
 #include <nvif/class.h>
@@ -92,7 +94,7 @@ calc(int blanks, int blanke, int total, int line)
         return line;
 }
 
-int
+static int
 nouveau_display_scanoutpos_head(struct drm_crtc *crtc, int *vpos, int *hpos,
                                 ktime_t *stime, ktime_t *etime)
 {
@@ -158,9 +160,13 @@ nouveau_display_vblstamp(struct drm_device *dev, unsigned int pipe,
 
         list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
                 if (nouveau_crtc(crtc)->index == pipe) {
+                        struct drm_display_mode *mode;
+                        if (dev->mode_config.funcs->atomic_commit)
+                                mode = &crtc->state->adjusted_mode;
+                        else
+                                mode = &crtc->hwmode;
                         return drm_calc_vbltimestamp_from_scanoutpos(dev,
-                                        pipe, max_error, time, flags,
-                                        &crtc->hwmode);
+                                        pipe, max_error, time, flags, mode);
                 }
         }
 
@@ -217,10 +223,6 @@ static void
 nouveau_user_framebuffer_destroy(struct drm_framebuffer *drm_fb)
 {
         struct nouveau_framebuffer *fb = nouveau_framebuffer(drm_fb);
-        struct nouveau_display *disp = nouveau_display(drm_fb->dev);
-
-        if (disp->fb_dtor)
-                disp->fb_dtor(drm_fb);
 
         if (fb->nvbo)
                 drm_gem_object_unreference_unlocked(&fb->nvbo->gem);
@@ -245,57 +247,45 @@ static const struct drm_framebuffer_funcs nouveau_framebuffer_funcs = {
 };
 
 int
-nouveau_framebuffer_init(struct drm_device *dev,
-                         struct nouveau_framebuffer *nv_fb,
-                         const struct drm_mode_fb_cmd2 *mode_cmd,
-                         struct nouveau_bo *nvbo)
+nouveau_framebuffer_new(struct drm_device *dev,
+                        const struct drm_mode_fb_cmd2 *mode_cmd,
+                        struct nouveau_bo *nvbo,
+                        struct nouveau_framebuffer **pfb)
 {
-        struct nouveau_display *disp = nouveau_display(dev);
-        struct drm_framebuffer *fb = &nv_fb->base;
+        struct nouveau_framebuffer *fb;
         int ret;
 
-        drm_helper_mode_fill_fb_struct(fb, mode_cmd);
-        nv_fb->nvbo = nvbo;
-
-        ret = drm_framebuffer_init(dev, fb, &nouveau_framebuffer_funcs);
-        if (ret)
-                return ret;
+        if (!(fb = *pfb = kzalloc(sizeof(*fb), GFP_KERNEL)))
+                return -ENOMEM;
 
-        if (disp->fb_ctor) {
-                ret = disp->fb_ctor(fb);
-                if (ret)
-                        disp->fb_dtor(fb);
-        }
+        drm_helper_mode_fill_fb_struct(&fb->base, mode_cmd);
+        fb->nvbo = nvbo;
 
+        ret = drm_framebuffer_init(dev, &fb->base, &nouveau_framebuffer_funcs);
+        if (ret)
+                kfree(fb);
         return ret;
 }
 
-static struct drm_framebuffer *
+struct drm_framebuffer *
 nouveau_user_framebuffer_create(struct drm_device *dev,
                                 struct drm_file *file_priv,
                                 const struct drm_mode_fb_cmd2 *mode_cmd)
 {
-        struct nouveau_framebuffer *nouveau_fb;
+        struct nouveau_framebuffer *fb;
+        struct nouveau_bo *nvbo;
         struct drm_gem_object *gem;
-        int ret = -ENOMEM;
+        int ret;
 
         gem = drm_gem_object_lookup(file_priv, mode_cmd->handles[0]);
         if (!gem)
                 return ERR_PTR(-ENOENT);
+        nvbo = nouveau_gem_object(gem);
 
-        nouveau_fb = kzalloc(sizeof(struct nouveau_framebuffer), GFP_KERNEL);
-        if (!nouveau_fb)
-                goto err_unref;
-
-        ret = nouveau_framebuffer_init(dev, nouveau_fb, mode_cmd, nouveau_gem_object(gem));
-        if (ret)
-                goto err;
-
-        return &nouveau_fb->base;
+        ret = nouveau_framebuffer_new(dev, mode_cmd, nvbo, &fb);
+        if (ret == 0)
+                return &fb->base;
 
-err:
-        kfree(nouveau_fb);
-err_unref:
         drm_gem_object_unreference_unlocked(gem);
         return ERR_PTR(ret);
 }
@@ -385,13 +375,16 @@ nouveau_display_init(struct drm_device *dev)
 }
 
 void
-nouveau_display_fini(struct drm_device *dev)
+nouveau_display_fini(struct drm_device *dev, bool suspend)
 {
         struct nouveau_display *disp = nouveau_display(dev);
         struct nouveau_drm *drm = nouveau_drm(dev);
         struct drm_connector *connector;
         int head;
 
+        if (!suspend)
+                drm_crtc_force_disable_all(dev);
+
         /* Make sure that drm and hw vblank irqs get properly disabled. */
         for (head = 0; head < dev->mode_config.num_crtc; head++)
                 drm_vblank_off(dev, head);
@@ -530,6 +523,8 @@ nouveau_display_create(struct drm_device *dev)
         if (ret)
                 goto disp_create_err;
 
+        drm_mode_config_reset(dev);
+
         if (dev->mode_config.num_crtc) {
                 ret = nouveau_display_vblank_init(dev);
                 if (ret)
@@ -556,7 +551,6 @@ nouveau_display_destroy(struct drm_device *dev)
         nouveau_display_vblank_fini(dev);
 
         drm_kms_helper_poll_fini(dev);
-        drm_crtc_force_disable_all(dev);
         drm_mode_config_cleanup(dev);
 
         if (disp->dtor)
@@ -568,12 +562,138 @@ nouveau_display_destroy(struct drm_device *dev)
         kfree(disp);
 }
 
+static int
+nouveau_atomic_disable_connector(struct drm_atomic_state *state,
+                                 struct drm_connector *connector)
+{
+        struct drm_connector_state *connector_state;
+        struct drm_crtc *crtc;
+        struct drm_crtc_state *crtc_state;
+        struct drm_plane_state *plane_state;
+        struct drm_plane *plane;
+        int ret;
+
+        if (!(crtc = connector->state->crtc))
+                return 0;
+
+        connector_state = drm_atomic_get_connector_state(state, connector);
+        if (IS_ERR(connector_state))
+                return PTR_ERR(connector_state);
+
+        ret = drm_atomic_set_crtc_for_connector(connector_state, NULL);
+        if (ret)
+                return ret;
+
+        crtc_state = drm_atomic_get_crtc_state(state, crtc);
+        if (IS_ERR(crtc_state))
+                return PTR_ERR(crtc_state);
+
+        ret = drm_atomic_set_mode_for_crtc(crtc_state, NULL);
+        if (ret)
+                return ret;
+
+        crtc_state->active = false;
+
+        drm_for_each_plane_mask(plane, connector->dev, crtc_state->plane_mask) {
+                plane_state = drm_atomic_get_plane_state(state, plane);
+                if (IS_ERR(plane_state))
+                        return PTR_ERR(plane_state);
+
+                ret = drm_atomic_set_crtc_for_plane(plane_state, NULL);
+                if (ret)
+                        return ret;
+
+                drm_atomic_set_fb_for_plane(plane_state, NULL);
+        }
+
+        return 0;
+}
+
+static int
+nouveau_atomic_disable(struct drm_device *dev,
+                       struct drm_modeset_acquire_ctx *ctx)
+{
+        struct drm_atomic_state *state;
+        struct drm_connector *connector;
+        int ret;
+
+        state = drm_atomic_state_alloc(dev);
+        if (!state)
+                return -ENOMEM;
+
+        state->acquire_ctx = ctx;
+
+        drm_for_each_connector(connector, dev) {
+                ret = nouveau_atomic_disable_connector(state, connector);
+                if (ret)
+                        break;
+        }
+
+        if (ret == 0)
+                ret = drm_atomic_commit(state);
+        drm_atomic_state_put(state);
+        return ret;
+}
+
+static struct drm_atomic_state *
+nouveau_atomic_suspend(struct drm_device *dev)
+{
+        struct drm_modeset_acquire_ctx ctx;
+        struct drm_atomic_state *state;
+        int ret;
+
+        drm_modeset_acquire_init(&ctx, 0);
+
+retry:
+        ret = drm_modeset_lock_all_ctx(dev, &ctx);
+        if (ret < 0) {
+                state = ERR_PTR(ret);
+                goto unlock;
+        }
+
+        state = drm_atomic_helper_duplicate_state(dev, &ctx);
+        if (IS_ERR(state))
+                goto unlock;
+
+        ret = nouveau_atomic_disable(dev, &ctx);
+        if (ret < 0) {
+                drm_atomic_state_put(state);
+                state = ERR_PTR(ret);
+                goto unlock;
+        }
+
+unlock:
+        if (PTR_ERR(state) == -EDEADLK) {
+                drm_modeset_backoff(&ctx);
+                goto retry;
+        }
+
+        drm_modeset_drop_locks(&ctx);
+        drm_modeset_acquire_fini(&ctx);
+        return state;
+}
+
 int
 nouveau_display_suspend(struct drm_device *dev, bool runtime)
 {
+        struct nouveau_display *disp = nouveau_display(dev);
         struct drm_crtc *crtc;
 
-        nouveau_display_fini(dev);
+        if (dev->mode_config.funcs->atomic_commit) {
+                if (!runtime) {
+                        disp->suspend = nouveau_atomic_suspend(dev);
+                        if (IS_ERR(disp->suspend)) {
+                                int ret = PTR_ERR(disp->suspend);
+                                disp->suspend = NULL;
+                                return ret;
+                        }
+                }
+
+                nouveau_display_fini(dev, true);
+                return 0;
+        }
+
+        nouveau_display_fini(dev, true);
 
         list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
                 struct nouveau_framebuffer *nouveau_fb;
@@ -600,10 +720,20 @@ nouveau_display_suspend(struct drm_device *dev, bool runtime)
 void
 nouveau_display_resume(struct drm_device *dev, bool runtime)
 {
+        struct nouveau_display *disp = nouveau_display(dev);
         struct nouveau_drm *drm = nouveau_drm(dev);
         struct drm_crtc *crtc;
         int ret, head;
 
+        if (dev->mode_config.funcs->atomic_commit) {
+                nouveau_display_init(dev);
+                if (disp->suspend) {
+                        drm_atomic_helper_resume(dev, disp->suspend);
+                        disp->suspend = NULL;
+                }
+                return;
+        }
+
         /* re-pin fb/cursors */
         list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
                 struct nouveau_framebuffer *nouveau_fb;
@@ -692,10 +822,7 @@ nouveau_page_flip_emit(struct nouveau_channel *chan,
         if (ret)
                 goto fail;
 
-        if (drm->device.info.family < NV_DEVICE_INFO_V0_FERMI)
-                BEGIN_NV04(chan, NvSubSw, NV_SW_PAGE_FLIP, 1);
-        else
-                BEGIN_NVC0(chan, FermiSw, NV_SW_PAGE_FLIP, 1);
+        BEGIN_NV04(chan, NvSubSw, NV_SW_PAGE_FLIP, 1);
         OUT_RING  (chan, 0x00000000);
         FIRE_RING (chan);
 
@@ -724,6 +851,8 @@ nouveau_crtc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *fb,
         struct nouveau_channel *chan;
         struct nouveau_cli *cli;
         struct nouveau_fence *fence;
+        struct nv04_display *dispnv04 = nv04_display(dev);
+        int head = nouveau_crtc(crtc)->index;
         int ret;
 
         chan = drm->channel;
@@ -770,32 +899,23 @@ nouveau_crtc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *fb,
         drm_crtc_vblank_get(crtc);
 
         /* Emit a page flip */
-        if (drm->device.info.family >= NV_DEVICE_INFO_V0_TESLA) {
-                ret = nv50_display_flip_next(crtc, fb, chan, swap_interval);
+        if (swap_interval) {
+                ret = RING_SPACE(chan, 8);
                 if (ret)
                         goto fail_unreserve;
-        } else {
-                struct nv04_display *dispnv04 = nv04_display(dev);
-                int head = nouveau_crtc(crtc)->index;
-
-                if (swap_interval) {
-                        ret = RING_SPACE(chan, 8);
-                        if (ret)
-                                goto fail_unreserve;
-
-                        BEGIN_NV04(chan, NvSubImageBlit, 0x012c, 1);
-                        OUT_RING  (chan, 0);
-                        BEGIN_NV04(chan, NvSubImageBlit, 0x0134, 1);
-                        OUT_RING  (chan, head);
-                        BEGIN_NV04(chan, NvSubImageBlit, 0x0100, 1);
-                        OUT_RING  (chan, 0);
-                        BEGIN_NV04(chan, NvSubImageBlit, 0x0130, 1);
-                        OUT_RING  (chan, 0);
-                }
 
-                nouveau_bo_ref(new_bo, &dispnv04->image[head]);
+                BEGIN_NV04(chan, NvSubImageBlit, 0x012c, 1);
+                OUT_RING  (chan, 0);
+                BEGIN_NV04(chan, NvSubImageBlit, 0x0134, 1);
+                OUT_RING  (chan, head);
+                BEGIN_NV04(chan, NvSubImageBlit, 0x0100, 1);
+                OUT_RING  (chan, 0);
+                BEGIN_NV04(chan, NvSubImageBlit, 0x0130, 1);
+                OUT_RING  (chan, 0);
         }
 
+        nouveau_bo_ref(new_bo, &dispnv04->image[head]);
+
         ret = nouveau_page_flip_emit(chan, old_bo, new_bo, s, &fence);
         if (ret)
                 goto fail_unreserve;
@@ -843,16 +963,8 @@ nouveau_finish_page_flip(struct nouveau_channel *chan,
 
         s = list_first_entry(&fctx->flip, struct nouveau_page_flip_state, head);
         if (s->event) {
-                if (drm->device.info.family < NV_DEVICE_INFO_V0_TESLA) {
-                        drm_crtc_arm_vblank_event(s->crtc, s->event);
-                } else {
-                        drm_crtc_send_vblank_event(s->crtc, s->event);
-
-                        /* Give up ownership of vblank for page-flipped crtc */
-                        drm_crtc_vblank_put(s->crtc);
-                }
-        }
-        else {
+                drm_crtc_arm_vblank_event(s->crtc, s->event);
+        } else {
                 /* Give up ownership of vblank for page-flipped crtc */
                 drm_crtc_vblank_put(s->crtc);
         }
@@ -874,12 +986,10 @@ nouveau_flip_complete(struct nvif_notify *notify)
         struct nouveau_page_flip_state state;
 
         if (!nouveau_finish_page_flip(chan, &state)) {
-                if (drm->device.info.family < NV_DEVICE_INFO_V0_TESLA) {
-                        nv_set_crtc_base(drm->dev, drm_crtc_index(state.crtc),
-                                         state.offset + state.crtc->y *
-                                         state.pitch + state.crtc->x *
-                                         state.bpp / 8);
-                }
+                nv_set_crtc_base(drm->dev, drm_crtc_index(state.crtc),
+                                 state.offset + state.crtc->y *
+                                 state.pitch + state.crtc->x *
+                                 state.bpp / 8);
         }
 
         return NVIF_NOTIFY_KEEP;
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.h b/drivers/gpu/drm/nouveau/nouveau_display.h
index 0420ee861ea4..330fe0fc5c11 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.h
+++ b/drivers/gpu/drm/nouveau/nouveau_display.h
@@ -22,8 +22,9 @@ nouveau_framebuffer(struct drm_framebuffer *fb)
         return container_of(fb, struct nouveau_framebuffer, base);
 }
 
-int nouveau_framebuffer_init(struct drm_device *, struct nouveau_framebuffer *,
-                             const struct drm_mode_fb_cmd2 *, struct nouveau_bo *);
+int nouveau_framebuffer_new(struct drm_device *,
+                            const struct drm_mode_fb_cmd2 *,
+                            struct nouveau_bo *, struct nouveau_framebuffer **);
 
 struct nouveau_page_flip_state {
         struct list_head head;
@@ -39,9 +40,6 @@ struct nouveau_display {
         int  (*init)(struct drm_device *);
         void (*fini)(struct drm_device *);
 
-        int  (*fb_ctor)(struct drm_framebuffer *);
-        void (*fb_dtor)(struct drm_framebuffer *);
-
         struct nvif_object disp;
 
         struct drm_property *dithering_mode;
@@ -52,6 +50,8 @@ struct nouveau_display {
         /* not really hue and saturation: */
         struct drm_property *vibrant_hue_property;
         struct drm_property *color_vibrance_property;
+
+        struct drm_atomic_state *suspend;
 };
 
 static inline struct nouveau_display *
@@ -63,7 +63,7 @@ nouveau_display(struct drm_device *dev)
 int  nouveau_display_create(struct drm_device *dev);
 void nouveau_display_destroy(struct drm_device *dev);
 int  nouveau_display_init(struct drm_device *dev);
-void nouveau_display_fini(struct drm_device *dev);
+void nouveau_display_fini(struct drm_device *dev, bool suspend);
 int  nouveau_display_suspend(struct drm_device *dev, bool runtime);
 void nouveau_display_resume(struct drm_device *dev, bool runtime);
 int  nouveau_display_vblank_enable(struct drm_device *, unsigned int);
@@ -103,4 +103,7 @@ nouveau_backlight_exit(struct drm_device *dev) {
 }
 #endif
 
+struct drm_framebuffer *
+nouveau_user_framebuffer_create(struct drm_device *, struct drm_file *,
+                                const struct drm_mode_fb_cmd2 *);
 #endif
diff --git a/drivers/gpu/drm/nouveau/nouveau_dp.c b/drivers/gpu/drm/nouveau/nouveau_dp.c
index 87d52d36f4fc..0d052e1660f8 100644
--- a/drivers/gpu/drm/nouveau/nouveau_dp.c
+++ b/drivers/gpu/drm/nouveau/nouveau_dp.c
@@ -30,6 +30,13 @@
 #include "nouveau_encoder.h"
 #include "nouveau_crtc.h"
 
+#include <nvif/class.h>
+#include <nvif/cl5070.h>
+
+MODULE_PARM_DESC(mst, "Enable DisplayPort multi-stream (default: enabled)");
+static int nouveau_mst = 1;
+module_param_named(mst, nouveau_mst, int, 0400);
+
 static void
 nouveau_dp_probe_oui(struct drm_device *dev, struct nvkm_i2c_aux *aux, u8 *dpcd)
 {
@@ -55,14 +62,14 @@ nouveau_dp_detect(struct nouveau_encoder *nv_encoder)
         struct drm_device *dev = nv_encoder->base.base.dev;
         struct nouveau_drm *drm = nouveau_drm(dev);
         struct nvkm_i2c_aux *aux;
-        u8 *dpcd = nv_encoder->dp.dpcd;
+        u8 dpcd[8];
         int ret;
 
         aux = nv_encoder->aux;
         if (!aux)
                 return -ENODEV;
 
-        ret = nvkm_rdaux(aux, DP_DPCD_REV, dpcd, 8);
+        ret = nvkm_rdaux(aux, DP_DPCD_REV, dpcd, sizeof(dpcd));
         if (ret)
                 return ret;
 
@@ -84,5 +91,11 @@ nouveau_dp_detect(struct nouveau_encoder *nv_encoder)
                      nv_encoder->dp.link_nr, nv_encoder->dp.link_bw);
 
         nouveau_dp_probe_oui(dev, aux, dpcd);
-        return 0;
+
+        ret = nv50_mstm_detect(nv_encoder->dp.mstm, dpcd, nouveau_mst);
+        if (ret == 1)
+                return NOUVEAU_DP_MST;
+        if (ret == 0)
+                return NOUVEAU_DP_SST;
+        return ret;
 }
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 6adf94789417..9876e6fcfcf0 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -519,7 +519,7 @@ nouveau_drm_unload(struct drm_device *dev)
         nouveau_debugfs_fini(drm);
 
         if (dev->mode_config.num_crtc)
-                nouveau_display_fini(dev);
+                nouveau_display_fini(dev, false);
         nouveau_display_destroy(dev);
 
         nouveau_bios_takedown(dev);
@@ -1037,6 +1037,7 @@ static void nouveau_display_options(void)
         DRM_DEBUG_DRIVER("... modeset      : %d\n", nouveau_modeset);
         DRM_DEBUG_DRIVER("... runpm        : %d\n", nouveau_runtime_pm);
         DRM_DEBUG_DRIVER("... vram_pushbuf : %d\n", nouveau_vram_pushbuf);
+        DRM_DEBUG_DRIVER("... hdmimhz      : %d\n", nouveau_hdmimhz);
 }
 
 static const struct dev_pm_ops nouveau_pm_ops = {
diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.h b/drivers/gpu/drm/nouveau/nouveau_drv.h
index c0e2b3207503..4cd47bae73c7 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drv.h
+++ b/drivers/gpu/drm/nouveau/nouveau_drv.h
@@ -204,6 +204,10 @@ void nouveau_drm_device_remove(struct drm_device *dev);
         if (unlikely(drm_debug & DRM_UT_DRIVER))                               \
                 NV_PRINTK(info, &(drm)->client, f, ##a);                       \
 } while(0)
+#define NV_ATOMIC(drm,f,a...) do {                                             \
+        if (unlikely(drm_debug & DRM_UT_ATOMIC))                               \
+                NV_PRINTK(info, &(drm)->client, f, ##a);                       \
+} while(0)
 
 extern int nouveau_modeset;
 
diff --git a/drivers/gpu/drm/nouveau/nouveau_encoder.h b/drivers/gpu/drm/nouveau/nouveau_encoder.h
index ee6a6d3fc80f..198e5f27682f 100644
--- a/drivers/gpu/drm/nouveau/nouveau_encoder.h
+++ b/drivers/gpu/drm/nouveau/nouveau_encoder.h
@@ -30,6 +30,7 @@
 #include <subdev/bios/dcb.h>
 
 #include <drm/drm_encoder_slave.h>
+#include <drm/drm_dp_mst_helper.h>
 #include "dispnv04/disp.h"
 
 #define NV_DPMS_CLEARED 0x80
@@ -57,15 +58,16 @@ struct nouveau_encoder {
 
         union {
                 struct {
-                        u8  dpcd[8];
+                        struct nv50_mstm *mstm;
                         int link_nr;
                         int link_bw;
-                        u32 datarate;
                 } dp;
         };
 
         void (*enc_save)(struct drm_encoder *encoder);
         void (*enc_restore)(struct drm_encoder *encoder);
+        void (*update)(struct nouveau_encoder *, u8 head,
+                       struct drm_display_mode *, u8 proto, u8 depth);
 };
 
 struct nouveau_encoder *
@@ -90,9 +92,17 @@ get_slave_funcs(struct drm_encoder *enc)
 }
 
 /* nouveau_dp.c */
+enum nouveau_dp_status {
+        NOUVEAU_DP_SST,
+        NOUVEAU_DP_MST,
+};
+
 int nouveau_dp_detect(struct nouveau_encoder *);
 
 struct nouveau_connector *
 nouveau_encoder_connector_get(struct nouveau_encoder *encoder);
 
+int nv50_mstm_detect(struct nv50_mstm *, u8 dpcd[8], int allow);
+void nv50_mstm_remove(struct nv50_mstm *);
+void nv50_mstm_service(struct nv50_mstm *);
 #endif /* __NOUVEAU_ENCODER_H__ */
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
index 9f5692726c16..cc8c58337981 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
@@ -58,7 +58,7 @@ static void
 nouveau_fbcon_fillrect(struct fb_info *info, const struct fb_fillrect *rect)
 {
         struct nouveau_fbdev *fbcon = info->par;
-        struct nouveau_drm *drm = nouveau_drm(fbcon->dev);
+        struct nouveau_drm *drm = nouveau_drm(fbcon->helper.dev);
         struct nvif_device *device = &drm->device;
         int ret;
 
@@ -90,7 +90,7 @@ static void
 nouveau_fbcon_copyarea(struct fb_info *info, const struct fb_copyarea *image)
 {
         struct nouveau_fbdev *fbcon = info->par;
-        struct nouveau_drm *drm = nouveau_drm(fbcon->dev);
+        struct nouveau_drm *drm = nouveau_drm(fbcon->helper.dev);
         struct nvif_device *device = &drm->device;
         int ret;
 
@@ -122,7 +122,7 @@ static void
 nouveau_fbcon_imageblit(struct fb_info *info, const struct fb_image *image)
 {
         struct nouveau_fbdev *fbcon = info->par;
-        struct nouveau_drm *drm = nouveau_drm(fbcon->dev);
+        struct nouveau_drm *drm = nouveau_drm(fbcon->helper.dev);
         struct nvif_device *device = &drm->device;
         int ret;
 
@@ -154,7 +154,7 @@ static int
 nouveau_fbcon_sync(struct fb_info *info)
 {
         struct nouveau_fbdev *fbcon = info->par;
-        struct nouveau_drm *drm = nouveau_drm(fbcon->dev);
+        struct nouveau_drm *drm = nouveau_drm(fbcon->helper.dev);
         struct nouveau_channel *chan = drm->channel;
         int ret;
 
@@ -181,7 +181,7 @@ static int
 nouveau_fbcon_open(struct fb_info *info, int user)
 {
         struct nouveau_fbdev *fbcon = info->par;
-        struct nouveau_drm *drm = nouveau_drm(fbcon->dev);
+        struct nouveau_drm *drm = nouveau_drm(fbcon->helper.dev);
         int ret = pm_runtime_get_sync(drm->dev->dev);
         if (ret < 0 && ret != -EACCES)
                 return ret;
@@ -192,7 +192,7 @@ static int
 nouveau_fbcon_release(struct fb_info *info, int user)
 {
         struct nouveau_fbdev *fbcon = info->par;
-        struct nouveau_drm *drm = nouveau_drm(fbcon->dev);
+        struct nouveau_drm *drm = nouveau_drm(fbcon->helper.dev);
         pm_runtime_put(drm->dev->dev);
         return 0;
 }
@@ -333,16 +333,15 @@ nouveau_fbcon_create(struct drm_fb_helper *helper,
 {
         struct nouveau_fbdev *fbcon =
                 container_of(helper, struct nouveau_fbdev, helper);
-        struct drm_device *dev = fbcon->dev;
+        struct drm_device *dev = fbcon->helper.dev;
         struct nouveau_drm *drm = nouveau_drm(dev);
         struct nvif_device *device = &drm->device;
         struct fb_info *info;
-        struct drm_framebuffer *fb;
-        struct nouveau_framebuffer *nouveau_fb;
+        struct nouveau_framebuffer *fb;
         struct nouveau_channel *chan;
         struct nouveau_bo *nvbo;
         struct drm_mode_fb_cmd2 mode_cmd;
-        int size, ret;
+        int ret;
 
         mode_cmd.width = sizes->surface_width;
         mode_cmd.height = sizes->surface_height;
@@ -353,16 +352,17 @@ nouveau_fbcon_create(struct drm_fb_helper *helper,
         mode_cmd.pixel_format = drm_mode_legacy_fb_format(sizes->surface_bpp,
                                                           sizes->surface_depth);
 
-        size = mode_cmd.pitches[0] * mode_cmd.height;
-        size = roundup(size, PAGE_SIZE);
-
-        ret = nouveau_gem_new(dev, size, 0, NOUVEAU_GEM_DOMAIN_VRAM,
-                              0, 0x0000, &nvbo);
+        ret = nouveau_gem_new(dev, mode_cmd.pitches[0] * mode_cmd.height,
+                              0, NOUVEAU_GEM_DOMAIN_VRAM, 0, 0x0000, &nvbo);
         if (ret) {
                 NV_ERROR(drm, "failed to allocate framebuffer\n");
                 goto out;
         }
 
+        ret = nouveau_framebuffer_new(dev, &mode_cmd, nvbo, &fb);
+        if (ret)
+                goto out_unref;
+
         ret = nouveau_bo_pin(nvbo, TTM_PL_FLAG_VRAM, false);
         if (ret) {
                 NV_ERROR(drm, "failed to pin fb: %d\n", ret);
@@ -377,8 +377,7 @@ nouveau_fbcon_create(struct drm_fb_helper *helper,
 
         chan = nouveau_nofbaccel ? NULL : drm->channel;
         if (chan && device->info.family >= NV_DEVICE_INFO_V0_TESLA) {
-                ret = nouveau_bo_vma_add(nvbo, drm->client.vm,
-                                        &fbcon->nouveau_fb.vma);
+                ret = nouveau_bo_vma_add(nvbo, drm->client.vm, &fb->vma);
                 if (ret) {
                         NV_ERROR(drm, "failed to map fb into chan: %d\n", ret);
                         chan = NULL;
@@ -394,13 +393,8 @@ nouveau_fbcon_create(struct drm_fb_helper *helper,
 
         info->par = fbcon;
 
-        nouveau_framebuffer_init(dev, &fbcon->nouveau_fb, &mode_cmd, nvbo);
-
-        nouveau_fb = &fbcon->nouveau_fb;
-        fb = &nouveau_fb->base;
-
         /* setup helper */
-        fbcon->helper.fb = fb;
+        fbcon->helper.fb = &fb->base;
 
         strcpy(info->fix.id, "nouveaufb");
         if (!chan)
@@ -411,14 +405,14 @@ nouveau_fbcon_create(struct drm_fb_helper *helper,
                               FBINFO_HWACCEL_IMAGEBLIT;
         info->flags |= FBINFO_CAN_FORCE_OUTPUT;
         info->fbops = &nouveau_fbcon_sw_ops;
-        info->fix.smem_start = nvbo->bo.mem.bus.base +
-                               nvbo->bo.mem.bus.offset;
-        info->fix.smem_len = size;
+        info->fix.smem_start = fb->nvbo->bo.mem.bus.base +
+                               fb->nvbo->bo.mem.bus.offset;
+        info->fix.smem_len = fb->nvbo->bo.mem.num_pages << PAGE_SHIFT;
 
-        info->screen_base = nvbo_kmap_obj_iovirtual(nouveau_fb->nvbo);
-        info->screen_size = size;
+        info->screen_base = nvbo_kmap_obj_iovirtual(fb->nvbo);
+        info->screen_size = fb->nvbo->bo.mem.num_pages << PAGE_SHIFT;
 
-        drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth);
+        drm_fb_helper_fill_fix(info, fb->base.pitches[0], fb->base.depth);
         drm_fb_helper_fill_var(info, &fbcon->helper, sizes->fb_width, sizes->fb_height);
 
         /* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */
@@ -429,20 +423,19 @@ nouveau_fbcon_create(struct drm_fb_helper *helper,
 
         /* To allow resizeing without swapping buffers */
         NV_INFO(drm, "allocated %dx%d fb: 0x%llx, bo %p\n",
-                nouveau_fb->base.width, nouveau_fb->base.height,
-                nvbo->bo.offset, nvbo);
+                fb->base.width, fb->base.height, fb->nvbo->bo.offset, nvbo);
 
         vga_switcheroo_client_fb_set(dev->pdev, info);
         return 0;
 
 out_unlock:
         if (chan)
-                nouveau_bo_vma_del(nvbo, &fbcon->nouveau_fb.vma);
-        nouveau_bo_unmap(nvbo);
+                nouveau_bo_vma_del(fb->nvbo, &fb->vma);
+        nouveau_bo_unmap(fb->nvbo);
 out_unpin:
-        nouveau_bo_unpin(nvbo);
+        nouveau_bo_unpin(fb->nvbo);
 out_unref:
-        nouveau_bo_ref(NULL, &nvbo);
+        nouveau_bo_ref(NULL, &fb->nvbo);
 out:
         return ret;
 }
@@ -458,28 +451,26 @@ nouveau_fbcon_output_poll_changed(struct drm_device *dev)
 static int
 nouveau_fbcon_destroy(struct drm_device *dev, struct nouveau_fbdev *fbcon)
 {
-        struct nouveau_framebuffer *nouveau_fb = &fbcon->nouveau_fb;
+        struct nouveau_framebuffer *nouveau_fb = nouveau_framebuffer(fbcon->helper.fb);
 
         drm_fb_helper_unregister_fbi(&fbcon->helper);
         drm_fb_helper_release_fbi(&fbcon->helper);
+        drm_fb_helper_fini(&fbcon->helper);
 
         if (nouveau_fb->nvbo) {
-                nouveau_bo_unmap(nouveau_fb->nvbo);
                 nouveau_bo_vma_del(nouveau_fb->nvbo, &nouveau_fb->vma);
+                nouveau_bo_unmap(nouveau_fb->nvbo);
                 nouveau_bo_unpin(nouveau_fb->nvbo);
-                drm_gem_object_unreference_unlocked(&nouveau_fb->nvbo->gem);
-                nouveau_fb->nvbo = NULL;
+                drm_framebuffer_unreference(&nouveau_fb->base);
         }
-        drm_fb_helper_fini(&fbcon->helper);
-        drm_framebuffer_unregister_private(&nouveau_fb->base);
-        drm_framebuffer_cleanup(&nouveau_fb->base);
+
         return 0;
 }
 
 void nouveau_fbcon_gpu_lockup(struct fb_info *info)
 {
         struct nouveau_fbdev *fbcon = info->par;
-        struct nouveau_drm *drm = nouveau_drm(fbcon->dev);
+        struct nouveau_drm *drm = nouveau_drm(fbcon->helper.dev);
 
         NV_ERROR(drm, "GPU lockup - switching to software fbcon\n");
         info->flags |= FBINFO_HWACCEL_DISABLED;
@@ -522,7 +513,6 @@ nouveau_fbcon_init(struct drm_device *dev)
         if (!fbcon)
                 return -ENOMEM;
 
-        fbcon->dev = dev;
         drm->fbcon = fbcon;
 
         drm_fb_helper_prepare(dev, &fbcon->helper, &nouveau_fbcon_helper_funcs);
@@ -545,7 +535,8 @@ nouveau_fbcon_init(struct drm_device *dev)
                 preferred_bpp = 32;
 
         /* disable all the possible outputs/crtcs before entering KMS mode */
-        drm_helper_disable_unused_functions(dev);
+        if (!dev->mode_config.funcs->atomic_commit)
+                drm_helper_disable_unused_functions(dev);
 
         ret = drm_fb_helper_initial_config(&fbcon->helper, preferred_bpp);
         if (ret)
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.h b/drivers/gpu/drm/nouveau/nouveau_fbcon.h
index ca77ad001978..e2bca729721e 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fbcon.h
+++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.h
@@ -33,8 +33,6 @@
 
 struct nouveau_fbdev {
         struct drm_fb_helper helper;
-        struct nouveau_framebuffer nouveau_fb;
-        struct drm_device *dev;
         unsigned int saved_flags;
         struct nvif_object surf2d;
         struct nvif_object clip;
diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c
index e9529ee6bc23..f2f348f0160c 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fence.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
@@ -586,5 +586,5 @@ static const struct dma_fence_ops nouveau_fence_ops_uevent = {
         .enable_signaling = nouveau_fence_enable_signaling,
         .signaled = nouveau_fence_is_signaled,
         .wait = dma_fence_default_wait,
-        .release = NULL
+        .release = nouveau_fence_release
 };
diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.h b/drivers/gpu/drm/nouveau/nouveau_fence.h
index 41f3c019e534..ccdce1b4eec4 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fence.h
+++ b/drivers/gpu/drm/nouveau/nouveau_fence.h
@@ -92,7 +92,6 @@ struct nv84_fence_chan {
         struct nouveau_fence_chan base;
         struct nvkm_vma vma;
         struct nvkm_vma vma_gart;
-        struct nvkm_vma dispc_vma[4];
 };
 
 struct nv84_fence_priv {
@@ -102,7 +101,6 @@ struct nv84_fence_priv {
         u32 *suspend;
 };
 
-u64  nv84_fence_crtc(struct nouveau_channel *, int);
 int  nv84_fence_context_new(struct nouveau_channel *);
 
 #endif
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c
index 7f083c95f422..201b52b750dd 100644
--- a/drivers/gpu/drm/nouveau/nouveau_gem.c
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.c
@@ -369,7 +369,7 @@ validate_init(struct nouveau_channel *chan, struct drm_file *file_priv,
 {
         struct nouveau_cli *cli = nouveau_cli(file_priv);
         int trycnt = 0;
-        int ret, i;
+        int ret = -EINVAL, i;
         struct nouveau_bo *res_bo = NULL;
         LIST_HEAD(gart_list);
         LIST_HEAD(vram_list);
diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c
index 1825dbc33192..a6dbe8258040 100644
--- a/drivers/gpu/drm/nouveau/nouveau_ttm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c
@@ -398,6 +398,9 @@ nouveau_ttm_init(struct nouveau_drm *drm)
         /* VRAM init */
         drm->gem.vram_available = drm->device.info.ram_user;
 
+        arch_io_reserve_memtype_wc(device->func->resource_addr(device, 1),
+                                   device->func->resource_size(device, 1));
+
         ret = ttm_bo_init_mm(&drm->ttm.bdev, TTM_PL_VRAM,
                               drm->gem.vram_available >> PAGE_SHIFT);
         if (ret) {
@@ -430,6 +433,8 @@ nouveau_ttm_init(struct nouveau_drm *drm)
 void
 nouveau_ttm_fini(struct nouveau_drm *drm)
 {
+        struct nvkm_device *device = nvxx_device(&drm->device);
+
         ttm_bo_clean_mm(&drm->ttm.bdev, TTM_PL_VRAM);
         ttm_bo_clean_mm(&drm->ttm.bdev, TTM_PL_TT);
 
@@ -439,4 +444,7 @@ nouveau_ttm_fini(struct nouveau_drm *drm)
 
         arch_phys_wc_del(drm->ttm.mtrr);
         drm->ttm.mtrr = 0;
+        arch_io_free_memtype_wc(device->func->resource_addr(device, 1),
+                                device->func->resource_size(device, 1));
+
 }
diff --git a/drivers/gpu/drm/nouveau/nv04_fbcon.c b/drivers/gpu/drm/nouveau/nv04_fbcon.c
index da8fd5ff9d0f..6a2b187e3c3b 100644
--- a/drivers/gpu/drm/nouveau/nv04_fbcon.c
+++ b/drivers/gpu/drm/nouveau/nv04_fbcon.c
@@ -30,7 +30,7 @@ int
 nv04_fbcon_copyarea(struct fb_info *info, const struct fb_copyarea *region)
 {
         struct nouveau_fbdev *nfbdev = info->par;
-        struct nouveau_drm *drm = nouveau_drm(nfbdev->dev);
+        struct nouveau_drm *drm = nouveau_drm(nfbdev->helper.dev);
         struct nouveau_channel *chan = drm->channel;
         int ret;
 
@@ -50,7 +50,7 @@ int
 nv04_fbcon_fillrect(struct fb_info *info, const struct fb_fillrect *rect)
 {
         struct nouveau_fbdev *nfbdev = info->par;
-        struct nouveau_drm *drm = nouveau_drm(nfbdev->dev);
+        struct nouveau_drm *drm = nouveau_drm(nfbdev->helper.dev);
         struct nouveau_channel *chan = drm->channel;
         int ret;
 
@@ -77,7 +77,7 @@ int
 nv04_fbcon_imageblit(struct fb_info *info, const struct fb_image *image)
 {
         struct nouveau_fbdev *nfbdev = info->par;
-        struct nouveau_drm *drm = nouveau_drm(nfbdev->dev);
+        struct nouveau_drm *drm = nouveau_drm(nfbdev->helper.dev);
         struct nouveau_channel *chan = drm->channel;
         uint32_t fg;
         uint32_t bg;
@@ -133,7 +133,7 @@ int
 nv04_fbcon_accel_init(struct fb_info *info)
 {
         struct nouveau_fbdev *nfbdev = info->par;
-        struct drm_device *dev = nfbdev->dev;
+        struct drm_device *dev = nfbdev->helper.dev;
         struct nouveau_drm *drm = nouveau_drm(dev);
         struct nouveau_channel *chan = drm->channel;
         struct nvif_device *device = &drm->device;
diff --git a/drivers/gpu/drm/nouveau/nv10_fence.c b/drivers/gpu/drm/nouveau/nv10_fence.c
index f99fcf56928a..2998bde29211 100644
--- a/drivers/gpu/drm/nouveau/nv10_fence.c
+++ b/drivers/gpu/drm/nouveau/nv10_fence.c
@@ -57,16 +57,13 @@ void
 nv10_fence_context_del(struct nouveau_channel *chan)
 {
         struct nv10_fence_chan *fctx = chan->fence;
-        int i;
         nouveau_fence_context_del(&fctx->base);
-        for (i = 0; i < ARRAY_SIZE(fctx->head); i++)
-                nvif_object_fini(&fctx->head[i]);
         nvif_object_fini(&fctx->sema);
         chan->fence = NULL;
         nouveau_fence_context_free(&fctx->base);
 }
 
-int
+static int
 nv10_fence_context_new(struct nouveau_channel *chan)
 {
         struct nv10_fence_chan *fctx;
diff --git a/drivers/gpu/drm/nouveau/nv10_fence.h b/drivers/gpu/drm/nouveau/nv10_fence.h
index a87259f3983a..b7a508585304 100644
--- a/drivers/gpu/drm/nouveau/nv10_fence.h
+++ b/drivers/gpu/drm/nouveau/nv10_fence.h
@@ -7,7 +7,6 @@
 struct nv10_fence_chan {
         struct nouveau_fence_chan base;
         struct nvif_object sema;
-        struct nvif_object head[4];
 };
 
 struct nv10_fence_priv {
diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c
index 7d0edcbcfca7..a9855a4ec532 100644
--- a/drivers/gpu/drm/nouveau/nv50_display.c
+++ b/drivers/gpu/drm/nouveau/nv50_display.c
@@ -25,10 +25,12 @@
 #include <linux/dma-mapping.h>
 
 #include <drm/drmP.h>
+#include <drm/drm_atomic.h>
+#include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc_helper.h>
-#include <drm/drm_plane_helper.h>
 #include <drm/drm_dp_helper.h>
 #include <drm/drm_fb_helper.h>
+#include <drm/drm_plane_helper.h>
 
 #include <nvif/class.h>
 #include <nvif/cl0002.h>
@@ -38,6 +40,7 @@
 #include <nvif/cl507c.h>
 #include <nvif/cl507d.h>
 #include <nvif/cl507e.h>
+#include <nvif/event.h>
 
 #include "nouveau_drv.h"
 #include "nouveau_dma.h"
@@ -46,6 +49,7 @@
 #include "nouveau_encoder.h"
 #include "nouveau_crtc.h"
 #include "nouveau_fence.h"
+#include "nouveau_fbcon.h"
 #include "nv50_display.h"
 
 #define EVO_DMA_NR 9
@@ -61,6 +65,227 @@
 #define EVO_MAST_NTFY     EVO_SYNC(      0, 0x00)
 #define EVO_FLIP_SEM0(c)  EVO_SYNC((c) + 1, 0x00)
 #define EVO_FLIP_SEM1(c)  EVO_SYNC((c) + 1, 0x10)
+#define EVO_FLIP_NTFY0(c) EVO_SYNC((c) + 1, 0x20)
+#define EVO_FLIP_NTFY1(c) EVO_SYNC((c) + 1, 0x30)
+
+/******************************************************************************
+ * Atomic state
+ *****************************************************************************/
+#define nv50_atom(p) container_of((p), struct nv50_atom, state)
+
+struct nv50_atom {
+        struct drm_atomic_state state;
+
+        struct list_head outp;
+        bool lock_core;
+        bool flush_disable;
+};
+
+struct nv50_outp_atom {
+        struct list_head head;
+
+        struct drm_encoder *encoder;
+        bool flush_disable;
+
+        union {
+                struct {
+                        bool ctrl:1;
+                };
+                u8 mask;
+        } clr;
+
+        union {
+                struct {
+                        bool ctrl:1;
+                };
+                u8 mask;
+        } set;
+};
+
+#define nv50_head_atom(p) container_of((p), struct nv50_head_atom, state)
+
+struct nv50_head_atom {
+        struct drm_crtc_state state;
+
+        struct {
+                u16 iW;
+                u16 iH;
+                u16 oW;
+                u16 oH;
+        } view;
+
+        struct nv50_head_mode {
+                bool interlace;
+                u32 clock;
+                struct {
+                        u16 active;
+                        u16 synce;
+                        u16 blanke;
+                        u16 blanks;
+                } h;
+                struct {
+                        u32 active;
+                        u16 synce;
+                        u16 blanke;
+                        u16 blanks;
+                        u16 blank2s;
+                        u16 blank2e;
+                        u16 blankus;
+                } v;
+        } mode;
+
+        struct {
+                u32 handle;
+                u64 offset:40;
+        } lut;
+
+        struct {
+                bool visible;
+                u32 handle;
+                u64 offset:40;
+                u8  format;
+                u8  kind:7;
+                u8  layout:1;
+                u8  block:4;
+                u32 pitch:20;
+                u16 x;
+                u16 y;
+                u16 w;
+                u16 h;
+        } core;
+
+        struct {
+                bool visible;
+                u32 handle;
+                u64 offset:40;
+                u8  layout:1;
+                u8  format:1;
+        } curs;
+
+        struct {
+                u8  depth;
+                u8  cpp;
+                u16 x;
+                u16 y;
+                u16 w;
+                u16 h;
+        } base;
+
+        struct {
+                u8 cpp;
+        } ovly;
+
+        struct {
+                bool enable:1;
+                u8 bits:2;
+                u8 mode:4;
+        } dither;
+
+        struct {
+                struct {
+                        u16 cos:12;
+                        u16 sin:12;
+                } sat;
+        } procamp;
+
+        union {
+                struct {
+                        bool core:1;
+                        bool curs:1;
+                };
+                u8 mask;
+        } clr;
+
+        union {
+                struct {
+                        bool core:1;
+                        bool curs:1;
+                        bool view:1;
+                        bool mode:1;
+                        bool base:1;
+                        bool ovly:1;
+                        bool dither:1;
+                        bool procamp:1;
+                };
+                u16 mask;
+        } set;
+};
+
+static inline struct nv50_head_atom *
+nv50_head_atom_get(struct drm_atomic_state *state, struct drm_crtc *crtc)
+{
+        struct drm_crtc_state *statec = drm_atomic_get_crtc_state(state, crtc);
+        if (IS_ERR(statec))
+                return (void *)statec;
+        return nv50_head_atom(statec);
+}
+
+#define nv50_wndw_atom(p) container_of((p), struct nv50_wndw_atom, state)
+
+struct nv50_wndw_atom {
+        struct drm_plane_state state;
+        u8 interval;
+
+        struct drm_rect clip;
+
+        struct {
+                u32  handle;
+                u16  offset:12;
+                bool awaken:1;
+        } ntfy;
+
+        struct {
+                u32 handle;
+                u16 offset:12;
+                u32 acquire;
+                u32 release;
+        } sema;
+
+        struct {
+                u8 enable:2;
+        } lut;
+
+        struct {
+                u8  mode:2;
+                u8  interval:4;
+
+                u8  format;
+                u8  kind:7;
+                u8  layout:1;
+                u8  block:4;
+                u32 pitch:20;
+                u16 w;
+                u16 h;
+
+                u32 handle;
+                u64 offset;
+        } image;
+
+        struct {
+                u16 x;
+                u16 y;
+        } point;
+
+        union {
+                struct {
+                        bool ntfy:1;
+                        bool sema:1;
+                        bool image:1;
+                };
+                u8 mask;
+        } clr;
+
+        union {
+                struct {
+                        bool ntfy:1;
+                        bool sema:1;
+                        bool image:1;
+                        bool lut:1;
+                        bool point:1;
+                };
+                u8 mask;
+        } set;
+};
 
 /******************************************************************************
  * EVO channel
@@ -133,34 +358,6 @@ nv50_pioc_create(struct nvif_device *device, struct nvif_object *disp,
 }
 
 /******************************************************************************
- * Cursor Immediate
- *****************************************************************************/
-
-struct nv50_curs {
-        struct nv50_pioc base;
-};
-
-static int
-nv50_curs_create(struct nvif_device *device, struct nvif_object *disp,
-                 int head, struct nv50_curs *curs)
-{
-        struct nv50_disp_cursor_v0 args = {
-                .head = head,
-        };
-        static const s32 oclass[] = {
-                GK104_DISP_CURSOR,
-                GF110_DISP_CURSOR,
-                GT214_DISP_CURSOR,
-                G82_DISP_CURSOR,
-                NV50_DISP_CURSOR,
-                0
-        };
-
-        return nv50_pioc_create(device, disp, oclass, head, &args, sizeof(args),
-                                &curs->base);
-}
-
-/******************************************************************************
  * Overlay Immediate
  *****************************************************************************/
 
@@ -192,6 +389,11 @@ nv50_oimm_create(struct nvif_device *device, struct nvif_object *disp,
  * DMA EVO channel
  *****************************************************************************/
 
+struct nv50_dmac_ctxdma {
+        struct list_head head;
+        struct nvif_object object;
+};
+
 struct nv50_dmac {
         struct nv50_chan base;
         dma_addr_t handle;
@@ -199,6 +401,7 @@ struct nv50_dmac {
 
         struct nvif_object sync;
         struct nvif_object vram;
+        struct list_head ctxdma;
 
         /* Protects against concurrent pushbuf access to this channel, lock is
          * grabbed by evo_wait (if the pushbuf reservation is successful) and
@@ -207,9 +410,82 @@ struct nv50_dmac {
 };
 
 static void
+nv50_dmac_ctxdma_del(struct nv50_dmac_ctxdma *ctxdma)
+{
+        nvif_object_fini(&ctxdma->object);
+        list_del(&ctxdma->head);
+        kfree(ctxdma);
+}
+
+static struct nv50_dmac_ctxdma *
+nv50_dmac_ctxdma_new(struct nv50_dmac *dmac, struct nouveau_framebuffer *fb)
+{
+        struct nouveau_drm *drm = nouveau_drm(fb->base.dev);
+        struct nv50_dmac_ctxdma *ctxdma;
+        const u8    kind = (fb->nvbo->tile_flags & 0x0000ff00) >> 8;
+        const u32 handle = 0xfb000000 | kind;
+        struct {
+                struct nv_dma_v0 base;
+                union {
+                        struct nv50_dma_v0 nv50;
+                        struct gf100_dma_v0 gf100;
+                        struct gf119_dma_v0 gf119;
+                };
+        } args = {};
+        u32 argc = sizeof(args.base);
+        int ret;
+
+        list_for_each_entry(ctxdma, &dmac->ctxdma, head) {
+                if (ctxdma->object.handle == handle)
+                        return ctxdma;
+        }
+
+        if (!(ctxdma = kzalloc(sizeof(*ctxdma), GFP_KERNEL)))
+                return ERR_PTR(-ENOMEM);
+        list_add(&ctxdma->head, &dmac->ctxdma);
+
+        args.base.target = NV_DMA_V0_TARGET_VRAM;
+        args.base.access = NV_DMA_V0_ACCESS_RDWR;
+        args.base.start  = 0;
+        args.base.limit  = drm->device.info.ram_user - 1;
+
+        if (drm->device.info.chipset < 0x80) {
+                args.nv50.part = NV50_DMA_V0_PART_256;
+                argc += sizeof(args.nv50);
+        } else
+        if (drm->device.info.chipset < 0xc0) {
+                args.nv50.part = NV50_DMA_V0_PART_256;
+                args.nv50.kind = kind;
+                argc += sizeof(args.nv50);
+        } else
+        if (drm->device.info.chipset < 0xd0) {
+                args.gf100.kind = kind;
+                argc += sizeof(args.gf100);
+        } else {
+                args.gf119.page = GF119_DMA_V0_PAGE_LP;
+                args.gf119.kind = kind;
+                argc += sizeof(args.gf119);
+        }
+
+        ret = nvif_object_init(&dmac->base.user, handle, NV_DMA_IN_MEMORY,
+                               &args, argc, &ctxdma->object);
+        if (ret) {
+                nv50_dmac_ctxdma_del(ctxdma);
+                return ERR_PTR(ret);
+        }
+
+        return ctxdma;
+}
+
+static void
 nv50_dmac_destroy(struct nv50_dmac *dmac, struct nvif_object *disp)
 {
         struct nvif_device *device = dmac->base.device;
+        struct nv50_dmac_ctxdma *ctxdma, *ctxtmp;
+
+        list_for_each_entry_safe(ctxdma, ctxtmp, &dmac->ctxdma, head) {
+                nv50_dmac_ctxdma_del(ctxdma);
+        }
 
         nvif_object_fini(&dmac->vram);
         nvif_object_fini(&dmac->sync);
@@ -278,6 +554,7 @@ nv50_dmac_create(struct nvif_device *device, struct nvif_object *disp,
         if (ret)
                 return ret;
 
+        INIT_LIST_HEAD(&dmac->ctxdma);
         return ret;
 }
 
@@ -381,34 +658,23 @@ nv50_ovly_create(struct nvif_device *device, struct nvif_object *disp,
 
 struct nv50_head {
         struct nouveau_crtc base;
-        struct nouveau_bo *image;
-        struct nv50_curs curs;
-        struct nv50_sync sync;
         struct nv50_ovly ovly;
         struct nv50_oimm oimm;
 };
 
 #define nv50_head(c) ((struct nv50_head *)nouveau_crtc(c))
-#define nv50_curs(c) (&nv50_head(c)->curs)
-#define nv50_sync(c) (&nv50_head(c)->sync)
 #define nv50_ovly(c) (&nv50_head(c)->ovly)
 #define nv50_oimm(c) (&nv50_head(c)->oimm)
 #define nv50_chan(c) (&(c)->base.base)
 #define nv50_vers(c) nv50_chan(c)->user.oclass
 
-struct nv50_fbdma {
-        struct list_head head;
-        struct nvif_object core;
-        struct nvif_object base[4];
-};
-
 struct nv50_disp {
         struct nvif_object *disp;
         struct nv50_mast mast;
 
-        struct list_head fbdma;
-
         struct nouveau_bo *sync;
+
+        struct mutex mutex;
 };
 
 static struct nv50_disp *
@@ -419,12 +685,6 @@ nv50_disp(struct drm_device *dev)
 
 #define nv50_mast(d) (&nv50_disp(d)->mast)
 
-static struct drm_crtc *
-nv50_display_crtc_get(struct drm_encoder *encoder)
-{
-        return nouveau_encoder(encoder)->crtc;
-}
-
 /******************************************************************************
  * EVO channel helpers
  *****************************************************************************/
@@ -463,812 +723,1460 @@ evo_kick(u32 *push, void *evoc)
         mutex_unlock(&dmac->lock);
 }
 
-#if 1
-#define evo_mthd(p,m,s) *((p)++) = (((s) << 18) | (m))
-#define evo_data(p,d)   *((p)++) = (d)
-#else
 #define evo_mthd(p,m,s) do {                                                   \
         const u32 _m = (m), _s = (s);                                          \
-        printk(KERN_ERR "%04x %d %s\n", _m, _s, __func__);                     \
+        if (drm_debug & DRM_UT_KMS)                                            \
+                printk(KERN_ERR "%04x %d %s\n", _m, _s, __func__);             \
         *((p)++) = ((_s << 18) | _m);                                          \
 } while(0)
+
 #define evo_data(p,d) do {                                                     \
         const u32 _d = (d);                                                    \
-        printk(KERN_ERR "\t%08x\n", _d);                                       \
+        if (drm_debug & DRM_UT_KMS)                                            \
+                printk(KERN_ERR "\t%08x\n", _d);                               \
         *((p)++) = _d;                                                         \
 } while(0)
-#endif
 
-static bool
-evo_sync_wait(void *data)
+/******************************************************************************
+ * Plane
+ *****************************************************************************/
+#define nv50_wndw(p) container_of((p), struct nv50_wndw, plane)
+
+struct nv50_wndw {
+        const struct nv50_wndw_func *func;
+        struct nv50_dmac *dmac;
+
+        struct drm_plane plane;
+
+        struct nvif_notify notify;
+        u16 ntfy;
+        u16 sema;
+        u32 data;
+};
+
+struct nv50_wndw_func {
+        void *(*dtor)(struct nv50_wndw *);
+        int (*acquire)(struct nv50_wndw *, struct nv50_wndw_atom *asyw,
+                       struct nv50_head_atom *asyh);
+        void (*release)(struct nv50_wndw *, struct nv50_wndw_atom *asyw,
+                        struct nv50_head_atom *asyh);
+        void (*prepare)(struct nv50_wndw *, struct nv50_head_atom *asyh,
+                        struct nv50_wndw_atom *asyw);
+
+        void (*sema_set)(struct nv50_wndw *, struct nv50_wndw_atom *);
+        void (*sema_clr)(struct nv50_wndw *);
+        void (*ntfy_set)(struct nv50_wndw *, struct nv50_wndw_atom *);
+        void (*ntfy_clr)(struct nv50_wndw *);
+        int (*ntfy_wait_begun)(struct nv50_wndw *, struct nv50_wndw_atom *);
+        void (*image_set)(struct nv50_wndw *, struct nv50_wndw_atom *);
+        void (*image_clr)(struct nv50_wndw *);
+        void (*lut)(struct nv50_wndw *, struct nv50_wndw_atom *);
+        void (*point)(struct nv50_wndw *, struct nv50_wndw_atom *);
+
+        u32 (*update)(struct nv50_wndw *, u32 interlock);
+};
+
+static int
+nv50_wndw_wait_armed(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw)
 {
-        if (nouveau_bo_rd32(data, EVO_MAST_NTFY) != 0x00000000)
-                return true;
-        usleep_range(1, 2);
-        return false;
+        if (asyw->set.ntfy)
+                return wndw->func->ntfy_wait_begun(wndw, asyw);
+        return 0;
 }
 
-static int
-evo_sync(struct drm_device *dev)
+static u32
+nv50_wndw_flush_clr(struct nv50_wndw *wndw, u32 interlock, bool flush,
+                    struct nv50_wndw_atom *asyw)
 {
-        struct nvif_device *device = &nouveau_drm(dev)->device;
-        struct nv50_disp *disp = nv50_disp(dev);
-        struct nv50_mast *mast = nv50_mast(dev);
-        u32 *push = evo_wait(mast, 8);
-        if (push) {
-                nouveau_bo_wr32(disp->sync, EVO_MAST_NTFY, 0x00000000);
-                evo_mthd(push, 0x0084, 1);
-                evo_data(push, 0x80000000 | EVO_MAST_NTFY);
-                evo_mthd(push, 0x0080, 2);
-                evo_data(push, 0x00000000);
-                evo_data(push, 0x00000000);
-                evo_kick(push, mast);
-                if (nvif_msec(device, 2000,
-                        if (evo_sync_wait(disp->sync))
-                                break;
-                ) >= 0)
-                        return 0;
+        if (asyw->clr.sema && (!asyw->set.sema || flush))
+                wndw->func->sema_clr(wndw);
+        if (asyw->clr.ntfy && (!asyw->set.ntfy || flush))
+                wndw->func->ntfy_clr(wndw);
+        if (asyw->clr.image && (!asyw->set.image || flush))
+                wndw->func->image_clr(wndw);
+
+        return flush ? wndw->func->update(wndw, interlock) : 0;
+}
+
+static u32
+nv50_wndw_flush_set(struct nv50_wndw *wndw, u32 interlock,
+                    struct nv50_wndw_atom *asyw)
+{
+        if (interlock) {
+                asyw->image.mode = 0;
+                asyw->image.interval = 1;
         }
 
-        return -EBUSY;
+        if (asyw->set.sema ) wndw->func->sema_set (wndw, asyw);
+        if (asyw->set.ntfy ) wndw->func->ntfy_set (wndw, asyw);
+        if (asyw->set.image) wndw->func->image_set(wndw, asyw);
+        if (asyw->set.lut  ) wndw->func->lut      (wndw, asyw);
+        if (asyw->set.point) wndw->func->point    (wndw, asyw);
+
+        return wndw->func->update(wndw, interlock);
 }
 
-/******************************************************************************
- * Page flipping channel
- *****************************************************************************/
-struct nouveau_bo *
-nv50_display_crtc_sema(struct drm_device *dev, int crtc)
+static void
+nv50_wndw_atomic_check_release(struct nv50_wndw *wndw,
+                               struct nv50_wndw_atom *asyw,
+                               struct nv50_head_atom *asyh)
 {
-        return nv50_disp(dev)->sync;
+        struct nouveau_drm *drm = nouveau_drm(wndw->plane.dev);
+        NV_ATOMIC(drm, "%s release\n", wndw->plane.name);
+        wndw->func->release(wndw, asyw, asyh);
+        asyw->ntfy.handle = 0;
+        asyw->sema.handle = 0;
 }
 
-struct nv50_display_flip {
-        struct nv50_disp *disp;
-        struct nv50_sync *chan;
-};
-
-static bool
-nv50_display_flip_wait(void *data)
+static int
+nv50_wndw_atomic_check_acquire(struct nv50_wndw *wndw,
+                               struct nv50_wndw_atom *asyw,
+                               struct nv50_head_atom *asyh)
 {
-        struct nv50_display_flip *flip = data;
-        if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) ==
-                                              flip->chan->data)
-                return true;
-        usleep_range(1, 2);
-        return false;
+        struct nouveau_framebuffer *fb = nouveau_framebuffer(asyw->state.fb);
+        struct nouveau_drm *drm = nouveau_drm(wndw->plane.dev);
+        int ret;
+
+        NV_ATOMIC(drm, "%s acquire\n", wndw->plane.name);
+        asyw->clip.x1 = 0;
+        asyw->clip.y1 = 0;
+        asyw->clip.x2 = asyh->state.mode.hdisplay;
+        asyw->clip.y2 = asyh->state.mode.vdisplay;
+
+        asyw->image.w = fb->base.width;
+        asyw->image.h = fb->base.height;
+        asyw->image.kind = (fb->nvbo->tile_flags & 0x0000ff00) >> 8;
+        if (asyw->image.kind) {
+                asyw->image.layout = 0;
+                if (drm->device.info.chipset >= 0xc0)
+                        asyw->image.block = fb->nvbo->tile_mode >> 4;
+                else
+                        asyw->image.block = fb->nvbo->tile_mode;
+                asyw->image.pitch = (fb->base.pitches[0] / 4) << 4;
+        } else {
+                asyw->image.layout = 1;
+                asyw->image.block  = 0;
+                asyw->image.pitch  = fb->base.pitches[0];
+        }
+
+        ret = wndw->func->acquire(wndw, asyw, asyh);
+        if (ret)
+                return ret;
+
+        if (asyw->set.image) {
+                if (!(asyw->image.mode = asyw->interval ? 0 : 1))
+                        asyw->image.interval = asyw->interval;
+                else
+                        asyw->image.interval = 0;
+        }
+
+        return 0;
 }
 
-void
-nv50_display_flip_stop(struct drm_crtc *crtc)
+static int
+nv50_wndw_atomic_check(struct drm_plane *plane, struct drm_plane_state *state)
 {
-        struct nvif_device *device = &nouveau_drm(crtc->dev)->device;
-        struct nv50_display_flip flip = {
-                .disp = nv50_disp(crtc->dev),
-                .chan = nv50_sync(crtc),
-        };
-        u32 *push;
+        struct nouveau_drm *drm = nouveau_drm(plane->dev);
+        struct nv50_wndw *wndw = nv50_wndw(plane);
+        struct nv50_wndw_atom *armw = nv50_wndw_atom(wndw->plane.state);
+        struct nv50_wndw_atom *asyw = nv50_wndw_atom(state);
+        struct nv50_head_atom *harm = NULL, *asyh = NULL;
+        bool varm = false, asyv = false, asym = false;
+        int ret;
 
-        push = evo_wait(flip.chan, 8);
-        if (push) {
-                evo_mthd(push, 0x0084, 1);
-                evo_data(push, 0x00000000);
-                evo_mthd(push, 0x0094, 1);
-                evo_data(push, 0x00000000);
-                evo_mthd(push, 0x00c0, 1);
-                evo_data(push, 0x00000000);
-                evo_mthd(push, 0x0080, 1);
-                evo_data(push, 0x00000000);
-                evo_kick(push, flip.chan);
+        NV_ATOMIC(drm, "%s atomic_check\n", plane->name);
+        if (asyw->state.crtc) {
+                asyh = nv50_head_atom_get(asyw->state.state, asyw->state.crtc);
+                if (IS_ERR(asyh))
+                        return PTR_ERR(asyh);
+                asym = drm_atomic_crtc_needs_modeset(&asyh->state);
+                asyv = asyh->state.active;
         }
 
-        nvif_msec(device, 2000,
-                if (nv50_display_flip_wait(&flip))
-                        break;
-        );
+        if (armw->state.crtc) {
+                harm = nv50_head_atom_get(asyw->state.state, armw->state.crtc);
+                if (IS_ERR(harm))
+                        return PTR_ERR(harm);
+                varm = harm->state.crtc->state->active;
+        }
+
+        if (asyv) {
+                asyw->point.x = asyw->state.crtc_x;
+                asyw->point.y = asyw->state.crtc_y;
+                if (memcmp(&armw->point, &asyw->point, sizeof(asyw->point)))
+                        asyw->set.point = true;
+
+                if (!varm || asym || armw->state.fb != asyw->state.fb) {
+                        ret = nv50_wndw_atomic_check_acquire(wndw, asyw, asyh);
+                        if (ret)
+                                return ret;
+                }
+        } else
+        if (varm) {
+                nv50_wndw_atomic_check_release(wndw, asyw, harm);
+        } else {
+                return 0;
+        }
+
+        if (!asyv || asym) {
+                asyw->clr.ntfy = armw->ntfy.handle != 0;
+                asyw->clr.sema = armw->sema.handle != 0;
+                if (wndw->func->image_clr)
+                        asyw->clr.image = armw->image.handle != 0;
+                asyw->set.lut = wndw->func->lut && asyv;
+        }
+
+        return 0;
 }
 
-int
-nv50_display_flip_next(struct drm_crtc *crtc, struct drm_framebuffer *fb,
-                       struct nouveau_channel *chan, u32 swap_interval)
+static void
+nv50_wndw_cleanup_fb(struct drm_plane *plane, struct drm_plane_state *old_state)
 {
-        struct nouveau_framebuffer *nv_fb = nouveau_framebuffer(fb);
-        struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-        struct nv50_head *head = nv50_head(crtc);
-        struct nv50_sync *sync = nv50_sync(crtc);
-        u32 *push;
-        int ret;
+        struct nouveau_framebuffer *fb = nouveau_framebuffer(old_state->fb);
+        struct nouveau_drm *drm = nouveau_drm(plane->dev);
 
-        if (crtc->primary->fb->width != fb->width ||
-            crtc->primary->fb->height != fb->height)
-                return -EINVAL;
+        NV_ATOMIC(drm, "%s cleanup: %p\n", plane->name, old_state->fb);
+        if (!old_state->fb)
+                return;
+
+        nouveau_bo_unpin(fb->nvbo);
+}
 
-        swap_interval <<= 4;
-        if (swap_interval == 0)
-                swap_interval |= 0x100;
-        if (chan == NULL)
-                evo_sync(crtc->dev);
+static int
+nv50_wndw_prepare_fb(struct drm_plane *plane, struct drm_plane_state *state)
+{
+        struct nouveau_framebuffer *fb = nouveau_framebuffer(state->fb);
+        struct nouveau_drm *drm = nouveau_drm(plane->dev);
+        struct nv50_wndw *wndw = nv50_wndw(plane);
+        struct nv50_wndw_atom *asyw = nv50_wndw_atom(state);
+        struct nv50_head_atom *asyh;
+        struct nv50_dmac_ctxdma *ctxdma;
+        int ret;
 
-        push = evo_wait(sync, 128);
-        if (unlikely(push == NULL))
-                return -EBUSY;
+        NV_ATOMIC(drm, "%s prepare: %p\n", plane->name, state->fb);
+        if (!asyw->state.fb)
+                return 0;
 
-        if (chan && chan->user.oclass < G82_CHANNEL_GPFIFO) {
-                ret = RING_SPACE(chan, 8);
-                if (ret)
-                        return ret;
+        ret = nouveau_bo_pin(fb->nvbo, TTM_PL_FLAG_VRAM, true);
+        if (ret)
+                return ret;
 
-                BEGIN_NV04(chan, 0, NV11_SUBCHAN_DMA_SEMAPHORE, 2);
-                OUT_RING  (chan, NvEvoSema0 + nv_crtc->index);
-                OUT_RING  (chan, sync->addr ^ 0x10);
-                BEGIN_NV04(chan, 0, NV11_SUBCHAN_SEMAPHORE_RELEASE, 1);
-                OUT_RING  (chan, sync->data + 1);
-                BEGIN_NV04(chan, 0, NV11_SUBCHAN_SEMAPHORE_OFFSET, 2);
-                OUT_RING  (chan, sync->addr);
-                OUT_RING  (chan, sync->data);
-        } else
-        if (chan && chan->user.oclass < FERMI_CHANNEL_GPFIFO) {
-                u64 addr = nv84_fence_crtc(chan, nv_crtc->index) + sync->addr;
-                ret = RING_SPACE(chan, 12);
-                if (ret)
-                        return ret;
+        ctxdma = nv50_dmac_ctxdma_new(wndw->dmac, fb);
+        if (IS_ERR(ctxdma)) {
+                nouveau_bo_unpin(fb->nvbo);
+                return PTR_ERR(ctxdma);
+        }
 
-                BEGIN_NV04(chan, 0, NV11_SUBCHAN_DMA_SEMAPHORE, 1);
-                OUT_RING  (chan, chan->vram.handle);
-                BEGIN_NV04(chan, 0, NV84_SUBCHAN_SEMAPHORE_ADDRESS_HIGH, 4);
-                OUT_RING  (chan, upper_32_bits(addr ^ 0x10));
-                OUT_RING  (chan, lower_32_bits(addr ^ 0x10));
-                OUT_RING  (chan, sync->data + 1);
-                OUT_RING  (chan, NV84_SUBCHAN_SEMAPHORE_TRIGGER_WRITE_LONG);
-                BEGIN_NV04(chan, 0, NV84_SUBCHAN_SEMAPHORE_ADDRESS_HIGH, 4);
-                OUT_RING  (chan, upper_32_bits(addr));
-                OUT_RING  (chan, lower_32_bits(addr));
-                OUT_RING  (chan, sync->data);
-                OUT_RING  (chan, NV84_SUBCHAN_SEMAPHORE_TRIGGER_ACQUIRE_EQUAL);
-        } else
-        if (chan) {
-                u64 addr = nv84_fence_crtc(chan, nv_crtc->index) + sync->addr;
-                ret = RING_SPACE(chan, 10);
-                if (ret)
-                        return ret;
+        asyw->state.fence = reservation_object_get_excl_rcu(fb->nvbo->bo.resv);
+        asyw->image.handle = ctxdma->object.handle;
+        asyw->image.offset = fb->nvbo->bo.offset;
 
-                BEGIN_NVC0(chan, 0, NV84_SUBCHAN_SEMAPHORE_ADDRESS_HIGH, 4);
-                OUT_RING  (chan, upper_32_bits(addr ^ 0x10));
-                OUT_RING  (chan, lower_32_bits(addr ^ 0x10));
-                OUT_RING  (chan, sync->data + 1);
-                OUT_RING  (chan, NV84_SUBCHAN_SEMAPHORE_TRIGGER_WRITE_LONG |
-                                 NVC0_SUBCHAN_SEMAPHORE_TRIGGER_YIELD);
-                BEGIN_NVC0(chan, 0, NV84_SUBCHAN_SEMAPHORE_ADDRESS_HIGH, 4);
-                OUT_RING  (chan, upper_32_bits(addr));
-                OUT_RING  (chan, lower_32_bits(addr));
-                OUT_RING  (chan, sync->data);
-                OUT_RING  (chan, NV84_SUBCHAN_SEMAPHORE_TRIGGER_ACQUIRE_EQUAL |
-                                 NVC0_SUBCHAN_SEMAPHORE_TRIGGER_YIELD);
-        }
-
-        if (chan) {
-                sync->addr ^= 0x10;
-                sync->data++;
-                FIRE_RING (chan);
-        }
-
-        /* queue the flip */
-        evo_mthd(push, 0x0100, 1);
-        evo_data(push, 0xfffe0000);
-        evo_mthd(push, 0x0084, 1);
-        evo_data(push, swap_interval);
-        if (!(swap_interval & 0x00000100)) {
-                evo_mthd(push, 0x00e0, 1);
-                evo_data(push, 0x40000000);
-        }
-        evo_mthd(push, 0x0088, 4);
-        evo_data(push, sync->addr);
-        evo_data(push, sync->data++);
-        evo_data(push, sync->data);
-        evo_data(push, sync->base.sync.handle);
-        evo_mthd(push, 0x00a0, 2);
-        evo_data(push, 0x00000000);
-        evo_data(push, 0x00000000);
-        evo_mthd(push, 0x00c0, 1);
-        evo_data(push, nv_fb->r_handle);
-        evo_mthd(push, 0x0110, 2);
-        evo_data(push, 0x00000000);
-        evo_data(push, 0x00000000);
-        if (nv50_vers(sync) < GF110_DISP_BASE_CHANNEL_DMA) {
-                evo_mthd(push, 0x0800, 5);
-                evo_data(push, nv_fb->nvbo->bo.offset >> 8);
-                evo_data(push, 0);
-                evo_data(push, (fb->height << 16) | fb->width);
-                evo_data(push, nv_fb->r_pitch);
-                evo_data(push, nv_fb->r_format);
-        } else {
-                evo_mthd(push, 0x0400, 5);
-                evo_data(push, nv_fb->nvbo->bo.offset >> 8);
-                evo_data(push, 0);
-                evo_data(push, (fb->height << 16) | fb->width);
-                evo_data(push, nv_fb->r_pitch);
-                evo_data(push, nv_fb->r_format);
+        if (wndw->func->prepare) {
+                asyh = nv50_head_atom_get(asyw->state.state, asyw->state.crtc);
+                if (IS_ERR(asyh))
+                        return PTR_ERR(asyh);
+
+                wndw->func->prepare(wndw, asyh, asyw);
         }
-        evo_mthd(push, 0x0080, 1);
-        evo_data(push, 0x00000000);
-        evo_kick(push, sync);
 
-        nouveau_bo_ref(nv_fb->nvbo, &head->image);
+        return 0;
+}
+
+static const struct drm_plane_helper_funcs
+nv50_wndw_helper = {
+        .prepare_fb = nv50_wndw_prepare_fb,
+        .cleanup_fb = nv50_wndw_cleanup_fb,
+        .atomic_check = nv50_wndw_atomic_check,
+};
+
+static void
+nv50_wndw_atomic_destroy_state(struct drm_plane *plane,
+                               struct drm_plane_state *state)
+{
+        struct nv50_wndw_atom *asyw = nv50_wndw_atom(state);
+        __drm_atomic_helper_plane_destroy_state(&asyw->state);
+        dma_fence_put(asyw->state.fence);
+        kfree(asyw);
+}
+
+static struct drm_plane_state *
+nv50_wndw_atomic_duplicate_state(struct drm_plane *plane)
+{
+        struct nv50_wndw_atom *armw = nv50_wndw_atom(plane->state);
+        struct nv50_wndw_atom *asyw;
+        if (!(asyw = kmalloc(sizeof(*asyw), GFP_KERNEL)))
+                return NULL;
+        __drm_atomic_helper_plane_duplicate_state(plane, &asyw->state);
+        asyw->state.fence = NULL;
+        asyw->interval = 1;
+        asyw->sema = armw->sema;
+        asyw->ntfy = armw->ntfy;
+        asyw->image = armw->image;
+        asyw->point = armw->point;
+        asyw->lut = armw->lut;
+        asyw->clr.mask = 0;
+        asyw->set.mask = 0;
+        return &asyw->state;
+}
+
+static void
+nv50_wndw_reset(struct drm_plane *plane)
+{
+        struct nv50_wndw_atom *asyw;
+
+        if (WARN_ON(!(asyw = kzalloc(sizeof(*asyw), GFP_KERNEL))))
+                return;
+
+        if (plane->state)
+                plane->funcs->atomic_destroy_state(plane, plane->state);
+        plane->state = &asyw->state;
+        plane->state->plane = plane;
+        plane->state->rotation = DRM_ROTATE_0;
+}
+
+static void
+nv50_wndw_destroy(struct drm_plane *plane)
+{
+        struct nv50_wndw *wndw = nv50_wndw(plane);
+        void *data;
+        nvif_notify_fini(&wndw->notify);
+        data = wndw->func->dtor(wndw);
+        drm_plane_cleanup(&wndw->plane);
+        kfree(data);
+}
+
+static const struct drm_plane_funcs
+nv50_wndw = {
+        .update_plane = drm_atomic_helper_update_plane,
+        .disable_plane = drm_atomic_helper_disable_plane,
+        .destroy = nv50_wndw_destroy,
+        .reset = nv50_wndw_reset,
+        .set_property = drm_atomic_helper_plane_set_property,
+        .atomic_duplicate_state = nv50_wndw_atomic_duplicate_state,
+        .atomic_destroy_state = nv50_wndw_atomic_destroy_state,
+};
+
+static void
+nv50_wndw_fini(struct nv50_wndw *wndw)
+{
+        nvif_notify_put(&wndw->notify);
+}
+
+static void
+nv50_wndw_init(struct nv50_wndw *wndw)
+{
+        nvif_notify_get(&wndw->notify);
+}
+
+static int
+nv50_wndw_ctor(const struct nv50_wndw_func *func, struct drm_device *dev,
+               enum drm_plane_type type, const char *name, int index,
+               struct nv50_dmac *dmac, const u32 *format, int nformat,
+               struct nv50_wndw *wndw)
+{
+        int ret;
+
+        wndw->func = func;
+        wndw->dmac = dmac;
+
+        ret = drm_universal_plane_init(dev, &wndw->plane, 0, &nv50_wndw, format,
+                                       nformat, type, "%s-%d", name, index);
+        if (ret)
+                return ret;
+
+        drm_plane_helper_add(&wndw->plane, &nv50_wndw_helper);
         return 0;
 }
 
 /******************************************************************************
- * CRTC
+ * Cursor plane
  *****************************************************************************/
+#define nv50_curs(p) container_of((p), struct nv50_curs, wndw)
+
+struct nv50_curs {
+        struct nv50_wndw wndw;
+        struct nvif_object chan;
+};
+
+static u32
+nv50_curs_update(struct nv50_wndw *wndw, u32 interlock)
+{
+        struct nv50_curs *curs = nv50_curs(wndw);
+        nvif_wr32(&curs->chan, 0x0080, 0x00000000);
+        return 0;
+}
+
+static void
+nv50_curs_point(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw)
+{
+        struct nv50_curs *curs = nv50_curs(wndw);
+        nvif_wr32(&curs->chan, 0x0084, (asyw->point.y << 16) | asyw->point.x);
+}
+
+static void
+nv50_curs_prepare(struct nv50_wndw *wndw, struct nv50_head_atom *asyh,
+                  struct nv50_wndw_atom *asyw)
+{
+        asyh->curs.handle = nv50_disp(wndw->plane.dev)->mast.base.vram.handle;
+        asyh->curs.offset = asyw->image.offset;
+        asyh->set.curs = asyh->curs.visible;
+}
+
+static void
+nv50_curs_release(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw,
+                  struct nv50_head_atom *asyh)
+{
+        asyh->curs.visible = false;
+}
+
 static int
-nv50_crtc_set_dither(struct nouveau_crtc *nv_crtc, bool update)
+nv50_curs_acquire(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw,
+                  struct nv50_head_atom *asyh)
 {
-        struct nv50_mast *mast = nv50_mast(nv_crtc->base.dev);
-        struct nouveau_connector *nv_connector;
-        struct drm_connector *connector;
-        u32 *push, mode = 0x00;
+        int ret;
 
-        nv_connector = nouveau_crtc_connector_get(nv_crtc);
-        connector = &nv_connector->base;
-        if (nv_connector->dithering_mode == DITHERING_MODE_AUTO) {
-                if (nv_crtc->base.primary->fb->depth > connector->display_info.bpc * 3)
-                        mode = DITHERING_MODE_DYNAMIC2X2;
-        } else {
-                mode = nv_connector->dithering_mode;
-        }
+        ret = drm_plane_helper_check_state(&asyw->state, &asyw->clip,
+                                           DRM_PLANE_HELPER_NO_SCALING,
+                                           DRM_PLANE_HELPER_NO_SCALING,
+                                           true, true);
+        asyh->curs.visible = asyw->state.visible;
+        if (ret || !asyh->curs.visible)
+                return ret;
 
-        if (nv_connector->dithering_depth == DITHERING_DEPTH_AUTO) {
-                if (connector->display_info.bpc >= 8)
-                        mode |= DITHERING_DEPTH_8BPC;
-        } else {
-                mode |= nv_connector->dithering_depth;
+        switch (asyw->state.fb->width) {
+        case 32: asyh->curs.layout = 0; break;
+        case 64: asyh->curs.layout = 1; break;
+        default:
+                return -EINVAL;
         }
 
-        push = evo_wait(mast, 4);
-        if (push) {
-                if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                        evo_mthd(push, 0x08a0 + (nv_crtc->index * 0x0400), 1);
-                        evo_data(push, mode);
-                } else
-                if (nv50_vers(mast) < GK104_DISP_CORE_CHANNEL_DMA) {
-                        evo_mthd(push, 0x0490 + (nv_crtc->index * 0x0300), 1);
-                        evo_data(push, mode);
-                } else {
-                        evo_mthd(push, 0x04a0 + (nv_crtc->index * 0x0300), 1);
-                        evo_data(push, mode);
-                }
+        if (asyw->state.fb->width != asyw->state.fb->height)
+                return -EINVAL;
 
-                if (update) {
-                        evo_mthd(push, 0x0080, 1);
-                        evo_data(push, 0x00000000);
-                }
-                evo_kick(push, mast);
+        switch (asyw->state.fb->pixel_format) {
+        case DRM_FORMAT_ARGB8888: asyh->curs.format = 1; break;
+        default:
+                WARN_ON(1);
+                return -EINVAL;
         }
 
         return 0;
 }
 
+static void *
+nv50_curs_dtor(struct nv50_wndw *wndw)
+{
+        struct nv50_curs *curs = nv50_curs(wndw);
+        nvif_object_fini(&curs->chan);
+        return curs;
+}
+
+static const u32
+nv50_curs_format[] = {
+        DRM_FORMAT_ARGB8888,
+};
+
+static const struct nv50_wndw_func
+nv50_curs = {
+        .dtor = nv50_curs_dtor,
+        .acquire = nv50_curs_acquire,
+        .release = nv50_curs_release,
+        .prepare = nv50_curs_prepare,
+        .point = nv50_curs_point,
+        .update = nv50_curs_update,
+};
+
 static int
-nv50_crtc_set_scale(struct nouveau_crtc *nv_crtc, bool update)
+nv50_curs_new(struct nouveau_drm *drm, struct nv50_head *head,
+              struct nv50_curs **pcurs)
 {
-        struct nv50_mast *mast = nv50_mast(nv_crtc->base.dev);
-        struct drm_display_mode *omode, *umode = &nv_crtc->base.mode;
-        struct drm_crtc *crtc = &nv_crtc->base;
-        struct nouveau_connector *nv_connector;
-        int mode = DRM_MODE_SCALE_NONE;
-        u32 oX, oY, *push;
+        static const struct nvif_mclass curses[] = {
+                { GK104_DISP_CURSOR, 0 },
+                { GF110_DISP_CURSOR, 0 },
+                { GT214_DISP_CURSOR, 0 },
+                {   G82_DISP_CURSOR, 0 },
+                {  NV50_DISP_CURSOR, 0 },
+                {}
+        };
+        struct nv50_disp_cursor_v0 args = {
+                .head = head->base.index,
+        };
+        struct nv50_disp *disp = nv50_disp(drm->dev);
+        struct nv50_curs *curs;
+        int cid, ret;
+
+        cid = nvif_mclass(disp->disp, curses);
+        if (cid < 0) {
+                NV_ERROR(drm, "No supported cursor immediate class\n");
+                return cid;
+        }
 
-        /* start off at the resolution we programmed the crtc for, this
-         * effectively handles NONE/FULL scaling
-         */
-        nv_connector = nouveau_crtc_connector_get(nv_crtc);
-        if (nv_connector && nv_connector->native_mode) {
-                mode = nv_connector->scaling_mode;
-                if (nv_connector->scaling_full) /* non-EDID LVDS/eDP mode */
-                        mode = DRM_MODE_SCALE_FULLSCREEN;
+        if (!(curs = *pcurs = kzalloc(sizeof(*curs), GFP_KERNEL)))
+                return -ENOMEM;
+
+        ret = nv50_wndw_ctor(&nv50_curs, drm->dev, DRM_PLANE_TYPE_CURSOR,
+                             "curs", head->base.index, &disp->mast.base,
+                             nv50_curs_format, ARRAY_SIZE(nv50_curs_format),
+                             &curs->wndw);
+        if (ret) {
+                kfree(curs);
+                return ret;
         }
 
-        if (mode != DRM_MODE_SCALE_NONE)
-                omode = nv_connector->native_mode;
-        else
-                omode = umode;
+        ret = nvif_object_init(disp->disp, 0, curses[cid].oclass, &args,
+                               sizeof(args), &curs->chan);
+        if (ret) {
+                NV_ERROR(drm, "curs%04x allocation failed: %d\n",
+                         curses[cid].oclass, ret);
+                return ret;
+        }
 
-        oX = omode->hdisplay;
-        oY = omode->vdisplay;
-        if (omode->flags & DRM_MODE_FLAG_DBLSCAN)
-                oY *= 2;
+        return 0;
+}
 
-        /* add overscan compensation if necessary, will keep the aspect
-         * ratio the same as the backend mode unless overridden by the
-         * user setting both hborder and vborder properties.
-         */
-        if (nv_connector && ( nv_connector->underscan == UNDERSCAN_ON ||
-                             (nv_connector->underscan == UNDERSCAN_AUTO &&
-                              drm_detect_hdmi_monitor(nv_connector->edid)))) {
-                u32 bX = nv_connector->underscan_hborder;
-                u32 bY = nv_connector->underscan_vborder;
-                u32 aspect = (oY << 19) / oX;
+/******************************************************************************
+ * Primary plane
+ *****************************************************************************/
+#define nv50_base(p) container_of((p), struct nv50_base, wndw)
 
-                if (bX) {
-                        oX -= (bX * 2);
-                        if (bY) oY -= (bY * 2);
-                        else    oY  = ((oX * aspect) + (aspect / 2)) >> 19;
-                } else {
-                        oX -= (oX >> 4) + 32;
-                        if (bY) oY -= (bY * 2);
-                        else    oY  = ((oX * aspect) + (aspect / 2)) >> 19;
-                }
+struct nv50_base {
+        struct nv50_wndw wndw;
+        struct nv50_sync chan;
+        int id;
+};
+
+static int
+nv50_base_notify(struct nvif_notify *notify)
+{
+        return NVIF_NOTIFY_KEEP;
+}
+
+static void
+nv50_base_lut(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw)
+{
+        struct nv50_base *base = nv50_base(wndw);
+        u32 *push;
+        if ((push = evo_wait(&base->chan, 2))) {
+                evo_mthd(push, 0x00e0, 1);
+                evo_data(push, asyw->lut.enable << 30);
+                evo_kick(push, &base->chan);
         }
+}
 
-        /* handle CENTER/ASPECT scaling, taking into account the areas
-         * removed already for overscan compensation
-         */
-        switch (mode) {
-        case DRM_MODE_SCALE_CENTER:
-                oX = min((u32)umode->hdisplay, oX);
-                oY = min((u32)umode->vdisplay, oY);
-                /* fall-through */
-        case DRM_MODE_SCALE_ASPECT:
-                if (oY < oX) {
-                        u32 aspect = (umode->hdisplay << 19) / umode->vdisplay;
-                        oX = ((oY * aspect) + (aspect / 2)) >> 19;
-                } else {
-                        u32 aspect = (umode->vdisplay << 19) / umode->hdisplay;
-                        oY = ((oX * aspect) + (aspect / 2)) >> 19;
-                }
-                break;
-        default:
-                break;
+static void
+nv50_base_image_clr(struct nv50_wndw *wndw)
+{
+        struct nv50_base *base = nv50_base(wndw);
+        u32 *push;
+        if ((push = evo_wait(&base->chan, 4))) {
+                evo_mthd(push, 0x0084, 1);
+                evo_data(push, 0x00000000);
+                evo_mthd(push, 0x00c0, 1);
+                evo_data(push, 0x00000000);
+                evo_kick(push, &base->chan);
         }
+}
 
-        push = evo_wait(mast, 8);
-        if (push) {
-                if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                        /*XXX: SCALE_CTRL_ACTIVE??? */
-                        evo_mthd(push, 0x08d8 + (nv_crtc->index * 0x400), 2);
-                        evo_data(push, (oY << 16) | oX);
-                        evo_data(push, (oY << 16) | oX);
-                        evo_mthd(push, 0x08a4 + (nv_crtc->index * 0x400), 1);
+static void
+nv50_base_image_set(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw)
+{
+        struct nv50_base *base = nv50_base(wndw);
+        const s32 oclass = base->chan.base.base.user.oclass;
+        u32 *push;
+        if ((push = evo_wait(&base->chan, 10))) {
+                evo_mthd(push, 0x0084, 1);
+                evo_data(push, (asyw->image.mode << 8) |
+                               (asyw->image.interval << 4));
+                evo_mthd(push, 0x00c0, 1);
+                evo_data(push, asyw->image.handle);
+                if (oclass < G82_DISP_BASE_CHANNEL_DMA) {
+                        evo_mthd(push, 0x0800, 5);
+                        evo_data(push, asyw->image.offset >> 8);
+                        evo_data(push, 0x00000000);
+                        evo_data(push, (asyw->image.h << 16) | asyw->image.w);
+                        evo_data(push, (asyw->image.layout << 20) |
+                                        asyw->image.pitch |
+                                        asyw->image.block);
+                        evo_data(push, (asyw->image.kind << 16) |
+                                       (asyw->image.format << 8));
+                } else
+                if (oclass < GF110_DISP_BASE_CHANNEL_DMA) {
+                        evo_mthd(push, 0x0800, 5);
+                        evo_data(push, asyw->image.offset >> 8);
                         evo_data(push, 0x00000000);
-                        evo_mthd(push, 0x08c8 + (nv_crtc->index * 0x400), 1);
-                        evo_data(push, umode->vdisplay << 16 | umode->hdisplay);
+                        evo_data(push, (asyw->image.h << 16) | asyw->image.w);
+                        evo_data(push, (asyw->image.layout << 20) |
+                                        asyw->image.pitch |
+                                        asyw->image.block);
+                        evo_data(push, asyw->image.format << 8);
                 } else {
-                        evo_mthd(push, 0x04c0 + (nv_crtc->index * 0x300), 3);
-                        evo_data(push, (oY << 16) | oX);
-                        evo_data(push, (oY << 16) | oX);
-                        evo_data(push, (oY << 16) | oX);
-                        evo_mthd(push, 0x0494 + (nv_crtc->index * 0x300), 1);
+                        evo_mthd(push, 0x0400, 5);
+                        evo_data(push, asyw->image.offset >> 8);
                         evo_data(push, 0x00000000);
-                        evo_mthd(push, 0x04b8 + (nv_crtc->index * 0x300), 1);
-                        evo_data(push, umode->vdisplay << 16 | umode->hdisplay);
+                        evo_data(push, (asyw->image.h << 16) | asyw->image.w);
+                        evo_data(push, (asyw->image.layout << 24) |
+                                        asyw->image.pitch |
+                                        asyw->image.block);
+                        evo_data(push, asyw->image.format << 8);
                 }
+                evo_kick(push, &base->chan);
+        }
+}
 
-                evo_kick(push, mast);
+static void
+nv50_base_ntfy_clr(struct nv50_wndw *wndw)
+{
+        struct nv50_base *base = nv50_base(wndw);
+        u32 *push;
+        if ((push = evo_wait(&base->chan, 2))) {
+                evo_mthd(push, 0x00a4, 1);
+                evo_data(push, 0x00000000);
+                evo_kick(push, &base->chan);
+        }
+}
 
-                if (update) {
-                        nv50_display_flip_stop(crtc);
-                        nv50_display_flip_next(crtc, crtc->primary->fb,
-                                               NULL, 1);
-                }
+static void
+nv50_base_ntfy_set(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw)
+{
+        struct nv50_base *base = nv50_base(wndw);
+        u32 *push;
+        if ((push = evo_wait(&base->chan, 3))) {
+                evo_mthd(push, 0x00a0, 2);
+                evo_data(push, (asyw->ntfy.awaken << 30) | asyw->ntfy.offset);
+                evo_data(push, asyw->ntfy.handle);
+                evo_kick(push, &base->chan);
         }
+}
 
-        return 0;
+static void
+nv50_base_sema_clr(struct nv50_wndw *wndw)
+{
+        struct nv50_base *base = nv50_base(wndw);
+        u32 *push;
+        if ((push = evo_wait(&base->chan, 2))) {
+                evo_mthd(push, 0x0094, 1);
+                evo_data(push, 0x00000000);
+                evo_kick(push, &base->chan);
+        }
 }
 
-static int
-nv50_crtc_set_raster_vblank_dmi(struct nouveau_crtc *nv_crtc, u32 usec)
+static void
+nv50_base_sema_set(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw)
 {
-        struct nv50_mast *mast = nv50_mast(nv_crtc->base.dev);
+        struct nv50_base *base = nv50_base(wndw);
         u32 *push;
+        if ((push = evo_wait(&base->chan, 5))) {
+                evo_mthd(push, 0x0088, 4);
+                evo_data(push, asyw->sema.offset);
+                evo_data(push, asyw->sema.acquire);
+                evo_data(push, asyw->sema.release);
+                evo_data(push, asyw->sema.handle);
+                evo_kick(push, &base->chan);
+        }
+}
 
-        push = evo_wait(mast, 8);
-        if (!push)
-                return -ENOMEM;
+static u32
+nv50_base_update(struct nv50_wndw *wndw, u32 interlock)
+{
+        struct nv50_base *base = nv50_base(wndw);
+        u32 *push;
 
-        evo_mthd(push, 0x0828 + (nv_crtc->index * 0x400), 1);
-        evo_data(push, usec);
-        evo_kick(push, mast);
+        if (!(push = evo_wait(&base->chan, 2)))
+                return 0;
+        evo_mthd(push, 0x0080, 1);
+        evo_data(push, interlock);
+        evo_kick(push, &base->chan);
+
+        if (base->chan.base.base.user.oclass < GF110_DISP_BASE_CHANNEL_DMA)
+                return interlock ? 2 << (base->id * 8) : 0;
+        return interlock ? 2 << (base->id * 4) : 0;
+}
+
+static int
+nv50_base_ntfy_wait_begun(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw)
+{
+        struct nouveau_drm *drm = nouveau_drm(wndw->plane.dev);
+        struct nv50_disp *disp = nv50_disp(wndw->plane.dev);
+        if (nvif_msec(&drm->device, 2000ULL,
+                u32 data = nouveau_bo_rd32(disp->sync, asyw->ntfy.offset / 4);
+                if ((data & 0xc0000000) == 0x40000000)
+                        break;
+                usleep_range(1, 2);
+        ) < 0)
+                return -ETIMEDOUT;
         return 0;
 }
 
+static void
+nv50_base_release(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw,
+                  struct nv50_head_atom *asyh)
+{
+        asyh->base.cpp = 0;
+}
+
 static int
-nv50_crtc_set_color_vibrance(struct nouveau_crtc *nv_crtc, bool update)
+nv50_base_acquire(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw,
+                  struct nv50_head_atom *asyh)
 {
-        struct nv50_mast *mast = nv50_mast(nv_crtc->base.dev);
-        u32 *push, hue, vib;
-        int adj;
+        const u32 format = asyw->state.fb->pixel_format;
+        const struct drm_format_info *info;
+        int ret;
 
-        adj = (nv_crtc->color_vibrance > 0) ? 50 : 0;
-        vib = ((nv_crtc->color_vibrance * 2047 + adj) / 100) & 0xfff;
-        hue = ((nv_crtc->vibrant_hue * 2047) / 100) & 0xfff;
+        info = drm_format_info(format);
+        if (!info || !info->depth)
+                return -EINVAL;
 
-        push = evo_wait(mast, 16);
-        if (push) {
-                if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                        evo_mthd(push, 0x08a8 + (nv_crtc->index * 0x400), 1);
-                        evo_data(push, (hue << 20) | (vib << 8));
-                } else {
-                        evo_mthd(push, 0x0498 + (nv_crtc->index * 0x300), 1);
-                        evo_data(push, (hue << 20) | (vib << 8));
-                }
+        ret = drm_plane_helper_check_state(&asyw->state, &asyw->clip,
+                                           DRM_PLANE_HELPER_NO_SCALING,
+                                           DRM_PLANE_HELPER_NO_SCALING,
+                                           false, true);
+        if (ret)
+                return ret;
 
-                if (update) {
-                        evo_mthd(push, 0x0080, 1);
-                        evo_data(push, 0x00000000);
-                }
-                evo_kick(push, mast);
+        asyh->base.depth = info->depth;
+        asyh->base.cpp = info->cpp[0];
+        asyh->base.x = asyw->state.src.x1 >> 16;
+        asyh->base.y = asyw->state.src.y1 >> 16;
+        asyh->base.w = asyw->state.fb->width;
+        asyh->base.h = asyw->state.fb->height;
+
+        switch (format) {
+        case DRM_FORMAT_C8         : asyw->image.format = 0x1e; break;
+        case DRM_FORMAT_RGB565     : asyw->image.format = 0xe8; break;
+        case DRM_FORMAT_XRGB1555   :
+        case DRM_FORMAT_ARGB1555   : asyw->image.format = 0xe9; break;
+        case DRM_FORMAT_XRGB8888   :
+        case DRM_FORMAT_ARGB8888   : asyw->image.format = 0xcf; break;
+        case DRM_FORMAT_XBGR2101010:
+        case DRM_FORMAT_ABGR2101010: asyw->image.format = 0xd1; break;
+        case DRM_FORMAT_XBGR8888   :
+        case DRM_FORMAT_ABGR8888   : asyw->image.format = 0xd5; break;
+        default:
+                WARN_ON(1);
+                return -EINVAL;
         }
 
+        asyw->lut.enable = 1;
+        asyw->set.image = true;
         return 0;
 }
 
+static void *
+nv50_base_dtor(struct nv50_wndw *wndw)
+{
+        struct nv50_disp *disp = nv50_disp(wndw->plane.dev);
+        struct nv50_base *base = nv50_base(wndw);
+        nv50_dmac_destroy(&base->chan.base, disp->disp);
+        return base;
+}
+
+static const u32
+nv50_base_format[] = {
+        DRM_FORMAT_C8,
+        DRM_FORMAT_RGB565,
+        DRM_FORMAT_XRGB1555,
+        DRM_FORMAT_ARGB1555,
+        DRM_FORMAT_XRGB8888,
+        DRM_FORMAT_ARGB8888,
+        DRM_FORMAT_XBGR2101010,
+        DRM_FORMAT_ABGR2101010,
+        DRM_FORMAT_XBGR8888,
+        DRM_FORMAT_ABGR8888,
+};
+
+static const struct nv50_wndw_func
+nv50_base = {
+        .dtor = nv50_base_dtor,
+        .acquire = nv50_base_acquire,
+        .release = nv50_base_release,
+        .sema_set = nv50_base_sema_set,
+        .sema_clr = nv50_base_sema_clr,
+        .ntfy_set = nv50_base_ntfy_set,
+        .ntfy_clr = nv50_base_ntfy_clr,
+        .ntfy_wait_begun = nv50_base_ntfy_wait_begun,
+        .image_set = nv50_base_image_set,
+        .image_clr = nv50_base_image_clr,
+        .lut = nv50_base_lut,
+        .update = nv50_base_update,
+};
+
 static int
-nv50_crtc_set_image(struct nouveau_crtc *nv_crtc, struct drm_framebuffer *fb,
-                    int x, int y, bool update)
+nv50_base_new(struct nouveau_drm *drm, struct nv50_head *head,
+              struct nv50_base **pbase)
+{
+        struct nv50_disp *disp = nv50_disp(drm->dev);
+        struct nv50_base *base;
+        int ret;
+
+        if (!(base = *pbase = kzalloc(sizeof(*base), GFP_KERNEL)))
+                return -ENOMEM;
+        base->id = head->base.index;
+        base->wndw.ntfy = EVO_FLIP_NTFY0(base->id);
+        base->wndw.sema = EVO_FLIP_SEM0(base->id);
+        base->wndw.data = 0x00000000;
+
+        ret = nv50_wndw_ctor(&nv50_base, drm->dev, DRM_PLANE_TYPE_PRIMARY,
+                             "base", base->id, &base->chan.base,
+                             nv50_base_format, ARRAY_SIZE(nv50_base_format),
+                             &base->wndw);
+        if (ret) {
+                kfree(base);
+                return ret;
+        }
+
+        ret = nv50_base_create(&drm->device, disp->disp, base->id,
+                               disp->sync->bo.offset, &base->chan);
+        if (ret)
+                return ret;
+
+        return nvif_notify_init(&base->chan.base.base.user, nv50_base_notify,
+                                false,
+                                NV50_DISP_BASE_CHANNEL_DMA_V0_NTFY_UEVENT,
+                                &(struct nvif_notify_uevent_req) {},
+                                sizeof(struct nvif_notify_uevent_req),
+                                sizeof(struct nvif_notify_uevent_rep),
+                                &base->wndw.notify);
+}
+
+/******************************************************************************
+ * Head
+ *****************************************************************************/
+static void
+nv50_head_procamp(struct nv50_head *head, struct nv50_head_atom *asyh)
 {
-        struct nouveau_framebuffer *nvfb = nouveau_framebuffer(fb);
-        struct nv50_mast *mast = nv50_mast(nv_crtc->base.dev);
+        struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
         u32 *push;
+        if ((push = evo_wait(core, 2))) {
+                if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA)
+                        evo_mthd(push, 0x08a8 + (head->base.index * 0x400), 1);
+                else
+                        evo_mthd(push, 0x0498 + (head->base.index * 0x300), 1);
+                evo_data(push, (asyh->procamp.sat.sin << 20) |
+                               (asyh->procamp.sat.cos << 8));
+                evo_kick(push, core);
+        }
+}
 
-        push = evo_wait(mast, 16);
-        if (push) {
-                if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                        evo_mthd(push, 0x0860 + (nv_crtc->index * 0x400), 1);
-                        evo_data(push, nvfb->nvbo->bo.offset >> 8);
-                        evo_mthd(push, 0x0868 + (nv_crtc->index * 0x400), 3);
-                        evo_data(push, (fb->height << 16) | fb->width);
-                        evo_data(push, nvfb->r_pitch);
-                        evo_data(push, nvfb->r_format);
-                        evo_mthd(push, 0x08c0 + (nv_crtc->index * 0x400), 1);
-                        evo_data(push, (y << 16) | x);
-                        if (nv50_vers(mast) > NV50_DISP_CORE_CHANNEL_DMA) {
-                                evo_mthd(push, 0x0874 + (nv_crtc->index * 0x400), 1);
-                                evo_data(push, nvfb->r_handle);
-                        }
-                } else {
-                        evo_mthd(push, 0x0460 + (nv_crtc->index * 0x300), 1);
-                        evo_data(push, nvfb->nvbo->bo.offset >> 8);
-                        evo_mthd(push, 0x0468 + (nv_crtc->index * 0x300), 4);
-                        evo_data(push, (fb->height << 16) | fb->width);
-                        evo_data(push, nvfb->r_pitch);
-                        evo_data(push, nvfb->r_format);
-                        evo_data(push, nvfb->r_handle);
-                        evo_mthd(push, 0x04b0 + (nv_crtc->index * 0x300), 1);
-                        evo_data(push, (y << 16) | x);
-                }
+static void
+nv50_head_dither(struct nv50_head *head, struct nv50_head_atom *asyh)
+{
+        struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+        u32 *push;
+        if ((push = evo_wait(core, 2))) {
+                if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA)
+                        evo_mthd(push, 0x08a0 + (head->base.index * 0x0400), 1);
+                else
+                if (core->base.user.oclass < GK104_DISP_CORE_CHANNEL_DMA)
+                        evo_mthd(push, 0x0490 + (head->base.index * 0x0300), 1);
+                else
+                        evo_mthd(push, 0x04a0 + (head->base.index * 0x0300), 1);
+                evo_data(push, (asyh->dither.mode << 3) |
+                               (asyh->dither.bits << 1) |
+                                asyh->dither.enable);
+                evo_kick(push, core);
+        }
+}
 
-                if (update) {
-                        evo_mthd(push, 0x0080, 1);
-                        evo_data(push, 0x00000000);
+static void
+nv50_head_ovly(struct nv50_head *head, struct nv50_head_atom *asyh)
+{
+        struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+        u32 bounds = 0;
+        u32 *push;
+
+        if (asyh->base.cpp) {
+                switch (asyh->base.cpp) {
+                case 8: bounds |= 0x00000500; break;
+                case 4: bounds |= 0x00000300; break;
+                case 2: bounds |= 0x00000100; break;
+                default:
+                        WARN_ON(1);
+                        break;
                 }
-                evo_kick(push, mast);
+                bounds |= 0x00000001;
         }
 
-        nv_crtc->fb.handle = nvfb->r_handle;
-        return 0;
+        if ((push = evo_wait(core, 2))) {
+                if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA)
+                        evo_mthd(push, 0x0904 + head->base.index * 0x400, 1);
+                else
+                        evo_mthd(push, 0x04d4 + head->base.index * 0x300, 1);
+                evo_data(push, bounds);
+                evo_kick(push, core);
+        }
 }
 
 static void
-nv50_crtc_cursor_show(struct nouveau_crtc *nv_crtc)
+nv50_head_base(struct nv50_head *head, struct nv50_head_atom *asyh)
 {
-        struct nv50_mast *mast = nv50_mast(nv_crtc->base.dev);
-        u32 *push = evo_wait(mast, 16);
-        if (push) {
-                if (nv50_vers(mast) < G82_DISP_CORE_CHANNEL_DMA) {
-                        evo_mthd(push, 0x0880 + (nv_crtc->index * 0x400), 2);
-                        evo_data(push, 0x85000000);
-                        evo_data(push, nv_crtc->cursor.nvbo->bo.offset >> 8);
-                } else
-                if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                        evo_mthd(push, 0x0880 + (nv_crtc->index * 0x400), 2);
-                        evo_data(push, 0x85000000);
-                        evo_data(push, nv_crtc->cursor.nvbo->bo.offset >> 8);
-                        evo_mthd(push, 0x089c + (nv_crtc->index * 0x400), 1);
-                        evo_data(push, mast->base.vram.handle);
-                } else {
-                        evo_mthd(push, 0x0480 + (nv_crtc->index * 0x300), 2);
-                        evo_data(push, 0x85000000);
-                        evo_data(push, nv_crtc->cursor.nvbo->bo.offset >> 8);
-                        evo_mthd(push, 0x048c + (nv_crtc->index * 0x300), 1);
-                        evo_data(push, mast->base.vram.handle);
+        struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+        u32 bounds = 0;
+        u32 *push;
+
+        if (asyh->base.cpp) {
+                switch (asyh->base.cpp) {
+                case 8: bounds |= 0x00000500; break;
+                case 4: bounds |= 0x00000300; break;
+                case 2: bounds |= 0x00000100; break;
+                case 1: bounds |= 0x00000000; break;
+                default:
+                        WARN_ON(1);
+                        break;
                 }
-                evo_kick(push, mast);
+                bounds |= 0x00000001;
+        }
+
+        if ((push = evo_wait(core, 2))) {
+                if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA)
+                        evo_mthd(push, 0x0900 + head->base.index * 0x400, 1);
+                else
+                        evo_mthd(push, 0x04d0 + head->base.index * 0x300, 1);
+                evo_data(push, bounds);
+                evo_kick(push, core);
         }
-        nv_crtc->cursor.visible = true;
 }
 
 static void
-nv50_crtc_cursor_hide(struct nouveau_crtc *nv_crtc)
+nv50_head_curs_clr(struct nv50_head *head)
 {
-        struct nv50_mast *mast = nv50_mast(nv_crtc->base.dev);
-        u32 *push = evo_wait(mast, 16);
-        if (push) {
-                if (nv50_vers(mast) < G82_DISP_CORE_CHANNEL_DMA) {
-                        evo_mthd(push, 0x0880 + (nv_crtc->index * 0x400), 1);
+        struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+        u32 *push;
+        if ((push = evo_wait(core, 4))) {
+                if (core->base.user.oclass < G82_DISP_CORE_CHANNEL_DMA) {
+                        evo_mthd(push, 0x0880 + head->base.index * 0x400, 1);
                         evo_data(push, 0x05000000);
                 } else
-                if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                        evo_mthd(push, 0x0880 + (nv_crtc->index * 0x400), 1);
+                if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA) {
+                        evo_mthd(push, 0x0880 + head->base.index * 0x400, 1);
                         evo_data(push, 0x05000000);
-                        evo_mthd(push, 0x089c + (nv_crtc->index * 0x400), 1);
+                        evo_mthd(push, 0x089c + head->base.index * 0x400, 1);
                         evo_data(push, 0x00000000);
                 } else {
-                        evo_mthd(push, 0x0480 + (nv_crtc->index * 0x300), 1);
+                        evo_mthd(push, 0x0480 + head->base.index * 0x300, 1);
                         evo_data(push, 0x05000000);
-                        evo_mthd(push, 0x048c + (nv_crtc->index * 0x300), 1);
+                        evo_mthd(push, 0x048c + head->base.index * 0x300, 1);
                         evo_data(push, 0x00000000);
                 }
-                evo_kick(push, mast);
+                evo_kick(push, core);
         }
-        nv_crtc->cursor.visible = false;
 }
 
 static void
-nv50_crtc_cursor_show_hide(struct nouveau_crtc *nv_crtc, bool show, bool update)
+nv50_head_curs_set(struct nv50_head *head, struct nv50_head_atom *asyh)
 {
-        struct nv50_mast *mast = nv50_mast(nv_crtc->base.dev);
-
-        if (show && nv_crtc->cursor.nvbo && nv_crtc->base.enabled)
-                nv50_crtc_cursor_show(nv_crtc);
-        else
-                nv50_crtc_cursor_hide(nv_crtc);
-
-        if (update) {
-                u32 *push = evo_wait(mast, 2);
-                if (push) {
-                        evo_mthd(push, 0x0080, 1);
-                        evo_data(push, 0x00000000);
-                        evo_kick(push, mast);
+        struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+        u32 *push;
+        if ((push = evo_wait(core, 5))) {
+                if (core->base.user.oclass < G82_DISP_BASE_CHANNEL_DMA) {
+                        evo_mthd(push, 0x0880 + head->base.index * 0x400, 2);
+                        evo_data(push, 0x80000000 | (asyh->curs.layout << 26) |
+                                                    (asyh->curs.format << 24));
+                        evo_data(push, asyh->curs.offset >> 8);
+                } else
+                if (core->base.user.oclass < GF110_DISP_BASE_CHANNEL_DMA) {
+                        evo_mthd(push, 0x0880 + head->base.index * 0x400, 2);
+                        evo_data(push, 0x80000000 | (asyh->curs.layout << 26) |
+                                                    (asyh->curs.format << 24));
+                        evo_data(push, asyh->curs.offset >> 8);
+                        evo_mthd(push, 0x089c + head->base.index * 0x400, 1);
+                        evo_data(push, asyh->curs.handle);
+                } else {
+                        evo_mthd(push, 0x0480 + head->base.index * 0x300, 2);
+                        evo_data(push, 0x80000000 | (asyh->curs.layout << 26) |
+                                                    (asyh->curs.format << 24));
+                        evo_data(push, asyh->curs.offset >> 8);
+                        evo_mthd(push, 0x048c + head->base.index * 0x300, 1);
+                        evo_data(push, asyh->curs.handle);
                 }
+                evo_kick(push, core);
         }
 }
 
 static void
-nv50_crtc_dpms(struct drm_crtc *crtc, int mode)
+nv50_head_core_clr(struct nv50_head *head)
 {
+        struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+        u32 *push;
+        if ((push = evo_wait(core, 2))) {
+                if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA)
+                        evo_mthd(push, 0x0874 + head->base.index * 0x400, 1);
+                else
+                        evo_mthd(push, 0x0474 + head->base.index * 0x300, 1);
+                evo_data(push, 0x00000000);
+                evo_kick(push, core);
+        }
 }
 
 static void
-nv50_crtc_prepare(struct drm_crtc *crtc)
+nv50_head_core_set(struct nv50_head *head, struct nv50_head_atom *asyh)
 {
-        struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-        struct nv50_mast *mast = nv50_mast(crtc->dev);
+        struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
         u32 *push;
+        if ((push = evo_wait(core, 9))) {
+                if (core->base.user.oclass < G82_DISP_CORE_CHANNEL_DMA) {
+                        evo_mthd(push, 0x0860 + head->base.index * 0x400, 1);
+                        evo_data(push, asyh->core.offset >> 8);
+                        evo_mthd(push, 0x0868 + head->base.index * 0x400, 4);
+                        evo_data(push, (asyh->core.h << 16) | asyh->core.w);
+                        evo_data(push, asyh->core.layout << 20 |
+                                       (asyh->core.pitch >> 8) << 8 |
+                                       asyh->core.block);
+                        evo_data(push, asyh->core.kind << 16 |
+                                       asyh->core.format << 8);
+                        evo_data(push, asyh->core.handle);
+                        evo_mthd(push, 0x08c0 + head->base.index * 0x400, 1);
+                        evo_data(push, (asyh->core.y << 16) | asyh->core.x);
+                } else
+                if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA) {
+                        evo_mthd(push, 0x0860 + head->base.index * 0x400, 1);
+                        evo_data(push, asyh->core.offset >> 8);
+                        evo_mthd(push, 0x0868 + head->base.index * 0x400, 4);
+                        evo_data(push, (asyh->core.h << 16) | asyh->core.w);
+                        evo_data(push, asyh->core.layout << 20 |
+                                       (asyh->core.pitch >> 8) << 8 |
+                                       asyh->core.block);
+                        evo_data(push, asyh->core.format << 8);
+                        evo_data(push, asyh->core.handle);
+                        evo_mthd(push, 0x08c0 + head->base.index * 0x400, 1);
+                        evo_data(push, (asyh->core.y << 16) | asyh->core.x);
+                } else {
+                        evo_mthd(push, 0x0460 + head->base.index * 0x300, 1);
+                        evo_data(push, asyh->core.offset >> 8);
+                        evo_mthd(push, 0x0468 + head->base.index * 0x300, 4);
+                        evo_data(push, (asyh->core.h << 16) | asyh->core.w);
+                        evo_data(push, asyh->core.layout << 24 |
+                                       (asyh->core.pitch >> 8) << 8 |
+                                       asyh->core.block);
+                        evo_data(push, asyh->core.format << 8);
+                        evo_data(push, asyh->core.handle);
+                        evo_mthd(push, 0x04b0 + head->base.index * 0x300, 1);
+                        evo_data(push, (asyh->core.y << 16) | asyh->core.x);
+                }
+                evo_kick(push, core);
+        }
+}
 
-        nv50_display_flip_stop(crtc);
-
-        push = evo_wait(mast, 6);
-        if (push) {
-                if (nv50_vers(mast) < G82_DISP_CORE_CHANNEL_DMA) {
-                        evo_mthd(push, 0x0874 + (nv_crtc->index * 0x400), 1);
-                        evo_data(push, 0x00000000);
-                        evo_mthd(push, 0x0840 + (nv_crtc->index * 0x400), 1);
+static void
+nv50_head_lut_clr(struct nv50_head *head)
+{
+        struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+        u32 *push;
+        if ((push = evo_wait(core, 4))) {
+                if (core->base.user.oclass < G82_DISP_CORE_CHANNEL_DMA) {
+                        evo_mthd(push, 0x0840 + (head->base.index * 0x400), 1);
                         evo_data(push, 0x40000000);
                 } else
-                if (nv50_vers(mast) <  GF110_DISP_CORE_CHANNEL_DMA) {
-                        evo_mthd(push, 0x0874 + (nv_crtc->index * 0x400), 1);
-                        evo_data(push, 0x00000000);
-                        evo_mthd(push, 0x0840 + (nv_crtc->index * 0x400), 1);
+                if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA) {
+                        evo_mthd(push, 0x0840 + (head->base.index * 0x400), 1);
                         evo_data(push, 0x40000000);
-                        evo_mthd(push, 0x085c + (nv_crtc->index * 0x400), 1);
+                        evo_mthd(push, 0x085c + (head->base.index * 0x400), 1);
                         evo_data(push, 0x00000000);
                 } else {
-                        evo_mthd(push, 0x0474 + (nv_crtc->index * 0x300), 1);
-                        evo_data(push, 0x00000000);
-                        evo_mthd(push, 0x0440 + (nv_crtc->index * 0x300), 1);
+                        evo_mthd(push, 0x0440 + (head->base.index * 0x300), 1);
                         evo_data(push, 0x03000000);
-                        evo_mthd(push, 0x045c + (nv_crtc->index * 0x300), 1);
+                        evo_mthd(push, 0x045c + (head->base.index * 0x300), 1);
                         evo_data(push, 0x00000000);
                 }
-
-                evo_kick(push, mast);
+                evo_kick(push, core);
         }
-
-        nv50_crtc_cursor_show_hide(nv_crtc, false, false);
 }
 
 static void
-nv50_crtc_commit(struct drm_crtc *crtc)
+nv50_head_lut_set(struct nv50_head *head, struct nv50_head_atom *asyh)
 {
-        struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-        struct nv50_mast *mast = nv50_mast(crtc->dev);
+        struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
         u32 *push;
-
-        push = evo_wait(mast, 32);
-        if (push) {
-                if (nv50_vers(mast) < G82_DISP_CORE_CHANNEL_DMA) {
-                        evo_mthd(push, 0x0874 + (nv_crtc->index * 0x400), 1);
-                        evo_data(push, nv_crtc->fb.handle);
-                        evo_mthd(push, 0x0840 + (nv_crtc->index * 0x400), 2);
+        if ((push = evo_wait(core, 7))) {
+                if (core->base.user.oclass < G82_DISP_CORE_CHANNEL_DMA) {
+                        evo_mthd(push, 0x0840 + (head->base.index * 0x400), 2);
                         evo_data(push, 0xc0000000);
-                        evo_data(push, nv_crtc->lut.nvbo->bo.offset >> 8);
+                        evo_data(push, asyh->lut.offset >> 8);
                 } else
-                if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                        evo_mthd(push, 0x0874 + (nv_crtc->index * 0x400), 1);
-                        evo_data(push, nv_crtc->fb.handle);
-                        evo_mthd(push, 0x0840 + (nv_crtc->index * 0x400), 2);
+                if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA) {
+                        evo_mthd(push, 0x0840 + (head->base.index * 0x400), 2);
                         evo_data(push, 0xc0000000);
-                        evo_data(push, nv_crtc->lut.nvbo->bo.offset >> 8);
-                        evo_mthd(push, 0x085c + (nv_crtc->index * 0x400), 1);
-                        evo_data(push, mast->base.vram.handle);
+                        evo_data(push, asyh->lut.offset >> 8);
+                        evo_mthd(push, 0x085c + (head->base.index * 0x400), 1);
+                        evo_data(push, asyh->lut.handle);
                 } else {
-                        evo_mthd(push, 0x0474 + (nv_crtc->index * 0x300), 1);
-                        evo_data(push, nv_crtc->fb.handle);
-                        evo_mthd(push, 0x0440 + (nv_crtc->index * 0x300), 4);
+                        evo_mthd(push, 0x0440 + (head->base.index * 0x300), 4);
                         evo_data(push, 0x83000000);
-                        evo_data(push, nv_crtc->lut.nvbo->bo.offset >> 8);
+                        evo_data(push, asyh->lut.offset >> 8);
                         evo_data(push, 0x00000000);
                         evo_data(push, 0x00000000);
-                        evo_mthd(push, 0x045c + (nv_crtc->index * 0x300), 1);
-                        evo_data(push, mast->base.vram.handle);
-                        evo_mthd(push, 0x0430 + (nv_crtc->index * 0x300), 1);
+                        evo_mthd(push, 0x045c + (head->base.index * 0x300), 1);
+                        evo_data(push, asyh->lut.handle);
+                }
+                evo_kick(push, core);
+        }
+}
+
+static void
+nv50_head_mode(struct nv50_head *head, struct nv50_head_atom *asyh)
+{
+        struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+        struct nv50_head_mode *m = &asyh->mode;
+        u32 *push;
+        if ((push = evo_wait(core, 14))) {
+                if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA) {
+                        evo_mthd(push, 0x0804 + (head->base.index * 0x400), 2);
+                        evo_data(push, 0x00800000 | m->clock);
+                        evo_data(push, m->interlace ? 0x00000002 : 0x00000000);
+                        evo_mthd(push, 0x0810 + (head->base.index * 0x400), 7);
+                        evo_data(push, 0x00000000);
+                        evo_data(push, (m->v.active  << 16) | m->h.active );
+                        evo_data(push, (m->v.synce   << 16) | m->h.synce  );
+                        evo_data(push, (m->v.blanke  << 16) | m->h.blanke );
+                        evo_data(push, (m->v.blanks  << 16) | m->h.blanks );
+                        evo_data(push, (m->v.blank2e << 16) | m->v.blank2s);
+                        evo_data(push, asyh->mode.v.blankus);
+                        evo_mthd(push, 0x082c + (head->base.index * 0x400), 1);
+                        evo_data(push, 0x00000000);
+                } else {
+                        evo_mthd(push, 0x0410 + (head->base.index * 0x300), 6);
+                        evo_data(push, 0x00000000);
+                        evo_data(push, (m->v.active  << 16) | m->h.active );
+                        evo_data(push, (m->v.synce   << 16) | m->h.synce  );
+                        evo_data(push, (m->v.blanke  << 16) | m->h.blanke );
+                        evo_data(push, (m->v.blanks  << 16) | m->h.blanks );
+                        evo_data(push, (m->v.blank2e << 16) | m->v.blank2s);
+                        evo_mthd(push, 0x042c + (head->base.index * 0x300), 2);
+                        evo_data(push, 0x00000000); /* ??? */
                         evo_data(push, 0xffffff00);
+                        evo_mthd(push, 0x0450 + (head->base.index * 0x300), 3);
+                        evo_data(push, m->clock * 1000);
+                        evo_data(push, 0x00200000); /* ??? */
+                        evo_data(push, m->clock * 1000);
                 }
+                evo_kick(push, core);
+        }
+}
 
-                evo_kick(push, mast);
+static void
+nv50_head_view(struct nv50_head *head, struct nv50_head_atom *asyh)
+{
+        struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+        u32 *push;
+        if ((push = evo_wait(core, 10))) {
+                if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA) {
+                        evo_mthd(push, 0x08a4 + (head->base.index * 0x400), 1);
+                        evo_data(push, 0x00000000);
+                        evo_mthd(push, 0x08c8 + (head->base.index * 0x400), 1);
+                        evo_data(push, (asyh->view.iH << 16) | asyh->view.iW);
+                        evo_mthd(push, 0x08d8 + (head->base.index * 0x400), 2);
+                        evo_data(push, (asyh->view.oH << 16) | asyh->view.oW);
+                        evo_data(push, (asyh->view.oH << 16) | asyh->view.oW);
+                } else {
+                        evo_mthd(push, 0x0494 + (head->base.index * 0x300), 1);
+                        evo_data(push, 0x00000000);
+                        evo_mthd(push, 0x04b8 + (head->base.index * 0x300), 1);
+                        evo_data(push, (asyh->view.iH << 16) | asyh->view.iW);
+                        evo_mthd(push, 0x04c0 + (head->base.index * 0x300), 3);
+                        evo_data(push, (asyh->view.oH << 16) | asyh->view.oW);
+                        evo_data(push, (asyh->view.oH << 16) | asyh->view.oW);
+                        evo_data(push, (asyh->view.oH << 16) | asyh->view.oW);
+                }
+                evo_kick(push, core);
         }
+}
 
-        nv50_crtc_cursor_show_hide(nv_crtc, true, true);
-        nv50_display_flip_next(crtc, crtc->primary->fb, NULL, 1);
+static void
+nv50_head_flush_clr(struct nv50_head *head, struct nv50_head_atom *asyh, bool y)
+{
+        if (asyh->clr.core && (!asyh->set.core || y))
+                nv50_head_lut_clr(head);
+        if (asyh->clr.core && (!asyh->set.core || y))
+                nv50_head_core_clr(head);
+        if (asyh->clr.curs && (!asyh->set.curs || y))
+                nv50_head_curs_clr(head);
 }
 
-static bool
-nv50_crtc_mode_fixup(struct drm_crtc *crtc, const struct drm_display_mode *mode,
-                     struct drm_display_mode *adjusted_mode)
+static void
+nv50_head_flush_set(struct nv50_head *head, struct nv50_head_atom *asyh)
 {
-        drm_mode_set_crtcinfo(adjusted_mode, CRTC_INTERLACE_HALVE_V);
-        return true;
+        if (asyh->set.view   ) nv50_head_view    (head, asyh);
+        if (asyh->set.mode   ) nv50_head_mode    (head, asyh);
+        if (asyh->set.core   ) nv50_head_lut_set (head, asyh);
+        if (asyh->set.core   ) nv50_head_core_set(head, asyh);
+        if (asyh->set.curs   ) nv50_head_curs_set(head, asyh);
+        if (asyh->set.base   ) nv50_head_base    (head, asyh);
+        if (asyh->set.ovly   ) nv50_head_ovly    (head, asyh);
+        if (asyh->set.dither ) nv50_head_dither  (head, asyh);
+        if (asyh->set.procamp) nv50_head_procamp (head, asyh);
 }
 
-static int
-nv50_crtc_swap_fbs(struct drm_crtc *crtc, struct drm_framebuffer *old_fb)
+static void
+nv50_head_atomic_check_procamp(struct nv50_head_atom *armh,
+                               struct nv50_head_atom *asyh,
+                               struct nouveau_conn_atom *asyc)
 {
-        struct nouveau_framebuffer *nvfb = nouveau_framebuffer(crtc->primary->fb);
-        struct nv50_head *head = nv50_head(crtc);
-        int ret;
+        const int vib = asyc->procamp.color_vibrance - 100;
+        const int hue = asyc->procamp.vibrant_hue - 90;
+        const int adj = (vib > 0) ? 50 : 0;
+        asyh->procamp.sat.cos = ((vib * 2047 + adj) / 100) & 0xfff;
+        asyh->procamp.sat.sin = ((hue * 2047) / 100) & 0xfff;
+        asyh->set.procamp = true;
+}
 
-        ret = nouveau_bo_pin(nvfb->nvbo, TTM_PL_FLAG_VRAM, true);
-        if (ret == 0) {
-                if (head->image)
-                        nouveau_bo_unpin(head->image);
-                nouveau_bo_ref(nvfb->nvbo, &head->image);
+static void
+nv50_head_atomic_check_dither(struct nv50_head_atom *armh,
+                              struct nv50_head_atom *asyh,
+                              struct nouveau_conn_atom *asyc)
+{
+        struct drm_connector *connector = asyc->state.connector;
+        u32 mode = 0x00;
+
+        if (asyc->dither.mode == DITHERING_MODE_AUTO) {
+                if (asyh->base.depth > connector->display_info.bpc * 3)
+                        mode = DITHERING_MODE_DYNAMIC2X2;
+        } else {
+                mode = asyc->dither.mode;
         }
 
-        return ret;
+        if (asyc->dither.depth == DITHERING_DEPTH_AUTO) {
+                if (connector->display_info.bpc >= 8)
+                        mode |= DITHERING_DEPTH_8BPC;
+        } else {
+                mode |= asyc->dither.depth;
+        }
+
+        asyh->dither.enable = mode;
+        asyh->dither.bits = mode >> 1;
+        asyh->dither.mode = mode >> 3;
+        asyh->set.dither = true;
 }
 
-static int
-nv50_crtc_mode_set(struct drm_crtc *crtc, struct drm_display_mode *umode,
-                   struct drm_display_mode *mode, int x, int y,
-                   struct drm_framebuffer *old_fb)
+static void
+nv50_head_atomic_check_view(struct nv50_head_atom *armh,
+                            struct nv50_head_atom *asyh,
+                            struct nouveau_conn_atom *asyc)
 {
-        struct nv50_mast *mast = nv50_mast(crtc->dev);
-        struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-        struct nouveau_connector *nv_connector;
-        u32 ilace = (mode->flags & DRM_MODE_FLAG_INTERLACE) ? 2 : 1;
-        u32 vscan = (mode->flags & DRM_MODE_FLAG_DBLSCAN) ? 2 : 1;
-        u32 hactive, hsynce, hbackp, hfrontp, hblanke, hblanks;
-        u32 vactive, vsynce, vbackp, vfrontp, vblanke, vblanks;
-        u32 vblan2e = 0, vblan2s = 1, vblankus = 0;
-        u32 *push;
-        int ret;
-
-        hactive = mode->htotal;
-        hsynce  = mode->hsync_end - mode->hsync_start - 1;
-        hbackp  = mode->htotal - mode->hsync_end;
-        hblanke = hsynce + hbackp;
-        hfrontp = mode->hsync_start - mode->hdisplay;
-        hblanks = mode->htotal - hfrontp - 1;
-
-        vactive = mode->vtotal * vscan / ilace;
-        vsynce  = ((mode->vsync_end - mode->vsync_start) * vscan / ilace) - 1;
-        vbackp  = (mode->vtotal - mode->vsync_end) * vscan / ilace;
-        vblanke = vsynce + vbackp;
-        vfrontp = (mode->vsync_start - mode->vdisplay) * vscan / ilace;
-        vblanks = vactive - vfrontp - 1;
-        /* XXX: Safe underestimate, even "0" works */
-        vblankus = (vactive - mode->vdisplay - 2) * hactive;
-        vblankus *= 1000;
-        vblankus /= mode->clock;
+        struct drm_connector *connector = asyc->state.connector;
+        struct drm_display_mode *omode = &asyh->state.adjusted_mode;
+        struct drm_display_mode *umode = &asyh->state.mode;
+        int mode = asyc->scaler.mode;
+        struct edid *edid;
+
+        if (connector->edid_blob_ptr)
+                edid = (struct edid *)connector->edid_blob_ptr->data;
+        else
+                edid = NULL;
 
-        if (mode->flags & DRM_MODE_FLAG_INTERLACE) {
-                vblan2e = vactive + vsynce + vbackp;
-                vblan2s = vblan2e + (mode->vdisplay * vscan / ilace);
-                vactive = (vactive * 2) + 1;
+        if (!asyc->scaler.full) {
+                if (mode == DRM_MODE_SCALE_NONE)
+                        omode = umode;
+        } else {
+                /* Non-EDID LVDS/eDP mode. */
+                mode = DRM_MODE_SCALE_FULLSCREEN;
         }
 
-        ret = nv50_crtc_swap_fbs(crtc, old_fb);
-        if (ret)
-                return ret;
+        asyh->view.iW = umode->hdisplay;
+        asyh->view.iH = umode->vdisplay;
+        asyh->view.oW = omode->hdisplay;
+        asyh->view.oH = omode->vdisplay;
+        if (omode->flags & DRM_MODE_FLAG_DBLSCAN)
+                asyh->view.oH *= 2;
 
-        push = evo_wait(mast, 64);
-        if (push) {
-                if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                        evo_mthd(push, 0x0804 + (nv_crtc->index * 0x400), 2);
-                        evo_data(push, 0x00800000 | mode->clock);
-                        evo_data(push, (ilace == 2) ? 2 : 0);
-                        evo_mthd(push, 0x0810 + (nv_crtc->index * 0x400), 6);
-                        evo_data(push, 0x00000000);
-                        evo_data(push, (vactive << 16) | hactive);
-                        evo_data(push, ( vsynce << 16) | hsynce);
-                        evo_data(push, (vblanke << 16) | hblanke);
-                        evo_data(push, (vblanks << 16) | hblanks);
-                        evo_data(push, (vblan2e << 16) | vblan2s);
-                        evo_mthd(push, 0x082c + (nv_crtc->index * 0x400), 1);
-                        evo_data(push, 0x00000000);
-                        evo_mthd(push, 0x0900 + (nv_crtc->index * 0x400), 2);
-                        evo_data(push, 0x00000311);
-                        evo_data(push, 0x00000100);
+        /* Add overscan compensation if necessary, will keep the aspect
+         * ratio the same as the backend mode unless overridden by the
+         * user setting both hborder and vborder properties.
+         */
+        if ((asyc->scaler.underscan.mode == UNDERSCAN_ON ||
+            (asyc->scaler.underscan.mode == UNDERSCAN_AUTO &&
+             drm_detect_hdmi_monitor(edid)))) {
+                u32 bX = asyc->scaler.underscan.hborder;
+                u32 bY = asyc->scaler.underscan.vborder;
+                u32 r = (asyh->view.oH << 19) / asyh->view.oW;
+
+                if (bX) {
+                        asyh->view.oW -= (bX * 2);
+                        if (bY) asyh->view.oH -= (bY * 2);
+                        else    asyh->view.oH  = ((asyh->view.oW * r) + (r / 2)) >> 19;
                 } else {
-                        evo_mthd(push, 0x0410 + (nv_crtc->index * 0x300), 6);
-                        evo_data(push, 0x00000000);
-                        evo_data(push, (vactive << 16) | hactive);
-                        evo_data(push, ( vsynce << 16) | hsynce);
-                        evo_data(push, (vblanke << 16) | hblanke);
-                        evo_data(push, (vblanks << 16) | hblanks);
-                        evo_data(push, (vblan2e << 16) | vblan2s);
-                        evo_mthd(push, 0x042c + (nv_crtc->index * 0x300), 1);
-                        evo_data(push, 0x00000000); /* ??? */
-                        evo_mthd(push, 0x0450 + (nv_crtc->index * 0x300), 3);
-                        evo_data(push, mode->clock * 1000);
-                        evo_data(push, 0x00200000); /* ??? */
-                        evo_data(push, mode->clock * 1000);
-                        evo_mthd(push, 0x04d0 + (nv_crtc->index * 0x300), 2);
-                        evo_data(push, 0x00000311);
-                        evo_data(push, 0x00000100);
+                        asyh->view.oW -= (asyh->view.oW >> 4) + 32;
+                        if (bY) asyh->view.oH -= (bY * 2);
+                        else    asyh->view.oH  = ((asyh->view.oW * r) + (r / 2)) >> 19;
                 }
+        }
 
-                evo_kick(push, mast);
+        /* Handle CENTER/ASPECT scaling, taking into account the areas
+         * removed already for overscan compensation.
+         */
+        switch (mode) {
+        case DRM_MODE_SCALE_CENTER:
+                asyh->view.oW = min((u16)umode->hdisplay, asyh->view.oW);
+                asyh->view.oH = min((u16)umode->vdisplay, asyh->view.oH);
+                /* fall-through */
+        case DRM_MODE_SCALE_ASPECT:
+                if (asyh->view.oH < asyh->view.oW) {
+                        u32 r = (asyh->view.iW << 19) / asyh->view.iH;
+                        asyh->view.oW = ((asyh->view.oH * r) + (r / 2)) >> 19;
+                } else {
+                        u32 r = (asyh->view.iH << 19) / asyh->view.iW;
+                        asyh->view.oH = ((asyh->view.oW * r) + (r / 2)) >> 19;
+                }
+                break;
+        default:
+                break;
         }
 
-        nv_connector = nouveau_crtc_connector_get(nv_crtc);
-        nv50_crtc_set_dither(nv_crtc, false);
-        nv50_crtc_set_scale(nv_crtc, false);
+        asyh->set.view = true;
+}
+
+static void
+nv50_head_atomic_check_mode(struct nv50_head *head, struct nv50_head_atom *asyh)
+{
+        struct drm_display_mode *mode = &asyh->state.adjusted_mode;
+        u32 ilace   = (mode->flags & DRM_MODE_FLAG_INTERLACE) ? 2 : 1;
+        u32 vscan   = (mode->flags & DRM_MODE_FLAG_DBLSCAN) ? 2 : 1;
+        u32 hbackp  =  mode->htotal - mode->hsync_end;
+        u32 vbackp  = (mode->vtotal - mode->vsync_end) * vscan / ilace;
+        u32 hfrontp =  mode->hsync_start - mode->hdisplay;
+        u32 vfrontp = (mode->vsync_start - mode->vdisplay) * vscan / ilace;
+        struct nv50_head_mode *m = &asyh->mode;
+
+        m->h.active = mode->htotal;
+        m->h.synce  = mode->hsync_end - mode->hsync_start - 1;
+        m->h.blanke = m->h.synce + hbackp;
+        m->h.blanks = mode->htotal - hfrontp - 1;
+
+        m->v.active = mode->vtotal * vscan / ilace;
+        m->v.synce  = ((mode->vsync_end - mode->vsync_start) * vscan / ilace) - 1;
+        m->v.blanke = m->v.synce + vbackp;
+        m->v.blanks = m->v.active - vfrontp - 1;
+
+        /*XXX: Safe underestimate, even "0" works */
+        m->v.blankus = (m->v.active - mode->vdisplay - 2) * m->h.active;
+        m->v.blankus *= 1000;
+        m->v.blankus /= mode->clock;
 
-        /* G94 only accepts this after setting scale */
-        if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA)
-                nv50_crtc_set_raster_vblank_dmi(nv_crtc, vblankus);
+        if (mode->flags & DRM_MODE_FLAG_INTERLACE) {
+                m->v.blank2e =  m->v.active + m->v.synce + vbackp;
+                m->v.blank2s =  m->v.blank2e + (mode->vdisplay * vscan / ilace);
+                m->v.active  = (m->v.active * 2) + 1;
+                m->interlace = true;
+        } else {
+                m->v.blank2e = 0;
+                m->v.blank2s = 1;
+                m->interlace = false;
+        }
+        m->clock = mode->clock;
 
-        nv50_crtc_set_color_vibrance(nv_crtc, false);
-        nv50_crtc_set_image(nv_crtc, crtc->primary->fb, x, y, false);
-        return 0;
+        drm_mode_set_crtcinfo(mode, CRTC_INTERLACE_HALVE_V);
+        asyh->set.mode = true;
 }
 
 static int
-nv50_crtc_mode_set_base(struct drm_crtc *crtc, int x, int y,
-                        struct drm_framebuffer *old_fb)
+nv50_head_atomic_check(struct drm_crtc *crtc, struct drm_crtc_state *state)
 {
         struct nouveau_drm *drm = nouveau_drm(crtc->dev);
-        struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-        int ret;
+        struct nv50_disp *disp = nv50_disp(crtc->dev);
+        struct nv50_head *head = nv50_head(crtc);
+        struct nv50_head_atom *armh = nv50_head_atom(crtc->state);
+        struct nv50_head_atom *asyh = nv50_head_atom(state);
+        struct nouveau_conn_atom *asyc = NULL;
+        struct drm_connector_state *conns;
+        struct drm_connector *conn;
+        int i;
 
-        if (!crtc->primary->fb) {
-                NV_DEBUG(drm, "No FB bound\n");
-                return 0;
+        NV_ATOMIC(drm, "%s atomic_check %d\n", crtc->name, asyh->state.active);
+        if (asyh->state.active) {
+                for_each_connector_in_state(asyh->state.state, conn, conns, i) {
+                        if (conns->crtc == crtc) {
+                                asyc = nouveau_conn_atom(conns);
+                                break;
+                        }
+                }
+
+                if (armh->state.active) {
+                        if (asyc) {
+                                if (asyh->state.mode_changed)
+                                        asyc->set.scaler = true;
+                                if (armh->base.depth != asyh->base.depth)
+                                        asyc->set.dither = true;
+                        }
+                } else {
+                        asyc->set.mask = ~0;
+                        asyh->set.mask = ~0;
+                }
+
+                if (asyh->state.mode_changed)
+                        nv50_head_atomic_check_mode(head, asyh);
+
+                if (asyc) {
+                        if (asyc->set.scaler)
+                                nv50_head_atomic_check_view(armh, asyh, asyc);
+                        if (asyc->set.dither)
+                                nv50_head_atomic_check_dither(armh, asyh, asyc);
+                        if (asyc->set.procamp)
+                                nv50_head_atomic_check_procamp(armh, asyh, asyc);
+                }
+
+                if ((asyh->core.visible = (asyh->base.cpp != 0))) {
+                        asyh->core.x = asyh->base.x;
+                        asyh->core.y = asyh->base.y;
+                        asyh->core.w = asyh->base.w;
+                        asyh->core.h = asyh->base.h;
+                } else
+                if ((asyh->core.visible = asyh->curs.visible)) {
+                        /*XXX: We need to either find some way of having the
+                         *     primary base layer appear black, while still
+                         *     being able to display the other layers, or we
+                         *     need to allocate a dummy black surface here.
+                         */
+                        asyh->core.x = 0;
+                        asyh->core.y = 0;
+                        asyh->core.w = asyh->state.mode.hdisplay;
+                        asyh->core.h = asyh->state.mode.vdisplay;
+                }
+                asyh->core.handle = disp->mast.base.vram.handle;
+                asyh->core.offset = 0;
+                asyh->core.format = 0xcf;
+                asyh->core.kind = 0;
+                asyh->core.layout = 1;
+                asyh->core.block = 0;
+                asyh->core.pitch = ALIGN(asyh->core.w, 64) * 4;
+                asyh->lut.handle = disp->mast.base.vram.handle;
+                asyh->lut.offset = head->base.lut.nvbo->bo.offset;
+                asyh->set.base = armh->base.cpp != asyh->base.cpp;
+                asyh->set.ovly = armh->ovly.cpp != asyh->ovly.cpp;
+        } else {
+                asyh->core.visible = false;
+                asyh->curs.visible = false;
+                asyh->base.cpp = 0;
+                asyh->ovly.cpp = 0;
         }
 
-        ret = nv50_crtc_swap_fbs(crtc, old_fb);
-        if (ret)
-                return ret;
+        if (!drm_atomic_crtc_needs_modeset(&asyh->state)) {
+                if (asyh->core.visible) {
+                        if (memcmp(&armh->core, &asyh->core, sizeof(asyh->core)))
+                                asyh->set.core = true;
+                } else
+                if (armh->core.visible) {
+                        asyh->clr.core = true;
+                }
 
-        nv50_display_flip_stop(crtc);
-        nv50_crtc_set_image(nv_crtc, crtc->primary->fb, x, y, true);
-        nv50_display_flip_next(crtc, crtc->primary->fb, NULL, 1);
-        return 0;
-}
+                if (asyh->curs.visible) {
+                        if (memcmp(&armh->curs, &asyh->curs, sizeof(asyh->curs)))
+                                asyh->set.curs = true;
+                } else
+                if (armh->curs.visible) {
+                        asyh->clr.curs = true;
+                }
+        } else {
+                asyh->clr.core = armh->core.visible;
+                asyh->clr.curs = armh->curs.visible;
+                asyh->set.core = asyh->core.visible;
+                asyh->set.curs = asyh->curs.visible;
+        }
 
-static int
-nv50_crtc_mode_set_base_atomic(struct drm_crtc *crtc,
-                               struct drm_framebuffer *fb, int x, int y,
-                               enum mode_set_atomic state)
-{
-        struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-        nv50_display_flip_stop(crtc);
-        nv50_crtc_set_image(nv_crtc, fb, x, y, true);
+        if (asyh->clr.mask || asyh->set.mask)
+                nv50_atom(asyh->state.state)->lock_core = true;
         return 0;
 }
 
 static void
-nv50_crtc_lut_load(struct drm_crtc *crtc)
+nv50_head_lut_load(struct drm_crtc *crtc)
 {
         struct nv50_disp *disp = nv50_disp(crtc->dev);
         struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
@@ -1292,64 +2200,95 @@ nv50_crtc_lut_load(struct drm_crtc *crtc)
         }
 }
 
-static void
-nv50_crtc_disable(struct drm_crtc *crtc)
+static int
+nv50_head_mode_set_base_atomic(struct drm_crtc *crtc,
+                               struct drm_framebuffer *fb, int x, int y,
+                               enum mode_set_atomic state)
 {
-        struct nv50_head *head = nv50_head(crtc);
-        evo_sync(crtc->dev);
-        if (head->image)
-                nouveau_bo_unpin(head->image);
-        nouveau_bo_ref(NULL, &head->image);
+        WARN_ON(1);
+        return 0;
 }
 
+static const struct drm_crtc_helper_funcs
+nv50_head_help = {
+        .mode_set_base_atomic = nv50_head_mode_set_base_atomic,
+        .load_lut = nv50_head_lut_load,
+        .atomic_check = nv50_head_atomic_check,
+};
+
+/* This is identical to the version in the atomic helpers, except that
+ * it supports non-vblanked ("async") page flips.
+ */
 static int
-nv50_crtc_cursor_set(struct drm_crtc *crtc, struct drm_file *file_priv,
-                     uint32_t handle, uint32_t width, uint32_t height)
+nv50_head_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *fb,
+                    struct drm_pending_vblank_event *event, u32 flags)
 {
-        struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-        struct drm_gem_object *gem = NULL;
-        struct nouveau_bo *nvbo = NULL;
+        struct drm_plane *plane = crtc->primary;
+        struct drm_atomic_state *state;
+        struct drm_plane_state *plane_state;
+        struct drm_crtc_state *crtc_state;
         int ret = 0;
 
-        if (handle) {
-                if (width != 64 || height != 64)
-                        return -EINVAL;
+        state = drm_atomic_state_alloc(plane->dev);
+        if (!state)
+                return -ENOMEM;
 
-                gem = drm_gem_object_lookup(file_priv, handle);
-                if (unlikely(!gem))
-                        return -ENOENT;
-                nvbo = nouveau_gem_object(gem);
+        state->acquire_ctx = drm_modeset_legacy_acquire_ctx(crtc);
+retry:
+        crtc_state = drm_atomic_get_crtc_state(state, crtc);
+        if (IS_ERR(crtc_state)) {
+                ret = PTR_ERR(crtc_state);
+                goto fail;
+        }
+        crtc_state->event = event;
 
-                ret = nouveau_bo_pin(nvbo, TTM_PL_FLAG_VRAM, true);
+        plane_state = drm_atomic_get_plane_state(state, plane);
+        if (IS_ERR(plane_state)) {
+                ret = PTR_ERR(plane_state);
+                goto fail;
         }
 
-        if (ret == 0) {
-                if (nv_crtc->cursor.nvbo)
-                        nouveau_bo_unpin(nv_crtc->cursor.nvbo);
-                nouveau_bo_ref(nvbo, &nv_crtc->cursor.nvbo);
+        ret = drm_atomic_set_crtc_for_plane(plane_state, crtc);
+        if (ret != 0)
+                goto fail;
+        drm_atomic_set_fb_for_plane(plane_state, fb);
+
+        /* Make sure we don't accidentally do a full modeset. */
+        state->allow_modeset = false;
+        if (!crtc_state->active) {
+                DRM_DEBUG_ATOMIC("[CRTC:%d] disabled, rejecting legacy flip\n",
+                                 crtc->base.id);
+                ret = -EINVAL;
+                goto fail;
         }
-        drm_gem_object_unreference_unlocked(gem);
 
-        nv50_crtc_cursor_show_hide(nv_crtc, true, true);
+        if (flags & DRM_MODE_PAGE_FLIP_ASYNC)
+                nv50_wndw_atom(plane_state)->interval = 0;
+
+        ret = drm_atomic_nonblocking_commit(state);
+fail:
+        if (ret == -EDEADLK)
+                goto backoff;
+
+        drm_atomic_state_put(state);
         return ret;
-}
 
-static int
-nv50_crtc_cursor_move(struct drm_crtc *crtc, int x, int y)
-{
-        struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-        struct nv50_curs *curs = nv50_curs(crtc);
-        struct nv50_chan *chan = nv50_chan(curs);
-        nvif_wr32(&chan->user, 0x0084, (y << 16) | (x & 0xffff));
-        nvif_wr32(&chan->user, 0x0080, 0x00000000);
+backoff:
+        drm_atomic_state_clear(state);
+        drm_atomic_legacy_backoff(state);
 
-        nv_crtc->cursor_saved_x = x;
-        nv_crtc->cursor_saved_y = y;
-        return 0;
+        /*
+         * Someone might have exchanged the framebuffer while we dropped locks
+         * in the backoff code. We need to fix up the fb refcount tracking the
+         * core does for us.
+         */
+        plane->old_fb = plane->fb;
+
+        goto retry;
 }
 
 static int
-nv50_crtc_gamma_set(struct drm_crtc *crtc, u16 *r, u16 *g, u16 *b,
+nv50_head_gamma_set(struct drm_crtc *crtc, u16 *r, u16 *g, u16 *b,
                     uint32_t size)
 {
         struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
@@ -1361,47 +2300,71 @@ nv50_crtc_gamma_set(struct drm_crtc *crtc, u16 *r, u16 *g, u16 *b,
                 nv_crtc->lut.b[i] = b[i];
         }
 
-        nv50_crtc_lut_load(crtc);
-
+        nv50_head_lut_load(crtc);
         return 0;
 }
 
 static void
-nv50_crtc_cursor_restore(struct nouveau_crtc *nv_crtc, int x, int y)
+nv50_head_atomic_destroy_state(struct drm_crtc *crtc,
+                               struct drm_crtc_state *state)
 {
-        nv50_crtc_cursor_move(&nv_crtc->base, x, y);
+        struct nv50_head_atom *asyh = nv50_head_atom(state);
+        __drm_atomic_helper_crtc_destroy_state(&asyh->state);
+        kfree(asyh);
+}
 
-        nv50_crtc_cursor_show_hide(nv_crtc, true, true);
+static struct drm_crtc_state *
+nv50_head_atomic_duplicate_state(struct drm_crtc *crtc)
+{
+        struct nv50_head_atom *armh = nv50_head_atom(crtc->state);
+        struct nv50_head_atom *asyh;
+        if (!(asyh = kmalloc(sizeof(*asyh), GFP_KERNEL)))
+                return NULL;
+        __drm_atomic_helper_crtc_duplicate_state(crtc, &asyh->state);
+        asyh->view = armh->view;
+        asyh->mode = armh->mode;
+        asyh->lut  = armh->lut;
+        asyh->core = armh->core;
+        asyh->curs = armh->curs;
+        asyh->base = armh->base;
+        asyh->ovly = armh->ovly;
+        asyh->dither = armh->dither;
+        asyh->procamp = armh->procamp;
+        asyh->clr.mask = 0;
+        asyh->set.mask = 0;
+        return &asyh->state;
+}
+
+static void
+__drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
+                               struct drm_crtc_state *state)
+{
+        if (crtc->state)
+                crtc->funcs->atomic_destroy_state(crtc, crtc->state);
+        crtc->state = state;
+        crtc->state->crtc = crtc;
 }
 
 static void
-nv50_crtc_destroy(struct drm_crtc *crtc)
+nv50_head_reset(struct drm_crtc *crtc)
+{
+        struct nv50_head_atom *asyh;
+
+        if (WARN_ON(!(asyh = kzalloc(sizeof(*asyh), GFP_KERNEL))))
+                return;
+
+        __drm_atomic_helper_crtc_reset(crtc, &asyh->state);
+}
+
+static void
+nv50_head_destroy(struct drm_crtc *crtc)
 {
         struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
         struct nv50_disp *disp = nv50_disp(crtc->dev);
         struct nv50_head *head = nv50_head(crtc);
-        struct nv50_fbdma *fbdma;
-
-        list_for_each_entry(fbdma, &disp->fbdma, head) {
-                nvif_object_fini(&fbdma->base[nv_crtc->index]);
-        }
 
         nv50_dmac_destroy(&head->ovly.base, disp->disp);
         nv50_pioc_destroy(&head->oimm.base);
-        nv50_dmac_destroy(&head->sync.base, disp->disp);
-        nv50_pioc_destroy(&head->curs.base);
-
-        /*XXX: this shouldn't be necessary, but the core doesn't call
-         *     disconnect() during the cleanup paths
-         */
-        if (head->image)
-                nouveau_bo_unpin(head->image);
-        nouveau_bo_ref(NULL, &head->image);
-
-        /*XXX: ditto */
-        if (nv_crtc->cursor.nvbo)
-                nouveau_bo_unpin(nv_crtc->cursor.nvbo);
-        nouveau_bo_ref(NULL, &nv_crtc->cursor.nvbo);
 
         nouveau_bo_unmap(nv_crtc->lut.nvbo);
         if (nv_crtc->lut.nvbo)
@@ -1412,34 +2375,27 @@ nv50_crtc_destroy(struct drm_crtc *crtc)
         kfree(crtc);
 }
 
-static const struct drm_crtc_helper_funcs nv50_crtc_hfunc = {
-        .dpms = nv50_crtc_dpms,
-        .prepare = nv50_crtc_prepare,
-        .commit = nv50_crtc_commit,
-        .mode_fixup = nv50_crtc_mode_fixup,
-        .mode_set = nv50_crtc_mode_set,
-        .mode_set_base = nv50_crtc_mode_set_base,
-        .mode_set_base_atomic = nv50_crtc_mode_set_base_atomic,
-        .load_lut = nv50_crtc_lut_load,
-        .disable = nv50_crtc_disable,
-};
-
-static const struct drm_crtc_funcs nv50_crtc_func = {
-        .cursor_set = nv50_crtc_cursor_set,
-        .cursor_move = nv50_crtc_cursor_move,
-        .gamma_set = nv50_crtc_gamma_set,
-        .set_config = nouveau_crtc_set_config,
-        .destroy = nv50_crtc_destroy,
-        .page_flip = nouveau_crtc_page_flip,
+static const struct drm_crtc_funcs
+nv50_head_func = {
+        .reset = nv50_head_reset,
+        .gamma_set = nv50_head_gamma_set,
+        .destroy = nv50_head_destroy,
+        .set_config = drm_atomic_helper_set_config,
+        .page_flip = nv50_head_page_flip,
+        .set_property = drm_atomic_helper_crtc_set_property,
+        .atomic_duplicate_state = nv50_head_atomic_duplicate_state,
+        .atomic_destroy_state = nv50_head_atomic_destroy_state,
 };
 
 static int
-nv50_crtc_create(struct drm_device *dev, int index)
+nv50_head_create(struct drm_device *dev, int index)
 {
         struct nouveau_drm *drm = nouveau_drm(dev);
         struct nvif_device *device = &drm->device;
         struct nv50_disp *disp = nv50_disp(dev);
         struct nv50_head *head;
+        struct nv50_base *base;
+        struct nv50_curs *curs;
         struct drm_crtc *crtc;
         int ret, i;
 
@@ -1448,21 +2404,25 @@ nv50_crtc_create(struct drm_device *dev, int index)
                 return -ENOMEM;
 
         head->base.index = index;
-        head->base.set_dither = nv50_crtc_set_dither;
-        head->base.set_scale = nv50_crtc_set_scale;
-        head->base.set_color_vibrance = nv50_crtc_set_color_vibrance;
-        head->base.color_vibrance = 50;
-        head->base.vibrant_hue = 0;
-        head->base.cursor.set_pos = nv50_crtc_cursor_restore;
         for (i = 0; i < 256; i++) {
                 head->base.lut.r[i] = i << 8;
                 head->base.lut.g[i] = i << 8;
                 head->base.lut.b[i] = i << 8;
         }
 
+        ret = nv50_base_new(drm, head, &base);
+        if (ret == 0)
+                ret = nv50_curs_new(drm, head, &curs);
+        if (ret) {
+                kfree(head);
+                return ret;
+        }
+
         crtc = &head->base.base;
-        drm_crtc_init(dev, crtc, &nv50_crtc_func);
-        drm_crtc_helper_add(crtc, &nv50_crtc_hfunc);
+        drm_crtc_init_with_planes(dev, crtc, &base->wndw.plane,
+                                  &curs->wndw.plane, &nv50_head_func,
+                                  "head-%d", head->base.index);
+        drm_crtc_helper_add(crtc, &nv50_head_help);
         drm_mode_crtc_set_gamma_size(crtc, 256);
 
         ret = nouveau_bo_new(dev, 8192, 0x100, TTM_PL_FLAG_VRAM,
@@ -1481,20 +2441,6 @@ nv50_crtc_create(struct drm_device *dev, int index)
         if (ret)
                 goto out;
 
-        /* allocate cursor resources */
-        ret = nv50_curs_create(device, disp->disp, index, &head->curs);
-        if (ret)
-                goto out;
-
-        /* allocate page flip / sync resources */
-        ret = nv50_base_create(device, disp->disp, index, disp->sync->bo.offset,
-                               &head->sync);
-        if (ret)
-                goto out;
-
-        head->sync.addr = EVO_FLIP_SEM0(index);
-        head->sync.data = 0x00000000;
-
         /* allocate overlay resources */
         ret = nv50_oimm_create(device, disp->disp, index, &head->oimm);
         if (ret)
@@ -1507,43 +2453,64 @@ nv50_crtc_create(struct drm_device *dev, int index)
 
 out:
         if (ret)
-                nv50_crtc_destroy(crtc);
+                nv50_head_destroy(crtc);
         return ret;
 }
 
 /******************************************************************************
- * Encoder helpers
+ * Output path helpers
  *****************************************************************************/
-static bool
-nv50_encoder_mode_fixup(struct drm_encoder *encoder,
-                        const struct drm_display_mode *mode,
-                        struct drm_display_mode *adjusted_mode)
+static int
+nv50_outp_atomic_check_view(struct drm_encoder *encoder,
+                            struct drm_crtc_state *crtc_state,
+                            struct drm_connector_state *conn_state,
+                            struct drm_display_mode *native_mode)
 {
-        struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
-        struct nouveau_connector *nv_connector;
+        struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode;
+        struct drm_display_mode *mode = &crtc_state->mode;
+        struct drm_connector *connector = conn_state->connector;
+        struct nouveau_conn_atom *asyc = nouveau_conn_atom(conn_state);
+        struct nouveau_drm *drm = nouveau_drm(encoder->dev);
+
+        NV_ATOMIC(drm, "%s atomic_check\n", encoder->name);
+        asyc->scaler.full = false;
+        if (!native_mode)
+                return 0;
 
-        nv_connector = nouveau_encoder_connector_get(nv_encoder);
-        if (nv_connector && nv_connector->native_mode) {
-                nv_connector->scaling_full = false;
-                if (nv_connector->scaling_mode == DRM_MODE_SCALE_NONE) {
-                        switch (nv_connector->type) {
-                        case DCB_CONNECTOR_LVDS:
-                        case DCB_CONNECTOR_LVDS_SPWG:
-                        case DCB_CONNECTOR_eDP:
-                                /* force use of scaler for non-edid modes */
-                                if (adjusted_mode->type & DRM_MODE_TYPE_DRIVER)
-                                        return true;
-                                nv_connector->scaling_full = true;
+        if (asyc->scaler.mode == DRM_MODE_SCALE_NONE) {
+                switch (connector->connector_type) {
+                case DRM_MODE_CONNECTOR_LVDS:
+                case DRM_MODE_CONNECTOR_eDP:
+                        /* Force use of scaler for non-EDID modes. */
+                        if (adjusted_mode->type & DRM_MODE_TYPE_DRIVER)
                                 break;
-                        default:
-                                return true;
-                        }
+                        mode = native_mode;
+                        asyc->scaler.full = true;
+                        break;
+                default:
+                        break;
                 }
+        } else {
+                mode = native_mode;
+        }
 
-                drm_mode_copy(adjusted_mode, nv_connector->native_mode);
+        if (!drm_mode_equal(adjusted_mode, mode)) {
+                drm_mode_copy(adjusted_mode, mode);
+                crtc_state->mode_changed = true;
         }
 
-        return true;
+        return 0;
+}
+
+static int
+nv50_outp_atomic_check(struct drm_encoder *encoder,
+                       struct drm_crtc_state *crtc_state,
+                       struct drm_connector_state *conn_state)
+{
+        struct nouveau_connector *nv_connector =
+                nouveau_connector(conn_state->connector);
+        return nv50_outp_atomic_check_view(encoder, crtc_state, conn_state,
+                                           nv_connector->native_mode);
 }
 
 /******************************************************************************
@@ -1574,21 +2541,39 @@ nv50_dac_dpms(struct drm_encoder *encoder, int mode)
 }
 
 static void
-nv50_dac_commit(struct drm_encoder *encoder)
+nv50_dac_disable(struct drm_encoder *encoder)
 {
+        struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
+        struct nv50_mast *mast = nv50_mast(encoder->dev);
+        const int or = nv_encoder->or;
+        u32 *push;
+
+        if (nv_encoder->crtc) {
+                push = evo_wait(mast, 4);
+                if (push) {
+                        if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
+                                evo_mthd(push, 0x0400 + (or * 0x080), 1);
+                                evo_data(push, 0x00000000);
+                        } else {
+                                evo_mthd(push, 0x0180 + (or * 0x020), 1);
+                                evo_data(push, 0x00000000);
+                        }
+                        evo_kick(push, mast);
+                }
+        }
+
+        nv_encoder->crtc = NULL;
 }
 
 static void
-nv50_dac_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode,
-                  struct drm_display_mode *adjusted_mode)
+nv50_dac_enable(struct drm_encoder *encoder)
 {
         struct nv50_mast *mast = nv50_mast(encoder->dev);
         struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
         struct nouveau_crtc *nv_crtc = nouveau_crtc(encoder->crtc);
+        struct drm_display_mode *mode = &nv_crtc->base.state->adjusted_mode;
         u32 *push;
 
-        nv50_dac_dpms(encoder, DRM_MODE_DPMS_ON);
-
         push = evo_wait(mast, 8);
         if (push) {
                 if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
@@ -1627,33 +2612,6 @@ nv50_dac_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode,
         nv_encoder->crtc = encoder->crtc;
 }
 
-static void
-nv50_dac_disconnect(struct drm_encoder *encoder)
-{
-        struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
-        struct nv50_mast *mast = nv50_mast(encoder->dev);
-        const int or = nv_encoder->or;
-        u32 *push;
-
-        if (nv_encoder->crtc) {
-                nv50_crtc_prepare(nv_encoder->crtc);
-
-                push = evo_wait(mast, 4);
-                if (push) {
-                        if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                                evo_mthd(push, 0x0400 + (or * 0x080), 1);
-                                evo_data(push, 0x00000000);
-                        } else {
-                                evo_mthd(push, 0x0180 + (or * 0x020), 1);
-                                evo_data(push, 0x00000000);
-                        }
-                        evo_kick(push, mast);
-                }
-        }
-
-        nv_encoder->crtc = NULL;
-}
-
 static enum drm_connector_status
 nv50_dac_detect(struct drm_encoder *encoder, struct drm_connector *connector)
 {
@@ -1681,6 +2639,15 @@ nv50_dac_detect(struct drm_encoder *encoder, struct drm_connector *connector)
         return connector_status_connected;
 }
 
+static const struct drm_encoder_helper_funcs
+nv50_dac_help = {
+        .dpms = nv50_dac_dpms,
+        .atomic_check = nv50_outp_atomic_check,
+        .enable = nv50_dac_enable,
+        .disable = nv50_dac_disable,
+        .detect = nv50_dac_detect
+};
+
 static void
 nv50_dac_destroy(struct drm_encoder *encoder)
 {
@@ -1688,18 +2655,8 @@ nv50_dac_destroy(struct drm_encoder *encoder)
         kfree(encoder);
 }
 
-static const struct drm_encoder_helper_funcs nv50_dac_hfunc = {
-        .dpms = nv50_dac_dpms,
-        .mode_fixup = nv50_encoder_mode_fixup,
-        .prepare = nv50_dac_disconnect,
-        .commit = nv50_dac_commit,
-        .mode_set = nv50_dac_mode_set,
-        .disable = nv50_dac_disconnect,
-        .get_crtc = nv50_display_crtc_get,
-        .detect = nv50_dac_detect
-};
-
-static const struct drm_encoder_funcs nv50_dac_func = {
+static const struct drm_encoder_funcs
+nv50_dac_func = {
         .destroy = nv50_dac_destroy,
 };
 
@@ -1726,8 +2683,9 @@ nv50_dac_create(struct drm_connector *connector, struct dcb_output *dcbe)
         encoder = to_drm_encoder(nv_encoder);
         encoder->possible_crtcs = dcbe->heads;
         encoder->possible_clones = 0;
-        drm_encoder_init(connector->dev, encoder, &nv50_dac_func, type, NULL);
-        drm_encoder_helper_add(encoder, &nv50_dac_hfunc);
+        drm_encoder_init(connector->dev, encoder, &nv50_dac_func, type,
+                         "dac-%04x-%04x", dcbe->hasht, dcbe->hashm);
+        drm_encoder_helper_add(encoder, &nv50_dac_help);
 
         drm_mode_connector_attach_encoder(connector, encoder);
         return 0;
@@ -1737,7 +2695,26 @@ nv50_dac_create(struct drm_connector *connector, struct dcb_output *dcbe)
  * Audio
  *****************************************************************************/
 static void
-nv50_audio_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode)
+nv50_audio_disable(struct drm_encoder *encoder, struct nouveau_crtc *nv_crtc)
+{
+        struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
+        struct nv50_disp *disp = nv50_disp(encoder->dev);
+        struct {
+                struct nv50_disp_mthd_v1 base;
+                struct nv50_disp_sor_hda_eld_v0 eld;
+        } args = {
+                .base.version = 1,
+                .base.method  = NV50_DISP_MTHD_V1_SOR_HDA_ELD,
+                .base.hasht   = nv_encoder->dcb->hasht,
+                .base.hashm   = (0xf0ff & nv_encoder->dcb->hashm) |
+                                (0x0100 << nv_crtc->index),
+        };
+
+        nvif_mthd(disp->disp, 0, &args, sizeof(args));
+}
+
+static void
+nv50_audio_enable(struct drm_encoder *encoder, struct drm_display_mode *mode)
 {
         struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
         struct nouveau_crtc *nv_crtc = nouveau_crtc(encoder->crtc);
@@ -1768,30 +2745,30 @@ nv50_audio_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode)
                   sizeof(args.base) + drm_eld_size(args.data));
 }
 
+/******************************************************************************
+ * HDMI
+ *****************************************************************************/
 static void
-nv50_audio_disconnect(struct drm_encoder *encoder, struct nouveau_crtc *nv_crtc)
+nv50_hdmi_disable(struct drm_encoder *encoder, struct nouveau_crtc *nv_crtc)
 {
         struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
         struct nv50_disp *disp = nv50_disp(encoder->dev);
         struct {
                 struct nv50_disp_mthd_v1 base;
-                struct nv50_disp_sor_hda_eld_v0 eld;
+                struct nv50_disp_sor_hdmi_pwr_v0 pwr;
         } args = {
                 .base.version = 1,
-                .base.method  = NV50_DISP_MTHD_V1_SOR_HDA_ELD,
-                .base.hasht   = nv_encoder->dcb->hasht,
-                .base.hashm   = (0xf0ff & nv_encoder->dcb->hashm) |
-                                (0x0100 << nv_crtc->index),
+                .base.method = NV50_DISP_MTHD_V1_SOR_HDMI_PWR,
+                .base.hasht  = nv_encoder->dcb->hasht,
+                .base.hashm  = (0xf0ff & nv_encoder->dcb->hashm) |
+                               (0x0100 << nv_crtc->index),
         };
 
         nvif_mthd(disp->disp, 0, &args, sizeof(args));
 }
 
-/******************************************************************************
- * HDMI
- *****************************************************************************/
 static void
-nv50_hdmi_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode)
+nv50_hdmi_enable(struct drm_encoder *encoder, struct drm_display_mode *mode)
 {
         struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
         struct nouveau_crtc *nv_crtc = nouveau_crtc(encoder->crtc);
@@ -1821,26 +2798,632 @@ nv50_hdmi_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode)
         args.pwr.max_ac_packet = max_ac_packet / 32;
 
         nvif_mthd(disp->disp, 0, &args, sizeof(args));
-        nv50_audio_mode_set(encoder, mode);
+        nv50_audio_enable(encoder, mode);
+}
+
+/******************************************************************************
+ * MST
+ *****************************************************************************/
+#define nv50_mstm(p) container_of((p), struct nv50_mstm, mgr)
+#define nv50_mstc(p) container_of((p), struct nv50_mstc, connector)
+#define nv50_msto(p) container_of((p), struct nv50_msto, encoder)
+
+struct nv50_mstm {
+        struct nouveau_encoder *outp;
+
+        struct drm_dp_mst_topology_mgr mgr;
+        struct nv50_msto *msto[4];
+
+        bool modified;
+};
+
+struct nv50_mstc {
+        struct nv50_mstm *mstm;
+        struct drm_dp_mst_port *port;
+        struct drm_connector connector;
+
+        struct drm_display_mode *native;
+        struct edid *edid;
+
+        int pbn;
+};
+
+struct nv50_msto {
+        struct drm_encoder encoder;
+
+        struct nv50_head *head;
+        struct nv50_mstc *mstc;
+        bool disabled;
+};
+
+static struct drm_dp_payload *
+nv50_msto_payload(struct nv50_msto *msto)
+{
+        struct nouveau_drm *drm = nouveau_drm(msto->encoder.dev);
+        struct nv50_mstc *mstc = msto->mstc;
+        struct nv50_mstm *mstm = mstc->mstm;
+        int vcpi = mstc->port->vcpi.vcpi, i;
+
+        NV_ATOMIC(drm, "%s: vcpi %d\n", msto->encoder.name, vcpi);
+        for (i = 0; i < mstm->mgr.max_payloads; i++) {
+                struct drm_dp_payload *payload = &mstm->mgr.payloads[i];
+                NV_ATOMIC(drm, "%s: %d: vcpi %d start 0x%02x slots 0x%02x\n",
+                          mstm->outp->base.base.name, i, payload->vcpi,
+                          payload->start_slot, payload->num_slots);
+        }
+
+        for (i = 0; i < mstm->mgr.max_payloads; i++) {
+                struct drm_dp_payload *payload = &mstm->mgr.payloads[i];
+                if (payload->vcpi == vcpi)
+                        return payload;
+        }
+
+        return NULL;
 }
 
 static void
-nv50_hdmi_disconnect(struct drm_encoder *encoder, struct nouveau_crtc *nv_crtc)
+nv50_msto_cleanup(struct nv50_msto *msto)
 {
-        struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
-        struct nv50_disp *disp = nv50_disp(encoder->dev);
+        struct nouveau_drm *drm = nouveau_drm(msto->encoder.dev);
+        struct nv50_mstc *mstc = msto->mstc;
+        struct nv50_mstm *mstm = mstc->mstm;
+
+        NV_ATOMIC(drm, "%s: msto cleanup\n", msto->encoder.name);
+        if (mstc->port && mstc->port->vcpi.vcpi > 0 && !nv50_msto_payload(msto))
+                drm_dp_mst_deallocate_vcpi(&mstm->mgr, mstc->port);
+        if (msto->disabled) {
+                msto->mstc = NULL;
+                msto->head = NULL;
+                msto->disabled = false;
+        }
+}
+
+static void
+nv50_msto_prepare(struct nv50_msto *msto)
+{
+        struct nouveau_drm *drm = nouveau_drm(msto->encoder.dev);
+        struct nv50_mstc *mstc = msto->mstc;
+        struct nv50_mstm *mstm = mstc->mstm;
         struct {
                 struct nv50_disp_mthd_v1 base;
-                struct nv50_disp_sor_hdmi_pwr_v0 pwr;
+                struct nv50_disp_sor_dp_mst_vcpi_v0 vcpi;
         } args = {
                 .base.version = 1,
-                .base.method = NV50_DISP_MTHD_V1_SOR_HDMI_PWR,
-                .base.hasht  = nv_encoder->dcb->hasht,
-                .base.hashm  = (0xf0ff & nv_encoder->dcb->hashm) |
-                               (0x0100 << nv_crtc->index),
+                .base.method = NV50_DISP_MTHD_V1_SOR_DP_MST_VCPI,
+                .base.hasht  = mstm->outp->dcb->hasht,
+                .base.hashm  = (0xf0ff & mstm->outp->dcb->hashm) |
+                               (0x0100 << msto->head->base.index),
         };
 
-        nvif_mthd(disp->disp, 0, &args, sizeof(args));
+        NV_ATOMIC(drm, "%s: msto prepare\n", msto->encoder.name);
+        if (mstc->port && mstc->port->vcpi.vcpi > 0) {
+                struct drm_dp_payload *payload = nv50_msto_payload(msto);
+                if (payload) {
+                        args.vcpi.start_slot = payload->start_slot;
+                        args.vcpi.num_slots = payload->num_slots;
+                        args.vcpi.pbn = mstc->port->vcpi.pbn;
+                        args.vcpi.aligned_pbn = mstc->port->vcpi.aligned_pbn;
+                }
+        }
+
+        NV_ATOMIC(drm, "%s: %s: %02x %02x %04x %04x\n",
+                  msto->encoder.name, msto->head->base.base.name,
+                  args.vcpi.start_slot, args.vcpi.num_slots,
+                  args.vcpi.pbn, args.vcpi.aligned_pbn);
+        nvif_mthd(&drm->display->disp, 0, &args, sizeof(args));
+}
+
+static int
+nv50_msto_atomic_check(struct drm_encoder *encoder,
+                       struct drm_crtc_state *crtc_state,
+                       struct drm_connector_state *conn_state)
+{
+        struct nv50_mstc *mstc = nv50_mstc(conn_state->connector);
+        struct nv50_mstm *mstm = mstc->mstm;
+        int bpp = conn_state->connector->display_info.bpc * 3;
+        int slots;
+
+        mstc->pbn = drm_dp_calc_pbn_mode(crtc_state->adjusted_mode.clock, bpp);
+
+        slots = drm_dp_find_vcpi_slots(&mstm->mgr, mstc->pbn);
+        if (slots < 0)
+                return slots;
+
+        return nv50_outp_atomic_check_view(encoder, crtc_state, conn_state,
+                                           mstc->native);
+}
+
+static void
+nv50_msto_enable(struct drm_encoder *encoder)
+{
+        struct nv50_head *head = nv50_head(encoder->crtc);
+        struct nv50_msto *msto = nv50_msto(encoder);
+        struct nv50_mstc *mstc = NULL;
+        struct nv50_mstm *mstm = NULL;
+        struct drm_connector *connector;
+        u8 proto, depth;
+        int slots;
+        bool r;
+
+        drm_for_each_connector(connector, encoder->dev) {
+                if (connector->state->best_encoder == &msto->encoder) {
+                        mstc = nv50_mstc(connector);
+                        mstm = mstc->mstm;
+                        break;
+                }
+        }
+
+        if (WARN_ON(!mstc))
+                return;
+
+        r = drm_dp_mst_allocate_vcpi(&mstm->mgr, mstc->port, mstc->pbn, &slots);
+        WARN_ON(!r);
+
+        if (mstm->outp->dcb->sorconf.link & 1)
+                proto = 0x8;
+        else
+                proto = 0x9;
+
+        switch (mstc->connector.display_info.bpc) {
+        case  6: depth = 0x2; break;
+        case  8: depth = 0x5; break;
+        case 10:
+        default: depth = 0x6; break;
+        }
+
+        mstm->outp->update(mstm->outp, head->base.index,
+                           &head->base.base.state->adjusted_mode, proto, depth);
+
+        msto->head = head;
+        msto->mstc = mstc;
+        mstm->modified = true;
+}
+
+static void
+nv50_msto_disable(struct drm_encoder *encoder)
+{
+        struct nv50_msto *msto = nv50_msto(encoder);
+        struct nv50_mstc *mstc = msto->mstc;
+        struct nv50_mstm *mstm = mstc->mstm;
+
+        if (mstc->port)
+                drm_dp_mst_reset_vcpi_slots(&mstm->mgr, mstc->port);
+
+        mstm->outp->update(mstm->outp, msto->head->base.index, NULL, 0, 0);
+        mstm->modified = true;
+        msto->disabled = true;
+}
+
+static const struct drm_encoder_helper_funcs
+nv50_msto_help = {
+        .disable = nv50_msto_disable,
+        .enable = nv50_msto_enable,
+        .atomic_check = nv50_msto_atomic_check,
+};
+
+static void
+nv50_msto_destroy(struct drm_encoder *encoder)
+{
+        struct nv50_msto *msto = nv50_msto(encoder);
+        drm_encoder_cleanup(&msto->encoder);
+        kfree(msto);
+}
+
+static const struct drm_encoder_funcs
+nv50_msto = {
+        .destroy = nv50_msto_destroy,
+};
+
+static int
+nv50_msto_new(struct drm_device *dev, u32 heads, const char *name, int id,
+              struct nv50_msto **pmsto)
+{
+        struct nv50_msto *msto;
+        int ret;
+
+        if (!(msto = *pmsto = kzalloc(sizeof(*msto), GFP_KERNEL)))
+                return -ENOMEM;
+
+        ret = drm_encoder_init(dev, &msto->encoder, &nv50_msto,
+                               DRM_MODE_ENCODER_DPMST, "%s-mst-%d", name, id);
+        if (ret) {
+                kfree(*pmsto);
+                *pmsto = NULL;
+                return ret;
+        }
+
+        drm_encoder_helper_add(&msto->encoder, &nv50_msto_help);
+        msto->encoder.possible_crtcs = heads;
+        return 0;
+}
+
+static struct drm_encoder *
+nv50_mstc_atomic_best_encoder(struct drm_connector *connector,
+                              struct drm_connector_state *connector_state)
+{
+        struct nv50_head *head = nv50_head(connector_state->crtc);
+        struct nv50_mstc *mstc = nv50_mstc(connector);
+        if (mstc->port) {
+                struct nv50_mstm *mstm = mstc->mstm;
+                return &mstm->msto[head->base.index]->encoder;
+        }
+        return NULL;
+}
+
+static struct drm_encoder *
+nv50_mstc_best_encoder(struct drm_connector *connector)
+{
+        struct nv50_mstc *mstc = nv50_mstc(connector);
+        if (mstc->port) {
+                struct nv50_mstm *mstm = mstc->mstm;
+                return &mstm->msto[0]->encoder;
+        }
+        return NULL;
+}
+
+static enum drm_mode_status
+nv50_mstc_mode_valid(struct drm_connector *connector,
+                     struct drm_display_mode *mode)
+{
+        return MODE_OK;
+}
+
+static int
+nv50_mstc_get_modes(struct drm_connector *connector)
+{
+        struct nv50_mstc *mstc = nv50_mstc(connector);
+        int ret = 0;
+
+        mstc->edid = drm_dp_mst_get_edid(&mstc->connector, mstc->port->mgr, mstc->port);
+        drm_mode_connector_update_edid_property(&mstc->connector, mstc->edid);
+        if (mstc->edid) {
+                ret = drm_add_edid_modes(&mstc->connector, mstc->edid);
+                drm_edid_to_eld(&mstc->connector, mstc->edid);
+        }
+
+        if (!mstc->connector.display_info.bpc)
+                mstc->connector.display_info.bpc = 8;
+
+        if (mstc->native)
+                drm_mode_destroy(mstc->connector.dev, mstc->native);
+        mstc->native = nouveau_conn_native_mode(&mstc->connector);
+        return ret;
+}
+
+static const struct drm_connector_helper_funcs
+nv50_mstc_help = {
+        .get_modes = nv50_mstc_get_modes,
+        .mode_valid = nv50_mstc_mode_valid,
+        .best_encoder = nv50_mstc_best_encoder,
+        .atomic_best_encoder = nv50_mstc_atomic_best_encoder,
+};
+
+static enum drm_connector_status
+nv50_mstc_detect(struct drm_connector *connector, bool force)
+{
+        struct nv50_mstc *mstc = nv50_mstc(connector);
+        if (!mstc->port)
+                return connector_status_disconnected;
+        return drm_dp_mst_detect_port(connector, mstc->port->mgr, mstc->port);
+}
+
+static void
+nv50_mstc_destroy(struct drm_connector *connector)
+{
+        struct nv50_mstc *mstc = nv50_mstc(connector);
+        drm_connector_cleanup(&mstc->connector);
+        kfree(mstc);
+}
+
+static const struct drm_connector_funcs
+nv50_mstc = {
+        .dpms = drm_atomic_helper_connector_dpms,
+        .reset = nouveau_conn_reset,
+        .detect = nv50_mstc_detect,
+        .fill_modes = drm_helper_probe_single_connector_modes,
+        .set_property = drm_atomic_helper_connector_set_property,
+        .destroy = nv50_mstc_destroy,
+        .atomic_duplicate_state = nouveau_conn_atomic_duplicate_state,
+        .atomic_destroy_state = nouveau_conn_atomic_destroy_state,
+        .atomic_set_property = nouveau_conn_atomic_set_property,
+        .atomic_get_property = nouveau_conn_atomic_get_property,
+};
+
+static int
+nv50_mstc_new(struct nv50_mstm *mstm, struct drm_dp_mst_port *port,
+              const char *path, struct nv50_mstc **pmstc)
+{
+        struct drm_device *dev = mstm->outp->base.base.dev;
+        struct nv50_mstc *mstc;
+        int ret, i;
+
+        if (!(mstc = *pmstc = kzalloc(sizeof(*mstc), GFP_KERNEL)))
+                return -ENOMEM;
+        mstc->mstm = mstm;
+        mstc->port = port;
+
+        ret = drm_connector_init(dev, &mstc->connector, &nv50_mstc,
+                                 DRM_MODE_CONNECTOR_DisplayPort);
+        if (ret) {
+                kfree(*pmstc);
+                *pmstc = NULL;
+                return ret;
+        }
+
+        drm_connector_helper_add(&mstc->connector, &nv50_mstc_help);
+
+        mstc->connector.funcs->reset(&mstc->connector);
+        nouveau_conn_attach_properties(&mstc->connector);
+
+        for (i = 0; i < ARRAY_SIZE(mstm->msto) && mstm->msto; i++)
+                drm_mode_connector_attach_encoder(&mstc->connector, &mstm->msto[i]->encoder);
+
+        drm_object_attach_property(&mstc->connector.base, dev->mode_config.path_property, 0);
+        drm_object_attach_property(&mstc->connector.base, dev->mode_config.tile_property, 0);
+        drm_mode_connector_set_path_property(&mstc->connector, path);
+        return 0;
+}
+
+static void
+nv50_mstm_cleanup(struct nv50_mstm *mstm)
+{
+        struct nouveau_drm *drm = nouveau_drm(mstm->outp->base.base.dev);
+        struct drm_encoder *encoder;
+        int ret;
+
+        NV_ATOMIC(drm, "%s: mstm cleanup\n", mstm->outp->base.base.name);
+        ret = drm_dp_check_act_status(&mstm->mgr);
+
+        ret = drm_dp_update_payload_part2(&mstm->mgr);
+
+        drm_for_each_encoder(encoder, mstm->outp->base.base.dev) {
+                if (encoder->encoder_type == DRM_MODE_ENCODER_DPMST) {
+                        struct nv50_msto *msto = nv50_msto(encoder);
+                        struct nv50_mstc *mstc = msto->mstc;
+                        if (mstc && mstc->mstm == mstm)
+                                nv50_msto_cleanup(msto);
+                }
+        }
+
+        mstm->modified = false;
+}
+
+static void
+nv50_mstm_prepare(struct nv50_mstm *mstm)
+{
+        struct nouveau_drm *drm = nouveau_drm(mstm->outp->base.base.dev);
+        struct drm_encoder *encoder;
+        int ret;
+
+        NV_ATOMIC(drm, "%s: mstm prepare\n", mstm->outp->base.base.name);
+        ret = drm_dp_update_payload_part1(&mstm->mgr);
+
+        drm_for_each_encoder(encoder, mstm->outp->base.base.dev) {
+                if (encoder->encoder_type == DRM_MODE_ENCODER_DPMST) {
+                        struct nv50_msto *msto = nv50_msto(encoder);
+                        struct nv50_mstc *mstc = msto->mstc;
+                        if (mstc && mstc->mstm == mstm)
+                                nv50_msto_prepare(msto);
+                }
+        }
+}
+
+static void
+nv50_mstm_hotplug(struct drm_dp_mst_topology_mgr *mgr)
+{
+        struct nv50_mstm *mstm = nv50_mstm(mgr);
+        drm_kms_helper_hotplug_event(mstm->outp->base.base.dev);
+}
+
+static void
+nv50_mstm_destroy_connector(struct drm_dp_mst_topology_mgr *mgr,
+                            struct drm_connector *connector)
+{
+        struct nouveau_drm *drm = nouveau_drm(connector->dev);
+        struct nv50_mstc *mstc = nv50_mstc(connector);
+
+        drm_connector_unregister(&mstc->connector);
+
+        drm_modeset_lock_all(drm->dev);
+        drm_fb_helper_remove_one_connector(&drm->fbcon->helper, &mstc->connector);
+        mstc->port = NULL;
+        drm_modeset_unlock_all(drm->dev);
+
+        drm_connector_unreference(&mstc->connector);
+}
+
+static void
+nv50_mstm_register_connector(struct drm_connector *connector)
+{
+        struct nouveau_drm *drm = nouveau_drm(connector->dev);
+
+        drm_modeset_lock_all(drm->dev);
+        drm_fb_helper_add_one_connector(&drm->fbcon->helper, connector);
+        drm_modeset_unlock_all(drm->dev);
+
+        drm_connector_register(connector);
+}
+
+static struct drm_connector *
+nv50_mstm_add_connector(struct drm_dp_mst_topology_mgr *mgr,
+                        struct drm_dp_mst_port *port, const char *path)
+{
+        struct nv50_mstm *mstm = nv50_mstm(mgr);
+        struct nv50_mstc *mstc;
+        int ret;
+
+        ret = nv50_mstc_new(mstm, port, path, &mstc);
+        if (ret) {
+                if (mstc)
+                        mstc->connector.funcs->destroy(&mstc->connector);
+                return NULL;
+        }
+
+        return &mstc->connector;
+}
+
+static const struct drm_dp_mst_topology_cbs
+nv50_mstm = {
+        .add_connector = nv50_mstm_add_connector,
+        .register_connector = nv50_mstm_register_connector,
+        .destroy_connector = nv50_mstm_destroy_connector,
+        .hotplug = nv50_mstm_hotplug,
+};
+
+void
+nv50_mstm_service(struct nv50_mstm *mstm)
+{
+        struct drm_dp_aux *aux = mstm->mgr.aux;
+        bool handled = true;
+        int ret;
+        u8 esi[8] = {};
+
+        while (handled) {
+                ret = drm_dp_dpcd_read(aux, DP_SINK_COUNT_ESI, esi, 8);
+                if (ret != 8) {
+                        drm_dp_mst_topology_mgr_set_mst(&mstm->mgr, false);
+                        return;
+                }
+
+                drm_dp_mst_hpd_irq(&mstm->mgr, esi, &handled);
+                if (!handled)
+                        break;
+
+                drm_dp_dpcd_write(aux, DP_SINK_COUNT_ESI + 1, &esi[1], 3);
+        }
+}
+
+void
+nv50_mstm_remove(struct nv50_mstm *mstm)
+{
+        if (mstm)
+                drm_dp_mst_topology_mgr_set_mst(&mstm->mgr, false);
+}
+
+static int
+nv50_mstm_enable(struct nv50_mstm *mstm, u8 dpcd, int state)
+{
+        struct nouveau_encoder *outp = mstm->outp;
+        struct {
+                struct nv50_disp_mthd_v1 base;
+                struct nv50_disp_sor_dp_mst_link_v0 mst;
+        } args = {
+                .base.version = 1,
+                .base.method = NV50_DISP_MTHD_V1_SOR_DP_MST_LINK,
+                .base.hasht = outp->dcb->hasht,
+                .base.hashm = outp->dcb->hashm,
+                .mst.state = state,
+        };
+        struct nouveau_drm *drm = nouveau_drm(outp->base.base.dev);
+        struct nvif_object *disp = &drm->display->disp;
+        int ret;
+
+        if (dpcd >= 0x12) {
+                ret = drm_dp_dpcd_readb(mstm->mgr.aux, DP_MSTM_CTRL, &dpcd);
+                if (ret < 0)
+                        return ret;
+
+                dpcd &= ~DP_MST_EN;
+                if (state)
+                        dpcd |= DP_MST_EN;
+
+                ret = drm_dp_dpcd_writeb(mstm->mgr.aux, DP_MSTM_CTRL, dpcd);
+                if (ret < 0)
+                        return ret;
+        }
+
+        return nvif_mthd(disp, 0, &args, sizeof(args));
+}
+
+int
+nv50_mstm_detect(struct nv50_mstm *mstm, u8 dpcd[8], int allow)
+{
+        int ret, state = 0;
+
+        if (!mstm)
+                return 0;
+
+        if (dpcd[0] >= 0x12 && allow) {
+                ret = drm_dp_dpcd_readb(mstm->mgr.aux, DP_MSTM_CAP, &dpcd[1]);
+                if (ret < 0)
+                        return ret;
+
+                state = dpcd[1] & DP_MST_CAP;
+        }
+
+        ret = nv50_mstm_enable(mstm, dpcd[0], state);
+        if (ret)
+                return ret;
+
+        ret = drm_dp_mst_topology_mgr_set_mst(&mstm->mgr, state);
+        if (ret)
+                return nv50_mstm_enable(mstm, dpcd[0], 0);
+
+        return mstm->mgr.mst_state;
+}
+
+static void
+nv50_mstm_fini(struct nv50_mstm *mstm)
+{
+        if (mstm && mstm->mgr.mst_state)
+                drm_dp_mst_topology_mgr_suspend(&mstm->mgr);
+}
+
+static void
+nv50_mstm_init(struct nv50_mstm *mstm)
+{
+        if (mstm && mstm->mgr.mst_state)
+                drm_dp_mst_topology_mgr_resume(&mstm->mgr);
+}
+
+static void
+nv50_mstm_del(struct nv50_mstm **pmstm)
+{
+        struct nv50_mstm *mstm = *pmstm;
+        if (mstm) {
+                kfree(*pmstm);
+                *pmstm = NULL;
+        }
+}
+
+static int
+nv50_mstm_new(struct nouveau_encoder *outp, struct drm_dp_aux *aux, int aux_max,
+              int conn_base_id, struct nv50_mstm **pmstm)
+{
+        const int max_payloads = hweight8(outp->dcb->heads);
+        struct drm_device *dev = outp->base.base.dev;
+        struct nv50_mstm *mstm;
+        int ret, i;
+        u8 dpcd;
+
+        /* This is a workaround for some monitors not functioning
+         * correctly in MST mode on initial module load.  I think
+         * some bad interaction with the VBIOS may be responsible.
+         *
+         * A good ol' off and on again seems to work here ;)
+         */
+        ret = drm_dp_dpcd_readb(aux, DP_DPCD_REV, &dpcd);
+        if (ret >= 0 && dpcd >= 0x12)
+                drm_dp_dpcd_writeb(aux, DP_MSTM_CTRL, 0);
+
+        if (!(mstm = *pmstm = kzalloc(sizeof(*mstm), GFP_KERNEL)))
+                return -ENOMEM;
+        mstm->outp = outp;
+        mstm->mgr.cbs = &nv50_mstm;
+
+        ret = drm_dp_mst_topology_mgr_init(&mstm->mgr, dev->dev, aux, aux_max,
+                                           max_payloads, conn_base_id);
+        if (ret)
+                return ret;
+
+        for (i = 0; i < max_payloads; i++) {
+                ret = nv50_msto_new(dev, outp->dcb->heads, outp->base.base.name,
+                                    i, &mstm->msto[i]);
+                if (ret)
+                        return ret;
+        }
+
+        return 0;
 }
 
 /******************************************************************************
@@ -1861,89 +3444,91 @@ nv50_sor_dpms(struct drm_encoder *encoder, int mode)
                 .base.hashm  = nv_encoder->dcb->hashm,
                 .pwr.state = mode == DRM_MODE_DPMS_ON,
         };
-        struct {
-                struct nv50_disp_mthd_v1 base;
-                struct nv50_disp_sor_dp_pwr_v0 pwr;
-        } link = {
-                .base.version = 1,
-                .base.method = NV50_DISP_MTHD_V1_SOR_DP_PWR,
-                .base.hasht  = nv_encoder->dcb->hasht,
-                .base.hashm  = nv_encoder->dcb->hashm,
-                .pwr.state = mode == DRM_MODE_DPMS_ON,
-        };
-        struct drm_device *dev = encoder->dev;
-        struct drm_encoder *partner;
 
-        nv_encoder->last_dpms = mode;
-
-        list_for_each_entry(partner, &dev->mode_config.encoder_list, head) {
-                struct nouveau_encoder *nv_partner = nouveau_encoder(partner);
-
-                if (partner->encoder_type != DRM_MODE_ENCODER_TMDS)
-                        continue;
+        nvif_mthd(disp->disp, 0, &args, sizeof(args));
+}
 
-                if (nv_partner != nv_encoder &&
-                    nv_partner->dcb->or == nv_encoder->dcb->or) {
-                        if (nv_partner->last_dpms == DRM_MODE_DPMS_ON)
-                                return;
-                        break;
-                }
-        }
+static void
+nv50_sor_update(struct nouveau_encoder *nv_encoder, u8 head,
+                struct drm_display_mode *mode, u8 proto, u8 depth)
+{
+        struct nv50_dmac *core = &nv50_mast(nv_encoder->base.base.dev)->base;
+        u32 *push;
 
-        if (nv_encoder->dcb->type == DCB_OUTPUT_DP) {
-                args.pwr.state = 1;
-                nvif_mthd(disp->disp, 0, &args, sizeof(args));
-                nvif_mthd(disp->disp, 0, &link, sizeof(link));
+        if (!mode) {
+                nv_encoder->ctrl &= ~BIT(head);
+                if (!(nv_encoder->ctrl & 0x0000000f))
+                        nv_encoder->ctrl = 0;
         } else {
-                nvif_mthd(disp->disp, 0, &args, sizeof(args));
+                nv_encoder->ctrl |= proto << 8;
+                nv_encoder->ctrl |= BIT(head);
         }
-}
 
-static void
-nv50_sor_ctrl(struct nouveau_encoder *nv_encoder, u32 mask, u32 data)
-{
-        struct nv50_mast *mast = nv50_mast(nv_encoder->base.base.dev);
-        u32 temp = (nv_encoder->ctrl & ~mask) | (data & mask), *push;
-        if (temp != nv_encoder->ctrl && (push = evo_wait(mast, 2))) {
-                if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
+        if ((push = evo_wait(core, 6))) {
+                if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA) {
+                        if (mode) {
+                                if (mode->flags & DRM_MODE_FLAG_NHSYNC)
+                                        nv_encoder->ctrl |= 0x00001000;
+                                if (mode->flags & DRM_MODE_FLAG_NVSYNC)
+                                        nv_encoder->ctrl |= 0x00002000;
+                                nv_encoder->ctrl |= depth << 16;
+                        }
                         evo_mthd(push, 0x0600 + (nv_encoder->or * 0x40), 1);
-                        evo_data(push, (nv_encoder->ctrl = temp));
                 } else {
+                        if (mode) {
+                                u32 magic = 0x31ec6000 | (head << 25);
+                                u32 syncs = 0x00000001;
+                                if (mode->flags & DRM_MODE_FLAG_NHSYNC)
+                                        syncs |= 0x00000008;
+                                if (mode->flags & DRM_MODE_FLAG_NVSYNC)
+                                        syncs |= 0x00000010;
+                                if (mode->flags & DRM_MODE_FLAG_INTERLACE)
+                                        magic |= 0x00000001;
+
+                                evo_mthd(push, 0x0404 + (head * 0x300), 2);
+                                evo_data(push, syncs | (depth << 6));
+                                evo_data(push, magic);
+                        }
                         evo_mthd(push, 0x0200 + (nv_encoder->or * 0x20), 1);
-                        evo_data(push, (nv_encoder->ctrl = temp));
                 }
-                evo_kick(push, mast);
+                evo_data(push, nv_encoder->ctrl);
+                evo_kick(push, core);
         }
 }
 
 static void
-nv50_sor_disconnect(struct drm_encoder *encoder)
+nv50_sor_disable(struct drm_encoder *encoder)
 {
         struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
         struct nouveau_crtc *nv_crtc = nouveau_crtc(nv_encoder->crtc);
 
-        nv_encoder->last_dpms = DRM_MODE_DPMS_OFF;
         nv_encoder->crtc = NULL;
 
         if (nv_crtc) {
-                nv50_crtc_prepare(&nv_crtc->base);
-                nv50_sor_ctrl(nv_encoder, 1 << nv_crtc->index, 0);
-                nv50_audio_disconnect(encoder, nv_crtc);
-                nv50_hdmi_disconnect(&nv_encoder->base.base, nv_crtc);
-        }
-}
+                struct nvkm_i2c_aux *aux = nv_encoder->aux;
+                u8 pwr;
 
-static void
-nv50_sor_commit(struct drm_encoder *encoder)
-{
+                if (aux) {
+                        int ret = nvkm_rdaux(aux, DP_SET_POWER, &pwr, 1);
+                        if (ret == 0) {
+                                pwr &= ~DP_SET_POWER_MASK;
+                                pwr |=  DP_SET_POWER_D3;
+                                nvkm_wraux(aux, DP_SET_POWER, &pwr, 1);
+                        }
+                }
+
+                nv_encoder->update(nv_encoder, nv_crtc->index, NULL, 0, 0);
+                nv50_audio_disable(encoder, nv_crtc);
+                nv50_hdmi_disable(&nv_encoder->base.base, nv_crtc);
+        }
 }
 
 static void
-nv50_sor_mode_set(struct drm_encoder *encoder, struct drm_display_mode *umode,
-                  struct drm_display_mode *mode)
+nv50_sor_enable(struct drm_encoder *encoder)
 {
         struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
         struct nouveau_crtc *nv_crtc = nouveau_crtc(encoder->crtc);
+        struct drm_display_mode *mode = &nv_crtc->base.state->adjusted_mode;
         struct {
                 struct nv50_disp_mthd_v1 base;
                 struct nv50_disp_sor_lvds_script_v0 lvds;
@@ -1954,13 +3539,10 @@ nv50_sor_mode_set(struct drm_encoder *encoder, struct drm_display_mode *umode,
                 .base.hashm   = nv_encoder->dcb->hashm,
         };
         struct nv50_disp *disp = nv50_disp(encoder->dev);
-        struct nv50_mast *mast = nv50_mast(encoder->dev);
         struct drm_device *dev = encoder->dev;
         struct nouveau_drm *drm = nouveau_drm(dev);
         struct nouveau_connector *nv_connector;
         struct nvbios *bios = &drm->vbios;
-        u32 mask, ctrl;
-        u8 owner = 1 << nv_crtc->index;
         u8 proto = 0xf;
         u8 depth = 0x0;
 
@@ -1985,7 +3567,7 @@ nv50_sor_mode_set(struct drm_encoder *encoder, struct drm_display_mode *umode,
                         proto = 0x2;
                 }
 
-                nv50_hdmi_mode_set(&nv_encoder->base.base, mode);
+                nv50_hdmi_enable(&nv_encoder->base.base, mode);
                 break;
         case DCB_OUTPUT_LVDS:
                 proto = 0x0;
@@ -2019,94 +3601,60 @@ nv50_sor_mode_set(struct drm_encoder *encoder, struct drm_display_mode *umode,
                 nvif_mthd(disp->disp, 0, &lvds, sizeof(lvds));
                 break;
         case DCB_OUTPUT_DP:
-                if (nv_connector->base.display_info.bpc == 6) {
-                        nv_encoder->dp.datarate = mode->clock * 18 / 8;
+                if (nv_connector->base.display_info.bpc == 6)
                         depth = 0x2;
-                } else
-                if (nv_connector->base.display_info.bpc == 8) {
-                        nv_encoder->dp.datarate = mode->clock * 24 / 8;
+                else
+                if (nv_connector->base.display_info.bpc == 8)
                         depth = 0x5;
-                } else {
-                        nv_encoder->dp.datarate = mode->clock * 30 / 8;
+                else
                         depth = 0x6;
-                }
 
                 if (nv_encoder->dcb->sorconf.link & 1)
                         proto = 0x8;
                 else
                         proto = 0x9;
-                nv50_audio_mode_set(encoder, mode);
+
+                nv50_audio_enable(encoder, mode);
                 break;
         default:
                 BUG_ON(1);
                 break;
         }
 
-        nv50_sor_dpms(&nv_encoder->base.base, DRM_MODE_DPMS_ON);
-
-        if (nv50_vers(mast) >= GF110_DISP) {
-                u32 *push = evo_wait(mast, 3);
-                if (push) {
-                        u32 magic = 0x31ec6000 | (nv_crtc->index << 25);
-                        u32 syncs = 0x00000001;
-
-                        if (mode->flags & DRM_MODE_FLAG_NHSYNC)
-                                syncs |= 0x00000008;
-                        if (mode->flags & DRM_MODE_FLAG_NVSYNC)
-                                syncs |= 0x00000010;
-
-                        if (mode->flags & DRM_MODE_FLAG_INTERLACE)
-                                magic |= 0x00000001;
-
-                        evo_mthd(push, 0x0404 + (nv_crtc->index * 0x300), 2);
-                        evo_data(push, syncs | (depth << 6));
-                        evo_data(push, magic);
-                        evo_kick(push, mast);
-                }
-
-                ctrl = proto << 8;
-                mask = 0x00000f00;
-        } else {
-                ctrl = (depth << 16) | (proto << 8);
-                if (mode->flags & DRM_MODE_FLAG_NHSYNC)
-                        ctrl |= 0x00001000;
-                if (mode->flags & DRM_MODE_FLAG_NVSYNC)
-                        ctrl |= 0x00002000;
-                mask = 0x000f3f00;
-        }
-
-        nv50_sor_ctrl(nv_encoder, mask | owner, ctrl | owner);
+        nv_encoder->update(nv_encoder, nv_crtc->index, mode, proto, depth);
 }
 
+static const struct drm_encoder_helper_funcs
+nv50_sor_help = {
+        .dpms = nv50_sor_dpms,
+        .atomic_check = nv50_outp_atomic_check,
+        .enable = nv50_sor_enable,
+        .disable = nv50_sor_disable,
+};
+
 static void
 nv50_sor_destroy(struct drm_encoder *encoder)
 {
+        struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
+        nv50_mstm_del(&nv_encoder->dp.mstm);
         drm_encoder_cleanup(encoder);
         kfree(encoder);
 }
 
-static const struct drm_encoder_helper_funcs nv50_sor_hfunc = {
-        .dpms = nv50_sor_dpms,
-        .mode_fixup = nv50_encoder_mode_fixup,
-        .prepare = nv50_sor_disconnect,
-        .commit = nv50_sor_commit,
-        .mode_set = nv50_sor_mode_set,
-        .disable = nv50_sor_disconnect,
-        .get_crtc = nv50_display_crtc_get,
-};
-
-static const struct drm_encoder_funcs nv50_sor_func = {
+static const struct drm_encoder_funcs
+nv50_sor_func = {
         .destroy = nv50_sor_destroy,
 };
 
 static int
 nv50_sor_create(struct drm_connector *connector, struct dcb_output *dcbe)
 {
+        struct nouveau_connector *nv_connector = nouveau_connector(connector);
         struct nouveau_drm *drm = nouveau_drm(connector->dev);
         struct nvkm_i2c *i2c = nvxx_i2c(&drm->device);
         struct nouveau_encoder *nv_encoder;
         struct drm_encoder *encoder;
-        int type;
+        int type, ret;
 
         switch (dcbe->type) {
         case DCB_OUTPUT_LVDS: type = DRM_MODE_ENCODER_LVDS; break;
@@ -2122,7 +3670,16 @@ nv50_sor_create(struct drm_connector *connector, struct dcb_output *dcbe)
                 return -ENOMEM;
         nv_encoder->dcb = dcbe;
         nv_encoder->or = ffs(dcbe->or) - 1;
-        nv_encoder->last_dpms = DRM_MODE_DPMS_OFF;
+        nv_encoder->update = nv50_sor_update;
+
+        encoder = to_drm_encoder(nv_encoder);
+        encoder->possible_crtcs = dcbe->heads;
+        encoder->possible_clones = 0;
+        drm_encoder_init(connector->dev, encoder, &nv50_sor_func, type,
+                         "sor-%04x-%04x", dcbe->hasht, dcbe->hashm);
+        drm_encoder_helper_add(encoder, &nv50_sor_help);
+
+        drm_mode_connector_attach_encoder(connector, encoder);
 
         if (dcbe->type == DCB_OUTPUT_DP) {
                 struct nvkm_i2c_aux *aux =
@@ -2131,6 +3688,15 @@ nv50_sor_create(struct drm_connector *connector, struct dcb_output *dcbe)
                         nv_encoder->i2c = &aux->i2c;
                         nv_encoder->aux = aux;
                 }
+
+                /*TODO: Use DP Info Table to check for support. */
+                if (nv50_disp(encoder->dev)->disp->oclass >= GF110_DISP) {
+                        ret = nv50_mstm_new(nv_encoder, &nv_connector->aux, 16,
+                                            nv_connector->base.base.id,
+                                            &nv_encoder->dp.mstm);
+                        if (ret)
+                                return ret;
+                }
         } else {
                 struct nvkm_i2c_bus *bus =
                         nvkm_i2c_bus_find(i2c, dcbe->i2c_index);
@@ -2138,20 +3704,12 @@ nv50_sor_create(struct drm_connector *connector, struct dcb_output *dcbe)
                         nv_encoder->i2c = &bus->i2c;
         }
 
-        encoder = to_drm_encoder(nv_encoder);
-        encoder->possible_crtcs = dcbe->heads;
-        encoder->possible_clones = 0;
-        drm_encoder_init(connector->dev, encoder, &nv50_sor_func, type, NULL);
-        drm_encoder_helper_add(encoder, &nv50_sor_hfunc);
-
-        drm_mode_connector_attach_encoder(connector, encoder);
         return 0;
 }
 
 /******************************************************************************
  * PIOR
  *****************************************************************************/
-
 static void
 nv50_pior_dpms(struct drm_encoder *encoder, int mode)
 {
@@ -2172,30 +3730,48 @@ nv50_pior_dpms(struct drm_encoder *encoder, int mode)
         nvif_mthd(disp->disp, 0, &args, sizeof(args));
 }
 
-static bool
-nv50_pior_mode_fixup(struct drm_encoder *encoder,
-                     const struct drm_display_mode *mode,
-                     struct drm_display_mode *adjusted_mode)
+static int
+nv50_pior_atomic_check(struct drm_encoder *encoder,
+                       struct drm_crtc_state *crtc_state,
+                       struct drm_connector_state *conn_state)
 {
-        if (!nv50_encoder_mode_fixup(encoder, mode, adjusted_mode))
-                return false;
-        adjusted_mode->clock *= 2;
-        return true;
+        int ret = nv50_outp_atomic_check(encoder, crtc_state, conn_state);
+        if (ret)
+                return ret;
+        crtc_state->adjusted_mode.clock *= 2;
+        return 0;
 }
 
 static void
-nv50_pior_commit(struct drm_encoder *encoder)
+nv50_pior_disable(struct drm_encoder *encoder)
 {
+        struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
+        struct nv50_mast *mast = nv50_mast(encoder->dev);
+        const int or = nv_encoder->or;
+        u32 *push;
+
+        if (nv_encoder->crtc) {
+                push = evo_wait(mast, 4);
+                if (push) {
+                        if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
+                                evo_mthd(push, 0x0700 + (or * 0x040), 1);
+                                evo_data(push, 0x00000000);
+                        }
+                        evo_kick(push, mast);
+                }
+        }
+
+        nv_encoder->crtc = NULL;
 }
 
 static void
-nv50_pior_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode,
-                   struct drm_display_mode *adjusted_mode)
+nv50_pior_enable(struct drm_encoder *encoder)
 {
         struct nv50_mast *mast = nv50_mast(encoder->dev);
         struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
         struct nouveau_crtc *nv_crtc = nouveau_crtc(encoder->crtc);
         struct nouveau_connector *nv_connector;
+        struct drm_display_mode *mode = &nv_crtc->base.state->adjusted_mode;
         u8 owner = 1 << nv_crtc->index;
         u8 proto, depth;
         u32 *push;
@@ -2218,8 +3794,6 @@ nv50_pior_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode,
                 break;
         }
 
-        nv50_pior_dpms(encoder, DRM_MODE_DPMS_ON);
-
         push = evo_wait(mast, 8);
         if (push) {
                 if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
@@ -2238,29 +3812,13 @@ nv50_pior_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode,
         nv_encoder->crtc = encoder->crtc;
 }
 
-static void
-nv50_pior_disconnect(struct drm_encoder *encoder)
-{
-        struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
-        struct nv50_mast *mast = nv50_mast(encoder->dev);
-        const int or = nv_encoder->or;
-        u32 *push;
-
-        if (nv_encoder->crtc) {
-                nv50_crtc_prepare(nv_encoder->crtc);
-
-                push = evo_wait(mast, 4);
-                if (push) {
-                        if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                                evo_mthd(push, 0x0700 + (or * 0x040), 1);
-                                evo_data(push, 0x00000000);
-                        }
-                        evo_kick(push, mast);
-                }
-        }
-
-        nv_encoder->crtc = NULL;
-}
+static const struct drm_encoder_helper_funcs
+nv50_pior_help = {
+        .dpms = nv50_pior_dpms,
+        .atomic_check = nv50_pior_atomic_check,
+        .enable = nv50_pior_enable,
+        .disable = nv50_pior_disable,
+};
 
 static void
 nv50_pior_destroy(struct drm_encoder *encoder)
@@ -2269,17 +3827,8 @@ nv50_pior_destroy(struct drm_encoder *encoder)
         kfree(encoder);
 }
 
-static const struct drm_encoder_helper_funcs nv50_pior_hfunc = {
-        .dpms = nv50_pior_dpms,
-        .mode_fixup = nv50_pior_mode_fixup,
-        .prepare = nv50_pior_disconnect,
-        .commit = nv50_pior_commit,
-        .mode_set = nv50_pior_mode_set,
-        .disable = nv50_pior_disconnect,
-        .get_crtc = nv50_display_crtc_get,
-};
-
-static const struct drm_encoder_funcs nv50_pior_func = {
+static const struct drm_encoder_funcs
+nv50_pior_func = {
         .destroy = nv50_pior_destroy,
 };
 
@@ -2321,149 +3870,462 @@ nv50_pior_create(struct drm_connector *connector, struct dcb_output *dcbe)
         encoder = to_drm_encoder(nv_encoder);
         encoder->possible_crtcs = dcbe->heads;
         encoder->possible_clones = 0;
-        drm_encoder_init(connector->dev, encoder, &nv50_pior_func, type, NULL);
-        drm_encoder_helper_add(encoder, &nv50_pior_hfunc);
+        drm_encoder_init(connector->dev, encoder, &nv50_pior_func, type,
+                         "pior-%04x-%04x", dcbe->hasht, dcbe->hashm);
+        drm_encoder_helper_add(encoder, &nv50_pior_help);
 
         drm_mode_connector_attach_encoder(connector, encoder);
         return 0;
 }
 
 /******************************************************************************
- * Framebuffer
+ * Atomic
  *****************************************************************************/
 
 static void
-nv50_fbdma_fini(struct nv50_fbdma *fbdma)
+nv50_disp_atomic_commit_core(struct nouveau_drm *drm, u32 interlock)
 {
-        int i;
-        for (i = 0; i < ARRAY_SIZE(fbdma->base); i++)
-                nvif_object_fini(&fbdma->base[i]);
-        nvif_object_fini(&fbdma->core);
-        list_del(&fbdma->head);
-        kfree(fbdma);
+        struct nv50_disp *disp = nv50_disp(drm->dev);
+        struct nv50_dmac *core = &disp->mast.base;
+        struct nv50_mstm *mstm;
+        struct drm_encoder *encoder;
+        u32 *push;
+
+        NV_ATOMIC(drm, "commit core %08x\n", interlock);
+
+        drm_for_each_encoder(encoder, drm->dev) {
+                if (encoder->encoder_type != DRM_MODE_ENCODER_DPMST) {
+                        mstm = nouveau_encoder(encoder)->dp.mstm;
+                        if (mstm && mstm->modified)
+                                nv50_mstm_prepare(mstm);
+                }
+        }
+
+        if ((push = evo_wait(core, 5))) {
+                evo_mthd(push, 0x0084, 1);
+                evo_data(push, 0x80000000);
+                evo_mthd(push, 0x0080, 2);
+                evo_data(push, interlock);
+                evo_data(push, 0x00000000);
+                nouveau_bo_wr32(disp->sync, 0, 0x00000000);
+                evo_kick(push, core);
+                if (nvif_msec(&drm->device, 2000ULL,
+                        if (nouveau_bo_rd32(disp->sync, 0))
+                                break;
+                        usleep_range(1, 2);
+                ) < 0)
+                        NV_ERROR(drm, "EVO timeout\n");
+        }
+
+        drm_for_each_encoder(encoder, drm->dev) {
+                if (encoder->encoder_type != DRM_MODE_ENCODER_DPMST) {
+                        mstm = nouveau_encoder(encoder)->dp.mstm;
+                        if (mstm && mstm->modified)
+                                nv50_mstm_cleanup(mstm);
+                }
+        }
 }
 
-static int
-nv50_fbdma_init(struct drm_device *dev, u32 name, u64 offset, u64 length, u8 kind)
+static void
+nv50_disp_atomic_commit_tail(struct drm_atomic_state *state)
 {
+        struct drm_device *dev = state->dev;
+        struct drm_crtc_state *crtc_state;
+        struct drm_crtc *crtc;
+        struct drm_plane_state *plane_state;
+        struct drm_plane *plane;
         struct nouveau_drm *drm = nouveau_drm(dev);
         struct nv50_disp *disp = nv50_disp(dev);
-        struct nv50_mast *mast = nv50_mast(dev);
-        struct __attribute__ ((packed)) {
-                struct nv_dma_v0 base;
-                union {
-                        struct nv50_dma_v0 nv50;
-                        struct gf100_dma_v0 gf100;
-                        struct gf119_dma_v0 gf119;
-                };
-        } args = {};
-        struct nv50_fbdma *fbdma;
-        struct drm_crtc *crtc;
-        u32 size = sizeof(args.base);
-        int ret;
+        struct nv50_atom *atom = nv50_atom(state);
+        struct nv50_outp_atom *outp, *outt;
+        u32 interlock_core = 0;
+        u32 interlock_chan = 0;
+        int i;
+
+        NV_ATOMIC(drm, "commit %d %d\n", atom->lock_core, atom->flush_disable);
+        drm_atomic_helper_wait_for_fences(dev, state, false);
+        drm_atomic_helper_wait_for_dependencies(state);
+        drm_atomic_helper_update_legacy_modeset_state(dev, state);
 
-        list_for_each_entry(fbdma, &disp->fbdma, head) {
-                if (fbdma->core.handle == name)
-                        return 0;
+        if (atom->lock_core)
+                mutex_lock(&disp->mutex);
+
+        /* Disable head(s). */
+        for_each_crtc_in_state(state, crtc, crtc_state, i) {
+                struct nv50_head_atom *asyh = nv50_head_atom(crtc->state);
+                struct nv50_head *head = nv50_head(crtc);
+
+                NV_ATOMIC(drm, "%s: clr %04x (set %04x)\n", crtc->name,
+                          asyh->clr.mask, asyh->set.mask);
+
+                if (asyh->clr.mask) {
+                        nv50_head_flush_clr(head, asyh, atom->flush_disable);
+                        interlock_core |= 1;
+                }
         }
 
-        fbdma = kzalloc(sizeof(*fbdma), GFP_KERNEL);
-        if (!fbdma)
-                return -ENOMEM;
-        list_add(&fbdma->head, &disp->fbdma);
+        /* Disable plane(s). */
+        for_each_plane_in_state(state, plane, plane_state, i) {
+                struct nv50_wndw_atom *asyw = nv50_wndw_atom(plane->state);
+                struct nv50_wndw *wndw = nv50_wndw(plane);
 
-        args.base.target = NV_DMA_V0_TARGET_VRAM;
-        args.base.access = NV_DMA_V0_ACCESS_RDWR;
-        args.base.start = offset;
-        args.base.limit = offset + length - 1;
+                NV_ATOMIC(drm, "%s: clr %02x (set %02x)\n", plane->name,
+                          asyw->clr.mask, asyw->set.mask);
+                if (!asyw->clr.mask)
+                        continue;
 
-        if (drm->device.info.chipset < 0x80) {
-                args.nv50.part = NV50_DMA_V0_PART_256;
-                size += sizeof(args.nv50);
-        } else
-        if (drm->device.info.chipset < 0xc0) {
-                args.nv50.part = NV50_DMA_V0_PART_256;
-                args.nv50.kind = kind;
-                size += sizeof(args.nv50);
-        } else
-        if (drm->device.info.chipset < 0xd0) {
-                args.gf100.kind = kind;
-                size += sizeof(args.gf100);
-        } else {
-                args.gf119.page = GF119_DMA_V0_PAGE_LP;
-                args.gf119.kind = kind;
-                size += sizeof(args.gf119);
+                interlock_chan |= nv50_wndw_flush_clr(wndw, interlock_core,
+                                                      atom->flush_disable,
+                                                      asyw);
+        }
+
+        /* Disable output path(s). */
+        list_for_each_entry(outp, &atom->outp, head) {
+                const struct drm_encoder_helper_funcs *help;
+                struct drm_encoder *encoder;
+
+                encoder = outp->encoder;
+                help = encoder->helper_private;
+
+                NV_ATOMIC(drm, "%s: clr %02x (set %02x)\n", encoder->name,
+                          outp->clr.mask, outp->set.mask);
+
+                if (outp->clr.mask) {
+                        help->disable(encoder);
+                        interlock_core |= 1;
+                        if (outp->flush_disable) {
+                                nv50_disp_atomic_commit_core(drm, interlock_chan);
+                                interlock_core = 0;
+                                interlock_chan = 0;
+                        }
+                }
+        }
+
+        /* Flush disable. */
+        if (interlock_core) {
+                if (atom->flush_disable) {
+                        nv50_disp_atomic_commit_core(drm, interlock_chan);
+                        interlock_core = 0;
+                        interlock_chan = 0;
+                }
         }
 
-        list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
+        /* Update output path(s). */
+        list_for_each_entry_safe(outp, outt, &atom->outp, head) {
+                const struct drm_encoder_helper_funcs *help;
+                struct drm_encoder *encoder;
+
+                encoder = outp->encoder;
+                help = encoder->helper_private;
+
+                NV_ATOMIC(drm, "%s: set %02x (clr %02x)\n", encoder->name,
+                          outp->set.mask, outp->clr.mask);
+
+                if (outp->set.mask) {
+                        help->enable(encoder);
+                        interlock_core = 1;
+                }
+
+                list_del(&outp->head);
+                kfree(outp);
+        }
+
+        /* Update head(s). */
+        for_each_crtc_in_state(state, crtc, crtc_state, i) {
+                struct nv50_head_atom *asyh = nv50_head_atom(crtc->state);
                 struct nv50_head *head = nv50_head(crtc);
-                int ret = nvif_object_init(&head->sync.base.base.user, name,
-                                           NV_DMA_IN_MEMORY, &args, size,
-                                           &fbdma->base[head->base.index]);
-                if (ret) {
-                        nv50_fbdma_fini(fbdma);
-                        return ret;
+
+                NV_ATOMIC(drm, "%s: set %04x (clr %04x)\n", crtc->name,
+                          asyh->set.mask, asyh->clr.mask);
+
+                if (asyh->set.mask) {
+                        nv50_head_flush_set(head, asyh);
+                        interlock_core = 1;
                 }
         }
 
-        ret = nvif_object_init(&mast->base.base.user, name, NV_DMA_IN_MEMORY,
-                               &args, size, &fbdma->core);
-        if (ret) {
-                nv50_fbdma_fini(fbdma);
+        /* Update plane(s). */
+        for_each_plane_in_state(state, plane, plane_state, i) {
+                struct nv50_wndw_atom *asyw = nv50_wndw_atom(plane->state);
+                struct nv50_wndw *wndw = nv50_wndw(plane);
+
+                NV_ATOMIC(drm, "%s: set %02x (clr %02x)\n", plane->name,
+                          asyw->set.mask, asyw->clr.mask);
+                if ( !asyw->set.mask &&
+                    (!asyw->clr.mask || atom->flush_disable))
+                        continue;
+
+                interlock_chan |= nv50_wndw_flush_set(wndw, interlock_core, asyw);
+        }
+
+        /* Flush update. */
+        if (interlock_core) {
+                if (!interlock_chan && atom->state.legacy_cursor_update) {
+                        u32 *push = evo_wait(&disp->mast, 2);
+                        if (push) {
+                                evo_mthd(push, 0x0080, 1);
+                                evo_data(push, 0x00000000);
+                                evo_kick(push, &disp->mast);
+                        }
+                } else {
+                        nv50_disp_atomic_commit_core(drm, interlock_chan);
+                }
+        }
+
+        if (atom->lock_core)
+                mutex_unlock(&disp->mutex);
+
+        /* Wait for HW to signal completion. */
+        for_each_plane_in_state(state, plane, plane_state, i) {
+                struct nv50_wndw_atom *asyw = nv50_wndw_atom(plane->state);
+                struct nv50_wndw *wndw = nv50_wndw(plane);
+                int ret = nv50_wndw_wait_armed(wndw, asyw);
+                if (ret)
+                        NV_ERROR(drm, "%s: timeout\n", plane->name);
+        }
+
+        for_each_crtc_in_state(state, crtc, crtc_state, i) {
+                if (crtc->state->event) {
+                        unsigned long flags;
+                        spin_lock_irqsave(&crtc->dev->event_lock, flags);
+                        drm_crtc_send_vblank_event(crtc, crtc->state->event);
+                        spin_unlock_irqrestore(&crtc->dev->event_lock, flags);
+                        crtc->state->event = NULL;
+                }
+        }
+
+        drm_atomic_helper_commit_hw_done(state);
+        drm_atomic_helper_cleanup_planes(dev, state);
+        drm_atomic_helper_commit_cleanup_done(state);
+        drm_atomic_state_put(state);
+}
+
+static void
+nv50_disp_atomic_commit_work(struct work_struct *work)
+{
+        struct drm_atomic_state *state =
+                container_of(work, typeof(*state), commit_work);
+        nv50_disp_atomic_commit_tail(state);
+}
+
+static int
+nv50_disp_atomic_commit(struct drm_device *dev,
+                        struct drm_atomic_state *state, bool nonblock)
+{
+        struct nouveau_drm *drm = nouveau_drm(dev);
+        struct nv50_disp *disp = nv50_disp(dev);
+        struct drm_plane_state *plane_state;
+        struct drm_plane *plane;
+        struct drm_crtc *crtc;
+        bool active = false;
+        int ret, i;
+
+        ret = pm_runtime_get_sync(dev->dev);
+        if (ret < 0 && ret != -EACCES)
                 return ret;
+
+        ret = drm_atomic_helper_setup_commit(state, nonblock);
+        if (ret)
+                goto done;
+
+        INIT_WORK(&state->commit_work, nv50_disp_atomic_commit_work);
+
+        ret = drm_atomic_helper_prepare_planes(dev, state);
+        if (ret)
+                goto done;
+
+        if (!nonblock) {
+                ret = drm_atomic_helper_wait_for_fences(dev, state, true);
+                if (ret)
+                        goto done;
+        }
+
+        for_each_plane_in_state(state, plane, plane_state, i) {
+                struct nv50_wndw_atom *asyw = nv50_wndw_atom(plane_state);
+                struct nv50_wndw *wndw = nv50_wndw(plane);
+                if (asyw->set.image) {
+                        asyw->ntfy.handle = wndw->dmac->sync.handle;
+                        asyw->ntfy.offset = wndw->ntfy;
+                        asyw->ntfy.awaken = false;
+                        asyw->set.ntfy = true;
+                        nouveau_bo_wr32(disp->sync, wndw->ntfy / 4, 0x00000000);
+                        wndw->ntfy ^= 0x10;
+                }
+        }
+
+        drm_atomic_helper_swap_state(state, true);
+        drm_atomic_state_get(state);
+
+        if (nonblock)
+                queue_work(system_unbound_wq, &state->commit_work);
+        else
+                nv50_disp_atomic_commit_tail(state);
+
+        drm_for_each_crtc(crtc, dev) {
+                if (crtc->state->enable) {
+                        if (!drm->have_disp_power_ref) {
+                                drm->have_disp_power_ref = true;
+                                return ret;
+                        }
+                        active = true;
+                        break;
+                }
+        }
+
+        if (!active && drm->have_disp_power_ref) {
+                pm_runtime_put_autosuspend(dev->dev);
+                drm->have_disp_power_ref = false;
+        }
+
+done:
+        pm_runtime_put_autosuspend(dev->dev);
+        return ret;
+}
+
+static struct nv50_outp_atom *
+nv50_disp_outp_atomic_add(struct nv50_atom *atom, struct drm_encoder *encoder)
+{
+        struct nv50_outp_atom *outp;
+
+        list_for_each_entry(outp, &atom->outp, head) {
+                if (outp->encoder == encoder)
+                        return outp;
+        }
+
+        outp = kzalloc(sizeof(*outp), GFP_KERNEL);
+        if (!outp)
+                return ERR_PTR(-ENOMEM);
+
+        list_add(&outp->head, &atom->outp);
+        outp->encoder = encoder;
+        return outp;
+}
+
+static int
+nv50_disp_outp_atomic_check_clr(struct nv50_atom *atom,
+                                struct drm_connector *connector)
+{
+        struct drm_encoder *encoder = connector->state->best_encoder;
+        struct drm_crtc_state *crtc_state;
+        struct drm_crtc *crtc;
+        struct nv50_outp_atom *outp;
+
+        if (!(crtc = connector->state->crtc))
+                return 0;
+
+        crtc_state = drm_atomic_get_existing_crtc_state(&atom->state, crtc);
+        if (crtc->state->active && drm_atomic_crtc_needs_modeset(crtc_state)) {
+                outp = nv50_disp_outp_atomic_add(atom, encoder);
+                if (IS_ERR(outp))
+                        return PTR_ERR(outp);
+
+                if (outp->encoder->encoder_type == DRM_MODE_ENCODER_DPMST) {
+                        outp->flush_disable = true;
+                        atom->flush_disable = true;
+                }
+                outp->clr.ctrl = true;
+                atom->lock_core = true;
         }
 
         return 0;
 }
 
-static void
-nv50_fb_dtor(struct drm_framebuffer *fb)
+static int
+nv50_disp_outp_atomic_check_set(struct nv50_atom *atom,
+                                struct drm_connector_state *connector_state)
 {
+        struct drm_encoder *encoder = connector_state->best_encoder;
+        struct drm_crtc_state *crtc_state;
+        struct drm_crtc *crtc;
+        struct nv50_outp_atom *outp;
+
+        if (!(crtc = connector_state->crtc))
+                return 0;
+
+        crtc_state = drm_atomic_get_existing_crtc_state(&atom->state, crtc);
+        if (crtc_state->active && drm_atomic_crtc_needs_modeset(crtc_state)) {
+                outp = nv50_disp_outp_atomic_add(atom, encoder);
+                if (IS_ERR(outp))
+                        return PTR_ERR(outp);
+
+                outp->set.ctrl = true;
+                atom->lock_core = true;
+        }
+
+        return 0;
 }
 
 static int
-nv50_fb_ctor(struct drm_framebuffer *fb)
-{
-        struct nouveau_framebuffer *nv_fb = nouveau_framebuffer(fb);
-        struct nouveau_drm *drm = nouveau_drm(fb->dev);
-        struct nouveau_bo *nvbo = nv_fb->nvbo;
-        struct nv50_disp *disp = nv50_disp(fb->dev);
-        u8 kind = nouveau_bo_tile_layout(nvbo) >> 8;
-        u8 tile = nvbo->tile_mode;
-
-        if (drm->device.info.chipset >= 0xc0)
-                tile >>= 4; /* yep.. */
-
-        switch (fb->depth) {
-        case  8: nv_fb->r_format = 0x1e00; break;
-        case 15: nv_fb->r_format = 0xe900; break;
-        case 16: nv_fb->r_format = 0xe800; break;
-        case 24:
-        case 32: nv_fb->r_format = 0xcf00; break;
-        case 30: nv_fb->r_format = 0xd100; break;
-        default:
-                 NV_ERROR(drm, "unknown depth %d\n", fb->depth);
-                 return -EINVAL;
+nv50_disp_atomic_check(struct drm_device *dev, struct drm_atomic_state *state)
+{
+        struct nv50_atom *atom = nv50_atom(state);
+        struct drm_connector_state *connector_state;
+        struct drm_connector *connector;
+        int ret, i;
+
+        ret = drm_atomic_helper_check(dev, state);
+        if (ret)
+                return ret;
+
+        for_each_connector_in_state(state, connector, connector_state, i) {
+                ret = nv50_disp_outp_atomic_check_clr(atom, connector);
+                if (ret)
+                        return ret;
+
+                ret = nv50_disp_outp_atomic_check_set(atom, connector_state);
+                if (ret)
+                        return ret;
         }
 
-        if (disp->disp->oclass < G82_DISP) {
-                nv_fb->r_pitch   = kind ? (((fb->pitches[0] / 4) << 4) | tile) :
-                                            (fb->pitches[0] | 0x00100000);
-                nv_fb->r_format |= kind << 16;
-        } else
-        if (disp->disp->oclass < GF110_DISP) {
-                nv_fb->r_pitch  = kind ? (((fb->pitches[0] / 4) << 4) | tile) :
-                                           (fb->pitches[0] | 0x00100000);
-        } else {
-                nv_fb->r_pitch  = kind ? (((fb->pitches[0] / 4) << 4) | tile) :
-                                           (fb->pitches[0] | 0x01000000);
+        return 0;
+}
+
+static void
+nv50_disp_atomic_state_clear(struct drm_atomic_state *state)
+{
+        struct nv50_atom *atom = nv50_atom(state);
+        struct nv50_outp_atom *outp, *outt;
+
+        list_for_each_entry_safe(outp, outt, &atom->outp, head) {
+                list_del(&outp->head);
+                kfree(outp);
         }
-        nv_fb->r_handle = 0xffff0000 | kind;
 
-        return nv50_fbdma_init(fb->dev, nv_fb->r_handle, 0,
-                               drm->device.info.ram_user, kind);
+        drm_atomic_state_default_clear(state);
+}
+
+static void
+nv50_disp_atomic_state_free(struct drm_atomic_state *state)
+{
+        struct nv50_atom *atom = nv50_atom(state);
+        drm_atomic_state_default_release(&atom->state);
+        kfree(atom);
 }
 
+static struct drm_atomic_state *
+nv50_disp_atomic_state_alloc(struct drm_device *dev)
+{
+        struct nv50_atom *atom;
+        if (!(atom = kzalloc(sizeof(*atom), GFP_KERNEL)) ||
+            drm_atomic_state_init(dev, &atom->state) < 0) {
+                kfree(atom);
+                return NULL;
+        }
+        INIT_LIST_HEAD(&atom->outp);
+        return &atom->state;
+}
+
+static const struct drm_mode_config_funcs
+nv50_disp_func = {
+        .fb_create = nouveau_user_framebuffer_create,
+        .output_poll_changed = nouveau_fbcon_output_poll_changed,
+        .atomic_check = nv50_disp_atomic_check,
+        .atomic_commit = nv50_disp_atomic_commit,
+        .atomic_state_alloc = nv50_disp_atomic_state_alloc,
+        .atomic_state_clear = nv50_disp_atomic_state_clear,
+        .atomic_state_free = nv50_disp_atomic_state_free,
+};
+
 /******************************************************************************
  * Init
  *****************************************************************************/
@@ -2471,12 +4333,30 @@ nv50_fb_ctor(struct drm_framebuffer *fb)
 void
 nv50_display_fini(struct drm_device *dev)
 {
+        struct nouveau_encoder *nv_encoder;
+        struct drm_encoder *encoder;
+        struct drm_plane *plane;
+
+        drm_for_each_plane(plane, dev) {
+                struct nv50_wndw *wndw = nv50_wndw(plane);
+                if (plane->funcs != &nv50_wndw)
+                        continue;
+                nv50_wndw_fini(wndw);
+        }
+
+        list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
+                if (encoder->encoder_type != DRM_MODE_ENCODER_DPMST) {
+                        nv_encoder = nouveau_encoder(encoder);
+                        nv50_mstm_fini(nv_encoder->dp.mstm);
+                }
+        }
 }
 
 int
 nv50_display_init(struct drm_device *dev)
 {
-        struct nv50_disp *disp = nv50_disp(dev);
+        struct drm_encoder *encoder;
+        struct drm_plane *plane;
         struct drm_crtc *crtc;
         u32 *push;
 
@@ -2484,16 +4364,35 @@ nv50_display_init(struct drm_device *dev)
         if (!push)
                 return -EBUSY;
 
-        list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
-                struct nv50_sync *sync = nv50_sync(crtc);
-
-                nv50_crtc_lut_load(crtc);
-                nouveau_bo_wr32(disp->sync, sync->addr / 4, sync->data);
-        }
-
         evo_mthd(push, 0x0088, 1);
         evo_data(push, nv50_mast(dev)->base.sync.handle);
         evo_kick(push, nv50_mast(dev));
+
+        list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
+                if (encoder->encoder_type != DRM_MODE_ENCODER_DPMST) {
+                        const struct drm_encoder_helper_funcs *help;
+                        struct nouveau_encoder *nv_encoder;
+
+                        nv_encoder = nouveau_encoder(encoder);
+                        help = encoder->helper_private;
+                        if (help && help->dpms)
+                                help->dpms(encoder, DRM_MODE_DPMS_ON);
+
+                        nv50_mstm_init(nv_encoder->dp.mstm);
+                }
+        }
+
+        drm_for_each_crtc(crtc, dev) {
+                nv50_head_lut_load(crtc);
+        }
+
+        drm_for_each_plane(plane, dev) {
+                struct nv50_wndw *wndw = nv50_wndw(plane);
+                if (plane->funcs != &nv50_wndw)
+                        continue;
+                nv50_wndw_init(wndw);
+        }
+
         return 0;
 }
 
@@ -2501,11 +4400,6 @@ void
 nv50_display_destroy(struct drm_device *dev)
 {
         struct nv50_disp *disp = nv50_disp(dev);
-        struct nv50_fbdma *fbdma, *fbtmp;
-
-        list_for_each_entry_safe(fbdma, fbtmp, &disp->fbdma, head) {
-                nv50_fbdma_fini(fbdma);
-        }
 
         nv50_dmac_destroy(&disp->mast.base, disp->disp);
 
@@ -2518,6 +4412,10 @@ nv50_display_destroy(struct drm_device *dev)
         kfree(disp);
 }
 
+MODULE_PARM_DESC(atomic, "Expose atomic ioctl (default: disabled)");
+static int nouveau_atomic = 0;
+module_param_named(atomic, nouveau_atomic, int, 0400);
+
 int
 nv50_display_create(struct drm_device *dev)
 {
@@ -2532,15 +4430,17 @@ nv50_display_create(struct drm_device *dev)
         disp = kzalloc(sizeof(*disp), GFP_KERNEL);
         if (!disp)
                 return -ENOMEM;
-        INIT_LIST_HEAD(&disp->fbdma);
+
+        mutex_init(&disp->mutex);
 
         nouveau_display(dev)->priv = disp;
         nouveau_display(dev)->dtor = nv50_display_destroy;
         nouveau_display(dev)->init = nv50_display_init;
         nouveau_display(dev)->fini = nv50_display_fini;
-        nouveau_display(dev)->fb_ctor = nv50_fb_ctor;
-        nouveau_display(dev)->fb_dtor = nv50_fb_dtor;
         disp->disp = &nouveau_display(dev)->disp;
+        dev->mode_config.funcs = &nv50_disp_func;
+        if (nouveau_atomic)
+                dev->driver->driver_features |= DRIVER_ATOMIC;
 
         /* small shared memory area we use for notifiers and semaphores */
         ret = nouveau_bo_new(dev, 4096, 0x1000, TTM_PL_FLAG_VRAM,
@@ -2572,7 +4472,7 @@ nv50_display_create(struct drm_device *dev)
                 crtcs = 2;
 
         for (i = 0; i < crtcs; i++) {
-                ret = nv50_crtc_create(dev, i);
+                ret = nv50_head_create(dev, i);
                 if (ret)
                         goto out;
         }
diff --git a/drivers/gpu/drm/nouveau/nv50_display.h b/drivers/gpu/drm/nouveau/nv50_display.h
index 70da347aa8c5..918187cee84b 100644
--- a/drivers/gpu/drm/nouveau/nv50_display.h
+++ b/drivers/gpu/drm/nouveau/nv50_display.h
@@ -35,11 +35,4 @@ int  nv50_display_create(struct drm_device *);
 void nv50_display_destroy(struct drm_device *);
 int  nv50_display_init(struct drm_device *);
 void nv50_display_fini(struct drm_device *);
-
-void nv50_display_flip_stop(struct drm_crtc *);
-int  nv50_display_flip_next(struct drm_crtc *, struct drm_framebuffer *,
-                            struct nouveau_channel *, u32 swap_interval);
-
-struct nouveau_bo *nv50_display_crtc_sema(struct drm_device *, int head);
-
 #endif /* __NV50_DISPLAY_H__ */
diff --git a/drivers/gpu/drm/nouveau/nv50_fbcon.c b/drivers/gpu/drm/nouveau/nv50_fbcon.c
index af3d3c49411a..327dcd7901ed 100644
--- a/drivers/gpu/drm/nouveau/nv50_fbcon.c
+++ b/drivers/gpu/drm/nouveau/nv50_fbcon.c
@@ -30,7 +30,7 @@ int
 nv50_fbcon_fillrect(struct fb_info *info, const struct fb_fillrect *rect)
 {
         struct nouveau_fbdev *nfbdev = info->par;
-        struct nouveau_drm *drm = nouveau_drm(nfbdev->dev);
+        struct nouveau_drm *drm = nouveau_drm(nfbdev->helper.dev);
         struct nouveau_channel *chan = drm->channel;
         int ret;
 
@@ -65,7 +65,7 @@ int
 nv50_fbcon_copyarea(struct fb_info *info, const struct fb_copyarea *region)
 {
         struct nouveau_fbdev *nfbdev = info->par;
-        struct nouveau_drm *drm = nouveau_drm(nfbdev->dev);
+        struct nouveau_drm *drm = nouveau_drm(nfbdev->helper.dev);
         struct nouveau_channel *chan = drm->channel;
         int ret;
 
@@ -93,7 +93,7 @@ int
 nv50_fbcon_imageblit(struct fb_info *info, const struct fb_image *image)
 {
         struct nouveau_fbdev *nfbdev = info->par;
-        struct nouveau_drm *drm = nouveau_drm(nfbdev->dev);
+        struct nouveau_drm *drm = nouveau_drm(nfbdev->helper.dev);
         struct nouveau_channel *chan = drm->channel;
         uint32_t dwords, *data = (uint32_t *)image->data;
         uint32_t mask = ~(~0 >> (32 - info->var.bits_per_pixel));
@@ -148,8 +148,8 @@ int
 nv50_fbcon_accel_init(struct fb_info *info)
 {
         struct nouveau_fbdev *nfbdev = info->par;
-        struct nouveau_framebuffer *fb = &nfbdev->nouveau_fb;
-        struct drm_device *dev = nfbdev->dev;
+        struct nouveau_framebuffer *fb = nouveau_framebuffer(nfbdev->helper.fb);
+        struct drm_device *dev = nfbdev->helper.dev;
         struct nouveau_drm *drm = nouveau_drm(dev);
         struct nouveau_channel *chan = drm->channel;
         int ret, format;
diff --git a/drivers/gpu/drm/nouveau/nv50_fence.c b/drivers/gpu/drm/nouveau/nv50_fence.c
index 8c5295414578..f68c7054fd53 100644
--- a/drivers/gpu/drm/nouveau/nv50_fence.c
+++ b/drivers/gpu/drm/nouveau/nv50_fence.c
@@ -35,13 +35,12 @@
 static int
 nv50_fence_context_new(struct nouveau_channel *chan)
 {
-        struct drm_device *dev = chan->drm->dev;
         struct nv10_fence_priv *priv = chan->drm->fence;
         struct nv10_fence_chan *fctx;
         struct ttm_mem_reg *mem = &priv->bo->bo.mem;
         u32 start = mem->start * PAGE_SIZE;
         u32 limit = start + mem->size - 1;
-        int ret, i;
+        int ret;
 
         fctx = chan->fence = kzalloc(sizeof(*fctx), GFP_KERNEL);
         if (!fctx)
@@ -60,23 +59,6 @@ nv50_fence_context_new(struct nouveau_channel *chan)
                                         .limit = limit,
                                }, sizeof(struct nv_dma_v0),
                                &fctx->sema);
-
-        /* dma objects for display sync channel semaphore blocks */
-        for (i = 0; !ret && i < dev->mode_config.num_crtc; i++) {
-                struct nouveau_bo *bo = nv50_display_crtc_sema(dev, i);
-                u32 start = bo->bo.mem.start * PAGE_SIZE;
-                u32 limit = start + bo->bo.mem.size - 1;
-
-                ret = nvif_object_init(&chan->user, NvEvoSema0 + i,
-                                       NV_DMA_IN_MEMORY, &(struct nv_dma_v0) {
-                                                .target = NV_DMA_V0_TARGET_VRAM,
-                                                .access = NV_DMA_V0_ACCESS_RDWR,
-                                                .start = start,
-                                                .limit = limit,
-                                       }, sizeof(struct nv_dma_v0),
-                                       &fctx->head[i]);
-        }
-
         if (ret)
                 nv10_fence_context_del(chan);
         return ret;
diff --git a/drivers/gpu/drm/nouveau/nv84_fence.c b/drivers/gpu/drm/nouveau/nv84_fence.c
index 23ef04b4e0b2..52b87ae83e7b 100644
--- a/drivers/gpu/drm/nouveau/nv84_fence.c
+++ b/drivers/gpu/drm/nouveau/nv84_fence.c
@@ -28,13 +28,6 @@
 
 #include "nv50_display.h"
 
-u64
-nv84_fence_crtc(struct nouveau_channel *chan, int crtc)
-{
-        struct nv84_fence_chan *fctx = chan->fence;
-        return fctx->dispc_vma[crtc].offset;
-}
-
 static int
 nv84_fence_emit32(struct nouveau_channel *chan, u64 virtual, u32 sequence)
 {
@@ -110,15 +103,8 @@ nv84_fence_read(struct nouveau_channel *chan)
 static void
 nv84_fence_context_del(struct nouveau_channel *chan)
 {
-        struct drm_device *dev = chan->drm->dev;
         struct nv84_fence_priv *priv = chan->drm->fence;
         struct nv84_fence_chan *fctx = chan->fence;
-        int i;
-
-        for (i = 0; i < dev->mode_config.num_crtc; i++) {
-                struct nouveau_bo *bo = nv50_display_crtc_sema(dev, i);
-                nouveau_bo_vma_del(bo, &fctx->dispc_vma[i]);
-        }
 
         nouveau_bo_wr32(priv->bo, chan->chid * 16 / 4, fctx->base.sequence);
         nouveau_bo_vma_del(priv->bo, &fctx->vma_gart);
@@ -134,7 +120,7 @@ nv84_fence_context_new(struct nouveau_channel *chan)
         struct nouveau_cli *cli = (void *)chan->user.client;
         struct nv84_fence_priv *priv = chan->drm->fence;
         struct nv84_fence_chan *fctx;
-        int ret, i;
+        int ret;
 
         fctx = chan->fence = kzalloc(sizeof(*fctx), GFP_KERNEL);
         if (!fctx)
@@ -154,12 +140,6 @@ nv84_fence_context_new(struct nouveau_channel *chan)
                                         &fctx->vma_gart);
         }
 
-        /* map display semaphore buffers into channel's vm */
-        for (i = 0; !ret && i < chan->drm->dev->mode_config.num_crtc; i++) {
-                struct nouveau_bo *bo = nv50_display_crtc_sema(chan->drm->dev, i);
-                ret = nouveau_bo_vma_add(bo, cli->vm, &fctx->dispc_vma[i]);
-        }
-
         if (ret)
                 nv84_fence_context_del(chan);
         return ret;
diff --git a/drivers/gpu/drm/nouveau/nvc0_fbcon.c b/drivers/gpu/drm/nouveau/nvc0_fbcon.c
index 054b6a056d99..90f27bfa381f 100644
--- a/drivers/gpu/drm/nouveau/nvc0_fbcon.c
+++ b/drivers/gpu/drm/nouveau/nvc0_fbcon.c
@@ -30,7 +30,7 @@ int
 nvc0_fbcon_fillrect(struct fb_info *info, const struct fb_fillrect *rect)
 {
         struct nouveau_fbdev *nfbdev = info->par;
-        struct nouveau_drm *drm = nouveau_drm(nfbdev->dev);
+        struct nouveau_drm *drm = nouveau_drm(nfbdev->helper.dev);
         struct nouveau_channel *chan = drm->channel;
         int ret;
 
@@ -65,7 +65,7 @@ int
 nvc0_fbcon_copyarea(struct fb_info *info, const struct fb_copyarea *region)
 {
         struct nouveau_fbdev *nfbdev = info->par;
-        struct nouveau_drm *drm = nouveau_drm(nfbdev->dev);
+        struct nouveau_drm *drm = nouveau_drm(nfbdev->helper.dev);
         struct nouveau_channel *chan = drm->channel;
         int ret;
 
@@ -93,7 +93,7 @@ int
 nvc0_fbcon_imageblit(struct fb_info *info, const struct fb_image *image)
 {
         struct nouveau_fbdev *nfbdev = info->par;
-        struct nouveau_drm *drm = nouveau_drm(nfbdev->dev);
+        struct nouveau_drm *drm = nouveau_drm(nfbdev->helper.dev);
         struct nouveau_channel *chan = drm->channel;
         uint32_t dwords, *data = (uint32_t *)image->data;
         uint32_t mask = ~(~0 >> (32 - info->var.bits_per_pixel));
@@ -148,8 +148,8 @@ int
 nvc0_fbcon_accel_init(struct fb_info *info)
 {
         struct nouveau_fbdev *nfbdev = info->par;
-        struct drm_device *dev = nfbdev->dev;
-        struct nouveau_framebuffer *fb = &nfbdev->nouveau_fb;
+        struct drm_device *dev = nfbdev->helper.dev;
+        struct nouveau_framebuffer *fb = nouveau_framebuffer(nfbdev->helper.fb);
         struct nouveau_drm *drm = nouveau_drm(dev);
         struct nouveau_channel *chan = drm->channel;
         int ret, format;
diff --git a/drivers/gpu/drm/nouveau/nvif/client.c b/drivers/gpu/drm/nouveau/nvif/client.c
index 1ee9294eca2e..29c20dfd894d 100644
--- a/drivers/gpu/drm/nouveau/nvif/client.c
+++ b/drivers/gpu/drm/nouveau/nvif/client.c
@@ -55,7 +55,7 @@ nvif_client_fini(struct nvif_client *client)
         }
 }
 
-const struct nvif_driver *
+static const struct nvif_driver *
 nvif_drivers[] = {
 #ifdef __KERNEL__
         &nvif_driver_nvkm,
diff --git a/drivers/gpu/drm/nouveau/nvif/notify.c b/drivers/gpu/drm/nouveau/nvif/notify.c
index b0787ff833ef..278b3933dc96 100644
--- a/drivers/gpu/drm/nouveau/nvif/notify.c
+++ b/drivers/gpu/drm/nouveau/nvif/notify.c
@@ -155,10 +155,8 @@ nvif_notify_fini(struct nvif_notify *notify)
         int ret = nvif_notify_put(notify);
         if (ret >= 0 && object) {
                 ret = nvif_object_ioctl(object, &args, sizeof(args), NULL);
-                if (ret == 0) {
-                        notify->object = NULL;
-                        kfree((void *)notify->data);
-                }
+                notify->object = NULL;
+                kfree((void *)notify->data);
         }
         return ret;
 }
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/ce/fuc/gf100.fuc3.h b/drivers/gpu/drm/nouveau/nvkm/engine/ce/fuc/gf100.fuc3.h
index 05bb65608dfe..d9ca9636a3e3 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/ce/fuc/gf100.fuc3.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/ce/fuc/gf100.fuc3.h
@@ -1,4 +1,4 @@
-uint32_t gf100_ce_data[] = {
+static uint32_t gf100_ce_data[] = {
 /* 0x0000: ctx_object */
         0x00000000,
 /* 0x0004: ctx_query_address_high */
@@ -171,7 +171,7 @@ uint32_t gf100_ce_data[] = {
         0x00000800,
 };
 
-uint32_t gf100_ce_code[] = {
+static uint32_t gf100_ce_code[] = {
 /* 0x0000: main */
         0x04fe04bd,
         0x3517f000,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/ce/fuc/gt215.fuc3.h b/drivers/gpu/drm/nouveau/nvkm/engine/ce/fuc/gt215.fuc3.h
index 972281d10f38..f0a1cf31c7ca 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/ce/fuc/gt215.fuc3.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/ce/fuc/gt215.fuc3.h
@@ -1,4 +1,4 @@
-uint32_t gt215_ce_data[] = {
+static uint32_t gt215_ce_data[] = {
 /* 0x0000: ctx_object */
         0x00000000,
 /* 0x0004: ctx_dma */
@@ -183,7 +183,7 @@ uint32_t gt215_ce_data[] = {
         0x00000800,
 };
 
-uint32_t gt215_ce_code[] = {
+static uint32_t gt215_ce_code[] = {
 /* 0x0000: main */
         0x04fe04bd,
         0x3517f000,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c b/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c
index 53d171729353..bd22526edb0b 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c
@@ -1852,7 +1852,7 @@ nvf1_chipset = {
         .fb = gk104_fb_new,
         .fuse = gf100_fuse_new,
         .gpio = gk104_gpio_new,
-        .i2c = gf119_i2c_new,
+        .i2c = gk104_i2c_new,
         .ibus = gk104_ibus_new,
         .iccsense = gf100_iccsense_new,
         .imem = nv50_instmem_new,
@@ -1966,7 +1966,7 @@ nv117_chipset = {
         .fb = gm107_fb_new,
         .fuse = gm107_fuse_new,
         .gpio = gk104_gpio_new,
-        .i2c = gf119_i2c_new,
+        .i2c = gk104_i2c_new,
         .ibus = gk104_ibus_new,
         .iccsense = gf100_iccsense_new,
         .imem = nv50_instmem_new,
@@ -2000,7 +2000,7 @@ nv118_chipset = {
         .fb = gm107_fb_new,
         .fuse = gm107_fuse_new,
         .gpio = gk104_gpio_new,
-        .i2c = gf119_i2c_new,
+        .i2c = gk104_i2c_new,
         .ibus = gk104_ibus_new,
         .iccsense = gf100_iccsense_new,
         .imem = nv50_instmem_new,
@@ -2131,7 +2131,7 @@ nv12b_chipset = {
         .bar = gk20a_bar_new,
         .bus = gf100_bus_new,
         .clk = gm20b_clk_new,
-        .fb = gk20a_fb_new,
+        .fb = gm20b_fb_new,
         .fuse = gm107_fuse_new,
         .ibus = gk20a_ibus_new,
         .imem = gk20a_instmem_new,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
index 9b638bd905ff..f2bc0b7d9b93 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
@@ -102,7 +102,7 @@ nvkm_device_tegra_probe_iommu(struct nvkm_device_tegra *tdev)
 
         if (iommu_present(&platform_bus_type)) {
                 tdev->iommu.domain = iommu_domain_alloc(&platform_bus_type);
-                if (IS_ERR(tdev->iommu.domain))
+                if (!tdev->iommu.domain)
                         goto error;
 
                 /*
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/user.c b/drivers/gpu/drm/nouveau/nvkm/engine/device/user.c
index 79a8f71cf788..513ee6b79553 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/device/user.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/user.c
@@ -326,7 +326,7 @@ nvkm_udevice = {
         .sclass = nvkm_udevice_child_get,
 };
 
-int
+static int
 nvkm_udevice_new(const struct nvkm_oclass *oclass, void *data, u32 size,
                  struct nvkm_object **pobject)
 {
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c
index dd2953bc9264..26990d44ae75 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c
@@ -153,7 +153,7 @@ nv50_disp_chan_uevent = {
         .fini = nv50_disp_chan_uevent_fini,
 };
 
-int
+static int
 nv50_disp_chan_rd32(struct nvkm_object *object, u64 addr, u32 *data)
 {
         struct nv50_disp_chan *chan = nv50_disp_chan(object);
@@ -163,7 +163,7 @@ nv50_disp_chan_rd32(struct nvkm_object *object, u64 addr, u32 *data)
         return 0;
 }
 
-int
+static int
 nv50_disp_chan_wr32(struct nvkm_object *object, u64 addr, u32 data)
 {
         struct nv50_disp_chan *chan = nv50_disp_chan(object);
@@ -173,7 +173,7 @@ nv50_disp_chan_wr32(struct nvkm_object *object, u64 addr, u32 data)
         return 0;
 }
 
-int
+static int
 nv50_disp_chan_ntfy(struct nvkm_object *object, u32 type,
                     struct nvkm_event **pevent)
 {
@@ -189,7 +189,7 @@ nv50_disp_chan_ntfy(struct nvkm_object *object, u32 type,
         return -EINVAL;
 }
 
-int
+static int
 nv50_disp_chan_map(struct nvkm_object *object, u64 *addr, u32 *size)
 {
         struct nv50_disp_chan *chan = nv50_disp_chan(object);
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/coreg94.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/coreg94.c
index 019379a3a01c..c65c9f3ff69f 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/coreg94.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/coreg94.c
@@ -26,7 +26,7 @@
 
 #include <nvif/class.h>
 
-const struct nv50_disp_mthd_list
+static const struct nv50_disp_mthd_list
 g94_disp_core_mthd_sor = {
         .mthd = 0x0040,
         .addr = 0x000008,
@@ -43,8 +43,8 @@ g94_disp_core_chan_mthd = {
         .prev = 0x000004,
         .data = {
                 { "Global", 1, &nv50_disp_core_mthd_base },
-                {    "DAC", 3, &g84_disp_core_mthd_dac  },
-                {    "SOR", 4, &g94_disp_core_mthd_sor  },
+                {    "DAC", 3, &g84_disp_core_mthd_dac },
+                {    "SOR", 4, &g94_disp_core_mthd_sor },
                 {   "PIOR", 3, &nv50_disp_core_mthd_pior },
                 {   "HEAD", 2, &g84_disp_core_mthd_head },
                 {}
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregp104.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregp104.c
index 6922f4007b61..e356f87fbe60 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregp104.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregp104.c
@@ -59,7 +59,7 @@ gp104_disp_core_init(struct nv50_disp_dmac *chan)
         return 0;
 }
 
-const struct nv50_disp_dmac_func
+static const struct nv50_disp_dmac_func
 gp104_disp_core_func = {
         .init = gp104_disp_core_init,
         .fini = gf119_disp_core_fini,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/dport.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/dport.c
index 9688970eca47..4a93ceb850ac 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/dport.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/dport.c
@@ -319,9 +319,8 @@ static const struct dp_rates {
 };
 
 void
-nvkm_dp_train(struct work_struct *w)
+nvkm_dp_train(struct nvkm_output_dp *outp)
 {
-        struct nvkm_output_dp *outp = container_of(w, typeof(*outp), lt.work);
         struct nv50_disp *disp = nv50_disp(outp->base.disp);
         const struct dp_rates *cfg = nvkm_dp_rates;
         struct dp_state _dp = {
@@ -353,9 +352,6 @@ nvkm_dp_train(struct work_struct *w)
         }
         cfg--;
 
-        /* disable link interrupt handling during link training */
-        nvkm_notify_put(&outp->irq);
-
         /* ensure sink is not in a low-power state */
         if (!nvkm_rdaux(outp->aux, DPCD_SC00, &pwr, 1)) {
                 if ((pwr & DPCD_SC00_SET_POWER) != DPCD_SC00_SET_POWER_D0) {
@@ -400,9 +396,6 @@ nvkm_dp_train(struct work_struct *w)
 
         dp_link_train_fini(dp);
 
-        /* signal completion and enable link interrupt handling */
         OUTP_DBG(&outp->base, "training complete");
         atomic_set(&outp->lt.done, 1);
-        wake_up(&outp->lt.wait);
-        nvkm_notify_get(&outp->irq);
 }
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/dport.h b/drivers/gpu/drm/nouveau/nvkm/engine/disp/dport.h
index 6e10c5e0ef11..baf1dd9ff975 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/dport.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/dport.h
@@ -1,6 +1,6 @@
 #ifndef __NVKM_DISP_DPORT_H__
 #define __NVKM_DISP_DPORT_H__
-#include <core/os.h>
+struct nvkm_output_dp;
 
 /* DPCD Receiver Capabilities */
 #define DPCD_RC00_DPCD_REV                                              0x00000
@@ -77,5 +77,5 @@
 #define DPCD_SC00_SET_POWER_D0                                             0x01
 #define DPCD_SC00_SET_POWER_D3                                             0x03
 
-void nvkm_dp_train(struct work_struct *);
+void nvkm_dp_train(struct nvkm_output_dp *);
 #endif
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/gf119.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/gf119.c
index 29e84b241cca..7b346ccc38b7 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/gf119.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/gf119.c
@@ -203,17 +203,20 @@ gf119_disp_intr_unk2_0(struct nv50_disp *disp, int head)
         /* see note in nv50_disp_intr_unk20_0() */
         if (outp && outp->info.type == DCB_OUTPUT_DP) {
                 struct nvkm_output_dp *outpdp = nvkm_output_dp(outp);
-                struct nvbios_init init = {
-                        .subdev = subdev,
-                        .bios = subdev->device->bios,
-                        .outp = &outp->info,
-                        .crtc = head,
-                        .offset = outpdp->info.script[4],
-                        .execute = 1,
-                };
+                if (!outpdp->lt.mst) {
+                        struct nvbios_init init = {
+                                .subdev = subdev,
+                                .bios = subdev->device->bios,
+                                .outp = &outp->info,
+                                .crtc = head,
+                                .offset = outpdp->info.script[4],
+                                .execute = 1,
+                        };
 
-                nvbios_exec(&init);
-                atomic_set(&outpdp->lt.done, 0);
+                        nvkm_notify_put(&outpdp->irq);
+                        nvbios_exec(&init);
+                        atomic_set(&outpdp->lt.done, 0);
+                }
         }
 }
 
@@ -314,7 +317,7 @@ gf119_disp_intr_unk2_2(struct nv50_disp *disp, int head)
                         break;
                 }
 
-                if (nvkm_output_dp_train(outp, pclk, true))
+                if (nvkm_output_dp_train(outp, pclk))
                         OUTP_ERR(outp, "link not trained before attach");
         } else {
                 if (disp->func->sor.magic)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/nv50.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/nv50.c
index fbb8c7dc18fd..567466f93cd5 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/nv50.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/nv50.c
@@ -590,6 +590,7 @@ nv50_disp_intr_unk20_0(struct nv50_disp *disp, int head)
                         .execute = 1,
                 };
 
+                nvkm_notify_put(&outpdp->irq);
                 nvbios_exec(&init);
                 atomic_set(&outpdp->lt.done, 0);
         }
@@ -779,7 +780,7 @@ nv50_disp_intr_unk20_2(struct nv50_disp *disp, int head)
                         break;
                 }
 
-                if (nvkm_output_dp_train(outp, datarate / soff, true))
+                if (nvkm_output_dp_train(outp, datarate / soff))
                         OUTP_ERR(outp, "link not trained before attach");
         }
 
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/outpdp.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/outpdp.c
index 3b7a9e7a1ea8..de36f73b14dc 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/outpdp.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/outpdp.c
@@ -31,7 +31,7 @@
 #include <nvif/event.h>
 
 int
-nvkm_output_dp_train(struct nvkm_output *base, u32 datarate, bool wait)
+nvkm_output_dp_train(struct nvkm_output *base, u32 datarate)
 {
         struct nvkm_output_dp *outp = nvkm_output_dp(base);
         bool retrain = true;
@@ -39,6 +39,8 @@ nvkm_output_dp_train(struct nvkm_output *base, u32 datarate, bool wait)
         u32 linkrate;
         int ret, i;
 
+        mutex_lock(&outp->mutex);
+
         /* check that the link is trained at a high enough rate */
         ret = nvkm_rdaux(outp->aux, DPCD_LC00_LINK_BW_SET, link, 2);
         if (ret) {
@@ -88,19 +90,10 @@ done:
                         outp->dpcd[DPCD_RC02] =
                                 outp->base.info.dpconf.link_nr;
                 }
-                atomic_set(&outp->lt.done, 0);
-                schedule_work(&outp->lt.work);
-        } else {
-                nvkm_notify_get(&outp->irq);
-        }
-
-        if (wait) {
-                if (!wait_event_timeout(outp->lt.wait,
-                                        atomic_read(&outp->lt.done),
-                                        msecs_to_jiffies(2000)))
-                        ret = -ETIMEDOUT;
+                nvkm_dp_train(outp);
         }
 
+        mutex_unlock(&outp->mutex);
         return ret;
 }
 
@@ -118,7 +111,7 @@ nvkm_output_dp_enable(struct nvkm_output_dp *outp, bool enable)
 
                 if (!nvkm_rdaux(aux, DPCD_RC00_DPCD_REV, outp->dpcd,
                                 sizeof(outp->dpcd))) {
-                        nvkm_output_dp_train(&outp->base, 0, true);
+                        nvkm_output_dp_train(&outp->base, 0);
                         return;
                 }
         }
@@ -165,10 +158,10 @@ nvkm_output_dp_irq(struct nvkm_notify *notify)
         };
 
         OUTP_DBG(&outp->base, "IRQ: %d", line->mask);
-        nvkm_output_dp_train(&outp->base, 0, true);
+        nvkm_output_dp_train(&outp->base, 0);
 
         nvkm_event_send(&disp->hpd, rep.mask, conn->index, &rep, sizeof(rep));
-        return NVKM_NOTIFY_DROP;
+        return NVKM_NOTIFY_KEEP;
 }
 
 static void
@@ -177,7 +170,6 @@ nvkm_output_dp_fini(struct nvkm_output *base)
         struct nvkm_output_dp *outp = nvkm_output_dp(base);
         nvkm_notify_put(&outp->hpd);
         nvkm_notify_put(&outp->irq);
-        flush_work(&outp->lt.work);
         nvkm_output_dp_enable(outp, false);
 }
 
@@ -187,6 +179,7 @@ nvkm_output_dp_init(struct nvkm_output *base)
         struct nvkm_output_dp *outp = nvkm_output_dp(base);
         nvkm_notify_put(&outp->base.conn->hpd);
         nvkm_output_dp_enable(outp, true);
+        nvkm_notify_get(&outp->irq);
         nvkm_notify_get(&outp->hpd);
 }
 
@@ -238,11 +231,6 @@ nvkm_output_dp_ctor(const struct nvkm_output_dp_func *func,
         OUTP_DBG(&outp->base, "bios dp %02x %02x %02x %02x",
                  outp->version, hdr, cnt, len);
 
-        /* link training */
-        INIT_WORK(&outp->lt.work, nvkm_dp_train);
-        init_waitqueue_head(&outp->lt.wait);
-        atomic_set(&outp->lt.done, 0);
-
         /* link maintenance */
         ret = nvkm_notify_init(NULL, &i2c->event, nvkm_output_dp_irq, true,
                                &(struct nvkm_i2c_ntfy_req) {
@@ -257,6 +245,9 @@ nvkm_output_dp_ctor(const struct nvkm_output_dp_func *func,
                 return ret;
         }
 
+        mutex_init(&outp->mutex);
+        atomic_set(&outp->lt.done, 0);
+
         /* hotplug detect, replaces gpio-based mechanism with aux events */
         ret = nvkm_notify_init(NULL, &i2c->event, nvkm_output_dp_hpd, true,
                                &(struct nvkm_i2c_ntfy_req) {
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/outpdp.h b/drivers/gpu/drm/nouveau/nvkm/engine/disp/outpdp.h
index 4e983f6d7032..3c83a561cd88 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/outpdp.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/outpdp.h
@@ -29,10 +29,10 @@ struct nvkm_output_dp {
         bool present;
         u8 dpcd[16];
 
+        struct mutex mutex;
         struct {
-                struct work_struct work;
-                wait_queue_head_t wait;
                 atomic_t done;
+                bool mst;
         } lt;
 };
 
@@ -41,9 +41,11 @@ struct nvkm_output_dp_func {
         int (*lnk_pwr)(struct nvkm_output_dp *, int nr);
         int (*lnk_ctl)(struct nvkm_output_dp *, int nr, int bw, bool ef);
         int (*drv_ctl)(struct nvkm_output_dp *, int ln, int vs, int pe, int pc);
+        void (*vcpi)(struct nvkm_output_dp *, int head, u8 start_slot,
+                     u8 num_slots, u16 pbn, u16 aligned_pbn);
 };
 
-int nvkm_output_dp_train(struct nvkm_output *, u32 rate, bool wait);
+int nvkm_output_dp_train(struct nvkm_output *, u32 rate);
 
 int nvkm_output_dp_ctor(const struct nvkm_output_dp_func *, struct nvkm_disp *,
                         int index, struct dcb_output *, struct nvkm_i2c_aux *,
@@ -63,6 +65,7 @@ int gf119_sor_dp_new(struct nvkm_disp *, int, struct dcb_output *,
                      struct nvkm_output **);
 int gf119_sor_dp_lnk_ctl(struct nvkm_output_dp *, int, int, bool);
 int gf119_sor_dp_drv_ctl(struct nvkm_output_dp *, int, int, int, int);
+void gf119_sor_dp_vcpi(struct nvkm_output_dp *, int, u8, u8, u16, u16);
 
 int gm107_sor_dp_new(struct nvkm_disp *, int, struct dcb_output *,
                      struct nvkm_output **);
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv50.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv50.c
index 2f9cecd81d04..c1158b22a721 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv50.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv50.c
@@ -66,7 +66,7 @@ nv50_disp_root_scanoutpos(NV50_DISP_MTHD_V0)
         return 0;
 }
 
-int
+static int
 nv50_disp_root_mthd_(struct nvkm_object *object, u32 mthd, void *data, u32 size)
 {
         union {
@@ -173,13 +173,56 @@ nv50_disp_root_mthd_(struct nvkm_object *object, u32 mthd, void *data, u32 size)
                                 return 0;
                         } else
                         if (args->v0.state != 0) {
-                                nvkm_output_dp_train(&outpdp->base, 0, true);
+                                nvkm_output_dp_train(&outpdp->base, 0);
                                 return 0;
                         }
                 } else
                         return ret;
         }
                 break;
+        case NV50_DISP_MTHD_V1_SOR_DP_MST_LINK: {
+                struct nvkm_output_dp *outpdp = nvkm_output_dp(outp);
+                union {
+                        struct nv50_disp_sor_dp_mst_link_v0 v0;
+                } *args = data;
+                int ret = -ENOSYS;
+                nvif_ioctl(object, "disp sor dp mst link size %d\n", size);
+                if (!(ret = nvif_unpack(ret, &data, &size, args->v0, 0, 0, false))) {
+                        nvif_ioctl(object, "disp sor dp mst link vers %d state %d\n",
+                                   args->v0.version, args->v0.state);
+                        if (outpdp->lt.mst != !!args->v0.state) {
+                                outpdp->lt.mst = !!args->v0.state;
+                                atomic_set(&outpdp->lt.done, 0);
+                                nvkm_output_dp_train(&outpdp->base, 0);
+                        }
+                        return 0;
+                } else
+                        return ret;
+        }
+                break;
+        case NV50_DISP_MTHD_V1_SOR_DP_MST_VCPI: {
+                struct nvkm_output_dp *outpdp = nvkm_output_dp(outp);
+                union {
+                        struct nv50_disp_sor_dp_mst_vcpi_v0 v0;
+                } *args = data;
+                int ret = -ENOSYS;
+                nvif_ioctl(object, "disp sor dp mst vcpi size %d\n", size);
+                if (!(ret = nvif_unpack(ret, &data, &size, args->v0, 0, 0, false))) {
+                        nvif_ioctl(object, "disp sor dp mst vcpi vers %d "
+                                           "slot %02x/%02x pbn %04x/%04x\n",
+                                   args->v0.version, args->v0.start_slot,
+                                   args->v0.num_slots, args->v0.pbn,
+                                   args->v0.aligned_pbn);
+                        if (!outpdp->func->vcpi)
+                                return -ENODEV;
+                        outpdp->func->vcpi(outpdp, head, args->v0.start_slot,
+                                           args->v0.num_slots, args->v0.pbn,
+                                           args->v0.aligned_pbn);
+                        return 0;
+                } else
+                        return ret;
+        }
+                break;
         case NV50_DISP_MTHD_V1_PIOR_PWR:
                 if (!func->pior.power)
                         return -ENODEV;
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgf119.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgf119.c
index 49bd5da194e1..6ffdaa65aa77 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgf119.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgf119.c
@@ -56,11 +56,13 @@ gf119_sor_dp_lnk_ctl(struct nvkm_output_dp *outp, int nr, int bw, bool ef)
 
         clksor |= bw << 18;
         dpctrl |= ((1 << nr) - 1) << 16;
+        if (outp->lt.mst)
+                dpctrl |= 0x40000000;
         if (ef)
                 dpctrl |= 0x00004000;
 
         nvkm_mask(device, 0x612300 + soff, 0x007c0000, clksor);
-        nvkm_mask(device, 0x61c10c + loff, 0x001f4000, dpctrl);
+        nvkm_mask(device, 0x61c10c + loff, 0x401f4000, dpctrl);
         return 0;
 }
 
@@ -101,12 +103,24 @@ gf119_sor_dp_drv_ctl(struct nvkm_output_dp *outp,
         return 0;
 }
 
+void
+gf119_sor_dp_vcpi(struct nvkm_output_dp *outp, int head, u8 slot,
+                  u8 slot_nr, u16 pbn, u16 aligned)
+{
+        struct nvkm_device *device = outp->base.disp->engine.subdev.device;
+        const u32 hoff = head * 0x800;
+
+        nvkm_mask(device, 0x616588 + hoff, 0x00003f3f, (slot_nr << 8) | slot);
+        nvkm_mask(device, 0x61658c + hoff, 0xffffffff, (aligned << 16) | pbn);
+}
+
 static const struct nvkm_output_dp_func
 gf119_sor_dp_func = {
         .pattern = gf119_sor_dp_pattern,
         .lnk_pwr = g94_sor_dp_lnk_pwr,
         .lnk_ctl = gf119_sor_dp_lnk_ctl,
         .drv_ctl = gf119_sor_dp_drv_ctl,
+        .vcpi = gf119_sor_dp_vcpi,
 };
 
 int
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgm107.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgm107.c
index 37790b2617c5..4cf8ad4d18ab 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgm107.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgm107.c
@@ -43,6 +43,7 @@ gm107_sor_dp_func = {
         .lnk_pwr = g94_sor_dp_lnk_pwr,
         .lnk_ctl = gf119_sor_dp_lnk_ctl,
         .drv_ctl = gf119_sor_dp_drv_ctl,
+        .vcpi = gf119_sor_dp_vcpi,
 };
 
 int
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgm200.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgm200.c
index c44fa7ea672a..81b788fa61be 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgm200.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgm200.c
@@ -120,6 +120,7 @@ gm200_sor_dp_func = {
         .lnk_pwr = gm200_sor_dp_lnk_pwr,
         .lnk_ctl = gf119_sor_dp_lnk_ctl,
         .drv_ctl = gm200_sor_dp_drv_ctl,
+        .vcpi = gf119_sor_dp_vcpi,
 };
 
 int
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c
index aeb3387a3fb0..15a992b3580a 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c
@@ -129,7 +129,7 @@ g84_fifo_chan_engine_fini(struct nvkm_fifo_chan *base,
 }
 
 
-int
+static int
 g84_fifo_chan_engine_init(struct nvkm_fifo_chan *base,
                           struct nvkm_engine *engine)
 {
@@ -170,7 +170,7 @@ g84_fifo_chan_engine_ctor(struct nvkm_fifo_chan *base,
         return nvkm_object_bind(object, NULL, 0, &chan->engn[engn]);
 }
 
-int
+static int
 g84_fifo_chan_object_ctor(struct nvkm_fifo_chan *base,
                           struct nvkm_object *object)
 {
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gpfifogf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gpfifogf100.c
index cbc67f262322..12d964260a29 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gpfifogf100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gpfifogf100.c
@@ -60,6 +60,7 @@ gf100_fifo_gpfifo_engine_fini(struct nvkm_fifo_chan *base,
         struct nvkm_gpuobj *inst = chan->base.inst;
         int ret = 0;
 
+        mutex_lock(&subdev->mutex);
         nvkm_wr32(device, 0x002634, chan->base.chid);
         if (nvkm_msec(device, 2000,
                 if (nvkm_rd32(device, 0x002634) == chan->base.chid)
@@ -67,10 +68,12 @@ gf100_fifo_gpfifo_engine_fini(struct nvkm_fifo_chan *base,
         ) < 0) {
                 nvkm_error(subdev, "channel %d [%s] kick timeout\n",
                            chan->base.chid, chan->base.object.client->name);
-                ret = -EBUSY;
-                if (suspend)
-                        return ret;
+                ret = -ETIMEDOUT;
         }
+        mutex_unlock(&subdev->mutex);
+
+        if (ret && suspend)
+                return ret;
 
         if (offset) {
                 nvkm_kmap(inst);
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gpfifogk104.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gpfifogk104.c
index ed4351032ed6..a2df4f3e7763 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gpfifogk104.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gpfifogk104.c
@@ -40,7 +40,9 @@ gk104_fifo_gpfifo_kick(struct gk104_fifo_chan *chan)
         struct nvkm_subdev *subdev = &fifo->base.engine.subdev;
         struct nvkm_device *device = subdev->device;
         struct nvkm_client *client = chan->base.object.client;
+        int ret = 0;
 
+        mutex_lock(&subdev->mutex);
         nvkm_wr32(device, 0x002634, chan->base.chid);
         if (nvkm_msec(device, 2000,
                 if (!(nvkm_rd32(device, 0x002634) & 0x00100000))
@@ -48,10 +50,10 @@ gk104_fifo_gpfifo_kick(struct gk104_fifo_chan *chan)
         ) < 0) {
                 nvkm_error(subdev, "channel %d [%s] kick timeout\n",
                            chan->base.chid, client->name);
-                return -EBUSY;
+                ret = -ETIMEDOUT;
         }
-
-        return 0;
+        mutex_unlock(&subdev->mutex);
+        return ret;
 }
 
 static u32
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c
index c925ade5880e..74a64e3fd59a 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c
@@ -218,7 +218,7 @@ gf117_grctx_generate_attrib(struct gf100_grctx *info)
         }
 }
 
-void
+static void
 gf117_grctx_generate_main(struct gf100_gr *gr, struct gf100_grctx *info)
 {
         struct nvkm_device *device = gr->base.engine.subdev.device;
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
index 6d3c5011e18c..4c4b5ab6e46d 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
@@ -933,7 +933,7 @@ gm107_grctx_generate_attrib(struct gf100_grctx *info)
         }
 }
 
-void
+static void
 gm107_grctx_generate_tpcid(struct gf100_gr *gr)
 {
         struct nvkm_device *device = gr->base.engine.subdev.device;
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c
index 1e13278cf306..c8bb9191f9a2 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c
@@ -106,6 +106,7 @@
 #define CP_SEEK_2      0x00c800ff
 
 #include "ctxnv40.h"
+#include "nv50.h"
 
 #include <subdev/fb.h>
 
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgf100.fuc3.h b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgf100.fuc3.h
index 8cb240b65ec2..12a703fe355d 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgf100.fuc3.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgf100.fuc3.h
@@ -1,4 +1,4 @@
-uint32_t gf100_grgpc_data[] = {
+static uint32_t gf100_grgpc_data[] = {
 /* 0x0000: gpc_mmio_list_head */
         0x00000064,
 /* 0x0004: gpc_mmio_list_tail */
@@ -36,7 +36,7 @@ uint32_t gf100_grgpc_data[] = {
         0x00000000,
 };
 
-uint32_t gf100_grgpc_code[] = {
+static uint32_t gf100_grgpc_code[] = {
         0x03a10ef5,
 /* 0x0004: queue_put */
         0x9800d898,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgf117.fuc3.h b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgf117.fuc3.h
index 550d6ba0933b..ffbfc51200f1 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgf117.fuc3.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgf117.fuc3.h
@@ -1,4 +1,4 @@
-uint32_t gf117_grgpc_data[] = {
+static uint32_t gf117_grgpc_data[] = {
 /* 0x0000: gpc_mmio_list_head */
         0x0000006c,
 /* 0x0004: gpc_mmio_list_tail */
@@ -40,7 +40,7 @@ uint32_t gf117_grgpc_data[] = {
         0x00000000,
 };
 
-uint32_t gf117_grgpc_code[] = {
+static uint32_t gf117_grgpc_code[] = {
         0x03a10ef5,
 /* 0x0004: queue_put */
         0x9800d898,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgk104.fuc3.h b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgk104.fuc3.h
index 271b59d365e5..357f662de571 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgk104.fuc3.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgk104.fuc3.h
@@ -1,4 +1,4 @@
-uint32_t gk104_grgpc_data[] = {
+static uint32_t gk104_grgpc_data[] = {
 /* 0x0000: gpc_mmio_list_head */
         0x0000006c,
 /* 0x0004: gpc_mmio_list_tail */
@@ -40,7 +40,7 @@ uint32_t gk104_grgpc_data[] = {
         0x00000000,
 };
 
-uint32_t gk104_grgpc_code[] = {
+static uint32_t gk104_grgpc_code[] = {
         0x03a10ef5,
 /* 0x0004: queue_put */
         0x9800d898,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgk110.fuc3.h b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgk110.fuc3.h
index 73b4a32c5d29..4ffc8212a85c 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgk110.fuc3.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgk110.fuc3.h
@@ -1,4 +1,4 @@
-uint32_t gk110_grgpc_data[] = {
+static uint32_t gk110_grgpc_data[] = {
 /* 0x0000: gpc_mmio_list_head */
         0x0000006c,
 /* 0x0004: gpc_mmio_list_tail */
@@ -40,7 +40,7 @@ uint32_t gk110_grgpc_data[] = {
         0x00000000,
 };
 
-uint32_t gk110_grgpc_code[] = {
+static uint32_t gk110_grgpc_code[] = {
         0x03a10ef5,
 /* 0x0004: queue_put */
         0x9800d898,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgk208.fuc5.h b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgk208.fuc5.h
index 018169818317..09196206c9bc 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgk208.fuc5.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgk208.fuc5.h
@@ -1,4 +1,4 @@
-uint32_t gk208_grgpc_data[] = {
+static uint32_t gk208_grgpc_data[] = {
 /* 0x0000: gpc_mmio_list_head */
         0x0000006c,
 /* 0x0004: gpc_mmio_list_tail */
@@ -40,7 +40,7 @@ uint32_t gk208_grgpc_data[] = {
         0x00000000,
 };
 
-uint32_t gk208_grgpc_code[] = {
+static uint32_t gk208_grgpc_code[] = {
         0x03140ef5,
 /* 0x0004: queue_put */
         0x9800d898,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgm107.fuc5.h b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgm107.fuc5.h
index eca007f03fa9..6d7d004363d9 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgm107.fuc5.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/gpcgm107.fuc5.h
@@ -1,4 +1,4 @@
-uint32_t gm107_grgpc_data[] = {
+static uint32_t gm107_grgpc_data[] = {
 /* 0x0000: gpc_mmio_list_head */
         0x0000006c,
 /* 0x0004: gpc_mmio_list_tail */
@@ -40,7 +40,7 @@ uint32_t gm107_grgpc_data[] = {
         0x00000000,
 };
 
-uint32_t gm107_grgpc_code[] = {
+static uint32_t gm107_grgpc_code[] = {
         0x03410ef5,
 /* 0x0004: queue_put */
         0x9800d898,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgf100.fuc3.h b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgf100.fuc3.h
index 8015b40a61d6..7538404b8b13 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgf100.fuc3.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgf100.fuc3.h
@@ -1,4 +1,4 @@
-uint32_t gf100_grhub_data[] = {
+static uint32_t gf100_grhub_data[] = {
 /* 0x0000: hub_mmio_list_head */
         0x00000300,
 /* 0x0004: hub_mmio_list_tail */
@@ -205,7 +205,7 @@ uint32_t gf100_grhub_data[] = {
         0x0417e91c,
 };
 
-uint32_t gf100_grhub_code[] = {
+static uint32_t gf100_grhub_code[] = {
         0x039b0ef5,
 /* 0x0004: queue_put */
         0x9800d898,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgf117.fuc3.h b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgf117.fuc3.h
index 2af90ec6852a..ce000a47ec6d 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgf117.fuc3.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgf117.fuc3.h
@@ -1,4 +1,4 @@
-uint32_t gf117_grhub_data[] = {
+static uint32_t gf117_grhub_data[] = {
 /* 0x0000: hub_mmio_list_head */
         0x00000300,
 /* 0x0004: hub_mmio_list_tail */
@@ -205,7 +205,7 @@ uint32_t gf117_grhub_data[] = {
         0x0417e91c,
 };
 
-uint32_t gf117_grhub_code[] = {
+static uint32_t gf117_grhub_code[] = {
         0x039b0ef5,
 /* 0x0004: queue_put */
         0x9800d898,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgk104.fuc3.h b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgk104.fuc3.h
index e8b8c1c94700..1f26cb6a233c 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgk104.fuc3.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgk104.fuc3.h
@@ -1,4 +1,4 @@
-uint32_t gk104_grhub_data[] = {
+static uint32_t gk104_grhub_data[] = {
 /* 0x0000: hub_mmio_list_head */
         0x00000300,
 /* 0x0004: hub_mmio_list_tail */
@@ -205,7 +205,7 @@ uint32_t gk104_grhub_data[] = {
         0x0417e91c,
 };
 
-uint32_t gk104_grhub_code[] = {
+static uint32_t gk104_grhub_code[] = {
         0x039b0ef5,
 /* 0x0004: queue_put */
         0x9800d898,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgk110.fuc3.h b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgk110.fuc3.h
index f4ed2fb6f714..70436d93efe3 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgk110.fuc3.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgk110.fuc3.h
@@ -1,4 +1,4 @@
-uint32_t gk110_grhub_data[] = {
+static uint32_t gk110_grhub_data[] = {
 /* 0x0000: hub_mmio_list_head */
         0x00000300,
 /* 0x0004: hub_mmio_list_tail */
@@ -205,7 +205,7 @@ uint32_t gk110_grhub_data[] = {
         0x0417e91c,
 };
 
-uint32_t gk110_grhub_code[] = {
+static uint32_t gk110_grhub_code[] = {
         0x039b0ef5,
 /* 0x0004: queue_put */
         0x9800d898,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgk208.fuc5.h b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgk208.fuc5.h
index ed488973c117..e0933a07426a 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgk208.fuc5.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgk208.fuc5.h
@@ -1,4 +1,4 @@
-uint32_t gk208_grhub_data[] = {
+static uint32_t gk208_grhub_data[] = {
 /* 0x0000: hub_mmio_list_head */
         0x00000300,
 /* 0x0004: hub_mmio_list_tail */
@@ -205,7 +205,7 @@ uint32_t gk208_grhub_data[] = {
         0x0417e91c,
 };
 
-uint32_t gk208_grhub_code[] = {
+static uint32_t gk208_grhub_code[] = {
         0x030e0ef5,
 /* 0x0004: queue_put */
         0x9800d898,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgm107.fuc5.h b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgm107.fuc5.h
index 5c9051839557..9b432823bcbe 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgm107.fuc5.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/fuc/hubgm107.fuc5.h
@@ -1,4 +1,4 @@
-uint32_t gm107_grhub_data[] = {
+static uint32_t gm107_grhub_data[] = {
 /* 0x0000: hub_mmio_list_head */
         0x00000300,
 /* 0x0004: hub_mmio_list_tail */
@@ -205,7 +205,7 @@ uint32_t gm107_grhub_data[] = {
         0x0417e91c,
 };
 
-uint32_t gm107_grhub_code[] = {
+static uint32_t gm107_grhub_code[] = {
         0x030e0ef5,
 /* 0x0004: queue_put */
         0x9800d898,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
index 157919c788e6..60a1b5c8214b 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
@@ -1384,7 +1384,7 @@ gf100_gr_intr(struct nvkm_gr *base)
         nvkm_fifo_chan_put(device->fifo, flags, &chan);
 }
 
-void
+static void
 gf100_gr_init_fw(struct gf100_gr *gr, u32 fuc_base,
                  struct gf100_gr_fuc *code, struct gf100_gr_fuc *data)
 {
@@ -1701,7 +1701,7 @@ gf100_gr_oneinit(struct nvkm_gr *base)
         return 0;
 }
 
-int
+static int
 gf100_gr_init_(struct nvkm_gr *base)
 {
         struct gf100_gr *gr = gf100_gr(base);
@@ -1756,6 +1756,50 @@ gf100_gr_ = {
 };
 
 int
+gf100_gr_ctor_fw_legacy(struct gf100_gr *gr, const char *fwname,
+                        struct gf100_gr_fuc *fuc, int ret)
+{
+        struct nvkm_subdev *subdev = &gr->base.engine.subdev;
+        struct nvkm_device *device = subdev->device;
+        const struct firmware *fw;
+        char f[32];
+
+        /* see if this firmware has a legacy path */
+        if (!strcmp(fwname, "fecs_inst"))
+                fwname = "fuc409c";
+        else if (!strcmp(fwname, "fecs_data"))
+                fwname = "fuc409d";
+        else if (!strcmp(fwname, "gpccs_inst"))
+                fwname = "fuc41ac";
+        else if (!strcmp(fwname, "gpccs_data"))
+                fwname = "fuc41ad";
+        else {
+                /* nope, let's just return the error we got */
+                nvkm_error(subdev, "failed to load %s\n", fwname);
+                return ret;
+        }
+
+        /* yes, try to load from the legacy path */
+        nvkm_debug(subdev, "%s: falling back to legacy path\n", fwname);
+
+        snprintf(f, sizeof(f), "nouveau/nv%02x_%s", device->chipset, fwname);
+        ret = request_firmware(&fw, f, device->dev);
+        if (ret) {
+                snprintf(f, sizeof(f), "nouveau/%s", fwname);
+                ret = request_firmware(&fw, f, device->dev);
+                if (ret) {
+                        nvkm_error(subdev, "failed to load %s\n", fwname);
+                        return ret;
+                }
+        }
+
+        fuc->size = fw->size;
+        fuc->data = kmemdup(fw->data, fuc->size, GFP_KERNEL);
+        release_firmware(fw);
+        return (fuc->data != NULL) ? 0 : -ENOMEM;
+}
+
+int
 gf100_gr_ctor_fw(struct gf100_gr *gr, const char *fwname,
                  struct gf100_gr_fuc *fuc)
 {
@@ -1765,10 +1809,8 @@ gf100_gr_ctor_fw(struct gf100_gr *gr, const char *fwname,
         int ret;
 
         ret = nvkm_firmware_get(device, fwname, &fw);
-        if (ret) {
-                nvkm_error(subdev, "failed to load %s\n", fwname);
-                return ret;
-        }
+        if (ret)
+                return gf100_gr_ctor_fw_legacy(gr, fwname, fuc, ret);
 
         fuc->size = fw->size;
         fuc->data = kmemdup(fw->data, fuc->size, GFP_KERNEL);
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf117.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf117.c
index 70335f65c51e..0124e468086e 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf117.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf117.c
@@ -102,7 +102,7 @@ gf117_gr_pack_mmio[] = {
 
 #include "fuc/hubgf117.fuc3.h"
 
-struct gf100_gr_ucode
+static struct gf100_gr_ucode
 gf117_gr_fecs_ucode = {
         .code.data = gf117_grhub_code,
         .code.size = sizeof(gf117_grhub_code),
@@ -112,7 +112,7 @@ gf117_gr_fecs_ucode = {
 
 #include "fuc/gpcgf117.fuc3.h"
 
-struct gf100_gr_ucode
+static struct gf100_gr_ucode
 gf117_gr_gpccs_ucode = {
         .code.data = gf117_grgpc_code,
         .code.size = sizeof(gf117_grgpc_code),
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c
index 45f965f608a7..2c67fac576d1 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c
@@ -308,7 +308,7 @@ gm107_gr_init_bios(struct gf100_gr *gr)
         }
 }
 
-int
+static int
 gm107_gr_init(struct gf100_gr *gr)
 {
         struct nvkm_device *device = gr->base.engine.subdev.device;
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
index 8616636ad7b4..dde89a4a0f5b 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
@@ -71,7 +71,7 @@ nvkm_perfdom_find(struct nvkm_pm *pm, int di)
         return NULL;
 }
 
-struct nvkm_perfsig *
+static struct nvkm_perfsig *
 nvkm_perfsig_find(struct nvkm_pm *pm, u8 di, u8 si, struct nvkm_perfdom **pdom)
 {
         struct nvkm_perfdom *dom = *pdom;
@@ -699,7 +699,7 @@ nvkm_pm_oclass_get(struct nvkm_oclass *oclass, int index,
         return 1;
 }
 
-int
+static int
 nvkm_perfsrc_new(struct nvkm_pm *pm, struct nvkm_perfsig *sig,
                  const struct nvkm_specsrc *spec)
 {
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/pm/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/pm/gf100.c
index d2901e9a7808..fe2532ee4145 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/pm/gf100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/pm/gf100.c
@@ -102,7 +102,7 @@ gf100_pm_gpc[] = {
         {}
 };
 
-const struct nvkm_specdom
+static const struct nvkm_specdom
 gf100_pm_part[] = {
         { 0xe0, (const struct nvkm_specsig[]) {
                         { 0x0f, "part00_pbfb_00", gf100_pbfb_sources },
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/sec/fuc/g98.fuc0s.h b/drivers/gpu/drm/nouveau/nvkm/engine/sec/fuc/g98.fuc0s.h
index eca62221f299..4b57f8814560 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/sec/fuc/g98.fuc0s.h
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/sec/fuc/g98.fuc0s.h
@@ -1,4 +1,4 @@
-uint32_t g98_sec_data[] = {
+static uint32_t g98_sec_data[] = {
 /* 0x0000: ctx_dma */
 /* 0x0000: ctx_dma_query */
         0x00000000,
@@ -150,7 +150,7 @@ uint32_t g98_sec_data[] = {
         0x00000000,
 };
 
-uint32_t g98_sec_code[] = {
+static uint32_t g98_sec_code[] = {
         0x17f004bd,
         0x0010fe35,
         0xf10004fe,
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c
index 80fed7e78dcb..e2905815049b 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c
@@ -25,7 +25,7 @@
 #include <subdev/bios/bit.h>
 #include <subdev/bios/fan.h>
 
-u16
+static u16
 nvbios_fan_table(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 *cnt, u8 *len)
 {
         struct bit_entry bit_P;
@@ -52,7 +52,7 @@ nvbios_fan_table(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 *cnt, u8 *len)
         return 0x0000;
 }
 
-u16
+static u16
 nvbios_fan_entry(struct nvkm_bios *bios, int idx, u8 *ver, u8 *hdr,
                  u8 *cnt, u8 *len)
 {
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/priv.h b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/priv.h
index 212800ecdce9..7d1d3c6b4b72 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/priv.h
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/priv.h
@@ -12,6 +12,7 @@ struct nvbios_source {
         bool rw;
         bool ignore_checksum;
         bool no_pcir;
+        bool require_checksum;
 };
 
 int nvbios_extend(struct nvkm_bios *, u32 length);
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadow.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadow.c
index b2557e87afdd..7deb81b6dbac 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadow.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadow.c
@@ -86,9 +86,12 @@ shadow_image(struct nvkm_bios *bios, int idx, u32 offset, struct shadow *mthd)
                     nvbios_checksum(&bios->data[image.base], image.size)) {
                         nvkm_debug(subdev, "%08x: checksum failed\n",
                                    image.base);
-                        if (mthd->func->rw)
+                        if (!mthd->func->require_checksum) {
+                                if (mthd->func->rw)
+                                        score += 1;
                                 score += 1;
-                        score += 1;
+                        } else
+                                return 0;
                 } else {
                         score += 3;
                 }
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowacpi.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowacpi.c
index 8fecb5ff22a0..06572f8ce914 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowacpi.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowacpi.c
@@ -99,6 +99,7 @@ nvbios_acpi_fast = {
         .init = acpi_init,
         .read = acpi_read_fast,
         .rw = false,
+        .require_checksum = true,
 };
 
 const struct nvbios_source
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c b/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c
index 056702ef69aa..96e0941c8edd 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c
@@ -180,7 +180,7 @@ gt215_clk_read(struct nvkm_clk *base, enum nv_clk_src src)
         return 0;
 }
 
-int
+static int
 gt215_clk_info(struct nvkm_clk *base, int idx, u32 khz,
                struct gt215_clk_info *info)
 {
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/Kbuild b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/Kbuild
index edcc157e6ac8..ef47d57fcb87 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/Kbuild
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/Kbuild
@@ -24,6 +24,7 @@ nvkm-y += nvkm/subdev/fb/gk104.o
 nvkm-y += nvkm/subdev/fb/gk20a.o
 nvkm-y += nvkm/subdev/fb/gm107.o
 nvkm-y += nvkm/subdev/fb/gm200.o
+nvkm-y += nvkm/subdev/fb/gm20b.o
 nvkm-y += nvkm/subdev/fb/gp100.o
 nvkm-y += nvkm/subdev/fb/gp104.o
 
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf100.h b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf100.h
index 449f431644b3..412eb89834e8 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf100.h
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf100.h
@@ -16,4 +16,8 @@ void gf100_fb_init(struct nvkm_fb *);
 void gf100_fb_intr(struct nvkm_fb *);
 
 void gp100_fb_init(struct nvkm_fb *);
+
+void gm200_fb_init_page(struct nvkm_fb *fb);
+void gm200_fb_init(struct nvkm_fb *base);
+
 #endif
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk20a.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk20a.c
index f815fe2bbf08..5d34d6136616 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk20a.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk20a.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2014, NVIDIA CORPORATION. All rights reserved.
+ * Copyright (c) 2014-2016, NVIDIA CORPORATION. All rights reserved.
  *
  * Permission is hereby granted, free of charge, to any person obtaining a
  * copy of this software and associated documentation files (the "Software"),
@@ -20,27 +20,21 @@
  * DEALINGS IN THE SOFTWARE.
  */
 #include "priv.h"
+#include "gf100.h"
 
-#include <core/memory.h>
-
-static void
-gk20a_fb_init(struct nvkm_fb *fb)
-{
-        struct nvkm_device *device = fb->subdev.device;
-        nvkm_wr32(device, 0x100cc8, nvkm_memory_addr(fb->mmu_wr) >> 8);
-        nvkm_wr32(device, 0x100ccc, nvkm_memory_addr(fb->mmu_rd) >> 8);
-}
-
+/* GK20A's FB is similar to GF100's, but without the ability to allocate VRAM */
 static const struct nvkm_fb_func
 gk20a_fb = {
+        .dtor = gf100_fb_dtor,
         .oneinit = gf100_fb_oneinit,
-        .init = gk20a_fb_init,
+        .init = gf100_fb_init,
         .init_page = gf100_fb_init_page,
+        .intr = gf100_fb_intr,
         .memtype_valid = gf100_fb_memtype_valid,
 };
 
 int
 gk20a_fb_new(struct nvkm_device *device, int index, struct nvkm_fb **pfb)
 {
-        return nvkm_fb_new_(&gk20a_fb, device, index, pfb);
+        return gf100_fb_new_(&gk20a_fb, device, index, pfb);
 }
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm200.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm200.c
index 62f653240be3..fe5886013ac0 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm200.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm200.c
@@ -44,7 +44,7 @@ gm200_fb_init_page(struct nvkm_fb *fb)
         }
 }
 
-static void
+void
 gm200_fb_init(struct nvkm_fb *base)
 {
         struct gf100_fb *fb = gf100_fb(base);
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm20b.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm20b.c
new file mode 100644
index 000000000000..b87c233bcd6d
--- /dev/null
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm20b.c
@@ -0,0 +1,40 @@
+/*
+ * Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+#include "priv.h"
+#include "gf100.h"
+
+/* GM20B's FB is similar to GM200, but without the ability to allocate VRAM */
+static const struct nvkm_fb_func
+gm20b_fb = {
+        .dtor = gf100_fb_dtor,
+        .oneinit = gf100_fb_oneinit,
+        .init = gm200_fb_init,
+        .init_page = gm200_fb_init_page,
+        .intr = gf100_fb_intr,
+        .memtype_valid = gf100_fb_memtype_valid,
+};
+
+int
+gm20b_fb_new(struct nvkm_device *device, int index, struct nvkm_fb **pfb)
+{
+        return gf100_fb_new_(&gm20b_fb, device, index, pfb);
+}
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c
index 772425ca5a9e..093223d1df4f 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c
@@ -420,8 +420,6 @@ gf100_ram_tidy(struct nvkm_ram *base)
         ram_exec(&ram->fuc, false);
 }
 
-extern const u8 gf100_pte_storage_type_map[256];
-
 void
 gf100_ram_put(struct nvkm_ram *ram, struct nvkm_mem **pmem)
 {
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c
index d15ea886df27..f10664372161 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c
@@ -95,7 +95,7 @@ struct gt215_ram {
         struct gt215_ltrain ltrain;
 };
 
-void
+static void
 gt215_link_train_calc(u32 *vals, struct gt215_ltrain *train)
 {
         int i, lo, hi;
@@ -149,7 +149,7 @@ gt215_link_train_calc(u32 *vals, struct gt215_ltrain *train)
 /*
  * Link training for (at least) DDR3
  */
-int
+static int
 gt215_link_train(struct gt215_ram *ram)
 {
         struct gt215_ltrain *train = &ram->ltrain;
@@ -267,7 +267,7 @@ out:
         return ret;
 }
 
-int
+static int
 gt215_link_train_init(struct gt215_ram *ram)
 {
         static const u32 pattern[16] = {
@@ -333,7 +333,7 @@ gt215_link_train_init(struct gt215_ram *ram)
         return 0;
 }
 
-void
+static void
 gt215_link_train_fini(struct gt215_ram *ram)
 {
         if (ram->ltrain.mem)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c
index b9f1ffdfc602..4dcd8742f2da 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c
@@ -23,6 +23,7 @@
  *          Ben Skeggs
  */
 #include "priv.h"
+#include "ram.h"
 
 struct ramxlat {
         int id;
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c
index 26900333b1d6..eca8a445eab3 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c
@@ -23,6 +23,7 @@
  *          Roy Spliet <rspliet@eclipso.eu>
  */
 #include "priv.h"
+#include "ram.h"
 
 struct ramxlat {
         int id;
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/gk104.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/gk104.c
index 3f45afd17d5a..2ead515b8530 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/gk104.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/gk104.c
@@ -37,7 +37,7 @@ gk104_gpio_intr_stat(struct nvkm_gpio *gpio, u32 *hi, u32 *lo)
         nvkm_wr32(device, 0x00dc80, intr1);
 }
 
-void
+static void
 gk104_gpio_intr_mask(struct nvkm_gpio *gpio, u32 type, u32 mask, u32 data)
 {
         struct nvkm_device *device = gpio->subdev.device;
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/aux.c b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/aux.c
index f0851d57df2f..01d5c5a56e2e 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/aux.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/aux.c
@@ -74,7 +74,7 @@ nvkm_i2c_aux_i2c_func(struct i2c_adapter *adap)
         return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
 }
 
-const struct i2c_algorithm
+static const struct i2c_algorithm
 nvkm_i2c_aux_i2c_algo = {
         .master_xfer = nvkm_i2c_aux_i2c_xfer,
         .functionality = nvkm_i2c_aux_i2c_func
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c
index 954f5b76bfcf..b80236a4eeac 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c
@@ -79,7 +79,7 @@ g94_i2c_aux_xfer(struct nvkm_i2c_aux *obj, bool retry,
         struct g94_i2c_aux *aux = g94_i2c_aux(obj);
         struct nvkm_device *device = aux->base.pad->i2c->subdev.device;
         const u32 base = aux->ch * 0x50;
-        u32 ctrl, stat, timeout, retries;
+        u32 ctrl, stat, timeout, retries = 0;
         u32 xbuf[4] = {};
         int ret, i;
 
@@ -111,7 +111,7 @@ g94_i2c_aux_xfer(struct nvkm_i2c_aux *obj, bool retry,
         nvkm_wr32(device, 0x00e4e0 + base, addr);
 
         /* (maybe) retry transaction a number of times on failure... */
-        for (retries = 0; !ret && retries < 32; retries++) {
+        do {
                 /* reset, and delay a while if this is a retry */
                 nvkm_wr32(device, 0x00e4e4 + base, 0x80000000 | ctrl);
                 nvkm_wr32(device, 0x00e4e4 + base, 0x00000000 | ctrl);
@@ -131,20 +131,20 @@ g94_i2c_aux_xfer(struct nvkm_i2c_aux *obj, bool retry,
                                 goto out;
                         }
                 } while (ctrl & 0x00010000);
-                ret = 1;
+                ret = 0;
 
                 /* read status, and check if transaction completed ok */
                 stat = nvkm_mask(device, 0x00e4e8 + base, 0, 0);
                 if ((stat & 0x000f0000) == 0x00080000 ||
                     (stat & 0x000f0000) == 0x00020000)
-                        ret = retry ? 0 : 1;
+                        ret = 1;
                 if ((stat & 0x00000100))
                         ret = -ETIMEDOUT;
                 if ((stat & 0x00000e00))
                         ret = -EIO;
 
                 AUX_TRACE(&aux->base, "%02d %08x %08x", retries, ctrl, stat);
-        }
+        } while (ret && retry && retries++ < 32);
 
         if (type & 1) {
                 for (i = 0; i < 16; i += 4) {
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c
index 61d729b82c69..ed458c7f056b 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c
@@ -79,7 +79,7 @@ gm200_i2c_aux_xfer(struct nvkm_i2c_aux *obj, bool retry,
         struct gm200_i2c_aux *aux = gm200_i2c_aux(obj);
         struct nvkm_device *device = aux->base.pad->i2c->subdev.device;
         const u32 base = aux->ch * 0x50;
-        u32 ctrl, stat, timeout, retries;
+        u32 ctrl, stat, timeout, retries = 0;
         u32 xbuf[4] = {};
         int ret, i;
 
@@ -111,7 +111,7 @@ gm200_i2c_aux_xfer(struct nvkm_i2c_aux *obj, bool retry,
         nvkm_wr32(device, 0x00d950 + base, addr);
 
         /* (maybe) retry transaction a number of times on failure... */
-        for (retries = 0; !ret && retries < 32; retries++) {
+        do {
                 /* reset, and delay a while if this is a retry */
                 nvkm_wr32(device, 0x00d954 + base, 0x80000000 | ctrl);
                 nvkm_wr32(device, 0x00d954 + base, 0x00000000 | ctrl);
@@ -131,20 +131,20 @@ gm200_i2c_aux_xfer(struct nvkm_i2c_aux *obj, bool retry,
                                 goto out;
                         }
                 } while (ctrl & 0x00010000);
-                ret = 1;
+                ret = 0;
 
                 /* read status, and check if transaction completed ok */
                 stat = nvkm_mask(device, 0x00d958 + base, 0, 0);
                 if ((stat & 0x000f0000) == 0x00080000 ||
                     (stat & 0x000f0000) == 0x00020000)
-                        ret = retry ? 0 : 1;
+                        ret = 1;
                 if ((stat & 0x00000100))
                         ret = -ETIMEDOUT;
                 if ((stat & 0x00000e00))
                         ret = -EIO;
 
                 AUX_TRACE(&aux->base, "%02d %08x %08x", retries, ctrl, stat);
-        }
+        } while (ret && retry && retries++ < 32);
 
         if (type & 1) {
                 for (i = 0; i < 16; i += 4) {
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
index 658355fc9354..f0af2a381eea 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
@@ -288,7 +288,8 @@ nvkm_iccsense_init(struct nvkm_subdev *subdev)
         return 0;
 }
 
-struct nvkm_subdev_func iccsense_func = {
+static const struct nvkm_subdev_func
+iccsense_func = {
         .oneinit = nvkm_iccsense_oneinit,
         .init = nvkm_iccsense_init,
         .dtor = nvkm_iccsense_dtor,
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/base.c
index 8ed8f65ff664..10c987a654ec 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/base.c
@@ -104,7 +104,7 @@ nvkm_instobj_dtor(struct nvkm_memory *memory)
         return iobj;
 }
 
-const struct nvkm_memory_func
+static const struct nvkm_memory_func
 nvkm_instobj_func = {
         .dtor = nvkm_instobj_dtor,
         .target = nvkm_instobj_target,
@@ -156,7 +156,7 @@ nvkm_instobj_wr32_slow(struct nvkm_memory *memory, u64 offset, u32 data)
         return nvkm_wo32(iobj->parent, offset, data);
 }
 
-const struct nvkm_memory_func
+static const struct nvkm_memory_func
 nvkm_instobj_func_slow = {
         .dtor = nvkm_instobj_dtor,
         .target = nvkm_instobj_target,
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mc/g84.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mc/g84.c
index c3d66ef5dc12..430a61c3df44 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/mc/g84.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mc/g84.c
@@ -34,7 +34,7 @@ g84_mc_reset[] = {
         {}
 };
 
-const struct nvkm_mc_map
+static const struct nvkm_mc_map
 g84_mc_intr[] = {
         { 0x04000000, NVKM_ENGINE_DISP },
         { 0x00020000, NVKM_ENGINE_VP },
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mxm/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mxm/base.c
index 21b65ee254e4..e3e2f5e83815 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/mxm/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mxm/base.c
@@ -250,6 +250,10 @@ nvkm_mxm_new_(struct nvkm_device *device, int index, struct nvkm_mxm **pmxm)
         }
 
         nvkm_info(&mxm->subdev, "BIOS version %d.%d\n", ver >> 4, ver & 0x0f);
+        nvkm_debug(&mxm->subdev, "module flags: %02x\n",
+                   nvbios_rd08(bios, data + 0x01));
+        nvkm_debug(&mxm->subdev, "config flags: %02x\n",
+                   nvbios_rd08(bios, data + 0x02));
 
         if (mxm_shadow(mxm, ver)) {
                 nvkm_warn(&mxm->subdev, "failed to locate valid SIS\n");
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/gf100.fuc3.h b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/gf100.fuc3.h
index e2faccffee6f..0bcf0b307a61 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/gf100.fuc3.h
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/gf100.fuc3.h
@@ -1,4 +1,4 @@
-uint32_t gf100_pmu_data[] = {
+static uint32_t gf100_pmu_data[] = {
 /* 0x0000: proc_kern */
         0x52544e49,
         0x00000000,
@@ -916,7 +916,7 @@ uint32_t gf100_pmu_data[] = {
         0x00000000,
 };
 
-uint32_t gf100_pmu_code[] = {
+static uint32_t gf100_pmu_code[] = {
         0x03920ef5,
 /* 0x0004: rd32 */
         0x07a007f1,
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/gf119.fuc4.h b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/gf119.fuc4.h
index 2d5bdc539697..fe8905666c67 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/gf119.fuc4.h
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/gf119.fuc4.h
@@ -1,4 +1,4 @@
-uint32_t gf119_pmu_data[] = {
+static uint32_t gf119_pmu_data[] = {
 /* 0x0000: proc_kern */
         0x52544e49,
         0x00000000,
@@ -915,7 +915,7 @@ uint32_t gf119_pmu_data[] = {
         0x00000000,
 };
 
-uint32_t gf119_pmu_code[] = {
+static uint32_t gf119_pmu_code[] = {
         0x03410ef5,
 /* 0x0004: rd32 */
         0x07a007f1,
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/gk208.fuc5.h b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/gk208.fuc5.h
index 3c731ff12871..9cf4e6fc724e 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/gk208.fuc5.h
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/gk208.fuc5.h
@@ -1,4 +1,4 @@
-uint32_t gk208_pmu_data[] = {
+static uint32_t gk208_pmu_data[] = {
 /* 0x0000: proc_kern */
         0x52544e49,
         0x00000000,
@@ -915,7 +915,7 @@ uint32_t gk208_pmu_data[] = {
         0x00000000,
 };
 
-uint32_t gk208_pmu_code[] = {
+static uint32_t gk208_pmu_code[] = {
         0x02f90ef5,
 /* 0x0004: rd32 */
         0xf607a040,
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/gt215.fuc3.h b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/gt215.fuc3.h
index e83341815ec6..5d692425b190 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/gt215.fuc3.h
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/gt215.fuc3.h
@@ -1,4 +1,4 @@
-uint32_t gt215_pmu_data[] = {
+static uint32_t gt215_pmu_data[] = {
 /* 0x0000: proc_kern */
         0x52544e49,
         0x00000000,
@@ -916,7 +916,7 @@ uint32_t gt215_pmu_data[] = {
         0x00000000,
 };
 
-uint32_t gt215_pmu_code[] = {
+static uint32_t gt215_pmu_code[] = {
         0x03920ef5,
 /* 0x0004: rd32 */
         0x07a007f1,
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gt215.c b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gt215.c
index 8ba7fa4ca75b..dcf9eaf274aa 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gt215.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gt215.c
@@ -24,17 +24,8 @@
 #include "priv.h"
 #include "fuc/gt215.fuc3.h"
 
-static void
-gt215_pmu_reset(struct nvkm_pmu *pmu)
-{
-        struct nvkm_device *device = pmu->subdev.device;
-        nvkm_mask(device, 0x022210, 0x00000001, 0x00000000);
-        nvkm_mask(device, 0x022210, 0x00000001, 0x00000001);
-}
-
 static const struct nvkm_pmu_func
 gt215_pmu = {
-        .reset = gt215_pmu_reset,
         .code.data = gt215_pmu_code,
         .code.size = sizeof(gt215_pmu_code),
         .data.data = gt215_pmu_data,
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/priv.h b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/priv.h
index f38c88fae3d6..73b811ccc2d5 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/priv.h
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/priv.h
@@ -8,8 +8,6 @@ int nvkm_pmu_new_(const struct nvkm_pmu_func *, struct nvkm_device *,
                   int index, struct nvkm_pmu **);
 
 struct nvkm_pmu_func {
-        void (*reset)(struct nvkm_pmu *);
-
         struct {
                 u32 *data;
                 u32  size;
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm200.c b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm200.c
index f1e2dc914366..ec48e4ace37a 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm200.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm200.c
@@ -1364,7 +1364,7 @@ gm200_secboot_init(struct nvkm_secboot *sb)
         return 0;
 }
 
-int
+static int
 gm200_secboot_fini(struct nvkm_secboot *sb, bool suspend)
 {
         struct gm200_secboot *gsb = gm200_secboot(sb);
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
index b2c5d1166a13..1c744e029454 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
@@ -35,7 +35,7 @@ struct gk104_volt {
         struct nvbios_volt bios;
 };
 
-int
+static int
 gk104_volt_get(struct nvkm_volt *base)
 {
         struct nvbios_volt *bios = &gk104_volt(base)->bios;
@@ -48,7 +48,7 @@ gk104_volt_get(struct nvkm_volt *base)
         return bios->base + bios->pwm_range * duty / div;
 }
 
-int
+static int
 gk104_volt_set(struct nvkm_volt *base, u32 uv)
 {
         struct nvbios_volt *bios = &gk104_volt(base)->bios;
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gm20b.c b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gm20b.c
index 74db4d28930f..2925b9cae681 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gm20b.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gm20b.c
@@ -25,7 +25,7 @@
 
 #include <core/tegra.h>
 
-const struct cvb_coef gm20b_cvb_coef[] = {
+static const struct cvb_coef gm20b_cvb_coef[] = {
         /* KHz,             c0,      c1,   c2 */
         /*  76800 */ { 1786666,  -85625, 1632 },
         /* 153600 */ { 1846729,  -87525, 1632 },
@@ -58,7 +58,7 @@ static const struct cvb_coef gm20b_na_cvb_coef[] = {
         /* 998400 */ { 1316991, 8144, -940, 808, -21583, 226 },
 };
 
-const u32 speedo_to_vmin[] = {
+static const u32 speedo_to_vmin[] = {
         /*   0,      1,      2,      3,      4, */
         950000, 840000, 818750, 840000, 810000,
 };
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c
index d2bac1d77819..443c031b966b 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c
@@ -25,6 +25,7 @@
 #include <subdev/bios.h>
 #include <subdev/bios/gpio.h>
 #include <subdev/gpio.h>
+#include "priv.h"
 
 static const u8 tags[] = {
         DCB_GPIO_VID0, DCB_GPIO_VID1, DCB_GPIO_VID2, DCB_GPIO_VID3,
diff --git a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
index 3485d1ecd655..aaa8a58390f1 100644
--- a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
+++ b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
@@ -24,23 +24,24 @@ struct panel_drv_data {
 
         struct device *dev;
 
-        struct omap_video_timings timings;
+        struct videomode vm;
 
         bool invert_polarity;
 };
 
-static const struct omap_video_timings tvc_pal_timings = {
-        .x_res          = 720,
-        .y_res          = 574,
+static const struct videomode tvc_pal_vm = {
+        .hactive        = 720,
+        .vactive        = 574,
         .pixelclock     = 13500000,
-        .hsw            = 64,
-        .hfp            = 12,
-        .hbp            = 68,
-        .vsw            = 5,
-        .vfp            = 5,
-        .vbp            = 41,
-
-        .interlace      = true,
+        .hsync_len      = 64,
+        .hfront_porch   = 12,
+        .hback_porch    = 68,
+        .vsync_len      = 5,
+        .vfront_porch   = 5,
+        .vback_porch    = 41,
+
+        .flags          = DISPLAY_FLAGS_INTERLACED | DISPLAY_FLAGS_HSYNC_LOW |
+                          DISPLAY_FLAGS_VSYNC_LOW,
 };
 
 static const struct of_device_id tvc_of_match[];
@@ -92,7 +93,7 @@ static int tvc_enable(struct omap_dss_device *dssdev)
         if (omapdss_device_is_enabled(dssdev))
                 return 0;
 
-        in->ops.atv->set_timings(in, &ddata->timings);
+        in->ops.atv->set_timings(in, &ddata->vm);
 
         if (!ddata->dev->of_node) {
                 in->ops.atv->set_type(in, OMAP_DSS_VENC_TYPE_COMPOSITE);
@@ -126,32 +127,32 @@ static void tvc_disable(struct omap_dss_device *dssdev)
 }
 
 static void tvc_set_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                            struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        ddata->timings = *timings;
-        dssdev->panel.timings = *timings;
+        ddata->vm = *vm;
+        dssdev->panel.vm = *vm;
 
-        in->ops.atv->set_timings(in, timings);
+        in->ops.atv->set_timings(in, vm);
 }
 
 static void tvc_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                            struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
 
-        *timings = ddata->timings;
+        *vm = ddata->vm;
 }
 
 static int tvc_check_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                             struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        return in->ops.atv->check_timings(in, timings);
+        return in->ops.atv->check_timings(in, vm);
 }
 
 static u32 tvc_get_wss(struct omap_dss_device *dssdev)
@@ -253,14 +254,14 @@ static int tvc_probe(struct platform_device *pdev)
                 return -ENODEV;
         }
 
-        ddata->timings = tvc_pal_timings;
+        ddata->vm = tvc_pal_vm;
 
         dssdev = &ddata->dssdev;
         dssdev->driver = &tvc_driver;
         dssdev->dev = &pdev->dev;
         dssdev->type = OMAP_DISPLAY_TYPE_VENC;
         dssdev->owner = THIS_MODULE;
-        dssdev->panel.timings = tvc_pal_timings;
+        dssdev->panel.vm = tvc_pal_vm;
 
         r = omapdss_register_display(dssdev);
         if (r) {
diff --git a/drivers/gpu/drm/omapdrm/displays/connector-dvi.c b/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
index 684b7aeda411..d6875d9fcefa 100644
--- a/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
+++ b/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
@@ -19,32 +19,30 @@
 
 #include "../dss/omapdss.h"
 
-static const struct omap_video_timings dvic_default_timings = {
-        .x_res          = 640,
-        .y_res          = 480,
+static const struct videomode dvic_default_vm = {
+        .hactive        = 640,
+        .vactive        = 480,
 
         .pixelclock     = 23500000,
 
-        .hfp            = 48,
-        .hsw            = 32,
-        .hbp            = 80,
+        .hfront_porch   = 48,
+        .hsync_len      = 32,
+        .hback_porch    = 80,
 
-        .vfp            = 3,
-        .vsw            = 4,
-        .vbp            = 7,
+        .vfront_porch   = 3,
+        .vsync_len      = 4,
+        .vback_porch    = 7,
 
-        .vsync_level    = OMAPDSS_SIG_ACTIVE_HIGH,
-        .hsync_level    = OMAPDSS_SIG_ACTIVE_HIGH,
-        .data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE,
-        .de_level       = OMAPDSS_SIG_ACTIVE_HIGH,
-        .sync_pclk_edge = OMAPDSS_DRIVE_SIG_FALLING_EDGE,
+        .flags          = DISPLAY_FLAGS_HSYNC_HIGH | DISPLAY_FLAGS_VSYNC_HIGH |
+                          DISPLAY_FLAGS_SYNC_NEGEDGE | DISPLAY_FLAGS_DE_HIGH |
+                          DISPLAY_FLAGS_PIXDATA_POSEDGE,
 };
 
 struct panel_drv_data {
         struct omap_dss_device dssdev;
         struct omap_dss_device *in;
 
-        struct omap_video_timings timings;
+        struct videomode vm;
 
         struct i2c_adapter *i2c_adapter;
 };
@@ -90,7 +88,7 @@ static int dvic_enable(struct omap_dss_device *dssdev)
         if (omapdss_device_is_enabled(dssdev))
                 return 0;
 
-        in->ops.dvi->set_timings(in, &ddata->timings);
+        in->ops.dvi->set_timings(in, &ddata->vm);
 
         r = in->ops.dvi->enable(in);
         if (r)
@@ -115,32 +113,32 @@ static void dvic_disable(struct omap_dss_device *dssdev)
 }
 
 static void dvic_set_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                             struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        ddata->timings = *timings;
-        dssdev->panel.timings = *timings;
+        ddata->vm = *vm;
+        dssdev->panel.vm = *vm;
 
-        in->ops.dvi->set_timings(in, timings);
+        in->ops.dvi->set_timings(in, vm);
 }
 
 static void dvic_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                             struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
 
-        *timings = ddata->timings;
+        *vm = ddata->vm;
 }
 
 static int dvic_check_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                              struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        return in->ops.dvi->check_timings(in, timings);
+        return in->ops.dvi->check_timings(in, vm);
 }
 
 static int dvic_ddc_read(struct i2c_adapter *adapter,
@@ -287,14 +285,14 @@ static int dvic_probe(struct platform_device *pdev)
         if (r)
                 return r;
 
-        ddata->timings = dvic_default_timings;
+        ddata->vm = dvic_default_vm;
 
         dssdev = &ddata->dssdev;
         dssdev->driver = &dvic_driver;
         dssdev->dev = &pdev->dev;
         dssdev->type = OMAP_DISPLAY_TYPE_DVI;
         dssdev->owner = THIS_MODULE;
-        dssdev->panel.timings = dvic_default_timings;
+        dssdev->panel.vm = dvic_default_vm;
 
         r = omapdss_register_display(dssdev);
         if (r) {
diff --git a/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c b/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
index 7bdf83af9797..1ef130641bae 100644
--- a/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
+++ b/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
@@ -21,21 +21,18 @@
 
 #include "../dss/omapdss.h"
 
-static const struct omap_video_timings hdmic_default_timings = {
-        .x_res          = 640,
-        .y_res          = 480,
+static const struct videomode hdmic_default_vm = {
+        .hactive        = 640,
+        .vactive        = 480,
         .pixelclock     = 25175000,
-        .hsw            = 96,
-        .hfp            = 16,
-        .hbp            = 48,
-        .vsw            = 2,
-        .vfp            = 11,
-        .vbp            = 31,
-
-        .vsync_level    = OMAPDSS_SIG_ACTIVE_LOW,
-        .hsync_level    = OMAPDSS_SIG_ACTIVE_LOW,
-
-        .interlace      = false,
+        .hsync_len      = 96,
+        .hfront_porch   = 16,
+        .hback_porch    = 48,
+        .vsync_len      = 2,
+        .vfront_porch   = 11,
+        .vback_porch    = 31,
+
+        .flags          = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW,
 };
 
 struct panel_drv_data {
@@ -44,7 +41,7 @@ struct panel_drv_data {
 
         struct device *dev;
 
-        struct omap_video_timings timings;
+        struct videomode vm;
 
         int hpd_gpio;
 };
@@ -96,7 +93,7 @@ static int hdmic_enable(struct omap_dss_device *dssdev)
         if (omapdss_device_is_enabled(dssdev))
                 return 0;
 
-        in->ops.hdmi->set_timings(in, &ddata->timings);
+        in->ops.hdmi->set_timings(in, &ddata->vm);
 
         r = in->ops.hdmi->enable(in);
         if (r)
@@ -123,32 +120,32 @@ static void hdmic_disable(struct omap_dss_device *dssdev)
 }
 
 static void hdmic_set_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                              struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        ddata->timings = *timings;
-        dssdev->panel.timings = *timings;
+        ddata->vm = *vm;
+        dssdev->panel.vm = *vm;
 
-        in->ops.hdmi->set_timings(in, timings);
+        in->ops.hdmi->set_timings(in, vm);
 }
 
 static void hdmic_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                              struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
 
-        *timings = ddata->timings;
+        *vm = ddata->vm;
 }
 
 static int hdmic_check_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                               struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        return in->ops.hdmi->check_timings(in, timings);
+        return in->ops.hdmi->check_timings(in, vm);
 }
 
 static int hdmic_read_edid(struct omap_dss_device *dssdev,
@@ -259,14 +256,14 @@ static int hdmic_probe(struct platform_device *pdev)
                         goto err_reg;
         }
 
-        ddata->timings = hdmic_default_timings;
+        ddata->vm = hdmic_default_vm;
 
         dssdev = &ddata->dssdev;
         dssdev->driver = &hdmic_driver;
         dssdev->dev = &pdev->dev;
         dssdev->type = OMAP_DISPLAY_TYPE_HDMI;
         dssdev->owner = THIS_MODULE;
-        dssdev->panel.timings = hdmic_default_timings;
+        dssdev->panel.vm = hdmic_default_vm;
 
         r = omapdss_register_display(dssdev);
         if (r) {
diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
index fe4e7ec3bab0..f7a5731492d0 100644
--- a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
+++ b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
@@ -27,7 +27,7 @@ struct panel_drv_data {
 
         struct gpio_desc *enable_gpio;
 
-        struct omap_video_timings timings;
+        struct videomode vm;
 };
 
 #define to_panel_data(x) container_of(x, struct panel_drv_data, dssdev)
@@ -90,7 +90,7 @@ static int opa362_enable(struct omap_dss_device *dssdev)
         if (omapdss_device_is_enabled(dssdev))
                 return 0;
 
-        in->ops.atv->set_timings(in, &ddata->timings);
+        in->ops.atv->set_timings(in, &ddata->vm);
 
         r = in->ops.atv->enable(in);
         if (r)
@@ -123,38 +123,38 @@ static void opa362_disable(struct omap_dss_device *dssdev)
 }
 
 static void opa362_set_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                               struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
         dev_dbg(dssdev->dev, "set_timings\n");
 
-        ddata->timings = *timings;
-        dssdev->panel.timings = *timings;
+        ddata->vm = *vm;
+        dssdev->panel.vm = *vm;
 
-        in->ops.atv->set_timings(in, timings);
+        in->ops.atv->set_timings(in, vm);
 }
 
 static void opa362_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                               struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
 
         dev_dbg(dssdev->dev, "get_timings\n");
 
-        *timings = ddata->timings;
+        *vm = ddata->vm;
 }
 
 static int opa362_check_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
         dev_dbg(dssdev->dev, "check_timings\n");
 
-        return in->ops.atv->check_timings(in, timings);
+        return in->ops.atv->check_timings(in, vm);
 }
 
 static void opa362_set_type(struct omap_dss_device *dssdev,
diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
index d768217cefe0..13e32d02c884 100644
--- a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
+++ b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
@@ -24,7 +24,7 @@ struct panel_drv_data {
         int pd_gpio;
         int data_lines;
 
-        struct omap_video_timings timings;
+        struct videomode vm;
 };
 
 #define to_panel_data(x) container_of(x, struct panel_drv_data, dssdev)
@@ -81,7 +81,7 @@ static int tfp410_enable(struct omap_dss_device *dssdev)
         if (omapdss_device_is_enabled(dssdev))
                 return 0;
 
-        in->ops.dpi->set_timings(in, &ddata->timings);
+        in->ops.dpi->set_timings(in, &ddata->vm);
         if (ddata->data_lines)
                 in->ops.dpi->set_data_lines(in, ddata->data_lines);
 
@@ -113,44 +113,43 @@ static void tfp410_disable(struct omap_dss_device *dssdev)
         dssdev->state = OMAP_DSS_DISPLAY_DISABLED;
 }
 
-static void tfp410_fix_timings(struct omap_video_timings *timings)
+static void tfp410_fix_timings(struct videomode *vm)
 {
-        timings->data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE;
-        timings->sync_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE;
-        timings->de_level = OMAPDSS_SIG_ACTIVE_HIGH;
+        vm->flags |= DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
+                     DISPLAY_FLAGS_SYNC_POSEDGE;
 }
 
 static void tfp410_set_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                               struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        tfp410_fix_timings(timings);
+        tfp410_fix_timings(vm);
 
-        ddata->timings = *timings;
-        dssdev->panel.timings = *timings;
+        ddata->vm = *vm;
+        dssdev->panel.vm = *vm;
 
-        in->ops.dpi->set_timings(in, timings);
+        in->ops.dpi->set_timings(in, vm);
 }
 
 static void tfp410_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                               struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
 
-        *timings = ddata->timings;
+        *vm = ddata->vm;
 }
 
 static int tfp410_check_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        tfp410_fix_timings(timings);
+        tfp410_fix_timings(vm);
 
-        return in->ops.dpi->check_timings(in, timings);
+        return in->ops.dpi->check_timings(in, vm);
 }
 
 static const struct omapdss_dvi_ops tfp410_dvi_ops = {
diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c b/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c
index 46855c8f5cbf..6d8f79b29af6 100644
--- a/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c
+++ b/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c
@@ -26,7 +26,7 @@ struct panel_drv_data {
         struct gpio_desc *ls_oe_gpio;
         struct gpio_desc *hpd_gpio;
 
-        struct omap_video_timings timings;
+        struct videomode vm;
 };
 
 #define to_panel_data(x) container_of(x, struct panel_drv_data, dssdev)
@@ -80,7 +80,7 @@ static int tpd_enable(struct omap_dss_device *dssdev)
         if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
                 return 0;
 
-        in->ops.hdmi->set_timings(in, &ddata->timings);
+        in->ops.hdmi->set_timings(in, &ddata->vm);
 
         r = in->ops.hdmi->enable(in);
         if (r)
@@ -105,33 +105,33 @@ static void tpd_disable(struct omap_dss_device *dssdev)
 }
 
 static void tpd_set_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                            struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        ddata->timings = *timings;
-        dssdev->panel.timings = *timings;
+        ddata->vm = *vm;
+        dssdev->panel.vm = *vm;
 
-        in->ops.hdmi->set_timings(in, timings);
+        in->ops.hdmi->set_timings(in, vm);
 }
 
 static void tpd_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                            struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
 
-        *timings = ddata->timings;
+        *vm = ddata->vm;
 }
 
 static int tpd_check_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                             struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
         int r;
 
-        r = in->ops.hdmi->check_timings(in, timings);
+        r = in->ops.hdmi->check_timings(in, vm);
 
         return r;
 }
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
index 7f16f985ab22..38003208d9ca 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
@@ -28,7 +28,7 @@ struct panel_drv_data {
 
         int data_lines;
 
-        struct omap_video_timings videomode;
+        struct videomode vm;
 
         /* used for non-DT boot, to be removed */
         int backlight_gpio;
@@ -80,7 +80,7 @@ static int panel_dpi_enable(struct omap_dss_device *dssdev)
 
         if (ddata->data_lines)
                 in->ops.dpi->set_data_lines(in, ddata->data_lines);
-        in->ops.dpi->set_timings(in, &ddata->videomode);
+        in->ops.dpi->set_timings(in, &ddata->vm);
 
         r = in->ops.dpi->enable(in);
         if (r)
@@ -122,32 +122,32 @@ static void panel_dpi_disable(struct omap_dss_device *dssdev)
 }
 
 static void panel_dpi_set_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                  struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        ddata->videomode = *timings;
-        dssdev->panel.timings = *timings;
+        ddata->vm = *vm;
+        dssdev->panel.vm = *vm;
 
-        in->ops.dpi->set_timings(in, timings);
+        in->ops.dpi->set_timings(in, vm);
 }
 
 static void panel_dpi_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                  struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
 
-        *timings = ddata->videomode;
+        *vm = ddata->vm;
 }
 
 static int panel_dpi_check_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                   struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        return in->ops.dpi->check_timings(in, timings);
+        return in->ops.dpi->check_timings(in, vm);
 }
 
 static struct omap_dss_driver panel_dpi_ops = {
@@ -169,7 +169,6 @@ static int panel_dpi_probe_pdata(struct platform_device *pdev)
         const struct panel_dpi_platform_data *pdata;
         struct panel_drv_data *ddata = platform_get_drvdata(pdev);
         struct omap_dss_device *dssdev, *in;
-        struct videomode vm;
         int r;
 
         pdata = dev_get_platdata(&pdev->dev);
@@ -185,8 +184,7 @@ static int panel_dpi_probe_pdata(struct platform_device *pdev)
 
         ddata->data_lines = pdata->data_lines;
 
-        videomode_from_timing(pdata->display_timing, &vm);
-        videomode_to_omap_video_timings(&vm, &ddata->videomode);
+        videomode_from_timing(pdata->display_timing, &ddata->vm);
 
         dssdev = &ddata->dssdev;
         dssdev->name = pdata->name;
@@ -214,7 +212,6 @@ static int panel_dpi_probe_of(struct platform_device *pdev)
         struct omap_dss_device *in;
         int r;
         struct display_timing timing;
-        struct videomode vm;
         struct gpio_desc *gpio;
 
         gpio = devm_gpiod_get_optional(&pdev->dev, "enable", GPIOD_OUT_LOW);
@@ -245,8 +242,7 @@ static int panel_dpi_probe_of(struct platform_device *pdev)
                 return r;
         }
 
-        videomode_from_timing(&timing, &vm);
-        videomode_to_omap_video_timings(&vm, &ddata->videomode);
+        videomode_from_timing(&timing, &ddata->vm);
 
         in = omapdss_of_find_source_for_first_ep(node);
         if (IS_ERR(in)) {
@@ -295,7 +291,7 @@ static int panel_dpi_probe(struct platform_device *pdev)
         dssdev->driver = &panel_dpi_ops;
         dssdev->type = OMAP_DISPLAY_TYPE_DPI;
         dssdev->owner = THIS_MODULE;
-        dssdev->panel.timings = ddata->videomode;
+        dssdev->panel.vm = ddata->vm;
         dssdev->phy.dpi.data_lines = ddata->data_lines;
 
         r = omapdss_register_display(dssdev);
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
index b1f3b818edf4..dc026a843712 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
@@ -42,7 +42,7 @@ struct panel_drv_data {
         struct omap_dss_device dssdev;
         struct omap_dss_device *in;
 
-        struct omap_video_timings timings;
+        struct videomode vm;
 
         struct platform_device *pdev;
 
@@ -382,8 +382,8 @@ static const struct backlight_ops dsicm_bl_ops = {
 static void dsicm_get_resolution(struct omap_dss_device *dssdev,
                 u16 *xres, u16 *yres)
 {
-        *xres = dssdev->panel.timings.x_res;
-        *yres = dssdev->panel.timings.y_res;
+        *xres = dssdev->panel.vm.hactive;
+        *yres = dssdev->panel.vm.vactive;
 }
 
 static ssize_t dsicm_num_errors_show(struct device *dev,
@@ -589,7 +589,7 @@ static int dsicm_power_on(struct panel_drv_data *ddata)
         struct omap_dss_dsi_config dsi_config = {
                 .mode = OMAP_DSS_DSI_CMD_MODE,
                 .pixel_format = OMAP_DSS_DSI_FMT_RGB888,
-                .timings = &ddata->timings,
+                .vm = &ddata->vm,
                 .hs_clk_min = 150000000,
                 .hs_clk_max = 300000000,
                 .lp_clk_min = 7000000,
@@ -892,8 +892,8 @@ static int dsicm_update(struct omap_dss_device *dssdev,
 
         /* XXX no need to send this every frame, but dsi break if not done */
         r = dsicm_set_update_window(ddata, 0, 0,
-                        dssdev->panel.timings.x_res,
-                        dssdev->panel.timings.y_res);
+                        dssdev->panel.vm.hactive,
+                        dssdev->panel.vm.vactive);
         if (r)
                 goto err;
 
@@ -1023,9 +1023,8 @@ static int dsicm_memory_read(struct omap_dss_device *dssdev,
                 goto err1;
         }
 
-        size = min(w * h * 3,
-                        dssdev->panel.timings.x_res *
-                        dssdev->panel.timings.y_res * 3);
+        size = min((u32)w * h * 3,
+                   dssdev->panel.vm.hactive * dssdev->panel.vm.vactive * 3);
 
         in->ops.dsi->bus_lock(in);
 
@@ -1186,14 +1185,14 @@ static int dsicm_probe(struct platform_device *pdev)
         if (r)
                 return r;
 
-        ddata->timings.x_res = 864;
-        ddata->timings.y_res = 480;
-        ddata->timings.pixelclock = 864 * 480 * 60;
+        ddata->vm.hactive = 864;
+        ddata->vm.vactive = 480;
+        ddata->vm.pixelclock = 864 * 480 * 60;
 
         dssdev = &ddata->dssdev;
         dssdev->dev = dev;
         dssdev->driver = &dsicm_ops;
-        dssdev->panel.timings = ddata->timings;
+        dssdev->panel.vm = ddata->vm;
         dssdev->type = OMAP_DISPLAY_TYPE_DSI;
         dssdev->owner = THIS_MODULE;
 
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
index 6dfb96cea293..43d21edb51f5 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
@@ -19,25 +19,28 @@
 
 #include "../dss/omapdss.h"
 
-static struct omap_video_timings lb035q02_timings = {
-        .x_res = 320,
-        .y_res = 240,
+static struct videomode lb035q02_vm = {
+        .hactive = 320,
+        .vactive = 240,
 
         .pixelclock     = 6500000,
 
-        .hsw            = 2,
-        .hfp            = 20,
-        .hbp            = 68,
-
-        .vsw            = 2,
-        .vfp            = 4,
-        .vbp            = 18,
-
-        .vsync_level    = OMAPDSS_SIG_ACTIVE_LOW,
-        .hsync_level    = OMAPDSS_SIG_ACTIVE_LOW,
-        .data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE,
-        .de_level       = OMAPDSS_SIG_ACTIVE_HIGH,
-        .sync_pclk_edge = OMAPDSS_DRIVE_SIG_FALLING_EDGE,
+        .hsync_len      = 2,
+        .hfront_porch   = 20,
+        .hback_porch    = 68,
+
+        .vsync_len      = 2,
+        .vfront_porch   = 4,
+        .vback_porch    = 18,
+
+        .flags          = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+                          DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_SYNC_NEGEDGE |
+                          DISPLAY_FLAGS_PIXDATA_POSEDGE,
+        /*
+         * Note: According to the panel documentation:
+         * DE is active LOW
+         * DATA needs to be driven on the FALLING edge
+         */
 };
 
 struct panel_drv_data {
@@ -48,7 +51,7 @@ struct panel_drv_data {
 
         int data_lines;
 
-        struct omap_video_timings videomode;
+        struct videomode vm;
 
         struct gpio_desc *enable_gpio;
 };
@@ -158,7 +161,7 @@ static int lb035q02_enable(struct omap_dss_device *dssdev)
 
         if (ddata->data_lines)
                 in->ops.dpi->set_data_lines(in, ddata->data_lines);
-        in->ops.dpi->set_timings(in, &ddata->videomode);
+        in->ops.dpi->set_timings(in, &ddata->vm);
 
         r = in->ops.dpi->enable(in);
         if (r)
@@ -189,32 +192,32 @@ static void lb035q02_disable(struct omap_dss_device *dssdev)
 }
 
 static void lb035q02_set_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                 struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        ddata->videomode = *timings;
-        dssdev->panel.timings = *timings;
+        ddata->vm = *vm;
+        dssdev->panel.vm = *vm;
 
-        in->ops.dpi->set_timings(in, timings);
+        in->ops.dpi->set_timings(in, vm);
 }
 
 static void lb035q02_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                 struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
 
-        *timings = ddata->videomode;
+        *vm = ddata->vm;
 }
 
 static int lb035q02_check_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                  struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        return in->ops.dpi->check_timings(in, timings);
+        return in->ops.dpi->check_timings(in, vm);
 }
 
 static struct omap_dss_driver lb035q02_ops = {
@@ -278,14 +281,14 @@ static int lb035q02_panel_spi_probe(struct spi_device *spi)
         if (r)
                 return r;
 
-        ddata->videomode = lb035q02_timings;
+        ddata->vm = lb035q02_vm;
 
         dssdev = &ddata->dssdev;
         dssdev->dev = &spi->dev;
         dssdev->driver = &lb035q02_ops;
         dssdev->type = OMAP_DISPLAY_TYPE_DPI;
         dssdev->owner = THIS_MODULE;
-        dssdev->panel.timings = ddata->videomode;
+        dssdev->panel.vm = ddata->vm;
         dssdev->phy.dpi.data_lines = ddata->data_lines;
 
         r = omapdss_register_display(dssdev);
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c b/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c
index 9f3d6f48f3e1..2de27ba01552 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c
@@ -23,7 +23,7 @@ struct panel_drv_data {
         struct omap_dss_device  dssdev;
         struct omap_dss_device *in;
 
-        struct omap_video_timings videomode;
+        struct videomode vm;
 
         int data_lines;
 
@@ -65,22 +65,20 @@ static const struct {
         { 156, 0x00 }, { 157, 0x00 }, { 2, 0x00 },
 };
 
-static const struct omap_video_timings nec_8048_panel_timings = {
-        .x_res          = LCD_XRES,
-        .y_res          = LCD_YRES,
+static const struct videomode nec_8048_panel_vm = {
+        .hactive        = LCD_XRES,
+        .vactive        = LCD_YRES,
         .pixelclock     = LCD_PIXEL_CLOCK,
-        .hfp            = 6,
-        .hsw            = 1,
-        .hbp            = 4,
-        .vfp            = 3,
-        .vsw            = 1,
-        .vbp            = 4,
-
-        .vsync_level    = OMAPDSS_SIG_ACTIVE_LOW,
-        .hsync_level    = OMAPDSS_SIG_ACTIVE_LOW,
-        .data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE,
-        .de_level       = OMAPDSS_SIG_ACTIVE_HIGH,
-        .sync_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE,
+        .hfront_porch   = 6,
+        .hsync_len      = 1,
+        .hback_porch    = 4,
+        .vfront_porch   = 3,
+        .vsync_len      = 1,
+        .vback_porch    = 4,
+
+        .flags          = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+                          DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_SYNC_POSEDGE |
+                          DISPLAY_FLAGS_PIXDATA_POSEDGE,
 };
 
 #define to_panel_data(p) container_of(p, struct panel_drv_data, dssdev)
@@ -157,7 +155,7 @@ static int nec_8048_enable(struct omap_dss_device *dssdev)
 
         if (ddata->data_lines)
                 in->ops.dpi->set_data_lines(in, ddata->data_lines);
-        in->ops.dpi->set_timings(in, &ddata->videomode);
+        in->ops.dpi->set_timings(in, &ddata->vm);
 
         r = in->ops.dpi->enable(in);
         if (r)
@@ -188,32 +186,32 @@ static void nec_8048_disable(struct omap_dss_device *dssdev)
 }
 
 static void nec_8048_set_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                 struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        ddata->videomode = *timings;
-        dssdev->panel.timings = *timings;
+        ddata->vm = *vm;
+        dssdev->panel.vm = *vm;
 
-        in->ops.dpi->set_timings(in, timings);
+        in->ops.dpi->set_timings(in, vm);
 }
 
 static void nec_8048_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                 struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
 
-        *timings = ddata->videomode;
+        *vm = ddata->vm;
 }
 
 static int nec_8048_check_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                  struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        return in->ops.dpi->check_timings(in, timings);
+        return in->ops.dpi->check_timings(in, vm);
 }
 
 static struct omap_dss_driver nec_8048_ops = {
@@ -306,14 +304,14 @@ static int nec_8048_probe(struct spi_device *spi)
                         goto err_gpio;
         }
 
-        ddata->videomode = nec_8048_panel_timings;
+        ddata->vm = nec_8048_panel_vm;
 
         dssdev = &ddata->dssdev;
         dssdev->dev = &spi->dev;
         dssdev->driver = &nec_8048_ops;
         dssdev->type = OMAP_DISPLAY_TYPE_DPI;
         dssdev->owner = THIS_MODULE;
-        dssdev->panel.timings = ddata->videomode;
+        dssdev->panel.vm = ddata->vm;
 
         r = omapdss_register_display(dssdev);
         if (r) {
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c b/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
index 3d3efc561ea9..04fe235b7cac 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
@@ -26,7 +26,7 @@ struct panel_drv_data {
 
         int data_lines;
 
-        struct omap_video_timings videomode;
+        struct videomode vm;
 
         struct gpio_desc *resb_gpio;    /* low = reset active min 20 us */
         struct gpio_desc *ini_gpio;     /* high = power on */
@@ -35,25 +35,27 @@ struct panel_drv_data {
         struct gpio_desc *ud_gpio;      /* high = conventional vertical scanning */
 };
 
-static const struct omap_video_timings sharp_ls_timings = {
-        .x_res = 480,
-        .y_res = 640,
+static const struct videomode sharp_ls_vm = {
+        .hactive = 480,
+        .vactive = 640,
 
         .pixelclock     = 19200000,
 
-        .hsw            = 2,
-        .hfp            = 1,
-        .hbp            = 28,
-
-        .vsw            = 1,
-        .vfp            = 1,
-        .vbp            = 1,
-
-        .vsync_level    = OMAPDSS_SIG_ACTIVE_LOW,
-        .hsync_level    = OMAPDSS_SIG_ACTIVE_LOW,
-        .data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE,
-        .de_level       = OMAPDSS_SIG_ACTIVE_HIGH,
-        .sync_pclk_edge = OMAPDSS_DRIVE_SIG_FALLING_EDGE,
+        .hsync_len      = 2,
+        .hfront_porch   = 1,
+        .hback_porch    = 28,
+
+        .vsync_len      = 1,
+        .vfront_porch   = 1,
+        .vback_porch    = 1,
+
+        .flags          = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+                          DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_SYNC_NEGEDGE |
+                          DISPLAY_FLAGS_PIXDATA_POSEDGE,
+        /*
+         * Note: According to the panel documentation:
+         * DATA needs to be driven on the FALLING edge
+         */
 };
 
 #define to_panel_data(p) container_of(p, struct panel_drv_data, dssdev)
@@ -99,7 +101,7 @@ static int sharp_ls_enable(struct omap_dss_device *dssdev)
 
         if (ddata->data_lines)
                 in->ops.dpi->set_data_lines(in, ddata->data_lines);
-        in->ops.dpi->set_timings(in, &ddata->videomode);
+        in->ops.dpi->set_timings(in, &ddata->vm);
 
         if (ddata->vcc) {
                 r = regulator_enable(ddata->vcc);
@@ -154,32 +156,32 @@ static void sharp_ls_disable(struct omap_dss_device *dssdev)
 }
 
 static void sharp_ls_set_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                 struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        ddata->videomode = *timings;
-        dssdev->panel.timings = *timings;
+        ddata->vm = *vm;
+        dssdev->panel.vm = *vm;
 
-        in->ops.dpi->set_timings(in, timings);
+        in->ops.dpi->set_timings(in, vm);
 }
 
 static void sharp_ls_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                 struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
 
-        *timings = ddata->videomode;
+        *vm = ddata->vm;
 }
 
 static int sharp_ls_check_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                  struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        return in->ops.dpi->check_timings(in, timings);
+        return in->ops.dpi->check_timings(in, vm);
 }
 
 static struct omap_dss_driver sharp_ls_ops = {
@@ -279,14 +281,14 @@ static int sharp_ls_probe(struct platform_device *pdev)
         if (r)
                 return r;
 
-        ddata->videomode = sharp_ls_timings;
+        ddata->vm = sharp_ls_vm;
 
         dssdev = &ddata->dssdev;
         dssdev->dev = &pdev->dev;
         dssdev->driver = &sharp_ls_ops;
         dssdev->type = OMAP_DISPLAY_TYPE_DPI;
         dssdev->owner = THIS_MODULE;
-        dssdev->panel.timings = ddata->videomode;
+        dssdev->panel.vm = ddata->vm;
         dssdev->phy.dpi.data_lines = ddata->data_lines;
 
         r = omapdss_register_display(dssdev);
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c b/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c
index 3557a4c7dd7b..746cb8d9cba1 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c
@@ -71,7 +71,7 @@ struct panel_drv_data {
         int reset_gpio;
         int datapairs;
 
-        struct omap_video_timings videomode;
+        struct videomode vm;
 
         char            *name;
         int             enabled;
@@ -92,23 +92,20 @@ struct panel_drv_data {
         struct backlight_device *bl_dev;
 };
 
-static const struct omap_video_timings acx565akm_panel_timings = {
-        .x_res          = 800,
-        .y_res          = 480,
+static const struct videomode acx565akm_panel_vm = {
+        .hactive        = 800,
+        .vactive        = 480,
         .pixelclock     = 24000000,
-        .hfp            = 28,
-        .hsw            = 4,
-        .hbp            = 24,
-        .vfp            = 3,
-        .vsw            = 3,
-        .vbp            = 4,
-
-        .vsync_level    = OMAPDSS_SIG_ACTIVE_LOW,
-        .hsync_level    = OMAPDSS_SIG_ACTIVE_LOW,
-
-        .data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE,
-        .de_level       = OMAPDSS_SIG_ACTIVE_HIGH,
-        .sync_pclk_edge = OMAPDSS_DRIVE_SIG_FALLING_EDGE,
+        .hfront_porch   = 28,
+        .hsync_len      = 4,
+        .hback_porch    = 24,
+        .vfront_porch   = 3,
+        .vsync_len      = 3,
+        .vback_porch    = 4,
+
+        .flags          = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+                          DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_SYNC_NEGEDGE |
+                          DISPLAY_FLAGS_PIXDATA_POSEDGE,
 };
 
 #define to_panel_data(p) container_of(p, struct panel_drv_data, dssdev)
@@ -548,7 +545,7 @@ static int acx565akm_panel_power_on(struct omap_dss_device *dssdev)
 
         dev_dbg(&ddata->spi->dev, "%s\n", __func__);
 
-        in->ops.sdi->set_timings(in, &ddata->videomode);
+        in->ops.sdi->set_timings(in, &ddata->vm);
 
         if (ddata->datapairs > 0)
                 in->ops.sdi->set_datapairs(in, ddata->datapairs);
@@ -662,32 +659,32 @@ static void acx565akm_disable(struct omap_dss_device *dssdev)
 }
 
 static void acx565akm_set_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                  struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        ddata->videomode = *timings;
-        dssdev->panel.timings = *timings;
+        ddata->vm = *vm;
+        dssdev->panel.vm = *vm;
 
-        in->ops.sdi->set_timings(in, timings);
+        in->ops.sdi->set_timings(in, vm);
 }
 
 static void acx565akm_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                  struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
 
-        *timings = ddata->videomode;
+        *vm = ddata->vm;
 }
 
 static int acx565akm_check_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                   struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        return in->ops.sdi->check_timings(in, timings);
+        return in->ops.sdi->check_timings(in, vm);
 }
 
 static struct omap_dss_driver acx565akm_ops = {
@@ -845,14 +842,14 @@ static int acx565akm_probe(struct spi_device *spi)
         acx565akm_bl_update_status(bldev);
 
 
-        ddata->videomode = acx565akm_panel_timings;
+        ddata->vm = acx565akm_panel_vm;
 
         dssdev = &ddata->dssdev;
         dssdev->dev = &spi->dev;
         dssdev->driver = &acx565akm_ops;
         dssdev->type = OMAP_DISPLAY_TYPE_SDI;
         dssdev->owner = THIS_MODULE;
-        dssdev->panel.timings = ddata->videomode;
+        dssdev->panel.vm = ddata->vm;
 
         r = omapdss_register_display(dssdev);
         if (r) {
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c
index e859b3f893f7..f313dbfcbacb 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c
@@ -37,28 +37,29 @@ struct panel_drv_data {
 
         int data_lines;
 
-        struct omap_video_timings videomode;
+        struct videomode vm;
 
         struct spi_device *spi_dev;
 };
 
-static struct omap_video_timings td028ttec1_panel_timings = {
-        .x_res          = 480,
-        .y_res          = 640,
+static struct videomode td028ttec1_panel_vm = {
+        .hactive        = 480,
+        .vactive        = 640,
         .pixelclock     = 22153000,
-        .hfp            = 24,
-        .hsw            = 8,
-        .hbp            = 8,
-        .vfp            = 4,
-        .vsw            = 2,
-        .vbp            = 2,
-
-        .vsync_level    = OMAPDSS_SIG_ACTIVE_LOW,
-        .hsync_level    = OMAPDSS_SIG_ACTIVE_LOW,
-
-        .data_pclk_edge = OMAPDSS_DRIVE_SIG_FALLING_EDGE,
-        .de_level       = OMAPDSS_SIG_ACTIVE_HIGH,
-        .sync_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE,
+        .hfront_porch   = 24,
+        .hsync_len      = 8,
+        .hback_porch    = 8,
+        .vfront_porch   = 4,
+        .vsync_len      = 2,
+        .vback_porch    = 2,
+
+        .flags          = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+                          DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_SYNC_POSEDGE |
+                          DISPLAY_FLAGS_PIXDATA_NEGEDGE,
+        /*
+         * Note: According to the panel documentation:
+         * SYNC needs to be driven on the FALLING edge
+         */
 };
 
 #define JBT_COMMAND     0x000
@@ -208,7 +209,7 @@ static int td028ttec1_panel_enable(struct omap_dss_device *dssdev)
 
         if (ddata->data_lines)
                 in->ops.dpi->set_data_lines(in, ddata->data_lines);
-        in->ops.dpi->set_timings(in, &ddata->videomode);
+        in->ops.dpi->set_timings(in, &ddata->vm);
 
         r = in->ops.dpi->enable(in);
         if (r)
@@ -325,32 +326,32 @@ static void td028ttec1_panel_disable(struct omap_dss_device *dssdev)
 }
 
 static void td028ttec1_panel_set_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                         struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        ddata->videomode = *timings;
-        dssdev->panel.timings = *timings;
+        ddata->vm = *vm;
+        dssdev->panel.vm = *vm;
 
-        in->ops.dpi->set_timings(in, timings);
+        in->ops.dpi->set_timings(in, vm);
 }
 
 static void td028ttec1_panel_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                         struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
 
-        *timings = ddata->videomode;
+        *vm = ddata->vm;
 }
 
 static int td028ttec1_panel_check_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                          struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        return in->ops.dpi->check_timings(in, timings);
+        return in->ops.dpi->check_timings(in, vm);
 }
 
 static struct omap_dss_driver td028ttec1_ops = {
@@ -414,14 +415,14 @@ static int td028ttec1_panel_probe(struct spi_device *spi)
         if (r)
                 return r;
 
-        ddata->videomode = td028ttec1_panel_timings;
+        ddata->vm = td028ttec1_panel_vm;
 
         dssdev = &ddata->dssdev;
         dssdev->dev = &spi->dev;
         dssdev->driver = &td028ttec1_ops;
         dssdev->type = OMAP_DISPLAY_TYPE_DPI;
         dssdev->owner = THIS_MODULE;
-        dssdev->panel.timings = ddata->videomode;
+        dssdev->panel.vm = ddata->vm;
         dssdev->phy.dpi.data_lines = ddata->data_lines;
 
         r = omapdss_register_display(dssdev);
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c
index 66c6bbe6472b..0787dba44faa 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c
@@ -56,7 +56,7 @@ struct panel_drv_data {
         struct omap_dss_device  dssdev;
         struct omap_dss_device *in;
 
-        struct omap_video_timings videomode;
+        struct videomode vm;
 
         int data_lines;
 
@@ -72,25 +72,27 @@ struct panel_drv_data {
         u32 power_on_resume:1;
 };
 
-static const struct omap_video_timings tpo_td043_timings = {
-        .x_res          = 800,
-        .y_res          = 480,
+static const struct videomode tpo_td043_vm = {
+        .hactive        = 800,
+        .vactive        = 480,
 
         .pixelclock     = 36000000,
 
-        .hsw            = 1,
-        .hfp            = 68,
-        .hbp            = 214,
+        .hsync_len      = 1,
+        .hfront_porch   = 68,
+        .hback_porch    = 214,
 
-        .vsw            = 1,
-        .vfp            = 39,
-        .vbp            = 34,
+        .vsync_len      = 1,
+        .vfront_porch   = 39,
+        .vback_porch    = 34,
 
-        .vsync_level    = OMAPDSS_SIG_ACTIVE_LOW,
-        .hsync_level    = OMAPDSS_SIG_ACTIVE_LOW,
-        .data_pclk_edge = OMAPDSS_DRIVE_SIG_FALLING_EDGE,
-        .de_level       = OMAPDSS_SIG_ACTIVE_HIGH,
-        .sync_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE,
+        .flags          = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+                          DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_SYNC_POSEDGE |
+                          DISPLAY_FLAGS_PIXDATA_NEGEDGE,
+        /*
+         * Note: According to the panel documentation:
+         * SYNC needs to be driven on the FALLING edge
+         */
 };
 
 #define to_panel_data(p) container_of(p, struct panel_drv_data, dssdev)
@@ -378,7 +380,7 @@ static int tpo_td043_enable(struct omap_dss_device *dssdev)
 
         if (ddata->data_lines)
                 in->ops.dpi->set_data_lines(in, ddata->data_lines);
-        in->ops.dpi->set_timings(in, &ddata->videomode);
+        in->ops.dpi->set_timings(in, &ddata->vm);
 
         r = in->ops.dpi->enable(in);
         if (r)
@@ -418,32 +420,32 @@ static void tpo_td043_disable(struct omap_dss_device *dssdev)
 }
 
 static void tpo_td043_set_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                  struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        ddata->videomode = *timings;
-        dssdev->panel.timings = *timings;
+        ddata->vm = *vm;
+        dssdev->panel.vm = *vm;
 
-        in->ops.dpi->set_timings(in, timings);
+        in->ops.dpi->set_timings(in, vm);
 }
 
 static void tpo_td043_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                  struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
 
-        *timings = ddata->videomode;
+        *vm = ddata->vm;
 }
 
 static int tpo_td043_check_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                   struct videomode *vm)
 {
         struct panel_drv_data *ddata = to_panel_data(dssdev);
         struct omap_dss_device *in = ddata->in;
 
-        return in->ops.dpi->check_timings(in, timings);
+        return in->ops.dpi->check_timings(in, vm);
 }
 
 static struct omap_dss_driver tpo_td043_ops = {
@@ -546,14 +548,14 @@ static int tpo_td043_probe(struct spi_device *spi)
                 goto err_sysfs;
         }
 
-        ddata->videomode = tpo_td043_timings;
+        ddata->vm = tpo_td043_vm;
 
         dssdev = &ddata->dssdev;
         dssdev->dev = &spi->dev;
         dssdev->driver = &tpo_td043_ops;
         dssdev->type = OMAP_DISPLAY_TYPE_DPI;
         dssdev->owner = THIS_MODULE;
-        dssdev->panel.timings = ddata->videomode;
+        dssdev->panel.vm = ddata->vm;
 
         r = omapdss_register_display(dssdev);
         if (r) {
diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c
index 535240fba671..c839f6456db2 100644
--- a/drivers/gpu/drm/omapdrm/dss/dispc.c
+++ b/drivers/gpu/drm/omapdrm/dss/dispc.c
@@ -75,7 +75,7 @@ struct dispc_features {
         unsigned long max_lcd_pclk;
         unsigned long max_tv_pclk;
         int (*calc_scaling) (unsigned long pclk, unsigned long lclk,
-                const struct omap_video_timings *mgr_timings,
+                const struct videomode *vm,
                 u16 width, u16 height, u16 out_width, u16 out_height,
                 enum omap_color_mode color_mode, bool *five_taps,
                 int *x_predecim, int *y_predecim, int *decim_x, int *decim_y,
@@ -1679,7 +1679,7 @@ static void dispc_ovl_set_scaling_uv(enum omap_plane plane,
 {
         int scale_x = out_width != orig_width;
         int scale_y = out_height != orig_height;
-        bool chroma_upscale = plane != OMAP_DSS_WB ? true : false;
+        bool chroma_upscale = plane != OMAP_DSS_WB;
 
         if (!dss_has_feature(FEAT_HANDLE_UV_SEPARATE))
                 return;
@@ -2179,7 +2179,7 @@ static void calc_tiler_rotation_offset(u16 screen_width, u16 width,
  * undocumented horizontal position and timing related limitations.
  */
 static int check_horiz_timing_omap3(unsigned long pclk, unsigned long lclk,
-                const struct omap_video_timings *t, u16 pos_x,
+                const struct videomode *vm, u16 pos_x,
                 u16 width, u16 height, u16 out_width, u16 out_height,
                 bool five_taps)
 {
@@ -2189,14 +2189,16 @@ static int check_horiz_timing_omap3(unsigned long pclk, unsigned long lclk,
         u64 val, blank;
         int i;
 
-        nonactive = t->x_res + t->hfp + t->hsw + t->hbp - out_width;
+        nonactive = vm->hactive + vm->hfront_porch + vm->hsync_len +
+                    vm->hback_porch - out_width;
 
         i = 0;
         if (out_height < height)
                 i++;
         if (out_width < width)
                 i++;
-        blank = div_u64((u64)(t->hbp + t->hsw + t->hfp) * lclk, pclk);
+        blank = div_u64((u64)(vm->hback_porch + vm->hsync_len + vm->hfront_porch) *
+                        lclk, pclk);
         DSSDBG("blanking period + ppl = %llu (limit = %u)\n", blank, limits[i]);
         if (blank <= limits[i])
                 return -EINVAL;
@@ -2231,7 +2233,7 @@ static int check_horiz_timing_omap3(unsigned long pclk, unsigned long lclk,
 }
 
 static unsigned long calc_core_clk_five_taps(unsigned long pclk,
-                const struct omap_video_timings *mgr_timings, u16 width,
+                const struct videomode *vm, u16 width,
                 u16 height, u16 out_width, u16 out_height,
                 enum omap_color_mode color_mode)
 {
@@ -2242,7 +2244,7 @@ static unsigned long calc_core_clk_five_taps(unsigned long pclk,
                 return (unsigned long) pclk;
 
         if (height > out_height) {
-                unsigned int ppl = mgr_timings->x_res;
+                unsigned int ppl = vm->hactive;
 
                 tmp = (u64)pclk * height * out_width;
                 do_div(tmp, 2 * out_height * ppl);
@@ -2324,7 +2326,7 @@ static unsigned long calc_core_clk_44xx(unsigned long pclk, u16 width,
 }
 
 static int dispc_ovl_calc_scaling_24xx(unsigned long pclk, unsigned long lclk,
-                const struct omap_video_timings *mgr_timings,
+                const struct videomode *vm,
                 u16 width, u16 height, u16 out_width, u16 out_height,
                 enum omap_color_mode color_mode, bool *five_taps,
                 int *x_predecim, int *y_predecim, int *decim_x, int *decim_y,
@@ -2370,7 +2372,7 @@ static int dispc_ovl_calc_scaling_24xx(unsigned long pclk, unsigned long lclk,
 }
 
 static int dispc_ovl_calc_scaling_34xx(unsigned long pclk, unsigned long lclk,
-                const struct omap_video_timings *mgr_timings,
+                const struct videomode *vm,
                 u16 width, u16 height, u16 out_width, u16 out_height,
                 enum omap_color_mode color_mode, bool *five_taps,
                 int *x_predecim, int *y_predecim, int *decim_x, int *decim_y,
@@ -2392,7 +2394,7 @@ static int dispc_ovl_calc_scaling_34xx(unsigned long pclk, unsigned long lclk,
                                 *five_taps = false;
 again:
                 if (*five_taps)
-                        *core_clk = calc_core_clk_five_taps(pclk, mgr_timings,
+                        *core_clk = calc_core_clk_five_taps(pclk, vm,
                                                 in_width, in_height, out_width,
                                                 out_height, color_mode);
                 else
@@ -2400,7 +2402,7 @@ again:
                                         in_height, out_width, out_height,
                                         mem_to_mem);
 
-                error = check_horiz_timing_omap3(pclk, lclk, mgr_timings,
+                error = check_horiz_timing_omap3(pclk, lclk, vm,
                                 pos_x, in_width, in_height, out_width,
                                 out_height, *five_taps);
                 if (error && *five_taps) {
@@ -2435,7 +2437,7 @@ again:
                 return -EINVAL;
         }
 
-        if (check_horiz_timing_omap3(pclk, lclk, mgr_timings, pos_x, in_width,
+        if (check_horiz_timing_omap3(pclk, lclk, vm, pos_x, in_width,
                                 in_height, out_width, out_height, *five_taps)) {
                         DSSERR("horizontal timing too tight\n");
                         return -EINVAL;
@@ -2455,7 +2457,7 @@ again:
 }
 
 static int dispc_ovl_calc_scaling_44xx(unsigned long pclk, unsigned long lclk,
-                const struct omap_video_timings *mgr_timings,
+                const struct videomode *vm,
                 u16 width, u16 height, u16 out_width, u16 out_height,
                 enum omap_color_mode color_mode, bool *five_taps,
                 int *x_predecim, int *y_predecim, int *decim_x, int *decim_y,
@@ -2501,7 +2503,7 @@ static int dispc_ovl_calc_scaling_44xx(unsigned long pclk, unsigned long lclk,
 
 static int dispc_ovl_calc_scaling(unsigned long pclk, unsigned long lclk,
                 enum omap_overlay_caps caps,
-                const struct omap_video_timings *mgr_timings,
+                const struct videomode *vm,
                 u16 width, u16 height, u16 out_width, u16 out_height,
                 enum omap_color_mode color_mode, bool *five_taps,
                 int *x_predecim, int *y_predecim, u16 pos_x,
@@ -2515,7 +2517,7 @@ static int dispc_ovl_calc_scaling(unsigned long pclk, unsigned long lclk,
         if (width == out_width && height == out_height)
                 return 0;
 
-        if (!mem_to_mem && (pclk == 0 || mgr_timings->pixelclock == 0)) {
+        if (!mem_to_mem && (pclk == 0 || vm->pixelclock == 0)) {
                 DSSERR("cannot calculate scaling settings: pclk is zero\n");
                 return -EINVAL;
         }
@@ -2551,7 +2553,7 @@ static int dispc_ovl_calc_scaling(unsigned long pclk, unsigned long lclk,
         if (decim_y > *y_predecim || out_height > height * 8)
                 return -EINVAL;
 
-        ret = dispc.feat->calc_scaling(pclk, lclk, mgr_timings, width, height,
+        ret = dispc.feat->calc_scaling(pclk, lclk, vm, width, height,
                 out_width, out_height, color_mode, five_taps,
                 x_predecim, y_predecim, &decim_x, &decim_y, pos_x, &core_clk,
                 mem_to_mem);
@@ -2591,7 +2593,7 @@ static int dispc_ovl_setup_common(enum omap_plane plane,
                 u16 out_width, u16 out_height, enum omap_color_mode color_mode,
                 u8 rotation, bool mirror, u8 zorder, u8 pre_mult_alpha,
                 u8 global_alpha, enum omap_dss_rotation_type rotation_type,
-                bool replication, const struct omap_video_timings *mgr_timings,
+                bool replication, const struct videomode *vm,
                 bool mem_to_mem)
 {
         bool five_taps = true;
@@ -2605,7 +2607,7 @@ static int dispc_ovl_setup_common(enum omap_plane plane,
         u16 in_height = height;
         u16 in_width = width;
         int x_predecim = 1, y_predecim = 1;
-        bool ilace = mgr_timings->interlace;
+        bool ilace = !!(vm->flags & DISPLAY_FLAGS_INTERLACED);
         unsigned long pclk = dispc_plane_pclk_rate(plane);
         unsigned long lclk = dispc_plane_lclk_rate(plane);
 
@@ -2647,7 +2649,7 @@ static int dispc_ovl_setup_common(enum omap_plane plane,
         if (!dss_feat_color_mode_supported(plane, color_mode))
                 return -EINVAL;
 
-        r = dispc_ovl_calc_scaling(pclk, lclk, caps, mgr_timings, in_width,
+        r = dispc_ovl_calc_scaling(pclk, lclk, caps, vm, in_width,
                         in_height, out_width, out_height, color_mode,
                         &five_taps, &x_predecim, &y_predecim, pos_x,
                         rotation_type, mem_to_mem);
@@ -2784,7 +2786,7 @@ static int dispc_ovl_setup_common(enum omap_plane plane,
 }
 
 int dispc_ovl_setup(enum omap_plane plane, const struct omap_overlay_info *oi,
-                bool replication, const struct omap_video_timings *mgr_timings,
+                bool replication, const struct videomode *vm,
                 bool mem_to_mem)
 {
         int r;
@@ -2803,14 +2805,14 @@ int dispc_ovl_setup(enum omap_plane plane, const struct omap_overlay_info *oi,
                 oi->screen_width, oi->pos_x, oi->pos_y, oi->width, oi->height,
                 oi->out_width, oi->out_height, oi->color_mode, oi->rotation,
                 oi->mirror, oi->zorder, oi->pre_mult_alpha, oi->global_alpha,
-                oi->rotation_type, replication, mgr_timings, mem_to_mem);
+                oi->rotation_type, replication, vm, mem_to_mem);
 
         return r;
 }
 EXPORT_SYMBOL(dispc_ovl_setup);
 
 int dispc_wb_setup(const struct omap_dss_writeback_info *wi,
-                bool mem_to_mem, const struct omap_video_timings *mgr_timings)
+                bool mem_to_mem, const struct videomode *vm)
 {
         int r;
         u32 l;
@@ -2819,8 +2821,8 @@ int dispc_wb_setup(const struct omap_dss_writeback_info *wi,
         const u8 zorder = 0, global_alpha = 0;
         const bool replication = false;
         bool truncation;
-        int in_width = mgr_timings->x_res;
-        int in_height = mgr_timings->y_res;
+        int in_width = vm->hactive;
+        int in_height = vm->vactive;
         enum omap_overlay_caps caps =
                 OMAP_DSS_OVL_CAP_SCALE | OMAP_DSS_OVL_CAP_PRE_MULT_ALPHA;
 
@@ -2833,7 +2835,7 @@ int dispc_wb_setup(const struct omap_dss_writeback_info *wi,
                 wi->buf_width, pos_x, pos_y, in_width, in_height, wi->width,
                 wi->height, wi->color_mode, wi->rotation, wi->mirror, zorder,
                 wi->pre_mult_alpha, global_alpha, wi->rotation_type,
-                replication, mgr_timings, mem_to_mem);
+                replication, vm, mem_to_mem);
 
         switch (wi->color_mode) {
         case OMAP_DSS_COLOR_RGB16:
@@ -2867,8 +2869,8 @@ int dispc_wb_setup(const struct omap_dss_writeback_info *wi,
         } else {
                 int wbdelay;
 
-                wbdelay = min(mgr_timings->vfp + mgr_timings->vsw +
-                        mgr_timings->vbp, 255);
+                wbdelay = min(vm->vfront_porch +
+                              vm->vsync_len + vm->vback_porch, (u32)255);
 
                 /* WBDELAYCOUNT */
                 REG_FLD_MOD(DISPC_OVL_ATTRIBUTES2(plane), wbdelay, 7, 0);
@@ -3093,10 +3095,10 @@ static bool _dispc_mgr_size_ok(u16 width, u16 height)
                 height <= dispc.feat->mgr_height_max;
 }
 
-static bool _dispc_lcd_timings_ok(int hsw, int hfp, int hbp,
+static bool _dispc_lcd_timings_ok(int hsync_len, int hfp, int hbp,
                 int vsw, int vfp, int vbp)
 {
-        if (hsw < 1 || hsw > dispc.feat->sw_max ||
+        if (hsync_len < 1 || hsync_len > dispc.feat->sw_max ||
                         hfp < 1 || hfp > dispc.feat->hp_max ||
                         hbp < 1 || hbp > dispc.feat->hp_max ||
                         vsw < 1 || vsw > dispc.feat->sw_max ||
@@ -3110,113 +3112,77 @@ static bool _dispc_mgr_pclk_ok(enum omap_channel channel,
                 unsigned long pclk)
 {
         if (dss_mgr_is_lcd(channel))
-                return pclk <= dispc.feat->max_lcd_pclk ? true : false;
+                return pclk <= dispc.feat->max_lcd_pclk;
         else
-                return pclk <= dispc.feat->max_tv_pclk ? true : false;
+                return pclk <= dispc.feat->max_tv_pclk;
 }
 
-bool dispc_mgr_timings_ok(enum omap_channel channel,
-                const struct omap_video_timings *timings)
+bool dispc_mgr_timings_ok(enum omap_channel channel, const struct videomode *vm)
 {
-        if (!_dispc_mgr_size_ok(timings->x_res, timings->y_res))
+        if (!_dispc_mgr_size_ok(vm->hactive, vm->vactive))
                 return false;
 
-        if (!_dispc_mgr_pclk_ok(channel, timings->pixelclock))
+        if (!_dispc_mgr_pclk_ok(channel, vm->pixelclock))
                 return false;
 
         if (dss_mgr_is_lcd(channel)) {
                 /* TODO: OMAP4+ supports interlace for LCD outputs */
-                if (timings->interlace)
+                if (vm->flags & DISPLAY_FLAGS_INTERLACED)
                         return false;
 
-                if (!_dispc_lcd_timings_ok(timings->hsw, timings->hfp,
-                                timings->hbp, timings->vsw, timings->vfp,
-                                timings->vbp))
+                if (!_dispc_lcd_timings_ok(vm->hsync_len,
+                                vm->hfront_porch, vm->hback_porch,
+                                vm->vsync_len, vm->vfront_porch,
+                                vm->vback_porch))
                         return false;
         }
 
         return true;
 }
 
-static void _dispc_mgr_set_lcd_timings(enum omap_channel channel, int hsw,
-                int hfp, int hbp, int vsw, int vfp, int vbp,
-                enum omap_dss_signal_level vsync_level,
-                enum omap_dss_signal_level hsync_level,
-                enum omap_dss_signal_edge data_pclk_edge,
-                enum omap_dss_signal_level de_level,
-                enum omap_dss_signal_edge sync_pclk_edge)
-
+static void _dispc_mgr_set_lcd_timings(enum omap_channel channel,
+                                       const struct videomode *vm)
 {
         u32 timing_h, timing_v, l;
         bool onoff, rf, ipc, vs, hs, de;
 
-        timing_h = FLD_VAL(hsw-1, dispc.feat->sw_start, 0) |
-                        FLD_VAL(hfp-1, dispc.feat->fp_start, 8) |
-                        FLD_VAL(hbp-1, dispc.feat->bp_start, 20);
-        timing_v = FLD_VAL(vsw-1, dispc.feat->sw_start, 0) |
-                        FLD_VAL(vfp, dispc.feat->fp_start, 8) |
-                        FLD_VAL(vbp, dispc.feat->bp_start, 20);
+        timing_h = FLD_VAL(vm->hsync_len - 1, dispc.feat->sw_start, 0) |
+                   FLD_VAL(vm->hfront_porch - 1, dispc.feat->fp_start, 8) |
+                   FLD_VAL(vm->hback_porch - 1, dispc.feat->bp_start, 20);
+        timing_v = FLD_VAL(vm->vsync_len - 1, dispc.feat->sw_start, 0) |
+                   FLD_VAL(vm->vfront_porch, dispc.feat->fp_start, 8) |
+                   FLD_VAL(vm->vback_porch, dispc.feat->bp_start, 20);
 
         dispc_write_reg(DISPC_TIMING_H(channel), timing_h);
         dispc_write_reg(DISPC_TIMING_V(channel), timing_v);
 
-        switch (vsync_level) {
-        case OMAPDSS_SIG_ACTIVE_LOW:
-                vs = true;
-                break;
-        case OMAPDSS_SIG_ACTIVE_HIGH:
+        if (vm->flags & DISPLAY_FLAGS_VSYNC_HIGH)
                 vs = false;
-                break;
-        default:
-                BUG();
-        }
+        else
+                vs = true;
 
-        switch (hsync_level) {
-        case OMAPDSS_SIG_ACTIVE_LOW:
-                hs = true;
-                break;
-        case OMAPDSS_SIG_ACTIVE_HIGH:
+        if (vm->flags & DISPLAY_FLAGS_HSYNC_HIGH)
                 hs = false;
-                break;
-        default:
-                BUG();
-        }
+        else
+                hs = true;
 
-        switch (de_level) {
-        case OMAPDSS_SIG_ACTIVE_LOW:
-                de = true;
-                break;
-        case OMAPDSS_SIG_ACTIVE_HIGH:
+        if (vm->flags & DISPLAY_FLAGS_DE_HIGH)
                 de = false;
-                break;
-        default:
-                BUG();
-        }
+        else
+                de = true;
 
-        switch (data_pclk_edge) {
-        case OMAPDSS_DRIVE_SIG_RISING_EDGE:
+        if (vm->flags & DISPLAY_FLAGS_PIXDATA_POSEDGE)
                 ipc = false;
-                break;
-        case OMAPDSS_DRIVE_SIG_FALLING_EDGE:
+        else
                 ipc = true;
-                break;
-        default:
-                BUG();
-        }
 
         /* always use the 'rf' setting */
         onoff = true;
 
-        switch (sync_pclk_edge) {
-        case OMAPDSS_DRIVE_SIG_FALLING_EDGE:
-                rf = false;
-                break;
-        case OMAPDSS_DRIVE_SIG_RISING_EDGE:
+        if (vm->flags & DISPLAY_FLAGS_SYNC_POSEDGE)
                 rf = true;
-                break;
-        default:
-                BUG();
-        }
+        else
+                rf = false;
 
         l = FLD_VAL(onoff, 17, 17) |
                 FLD_VAL(rf, 16, 16) |
@@ -3253,13 +3219,13 @@ static void _dispc_mgr_set_lcd_timings(enum omap_channel channel, int hsw,
 
 /* change name to mode? */
 void dispc_mgr_set_timings(enum omap_channel channel,
-                const struct omap_video_timings *timings)
+                           const struct videomode *vm)
 {
         unsigned xtot, ytot;
         unsigned long ht, vt;
-        struct omap_video_timings t = *timings;
+        struct videomode t = *vm;
 
-        DSSDBG("channel %d xres %u yres %u\n", channel, t.x_res, t.y_res);
+        DSSDBG("channel %d xres %u yres %u\n", channel, t.hactive, t.vactive);
 
         if (!dispc_mgr_timings_ok(channel, &t)) {
                 BUG();
@@ -3267,34 +3233,37 @@ void dispc_mgr_set_timings(enum omap_channel channel,
         }
 
         if (dss_mgr_is_lcd(channel)) {
-                _dispc_mgr_set_lcd_timings(channel, t.hsw, t.hfp, t.hbp, t.vsw,
-                                t.vfp, t.vbp, t.vsync_level, t.hsync_level,
-                                t.data_pclk_edge, t.de_level, t.sync_pclk_edge);
+                _dispc_mgr_set_lcd_timings(channel, &t);
 
-                xtot = t.x_res + t.hfp + t.hsw + t.hbp;
-                ytot = t.y_res + t.vfp + t.vsw + t.vbp;
+                xtot = t.hactive + t.hfront_porch + t.hsync_len + t.hback_porch;
+                ytot = t.vactive + t.vfront_porch + t.vsync_len + t.vback_porch;
 
-                ht = timings->pixelclock / xtot;
-                vt = timings->pixelclock / xtot / ytot;
+                ht = vm->pixelclock / xtot;
+                vt = vm->pixelclock / xtot / ytot;
 
-                DSSDBG("pck %u\n", timings->pixelclock);
-                DSSDBG("hsw %d hfp %d hbp %d vsw %d vfp %d vbp %d\n",
-                        t.hsw, t.hfp, t.hbp, t.vsw, t.vfp, t.vbp);
+                DSSDBG("pck %lu\n", vm->pixelclock);
+                DSSDBG("hsync_len %d hfp %d hbp %d vsw %d vfp %d vbp %d\n",
+                        t.hsync_len, t.hfront_porch, t.hback_porch,
+                        t.vsync_len, t.vfront_porch, t.vback_porch);
                 DSSDBG("vsync_level %d hsync_level %d data_pclk_edge %d de_level %d sync_pclk_edge %d\n",
-                        t.vsync_level, t.hsync_level, t.data_pclk_edge,
-                        t.de_level, t.sync_pclk_edge);
+                        !!(t.flags & DISPLAY_FLAGS_VSYNC_HIGH),
+                        !!(t.flags & DISPLAY_FLAGS_HSYNC_HIGH),
+                        !!(t.flags & DISPLAY_FLAGS_PIXDATA_POSEDGE),
+                        !!(t.flags & DISPLAY_FLAGS_DE_HIGH),
+                        !!(t.flags & DISPLAY_FLAGS_SYNC_POSEDGE));
 
                 DSSDBG("hsync %luHz, vsync %luHz\n", ht, vt);
         } else {
-                if (t.interlace)
-                        t.y_res /= 2;
+                if (t.flags & DISPLAY_FLAGS_INTERLACED)
+                        t.vactive /= 2;
 
                 if (dispc.feat->supports_double_pixel)
-                        REG_FLD_MOD(DISPC_CONTROL, t.double_pixel ? 1 : 0,
-                                19, 17);
+                        REG_FLD_MOD(DISPC_CONTROL,
+                                    !!(t.flags & DISPLAY_FLAGS_DOUBLECLK),
+                                    19, 17);
         }
 
-        dispc_mgr_set_size(channel, t.x_res, t.y_res);
+        dispc_mgr_set_size(channel, t.hactive, t.vactive);
 }
 EXPORT_SYMBOL(dispc_mgr_set_timings);
 
@@ -4214,23 +4183,20 @@ EXPORT_SYMBOL(dispc_free_irq);
  */
 
 static const struct dispc_errata_i734_data {
-        struct omap_video_timings timings;
+        struct videomode vm;
         struct omap_overlay_info ovli;
         struct omap_overlay_manager_info mgri;
         struct dss_lcd_mgr_config lcd_conf;
 } i734 = {
-        .timings = {
-                .x_res = 8, .y_res = 1,
+        .vm = {
+                .hactive = 8, .vactive = 1,
                 .pixelclock = 16000000,
-                .hsw = 8, .hfp = 4, .hbp = 4,
-                .vsw = 1, .vfp = 1, .vbp = 1,
-                .vsync_level = OMAPDSS_SIG_ACTIVE_LOW,
-                .hsync_level = OMAPDSS_SIG_ACTIVE_LOW,
-                .interlace = false,
-                .data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE,
-                .de_level = OMAPDSS_SIG_ACTIVE_HIGH,
-                .sync_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE,
-                .double_pixel = false,
+                .hsync_len = 8, .hfront_porch = 4, .hback_porch = 4,
+                .vsync_len = 1, .vfront_porch = 1, .vback_porch = 1,
+
+                .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+                         DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_SYNC_POSEDGE |
+                         DISPLAY_FLAGS_PIXDATA_POSEDGE,
         },
         .ovli = {
                 .screen_width = 1,
@@ -4320,7 +4286,7 @@ static void dispc_errata_i734_wa(void)
 
         /* Setup and enable GFX plane */
         dispc_ovl_set_channel_out(OMAP_DSS_GFX, OMAP_DSS_CHANNEL_LCD);
-        dispc_ovl_setup(OMAP_DSS_GFX, &ovli, false, &i734.timings, false);
+        dispc_ovl_setup(OMAP_DSS_GFX, &ovli, false, &i734.vm, false);
         dispc_ovl_enable(OMAP_DSS_GFX, true);
 
         /* Set up and enable display manager for LCD1 */
@@ -4328,7 +4294,7 @@ static void dispc_errata_i734_wa(void)
         dispc_calc_clock_rates(dss_get_dispc_clk_rate(),
                                &lcd_conf.clock_info);
         dispc_mgr_set_lcd_config(OMAP_DSS_CHANNEL_LCD, &lcd_conf);
-        dispc_mgr_set_timings(OMAP_DSS_CHANNEL_LCD, &i734.timings);
+        dispc_mgr_set_timings(OMAP_DSS_CHANNEL_LCD, &i734.vm);
 
         dispc_clear_irqstatus(framedone_irq);
 
diff --git a/drivers/gpu/drm/omapdrm/dss/display.c b/drivers/gpu/drm/omapdrm/dss/display.c
index 8dcdd7cf9937..425a5a8dff8b 100644
--- a/drivers/gpu/drm/omapdrm/dss/display.c
+++ b/drivers/gpu/drm/omapdrm/dss/display.c
@@ -35,8 +35,8 @@
 void omapdss_default_get_resolution(struct omap_dss_device *dssdev,
                         u16 *xres, u16 *yres)
 {
-        *xres = dssdev->panel.timings.x_res;
-        *yres = dssdev->panel.timings.y_res;
+        *xres = dssdev->panel.vm.hactive;
+        *yres = dssdev->panel.vm.vactive;
 }
 EXPORT_SYMBOL(omapdss_default_get_resolution);
 
@@ -72,9 +72,9 @@ int omapdss_default_get_recommended_bpp(struct omap_dss_device *dssdev)
 EXPORT_SYMBOL(omapdss_default_get_recommended_bpp);
 
 void omapdss_default_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                 struct videomode *vm)
 {
-        *timings = dssdev->panel.timings;
+        *vm = dssdev->panel.vm;
 }
 EXPORT_SYMBOL(omapdss_default_get_timings);
 
@@ -217,73 +217,3 @@ struct omap_dss_device *omap_dss_find_device(void *data,
         return NULL;
 }
 EXPORT_SYMBOL(omap_dss_find_device);
-
-void videomode_to_omap_video_timings(const struct videomode *vm,
-                struct omap_video_timings *ovt)
-{
-        memset(ovt, 0, sizeof(*ovt));
-
-        ovt->pixelclock = vm->pixelclock;
-        ovt->x_res = vm->hactive;
-        ovt->hbp = vm->hback_porch;
-        ovt->hfp = vm->hfront_porch;
-        ovt->hsw = vm->hsync_len;
-        ovt->y_res = vm->vactive;
-        ovt->vbp = vm->vback_porch;
-        ovt->vfp = vm->vfront_porch;
-        ovt->vsw = vm->vsync_len;
-
-        ovt->vsync_level = vm->flags & DISPLAY_FLAGS_VSYNC_HIGH ?
-                OMAPDSS_SIG_ACTIVE_HIGH :
-                OMAPDSS_SIG_ACTIVE_LOW;
-        ovt->hsync_level = vm->flags & DISPLAY_FLAGS_HSYNC_HIGH ?
-                OMAPDSS_SIG_ACTIVE_HIGH :
-                OMAPDSS_SIG_ACTIVE_LOW;
-        ovt->de_level = vm->flags & DISPLAY_FLAGS_DE_HIGH ?
-                OMAPDSS_SIG_ACTIVE_HIGH :
-                OMAPDSS_SIG_ACTIVE_LOW;
-        ovt->data_pclk_edge = vm->flags & DISPLAY_FLAGS_PIXDATA_POSEDGE ?
-                OMAPDSS_DRIVE_SIG_RISING_EDGE :
-                OMAPDSS_DRIVE_SIG_FALLING_EDGE;
-
-        ovt->sync_pclk_edge = ovt->data_pclk_edge;
-}
-EXPORT_SYMBOL(videomode_to_omap_video_timings);
-
-void omap_video_timings_to_videomode(const struct omap_video_timings *ovt,
-                struct videomode *vm)
-{
-        memset(vm, 0, sizeof(*vm));
-
-        vm->pixelclock = ovt->pixelclock;
-
-        vm->hactive = ovt->x_res;
-        vm->hback_porch = ovt->hbp;
-        vm->hfront_porch = ovt->hfp;
-        vm->hsync_len = ovt->hsw;
-        vm->vactive = ovt->y_res;
-        vm->vback_porch = ovt->vbp;
-        vm->vfront_porch = ovt->vfp;
-        vm->vsync_len = ovt->vsw;
-
-        if (ovt->hsync_level == OMAPDSS_SIG_ACTIVE_HIGH)
-                vm->flags |= DISPLAY_FLAGS_HSYNC_HIGH;
-        else
-                vm->flags |= DISPLAY_FLAGS_HSYNC_LOW;
-
-        if (ovt->vsync_level == OMAPDSS_SIG_ACTIVE_HIGH)
-                vm->flags |= DISPLAY_FLAGS_VSYNC_HIGH;
-        else
-                vm->flags |= DISPLAY_FLAGS_VSYNC_LOW;
-
-        if (ovt->de_level == OMAPDSS_SIG_ACTIVE_HIGH)
-                vm->flags |= DISPLAY_FLAGS_DE_HIGH;
-        else
-                vm->flags |= DISPLAY_FLAGS_DE_LOW;
-
-        if (ovt->data_pclk_edge == OMAPDSS_DRIVE_SIG_RISING_EDGE)
-                vm->flags |= DISPLAY_FLAGS_PIXDATA_POSEDGE;
-        else
-                vm->flags |= DISPLAY_FLAGS_PIXDATA_NEGEDGE;
-}
-EXPORT_SYMBOL(omap_video_timings_to_videomode);
diff --git a/drivers/gpu/drm/omapdrm/dss/dpi.c b/drivers/gpu/drm/omapdrm/dss/dpi.c
index b268295b76cf..e75162d26ac0 100644
--- a/drivers/gpu/drm/omapdrm/dss/dpi.c
+++ b/drivers/gpu/drm/omapdrm/dss/dpi.c
@@ -47,7 +47,7 @@ struct dpi_data {
 
         struct mutex lock;
 
-        struct omap_video_timings timings;
+        struct videomode vm;
         struct dss_lcd_mgr_config mgr_config;
         int data_lines;
 
@@ -333,31 +333,31 @@ static int dpi_set_mode(struct dpi_data *dpi)
 {
         struct omap_dss_device *out = &dpi->output;
         enum omap_channel channel = out->dispc_channel;
-        struct omap_video_timings *t = &dpi->timings;
+        struct videomode *vm = &dpi->vm;
         int lck_div = 0, pck_div = 0;
         unsigned long fck = 0;
         unsigned long pck;
         int r = 0;
 
         if (dpi->pll)
-                r = dpi_set_pll_clk(dpi, channel, t->pixelclock, &fck,
+                r = dpi_set_pll_clk(dpi, channel, vm->pixelclock, &fck,
                                 &lck_div, &pck_div);
         else
-                r = dpi_set_dispc_clk(dpi, t->pixelclock, &fck,
+                r = dpi_set_dispc_clk(dpi, vm->pixelclock, &fck,
                                 &lck_div, &pck_div);
         if (r)
                 return r;
 
         pck = fck / lck_div / pck_div;
 
-        if (pck != t->pixelclock) {
-                DSSWARN("Could not find exact pixel clock. Requested %d Hz, got %lu Hz\n",
-                        t->pixelclock, pck);
+        if (pck != vm->pixelclock) {
+                DSSWARN("Could not find exact pixel clock. Requested %lu Hz, got %lu Hz\n",
+                        vm->pixelclock, pck);
 
-                t->pixelclock = pck;
+                vm->pixelclock = pck;
         }
 
-        dss_mgr_set_timings(channel, t);
+        dss_mgr_set_timings(channel, vm);
 
         return 0;
 }
@@ -476,7 +476,7 @@ static void dpi_display_disable(struct omap_dss_device *dssdev)
 }
 
 static void dpi_set_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                            struct videomode *vm)
 {
         struct dpi_data *dpi = dpi_get_data_from_dssdev(dssdev);
 
@@ -484,25 +484,25 @@ static void dpi_set_timings(struct omap_dss_device *dssdev,
 
         mutex_lock(&dpi->lock);
 
-        dpi->timings = *timings;
+        dpi->vm = *vm;
 
         mutex_unlock(&dpi->lock);
 }
 
 static void dpi_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                            struct videomode *vm)
 {
         struct dpi_data *dpi = dpi_get_data_from_dssdev(dssdev);
 
         mutex_lock(&dpi->lock);
 
-        *timings = dpi->timings;
+        *vm = dpi->vm;
 
         mutex_unlock(&dpi->lock);
 }
 
 static int dpi_check_timings(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings)
+                             struct videomode *vm)
 {
         struct dpi_data *dpi = dpi_get_data_from_dssdev(dssdev);
         enum omap_channel channel = dpi->output.dispc_channel;
@@ -512,23 +512,23 @@ static int dpi_check_timings(struct omap_dss_device *dssdev,
         struct dpi_clk_calc_ctx ctx;
         bool ok;
 
-        if (timings->x_res % 8 != 0)
+        if (vm->hactive % 8 != 0)
                 return -EINVAL;
 
-        if (!dispc_mgr_timings_ok(channel, timings))
+        if (!dispc_mgr_timings_ok(channel, vm))
                 return -EINVAL;
 
-        if (timings->pixelclock == 0)
+        if (vm->pixelclock == 0)
                 return -EINVAL;
 
         if (dpi->pll) {
-                ok = dpi_pll_clk_calc(dpi, timings->pixelclock, &ctx);
+                ok = dpi_pll_clk_calc(dpi, vm->pixelclock, &ctx);
                 if (!ok)
                         return -EINVAL;
 
                 fck = ctx.pll_cinfo.clkout[ctx.clkout_idx];
         } else {
-                ok = dpi_dss_clk_calc(timings->pixelclock, &ctx);
+                ok = dpi_dss_clk_calc(vm->pixelclock, &ctx);
                 if (!ok)
                         return -EINVAL;
 
@@ -540,7 +540,7 @@ static int dpi_check_timings(struct omap_dss_device *dssdev,
 
         pck = fck / lck_div / pck_div;
 
-        timings->pixelclock = pck;
+        vm->pixelclock = pck;
 
         return 0;
 }
diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
index e1be5e795cd8..f060bda31235 100644
--- a/drivers/gpu/drm/omapdrm/dss/dsi.c
+++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
@@ -289,7 +289,7 @@ struct dsi_clk_calc_ctx {
         struct dss_pll_clock_info dsi_cinfo;
         struct dispc_clock_info dispc_cinfo;
 
-        struct omap_video_timings dispc_vm;
+        struct videomode vm;
         struct omap_dss_dsi_videomode_timings dsi_vm;
 };
 
@@ -383,7 +383,7 @@ struct dsi_data {
         unsigned scp_clk_refcount;
 
         struct dss_lcd_mgr_config mgr_config;
-        struct omap_video_timings timings;
+        struct videomode vm;
         enum omap_dss_dsi_pixel_format pix_fmt;
         enum omap_dss_dsi_mode mode;
         struct omap_dss_dsi_videomode_timings vm_timings;
@@ -3321,12 +3321,12 @@ static void dsi_config_vp_num_line_buffers(struct platform_device *dsidev)
 
         if (dsi->mode == OMAP_DSS_DSI_VIDEO_MODE) {
                 int bpp = dsi_get_pixel_size(dsi->pix_fmt);
-                struct omap_video_timings *timings = &dsi->timings;
+                struct videomode *vm = &dsi->vm;
                 /*
                  * Don't use line buffers if width is greater than the video
                  * port's line buffer size
                  */
-                if (dsi->line_buffer_size <= timings->x_res * bpp / 8)
+                if (dsi->line_buffer_size <= vm->hactive * bpp / 8)
                         num_line_buffers = 0;
                 else
                         num_line_buffers = 2;
@@ -3453,7 +3453,7 @@ static void dsi_config_cmd_mode_interleaving(struct platform_device *dsidev)
         int ddr_clk_pre, ddr_clk_post, enter_hs_mode_lat, exit_hs_mode_lat;
         int tclk_trail, ths_exit, exiths_clk;
         bool ddr_alwon;
-        struct omap_video_timings *timings = &dsi->timings;
+        struct videomode *vm = &dsi->vm;
         int bpp = dsi_get_pixel_size(dsi->pix_fmt);
         int ndl = dsi->num_lanes_used - 1;
         int dsi_fclk_hsdiv = dsi->user_dsi_cinfo.mX[HSDIV_DSI] + 1;
@@ -3494,7 +3494,7 @@ static void dsi_config_cmd_mode_interleaving(struct platform_device *dsidev)
 
         exiths_clk = ths_exit + tclk_trail;
 
-        width_bytes = DIV_ROUND_UP(timings->x_res * bpp, 8);
+        width_bytes = DIV_ROUND_UP(vm->hactive * bpp, 8);
         bllp = hbp + hfp + hsa + DIV_ROUND_UP(width_bytes + 6, ndl);
 
         if (!hsa_blanking_mode) {
@@ -3705,7 +3705,7 @@ static void dsi_proto_timings(struct platform_device *dsidev)
                 int vbp = dsi->vm_timings.vbp;
                 int window_sync = dsi->vm_timings.window_sync;
                 bool hsync_end;
-                struct omap_video_timings *timings = &dsi->timings;
+                struct videomode *vm = &dsi->vm;
                 int bpp = dsi_get_pixel_size(dsi->pix_fmt);
                 int tl, t_he, width_bytes;
 
@@ -3713,7 +3713,7 @@ static void dsi_proto_timings(struct platform_device *dsidev)
                 t_he = hsync_end ?
                         ((hsa == 0 && ndl == 3) ? 1 : DIV_ROUND_UP(4, ndl)) : 0;
 
-                width_bytes = DIV_ROUND_UP(timings->x_res * bpp, 8);
+                width_bytes = DIV_ROUND_UP(vm->hactive * bpp, 8);
 
                 /* TL = t_HS + HSA + t_HE + HFP + ceil((WC + 6) / NDL) + HBP */
                 tl = DIV_ROUND_UP(4, ndl) + (hsync_end ? hsa : 0) + t_he + hfp +
@@ -3722,7 +3722,7 @@ static void dsi_proto_timings(struct platform_device *dsidev)
                 DSSDBG("HBP: %d, HFP: %d, HSA: %d, TL: %d TXBYTECLKHS\n", hbp,
                         hfp, hsync_end ? hsa : 0, tl);
                 DSSDBG("VBP: %d, VFP: %d, VSA: %d, VACT: %d lines\n", vbp, vfp,
-                        vsa, timings->y_res);
+                        vsa, vm->vactive);
 
                 r = dsi_read_reg(dsidev, DSI_VM_TIMING1);
                 r = FLD_MOD(r, hbp, 11, 0);     /* HBP */
@@ -3738,7 +3738,7 @@ static void dsi_proto_timings(struct platform_device *dsidev)
                 dsi_write_reg(dsidev, DSI_VM_TIMING2, r);
 
                 r = dsi_read_reg(dsidev, DSI_VM_TIMING3);
-                r = FLD_MOD(r, timings->y_res, 14, 0);  /* VACT */
+                r = FLD_MOD(r, vm->vactive, 14, 0);     /* VACT */
                 r = FLD_MOD(r, tl, 31, 16);             /* TL */
                 dsi_write_reg(dsidev, DSI_VM_TIMING3, r);
         }
@@ -3856,7 +3856,7 @@ static int dsi_enable_video_output(struct omap_dss_device *dssdev, int channel)
                 /* MODE, 1 = video mode */
                 REG_FLD_MOD(dsidev, DSI_VC_CTRL(channel), 1, 4, 4);
 
-                word_count = DIV_ROUND_UP(dsi->timings.x_res * bpp, 8);
+                word_count = DIV_ROUND_UP(dsi->vm.hactive * bpp, 8);
 
                 dsi_vc_write_long_header(dsidev, channel, data_type,
                                 word_count, 0);
@@ -3918,8 +3918,8 @@ static void dsi_update_screen_dispc(struct platform_device *dsidev)
         int r;
         const unsigned channel = dsi->update_channel;
         const unsigned line_buf_size = dsi->line_buffer_size;
-        u16 w = dsi->timings.x_res;
-        u16 h = dsi->timings.y_res;
+        u16 w = dsi->vm.hactive;
+        u16 h = dsi->vm.vactive;
 
         DSSDBG("dsi_update_screen_dispc(%dx%d)\n", w, h);
 
@@ -3969,7 +3969,7 @@ static void dsi_update_screen_dispc(struct platform_device *dsidev)
                 msecs_to_jiffies(250));
         BUG_ON(r == 0);
 
-        dss_mgr_set_timings(dispc_channel, &dsi->timings);
+        dss_mgr_set_timings(dispc_channel, &dsi->vm);
 
         dss_mgr_start_update(dispc_channel);
 
@@ -4056,8 +4056,8 @@ static int dsi_update(struct omap_dss_device *dssdev, int channel,
         dsi->framedone_callback = callback;
         dsi->framedone_data = data;
 
-        dw = dsi->timings.x_res;
-        dh = dsi->timings.y_res;
+        dw = dsi->vm.hactive;
+        dh = dsi->vm.vactive;
 
 #ifdef DSI_PERF_MEASURE
         dsi->update_bytes = dw * dh *
@@ -4120,16 +4120,21 @@ static int dsi_display_init_dispc(struct platform_device *dsidev,
 
         /*
          * override interlace, logic level and edge related parameters in
-         * omap_video_timings with default values
+         * videomode with default values
          */
-        dsi->timings.interlace = false;
-        dsi->timings.hsync_level = OMAPDSS_SIG_ACTIVE_HIGH;
-        dsi->timings.vsync_level = OMAPDSS_SIG_ACTIVE_HIGH;
-        dsi->timings.data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE;
-        dsi->timings.de_level = OMAPDSS_SIG_ACTIVE_HIGH;
-        dsi->timings.sync_pclk_edge = OMAPDSS_DRIVE_SIG_FALLING_EDGE;
-
-        dss_mgr_set_timings(channel, &dsi->timings);
+        dsi->vm.flags &= ~DISPLAY_FLAGS_INTERLACED;
+        dsi->vm.flags &= ~DISPLAY_FLAGS_HSYNC_LOW;
+        dsi->vm.flags |= DISPLAY_FLAGS_HSYNC_HIGH;
+        dsi->vm.flags &= ~DISPLAY_FLAGS_VSYNC_LOW;
+        dsi->vm.flags |= DISPLAY_FLAGS_VSYNC_HIGH;
+        dsi->vm.flags &= ~DISPLAY_FLAGS_PIXDATA_NEGEDGE;
+        dsi->vm.flags |= DISPLAY_FLAGS_PIXDATA_POSEDGE;
+        dsi->vm.flags &= ~DISPLAY_FLAGS_DE_LOW;
+        dsi->vm.flags |= DISPLAY_FLAGS_DE_HIGH;
+        dsi->vm.flags &= ~DISPLAY_FLAGS_SYNC_POSEDGE;
+        dsi->vm.flags |= DISPLAY_FLAGS_SYNC_NEGEDGE;
+
+        dss_mgr_set_timings(channel, &dsi->vm);
 
         r = dsi_configure_dispc_clocks(dsidev);
         if (r)
@@ -4331,7 +4336,7 @@ static void print_dsi_vm(const char *str,
 
         wc = DIV_ROUND_UP(t->hact * t->bitspp, 8);
         pps = DIV_ROUND_UP(wc + 6, t->ndl); /* pixel packet size */
-        bl = t->hss + t->hsa + t->hse + t->hbp + t->hfp;
+        bl = t->hss + t->hsa + t->hse + t->hbp + t->hfront_porch;
         tot = bl + pps;
 
 #define TO_DSI_T(x) ((u32)div64_u64((u64)x * 1000000000llu, byteclk))
@@ -4340,14 +4345,14 @@ static void print_dsi_vm(const char *str,
                         "%u/%u/%u/%u/%u/%u = %u + %u = %u\n",
                         str,
                         byteclk,
-                        t->hss, t->hsa, t->hse, t->hbp, pps, t->hfp,
+                        t->hss, t->hsa, t->hse, t->hbp, pps, t->hfront_porch,
                         bl, pps, tot,
                         TO_DSI_T(t->hss),
                         TO_DSI_T(t->hsa),
                         TO_DSI_T(t->hse),
                         TO_DSI_T(t->hbp),
                         TO_DSI_T(pps),
-                        TO_DSI_T(t->hfp),
+                        TO_DSI_T(t->hfront_porch),
 
                         TO_DSI_T(bl),
                         TO_DSI_T(pps),
@@ -4356,13 +4361,13 @@ static void print_dsi_vm(const char *str,
 #undef TO_DSI_T
 }
 
-static void print_dispc_vm(const char *str, const struct omap_video_timings *t)
+static void print_dispc_vm(const char *str, const struct videomode *vm)
 {
-        unsigned long pck = t->pixelclock;
+        unsigned long pck = vm->pixelclock;
         int hact, bl, tot;
 
-        hact = t->x_res;
-        bl = t->hsw + t->hbp + t->hfp;
+        hact = vm->hactive;
+        bl = vm->hsync_len + vm->hbp + vm->hfront_porch;
         tot = hact + bl;
 
 #define TO_DISPC_T(x) ((u32)div64_u64((u64)x * 1000000000llu, pck))
@@ -4371,12 +4376,12 @@ static void print_dispc_vm(const char *str, const struct omap_video_timings *t)
                         "%u/%u/%u/%u = %u + %u = %u\n",
                         str,
                         pck,
-                        t->hsw, t->hbp, hact, t->hfp,
+                        vm->hsync_len, vm->hbp, hact, vm->hfront_porch,
                         bl, hact, tot,
-                        TO_DISPC_T(t->hsw),
-                        TO_DISPC_T(t->hbp),
+                        TO_DISPC_T(vm->hsync_len),
+                        TO_DISPC_T(vm->hbp),
                         TO_DISPC_T(hact),
-                        TO_DISPC_T(t->hfp),
+                        TO_DISPC_T(vm->hfront_porch),
                         TO_DISPC_T(bl),
                         TO_DISPC_T(hact),
                         TO_DISPC_T(tot));
@@ -4387,7 +4392,7 @@ static void print_dispc_vm(const char *str, const struct omap_video_timings *t)
 static void print_dsi_dispc_vm(const char *str,
                 const struct omap_dss_dsi_videomode_timings *t)
 {
-        struct omap_video_timings vm = { 0 };
+        struct videomode vm = { 0 };
         unsigned long byteclk = t->hsclk / 4;
         unsigned long pck;
         u64 dsi_tput;
@@ -4396,13 +4401,13 @@ static void print_dsi_dispc_vm(const char *str,
         dsi_tput = (u64)byteclk * t->ndl * 8;
         pck = (u32)div64_u64(dsi_tput, t->bitspp);
         dsi_hact = DIV_ROUND_UP(DIV_ROUND_UP(t->hact * t->bitspp, 8) + 6, t->ndl);
-        dsi_htot = t->hss + t->hsa + t->hse + t->hbp + dsi_hact + t->hfp;
+        dsi_htot = t->hss + t->hsa + t->hse + t->hbp + dsi_hact + t->hfront_porch;
 
         vm.pixelclock = pck;
-        vm.hsw = div64_u64((u64)(t->hsa + t->hse) * pck, byteclk);
+        vm.hsync_len = div64_u64((u64)(t->hsa + t->hse) * pck, byteclk);
         vm.hbp = div64_u64((u64)t->hbp * pck, byteclk);
-        vm.hfp = div64_u64((u64)t->hfp * pck, byteclk);
-        vm.x_res = t->hact;
+        vm.hfront_porch = div64_u64((u64)t->hfront_porch * pck, byteclk);
+        vm.hactive = t->hact;
 
         print_dispc_vm(str, &vm);
 }
@@ -4412,19 +4417,19 @@ static bool dsi_cm_calc_dispc_cb(int lckd, int pckd, unsigned long lck,
                 unsigned long pck, void *data)
 {
         struct dsi_clk_calc_ctx *ctx = data;
-        struct omap_video_timings *t = &ctx->dispc_vm;
+        struct videomode *vm = &ctx->vm;
 
         ctx->dispc_cinfo.lck_div = lckd;
         ctx->dispc_cinfo.pck_div = pckd;
         ctx->dispc_cinfo.lck = lck;
         ctx->dispc_cinfo.pck = pck;
 
-        *t = *ctx->config->timings;
-        t->pixelclock = pck;
-        t->x_res = ctx->config->timings->x_res;
-        t->y_res = ctx->config->timings->y_res;
-        t->hsw = t->hfp = t->hbp = t->vsw = 1;
-        t->vfp = t->vbp = 0;
+        *vm = *ctx->config->vm;
+        vm->pixelclock = pck;
+        vm->hactive = ctx->config->vm->hactive;
+        vm->vactive = ctx->config->vm->vactive;
+        vm->hsync_len = vm->hfront_porch = vm->hback_porch = vm->vsync_len = 1;
+        vm->vfront_porch = vm->vback_porch = 0;
 
         return true;
 }
@@ -4475,7 +4480,7 @@ static bool dsi_cm_calc(struct dsi_data *dsi,
          * especially as we go to LP between each pixel packet due to HW
          * "feature". So let's just estimate very roughly and multiply by 1.5.
          */
-        pck = cfg->timings->pixelclock;
+        pck = cfg->vm->pixelclock;
         pck = pck * 3 / 2;
         txbyteclk = pck * bitspp / 8 / ndl;
 
@@ -4510,14 +4515,14 @@ static bool dsi_vm_calc_blanking(struct dsi_clk_calc_ctx *ctx)
         int dispc_htot, dispc_hbl; /* pixels */
         int dsi_htot, dsi_hact, dsi_hbl, hss, hse; /* byteclks */
         int hfp, hsa, hbp;
-        const struct omap_video_timings *req_vm;
-        struct omap_video_timings *dispc_vm;
+        const struct videomode *req_vm;
+        struct videomode *dispc_vm;
         struct omap_dss_dsi_videomode_timings *dsi_vm;
         u64 dsi_tput, dispc_tput;
 
         dsi_tput = (u64)byteclk * ndl * 8;
 
-        req_vm = cfg->timings;
+        req_vm = cfg->vm;
         req_pck_min = ctx->req_pck_min;
         req_pck_max = ctx->req_pck_max;
         req_pck_nom = ctx->req_pck_nom;
@@ -4525,9 +4530,10 @@ static bool dsi_vm_calc_blanking(struct dsi_clk_calc_ctx *ctx)
         dispc_pck = ctx->dispc_cinfo.pck;
         dispc_tput = (u64)dispc_pck * bitspp;
 
-        xres = req_vm->x_res;
+        xres = req_vm->hactive;
 
-        panel_hbl = req_vm->hfp + req_vm->hbp + req_vm->hsw;
+        panel_hbl = req_vm->hfront_porch + req_vm->hback_porch +
+                    req_vm->hsync_len;
         panel_htot = xres + panel_hbl;
 
         dsi_hact = DIV_ROUND_UP(DIV_ROUND_UP(xres * bitspp, 8) + 6, ndl);
@@ -4557,7 +4563,7 @@ static bool dsi_vm_calc_blanking(struct dsi_clk_calc_ctx *ctx)
         hss = DIV_ROUND_UP(4, ndl);
 
         if (cfg->trans_mode == OMAP_DSS_DSI_PULSE_MODE) {
-                if (ndl == 3 && req_vm->hsw == 0)
+                if (ndl == 3 && req_vm->hsync_len == 0)
                         hse = 1;
                 else
                         hse = DIV_ROUND_UP(4, ndl);
@@ -4596,14 +4602,14 @@ static bool dsi_vm_calc_blanking(struct dsi_clk_calc_ctx *ctx)
 
         if (cfg->trans_mode != OMAP_DSS_DSI_PULSE_MODE) {
                 hsa = 0;
-        } else if (ndl == 3 && req_vm->hsw == 0) {
+        } else if (ndl == 3 && req_vm->hsync_len == 0) {
                 hsa = 0;
         } else {
-                hsa = div64_u64((u64)req_vm->hsw * byteclk, req_pck_nom);
+                hsa = div64_u64((u64)req_vm->hsync_len * byteclk, req_pck_nom);
                 hsa = max(hsa - hse, 1);
         }
 
-        hbp = div64_u64((u64)req_vm->hbp * byteclk, req_pck_nom);
+        hbp = div64_u64((u64)req_vm->hback_porch * byteclk, req_pck_nom);
         hbp = max(hbp, 1);
 
         hfp = dsi_hbl - (hss + hsa + hse + hbp);
@@ -4633,10 +4639,10 @@ static bool dsi_vm_calc_blanking(struct dsi_clk_calc_ctx *ctx)
         dsi_vm->hact = xres;
         dsi_vm->hfp = hfp;
 
-        dsi_vm->vsa = req_vm->vsw;
-        dsi_vm->vbp = req_vm->vbp;
-        dsi_vm->vact = req_vm->y_res;
-        dsi_vm->vfp = req_vm->vfp;
+        dsi_vm->vsa = req_vm->vsync_len;
+        dsi_vm->vbp = req_vm->vback_porch;
+        dsi_vm->vact = req_vm->vactive;
+        dsi_vm->vfp = req_vm->vfront_porch;
 
         dsi_vm->trans_mode = cfg->trans_mode;
 
@@ -4650,19 +4656,19 @@ static bool dsi_vm_calc_blanking(struct dsi_clk_calc_ctx *ctx)
 
         /* setup DISPC videomode */
 
-        dispc_vm = &ctx->dispc_vm;
+        dispc_vm = &ctx->vm;
         *dispc_vm = *req_vm;
         dispc_vm->pixelclock = dispc_pck;
 
         if (cfg->trans_mode == OMAP_DSS_DSI_PULSE_MODE) {
-                hsa = div64_u64((u64)req_vm->hsw * dispc_pck,
+                hsa = div64_u64((u64)req_vm->hsync_len * dispc_pck,
                                 req_pck_nom);
                 hsa = max(hsa, 1);
         } else {
                 hsa = 1;
         }
 
-        hbp = div64_u64((u64)req_vm->hbp * dispc_pck, req_pck_nom);
+        hbp = div64_u64((u64)req_vm->hback_porch * dispc_pck, req_pck_nom);
         hbp = max(hbp, 1);
 
         hfp = dispc_hbl - hsa - hbp;
@@ -4685,9 +4691,9 @@ static bool dsi_vm_calc_blanking(struct dsi_clk_calc_ctx *ctx)
         if (hfp < 1)
                 return false;
 
-        dispc_vm->hfp = hfp;
-        dispc_vm->hsw = hsa;
-        dispc_vm->hbp = hbp;
+        dispc_vm->hfront_porch = hfp;
+        dispc_vm->hsync_len = hsa;
+        dispc_vm->hback_porch = hbp;
 
         return true;
 }
@@ -4707,9 +4713,9 @@ static bool dsi_vm_calc_dispc_cb(int lckd, int pckd, unsigned long lck,
                 return false;
 
 #ifdef PRINT_VERBOSE_VM_TIMINGS
-        print_dispc_vm("dispc", &ctx->dispc_vm);
+        print_dispc_vm("dispc", &ctx->vm);
         print_dsi_vm("dsi  ", &ctx->dsi_vm);
-        print_dispc_vm("req  ", ctx->config->timings);
+        print_dispc_vm("req  ", ctx->config->vm);
         print_dsi_dispc_vm("act  ", &ctx->dsi_vm);
 #endif
 
@@ -4758,7 +4764,7 @@ static bool dsi_vm_calc(struct dsi_data *dsi,
                 const struct omap_dss_dsi_config *cfg,
                 struct dsi_clk_calc_ctx *ctx)
 {
-        const struct omap_video_timings *t = cfg->timings;
+        const struct videomode *vm = cfg->vm;
         unsigned long clkin;
         unsigned long pll_min;
         unsigned long pll_max;
@@ -4774,9 +4780,9 @@ static bool dsi_vm_calc(struct dsi_data *dsi,
         ctx->config = cfg;
 
         /* these limits should come from the panel driver */
-        ctx->req_pck_min = t->pixelclock - 1000;
-        ctx->req_pck_nom = t->pixelclock;
-        ctx->req_pck_max = t->pixelclock + 1000;
+        ctx->req_pck_min = vm->pixelclock - 1000;
+        ctx->req_pck_nom = vm->pixelclock;
+        ctx->req_pck_max = vm->pixelclock + 1000;
 
         byteclk_min = div64_u64((u64)ctx->req_pck_min * bitspp, ndl * 8);
         pll_min = max(cfg->hs_clk_min * 4, byteclk_min * 4 * 4);
@@ -4833,7 +4839,7 @@ static int dsi_set_config(struct omap_dss_device *dssdev,
         dsi->user_dsi_cinfo = ctx.dsi_cinfo;
         dsi->user_dispc_cinfo = ctx.dispc_cinfo;
 
-        dsi->timings = ctx.dispc_vm;
+        dsi->vm = ctx.vm;
         dsi->vm_timings = ctx.dsi_vm;
 
         mutex_unlock(&dsi->lock);
@@ -5342,7 +5348,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
 
         dsi->phy_base = devm_ioremap(&dsidev->dev, res->start,
                 resource_size(res));
-        if (!dsi->proto_base) {
+        if (!dsi->phy_base) {
                 DSSERR("can't ioremap DSI PHY\n");
                 return -ENOMEM;
         }
@@ -5362,7 +5368,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
 
         dsi->pll_base = devm_ioremap(&dsidev->dev, res->start,
                 resource_size(res));
-        if (!dsi->proto_base) {
+        if (!dsi->pll_base) {
                 DSSERR("can't ioremap DSI PLL\n");
                 return -ENOMEM;
         }
diff --git a/drivers/gpu/drm/omapdrm/dss/dss.h b/drivers/gpu/drm/omapdrm/dss/dss.h
index 4fd06dc41cb3..56493b290731 100644
--- a/drivers/gpu/drm/omapdrm/dss/dss.h
+++ b/drivers/gpu/drm/omapdrm/dss/dss.h
@@ -366,8 +366,7 @@ bool dispc_div_calc(unsigned long dispc,
                 unsigned long pck_min, unsigned long pck_max,
                 dispc_div_calc_func func, void *data);
 
-bool dispc_mgr_timings_ok(enum omap_channel channel,
-                const struct omap_video_timings *timings);
+bool dispc_mgr_timings_ok(enum omap_channel channel, const struct videomode *vm);
 int dispc_calc_clock_rates(unsigned long dispc_fclk_rate,
                 struct dispc_clock_info *cinfo);
 
@@ -390,7 +389,7 @@ void dispc_wb_enable(bool enable);
 bool dispc_wb_is_enabled(void);
 void dispc_wb_set_channel_in(enum dss_writeback_channel channel);
 int dispc_wb_setup(const struct omap_dss_writeback_info *wi,
-                bool mem_to_mem, const struct omap_video_timings *timings);
+                bool mem_to_mem, const struct videomode *vm);
 
 /* VENC */
 int venc_init_platform_driver(void) __init;
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi.h b/drivers/gpu/drm/omapdrm/dss/hdmi.h
index 63e711545865..fb6cccd02374 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi.h
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi.h
@@ -181,7 +181,7 @@ struct hdmi_video_format {
 };
 
 struct hdmi_config {
-        struct omap_video_timings timings;
+        struct videomode vm;
         struct hdmi_avi_infoframe infoframe;
         enum hdmi_core_hdmi_dvi hdmi_dvi_mode;
 };
@@ -298,11 +298,11 @@ int hdmi_wp_set_pll_pwr(struct hdmi_wp_data *wp, enum hdmi_pll_pwr val);
 void hdmi_wp_video_config_format(struct hdmi_wp_data *wp,
                 struct hdmi_video_format *video_fmt);
 void hdmi_wp_video_config_interface(struct hdmi_wp_data *wp,
-                struct omap_video_timings *timings);
+                struct videomode *vm);
 void hdmi_wp_video_config_timing(struct hdmi_wp_data *wp,
-                struct omap_video_timings *timings);
+                struct videomode *vm);
 void hdmi_wp_init_vid_fmt_timings(struct hdmi_video_format *video_fmt,
-                struct omap_video_timings *timings, struct hdmi_config *param);
+                struct videomode *vm, struct hdmi_config *param);
 int hdmi_wp_init(struct platform_device *pdev, struct hdmi_wp_data *wp);
 phys_addr_t hdmi_wp_get_audio_dma_addr(struct hdmi_wp_data *wp);
 
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c b/drivers/gpu/drm/omapdrm/dss/hdmi4.c
index cbd28dfdb86a..e7162c16de2e 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c
@@ -155,7 +155,7 @@ static void hdmi_power_off_core(struct omap_dss_device *dssdev)
 static int hdmi_power_on_full(struct omap_dss_device *dssdev)
 {
         int r;
-        struct omap_video_timings *p;
+        struct videomode *vm;
         enum omap_channel channel = dssdev->dispc_channel;
         struct hdmi_wp_data *wp = &hdmi.wp;
         struct dss_pll_clock_info hdmi_cinfo = { 0 };
@@ -169,12 +169,13 @@ static int hdmi_power_on_full(struct omap_dss_device *dssdev)
         hdmi_wp_clear_irqenable(wp, 0xffffffff);
         hdmi_wp_set_irqstatus(wp, 0xffffffff);
 
-        p = &hdmi.cfg.timings;
+        vm = &hdmi.cfg.vm;
 
-        DSSDBG("hdmi_power_on x_res= %d y_res = %d\n", p->x_res, p->y_res);
+        DSSDBG("hdmi_power_on hactive= %d vactive = %d\n", vm->hactive,
+               vm->vactive);
 
-        pc = p->pixelclock;
-        if (p->double_pixel)
+        pc = vm->pixelclock;
+        if (vm->flags & DISPLAY_FLAGS_DOUBLECLK)
                 pc *= 2;
 
         /* DSS_HDMI_TCLK is bitclk / 10 */
@@ -209,7 +210,7 @@ static int hdmi_power_on_full(struct omap_dss_device *dssdev)
         hdmi4_configure(&hdmi.core, &hdmi.wp, &hdmi.cfg);
 
         /* tv size */
-        dss_mgr_set_timings(channel, p);
+        dss_mgr_set_timings(channel, vm);
 
         r = dss_mgr_enable(channel);
         if (r)
@@ -255,30 +256,30 @@ static void hdmi_power_off_full(struct omap_dss_device *dssdev)
 }
 
 static int hdmi_display_check_timing(struct omap_dss_device *dssdev,
-                                        struct omap_video_timings *timings)
+                                     struct videomode *vm)
 {
-        if (!dispc_mgr_timings_ok(dssdev->dispc_channel, timings))
+        if (!dispc_mgr_timings_ok(dssdev->dispc_channel, vm))
                 return -EINVAL;
 
         return 0;
 }
 
 static void hdmi_display_set_timing(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                    struct videomode *vm)
 {
         mutex_lock(&hdmi.lock);
 
-        hdmi.cfg.timings = *timings;
+        hdmi.cfg.vm = *vm;
 
-        dispc_set_tv_pclk(timings->pixelclock);
+        dispc_set_tv_pclk(vm->pixelclock);
 
         mutex_unlock(&hdmi.lock);
 }
 
 static void hdmi_display_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                     struct videomode *vm)
 {
-        *timings = hdmi.cfg.timings;
+        *vm = hdmi.cfg.vm;
 }
 
 static void hdmi_dump_regs(struct seq_file *s)
@@ -352,7 +353,7 @@ static int hdmi_display_enable(struct omap_dss_device *dssdev)
 
         if (hdmi.audio_configured) {
                 r = hdmi4_audio_config(&hdmi.core, &hdmi.wp, &hdmi.audio_config,
-                                       hdmi.cfg.timings.pixelclock);
+                                       hdmi.cfg.vm.pixelclock);
                 if (r) {
                         DSSERR("Error restoring audio configuration: %d", r);
                         hdmi.audio_abort_cb(&hdmi.pdev->dev);
@@ -643,7 +644,7 @@ static int hdmi_audio_config(struct device *dev,
         }
 
         ret = hdmi4_audio_config(&hd->core, &hd->wp, dss_audio,
-                                 hd->cfg.timings.pixelclock);
+                                 hd->cfg.vm.pixelclock);
         if (!ret) {
                 hd->audio_configured = true;
                 hd->audio_config = *dss_audio;
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c
index ef3afe99e487..e05b7ac4f7dd 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c
@@ -310,7 +310,7 @@ void hdmi4_configure(struct hdmi_core_data *core,
         struct hdmi_wp_data *wp, struct hdmi_config *cfg)
 {
         /* HDMI */
-        struct omap_video_timings video_timing;
+        struct videomode vm;
         struct hdmi_video_format video_format;
         /* HDMI core */
         struct hdmi_core_video_config v_core_cfg;
@@ -318,16 +318,16 @@ void hdmi4_configure(struct hdmi_core_data *core,
 
         hdmi_core_init(&v_core_cfg);
 
-        hdmi_wp_init_vid_fmt_timings(&video_format, &video_timing, cfg);
+        hdmi_wp_init_vid_fmt_timings(&video_format, &vm, cfg);
 
-        hdmi_wp_video_config_timing(wp, &video_timing);
+        hdmi_wp_video_config_timing(wp, &vm);
 
         /* video config */
         video_format.packing_mode = HDMI_PACK_24b_RGB_YUV444_YUV422;
 
         hdmi_wp_video_config_format(wp, &video_format);
 
-        hdmi_wp_video_config_interface(wp, &video_timing);
+        hdmi_wp_video_config_interface(wp, &vm);
 
         /*
          * configure core video part
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c b/drivers/gpu/drm/omapdrm/dss/hdmi5.c
index 0c0a5139a301..678dfb02764a 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi5.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi5.c
@@ -172,7 +172,7 @@ static void hdmi_power_off_core(struct omap_dss_device *dssdev)
 static int hdmi_power_on_full(struct omap_dss_device *dssdev)
 {
         int r;
-        struct omap_video_timings *p;
+        struct videomode *vm;
         enum omap_channel channel = dssdev->dispc_channel;
         struct dss_pll_clock_info hdmi_cinfo = { 0 };
         unsigned pc;
@@ -181,12 +181,13 @@ static int hdmi_power_on_full(struct omap_dss_device *dssdev)
         if (r)
                 return r;
 
-        p = &hdmi.cfg.timings;
+        vm = &hdmi.cfg.vm;
 
-        DSSDBG("hdmi_power_on x_res= %d y_res = %d\n", p->x_res, p->y_res);
+        DSSDBG("hdmi_power_on hactive= %d vactive = %d\n", vm->hactive,
+               vm->vactive);
 
-        pc = p->pixelclock;
-        if (p->double_pixel)
+        pc = vm->pixelclock;
+        if (vm->flags & DISPLAY_FLAGS_DOUBLECLK)
                 pc *= 2;
 
         /* DSS_HDMI_TCLK is bitclk / 10 */
@@ -226,7 +227,7 @@ static int hdmi_power_on_full(struct omap_dss_device *dssdev)
         hdmi5_configure(&hdmi.core, &hdmi.wp, &hdmi.cfg);
 
         /* tv size */
-        dss_mgr_set_timings(channel, p);
+        dss_mgr_set_timings(channel, vm);
 
         r = dss_mgr_enable(channel);
         if (r)
@@ -272,30 +273,30 @@ static void hdmi_power_off_full(struct omap_dss_device *dssdev)
 }
 
 static int hdmi_display_check_timing(struct omap_dss_device *dssdev,
-                                        struct omap_video_timings *timings)
+                                     struct videomode *vm)
 {
-        if (!dispc_mgr_timings_ok(dssdev->dispc_channel, timings))
+        if (!dispc_mgr_timings_ok(dssdev->dispc_channel, vm))
                 return -EINVAL;
 
         return 0;
 }
 
 static void hdmi_display_set_timing(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                    struct videomode *vm)
 {
         mutex_lock(&hdmi.lock);
 
-        hdmi.cfg.timings = *timings;
+        hdmi.cfg.vm = *vm;
 
-        dispc_set_tv_pclk(timings->pixelclock);
+        dispc_set_tv_pclk(vm->pixelclock);
 
         mutex_unlock(&hdmi.lock);
 }
 
 static void hdmi_display_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                                     struct videomode *vm)
 {
-        *timings = hdmi.cfg.timings;
+        *vm = hdmi.cfg.vm;
 }
 
 static void hdmi_dump_regs(struct seq_file *s)
@@ -378,7 +379,7 @@ static int hdmi_display_enable(struct omap_dss_device *dssdev)
 
         if (hdmi.audio_configured) {
                 r = hdmi5_audio_config(&hdmi.core, &hdmi.wp, &hdmi.audio_config,
-                                       hdmi.cfg.timings.pixelclock);
+                                       hdmi.cfg.vm.pixelclock);
                 if (r) {
                         DSSERR("Error restoring audio configuration: %d", r);
                         hdmi.audio_abort_cb(&hdmi.pdev->dev);
@@ -669,7 +670,7 @@ static int hdmi_audio_config(struct device *dev,
         }
 
         ret = hdmi5_audio_config(&hd->core, &hd->wp, dss_audio,
-                                 hd->cfg.timings.pixelclock);
+                                 hd->cfg.vm.pixelclock);
 
         if (!ret) {
                 hd->audio_configured = true;
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c
index 8ab2093daa12..8de1d7b2ae55 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c
@@ -292,35 +292,35 @@ static void hdmi_core_init(struct hdmi_core_vid_config *video_cfg,
 {
         DSSDBG("hdmi_core_init\n");
 
-        video_cfg->v_fc_config.timings = cfg->timings;
+        video_cfg->v_fc_config.vm = cfg->vm;
 
         /* video core */
         video_cfg->data_enable_pol = 1; /* It is always 1*/
-        video_cfg->hblank = cfg->timings.hfp +
-                                cfg->timings.hbp + cfg->timings.hsw;
+        video_cfg->hblank = cfg->vm.hfront_porch +
+                            cfg->vm.hback_porch + cfg->vm.hsync_len;
         video_cfg->vblank_osc = 0;
-        video_cfg->vblank = cfg->timings.vsw +
-                                cfg->timings.vfp + cfg->timings.vbp;
+        video_cfg->vblank = cfg->vm.vsync_len + cfg->vm.vfront_porch +
+                            cfg->vm.vback_porch;
         video_cfg->v_fc_config.hdmi_dvi_mode = cfg->hdmi_dvi_mode;
 
-        if (cfg->timings.interlace) {
+        if (cfg->vm.flags & DISPLAY_FLAGS_INTERLACED) {
                 /* set vblank_osc if vblank is fractional */
                 if (video_cfg->vblank % 2 != 0)
                         video_cfg->vblank_osc = 1;
 
-                video_cfg->v_fc_config.timings.y_res /= 2;
+                video_cfg->v_fc_config.vm.vactive /= 2;
                 video_cfg->vblank /= 2;
-                video_cfg->v_fc_config.timings.vfp /= 2;
-                video_cfg->v_fc_config.timings.vsw /= 2;
-                video_cfg->v_fc_config.timings.vbp /= 2;
+                video_cfg->v_fc_config.vm.vfront_porch /= 2;
+                video_cfg->v_fc_config.vm.vsync_len /= 2;
+                video_cfg->v_fc_config.vm.vback_porch /= 2;
         }
 
-        if (cfg->timings.double_pixel) {
-                video_cfg->v_fc_config.timings.x_res *= 2;
+        if (cfg->vm.flags & DISPLAY_FLAGS_DOUBLECLK) {
+                video_cfg->v_fc_config.vm.hactive *= 2;
                 video_cfg->hblank *= 2;
-                video_cfg->v_fc_config.timings.hfp *= 2;
-                video_cfg->v_fc_config.timings.hsw *= 2;
-                video_cfg->v_fc_config.timings.hbp *= 2;
+                video_cfg->v_fc_config.vm.hfront_porch *= 2;
+                video_cfg->v_fc_config.vm.hsync_len *= 2;
+                video_cfg->v_fc_config.vm.hback_porch *= 2;
         }
 }
 
@@ -329,13 +329,12 @@ static void hdmi_core_video_config(struct hdmi_core_data *core,
                         struct hdmi_core_vid_config *cfg)
 {
         void __iomem *base = core->base;
+        struct videomode *vm = &cfg->v_fc_config.vm;
         unsigned char r = 0;
         bool vsync_pol, hsync_pol;
 
-        vsync_pol =
-                cfg->v_fc_config.timings.vsync_level == OMAPDSS_SIG_ACTIVE_HIGH;
-        hsync_pol =
-                cfg->v_fc_config.timings.hsync_level == OMAPDSS_SIG_ACTIVE_HIGH;
+        vsync_pol = !!(vm->flags & DISPLAY_FLAGS_VSYNC_HIGH);
+        hsync_pol = !!(vm->flags & DISPLAY_FLAGS_HSYNC_HIGH);
 
         /* Set hsync, vsync and data-enable polarity  */
         r = hdmi_read_reg(base, HDMI_CORE_FC_INVIDCONF);
@@ -343,20 +342,16 @@ static void hdmi_core_video_config(struct hdmi_core_data *core,
         r = FLD_MOD(r, hsync_pol, 5, 5);
         r = FLD_MOD(r, cfg->data_enable_pol, 4, 4);
         r = FLD_MOD(r, cfg->vblank_osc, 1, 1);
-        r = FLD_MOD(r, cfg->v_fc_config.timings.interlace, 0, 0);
+        r = FLD_MOD(r, !!(vm->flags & DISPLAY_FLAGS_INTERLACED), 0, 0);
         hdmi_write_reg(base, HDMI_CORE_FC_INVIDCONF, r);
 
         /* set x resolution */
-        REG_FLD_MOD(base, HDMI_CORE_FC_INHACTIV1,
-                        cfg->v_fc_config.timings.x_res >> 8, 4, 0);
-        REG_FLD_MOD(base, HDMI_CORE_FC_INHACTIV0,
-                        cfg->v_fc_config.timings.x_res & 0xFF, 7, 0);
+        REG_FLD_MOD(base, HDMI_CORE_FC_INHACTIV1, vm->hactive >> 8, 4, 0);
+        REG_FLD_MOD(base, HDMI_CORE_FC_INHACTIV0, vm->hactive & 0xFF, 7, 0);
 
         /* set y resolution */
-        REG_FLD_MOD(base, HDMI_CORE_FC_INVACTIV1,
-                        cfg->v_fc_config.timings.y_res >> 8, 4, 0);
-        REG_FLD_MOD(base, HDMI_CORE_FC_INVACTIV0,
-                        cfg->v_fc_config.timings.y_res & 0xFF, 7, 0);
+        REG_FLD_MOD(base, HDMI_CORE_FC_INVACTIV1, vm->vactive >> 8, 4, 0);
+        REG_FLD_MOD(base, HDMI_CORE_FC_INVACTIV0, vm->vactive & 0xFF, 7, 0);
 
         /* set horizontal blanking pixels */
         REG_FLD_MOD(base, HDMI_CORE_FC_INHBLANK1, cfg->hblank >> 8, 4, 0);
@@ -366,30 +361,28 @@ static void hdmi_core_video_config(struct hdmi_core_data *core,
         REG_FLD_MOD(base, HDMI_CORE_FC_INVBLANK, cfg->vblank, 7, 0);
 
         /* set horizontal sync offset */
-        REG_FLD_MOD(base, HDMI_CORE_FC_HSYNCINDELAY1,
-                        cfg->v_fc_config.timings.hfp >> 8, 4, 0);
-        REG_FLD_MOD(base, HDMI_CORE_FC_HSYNCINDELAY0,
-                        cfg->v_fc_config.timings.hfp & 0xFF, 7, 0);
+        REG_FLD_MOD(base, HDMI_CORE_FC_HSYNCINDELAY1, vm->hfront_porch >> 8,
+                    4, 0);
+        REG_FLD_MOD(base, HDMI_CORE_FC_HSYNCINDELAY0, vm->hfront_porch & 0xFF,
+                    7, 0);
 
         /* set vertical sync offset */
-        REG_FLD_MOD(base, HDMI_CORE_FC_VSYNCINDELAY,
-                        cfg->v_fc_config.timings.vfp, 7, 0);
+        REG_FLD_MOD(base, HDMI_CORE_FC_VSYNCINDELAY, vm->vfront_porch, 7, 0);
 
         /* set horizontal sync pulse width */
-        REG_FLD_MOD(base, HDMI_CORE_FC_HSYNCINWIDTH1,
-                        (cfg->v_fc_config.timings.hsw >> 8), 1, 0);
-        REG_FLD_MOD(base, HDMI_CORE_FC_HSYNCINWIDTH0,
-                        cfg->v_fc_config.timings.hsw & 0xFF, 7, 0);
+        REG_FLD_MOD(base, HDMI_CORE_FC_HSYNCINWIDTH1, (vm->hsync_len >> 8),
+                    1, 0);
+        REG_FLD_MOD(base, HDMI_CORE_FC_HSYNCINWIDTH0, vm->hsync_len & 0xFF,
+                    7, 0);
 
         /*  set vertical sync pulse width */
-        REG_FLD_MOD(base, HDMI_CORE_FC_VSYNCINWIDTH,
-                        cfg->v_fc_config.timings.vsw, 5, 0);
+        REG_FLD_MOD(base, HDMI_CORE_FC_VSYNCINWIDTH, vm->vsync_len, 5, 0);
 
         /* select DVI mode */
         REG_FLD_MOD(base, HDMI_CORE_FC_INVIDCONF,
-                        cfg->v_fc_config.hdmi_dvi_mode, 3, 3);
+                    cfg->v_fc_config.hdmi_dvi_mode, 3, 3);
 
-        if (cfg->v_fc_config.timings.double_pixel)
+        if (vm->flags & DISPLAY_FLAGS_DOUBLECLK)
                 REG_FLD_MOD(base, HDMI_CORE_FC_PRCONF, 2, 7, 4);
         else
                 REG_FLD_MOD(base, HDMI_CORE_FC_PRCONF, 1, 7, 4);
@@ -616,7 +609,7 @@ int hdmi5_core_handle_irqs(struct hdmi_core_data *core)
 void hdmi5_configure(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
                 struct hdmi_config *cfg)
 {
-        struct omap_video_timings video_timing;
+        struct videomode vm;
         struct hdmi_video_format video_format;
         struct hdmi_core_vid_config v_core_cfg;
 
@@ -624,16 +617,16 @@ void hdmi5_configure(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
 
         hdmi_core_init(&v_core_cfg, cfg);
 
-        hdmi_wp_init_vid_fmt_timings(&video_format, &video_timing, cfg);
+        hdmi_wp_init_vid_fmt_timings(&video_format, &vm, cfg);
 
-        hdmi_wp_video_config_timing(wp, &video_timing);
+        hdmi_wp_video_config_timing(wp, &vm);
 
         /* video config */
         video_format.packing_mode = HDMI_PACK_24b_RGB_YUV444_YUV422;
 
         hdmi_wp_video_config_format(wp, &video_format);
 
-        hdmi_wp_video_config_interface(wp, &video_timing);
+        hdmi_wp_video_config_interface(wp, &vm);
 
         /* support limited range with 24 bit color depth for now */
         hdmi_core_configure_range(core);
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi_wp.c b/drivers/gpu/drm/omapdrm/dss/hdmi_wp.c
index 203694a52d18..b783d5a0750e 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi_wp.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi_wp.c
@@ -144,87 +144,84 @@ void hdmi_wp_video_config_format(struct hdmi_wp_data *wp,
 }
 
 void hdmi_wp_video_config_interface(struct hdmi_wp_data *wp,
-                struct omap_video_timings *timings)
+                                    struct videomode *vm)
 {
         u32 r;
         bool vsync_pol, hsync_pol;
         DSSDBG("Enter hdmi_wp_video_config_interface\n");
 
-        vsync_pol = timings->vsync_level == OMAPDSS_SIG_ACTIVE_HIGH;
-        hsync_pol = timings->hsync_level == OMAPDSS_SIG_ACTIVE_HIGH;
+        vsync_pol = !!(vm->flags & DISPLAY_FLAGS_VSYNC_HIGH);
+        hsync_pol = !!(vm->flags & DISPLAY_FLAGS_HSYNC_HIGH);
 
         r = hdmi_read_reg(wp->base, HDMI_WP_VIDEO_CFG);
         r = FLD_MOD(r, vsync_pol, 7, 7);
         r = FLD_MOD(r, hsync_pol, 6, 6);
-        r = FLD_MOD(r, timings->interlace, 3, 3);
+        r = FLD_MOD(r, !!(vm->flags & DISPLAY_FLAGS_INTERLACED), 3, 3);
         r = FLD_MOD(r, 1, 1, 0); /* HDMI_TIMING_MASTER_24BIT */
         hdmi_write_reg(wp->base, HDMI_WP_VIDEO_CFG, r);
 }
 
 void hdmi_wp_video_config_timing(struct hdmi_wp_data *wp,
-                struct omap_video_timings *timings)
+                                 struct videomode *vm)
 {
         u32 timing_h = 0;
         u32 timing_v = 0;
-        unsigned hsw_offset = 1;
+        unsigned hsync_len_offset = 1;
 
         DSSDBG("Enter hdmi_wp_video_config_timing\n");
 
         /*
          * On OMAP4 and OMAP5 ES1 the HSW field is programmed as is. On OMAP5
-         * ES2+ (including DRA7/AM5 SoCs) HSW field is programmed to hsw-1.
+         * ES2+ (including DRA7/AM5 SoCs) HSW field is programmed to hsync_len-1.
          * However, we don't support OMAP5 ES1 at all, so we can just check for
          * OMAP4 here.
          */
         if (omapdss_get_version() == OMAPDSS_VER_OMAP4430_ES1 ||
             omapdss_get_version() == OMAPDSS_VER_OMAP4430_ES2 ||
             omapdss_get_version() == OMAPDSS_VER_OMAP4)
-                hsw_offset = 0;
+                hsync_len_offset = 0;
 
-        timing_h |= FLD_VAL(timings->hbp, 31, 20);
-        timing_h |= FLD_VAL(timings->hfp, 19, 8);
-        timing_h |= FLD_VAL(timings->hsw - hsw_offset, 7, 0);
+        timing_h |= FLD_VAL(vm->hback_porch, 31, 20);
+        timing_h |= FLD_VAL(vm->hfront_porch, 19, 8);
+        timing_h |= FLD_VAL(vm->hsync_len - hsync_len_offset, 7, 0);
         hdmi_write_reg(wp->base, HDMI_WP_VIDEO_TIMING_H, timing_h);
 
-        timing_v |= FLD_VAL(timings->vbp, 31, 20);
-        timing_v |= FLD_VAL(timings->vfp, 19, 8);
-        timing_v |= FLD_VAL(timings->vsw, 7, 0);
+        timing_v |= FLD_VAL(vm->vback_porch, 31, 20);
+        timing_v |= FLD_VAL(vm->vfront_porch, 19, 8);
+        timing_v |= FLD_VAL(vm->vsync_len, 7, 0);
         hdmi_write_reg(wp->base, HDMI_WP_VIDEO_TIMING_V, timing_v);
 }
 
 void hdmi_wp_init_vid_fmt_timings(struct hdmi_video_format *video_fmt,
-                struct omap_video_timings *timings, struct hdmi_config *param)
+                struct videomode *vm, struct hdmi_config *param)
 {
         DSSDBG("Enter hdmi_wp_video_init_format\n");
 
         video_fmt->packing_mode = HDMI_PACK_10b_RGB_YUV444;
-        video_fmt->y_res = param->timings.y_res;
-        video_fmt->x_res = param->timings.x_res;
-
-        timings->hbp = param->timings.hbp;
-        timings->hfp = param->timings.hfp;
-        timings->hsw = param->timings.hsw;
-        timings->vbp = param->timings.vbp;
-        timings->vfp = param->timings.vfp;
-        timings->vsw = param->timings.vsw;
-
-        timings->vsync_level = param->timings.vsync_level;
-        timings->hsync_level = param->timings.hsync_level;
-        timings->interlace = param->timings.interlace;
-        timings->double_pixel = param->timings.double_pixel;
-
-        if (param->timings.interlace) {
+        video_fmt->y_res = param->vm.vactive;
+        video_fmt->x_res = param->vm.hactive;
+
+        vm->hback_porch = param->vm.hback_porch;
+        vm->hfront_porch = param->vm.hfront_porch;
+        vm->hsync_len = param->vm.hsync_len;
+        vm->vback_porch = param->vm.vback_porch;
+        vm->vfront_porch = param->vm.vfront_porch;
+        vm->vsync_len = param->vm.vsync_len;
+
+        vm->flags = param->vm.flags;
+
+        if (param->vm.flags & DISPLAY_FLAGS_INTERLACED) {
                 video_fmt->y_res /= 2;
-                timings->vbp /= 2;
-                timings->vfp /= 2;
-                timings->vsw /= 2;
+                vm->vback_porch /= 2;
+                vm->vfront_porch /= 2;
+                vm->vsync_len /= 2;
         }
 
-        if (param->timings.double_pixel) {
+        if (param->vm.flags & DISPLAY_FLAGS_DOUBLECLK) {
                 video_fmt->x_res *= 2;
-                timings->hfp *= 2;
-                timings->hsw *= 2;
-                timings->hbp *= 2;
+                vm->hfront_porch *= 2;
+                vm->hsync_len *= 2;
+                vm->hback_porch *= 2;
         }
 }
 
diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
index 6eaf1adbd606..b420dde8c0fb 100644
--- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
+++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
@@ -290,7 +290,7 @@ struct omap_dss_dsi_videomode_timings {
 struct omap_dss_dsi_config {
         enum omap_dss_dsi_mode mode;
         enum omap_dss_dsi_pixel_format pixel_format;
-        const struct omap_video_timings *timings;
+        const struct videomode *vm;
 
         unsigned long hs_clk_min, hs_clk_max;
         unsigned long lp_clk_min, lp_clk_max;
@@ -299,48 +299,12 @@ struct omap_dss_dsi_config {
         enum omap_dss_dsi_trans_mode trans_mode;
 };
 
-struct omap_video_timings {
-        /* Unit: pixels */
-        u16 x_res;
-        /* Unit: pixels */
-        u16 y_res;
-        /* Unit: Hz */
-        u32 pixelclock;
-        /* Unit: pixel clocks */
-        u16 hsw;        /* Horizontal synchronization pulse width */
-        /* Unit: pixel clocks */
-        u16 hfp;        /* Horizontal front porch */
-        /* Unit: pixel clocks */
-        u16 hbp;        /* Horizontal back porch */
-        /* Unit: line clocks */
-        u16 vsw;        /* Vertical synchronization pulse width */
-        /* Unit: line clocks */
-        u16 vfp;        /* Vertical front porch */
-        /* Unit: line clocks */
-        u16 vbp;        /* Vertical back porch */
-
-        /* Vsync logic level */
-        enum omap_dss_signal_level vsync_level;
-        /* Hsync logic level */
-        enum omap_dss_signal_level hsync_level;
-        /* Interlaced or Progressive timings */
-        bool interlace;
-        /* Pixel clock edge to drive LCD data */
-        enum omap_dss_signal_edge data_pclk_edge;
-        /* Data enable logic level */
-        enum omap_dss_signal_level de_level;
-        /* Pixel clock edges to drive HSYNC and VSYNC signals */
-        enum omap_dss_signal_edge sync_pclk_edge;
-
-        bool double_pixel;
-};
-
-/* Hardcoded timings for tv modes. Venc only uses these to
+/* Hardcoded videomodes for tv. Venc only uses these to
  * identify the mode, and does not actually use the configs
  * itself. However, the configs should be something that
  * a normal monitor can also show */
-extern const struct omap_video_timings omap_dss_pal_timings;
-extern const struct omap_video_timings omap_dss_ntsc_timings;
+extern const struct videomode omap_dss_pal_vm;
+extern const struct videomode omap_dss_ntsc_vm;
 
 struct omap_dss_cpr_coefs {
         s16 rr, rg, rb;
@@ -502,11 +466,11 @@ struct omapdss_dpi_ops {
         void (*disable)(struct omap_dss_device *dssdev);
 
         int (*check_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                             struct videomode *vm);
         void (*set_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                            struct videomode *vm);
         void (*get_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                            struct videomode *vm);
 
         void (*set_data_lines)(struct omap_dss_device *dssdev, int data_lines);
 };
@@ -521,11 +485,11 @@ struct omapdss_sdi_ops {
         void (*disable)(struct omap_dss_device *dssdev);
 
         int (*check_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                             struct videomode *vm);
         void (*set_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                            struct videomode *vm);
         void (*get_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                            struct videomode *vm);
 
         void (*set_datapairs)(struct omap_dss_device *dssdev, int datapairs);
 };
@@ -540,11 +504,11 @@ struct omapdss_dvi_ops {
         void (*disable)(struct omap_dss_device *dssdev);
 
         int (*check_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                             struct videomode *vm);
         void (*set_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                            struct videomode *vm);
         void (*get_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                            struct videomode *vm);
 };
 
 struct omapdss_atv_ops {
@@ -557,11 +521,11 @@ struct omapdss_atv_ops {
         void (*disable)(struct omap_dss_device *dssdev);
 
         int (*check_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                             struct videomode *vm);
         void (*set_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                            struct videomode *vm);
         void (*get_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                            struct videomode *vm);
 
         void (*set_type)(struct omap_dss_device *dssdev,
                 enum omap_dss_venc_type type);
@@ -582,11 +546,11 @@ struct omapdss_hdmi_ops {
         void (*disable)(struct omap_dss_device *dssdev);
 
         int (*check_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                             struct videomode *vm);
         void (*set_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                            struct videomode *vm);
         void (*get_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                            struct videomode *vm);
 
         int (*read_edid)(struct omap_dss_device *dssdev, u8 *buf, int len);
         bool (*detect)(struct omap_dss_device *dssdev);
@@ -692,7 +656,7 @@ struct omap_dss_device {
         } phy;
 
         struct {
-                struct omap_video_timings timings;
+                struct videomode vm;
 
                 enum omap_dss_dsi_pixel_format dsi_pix_fmt;
                 enum omap_dss_dsi_mode dsi_mode;
@@ -785,11 +749,11 @@ struct omap_dss_driver {
         int (*get_recommended_bpp)(struct omap_dss_device *dssdev);
 
         int (*check_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                             struct videomode *vm);
         void (*set_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                            struct videomode *vm);
         void (*get_timings)(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings);
+                            struct videomode *vm);
 
         int (*set_wss)(struct omap_dss_device *dssdev, u32 wss);
         u32 (*get_wss)(struct omap_dss_device *dssdev);
@@ -819,11 +783,6 @@ struct omap_dss_device *omap_dss_find_device(void *data,
                 int (*match)(struct omap_dss_device *dssdev, void *data));
 const char *omapdss_get_default_display_name(void);
 
-void videomode_to_omap_video_timings(const struct videomode *vm,
-                struct omap_video_timings *ovt);
-void omap_video_timings_to_videomode(const struct omap_video_timings *ovt,
-                struct videomode *vm);
-
 int dss_feat_get_num_mgrs(void);
 int dss_feat_get_num_ovls(void);
 enum omap_color_mode dss_feat_get_supported_color_modes(enum omap_plane plane);
@@ -852,7 +811,7 @@ void omapdss_default_get_resolution(struct omap_dss_device *dssdev,
                 u16 *xres, u16 *yres);
 int omapdss_default_get_recommended_bpp(struct omap_dss_device *dssdev);
 void omapdss_default_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings);
+                                 struct videomode *vm);
 
 typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
 int omap_dispc_register_isr(omap_dispc_isr_t isr, void *arg, u32 mask);
@@ -906,7 +865,7 @@ void dispc_mgr_go(enum omap_channel channel);
 void dispc_mgr_set_lcd_config(enum omap_channel channel,
                 const struct dss_lcd_mgr_config *config);
 void dispc_mgr_set_timings(enum omap_channel channel,
-                const struct omap_video_timings *timings);
+                const struct videomode *vm);
 void dispc_mgr_setup(enum omap_channel channel,
                 const struct omap_overlay_manager_info *info);
 u32 dispc_mgr_gamma_size(enum omap_channel channel);
@@ -919,8 +878,7 @@ bool dispc_ovl_enabled(enum omap_plane plane);
 void dispc_ovl_set_channel_out(enum omap_plane plane,
                 enum omap_channel channel);
 int dispc_ovl_setup(enum omap_plane plane, const struct omap_overlay_info *oi,
-                bool replication, const struct omap_video_timings *mgr_timings,
-                bool mem_to_mem);
+                bool replication, const struct videomode *vm, bool mem_to_mem);
 
 enum omap_dss_output_id dispc_mgr_get_supported_outputs(enum omap_channel channel);
 
@@ -934,7 +892,7 @@ struct dss_mgr_ops {
         int (*enable)(enum omap_channel channel);
         void (*disable)(enum omap_channel channel);
         void (*set_timings)(enum omap_channel channel,
-                        const struct omap_video_timings *timings);
+                        const struct videomode *vm);
         void (*set_lcd_config)(enum omap_channel channel,
                         const struct dss_lcd_mgr_config *config);
         int (*register_framedone_handler)(enum omap_channel channel,
@@ -951,7 +909,7 @@ int dss_mgr_connect(enum omap_channel channel,
 void dss_mgr_disconnect(enum omap_channel channel,
                 struct omap_dss_device *dst);
 void dss_mgr_set_timings(enum omap_channel channel,
-                const struct omap_video_timings *timings);
+                const struct videomode *vm);
 void dss_mgr_set_lcd_config(enum omap_channel channel,
                 const struct dss_lcd_mgr_config *config);
 int dss_mgr_enable(enum omap_channel channel);
diff --git a/drivers/gpu/drm/omapdrm/dss/output.c b/drivers/gpu/drm/omapdrm/dss/output.c
index 24f859488201..a901af5a9bc3 100644
--- a/drivers/gpu/drm/omapdrm/dss/output.c
+++ b/drivers/gpu/drm/omapdrm/dss/output.c
@@ -201,10 +201,9 @@ void dss_mgr_disconnect(enum omap_channel channel,
 }
 EXPORT_SYMBOL(dss_mgr_disconnect);
 
-void dss_mgr_set_timings(enum omap_channel channel,
-                const struct omap_video_timings *timings)
+void dss_mgr_set_timings(enum omap_channel channel, const struct videomode *vm)
 {
-        dss_mgr_ops->set_timings(channel, timings);
+        dss_mgr_ops->set_timings(channel, vm);
 }
 EXPORT_SYMBOL(dss_mgr_set_timings);
 
diff --git a/drivers/gpu/drm/omapdrm/dss/rfbi.c b/drivers/gpu/drm/omapdrm/dss/rfbi.c
index cd53566d75eb..09724757366a 100644
--- a/drivers/gpu/drm/omapdrm/dss/rfbi.c
+++ b/drivers/gpu/drm/omapdrm/dss/rfbi.c
@@ -113,7 +113,7 @@ static struct {
 
         struct semaphore bus_lock;
 
-        struct omap_video_timings timings;
+        struct videomode vm;
         int pixel_size;
         int data_lines;
         struct rfbi_timings intf_timings;
@@ -308,15 +308,15 @@ static int rfbi_transfer_area(struct omap_dss_device *dssdev,
         u32 l;
         int r;
         struct omap_overlay_manager *mgr = rfbi.output.manager;
-        u16 width = rfbi.timings.x_res;
-        u16 height = rfbi.timings.y_res;
+        u16 width = rfbi.vm.hactive;
+        u16 height = rfbi.vm.vactive;
 
         /*BUG_ON(callback == 0);*/
         BUG_ON(rfbi.framedone_callback != NULL);
 
         DSSDBG("rfbi_transfer_area %dx%d\n", width, height);
 
-        dss_mgr_set_timings(mgr, &rfbi.timings);
+        dss_mgr_set_timings(mgr, &rfbi.vm);
 
         r = dss_mgr_enable(mgr);
         if (r)
@@ -777,8 +777,8 @@ static int rfbi_update(struct omap_dss_device *dssdev, void (*callback)(void *),
 
 static void rfbi_set_size(struct omap_dss_device *dssdev, u16 w, u16 h)
 {
-        rfbi.timings.x_res = w;
-        rfbi.timings.y_res = h;
+        rfbi.vm.hactive = w;
+        rfbi.vm.vactive = h;
 }
 
 static void rfbi_set_pixel_size(struct omap_dss_device *dssdev, int pixel_size)
@@ -854,25 +854,30 @@ static void rfbi_config_lcd_manager(struct omap_dss_device *dssdev)
         dss_mgr_set_lcd_config(mgr, &mgr_config);
 
         /*
-         * Set rfbi.timings with default values, the x_res and y_res fields
+         * Set rfbi.timings with default values, the hactive and vactive fields
          * are expected to be already configured by the panel driver via
          * omapdss_rfbi_set_size()
          */
-        rfbi.timings.hsw = 1;
-        rfbi.timings.hfp = 1;
-        rfbi.timings.hbp = 1;
-        rfbi.timings.vsw = 1;
-        rfbi.timings.vfp = 0;
-        rfbi.timings.vbp = 0;
-
-        rfbi.timings.interlace = false;
-        rfbi.timings.hsync_level = OMAPDSS_SIG_ACTIVE_HIGH;
-        rfbi.timings.vsync_level = OMAPDSS_SIG_ACTIVE_HIGH;
-        rfbi.timings.data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE;
-        rfbi.timings.de_level = OMAPDSS_SIG_ACTIVE_HIGH;
-        rfbi.timings.sync_pclk_edge = OMAPDSS_DRIVE_SIG_FALLING_EDGE;
-
-        dss_mgr_set_timings(mgr, &rfbi.timings);
+        rfbi.vm.hsync_len = 1;
+        rfbi.vm.hfront_porch = 1;
+        rfbi.vm.hback_porch = 1;
+        rfbi.vm.vsync_len = 1;
+        rfbi.vm.vfront_porch = 0;
+        rfbi.vm.vback_porch = 0;
+
+        rfbi.vm.flags &= ~DISPLAY_FLAGS_INTERLACED;
+        rfbi.vm.flags &= ~DISPLAY_FLAGS_HSYNC_LOW;
+        rfbi.vm.flags |= DISPLAY_FLAGS_HSYNC_HIGH;
+        rfbi.vm.flags &= ~DISPLAY_FLAGS_VSYNC_LOW;
+        rfbi.vm.flags |= DISPLAY_FLAGS_VSYNC_HIGH;
+        rfbi.vm.flags &= ~DISPLAY_FLAGS_PIXDATA_NEGEDGE;
+        rfbi.vm.flags |= DISPLAY_FLAGS_PIXDATA_POSEDGE;
+        rfbi.vm.flags &= ~DISPLAY_FLAGS_DE_LOW;
+        rfbi.vm.flags |= DISPLAY_FLAGS_DE_HIGH;
+        rfbi.vm.flags &= ~DISPLAY_FLAGS_SYNC_POSEDGE;
+        rfbi.vm.flags |= DISPLAY_FLAGS_SYNC_NEGEDGE;
+
+        dss_mgr_set_timings(mgr, &rfbi.vm);
 }
 
 static int rfbi_display_enable(struct omap_dss_device *dssdev)
diff --git a/drivers/gpu/drm/omapdrm/dss/sdi.c b/drivers/gpu/drm/omapdrm/dss/sdi.c
index 0a96c321ce62..b3bda2d3c08d 100644
--- a/drivers/gpu/drm/omapdrm/dss/sdi.c
+++ b/drivers/gpu/drm/omapdrm/dss/sdi.c
@@ -39,7 +39,7 @@ static struct {
         struct regulator *vdds_sdi_reg;
 
         struct dss_lcd_mgr_config mgr_config;
-        struct omap_video_timings timings;
+        struct videomode vm;
         int datapairs;
 
         struct omap_dss_device output;
@@ -131,7 +131,7 @@ static int sdi_display_enable(struct omap_dss_device *dssdev)
 {
         struct omap_dss_device *out = &sdi.output;
         enum omap_channel channel = dssdev->dispc_channel;
-        struct omap_video_timings *t = &sdi.timings;
+        struct videomode *vm = &sdi.vm;
         unsigned long fck;
         struct dispc_clock_info dispc_cinfo;
         unsigned long pck;
@@ -151,10 +151,9 @@ static int sdi_display_enable(struct omap_dss_device *dssdev)
                 goto err_get_dispc;
 
         /* 15.5.9.1.2 */
-        t->data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE;
-        t->sync_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE;
+        vm->flags |= DISPLAY_FLAGS_PIXDATA_POSEDGE | DISPLAY_FLAGS_SYNC_POSEDGE;
 
-        r = sdi_calc_clock_div(t->pixelclock, &fck, &dispc_cinfo);
+        r = sdi_calc_clock_div(vm->pixelclock, &fck, &dispc_cinfo);
         if (r)
                 goto err_calc_clock_div;
 
@@ -162,15 +161,15 @@ static int sdi_display_enable(struct omap_dss_device *dssdev)
 
         pck = fck / dispc_cinfo.lck_div / dispc_cinfo.pck_div;
 
-        if (pck != t->pixelclock) {
-                DSSWARN("Could not find exact pixel clock. Requested %d Hz, got %lu Hz\n",
-                        t->pixelclock, pck);
+        if (pck != vm->pixelclock) {
+                DSSWARN("Could not find exact pixel clock. Requested %lu Hz, got %lu Hz\n",
+                        vm->pixelclock, pck);
 
-                t->pixelclock = pck;
+                vm->pixelclock = pck;
         }
 
 
-        dss_mgr_set_timings(channel, t);
+        dss_mgr_set_timings(channel, vm);
 
         r = dss_set_fck_rate(fck);
         if (r)
@@ -229,26 +228,26 @@ static void sdi_display_disable(struct omap_dss_device *dssdev)
 }
 
 static void sdi_set_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                            struct videomode *vm)
 {
-        sdi.timings = *timings;
+        sdi.vm = *vm;
 }
 
 static void sdi_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                            struct videomode *vm)
 {
-        *timings = sdi.timings;
+        *vm = sdi.vm;
 }
 
 static int sdi_check_timings(struct omap_dss_device *dssdev,
-                        struct omap_video_timings *timings)
+                             struct videomode *vm)
 {
         enum omap_channel channel = dssdev->dispc_channel;
 
-        if (!dispc_mgr_timings_ok(channel, timings))
+        if (!dispc_mgr_timings_ok(channel, vm))
                 return -EINVAL;
 
-        if (timings->pixelclock == 0)
+        if (vm->pixelclock == 0)
                 return -EINVAL;
 
         return 0;
diff --git a/drivers/gpu/drm/omapdrm/dss/venc.c b/drivers/gpu/drm/omapdrm/dss/venc.c
index 6eedf2118708..d74f7fcc2e46 100644
--- a/drivers/gpu/drm/omapdrm/dss/venc.c
+++ b/drivers/gpu/drm/omapdrm/dss/venc.c
@@ -262,47 +262,41 @@ static const struct venc_config venc_config_pal_bdghi = {
         .fid_ext_start_y__fid_ext_offset_y      = 0x01380005,
 };
 
-const struct omap_video_timings omap_dss_pal_timings = {
-        .x_res          = 720,
-        .y_res          = 574,
+const struct videomode omap_dss_pal_vm = {
+        .hactive        = 720,
+        .vactive        = 574,
         .pixelclock     = 13500000,
-        .hsw            = 64,
-        .hfp            = 12,
-        .hbp            = 68,
-        .vsw            = 5,
-        .vfp            = 5,
-        .vbp            = 41,
-
-        .interlace      = true,
-
-        .hsync_level = OMAPDSS_SIG_ACTIVE_LOW,
-        .vsync_level = OMAPDSS_SIG_ACTIVE_LOW,
-        .data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE,
-        .de_level = OMAPDSS_SIG_ACTIVE_HIGH,
-        .sync_pclk_edge = OMAPDSS_DRIVE_SIG_FALLING_EDGE,
+        .hsync_len      = 64,
+        .hfront_porch   = 12,
+        .hback_porch    = 68,
+        .vsync_len      = 5,
+        .vfront_porch   = 5,
+        .vback_porch    = 41,
+
+        .flags          = DISPLAY_FLAGS_INTERLACED | DISPLAY_FLAGS_HSYNC_LOW |
+                          DISPLAY_FLAGS_VSYNC_LOW | DISPLAY_FLAGS_DE_HIGH |
+                          DISPLAY_FLAGS_PIXDATA_POSEDGE |
+                          DISPLAY_FLAGS_SYNC_NEGEDGE,
 };
-EXPORT_SYMBOL(omap_dss_pal_timings);
+EXPORT_SYMBOL(omap_dss_pal_vm);
 
-const struct omap_video_timings omap_dss_ntsc_timings = {
-        .x_res          = 720,
-        .y_res          = 482,
+const struct videomode omap_dss_ntsc_vm = {
+        .hactive        = 720,
+        .vactive        = 482,
         .pixelclock     = 13500000,
-        .hsw            = 64,
-        .hfp            = 16,
-        .hbp            = 58,
-        .vsw            = 6,
-        .vfp            = 6,
-        .vbp            = 31,
-
-        .interlace      = true,
-
-        .hsync_level = OMAPDSS_SIG_ACTIVE_LOW,
-        .vsync_level = OMAPDSS_SIG_ACTIVE_LOW,
-        .data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE,
-        .de_level = OMAPDSS_SIG_ACTIVE_HIGH,
-        .sync_pclk_edge = OMAPDSS_DRIVE_SIG_FALLING_EDGE,
+        .hsync_len      = 64,
+        .hfront_porch   = 16,
+        .hback_porch    = 58,
+        .vsync_len      = 6,
+        .vfront_porch   = 6,
+        .vback_porch    = 31,
+
+        .flags          = DISPLAY_FLAGS_INTERLACED | DISPLAY_FLAGS_HSYNC_LOW |
+                          DISPLAY_FLAGS_VSYNC_LOW | DISPLAY_FLAGS_DE_HIGH |
+                          DISPLAY_FLAGS_PIXDATA_POSEDGE |
+                          DISPLAY_FLAGS_SYNC_NEGEDGE,
 };
-EXPORT_SYMBOL(omap_dss_ntsc_timings);
+EXPORT_SYMBOL(omap_dss_ntsc_vm);
 
 static struct {
         struct platform_device *pdev;
@@ -313,7 +307,7 @@ static struct {
 
         struct clk      *tv_dac_clk;
 
-        struct omap_video_timings timings;
+        struct videomode vm;
         enum omap_dss_venc_type type;
         bool invert_polarity;
 
@@ -427,13 +421,12 @@ static void venc_runtime_put(void)
         WARN_ON(r < 0 && r != -ENOSYS);
 }
 
-static const struct venc_config *venc_timings_to_config(
-                struct omap_video_timings *timings)
+static const struct venc_config *venc_timings_to_config(struct videomode *vm)
 {
-        if (memcmp(&omap_dss_pal_timings, timings, sizeof(*timings)) == 0)
+        if (memcmp(&omap_dss_pal_vm, vm, sizeof(*vm)) == 0)
                 return &venc_config_pal_trm;
 
-        if (memcmp(&omap_dss_ntsc_timings, timings, sizeof(*timings)) == 0)
+        if (memcmp(&omap_dss_ntsc_vm, vm, sizeof(*vm)) == 0)
                 return &venc_config_ntsc_trm;
 
         BUG();
@@ -451,7 +444,7 @@ static int venc_power_on(struct omap_dss_device *dssdev)
                 goto err0;
 
         venc_reset();
-        venc_write_config(venc_timings_to_config(&venc.timings));
+        venc_write_config(venc_timings_to_config(&venc.vm));
 
         dss_set_venc_output(venc.type);
         dss_set_dac_pwrdn_bgz(1);
@@ -468,7 +461,7 @@ static int venc_power_on(struct omap_dss_device *dssdev)
 
         venc_write_reg(VENC_OUTPUT_CONTROL, l);
 
-        dss_mgr_set_timings(channel, &venc.timings);
+        dss_mgr_set_timings(channel, &venc.vm);
 
         r = regulator_enable(venc.vdda_dac_reg);
         if (r)
@@ -546,17 +539,17 @@ static void venc_display_disable(struct omap_dss_device *dssdev)
 }
 
 static void venc_set_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                             struct videomode *vm)
 {
         DSSDBG("venc_set_timings\n");
 
         mutex_lock(&venc.venc_lock);
 
         /* Reset WSS data when the TV standard changes. */
-        if (memcmp(&venc.timings, timings, sizeof(*timings)))
+        if (memcmp(&venc.vm, vm, sizeof(*vm)))
                 venc.wss_data = 0;
 
-        venc.timings = *timings;
+        venc.vm = *vm;
 
         dispc_set_tv_pclk(13500000);
 
@@ -564,25 +557,25 @@ static void venc_set_timings(struct omap_dss_device *dssdev,
 }
 
 static int venc_check_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                              struct videomode *vm)
 {
         DSSDBG("venc_check_timings\n");
 
-        if (memcmp(&omap_dss_pal_timings, timings, sizeof(*timings)) == 0)
+        if (memcmp(&omap_dss_pal_vm, vm, sizeof(*vm)) == 0)
                 return 0;
 
-        if (memcmp(&omap_dss_ntsc_timings, timings, sizeof(*timings)) == 0)
+        if (memcmp(&omap_dss_ntsc_vm, vm, sizeof(*vm)) == 0)
                 return 0;
 
         return -EINVAL;
 }
 
 static void venc_get_timings(struct omap_dss_device *dssdev,
-                struct omap_video_timings *timings)
+                             struct videomode *vm)
 {
         mutex_lock(&venc.venc_lock);
 
-        *timings = venc.timings;
+        *vm = venc.vm;
 
         mutex_unlock(&venc.venc_lock);
 }
@@ -602,7 +595,7 @@ static int venc_set_wss(struct omap_dss_device *dssdev, u32 wss)
 
         mutex_lock(&venc.venc_lock);
 
-        config = venc_timings_to_config(&venc.timings);
+        config = venc_timings_to_config(&venc.vm);
 
         /* Invert due to VENC_L21_WC_CTL:INV=1 */
         venc.wss_data = (wss ^ 0xfffff) << 8;
diff --git a/drivers/gpu/drm/omapdrm/omap_connector.c b/drivers/gpu/drm/omapdrm/omap_connector.c
index 137fe690a0da..2580e8673908 100644
--- a/drivers/gpu/drm/omapdrm/omap_connector.c
+++ b/drivers/gpu/drm/omapdrm/omap_connector.c
@@ -42,73 +42,6 @@ bool omap_connector_get_hdmi_mode(struct drm_connector *connector)
         return omap_connector->hdmi_mode;
 }
 
-void copy_timings_omap_to_drm(struct drm_display_mode *mode,
-                struct omap_video_timings *timings)
-{
-        mode->clock = timings->pixelclock / 1000;
-
-        mode->hdisplay = timings->x_res;
-        mode->hsync_start = mode->hdisplay + timings->hfp;
-        mode->hsync_end = mode->hsync_start + timings->hsw;
-        mode->htotal = mode->hsync_end + timings->hbp;
-
-        mode->vdisplay = timings->y_res;
-        mode->vsync_start = mode->vdisplay + timings->vfp;
-        mode->vsync_end = mode->vsync_start + timings->vsw;
-        mode->vtotal = mode->vsync_end + timings->vbp;
-
-        mode->flags = 0;
-
-        if (timings->interlace)
-                mode->flags |= DRM_MODE_FLAG_INTERLACE;
-
-        if (timings->double_pixel)
-                mode->flags |= DRM_MODE_FLAG_DBLCLK;
-
-        if (timings->hsync_level == OMAPDSS_SIG_ACTIVE_HIGH)
-                mode->flags |= DRM_MODE_FLAG_PHSYNC;
-        else
-                mode->flags |= DRM_MODE_FLAG_NHSYNC;
-
-        if (timings->vsync_level == OMAPDSS_SIG_ACTIVE_HIGH)
-                mode->flags |= DRM_MODE_FLAG_PVSYNC;
-        else
-                mode->flags |= DRM_MODE_FLAG_NVSYNC;
-}
-
-void copy_timings_drm_to_omap(struct omap_video_timings *timings,
-                struct drm_display_mode *mode)
-{
-        timings->pixelclock = mode->clock * 1000;
-
-        timings->x_res = mode->hdisplay;
-        timings->hfp = mode->hsync_start - mode->hdisplay;
-        timings->hsw = mode->hsync_end - mode->hsync_start;
-        timings->hbp = mode->htotal - mode->hsync_end;
-
-        timings->y_res = mode->vdisplay;
-        timings->vfp = mode->vsync_start - mode->vdisplay;
-        timings->vsw = mode->vsync_end - mode->vsync_start;
-        timings->vbp = mode->vtotal - mode->vsync_end;
-
-        timings->interlace = !!(mode->flags & DRM_MODE_FLAG_INTERLACE);
-        timings->double_pixel = !!(mode->flags & DRM_MODE_FLAG_DBLCLK);
-
-        if (mode->flags & DRM_MODE_FLAG_PHSYNC)
-                timings->hsync_level = OMAPDSS_SIG_ACTIVE_HIGH;
-        else
-                timings->hsync_level = OMAPDSS_SIG_ACTIVE_LOW;
-
-        if (mode->flags & DRM_MODE_FLAG_PVSYNC)
-                timings->vsync_level = OMAPDSS_SIG_ACTIVE_HIGH;
-        else
-                timings->vsync_level = OMAPDSS_SIG_ACTIVE_LOW;
-
-        timings->data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE;
-        timings->de_level = OMAPDSS_SIG_ACTIVE_HIGH;
-        timings->sync_pclk_edge = OMAPDSS_DRIVE_SIG_FALLING_EDGE;
-}
-
 static enum drm_connector_status omap_connector_detect(
                 struct drm_connector *connector, bool force)
 {
@@ -185,11 +118,11 @@ static int omap_connector_get_modes(struct drm_connector *connector)
                 kfree(edid);
         } else {
                 struct drm_display_mode *mode = drm_mode_create(dev);
-                struct omap_video_timings timings = {0};
+                struct videomode vm = {0};
 
-                dssdrv->get_timings(dssdev, &timings);
+                dssdrv->get_timings(dssdev, &vm);
 
-                copy_timings_omap_to_drm(mode, &timings);
+                drm_display_mode_from_videomode(&vm, mode);
 
                 mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
                 drm_mode_set_name(mode);
@@ -207,12 +140,14 @@ static int omap_connector_mode_valid(struct drm_connector *connector,
         struct omap_connector *omap_connector = to_omap_connector(connector);
         struct omap_dss_device *dssdev = omap_connector->dssdev;
         struct omap_dss_driver *dssdrv = dssdev->driver;
-        struct omap_video_timings timings = {0};
+        struct videomode vm = {0};
         struct drm_device *dev = connector->dev;
         struct drm_display_mode *new_mode;
         int r, ret = MODE_BAD;
 
-        copy_timings_drm_to_omap(&timings, mode);
+        drm_display_mode_to_videomode(mode, &vm);
+        vm.flags |= DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
+                    DISPLAY_FLAGS_SYNC_NEGEDGE;
         mode->vrefresh = drm_mode_vrefresh(mode);
 
         /*
@@ -221,13 +156,13 @@ static int omap_connector_mode_valid(struct drm_connector *connector,
          * panel's timings
          */
         if (dssdrv->check_timings) {
-                r = dssdrv->check_timings(dssdev, &timings);
+                r = dssdrv->check_timings(dssdev, &vm);
         } else {
-                struct omap_video_timings t = {0};
+                struct videomode t = {0};
 
                 dssdrv->get_timings(dssdev, &t);
 
-                if (memcmp(&timings, &t, sizeof(struct omap_video_timings)))
+                if (memcmp(&vm, &t, sizeof(struct videomode)))
                         r = -EINVAL;
                 else
                         r = 0;
@@ -236,7 +171,7 @@ static int omap_connector_mode_valid(struct drm_connector *connector,
         if (!r) {
                 /* check if vrefresh is still valid */
                 new_mode = drm_mode_duplicate(dev, mode);
-                new_mode->clock = timings.pixelclock / 1000;
+                new_mode->clock = vm.pixelclock / 1000;
                 new_mode->vrefresh = 0;
                 if (mode->vrefresh == drm_mode_vrefresh(new_mode))
                         ret = MODE_OK;
diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c b/drivers/gpu/drm/omapdrm/omap_crtc.c
index 16c691dbc372..8dea89030e66 100644
--- a/drivers/gpu/drm/omapdrm/omap_crtc.c
+++ b/drivers/gpu/drm/omapdrm/omap_crtc.c
@@ -34,7 +34,7 @@ struct omap_crtc {
         const char *name;
         enum omap_channel channel;
 
-        struct omap_video_timings timings;
+        struct videomode vm;
 
         struct omap_drm_irq vblank_irq;
         struct omap_drm_irq error_irq;
@@ -56,10 +56,10 @@ uint32_t pipe2vbl(struct drm_crtc *crtc)
         return dispc_mgr_get_vsync_irq(omap_crtc->channel);
 }
 
-struct omap_video_timings *omap_crtc_timings(struct drm_crtc *crtc)
+struct videomode *omap_crtc_timings(struct drm_crtc *crtc)
 {
         struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
-        return &omap_crtc->timings;
+        return &omap_crtc->vm;
 }
 
 enum omap_channel omap_crtc_channel(struct drm_crtc *crtc)
@@ -201,7 +201,7 @@ static int omap_crtc_dss_enable(enum omap_channel channel)
 
         dispc_mgr_setup(omap_crtc->channel, &info);
         dispc_mgr_set_timings(omap_crtc->channel,
-                        &omap_crtc->timings);
+                        &omap_crtc->vm);
         omap_crtc_set_enabled(&omap_crtc->base, true);
 
         return 0;
@@ -215,11 +215,11 @@ static void omap_crtc_dss_disable(enum omap_channel channel)
 }
 
 static void omap_crtc_dss_set_timings(enum omap_channel channel,
-                const struct omap_video_timings *timings)
+                const struct videomode *vm)
 {
         struct omap_crtc *omap_crtc = omap_crtcs[channel];
         DBG("%s", omap_crtc->name);
-        omap_crtc->timings = *timings;
+        omap_crtc->vm = *vm;
 }
 
 static void omap_crtc_dss_set_lcd_config(enum omap_channel channel,
@@ -369,7 +369,10 @@ static void omap_crtc_mode_set_nofb(struct drm_crtc *crtc)
             mode->vdisplay, mode->vsync_start, mode->vsync_end, mode->vtotal,
             mode->type, mode->flags);
 
-        copy_timings_drm_to_omap(&omap_crtc->timings, mode);
+        drm_display_mode_to_videomode(mode, &omap_crtc->vm);
+        omap_crtc->vm.flags |= DISPLAY_FLAGS_DE_HIGH |
+                               DISPLAY_FLAGS_PIXDATA_POSEDGE |
+                               DISPLAY_FLAGS_SYNC_NEGEDGE;
 }
 
 static int omap_crtc_atomic_check(struct drm_crtc *crtc,
@@ -411,19 +414,6 @@ static void omap_crtc_atomic_flush(struct drm_crtc *crtc,
                 dispc_mgr_set_gamma(omap_crtc->channel, lut, length);
         }
 
-        if (crtc->state->color_mgmt_changed) {
-                struct drm_color_lut *lut = NULL;
-                uint length = 0;
-
-                if (crtc->state->gamma_lut) {
-                        lut = (struct drm_color_lut *)
-                                crtc->state->gamma_lut->data;
-                        length = crtc->state->gamma_lut->length /
-                                sizeof(*lut);
-                }
-                dispc_mgr_set_gamma(omap_crtc->channel, lut, length);
-        }
-
         if (dispc_mgr_is_enabled(omap_crtc->channel)) {
 
                 DBG("%s: GO", omap_crtc->name);
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h b/drivers/gpu/drm/omapdrm/omap_drv.h
index dcc30a98b9d4..4c51135eb9a6 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.h
+++ b/drivers/gpu/drm/omapdrm/omap_drv.h
@@ -148,7 +148,7 @@ static inline void omap_fbdev_free(struct drm_device *dev)
 }
 #endif
 
-struct omap_video_timings *omap_crtc_timings(struct drm_crtc *crtc);
+struct videomode *omap_crtc_timings(struct drm_crtc *crtc);
 enum omap_channel omap_crtc_channel(struct drm_crtc *crtc);
 void omap_crtc_pre_init(void);
 void omap_crtc_pre_uninit(void);
@@ -171,11 +171,6 @@ struct drm_encoder *omap_connector_attached_encoder(
                 struct drm_connector *connector);
 bool omap_connector_get_hdmi_mode(struct drm_connector *connector);
 
-void copy_timings_omap_to_drm(struct drm_display_mode *mode,
-                struct omap_video_timings *timings);
-void copy_timings_drm_to_omap(struct omap_video_timings *timings,
-                struct drm_display_mode *mode);
-
 uint32_t omap_framebuffer_get_formats(uint32_t *pixel_formats,
                 uint32_t max_formats, enum omap_color_mode supported_modes);
 struct drm_framebuffer *omap_framebuffer_create(struct drm_device *dev,
diff --git a/drivers/gpu/drm/omapdrm/omap_encoder.c b/drivers/gpu/drm/omapdrm/omap_encoder.c
index 0bbb9c59622e..a20f30039aee 100644
--- a/drivers/gpu/drm/omapdrm/omap_encoder.c
+++ b/drivers/gpu/drm/omapdrm/omap_encoder.c
@@ -102,7 +102,7 @@ static void omap_encoder_disable(struct drm_encoder *encoder)
 
 static int omap_encoder_update(struct drm_encoder *encoder,
                                enum omap_channel channel,
-                               struct omap_video_timings *timings)
+                               struct videomode *vm)
 {
         struct drm_device *dev = encoder->dev;
         struct omap_encoder *omap_encoder = to_omap_encoder(encoder);
@@ -111,13 +111,13 @@ static int omap_encoder_update(struct drm_encoder *encoder,
         int ret;
 
         if (dssdrv->check_timings) {
-                ret = dssdrv->check_timings(dssdev, timings);
+                ret = dssdrv->check_timings(dssdev, vm);
         } else {
-                struct omap_video_timings t = {0};
+                struct videomode t = {0};
 
                 dssdrv->get_timings(dssdev, &t);
 
-                if (memcmp(timings, &t, sizeof(struct omap_video_timings)))
+                if (memcmp(vm, &t, sizeof(struct videomode)))
                         ret = -EINVAL;
                 else
                         ret = 0;
@@ -129,7 +129,7 @@ static int omap_encoder_update(struct drm_encoder *encoder,
         }
 
         if (dssdrv->set_timings)
-                dssdrv->set_timings(dssdev, timings);
+                dssdrv->set_timings(dssdev, vm);
 
         return 0;
 }
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
index 505dee0db973..d4e1e11466f8 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.c
+++ b/drivers/gpu/drm/omapdrm/omap_gem.c
@@ -336,8 +336,10 @@ static void omap_gem_detach_pages(struct drm_gem_object *obj)
         if (omap_obj->flags & (OMAP_BO_WC|OMAP_BO_UNCACHED)) {
                 int i, npages = obj->size >> PAGE_SHIFT;
                 for (i = 0; i < npages; i++) {
-                        dma_unmap_page(obj->dev->dev, omap_obj->addrs[i],
-                                        PAGE_SIZE, DMA_BIDIRECTIONAL);
+                        if (omap_obj->addrs[i])
+                                dma_unmap_page(obj->dev->dev,
+                                               omap_obj->addrs[i],
+                                               PAGE_SIZE, DMA_BIDIRECTIONAL);
                 }
         }
 
diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c b/drivers/gpu/drm/omapdrm/omap_plane.c
index 0ffd5b930ec0..9c43cb481e62 100644
--- a/drivers/gpu/drm/omapdrm/omap_plane.c
+++ b/drivers/gpu/drm/omapdrm/omap_plane.c
@@ -131,7 +131,9 @@ static void omap_plane_atomic_update(struct drm_plane *plane,
         /* and finally, update omapdss: */
         ret = dispc_ovl_setup(omap_plane->id, &info, false,
                               omap_crtc_timings(state->crtc), false);
-        if (WARN_ON(ret)) {
+        if (ret) {
+                dev_err(plane->dev->dev, "Failed to setup plane %s\n",
+                        omap_plane->name);
                 dispc_ovl_enable(omap_plane->id, false);
                 return;
         }
@@ -157,12 +159,20 @@ static int omap_plane_atomic_check(struct drm_plane *plane,
 {
         struct drm_crtc_state *crtc_state;
 
-        if (!state->crtc)
+        if (!state->fb)
                 return 0;
 
-        crtc_state = drm_atomic_get_crtc_state(state->state, state->crtc);
-        if (IS_ERR(crtc_state))
-                return PTR_ERR(crtc_state);
+        /* crtc should only be NULL when disabling (i.e., !state->fb) */
+        if (WARN_ON(!state->crtc))
+                return 0;
+
+        crtc_state = drm_atomic_get_existing_crtc_state(state->state, state->crtc);
+        /* we should have a crtc state if the plane is attached to a crtc */
+        if (WARN_ON(!crtc_state))
+                return 0;
+
+        if (!crtc_state->enable)
+                return 0;
 
         if (state->crtc_x < 0 || state->crtc_y < 0)
                 return -EINVAL;
@@ -173,11 +183,9 @@ static int omap_plane_atomic_check(struct drm_plane *plane,
         if (state->crtc_y + state->crtc_h > crtc_state->adjusted_mode.vdisplay)
                 return -EINVAL;
 
-        if (state->fb) {
-                if (state->rotation != DRM_ROTATE_0 &&
-                    !omap_framebuffer_supports_rotation(state->fb))
-                        return -EINVAL;
-        }
+        if (state->rotation != DRM_ROTATE_0 &&
+            !omap_framebuffer_supports_rotation(state->fb))
+                return -EINVAL;
 
         return 0;
 }
diff --git a/drivers/gpu/drm/radeon/ni.c b/drivers/gpu/drm/radeon/ni.c
index 103fc8650197..a0d4a0522fdc 100644
--- a/drivers/gpu/drm/radeon/ni.c
+++ b/drivers/gpu/drm/radeon/ni.c
@@ -1396,9 +1396,7 @@ static void cayman_pcie_gart_fini(struct radeon_device *rdev)
 void cayman_cp_int_cntl_setup(struct radeon_device *rdev,
                               int ring, u32 cp_int_cntl)
 {
-        u32 srbm_gfx_cntl = RREG32(SRBM_GFX_CNTL) & ~3;
-
-        WREG32(SRBM_GFX_CNTL, srbm_gfx_cntl | (ring & 3));
+        WREG32(SRBM_GFX_CNTL, RINGID(ring));
         WREG32(CP_INT_CNTL, cp_int_cntl);
 }
 
diff --git a/drivers/gpu/drm/radeon/radeon_dp_auxch.c b/drivers/gpu/drm/radeon/radeon_dp_auxch.c
index 2d465648856a..474a8a1886f7 100644
--- a/drivers/gpu/drm/radeon/radeon_dp_auxch.c
+++ b/drivers/gpu/drm/radeon/radeon_dp_auxch.c
@@ -105,7 +105,7 @@ radeon_dp_aux_transfer_native(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg
 
         tmp &= AUX_HPD_SEL(0x7);
         tmp |= AUX_HPD_SEL(chan->rec.hpd);
-        tmp |= AUX_EN | AUX_LS_READ_EN | AUX_HPD_DISCON(0x1);
+        tmp |= AUX_EN | AUX_LS_READ_EN;
 
         WREG32(AUX_CONTROL + aux_offset[instance], tmp);
 
diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
index be30861afae9..41b72ce6613f 100644
--- a/drivers/gpu/drm/radeon/radeon_object.c
+++ b/drivers/gpu/drm/radeon/radeon_object.c
@@ -446,6 +446,10 @@ void radeon_bo_force_delete(struct radeon_device *rdev)
 
 int radeon_bo_init(struct radeon_device *rdev)
 {
+        /* reserve PAT memory space to WC for VRAM */
+        arch_io_reserve_memtype_wc(rdev->mc.aper_base,
+                                   rdev->mc.aper_size);
+
         /* Add an MTRR for the VRAM */
         if (!rdev->fastfb_working) {
                 rdev->mc.vram_mtrr = arch_phys_wc_add(rdev->mc.aper_base,
@@ -463,6 +467,7 @@ void radeon_bo_fini(struct radeon_device *rdev)
 {
         radeon_ttm_fini(rdev);
         arch_phys_wc_del(rdev->mc.vram_mtrr);
+        arch_io_free_memtype_wc(rdev->mc.aper_base, rdev->mc.aper_size);
 }
 
 /* Returns how many bytes TTM can move per IB.
diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c
index 89bdf20344ae..c49934527a87 100644
--- a/drivers/gpu/drm/radeon/si_dpm.c
+++ b/drivers/gpu/drm/radeon/si_dpm.c
@@ -2999,6 +2999,49 @@ static void si_apply_state_adjust_rules(struct radeon_device *rdev,
         int i;
         struct si_dpm_quirk *p = si_dpm_quirk_list;
 
+        /* limit all SI kickers */
+        if (rdev->family == CHIP_PITCAIRN) {
+                if ((rdev->pdev->revision == 0x81) ||
+                    (rdev->pdev->device == 0x6810) ||
+                    (rdev->pdev->device == 0x6811) ||
+                    (rdev->pdev->device == 0x6816) ||
+                    (rdev->pdev->device == 0x6817) ||
+                    (rdev->pdev->device == 0x6806))
+                        max_mclk = 120000;
+        } else if (rdev->family == CHIP_VERDE) {
+                if ((rdev->pdev->revision == 0x81) ||
+                    (rdev->pdev->revision == 0x83) ||
+                    (rdev->pdev->revision == 0x87) ||
+                    (rdev->pdev->device == 0x6820) ||
+                    (rdev->pdev->device == 0x6821) ||
+                    (rdev->pdev->device == 0x6822) ||
+                    (rdev->pdev->device == 0x6823) ||
+                    (rdev->pdev->device == 0x682A) ||
+                    (rdev->pdev->device == 0x682B)) {
+                        max_sclk = 75000;
+                        max_mclk = 80000;
+                }
+        } else if (rdev->family == CHIP_OLAND) {
+                if ((rdev->pdev->revision == 0xC7) ||
+                    (rdev->pdev->revision == 0x80) ||
+                    (rdev->pdev->revision == 0x81) ||
+                    (rdev->pdev->revision == 0x83) ||
+                    (rdev->pdev->device == 0x6604) ||
+                    (rdev->pdev->device == 0x6605)) {
+                        max_sclk = 75000;
+                        max_mclk = 80000;
+                }
+        } else if (rdev->family == CHIP_HAINAN) {
+                if ((rdev->pdev->revision == 0x81) ||
+                    (rdev->pdev->revision == 0x83) ||
+                    (rdev->pdev->revision == 0xC3) ||
+                    (rdev->pdev->device == 0x6664) ||
+                    (rdev->pdev->device == 0x6665) ||
+                    (rdev->pdev->device == 0x6667)) {
+                        max_sclk = 75000;
+                        max_mclk = 80000;
+                }
+        }
         /* Apply dpm quirks */
         while (p && p->chip_device != 0) {
                 if (rdev->pdev->vendor == p->chip_vendor &&
@@ -3011,16 +3054,6 @@ static void si_apply_state_adjust_rules(struct radeon_device *rdev,
                 }
                 ++p;
         }
-        /* limit mclk on all R7 370 parts for stability */
-        if (rdev->pdev->device == 0x6811 &&
-            rdev->pdev->revision == 0x81)
-                max_mclk = 120000;
-        /* limit sclk/mclk on Jet parts for stability */
-        if (rdev->pdev->device == 0x6665 &&
-            rdev->pdev->revision == 0xc3) {
-                max_sclk = 75000;
-                max_mclk = 80000;
-        }
 
         if (rps->vce_active) {
                 rps->evclk = rdev->pm.dpm.vce_states[rdev->pm.dpm.vce_level].evclk;
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
index c76ed9ee6a01..4220d621f55f 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
@@ -231,8 +231,16 @@ static int rcar_du_atomic_check(struct drm_device *dev,
         struct rcar_du_device *rcdu = dev->dev_private;
         int ret;
 
-        ret = drm_atomic_helper_check(dev, state);
-        if (ret < 0)
+        ret = drm_atomic_helper_check_modeset(dev, state);
+        if (ret)
+                return ret;
+
+        ret = drm_atomic_normalize_zpos(dev, state);
+        if (ret)
+                return ret;
+
+        ret = drm_atomic_helper_check_planes(dev, state);
+        if (ret)
                 return ret;
 
         if (rcar_du_has(rcdu, RCAR_DU_FEATURE_VSP1_SOURCE))
diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
index 6aead2013b62..d614701bdcc7 100644
--- a/drivers/gpu/drm/sti/sti_drv.c
+++ b/drivers/gpu/drm/sti/sti_drv.c
@@ -196,6 +196,26 @@ static void sti_atomic_work(struct work_struct *work)
         sti_atomic_complete(private, private->commit.state);
 }
 
+static int sti_atomic_check(struct drm_device *dev,
+                            struct drm_atomic_state *state)
+{
+        int ret;
+
+        ret = drm_atomic_helper_check_modeset(dev, state);
+        if (ret)
+                return ret;
+
+        ret = drm_atomic_normalize_zpos(dev, state);
+        if (ret)
+                return ret;
+
+        ret = drm_atomic_helper_check_planes(dev, state);
+        if (ret)
+                return ret;
+
+        return ret;
+}
+
 static int sti_atomic_commit(struct drm_device *drm,
                              struct drm_atomic_state *state, bool nonblock)
 {
@@ -250,7 +270,7 @@ static void sti_output_poll_changed(struct drm_device *ddev)
 static const struct drm_mode_config_funcs sti_mode_config_funcs = {
         .fb_create = drm_fb_cma_create,
         .output_poll_changed = sti_output_poll_changed,
-        .atomic_check = drm_atomic_helper_check,
+        .atomic_check = sti_atomic_check,
         .atomic_commit = sti_atomic_commit,
 };
 
diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
index 7cf3678623c3..58048709c34e 100644
--- a/drivers/gpu/drm/virtio/virtgpu_display.c
+++ b/drivers/gpu/drm/virtio/virtgpu_display.c
@@ -338,8 +338,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state)
 
         drm_atomic_helper_commit_modeset_disables(dev, state);
         drm_atomic_helper_commit_modeset_enables(dev, state);
-        drm_atomic_helper_commit_planes(dev, state,
-                                        DRM_PLANE_COMMIT_ACTIVE_ONLY);
+        drm_atomic_helper_commit_planes(dev, state, 0);
 
         drm_atomic_helper_commit_hw_done(state);
 
diff --git a/drivers/gpu/ipu-v3/ipu-image-convert.c b/drivers/gpu/ipu-v3/ipu-image-convert.c
index 2ba7d437a2af..805b6fa7b5f4 100644
--- a/drivers/gpu/ipu-v3/ipu-image-convert.c
+++ b/drivers/gpu/ipu-v3/ipu-image-convert.c
@@ -1617,7 +1617,7 @@ ipu_image_convert(struct ipu_soc *ipu, enum ipu_ic_task ic_task,
         ctx = ipu_image_convert_prepare(ipu, ic_task, in, out, rot_mode,
                                         complete, complete_context);
         if (IS_ERR(ctx))
-                return ERR_PTR(PTR_ERR(ctx));
+                return ERR_CAST(ctx);
 
         run = kzalloc(sizeof(*run), GFP_KERNEL);
         if (!run) {