diff options
| -rw-r--r-- | include/linux/dma-mapping.h | 9 | ||||
| -rw-r--r-- | scripts/coccinelle/api/alloc/alloc_cast.cocci | 8 | ||||
| -rw-r--r-- | scripts/coccinelle/api/alloc/zalloc-simple.cocci | 11 |
3 files changed, 5 insertions, 23 deletions
diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index cef2127e1d70..f6ded992c183 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h | |||
| @@ -717,15 +717,6 @@ static inline unsigned long dma_max_pfn(struct device *dev) | |||
| 717 | } | 717 | } |
| 718 | #endif | 718 | #endif |
| 719 | 719 | ||
| 720 | /* | ||
| 721 | * Please always use dma_alloc_coherent instead as it already zeroes the memory! | ||
| 722 | */ | ||
| 723 | static inline void *dma_zalloc_coherent(struct device *dev, size_t size, | ||
| 724 | dma_addr_t *dma_handle, gfp_t flag) | ||
| 725 | { | ||
| 726 | return dma_alloc_coherent(dev, size, dma_handle, flag); | ||
| 727 | } | ||
| 728 | |||
| 729 | static inline int dma_get_cache_alignment(void) | 720 | static inline int dma_get_cache_alignment(void) |
| 730 | { | 721 | { |
| 731 | #ifdef ARCH_DMA_MINALIGN | 722 | #ifdef ARCH_DMA_MINALIGN |
diff --git a/scripts/coccinelle/api/alloc/alloc_cast.cocci b/scripts/coccinelle/api/alloc/alloc_cast.cocci index 408ee3879f9b..18fedf7c60ed 100644 --- a/scripts/coccinelle/api/alloc/alloc_cast.cocci +++ b/scripts/coccinelle/api/alloc/alloc_cast.cocci | |||
| @@ -32,7 +32,7 @@ type T; | |||
| 32 | (T *) | 32 | (T *) |
| 33 | \(kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|kmem_cache_zalloc\| | 33 | \(kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|kmem_cache_zalloc\| |
| 34 | kmem_cache_alloc_node\|kmalloc_node\|kzalloc_node\|vmalloc\|vzalloc\| | 34 | kmem_cache_alloc_node\|kmalloc_node\|kzalloc_node\|vmalloc\|vzalloc\| |
| 35 | dma_alloc_coherent\|dma_zalloc_coherent\|devm_kmalloc\|devm_kzalloc\| | 35 | dma_alloc_coherent\|devm_kmalloc\|devm_kzalloc\| |
| 36 | kvmalloc\|kvzalloc\|kvmalloc_node\|kvzalloc_node\|pci_alloc_consistent\| | 36 | kvmalloc\|kvzalloc\|kvmalloc_node\|kvzalloc_node\|pci_alloc_consistent\| |
| 37 | pci_zalloc_consistent\|kmem_alloc\|kmem_zalloc\|kmem_zone_alloc\| | 37 | pci_zalloc_consistent\|kmem_alloc\|kmem_zalloc\|kmem_zone_alloc\| |
| 38 | kmem_zone_zalloc\|vmalloc_node\|vzalloc_node\)(...) | 38 | kmem_zone_zalloc\|vmalloc_node\|vzalloc_node\)(...) |
| @@ -55,7 +55,7 @@ type r1.T; | |||
| 55 | * (T *) | 55 | * (T *) |
| 56 | \(kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|kmem_cache_zalloc\| | 56 | \(kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|kmem_cache_zalloc\| |
| 57 | kmem_cache_alloc_node\|kmalloc_node\|kzalloc_node\|vmalloc\|vzalloc\| | 57 | kmem_cache_alloc_node\|kmalloc_node\|kzalloc_node\|vmalloc\|vzalloc\| |
| 58 | dma_alloc_coherent\|dma_zalloc_coherent\|devm_kmalloc\|devm_kzalloc\| | 58 | dma_alloc_coherent\|devm_kmalloc\|devm_kzalloc\| |
| 59 | kvmalloc\|kvzalloc\|kvmalloc_node\|kvzalloc_node\|pci_alloc_consistent\| | 59 | kvmalloc\|kvzalloc\|kvmalloc_node\|kvzalloc_node\|pci_alloc_consistent\| |
| 60 | pci_zalloc_consistent\|kmem_alloc\|kmem_zalloc\|kmem_zone_alloc\| | 60 | pci_zalloc_consistent\|kmem_alloc\|kmem_zalloc\|kmem_zone_alloc\| |
| 61 | kmem_zone_zalloc\|vmalloc_node\|vzalloc_node\)(...) | 61 | kmem_zone_zalloc\|vmalloc_node\|vzalloc_node\)(...) |
| @@ -78,7 +78,7 @@ type r1.T; | |||
| 78 | - (T *) | 78 | - (T *) |
| 79 | \(kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|kmem_cache_zalloc\| | 79 | \(kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|kmem_cache_zalloc\| |
| 80 | kmem_cache_alloc_node\|kmalloc_node\|kzalloc_node\|vmalloc\|vzalloc\| | 80 | kmem_cache_alloc_node\|kmalloc_node\|kzalloc_node\|vmalloc\|vzalloc\| |
| 81 | dma_alloc_coherent\|dma_zalloc_coherent\|devm_kmalloc\|devm_kzalloc\| | 81 | dma_alloc_coherent\|devm_kmalloc\|devm_kzalloc\| |
| 82 | kvmalloc\|kvzalloc\|kvmalloc_node\|kvzalloc_node\|pci_alloc_consistent\| | 82 | kvmalloc\|kvzalloc\|kvmalloc_node\|kvzalloc_node\|pci_alloc_consistent\| |
| 83 | pci_zalloc_consistent\|kmem_alloc\|kmem_zalloc\|kmem_zone_alloc\| | 83 | pci_zalloc_consistent\|kmem_alloc\|kmem_zalloc\|kmem_zone_alloc\| |
| 84 | kmem_zone_zalloc\|vmalloc_node\|vzalloc_node\)(...) | 84 | kmem_zone_zalloc\|vmalloc_node\|vzalloc_node\)(...) |
| @@ -95,7 +95,7 @@ position p; | |||
| 95 | (T@p *) | 95 | (T@p *) |
| 96 | \(kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|kmem_cache_zalloc\| | 96 | \(kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|kmem_cache_zalloc\| |
| 97 | kmem_cache_alloc_node\|kmalloc_node\|kzalloc_node\|vmalloc\|vzalloc\| | 97 | kmem_cache_alloc_node\|kmalloc_node\|kzalloc_node\|vmalloc\|vzalloc\| |
| 98 | dma_alloc_coherent\|dma_zalloc_coherent\|devm_kmalloc\|devm_kzalloc\| | 98 | dma_alloc_coherent\|devm_kmalloc\|devm_kzalloc\| |
| 99 | kvmalloc\|kvzalloc\|kvmalloc_node\|kvzalloc_node\|pci_alloc_consistent\| | 99 | kvmalloc\|kvzalloc\|kvmalloc_node\|kvzalloc_node\|pci_alloc_consistent\| |
| 100 | pci_zalloc_consistent\|kmem_alloc\|kmem_zalloc\|kmem_zone_alloc\| | 100 | pci_zalloc_consistent\|kmem_alloc\|kmem_zalloc\|kmem_zone_alloc\| |
| 101 | kmem_zone_zalloc\|vmalloc_node\|vzalloc_node\)(...) | 101 | kmem_zone_zalloc\|vmalloc_node\|vzalloc_node\)(...) |
diff --git a/scripts/coccinelle/api/alloc/zalloc-simple.cocci b/scripts/coccinelle/api/alloc/zalloc-simple.cocci index d819275b7fde..5cd1991c582e 100644 --- a/scripts/coccinelle/api/alloc/zalloc-simple.cocci +++ b/scripts/coccinelle/api/alloc/zalloc-simple.cocci | |||
| @@ -69,15 +69,6 @@ statement S; | |||
| 69 | - x = (T)vmalloc(E1); | 69 | - x = (T)vmalloc(E1); |
| 70 | + x = (T)vzalloc(E1); | 70 | + x = (T)vzalloc(E1); |
| 71 | | | 71 | | |
| 72 | - x = dma_alloc_coherent(E2,E1,E3,E4); | ||
| 73 | + x = dma_zalloc_coherent(E2,E1,E3,E4); | ||
| 74 | | | ||
| 75 | - x = (T *)dma_alloc_coherent(E2,E1,E3,E4); | ||
| 76 | + x = dma_zalloc_coherent(E2,E1,E3,E4); | ||
| 77 | | | ||
| 78 | - x = (T)dma_alloc_coherent(E2,E1,E3,E4); | ||
| 79 | + x = (T)dma_zalloc_coherent(E2,E1,E3,E4); | ||
| 80 | | | ||
| 81 | - x = kmalloc_node(E1,E2,E3); | 72 | - x = kmalloc_node(E1,E2,E3); |
| 82 | + x = kzalloc_node(E1,E2,E3); | 73 | + x = kzalloc_node(E1,E2,E3); |
| 83 | | | 74 | | |
| @@ -225,7 +216,7 @@ p << r2.p; | |||
| 225 | x << r2.x; | 216 | x << r2.x; |
| 226 | @@ | 217 | @@ |
| 227 | 218 | ||
| 228 | msg="WARNING: dma_zalloc_coherent should be used for %s, instead of dma_alloc_coherent/memset" % (x) | 219 | msg="WARNING: dma_alloc_coherent use in %s already zeroes out memory, so memset is not needed" % (x) |
| 229 | coccilib.report.print_report(p[0], msg) | 220 | coccilib.report.print_report(p[0], msg) |
| 230 | 221 | ||
| 231 | //----------------------------------------------------------------- | 222 | //----------------------------------------------------------------- |
