diff options
262 files changed, 2752 insertions, 1544 deletions
diff --git a/Documentation/networking/dsa/dsa.txt b/Documentation/networking/dsa/dsa.txt index 6d6c07cf1a9a..63912ef34606 100644 --- a/Documentation/networking/dsa/dsa.txt +++ b/Documentation/networking/dsa/dsa.txt | |||
| @@ -67,13 +67,14 @@ Note that DSA does not currently create network interfaces for the "cpu" and | |||
| 67 | Switch tagging protocols | 67 | Switch tagging protocols |
| 68 | ------------------------ | 68 | ------------------------ |
| 69 | 69 | ||
| 70 | DSA currently supports 4 different tagging protocols, and a tag-less mode as | 70 | DSA currently supports 5 different tagging protocols, and a tag-less mode as |
| 71 | well. The different protocols are implemented in: | 71 | well. The different protocols are implemented in: |
| 72 | 72 | ||
| 73 | net/dsa/tag_trailer.c: Marvell's 4 trailer tag mode (legacy) | 73 | net/dsa/tag_trailer.c: Marvell's 4 trailer tag mode (legacy) |
| 74 | net/dsa/tag_dsa.c: Marvell's original DSA tag | 74 | net/dsa/tag_dsa.c: Marvell's original DSA tag |
| 75 | net/dsa/tag_edsa.c: Marvell's enhanced DSA tag | 75 | net/dsa/tag_edsa.c: Marvell's enhanced DSA tag |
| 76 | net/dsa/tag_brcm.c: Broadcom's 4 bytes tag | 76 | net/dsa/tag_brcm.c: Broadcom's 4 bytes tag |
| 77 | net/dsa/tag_qca.c: Qualcomm's 2 bytes tag | ||
| 77 | 78 | ||
| 78 | The exact format of the tag protocol is vendor specific, but in general, they | 79 | The exact format of the tag protocol is vendor specific, but in general, they |
| 79 | all contain something which: | 80 | all contain something which: |
diff --git a/MAINTAINERS b/MAINTAINERS index 851b89b9edcb..ad9b965e5e44 100644 --- a/MAINTAINERS +++ b/MAINTAINERS | |||
| @@ -7084,6 +7084,7 @@ F: drivers/scsi/53c700* | |||
| 7084 | LED SUBSYSTEM | 7084 | LED SUBSYSTEM |
| 7085 | M: Richard Purdie <rpurdie@rpsys.net> | 7085 | M: Richard Purdie <rpurdie@rpsys.net> |
| 7086 | M: Jacek Anaszewski <j.anaszewski@samsung.com> | 7086 | M: Jacek Anaszewski <j.anaszewski@samsung.com> |
| 7087 | M: Pavel Machek <pavel@ucw.cz> | ||
| 7087 | L: linux-leds@vger.kernel.org | 7088 | L: linux-leds@vger.kernel.org |
| 7088 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git | 7089 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git |
| 7089 | S: Maintained | 7090 | S: Maintained |
| @@ -8057,6 +8058,7 @@ F: drivers/infiniband/hw/mlx4/ | |||
| 8057 | F: include/linux/mlx4/ | 8058 | F: include/linux/mlx4/ |
| 8058 | 8059 | ||
| 8059 | MELLANOX MLX5 core VPI driver | 8060 | MELLANOX MLX5 core VPI driver |
| 8061 | M: Saeed Mahameed <saeedm@mellanox.com> | ||
| 8060 | M: Matan Barak <matanb@mellanox.com> | 8062 | M: Matan Barak <matanb@mellanox.com> |
| 8061 | M: Leon Romanovsky <leonro@mellanox.com> | 8063 | M: Leon Romanovsky <leonro@mellanox.com> |
| 8062 | L: netdev@vger.kernel.org | 8064 | L: netdev@vger.kernel.org |
| @@ -399,11 +399,12 @@ KBUILD_CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \ | |||
| 399 | -fno-strict-aliasing -fno-common \ | 399 | -fno-strict-aliasing -fno-common \ |
| 400 | -Werror-implicit-function-declaration \ | 400 | -Werror-implicit-function-declaration \ |
| 401 | -Wno-format-security \ | 401 | -Wno-format-security \ |
| 402 | -std=gnu89 | 402 | -std=gnu89 $(call cc-option,-fno-PIE) |
| 403 | |||
| 403 | 404 | ||
| 404 | KBUILD_AFLAGS_KERNEL := | 405 | KBUILD_AFLAGS_KERNEL := |
| 405 | KBUILD_CFLAGS_KERNEL := | 406 | KBUILD_CFLAGS_KERNEL := |
| 406 | KBUILD_AFLAGS := -D__ASSEMBLY__ | 407 | KBUILD_AFLAGS := -D__ASSEMBLY__ $(call cc-option,-fno-PIE) |
| 407 | KBUILD_AFLAGS_MODULE := -DMODULE | 408 | KBUILD_AFLAGS_MODULE := -DMODULE |
| 408 | KBUILD_CFLAGS_MODULE := -DMODULE | 409 | KBUILD_CFLAGS_MODULE := -DMODULE |
| 409 | KBUILD_LDFLAGS_MODULE := -T $(srctree)/scripts/module-common.lds | 410 | KBUILD_LDFLAGS_MODULE := -T $(srctree)/scripts/module-common.lds |
diff --git a/arch/powerpc/include/asm/exception-64s.h b/arch/powerpc/include/asm/exception-64s.h index 84d49b197c32..9a3eee661297 100644 --- a/arch/powerpc/include/asm/exception-64s.h +++ b/arch/powerpc/include/asm/exception-64s.h | |||
| @@ -91,7 +91,7 @@ | |||
| 91 | */ | 91 | */ |
| 92 | #define LOAD_HANDLER(reg, label) \ | 92 | #define LOAD_HANDLER(reg, label) \ |
| 93 | ld reg,PACAKBASE(r13); /* get high part of &label */ \ | 93 | ld reg,PACAKBASE(r13); /* get high part of &label */ \ |
| 94 | ori reg,reg,(FIXED_SYMBOL_ABS_ADDR(label))@l; | 94 | ori reg,reg,FIXED_SYMBOL_ABS_ADDR(label); |
| 95 | 95 | ||
| 96 | #define __LOAD_HANDLER(reg, label) \ | 96 | #define __LOAD_HANDLER(reg, label) \ |
| 97 | ld reg,PACAKBASE(r13); \ | 97 | ld reg,PACAKBASE(r13); \ |
| @@ -158,14 +158,17 @@ BEGIN_FTR_SECTION_NESTED(943) \ | |||
| 158 | std ra,offset(r13); \ | 158 | std ra,offset(r13); \ |
| 159 | END_FTR_SECTION_NESTED(ftr,ftr,943) | 159 | END_FTR_SECTION_NESTED(ftr,ftr,943) |
| 160 | 160 | ||
| 161 | #define EXCEPTION_PROLOG_0(area) \ | 161 | #define EXCEPTION_PROLOG_0_PACA(area) \ |
| 162 | GET_PACA(r13); \ | ||
| 163 | std r9,area+EX_R9(r13); /* save r9 */ \ | 162 | std r9,area+EX_R9(r13); /* save r9 */ \ |
| 164 | OPT_GET_SPR(r9, SPRN_PPR, CPU_FTR_HAS_PPR); \ | 163 | OPT_GET_SPR(r9, SPRN_PPR, CPU_FTR_HAS_PPR); \ |
| 165 | HMT_MEDIUM; \ | 164 | HMT_MEDIUM; \ |
| 166 | std r10,area+EX_R10(r13); /* save r10 - r12 */ \ | 165 | std r10,area+EX_R10(r13); /* save r10 - r12 */ \ |
| 167 | OPT_GET_SPR(r10, SPRN_CFAR, CPU_FTR_CFAR) | 166 | OPT_GET_SPR(r10, SPRN_CFAR, CPU_FTR_CFAR) |
| 168 | 167 | ||
| 168 | #define EXCEPTION_PROLOG_0(area) \ | ||
| 169 | GET_PACA(r13); \ | ||
| 170 | EXCEPTION_PROLOG_0_PACA(area) | ||
| 171 | |||
| 169 | #define __EXCEPTION_PROLOG_1(area, extra, vec) \ | 172 | #define __EXCEPTION_PROLOG_1(area, extra, vec) \ |
| 170 | OPT_SAVE_REG_TO_PACA(area+EX_PPR, r9, CPU_FTR_HAS_PPR); \ | 173 | OPT_SAVE_REG_TO_PACA(area+EX_PPR, r9, CPU_FTR_HAS_PPR); \ |
| 171 | OPT_SAVE_REG_TO_PACA(area+EX_CFAR, r10, CPU_FTR_CFAR); \ | 174 | OPT_SAVE_REG_TO_PACA(area+EX_CFAR, r10, CPU_FTR_CFAR); \ |
| @@ -196,6 +199,12 @@ END_FTR_SECTION_NESTED(ftr,ftr,943) | |||
| 196 | EXCEPTION_PROLOG_1(area, extra, vec); \ | 199 | EXCEPTION_PROLOG_1(area, extra, vec); \ |
| 197 | EXCEPTION_PROLOG_PSERIES_1(label, h); | 200 | EXCEPTION_PROLOG_PSERIES_1(label, h); |
| 198 | 201 | ||
| 202 | /* Have the PACA in r13 already */ | ||
| 203 | #define EXCEPTION_PROLOG_PSERIES_PACA(area, label, h, extra, vec) \ | ||
| 204 | EXCEPTION_PROLOG_0_PACA(area); \ | ||
| 205 | EXCEPTION_PROLOG_1(area, extra, vec); \ | ||
| 206 | EXCEPTION_PROLOG_PSERIES_1(label, h); | ||
| 207 | |||
| 199 | #define __KVMTEST(h, n) \ | 208 | #define __KVMTEST(h, n) \ |
| 200 | lbz r10,HSTATE_IN_GUEST(r13); \ | 209 | lbz r10,HSTATE_IN_GUEST(r13); \ |
| 201 | cmpwi r10,0; \ | 210 | cmpwi r10,0; \ |
diff --git a/arch/powerpc/include/asm/ppc-opcode.h b/arch/powerpc/include/asm/ppc-opcode.h index 0132831b3081..c56ea8c84abb 100644 --- a/arch/powerpc/include/asm/ppc-opcode.h +++ b/arch/powerpc/include/asm/ppc-opcode.h | |||
| @@ -460,5 +460,6 @@ | |||
| 460 | 460 | ||
| 461 | #define PPC_SLBIA(IH) stringify_in_c(.long PPC_INST_SLBIA | \ | 461 | #define PPC_SLBIA(IH) stringify_in_c(.long PPC_INST_SLBIA | \ |
| 462 | ((IH & 0x7) << 21)) | 462 | ((IH & 0x7) << 21)) |
| 463 | #define PPC_INVALIDATE_ERAT PPC_SLBIA(7) | ||
| 463 | 464 | ||
| 464 | #endif /* _ASM_POWERPC_PPC_OPCODE_H */ | 465 | #endif /* _ASM_POWERPC_PPC_OPCODE_H */ |
diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S index 08ba447a4b3d..1ba82ea90230 100644 --- a/arch/powerpc/kernel/exceptions-64s.S +++ b/arch/powerpc/kernel/exceptions-64s.S | |||
| @@ -116,7 +116,9 @@ EXC_VIRT_NONE(0x4000, 0x4100) | |||
| 116 | 116 | ||
| 117 | EXC_REAL_BEGIN(system_reset, 0x100, 0x200) | 117 | EXC_REAL_BEGIN(system_reset, 0x100, 0x200) |
| 118 | SET_SCRATCH0(r13) | 118 | SET_SCRATCH0(r13) |
| 119 | EXCEPTION_PROLOG_PSERIES(PACA_EXGEN, system_reset_common, EXC_STD, | 119 | GET_PACA(r13) |
| 120 | clrrdi r13,r13,1 /* Last bit of HSPRG0 is set if waking from winkle */ | ||
| 121 | EXCEPTION_PROLOG_PSERIES_PACA(PACA_EXGEN, system_reset_common, EXC_STD, | ||
| 120 | IDLETEST, 0x100) | 122 | IDLETEST, 0x100) |
| 121 | 123 | ||
| 122 | EXC_REAL_END(system_reset, 0x100, 0x200) | 124 | EXC_REAL_END(system_reset, 0x100, 0x200) |
| @@ -124,6 +126,9 @@ EXC_VIRT_NONE(0x4100, 0x4200) | |||
| 124 | 126 | ||
| 125 | #ifdef CONFIG_PPC_P7_NAP | 127 | #ifdef CONFIG_PPC_P7_NAP |
| 126 | EXC_COMMON_BEGIN(system_reset_idle_common) | 128 | EXC_COMMON_BEGIN(system_reset_idle_common) |
| 129 | BEGIN_FTR_SECTION | ||
| 130 | GET_PACA(r13) /* Restore HSPRG0 to get the winkle bit in r13 */ | ||
| 131 | END_FTR_SECTION_IFCLR(CPU_FTR_ARCH_300) | ||
| 127 | bl pnv_restore_hyp_resource | 132 | bl pnv_restore_hyp_resource |
| 128 | 133 | ||
| 129 | li r0,PNV_THREAD_RUNNING | 134 | li r0,PNV_THREAD_RUNNING |
| @@ -169,7 +174,7 @@ EXC_REAL_BEGIN(machine_check, 0x200, 0x300) | |||
| 169 | SET_SCRATCH0(r13) /* save r13 */ | 174 | SET_SCRATCH0(r13) /* save r13 */ |
| 170 | /* | 175 | /* |
| 171 | * Running native on arch 2.06 or later, we may wakeup from winkle | 176 | * Running native on arch 2.06 or later, we may wakeup from winkle |
| 172 | * inside machine check. If yes, then last bit of HSPGR0 would be set | 177 | * inside machine check. If yes, then last bit of HSPRG0 would be set |
| 173 | * to 1. Hence clear it unconditionally. | 178 | * to 1. Hence clear it unconditionally. |
| 174 | */ | 179 | */ |
| 175 | GET_PACA(r13) | 180 | GET_PACA(r13) |
| @@ -388,7 +393,7 @@ EXC_COMMON_BEGIN(machine_check_handle_early) | |||
| 388 | /* | 393 | /* |
| 389 | * Go back to winkle. Please note that this thread was woken up in | 394 | * Go back to winkle. Please note that this thread was woken up in |
| 390 | * machine check from winkle and have not restored the per-subcore | 395 | * machine check from winkle and have not restored the per-subcore |
| 391 | * state. Hence before going back to winkle, set last bit of HSPGR0 | 396 | * state. Hence before going back to winkle, set last bit of HSPRG0 |
| 392 | * to 1. This will make sure that if this thread gets woken up | 397 | * to 1. This will make sure that if this thread gets woken up |
| 393 | * again at reset vector 0x100 then it will get chance to restore | 398 | * again at reset vector 0x100 then it will get chance to restore |
| 394 | * the subcore state. | 399 | * the subcore state. |
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c index ce6dc61b15b2..49a680d5ae37 100644 --- a/arch/powerpc/kernel/process.c +++ b/arch/powerpc/kernel/process.c | |||
| @@ -1215,7 +1215,7 @@ static void show_instructions(struct pt_regs *regs) | |||
| 1215 | int instr; | 1215 | int instr; |
| 1216 | 1216 | ||
| 1217 | if (!(i % 8)) | 1217 | if (!(i % 8)) |
| 1218 | printk("\n"); | 1218 | pr_cont("\n"); |
| 1219 | 1219 | ||
| 1220 | #if !defined(CONFIG_BOOKE) | 1220 | #if !defined(CONFIG_BOOKE) |
| 1221 | /* If executing with the IMMU off, adjust pc rather | 1221 | /* If executing with the IMMU off, adjust pc rather |
| @@ -1227,18 +1227,18 @@ static void show_instructions(struct pt_regs *regs) | |||
| 1227 | 1227 | ||
| 1228 | if (!__kernel_text_address(pc) || | 1228 | if (!__kernel_text_address(pc) || |
| 1229 | probe_kernel_address((unsigned int __user *)pc, instr)) { | 1229 | probe_kernel_address((unsigned int __user *)pc, instr)) { |
| 1230 | printk(KERN_CONT "XXXXXXXX "); | 1230 | pr_cont("XXXXXXXX "); |
| 1231 | } else { | 1231 | } else { |
| 1232 | if (regs->nip == pc) | 1232 | if (regs->nip == pc) |
| 1233 | printk(KERN_CONT "<%08x> ", instr); | 1233 | pr_cont("<%08x> ", instr); |
| 1234 | else | 1234 | else |
| 1235 | printk(KERN_CONT "%08x ", instr); | 1235 | pr_cont("%08x ", instr); |
| 1236 | } | 1236 | } |
| 1237 | 1237 | ||
| 1238 | pc += sizeof(int); | 1238 | pc += sizeof(int); |
| 1239 | } | 1239 | } |
| 1240 | 1240 | ||
| 1241 | printk("\n"); | 1241 | pr_cont("\n"); |
| 1242 | } | 1242 | } |
| 1243 | 1243 | ||
| 1244 | struct regbit { | 1244 | struct regbit { |
| @@ -1282,7 +1282,7 @@ static void print_bits(unsigned long val, struct regbit *bits, const char *sep) | |||
| 1282 | 1282 | ||
| 1283 | for (; bits->bit; ++bits) | 1283 | for (; bits->bit; ++bits) |
| 1284 | if (val & bits->bit) { | 1284 | if (val & bits->bit) { |
| 1285 | printk("%s%s", s, bits->name); | 1285 | pr_cont("%s%s", s, bits->name); |
| 1286 | s = sep; | 1286 | s = sep; |
| 1287 | } | 1287 | } |
| 1288 | } | 1288 | } |
| @@ -1305,9 +1305,9 @@ static void print_tm_bits(unsigned long val) | |||
| 1305 | * T: Transactional (bit 34) | 1305 | * T: Transactional (bit 34) |
| 1306 | */ | 1306 | */ |
| 1307 | if (val & (MSR_TM | MSR_TS_S | MSR_TS_T)) { | 1307 | if (val & (MSR_TM | MSR_TS_S | MSR_TS_T)) { |
| 1308 | printk(",TM["); | 1308 | pr_cont(",TM["); |
| 1309 | print_bits(val, msr_tm_bits, ""); | 1309 | print_bits(val, msr_tm_bits, ""); |
| 1310 | printk("]"); | 1310 | pr_cont("]"); |
| 1311 | } | 1311 | } |
| 1312 | } | 1312 | } |
| 1313 | #else | 1313 | #else |
| @@ -1316,10 +1316,10 @@ static void print_tm_bits(unsigned long val) {} | |||
| 1316 | 1316 | ||
| 1317 | static void print_msr_bits(unsigned long val) | 1317 | static void print_msr_bits(unsigned long val) |
| 1318 | { | 1318 | { |
| 1319 | printk("<"); | 1319 | pr_cont("<"); |
| 1320 | print_bits(val, msr_bits, ","); | 1320 | print_bits(val, msr_bits, ","); |
| 1321 | print_tm_bits(val); | 1321 | print_tm_bits(val); |
| 1322 | printk(">"); | 1322 | pr_cont(">"); |
| 1323 | } | 1323 | } |
| 1324 | 1324 | ||
| 1325 | #ifdef CONFIG_PPC64 | 1325 | #ifdef CONFIG_PPC64 |
| @@ -1347,29 +1347,29 @@ void show_regs(struct pt_regs * regs) | |||
| 1347 | printk(" CR: %08lx XER: %08lx\n", regs->ccr, regs->xer); | 1347 | printk(" CR: %08lx XER: %08lx\n", regs->ccr, regs->xer); |
| 1348 | trap = TRAP(regs); | 1348 | trap = TRAP(regs); |
| 1349 | if ((regs->trap != 0xc00) && cpu_has_feature(CPU_FTR_CFAR)) | 1349 | if ((regs->trap != 0xc00) && cpu_has_feature(CPU_FTR_CFAR)) |
| 1350 | printk("CFAR: "REG" ", regs->orig_gpr3); | 1350 | pr_cont("CFAR: "REG" ", regs->orig_gpr3); |
| 1351 | if (trap == 0x200 || trap == 0x300 || trap == 0x600) | 1351 | if (trap == 0x200 || trap == 0x300 || trap == 0x600) |
| 1352 | #if defined(CONFIG_4xx) || defined(CONFIG_BOOKE) | 1352 | #if defined(CONFIG_4xx) || defined(CONFIG_BOOKE) |
| 1353 | printk("DEAR: "REG" ESR: "REG" ", regs->dar, regs->dsisr); | 1353 | pr_cont("DEAR: "REG" ESR: "REG" ", regs->dar, regs->dsisr); |
| 1354 | #else | 1354 | #else |
| 1355 | printk("DAR: "REG" DSISR: %08lx ", regs->dar, regs->dsisr); | 1355 | pr_cont("DAR: "REG" DSISR: %08lx ", regs->dar, regs->dsisr); |
| 1356 | #endif | 1356 | #endif |
| 1357 | #ifdef CONFIG_PPC64 | 1357 | #ifdef CONFIG_PPC64 |
| 1358 | printk("SOFTE: %ld ", regs->softe); | 1358 | pr_cont("SOFTE: %ld ", regs->softe); |
| 1359 | #endif | 1359 | #endif |
| 1360 | #ifdef CONFIG_PPC_TRANSACTIONAL_MEM | 1360 | #ifdef CONFIG_PPC_TRANSACTIONAL_MEM |
| 1361 | if (MSR_TM_ACTIVE(regs->msr)) | 1361 | if (MSR_TM_ACTIVE(regs->msr)) |
| 1362 | printk("\nPACATMSCRATCH: %016llx ", get_paca()->tm_scratch); | 1362 | pr_cont("\nPACATMSCRATCH: %016llx ", get_paca()->tm_scratch); |
| 1363 | #endif | 1363 | #endif |
| 1364 | 1364 | ||
| 1365 | for (i = 0; i < 32; i++) { | 1365 | for (i = 0; i < 32; i++) { |
| 1366 | if ((i % REGS_PER_LINE) == 0) | 1366 | if ((i % REGS_PER_LINE) == 0) |
| 1367 | printk("\nGPR%02d: ", i); | 1367 | pr_cont("\nGPR%02d: ", i); |
| 1368 | printk(REG " ", regs->gpr[i]); | 1368 | pr_cont(REG " ", regs->gpr[i]); |
| 1369 | if (i == LAST_VOLATILE && !FULL_REGS(regs)) | 1369 | if (i == LAST_VOLATILE && !FULL_REGS(regs)) |
| 1370 | break; | 1370 | break; |
| 1371 | } | 1371 | } |
| 1372 | printk("\n"); | 1372 | pr_cont("\n"); |
| 1373 | #ifdef CONFIG_KALLSYMS | 1373 | #ifdef CONFIG_KALLSYMS |
| 1374 | /* | 1374 | /* |
| 1375 | * Lookup NIP late so we have the best change of getting the | 1375 | * Lookup NIP late so we have the best change of getting the |
| @@ -1900,14 +1900,14 @@ void show_stack(struct task_struct *tsk, unsigned long *stack) | |||
| 1900 | printk("["REG"] ["REG"] %pS", sp, ip, (void *)ip); | 1900 | printk("["REG"] ["REG"] %pS", sp, ip, (void *)ip); |
| 1901 | #ifdef CONFIG_FUNCTION_GRAPH_TRACER | 1901 | #ifdef CONFIG_FUNCTION_GRAPH_TRACER |
| 1902 | if ((ip == rth) && curr_frame >= 0) { | 1902 | if ((ip == rth) && curr_frame >= 0) { |
| 1903 | printk(" (%pS)", | 1903 | pr_cont(" (%pS)", |
| 1904 | (void *)current->ret_stack[curr_frame].ret); | 1904 | (void *)current->ret_stack[curr_frame].ret); |
| 1905 | curr_frame--; | 1905 | curr_frame--; |
| 1906 | } | 1906 | } |
| 1907 | #endif | 1907 | #endif |
| 1908 | if (firstframe) | 1908 | if (firstframe) |
| 1909 | printk(" (unreliable)"); | 1909 | pr_cont(" (unreliable)"); |
| 1910 | printk("\n"); | 1910 | pr_cont("\n"); |
| 1911 | } | 1911 | } |
| 1912 | firstframe = 0; | 1912 | firstframe = 0; |
| 1913 | 1913 | ||
diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c index 7ac8e6eaab5b..8d586cff8a41 100644 --- a/arch/powerpc/kernel/setup_64.c +++ b/arch/powerpc/kernel/setup_64.c | |||
| @@ -226,17 +226,25 @@ static void __init configure_exceptions(void) | |||
| 226 | if (firmware_has_feature(FW_FEATURE_OPAL)) | 226 | if (firmware_has_feature(FW_FEATURE_OPAL)) |
| 227 | opal_configure_cores(); | 227 | opal_configure_cores(); |
| 228 | 228 | ||
| 229 | /* Enable AIL if supported, and we are in hypervisor mode */ | 229 | /* AIL on native is done in cpu_ready_for_interrupts() */ |
| 230 | if (early_cpu_has_feature(CPU_FTR_HVMODE) && | ||
| 231 | early_cpu_has_feature(CPU_FTR_ARCH_207S)) { | ||
| 232 | unsigned long lpcr = mfspr(SPRN_LPCR); | ||
| 233 | mtspr(SPRN_LPCR, lpcr | LPCR_AIL_3); | ||
| 234 | } | ||
| 235 | } | 230 | } |
| 236 | } | 231 | } |
| 237 | 232 | ||
| 238 | static void cpu_ready_for_interrupts(void) | 233 | static void cpu_ready_for_interrupts(void) |
| 239 | { | 234 | { |
| 235 | /* | ||
| 236 | * Enable AIL if supported, and we are in hypervisor mode. This | ||
| 237 | * is called once for every processor. | ||
| 238 | * | ||
| 239 | * If we are not in hypervisor mode the job is done once for | ||
| 240 | * the whole partition in configure_exceptions(). | ||
| 241 | */ | ||
| 242 | if (early_cpu_has_feature(CPU_FTR_HVMODE) && | ||
| 243 | early_cpu_has_feature(CPU_FTR_ARCH_207S)) { | ||
| 244 | unsigned long lpcr = mfspr(SPRN_LPCR); | ||
| 245 | mtspr(SPRN_LPCR, lpcr | LPCR_AIL_3); | ||
| 246 | } | ||
| 247 | |||
| 240 | /* Set IR and DR in PACA MSR */ | 248 | /* Set IR and DR in PACA MSR */ |
| 241 | get_paca()->kernel_msr = MSR_KERNEL; | 249 | get_paca()->kernel_msr = MSR_KERNEL; |
| 242 | } | 250 | } |
diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c index 44d3c3a38e3e..5503078090cd 100644 --- a/arch/powerpc/mm/hash_utils_64.c +++ b/arch/powerpc/mm/hash_utils_64.c | |||
| @@ -1029,6 +1029,10 @@ void hash__early_init_mmu_secondary(void) | |||
| 1029 | { | 1029 | { |
| 1030 | /* Initialize hash table for that CPU */ | 1030 | /* Initialize hash table for that CPU */ |
| 1031 | if (!firmware_has_feature(FW_FEATURE_LPAR)) { | 1031 | if (!firmware_has_feature(FW_FEATURE_LPAR)) { |
| 1032 | |||
| 1033 | if (cpu_has_feature(CPU_FTR_POWER9_DD1)) | ||
| 1034 | update_hid_for_hash(); | ||
| 1035 | |||
| 1032 | if (!cpu_has_feature(CPU_FTR_ARCH_300)) | 1036 | if (!cpu_has_feature(CPU_FTR_ARCH_300)) |
| 1033 | mtspr(SPRN_SDR1, _SDR1); | 1037 | mtspr(SPRN_SDR1, _SDR1); |
| 1034 | else | 1038 | else |
diff --git a/arch/powerpc/mm/pgtable-radix.c b/arch/powerpc/mm/pgtable-radix.c index ed7bddc456b7..688b54517655 100644 --- a/arch/powerpc/mm/pgtable-radix.c +++ b/arch/powerpc/mm/pgtable-radix.c | |||
| @@ -388,6 +388,10 @@ void radix__early_init_mmu_secondary(void) | |||
| 388 | * update partition table control register and UPRT | 388 | * update partition table control register and UPRT |
| 389 | */ | 389 | */ |
| 390 | if (!firmware_has_feature(FW_FEATURE_LPAR)) { | 390 | if (!firmware_has_feature(FW_FEATURE_LPAR)) { |
| 391 | |||
| 392 | if (cpu_has_feature(CPU_FTR_POWER9_DD1)) | ||
| 393 | update_hid_for_radix(); | ||
| 394 | |||
| 391 | lpcr = mfspr(SPRN_LPCR); | 395 | lpcr = mfspr(SPRN_LPCR); |
| 392 | mtspr(SPRN_LPCR, lpcr | LPCR_UPRT | LPCR_HR); | 396 | mtspr(SPRN_LPCR, lpcr | LPCR_UPRT | LPCR_HR); |
| 393 | 397 | ||
diff --git a/arch/powerpc/mm/tlb-radix.c b/arch/powerpc/mm/tlb-radix.c index bda8c43be78a..3493cf4e0452 100644 --- a/arch/powerpc/mm/tlb-radix.c +++ b/arch/powerpc/mm/tlb-radix.c | |||
| @@ -50,6 +50,8 @@ static inline void _tlbiel_pid(unsigned long pid, unsigned long ric) | |||
| 50 | for (set = 0; set < POWER9_TLB_SETS_RADIX ; set++) { | 50 | for (set = 0; set < POWER9_TLB_SETS_RADIX ; set++) { |
| 51 | __tlbiel_pid(pid, set, ric); | 51 | __tlbiel_pid(pid, set, ric); |
| 52 | } | 52 | } |
| 53 | if (cpu_has_feature(CPU_FTR_POWER9_DD1)) | ||
| 54 | asm volatile(PPC_INVALIDATE_ERAT : : :"memory"); | ||
| 53 | return; | 55 | return; |
| 54 | } | 56 | } |
| 55 | 57 | ||
| @@ -83,6 +85,8 @@ static inline void _tlbiel_va(unsigned long va, unsigned long pid, | |||
| 83 | asm volatile(PPC_TLBIEL(%0, %4, %3, %2, %1) | 85 | asm volatile(PPC_TLBIEL(%0, %4, %3, %2, %1) |
| 84 | : : "r"(rb), "i"(r), "i"(prs), "i"(ric), "r"(rs) : "memory"); | 86 | : : "r"(rb), "i"(r), "i"(prs), "i"(ric), "r"(rs) : "memory"); |
| 85 | asm volatile("ptesync": : :"memory"); | 87 | asm volatile("ptesync": : :"memory"); |
| 88 | if (cpu_has_feature(CPU_FTR_POWER9_DD1)) | ||
| 89 | asm volatile(PPC_INVALIDATE_ERAT : : :"memory"); | ||
| 86 | } | 90 | } |
| 87 | 91 | ||
| 88 | static inline void _tlbie_va(unsigned long va, unsigned long pid, | 92 | static inline void _tlbie_va(unsigned long va, unsigned long pid, |
diff --git a/arch/tile/include/asm/cache.h b/arch/tile/include/asm/cache.h index 6160761d5f61..4810e48dbbbf 100644 --- a/arch/tile/include/asm/cache.h +++ b/arch/tile/include/asm/cache.h | |||
| @@ -61,4 +61,7 @@ | |||
| 61 | */ | 61 | */ |
| 62 | #define __write_once __read_mostly | 62 | #define __write_once __read_mostly |
| 63 | 63 | ||
| 64 | /* __ro_after_init is the generic name for the tile arch __write_once. */ | ||
| 65 | #define __ro_after_init __read_mostly | ||
| 66 | |||
| 64 | #endif /* _ASM_TILE_CACHE_H */ | 67 | #endif /* _ASM_TILE_CACHE_H */ |
diff --git a/arch/x86/events/intel/uncore_snb.c b/arch/x86/events/intel/uncore_snb.c index 5f845eef9a4d..81195cca7eae 100644 --- a/arch/x86/events/intel/uncore_snb.c +++ b/arch/x86/events/intel/uncore_snb.c | |||
| @@ -8,8 +8,12 @@ | |||
| 8 | #define PCI_DEVICE_ID_INTEL_HSW_IMC 0x0c00 | 8 | #define PCI_DEVICE_ID_INTEL_HSW_IMC 0x0c00 |
| 9 | #define PCI_DEVICE_ID_INTEL_HSW_U_IMC 0x0a04 | 9 | #define PCI_DEVICE_ID_INTEL_HSW_U_IMC 0x0a04 |
| 10 | #define PCI_DEVICE_ID_INTEL_BDW_IMC 0x1604 | 10 | #define PCI_DEVICE_ID_INTEL_BDW_IMC 0x1604 |
| 11 | #define PCI_DEVICE_ID_INTEL_SKL_IMC 0x191f | 11 | #define PCI_DEVICE_ID_INTEL_SKL_U_IMC 0x1904 |
| 12 | #define PCI_DEVICE_ID_INTEL_SKL_U_IMC 0x190c | 12 | #define PCI_DEVICE_ID_INTEL_SKL_Y_IMC 0x190c |
| 13 | #define PCI_DEVICE_ID_INTEL_SKL_HD_IMC 0x1900 | ||
| 14 | #define PCI_DEVICE_ID_INTEL_SKL_HQ_IMC 0x1910 | ||
| 15 | #define PCI_DEVICE_ID_INTEL_SKL_SD_IMC 0x190f | ||
| 16 | #define PCI_DEVICE_ID_INTEL_SKL_SQ_IMC 0x191f | ||
| 13 | 17 | ||
| 14 | /* SNB event control */ | 18 | /* SNB event control */ |
| 15 | #define SNB_UNC_CTL_EV_SEL_MASK 0x000000ff | 19 | #define SNB_UNC_CTL_EV_SEL_MASK 0x000000ff |
| @@ -616,13 +620,29 @@ static const struct pci_device_id bdw_uncore_pci_ids[] = { | |||
| 616 | 620 | ||
| 617 | static const struct pci_device_id skl_uncore_pci_ids[] = { | 621 | static const struct pci_device_id skl_uncore_pci_ids[] = { |
| 618 | { /* IMC */ | 622 | { /* IMC */ |
| 619 | PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SKL_IMC), | 623 | PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SKL_Y_IMC), |
| 620 | .driver_data = UNCORE_PCI_DEV_DATA(SNB_PCI_UNCORE_IMC, 0), | 624 | .driver_data = UNCORE_PCI_DEV_DATA(SNB_PCI_UNCORE_IMC, 0), |
| 621 | }, | 625 | }, |
| 622 | { /* IMC */ | 626 | { /* IMC */ |
| 623 | PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SKL_U_IMC), | 627 | PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SKL_U_IMC), |
| 624 | .driver_data = UNCORE_PCI_DEV_DATA(SNB_PCI_UNCORE_IMC, 0), | 628 | .driver_data = UNCORE_PCI_DEV_DATA(SNB_PCI_UNCORE_IMC, 0), |
| 625 | }, | 629 | }, |
| 630 | { /* IMC */ | ||
| 631 | PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SKL_HD_IMC), | ||
| 632 | .driver_data = UNCORE_PCI_DEV_DATA(SNB_PCI_UNCORE_IMC, 0), | ||
| 633 | }, | ||
| 634 | { /* IMC */ | ||
| 635 | PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SKL_HQ_IMC), | ||
| 636 | .driver_data = UNCORE_PCI_DEV_DATA(SNB_PCI_UNCORE_IMC, 0), | ||
| 637 | }, | ||
| 638 | { /* IMC */ | ||
| 639 | PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SKL_SD_IMC), | ||
| 640 | .driver_data = UNCORE_PCI_DEV_DATA(SNB_PCI_UNCORE_IMC, 0), | ||
| 641 | }, | ||
| 642 | { /* IMC */ | ||
| 643 | PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SKL_SQ_IMC), | ||
| 644 | .driver_data = UNCORE_PCI_DEV_DATA(SNB_PCI_UNCORE_IMC, 0), | ||
| 645 | }, | ||
| 626 | 646 | ||
| 627 | { /* end: all zeroes */ }, | 647 | { /* end: all zeroes */ }, |
| 628 | }; | 648 | }; |
| @@ -666,8 +686,12 @@ static const struct imc_uncore_pci_dev desktop_imc_pci_ids[] = { | |||
| 666 | IMC_DEV(HSW_IMC, &hsw_uncore_pci_driver), /* 4th Gen Core Processor */ | 686 | IMC_DEV(HSW_IMC, &hsw_uncore_pci_driver), /* 4th Gen Core Processor */ |
| 667 | IMC_DEV(HSW_U_IMC, &hsw_uncore_pci_driver), /* 4th Gen Core ULT Mobile Processor */ | 687 | IMC_DEV(HSW_U_IMC, &hsw_uncore_pci_driver), /* 4th Gen Core ULT Mobile Processor */ |
| 668 | IMC_DEV(BDW_IMC, &bdw_uncore_pci_driver), /* 5th Gen Core U */ | 688 | IMC_DEV(BDW_IMC, &bdw_uncore_pci_driver), /* 5th Gen Core U */ |
| 669 | IMC_DEV(SKL_IMC, &skl_uncore_pci_driver), /* 6th Gen Core */ | 689 | IMC_DEV(SKL_Y_IMC, &skl_uncore_pci_driver), /* 6th Gen Core Y */ |
| 670 | IMC_DEV(SKL_U_IMC, &skl_uncore_pci_driver), /* 6th Gen Core U */ | 690 | IMC_DEV(SKL_U_IMC, &skl_uncore_pci_driver), /* 6th Gen Core U */ |
| 691 | IMC_DEV(SKL_HD_IMC, &skl_uncore_pci_driver), /* 6th Gen Core H Dual Core */ | ||
| 692 | IMC_DEV(SKL_HQ_IMC, &skl_uncore_pci_driver), /* 6th Gen Core H Quad Core */ | ||
| 693 | IMC_DEV(SKL_SD_IMC, &skl_uncore_pci_driver), /* 6th Gen Core S Dual Core */ | ||
| 694 | IMC_DEV(SKL_SQ_IMC, &skl_uncore_pci_driver), /* 6th Gen Core S Quad Core */ | ||
| 671 | { /* end marker */ } | 695 | { /* end marker */ } |
| 672 | }; | 696 | }; |
| 673 | 697 | ||
diff --git a/arch/x86/include/asm/intel-mid.h b/arch/x86/include/asm/intel-mid.h index 5b6753d1f7f4..49da9f497b90 100644 --- a/arch/x86/include/asm/intel-mid.h +++ b/arch/x86/include/asm/intel-mid.h | |||
| @@ -17,6 +17,7 @@ | |||
| 17 | 17 | ||
| 18 | extern int intel_mid_pci_init(void); | 18 | extern int intel_mid_pci_init(void); |
| 19 | extern int intel_mid_pci_set_power_state(struct pci_dev *pdev, pci_power_t state); | 19 | extern int intel_mid_pci_set_power_state(struct pci_dev *pdev, pci_power_t state); |
| 20 | extern pci_power_t intel_mid_pci_get_power_state(struct pci_dev *pdev); | ||
| 20 | 21 | ||
| 21 | extern void intel_mid_pwr_power_off(void); | 22 | extern void intel_mid_pwr_power_off(void); |
| 22 | 23 | ||
diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c index b81fe2d63e15..1e81a37c034e 100644 --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c | |||
| @@ -347,7 +347,6 @@ static void amd_detect_cmp(struct cpuinfo_x86 *c) | |||
| 347 | #ifdef CONFIG_SMP | 347 | #ifdef CONFIG_SMP |
| 348 | unsigned bits; | 348 | unsigned bits; |
| 349 | int cpu = smp_processor_id(); | 349 | int cpu = smp_processor_id(); |
| 350 | unsigned int socket_id, core_complex_id; | ||
| 351 | 350 | ||
| 352 | bits = c->x86_coreid_bits; | 351 | bits = c->x86_coreid_bits; |
| 353 | /* Low order bits define the core id (index of core in socket) */ | 352 | /* Low order bits define the core id (index of core in socket) */ |
| @@ -365,10 +364,7 @@ static void amd_detect_cmp(struct cpuinfo_x86 *c) | |||
| 365 | if (c->x86 != 0x17 || !cpuid_edx(0x80000006)) | 364 | if (c->x86 != 0x17 || !cpuid_edx(0x80000006)) |
| 366 | return; | 365 | return; |
| 367 | 366 | ||
| 368 | socket_id = (c->apicid >> bits) - 1; | 367 | per_cpu(cpu_llc_id, cpu) = c->apicid >> 3; |
| 369 | core_complex_id = (c->apicid & ((1 << bits) - 1)) >> 3; | ||
| 370 | |||
| 371 | per_cpu(cpu_llc_id, cpu) = (socket_id << 3) | core_complex_id; | ||
| 372 | #endif | 368 | #endif |
| 373 | } | 369 | } |
| 374 | 370 | ||
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index 9bd910a7dd0a..cc9e980c68ec 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c | |||
| @@ -979,6 +979,35 @@ static void x86_init_cache_qos(struct cpuinfo_x86 *c) | |||
| 979 | } | 979 | } |
| 980 | 980 | ||
| 981 | /* | 981 | /* |
| 982 | * The physical to logical package id mapping is initialized from the | ||
| 983 | * acpi/mptables information. Make sure that CPUID actually agrees with | ||
| 984 | * that. | ||
| 985 | */ | ||
| 986 | static void sanitize_package_id(struct cpuinfo_x86 *c) | ||
| 987 | { | ||
| 988 | #ifdef CONFIG_SMP | ||
| 989 | unsigned int pkg, apicid, cpu = smp_processor_id(); | ||
| 990 | |||
| 991 | apicid = apic->cpu_present_to_apicid(cpu); | ||
| 992 | pkg = apicid >> boot_cpu_data.x86_coreid_bits; | ||
| 993 | |||
| 994 | if (apicid != c->initial_apicid) { | ||
| 995 | pr_err(FW_BUG "CPU%u: APIC id mismatch. Firmware: %x CPUID: %x\n", | ||
| 996 | cpu, apicid, c->initial_apicid); | ||
| 997 | c->initial_apicid = apicid; | ||
| 998 | } | ||
| 999 | if (pkg != c->phys_proc_id) { | ||
| 1000 | pr_err(FW_BUG "CPU%u: Using firmware package id %u instead of %u\n", | ||
| 1001 | cpu, pkg, c->phys_proc_id); | ||
| 1002 | c->phys_proc_id = pkg; | ||
| 1003 | } | ||
| 1004 | c->logical_proc_id = topology_phys_to_logical_pkg(pkg); | ||
| 1005 | #else | ||
| 1006 | c->logical_proc_id = 0; | ||
| 1007 | #endif | ||
| 1008 | } | ||
| 1009 | |||
| 1010 | /* | ||
| 982 | * This does the hard work of actually picking apart the CPU stuff... | 1011 | * This does the hard work of actually picking apart the CPU stuff... |
| 983 | */ | 1012 | */ |
| 984 | static void identify_cpu(struct cpuinfo_x86 *c) | 1013 | static void identify_cpu(struct cpuinfo_x86 *c) |
| @@ -1103,8 +1132,7 @@ static void identify_cpu(struct cpuinfo_x86 *c) | |||
| 1103 | #ifdef CONFIG_NUMA | 1132 | #ifdef CONFIG_NUMA |
| 1104 | numa_add_cpu(smp_processor_id()); | 1133 | numa_add_cpu(smp_processor_id()); |
| 1105 | #endif | 1134 | #endif |
| 1106 | /* The boot/hotplug time assigment got cleared, restore it */ | 1135 | sanitize_package_id(c); |
| 1107 | c->logical_proc_id = topology_phys_to_logical_pkg(c->phys_proc_id); | ||
| 1108 | } | 1136 | } |
| 1109 | 1137 | ||
| 1110 | /* | 1138 | /* |
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c index bf99aa7005eb..936a488d6cf6 100644 --- a/arch/x86/platform/efi/efi.c +++ b/arch/x86/platform/efi/efi.c | |||
| @@ -861,7 +861,7 @@ static void __init __efi_enter_virtual_mode(void) | |||
| 861 | int count = 0, pg_shift = 0; | 861 | int count = 0, pg_shift = 0; |
| 862 | void *new_memmap = NULL; | 862 | void *new_memmap = NULL; |
| 863 | efi_status_t status; | 863 | efi_status_t status; |
| 864 | phys_addr_t pa; | 864 | unsigned long pa; |
| 865 | 865 | ||
| 866 | efi.systab = NULL; | 866 | efi.systab = NULL; |
| 867 | 867 | ||
diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c index 58b0f801f66f..319148bd4b05 100644 --- a/arch/x86/platform/efi/efi_64.c +++ b/arch/x86/platform/efi/efi_64.c | |||
| @@ -31,6 +31,7 @@ | |||
| 31 | #include <linux/io.h> | 31 | #include <linux/io.h> |
| 32 | #include <linux/reboot.h> | 32 | #include <linux/reboot.h> |
| 33 | #include <linux/slab.h> | 33 | #include <linux/slab.h> |
| 34 | #include <linux/ucs2_string.h> | ||
| 34 | 35 | ||
| 35 | #include <asm/setup.h> | 36 | #include <asm/setup.h> |
| 36 | #include <asm/page.h> | 37 | #include <asm/page.h> |
| @@ -211,6 +212,35 @@ void efi_sync_low_kernel_mappings(void) | |||
| 211 | memcpy(pud_efi, pud_k, sizeof(pud_t) * num_entries); | 212 | memcpy(pud_efi, pud_k, sizeof(pud_t) * num_entries); |
| 212 | } | 213 | } |
| 213 | 214 | ||
| 215 | /* | ||
| 216 | * Wrapper for slow_virt_to_phys() that handles NULL addresses. | ||
| 217 | */ | ||
| 218 | static inline phys_addr_t | ||
| 219 | virt_to_phys_or_null_size(void *va, unsigned long size) | ||
| 220 | { | ||
| 221 | bool bad_size; | ||
| 222 | |||
| 223 | if (!va) | ||
| 224 | return 0; | ||
| 225 | |||
| 226 | if (virt_addr_valid(va)) | ||
| 227 | return virt_to_phys(va); | ||
| 228 | |||
| 229 | /* | ||
| 230 | * A fully aligned variable on the stack is guaranteed not to | ||
| 231 | * cross a page bounary. Try to catch strings on the stack by | ||
| 232 | * checking that 'size' is a power of two. | ||
| 233 | */ | ||
| 234 | bad_size = size > PAGE_SIZE || !is_power_of_2(size); | ||
| 235 | |||
| 236 | WARN_ON(!IS_ALIGNED((unsigned long)va, size) || bad_size); | ||
| 237 | |||
| 238 | return slow_virt_to_phys(va); | ||
| 239 | } | ||
| 240 | |||
| 241 | #define virt_to_phys_or_null(addr) \ | ||
| 242 | virt_to_phys_or_null_size((addr), sizeof(*(addr))) | ||
| 243 | |||
| 214 | int __init efi_setup_page_tables(unsigned long pa_memmap, unsigned num_pages) | 244 | int __init efi_setup_page_tables(unsigned long pa_memmap, unsigned num_pages) |
| 215 | { | 245 | { |
| 216 | unsigned long pfn, text; | 246 | unsigned long pfn, text; |
| @@ -494,8 +524,8 @@ static efi_status_t efi_thunk_get_time(efi_time_t *tm, efi_time_cap_t *tc) | |||
| 494 | 524 | ||
| 495 | spin_lock(&rtc_lock); | 525 | spin_lock(&rtc_lock); |
| 496 | 526 | ||
| 497 | phys_tm = virt_to_phys(tm); | 527 | phys_tm = virt_to_phys_or_null(tm); |
| 498 | phys_tc = virt_to_phys(tc); | 528 | phys_tc = virt_to_phys_or_null(tc); |
| 499 | 529 | ||
| 500 | status = efi_thunk(get_time, phys_tm, phys_tc); | 530 | status = efi_thunk(get_time, phys_tm, phys_tc); |
| 501 | 531 | ||
| @@ -511,7 +541,7 @@ static efi_status_t efi_thunk_set_time(efi_time_t *tm) | |||
| 511 | 541 | ||
| 512 | spin_lock(&rtc_lock); | 542 | spin_lock(&rtc_lock); |
| 513 | 543 | ||
| 514 | phys_tm = virt_to_phys(tm); | 544 | phys_tm = virt_to_phys_or_null(tm); |
| 515 | 545 | ||
| 516 | status = efi_thunk(set_time, phys_tm); | 546 | status = efi_thunk(set_time, phys_tm); |
| 517 | 547 | ||
| @@ -529,9 +559,9 @@ efi_thunk_get_wakeup_time(efi_bool_t *enabled, efi_bool_t *pending, | |||
| 529 | 559 | ||
| 530 | spin_lock(&rtc_lock); | 560 | spin_lock(&rtc_lock); |
| 531 | 561 | ||
| 532 | phys_enabled = virt_to_phys(enabled); | 562 | phys_enabled = virt_to_phys_or_null(enabled); |
| 533 | phys_pending = virt_to_phys(pending); | 563 | phys_pending = virt_to_phys_or_null(pending); |
| 534 | phys_tm = virt_to_phys(tm); | 564 | phys_tm = virt_to_phys_or_null(tm); |
| 535 | 565 | ||
| 536 | status = efi_thunk(get_wakeup_time, phys_enabled, | 566 | status = efi_thunk(get_wakeup_time, phys_enabled, |
| 537 | phys_pending, phys_tm); | 567 | phys_pending, phys_tm); |
| @@ -549,7 +579,7 @@ efi_thunk_set_wakeup_time(efi_bool_t enabled, efi_time_t *tm) | |||
| 549 | 579 | ||
| 550 | spin_lock(&rtc_lock); | 580 | spin_lock(&rtc_lock); |
| 551 | 581 | ||
| 552 | phys_tm = virt_to_phys(tm); | 582 | phys_tm = virt_to_phys_or_null(tm); |
| 553 | 583 | ||
| 554 | status = efi_thunk(set_wakeup_time, enabled, phys_tm); | 584 | status = efi_thunk(set_wakeup_time, enabled, phys_tm); |
| 555 | 585 | ||
| @@ -558,6 +588,10 @@ efi_thunk_set_wakeup_time(efi_bool_t enabled, efi_time_t *tm) | |||
| 558 | return status; | 588 | return status; |
| 559 | } | 589 | } |
| 560 | 590 | ||
| 591 | static unsigned long efi_name_size(efi_char16_t *name) | ||
| 592 | { | ||
| 593 | return ucs2_strsize(name, EFI_VAR_NAME_LEN) + 1; | ||
| 594 | } | ||
| 561 | 595 | ||
| 562 | static efi_status_t | 596 | static efi_status_t |
| 563 | efi_thunk_get_variable(efi_char16_t *name, efi_guid_t *vendor, | 597 | efi_thunk_get_variable(efi_char16_t *name, efi_guid_t *vendor, |
| @@ -567,11 +601,11 @@ efi_thunk_get_variable(efi_char16_t *name, efi_guid_t *vendor, | |||
| 567 | u32 phys_name, phys_vendor, phys_attr; | 601 | u32 phys_name, phys_vendor, phys_attr; |
| 568 | u32 phys_data_size, phys_data; | 602 | u32 phys_data_size, phys_data; |
| 569 | 603 | ||
| 570 | phys_data_size = virt_to_phys(data_size); | 604 | phys_data_size = virt_to_phys_or_null(data_size); |
| 571 | phys_vendor = virt_to_phys(vendor); | 605 | phys_vendor = virt_to_phys_or_null(vendor); |
| 572 | phys_name = virt_to_phys(name); | 606 | phys_name = virt_to_phys_or_null_size(name, efi_name_size(name)); |
| 573 | phys_attr = virt_to_phys(attr); | 607 | phys_attr = virt_to_phys_or_null(attr); |
| 574 | phys_data = virt_to_phys(data); | 608 | phys_data = virt_to_phys_or_null_size(data, *data_size); |
| 575 | 609 | ||
| 576 | status = efi_thunk(get_variable, phys_name, phys_vendor, | 610 | status = efi_thunk(get_variable, phys_name, phys_vendor, |
| 577 | phys_attr, phys_data_size, phys_data); | 611 | phys_attr, phys_data_size, phys_data); |
| @@ -586,9 +620,9 @@ efi_thunk_set_variable(efi_char16_t *name, efi_guid_t *vendor, | |||
| 586 | u32 phys_name, phys_vendor, phys_data; | 620 | u32 phys_name, phys_vendor, phys_data; |
| 587 | efi_status_t status; | 621 | efi_status_t status; |
| 588 | 622 | ||
| 589 | phys_name = virt_to_phys(name); | 623 | phys_name = virt_to_phys_or_null_size(name, efi_name_size(name)); |
| 590 | phys_vendor = virt_to_phys(vendor); | 624 | phys_vendor = virt_to_phys_or_null(vendor); |
| 591 | phys_data = virt_to_phys(data); | 625 | phys_data = virt_to_phys_or_null_size(data, data_size); |
| 592 | 626 | ||
| 593 | /* If data_size is > sizeof(u32) we've got problems */ | 627 | /* If data_size is > sizeof(u32) we've got problems */ |
| 594 | status = efi_thunk(set_variable, phys_name, phys_vendor, | 628 | status = efi_thunk(set_variable, phys_name, phys_vendor, |
| @@ -605,9 +639,9 @@ efi_thunk_get_next_variable(unsigned long *name_size, | |||
| 605 | efi_status_t status; | 639 | efi_status_t status; |
| 606 | u32 phys_name_size, phys_name, phys_vendor; | 640 | u32 phys_name_size, phys_name, phys_vendor; |
| 607 | 641 | ||
| 608 | phys_name_size = virt_to_phys(name_size); | 642 | phys_name_size = virt_to_phys_or_null(name_size); |
| 609 | phys_vendor = virt_to_phys(vendor); | 643 | phys_vendor = virt_to_phys_or_null(vendor); |
| 610 | phys_name = virt_to_phys(name); | 644 | phys_name = virt_to_phys_or_null_size(name, *name_size); |
| 611 | 645 | ||
| 612 | status = efi_thunk(get_next_variable, phys_name_size, | 646 | status = efi_thunk(get_next_variable, phys_name_size, |
| 613 | phys_name, phys_vendor); | 647 | phys_name, phys_vendor); |
| @@ -621,7 +655,7 @@ efi_thunk_get_next_high_mono_count(u32 *count) | |||
| 621 | efi_status_t status; | 655 | efi_status_t status; |
| 622 | u32 phys_count; | 656 | u32 phys_count; |
| 623 | 657 | ||
| 624 | phys_count = virt_to_phys(count); | 658 | phys_count = virt_to_phys_or_null(count); |
| 625 | status = efi_thunk(get_next_high_mono_count, phys_count); | 659 | status = efi_thunk(get_next_high_mono_count, phys_count); |
| 626 | 660 | ||
| 627 | return status; | 661 | return status; |
| @@ -633,7 +667,7 @@ efi_thunk_reset_system(int reset_type, efi_status_t status, | |||
| 633 | { | 667 | { |
| 634 | u32 phys_data; | 668 | u32 phys_data; |
| 635 | 669 | ||
| 636 | phys_data = virt_to_phys(data); | 670 | phys_data = virt_to_phys_or_null_size(data, data_size); |
| 637 | 671 | ||
| 638 | efi_thunk(reset_system, reset_type, status, data_size, phys_data); | 672 | efi_thunk(reset_system, reset_type, status, data_size, phys_data); |
| 639 | } | 673 | } |
| @@ -661,9 +695,9 @@ efi_thunk_query_variable_info(u32 attr, u64 *storage_space, | |||
| 661 | if (efi.runtime_version < EFI_2_00_SYSTEM_TABLE_REVISION) | 695 | if (efi.runtime_version < EFI_2_00_SYSTEM_TABLE_REVISION) |
| 662 | return EFI_UNSUPPORTED; | 696 | return EFI_UNSUPPORTED; |
| 663 | 697 | ||
| 664 | phys_storage = virt_to_phys(storage_space); | 698 | phys_storage = virt_to_phys_or_null(storage_space); |
| 665 | phys_remaining = virt_to_phys(remaining_space); | 699 | phys_remaining = virt_to_phys_or_null(remaining_space); |
| 666 | phys_max = virt_to_phys(max_variable_size); | 700 | phys_max = virt_to_phys_or_null(max_variable_size); |
| 667 | 701 | ||
| 668 | status = efi_thunk(query_variable_info, attr, phys_storage, | 702 | status = efi_thunk(query_variable_info, attr, phys_storage, |
| 669 | phys_remaining, phys_max); | 703 | phys_remaining, phys_max); |
diff --git a/arch/x86/platform/intel-mid/pwr.c b/arch/x86/platform/intel-mid/pwr.c index 5d3b45ad1c03..67375dda451c 100644 --- a/arch/x86/platform/intel-mid/pwr.c +++ b/arch/x86/platform/intel-mid/pwr.c | |||
| @@ -272,6 +272,25 @@ int intel_mid_pci_set_power_state(struct pci_dev *pdev, pci_power_t state) | |||
| 272 | } | 272 | } |
| 273 | EXPORT_SYMBOL_GPL(intel_mid_pci_set_power_state); | 273 | EXPORT_SYMBOL_GPL(intel_mid_pci_set_power_state); |
| 274 | 274 | ||
| 275 | pci_power_t intel_mid_pci_get_power_state(struct pci_dev *pdev) | ||
| 276 | { | ||
| 277 | struct mid_pwr *pwr = midpwr; | ||
| 278 | int id, reg, bit; | ||
| 279 | u32 power; | ||
| 280 | |||
| 281 | if (!pwr || !pwr->available) | ||
| 282 | return PCI_UNKNOWN; | ||
| 283 | |||
| 284 | id = intel_mid_pwr_get_lss_id(pdev); | ||
| 285 | if (id < 0) | ||
| 286 | return PCI_UNKNOWN; | ||
| 287 | |||
| 288 | reg = (id * LSS_PWS_BITS) / 32; | ||
| 289 | bit = (id * LSS_PWS_BITS) % 32; | ||
| 290 | power = mid_pwr_get_state(pwr, reg); | ||
| 291 | return (__force pci_power_t)((power >> bit) & 3); | ||
| 292 | } | ||
| 293 | |||
| 275 | void intel_mid_pwr_power_off(void) | 294 | void intel_mid_pwr_power_off(void) |
| 276 | { | 295 | { |
| 277 | struct mid_pwr *pwr = midpwr; | 296 | struct mid_pwr *pwr = midpwr; |
diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile index ac58c1616408..555b9fa0ad43 100644 --- a/arch/x86/purgatory/Makefile +++ b/arch/x86/purgatory/Makefile | |||
| @@ -16,6 +16,7 @@ KCOV_INSTRUMENT := n | |||
| 16 | 16 | ||
| 17 | KBUILD_CFLAGS := -fno-strict-aliasing -Wall -Wstrict-prototypes -fno-zero-initialized-in-bss -fno-builtin -ffreestanding -c -MD -Os -mcmodel=large | 17 | KBUILD_CFLAGS := -fno-strict-aliasing -Wall -Wstrict-prototypes -fno-zero-initialized-in-bss -fno-builtin -ffreestanding -c -MD -Os -mcmodel=large |
| 18 | KBUILD_CFLAGS += -m$(BITS) | 18 | KBUILD_CFLAGS += -m$(BITS) |
| 19 | KBUILD_CFLAGS += $(call cc-option,-fno-PIE) | ||
| 19 | 20 | ||
| 20 | $(obj)/purgatory.ro: $(PURGATORY_OBJS) FORCE | 21 | $(obj)/purgatory.ro: $(PURGATORY_OBJS) FORCE |
| 21 | $(call if_changed,ld) | 22 | $(call if_changed,ld) |
diff --git a/arch/xtensa/include/uapi/asm/unistd.h b/arch/xtensa/include/uapi/asm/unistd.h index de9b14b2d348..cd400af4a6b2 100644 --- a/arch/xtensa/include/uapi/asm/unistd.h +++ b/arch/xtensa/include/uapi/asm/unistd.h | |||
| @@ -767,7 +767,14 @@ __SYSCALL(346, sys_preadv2, 6) | |||
| 767 | #define __NR_pwritev2 347 | 767 | #define __NR_pwritev2 347 |
| 768 | __SYSCALL(347, sys_pwritev2, 6) | 768 | __SYSCALL(347, sys_pwritev2, 6) |
| 769 | 769 | ||
| 770 | #define __NR_syscall_count 348 | 770 | #define __NR_pkey_mprotect 348 |
| 771 | __SYSCALL(348, sys_pkey_mprotect, 4) | ||
| 772 | #define __NR_pkey_alloc 349 | ||
| 773 | __SYSCALL(349, sys_pkey_alloc, 2) | ||
| 774 | #define __NR_pkey_free 350 | ||
| 775 | __SYSCALL(350, sys_pkey_free, 1) | ||
| 776 | |||
| 777 | #define __NR_syscall_count 351 | ||
| 771 | 778 | ||
| 772 | /* | 779 | /* |
| 773 | * sysxtensa syscall handler | 780 | * sysxtensa syscall handler |
diff --git a/arch/xtensa/kernel/time.c b/arch/xtensa/kernel/time.c index 9a5bcd0381a7..be81e69b25bc 100644 --- a/arch/xtensa/kernel/time.c +++ b/arch/xtensa/kernel/time.c | |||
| @@ -172,10 +172,11 @@ void __init time_init(void) | |||
| 172 | { | 172 | { |
| 173 | of_clk_init(NULL); | 173 | of_clk_init(NULL); |
| 174 | #ifdef CONFIG_XTENSA_CALIBRATE_CCOUNT | 174 | #ifdef CONFIG_XTENSA_CALIBRATE_CCOUNT |
| 175 | printk("Calibrating CPU frequency "); | 175 | pr_info("Calibrating CPU frequency "); |
| 176 | calibrate_ccount(); | 176 | calibrate_ccount(); |
| 177 | printk("%d.%02d MHz\n", (int)ccount_freq/1000000, | 177 | pr_cont("%d.%02d MHz\n", |
| 178 | (int)(ccount_freq/10000)%100); | 178 | (int)ccount_freq / 1000000, |
| 179 | (int)(ccount_freq / 10000) % 100); | ||
| 179 | #else | 180 | #else |
| 180 | ccount_freq = CONFIG_XTENSA_CPU_CLOCK*1000000UL; | 181 | ccount_freq = CONFIG_XTENSA_CPU_CLOCK*1000000UL; |
| 181 | #endif | 182 | #endif |
| @@ -210,9 +211,8 @@ irqreturn_t timer_interrupt(int irq, void *dev_id) | |||
| 210 | void calibrate_delay(void) | 211 | void calibrate_delay(void) |
| 211 | { | 212 | { |
| 212 | loops_per_jiffy = ccount_freq / HZ; | 213 | loops_per_jiffy = ccount_freq / HZ; |
| 213 | printk("Calibrating delay loop (skipped)... " | 214 | pr_info("Calibrating delay loop (skipped)... %lu.%02lu BogoMIPS preset\n", |
| 214 | "%lu.%02lu BogoMIPS preset\n", | 215 | loops_per_jiffy / (1000000 / HZ), |
| 215 | loops_per_jiffy/(1000000/HZ), | 216 | (loops_per_jiffy / (10000 / HZ)) % 100); |
| 216 | (loops_per_jiffy/(10000/HZ)) % 100); | ||
| 217 | } | 217 | } |
| 218 | #endif | 218 | #endif |
diff --git a/arch/xtensa/kernel/traps.c b/arch/xtensa/kernel/traps.c index d02fc304b31c..ce37d5b899fe 100644 --- a/arch/xtensa/kernel/traps.c +++ b/arch/xtensa/kernel/traps.c | |||
| @@ -465,26 +465,25 @@ void show_regs(struct pt_regs * regs) | |||
| 465 | 465 | ||
| 466 | for (i = 0; i < 16; i++) { | 466 | for (i = 0; i < 16; i++) { |
| 467 | if ((i % 8) == 0) | 467 | if ((i % 8) == 0) |
| 468 | printk(KERN_INFO "a%02d:", i); | 468 | pr_info("a%02d:", i); |
| 469 | printk(KERN_CONT " %08lx", regs->areg[i]); | 469 | pr_cont(" %08lx", regs->areg[i]); |
| 470 | } | 470 | } |
| 471 | printk(KERN_CONT "\n"); | 471 | pr_cont("\n"); |
| 472 | 472 | pr_info("pc: %08lx, ps: %08lx, depc: %08lx, excvaddr: %08lx\n", | |
| 473 | printk("pc: %08lx, ps: %08lx, depc: %08lx, excvaddr: %08lx\n", | 473 | regs->pc, regs->ps, regs->depc, regs->excvaddr); |
| 474 | regs->pc, regs->ps, regs->depc, regs->excvaddr); | 474 | pr_info("lbeg: %08lx, lend: %08lx lcount: %08lx, sar: %08lx\n", |
| 475 | printk("lbeg: %08lx, lend: %08lx lcount: %08lx, sar: %08lx\n", | 475 | regs->lbeg, regs->lend, regs->lcount, regs->sar); |
| 476 | regs->lbeg, regs->lend, regs->lcount, regs->sar); | ||
| 477 | if (user_mode(regs)) | 476 | if (user_mode(regs)) |
| 478 | printk("wb: %08lx, ws: %08lx, wmask: %08lx, syscall: %ld\n", | 477 | pr_cont("wb: %08lx, ws: %08lx, wmask: %08lx, syscall: %ld\n", |
| 479 | regs->windowbase, regs->windowstart, regs->wmask, | 478 | regs->windowbase, regs->windowstart, regs->wmask, |
| 480 | regs->syscall); | 479 | regs->syscall); |
| 481 | } | 480 | } |
| 482 | 481 | ||
| 483 | static int show_trace_cb(struct stackframe *frame, void *data) | 482 | static int show_trace_cb(struct stackframe *frame, void *data) |
| 484 | { | 483 | { |
| 485 | if (kernel_text_address(frame->pc)) { | 484 | if (kernel_text_address(frame->pc)) { |
| 486 | printk(" [<%08lx>] ", frame->pc); | 485 | pr_cont(" [<%08lx>]", frame->pc); |
| 487 | print_symbol("%s\n", frame->pc); | 486 | print_symbol(" %s\n", frame->pc); |
| 488 | } | 487 | } |
| 489 | return 0; | 488 | return 0; |
| 490 | } | 489 | } |
| @@ -494,19 +493,13 @@ void show_trace(struct task_struct *task, unsigned long *sp) | |||
| 494 | if (!sp) | 493 | if (!sp) |
| 495 | sp = stack_pointer(task); | 494 | sp = stack_pointer(task); |
| 496 | 495 | ||
| 497 | printk("Call Trace:"); | 496 | pr_info("Call Trace:\n"); |
| 498 | #ifdef CONFIG_KALLSYMS | ||
| 499 | printk("\n"); | ||
| 500 | #endif | ||
| 501 | walk_stackframe(sp, show_trace_cb, NULL); | 497 | walk_stackframe(sp, show_trace_cb, NULL); |
| 502 | printk("\n"); | 498 | #ifndef CONFIG_KALLSYMS |
| 499 | pr_cont("\n"); | ||
| 500 | #endif | ||
| 503 | } | 501 | } |
| 504 | 502 | ||
| 505 | /* | ||
| 506 | * This routine abuses get_user()/put_user() to reference pointers | ||
| 507 | * with at least a bit of error checking ... | ||
| 508 | */ | ||
| 509 | |||
| 510 | static int kstack_depth_to_print = 24; | 503 | static int kstack_depth_to_print = 24; |
| 511 | 504 | ||
| 512 | void show_stack(struct task_struct *task, unsigned long *sp) | 505 | void show_stack(struct task_struct *task, unsigned long *sp) |
| @@ -518,52 +511,29 @@ void show_stack(struct task_struct *task, unsigned long *sp) | |||
| 518 | sp = stack_pointer(task); | 511 | sp = stack_pointer(task); |
| 519 | stack = sp; | 512 | stack = sp; |
| 520 | 513 | ||
| 521 | printk("\nStack: "); | 514 | pr_info("Stack:\n"); |
| 522 | 515 | ||
| 523 | for (i = 0; i < kstack_depth_to_print; i++) { | 516 | for (i = 0; i < kstack_depth_to_print; i++) { |
| 524 | if (kstack_end(sp)) | 517 | if (kstack_end(sp)) |
| 525 | break; | 518 | break; |
| 526 | if (i && ((i % 8) == 0)) | 519 | pr_cont(" %08lx", *sp++); |
| 527 | printk("\n "); | 520 | if (i % 8 == 7) |
| 528 | printk("%08lx ", *sp++); | 521 | pr_cont("\n"); |
| 529 | } | 522 | } |
| 530 | printk("\n"); | ||
| 531 | show_trace(task, stack); | 523 | show_trace(task, stack); |
| 532 | } | 524 | } |
| 533 | 525 | ||
| 534 | void show_code(unsigned int *pc) | ||
| 535 | { | ||
| 536 | long i; | ||
| 537 | |||
| 538 | printk("\nCode:"); | ||
| 539 | |||
| 540 | for(i = -3 ; i < 6 ; i++) { | ||
| 541 | unsigned long insn; | ||
| 542 | if (__get_user(insn, pc + i)) { | ||
| 543 | printk(" (Bad address in pc)\n"); | ||
| 544 | break; | ||
| 545 | } | ||
| 546 | printk("%c%08lx%c",(i?' ':'<'),insn,(i?' ':'>')); | ||
| 547 | } | ||
| 548 | } | ||
| 549 | |||
| 550 | DEFINE_SPINLOCK(die_lock); | 526 | DEFINE_SPINLOCK(die_lock); |
| 551 | 527 | ||
| 552 | void die(const char * str, struct pt_regs * regs, long err) | 528 | void die(const char * str, struct pt_regs * regs, long err) |
| 553 | { | 529 | { |
| 554 | static int die_counter; | 530 | static int die_counter; |
| 555 | int nl = 0; | ||
| 556 | 531 | ||
| 557 | console_verbose(); | 532 | console_verbose(); |
| 558 | spin_lock_irq(&die_lock); | 533 | spin_lock_irq(&die_lock); |
| 559 | 534 | ||
| 560 | printk("%s: sig: %ld [#%d]\n", str, err, ++die_counter); | 535 | pr_info("%s: sig: %ld [#%d]%s\n", str, err, ++die_counter, |
| 561 | #ifdef CONFIG_PREEMPT | 536 | IS_ENABLED(CONFIG_PREEMPT) ? " PREEMPT" : ""); |
| 562 | printk("PREEMPT "); | ||
| 563 | nl = 1; | ||
| 564 | #endif | ||
| 565 | if (nl) | ||
| 566 | printk("\n"); | ||
| 567 | show_regs(regs); | 537 | show_regs(regs); |
| 568 | if (!user_mode(regs)) | 538 | if (!user_mode(regs)) |
| 569 | show_stack(NULL, (unsigned long*)regs->areg[1]); | 539 | show_stack(NULL, (unsigned long*)regs->areg[1]); |
diff --git a/crypto/algif_hash.c b/crypto/algif_hash.c index 2d8466f9e49b..05e21b464433 100644 --- a/crypto/algif_hash.c +++ b/crypto/algif_hash.c | |||
| @@ -214,23 +214,26 @@ static int hash_recvmsg(struct socket *sock, struct msghdr *msg, size_t len, | |||
| 214 | 214 | ||
| 215 | ahash_request_set_crypt(&ctx->req, NULL, ctx->result, 0); | 215 | ahash_request_set_crypt(&ctx->req, NULL, ctx->result, 0); |
| 216 | 216 | ||
| 217 | if (ctx->more) { | 217 | if (!result) { |
| 218 | err = af_alg_wait_for_completion( | ||
| 219 | crypto_ahash_init(&ctx->req), | ||
| 220 | &ctx->completion); | ||
| 221 | if (err) | ||
| 222 | goto unlock; | ||
| 223 | } | ||
| 224 | |||
| 225 | if (!result || ctx->more) { | ||
| 218 | ctx->more = 0; | 226 | ctx->more = 0; |
| 219 | err = af_alg_wait_for_completion(crypto_ahash_final(&ctx->req), | 227 | err = af_alg_wait_for_completion(crypto_ahash_final(&ctx->req), |
| 220 | &ctx->completion); | 228 | &ctx->completion); |
| 221 | if (err) | 229 | if (err) |
| 222 | goto unlock; | 230 | goto unlock; |
| 223 | } else if (!result) { | ||
| 224 | err = af_alg_wait_for_completion( | ||
| 225 | crypto_ahash_digest(&ctx->req), | ||
| 226 | &ctx->completion); | ||
| 227 | } | 231 | } |
| 228 | 232 | ||
| 229 | err = memcpy_to_msg(msg, ctx->result, len); | 233 | err = memcpy_to_msg(msg, ctx->result, len); |
| 230 | 234 | ||
| 231 | hash_free_result(sk, ctx); | ||
| 232 | |||
| 233 | unlock: | 235 | unlock: |
| 236 | hash_free_result(sk, ctx); | ||
| 234 | release_sock(sk); | 237 | release_sock(sk); |
| 235 | 238 | ||
| 236 | return err ?: len; | 239 | return err ?: len; |
diff --git a/drivers/acpi/acpica/tbfadt.c b/drivers/acpi/acpica/tbfadt.c index 046c4d0394ee..5fb838e592dc 100644 --- a/drivers/acpi/acpica/tbfadt.c +++ b/drivers/acpi/acpica/tbfadt.c | |||
| @@ -480,19 +480,17 @@ static void acpi_tb_convert_fadt(void) | |||
| 480 | u32 i; | 480 | u32 i; |
| 481 | 481 | ||
| 482 | /* | 482 | /* |
| 483 | * For ACPI 1.0 FADTs (revision 1), ensure that reserved fields which | 483 | * For ACPI 1.0 FADTs (revision 1 or 2), ensure that reserved fields which |
| 484 | * should be zero are indeed zero. This will workaround BIOSs that | 484 | * should be zero are indeed zero. This will workaround BIOSs that |
| 485 | * inadvertently place values in these fields. | 485 | * inadvertently place values in these fields. |
| 486 | * | 486 | * |
| 487 | * The ACPI 1.0 reserved fields that will be zeroed are the bytes located | 487 | * The ACPI 1.0 reserved fields that will be zeroed are the bytes located |
| 488 | * at offset 45, 55, 95, and the word located at offset 109, 110. | 488 | * at offset 45, 55, 95, and the word located at offset 109, 110. |
| 489 | * | 489 | * |
| 490 | * Note: The FADT revision value is unreliable because of BIOS errors. | 490 | * Note: The FADT revision value is unreliable. Only the length can be |
| 491 | * The table length is instead used as the final word on the version. | 491 | * trusted. |
| 492 | * | ||
| 493 | * Note: FADT revision 3 is the ACPI 2.0 version of the FADT. | ||
| 494 | */ | 492 | */ |
| 495 | if (acpi_gbl_FADT.header.length <= ACPI_FADT_V3_SIZE) { | 493 | if (acpi_gbl_FADT.header.length <= ACPI_FADT_V2_SIZE) { |
| 496 | acpi_gbl_FADT.preferred_profile = 0; | 494 | acpi_gbl_FADT.preferred_profile = 0; |
| 497 | acpi_gbl_FADT.pstate_control = 0; | 495 | acpi_gbl_FADT.pstate_control = 0; |
| 498 | acpi_gbl_FADT.cst_control = 0; | 496 | acpi_gbl_FADT.cst_control = 0; |
diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg.c index 156aad167cd6..954a64c7757b 100644 --- a/drivers/crypto/caam/caamalg.c +++ b/drivers/crypto/caam/caamalg.c | |||
| @@ -137,7 +137,7 @@ static void dbg_dump_sg(const char *level, const char *prefix_str, | |||
| 137 | } | 137 | } |
| 138 | 138 | ||
| 139 | buf = it_page + it->offset; | 139 | buf = it_page + it->offset; |
| 140 | len = min(tlen, it->length); | 140 | len = min_t(size_t, tlen, it->length); |
| 141 | print_hex_dump(level, prefix_str, prefix_type, rowsize, | 141 | print_hex_dump(level, prefix_str, prefix_type, rowsize, |
| 142 | groupsize, buf, len, ascii); | 142 | groupsize, buf, len, ascii); |
| 143 | tlen -= len; | 143 | tlen -= len; |
| @@ -4583,6 +4583,15 @@ static int __init caam_algapi_init(void) | |||
| 4583 | if (!aes_inst && (alg_sel == OP_ALG_ALGSEL_AES)) | 4583 | if (!aes_inst && (alg_sel == OP_ALG_ALGSEL_AES)) |
| 4584 | continue; | 4584 | continue; |
| 4585 | 4585 | ||
| 4586 | /* | ||
| 4587 | * Check support for AES modes not available | ||
| 4588 | * on LP devices. | ||
| 4589 | */ | ||
| 4590 | if ((cha_vid & CHA_ID_LS_AES_MASK) == CHA_ID_LS_AES_LP) | ||
| 4591 | if ((alg->class1_alg_type & OP_ALG_AAI_MASK) == | ||
| 4592 | OP_ALG_AAI_XTS) | ||
| 4593 | continue; | ||
| 4594 | |||
| 4586 | t_alg = caam_alg_alloc(alg); | 4595 | t_alg = caam_alg_alloc(alg); |
| 4587 | if (IS_ERR(t_alg)) { | 4596 | if (IS_ERR(t_alg)) { |
| 4588 | err = PTR_ERR(t_alg); | 4597 | err = PTR_ERR(t_alg); |
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index af63a6bcf564..141aefbe37ec 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig | |||
| @@ -306,6 +306,7 @@ config MMP_TDMA | |||
| 306 | depends on ARCH_MMP || COMPILE_TEST | 306 | depends on ARCH_MMP || COMPILE_TEST |
| 307 | select DMA_ENGINE | 307 | select DMA_ENGINE |
| 308 | select MMP_SRAM if ARCH_MMP | 308 | select MMP_SRAM if ARCH_MMP |
| 309 | select GENERIC_ALLOCATOR | ||
| 309 | help | 310 | help |
| 310 | Support the MMP Two-Channel DMA engine. | 311 | Support the MMP Two-Channel DMA engine. |
| 311 | This engine used for MMP Audio DMA and pxa910 SQU. | 312 | This engine used for MMP Audio DMA and pxa910 SQU. |
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c index bac5f023013b..d5ba43a87a68 100644 --- a/drivers/dma/cppi41.c +++ b/drivers/dma/cppi41.c | |||
| @@ -317,6 +317,12 @@ static irqreturn_t cppi41_irq(int irq, void *data) | |||
| 317 | 317 | ||
| 318 | while (val) { | 318 | while (val) { |
| 319 | u32 desc, len; | 319 | u32 desc, len; |
| 320 | int error; | ||
| 321 | |||
| 322 | error = pm_runtime_get(cdd->ddev.dev); | ||
| 323 | if (error < 0) | ||
| 324 | dev_err(cdd->ddev.dev, "%s pm runtime get: %i\n", | ||
| 325 | __func__, error); | ||
| 320 | 326 | ||
| 321 | q_num = __fls(val); | 327 | q_num = __fls(val); |
| 322 | val &= ~(1 << q_num); | 328 | val &= ~(1 << q_num); |
| @@ -338,7 +344,6 @@ static irqreturn_t cppi41_irq(int irq, void *data) | |||
| 338 | dma_cookie_complete(&c->txd); | 344 | dma_cookie_complete(&c->txd); |
| 339 | dmaengine_desc_get_callback_invoke(&c->txd, NULL); | 345 | dmaengine_desc_get_callback_invoke(&c->txd, NULL); |
| 340 | 346 | ||
| 341 | /* Paired with cppi41_dma_issue_pending */ | ||
| 342 | pm_runtime_mark_last_busy(cdd->ddev.dev); | 347 | pm_runtime_mark_last_busy(cdd->ddev.dev); |
| 343 | pm_runtime_put_autosuspend(cdd->ddev.dev); | 348 | pm_runtime_put_autosuspend(cdd->ddev.dev); |
| 344 | } | 349 | } |
| @@ -362,8 +367,13 @@ static int cppi41_dma_alloc_chan_resources(struct dma_chan *chan) | |||
| 362 | int error; | 367 | int error; |
| 363 | 368 | ||
| 364 | error = pm_runtime_get_sync(cdd->ddev.dev); | 369 | error = pm_runtime_get_sync(cdd->ddev.dev); |
| 365 | if (error < 0) | 370 | if (error < 0) { |
| 371 | dev_err(cdd->ddev.dev, "%s pm runtime get: %i\n", | ||
| 372 | __func__, error); | ||
| 373 | pm_runtime_put_noidle(cdd->ddev.dev); | ||
| 374 | |||
| 366 | return error; | 375 | return error; |
| 376 | } | ||
| 367 | 377 | ||
| 368 | dma_cookie_init(chan); | 378 | dma_cookie_init(chan); |
| 369 | dma_async_tx_descriptor_init(&c->txd, chan); | 379 | dma_async_tx_descriptor_init(&c->txd, chan); |
| @@ -385,8 +395,11 @@ static void cppi41_dma_free_chan_resources(struct dma_chan *chan) | |||
| 385 | int error; | 395 | int error; |
| 386 | 396 | ||
| 387 | error = pm_runtime_get_sync(cdd->ddev.dev); | 397 | error = pm_runtime_get_sync(cdd->ddev.dev); |
| 388 | if (error < 0) | 398 | if (error < 0) { |
| 399 | pm_runtime_put_noidle(cdd->ddev.dev); | ||
| 400 | |||
| 389 | return; | 401 | return; |
| 402 | } | ||
| 390 | 403 | ||
| 391 | WARN_ON(!list_empty(&cdd->pending)); | 404 | WARN_ON(!list_empty(&cdd->pending)); |
| 392 | 405 | ||
| @@ -460,9 +473,9 @@ static void cppi41_dma_issue_pending(struct dma_chan *chan) | |||
| 460 | struct cppi41_dd *cdd = c->cdd; | 473 | struct cppi41_dd *cdd = c->cdd; |
| 461 | int error; | 474 | int error; |
| 462 | 475 | ||
| 463 | /* PM runtime paired with dmaengine_desc_get_callback_invoke */ | ||
| 464 | error = pm_runtime_get(cdd->ddev.dev); | 476 | error = pm_runtime_get(cdd->ddev.dev); |
| 465 | if ((error != -EINPROGRESS) && error < 0) { | 477 | if ((error != -EINPROGRESS) && error < 0) { |
| 478 | pm_runtime_put_noidle(cdd->ddev.dev); | ||
| 466 | dev_err(cdd->ddev.dev, "Failed to pm_runtime_get: %i\n", | 479 | dev_err(cdd->ddev.dev, "Failed to pm_runtime_get: %i\n", |
| 467 | error); | 480 | error); |
| 468 | 481 | ||
| @@ -473,6 +486,9 @@ static void cppi41_dma_issue_pending(struct dma_chan *chan) | |||
| 473 | push_desc_queue(c); | 486 | push_desc_queue(c); |
| 474 | else | 487 | else |
| 475 | pending_desc(c); | 488 | pending_desc(c); |
| 489 | |||
| 490 | pm_runtime_mark_last_busy(cdd->ddev.dev); | ||
| 491 | pm_runtime_put_autosuspend(cdd->ddev.dev); | ||
| 476 | } | 492 | } |
| 477 | 493 | ||
| 478 | static u32 get_host_pd0(u32 length) | 494 | static u32 get_host_pd0(u32 length) |
| @@ -1059,8 +1075,8 @@ err_chans: | |||
| 1059 | deinit_cppi41(dev, cdd); | 1075 | deinit_cppi41(dev, cdd); |
| 1060 | err_init_cppi: | 1076 | err_init_cppi: |
| 1061 | pm_runtime_dont_use_autosuspend(dev); | 1077 | pm_runtime_dont_use_autosuspend(dev); |
| 1062 | pm_runtime_put_sync(dev); | ||
| 1063 | err_get_sync: | 1078 | err_get_sync: |
| 1079 | pm_runtime_put_sync(dev); | ||
| 1064 | pm_runtime_disable(dev); | 1080 | pm_runtime_disable(dev); |
| 1065 | iounmap(cdd->usbss_mem); | 1081 | iounmap(cdd->usbss_mem); |
| 1066 | iounmap(cdd->ctrl_mem); | 1082 | iounmap(cdd->ctrl_mem); |
| @@ -1072,7 +1088,12 @@ err_get_sync: | |||
| 1072 | static int cppi41_dma_remove(struct platform_device *pdev) | 1088 | static int cppi41_dma_remove(struct platform_device *pdev) |
| 1073 | { | 1089 | { |
| 1074 | struct cppi41_dd *cdd = platform_get_drvdata(pdev); | 1090 | struct cppi41_dd *cdd = platform_get_drvdata(pdev); |
| 1091 | int error; | ||
| 1075 | 1092 | ||
| 1093 | error = pm_runtime_get_sync(&pdev->dev); | ||
| 1094 | if (error < 0) | ||
| 1095 | dev_err(&pdev->dev, "%s could not pm_runtime_get: %i\n", | ||
| 1096 | __func__, error); | ||
| 1076 | of_dma_controller_free(pdev->dev.of_node); | 1097 | of_dma_controller_free(pdev->dev.of_node); |
| 1077 | dma_async_device_unregister(&cdd->ddev); | 1098 | dma_async_device_unregister(&cdd->ddev); |
| 1078 | 1099 | ||
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index e18a58068bca..77242b37ef87 100644 --- a/drivers/dma/edma.c +++ b/drivers/dma/edma.c | |||
| @@ -1628,6 +1628,7 @@ static int edma_alloc_chan_resources(struct dma_chan *chan) | |||
| 1628 | if (echan->slot[0] < 0) { | 1628 | if (echan->slot[0] < 0) { |
| 1629 | dev_err(dev, "Entry slot allocation failed for channel %u\n", | 1629 | dev_err(dev, "Entry slot allocation failed for channel %u\n", |
| 1630 | EDMA_CHAN_SLOT(echan->ch_num)); | 1630 | EDMA_CHAN_SLOT(echan->ch_num)); |
| 1631 | ret = echan->slot[0]; | ||
| 1631 | goto err_slot; | 1632 | goto err_slot; |
| 1632 | } | 1633 | } |
| 1633 | 1634 | ||
diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c index 83461994e418..a2358780ab2c 100644 --- a/drivers/dma/sun6i-dma.c +++ b/drivers/dma/sun6i-dma.c | |||
| @@ -578,7 +578,7 @@ static struct dma_async_tx_descriptor *sun6i_dma_prep_dma_memcpy( | |||
| 578 | 578 | ||
| 579 | burst = convert_burst(8); | 579 | burst = convert_burst(8); |
| 580 | width = convert_buswidth(DMA_SLAVE_BUSWIDTH_4_BYTES); | 580 | width = convert_buswidth(DMA_SLAVE_BUSWIDTH_4_BYTES); |
| 581 | v_lli->cfg |= DMA_CHAN_CFG_SRC_DRQ(DRQ_SDRAM) | | 581 | v_lli->cfg = DMA_CHAN_CFG_SRC_DRQ(DRQ_SDRAM) | |
| 582 | DMA_CHAN_CFG_DST_DRQ(DRQ_SDRAM) | | 582 | DMA_CHAN_CFG_DST_DRQ(DRQ_SDRAM) | |
| 583 | DMA_CHAN_CFG_DST_LINEAR_MODE | | 583 | DMA_CHAN_CFG_DST_LINEAR_MODE | |
| 584 | DMA_CHAN_CFG_SRC_LINEAR_MODE | | 584 | DMA_CHAN_CFG_SRC_LINEAR_MODE | |
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index d011cb89d25e..ed37e5908b91 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig | |||
| @@ -22,10 +22,6 @@ menuconfig GPIOLIB | |||
| 22 | 22 | ||
| 23 | if GPIOLIB | 23 | if GPIOLIB |
| 24 | 24 | ||
| 25 | config GPIO_DEVRES | ||
| 26 | def_bool y | ||
| 27 | depends on HAS_IOMEM | ||
| 28 | |||
| 29 | config OF_GPIO | 25 | config OF_GPIO |
| 30 | def_bool y | 26 | def_bool y |
| 31 | depends on OF | 27 | depends on OF |
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile index ab28a2daeacc..d074c2299393 100644 --- a/drivers/gpio/Makefile +++ b/drivers/gpio/Makefile | |||
| @@ -2,7 +2,7 @@ | |||
| 2 | 2 | ||
| 3 | ccflags-$(CONFIG_DEBUG_GPIO) += -DDEBUG | 3 | ccflags-$(CONFIG_DEBUG_GPIO) += -DDEBUG |
| 4 | 4 | ||
| 5 | obj-$(CONFIG_GPIO_DEVRES) += devres.o | 5 | obj-$(CONFIG_GPIOLIB) += devres.o |
| 6 | obj-$(CONFIG_GPIOLIB) += gpiolib.o | 6 | obj-$(CONFIG_GPIOLIB) += gpiolib.o |
| 7 | obj-$(CONFIG_GPIOLIB) += gpiolib-legacy.o | 7 | obj-$(CONFIG_GPIOLIB) += gpiolib-legacy.o |
| 8 | obj-$(CONFIG_OF_GPIO) += gpiolib-of.o | 8 | obj-$(CONFIG_OF_GPIO) += gpiolib-of.o |
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index e422568e14ad..fe731f094257 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c | |||
| @@ -372,14 +372,15 @@ static void pca953x_gpio_set_multiple(struct gpio_chip *gc, | |||
| 372 | 372 | ||
| 373 | bank_shift = fls((chip->gpio_chip.ngpio - 1) / BANK_SZ); | 373 | bank_shift = fls((chip->gpio_chip.ngpio - 1) / BANK_SZ); |
| 374 | 374 | ||
| 375 | memcpy(reg_val, chip->reg_output, NBANK(chip)); | ||
| 376 | mutex_lock(&chip->i2c_lock); | 375 | mutex_lock(&chip->i2c_lock); |
| 376 | memcpy(reg_val, chip->reg_output, NBANK(chip)); | ||
| 377 | for (bank = 0; bank < NBANK(chip); bank++) { | 377 | for (bank = 0; bank < NBANK(chip); bank++) { |
| 378 | bank_mask = mask[bank / sizeof(*mask)] >> | 378 | bank_mask = mask[bank / sizeof(*mask)] >> |
| 379 | ((bank % sizeof(*mask)) * 8); | 379 | ((bank % sizeof(*mask)) * 8); |
| 380 | if (bank_mask) { | 380 | if (bank_mask) { |
| 381 | bank_val = bits[bank / sizeof(*bits)] >> | 381 | bank_val = bits[bank / sizeof(*bits)] >> |
| 382 | ((bank % sizeof(*bits)) * 8); | 382 | ((bank % sizeof(*bits)) * 8); |
| 383 | bank_val &= bank_mask; | ||
| 383 | reg_val[bank] = (reg_val[bank] & ~bank_mask) | bank_val; | 384 | reg_val[bank] = (reg_val[bank] & ~bank_mask) | bank_val; |
| 384 | } | 385 | } |
| 385 | } | 386 | } |
| @@ -607,7 +608,6 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, | |||
| 607 | 608 | ||
| 608 | if (client->irq && irq_base != -1 | 609 | if (client->irq && irq_base != -1 |
| 609 | && (chip->driver_data & PCA_INT)) { | 610 | && (chip->driver_data & PCA_INT)) { |
| 610 | |||
| 611 | ret = pca953x_read_regs(chip, | 611 | ret = pca953x_read_regs(chip, |
| 612 | chip->regs->input, chip->irq_stat); | 612 | chip->regs->input, chip->irq_stat); |
| 613 | if (ret) | 613 | if (ret) |
diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c index 5a5a6cb00eea..d6e21f1a70a9 100644 --- a/drivers/gpio/gpio-tc3589x.c +++ b/drivers/gpio/gpio-tc3589x.c | |||
| @@ -97,7 +97,7 @@ static int tc3589x_gpio_get_direction(struct gpio_chip *chip, | |||
| 97 | if (ret < 0) | 97 | if (ret < 0) |
| 98 | return ret; | 98 | return ret; |
| 99 | 99 | ||
| 100 | return !!(ret & BIT(pos)); | 100 | return !(ret & BIT(pos)); |
| 101 | } | 101 | } |
| 102 | 102 | ||
| 103 | static int tc3589x_gpio_set_single_ended(struct gpio_chip *chip, | 103 | static int tc3589x_gpio_set_single_ended(struct gpio_chip *chip, |
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 93ed0e00c578..868128a676ba 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c | |||
| @@ -2737,8 +2737,11 @@ int gpiochip_lock_as_irq(struct gpio_chip *chip, unsigned int offset) | |||
| 2737 | if (IS_ERR(desc)) | 2737 | if (IS_ERR(desc)) |
| 2738 | return PTR_ERR(desc); | 2738 | return PTR_ERR(desc); |
| 2739 | 2739 | ||
| 2740 | /* Flush direction if something changed behind our back */ | 2740 | /* |
| 2741 | if (chip->get_direction) { | 2741 | * If it's fast: flush the direction setting if something changed |
| 2742 | * behind our back | ||
| 2743 | */ | ||
| 2744 | if (!chip->can_sleep && chip->get_direction) { | ||
| 2742 | int dir = chip->get_direction(chip, offset); | 2745 | int dir = chip->get_direction(chip, offset); |
| 2743 | 2746 | ||
| 2744 | if (dir) | 2747 | if (dir) |
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index 039b57e4644c..496f72b134eb 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h | |||
| @@ -459,6 +459,7 @@ struct amdgpu_bo { | |||
| 459 | u64 metadata_flags; | 459 | u64 metadata_flags; |
| 460 | void *metadata; | 460 | void *metadata; |
| 461 | u32 metadata_size; | 461 | u32 metadata_size; |
| 462 | unsigned prime_shared_count; | ||
| 462 | /* list of all virtual address to which this bo | 463 | /* list of all virtual address to which this bo |
| 463 | * is associated to | 464 | * is associated to |
| 464 | */ | 465 | */ |
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c index 651115dcce12..c02db01f6583 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | |||
| @@ -132,7 +132,7 @@ static int amdgpu_bo_list_set(struct amdgpu_device *adev, | |||
| 132 | entry->priority = min(info[i].bo_priority, | 132 | entry->priority = min(info[i].bo_priority, |
| 133 | AMDGPU_BO_LIST_MAX_PRIORITY); | 133 | AMDGPU_BO_LIST_MAX_PRIORITY); |
| 134 | entry->tv.bo = &entry->robj->tbo; | 134 | entry->tv.bo = &entry->robj->tbo; |
| 135 | entry->tv.shared = true; | 135 | entry->tv.shared = !entry->robj->prime_shared_count; |
| 136 | 136 | ||
| 137 | if (entry->robj->prefered_domains == AMDGPU_GEM_DOMAIN_GDS) | 137 | if (entry->robj->prefered_domains == AMDGPU_GEM_DOMAIN_GDS) |
| 138 | gds_obj = entry->robj; | 138 | gds_obj = entry->robj; |
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 7ca07e7b25c1..3161d77bf299 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | |||
| @@ -658,12 +658,10 @@ static bool amdgpu_vpost_needed(struct amdgpu_device *adev) | |||
| 658 | return false; | 658 | return false; |
| 659 | 659 | ||
| 660 | if (amdgpu_passthrough(adev)) { | 660 | if (amdgpu_passthrough(adev)) { |
| 661 | /* for FIJI: In whole GPU pass-through virtualization case | 661 | /* for FIJI: In whole GPU pass-through virtualization case, after VM reboot |
| 662 | * old smc fw won't clear some registers (e.g. MEM_SIZE, BIOS_SCRATCH) | 662 | * some old smc fw still need driver do vPost otherwise gpu hang, while |
| 663 | * so amdgpu_card_posted return false and driver will incorrectly skip vPost. | 663 | * those smc fw version above 22.15 doesn't have this flaw, so we force |
| 664 | * but if we force vPost do in pass-through case, the driver reload will hang. | 664 | * vpost executed for smc version below 22.15 |
| 665 | * whether doing vPost depends on amdgpu_card_posted if smc version is above | ||
| 666 | * 00160e00 for FIJI. | ||
| 667 | */ | 665 | */ |
| 668 | if (adev->asic_type == CHIP_FIJI) { | 666 | if (adev->asic_type == CHIP_FIJI) { |
| 669 | int err; | 667 | int err; |
| @@ -674,22 +672,11 @@ static bool amdgpu_vpost_needed(struct amdgpu_device *adev) | |||
| 674 | return true; | 672 | return true; |
| 675 | 673 | ||
| 676 | fw_ver = *((uint32_t *)adev->pm.fw->data + 69); | 674 | fw_ver = *((uint32_t *)adev->pm.fw->data + 69); |
| 677 | if (fw_ver >= 0x00160e00) | 675 | if (fw_ver < 0x00160e00) |
| 678 | return !amdgpu_card_posted(adev); | 676 | return true; |
| 679 | } | 677 | } |
| 680 | } else { | ||
| 681 | /* in bare-metal case, amdgpu_card_posted return false | ||
| 682 | * after system reboot/boot, and return true if driver | ||
| 683 | * reloaded. | ||
| 684 | * we shouldn't do vPost after driver reload otherwise GPU | ||
| 685 | * could hang. | ||
| 686 | */ | ||
| 687 | if (amdgpu_card_posted(adev)) | ||
| 688 | return false; | ||
| 689 | } | 678 | } |
| 690 | 679 | return !amdgpu_card_posted(adev); | |
| 691 | /* we assume vPost is neede for all other cases */ | ||
| 692 | return true; | ||
| 693 | } | 680 | } |
| 694 | 681 | ||
| 695 | /** | 682 | /** |
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c index 7700dc22f243..3826d5aea0a6 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c | |||
| @@ -74,20 +74,36 @@ amdgpu_gem_prime_import_sg_table(struct drm_device *dev, | |||
| 74 | if (ret) | 74 | if (ret) |
| 75 | return ERR_PTR(ret); | 75 | return ERR_PTR(ret); |
| 76 | 76 | ||
| 77 | bo->prime_shared_count = 1; | ||
| 77 | return &bo->gem_base; | 78 | return &bo->gem_base; |
| 78 | } | 79 | } |
| 79 | 80 | ||
| 80 | int amdgpu_gem_prime_pin(struct drm_gem_object *obj) | 81 | int amdgpu_gem_prime_pin(struct drm_gem_object *obj) |
| 81 | { | 82 | { |
| 82 | struct amdgpu_bo *bo = gem_to_amdgpu_bo(obj); | 83 | struct amdgpu_bo *bo = gem_to_amdgpu_bo(obj); |
| 83 | int ret = 0; | 84 | long ret = 0; |
| 84 | 85 | ||
| 85 | ret = amdgpu_bo_reserve(bo, false); | 86 | ret = amdgpu_bo_reserve(bo, false); |
| 86 | if (unlikely(ret != 0)) | 87 | if (unlikely(ret != 0)) |
| 87 | return ret; | 88 | return ret; |
| 88 | 89 | ||
| 90 | /* | ||
| 91 | * Wait for all shared fences to complete before we switch to future | ||
| 92 | * use of exclusive fence on this prime shared bo. | ||
| 93 | */ | ||
| 94 | ret = reservation_object_wait_timeout_rcu(bo->tbo.resv, true, false, | ||
| 95 | MAX_SCHEDULE_TIMEOUT); | ||
| 96 | if (unlikely(ret < 0)) { | ||
| 97 | DRM_DEBUG_PRIME("Fence wait failed: %li\n", ret); | ||
| 98 | amdgpu_bo_unreserve(bo); | ||
| 99 | return ret; | ||
| 100 | } | ||
| 101 | |||
| 89 | /* pin buffer into GTT */ | 102 | /* pin buffer into GTT */ |
| 90 | ret = amdgpu_bo_pin(bo, AMDGPU_GEM_DOMAIN_GTT, NULL); | 103 | ret = amdgpu_bo_pin(bo, AMDGPU_GEM_DOMAIN_GTT, NULL); |
| 104 | if (likely(ret == 0)) | ||
| 105 | bo->prime_shared_count++; | ||
| 106 | |||
| 91 | amdgpu_bo_unreserve(bo); | 107 | amdgpu_bo_unreserve(bo); |
| 92 | return ret; | 108 | return ret; |
| 93 | } | 109 | } |
| @@ -102,6 +118,8 @@ void amdgpu_gem_prime_unpin(struct drm_gem_object *obj) | |||
| 102 | return; | 118 | return; |
| 103 | 119 | ||
| 104 | amdgpu_bo_unpin(bo); | 120 | amdgpu_bo_unpin(bo); |
| 121 | if (bo->prime_shared_count) | ||
| 122 | bo->prime_shared_count--; | ||
| 105 | amdgpu_bo_unreserve(bo); | 123 | amdgpu_bo_unreserve(bo); |
| 106 | } | 124 | } |
| 107 | 125 | ||
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c index b0c929dd8beb..13f2b705ea49 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | |||
| @@ -1469,8 +1469,6 @@ static int smu7_get_evv_voltages(struct pp_hwmgr *hwmgr) | |||
| 1469 | table_info->vddgfx_lookup_table, vv_id, &sclk)) { | 1469 | table_info->vddgfx_lookup_table, vv_id, &sclk)) { |
| 1470 | if (phm_cap_enabled(hwmgr->platform_descriptor.platformCaps, | 1470 | if (phm_cap_enabled(hwmgr->platform_descriptor.platformCaps, |
| 1471 | PHM_PlatformCaps_ClockStretcher)) { | 1471 | PHM_PlatformCaps_ClockStretcher)) { |
| 1472 | if (table_info == NULL) | ||
| 1473 | return -EINVAL; | ||
| 1474 | sclk_table = table_info->vdd_dep_on_sclk; | 1472 | sclk_table = table_info->vdd_dep_on_sclk; |
| 1475 | 1473 | ||
| 1476 | for (j = 1; j < sclk_table->count; j++) { | 1474 | for (j = 1; j < sclk_table->count; j++) { |
diff --git a/drivers/gpu/drm/arc/arcpgu_hdmi.c b/drivers/gpu/drm/arc/arcpgu_hdmi.c index b7a8b2ac4055..b69c66b4897e 100644 --- a/drivers/gpu/drm/arc/arcpgu_hdmi.c +++ b/drivers/gpu/drm/arc/arcpgu_hdmi.c | |||
| @@ -14,170 +14,45 @@ | |||
| 14 | * | 14 | * |
| 15 | */ | 15 | */ |
| 16 | 16 | ||
| 17 | #include <drm/drm_crtc_helper.h> | 17 | #include <drm/drm_crtc.h> |
| 18 | #include <drm/drm_encoder_slave.h> | 18 | #include <drm/drm_encoder_slave.h> |
| 19 | #include <drm/drm_atomic_helper.h> | ||
| 20 | 19 | ||
| 21 | #include "arcpgu.h" | 20 | #include "arcpgu.h" |
| 22 | 21 | ||
| 23 | struct arcpgu_drm_connector { | ||
| 24 | struct drm_connector connector; | ||
| 25 | struct drm_encoder_slave *encoder_slave; | ||
| 26 | }; | ||
| 27 | |||
| 28 | static int arcpgu_drm_connector_get_modes(struct drm_connector *connector) | ||
| 29 | { | ||
| 30 | const struct drm_encoder_slave_funcs *sfuncs; | ||
| 31 | struct drm_encoder_slave *slave; | ||
| 32 | struct arcpgu_drm_connector *con = | ||
| 33 | container_of(connector, struct arcpgu_drm_connector, connector); | ||
| 34 | |||
| 35 | slave = con->encoder_slave; | ||
| 36 | if (slave == NULL) { | ||
| 37 | dev_err(connector->dev->dev, | ||
| 38 | "connector_get_modes: cannot find slave encoder for connector\n"); | ||
| 39 | return 0; | ||
| 40 | } | ||
| 41 | |||
| 42 | sfuncs = slave->slave_funcs; | ||
| 43 | if (sfuncs->get_modes == NULL) | ||
| 44 | return 0; | ||
| 45 | |||
| 46 | return sfuncs->get_modes(&slave->base, connector); | ||
| 47 | } | ||
| 48 | |||
| 49 | static enum drm_connector_status | ||
| 50 | arcpgu_drm_connector_detect(struct drm_connector *connector, bool force) | ||
| 51 | { | ||
| 52 | enum drm_connector_status status = connector_status_unknown; | ||
| 53 | const struct drm_encoder_slave_funcs *sfuncs; | ||
| 54 | struct drm_encoder_slave *slave; | ||
| 55 | |||
| 56 | struct arcpgu_drm_connector *con = | ||
| 57 | container_of(connector, struct arcpgu_drm_connector, connector); | ||
| 58 | |||
| 59 | slave = con->encoder_slave; | ||
| 60 | if (slave == NULL) { | ||
| 61 | dev_err(connector->dev->dev, | ||
| 62 | "connector_detect: cannot find slave encoder for connector\n"); | ||
| 63 | return status; | ||
| 64 | } | ||
| 65 | |||
| 66 | sfuncs = slave->slave_funcs; | ||
| 67 | if (sfuncs && sfuncs->detect) | ||
| 68 | return sfuncs->detect(&slave->base, connector); | ||
| 69 | |||
| 70 | dev_err(connector->dev->dev, "connector_detect: could not detect slave funcs\n"); | ||
| 71 | return status; | ||
| 72 | } | ||
| 73 | |||
| 74 | static void arcpgu_drm_connector_destroy(struct drm_connector *connector) | ||
| 75 | { | ||
| 76 | drm_connector_unregister(connector); | ||
| 77 | drm_connector_cleanup(connector); | ||
| 78 | } | ||
| 79 | |||
| 80 | static const struct drm_connector_helper_funcs | ||
| 81 | arcpgu_drm_connector_helper_funcs = { | ||
| 82 | .get_modes = arcpgu_drm_connector_get_modes, | ||
| 83 | }; | ||
| 84 | |||
| 85 | static const struct drm_connector_funcs arcpgu_drm_connector_funcs = { | ||
| 86 | .dpms = drm_helper_connector_dpms, | ||
| 87 | .reset = drm_atomic_helper_connector_reset, | ||
| 88 | .detect = arcpgu_drm_connector_detect, | ||
| 89 | .fill_modes = drm_helper_probe_single_connector_modes, | ||
| 90 | .destroy = arcpgu_drm_connector_destroy, | ||
| 91 | .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, | ||
| 92 | .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, | ||
| 93 | }; | ||
| 94 | |||
| 95 | static struct drm_encoder_helper_funcs arcpgu_drm_encoder_helper_funcs = { | ||
| 96 | .dpms = drm_i2c_encoder_dpms, | ||
| 97 | .mode_fixup = drm_i2c_encoder_mode_fixup, | ||
| 98 | .mode_set = drm_i2c_encoder_mode_set, | ||
| 99 | .prepare = drm_i2c_encoder_prepare, | ||
| 100 | .commit = drm_i2c_encoder_commit, | ||
| 101 | .detect = drm_i2c_encoder_detect, | ||
| 102 | }; | ||
| 103 | |||
| 104 | static struct drm_encoder_funcs arcpgu_drm_encoder_funcs = { | 22 | static struct drm_encoder_funcs arcpgu_drm_encoder_funcs = { |
| 105 | .destroy = drm_encoder_cleanup, | 23 | .destroy = drm_encoder_cleanup, |
| 106 | }; | 24 | }; |
| 107 | 25 | ||
| 108 | int arcpgu_drm_hdmi_init(struct drm_device *drm, struct device_node *np) | 26 | int arcpgu_drm_hdmi_init(struct drm_device *drm, struct device_node *np) |
| 109 | { | 27 | { |
| 110 | struct arcpgu_drm_connector *arcpgu_connector; | 28 | struct drm_encoder *encoder; |
| 111 | struct drm_i2c_encoder_driver *driver; | 29 | struct drm_bridge *bridge; |
| 112 | struct drm_encoder_slave *encoder; | 30 | |
| 113 | struct drm_connector *connector; | 31 | int ret = 0; |
| 114 | struct i2c_client *i2c_slave; | ||
| 115 | int ret; | ||
| 116 | 32 | ||
| 117 | encoder = devm_kzalloc(drm->dev, sizeof(*encoder), GFP_KERNEL); | 33 | encoder = devm_kzalloc(drm->dev, sizeof(*encoder), GFP_KERNEL); |
| 118 | if (encoder == NULL) | 34 | if (encoder == NULL) |
| 119 | return -ENOMEM; | 35 | return -ENOMEM; |
| 120 | 36 | ||
| 121 | i2c_slave = of_find_i2c_device_by_node(np); | 37 | /* Locate drm bridge from the hdmi encoder DT node */ |
| 122 | if (!i2c_slave || !i2c_get_clientdata(i2c_slave)) { | 38 | bridge = of_drm_find_bridge(np); |
| 123 | dev_err(drm->dev, "failed to find i2c slave encoder\n"); | 39 | if (!bridge) |
| 124 | return -EPROBE_DEFER; | ||
| 125 | } | ||
| 126 | |||
| 127 | if (i2c_slave->dev.driver == NULL) { | ||
| 128 | dev_err(drm->dev, "failed to find i2c slave driver\n"); | ||
| 129 | return -EPROBE_DEFER; | 40 | return -EPROBE_DEFER; |
| 130 | } | ||
| 131 | 41 | ||
| 132 | driver = | 42 | encoder->possible_crtcs = 1; |
| 133 | to_drm_i2c_encoder_driver(to_i2c_driver(i2c_slave->dev.driver)); | 43 | encoder->possible_clones = 0; |
| 134 | ret = driver->encoder_init(i2c_slave, drm, encoder); | 44 | ret = drm_encoder_init(drm, encoder, &arcpgu_drm_encoder_funcs, |
| 135 | if (ret) { | ||
| 136 | dev_err(drm->dev, "failed to initialize i2c encoder slave\n"); | ||
| 137 | return ret; | ||
| 138 | } | ||
| 139 | |||
| 140 | encoder->base.possible_crtcs = 1; | ||
| 141 | encoder->base.possible_clones = 0; | ||
| 142 | ret = drm_encoder_init(drm, &encoder->base, &arcpgu_drm_encoder_funcs, | ||
| 143 | DRM_MODE_ENCODER_TMDS, NULL); | 45 | DRM_MODE_ENCODER_TMDS, NULL); |
| 144 | if (ret) | 46 | if (ret) |
| 145 | return ret; | 47 | return ret; |
| 146 | 48 | ||
| 147 | drm_encoder_helper_add(&encoder->base, | 49 | /* Link drm_bridge to encoder */ |
| 148 | &arcpgu_drm_encoder_helper_funcs); | 50 | bridge->encoder = encoder; |
| 149 | 51 | encoder->bridge = bridge; | |
| 150 | arcpgu_connector = devm_kzalloc(drm->dev, sizeof(*arcpgu_connector), | ||
| 151 | GFP_KERNEL); | ||
| 152 | if (!arcpgu_connector) { | ||
| 153 | ret = -ENOMEM; | ||
| 154 | goto error_encoder_cleanup; | ||
| 155 | } | ||
| 156 | |||
| 157 | connector = &arcpgu_connector->connector; | ||
| 158 | drm_connector_helper_add(connector, &arcpgu_drm_connector_helper_funcs); | ||
| 159 | ret = drm_connector_init(drm, connector, &arcpgu_drm_connector_funcs, | ||
| 160 | DRM_MODE_CONNECTOR_HDMIA); | ||
| 161 | if (ret < 0) { | ||
| 162 | dev_err(drm->dev, "failed to initialize drm connector\n"); | ||
| 163 | goto error_encoder_cleanup; | ||
| 164 | } | ||
| 165 | 52 | ||
| 166 | ret = drm_mode_connector_attach_encoder(connector, &encoder->base); | 53 | ret = drm_bridge_attach(drm, bridge); |
| 167 | if (ret < 0) { | 54 | if (ret) |
| 168 | dev_err(drm->dev, "could not attach connector to encoder\n"); | 55 | drm_encoder_cleanup(encoder); |
| 169 | drm_connector_unregister(connector); | ||
| 170 | goto error_connector_cleanup; | ||
| 171 | } | ||
| 172 | |||
| 173 | arcpgu_connector->encoder_slave = encoder; | ||
| 174 | |||
| 175 | return 0; | ||
| 176 | |||
| 177 | error_connector_cleanup: | ||
| 178 | drm_connector_cleanup(connector); | ||
| 179 | 56 | ||
| 180 | error_encoder_cleanup: | ||
| 181 | drm_encoder_cleanup(&encoder->base); | ||
| 182 | return ret; | 57 | return ret; |
| 183 | } | 58 | } |
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c index b2d5e188b1b8..deb57435cc89 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | |||
| @@ -25,8 +25,13 @@ | |||
| 25 | static void fsl_dcu_drm_crtc_atomic_flush(struct drm_crtc *crtc, | 25 | static void fsl_dcu_drm_crtc_atomic_flush(struct drm_crtc *crtc, |
| 26 | struct drm_crtc_state *old_crtc_state) | 26 | struct drm_crtc_state *old_crtc_state) |
| 27 | { | 27 | { |
| 28 | struct drm_device *dev = crtc->dev; | ||
| 29 | struct fsl_dcu_drm_device *fsl_dev = dev->dev_private; | ||
| 28 | struct drm_pending_vblank_event *event = crtc->state->event; | 30 | struct drm_pending_vblank_event *event = crtc->state->event; |
| 29 | 31 | ||
| 32 | regmap_write(fsl_dev->regmap, | ||
| 33 | DCU_UPDATE_MODE, DCU_UPDATE_MODE_READREG); | ||
| 34 | |||
| 30 | if (event) { | 35 | if (event) { |
| 31 | crtc->state->event = NULL; | 36 | crtc->state->event = NULL; |
| 32 | 37 | ||
| @@ -39,11 +44,15 @@ static void fsl_dcu_drm_crtc_atomic_flush(struct drm_crtc *crtc, | |||
| 39 | } | 44 | } |
| 40 | } | 45 | } |
| 41 | 46 | ||
| 42 | static void fsl_dcu_drm_disable_crtc(struct drm_crtc *crtc) | 47 | static void fsl_dcu_drm_crtc_atomic_disable(struct drm_crtc *crtc, |
| 48 | struct drm_crtc_state *old_crtc_state) | ||
| 43 | { | 49 | { |
| 44 | struct drm_device *dev = crtc->dev; | 50 | struct drm_device *dev = crtc->dev; |
| 45 | struct fsl_dcu_drm_device *fsl_dev = dev->dev_private; | 51 | struct fsl_dcu_drm_device *fsl_dev = dev->dev_private; |
| 46 | 52 | ||
| 53 | /* always disable planes on the CRTC */ | ||
| 54 | drm_atomic_helper_disable_planes_on_crtc(old_crtc_state, true); | ||
| 55 | |||
| 47 | drm_crtc_vblank_off(crtc); | 56 | drm_crtc_vblank_off(crtc); |
| 48 | 57 | ||
| 49 | regmap_update_bits(fsl_dev->regmap, DCU_DCU_MODE, | 58 | regmap_update_bits(fsl_dev->regmap, DCU_DCU_MODE, |
| @@ -122,8 +131,8 @@ static void fsl_dcu_drm_crtc_mode_set_nofb(struct drm_crtc *crtc) | |||
| 122 | } | 131 | } |
| 123 | 132 | ||
| 124 | static const struct drm_crtc_helper_funcs fsl_dcu_drm_crtc_helper_funcs = { | 133 | static const struct drm_crtc_helper_funcs fsl_dcu_drm_crtc_helper_funcs = { |
| 134 | .atomic_disable = fsl_dcu_drm_crtc_atomic_disable, | ||
| 125 | .atomic_flush = fsl_dcu_drm_crtc_atomic_flush, | 135 | .atomic_flush = fsl_dcu_drm_crtc_atomic_flush, |
| 126 | .disable = fsl_dcu_drm_disable_crtc, | ||
| 127 | .enable = fsl_dcu_drm_crtc_enable, | 136 | .enable = fsl_dcu_drm_crtc_enable, |
| 128 | .mode_set_nofb = fsl_dcu_drm_crtc_mode_set_nofb, | 137 | .mode_set_nofb = fsl_dcu_drm_crtc_mode_set_nofb, |
| 129 | }; | 138 | }; |
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c index e04efbed1a54..cc2fde2ae5ef 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | |||
| @@ -59,8 +59,6 @@ static int fsl_dcu_drm_irq_init(struct drm_device *dev) | |||
| 59 | 59 | ||
| 60 | regmap_write(fsl_dev->regmap, DCU_INT_STATUS, 0); | 60 | regmap_write(fsl_dev->regmap, DCU_INT_STATUS, 0); |
| 61 | regmap_write(fsl_dev->regmap, DCU_INT_MASK, ~0); | 61 | regmap_write(fsl_dev->regmap, DCU_INT_MASK, ~0); |
| 62 | regmap_write(fsl_dev->regmap, DCU_UPDATE_MODE, | ||
| 63 | DCU_UPDATE_MODE_READREG); | ||
| 64 | 62 | ||
| 65 | return ret; | 63 | return ret; |
| 66 | } | 64 | } |
| @@ -139,8 +137,6 @@ static irqreturn_t fsl_dcu_drm_irq(int irq, void *arg) | |||
| 139 | drm_handle_vblank(dev, 0); | 137 | drm_handle_vblank(dev, 0); |
| 140 | 138 | ||
| 141 | regmap_write(fsl_dev->regmap, DCU_INT_STATUS, int_status); | 139 | regmap_write(fsl_dev->regmap, DCU_INT_STATUS, int_status); |
| 142 | regmap_write(fsl_dev->regmap, DCU_UPDATE_MODE, | ||
| 143 | DCU_UPDATE_MODE_READREG); | ||
| 144 | 140 | ||
| 145 | return IRQ_HANDLED; | 141 | return IRQ_HANDLED; |
| 146 | } | 142 | } |
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c index 9e6f7d8112b3..a99f48847420 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c | |||
| @@ -160,11 +160,6 @@ static void fsl_dcu_drm_plane_atomic_update(struct drm_plane *plane, | |||
| 160 | DCU_LAYER_POST_SKIP(0) | | 160 | DCU_LAYER_POST_SKIP(0) | |
| 161 | DCU_LAYER_PRE_SKIP(0)); | 161 | DCU_LAYER_PRE_SKIP(0)); |
| 162 | } | 162 | } |
| 163 | regmap_update_bits(fsl_dev->regmap, DCU_DCU_MODE, | ||
| 164 | DCU_MODE_DCU_MODE_MASK, | ||
| 165 | DCU_MODE_DCU_MODE(DCU_MODE_NORMAL)); | ||
| 166 | regmap_write(fsl_dev->regmap, | ||
| 167 | DCU_UPDATE_MODE, DCU_UPDATE_MODE_READREG); | ||
| 168 | 163 | ||
| 169 | return; | 164 | return; |
| 170 | } | 165 | } |
diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c index 7adb4c77cc7f..a218c2e395e7 100644 --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c | |||
| @@ -1281,6 +1281,12 @@ i915_gem_validate_context(struct drm_device *dev, struct drm_file *file, | |||
| 1281 | return ctx; | 1281 | return ctx; |
| 1282 | } | 1282 | } |
| 1283 | 1283 | ||
| 1284 | static bool gpu_write_needs_clflush(struct drm_i915_gem_object *obj) | ||
| 1285 | { | ||
| 1286 | return !(obj->cache_level == I915_CACHE_NONE || | ||
| 1287 | obj->cache_level == I915_CACHE_WT); | ||
| 1288 | } | ||
| 1289 | |||
| 1284 | void i915_vma_move_to_active(struct i915_vma *vma, | 1290 | void i915_vma_move_to_active(struct i915_vma *vma, |
| 1285 | struct drm_i915_gem_request *req, | 1291 | struct drm_i915_gem_request *req, |
| 1286 | unsigned int flags) | 1292 | unsigned int flags) |
| @@ -1311,6 +1317,8 @@ void i915_vma_move_to_active(struct i915_vma *vma, | |||
| 1311 | 1317 | ||
| 1312 | /* update for the implicit flush after a batch */ | 1318 | /* update for the implicit flush after a batch */ |
| 1313 | obj->base.write_domain &= ~I915_GEM_GPU_DOMAINS; | 1319 | obj->base.write_domain &= ~I915_GEM_GPU_DOMAINS; |
| 1320 | if (!obj->cache_dirty && gpu_write_needs_clflush(obj)) | ||
| 1321 | obj->cache_dirty = true; | ||
| 1314 | } | 1322 | } |
| 1315 | 1323 | ||
| 1316 | if (flags & EXEC_OBJECT_NEEDS_FENCE) | 1324 | if (flags & EXEC_OBJECT_NEEDS_FENCE) |
diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c index 1f8af87c6294..cf2560708e03 100644 --- a/drivers/gpu/drm/i915/intel_bios.c +++ b/drivers/gpu/drm/i915/intel_bios.c | |||
| @@ -1143,7 +1143,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv, enum port port, | |||
| 1143 | if (!child) | 1143 | if (!child) |
| 1144 | return; | 1144 | return; |
| 1145 | 1145 | ||
| 1146 | aux_channel = child->raw[25]; | 1146 | aux_channel = child->common.aux_channel; |
| 1147 | ddc_pin = child->common.ddc_pin; | 1147 | ddc_pin = child->common.ddc_pin; |
| 1148 | 1148 | ||
| 1149 | is_dvi = child->common.device_type & DEVICE_TYPE_TMDS_DVI_SIGNALING; | 1149 | is_dvi = child->common.device_type & DEVICE_TYPE_TMDS_DVI_SIGNALING; |
| @@ -1673,7 +1673,8 @@ bool intel_bios_is_port_edp(struct drm_i915_private *dev_priv, enum port port) | |||
| 1673 | return false; | 1673 | return false; |
| 1674 | } | 1674 | } |
| 1675 | 1675 | ||
| 1676 | bool intel_bios_is_port_dp_dual_mode(struct drm_i915_private *dev_priv, enum port port) | 1676 | static bool child_dev_is_dp_dual_mode(const union child_device_config *p_child, |
| 1677 | enum port port) | ||
| 1677 | { | 1678 | { |
| 1678 | static const struct { | 1679 | static const struct { |
| 1679 | u16 dp, hdmi; | 1680 | u16 dp, hdmi; |
| @@ -1687,22 +1688,35 @@ bool intel_bios_is_port_dp_dual_mode(struct drm_i915_private *dev_priv, enum por | |||
| 1687 | [PORT_D] = { DVO_PORT_DPD, DVO_PORT_HDMID, }, | 1688 | [PORT_D] = { DVO_PORT_DPD, DVO_PORT_HDMID, }, |
| 1688 | [PORT_E] = { DVO_PORT_DPE, DVO_PORT_HDMIE, }, | 1689 | [PORT_E] = { DVO_PORT_DPE, DVO_PORT_HDMIE, }, |
| 1689 | }; | 1690 | }; |
| 1690 | int i; | ||
| 1691 | 1691 | ||
| 1692 | if (port == PORT_A || port >= ARRAY_SIZE(port_mapping)) | 1692 | if (port == PORT_A || port >= ARRAY_SIZE(port_mapping)) |
| 1693 | return false; | 1693 | return false; |
| 1694 | 1694 | ||
| 1695 | if (!dev_priv->vbt.child_dev_num) | 1695 | if ((p_child->common.device_type & DEVICE_TYPE_DP_DUAL_MODE_BITS) != |
| 1696 | (DEVICE_TYPE_DP_DUAL_MODE & DEVICE_TYPE_DP_DUAL_MODE_BITS)) | ||
| 1696 | return false; | 1697 | return false; |
| 1697 | 1698 | ||
| 1699 | if (p_child->common.dvo_port == port_mapping[port].dp) | ||
| 1700 | return true; | ||
| 1701 | |||
| 1702 | /* Only accept a HDMI dvo_port as DP++ if it has an AUX channel */ | ||
| 1703 | if (p_child->common.dvo_port == port_mapping[port].hdmi && | ||
| 1704 | p_child->common.aux_channel != 0) | ||
| 1705 | return true; | ||
| 1706 | |||
| 1707 | return false; | ||
| 1708 | } | ||
| 1709 | |||
| 1710 | bool intel_bios_is_port_dp_dual_mode(struct drm_i915_private *dev_priv, | ||
| 1711 | enum port port) | ||
| 1712 | { | ||
| 1713 | int i; | ||
| 1714 | |||
| 1698 | for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { | 1715 | for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { |
| 1699 | const union child_device_config *p_child = | 1716 | const union child_device_config *p_child = |
| 1700 | &dev_priv->vbt.child_dev[i]; | 1717 | &dev_priv->vbt.child_dev[i]; |
| 1701 | 1718 | ||
| 1702 | if ((p_child->common.dvo_port == port_mapping[port].dp || | 1719 | if (child_dev_is_dp_dual_mode(p_child, port)) |
| 1703 | p_child->common.dvo_port == port_mapping[port].hdmi) && | ||
| 1704 | (p_child->common.device_type & DEVICE_TYPE_DP_DUAL_MODE_BITS) == | ||
| 1705 | (DEVICE_TYPE_DP_DUAL_MODE & DEVICE_TYPE_DP_DUAL_MODE_BITS)) | ||
| 1706 | return true; | 1720 | return true; |
| 1707 | } | 1721 | } |
| 1708 | 1722 | ||
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 3581b5a7f716..bf344d08356a 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c | |||
| @@ -4463,21 +4463,11 @@ static enum drm_connector_status | |||
| 4463 | intel_dp_detect(struct drm_connector *connector, bool force) | 4463 | intel_dp_detect(struct drm_connector *connector, bool force) |
| 4464 | { | 4464 | { |
| 4465 | struct intel_dp *intel_dp = intel_attached_dp(connector); | 4465 | struct intel_dp *intel_dp = intel_attached_dp(connector); |
| 4466 | struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); | ||
| 4467 | struct intel_encoder *intel_encoder = &intel_dig_port->base; | ||
| 4468 | enum drm_connector_status status = connector->status; | 4466 | enum drm_connector_status status = connector->status; |
| 4469 | 4467 | ||
| 4470 | DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n", | 4468 | DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n", |
| 4471 | connector->base.id, connector->name); | 4469 | connector->base.id, connector->name); |
| 4472 | 4470 | ||
| 4473 | if (intel_dp->is_mst) { | ||
| 4474 | /* MST devices are disconnected from a monitor POV */ | ||
| 4475 | intel_dp_unset_edid(intel_dp); | ||
| 4476 | if (intel_encoder->type != INTEL_OUTPUT_EDP) | ||
| 4477 | intel_encoder->type = INTEL_OUTPUT_DP; | ||
| 4478 | return connector_status_disconnected; | ||
| 4479 | } | ||
| 4480 | |||
| 4481 | /* If full detect is not performed yet, do a full detect */ | 4471 | /* If full detect is not performed yet, do a full detect */ |
| 4482 | if (!intel_dp->detect_done) | 4472 | if (!intel_dp->detect_done) |
| 4483 | status = intel_dp_long_pulse(intel_dp->attached_connector); | 4473 | status = intel_dp_long_pulse(intel_dp->attached_connector); |
diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c index 73a521fdf1bd..dbed12c484c9 100644 --- a/drivers/gpu/drm/i915/intel_sprite.c +++ b/drivers/gpu/drm/i915/intel_sprite.c | |||
| @@ -358,7 +358,7 @@ vlv_update_plane(struct drm_plane *dplane, | |||
| 358 | int plane = intel_plane->plane; | 358 | int plane = intel_plane->plane; |
| 359 | u32 sprctl; | 359 | u32 sprctl; |
| 360 | u32 sprsurf_offset, linear_offset; | 360 | u32 sprsurf_offset, linear_offset; |
| 361 | unsigned int rotation = dplane->state->rotation; | 361 | unsigned int rotation = plane_state->base.rotation; |
| 362 | const struct drm_intel_sprite_colorkey *key = &plane_state->ckey; | 362 | const struct drm_intel_sprite_colorkey *key = &plane_state->ckey; |
| 363 | int crtc_x = plane_state->base.dst.x1; | 363 | int crtc_x = plane_state->base.dst.x1; |
| 364 | int crtc_y = plane_state->base.dst.y1; | 364 | int crtc_y = plane_state->base.dst.y1; |
diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h b/drivers/gpu/drm/i915/intel_vbt_defs.h index 68db9621f1f0..8886cab19f98 100644 --- a/drivers/gpu/drm/i915/intel_vbt_defs.h +++ b/drivers/gpu/drm/i915/intel_vbt_defs.h | |||
| @@ -280,7 +280,8 @@ struct common_child_dev_config { | |||
| 280 | u8 dp_support:1; | 280 | u8 dp_support:1; |
| 281 | u8 tmds_support:1; | 281 | u8 tmds_support:1; |
| 282 | u8 support_reserved:5; | 282 | u8 support_reserved:5; |
| 283 | u8 not_common3[12]; | 283 | u8 aux_channel; |
| 284 | u8 not_common3[11]; | ||
| 284 | u8 iboost_level; | 285 | u8 iboost_level; |
| 285 | } __packed; | 286 | } __packed; |
| 286 | 287 | ||
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index 019b7ca392d7..f75c5b5a536c 100644 --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c | |||
| @@ -80,6 +80,7 @@ static void mtk_ovl_enable_vblank(struct mtk_ddp_comp *comp, | |||
| 80 | ddp_comp); | 80 | ddp_comp); |
| 81 | 81 | ||
| 82 | priv->crtc = crtc; | 82 | priv->crtc = crtc; |
| 83 | writel(0x0, comp->regs + DISP_REG_OVL_INTSTA); | ||
| 83 | writel_relaxed(OVL_FME_CPL_INT, comp->regs + DISP_REG_OVL_INTEN); | 84 | writel_relaxed(OVL_FME_CPL_INT, comp->regs + DISP_REG_OVL_INTEN); |
| 84 | } | 85 | } |
| 85 | 86 | ||
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index 0186e500d2a5..90fb831ef031 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c | |||
| @@ -432,11 +432,16 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi, | |||
| 432 | unsigned long pll_rate; | 432 | unsigned long pll_rate; |
| 433 | unsigned int factor; | 433 | unsigned int factor; |
| 434 | 434 | ||
| 435 | /* let pll_rate can fix the valid range of tvdpll (1G~2GHz) */ | ||
| 435 | pix_rate = 1000UL * mode->clock; | 436 | pix_rate = 1000UL * mode->clock; |
| 436 | if (mode->clock <= 74000) | 437 | if (mode->clock <= 27000) |
| 438 | factor = 16 * 3; | ||
| 439 | else if (mode->clock <= 84000) | ||
| 437 | factor = 8 * 3; | 440 | factor = 8 * 3; |
| 438 | else | 441 | else if (mode->clock <= 167000) |
| 439 | factor = 4 * 3; | 442 | factor = 4 * 3; |
| 443 | else | ||
| 444 | factor = 2 * 3; | ||
| 440 | pll_rate = pix_rate * factor; | 445 | pll_rate = pix_rate * factor; |
| 441 | 446 | ||
| 442 | dev_dbg(dpi->dev, "Want PLL %lu Hz, pixel clock %lu Hz\n", | 447 | dev_dbg(dpi->dev, "Want PLL %lu Hz, pixel clock %lu Hz\n", |
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index 71227deef21b..0e8c4d9af340 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c | |||
| @@ -1133,12 +1133,6 @@ static int mtk_hdmi_output_set_display_mode(struct mtk_hdmi *hdmi, | |||
| 1133 | phy_power_on(hdmi->phy); | 1133 | phy_power_on(hdmi->phy); |
| 1134 | mtk_hdmi_aud_output_config(hdmi, mode); | 1134 | mtk_hdmi_aud_output_config(hdmi, mode); |
| 1135 | 1135 | ||
| 1136 | mtk_hdmi_setup_audio_infoframe(hdmi); | ||
| 1137 | mtk_hdmi_setup_avi_infoframe(hdmi, mode); | ||
| 1138 | mtk_hdmi_setup_spd_infoframe(hdmi, "mediatek", "On-chip HDMI"); | ||
| 1139 | if (mode->flags & DRM_MODE_FLAG_3D_MASK) | ||
| 1140 | mtk_hdmi_setup_vendor_specific_infoframe(hdmi, mode); | ||
| 1141 | |||
| 1142 | mtk_hdmi_hw_vid_black(hdmi, false); | 1136 | mtk_hdmi_hw_vid_black(hdmi, false); |
| 1143 | mtk_hdmi_hw_aud_unmute(hdmi); | 1137 | mtk_hdmi_hw_aud_unmute(hdmi); |
| 1144 | mtk_hdmi_hw_send_av_unmute(hdmi); | 1138 | mtk_hdmi_hw_send_av_unmute(hdmi); |
| @@ -1401,6 +1395,16 @@ static void mtk_hdmi_bridge_pre_enable(struct drm_bridge *bridge) | |||
| 1401 | hdmi->powered = true; | 1395 | hdmi->powered = true; |
| 1402 | } | 1396 | } |
| 1403 | 1397 | ||
| 1398 | static void mtk_hdmi_send_infoframe(struct mtk_hdmi *hdmi, | ||
| 1399 | struct drm_display_mode *mode) | ||
| 1400 | { | ||
| 1401 | mtk_hdmi_setup_audio_infoframe(hdmi); | ||
| 1402 | mtk_hdmi_setup_avi_infoframe(hdmi, mode); | ||
| 1403 | mtk_hdmi_setup_spd_infoframe(hdmi, "mediatek", "On-chip HDMI"); | ||
| 1404 | if (mode->flags & DRM_MODE_FLAG_3D_MASK) | ||
| 1405 | mtk_hdmi_setup_vendor_specific_infoframe(hdmi, mode); | ||
| 1406 | } | ||
| 1407 | |||
| 1404 | static void mtk_hdmi_bridge_enable(struct drm_bridge *bridge) | 1408 | static void mtk_hdmi_bridge_enable(struct drm_bridge *bridge) |
| 1405 | { | 1409 | { |
| 1406 | struct mtk_hdmi *hdmi = hdmi_ctx_from_bridge(bridge); | 1410 | struct mtk_hdmi *hdmi = hdmi_ctx_from_bridge(bridge); |
| @@ -1409,6 +1413,7 @@ static void mtk_hdmi_bridge_enable(struct drm_bridge *bridge) | |||
| 1409 | clk_prepare_enable(hdmi->clk[MTK_HDMI_CLK_HDMI_PLL]); | 1413 | clk_prepare_enable(hdmi->clk[MTK_HDMI_CLK_HDMI_PLL]); |
| 1410 | clk_prepare_enable(hdmi->clk[MTK_HDMI_CLK_HDMI_PIXEL]); | 1414 | clk_prepare_enable(hdmi->clk[MTK_HDMI_CLK_HDMI_PIXEL]); |
| 1411 | phy_power_on(hdmi->phy); | 1415 | phy_power_on(hdmi->phy); |
| 1416 | mtk_hdmi_send_infoframe(hdmi, &hdmi->mode); | ||
| 1412 | 1417 | ||
| 1413 | hdmi->enabled = true; | 1418 | hdmi->enabled = true; |
| 1414 | } | 1419 | } |
diff --git a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c b/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c index 8a24754b440f..51cb9cfb6646 100644 --- a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c +++ b/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c | |||
| @@ -265,6 +265,9 @@ static int mtk_hdmi_pll_set_rate(struct clk_hw *hw, unsigned long rate, | |||
| 265 | struct mtk_hdmi_phy *hdmi_phy = to_mtk_hdmi_phy(hw); | 265 | struct mtk_hdmi_phy *hdmi_phy = to_mtk_hdmi_phy(hw); |
| 266 | unsigned int pre_div; | 266 | unsigned int pre_div; |
| 267 | unsigned int div; | 267 | unsigned int div; |
| 268 | unsigned int pre_ibias; | ||
| 269 | unsigned int hdmi_ibias; | ||
| 270 | unsigned int imp_en; | ||
| 268 | 271 | ||
| 269 | dev_dbg(hdmi_phy->dev, "%s: %lu Hz, parent: %lu Hz\n", __func__, | 272 | dev_dbg(hdmi_phy->dev, "%s: %lu Hz, parent: %lu Hz\n", __func__, |
| 270 | rate, parent_rate); | 273 | rate, parent_rate); |
| @@ -298,18 +301,31 @@ static int mtk_hdmi_pll_set_rate(struct clk_hw *hw, unsigned long rate, | |||
| 298 | (0x1 << PLL_BR_SHIFT), | 301 | (0x1 << PLL_BR_SHIFT), |
| 299 | RG_HDMITX_PLL_BP | RG_HDMITX_PLL_BC | | 302 | RG_HDMITX_PLL_BP | RG_HDMITX_PLL_BC | |
| 300 | RG_HDMITX_PLL_BR); | 303 | RG_HDMITX_PLL_BR); |
| 301 | mtk_hdmi_phy_clear_bits(hdmi_phy, HDMI_CON3, RG_HDMITX_PRD_IMP_EN); | 304 | if (rate < 165000000) { |
| 305 | mtk_hdmi_phy_clear_bits(hdmi_phy, HDMI_CON3, | ||
| 306 | RG_HDMITX_PRD_IMP_EN); | ||
| 307 | pre_ibias = 0x3; | ||
| 308 | imp_en = 0x0; | ||
| 309 | hdmi_ibias = hdmi_phy->ibias; | ||
| 310 | } else { | ||
| 311 | mtk_hdmi_phy_set_bits(hdmi_phy, HDMI_CON3, | ||
| 312 | RG_HDMITX_PRD_IMP_EN); | ||
| 313 | pre_ibias = 0x6; | ||
| 314 | imp_en = 0xf; | ||
| 315 | hdmi_ibias = hdmi_phy->ibias_up; | ||
| 316 | } | ||
| 302 | mtk_hdmi_phy_mask(hdmi_phy, HDMI_CON4, | 317 | mtk_hdmi_phy_mask(hdmi_phy, HDMI_CON4, |
| 303 | (0x3 << PRD_IBIAS_CLK_SHIFT) | | 318 | (pre_ibias << PRD_IBIAS_CLK_SHIFT) | |
| 304 | (0x3 << PRD_IBIAS_D2_SHIFT) | | 319 | (pre_ibias << PRD_IBIAS_D2_SHIFT) | |
| 305 | (0x3 << PRD_IBIAS_D1_SHIFT) | | 320 | (pre_ibias << PRD_IBIAS_D1_SHIFT) | |
| 306 | (0x3 << PRD_IBIAS_D0_SHIFT), | 321 | (pre_ibias << PRD_IBIAS_D0_SHIFT), |
| 307 | RG_HDMITX_PRD_IBIAS_CLK | | 322 | RG_HDMITX_PRD_IBIAS_CLK | |
| 308 | RG_HDMITX_PRD_IBIAS_D2 | | 323 | RG_HDMITX_PRD_IBIAS_D2 | |
| 309 | RG_HDMITX_PRD_IBIAS_D1 | | 324 | RG_HDMITX_PRD_IBIAS_D1 | |
| 310 | RG_HDMITX_PRD_IBIAS_D0); | 325 | RG_HDMITX_PRD_IBIAS_D0); |
| 311 | mtk_hdmi_phy_mask(hdmi_phy, HDMI_CON3, | 326 | mtk_hdmi_phy_mask(hdmi_phy, HDMI_CON3, |
| 312 | (0x0 << DRV_IMP_EN_SHIFT), RG_HDMITX_DRV_IMP_EN); | 327 | (imp_en << DRV_IMP_EN_SHIFT), |
| 328 | RG_HDMITX_DRV_IMP_EN); | ||
| 313 | mtk_hdmi_phy_mask(hdmi_phy, HDMI_CON6, | 329 | mtk_hdmi_phy_mask(hdmi_phy, HDMI_CON6, |
| 314 | (hdmi_phy->drv_imp_clk << DRV_IMP_CLK_SHIFT) | | 330 | (hdmi_phy->drv_imp_clk << DRV_IMP_CLK_SHIFT) | |
| 315 | (hdmi_phy->drv_imp_d2 << DRV_IMP_D2_SHIFT) | | 331 | (hdmi_phy->drv_imp_d2 << DRV_IMP_D2_SHIFT) | |
| @@ -318,12 +334,14 @@ static int mtk_hdmi_pll_set_rate(struct clk_hw *hw, unsigned long rate, | |||
| 318 | RG_HDMITX_DRV_IMP_CLK | RG_HDMITX_DRV_IMP_D2 | | 334 | RG_HDMITX_DRV_IMP_CLK | RG_HDMITX_DRV_IMP_D2 | |
| 319 | RG_HDMITX_DRV_IMP_D1 | RG_HDMITX_DRV_IMP_D0); | 335 | RG_HDMITX_DRV_IMP_D1 | RG_HDMITX_DRV_IMP_D0); |
| 320 | mtk_hdmi_phy_mask(hdmi_phy, HDMI_CON5, | 336 | mtk_hdmi_phy_mask(hdmi_phy, HDMI_CON5, |
| 321 | (hdmi_phy->ibias << DRV_IBIAS_CLK_SHIFT) | | 337 | (hdmi_ibias << DRV_IBIAS_CLK_SHIFT) | |
| 322 | (hdmi_phy->ibias << DRV_IBIAS_D2_SHIFT) | | 338 | (hdmi_ibias << DRV_IBIAS_D2_SHIFT) | |
| 323 | (hdmi_phy->ibias << DRV_IBIAS_D1_SHIFT) | | 339 | (hdmi_ibias << DRV_IBIAS_D1_SHIFT) | |
| 324 | (hdmi_phy->ibias << DRV_IBIAS_D0_SHIFT), | 340 | (hdmi_ibias << DRV_IBIAS_D0_SHIFT), |
| 325 | RG_HDMITX_DRV_IBIAS_CLK | RG_HDMITX_DRV_IBIAS_D2 | | 341 | RG_HDMITX_DRV_IBIAS_CLK | |
| 326 | RG_HDMITX_DRV_IBIAS_D1 | RG_HDMITX_DRV_IBIAS_D0); | 342 | RG_HDMITX_DRV_IBIAS_D2 | |
| 343 | RG_HDMITX_DRV_IBIAS_D1 | | ||
| 344 | RG_HDMITX_DRV_IBIAS_D0); | ||
| 327 | return 0; | 345 | return 0; |
| 328 | } | 346 | } |
| 329 | 347 | ||
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c index 0da9862ad8ed..70e9fd59c5a2 100644 --- a/drivers/gpu/drm/sun4i/sun4i_drv.c +++ b/drivers/gpu/drm/sun4i/sun4i_drv.c | |||
| @@ -142,9 +142,9 @@ static int sun4i_drv_bind(struct device *dev) | |||
| 142 | 142 | ||
| 143 | /* Create our layers */ | 143 | /* Create our layers */ |
| 144 | drv->layers = sun4i_layers_init(drm); | 144 | drv->layers = sun4i_layers_init(drm); |
| 145 | if (!drv->layers) { | 145 | if (IS_ERR(drv->layers)) { |
| 146 | dev_err(drm->dev, "Couldn't create the planes\n"); | 146 | dev_err(drm->dev, "Couldn't create the planes\n"); |
| 147 | ret = -EINVAL; | 147 | ret = PTR_ERR(drv->layers); |
| 148 | goto free_drm; | 148 | goto free_drm; |
| 149 | } | 149 | } |
| 150 | 150 | ||
diff --git a/drivers/gpu/drm/sun4i/sun4i_rgb.c b/drivers/gpu/drm/sun4i/sun4i_rgb.c index c3ff10f559cc..d198ad7e5323 100644 --- a/drivers/gpu/drm/sun4i/sun4i_rgb.c +++ b/drivers/gpu/drm/sun4i/sun4i_rgb.c | |||
| @@ -152,15 +152,13 @@ static void sun4i_rgb_encoder_enable(struct drm_encoder *encoder) | |||
| 152 | 152 | ||
| 153 | DRM_DEBUG_DRIVER("Enabling RGB output\n"); | 153 | DRM_DEBUG_DRIVER("Enabling RGB output\n"); |
| 154 | 154 | ||
| 155 | if (!IS_ERR(tcon->panel)) { | 155 | if (!IS_ERR(tcon->panel)) |
| 156 | drm_panel_prepare(tcon->panel); | 156 | drm_panel_prepare(tcon->panel); |
| 157 | drm_panel_enable(tcon->panel); | ||
| 158 | } | ||
| 159 | |||
| 160 | /* encoder->bridge can be NULL; drm_bridge_enable checks for it */ | ||
| 161 | drm_bridge_enable(encoder->bridge); | ||
| 162 | 157 | ||
| 163 | sun4i_tcon_channel_enable(tcon, 0); | 158 | sun4i_tcon_channel_enable(tcon, 0); |
| 159 | |||
| 160 | if (!IS_ERR(tcon->panel)) | ||
| 161 | drm_panel_enable(tcon->panel); | ||
| 164 | } | 162 | } |
| 165 | 163 | ||
| 166 | static void sun4i_rgb_encoder_disable(struct drm_encoder *encoder) | 164 | static void sun4i_rgb_encoder_disable(struct drm_encoder *encoder) |
| @@ -171,15 +169,13 @@ static void sun4i_rgb_encoder_disable(struct drm_encoder *encoder) | |||
| 171 | 169 | ||
| 172 | DRM_DEBUG_DRIVER("Disabling RGB output\n"); | 170 | DRM_DEBUG_DRIVER("Disabling RGB output\n"); |
| 173 | 171 | ||
| 174 | sun4i_tcon_channel_disable(tcon, 0); | 172 | if (!IS_ERR(tcon->panel)) |
| 173 | drm_panel_disable(tcon->panel); | ||
| 175 | 174 | ||
| 176 | /* encoder->bridge can be NULL; drm_bridge_disable checks for it */ | 175 | sun4i_tcon_channel_disable(tcon, 0); |
| 177 | drm_bridge_disable(encoder->bridge); | ||
| 178 | 176 | ||
| 179 | if (!IS_ERR(tcon->panel)) { | 177 | if (!IS_ERR(tcon->panel)) |
| 180 | drm_panel_disable(tcon->panel); | ||
| 181 | drm_panel_unprepare(tcon->panel); | 178 | drm_panel_unprepare(tcon->panel); |
| 182 | } | ||
| 183 | } | 179 | } |
| 184 | 180 | ||
| 185 | static void sun4i_rgb_encoder_mode_set(struct drm_encoder *encoder, | 181 | static void sun4i_rgb_encoder_mode_set(struct drm_encoder *encoder, |
diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c index b136d3acc5bd..0f58f46dbad7 100644 --- a/drivers/infiniband/core/addr.c +++ b/drivers/infiniband/core/addr.c | |||
| @@ -699,13 +699,16 @@ EXPORT_SYMBOL(rdma_addr_cancel); | |||
| 699 | struct resolve_cb_context { | 699 | struct resolve_cb_context { |
| 700 | struct rdma_dev_addr *addr; | 700 | struct rdma_dev_addr *addr; |
| 701 | struct completion comp; | 701 | struct completion comp; |
| 702 | int status; | ||
| 702 | }; | 703 | }; |
| 703 | 704 | ||
| 704 | static void resolve_cb(int status, struct sockaddr *src_addr, | 705 | static void resolve_cb(int status, struct sockaddr *src_addr, |
| 705 | struct rdma_dev_addr *addr, void *context) | 706 | struct rdma_dev_addr *addr, void *context) |
| 706 | { | 707 | { |
| 707 | memcpy(((struct resolve_cb_context *)context)->addr, addr, sizeof(struct | 708 | if (!status) |
| 708 | rdma_dev_addr)); | 709 | memcpy(((struct resolve_cb_context *)context)->addr, |
| 710 | addr, sizeof(struct rdma_dev_addr)); | ||
| 711 | ((struct resolve_cb_context *)context)->status = status; | ||
| 709 | complete(&((struct resolve_cb_context *)context)->comp); | 712 | complete(&((struct resolve_cb_context *)context)->comp); |
| 710 | } | 713 | } |
| 711 | 714 | ||
| @@ -743,6 +746,10 @@ int rdma_addr_find_l2_eth_by_grh(const union ib_gid *sgid, | |||
| 743 | 746 | ||
| 744 | wait_for_completion(&ctx.comp); | 747 | wait_for_completion(&ctx.comp); |
| 745 | 748 | ||
| 749 | ret = ctx.status; | ||
| 750 | if (ret) | ||
| 751 | return ret; | ||
| 752 | |||
| 746 | memcpy(dmac, dev_addr.dst_dev_addr, ETH_ALEN); | 753 | memcpy(dmac, dev_addr.dst_dev_addr, ETH_ALEN); |
| 747 | dev = dev_get_by_index(&init_net, dev_addr.bound_dev_if); | 754 | dev = dev_get_by_index(&init_net, dev_addr.bound_dev_if); |
| 748 | if (!dev) | 755 | if (!dev) |
diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c index c99525512b34..71c7c4c328ef 100644 --- a/drivers/infiniband/core/cm.c +++ b/drivers/infiniband/core/cm.c | |||
| @@ -80,6 +80,8 @@ static struct ib_cm { | |||
| 80 | __be32 random_id_operand; | 80 | __be32 random_id_operand; |
| 81 | struct list_head timewait_list; | 81 | struct list_head timewait_list; |
| 82 | struct workqueue_struct *wq; | 82 | struct workqueue_struct *wq; |
| 83 | /* Sync on cm change port state */ | ||
| 84 | spinlock_t state_lock; | ||
| 83 | } cm; | 85 | } cm; |
| 84 | 86 | ||
| 85 | /* Counter indexes ordered by attribute ID */ | 87 | /* Counter indexes ordered by attribute ID */ |
| @@ -161,6 +163,8 @@ struct cm_port { | |||
| 161 | struct ib_mad_agent *mad_agent; | 163 | struct ib_mad_agent *mad_agent; |
| 162 | struct kobject port_obj; | 164 | struct kobject port_obj; |
| 163 | u8 port_num; | 165 | u8 port_num; |
| 166 | struct list_head cm_priv_prim_list; | ||
| 167 | struct list_head cm_priv_altr_list; | ||
| 164 | struct cm_counter_group counter_group[CM_COUNTER_GROUPS]; | 168 | struct cm_counter_group counter_group[CM_COUNTER_GROUPS]; |
| 165 | }; | 169 | }; |
| 166 | 170 | ||
| @@ -241,6 +245,12 @@ struct cm_id_private { | |||
| 241 | u8 service_timeout; | 245 | u8 service_timeout; |
| 242 | u8 target_ack_delay; | 246 | u8 target_ack_delay; |
| 243 | 247 | ||
| 248 | struct list_head prim_list; | ||
| 249 | struct list_head altr_list; | ||
| 250 | /* Indicates that the send port mad is registered and av is set */ | ||
| 251 | int prim_send_port_not_ready; | ||
| 252 | int altr_send_port_not_ready; | ||
| 253 | |||
| 244 | struct list_head work_list; | 254 | struct list_head work_list; |
| 245 | atomic_t work_count; | 255 | atomic_t work_count; |
| 246 | }; | 256 | }; |
| @@ -259,20 +269,47 @@ static int cm_alloc_msg(struct cm_id_private *cm_id_priv, | |||
| 259 | struct ib_mad_agent *mad_agent; | 269 | struct ib_mad_agent *mad_agent; |
| 260 | struct ib_mad_send_buf *m; | 270 | struct ib_mad_send_buf *m; |
| 261 | struct ib_ah *ah; | 271 | struct ib_ah *ah; |
| 272 | struct cm_av *av; | ||
| 273 | unsigned long flags, flags2; | ||
| 274 | int ret = 0; | ||
| 262 | 275 | ||
| 276 | /* don't let the port to be released till the agent is down */ | ||
| 277 | spin_lock_irqsave(&cm.state_lock, flags2); | ||
| 278 | spin_lock_irqsave(&cm.lock, flags); | ||
| 279 | if (!cm_id_priv->prim_send_port_not_ready) | ||
| 280 | av = &cm_id_priv->av; | ||
| 281 | else if (!cm_id_priv->altr_send_port_not_ready && | ||
| 282 | (cm_id_priv->alt_av.port)) | ||
| 283 | av = &cm_id_priv->alt_av; | ||
| 284 | else { | ||
| 285 | pr_info("%s: not valid CM id\n", __func__); | ||
| 286 | ret = -ENODEV; | ||
| 287 | spin_unlock_irqrestore(&cm.lock, flags); | ||
| 288 | goto out; | ||
| 289 | } | ||
| 290 | spin_unlock_irqrestore(&cm.lock, flags); | ||
| 291 | /* Make sure the port haven't released the mad yet */ | ||
| 263 | mad_agent = cm_id_priv->av.port->mad_agent; | 292 | mad_agent = cm_id_priv->av.port->mad_agent; |
| 264 | ah = ib_create_ah(mad_agent->qp->pd, &cm_id_priv->av.ah_attr); | 293 | if (!mad_agent) { |
| 265 | if (IS_ERR(ah)) | 294 | pr_info("%s: not a valid MAD agent\n", __func__); |
| 266 | return PTR_ERR(ah); | 295 | ret = -ENODEV; |
| 296 | goto out; | ||
| 297 | } | ||
| 298 | ah = ib_create_ah(mad_agent->qp->pd, &av->ah_attr); | ||
| 299 | if (IS_ERR(ah)) { | ||
| 300 | ret = PTR_ERR(ah); | ||
| 301 | goto out; | ||
| 302 | } | ||
| 267 | 303 | ||
| 268 | m = ib_create_send_mad(mad_agent, cm_id_priv->id.remote_cm_qpn, | 304 | m = ib_create_send_mad(mad_agent, cm_id_priv->id.remote_cm_qpn, |
| 269 | cm_id_priv->av.pkey_index, | 305 | av->pkey_index, |
| 270 | 0, IB_MGMT_MAD_HDR, IB_MGMT_MAD_DATA, | 306 | 0, IB_MGMT_MAD_HDR, IB_MGMT_MAD_DATA, |
| 271 | GFP_ATOMIC, | 307 | GFP_ATOMIC, |
| 272 | IB_MGMT_BASE_VERSION); | 308 | IB_MGMT_BASE_VERSION); |
| 273 | if (IS_ERR(m)) { | 309 | if (IS_ERR(m)) { |
| 274 | ib_destroy_ah(ah); | 310 | ib_destroy_ah(ah); |
| 275 | return PTR_ERR(m); | 311 | ret = PTR_ERR(m); |
| 312 | goto out; | ||
| 276 | } | 313 | } |
| 277 | 314 | ||
| 278 | /* Timeout set by caller if response is expected. */ | 315 | /* Timeout set by caller if response is expected. */ |
| @@ -282,7 +319,10 @@ static int cm_alloc_msg(struct cm_id_private *cm_id_priv, | |||
| 282 | atomic_inc(&cm_id_priv->refcount); | 319 | atomic_inc(&cm_id_priv->refcount); |
| 283 | m->context[0] = cm_id_priv; | 320 | m->context[0] = cm_id_priv; |
| 284 | *msg = m; | 321 | *msg = m; |
| 285 | return 0; | 322 | |
| 323 | out: | ||
| 324 | spin_unlock_irqrestore(&cm.state_lock, flags2); | ||
| 325 | return ret; | ||
| 286 | } | 326 | } |
| 287 | 327 | ||
| 288 | static int cm_alloc_response_msg(struct cm_port *port, | 328 | static int cm_alloc_response_msg(struct cm_port *port, |
| @@ -352,7 +392,8 @@ static void cm_init_av_for_response(struct cm_port *port, struct ib_wc *wc, | |||
| 352 | grh, &av->ah_attr); | 392 | grh, &av->ah_attr); |
| 353 | } | 393 | } |
| 354 | 394 | ||
| 355 | static int cm_init_av_by_path(struct ib_sa_path_rec *path, struct cm_av *av) | 395 | static int cm_init_av_by_path(struct ib_sa_path_rec *path, struct cm_av *av, |
| 396 | struct cm_id_private *cm_id_priv) | ||
| 356 | { | 397 | { |
| 357 | struct cm_device *cm_dev; | 398 | struct cm_device *cm_dev; |
| 358 | struct cm_port *port = NULL; | 399 | struct cm_port *port = NULL; |
| @@ -387,7 +428,17 @@ static int cm_init_av_by_path(struct ib_sa_path_rec *path, struct cm_av *av) | |||
| 387 | &av->ah_attr); | 428 | &av->ah_attr); |
| 388 | av->timeout = path->packet_life_time + 1; | 429 | av->timeout = path->packet_life_time + 1; |
| 389 | 430 | ||
| 390 | return 0; | 431 | spin_lock_irqsave(&cm.lock, flags); |
| 432 | if (&cm_id_priv->av == av) | ||
| 433 | list_add_tail(&cm_id_priv->prim_list, &port->cm_priv_prim_list); | ||
| 434 | else if (&cm_id_priv->alt_av == av) | ||
| 435 | list_add_tail(&cm_id_priv->altr_list, &port->cm_priv_altr_list); | ||
| 436 | else | ||
| 437 | ret = -EINVAL; | ||
| 438 | |||
| 439 | spin_unlock_irqrestore(&cm.lock, flags); | ||
| 440 | |||
| 441 | return ret; | ||
| 391 | } | 442 | } |
| 392 | 443 | ||
| 393 | static int cm_alloc_id(struct cm_id_private *cm_id_priv) | 444 | static int cm_alloc_id(struct cm_id_private *cm_id_priv) |
| @@ -677,6 +728,8 @@ struct ib_cm_id *ib_create_cm_id(struct ib_device *device, | |||
| 677 | spin_lock_init(&cm_id_priv->lock); | 728 | spin_lock_init(&cm_id_priv->lock); |
| 678 | init_completion(&cm_id_priv->comp); | 729 | init_completion(&cm_id_priv->comp); |
| 679 | INIT_LIST_HEAD(&cm_id_priv->work_list); | 730 | INIT_LIST_HEAD(&cm_id_priv->work_list); |
| 731 | INIT_LIST_HEAD(&cm_id_priv->prim_list); | ||
| 732 | INIT_LIST_HEAD(&cm_id_priv->altr_list); | ||
| 680 | atomic_set(&cm_id_priv->work_count, -1); | 733 | atomic_set(&cm_id_priv->work_count, -1); |
| 681 | atomic_set(&cm_id_priv->refcount, 1); | 734 | atomic_set(&cm_id_priv->refcount, 1); |
| 682 | return &cm_id_priv->id; | 735 | return &cm_id_priv->id; |
| @@ -892,6 +945,15 @@ retest: | |||
| 892 | break; | 945 | break; |
| 893 | } | 946 | } |
| 894 | 947 | ||
| 948 | spin_lock_irq(&cm.lock); | ||
| 949 | if (!list_empty(&cm_id_priv->altr_list) && | ||
| 950 | (!cm_id_priv->altr_send_port_not_ready)) | ||
| 951 | list_del(&cm_id_priv->altr_list); | ||
| 952 | if (!list_empty(&cm_id_priv->prim_list) && | ||
| 953 | (!cm_id_priv->prim_send_port_not_ready)) | ||
| 954 | list_del(&cm_id_priv->prim_list); | ||
| 955 | spin_unlock_irq(&cm.lock); | ||
| 956 | |||
| 895 | cm_free_id(cm_id->local_id); | 957 | cm_free_id(cm_id->local_id); |
| 896 | cm_deref_id(cm_id_priv); | 958 | cm_deref_id(cm_id_priv); |
| 897 | wait_for_completion(&cm_id_priv->comp); | 959 | wait_for_completion(&cm_id_priv->comp); |
| @@ -1192,12 +1254,13 @@ int ib_send_cm_req(struct ib_cm_id *cm_id, | |||
| 1192 | goto out; | 1254 | goto out; |
| 1193 | } | 1255 | } |
| 1194 | 1256 | ||
| 1195 | ret = cm_init_av_by_path(param->primary_path, &cm_id_priv->av); | 1257 | ret = cm_init_av_by_path(param->primary_path, &cm_id_priv->av, |
| 1258 | cm_id_priv); | ||
| 1196 | if (ret) | 1259 | if (ret) |
| 1197 | goto error1; | 1260 | goto error1; |
| 1198 | if (param->alternate_path) { | 1261 | if (param->alternate_path) { |
| 1199 | ret = cm_init_av_by_path(param->alternate_path, | 1262 | ret = cm_init_av_by_path(param->alternate_path, |
| 1200 | &cm_id_priv->alt_av); | 1263 | &cm_id_priv->alt_av, cm_id_priv); |
| 1201 | if (ret) | 1264 | if (ret) |
| 1202 | goto error1; | 1265 | goto error1; |
| 1203 | } | 1266 | } |
| @@ -1653,7 +1716,8 @@ static int cm_req_handler(struct cm_work *work) | |||
| 1653 | dev_put(gid_attr.ndev); | 1716 | dev_put(gid_attr.ndev); |
| 1654 | } | 1717 | } |
| 1655 | work->path[0].gid_type = gid_attr.gid_type; | 1718 | work->path[0].gid_type = gid_attr.gid_type; |
| 1656 | ret = cm_init_av_by_path(&work->path[0], &cm_id_priv->av); | 1719 | ret = cm_init_av_by_path(&work->path[0], &cm_id_priv->av, |
| 1720 | cm_id_priv); | ||
| 1657 | } | 1721 | } |
| 1658 | if (ret) { | 1722 | if (ret) { |
| 1659 | int err = ib_get_cached_gid(work->port->cm_dev->ib_device, | 1723 | int err = ib_get_cached_gid(work->port->cm_dev->ib_device, |
| @@ -1672,7 +1736,8 @@ static int cm_req_handler(struct cm_work *work) | |||
| 1672 | goto rejected; | 1736 | goto rejected; |
| 1673 | } | 1737 | } |
| 1674 | if (req_msg->alt_local_lid) { | 1738 | if (req_msg->alt_local_lid) { |
| 1675 | ret = cm_init_av_by_path(&work->path[1], &cm_id_priv->alt_av); | 1739 | ret = cm_init_av_by_path(&work->path[1], &cm_id_priv->alt_av, |
| 1740 | cm_id_priv); | ||
| 1676 | if (ret) { | 1741 | if (ret) { |
| 1677 | ib_send_cm_rej(cm_id, IB_CM_REJ_INVALID_ALT_GID, | 1742 | ib_send_cm_rej(cm_id, IB_CM_REJ_INVALID_ALT_GID, |
| 1678 | &work->path[0].sgid, | 1743 | &work->path[0].sgid, |
| @@ -2727,7 +2792,8 @@ int ib_send_cm_lap(struct ib_cm_id *cm_id, | |||
| 2727 | goto out; | 2792 | goto out; |
| 2728 | } | 2793 | } |
| 2729 | 2794 | ||
| 2730 | ret = cm_init_av_by_path(alternate_path, &cm_id_priv->alt_av); | 2795 | ret = cm_init_av_by_path(alternate_path, &cm_id_priv->alt_av, |
| 2796 | cm_id_priv); | ||
| 2731 | if (ret) | 2797 | if (ret) |
| 2732 | goto out; | 2798 | goto out; |
| 2733 | cm_id_priv->alt_av.timeout = | 2799 | cm_id_priv->alt_av.timeout = |
| @@ -2839,7 +2905,8 @@ static int cm_lap_handler(struct cm_work *work) | |||
| 2839 | cm_init_av_for_response(work->port, work->mad_recv_wc->wc, | 2905 | cm_init_av_for_response(work->port, work->mad_recv_wc->wc, |
| 2840 | work->mad_recv_wc->recv_buf.grh, | 2906 | work->mad_recv_wc->recv_buf.grh, |
| 2841 | &cm_id_priv->av); | 2907 | &cm_id_priv->av); |
| 2842 | cm_init_av_by_path(param->alternate_path, &cm_id_priv->alt_av); | 2908 | cm_init_av_by_path(param->alternate_path, &cm_id_priv->alt_av, |
| 2909 | cm_id_priv); | ||
| 2843 | ret = atomic_inc_and_test(&cm_id_priv->work_count); | 2910 | ret = atomic_inc_and_test(&cm_id_priv->work_count); |
| 2844 | if (!ret) | 2911 | if (!ret) |
| 2845 | list_add_tail(&work->list, &cm_id_priv->work_list); | 2912 | list_add_tail(&work->list, &cm_id_priv->work_list); |
| @@ -3031,7 +3098,7 @@ int ib_send_cm_sidr_req(struct ib_cm_id *cm_id, | |||
| 3031 | return -EINVAL; | 3098 | return -EINVAL; |
| 3032 | 3099 | ||
| 3033 | cm_id_priv = container_of(cm_id, struct cm_id_private, id); | 3100 | cm_id_priv = container_of(cm_id, struct cm_id_private, id); |
| 3034 | ret = cm_init_av_by_path(param->path, &cm_id_priv->av); | 3101 | ret = cm_init_av_by_path(param->path, &cm_id_priv->av, cm_id_priv); |
| 3035 | if (ret) | 3102 | if (ret) |
| 3036 | goto out; | 3103 | goto out; |
| 3037 | 3104 | ||
| @@ -3468,7 +3535,9 @@ out: | |||
| 3468 | static int cm_migrate(struct ib_cm_id *cm_id) | 3535 | static int cm_migrate(struct ib_cm_id *cm_id) |
| 3469 | { | 3536 | { |
| 3470 | struct cm_id_private *cm_id_priv; | 3537 | struct cm_id_private *cm_id_priv; |
| 3538 | struct cm_av tmp_av; | ||
| 3471 | unsigned long flags; | 3539 | unsigned long flags; |
| 3540 | int tmp_send_port_not_ready; | ||
| 3472 | int ret = 0; | 3541 | int ret = 0; |
| 3473 | 3542 | ||
| 3474 | cm_id_priv = container_of(cm_id, struct cm_id_private, id); | 3543 | cm_id_priv = container_of(cm_id, struct cm_id_private, id); |
| @@ -3477,7 +3546,14 @@ static int cm_migrate(struct ib_cm_id *cm_id) | |||
| 3477 | (cm_id->lap_state == IB_CM_LAP_UNINIT || | 3546 | (cm_id->lap_state == IB_CM_LAP_UNINIT || |
| 3478 | cm_id->lap_state == IB_CM_LAP_IDLE)) { | 3547 | cm_id->lap_state == IB_CM_LAP_IDLE)) { |
| 3479 | cm_id->lap_state = IB_CM_LAP_IDLE; | 3548 | cm_id->lap_state = IB_CM_LAP_IDLE; |
| 3549 | /* Swap address vector */ | ||
| 3550 | tmp_av = cm_id_priv->av; | ||
| 3480 | cm_id_priv->av = cm_id_priv->alt_av; | 3551 | cm_id_priv->av = cm_id_priv->alt_av; |
| 3552 | cm_id_priv->alt_av = tmp_av; | ||
| 3553 | /* Swap port send ready state */ | ||
| 3554 | tmp_send_port_not_ready = cm_id_priv->prim_send_port_not_ready; | ||
| 3555 | cm_id_priv->prim_send_port_not_ready = cm_id_priv->altr_send_port_not_ready; | ||
| 3556 | cm_id_priv->altr_send_port_not_ready = tmp_send_port_not_ready; | ||
| 3481 | } else | 3557 | } else |
| 3482 | ret = -EINVAL; | 3558 | ret = -EINVAL; |
| 3483 | spin_unlock_irqrestore(&cm_id_priv->lock, flags); | 3559 | spin_unlock_irqrestore(&cm_id_priv->lock, flags); |
| @@ -3888,6 +3964,9 @@ static void cm_add_one(struct ib_device *ib_device) | |||
| 3888 | port->cm_dev = cm_dev; | 3964 | port->cm_dev = cm_dev; |
| 3889 | port->port_num = i; | 3965 | port->port_num = i; |
| 3890 | 3966 | ||
| 3967 | INIT_LIST_HEAD(&port->cm_priv_prim_list); | ||
| 3968 | INIT_LIST_HEAD(&port->cm_priv_altr_list); | ||
| 3969 | |||
| 3891 | ret = cm_create_port_fs(port); | 3970 | ret = cm_create_port_fs(port); |
| 3892 | if (ret) | 3971 | if (ret) |
| 3893 | goto error1; | 3972 | goto error1; |
| @@ -3945,6 +4024,8 @@ static void cm_remove_one(struct ib_device *ib_device, void *client_data) | |||
| 3945 | { | 4024 | { |
| 3946 | struct cm_device *cm_dev = client_data; | 4025 | struct cm_device *cm_dev = client_data; |
| 3947 | struct cm_port *port; | 4026 | struct cm_port *port; |
| 4027 | struct cm_id_private *cm_id_priv; | ||
| 4028 | struct ib_mad_agent *cur_mad_agent; | ||
| 3948 | struct ib_port_modify port_modify = { | 4029 | struct ib_port_modify port_modify = { |
| 3949 | .clr_port_cap_mask = IB_PORT_CM_SUP | 4030 | .clr_port_cap_mask = IB_PORT_CM_SUP |
| 3950 | }; | 4031 | }; |
| @@ -3968,15 +4049,27 @@ static void cm_remove_one(struct ib_device *ib_device, void *client_data) | |||
| 3968 | 4049 | ||
| 3969 | port = cm_dev->port[i-1]; | 4050 | port = cm_dev->port[i-1]; |
| 3970 | ib_modify_port(ib_device, port->port_num, 0, &port_modify); | 4051 | ib_modify_port(ib_device, port->port_num, 0, &port_modify); |
| 4052 | /* Mark all the cm_id's as not valid */ | ||
| 4053 | spin_lock_irq(&cm.lock); | ||
| 4054 | list_for_each_entry(cm_id_priv, &port->cm_priv_altr_list, altr_list) | ||
| 4055 | cm_id_priv->altr_send_port_not_ready = 1; | ||
| 4056 | list_for_each_entry(cm_id_priv, &port->cm_priv_prim_list, prim_list) | ||
| 4057 | cm_id_priv->prim_send_port_not_ready = 1; | ||
| 4058 | spin_unlock_irq(&cm.lock); | ||
| 3971 | /* | 4059 | /* |
| 3972 | * We flush the queue here after the going_down set, this | 4060 | * We flush the queue here after the going_down set, this |
| 3973 | * verify that no new works will be queued in the recv handler, | 4061 | * verify that no new works will be queued in the recv handler, |
| 3974 | * after that we can call the unregister_mad_agent | 4062 | * after that we can call the unregister_mad_agent |
| 3975 | */ | 4063 | */ |
| 3976 | flush_workqueue(cm.wq); | 4064 | flush_workqueue(cm.wq); |
| 3977 | ib_unregister_mad_agent(port->mad_agent); | 4065 | spin_lock_irq(&cm.state_lock); |
| 4066 | cur_mad_agent = port->mad_agent; | ||
| 4067 | port->mad_agent = NULL; | ||
| 4068 | spin_unlock_irq(&cm.state_lock); | ||
| 4069 | ib_unregister_mad_agent(cur_mad_agent); | ||
| 3978 | cm_remove_port_fs(port); | 4070 | cm_remove_port_fs(port); |
| 3979 | } | 4071 | } |
| 4072 | |||
| 3980 | device_unregister(cm_dev->device); | 4073 | device_unregister(cm_dev->device); |
| 3981 | kfree(cm_dev); | 4074 | kfree(cm_dev); |
| 3982 | } | 4075 | } |
| @@ -3989,6 +4082,7 @@ static int __init ib_cm_init(void) | |||
| 3989 | INIT_LIST_HEAD(&cm.device_list); | 4082 | INIT_LIST_HEAD(&cm.device_list); |
| 3990 | rwlock_init(&cm.device_lock); | 4083 | rwlock_init(&cm.device_lock); |
| 3991 | spin_lock_init(&cm.lock); | 4084 | spin_lock_init(&cm.lock); |
| 4085 | spin_lock_init(&cm.state_lock); | ||
| 3992 | cm.listen_service_table = RB_ROOT; | 4086 | cm.listen_service_table = RB_ROOT; |
| 3993 | cm.listen_service_id = be64_to_cpu(IB_CM_ASSIGN_SERVICE_ID); | 4087 | cm.listen_service_id = be64_to_cpu(IB_CM_ASSIGN_SERVICE_ID); |
| 3994 | cm.remote_id_table = RB_ROOT; | 4088 | cm.remote_id_table = RB_ROOT; |
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index 89a6b0546804..2a6fc47a1dfb 100644 --- a/drivers/infiniband/core/cma.c +++ b/drivers/infiniband/core/cma.c | |||
| @@ -2438,6 +2438,18 @@ static int iboe_tos_to_sl(struct net_device *ndev, int tos) | |||
| 2438 | return 0; | 2438 | return 0; |
| 2439 | } | 2439 | } |
| 2440 | 2440 | ||
| 2441 | static enum ib_gid_type cma_route_gid_type(enum rdma_network_type network_type, | ||
| 2442 | unsigned long supported_gids, | ||
| 2443 | enum ib_gid_type default_gid) | ||
| 2444 | { | ||
| 2445 | if ((network_type == RDMA_NETWORK_IPV4 || | ||
| 2446 | network_type == RDMA_NETWORK_IPV6) && | ||
| 2447 | test_bit(IB_GID_TYPE_ROCE_UDP_ENCAP, &supported_gids)) | ||
| 2448 | return IB_GID_TYPE_ROCE_UDP_ENCAP; | ||
| 2449 | |||
| 2450 | return default_gid; | ||
| 2451 | } | ||
| 2452 | |||
| 2441 | static int cma_resolve_iboe_route(struct rdma_id_private *id_priv) | 2453 | static int cma_resolve_iboe_route(struct rdma_id_private *id_priv) |
| 2442 | { | 2454 | { |
| 2443 | struct rdma_route *route = &id_priv->id.route; | 2455 | struct rdma_route *route = &id_priv->id.route; |
| @@ -2463,6 +2475,8 @@ static int cma_resolve_iboe_route(struct rdma_id_private *id_priv) | |||
| 2463 | route->num_paths = 1; | 2475 | route->num_paths = 1; |
| 2464 | 2476 | ||
| 2465 | if (addr->dev_addr.bound_dev_if) { | 2477 | if (addr->dev_addr.bound_dev_if) { |
| 2478 | unsigned long supported_gids; | ||
| 2479 | |||
| 2466 | ndev = dev_get_by_index(&init_net, addr->dev_addr.bound_dev_if); | 2480 | ndev = dev_get_by_index(&init_net, addr->dev_addr.bound_dev_if); |
| 2467 | if (!ndev) { | 2481 | if (!ndev) { |
| 2468 | ret = -ENODEV; | 2482 | ret = -ENODEV; |
| @@ -2486,7 +2500,12 @@ static int cma_resolve_iboe_route(struct rdma_id_private *id_priv) | |||
| 2486 | 2500 | ||
| 2487 | route->path_rec->net = &init_net; | 2501 | route->path_rec->net = &init_net; |
| 2488 | route->path_rec->ifindex = ndev->ifindex; | 2502 | route->path_rec->ifindex = ndev->ifindex; |
| 2489 | route->path_rec->gid_type = id_priv->gid_type; | 2503 | supported_gids = roce_gid_type_mask_support(id_priv->id.device, |
| 2504 | id_priv->id.port_num); | ||
| 2505 | route->path_rec->gid_type = | ||
| 2506 | cma_route_gid_type(addr->dev_addr.network, | ||
| 2507 | supported_gids, | ||
| 2508 | id_priv->gid_type); | ||
| 2490 | } | 2509 | } |
| 2491 | if (!ndev) { | 2510 | if (!ndev) { |
| 2492 | ret = -ENODEV; | 2511 | ret = -ENODEV; |
diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c index 224ad274ea0b..84b4eff90395 100644 --- a/drivers/infiniband/core/umem.c +++ b/drivers/infiniband/core/umem.c | |||
| @@ -175,7 +175,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr, | |||
| 175 | 175 | ||
| 176 | cur_base = addr & PAGE_MASK; | 176 | cur_base = addr & PAGE_MASK; |
| 177 | 177 | ||
| 178 | if (npages == 0) { | 178 | if (npages == 0 || npages > UINT_MAX) { |
| 179 | ret = -EINVAL; | 179 | ret = -EINVAL; |
| 180 | goto out; | 180 | goto out; |
| 181 | } | 181 | } |
diff --git a/drivers/infiniband/core/uverbs_main.c b/drivers/infiniband/core/uverbs_main.c index 0012fa58c105..44b1104eb168 100644 --- a/drivers/infiniband/core/uverbs_main.c +++ b/drivers/infiniband/core/uverbs_main.c | |||
| @@ -262,12 +262,9 @@ static int ib_uverbs_cleanup_ucontext(struct ib_uverbs_file *file, | |||
| 262 | container_of(uobj, struct ib_uqp_object, uevent.uobject); | 262 | container_of(uobj, struct ib_uqp_object, uevent.uobject); |
| 263 | 263 | ||
| 264 | idr_remove_uobj(&ib_uverbs_qp_idr, uobj); | 264 | idr_remove_uobj(&ib_uverbs_qp_idr, uobj); |
| 265 | if (qp != qp->real_qp) { | 265 | if (qp == qp->real_qp) |
| 266 | ib_close_qp(qp); | ||
| 267 | } else { | ||
| 268 | ib_uverbs_detach_umcast(qp, uqp); | 266 | ib_uverbs_detach_umcast(qp, uqp); |
| 269 | ib_destroy_qp(qp); | 267 | ib_destroy_qp(qp); |
| 270 | } | ||
| 271 | ib_uverbs_release_uevent(file, &uqp->uevent); | 268 | ib_uverbs_release_uevent(file, &uqp->uevent); |
| 272 | kfree(uqp); | 269 | kfree(uqp); |
| 273 | } | 270 | } |
diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/drivers/infiniband/hw/cxgb4/cq.c index 867b8cf82be8..19c6477af19f 100644 --- a/drivers/infiniband/hw/cxgb4/cq.c +++ b/drivers/infiniband/hw/cxgb4/cq.c | |||
| @@ -666,18 +666,6 @@ skip_cqe: | |||
| 666 | return ret; | 666 | return ret; |
| 667 | } | 667 | } |
| 668 | 668 | ||
| 669 | static void invalidate_mr(struct c4iw_dev *rhp, u32 rkey) | ||
| 670 | { | ||
| 671 | struct c4iw_mr *mhp; | ||
| 672 | unsigned long flags; | ||
| 673 | |||
| 674 | spin_lock_irqsave(&rhp->lock, flags); | ||
| 675 | mhp = get_mhp(rhp, rkey >> 8); | ||
| 676 | if (mhp) | ||
| 677 | mhp->attr.state = 0; | ||
| 678 | spin_unlock_irqrestore(&rhp->lock, flags); | ||
| 679 | } | ||
| 680 | |||
| 681 | /* | 669 | /* |
| 682 | * Get one cq entry from c4iw and map it to openib. | 670 | * Get one cq entry from c4iw and map it to openib. |
| 683 | * | 671 | * |
| @@ -733,7 +721,7 @@ static int c4iw_poll_cq_one(struct c4iw_cq *chp, struct ib_wc *wc) | |||
| 733 | CQE_OPCODE(&cqe) == FW_RI_SEND_WITH_SE_INV) { | 721 | CQE_OPCODE(&cqe) == FW_RI_SEND_WITH_SE_INV) { |
| 734 | wc->ex.invalidate_rkey = CQE_WRID_STAG(&cqe); | 722 | wc->ex.invalidate_rkey = CQE_WRID_STAG(&cqe); |
| 735 | wc->wc_flags |= IB_WC_WITH_INVALIDATE; | 723 | wc->wc_flags |= IB_WC_WITH_INVALIDATE; |
| 736 | invalidate_mr(qhp->rhp, wc->ex.invalidate_rkey); | 724 | c4iw_invalidate_mr(qhp->rhp, wc->ex.invalidate_rkey); |
| 737 | } | 725 | } |
| 738 | } else { | 726 | } else { |
| 739 | switch (CQE_OPCODE(&cqe)) { | 727 | switch (CQE_OPCODE(&cqe)) { |
| @@ -762,7 +750,8 @@ static int c4iw_poll_cq_one(struct c4iw_cq *chp, struct ib_wc *wc) | |||
| 762 | 750 | ||
| 763 | /* Invalidate the MR if the fastreg failed */ | 751 | /* Invalidate the MR if the fastreg failed */ |
| 764 | if (CQE_STATUS(&cqe) != T4_ERR_SUCCESS) | 752 | if (CQE_STATUS(&cqe) != T4_ERR_SUCCESS) |
| 765 | invalidate_mr(qhp->rhp, CQE_WRID_FR_STAG(&cqe)); | 753 | c4iw_invalidate_mr(qhp->rhp, |
| 754 | CQE_WRID_FR_STAG(&cqe)); | ||
| 766 | break; | 755 | break; |
| 767 | default: | 756 | default: |
| 768 | printk(KERN_ERR MOD "Unexpected opcode %d " | 757 | printk(KERN_ERR MOD "Unexpected opcode %d " |
diff --git a/drivers/infiniband/hw/cxgb4/iw_cxgb4.h b/drivers/infiniband/hw/cxgb4/iw_cxgb4.h index 7e7f79e55006..4788e1a46fde 100644 --- a/drivers/infiniband/hw/cxgb4/iw_cxgb4.h +++ b/drivers/infiniband/hw/cxgb4/iw_cxgb4.h | |||
| @@ -999,6 +999,6 @@ extern int db_coalescing_threshold; | |||
| 999 | extern int use_dsgl; | 999 | extern int use_dsgl; |
| 1000 | void c4iw_drain_rq(struct ib_qp *qp); | 1000 | void c4iw_drain_rq(struct ib_qp *qp); |
| 1001 | void c4iw_drain_sq(struct ib_qp *qp); | 1001 | void c4iw_drain_sq(struct ib_qp *qp); |
| 1002 | 1002 | void c4iw_invalidate_mr(struct c4iw_dev *rhp, u32 rkey); | |
| 1003 | 1003 | ||
| 1004 | #endif | 1004 | #endif |
diff --git a/drivers/infiniband/hw/cxgb4/mem.c b/drivers/infiniband/hw/cxgb4/mem.c index 80e27749420a..410408f886c1 100644 --- a/drivers/infiniband/hw/cxgb4/mem.c +++ b/drivers/infiniband/hw/cxgb4/mem.c | |||
| @@ -770,3 +770,15 @@ int c4iw_dereg_mr(struct ib_mr *ib_mr) | |||
| 770 | kfree(mhp); | 770 | kfree(mhp); |
| 771 | return 0; | 771 | return 0; |
| 772 | } | 772 | } |
| 773 | |||
| 774 | void c4iw_invalidate_mr(struct c4iw_dev *rhp, u32 rkey) | ||
| 775 | { | ||
| 776 | struct c4iw_mr *mhp; | ||
| 777 | unsigned long flags; | ||
| 778 | |||
| 779 | spin_lock_irqsave(&rhp->lock, flags); | ||
| 780 | mhp = get_mhp(rhp, rkey >> 8); | ||
| 781 | if (mhp) | ||
| 782 | mhp->attr.state = 0; | ||
| 783 | spin_unlock_irqrestore(&rhp->lock, flags); | ||
| 784 | } | ||
diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c index f57deba6717c..b7ac97b27c88 100644 --- a/drivers/infiniband/hw/cxgb4/qp.c +++ b/drivers/infiniband/hw/cxgb4/qp.c | |||
| @@ -706,12 +706,8 @@ static int build_memreg(struct t4_sq *sq, union t4_wr *wqe, | |||
| 706 | return 0; | 706 | return 0; |
| 707 | } | 707 | } |
| 708 | 708 | ||
| 709 | static int build_inv_stag(struct c4iw_dev *dev, union t4_wr *wqe, | 709 | static int build_inv_stag(union t4_wr *wqe, struct ib_send_wr *wr, u8 *len16) |
| 710 | struct ib_send_wr *wr, u8 *len16) | ||
| 711 | { | 710 | { |
| 712 | struct c4iw_mr *mhp = get_mhp(dev, wr->ex.invalidate_rkey >> 8); | ||
| 713 | |||
| 714 | mhp->attr.state = 0; | ||
| 715 | wqe->inv.stag_inv = cpu_to_be32(wr->ex.invalidate_rkey); | 711 | wqe->inv.stag_inv = cpu_to_be32(wr->ex.invalidate_rkey); |
| 716 | wqe->inv.r2 = 0; | 712 | wqe->inv.r2 = 0; |
| 717 | *len16 = DIV_ROUND_UP(sizeof wqe->inv, 16); | 713 | *len16 = DIV_ROUND_UP(sizeof wqe->inv, 16); |
| @@ -797,11 +793,13 @@ int c4iw_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr, | |||
| 797 | spin_lock_irqsave(&qhp->lock, flag); | 793 | spin_lock_irqsave(&qhp->lock, flag); |
| 798 | if (t4_wq_in_error(&qhp->wq)) { | 794 | if (t4_wq_in_error(&qhp->wq)) { |
| 799 | spin_unlock_irqrestore(&qhp->lock, flag); | 795 | spin_unlock_irqrestore(&qhp->lock, flag); |
| 796 | *bad_wr = wr; | ||
| 800 | return -EINVAL; | 797 | return -EINVAL; |
| 801 | } | 798 | } |
| 802 | num_wrs = t4_sq_avail(&qhp->wq); | 799 | num_wrs = t4_sq_avail(&qhp->wq); |
| 803 | if (num_wrs == 0) { | 800 | if (num_wrs == 0) { |
| 804 | spin_unlock_irqrestore(&qhp->lock, flag); | 801 | spin_unlock_irqrestore(&qhp->lock, flag); |
| 802 | *bad_wr = wr; | ||
| 805 | return -ENOMEM; | 803 | return -ENOMEM; |
| 806 | } | 804 | } |
| 807 | while (wr) { | 805 | while (wr) { |
| @@ -840,10 +838,13 @@ int c4iw_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr, | |||
| 840 | case IB_WR_RDMA_READ_WITH_INV: | 838 | case IB_WR_RDMA_READ_WITH_INV: |
| 841 | fw_opcode = FW_RI_RDMA_READ_WR; | 839 | fw_opcode = FW_RI_RDMA_READ_WR; |
| 842 | swsqe->opcode = FW_RI_READ_REQ; | 840 | swsqe->opcode = FW_RI_READ_REQ; |
| 843 | if (wr->opcode == IB_WR_RDMA_READ_WITH_INV) | 841 | if (wr->opcode == IB_WR_RDMA_READ_WITH_INV) { |
| 842 | c4iw_invalidate_mr(qhp->rhp, | ||
| 843 | wr->sg_list[0].lkey); | ||
| 844 | fw_flags = FW_RI_RDMA_READ_INVALIDATE; | 844 | fw_flags = FW_RI_RDMA_READ_INVALIDATE; |
| 845 | else | 845 | } else { |
| 846 | fw_flags = 0; | 846 | fw_flags = 0; |
| 847 | } | ||
| 847 | err = build_rdma_read(wqe, wr, &len16); | 848 | err = build_rdma_read(wqe, wr, &len16); |
| 848 | if (err) | 849 | if (err) |
| 849 | break; | 850 | break; |
| @@ -876,7 +877,8 @@ int c4iw_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr, | |||
| 876 | fw_flags |= FW_RI_LOCAL_FENCE_FLAG; | 877 | fw_flags |= FW_RI_LOCAL_FENCE_FLAG; |
| 877 | fw_opcode = FW_RI_INV_LSTAG_WR; | 878 | fw_opcode = FW_RI_INV_LSTAG_WR; |
| 878 | swsqe->opcode = FW_RI_LOCAL_INV; | 879 | swsqe->opcode = FW_RI_LOCAL_INV; |
| 879 | err = build_inv_stag(qhp->rhp, wqe, wr, &len16); | 880 | err = build_inv_stag(wqe, wr, &len16); |
| 881 | c4iw_invalidate_mr(qhp->rhp, wr->ex.invalidate_rkey); | ||
| 880 | break; | 882 | break; |
| 881 | default: | 883 | default: |
| 882 | PDBG("%s post of type=%d TBD!\n", __func__, | 884 | PDBG("%s post of type=%d TBD!\n", __func__, |
| @@ -934,11 +936,13 @@ int c4iw_post_receive(struct ib_qp *ibqp, struct ib_recv_wr *wr, | |||
| 934 | spin_lock_irqsave(&qhp->lock, flag); | 936 | spin_lock_irqsave(&qhp->lock, flag); |
| 935 | if (t4_wq_in_error(&qhp->wq)) { | 937 | if (t4_wq_in_error(&qhp->wq)) { |
| 936 | spin_unlock_irqrestore(&qhp->lock, flag); | 938 | spin_unlock_irqrestore(&qhp->lock, flag); |
| 939 | *bad_wr = wr; | ||
| 937 | return -EINVAL; | 940 | return -EINVAL; |
| 938 | } | 941 | } |
| 939 | num_wrs = t4_rq_avail(&qhp->wq); | 942 | num_wrs = t4_rq_avail(&qhp->wq); |
| 940 | if (num_wrs == 0) { | 943 | if (num_wrs == 0) { |
| 941 | spin_unlock_irqrestore(&qhp->lock, flag); | 944 | spin_unlock_irqrestore(&qhp->lock, flag); |
| 945 | *bad_wr = wr; | ||
| 942 | return -ENOMEM; | 946 | return -ENOMEM; |
| 943 | } | 947 | } |
| 944 | while (wr) { | 948 | while (wr) { |
diff --git a/drivers/infiniband/hw/hfi1/affinity.c b/drivers/infiniband/hw/hfi1/affinity.c index a26a9a0bfc41..67ea85a56945 100644 --- a/drivers/infiniband/hw/hfi1/affinity.c +++ b/drivers/infiniband/hw/hfi1/affinity.c | |||
| @@ -775,75 +775,3 @@ void hfi1_put_proc_affinity(int cpu) | |||
| 775 | } | 775 | } |
| 776 | mutex_unlock(&affinity->lock); | 776 | mutex_unlock(&affinity->lock); |
| 777 | } | 777 | } |
| 778 | |||
| 779 | int hfi1_set_sdma_affinity(struct hfi1_devdata *dd, const char *buf, | ||
| 780 | size_t count) | ||
| 781 | { | ||
| 782 | struct hfi1_affinity_node *entry; | ||
| 783 | cpumask_var_t mask; | ||
| 784 | int ret, i; | ||
| 785 | |||
| 786 | mutex_lock(&node_affinity.lock); | ||
| 787 | entry = node_affinity_lookup(dd->node); | ||
| 788 | |||
| 789 | if (!entry) { | ||
| 790 | ret = -EINVAL; | ||
| 791 | goto unlock; | ||
| 792 | } | ||
| 793 | |||
| 794 | ret = zalloc_cpumask_var(&mask, GFP_KERNEL); | ||
| 795 | if (!ret) { | ||
| 796 | ret = -ENOMEM; | ||
| 797 | goto unlock; | ||
| 798 | } | ||
| 799 | |||
| 800 | ret = cpulist_parse(buf, mask); | ||
| 801 | if (ret) | ||
| 802 | goto out; | ||
| 803 | |||
| 804 | if (!cpumask_subset(mask, cpu_online_mask) || cpumask_empty(mask)) { | ||
| 805 | dd_dev_warn(dd, "Invalid CPU mask\n"); | ||
| 806 | ret = -EINVAL; | ||
| 807 | goto out; | ||
| 808 | } | ||
| 809 | |||
| 810 | /* reset the SDMA interrupt affinity details */ | ||
| 811 | init_cpu_mask_set(&entry->def_intr); | ||
| 812 | cpumask_copy(&entry->def_intr.mask, mask); | ||
| 813 | |||
| 814 | /* Reassign the affinity for each SDMA interrupt. */ | ||
| 815 | for (i = 0; i < dd->num_msix_entries; i++) { | ||
| 816 | struct hfi1_msix_entry *msix; | ||
| 817 | |||
| 818 | msix = &dd->msix_entries[i]; | ||
| 819 | if (msix->type != IRQ_SDMA) | ||
| 820 | continue; | ||
| 821 | |||
| 822 | ret = get_irq_affinity(dd, msix); | ||
| 823 | |||
| 824 | if (ret) | ||
| 825 | break; | ||
| 826 | } | ||
| 827 | out: | ||
| 828 | free_cpumask_var(mask); | ||
| 829 | unlock: | ||
| 830 | mutex_unlock(&node_affinity.lock); | ||
| 831 | return ret ? ret : strnlen(buf, PAGE_SIZE); | ||
| 832 | } | ||
| 833 | |||
| 834 | int hfi1_get_sdma_affinity(struct hfi1_devdata *dd, char *buf) | ||
| 835 | { | ||
| 836 | struct hfi1_affinity_node *entry; | ||
| 837 | |||
| 838 | mutex_lock(&node_affinity.lock); | ||
| 839 | entry = node_affinity_lookup(dd->node); | ||
| 840 | |||
| 841 | if (!entry) { | ||
| 842 | mutex_unlock(&node_affinity.lock); | ||
| 843 | return -EINVAL; | ||
| 844 | } | ||
| 845 | |||
| 846 | cpumap_print_to_pagebuf(true, buf, &entry->def_intr.mask); | ||
| 847 | mutex_unlock(&node_affinity.lock); | ||
| 848 | return strnlen(buf, PAGE_SIZE); | ||
| 849 | } | ||
diff --git a/drivers/infiniband/hw/hfi1/affinity.h b/drivers/infiniband/hw/hfi1/affinity.h index b89ea3c0ee1a..42e63316afd1 100644 --- a/drivers/infiniband/hw/hfi1/affinity.h +++ b/drivers/infiniband/hw/hfi1/affinity.h | |||
| @@ -102,10 +102,6 @@ int hfi1_get_proc_affinity(int); | |||
| 102 | /* Release a CPU used by a user process. */ | 102 | /* Release a CPU used by a user process. */ |
| 103 | void hfi1_put_proc_affinity(int); | 103 | void hfi1_put_proc_affinity(int); |
| 104 | 104 | ||
| 105 | int hfi1_get_sdma_affinity(struct hfi1_devdata *dd, char *buf); | ||
| 106 | int hfi1_set_sdma_affinity(struct hfi1_devdata *dd, const char *buf, | ||
| 107 | size_t count); | ||
| 108 | |||
| 109 | struct hfi1_affinity_node { | 105 | struct hfi1_affinity_node { |
| 110 | int node; | 106 | int node; |
| 111 | struct cpu_mask_set def_intr; | 107 | struct cpu_mask_set def_intr; |
diff --git a/drivers/infiniband/hw/hfi1/chip.c b/drivers/infiniband/hw/hfi1/chip.c index 9bf5f23544d4..24d0820873cf 100644 --- a/drivers/infiniband/hw/hfi1/chip.c +++ b/drivers/infiniband/hw/hfi1/chip.c | |||
| @@ -6301,19 +6301,8 @@ void set_up_vl15(struct hfi1_devdata *dd, u8 vau, u16 vl15buf) | |||
| 6301 | /* leave shared count at zero for both global and VL15 */ | 6301 | /* leave shared count at zero for both global and VL15 */ |
| 6302 | write_global_credit(dd, vau, vl15buf, 0); | 6302 | write_global_credit(dd, vau, vl15buf, 0); |
| 6303 | 6303 | ||
| 6304 | /* We may need some credits for another VL when sending packets | 6304 | write_csr(dd, SEND_CM_CREDIT_VL15, (u64)vl15buf |
| 6305 | * with the snoop interface. Dividing it down the middle for VL15 | 6305 | << SEND_CM_CREDIT_VL15_DEDICATED_LIMIT_VL_SHIFT); |
| 6306 | * and VL0 should suffice. | ||
| 6307 | */ | ||
| 6308 | if (unlikely(dd->hfi1_snoop.mode_flag == HFI1_PORT_SNOOP_MODE)) { | ||
| 6309 | write_csr(dd, SEND_CM_CREDIT_VL15, (u64)(vl15buf >> 1) | ||
| 6310 | << SEND_CM_CREDIT_VL15_DEDICATED_LIMIT_VL_SHIFT); | ||
| 6311 | write_csr(dd, SEND_CM_CREDIT_VL, (u64)(vl15buf >> 1) | ||
| 6312 | << SEND_CM_CREDIT_VL_DEDICATED_LIMIT_VL_SHIFT); | ||
| 6313 | } else { | ||
| 6314 | write_csr(dd, SEND_CM_CREDIT_VL15, (u64)vl15buf | ||
| 6315 | << SEND_CM_CREDIT_VL15_DEDICATED_LIMIT_VL_SHIFT); | ||
| 6316 | } | ||
| 6317 | } | 6306 | } |
| 6318 | 6307 | ||
| 6319 | /* | 6308 | /* |
| @@ -9915,9 +9904,6 @@ static void set_lidlmc(struct hfi1_pportdata *ppd) | |||
| 9915 | u32 mask = ~((1U << ppd->lmc) - 1); | 9904 | u32 mask = ~((1U << ppd->lmc) - 1); |
| 9916 | u64 c1 = read_csr(ppd->dd, DCC_CFG_PORT_CONFIG1); | 9905 | u64 c1 = read_csr(ppd->dd, DCC_CFG_PORT_CONFIG1); |
| 9917 | 9906 | ||
| 9918 | if (dd->hfi1_snoop.mode_flag) | ||
| 9919 | dd_dev_info(dd, "Set lid/lmc while snooping"); | ||
| 9920 | |||
| 9921 | c1 &= ~(DCC_CFG_PORT_CONFIG1_TARGET_DLID_SMASK | 9907 | c1 &= ~(DCC_CFG_PORT_CONFIG1_TARGET_DLID_SMASK |
| 9922 | | DCC_CFG_PORT_CONFIG1_DLID_MASK_SMASK); | 9908 | | DCC_CFG_PORT_CONFIG1_DLID_MASK_SMASK); |
| 9923 | c1 |= ((ppd->lid & DCC_CFG_PORT_CONFIG1_TARGET_DLID_MASK) | 9909 | c1 |= ((ppd->lid & DCC_CFG_PORT_CONFIG1_TARGET_DLID_MASK) |
| @@ -12112,7 +12098,7 @@ static void update_synth_timer(unsigned long opaque) | |||
| 12112 | mod_timer(&dd->synth_stats_timer, jiffies + HZ * SYNTH_CNT_TIME); | 12098 | mod_timer(&dd->synth_stats_timer, jiffies + HZ * SYNTH_CNT_TIME); |
| 12113 | } | 12099 | } |
| 12114 | 12100 | ||
| 12115 | #define C_MAX_NAME 13 /* 12 chars + one for /0 */ | 12101 | #define C_MAX_NAME 16 /* 15 chars + one for /0 */ |
| 12116 | static int init_cntrs(struct hfi1_devdata *dd) | 12102 | static int init_cntrs(struct hfi1_devdata *dd) |
| 12117 | { | 12103 | { |
| 12118 | int i, rcv_ctxts, j; | 12104 | int i, rcv_ctxts, j; |
| @@ -14463,7 +14449,7 @@ struct hfi1_devdata *hfi1_init_dd(struct pci_dev *pdev, | |||
| 14463 | * Any error printing is already done by the init code. | 14449 | * Any error printing is already done by the init code. |
| 14464 | * On return, we have the chip mapped. | 14450 | * On return, we have the chip mapped. |
| 14465 | */ | 14451 | */ |
| 14466 | ret = hfi1_pcie_ddinit(dd, pdev, ent); | 14452 | ret = hfi1_pcie_ddinit(dd, pdev); |
| 14467 | if (ret < 0) | 14453 | if (ret < 0) |
| 14468 | goto bail_free; | 14454 | goto bail_free; |
| 14469 | 14455 | ||
| @@ -14691,6 +14677,11 @@ struct hfi1_devdata *hfi1_init_dd(struct pci_dev *pdev, | |||
| 14691 | if (ret) | 14677 | if (ret) |
| 14692 | goto bail_free_cntrs; | 14678 | goto bail_free_cntrs; |
| 14693 | 14679 | ||
| 14680 | init_completion(&dd->user_comp); | ||
| 14681 | |||
| 14682 | /* The user refcount starts with one to inidicate an active device */ | ||
| 14683 | atomic_set(&dd->user_refcount, 1); | ||
| 14684 | |||
| 14694 | goto bail; | 14685 | goto bail; |
| 14695 | 14686 | ||
| 14696 | bail_free_rcverr: | 14687 | bail_free_rcverr: |
diff --git a/drivers/infiniband/hw/hfi1/chip.h b/drivers/infiniband/hw/hfi1/chip.h index 92345259a8f4..043fd21dc5f3 100644 --- a/drivers/infiniband/hw/hfi1/chip.h +++ b/drivers/infiniband/hw/hfi1/chip.h | |||
| @@ -320,6 +320,9 @@ | |||
| 320 | /* DC_DC8051_CFG_MODE.GENERAL bits */ | 320 | /* DC_DC8051_CFG_MODE.GENERAL bits */ |
| 321 | #define DISABLE_SELF_GUID_CHECK 0x2 | 321 | #define DISABLE_SELF_GUID_CHECK 0x2 |
| 322 | 322 | ||
| 323 | /* Bad L2 frame error code */ | ||
| 324 | #define BAD_L2_ERR 0x6 | ||
| 325 | |||
| 323 | /* | 326 | /* |
| 324 | * Eager buffer minimum and maximum sizes supported by the hardware. | 327 | * Eager buffer minimum and maximum sizes supported by the hardware. |
| 325 | * All power-of-two sizes in between are supported as well. | 328 | * All power-of-two sizes in between are supported as well. |
diff --git a/drivers/infiniband/hw/hfi1/driver.c b/drivers/infiniband/hw/hfi1/driver.c index 6563e4d38b80..c5efff29c147 100644 --- a/drivers/infiniband/hw/hfi1/driver.c +++ b/drivers/infiniband/hw/hfi1/driver.c | |||
| @@ -599,7 +599,6 @@ static void __prescan_rxq(struct hfi1_packet *packet) | |||
| 599 | dd->rhf_offset; | 599 | dd->rhf_offset; |
| 600 | struct rvt_qp *qp; | 600 | struct rvt_qp *qp; |
| 601 | struct ib_header *hdr; | 601 | struct ib_header *hdr; |
| 602 | struct ib_other_headers *ohdr; | ||
| 603 | struct rvt_dev_info *rdi = &dd->verbs_dev.rdi; | 602 | struct rvt_dev_info *rdi = &dd->verbs_dev.rdi; |
| 604 | u64 rhf = rhf_to_cpu(rhf_addr); | 603 | u64 rhf = rhf_to_cpu(rhf_addr); |
| 605 | u32 etype = rhf_rcv_type(rhf), qpn, bth1; | 604 | u32 etype = rhf_rcv_type(rhf), qpn, bth1; |
| @@ -615,18 +614,21 @@ static void __prescan_rxq(struct hfi1_packet *packet) | |||
| 615 | if (etype != RHF_RCV_TYPE_IB) | 614 | if (etype != RHF_RCV_TYPE_IB) |
| 616 | goto next; | 615 | goto next; |
| 617 | 616 | ||
| 618 | hdr = hfi1_get_msgheader(dd, rhf_addr); | 617 | packet->hdr = hfi1_get_msgheader(dd, rhf_addr); |
| 618 | hdr = packet->hdr; | ||
| 619 | 619 | ||
| 620 | lnh = be16_to_cpu(hdr->lrh[0]) & 3; | 620 | lnh = be16_to_cpu(hdr->lrh[0]) & 3; |
| 621 | 621 | ||
| 622 | if (lnh == HFI1_LRH_BTH) | 622 | if (lnh == HFI1_LRH_BTH) { |
| 623 | ohdr = &hdr->u.oth; | 623 | packet->ohdr = &hdr->u.oth; |
| 624 | else if (lnh == HFI1_LRH_GRH) | 624 | } else if (lnh == HFI1_LRH_GRH) { |
| 625 | ohdr = &hdr->u.l.oth; | 625 | packet->ohdr = &hdr->u.l.oth; |
| 626 | else | 626 | packet->rcv_flags |= HFI1_HAS_GRH; |
| 627 | } else { | ||
| 627 | goto next; /* just in case */ | 628 | goto next; /* just in case */ |
| 629 | } | ||
| 628 | 630 | ||
| 629 | bth1 = be32_to_cpu(ohdr->bth[1]); | 631 | bth1 = be32_to_cpu(packet->ohdr->bth[1]); |
| 630 | is_ecn = !!(bth1 & (HFI1_FECN_SMASK | HFI1_BECN_SMASK)); | 632 | is_ecn = !!(bth1 & (HFI1_FECN_SMASK | HFI1_BECN_SMASK)); |
| 631 | 633 | ||
| 632 | if (!is_ecn) | 634 | if (!is_ecn) |
| @@ -646,7 +648,7 @@ static void __prescan_rxq(struct hfi1_packet *packet) | |||
| 646 | 648 | ||
| 647 | /* turn off BECN, FECN */ | 649 | /* turn off BECN, FECN */ |
| 648 | bth1 &= ~(HFI1_FECN_SMASK | HFI1_BECN_SMASK); | 650 | bth1 &= ~(HFI1_FECN_SMASK | HFI1_BECN_SMASK); |
| 649 | ohdr->bth[1] = cpu_to_be32(bth1); | 651 | packet->ohdr->bth[1] = cpu_to_be32(bth1); |
| 650 | next: | 652 | next: |
| 651 | update_ps_mdata(&mdata, rcd); | 653 | update_ps_mdata(&mdata, rcd); |
| 652 | } | 654 | } |
| @@ -1360,12 +1362,25 @@ int process_receive_ib(struct hfi1_packet *packet) | |||
| 1360 | 1362 | ||
| 1361 | int process_receive_bypass(struct hfi1_packet *packet) | 1363 | int process_receive_bypass(struct hfi1_packet *packet) |
| 1362 | { | 1364 | { |
| 1365 | struct hfi1_devdata *dd = packet->rcd->dd; | ||
| 1366 | |||
| 1363 | if (unlikely(rhf_err_flags(packet->rhf))) | 1367 | if (unlikely(rhf_err_flags(packet->rhf))) |
| 1364 | handle_eflags(packet); | 1368 | handle_eflags(packet); |
| 1365 | 1369 | ||
| 1366 | dd_dev_err(packet->rcd->dd, | 1370 | dd_dev_err(dd, |
| 1367 | "Bypass packets are not supported in normal operation. Dropping\n"); | 1371 | "Bypass packets are not supported in normal operation. Dropping\n"); |
| 1368 | incr_cntr64(&packet->rcd->dd->sw_rcv_bypass_packet_errors); | 1372 | incr_cntr64(&dd->sw_rcv_bypass_packet_errors); |
| 1373 | if (!(dd->err_info_rcvport.status_and_code & OPA_EI_STATUS_SMASK)) { | ||
| 1374 | u64 *flits = packet->ebuf; | ||
| 1375 | |||
| 1376 | if (flits && !(packet->rhf & RHF_LEN_ERR)) { | ||
| 1377 | dd->err_info_rcvport.packet_flit1 = flits[0]; | ||
| 1378 | dd->err_info_rcvport.packet_flit2 = | ||
| 1379 | packet->tlen > sizeof(flits[0]) ? flits[1] : 0; | ||
| 1380 | } | ||
| 1381 | dd->err_info_rcvport.status_and_code |= | ||
| 1382 | (OPA_EI_STATUS_SMASK | BAD_L2_ERR); | ||
| 1383 | } | ||
| 1369 | return RHF_RCV_CONTINUE; | 1384 | return RHF_RCV_CONTINUE; |
| 1370 | } | 1385 | } |
| 1371 | 1386 | ||
diff --git a/drivers/infiniband/hw/hfi1/file_ops.c b/drivers/infiniband/hw/hfi1/file_ops.c index 677efa0e8cd6..bd786b7bd30b 100644 --- a/drivers/infiniband/hw/hfi1/file_ops.c +++ b/drivers/infiniband/hw/hfi1/file_ops.c | |||
| @@ -172,6 +172,9 @@ static int hfi1_file_open(struct inode *inode, struct file *fp) | |||
| 172 | struct hfi1_devdata, | 172 | struct hfi1_devdata, |
| 173 | user_cdev); | 173 | user_cdev); |
| 174 | 174 | ||
| 175 | if (!atomic_inc_not_zero(&dd->user_refcount)) | ||
| 176 | return -ENXIO; | ||
| 177 | |||
| 175 | /* Just take a ref now. Not all opens result in a context assign */ | 178 | /* Just take a ref now. Not all opens result in a context assign */ |
| 176 | kobject_get(&dd->kobj); | 179 | kobject_get(&dd->kobj); |
| 177 | 180 | ||
| @@ -183,11 +186,17 @@ static int hfi1_file_open(struct inode *inode, struct file *fp) | |||
| 183 | fd->rec_cpu_num = -1; /* no cpu affinity by default */ | 186 | fd->rec_cpu_num = -1; /* no cpu affinity by default */ |
| 184 | fd->mm = current->mm; | 187 | fd->mm = current->mm; |
| 185 | atomic_inc(&fd->mm->mm_count); | 188 | atomic_inc(&fd->mm->mm_count); |
| 186 | } | 189 | fp->private_data = fd; |
| 190 | } else { | ||
| 191 | fp->private_data = NULL; | ||
| 192 | |||
| 193 | if (atomic_dec_and_test(&dd->user_refcount)) | ||
| 194 | complete(&dd->user_comp); | ||
| 187 | 195 | ||
| 188 | fp->private_data = fd; | 196 | return -ENOMEM; |
| 197 | } | ||
| 189 | 198 | ||
| 190 | return fd ? 0 : -ENOMEM; | 199 | return 0; |
| 191 | } | 200 | } |
| 192 | 201 | ||
| 193 | static long hfi1_file_ioctl(struct file *fp, unsigned int cmd, | 202 | static long hfi1_file_ioctl(struct file *fp, unsigned int cmd, |
| @@ -798,6 +807,10 @@ static int hfi1_file_close(struct inode *inode, struct file *fp) | |||
| 798 | done: | 807 | done: |
| 799 | mmdrop(fdata->mm); | 808 | mmdrop(fdata->mm); |
| 800 | kobject_put(&dd->kobj); | 809 | kobject_put(&dd->kobj); |
| 810 | |||
| 811 | if (atomic_dec_and_test(&dd->user_refcount)) | ||
| 812 | complete(&dd->user_comp); | ||
| 813 | |||
| 801 | kfree(fdata); | 814 | kfree(fdata); |
| 802 | return 0; | 815 | return 0; |
| 803 | } | 816 | } |
diff --git a/drivers/infiniband/hw/hfi1/hfi.h b/drivers/infiniband/hw/hfi1/hfi.h index 7eef11b316ff..cc87fd4e534b 100644 --- a/drivers/infiniband/hw/hfi1/hfi.h +++ b/drivers/infiniband/hw/hfi1/hfi.h | |||
| @@ -367,26 +367,6 @@ struct hfi1_packet { | |||
| 367 | u8 etype; | 367 | u8 etype; |
| 368 | }; | 368 | }; |
| 369 | 369 | ||
| 370 | /* | ||
| 371 | * Private data for snoop/capture support. | ||
| 372 | */ | ||
| 373 | struct hfi1_snoop_data { | ||
| 374 | int mode_flag; | ||
| 375 | struct cdev cdev; | ||
| 376 | struct device *class_dev; | ||
| 377 | /* protect snoop data */ | ||
| 378 | spinlock_t snoop_lock; | ||
| 379 | struct list_head queue; | ||
| 380 | wait_queue_head_t waitq; | ||
| 381 | void *filter_value; | ||
| 382 | int (*filter_callback)(void *hdr, void *data, void *value); | ||
| 383 | u64 dcc_cfg; /* saved value of DCC Cfg register */ | ||
| 384 | }; | ||
| 385 | |||
| 386 | /* snoop mode_flag values */ | ||
| 387 | #define HFI1_PORT_SNOOP_MODE 1U | ||
| 388 | #define HFI1_PORT_CAPTURE_MODE 2U | ||
| 389 | |||
| 390 | struct rvt_sge_state; | 370 | struct rvt_sge_state; |
| 391 | 371 | ||
| 392 | /* | 372 | /* |
| @@ -613,8 +593,6 @@ struct hfi1_pportdata { | |||
| 613 | struct mutex hls_lock; | 593 | struct mutex hls_lock; |
| 614 | u32 host_link_state; | 594 | u32 host_link_state; |
| 615 | 595 | ||
| 616 | spinlock_t sdma_alllock ____cacheline_aligned_in_smp; | ||
| 617 | |||
| 618 | u32 lstate; /* logical link state */ | 596 | u32 lstate; /* logical link state */ |
| 619 | 597 | ||
| 620 | /* these are the "32 bit" regs */ | 598 | /* these are the "32 bit" regs */ |
| @@ -1104,8 +1082,6 @@ struct hfi1_devdata { | |||
| 1104 | char *portcntrnames; | 1082 | char *portcntrnames; |
| 1105 | size_t portcntrnameslen; | 1083 | size_t portcntrnameslen; |
| 1106 | 1084 | ||
| 1107 | struct hfi1_snoop_data hfi1_snoop; | ||
| 1108 | |||
| 1109 | struct err_info_rcvport err_info_rcvport; | 1085 | struct err_info_rcvport err_info_rcvport; |
| 1110 | struct err_info_constraint err_info_rcv_constraint; | 1086 | struct err_info_constraint err_info_rcv_constraint; |
| 1111 | struct err_info_constraint err_info_xmit_constraint; | 1087 | struct err_info_constraint err_info_xmit_constraint; |
| @@ -1141,8 +1117,8 @@ struct hfi1_devdata { | |||
| 1141 | rhf_rcv_function_ptr normal_rhf_rcv_functions[8]; | 1117 | rhf_rcv_function_ptr normal_rhf_rcv_functions[8]; |
| 1142 | 1118 | ||
| 1143 | /* | 1119 | /* |
| 1144 | * Handlers for outgoing data so that snoop/capture does not | 1120 | * Capability to have different send engines simply by changing a |
| 1145 | * have to have its hooks in the send path | 1121 | * pointer value. |
| 1146 | */ | 1122 | */ |
| 1147 | send_routine process_pio_send; | 1123 | send_routine process_pio_send; |
| 1148 | send_routine process_dma_send; | 1124 | send_routine process_dma_send; |
| @@ -1174,6 +1150,10 @@ struct hfi1_devdata { | |||
| 1174 | spinlock_t aspm_lock; | 1150 | spinlock_t aspm_lock; |
| 1175 | /* Number of verbs contexts which have disabled ASPM */ | 1151 | /* Number of verbs contexts which have disabled ASPM */ |
| 1176 | atomic_t aspm_disabled_cnt; | 1152 | atomic_t aspm_disabled_cnt; |
| 1153 | /* Keeps track of user space clients */ | ||
| 1154 | atomic_t user_refcount; | ||
| 1155 | /* Used to wait for outstanding user space clients before dev removal */ | ||
| 1156 | struct completion user_comp; | ||
| 1177 | 1157 | ||
| 1178 | struct hfi1_affinity *affinity; | 1158 | struct hfi1_affinity *affinity; |
| 1179 | struct rhashtable sdma_rht; | 1159 | struct rhashtable sdma_rht; |
| @@ -1221,8 +1201,6 @@ struct hfi1_devdata *hfi1_lookup(int unit); | |||
| 1221 | extern u32 hfi1_cpulist_count; | 1201 | extern u32 hfi1_cpulist_count; |
| 1222 | extern unsigned long *hfi1_cpulist; | 1202 | extern unsigned long *hfi1_cpulist; |
| 1223 | 1203 | ||
| 1224 | extern unsigned int snoop_drop_send; | ||
| 1225 | extern unsigned int snoop_force_capture; | ||
| 1226 | int hfi1_init(struct hfi1_devdata *, int); | 1204 | int hfi1_init(struct hfi1_devdata *, int); |
| 1227 | int hfi1_count_units(int *npresentp, int *nupp); | 1205 | int hfi1_count_units(int *npresentp, int *nupp); |
| 1228 | int hfi1_count_active_units(void); | 1206 | int hfi1_count_active_units(void); |
| @@ -1557,13 +1535,6 @@ void set_up_vl15(struct hfi1_devdata *dd, u8 vau, u16 vl15buf); | |||
| 1557 | void reset_link_credits(struct hfi1_devdata *dd); | 1535 | void reset_link_credits(struct hfi1_devdata *dd); |
| 1558 | void assign_remote_cm_au_table(struct hfi1_devdata *dd, u8 vcu); | 1536 | void assign_remote_cm_au_table(struct hfi1_devdata *dd, u8 vcu); |
| 1559 | 1537 | ||
| 1560 | int snoop_recv_handler(struct hfi1_packet *packet); | ||
| 1561 | int snoop_send_dma_handler(struct rvt_qp *qp, struct hfi1_pkt_state *ps, | ||
| 1562 | u64 pbc); | ||
| 1563 | int snoop_send_pio_handler(struct rvt_qp *qp, struct hfi1_pkt_state *ps, | ||
| 1564 | u64 pbc); | ||
| 1565 | void snoop_inline_pio_send(struct hfi1_devdata *dd, struct pio_buf *pbuf, | ||
| 1566 | u64 pbc, const void *from, size_t count); | ||
| 1567 | int set_buffer_control(struct hfi1_pportdata *ppd, struct buffer_control *bc); | 1538 | int set_buffer_control(struct hfi1_pportdata *ppd, struct buffer_control *bc); |
| 1568 | 1539 | ||
| 1569 | static inline struct hfi1_devdata *dd_from_ppd(struct hfi1_pportdata *ppd) | 1540 | static inline struct hfi1_devdata *dd_from_ppd(struct hfi1_pportdata *ppd) |
| @@ -1763,8 +1734,7 @@ int qsfp_dump(struct hfi1_pportdata *ppd, char *buf, int len); | |||
| 1763 | 1734 | ||
| 1764 | int hfi1_pcie_init(struct pci_dev *, const struct pci_device_id *); | 1735 | int hfi1_pcie_init(struct pci_dev *, const struct pci_device_id *); |
| 1765 | void hfi1_pcie_cleanup(struct pci_dev *); | 1736 | void hfi1_pcie_cleanup(struct pci_dev *); |
| 1766 | int hfi1_pcie_ddinit(struct hfi1_devdata *, struct pci_dev *, | 1737 | int hfi1_pcie_ddinit(struct hfi1_devdata *, struct pci_dev *); |
| 1767 | const struct pci_device_id *); | ||
| 1768 | void hfi1_pcie_ddcleanup(struct hfi1_devdata *); | 1738 | void hfi1_pcie_ddcleanup(struct hfi1_devdata *); |
| 1769 | void hfi1_pcie_flr(struct hfi1_devdata *); | 1739 | void hfi1_pcie_flr(struct hfi1_devdata *); |
| 1770 | int pcie_speeds(struct hfi1_devdata *); | 1740 | int pcie_speeds(struct hfi1_devdata *); |
| @@ -1799,8 +1769,6 @@ int kdeth_process_expected(struct hfi1_packet *packet); | |||
| 1799 | int kdeth_process_eager(struct hfi1_packet *packet); | 1769 | int kdeth_process_eager(struct hfi1_packet *packet); |
| 1800 | int process_receive_invalid(struct hfi1_packet *packet); | 1770 | int process_receive_invalid(struct hfi1_packet *packet); |
| 1801 | 1771 | ||
| 1802 | extern rhf_rcv_function_ptr snoop_rhf_rcv_functions[8]; | ||
| 1803 | |||
| 1804 | void update_sge(struct rvt_sge_state *ss, u32 length); | 1772 | void update_sge(struct rvt_sge_state *ss, u32 length); |
| 1805 | 1773 | ||
| 1806 | /* global module parameter variables */ | 1774 | /* global module parameter variables */ |
| @@ -1827,9 +1795,6 @@ extern struct mutex hfi1_mutex; | |||
| 1827 | #define DRIVER_NAME "hfi1" | 1795 | #define DRIVER_NAME "hfi1" |
| 1828 | #define HFI1_USER_MINOR_BASE 0 | 1796 | #define HFI1_USER_MINOR_BASE 0 |
| 1829 | #define HFI1_TRACE_MINOR 127 | 1797 | #define HFI1_TRACE_MINOR 127 |
| 1830 | #define HFI1_DIAGPKT_MINOR 128 | ||
| 1831 | #define HFI1_DIAG_MINOR_BASE 129 | ||
| 1832 | #define HFI1_SNOOP_CAPTURE_BASE 200 | ||
| 1833 | #define HFI1_NMINORS 255 | 1798 | #define HFI1_NMINORS 255 |
| 1834 | 1799 | ||
| 1835 | #define PCI_VENDOR_ID_INTEL 0x8086 | 1800 | #define PCI_VENDOR_ID_INTEL 0x8086 |
| @@ -1848,7 +1813,13 @@ extern struct mutex hfi1_mutex; | |||
| 1848 | static inline u64 hfi1_pkt_default_send_ctxt_mask(struct hfi1_devdata *dd, | 1813 | static inline u64 hfi1_pkt_default_send_ctxt_mask(struct hfi1_devdata *dd, |
| 1849 | u16 ctxt_type) | 1814 | u16 ctxt_type) |
| 1850 | { | 1815 | { |
| 1851 | u64 base_sc_integrity = | 1816 | u64 base_sc_integrity; |
| 1817 | |||
| 1818 | /* No integrity checks if HFI1_CAP_NO_INTEGRITY is set */ | ||
| 1819 | if (HFI1_CAP_IS_KSET(NO_INTEGRITY)) | ||
| 1820 | return 0; | ||
| 1821 | |||
| 1822 | base_sc_integrity = | ||
| 1852 | SEND_CTXT_CHECK_ENABLE_DISALLOW_BYPASS_BAD_PKT_LEN_SMASK | 1823 | SEND_CTXT_CHECK_ENABLE_DISALLOW_BYPASS_BAD_PKT_LEN_SMASK |
| 1853 | | SEND_CTXT_CHECK_ENABLE_DISALLOW_PBC_STATIC_RATE_CONTROL_SMASK | 1824 | | SEND_CTXT_CHECK_ENABLE_DISALLOW_PBC_STATIC_RATE_CONTROL_SMASK |
| 1854 | | SEND_CTXT_CHECK_ENABLE_DISALLOW_TOO_LONG_BYPASS_PACKETS_SMASK | 1825 | | SEND_CTXT_CHECK_ENABLE_DISALLOW_TOO_LONG_BYPASS_PACKETS_SMASK |
| @@ -1863,7 +1834,6 @@ static inline u64 hfi1_pkt_default_send_ctxt_mask(struct hfi1_devdata *dd, | |||
| 1863 | | SEND_CTXT_CHECK_ENABLE_CHECK_VL_MAPPING_SMASK | 1834 | | SEND_CTXT_CHECK_ENABLE_CHECK_VL_MAPPING_SMASK |
| 1864 | | SEND_CTXT_CHECK_ENABLE_CHECK_OPCODE_SMASK | 1835 | | SEND_CTXT_CHECK_ENABLE_CHECK_OPCODE_SMASK |
| 1865 | | SEND_CTXT_CHECK_ENABLE_CHECK_SLID_SMASK | 1836 | | SEND_CTXT_CHECK_ENABLE_CHECK_SLID_SMASK |
| 1866 | | SEND_CTXT_CHECK_ENABLE_CHECK_JOB_KEY_SMASK | ||
| 1867 | | SEND_CTXT_CHECK_ENABLE_CHECK_VL_SMASK | 1837 | | SEND_CTXT_CHECK_ENABLE_CHECK_VL_SMASK |
| 1868 | | SEND_CTXT_CHECK_ENABLE_CHECK_ENABLE_SMASK; | 1838 | | SEND_CTXT_CHECK_ENABLE_CHECK_ENABLE_SMASK; |
| 1869 | 1839 | ||
| @@ -1872,18 +1842,23 @@ static inline u64 hfi1_pkt_default_send_ctxt_mask(struct hfi1_devdata *dd, | |||
| 1872 | else | 1842 | else |
| 1873 | base_sc_integrity |= HFI1_PKT_KERNEL_SC_INTEGRITY; | 1843 | base_sc_integrity |= HFI1_PKT_KERNEL_SC_INTEGRITY; |
| 1874 | 1844 | ||
| 1875 | if (is_ax(dd)) | 1845 | /* turn on send-side job key checks if !A0 */ |
| 1876 | /* turn off send-side job key checks - A0 */ | 1846 | if (!is_ax(dd)) |
| 1877 | return base_sc_integrity & | 1847 | base_sc_integrity |= SEND_CTXT_CHECK_ENABLE_CHECK_JOB_KEY_SMASK; |
| 1878 | ~SEND_CTXT_CHECK_ENABLE_CHECK_JOB_KEY_SMASK; | 1848 | |
| 1879 | return base_sc_integrity; | 1849 | return base_sc_integrity; |
| 1880 | } | 1850 | } |
| 1881 | 1851 | ||
| 1882 | static inline u64 hfi1_pkt_base_sdma_integrity(struct hfi1_devdata *dd) | 1852 | static inline u64 hfi1_pkt_base_sdma_integrity(struct hfi1_devdata *dd) |
| 1883 | { | 1853 | { |
| 1884 | u64 base_sdma_integrity = | 1854 | u64 base_sdma_integrity; |
| 1855 | |||
| 1856 | /* No integrity checks if HFI1_CAP_NO_INTEGRITY is set */ | ||
| 1857 | if (HFI1_CAP_IS_KSET(NO_INTEGRITY)) | ||
| 1858 | return 0; | ||
| 1859 | |||
| 1860 | base_sdma_integrity = | ||
| 1885 | SEND_DMA_CHECK_ENABLE_DISALLOW_BYPASS_BAD_PKT_LEN_SMASK | 1861 | SEND_DMA_CHECK_ENABLE_DISALLOW_BYPASS_BAD_PKT_LEN_SMASK |
| 1886 | | SEND_DMA_CHECK_ENABLE_DISALLOW_PBC_STATIC_RATE_CONTROL_SMASK | ||
| 1887 | | SEND_DMA_CHECK_ENABLE_DISALLOW_TOO_LONG_BYPASS_PACKETS_SMASK | 1862 | | SEND_DMA_CHECK_ENABLE_DISALLOW_TOO_LONG_BYPASS_PACKETS_SMASK |
| 1888 | | SEND_DMA_CHECK_ENABLE_DISALLOW_TOO_LONG_IB_PACKETS_SMASK | 1863 | | SEND_DMA_CHECK_ENABLE_DISALLOW_TOO_LONG_IB_PACKETS_SMASK |
| 1889 | | SEND_DMA_CHECK_ENABLE_DISALLOW_BAD_PKT_LEN_SMASK | 1864 | | SEND_DMA_CHECK_ENABLE_DISALLOW_BAD_PKT_LEN_SMASK |
| @@ -1895,14 +1870,18 @@ static inline u64 hfi1_pkt_base_sdma_integrity(struct hfi1_devdata *dd) | |||
| 1895 | | SEND_DMA_CHECK_ENABLE_CHECK_VL_MAPPING_SMASK | 1870 | | SEND_DMA_CHECK_ENABLE_CHECK_VL_MAPPING_SMASK |
| 1896 | | SEND_DMA_CHECK_ENABLE_CHECK_OPCODE_SMASK | 1871 | | SEND_DMA_CHECK_ENABLE_CHECK_OPCODE_SMASK |
| 1897 | | SEND_DMA_CHECK_ENABLE_CHECK_SLID_SMASK | 1872 | | SEND_DMA_CHECK_ENABLE_CHECK_SLID_SMASK |
| 1898 | | SEND_DMA_CHECK_ENABLE_CHECK_JOB_KEY_SMASK | ||
| 1899 | | SEND_DMA_CHECK_ENABLE_CHECK_VL_SMASK | 1873 | | SEND_DMA_CHECK_ENABLE_CHECK_VL_SMASK |
| 1900 | | SEND_DMA_CHECK_ENABLE_CHECK_ENABLE_SMASK; | 1874 | | SEND_DMA_CHECK_ENABLE_CHECK_ENABLE_SMASK; |
| 1901 | 1875 | ||
| 1902 | if (is_ax(dd)) | 1876 | if (!HFI1_CAP_IS_KSET(STATIC_RATE_CTRL)) |
| 1903 | /* turn off send-side job key checks - A0 */ | 1877 | base_sdma_integrity |= |
| 1904 | return base_sdma_integrity & | 1878 | SEND_DMA_CHECK_ENABLE_DISALLOW_PBC_STATIC_RATE_CONTROL_SMASK; |
| 1905 | ~SEND_DMA_CHECK_ENABLE_CHECK_JOB_KEY_SMASK; | 1879 | |
| 1880 | /* turn on send-side job key checks if !A0 */ | ||
| 1881 | if (!is_ax(dd)) | ||
| 1882 | base_sdma_integrity |= | ||
| 1883 | SEND_DMA_CHECK_ENABLE_CHECK_JOB_KEY_SMASK; | ||
| 1884 | |||
| 1906 | return base_sdma_integrity; | 1885 | return base_sdma_integrity; |
| 1907 | } | 1886 | } |
| 1908 | 1887 | ||
diff --git a/drivers/infiniband/hw/hfi1/init.c b/drivers/infiniband/hw/hfi1/init.c index 60db61536fed..e3b5bc93bc70 100644 --- a/drivers/infiniband/hw/hfi1/init.c +++ b/drivers/infiniband/hw/hfi1/init.c | |||
| @@ -144,6 +144,8 @@ int hfi1_create_ctxts(struct hfi1_devdata *dd) | |||
| 144 | struct hfi1_ctxtdata *rcd; | 144 | struct hfi1_ctxtdata *rcd; |
| 145 | 145 | ||
| 146 | ppd = dd->pport + (i % dd->num_pports); | 146 | ppd = dd->pport + (i % dd->num_pports); |
| 147 | |||
| 148 | /* dd->rcd[i] gets assigned inside the callee */ | ||
| 147 | rcd = hfi1_create_ctxtdata(ppd, i, dd->node); | 149 | rcd = hfi1_create_ctxtdata(ppd, i, dd->node); |
| 148 | if (!rcd) { | 150 | if (!rcd) { |
| 149 | dd_dev_err(dd, | 151 | dd_dev_err(dd, |
| @@ -169,8 +171,6 @@ int hfi1_create_ctxts(struct hfi1_devdata *dd) | |||
| 169 | if (!rcd->sc) { | 171 | if (!rcd->sc) { |
| 170 | dd_dev_err(dd, | 172 | dd_dev_err(dd, |
| 171 | "Unable to allocate kernel send context, failing\n"); | 173 | "Unable to allocate kernel send context, failing\n"); |
| 172 | dd->rcd[rcd->ctxt] = NULL; | ||
| 173 | hfi1_free_ctxtdata(dd, rcd); | ||
| 174 | goto nomem; | 174 | goto nomem; |
| 175 | } | 175 | } |
| 176 | 176 | ||
| @@ -178,9 +178,6 @@ int hfi1_create_ctxts(struct hfi1_devdata *dd) | |||
| 178 | if (ret < 0) { | 178 | if (ret < 0) { |
| 179 | dd_dev_err(dd, | 179 | dd_dev_err(dd, |
| 180 | "Failed to setup kernel receive context, failing\n"); | 180 | "Failed to setup kernel receive context, failing\n"); |
| 181 | sc_free(rcd->sc); | ||
| 182 | dd->rcd[rcd->ctxt] = NULL; | ||
| 183 | hfi1_free_ctxtdata(dd, rcd); | ||
| 184 | ret = -EFAULT; | 181 | ret = -EFAULT; |
| 185 | goto bail; | 182 | goto bail; |
| 186 | } | 183 | } |
| @@ -196,6 +193,10 @@ int hfi1_create_ctxts(struct hfi1_devdata *dd) | |||
| 196 | nomem: | 193 | nomem: |
| 197 | ret = -ENOMEM; | 194 | ret = -ENOMEM; |
| 198 | bail: | 195 | bail: |
| 196 | if (dd->rcd) { | ||
| 197 | for (i = 0; i < dd->num_rcv_contexts; ++i) | ||
| 198 | hfi1_free_ctxtdata(dd, dd->rcd[i]); | ||
| 199 | } | ||
| 199 | kfree(dd->rcd); | 200 | kfree(dd->rcd); |
| 200 | dd->rcd = NULL; | 201 | dd->rcd = NULL; |
| 201 | return ret; | 202 | return ret; |
| @@ -216,7 +217,7 @@ struct hfi1_ctxtdata *hfi1_create_ctxtdata(struct hfi1_pportdata *ppd, u32 ctxt, | |||
| 216 | dd->num_rcv_contexts - dd->first_user_ctxt) | 217 | dd->num_rcv_contexts - dd->first_user_ctxt) |
| 217 | kctxt_ngroups = (dd->rcv_entries.nctxt_extra - | 218 | kctxt_ngroups = (dd->rcv_entries.nctxt_extra - |
| 218 | (dd->num_rcv_contexts - dd->first_user_ctxt)); | 219 | (dd->num_rcv_contexts - dd->first_user_ctxt)); |
| 219 | rcd = kzalloc(sizeof(*rcd), GFP_KERNEL); | 220 | rcd = kzalloc_node(sizeof(*rcd), GFP_KERNEL, numa); |
| 220 | if (rcd) { | 221 | if (rcd) { |
| 221 | u32 rcvtids, max_entries; | 222 | u32 rcvtids, max_entries; |
| 222 | 223 | ||
| @@ -261,13 +262,6 @@ struct hfi1_ctxtdata *hfi1_create_ctxtdata(struct hfi1_pportdata *ppd, u32 ctxt, | |||
| 261 | } | 262 | } |
| 262 | rcd->eager_base = base * dd->rcv_entries.group_size; | 263 | rcd->eager_base = base * dd->rcv_entries.group_size; |
| 263 | 264 | ||
| 264 | /* Validate and initialize Rcv Hdr Q variables */ | ||
| 265 | if (rcvhdrcnt % HDRQ_INCREMENT) { | ||
| 266 | dd_dev_err(dd, | ||
| 267 | "ctxt%u: header queue count %d must be divisible by %lu\n", | ||
| 268 | rcd->ctxt, rcvhdrcnt, HDRQ_INCREMENT); | ||
| 269 | goto bail; | ||
| 270 | } | ||
| 271 | rcd->rcvhdrq_cnt = rcvhdrcnt; | 265 | rcd->rcvhdrq_cnt = rcvhdrcnt; |
| 272 | rcd->rcvhdrqentsize = hfi1_hdrq_entsize; | 266 | rcd->rcvhdrqentsize = hfi1_hdrq_entsize; |
| 273 | /* | 267 | /* |
| @@ -506,7 +500,6 @@ void hfi1_init_pportdata(struct pci_dev *pdev, struct hfi1_pportdata *ppd, | |||
| 506 | INIT_WORK(&ppd->qsfp_info.qsfp_work, qsfp_event); | 500 | INIT_WORK(&ppd->qsfp_info.qsfp_work, qsfp_event); |
| 507 | 501 | ||
| 508 | mutex_init(&ppd->hls_lock); | 502 | mutex_init(&ppd->hls_lock); |
| 509 | spin_lock_init(&ppd->sdma_alllock); | ||
| 510 | spin_lock_init(&ppd->qsfp_info.qsfp_lock); | 503 | spin_lock_init(&ppd->qsfp_info.qsfp_lock); |
| 511 | 504 | ||
| 512 | ppd->qsfp_info.ppd = ppd; | 505 | ppd->qsfp_info.ppd = ppd; |
| @@ -1399,28 +1392,43 @@ static void postinit_cleanup(struct hfi1_devdata *dd) | |||
| 1399 | hfi1_free_devdata(dd); | 1392 | hfi1_free_devdata(dd); |
| 1400 | } | 1393 | } |
| 1401 | 1394 | ||
| 1395 | static int init_validate_rcvhdrcnt(struct device *dev, uint thecnt) | ||
| 1396 | { | ||
| 1397 | if (thecnt <= HFI1_MIN_HDRQ_EGRBUF_CNT) { | ||
| 1398 | hfi1_early_err(dev, "Receive header queue count too small\n"); | ||
| 1399 | return -EINVAL; | ||
| 1400 | } | ||
| 1401 | |||
| 1402 | if (thecnt > HFI1_MAX_HDRQ_EGRBUF_CNT) { | ||
| 1403 | hfi1_early_err(dev, | ||
| 1404 | "Receive header queue count cannot be greater than %u\n", | ||
| 1405 | HFI1_MAX_HDRQ_EGRBUF_CNT); | ||
| 1406 | return -EINVAL; | ||
| 1407 | } | ||
| 1408 | |||
| 1409 | if (thecnt % HDRQ_INCREMENT) { | ||
| 1410 | hfi1_early_err(dev, "Receive header queue count %d must be divisible by %lu\n", | ||
| 1411 | thecnt, HDRQ_INCREMENT); | ||
| 1412 | return -EINVAL; | ||
| 1413 | } | ||
| 1414 | |||
| 1415 | return 0; | ||
| 1416 | } | ||
| 1417 | |||
| 1402 | static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) | 1418 | static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) |
| 1403 | { | 1419 | { |
| 1404 | int ret = 0, j, pidx, initfail; | 1420 | int ret = 0, j, pidx, initfail; |
| 1405 | struct hfi1_devdata *dd = ERR_PTR(-EINVAL); | 1421 | struct hfi1_devdata *dd; |
| 1406 | struct hfi1_pportdata *ppd; | 1422 | struct hfi1_pportdata *ppd; |
| 1407 | 1423 | ||
| 1408 | /* First, lock the non-writable module parameters */ | 1424 | /* First, lock the non-writable module parameters */ |
| 1409 | HFI1_CAP_LOCK(); | 1425 | HFI1_CAP_LOCK(); |
| 1410 | 1426 | ||
| 1411 | /* Validate some global module parameters */ | 1427 | /* Validate some global module parameters */ |
| 1412 | if (rcvhdrcnt <= HFI1_MIN_HDRQ_EGRBUF_CNT) { | 1428 | ret = init_validate_rcvhdrcnt(&pdev->dev, rcvhdrcnt); |
| 1413 | hfi1_early_err(&pdev->dev, "Header queue count too small\n"); | 1429 | if (ret) |
| 1414 | ret = -EINVAL; | ||
| 1415 | goto bail; | ||
| 1416 | } | ||
| 1417 | if (rcvhdrcnt > HFI1_MAX_HDRQ_EGRBUF_CNT) { | ||
| 1418 | hfi1_early_err(&pdev->dev, | ||
| 1419 | "Receive header queue count cannot be greater than %u\n", | ||
| 1420 | HFI1_MAX_HDRQ_EGRBUF_CNT); | ||
| 1421 | ret = -EINVAL; | ||
| 1422 | goto bail; | 1430 | goto bail; |
| 1423 | } | 1431 | |
| 1424 | /* use the encoding function as a sanitization check */ | 1432 | /* use the encoding function as a sanitization check */ |
| 1425 | if (!encode_rcv_header_entry_size(hfi1_hdrq_entsize)) { | 1433 | if (!encode_rcv_header_entry_size(hfi1_hdrq_entsize)) { |
| 1426 | hfi1_early_err(&pdev->dev, "Invalid HdrQ Entry size %u\n", | 1434 | hfi1_early_err(&pdev->dev, "Invalid HdrQ Entry size %u\n", |
| @@ -1461,26 +1469,25 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
| 1461 | if (ret) | 1469 | if (ret) |
| 1462 | goto bail; | 1470 | goto bail; |
| 1463 | 1471 | ||
| 1464 | /* | 1472 | if (!(ent->device == PCI_DEVICE_ID_INTEL0 || |
| 1465 | * Do device-specific initialization, function table setup, dd | 1473 | ent->device == PCI_DEVICE_ID_INTEL1)) { |
| 1466 | * allocation, etc. | ||
| 1467 | */ | ||
| 1468 | switch (ent->device) { | ||
| 1469 | case PCI_DEVICE_ID_INTEL0: | ||
| 1470 | case PCI_DEVICE_ID_INTEL1: | ||
| 1471 | dd = hfi1_init_dd(pdev, ent); | ||
| 1472 | break; | ||
| 1473 | default: | ||
| 1474 | hfi1_early_err(&pdev->dev, | 1474 | hfi1_early_err(&pdev->dev, |
| 1475 | "Failing on unknown Intel deviceid 0x%x\n", | 1475 | "Failing on unknown Intel deviceid 0x%x\n", |
| 1476 | ent->device); | 1476 | ent->device); |
| 1477 | ret = -ENODEV; | 1477 | ret = -ENODEV; |
| 1478 | goto clean_bail; | ||
| 1478 | } | 1479 | } |
| 1479 | 1480 | ||
| 1480 | if (IS_ERR(dd)) | 1481 | /* |
| 1482 | * Do device-specific initialization, function table setup, dd | ||
| 1483 | * allocation, etc. | ||
| 1484 | */ | ||
| 1485 | dd = hfi1_init_dd(pdev, ent); | ||
| 1486 | |||
| 1487 | if (IS_ERR(dd)) { | ||
| 1481 | ret = PTR_ERR(dd); | 1488 | ret = PTR_ERR(dd); |
| 1482 | if (ret) | ||
| 1483 | goto clean_bail; /* error already printed */ | 1489 | goto clean_bail; /* error already printed */ |
| 1490 | } | ||
| 1484 | 1491 | ||
| 1485 | ret = create_workqueues(dd); | 1492 | ret = create_workqueues(dd); |
| 1486 | if (ret) | 1493 | if (ret) |
| @@ -1538,12 +1545,31 @@ bail: | |||
| 1538 | return ret; | 1545 | return ret; |
| 1539 | } | 1546 | } |
| 1540 | 1547 | ||
| 1548 | static void wait_for_clients(struct hfi1_devdata *dd) | ||
| 1549 | { | ||
| 1550 | /* | ||
| 1551 | * Remove the device init value and complete the device if there is | ||
| 1552 | * no clients or wait for active clients to finish. | ||
| 1553 | */ | ||
| 1554 | if (atomic_dec_and_test(&dd->user_refcount)) | ||
| 1555 | complete(&dd->user_comp); | ||
| 1556 | |||
| 1557 | wait_for_completion(&dd->user_comp); | ||
| 1558 | } | ||
| 1559 | |||
| 1541 | static void remove_one(struct pci_dev *pdev) | 1560 | static void remove_one(struct pci_dev *pdev) |
| 1542 | { | 1561 | { |
| 1543 | struct hfi1_devdata *dd = pci_get_drvdata(pdev); | 1562 | struct hfi1_devdata *dd = pci_get_drvdata(pdev); |
| 1544 | 1563 | ||
| 1545 | /* close debugfs files before ib unregister */ | 1564 | /* close debugfs files before ib unregister */ |
| 1546 | hfi1_dbg_ibdev_exit(&dd->verbs_dev); | 1565 | hfi1_dbg_ibdev_exit(&dd->verbs_dev); |
| 1566 | |||
| 1567 | /* remove the /dev hfi1 interface */ | ||
| 1568 | hfi1_device_remove(dd); | ||
| 1569 | |||
| 1570 | /* wait for existing user space clients to finish */ | ||
| 1571 | wait_for_clients(dd); | ||
| 1572 | |||
| 1547 | /* unregister from IB core */ | 1573 | /* unregister from IB core */ |
| 1548 | hfi1_unregister_ib_device(dd); | 1574 | hfi1_unregister_ib_device(dd); |
| 1549 | 1575 | ||
| @@ -1558,8 +1584,6 @@ static void remove_one(struct pci_dev *pdev) | |||
| 1558 | /* wait until all of our (qsfp) queue_work() calls complete */ | 1584 | /* wait until all of our (qsfp) queue_work() calls complete */ |
| 1559 | flush_workqueue(ib_wq); | 1585 | flush_workqueue(ib_wq); |
| 1560 | 1586 | ||
| 1561 | hfi1_device_remove(dd); | ||
| 1562 | |||
| 1563 | postinit_cleanup(dd); | 1587 | postinit_cleanup(dd); |
| 1564 | } | 1588 | } |
| 1565 | 1589 | ||
diff --git a/drivers/infiniband/hw/hfi1/pcie.c b/drivers/infiniband/hw/hfi1/pcie.c index 89c68da1c273..4ac8f330c5cb 100644 --- a/drivers/infiniband/hw/hfi1/pcie.c +++ b/drivers/infiniband/hw/hfi1/pcie.c | |||
| @@ -157,8 +157,7 @@ void hfi1_pcie_cleanup(struct pci_dev *pdev) | |||
| 157 | * fields required to re-initialize after a chip reset, or for | 157 | * fields required to re-initialize after a chip reset, or for |
| 158 | * various other purposes | 158 | * various other purposes |
| 159 | */ | 159 | */ |
| 160 | int hfi1_pcie_ddinit(struct hfi1_devdata *dd, struct pci_dev *pdev, | 160 | int hfi1_pcie_ddinit(struct hfi1_devdata *dd, struct pci_dev *pdev) |
| 161 | const struct pci_device_id *ent) | ||
| 162 | { | 161 | { |
| 163 | unsigned long len; | 162 | unsigned long len; |
| 164 | resource_size_t addr; | 163 | resource_size_t addr; |
diff --git a/drivers/infiniband/hw/hfi1/pio.c b/drivers/infiniband/hw/hfi1/pio.c index 50a3a36d9363..d89b8745d4c1 100644 --- a/drivers/infiniband/hw/hfi1/pio.c +++ b/drivers/infiniband/hw/hfi1/pio.c | |||
| @@ -668,19 +668,12 @@ void sc_set_cr_threshold(struct send_context *sc, u32 new_threshold) | |||
| 668 | void set_pio_integrity(struct send_context *sc) | 668 | void set_pio_integrity(struct send_context *sc) |
| 669 | { | 669 | { |
| 670 | struct hfi1_devdata *dd = sc->dd; | 670 | struct hfi1_devdata *dd = sc->dd; |
| 671 | u64 reg = 0; | ||
| 672 | u32 hw_context = sc->hw_context; | 671 | u32 hw_context = sc->hw_context; |
| 673 | int type = sc->type; | 672 | int type = sc->type; |
| 674 | 673 | ||
| 675 | /* | 674 | write_kctxt_csr(dd, hw_context, |
| 676 | * No integrity checks if HFI1_CAP_NO_INTEGRITY is set, or if | 675 | SC(CHECK_ENABLE), |
| 677 | * we're snooping. | 676 | hfi1_pkt_default_send_ctxt_mask(dd, type)); |
| 678 | */ | ||
| 679 | if (likely(!HFI1_CAP_IS_KSET(NO_INTEGRITY)) && | ||
| 680 | dd->hfi1_snoop.mode_flag != HFI1_PORT_SNOOP_MODE) | ||
| 681 | reg = hfi1_pkt_default_send_ctxt_mask(dd, type); | ||
| 682 | |||
| 683 | write_kctxt_csr(dd, hw_context, SC(CHECK_ENABLE), reg); | ||
| 684 | } | 677 | } |
| 685 | 678 | ||
| 686 | static u32 get_buffers_allocated(struct send_context *sc) | 679 | static u32 get_buffers_allocated(struct send_context *sc) |
diff --git a/drivers/infiniband/hw/hfi1/rc.c b/drivers/infiniband/hw/hfi1/rc.c index 8bc5013f39a1..83198a8a8797 100644 --- a/drivers/infiniband/hw/hfi1/rc.c +++ b/drivers/infiniband/hw/hfi1/rc.c | |||
| @@ -89,7 +89,7 @@ void hfi1_add_rnr_timer(struct rvt_qp *qp, u32 to) | |||
| 89 | 89 | ||
| 90 | lockdep_assert_held(&qp->s_lock); | 90 | lockdep_assert_held(&qp->s_lock); |
| 91 | qp->s_flags |= RVT_S_WAIT_RNR; | 91 | qp->s_flags |= RVT_S_WAIT_RNR; |
| 92 | qp->s_timer.expires = jiffies + usecs_to_jiffies(to); | 92 | priv->s_rnr_timer.expires = jiffies + usecs_to_jiffies(to); |
| 93 | add_timer(&priv->s_rnr_timer); | 93 | add_timer(&priv->s_rnr_timer); |
| 94 | } | 94 | } |
| 95 | 95 | ||
diff --git a/drivers/infiniband/hw/hfi1/sdma.c b/drivers/infiniband/hw/hfi1/sdma.c index fd39bcaa062d..9cbe52d21077 100644 --- a/drivers/infiniband/hw/hfi1/sdma.c +++ b/drivers/infiniband/hw/hfi1/sdma.c | |||
| @@ -2009,11 +2009,6 @@ static void sdma_hw_start_up(struct sdma_engine *sde) | |||
| 2009 | write_sde_csr(sde, SD(ENG_ERR_CLEAR), reg); | 2009 | write_sde_csr(sde, SD(ENG_ERR_CLEAR), reg); |
| 2010 | } | 2010 | } |
| 2011 | 2011 | ||
| 2012 | #define CLEAR_STATIC_RATE_CONTROL_SMASK(r) \ | ||
| 2013 | (r &= ~SEND_DMA_CHECK_ENABLE_DISALLOW_PBC_STATIC_RATE_CONTROL_SMASK) | ||
| 2014 | |||
| 2015 | #define SET_STATIC_RATE_CONTROL_SMASK(r) \ | ||
| 2016 | (r |= SEND_DMA_CHECK_ENABLE_DISALLOW_PBC_STATIC_RATE_CONTROL_SMASK) | ||
| 2017 | /* | 2012 | /* |
| 2018 | * set_sdma_integrity | 2013 | * set_sdma_integrity |
| 2019 | * | 2014 | * |
| @@ -2022,19 +2017,9 @@ static void sdma_hw_start_up(struct sdma_engine *sde) | |||
| 2022 | static void set_sdma_integrity(struct sdma_engine *sde) | 2017 | static void set_sdma_integrity(struct sdma_engine *sde) |
| 2023 | { | 2018 | { |
| 2024 | struct hfi1_devdata *dd = sde->dd; | 2019 | struct hfi1_devdata *dd = sde->dd; |
| 2025 | u64 reg; | ||
| 2026 | |||
| 2027 | if (unlikely(HFI1_CAP_IS_KSET(NO_INTEGRITY))) | ||
| 2028 | return; | ||
| 2029 | |||
| 2030 | reg = hfi1_pkt_base_sdma_integrity(dd); | ||
| 2031 | |||
| 2032 | if (HFI1_CAP_IS_KSET(STATIC_RATE_CTRL)) | ||
| 2033 | CLEAR_STATIC_RATE_CONTROL_SMASK(reg); | ||
| 2034 | else | ||
| 2035 | SET_STATIC_RATE_CONTROL_SMASK(reg); | ||
| 2036 | 2020 | ||
| 2037 | write_sde_csr(sde, SD(CHECK_ENABLE), reg); | 2021 | write_sde_csr(sde, SD(CHECK_ENABLE), |
| 2022 | hfi1_pkt_base_sdma_integrity(dd)); | ||
| 2038 | } | 2023 | } |
| 2039 | 2024 | ||
| 2040 | static void init_sdma_regs( | 2025 | static void init_sdma_regs( |
diff --git a/drivers/infiniband/hw/hfi1/sysfs.c b/drivers/infiniband/hw/hfi1/sysfs.c index edba22461a9c..919a5474e651 100644 --- a/drivers/infiniband/hw/hfi1/sysfs.c +++ b/drivers/infiniband/hw/hfi1/sysfs.c | |||
| @@ -49,7 +49,6 @@ | |||
| 49 | #include "hfi.h" | 49 | #include "hfi.h" |
| 50 | #include "mad.h" | 50 | #include "mad.h" |
| 51 | #include "trace.h" | 51 | #include "trace.h" |
| 52 | #include "affinity.h" | ||
| 53 | 52 | ||
| 54 | /* | 53 | /* |
| 55 | * Start of per-port congestion control structures and support code | 54 | * Start of per-port congestion control structures and support code |
| @@ -623,27 +622,6 @@ static ssize_t show_tempsense(struct device *device, | |||
| 623 | return ret; | 622 | return ret; |
| 624 | } | 623 | } |
| 625 | 624 | ||
| 626 | static ssize_t show_sdma_affinity(struct device *device, | ||
| 627 | struct device_attribute *attr, char *buf) | ||
| 628 | { | ||
| 629 | struct hfi1_ibdev *dev = | ||
| 630 | container_of(device, struct hfi1_ibdev, rdi.ibdev.dev); | ||
| 631 | struct hfi1_devdata *dd = dd_from_dev(dev); | ||
| 632 | |||
| 633 | return hfi1_get_sdma_affinity(dd, buf); | ||
| 634 | } | ||
| 635 | |||
| 636 | static ssize_t store_sdma_affinity(struct device *device, | ||
| 637 | struct device_attribute *attr, | ||
| 638 | const char *buf, size_t count) | ||
| 639 | { | ||
| 640 | struct hfi1_ibdev *dev = | ||
| 641 | container_of(device, struct hfi1_ibdev, rdi.ibdev.dev); | ||
| 642 | struct hfi1_devdata *dd = dd_from_dev(dev); | ||
| 643 | |||
| 644 | return hfi1_set_sdma_affinity(dd, buf, count); | ||
| 645 | } | ||
| 646 | |||
| 647 | /* | 625 | /* |
| 648 | * end of per-unit (or driver, in some cases, but replicated | 626 | * end of per-unit (or driver, in some cases, but replicated |
| 649 | * per unit) functions | 627 | * per unit) functions |
| @@ -658,8 +636,6 @@ static DEVICE_ATTR(serial, S_IRUGO, show_serial, NULL); | |||
| 658 | static DEVICE_ATTR(boardversion, S_IRUGO, show_boardversion, NULL); | 636 | static DEVICE_ATTR(boardversion, S_IRUGO, show_boardversion, NULL); |
| 659 | static DEVICE_ATTR(tempsense, S_IRUGO, show_tempsense, NULL); | 637 | static DEVICE_ATTR(tempsense, S_IRUGO, show_tempsense, NULL); |
| 660 | static DEVICE_ATTR(chip_reset, S_IWUSR, NULL, store_chip_reset); | 638 | static DEVICE_ATTR(chip_reset, S_IWUSR, NULL, store_chip_reset); |
| 661 | static DEVICE_ATTR(sdma_affinity, S_IWUSR | S_IRUGO, show_sdma_affinity, | ||
| 662 | store_sdma_affinity); | ||
| 663 | 639 | ||
| 664 | static struct device_attribute *hfi1_attributes[] = { | 640 | static struct device_attribute *hfi1_attributes[] = { |
| 665 | &dev_attr_hw_rev, | 641 | &dev_attr_hw_rev, |
| @@ -670,7 +646,6 @@ static struct device_attribute *hfi1_attributes[] = { | |||
| 670 | &dev_attr_boardversion, | 646 | &dev_attr_boardversion, |
| 671 | &dev_attr_tempsense, | 647 | &dev_attr_tempsense, |
| 672 | &dev_attr_chip_reset, | 648 | &dev_attr_chip_reset, |
| 673 | &dev_attr_sdma_affinity, | ||
| 674 | }; | 649 | }; |
| 675 | 650 | ||
| 676 | int hfi1_create_port_files(struct ib_device *ibdev, u8 port_num, | 651 | int hfi1_create_port_files(struct ib_device *ibdev, u8 port_num, |
diff --git a/drivers/infiniband/hw/hfi1/trace_rx.h b/drivers/infiniband/hw/hfi1/trace_rx.h index 11e02b228922..f77e59fb43fe 100644 --- a/drivers/infiniband/hw/hfi1/trace_rx.h +++ b/drivers/infiniband/hw/hfi1/trace_rx.h | |||
| @@ -253,66 +253,6 @@ TRACE_EVENT(hfi1_mmu_invalidate, | |||
| 253 | ) | 253 | ) |
| 254 | ); | 254 | ); |
| 255 | 255 | ||
| 256 | #define SNOOP_PRN \ | ||
| 257 | "slid %.4x dlid %.4x qpn 0x%.6x opcode 0x%.2x,%s " \ | ||
| 258 | "svc lvl %d pkey 0x%.4x [header = %d bytes] [data = %d bytes]" | ||
| 259 | |||
| 260 | TRACE_EVENT(snoop_capture, | ||
| 261 | TP_PROTO(struct hfi1_devdata *dd, | ||
| 262 | int hdr_len, | ||
| 263 | struct ib_header *hdr, | ||
| 264 | int data_len, | ||
| 265 | void *data), | ||
| 266 | TP_ARGS(dd, hdr_len, hdr, data_len, data), | ||
| 267 | TP_STRUCT__entry( | ||
| 268 | DD_DEV_ENTRY(dd) | ||
| 269 | __field(u16, slid) | ||
| 270 | __field(u16, dlid) | ||
| 271 | __field(u32, qpn) | ||
| 272 | __field(u8, opcode) | ||
| 273 | __field(u8, sl) | ||
| 274 | __field(u16, pkey) | ||
| 275 | __field(u32, hdr_len) | ||
| 276 | __field(u32, data_len) | ||
| 277 | __field(u8, lnh) | ||
| 278 | __dynamic_array(u8, raw_hdr, hdr_len) | ||
| 279 | __dynamic_array(u8, raw_pkt, data_len) | ||
| 280 | ), | ||
| 281 | TP_fast_assign( | ||
| 282 | struct ib_other_headers *ohdr; | ||
| 283 | |||
| 284 | __entry->lnh = (u8)(be16_to_cpu(hdr->lrh[0]) & 3); | ||
| 285 | if (__entry->lnh == HFI1_LRH_BTH) | ||
| 286 | ohdr = &hdr->u.oth; | ||
| 287 | else | ||
| 288 | ohdr = &hdr->u.l.oth; | ||
| 289 | DD_DEV_ASSIGN(dd); | ||
| 290 | __entry->slid = be16_to_cpu(hdr->lrh[3]); | ||
| 291 | __entry->dlid = be16_to_cpu(hdr->lrh[1]); | ||
| 292 | __entry->qpn = be32_to_cpu(ohdr->bth[1]) & RVT_QPN_MASK; | ||
| 293 | __entry->opcode = (be32_to_cpu(ohdr->bth[0]) >> 24) & 0xff; | ||
| 294 | __entry->sl = (u8)(be16_to_cpu(hdr->lrh[0]) >> 4) & 0xf; | ||
| 295 | __entry->pkey = be32_to_cpu(ohdr->bth[0]) & 0xffff; | ||
| 296 | __entry->hdr_len = hdr_len; | ||
| 297 | __entry->data_len = data_len; | ||
| 298 | memcpy(__get_dynamic_array(raw_hdr), hdr, hdr_len); | ||
| 299 | memcpy(__get_dynamic_array(raw_pkt), data, data_len); | ||
| 300 | ), | ||
| 301 | TP_printk( | ||
| 302 | "[%s] " SNOOP_PRN, | ||
| 303 | __get_str(dev), | ||
| 304 | __entry->slid, | ||
| 305 | __entry->dlid, | ||
| 306 | __entry->qpn, | ||
| 307 | __entry->opcode, | ||
| 308 | show_ib_opcode(__entry->opcode), | ||
| 309 | __entry->sl, | ||
| 310 | __entry->pkey, | ||
| 311 | __entry->hdr_len, | ||
| 312 | __entry->data_len | ||
| 313 | ) | ||
| 314 | ); | ||
| 315 | |||
| 316 | #endif /* __HFI1_TRACE_RX_H */ | 256 | #endif /* __HFI1_TRACE_RX_H */ |
| 317 | 257 | ||
| 318 | #undef TRACE_INCLUDE_PATH | 258 | #undef TRACE_INCLUDE_PATH |
diff --git a/drivers/infiniband/hw/hfi1/user_sdma.c b/drivers/infiniband/hw/hfi1/user_sdma.c index a761f804111e..77697d690f3e 100644 --- a/drivers/infiniband/hw/hfi1/user_sdma.c +++ b/drivers/infiniband/hw/hfi1/user_sdma.c | |||
| @@ -1144,7 +1144,7 @@ static int pin_vector_pages(struct user_sdma_request *req, | |||
| 1144 | rb_node = hfi1_mmu_rb_extract(pq->handler, | 1144 | rb_node = hfi1_mmu_rb_extract(pq->handler, |
| 1145 | (unsigned long)iovec->iov.iov_base, | 1145 | (unsigned long)iovec->iov.iov_base, |
| 1146 | iovec->iov.iov_len); | 1146 | iovec->iov.iov_len); |
| 1147 | if (rb_node && !IS_ERR(rb_node)) | 1147 | if (rb_node) |
| 1148 | node = container_of(rb_node, struct sdma_mmu_node, rb); | 1148 | node = container_of(rb_node, struct sdma_mmu_node, rb); |
| 1149 | else | 1149 | else |
| 1150 | rb_node = NULL; | 1150 | rb_node = NULL; |
diff --git a/drivers/infiniband/hw/mlx4/ah.c b/drivers/infiniband/hw/mlx4/ah.c index 5fc623362731..b9bf0759f10a 100644 --- a/drivers/infiniband/hw/mlx4/ah.c +++ b/drivers/infiniband/hw/mlx4/ah.c | |||
| @@ -102,7 +102,10 @@ static struct ib_ah *create_iboe_ah(struct ib_pd *pd, struct ib_ah_attr *ah_attr | |||
| 102 | if (vlan_tag < 0x1000) | 102 | if (vlan_tag < 0x1000) |
| 103 | vlan_tag |= (ah_attr->sl & 7) << 13; | 103 | vlan_tag |= (ah_attr->sl & 7) << 13; |
| 104 | ah->av.eth.port_pd = cpu_to_be32(to_mpd(pd)->pdn | (ah_attr->port_num << 24)); | 104 | ah->av.eth.port_pd = cpu_to_be32(to_mpd(pd)->pdn | (ah_attr->port_num << 24)); |
| 105 | ah->av.eth.gid_index = mlx4_ib_gid_index_to_real_index(ibdev, ah_attr->port_num, ah_attr->grh.sgid_index); | 105 | ret = mlx4_ib_gid_index_to_real_index(ibdev, ah_attr->port_num, ah_attr->grh.sgid_index); |
| 106 | if (ret < 0) | ||
| 107 | return ERR_PTR(ret); | ||
| 108 | ah->av.eth.gid_index = ret; | ||
| 106 | ah->av.eth.vlan = cpu_to_be16(vlan_tag); | 109 | ah->av.eth.vlan = cpu_to_be16(vlan_tag); |
| 107 | ah->av.eth.hop_limit = ah_attr->grh.hop_limit; | 110 | ah->av.eth.hop_limit = ah_attr->grh.hop_limit; |
| 108 | if (ah_attr->static_rate) { | 111 | if (ah_attr->static_rate) { |
diff --git a/drivers/infiniband/hw/mlx4/cq.c b/drivers/infiniband/hw/mlx4/cq.c index 1ea686b9e0f9..6a0fec357dae 100644 --- a/drivers/infiniband/hw/mlx4/cq.c +++ b/drivers/infiniband/hw/mlx4/cq.c | |||
| @@ -253,11 +253,14 @@ struct ib_cq *mlx4_ib_create_cq(struct ib_device *ibdev, | |||
| 253 | if (context) | 253 | if (context) |
| 254 | if (ib_copy_to_udata(udata, &cq->mcq.cqn, sizeof (__u32))) { | 254 | if (ib_copy_to_udata(udata, &cq->mcq.cqn, sizeof (__u32))) { |
| 255 | err = -EFAULT; | 255 | err = -EFAULT; |
| 256 | goto err_dbmap; | 256 | goto err_cq_free; |
| 257 | } | 257 | } |
| 258 | 258 | ||
| 259 | return &cq->ibcq; | 259 | return &cq->ibcq; |
| 260 | 260 | ||
| 261 | err_cq_free: | ||
| 262 | mlx4_cq_free(dev->dev, &cq->mcq); | ||
| 263 | |||
| 261 | err_dbmap: | 264 | err_dbmap: |
| 262 | if (context) | 265 | if (context) |
| 263 | mlx4_ib_db_unmap_user(to_mucontext(context), &cq->db); | 266 | mlx4_ib_db_unmap_user(to_mucontext(context), &cq->db); |
diff --git a/drivers/infiniband/hw/mlx5/cq.c b/drivers/infiniband/hw/mlx5/cq.c index 79d017baf6f4..fcd04b881ec1 100644 --- a/drivers/infiniband/hw/mlx5/cq.c +++ b/drivers/infiniband/hw/mlx5/cq.c | |||
| @@ -932,8 +932,7 @@ struct ib_cq *mlx5_ib_create_cq(struct ib_device *ibdev, | |||
| 932 | if (err) | 932 | if (err) |
| 933 | goto err_create; | 933 | goto err_create; |
| 934 | } else { | 934 | } else { |
| 935 | /* for now choose 64 bytes till we have a proper interface */ | 935 | cqe_size = cache_line_size() == 128 ? 128 : 64; |
| 936 | cqe_size = 64; | ||
| 937 | err = create_cq_kernel(dev, cq, entries, cqe_size, &cqb, | 936 | err = create_cq_kernel(dev, cq, entries, cqe_size, &cqb, |
| 938 | &index, &inlen); | 937 | &index, &inlen); |
| 939 | if (err) | 938 | if (err) |
diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c index 63036c731626..32b09f059c84 100644 --- a/drivers/infiniband/hw/mlx5/main.c +++ b/drivers/infiniband/hw/mlx5/main.c | |||
| @@ -2311,14 +2311,14 @@ static void mlx5_ib_event(struct mlx5_core_dev *dev, void *context, | |||
| 2311 | { | 2311 | { |
| 2312 | struct mlx5_ib_dev *ibdev = (struct mlx5_ib_dev *)context; | 2312 | struct mlx5_ib_dev *ibdev = (struct mlx5_ib_dev *)context; |
| 2313 | struct ib_event ibev; | 2313 | struct ib_event ibev; |
| 2314 | 2314 | bool fatal = false; | |
| 2315 | u8 port = 0; | 2315 | u8 port = 0; |
| 2316 | 2316 | ||
| 2317 | switch (event) { | 2317 | switch (event) { |
| 2318 | case MLX5_DEV_EVENT_SYS_ERROR: | 2318 | case MLX5_DEV_EVENT_SYS_ERROR: |
| 2319 | ibdev->ib_active = false; | ||
| 2320 | ibev.event = IB_EVENT_DEVICE_FATAL; | 2319 | ibev.event = IB_EVENT_DEVICE_FATAL; |
| 2321 | mlx5_ib_handle_internal_error(ibdev); | 2320 | mlx5_ib_handle_internal_error(ibdev); |
| 2321 | fatal = true; | ||
| 2322 | break; | 2322 | break; |
| 2323 | 2323 | ||
| 2324 | case MLX5_DEV_EVENT_PORT_UP: | 2324 | case MLX5_DEV_EVENT_PORT_UP: |
| @@ -2370,6 +2370,9 @@ static void mlx5_ib_event(struct mlx5_core_dev *dev, void *context, | |||
| 2370 | 2370 | ||
| 2371 | if (ibdev->ib_active) | 2371 | if (ibdev->ib_active) |
| 2372 | ib_dispatch_event(&ibev); | 2372 | ib_dispatch_event(&ibev); |
| 2373 | |||
| 2374 | if (fatal) | ||
| 2375 | ibdev->ib_active = false; | ||
| 2373 | } | 2376 | } |
| 2374 | 2377 | ||
| 2375 | static void get_ext_port_caps(struct mlx5_ib_dev *dev) | 2378 | static void get_ext_port_caps(struct mlx5_ib_dev *dev) |
| @@ -3115,7 +3118,7 @@ static void *mlx5_ib_add(struct mlx5_core_dev *mdev) | |||
| 3115 | } | 3118 | } |
| 3116 | err = init_node_data(dev); | 3119 | err = init_node_data(dev); |
| 3117 | if (err) | 3120 | if (err) |
| 3118 | goto err_dealloc; | 3121 | goto err_free_port; |
| 3119 | 3122 | ||
| 3120 | mutex_init(&dev->flow_db.lock); | 3123 | mutex_init(&dev->flow_db.lock); |
| 3121 | mutex_init(&dev->cap_mask_mutex); | 3124 | mutex_init(&dev->cap_mask_mutex); |
| @@ -3125,7 +3128,7 @@ static void *mlx5_ib_add(struct mlx5_core_dev *mdev) | |||
| 3125 | if (ll == IB_LINK_LAYER_ETHERNET) { | 3128 | if (ll == IB_LINK_LAYER_ETHERNET) { |
| 3126 | err = mlx5_enable_roce(dev); | 3129 | err = mlx5_enable_roce(dev); |
| 3127 | if (err) | 3130 | if (err) |
| 3128 | goto err_dealloc; | 3131 | goto err_free_port; |
| 3129 | } | 3132 | } |
| 3130 | 3133 | ||
| 3131 | err = create_dev_resources(&dev->devr); | 3134 | err = create_dev_resources(&dev->devr); |
diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/drivers/infiniband/hw/mlx5/mlx5_ib.h index dcdcd195fe53..7d689903c87c 100644 --- a/drivers/infiniband/hw/mlx5/mlx5_ib.h +++ b/drivers/infiniband/hw/mlx5/mlx5_ib.h | |||
| @@ -626,6 +626,8 @@ struct mlx5_ib_dev { | |||
| 626 | struct mlx5_ib_resources devr; | 626 | struct mlx5_ib_resources devr; |
| 627 | struct mlx5_mr_cache cache; | 627 | struct mlx5_mr_cache cache; |
| 628 | struct timer_list delay_timer; | 628 | struct timer_list delay_timer; |
| 629 | /* Prevents soft lock on massive reg MRs */ | ||
| 630 | struct mutex slow_path_mutex; | ||
| 629 | int fill_delay; | 631 | int fill_delay; |
| 630 | #ifdef CONFIG_INFINIBAND_ON_DEMAND_PAGING | 632 | #ifdef CONFIG_INFINIBAND_ON_DEMAND_PAGING |
| 631 | struct ib_odp_caps odp_caps; | 633 | struct ib_odp_caps odp_caps; |
diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c index d4ad672b905b..4e9012463c37 100644 --- a/drivers/infiniband/hw/mlx5/mr.c +++ b/drivers/infiniband/hw/mlx5/mr.c | |||
| @@ -610,6 +610,7 @@ int mlx5_mr_cache_init(struct mlx5_ib_dev *dev) | |||
| 610 | int err; | 610 | int err; |
| 611 | int i; | 611 | int i; |
| 612 | 612 | ||
| 613 | mutex_init(&dev->slow_path_mutex); | ||
| 613 | cache->wq = alloc_ordered_workqueue("mkey_cache", WQ_MEM_RECLAIM); | 614 | cache->wq = alloc_ordered_workqueue("mkey_cache", WQ_MEM_RECLAIM); |
| 614 | if (!cache->wq) { | 615 | if (!cache->wq) { |
| 615 | mlx5_ib_warn(dev, "failed to create work queue\n"); | 616 | mlx5_ib_warn(dev, "failed to create work queue\n"); |
| @@ -1182,9 +1183,12 @@ struct ib_mr *mlx5_ib_reg_user_mr(struct ib_pd *pd, u64 start, u64 length, | |||
| 1182 | goto error; | 1183 | goto error; |
| 1183 | } | 1184 | } |
| 1184 | 1185 | ||
| 1185 | if (!mr) | 1186 | if (!mr) { |
| 1187 | mutex_lock(&dev->slow_path_mutex); | ||
| 1186 | mr = reg_create(NULL, pd, virt_addr, length, umem, ncont, | 1188 | mr = reg_create(NULL, pd, virt_addr, length, umem, ncont, |
| 1187 | page_shift, access_flags); | 1189 | page_shift, access_flags); |
| 1190 | mutex_unlock(&dev->slow_path_mutex); | ||
| 1191 | } | ||
| 1188 | 1192 | ||
| 1189 | if (IS_ERR(mr)) { | 1193 | if (IS_ERR(mr)) { |
| 1190 | err = PTR_ERR(mr); | 1194 | err = PTR_ERR(mr); |
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index 7ce97daf26c6..d1e921816bfe 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c | |||
| @@ -2051,8 +2051,8 @@ struct ib_qp *mlx5_ib_create_qp(struct ib_pd *pd, | |||
| 2051 | 2051 | ||
| 2052 | mlx5_ib_dbg(dev, "ib qpnum 0x%x, mlx qpn 0x%x, rcqn 0x%x, scqn 0x%x\n", | 2052 | mlx5_ib_dbg(dev, "ib qpnum 0x%x, mlx qpn 0x%x, rcqn 0x%x, scqn 0x%x\n", |
| 2053 | qp->ibqp.qp_num, qp->trans_qp.base.mqp.qpn, | 2053 | qp->ibqp.qp_num, qp->trans_qp.base.mqp.qpn, |
| 2054 | to_mcq(init_attr->recv_cq)->mcq.cqn, | 2054 | init_attr->recv_cq ? to_mcq(init_attr->recv_cq)->mcq.cqn : -1, |
| 2055 | to_mcq(init_attr->send_cq)->mcq.cqn); | 2055 | init_attr->send_cq ? to_mcq(init_attr->send_cq)->mcq.cqn : -1); |
| 2056 | 2056 | ||
| 2057 | qp->trans_qp.xrcdn = xrcdn; | 2057 | qp->trans_qp.xrcdn = xrcdn; |
| 2058 | 2058 | ||
| @@ -4814,6 +4814,14 @@ struct ib_rwq_ind_table *mlx5_ib_create_rwq_ind_table(struct ib_device *device, | |||
| 4814 | udata->inlen)) | 4814 | udata->inlen)) |
| 4815 | return ERR_PTR(-EOPNOTSUPP); | 4815 | return ERR_PTR(-EOPNOTSUPP); |
| 4816 | 4816 | ||
| 4817 | if (init_attr->log_ind_tbl_size > | ||
| 4818 | MLX5_CAP_GEN(dev->mdev, log_max_rqt_size)) { | ||
| 4819 | mlx5_ib_dbg(dev, "log_ind_tbl_size = %d is bigger than supported = %d\n", | ||
| 4820 | init_attr->log_ind_tbl_size, | ||
| 4821 | MLX5_CAP_GEN(dev->mdev, log_max_rqt_size)); | ||
| 4822 | return ERR_PTR(-EINVAL); | ||
| 4823 | } | ||
| 4824 | |||
| 4817 | min_resp_len = offsetof(typeof(resp), reserved) + sizeof(resp.reserved); | 4825 | min_resp_len = offsetof(typeof(resp), reserved) + sizeof(resp.reserved); |
| 4818 | if (udata->outlen && udata->outlen < min_resp_len) | 4826 | if (udata->outlen && udata->outlen < min_resp_len) |
| 4819 | return ERR_PTR(-EINVAL); | 4827 | return ERR_PTR(-EINVAL); |
diff --git a/drivers/infiniband/sw/rdmavt/dma.c b/drivers/infiniband/sw/rdmavt/dma.c index 01f71caa3ac4..f2cefb0d9180 100644 --- a/drivers/infiniband/sw/rdmavt/dma.c +++ b/drivers/infiniband/sw/rdmavt/dma.c | |||
| @@ -90,9 +90,6 @@ static u64 rvt_dma_map_page(struct ib_device *dev, struct page *page, | |||
| 90 | if (WARN_ON(!valid_dma_direction(direction))) | 90 | if (WARN_ON(!valid_dma_direction(direction))) |
| 91 | return BAD_DMA_ADDRESS; | 91 | return BAD_DMA_ADDRESS; |
| 92 | 92 | ||
| 93 | if (offset + size > PAGE_SIZE) | ||
| 94 | return BAD_DMA_ADDRESS; | ||
| 95 | |||
| 96 | addr = (u64)page_address(page); | 93 | addr = (u64)page_address(page); |
| 97 | if (addr) | 94 | if (addr) |
| 98 | addr += offset; | 95 | addr += offset; |
diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c index b8258e4f0aea..ffff5a54cb34 100644 --- a/drivers/infiniband/sw/rxe/rxe_net.c +++ b/drivers/infiniband/sw/rxe/rxe_net.c | |||
| @@ -243,10 +243,8 @@ static struct socket *rxe_setup_udp_tunnel(struct net *net, __be16 port, | |||
| 243 | { | 243 | { |
| 244 | int err; | 244 | int err; |
| 245 | struct socket *sock; | 245 | struct socket *sock; |
| 246 | struct udp_port_cfg udp_cfg; | 246 | struct udp_port_cfg udp_cfg = {0}; |
| 247 | struct udp_tunnel_sock_cfg tnl_cfg; | 247 | struct udp_tunnel_sock_cfg tnl_cfg = {0}; |
| 248 | |||
| 249 | memset(&udp_cfg, 0, sizeof(udp_cfg)); | ||
| 250 | 248 | ||
| 251 | if (ipv6) { | 249 | if (ipv6) { |
| 252 | udp_cfg.family = AF_INET6; | 250 | udp_cfg.family = AF_INET6; |
| @@ -264,10 +262,8 @@ static struct socket *rxe_setup_udp_tunnel(struct net *net, __be16 port, | |||
| 264 | return ERR_PTR(err); | 262 | return ERR_PTR(err); |
| 265 | } | 263 | } |
| 266 | 264 | ||
| 267 | tnl_cfg.sk_user_data = NULL; | ||
| 268 | tnl_cfg.encap_type = 1; | 265 | tnl_cfg.encap_type = 1; |
| 269 | tnl_cfg.encap_rcv = rxe_udp_encap_recv; | 266 | tnl_cfg.encap_rcv = rxe_udp_encap_recv; |
| 270 | tnl_cfg.encap_destroy = NULL; | ||
| 271 | 267 | ||
| 272 | /* Setup UDP tunnel */ | 268 | /* Setup UDP tunnel */ |
| 273 | setup_udp_tunnel_sock(net, sock, &tnl_cfg); | 269 | setup_udp_tunnel_sock(net, sock, &tnl_cfg); |
diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c index b8036cfbce04..c3e60e4bde6e 100644 --- a/drivers/infiniband/sw/rxe/rxe_qp.c +++ b/drivers/infiniband/sw/rxe/rxe_qp.c | |||
| @@ -522,6 +522,7 @@ static void rxe_qp_reset(struct rxe_qp *qp) | |||
| 522 | if (qp->sq.queue) { | 522 | if (qp->sq.queue) { |
| 523 | __rxe_do_task(&qp->comp.task); | 523 | __rxe_do_task(&qp->comp.task); |
| 524 | __rxe_do_task(&qp->req.task); | 524 | __rxe_do_task(&qp->req.task); |
| 525 | rxe_queue_reset(qp->sq.queue); | ||
| 525 | } | 526 | } |
| 526 | 527 | ||
| 527 | /* cleanup attributes */ | 528 | /* cleanup attributes */ |
| @@ -573,6 +574,7 @@ void rxe_qp_error(struct rxe_qp *qp) | |||
| 573 | { | 574 | { |
| 574 | qp->req.state = QP_STATE_ERROR; | 575 | qp->req.state = QP_STATE_ERROR; |
| 575 | qp->resp.state = QP_STATE_ERROR; | 576 | qp->resp.state = QP_STATE_ERROR; |
| 577 | qp->attr.qp_state = IB_QPS_ERR; | ||
| 576 | 578 | ||
| 577 | /* drain work and packet queues */ | 579 | /* drain work and packet queues */ |
| 578 | rxe_run_task(&qp->resp.task, 1); | 580 | rxe_run_task(&qp->resp.task, 1); |
diff --git a/drivers/infiniband/sw/rxe/rxe_queue.c b/drivers/infiniband/sw/rxe/rxe_queue.c index 08274254eb88..d14bf496d62d 100644 --- a/drivers/infiniband/sw/rxe/rxe_queue.c +++ b/drivers/infiniband/sw/rxe/rxe_queue.c | |||
| @@ -84,6 +84,15 @@ err1: | |||
| 84 | return -EINVAL; | 84 | return -EINVAL; |
| 85 | } | 85 | } |
| 86 | 86 | ||
| 87 | inline void rxe_queue_reset(struct rxe_queue *q) | ||
| 88 | { | ||
| 89 | /* queue is comprised from header and the memory | ||
| 90 | * of the actual queue. See "struct rxe_queue_buf" in rxe_queue.h | ||
| 91 | * reset only the queue itself and not the management header | ||
| 92 | */ | ||
| 93 | memset(q->buf->data, 0, q->buf_size - sizeof(struct rxe_queue_buf)); | ||
| 94 | } | ||
| 95 | |||
| 87 | struct rxe_queue *rxe_queue_init(struct rxe_dev *rxe, | 96 | struct rxe_queue *rxe_queue_init(struct rxe_dev *rxe, |
| 88 | int *num_elem, | 97 | int *num_elem, |
| 89 | unsigned int elem_size) | 98 | unsigned int elem_size) |
diff --git a/drivers/infiniband/sw/rxe/rxe_queue.h b/drivers/infiniband/sw/rxe/rxe_queue.h index 239fd609c31e..8c8641c87817 100644 --- a/drivers/infiniband/sw/rxe/rxe_queue.h +++ b/drivers/infiniband/sw/rxe/rxe_queue.h | |||
| @@ -84,6 +84,8 @@ int do_mmap_info(struct rxe_dev *rxe, | |||
| 84 | size_t buf_size, | 84 | size_t buf_size, |
| 85 | struct rxe_mmap_info **ip_p); | 85 | struct rxe_mmap_info **ip_p); |
| 86 | 86 | ||
| 87 | void rxe_queue_reset(struct rxe_queue *q); | ||
| 88 | |||
| 87 | struct rxe_queue *rxe_queue_init(struct rxe_dev *rxe, | 89 | struct rxe_queue *rxe_queue_init(struct rxe_dev *rxe, |
| 88 | int *num_elem, | 90 | int *num_elem, |
| 89 | unsigned int elem_size); | 91 | unsigned int elem_size); |
diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c index 832846b73ea0..22bd9630dcd9 100644 --- a/drivers/infiniband/sw/rxe/rxe_req.c +++ b/drivers/infiniband/sw/rxe/rxe_req.c | |||
| @@ -696,7 +696,8 @@ next_wqe: | |||
| 696 | qp->req.wqe_index); | 696 | qp->req.wqe_index); |
| 697 | wqe->state = wqe_state_done; | 697 | wqe->state = wqe_state_done; |
| 698 | wqe->status = IB_WC_SUCCESS; | 698 | wqe->status = IB_WC_SUCCESS; |
| 699 | goto complete; | 699 | __rxe_do_task(&qp->comp.task); |
| 700 | return 0; | ||
| 700 | } | 701 | } |
| 701 | payload = mtu; | 702 | payload = mtu; |
| 702 | } | 703 | } |
| @@ -745,13 +746,17 @@ err: | |||
| 745 | wqe->status = IB_WC_LOC_PROT_ERR; | 746 | wqe->status = IB_WC_LOC_PROT_ERR; |
| 746 | wqe->state = wqe_state_error; | 747 | wqe->state = wqe_state_error; |
| 747 | 748 | ||
| 748 | complete: | 749 | /* |
| 749 | if (qp_type(qp) != IB_QPT_RC) { | 750 | * IBA Spec. Section 10.7.3.1 SIGNALED COMPLETIONS |
| 750 | while (rxe_completer(qp) == 0) | 751 | * ---------8<---------8<------------- |
| 751 | ; | 752 | * ...Note that if a completion error occurs, a Work Completion |
| 752 | } | 753 | * will always be generated, even if the signaling |
| 753 | 754 | * indicator requests an Unsignaled Completion. | |
| 754 | return 0; | 755 | * ---------8<---------8<------------- |
| 756 | */ | ||
| 757 | wqe->wr.send_flags |= IB_SEND_SIGNALED; | ||
| 758 | __rxe_do_task(&qp->comp.task); | ||
| 759 | return -EAGAIN; | ||
| 755 | 760 | ||
| 756 | exit: | 761 | exit: |
| 757 | return -EAGAIN; | 762 | return -EAGAIN; |
diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c index 08c87fadca8c..1f32688c312d 100644 --- a/drivers/mailbox/pcc.c +++ b/drivers/mailbox/pcc.c | |||
| @@ -65,6 +65,7 @@ | |||
| 65 | #include <linux/mailbox_controller.h> | 65 | #include <linux/mailbox_controller.h> |
| 66 | #include <linux/mailbox_client.h> | 66 | #include <linux/mailbox_client.h> |
| 67 | #include <linux/io-64-nonatomic-lo-hi.h> | 67 | #include <linux/io-64-nonatomic-lo-hi.h> |
| 68 | #include <acpi/pcc.h> | ||
| 68 | 69 | ||
| 69 | #include "mailbox.h" | 70 | #include "mailbox.h" |
| 70 | 71 | ||
| @@ -267,6 +268,8 @@ struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *cl, | |||
| 267 | if (chan->txdone_method == TXDONE_BY_POLL && cl->knows_txdone) | 268 | if (chan->txdone_method == TXDONE_BY_POLL && cl->knows_txdone) |
| 268 | chan->txdone_method |= TXDONE_BY_ACK; | 269 | chan->txdone_method |= TXDONE_BY_ACK; |
| 269 | 270 | ||
| 271 | spin_unlock_irqrestore(&chan->lock, flags); | ||
| 272 | |||
| 270 | if (pcc_doorbell_irq[subspace_id] > 0) { | 273 | if (pcc_doorbell_irq[subspace_id] > 0) { |
| 271 | int rc; | 274 | int rc; |
| 272 | 275 | ||
| @@ -275,12 +278,11 @@ struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *cl, | |||
| 275 | if (unlikely(rc)) { | 278 | if (unlikely(rc)) { |
| 276 | dev_err(dev, "failed to register PCC interrupt %d\n", | 279 | dev_err(dev, "failed to register PCC interrupt %d\n", |
| 277 | pcc_doorbell_irq[subspace_id]); | 280 | pcc_doorbell_irq[subspace_id]); |
| 281 | pcc_mbox_free_channel(chan); | ||
| 278 | chan = ERR_PTR(rc); | 282 | chan = ERR_PTR(rc); |
| 279 | } | 283 | } |
| 280 | } | 284 | } |
| 281 | 285 | ||
| 282 | spin_unlock_irqrestore(&chan->lock, flags); | ||
| 283 | |||
| 284 | return chan; | 286 | return chan; |
| 285 | } | 287 | } |
| 286 | EXPORT_SYMBOL_GPL(pcc_mbox_request_channel); | 288 | EXPORT_SYMBOL_GPL(pcc_mbox_request_channel); |
| @@ -304,20 +306,19 @@ void pcc_mbox_free_channel(struct mbox_chan *chan) | |||
| 304 | return; | 306 | return; |
| 305 | } | 307 | } |
| 306 | 308 | ||
| 309 | if (pcc_doorbell_irq[id] > 0) | ||
| 310 | devm_free_irq(chan->mbox->dev, pcc_doorbell_irq[id], chan); | ||
| 311 | |||
| 307 | spin_lock_irqsave(&chan->lock, flags); | 312 | spin_lock_irqsave(&chan->lock, flags); |
| 308 | chan->cl = NULL; | 313 | chan->cl = NULL; |
| 309 | chan->active_req = NULL; | 314 | chan->active_req = NULL; |
| 310 | if (chan->txdone_method == (TXDONE_BY_POLL | TXDONE_BY_ACK)) | 315 | if (chan->txdone_method == (TXDONE_BY_POLL | TXDONE_BY_ACK)) |
| 311 | chan->txdone_method = TXDONE_BY_POLL; | 316 | chan->txdone_method = TXDONE_BY_POLL; |
| 312 | 317 | ||
| 313 | if (pcc_doorbell_irq[id] > 0) | ||
| 314 | devm_free_irq(chan->mbox->dev, pcc_doorbell_irq[id], chan); | ||
| 315 | |||
| 316 | spin_unlock_irqrestore(&chan->lock, flags); | 318 | spin_unlock_irqrestore(&chan->lock, flags); |
| 317 | } | 319 | } |
| 318 | EXPORT_SYMBOL_GPL(pcc_mbox_free_channel); | 320 | EXPORT_SYMBOL_GPL(pcc_mbox_free_channel); |
| 319 | 321 | ||
| 320 | |||
| 321 | /** | 322 | /** |
| 322 | * pcc_send_data - Called from Mailbox Controller code. Used | 323 | * pcc_send_data - Called from Mailbox Controller code. Used |
| 323 | * here only to ring the channel doorbell. The PCC client | 324 | * here only to ring the channel doorbell. The PCC client |
diff --git a/drivers/media/dvb-frontends/gp8psk-fe.c b/drivers/media/dvb-frontends/gp8psk-fe.c index be19afeed7a9..93f59bfea092 100644 --- a/drivers/media/dvb-frontends/gp8psk-fe.c +++ b/drivers/media/dvb-frontends/gp8psk-fe.c | |||
| @@ -1,5 +1,5 @@ | |||
| 1 | /* DVB USB compliant Linux driver for the | 1 | /* |
| 2 | * - GENPIX 8pks/qpsk/DCII USB2.0 DVB-S module | 2 | * Frontend driver for the GENPIX 8pks/qpsk/DCII USB2.0 DVB-S module |
| 3 | * | 3 | * |
| 4 | * Copyright (C) 2006,2007 Alan Nisota (alannisota@gmail.com) | 4 | * Copyright (C) 2006,2007 Alan Nisota (alannisota@gmail.com) |
| 5 | * Copyright (C) 2006,2007 Genpix Electronics (genpix@genpix-electronics.com) | 5 | * Copyright (C) 2006,2007 Genpix Electronics (genpix@genpix-electronics.com) |
| @@ -8,11 +8,9 @@ | |||
| 8 | * | 8 | * |
| 9 | * This module is based off the vp7045 and vp702x modules | 9 | * This module is based off the vp7045 and vp702x modules |
| 10 | * | 10 | * |
| 11 | * This program is free software; you can redistribute it and/or modify it | 11 | * This program is free software; you can redistribute it and/or modify it |
| 12 | * under the terms of the GNU General Public License as published by the Free | 12 | * under the terms of the GNU General Public License as published by the Free |
| 13 | * Software Foundation, version 2. | 13 | * Software Foundation, version 2. |
| 14 | * | ||
| 15 | * see Documentation/dvb/README.dvb-usb for more information | ||
| 16 | */ | 14 | */ |
| 17 | 15 | ||
| 18 | #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt | 16 | #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt |
| @@ -395,3 +393,8 @@ static struct dvb_frontend_ops gp8psk_fe_ops = { | |||
| 395 | .dishnetwork_send_legacy_command = gp8psk_fe_send_legacy_dish_cmd, | 393 | .dishnetwork_send_legacy_command = gp8psk_fe_send_legacy_dish_cmd, |
| 396 | .enable_high_lnb_voltage = gp8psk_fe_enable_high_lnb_voltage | 394 | .enable_high_lnb_voltage = gp8psk_fe_enable_high_lnb_voltage |
| 397 | }; | 395 | }; |
| 396 | |||
| 397 | MODULE_AUTHOR("Alan Nisota <alannisota@gamil.com>"); | ||
| 398 | MODULE_DESCRIPTION("Frontend Driver for Genpix DVB-S"); | ||
| 399 | MODULE_VERSION("1.1"); | ||
| 400 | MODULE_LICENSE("GPL"); | ||
diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c index 3228fd182a99..9ff243970e93 100644 --- a/drivers/mfd/intel-lpss-pci.c +++ b/drivers/mfd/intel-lpss-pci.c | |||
| @@ -123,19 +123,6 @@ static const struct intel_lpss_platform_info apl_i2c_info = { | |||
| 123 | .properties = apl_i2c_properties, | 123 | .properties = apl_i2c_properties, |
| 124 | }; | 124 | }; |
| 125 | 125 | ||
| 126 | static const struct intel_lpss_platform_info kbl_info = { | ||
| 127 | .clk_rate = 120000000, | ||
| 128 | }; | ||
| 129 | |||
| 130 | static const struct intel_lpss_platform_info kbl_uart_info = { | ||
| 131 | .clk_rate = 120000000, | ||
| 132 | .clk_con_id = "baudclk", | ||
| 133 | }; | ||
| 134 | |||
| 135 | static const struct intel_lpss_platform_info kbl_i2c_info = { | ||
| 136 | .clk_rate = 133000000, | ||
| 137 | }; | ||
| 138 | |||
| 139 | static const struct pci_device_id intel_lpss_pci_ids[] = { | 126 | static const struct pci_device_id intel_lpss_pci_ids[] = { |
| 140 | /* BXT A-Step */ | 127 | /* BXT A-Step */ |
| 141 | { PCI_VDEVICE(INTEL, 0x0aac), (kernel_ulong_t)&bxt_i2c_info }, | 128 | { PCI_VDEVICE(INTEL, 0x0aac), (kernel_ulong_t)&bxt_i2c_info }, |
| @@ -207,15 +194,15 @@ static const struct pci_device_id intel_lpss_pci_ids[] = { | |||
| 207 | { PCI_VDEVICE(INTEL, 0xa161), (kernel_ulong_t)&spt_i2c_info }, | 194 | { PCI_VDEVICE(INTEL, 0xa161), (kernel_ulong_t)&spt_i2c_info }, |
| 208 | { PCI_VDEVICE(INTEL, 0xa166), (kernel_ulong_t)&spt_uart_info }, | 195 | { PCI_VDEVICE(INTEL, 0xa166), (kernel_ulong_t)&spt_uart_info }, |
| 209 | /* KBL-H */ | 196 | /* KBL-H */ |
| 210 | { PCI_VDEVICE(INTEL, 0xa2a7), (kernel_ulong_t)&kbl_uart_info }, | 197 | { PCI_VDEVICE(INTEL, 0xa2a7), (kernel_ulong_t)&spt_uart_info }, |
| 211 | { PCI_VDEVICE(INTEL, 0xa2a8), (kernel_ulong_t)&kbl_uart_info }, | 198 | { PCI_VDEVICE(INTEL, 0xa2a8), (kernel_ulong_t)&spt_uart_info }, |
| 212 | { PCI_VDEVICE(INTEL, 0xa2a9), (kernel_ulong_t)&kbl_info }, | 199 | { PCI_VDEVICE(INTEL, 0xa2a9), (kernel_ulong_t)&spt_info }, |
| 213 | { PCI_VDEVICE(INTEL, 0xa2aa), (kernel_ulong_t)&kbl_info }, | 200 | { PCI_VDEVICE(INTEL, 0xa2aa), (kernel_ulong_t)&spt_info }, |
| 214 | { PCI_VDEVICE(INTEL, 0xa2e0), (kernel_ulong_t)&kbl_i2c_info }, | 201 | { PCI_VDEVICE(INTEL, 0xa2e0), (kernel_ulong_t)&spt_i2c_info }, |
| 215 | { PCI_VDEVICE(INTEL, 0xa2e1), (kernel_ulong_t)&kbl_i2c_info }, | 202 | { PCI_VDEVICE(INTEL, 0xa2e1), (kernel_ulong_t)&spt_i2c_info }, |
| 216 | { PCI_VDEVICE(INTEL, 0xa2e2), (kernel_ulong_t)&kbl_i2c_info }, | 203 | { PCI_VDEVICE(INTEL, 0xa2e2), (kernel_ulong_t)&spt_i2c_info }, |
| 217 | { PCI_VDEVICE(INTEL, 0xa2e3), (kernel_ulong_t)&kbl_i2c_info }, | 204 | { PCI_VDEVICE(INTEL, 0xa2e3), (kernel_ulong_t)&spt_i2c_info }, |
| 218 | { PCI_VDEVICE(INTEL, 0xa2e6), (kernel_ulong_t)&kbl_uart_info }, | 205 | { PCI_VDEVICE(INTEL, 0xa2e6), (kernel_ulong_t)&spt_uart_info }, |
| 219 | { } | 206 | { } |
| 220 | }; | 207 | }; |
| 221 | MODULE_DEVICE_TABLE(pci, intel_lpss_pci_ids); | 208 | MODULE_DEVICE_TABLE(pci, intel_lpss_pci_ids); |
diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c index 41b113875d64..70c646b0097d 100644 --- a/drivers/mfd/intel-lpss.c +++ b/drivers/mfd/intel-lpss.c | |||
| @@ -502,9 +502,6 @@ int intel_lpss_suspend(struct device *dev) | |||
| 502 | for (i = 0; i < LPSS_PRIV_REG_COUNT; i++) | 502 | for (i = 0; i < LPSS_PRIV_REG_COUNT; i++) |
| 503 | lpss->priv_ctx[i] = readl(lpss->priv + i * 4); | 503 | lpss->priv_ctx[i] = readl(lpss->priv + i * 4); |
| 504 | 504 | ||
| 505 | /* Put the device into reset state */ | ||
| 506 | writel(0, lpss->priv + LPSS_PRIV_RESETS); | ||
| 507 | |||
| 508 | return 0; | 505 | return 0; |
| 509 | } | 506 | } |
| 510 | EXPORT_SYMBOL_GPL(intel_lpss_suspend); | 507 | EXPORT_SYMBOL_GPL(intel_lpss_suspend); |
diff --git a/drivers/mfd/intel_soc_pmic_bxtwc.c b/drivers/mfd/intel_soc_pmic_bxtwc.c index 43e54b7e908f..f9a8c5203873 100644 --- a/drivers/mfd/intel_soc_pmic_bxtwc.c +++ b/drivers/mfd/intel_soc_pmic_bxtwc.c | |||
| @@ -86,6 +86,7 @@ enum bxtwc_irqs_level2 { | |||
| 86 | BXTWC_THRM2_IRQ, | 86 | BXTWC_THRM2_IRQ, |
| 87 | BXTWC_BCU_IRQ, | 87 | BXTWC_BCU_IRQ, |
| 88 | BXTWC_ADC_IRQ, | 88 | BXTWC_ADC_IRQ, |
| 89 | BXTWC_USBC_IRQ, | ||
| 89 | BXTWC_CHGR0_IRQ, | 90 | BXTWC_CHGR0_IRQ, |
| 90 | BXTWC_CHGR1_IRQ, | 91 | BXTWC_CHGR1_IRQ, |
| 91 | BXTWC_GPIO0_IRQ, | 92 | BXTWC_GPIO0_IRQ, |
| @@ -111,7 +112,8 @@ static const struct regmap_irq bxtwc_regmap_irqs_level2[] = { | |||
| 111 | REGMAP_IRQ_REG(BXTWC_THRM2_IRQ, 2, 0xff), | 112 | REGMAP_IRQ_REG(BXTWC_THRM2_IRQ, 2, 0xff), |
| 112 | REGMAP_IRQ_REG(BXTWC_BCU_IRQ, 3, 0x1f), | 113 | REGMAP_IRQ_REG(BXTWC_BCU_IRQ, 3, 0x1f), |
| 113 | REGMAP_IRQ_REG(BXTWC_ADC_IRQ, 4, 0xff), | 114 | REGMAP_IRQ_REG(BXTWC_ADC_IRQ, 4, 0xff), |
| 114 | REGMAP_IRQ_REG(BXTWC_CHGR0_IRQ, 5, 0x3f), | 115 | REGMAP_IRQ_REG(BXTWC_USBC_IRQ, 5, BIT(5)), |
| 116 | REGMAP_IRQ_REG(BXTWC_CHGR0_IRQ, 5, 0x1f), | ||
| 115 | REGMAP_IRQ_REG(BXTWC_CHGR1_IRQ, 6, 0x1f), | 117 | REGMAP_IRQ_REG(BXTWC_CHGR1_IRQ, 6, 0x1f), |
| 116 | REGMAP_IRQ_REG(BXTWC_GPIO0_IRQ, 7, 0xff), | 118 | REGMAP_IRQ_REG(BXTWC_GPIO0_IRQ, 7, 0xff), |
| 117 | REGMAP_IRQ_REG(BXTWC_GPIO1_IRQ, 8, 0x3f), | 119 | REGMAP_IRQ_REG(BXTWC_GPIO1_IRQ, 8, 0x3f), |
| @@ -146,7 +148,7 @@ static struct resource adc_resources[] = { | |||
| 146 | }; | 148 | }; |
| 147 | 149 | ||
| 148 | static struct resource usbc_resources[] = { | 150 | static struct resource usbc_resources[] = { |
| 149 | DEFINE_RES_IRQ_NAMED(BXTWC_CHGR0_IRQ, "USBC"), | 151 | DEFINE_RES_IRQ(BXTWC_USBC_IRQ), |
| 150 | }; | 152 | }; |
| 151 | 153 | ||
| 152 | static struct resource charger_resources[] = { | 154 | static struct resource charger_resources[] = { |
diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c index 3ac486a597f3..c57e407020f1 100644 --- a/drivers/mfd/mfd-core.c +++ b/drivers/mfd/mfd-core.c | |||
| @@ -399,6 +399,8 @@ int mfd_clone_cell(const char *cell, const char **clones, size_t n_clones) | |||
| 399 | clones[i]); | 399 | clones[i]); |
| 400 | } | 400 | } |
| 401 | 401 | ||
| 402 | put_device(dev); | ||
| 403 | |||
| 402 | return 0; | 404 | return 0; |
| 403 | } | 405 | } |
| 404 | EXPORT_SYMBOL(mfd_clone_cell); | 406 | EXPORT_SYMBOL(mfd_clone_cell); |
diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c index cfdae8a3d779..b0c7bcdaf5df 100644 --- a/drivers/mfd/stmpe.c +++ b/drivers/mfd/stmpe.c | |||
| @@ -851,6 +851,8 @@ static int stmpe_reset(struct stmpe *stmpe) | |||
| 851 | if (ret < 0) | 851 | if (ret < 0) |
| 852 | return ret; | 852 | return ret; |
| 853 | 853 | ||
| 854 | msleep(10); | ||
| 855 | |||
| 854 | timeout = jiffies + msecs_to_jiffies(100); | 856 | timeout = jiffies + msecs_to_jiffies(100); |
| 855 | while (time_before(jiffies, timeout)) { | 857 | while (time_before(jiffies, timeout)) { |
| 856 | ret = __stmpe_reg_read(stmpe, stmpe->regs[STMPE_IDX_SYS_CTRL]); | 858 | ret = __stmpe_reg_read(stmpe, stmpe->regs[STMPE_IDX_SYS_CTRL]); |
diff --git a/drivers/net/can/sja1000/plx_pci.c b/drivers/net/can/sja1000/plx_pci.c index 3eb7430dffbf..f8ff25c8ee2e 100644 --- a/drivers/net/can/sja1000/plx_pci.c +++ b/drivers/net/can/sja1000/plx_pci.c | |||
| @@ -142,6 +142,9 @@ struct plx_pci_card { | |||
| 142 | #define CTI_PCI_VENDOR_ID 0x12c4 | 142 | #define CTI_PCI_VENDOR_ID 0x12c4 |
| 143 | #define CTI_PCI_DEVICE_ID_CRG001 0x0900 | 143 | #define CTI_PCI_DEVICE_ID_CRG001 0x0900 |
| 144 | 144 | ||
| 145 | #define MOXA_PCI_VENDOR_ID 0x1393 | ||
| 146 | #define MOXA_PCI_DEVICE_ID 0x0100 | ||
| 147 | |||
| 145 | static void plx_pci_reset_common(struct pci_dev *pdev); | 148 | static void plx_pci_reset_common(struct pci_dev *pdev); |
| 146 | static void plx9056_pci_reset_common(struct pci_dev *pdev); | 149 | static void plx9056_pci_reset_common(struct pci_dev *pdev); |
| 147 | static void plx_pci_reset_marathon_pci(struct pci_dev *pdev); | 150 | static void plx_pci_reset_marathon_pci(struct pci_dev *pdev); |
| @@ -258,6 +261,14 @@ static struct plx_pci_card_info plx_pci_card_info_elcus = { | |||
| 258 | /* based on PLX9030 */ | 261 | /* based on PLX9030 */ |
| 259 | }; | 262 | }; |
| 260 | 263 | ||
| 264 | static struct plx_pci_card_info plx_pci_card_info_moxa = { | ||
| 265 | "MOXA", 2, | ||
| 266 | PLX_PCI_CAN_CLOCK, PLX_PCI_OCR, PLX_PCI_CDR, | ||
| 267 | {0, 0x00, 0x00}, { {0, 0x00, 0x80}, {1, 0x00, 0x80} }, | ||
| 268 | &plx_pci_reset_common | ||
| 269 | /* based on PLX9052 */ | ||
| 270 | }; | ||
| 271 | |||
| 261 | static const struct pci_device_id plx_pci_tbl[] = { | 272 | static const struct pci_device_id plx_pci_tbl[] = { |
| 262 | { | 273 | { |
| 263 | /* Adlink PCI-7841/cPCI-7841 */ | 274 | /* Adlink PCI-7841/cPCI-7841 */ |
| @@ -357,6 +368,13 @@ static const struct pci_device_id plx_pci_tbl[] = { | |||
| 357 | 0, 0, | 368 | 0, 0, |
| 358 | (kernel_ulong_t)&plx_pci_card_info_elcus | 369 | (kernel_ulong_t)&plx_pci_card_info_elcus |
| 359 | }, | 370 | }, |
| 371 | { | ||
| 372 | /* moxa */ | ||
| 373 | MOXA_PCI_VENDOR_ID, MOXA_PCI_DEVICE_ID, | ||
| 374 | PCI_ANY_ID, PCI_ANY_ID, | ||
| 375 | 0, 0, | ||
| 376 | (kernel_ulong_t)&plx_pci_card_info_moxa | ||
| 377 | }, | ||
| 360 | { 0,} | 378 | { 0,} |
| 361 | }; | 379 | }; |
| 362 | MODULE_DEVICE_TABLE(pci, plx_pci_tbl); | 380 | MODULE_DEVICE_TABLE(pci, plx_pci_tbl); |
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c index c481f104a8fe..5390ae89136c 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | |||
| @@ -204,17 +204,6 @@ static u32 xgene_enet_ring_len(struct xgene_enet_desc_ring *ring) | |||
| 204 | return num_msgs; | 204 | return num_msgs; |
| 205 | } | 205 | } |
| 206 | 206 | ||
| 207 | static void xgene_enet_setup_coalescing(struct xgene_enet_desc_ring *ring) | ||
| 208 | { | ||
| 209 | u32 data = 0x7777; | ||
| 210 | |||
| 211 | xgene_enet_ring_wr32(ring, CSR_PBM_COAL, 0x8e); | ||
| 212 | xgene_enet_ring_wr32(ring, CSR_PBM_CTICK1, data); | ||
| 213 | xgene_enet_ring_wr32(ring, CSR_PBM_CTICK2, data << 16); | ||
| 214 | xgene_enet_ring_wr32(ring, CSR_THRESHOLD0_SET1, 0x40); | ||
| 215 | xgene_enet_ring_wr32(ring, CSR_THRESHOLD1_SET1, 0x80); | ||
| 216 | } | ||
| 217 | |||
| 218 | void xgene_enet_parse_error(struct xgene_enet_desc_ring *ring, | 207 | void xgene_enet_parse_error(struct xgene_enet_desc_ring *ring, |
| 219 | struct xgene_enet_pdata *pdata, | 208 | struct xgene_enet_pdata *pdata, |
| 220 | enum xgene_enet_err_code status) | 209 | enum xgene_enet_err_code status) |
| @@ -929,5 +918,4 @@ struct xgene_ring_ops xgene_ring1_ops = { | |||
| 929 | .clear = xgene_enet_clear_ring, | 918 | .clear = xgene_enet_clear_ring, |
| 930 | .wr_cmd = xgene_enet_wr_cmd, | 919 | .wr_cmd = xgene_enet_wr_cmd, |
| 931 | .len = xgene_enet_ring_len, | 920 | .len = xgene_enet_ring_len, |
| 932 | .coalesce = xgene_enet_setup_coalescing, | ||
| 933 | }; | 921 | }; |
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.h b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.h index 8456337a237d..06e598c8bc16 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.h +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.h | |||
| @@ -55,8 +55,10 @@ enum xgene_enet_rm { | |||
| 55 | #define PREFETCH_BUF_EN BIT(21) | 55 | #define PREFETCH_BUF_EN BIT(21) |
| 56 | #define CSR_RING_ID_BUF 0x000c | 56 | #define CSR_RING_ID_BUF 0x000c |
| 57 | #define CSR_PBM_COAL 0x0014 | 57 | #define CSR_PBM_COAL 0x0014 |
| 58 | #define CSR_PBM_CTICK0 0x0018 | ||
| 58 | #define CSR_PBM_CTICK1 0x001c | 59 | #define CSR_PBM_CTICK1 0x001c |
| 59 | #define CSR_PBM_CTICK2 0x0020 | 60 | #define CSR_PBM_CTICK2 0x0020 |
| 61 | #define CSR_PBM_CTICK3 0x0024 | ||
| 60 | #define CSR_THRESHOLD0_SET1 0x0030 | 62 | #define CSR_THRESHOLD0_SET1 0x0030 |
| 61 | #define CSR_THRESHOLD1_SET1 0x0034 | 63 | #define CSR_THRESHOLD1_SET1 0x0034 |
| 62 | #define CSR_RING_NE_INT_MODE 0x017c | 64 | #define CSR_RING_NE_INT_MODE 0x017c |
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c index 429f18fc5503..8158d4698734 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c | |||
| @@ -1188,7 +1188,8 @@ static int xgene_enet_create_desc_rings(struct net_device *ndev) | |||
| 1188 | tx_ring->dst_ring_num = xgene_enet_dst_ring_num(cp_ring); | 1188 | tx_ring->dst_ring_num = xgene_enet_dst_ring_num(cp_ring); |
| 1189 | } | 1189 | } |
| 1190 | 1190 | ||
| 1191 | pdata->ring_ops->coalesce(pdata->tx_ring[0]); | 1191 | if (pdata->ring_ops->coalesce) |
| 1192 | pdata->ring_ops->coalesce(pdata->tx_ring[0]); | ||
| 1192 | pdata->tx_qcnt_hi = pdata->tx_ring[0]->slots - 128; | 1193 | pdata->tx_qcnt_hi = pdata->tx_ring[0]->slots - 128; |
| 1193 | 1194 | ||
| 1194 | return 0; | 1195 | return 0; |
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_ring2.c b/drivers/net/ethernet/apm/xgene/xgene_enet_ring2.c index 2b76732add5d..af51dd5844ce 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_ring2.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_ring2.c | |||
| @@ -30,7 +30,7 @@ static void xgene_enet_ring_init(struct xgene_enet_desc_ring *ring) | |||
| 30 | ring_cfg[0] |= SET_VAL(X2_INTLINE, ring->id & RING_BUFNUM_MASK); | 30 | ring_cfg[0] |= SET_VAL(X2_INTLINE, ring->id & RING_BUFNUM_MASK); |
| 31 | ring_cfg[3] |= SET_BIT(X2_DEQINTEN); | 31 | ring_cfg[3] |= SET_BIT(X2_DEQINTEN); |
| 32 | } | 32 | } |
| 33 | ring_cfg[0] |= SET_VAL(X2_CFGCRID, 1); | 33 | ring_cfg[0] |= SET_VAL(X2_CFGCRID, 2); |
| 34 | 34 | ||
| 35 | addr >>= 8; | 35 | addr >>= 8; |
| 36 | ring_cfg[2] |= QCOHERENT | SET_VAL(RINGADDRL, addr); | 36 | ring_cfg[2] |= QCOHERENT | SET_VAL(RINGADDRL, addr); |
| @@ -192,13 +192,15 @@ static u32 xgene_enet_ring_len(struct xgene_enet_desc_ring *ring) | |||
| 192 | 192 | ||
| 193 | static void xgene_enet_setup_coalescing(struct xgene_enet_desc_ring *ring) | 193 | static void xgene_enet_setup_coalescing(struct xgene_enet_desc_ring *ring) |
| 194 | { | 194 | { |
| 195 | u32 data = 0x7777; | 195 | u32 data = 0x77777777; |
| 196 | 196 | ||
| 197 | xgene_enet_ring_wr32(ring, CSR_PBM_COAL, 0x8e); | 197 | xgene_enet_ring_wr32(ring, CSR_PBM_COAL, 0x8e); |
| 198 | xgene_enet_ring_wr32(ring, CSR_PBM_CTICK0, data); | ||
| 198 | xgene_enet_ring_wr32(ring, CSR_PBM_CTICK1, data); | 199 | xgene_enet_ring_wr32(ring, CSR_PBM_CTICK1, data); |
| 199 | xgene_enet_ring_wr32(ring, CSR_PBM_CTICK2, data << 16); | 200 | xgene_enet_ring_wr32(ring, CSR_PBM_CTICK2, data); |
| 200 | xgene_enet_ring_wr32(ring, CSR_THRESHOLD0_SET1, 0x40); | 201 | xgene_enet_ring_wr32(ring, CSR_PBM_CTICK3, data); |
| 201 | xgene_enet_ring_wr32(ring, CSR_THRESHOLD1_SET1, 0x80); | 202 | xgene_enet_ring_wr32(ring, CSR_THRESHOLD0_SET1, 0x08); |
| 203 | xgene_enet_ring_wr32(ring, CSR_THRESHOLD1_SET1, 0x10); | ||
| 202 | } | 204 | } |
| 203 | 205 | ||
| 204 | struct xgene_ring_ops xgene_ring2_ops = { | 206 | struct xgene_ring_ops xgene_ring2_ops = { |
diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c index 31ca204b38d2..49f4cafe5438 100644 --- a/drivers/net/ethernet/broadcom/bgmac.c +++ b/drivers/net/ethernet/broadcom/bgmac.c | |||
| @@ -307,6 +307,10 @@ static void bgmac_dma_rx_enable(struct bgmac *bgmac, | |||
| 307 | u32 ctl; | 307 | u32 ctl; |
| 308 | 308 | ||
| 309 | ctl = bgmac_read(bgmac, ring->mmio_base + BGMAC_DMA_RX_CTL); | 309 | ctl = bgmac_read(bgmac, ring->mmio_base + BGMAC_DMA_RX_CTL); |
| 310 | |||
| 311 | /* preserve ONLY bits 16-17 from current hardware value */ | ||
| 312 | ctl &= BGMAC_DMA_RX_ADDREXT_MASK; | ||
| 313 | |||
| 310 | if (bgmac->feature_flags & BGMAC_FEAT_RX_MASK_SETUP) { | 314 | if (bgmac->feature_flags & BGMAC_FEAT_RX_MASK_SETUP) { |
| 311 | ctl &= ~BGMAC_DMA_RX_BL_MASK; | 315 | ctl &= ~BGMAC_DMA_RX_BL_MASK; |
| 312 | ctl |= BGMAC_DMA_RX_BL_128 << BGMAC_DMA_RX_BL_SHIFT; | 316 | ctl |= BGMAC_DMA_RX_BL_128 << BGMAC_DMA_RX_BL_SHIFT; |
| @@ -317,7 +321,6 @@ static void bgmac_dma_rx_enable(struct bgmac *bgmac, | |||
| 317 | ctl &= ~BGMAC_DMA_RX_PT_MASK; | 321 | ctl &= ~BGMAC_DMA_RX_PT_MASK; |
| 318 | ctl |= BGMAC_DMA_RX_PT_1 << BGMAC_DMA_RX_PT_SHIFT; | 322 | ctl |= BGMAC_DMA_RX_PT_1 << BGMAC_DMA_RX_PT_SHIFT; |
| 319 | } | 323 | } |
| 320 | ctl &= BGMAC_DMA_RX_ADDREXT_MASK; | ||
| 321 | ctl |= BGMAC_DMA_RX_ENABLE; | 324 | ctl |= BGMAC_DMA_RX_ENABLE; |
| 322 | ctl |= BGMAC_DMA_RX_PARITY_DISABLE; | 325 | ctl |= BGMAC_DMA_RX_PARITY_DISABLE; |
| 323 | ctl |= BGMAC_DMA_RX_OVERFLOW_CONT; | 326 | ctl |= BGMAC_DMA_RX_OVERFLOW_CONT; |
| @@ -1046,9 +1049,9 @@ static void bgmac_enable(struct bgmac *bgmac) | |||
| 1046 | 1049 | ||
| 1047 | mode = (bgmac_read(bgmac, BGMAC_DEV_STATUS) & BGMAC_DS_MM_MASK) >> | 1050 | mode = (bgmac_read(bgmac, BGMAC_DEV_STATUS) & BGMAC_DS_MM_MASK) >> |
| 1048 | BGMAC_DS_MM_SHIFT; | 1051 | BGMAC_DS_MM_SHIFT; |
| 1049 | if (!(bgmac->feature_flags & BGMAC_FEAT_CLKCTLST) || mode != 0) | 1052 | if (bgmac->feature_flags & BGMAC_FEAT_CLKCTLST || mode != 0) |
| 1050 | bgmac_set(bgmac, BCMA_CLKCTLST, BCMA_CLKCTLST_FORCEHT); | 1053 | bgmac_set(bgmac, BCMA_CLKCTLST, BCMA_CLKCTLST_FORCEHT); |
| 1051 | if (bgmac->feature_flags & BGMAC_FEAT_CLKCTLST && mode == 2) | 1054 | if (!(bgmac->feature_flags & BGMAC_FEAT_CLKCTLST) && mode == 2) |
| 1052 | bgmac_cco_ctl_maskset(bgmac, 1, ~0, | 1055 | bgmac_cco_ctl_maskset(bgmac, 1, ~0, |
| 1053 | BGMAC_CHIPCTL_1_RXC_DLL_BYPASS); | 1056 | BGMAC_CHIPCTL_1_RXC_DLL_BYPASS); |
| 1054 | 1057 | ||
diff --git a/drivers/net/ethernet/broadcom/bnx2.c b/drivers/net/ethernet/broadcom/bnx2.c index b3791b394715..1f7034d739b0 100644 --- a/drivers/net/ethernet/broadcom/bnx2.c +++ b/drivers/net/ethernet/broadcom/bnx2.c | |||
| @@ -49,6 +49,7 @@ | |||
| 49 | #include <linux/firmware.h> | 49 | #include <linux/firmware.h> |
| 50 | #include <linux/log2.h> | 50 | #include <linux/log2.h> |
| 51 | #include <linux/aer.h> | 51 | #include <linux/aer.h> |
| 52 | #include <linux/crash_dump.h> | ||
| 52 | 53 | ||
| 53 | #if IS_ENABLED(CONFIG_CNIC) | 54 | #if IS_ENABLED(CONFIG_CNIC) |
| 54 | #define BCM_CNIC 1 | 55 | #define BCM_CNIC 1 |
| @@ -4764,15 +4765,16 @@ bnx2_setup_msix_tbl(struct bnx2 *bp) | |||
| 4764 | BNX2_WR(bp, BNX2_PCI_GRC_WINDOW3_ADDR, BNX2_MSIX_PBA_ADDR); | 4765 | BNX2_WR(bp, BNX2_PCI_GRC_WINDOW3_ADDR, BNX2_MSIX_PBA_ADDR); |
| 4765 | } | 4766 | } |
| 4766 | 4767 | ||
| 4767 | static int | 4768 | static void |
| 4768 | bnx2_reset_chip(struct bnx2 *bp, u32 reset_code) | 4769 | bnx2_wait_dma_complete(struct bnx2 *bp) |
| 4769 | { | 4770 | { |
| 4770 | u32 val; | 4771 | u32 val; |
| 4771 | int i, rc = 0; | 4772 | int i; |
| 4772 | u8 old_port; | ||
| 4773 | 4773 | ||
| 4774 | /* Wait for the current PCI transaction to complete before | 4774 | /* |
| 4775 | * issuing a reset. */ | 4775 | * Wait for the current PCI transaction to complete before |
| 4776 | * issuing a reset. | ||
| 4777 | */ | ||
| 4776 | if ((BNX2_CHIP(bp) == BNX2_CHIP_5706) || | 4778 | if ((BNX2_CHIP(bp) == BNX2_CHIP_5706) || |
| 4777 | (BNX2_CHIP(bp) == BNX2_CHIP_5708)) { | 4779 | (BNX2_CHIP(bp) == BNX2_CHIP_5708)) { |
| 4778 | BNX2_WR(bp, BNX2_MISC_ENABLE_CLR_BITS, | 4780 | BNX2_WR(bp, BNX2_MISC_ENABLE_CLR_BITS, |
| @@ -4796,6 +4798,21 @@ bnx2_reset_chip(struct bnx2 *bp, u32 reset_code) | |||
| 4796 | } | 4798 | } |
| 4797 | } | 4799 | } |
| 4798 | 4800 | ||
| 4801 | return; | ||
| 4802 | } | ||
| 4803 | |||
| 4804 | |||
| 4805 | static int | ||
| 4806 | bnx2_reset_chip(struct bnx2 *bp, u32 reset_code) | ||
| 4807 | { | ||
| 4808 | u32 val; | ||
| 4809 | int i, rc = 0; | ||
| 4810 | u8 old_port; | ||
| 4811 | |||
| 4812 | /* Wait for the current PCI transaction to complete before | ||
| 4813 | * issuing a reset. */ | ||
| 4814 | bnx2_wait_dma_complete(bp); | ||
| 4815 | |||
| 4799 | /* Wait for the firmware to tell us it is ok to issue a reset. */ | 4816 | /* Wait for the firmware to tell us it is ok to issue a reset. */ |
| 4800 | bnx2_fw_sync(bp, BNX2_DRV_MSG_DATA_WAIT0 | reset_code, 1, 1); | 4817 | bnx2_fw_sync(bp, BNX2_DRV_MSG_DATA_WAIT0 | reset_code, 1, 1); |
| 4801 | 4818 | ||
| @@ -6361,6 +6378,10 @@ bnx2_open(struct net_device *dev) | |||
| 6361 | struct bnx2 *bp = netdev_priv(dev); | 6378 | struct bnx2 *bp = netdev_priv(dev); |
| 6362 | int rc; | 6379 | int rc; |
| 6363 | 6380 | ||
| 6381 | rc = bnx2_request_firmware(bp); | ||
| 6382 | if (rc < 0) | ||
| 6383 | goto out; | ||
| 6384 | |||
| 6364 | netif_carrier_off(dev); | 6385 | netif_carrier_off(dev); |
| 6365 | 6386 | ||
| 6366 | bnx2_disable_int(bp); | 6387 | bnx2_disable_int(bp); |
| @@ -6429,6 +6450,7 @@ open_err: | |||
| 6429 | bnx2_free_irq(bp); | 6450 | bnx2_free_irq(bp); |
| 6430 | bnx2_free_mem(bp); | 6451 | bnx2_free_mem(bp); |
| 6431 | bnx2_del_napi(bp); | 6452 | bnx2_del_napi(bp); |
| 6453 | bnx2_release_firmware(bp); | ||
| 6432 | goto out; | 6454 | goto out; |
| 6433 | } | 6455 | } |
| 6434 | 6456 | ||
| @@ -8575,12 +8597,15 @@ bnx2_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
| 8575 | 8597 | ||
| 8576 | pci_set_drvdata(pdev, dev); | 8598 | pci_set_drvdata(pdev, dev); |
| 8577 | 8599 | ||
| 8578 | rc = bnx2_request_firmware(bp); | 8600 | /* |
| 8579 | if (rc < 0) | 8601 | * In-flight DMA from 1st kernel could continue going in kdump kernel. |
| 8580 | goto error; | 8602 | * New io-page table has been created before bnx2 does reset at open stage. |
| 8581 | 8603 | * We have to wait for the in-flight DMA to complete to avoid it look up | |
| 8604 | * into the newly created io-page table. | ||
| 8605 | */ | ||
| 8606 | if (is_kdump_kernel()) | ||
| 8607 | bnx2_wait_dma_complete(bp); | ||
| 8582 | 8608 | ||
| 8583 | bnx2_reset_chip(bp, BNX2_DRV_MSG_CODE_RESET); | ||
| 8584 | memcpy(dev->dev_addr, bp->mac_addr, ETH_ALEN); | 8609 | memcpy(dev->dev_addr, bp->mac_addr, ETH_ALEN); |
| 8585 | 8610 | ||
| 8586 | dev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG | | 8611 | dev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG | |
| @@ -8613,7 +8638,6 @@ bnx2_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
| 8613 | return 0; | 8638 | return 0; |
| 8614 | 8639 | ||
| 8615 | error: | 8640 | error: |
| 8616 | bnx2_release_firmware(bp); | ||
| 8617 | pci_iounmap(pdev, bp->regview); | 8641 | pci_iounmap(pdev, bp->regview); |
| 8618 | pci_release_regions(pdev); | 8642 | pci_release_regions(pdev); |
| 8619 | pci_disable_device(pdev); | 8643 | pci_disable_device(pdev); |
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index a9f9f3738022..c6909660e097 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c | |||
| @@ -6309,6 +6309,7 @@ static int bnxt_setup_tc(struct net_device *dev, u32 handle, __be16 proto, | |||
| 6309 | struct tc_to_netdev *ntc) | 6309 | struct tc_to_netdev *ntc) |
| 6310 | { | 6310 | { |
| 6311 | struct bnxt *bp = netdev_priv(dev); | 6311 | struct bnxt *bp = netdev_priv(dev); |
| 6312 | bool sh = false; | ||
| 6312 | u8 tc; | 6313 | u8 tc; |
| 6313 | 6314 | ||
| 6314 | if (ntc->type != TC_SETUP_MQPRIO) | 6315 | if (ntc->type != TC_SETUP_MQPRIO) |
| @@ -6325,12 +6326,11 @@ static int bnxt_setup_tc(struct net_device *dev, u32 handle, __be16 proto, | |||
| 6325 | if (netdev_get_num_tc(dev) == tc) | 6326 | if (netdev_get_num_tc(dev) == tc) |
| 6326 | return 0; | 6327 | return 0; |
| 6327 | 6328 | ||
| 6329 | if (bp->flags & BNXT_FLAG_SHARED_RINGS) | ||
| 6330 | sh = true; | ||
| 6331 | |||
| 6328 | if (tc) { | 6332 | if (tc) { |
| 6329 | int max_rx_rings, max_tx_rings, rc; | 6333 | int max_rx_rings, max_tx_rings, rc; |
| 6330 | bool sh = false; | ||
| 6331 | |||
| 6332 | if (bp->flags & BNXT_FLAG_SHARED_RINGS) | ||
| 6333 | sh = true; | ||
| 6334 | 6334 | ||
| 6335 | rc = bnxt_get_max_rings(bp, &max_rx_rings, &max_tx_rings, sh); | 6335 | rc = bnxt_get_max_rings(bp, &max_rx_rings, &max_tx_rings, sh); |
| 6336 | if (rc || bp->tx_nr_rings_per_tc * tc > max_tx_rings) | 6336 | if (rc || bp->tx_nr_rings_per_tc * tc > max_tx_rings) |
| @@ -6348,7 +6348,8 @@ static int bnxt_setup_tc(struct net_device *dev, u32 handle, __be16 proto, | |||
| 6348 | bp->tx_nr_rings = bp->tx_nr_rings_per_tc; | 6348 | bp->tx_nr_rings = bp->tx_nr_rings_per_tc; |
| 6349 | netdev_reset_tc(dev); | 6349 | netdev_reset_tc(dev); |
| 6350 | } | 6350 | } |
| 6351 | bp->cp_nr_rings = max_t(int, bp->tx_nr_rings, bp->rx_nr_rings); | 6351 | bp->cp_nr_rings = sh ? max_t(int, bp->tx_nr_rings, bp->rx_nr_rings) : |
| 6352 | bp->tx_nr_rings + bp->rx_nr_rings; | ||
| 6352 | bp->num_stat_ctxs = bp->cp_nr_rings; | 6353 | bp->num_stat_ctxs = bp->cp_nr_rings; |
| 6353 | 6354 | ||
| 6354 | if (netif_running(bp->dev)) | 6355 | if (netif_running(bp->dev)) |
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c index ec6cd18842c3..60e2af8678bd 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | |||
| @@ -774,8 +774,8 @@ static int bnxt_vf_set_link(struct bnxt *bp, struct bnxt_vf_info *vf) | |||
| 774 | 774 | ||
| 775 | if (vf->flags & BNXT_VF_LINK_UP) { | 775 | if (vf->flags & BNXT_VF_LINK_UP) { |
| 776 | /* if physical link is down, force link up on VF */ | 776 | /* if physical link is down, force link up on VF */ |
| 777 | if (phy_qcfg_resp.link == | 777 | if (phy_qcfg_resp.link != |
| 778 | PORT_PHY_QCFG_RESP_LINK_NO_LINK) { | 778 | PORT_PHY_QCFG_RESP_LINK_LINK) { |
| 779 | phy_qcfg_resp.link = | 779 | phy_qcfg_resp.link = |
| 780 | PORT_PHY_QCFG_RESP_LINK_LINK; | 780 | PORT_PHY_QCFG_RESP_LINK_LINK; |
| 781 | phy_qcfg_resp.link_speed = cpu_to_le16( | 781 | phy_qcfg_resp.link_speed = cpu_to_le16( |
diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c index f9df4b5ae90e..f42f672b0e7e 100644 --- a/drivers/net/ethernet/brocade/bna/bnad.c +++ b/drivers/net/ethernet/brocade/bna/bnad.c | |||
| @@ -177,6 +177,7 @@ bnad_txcmpl_process(struct bnad *bnad, struct bna_tcb *tcb) | |||
| 177 | return 0; | 177 | return 0; |
| 178 | 178 | ||
| 179 | hw_cons = *(tcb->hw_consumer_index); | 179 | hw_cons = *(tcb->hw_consumer_index); |
| 180 | rmb(); | ||
| 180 | cons = tcb->consumer_index; | 181 | cons = tcb->consumer_index; |
| 181 | q_depth = tcb->q_depth; | 182 | q_depth = tcb->q_depth; |
| 182 | 183 | ||
| @@ -3094,7 +3095,7 @@ bnad_start_xmit(struct sk_buff *skb, struct net_device *netdev) | |||
| 3094 | BNA_QE_INDX_INC(prod, q_depth); | 3095 | BNA_QE_INDX_INC(prod, q_depth); |
| 3095 | tcb->producer_index = prod; | 3096 | tcb->producer_index = prod; |
| 3096 | 3097 | ||
| 3097 | smp_mb(); | 3098 | wmb(); |
| 3098 | 3099 | ||
| 3099 | if (unlikely(!test_bit(BNAD_TXQ_TX_STARTED, &tcb->flags))) | 3100 | if (unlikely(!test_bit(BNAD_TXQ_TX_STARTED, &tcb->flags))) |
| 3100 | return NETDEV_TX_OK; | 3101 | return NETDEV_TX_OK; |
| @@ -3102,7 +3103,6 @@ bnad_start_xmit(struct sk_buff *skb, struct net_device *netdev) | |||
| 3102 | skb_tx_timestamp(skb); | 3103 | skb_tx_timestamp(skb); |
| 3103 | 3104 | ||
| 3104 | bna_txq_prod_indx_doorbell(tcb); | 3105 | bna_txq_prod_indx_doorbell(tcb); |
| 3105 | smp_mb(); | ||
| 3106 | 3106 | ||
| 3107 | return NETDEV_TX_OK; | 3107 | return NETDEV_TX_OK; |
| 3108 | } | 3108 | } |
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h b/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h index 50812a1d67bd..df1573c4a659 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h | |||
| @@ -178,9 +178,9 @@ CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN | |||
| 178 | CH_PCI_ID_TABLE_FENTRY(0x6005), | 178 | CH_PCI_ID_TABLE_FENTRY(0x6005), |
| 179 | CH_PCI_ID_TABLE_FENTRY(0x6006), | 179 | CH_PCI_ID_TABLE_FENTRY(0x6006), |
| 180 | CH_PCI_ID_TABLE_FENTRY(0x6007), | 180 | CH_PCI_ID_TABLE_FENTRY(0x6007), |
| 181 | CH_PCI_ID_TABLE_FENTRY(0x6008), | ||
| 181 | CH_PCI_ID_TABLE_FENTRY(0x6009), | 182 | CH_PCI_ID_TABLE_FENTRY(0x6009), |
| 182 | CH_PCI_ID_TABLE_FENTRY(0x600d), | 183 | CH_PCI_ID_TABLE_FENTRY(0x600d), |
| 183 | CH_PCI_ID_TABLE_FENTRY(0x6010), | ||
| 184 | CH_PCI_ID_TABLE_FENTRY(0x6011), | 184 | CH_PCI_ID_TABLE_FENTRY(0x6011), |
| 185 | CH_PCI_ID_TABLE_FENTRY(0x6014), | 185 | CH_PCI_ID_TABLE_FENTRY(0x6014), |
| 186 | CH_PCI_ID_TABLE_FENTRY(0x6015), | 186 | CH_PCI_ID_TABLE_FENTRY(0x6015), |
diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.c b/drivers/net/ethernet/hisilicon/hns/hnae.c index c54c6fac0d1d..b6ed818f78ff 100644 --- a/drivers/net/ethernet/hisilicon/hns/hnae.c +++ b/drivers/net/ethernet/hisilicon/hns/hnae.c | |||
| @@ -332,8 +332,10 @@ struct hnae_handle *hnae_get_handle(struct device *owner_dev, | |||
| 332 | return ERR_PTR(-ENODEV); | 332 | return ERR_PTR(-ENODEV); |
| 333 | 333 | ||
| 334 | handle = dev->ops->get_handle(dev, port_id); | 334 | handle = dev->ops->get_handle(dev, port_id); |
| 335 | if (IS_ERR(handle)) | 335 | if (IS_ERR(handle)) { |
| 336 | put_device(&dev->cls_dev); | ||
| 336 | return handle; | 337 | return handle; |
| 338 | } | ||
| 337 | 339 | ||
| 338 | handle->dev = dev; | 340 | handle->dev = dev; |
| 339 | handle->owner_dev = owner_dev; | 341 | handle->owner_dev = owner_dev; |
| @@ -356,6 +358,8 @@ out_when_init_queue: | |||
| 356 | for (j = i - 1; j >= 0; j--) | 358 | for (j = i - 1; j >= 0; j--) |
| 357 | hnae_fini_queue(handle->qs[j]); | 359 | hnae_fini_queue(handle->qs[j]); |
| 358 | 360 | ||
| 361 | put_device(&dev->cls_dev); | ||
| 362 | |||
| 359 | return ERR_PTR(-ENOMEM); | 363 | return ERR_PTR(-ENOMEM); |
| 360 | } | 364 | } |
| 361 | EXPORT_SYMBOL(hnae_get_handle); | 365 | EXPORT_SYMBOL(hnae_get_handle); |
| @@ -377,6 +381,8 @@ void hnae_put_handle(struct hnae_handle *h) | |||
| 377 | dev->ops->put_handle(h); | 381 | dev->ops->put_handle(h); |
| 378 | 382 | ||
| 379 | module_put(dev->owner); | 383 | module_put(dev->owner); |
| 384 | |||
| 385 | put_device(&dev->cls_dev); | ||
| 380 | } | 386 | } |
| 381 | EXPORT_SYMBOL(hnae_put_handle); | 387 | EXPORT_SYMBOL(hnae_put_handle); |
| 382 | 388 | ||
diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c index 54efa9a5167b..bd719e25dd76 100644 --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c | |||
| @@ -2446,6 +2446,8 @@ static int ehea_open(struct net_device *dev) | |||
| 2446 | 2446 | ||
| 2447 | netif_info(port, ifup, dev, "enabling port\n"); | 2447 | netif_info(port, ifup, dev, "enabling port\n"); |
| 2448 | 2448 | ||
| 2449 | netif_carrier_off(dev); | ||
| 2450 | |||
| 2449 | ret = ehea_up(dev); | 2451 | ret = ehea_up(dev); |
| 2450 | if (!ret) { | 2452 | if (!ret) { |
| 2451 | port_napi_enable(port); | 2453 | port_napi_enable(port); |
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 5f44c5520fbc..4f3281a03e7e 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c | |||
| @@ -1505,9 +1505,8 @@ static void init_sub_crqs(struct ibmvnic_adapter *adapter, int retry) | |||
| 1505 | adapter->max_rx_add_entries_per_subcrq > entries_page ? | 1505 | adapter->max_rx_add_entries_per_subcrq > entries_page ? |
| 1506 | entries_page : adapter->max_rx_add_entries_per_subcrq; | 1506 | entries_page : adapter->max_rx_add_entries_per_subcrq; |
| 1507 | 1507 | ||
| 1508 | /* Choosing the maximum number of queues supported by firmware*/ | 1508 | adapter->req_tx_queues = adapter->opt_tx_comp_sub_queues; |
| 1509 | adapter->req_tx_queues = adapter->max_tx_queues; | 1509 | adapter->req_rx_queues = adapter->opt_rx_comp_queues; |
| 1510 | adapter->req_rx_queues = adapter->max_rx_queues; | ||
| 1511 | adapter->req_rx_add_queues = adapter->max_rx_add_queues; | 1510 | adapter->req_rx_add_queues = adapter->max_rx_add_queues; |
| 1512 | 1511 | ||
| 1513 | adapter->req_mtu = adapter->max_mtu; | 1512 | adapter->req_mtu = adapter->max_mtu; |
| @@ -3706,7 +3705,7 @@ static int ibmvnic_probe(struct vio_dev *dev, const struct vio_device_id *id) | |||
| 3706 | struct net_device *netdev; | 3705 | struct net_device *netdev; |
| 3707 | unsigned char *mac_addr_p; | 3706 | unsigned char *mac_addr_p; |
| 3708 | struct dentry *ent; | 3707 | struct dentry *ent; |
| 3709 | char buf[16]; /* debugfs name buf */ | 3708 | char buf[17]; /* debugfs name buf */ |
| 3710 | int rc; | 3709 | int rc; |
| 3711 | 3710 | ||
| 3712 | dev_dbg(&dev->dev, "entering ibmvnic_probe for UA 0x%x\n", | 3711 | dev_dbg(&dev->dev, "entering ibmvnic_probe for UA 0x%x\n", |
| @@ -3845,6 +3844,9 @@ static int ibmvnic_remove(struct vio_dev *dev) | |||
| 3845 | if (adapter->debugfs_dir && !IS_ERR(adapter->debugfs_dir)) | 3844 | if (adapter->debugfs_dir && !IS_ERR(adapter->debugfs_dir)) |
| 3846 | debugfs_remove_recursive(adapter->debugfs_dir); | 3845 | debugfs_remove_recursive(adapter->debugfs_dir); |
| 3847 | 3846 | ||
| 3847 | dma_unmap_single(&dev->dev, adapter->stats_token, | ||
| 3848 | sizeof(struct ibmvnic_statistics), DMA_FROM_DEVICE); | ||
| 3849 | |||
| 3848 | if (adapter->ras_comps) | 3850 | if (adapter->ras_comps) |
| 3849 | dma_free_coherent(&dev->dev, | 3851 | dma_free_coherent(&dev->dev, |
| 3850 | adapter->ras_comp_num * | 3852 | adapter->ras_comp_num * |
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index bf5cc55ba24c..5b12022adf1f 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c | |||
| @@ -1381,6 +1381,7 @@ static unsigned int get_rx_coal(struct mv643xx_eth_private *mp) | |||
| 1381 | temp = (val & 0x003fff00) >> 8; | 1381 | temp = (val & 0x003fff00) >> 8; |
| 1382 | 1382 | ||
| 1383 | temp *= 64000000; | 1383 | temp *= 64000000; |
| 1384 | temp += mp->t_clk / 2; | ||
| 1384 | do_div(temp, mp->t_clk); | 1385 | do_div(temp, mp->t_clk); |
| 1385 | 1386 | ||
| 1386 | return (unsigned int)temp; | 1387 | return (unsigned int)temp; |
| @@ -1417,6 +1418,7 @@ static unsigned int get_tx_coal(struct mv643xx_eth_private *mp) | |||
| 1417 | 1418 | ||
| 1418 | temp = (rdlp(mp, TX_FIFO_URGENT_THRESHOLD) & 0x3fff0) >> 4; | 1419 | temp = (rdlp(mp, TX_FIFO_URGENT_THRESHOLD) & 0x3fff0) >> 4; |
| 1419 | temp *= 64000000; | 1420 | temp *= 64000000; |
| 1421 | temp += mp->t_clk / 2; | ||
| 1420 | do_div(temp, mp->t_clk); | 1422 | do_div(temp, mp->t_clk); |
| 1421 | 1423 | ||
| 1422 | return (unsigned int)temp; | 1424 | return (unsigned int)temp; |
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c index 12c99a2655f2..3a47e83d3e07 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c | |||
| @@ -2202,7 +2202,6 @@ void mlx4_en_destroy_netdev(struct net_device *dev) | |||
| 2202 | 2202 | ||
| 2203 | if (!shutdown) | 2203 | if (!shutdown) |
| 2204 | free_netdev(dev); | 2204 | free_netdev(dev); |
| 2205 | dev->ethtool_ops = NULL; | ||
| 2206 | } | 2205 | } |
| 2207 | 2206 | ||
| 2208 | static int mlx4_en_change_mtu(struct net_device *dev, int new_mtu) | 2207 | static int mlx4_en_change_mtu(struct net_device *dev, int new_mtu) |
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index f4c687ce4c59..84e8b250e2af 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c | |||
| @@ -1445,6 +1445,7 @@ static int mlx5e_open_channel(struct mlx5e_priv *priv, int ix, | |||
| 1445 | c->netdev = priv->netdev; | 1445 | c->netdev = priv->netdev; |
| 1446 | c->mkey_be = cpu_to_be32(priv->mdev->mlx5e_res.mkey.key); | 1446 | c->mkey_be = cpu_to_be32(priv->mdev->mlx5e_res.mkey.key); |
| 1447 | c->num_tc = priv->params.num_tc; | 1447 | c->num_tc = priv->params.num_tc; |
| 1448 | c->xdp = !!priv->xdp_prog; | ||
| 1448 | 1449 | ||
| 1449 | if (priv->params.rx_am_enabled) | 1450 | if (priv->params.rx_am_enabled) |
| 1450 | rx_cq_profile = mlx5e_am_get_def_profile(priv->params.rx_cq_period_mode); | 1451 | rx_cq_profile = mlx5e_am_get_def_profile(priv->params.rx_cq_period_mode); |
| @@ -1468,6 +1469,12 @@ static int mlx5e_open_channel(struct mlx5e_priv *priv, int ix, | |||
| 1468 | if (err) | 1469 | if (err) |
| 1469 | goto err_close_tx_cqs; | 1470 | goto err_close_tx_cqs; |
| 1470 | 1471 | ||
| 1472 | /* XDP SQ CQ params are same as normal TXQ sq CQ params */ | ||
| 1473 | err = c->xdp ? mlx5e_open_cq(c, &cparam->tx_cq, &c->xdp_sq.cq, | ||
| 1474 | priv->params.tx_cq_moderation) : 0; | ||
| 1475 | if (err) | ||
| 1476 | goto err_close_rx_cq; | ||
| 1477 | |||
| 1471 | napi_enable(&c->napi); | 1478 | napi_enable(&c->napi); |
| 1472 | 1479 | ||
| 1473 | err = mlx5e_open_sq(c, 0, &cparam->icosq, &c->icosq); | 1480 | err = mlx5e_open_sq(c, 0, &cparam->icosq, &c->icosq); |
| @@ -1488,21 +1495,10 @@ static int mlx5e_open_channel(struct mlx5e_priv *priv, int ix, | |||
| 1488 | } | 1495 | } |
| 1489 | } | 1496 | } |
| 1490 | 1497 | ||
| 1491 | if (priv->xdp_prog) { | 1498 | err = c->xdp ? mlx5e_open_sq(c, 0, &cparam->xdp_sq, &c->xdp_sq) : 0; |
| 1492 | /* XDP SQ CQ params are same as normal TXQ sq CQ params */ | 1499 | if (err) |
| 1493 | err = mlx5e_open_cq(c, &cparam->tx_cq, &c->xdp_sq.cq, | 1500 | goto err_close_sqs; |
| 1494 | priv->params.tx_cq_moderation); | ||
| 1495 | if (err) | ||
| 1496 | goto err_close_sqs; | ||
| 1497 | |||
| 1498 | err = mlx5e_open_sq(c, 0, &cparam->xdp_sq, &c->xdp_sq); | ||
| 1499 | if (err) { | ||
| 1500 | mlx5e_close_cq(&c->xdp_sq.cq); | ||
| 1501 | goto err_close_sqs; | ||
| 1502 | } | ||
| 1503 | } | ||
| 1504 | 1501 | ||
| 1505 | c->xdp = !!priv->xdp_prog; | ||
| 1506 | err = mlx5e_open_rq(c, &cparam->rq, &c->rq); | 1502 | err = mlx5e_open_rq(c, &cparam->rq, &c->rq); |
| 1507 | if (err) | 1503 | if (err) |
| 1508 | goto err_close_xdp_sq; | 1504 | goto err_close_xdp_sq; |
| @@ -1512,7 +1508,8 @@ static int mlx5e_open_channel(struct mlx5e_priv *priv, int ix, | |||
| 1512 | 1508 | ||
| 1513 | return 0; | 1509 | return 0; |
| 1514 | err_close_xdp_sq: | 1510 | err_close_xdp_sq: |
| 1515 | mlx5e_close_sq(&c->xdp_sq); | 1511 | if (c->xdp) |
| 1512 | mlx5e_close_sq(&c->xdp_sq); | ||
| 1516 | 1513 | ||
| 1517 | err_close_sqs: | 1514 | err_close_sqs: |
| 1518 | mlx5e_close_sqs(c); | 1515 | mlx5e_close_sqs(c); |
| @@ -1522,6 +1519,10 @@ err_close_icosq: | |||
| 1522 | 1519 | ||
| 1523 | err_disable_napi: | 1520 | err_disable_napi: |
| 1524 | napi_disable(&c->napi); | 1521 | napi_disable(&c->napi); |
| 1522 | if (c->xdp) | ||
| 1523 | mlx5e_close_cq(&c->xdp_sq.cq); | ||
| 1524 | |||
| 1525 | err_close_rx_cq: | ||
| 1525 | mlx5e_close_cq(&c->rq.cq); | 1526 | mlx5e_close_cq(&c->rq.cq); |
| 1526 | 1527 | ||
| 1527 | err_close_tx_cqs: | 1528 | err_close_tx_cqs: |
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c index 7fe6559e4ab3..bf1c09ca73c0 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | |||
| @@ -308,7 +308,7 @@ static void mlx5e_build_rep_netdev(struct net_device *netdev) | |||
| 308 | netdev->switchdev_ops = &mlx5e_rep_switchdev_ops; | 308 | netdev->switchdev_ops = &mlx5e_rep_switchdev_ops; |
| 309 | #endif | 309 | #endif |
| 310 | 310 | ||
| 311 | netdev->features |= NETIF_F_VLAN_CHALLENGED | NETIF_F_HW_TC; | 311 | netdev->features |= NETIF_F_VLAN_CHALLENGED | NETIF_F_HW_TC | NETIF_F_NETNS_LOCAL; |
| 312 | netdev->hw_features |= NETIF_F_HW_TC; | 312 | netdev->hw_features |= NETIF_F_HW_TC; |
| 313 | 313 | ||
| 314 | eth_hw_addr_random(netdev); | 314 | eth_hw_addr_random(netdev); |
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index ce8c54d18906..6bb21b31cfeb 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | |||
| @@ -237,12 +237,15 @@ static int parse_cls_flower(struct mlx5e_priv *priv, struct mlx5_flow_spec *spec | |||
| 237 | skb_flow_dissector_target(f->dissector, | 237 | skb_flow_dissector_target(f->dissector, |
| 238 | FLOW_DISSECTOR_KEY_VLAN, | 238 | FLOW_DISSECTOR_KEY_VLAN, |
| 239 | f->mask); | 239 | f->mask); |
| 240 | if (mask->vlan_id) { | 240 | if (mask->vlan_id || mask->vlan_priority) { |
| 241 | MLX5_SET(fte_match_set_lyr_2_4, headers_c, vlan_tag, 1); | 241 | MLX5_SET(fte_match_set_lyr_2_4, headers_c, vlan_tag, 1); |
| 242 | MLX5_SET(fte_match_set_lyr_2_4, headers_v, vlan_tag, 1); | 242 | MLX5_SET(fte_match_set_lyr_2_4, headers_v, vlan_tag, 1); |
| 243 | 243 | ||
| 244 | MLX5_SET(fte_match_set_lyr_2_4, headers_c, first_vid, mask->vlan_id); | 244 | MLX5_SET(fte_match_set_lyr_2_4, headers_c, first_vid, mask->vlan_id); |
| 245 | MLX5_SET(fte_match_set_lyr_2_4, headers_v, first_vid, key->vlan_id); | 245 | MLX5_SET(fte_match_set_lyr_2_4, headers_v, first_vid, key->vlan_id); |
| 246 | |||
| 247 | MLX5_SET(fte_match_set_lyr_2_4, headers_c, first_prio, mask->vlan_priority); | ||
| 248 | MLX5_SET(fte_match_set_lyr_2_4, headers_v, first_prio, key->vlan_priority); | ||
| 246 | } | 249 | } |
| 247 | } | 250 | } |
| 248 | 251 | ||
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c index c55ad8d00c05..d239f5d0ea36 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | |||
| @@ -57,7 +57,8 @@ mlx5_eswitch_add_offloaded_rule(struct mlx5_eswitch *esw, | |||
| 57 | if (esw->mode != SRIOV_OFFLOADS) | 57 | if (esw->mode != SRIOV_OFFLOADS) |
| 58 | return ERR_PTR(-EOPNOTSUPP); | 58 | return ERR_PTR(-EOPNOTSUPP); |
| 59 | 59 | ||
| 60 | action = attr->action; | 60 | /* per flow vlan pop/push is emulated, don't set that into the firmware */ |
| 61 | action = attr->action & ~(MLX5_FLOW_CONTEXT_ACTION_VLAN_PUSH | MLX5_FLOW_CONTEXT_ACTION_VLAN_POP); | ||
| 61 | 62 | ||
| 62 | if (action & MLX5_FLOW_CONTEXT_ACTION_FWD_DEST) { | 63 | if (action & MLX5_FLOW_CONTEXT_ACTION_FWD_DEST) { |
| 63 | dest.type = MLX5_FLOW_DESTINATION_TYPE_VPORT; | 64 | dest.type = MLX5_FLOW_DESTINATION_TYPE_VPORT; |
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c index 89696048b045..914e5466f729 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | |||
| @@ -1690,7 +1690,7 @@ static int init_root_ns(struct mlx5_flow_steering *steering) | |||
| 1690 | { | 1690 | { |
| 1691 | 1691 | ||
| 1692 | steering->root_ns = create_root_ns(steering, FS_FT_NIC_RX); | 1692 | steering->root_ns = create_root_ns(steering, FS_FT_NIC_RX); |
| 1693 | if (IS_ERR_OR_NULL(steering->root_ns)) | 1693 | if (!steering->root_ns) |
| 1694 | goto cleanup; | 1694 | goto cleanup; |
| 1695 | 1695 | ||
| 1696 | if (init_root_tree(steering, &root_fs, &steering->root_ns->ns.node)) | 1696 | if (init_root_tree(steering, &root_fs, &steering->root_ns->ns.node)) |
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c index d5433c49b2b0..3eb931585b3e 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c | |||
| @@ -1226,6 +1226,9 @@ static int init_one(struct pci_dev *pdev, | |||
| 1226 | 1226 | ||
| 1227 | pci_set_drvdata(pdev, dev); | 1227 | pci_set_drvdata(pdev, dev); |
| 1228 | 1228 | ||
| 1229 | dev->pdev = pdev; | ||
| 1230 | dev->event = mlx5_core_event; | ||
| 1231 | |||
| 1229 | if (prof_sel < 0 || prof_sel >= ARRAY_SIZE(profile)) { | 1232 | if (prof_sel < 0 || prof_sel >= ARRAY_SIZE(profile)) { |
| 1230 | mlx5_core_warn(dev, | 1233 | mlx5_core_warn(dev, |
| 1231 | "selected profile out of range, selecting default (%d)\n", | 1234 | "selected profile out of range, selecting default (%d)\n", |
| @@ -1233,8 +1236,6 @@ static int init_one(struct pci_dev *pdev, | |||
| 1233 | prof_sel = MLX5_DEFAULT_PROF; | 1236 | prof_sel = MLX5_DEFAULT_PROF; |
| 1234 | } | 1237 | } |
| 1235 | dev->profile = &profile[prof_sel]; | 1238 | dev->profile = &profile[prof_sel]; |
| 1236 | dev->pdev = pdev; | ||
| 1237 | dev->event = mlx5_core_event; | ||
| 1238 | 1239 | ||
| 1239 | INIT_LIST_HEAD(&priv->ctx_list); | 1240 | INIT_LIST_HEAD(&priv->ctx_list); |
| 1240 | spin_lock_init(&priv->ctx_lock); | 1241 | spin_lock_init(&priv->ctx_lock); |
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c index 1ec0a4ce3c46..dda5761e91bc 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c | |||
| @@ -231,7 +231,7 @@ mlxsw_sp_span_entry_create(struct mlxsw_sp_port *port) | |||
| 231 | 231 | ||
| 232 | span_entry->used = true; | 232 | span_entry->used = true; |
| 233 | span_entry->id = index; | 233 | span_entry->id = index; |
| 234 | span_entry->ref_count = 0; | 234 | span_entry->ref_count = 1; |
| 235 | span_entry->local_port = local_port; | 235 | span_entry->local_port = local_port; |
| 236 | return span_entry; | 236 | return span_entry; |
| 237 | } | 237 | } |
| @@ -270,6 +270,7 @@ static struct mlxsw_sp_span_entry | |||
| 270 | 270 | ||
| 271 | span_entry = mlxsw_sp_span_entry_find(port); | 271 | span_entry = mlxsw_sp_span_entry_find(port); |
| 272 | if (span_entry) { | 272 | if (span_entry) { |
| 273 | /* Already exists, just take a reference */ | ||
| 273 | span_entry->ref_count++; | 274 | span_entry->ref_count++; |
| 274 | return span_entry; | 275 | return span_entry; |
| 275 | } | 276 | } |
| @@ -280,6 +281,7 @@ static struct mlxsw_sp_span_entry | |||
| 280 | static int mlxsw_sp_span_entry_put(struct mlxsw_sp *mlxsw_sp, | 281 | static int mlxsw_sp_span_entry_put(struct mlxsw_sp *mlxsw_sp, |
| 281 | struct mlxsw_sp_span_entry *span_entry) | 282 | struct mlxsw_sp_span_entry *span_entry) |
| 282 | { | 283 | { |
| 284 | WARN_ON(!span_entry->ref_count); | ||
| 283 | if (--span_entry->ref_count == 0) | 285 | if (--span_entry->ref_count == 0) |
| 284 | mlxsw_sp_span_entry_destroy(mlxsw_sp, span_entry); | 286 | mlxsw_sp_span_entry_destroy(mlxsw_sp, span_entry); |
| 285 | return 0; | 287 | return 0; |
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.h b/drivers/net/ethernet/mellanox/mlxsw/spectrum.h index 9b22863a924b..97bbc1d21df8 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.h +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.h | |||
| @@ -115,7 +115,7 @@ struct mlxsw_sp_rif { | |||
| 115 | struct mlxsw_sp_mid { | 115 | struct mlxsw_sp_mid { |
| 116 | struct list_head list; | 116 | struct list_head list; |
| 117 | unsigned char addr[ETH_ALEN]; | 117 | unsigned char addr[ETH_ALEN]; |
| 118 | u16 vid; | 118 | u16 fid; |
| 119 | u16 mid; | 119 | u16 mid; |
| 120 | unsigned int ref_count; | 120 | unsigned int ref_count; |
| 121 | }; | 121 | }; |
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c index 4573da2c5560..e83072da6272 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | |||
| @@ -594,21 +594,22 @@ static int mlxsw_sp_vrs_init(struct mlxsw_sp *mlxsw_sp) | |||
| 594 | return 0; | 594 | return 0; |
| 595 | } | 595 | } |
| 596 | 596 | ||
| 597 | static void mlxsw_sp_router_fib_flush(struct mlxsw_sp *mlxsw_sp); | ||
| 598 | |||
| 597 | static void mlxsw_sp_vrs_fini(struct mlxsw_sp *mlxsw_sp) | 599 | static void mlxsw_sp_vrs_fini(struct mlxsw_sp *mlxsw_sp) |
| 598 | { | 600 | { |
| 601 | mlxsw_sp_router_fib_flush(mlxsw_sp); | ||
| 599 | kfree(mlxsw_sp->router.vrs); | 602 | kfree(mlxsw_sp->router.vrs); |
| 600 | } | 603 | } |
| 601 | 604 | ||
| 602 | struct mlxsw_sp_neigh_key { | 605 | struct mlxsw_sp_neigh_key { |
| 603 | unsigned char addr[sizeof(struct in6_addr)]; | 606 | struct neighbour *n; |
| 604 | struct net_device *dev; | ||
| 605 | }; | 607 | }; |
| 606 | 608 | ||
| 607 | struct mlxsw_sp_neigh_entry { | 609 | struct mlxsw_sp_neigh_entry { |
| 608 | struct rhash_head ht_node; | 610 | struct rhash_head ht_node; |
| 609 | struct mlxsw_sp_neigh_key key; | 611 | struct mlxsw_sp_neigh_key key; |
| 610 | u16 rif; | 612 | u16 rif; |
| 611 | struct neighbour *n; | ||
| 612 | bool offloaded; | 613 | bool offloaded; |
| 613 | struct delayed_work dw; | 614 | struct delayed_work dw; |
| 614 | struct mlxsw_sp_port *mlxsw_sp_port; | 615 | struct mlxsw_sp_port *mlxsw_sp_port; |
| @@ -646,19 +647,15 @@ mlxsw_sp_neigh_entry_remove(struct mlxsw_sp *mlxsw_sp, | |||
| 646 | static void mlxsw_sp_router_neigh_update_hw(struct work_struct *work); | 647 | static void mlxsw_sp_router_neigh_update_hw(struct work_struct *work); |
| 647 | 648 | ||
| 648 | static struct mlxsw_sp_neigh_entry * | 649 | static struct mlxsw_sp_neigh_entry * |
| 649 | mlxsw_sp_neigh_entry_create(const void *addr, size_t addr_len, | 650 | mlxsw_sp_neigh_entry_create(struct neighbour *n, u16 rif) |
| 650 | struct net_device *dev, u16 rif, | ||
| 651 | struct neighbour *n) | ||
| 652 | { | 651 | { |
| 653 | struct mlxsw_sp_neigh_entry *neigh_entry; | 652 | struct mlxsw_sp_neigh_entry *neigh_entry; |
| 654 | 653 | ||
| 655 | neigh_entry = kzalloc(sizeof(*neigh_entry), GFP_ATOMIC); | 654 | neigh_entry = kzalloc(sizeof(*neigh_entry), GFP_ATOMIC); |
| 656 | if (!neigh_entry) | 655 | if (!neigh_entry) |
| 657 | return NULL; | 656 | return NULL; |
| 658 | memcpy(neigh_entry->key.addr, addr, addr_len); | 657 | neigh_entry->key.n = n; |
| 659 | neigh_entry->key.dev = dev; | ||
| 660 | neigh_entry->rif = rif; | 658 | neigh_entry->rif = rif; |
| 661 | neigh_entry->n = n; | ||
| 662 | INIT_DELAYED_WORK(&neigh_entry->dw, mlxsw_sp_router_neigh_update_hw); | 659 | INIT_DELAYED_WORK(&neigh_entry->dw, mlxsw_sp_router_neigh_update_hw); |
| 663 | INIT_LIST_HEAD(&neigh_entry->nexthop_list); | 660 | INIT_LIST_HEAD(&neigh_entry->nexthop_list); |
| 664 | return neigh_entry; | 661 | return neigh_entry; |
| @@ -671,13 +668,11 @@ mlxsw_sp_neigh_entry_destroy(struct mlxsw_sp_neigh_entry *neigh_entry) | |||
| 671 | } | 668 | } |
| 672 | 669 | ||
| 673 | static struct mlxsw_sp_neigh_entry * | 670 | static struct mlxsw_sp_neigh_entry * |
| 674 | mlxsw_sp_neigh_entry_lookup(struct mlxsw_sp *mlxsw_sp, const void *addr, | 671 | mlxsw_sp_neigh_entry_lookup(struct mlxsw_sp *mlxsw_sp, struct neighbour *n) |
| 675 | size_t addr_len, struct net_device *dev) | ||
| 676 | { | 672 | { |
| 677 | struct mlxsw_sp_neigh_key key = {{ 0 } }; | 673 | struct mlxsw_sp_neigh_key key; |
| 678 | 674 | ||
| 679 | memcpy(key.addr, addr, addr_len); | 675 | key.n = n; |
| 680 | key.dev = dev; | ||
| 681 | return rhashtable_lookup_fast(&mlxsw_sp->router.neigh_ht, | 676 | return rhashtable_lookup_fast(&mlxsw_sp->router.neigh_ht, |
| 682 | &key, mlxsw_sp_neigh_ht_params); | 677 | &key, mlxsw_sp_neigh_ht_params); |
| 683 | } | 678 | } |
| @@ -689,26 +684,20 @@ int mlxsw_sp_router_neigh_construct(struct net_device *dev, | |||
| 689 | struct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp; | 684 | struct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp; |
| 690 | struct mlxsw_sp_neigh_entry *neigh_entry; | 685 | struct mlxsw_sp_neigh_entry *neigh_entry; |
| 691 | struct mlxsw_sp_rif *r; | 686 | struct mlxsw_sp_rif *r; |
| 692 | u32 dip; | ||
| 693 | int err; | 687 | int err; |
| 694 | 688 | ||
| 695 | if (n->tbl != &arp_tbl) | 689 | if (n->tbl != &arp_tbl) |
| 696 | return 0; | 690 | return 0; |
| 697 | 691 | ||
| 698 | dip = ntohl(*((__be32 *) n->primary_key)); | 692 | neigh_entry = mlxsw_sp_neigh_entry_lookup(mlxsw_sp, n); |
| 699 | neigh_entry = mlxsw_sp_neigh_entry_lookup(mlxsw_sp, &dip, sizeof(dip), | 693 | if (neigh_entry) |
| 700 | n->dev); | ||
| 701 | if (neigh_entry) { | ||
| 702 | WARN_ON(neigh_entry->n != n); | ||
| 703 | return 0; | 694 | return 0; |
| 704 | } | ||
| 705 | 695 | ||
| 706 | r = mlxsw_sp_rif_find_by_dev(mlxsw_sp, n->dev); | 696 | r = mlxsw_sp_rif_find_by_dev(mlxsw_sp, n->dev); |
| 707 | if (WARN_ON(!r)) | 697 | if (WARN_ON(!r)) |
| 708 | return -EINVAL; | 698 | return -EINVAL; |
| 709 | 699 | ||
| 710 | neigh_entry = mlxsw_sp_neigh_entry_create(&dip, sizeof(dip), n->dev, | 700 | neigh_entry = mlxsw_sp_neigh_entry_create(n, r->rif); |
| 711 | r->rif, n); | ||
| 712 | if (!neigh_entry) | 701 | if (!neigh_entry) |
| 713 | return -ENOMEM; | 702 | return -ENOMEM; |
| 714 | err = mlxsw_sp_neigh_entry_insert(mlxsw_sp, neigh_entry); | 703 | err = mlxsw_sp_neigh_entry_insert(mlxsw_sp, neigh_entry); |
| @@ -727,14 +716,11 @@ void mlxsw_sp_router_neigh_destroy(struct net_device *dev, | |||
| 727 | struct mlxsw_sp_port *mlxsw_sp_port = netdev_priv(dev); | 716 | struct mlxsw_sp_port *mlxsw_sp_port = netdev_priv(dev); |
| 728 | struct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp; | 717 | struct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp; |
| 729 | struct mlxsw_sp_neigh_entry *neigh_entry; | 718 | struct mlxsw_sp_neigh_entry *neigh_entry; |
| 730 | u32 dip; | ||
| 731 | 719 | ||
| 732 | if (n->tbl != &arp_tbl) | 720 | if (n->tbl != &arp_tbl) |
| 733 | return; | 721 | return; |
| 734 | 722 | ||
| 735 | dip = ntohl(*((__be32 *) n->primary_key)); | 723 | neigh_entry = mlxsw_sp_neigh_entry_lookup(mlxsw_sp, n); |
| 736 | neigh_entry = mlxsw_sp_neigh_entry_lookup(mlxsw_sp, &dip, sizeof(dip), | ||
| 737 | n->dev); | ||
| 738 | if (!neigh_entry) | 724 | if (!neigh_entry) |
| 739 | return; | 725 | return; |
| 740 | mlxsw_sp_neigh_entry_remove(mlxsw_sp, neigh_entry); | 726 | mlxsw_sp_neigh_entry_remove(mlxsw_sp, neigh_entry); |
| @@ -817,6 +803,26 @@ static void mlxsw_sp_router_neigh_rec_process(struct mlxsw_sp *mlxsw_sp, | |||
| 817 | } | 803 | } |
| 818 | } | 804 | } |
| 819 | 805 | ||
| 806 | static bool mlxsw_sp_router_rauhtd_is_full(char *rauhtd_pl) | ||
| 807 | { | ||
| 808 | u8 num_rec, last_rec_index, num_entries; | ||
| 809 | |||
| 810 | num_rec = mlxsw_reg_rauhtd_num_rec_get(rauhtd_pl); | ||
| 811 | last_rec_index = num_rec - 1; | ||
| 812 | |||
| 813 | if (num_rec < MLXSW_REG_RAUHTD_REC_MAX_NUM) | ||
| 814 | return false; | ||
| 815 | if (mlxsw_reg_rauhtd_rec_type_get(rauhtd_pl, last_rec_index) == | ||
| 816 | MLXSW_REG_RAUHTD_TYPE_IPV6) | ||
| 817 | return true; | ||
| 818 | |||
| 819 | num_entries = mlxsw_reg_rauhtd_ipv4_rec_num_entries_get(rauhtd_pl, | ||
| 820 | last_rec_index); | ||
| 821 | if (++num_entries == MLXSW_REG_RAUHTD_IPV4_ENT_PER_REC) | ||
| 822 | return true; | ||
| 823 | return false; | ||
| 824 | } | ||
| 825 | |||
| 820 | static int mlxsw_sp_router_neighs_update_rauhtd(struct mlxsw_sp *mlxsw_sp) | 826 | static int mlxsw_sp_router_neighs_update_rauhtd(struct mlxsw_sp *mlxsw_sp) |
| 821 | { | 827 | { |
| 822 | char *rauhtd_pl; | 828 | char *rauhtd_pl; |
| @@ -843,7 +849,7 @@ static int mlxsw_sp_router_neighs_update_rauhtd(struct mlxsw_sp *mlxsw_sp) | |||
| 843 | for (i = 0; i < num_rec; i++) | 849 | for (i = 0; i < num_rec; i++) |
| 844 | mlxsw_sp_router_neigh_rec_process(mlxsw_sp, rauhtd_pl, | 850 | mlxsw_sp_router_neigh_rec_process(mlxsw_sp, rauhtd_pl, |
| 845 | i); | 851 | i); |
| 846 | } while (num_rec); | 852 | } while (mlxsw_sp_router_rauhtd_is_full(rauhtd_pl)); |
| 847 | rtnl_unlock(); | 853 | rtnl_unlock(); |
| 848 | 854 | ||
| 849 | kfree(rauhtd_pl); | 855 | kfree(rauhtd_pl); |
| @@ -862,7 +868,7 @@ static void mlxsw_sp_router_neighs_update_nh(struct mlxsw_sp *mlxsw_sp) | |||
| 862 | * is active regardless of the traffic. | 868 | * is active regardless of the traffic. |
| 863 | */ | 869 | */ |
| 864 | if (!list_empty(&neigh_entry->nexthop_list)) | 870 | if (!list_empty(&neigh_entry->nexthop_list)) |
| 865 | neigh_event_send(neigh_entry->n, NULL); | 871 | neigh_event_send(neigh_entry->key.n, NULL); |
| 866 | } | 872 | } |
| 867 | rtnl_unlock(); | 873 | rtnl_unlock(); |
| 868 | } | 874 | } |
| @@ -908,9 +914,9 @@ static void mlxsw_sp_router_probe_unresolved_nexthops(struct work_struct *work) | |||
| 908 | rtnl_lock(); | 914 | rtnl_lock(); |
| 909 | list_for_each_entry(neigh_entry, &mlxsw_sp->router.nexthop_neighs_list, | 915 | list_for_each_entry(neigh_entry, &mlxsw_sp->router.nexthop_neighs_list, |
| 910 | nexthop_neighs_list_node) { | 916 | nexthop_neighs_list_node) { |
| 911 | if (!(neigh_entry->n->nud_state & NUD_VALID) && | 917 | if (!(neigh_entry->key.n->nud_state & NUD_VALID) && |
| 912 | !list_empty(&neigh_entry->nexthop_list)) | 918 | !list_empty(&neigh_entry->nexthop_list)) |
| 913 | neigh_event_send(neigh_entry->n, NULL); | 919 | neigh_event_send(neigh_entry->key.n, NULL); |
| 914 | } | 920 | } |
| 915 | rtnl_unlock(); | 921 | rtnl_unlock(); |
| 916 | 922 | ||
| @@ -927,7 +933,7 @@ static void mlxsw_sp_router_neigh_update_hw(struct work_struct *work) | |||
| 927 | { | 933 | { |
| 928 | struct mlxsw_sp_neigh_entry *neigh_entry = | 934 | struct mlxsw_sp_neigh_entry *neigh_entry = |
| 929 | container_of(work, struct mlxsw_sp_neigh_entry, dw.work); | 935 | container_of(work, struct mlxsw_sp_neigh_entry, dw.work); |
| 930 | struct neighbour *n = neigh_entry->n; | 936 | struct neighbour *n = neigh_entry->key.n; |
| 931 | struct mlxsw_sp_port *mlxsw_sp_port = neigh_entry->mlxsw_sp_port; | 937 | struct mlxsw_sp_port *mlxsw_sp_port = neigh_entry->mlxsw_sp_port; |
| 932 | struct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp; | 938 | struct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp; |
| 933 | char rauht_pl[MLXSW_REG_RAUHT_LEN]; | 939 | char rauht_pl[MLXSW_REG_RAUHT_LEN]; |
| @@ -1030,11 +1036,8 @@ int mlxsw_sp_router_netevent_event(struct notifier_block *unused, | |||
| 1030 | 1036 | ||
| 1031 | mlxsw_sp = mlxsw_sp_port->mlxsw_sp; | 1037 | mlxsw_sp = mlxsw_sp_port->mlxsw_sp; |
| 1032 | dip = ntohl(*((__be32 *) n->primary_key)); | 1038 | dip = ntohl(*((__be32 *) n->primary_key)); |
| 1033 | neigh_entry = mlxsw_sp_neigh_entry_lookup(mlxsw_sp, | 1039 | neigh_entry = mlxsw_sp_neigh_entry_lookup(mlxsw_sp, n); |
| 1034 | &dip, | 1040 | if (WARN_ON(!neigh_entry)) { |
| 1035 | sizeof(__be32), | ||
| 1036 | dev); | ||
| 1037 | if (WARN_ON(!neigh_entry) || WARN_ON(neigh_entry->n != n)) { | ||
| 1038 | mlxsw_sp_port_dev_put(mlxsw_sp_port); | 1041 | mlxsw_sp_port_dev_put(mlxsw_sp_port); |
| 1039 | return NOTIFY_DONE; | 1042 | return NOTIFY_DONE; |
| 1040 | } | 1043 | } |
| @@ -1343,33 +1346,26 @@ static int mlxsw_sp_nexthop_init(struct mlxsw_sp *mlxsw_sp, | |||
| 1343 | struct fib_nh *fib_nh) | 1346 | struct fib_nh *fib_nh) |
| 1344 | { | 1347 | { |
| 1345 | struct mlxsw_sp_neigh_entry *neigh_entry; | 1348 | struct mlxsw_sp_neigh_entry *neigh_entry; |
| 1346 | u32 gwip = ntohl(fib_nh->nh_gw); | ||
| 1347 | struct net_device *dev = fib_nh->nh_dev; | 1349 | struct net_device *dev = fib_nh->nh_dev; |
| 1348 | struct neighbour *n; | 1350 | struct neighbour *n; |
| 1349 | u8 nud_state; | 1351 | u8 nud_state; |
| 1350 | 1352 | ||
| 1351 | neigh_entry = mlxsw_sp_neigh_entry_lookup(mlxsw_sp, &gwip, | 1353 | /* Take a reference of neigh here ensuring that neigh would |
| 1352 | sizeof(gwip), dev); | 1354 | * not be detructed before the nexthop entry is finished. |
| 1353 | if (!neigh_entry) { | 1355 | * The reference is taken either in neigh_lookup() or |
| 1354 | __be32 gwipn = htonl(gwip); | 1356 | * in neith_create() in case n is not found. |
| 1355 | 1357 | */ | |
| 1356 | n = neigh_create(&arp_tbl, &gwipn, dev); | 1358 | n = neigh_lookup(&arp_tbl, &fib_nh->nh_gw, dev); |
| 1359 | if (!n) { | ||
| 1360 | n = neigh_create(&arp_tbl, &fib_nh->nh_gw, dev); | ||
| 1357 | if (IS_ERR(n)) | 1361 | if (IS_ERR(n)) |
| 1358 | return PTR_ERR(n); | 1362 | return PTR_ERR(n); |
| 1359 | neigh_event_send(n, NULL); | 1363 | neigh_event_send(n, NULL); |
| 1360 | neigh_entry = mlxsw_sp_neigh_entry_lookup(mlxsw_sp, &gwip, | 1364 | } |
| 1361 | sizeof(gwip), dev); | 1365 | neigh_entry = mlxsw_sp_neigh_entry_lookup(mlxsw_sp, n); |
| 1362 | if (!neigh_entry) { | 1366 | if (!neigh_entry) { |
| 1363 | neigh_release(n); | 1367 | neigh_release(n); |
| 1364 | return -EINVAL; | 1368 | return -EINVAL; |
| 1365 | } | ||
| 1366 | } else { | ||
| 1367 | /* Take a reference of neigh here ensuring that neigh would | ||
| 1368 | * not be detructed before the nexthop entry is finished. | ||
| 1369 | * The second branch takes the reference in neith_create() | ||
| 1370 | */ | ||
| 1371 | n = neigh_entry->n; | ||
| 1372 | neigh_clone(n); | ||
| 1373 | } | 1369 | } |
| 1374 | 1370 | ||
| 1375 | /* If that is the first nexthop connected to that neigh, add to | 1371 | /* If that is the first nexthop connected to that neigh, add to |
| @@ -1403,7 +1399,7 @@ static void mlxsw_sp_nexthop_fini(struct mlxsw_sp *mlxsw_sp, | |||
| 1403 | if (list_empty(&nh->neigh_entry->nexthop_list)) | 1399 | if (list_empty(&nh->neigh_entry->nexthop_list)) |
| 1404 | list_del(&nh->neigh_entry->nexthop_neighs_list_node); | 1400 | list_del(&nh->neigh_entry->nexthop_neighs_list_node); |
| 1405 | 1401 | ||
| 1406 | neigh_release(neigh_entry->n); | 1402 | neigh_release(neigh_entry->key.n); |
| 1407 | } | 1403 | } |
| 1408 | 1404 | ||
| 1409 | static struct mlxsw_sp_nexthop_group * | 1405 | static struct mlxsw_sp_nexthop_group * |
| @@ -1463,11 +1459,11 @@ static bool mlxsw_sp_nexthop_match(struct mlxsw_sp_nexthop *nh, | |||
| 1463 | 1459 | ||
| 1464 | for (i = 0; i < fi->fib_nhs; i++) { | 1460 | for (i = 0; i < fi->fib_nhs; i++) { |
| 1465 | struct fib_nh *fib_nh = &fi->fib_nh[i]; | 1461 | struct fib_nh *fib_nh = &fi->fib_nh[i]; |
| 1466 | u32 gwip = ntohl(fib_nh->nh_gw); | 1462 | struct neighbour *n = nh->neigh_entry->key.n; |
| 1467 | 1463 | ||
| 1468 | if (memcmp(nh->neigh_entry->key.addr, | 1464 | if (memcmp(n->primary_key, &fib_nh->nh_gw, |
| 1469 | &gwip, sizeof(u32)) == 0 && | 1465 | sizeof(fib_nh->nh_gw)) == 0 && |
| 1470 | nh->neigh_entry->key.dev == fib_nh->nh_dev) | 1466 | n->dev == fib_nh->nh_dev) |
| 1471 | return true; | 1467 | return true; |
| 1472 | } | 1468 | } |
| 1473 | return false; | 1469 | return false; |
| @@ -1874,18 +1870,18 @@ static int mlxsw_sp_router_set_abort_trap(struct mlxsw_sp *mlxsw_sp) | |||
| 1874 | return mlxsw_reg_write(mlxsw_sp->core, MLXSW_REG(ralue), ralue_pl); | 1870 | return mlxsw_reg_write(mlxsw_sp->core, MLXSW_REG(ralue), ralue_pl); |
| 1875 | } | 1871 | } |
| 1876 | 1872 | ||
| 1877 | static void mlxsw_sp_router_fib4_abort(struct mlxsw_sp *mlxsw_sp) | 1873 | static void mlxsw_sp_router_fib_flush(struct mlxsw_sp *mlxsw_sp) |
| 1878 | { | 1874 | { |
| 1879 | struct mlxsw_resources *resources; | 1875 | struct mlxsw_resources *resources; |
| 1880 | struct mlxsw_sp_fib_entry *fib_entry; | 1876 | struct mlxsw_sp_fib_entry *fib_entry; |
| 1881 | struct mlxsw_sp_fib_entry *tmp; | 1877 | struct mlxsw_sp_fib_entry *tmp; |
| 1882 | struct mlxsw_sp_vr *vr; | 1878 | struct mlxsw_sp_vr *vr; |
| 1883 | int i; | 1879 | int i; |
| 1884 | int err; | ||
| 1885 | 1880 | ||
| 1886 | resources = mlxsw_core_resources_get(mlxsw_sp->core); | 1881 | resources = mlxsw_core_resources_get(mlxsw_sp->core); |
| 1887 | for (i = 0; i < resources->max_virtual_routers; i++) { | 1882 | for (i = 0; i < resources->max_virtual_routers; i++) { |
| 1888 | vr = &mlxsw_sp->router.vrs[i]; | 1883 | vr = &mlxsw_sp->router.vrs[i]; |
| 1884 | |||
| 1889 | if (!vr->used) | 1885 | if (!vr->used) |
| 1890 | continue; | 1886 | continue; |
| 1891 | 1887 | ||
| @@ -1901,6 +1897,13 @@ static void mlxsw_sp_router_fib4_abort(struct mlxsw_sp *mlxsw_sp) | |||
| 1901 | break; | 1897 | break; |
| 1902 | } | 1898 | } |
| 1903 | } | 1899 | } |
| 1900 | } | ||
| 1901 | |||
| 1902 | static void mlxsw_sp_router_fib4_abort(struct mlxsw_sp *mlxsw_sp) | ||
| 1903 | { | ||
| 1904 | int err; | ||
| 1905 | |||
| 1906 | mlxsw_sp_router_fib_flush(mlxsw_sp); | ||
| 1904 | mlxsw_sp->router.aborted = true; | 1907 | mlxsw_sp->router.aborted = true; |
| 1905 | err = mlxsw_sp_router_set_abort_trap(mlxsw_sp); | 1908 | err = mlxsw_sp_router_set_abort_trap(mlxsw_sp); |
| 1906 | if (err) | 1909 | if (err) |
| @@ -1958,6 +1961,9 @@ static int mlxsw_sp_router_fib_event(struct notifier_block *nb, | |||
| 1958 | struct fib_entry_notifier_info *fen_info = ptr; | 1961 | struct fib_entry_notifier_info *fen_info = ptr; |
| 1959 | int err; | 1962 | int err; |
| 1960 | 1963 | ||
| 1964 | if (!net_eq(fen_info->info.net, &init_net)) | ||
| 1965 | return NOTIFY_DONE; | ||
| 1966 | |||
| 1961 | switch (event) { | 1967 | switch (event) { |
| 1962 | case FIB_EVENT_ENTRY_ADD: | 1968 | case FIB_EVENT_ENTRY_ADD: |
| 1963 | err = mlxsw_sp_router_fib4_add(mlxsw_sp, fen_info); | 1969 | err = mlxsw_sp_router_fib4_add(mlxsw_sp, fen_info); |
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c index 5e00c79e8133..1e2c8eca3af1 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | |||
| @@ -929,12 +929,12 @@ static int mlxsw_sp_port_smid_set(struct mlxsw_sp_port *mlxsw_sp_port, u16 mid, | |||
| 929 | 929 | ||
| 930 | static struct mlxsw_sp_mid *__mlxsw_sp_mc_get(struct mlxsw_sp *mlxsw_sp, | 930 | static struct mlxsw_sp_mid *__mlxsw_sp_mc_get(struct mlxsw_sp *mlxsw_sp, |
| 931 | const unsigned char *addr, | 931 | const unsigned char *addr, |
| 932 | u16 vid) | 932 | u16 fid) |
| 933 | { | 933 | { |
| 934 | struct mlxsw_sp_mid *mid; | 934 | struct mlxsw_sp_mid *mid; |
| 935 | 935 | ||
| 936 | list_for_each_entry(mid, &mlxsw_sp->br_mids.list, list) { | 936 | list_for_each_entry(mid, &mlxsw_sp->br_mids.list, list) { |
| 937 | if (ether_addr_equal(mid->addr, addr) && mid->vid == vid) | 937 | if (ether_addr_equal(mid->addr, addr) && mid->fid == fid) |
| 938 | return mid; | 938 | return mid; |
| 939 | } | 939 | } |
| 940 | return NULL; | 940 | return NULL; |
| @@ -942,7 +942,7 @@ static struct mlxsw_sp_mid *__mlxsw_sp_mc_get(struct mlxsw_sp *mlxsw_sp, | |||
| 942 | 942 | ||
| 943 | static struct mlxsw_sp_mid *__mlxsw_sp_mc_alloc(struct mlxsw_sp *mlxsw_sp, | 943 | static struct mlxsw_sp_mid *__mlxsw_sp_mc_alloc(struct mlxsw_sp *mlxsw_sp, |
| 944 | const unsigned char *addr, | 944 | const unsigned char *addr, |
| 945 | u16 vid) | 945 | u16 fid) |
| 946 | { | 946 | { |
| 947 | struct mlxsw_sp_mid *mid; | 947 | struct mlxsw_sp_mid *mid; |
| 948 | u16 mid_idx; | 948 | u16 mid_idx; |
| @@ -958,7 +958,7 @@ static struct mlxsw_sp_mid *__mlxsw_sp_mc_alloc(struct mlxsw_sp *mlxsw_sp, | |||
| 958 | 958 | ||
| 959 | set_bit(mid_idx, mlxsw_sp->br_mids.mapped); | 959 | set_bit(mid_idx, mlxsw_sp->br_mids.mapped); |
| 960 | ether_addr_copy(mid->addr, addr); | 960 | ether_addr_copy(mid->addr, addr); |
| 961 | mid->vid = vid; | 961 | mid->fid = fid; |
| 962 | mid->mid = mid_idx; | 962 | mid->mid = mid_idx; |
| 963 | mid->ref_count = 0; | 963 | mid->ref_count = 0; |
| 964 | list_add_tail(&mid->list, &mlxsw_sp->br_mids.list); | 964 | list_add_tail(&mid->list, &mlxsw_sp->br_mids.list); |
| @@ -991,9 +991,9 @@ static int mlxsw_sp_port_mdb_add(struct mlxsw_sp_port *mlxsw_sp_port, | |||
| 991 | if (switchdev_trans_ph_prepare(trans)) | 991 | if (switchdev_trans_ph_prepare(trans)) |
| 992 | return 0; | 992 | return 0; |
| 993 | 993 | ||
| 994 | mid = __mlxsw_sp_mc_get(mlxsw_sp, mdb->addr, mdb->vid); | 994 | mid = __mlxsw_sp_mc_get(mlxsw_sp, mdb->addr, fid); |
| 995 | if (!mid) { | 995 | if (!mid) { |
| 996 | mid = __mlxsw_sp_mc_alloc(mlxsw_sp, mdb->addr, mdb->vid); | 996 | mid = __mlxsw_sp_mc_alloc(mlxsw_sp, mdb->addr, fid); |
| 997 | if (!mid) { | 997 | if (!mid) { |
| 998 | netdev_err(dev, "Unable to allocate MC group\n"); | 998 | netdev_err(dev, "Unable to allocate MC group\n"); |
| 999 | return -ENOMEM; | 999 | return -ENOMEM; |
| @@ -1137,7 +1137,7 @@ static int mlxsw_sp_port_mdb_del(struct mlxsw_sp_port *mlxsw_sp_port, | |||
| 1137 | u16 mid_idx; | 1137 | u16 mid_idx; |
| 1138 | int err = 0; | 1138 | int err = 0; |
| 1139 | 1139 | ||
| 1140 | mid = __mlxsw_sp_mc_get(mlxsw_sp, mdb->addr, mdb->vid); | 1140 | mid = __mlxsw_sp_mc_get(mlxsw_sp, mdb->addr, fid); |
| 1141 | if (!mid) { | 1141 | if (!mid) { |
| 1142 | netdev_err(dev, "Unable to remove port from MC DB\n"); | 1142 | netdev_err(dev, "Unable to remove port from MC DB\n"); |
| 1143 | return -EINVAL; | 1143 | return -EINVAL; |
diff --git a/drivers/net/ethernet/qlogic/qed/qed_hsi.h b/drivers/net/ethernet/qlogic/qed/qed_hsi.h index 72eee29c677f..2777d5bb4380 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_hsi.h +++ b/drivers/net/ethernet/qlogic/qed/qed_hsi.h | |||
| @@ -727,9 +727,6 @@ struct core_tx_bd_flags { | |||
| 727 | #define CORE_TX_BD_FLAGS_L4_PROTOCOL_SHIFT 6 | 727 | #define CORE_TX_BD_FLAGS_L4_PROTOCOL_SHIFT 6 |
| 728 | #define CORE_TX_BD_FLAGS_L4_PSEUDO_CSUM_MODE_MASK 0x1 | 728 | #define CORE_TX_BD_FLAGS_L4_PSEUDO_CSUM_MODE_MASK 0x1 |
| 729 | #define CORE_TX_BD_FLAGS_L4_PSEUDO_CSUM_MODE_SHIFT 7 | 729 | #define CORE_TX_BD_FLAGS_L4_PSEUDO_CSUM_MODE_SHIFT 7 |
| 730 | #define CORE_TX_BD_FLAGS_ROCE_FLAV_MASK 0x1 | ||
| 731 | #define CORE_TX_BD_FLAGS_ROCE_FLAV_SHIFT 12 | ||
| 732 | |||
| 733 | }; | 730 | }; |
| 734 | 731 | ||
| 735 | struct core_tx_bd { | 732 | struct core_tx_bd { |
diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c index 63e1a1b0ef8e..f95385cbbd40 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c +++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c | |||
| @@ -1119,6 +1119,7 @@ static void qed_ll2_prepare_tx_packet_set_bd(struct qed_hwfn *p_hwfn, | |||
| 1119 | start_bd->bd_flags.as_bitfield |= CORE_TX_BD_FLAGS_START_BD_MASK << | 1119 | start_bd->bd_flags.as_bitfield |= CORE_TX_BD_FLAGS_START_BD_MASK << |
| 1120 | CORE_TX_BD_FLAGS_START_BD_SHIFT; | 1120 | CORE_TX_BD_FLAGS_START_BD_SHIFT; |
| 1121 | SET_FIELD(start_bd->bitfield0, CORE_TX_BD_NBDS, num_of_bds); | 1121 | SET_FIELD(start_bd->bitfield0, CORE_TX_BD_NBDS, num_of_bds); |
| 1122 | SET_FIELD(start_bd->bitfield0, CORE_TX_BD_ROCE_FLAV, type); | ||
| 1122 | DMA_REGPAIR_LE(start_bd->addr, first_frag); | 1123 | DMA_REGPAIR_LE(start_bd->addr, first_frag); |
| 1123 | start_bd->nbytes = cpu_to_le16(first_frag_len); | 1124 | start_bd->nbytes = cpu_to_le16(first_frag_len); |
| 1124 | 1125 | ||
diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c index c418360ba02a..333c7442e48a 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_main.c +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c | |||
| @@ -839,20 +839,19 @@ static void qed_update_pf_params(struct qed_dev *cdev, | |||
| 839 | { | 839 | { |
| 840 | int i; | 840 | int i; |
| 841 | 841 | ||
| 842 | if (IS_ENABLED(CONFIG_QED_RDMA)) { | ||
| 843 | params->rdma_pf_params.num_qps = QED_ROCE_QPS; | ||
| 844 | params->rdma_pf_params.min_dpis = QED_ROCE_DPIS; | ||
| 845 | /* divide by 3 the MRs to avoid MF ILT overflow */ | ||
| 846 | params->rdma_pf_params.num_mrs = RDMA_MAX_TIDS; | ||
| 847 | params->rdma_pf_params.gl_pi = QED_ROCE_PROTOCOL_INDEX; | ||
| 848 | } | ||
| 849 | |||
| 842 | for (i = 0; i < cdev->num_hwfns; i++) { | 850 | for (i = 0; i < cdev->num_hwfns; i++) { |
| 843 | struct qed_hwfn *p_hwfn = &cdev->hwfns[i]; | 851 | struct qed_hwfn *p_hwfn = &cdev->hwfns[i]; |
| 844 | 852 | ||
| 845 | p_hwfn->pf_params = *params; | 853 | p_hwfn->pf_params = *params; |
| 846 | } | 854 | } |
| 847 | |||
| 848 | if (!IS_ENABLED(CONFIG_QED_RDMA)) | ||
| 849 | return; | ||
| 850 | |||
| 851 | params->rdma_pf_params.num_qps = QED_ROCE_QPS; | ||
| 852 | params->rdma_pf_params.min_dpis = QED_ROCE_DPIS; | ||
| 853 | /* divide by 3 the MRs to avoid MF ILT overflow */ | ||
| 854 | params->rdma_pf_params.num_mrs = RDMA_MAX_TIDS; | ||
| 855 | params->rdma_pf_params.gl_pi = QED_ROCE_PROTOCOL_INDEX; | ||
| 856 | } | 855 | } |
| 857 | 856 | ||
| 858 | static int qed_slowpath_start(struct qed_dev *cdev, | 857 | static int qed_slowpath_start(struct qed_dev *cdev, |
diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c index 12251a1032d1..7567cc464b88 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c | |||
| @@ -175,16 +175,23 @@ static void qede_get_strings_stats(struct qede_dev *edev, u8 *buf) | |||
| 175 | for (i = 0, k = 0; i < QEDE_QUEUE_CNT(edev); i++) { | 175 | for (i = 0, k = 0; i < QEDE_QUEUE_CNT(edev); i++) { |
| 176 | int tc; | 176 | int tc; |
| 177 | 177 | ||
| 178 | for (j = 0; j < QEDE_NUM_RQSTATS; j++) | 178 | if (edev->fp_array[i].type & QEDE_FASTPATH_RX) { |
| 179 | sprintf(buf + (k + j) * ETH_GSTRING_LEN, | 179 | for (j = 0; j < QEDE_NUM_RQSTATS; j++) |
| 180 | "%d: %s", i, qede_rqstats_arr[j].string); | ||
| 181 | k += QEDE_NUM_RQSTATS; | ||
| 182 | for (tc = 0; tc < edev->num_tc; tc++) { | ||
| 183 | for (j = 0; j < QEDE_NUM_TQSTATS; j++) | ||
| 184 | sprintf(buf + (k + j) * ETH_GSTRING_LEN, | 180 | sprintf(buf + (k + j) * ETH_GSTRING_LEN, |
| 185 | "%d.%d: %s", i, tc, | 181 | "%d: %s", i, |
| 186 | qede_tqstats_arr[j].string); | 182 | qede_rqstats_arr[j].string); |
| 187 | k += QEDE_NUM_TQSTATS; | 183 | k += QEDE_NUM_RQSTATS; |
| 184 | } | ||
| 185 | |||
| 186 | if (edev->fp_array[i].type & QEDE_FASTPATH_TX) { | ||
| 187 | for (tc = 0; tc < edev->num_tc; tc++) { | ||
| 188 | for (j = 0; j < QEDE_NUM_TQSTATS; j++) | ||
| 189 | sprintf(buf + (k + j) * | ||
| 190 | ETH_GSTRING_LEN, | ||
| 191 | "%d.%d: %s", i, tc, | ||
| 192 | qede_tqstats_arr[j].string); | ||
| 193 | k += QEDE_NUM_TQSTATS; | ||
| 194 | } | ||
| 188 | } | 195 | } |
| 189 | } | 196 | } |
| 190 | 197 | ||
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c index 7def29aaf65c..85f46dbecd5b 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_main.c +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c | |||
| @@ -2839,7 +2839,7 @@ static int qede_alloc_sge_mem(struct qede_dev *edev, struct qede_rx_queue *rxq) | |||
| 2839 | } | 2839 | } |
| 2840 | 2840 | ||
| 2841 | mapping = dma_map_page(&edev->pdev->dev, replace_buf->data, 0, | 2841 | mapping = dma_map_page(&edev->pdev->dev, replace_buf->data, 0, |
| 2842 | rxq->rx_buf_size, DMA_FROM_DEVICE); | 2842 | PAGE_SIZE, DMA_FROM_DEVICE); |
| 2843 | if (unlikely(dma_mapping_error(&edev->pdev->dev, mapping))) { | 2843 | if (unlikely(dma_mapping_error(&edev->pdev->dev, mapping))) { |
| 2844 | DP_NOTICE(edev, | 2844 | DP_NOTICE(edev, |
| 2845 | "Failed to map TPA replacement buffer\n"); | 2845 | "Failed to map TPA replacement buffer\n"); |
diff --git a/drivers/net/ethernet/qualcomm/emac/emac-mac.c b/drivers/net/ethernet/qualcomm/emac/emac-mac.c index 6fb3bee904d3..0b4deb31e742 100644 --- a/drivers/net/ethernet/qualcomm/emac/emac-mac.c +++ b/drivers/net/ethernet/qualcomm/emac/emac-mac.c | |||
| @@ -575,10 +575,11 @@ void emac_mac_start(struct emac_adapter *adpt) | |||
| 575 | 575 | ||
| 576 | mac |= TXEN | RXEN; /* enable RX/TX */ | 576 | mac |= TXEN | RXEN; /* enable RX/TX */ |
| 577 | 577 | ||
| 578 | /* We don't have ethtool support yet, so force flow-control mode | 578 | /* Configure MAC flow control to match the PHY's settings. */ |
| 579 | * to 'full' always. | 579 | if (phydev->pause) |
| 580 | */ | 580 | mac |= RXFC; |
| 581 | mac |= TXFC | RXFC; | 581 | if (phydev->pause != phydev->asym_pause) |
| 582 | mac |= TXFC; | ||
| 582 | 583 | ||
| 583 | /* setup link speed */ | 584 | /* setup link speed */ |
| 584 | mac &= ~SPEED_MASK; | 585 | mac &= ~SPEED_MASK; |
| @@ -1003,6 +1004,12 @@ int emac_mac_up(struct emac_adapter *adpt) | |||
| 1003 | writel((u32)~DIS_INT, adpt->base + EMAC_INT_STATUS); | 1004 | writel((u32)~DIS_INT, adpt->base + EMAC_INT_STATUS); |
| 1004 | writel(adpt->irq.mask, adpt->base + EMAC_INT_MASK); | 1005 | writel(adpt->irq.mask, adpt->base + EMAC_INT_MASK); |
| 1005 | 1006 | ||
| 1007 | /* Enable pause frames. Without this feature, the EMAC has been shown | ||
| 1008 | * to receive (and drop) frames with FCS errors at gigabit connections. | ||
| 1009 | */ | ||
| 1010 | adpt->phydev->supported |= SUPPORTED_Pause | SUPPORTED_Asym_Pause; | ||
| 1011 | adpt->phydev->advertising |= SUPPORTED_Pause | SUPPORTED_Asym_Pause; | ||
| 1012 | |||
| 1006 | adpt->phydev->irq = PHY_IGNORE_INTERRUPT; | 1013 | adpt->phydev->irq = PHY_IGNORE_INTERRUPT; |
| 1007 | phy_start(adpt->phydev); | 1014 | phy_start(adpt->phydev); |
| 1008 | 1015 | ||
diff --git a/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c b/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c index 75c1b530e39e..72fe343c7a36 100644 --- a/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c +++ b/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | |||
| @@ -421,7 +421,7 @@ static const struct emac_reg_write sgmii_v2_laned[] = { | |||
| 421 | /* CDR Settings */ | 421 | /* CDR Settings */ |
| 422 | {EMAC_SGMII_LN_UCDR_FO_GAIN_MODE0, | 422 | {EMAC_SGMII_LN_UCDR_FO_GAIN_MODE0, |
| 423 | UCDR_STEP_BY_TWO_MODE0 | UCDR_xO_GAIN_MODE(10)}, | 423 | UCDR_STEP_BY_TWO_MODE0 | UCDR_xO_GAIN_MODE(10)}, |
| 424 | {EMAC_SGMII_LN_UCDR_SO_GAIN_MODE0, UCDR_xO_GAIN_MODE(6)}, | 424 | {EMAC_SGMII_LN_UCDR_SO_GAIN_MODE0, UCDR_xO_GAIN_MODE(0)}, |
| 425 | {EMAC_SGMII_LN_UCDR_SO_CONFIG, UCDR_ENABLE | UCDR_SO_SATURATION(12)}, | 425 | {EMAC_SGMII_LN_UCDR_SO_CONFIG, UCDR_ENABLE | UCDR_SO_SATURATION(12)}, |
| 426 | 426 | ||
| 427 | /* TX/RX Settings */ | 427 | /* TX/RX Settings */ |
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c index 3cf3557106c2..6b89e4a7b164 100644 --- a/drivers/net/ethernet/sfc/efx.c +++ b/drivers/net/ethernet/sfc/efx.c | |||
| @@ -485,6 +485,9 @@ efx_copy_channel(const struct efx_channel *old_channel) | |||
| 485 | *channel = *old_channel; | 485 | *channel = *old_channel; |
| 486 | 486 | ||
| 487 | channel->napi_dev = NULL; | 487 | channel->napi_dev = NULL; |
| 488 | INIT_HLIST_NODE(&channel->napi_str.napi_hash_node); | ||
| 489 | channel->napi_str.napi_id = 0; | ||
| 490 | channel->napi_str.state = 0; | ||
| 488 | memset(&channel->eventq, 0, sizeof(channel->eventq)); | 491 | memset(&channel->eventq, 0, sizeof(channel->eventq)); |
| 489 | 492 | ||
| 490 | for (j = 0; j < EFX_TXQ_TYPES; j++) { | 493 | for (j = 0; j < EFX_TXQ_TYPES; j++) { |
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 48e71fad4210..e2c94ec4edd0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | |||
| @@ -880,6 +880,13 @@ static int stmmac_init_phy(struct net_device *dev) | |||
| 880 | return -ENODEV; | 880 | return -ENODEV; |
| 881 | } | 881 | } |
| 882 | 882 | ||
| 883 | /* stmmac_adjust_link will change this to PHY_IGNORE_INTERRUPT to avoid | ||
| 884 | * subsequent PHY polling, make sure we force a link transition if | ||
| 885 | * we have a UP/DOWN/UP transition | ||
| 886 | */ | ||
| 887 | if (phydev->is_pseudo_fixed_link) | ||
| 888 | phydev->irq = PHY_POLL; | ||
| 889 | |||
| 883 | pr_debug("stmmac_init_phy: %s: attached to PHY (UID 0x%x)" | 890 | pr_debug("stmmac_init_phy: %s: attached to PHY (UID 0x%x)" |
| 884 | " Link = %d\n", dev->name, phydev->phy_id, phydev->link); | 891 | " Link = %d\n", dev->name, phydev->phy_id, phydev->link); |
| 885 | 892 | ||
diff --git a/drivers/net/ethernet/ti/cpsw-phy-sel.c b/drivers/net/ethernet/ti/cpsw-phy-sel.c index 054a8dd23dae..ba1e45ff6aae 100644 --- a/drivers/net/ethernet/ti/cpsw-phy-sel.c +++ b/drivers/net/ethernet/ti/cpsw-phy-sel.c | |||
| @@ -176,9 +176,12 @@ void cpsw_phy_sel(struct device *dev, phy_interface_t phy_mode, int slave) | |||
| 176 | } | 176 | } |
| 177 | 177 | ||
| 178 | dev = bus_find_device(&platform_bus_type, NULL, node, match); | 178 | dev = bus_find_device(&platform_bus_type, NULL, node, match); |
| 179 | of_node_put(node); | ||
| 179 | priv = dev_get_drvdata(dev); | 180 | priv = dev_get_drvdata(dev); |
| 180 | 181 | ||
| 181 | priv->cpsw_phy_sel(priv, phy_mode, slave); | 182 | priv->cpsw_phy_sel(priv, phy_mode, slave); |
| 183 | |||
| 184 | put_device(dev); | ||
| 182 | } | 185 | } |
| 183 | EXPORT_SYMBOL_GPL(cpsw_phy_sel); | 186 | EXPORT_SYMBOL_GPL(cpsw_phy_sel); |
| 184 | 187 | ||
diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c index 2fd94a5bc1f3..84fbe5714f8b 100644 --- a/drivers/net/ethernet/ti/davinci_emac.c +++ b/drivers/net/ethernet/ti/davinci_emac.c | |||
| @@ -1410,6 +1410,7 @@ static int emac_dev_open(struct net_device *ndev) | |||
| 1410 | int i = 0; | 1410 | int i = 0; |
| 1411 | struct emac_priv *priv = netdev_priv(ndev); | 1411 | struct emac_priv *priv = netdev_priv(ndev); |
| 1412 | struct phy_device *phydev = NULL; | 1412 | struct phy_device *phydev = NULL; |
| 1413 | struct device *phy = NULL; | ||
| 1413 | 1414 | ||
| 1414 | ret = pm_runtime_get_sync(&priv->pdev->dev); | 1415 | ret = pm_runtime_get_sync(&priv->pdev->dev); |
| 1415 | if (ret < 0) { | 1416 | if (ret < 0) { |
| @@ -1488,19 +1489,20 @@ static int emac_dev_open(struct net_device *ndev) | |||
| 1488 | 1489 | ||
| 1489 | /* use the first phy on the bus if pdata did not give us a phy id */ | 1490 | /* use the first phy on the bus if pdata did not give us a phy id */ |
| 1490 | if (!phydev && !priv->phy_id) { | 1491 | if (!phydev && !priv->phy_id) { |
| 1491 | struct device *phy; | ||
| 1492 | |||
| 1493 | phy = bus_find_device(&mdio_bus_type, NULL, NULL, | 1492 | phy = bus_find_device(&mdio_bus_type, NULL, NULL, |
| 1494 | match_first_device); | 1493 | match_first_device); |
| 1495 | if (phy) | 1494 | if (phy) { |
| 1496 | priv->phy_id = dev_name(phy); | 1495 | priv->phy_id = dev_name(phy); |
| 1496 | if (!priv->phy_id || !*priv->phy_id) | ||
| 1497 | put_device(phy); | ||
| 1498 | } | ||
| 1497 | } | 1499 | } |
| 1498 | 1500 | ||
| 1499 | if (!phydev && priv->phy_id && *priv->phy_id) { | 1501 | if (!phydev && priv->phy_id && *priv->phy_id) { |
| 1500 | phydev = phy_connect(ndev, priv->phy_id, | 1502 | phydev = phy_connect(ndev, priv->phy_id, |
| 1501 | &emac_adjust_link, | 1503 | &emac_adjust_link, |
| 1502 | PHY_INTERFACE_MODE_MII); | 1504 | PHY_INTERFACE_MODE_MII); |
| 1503 | 1505 | put_device(phy); /* reference taken by bus_find_device */ | |
| 1504 | if (IS_ERR(phydev)) { | 1506 | if (IS_ERR(phydev)) { |
| 1505 | dev_err(emac_dev, "could not connect to phy %s\n", | 1507 | dev_err(emac_dev, "could not connect to phy %s\n", |
| 1506 | priv->phy_id); | 1508 | priv->phy_id); |
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c index 446ea580ad42..928c1dca2673 100644 --- a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c +++ b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | |||
| @@ -1694,7 +1694,7 @@ struct gelic_wl_scan_info *gelic_wl_find_best_bss(struct gelic_wl_info *wl) | |||
| 1694 | pr_debug("%s: bssid matched\n", __func__); | 1694 | pr_debug("%s: bssid matched\n", __func__); |
| 1695 | break; | 1695 | break; |
| 1696 | } else { | 1696 | } else { |
| 1697 | pr_debug("%s: bssid unmached\n", __func__); | 1697 | pr_debug("%s: bssid unmatched\n", __func__); |
| 1698 | continue; | 1698 | continue; |
| 1699 | } | 1699 | } |
| 1700 | } | 1700 | } |
diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c index 7f127dc1b7ba..fa32391720fe 100644 --- a/drivers/net/ethernet/xscale/ixp4xx_eth.c +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c | |||
| @@ -708,8 +708,7 @@ static int eth_poll(struct napi_struct *napi, int budget) | |||
| 708 | if (!qmgr_stat_below_low_watermark(rxq) && | 708 | if (!qmgr_stat_below_low_watermark(rxq) && |
| 709 | napi_reschedule(napi)) { /* not empty again */ | 709 | napi_reschedule(napi)) { /* not empty again */ |
| 710 | #if DEBUG_RX | 710 | #if DEBUG_RX |
| 711 | printk(KERN_DEBUG "%s: eth_poll" | 711 | printk(KERN_DEBUG "%s: eth_poll napi_reschedule succeeded\n", |
| 712 | " napi_reschedule successed\n", | ||
| 713 | dev->name); | 712 | dev->name); |
| 714 | #endif | 713 | #endif |
| 715 | qmgr_disable_irq(rxq); | 714 | qmgr_disable_irq(rxq); |
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 3234fcdea317..d2d6f12a112f 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c | |||
| @@ -1278,6 +1278,7 @@ int macvlan_common_newlink(struct net *src_net, struct net_device *dev, | |||
| 1278 | struct net_device *lowerdev; | 1278 | struct net_device *lowerdev; |
| 1279 | int err; | 1279 | int err; |
| 1280 | int macmode; | 1280 | int macmode; |
| 1281 | bool create = false; | ||
| 1281 | 1282 | ||
| 1282 | if (!tb[IFLA_LINK]) | 1283 | if (!tb[IFLA_LINK]) |
| 1283 | return -EINVAL; | 1284 | return -EINVAL; |
| @@ -1304,12 +1305,18 @@ int macvlan_common_newlink(struct net *src_net, struct net_device *dev, | |||
| 1304 | err = macvlan_port_create(lowerdev); | 1305 | err = macvlan_port_create(lowerdev); |
| 1305 | if (err < 0) | 1306 | if (err < 0) |
| 1306 | return err; | 1307 | return err; |
| 1308 | create = true; | ||
| 1307 | } | 1309 | } |
| 1308 | port = macvlan_port_get_rtnl(lowerdev); | 1310 | port = macvlan_port_get_rtnl(lowerdev); |
| 1309 | 1311 | ||
| 1310 | /* Only 1 macvlan device can be created in passthru mode */ | 1312 | /* Only 1 macvlan device can be created in passthru mode */ |
| 1311 | if (port->passthru) | 1313 | if (port->passthru) { |
| 1312 | return -EINVAL; | 1314 | /* The macvlan port must be not created this time, |
| 1315 | * still goto destroy_macvlan_port for readability. | ||
| 1316 | */ | ||
| 1317 | err = -EINVAL; | ||
| 1318 | goto destroy_macvlan_port; | ||
| 1319 | } | ||
| 1313 | 1320 | ||
| 1314 | vlan->lowerdev = lowerdev; | 1321 | vlan->lowerdev = lowerdev; |
| 1315 | vlan->dev = dev; | 1322 | vlan->dev = dev; |
| @@ -1325,24 +1332,28 @@ int macvlan_common_newlink(struct net *src_net, struct net_device *dev, | |||
| 1325 | vlan->flags = nla_get_u16(data[IFLA_MACVLAN_FLAGS]); | 1332 | vlan->flags = nla_get_u16(data[IFLA_MACVLAN_FLAGS]); |
| 1326 | 1333 | ||
| 1327 | if (vlan->mode == MACVLAN_MODE_PASSTHRU) { | 1334 | if (vlan->mode == MACVLAN_MODE_PASSTHRU) { |
| 1328 | if (port->count) | 1335 | if (port->count) { |
| 1329 | return -EINVAL; | 1336 | err = -EINVAL; |
| 1337 | goto destroy_macvlan_port; | ||
| 1338 | } | ||
| 1330 | port->passthru = true; | 1339 | port->passthru = true; |
| 1331 | eth_hw_addr_inherit(dev, lowerdev); | 1340 | eth_hw_addr_inherit(dev, lowerdev); |
| 1332 | } | 1341 | } |
| 1333 | 1342 | ||
| 1334 | if (data && data[IFLA_MACVLAN_MACADDR_MODE]) { | 1343 | if (data && data[IFLA_MACVLAN_MACADDR_MODE]) { |
| 1335 | if (vlan->mode != MACVLAN_MODE_SOURCE) | 1344 | if (vlan->mode != MACVLAN_MODE_SOURCE) { |
| 1336 | return -EINVAL; | 1345 | err = -EINVAL; |
| 1346 | goto destroy_macvlan_port; | ||
| 1347 | } | ||
| 1337 | macmode = nla_get_u32(data[IFLA_MACVLAN_MACADDR_MODE]); | 1348 | macmode = nla_get_u32(data[IFLA_MACVLAN_MACADDR_MODE]); |
| 1338 | err = macvlan_changelink_sources(vlan, macmode, data); | 1349 | err = macvlan_changelink_sources(vlan, macmode, data); |
| 1339 | if (err) | 1350 | if (err) |
| 1340 | return err; | 1351 | goto destroy_macvlan_port; |
| 1341 | } | 1352 | } |
| 1342 | 1353 | ||
| 1343 | err = register_netdevice(dev); | 1354 | err = register_netdevice(dev); |
| 1344 | if (err < 0) | 1355 | if (err < 0) |
| 1345 | return err; | 1356 | goto destroy_macvlan_port; |
| 1346 | 1357 | ||
| 1347 | dev->priv_flags |= IFF_MACVLAN; | 1358 | dev->priv_flags |= IFF_MACVLAN; |
| 1348 | err = netdev_upper_dev_link(lowerdev, dev); | 1359 | err = netdev_upper_dev_link(lowerdev, dev); |
| @@ -1357,7 +1368,9 @@ int macvlan_common_newlink(struct net *src_net, struct net_device *dev, | |||
| 1357 | 1368 | ||
| 1358 | unregister_netdev: | 1369 | unregister_netdev: |
| 1359 | unregister_netdevice(dev); | 1370 | unregister_netdevice(dev); |
| 1360 | 1371 | destroy_macvlan_port: | |
| 1372 | if (create) | ||
| 1373 | macvlan_port_destroy(port->dev); | ||
| 1361 | return err; | 1374 | return err; |
| 1362 | } | 1375 | } |
| 1363 | EXPORT_SYMBOL_GPL(macvlan_common_newlink); | 1376 | EXPORT_SYMBOL_GPL(macvlan_common_newlink); |
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index e977ba931878..1a4bf8acad78 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c | |||
| @@ -723,6 +723,7 @@ struct phy_device *phy_connect(struct net_device *dev, const char *bus_id, | |||
| 723 | phydev = to_phy_device(d); | 723 | phydev = to_phy_device(d); |
| 724 | 724 | ||
| 725 | rc = phy_connect_direct(dev, phydev, handler, interface); | 725 | rc = phy_connect_direct(dev, phydev, handler, interface); |
| 726 | put_device(d); | ||
| 726 | if (rc) | 727 | if (rc) |
| 727 | return ERR_PTR(rc); | 728 | return ERR_PTR(rc); |
| 728 | 729 | ||
| @@ -953,6 +954,7 @@ struct phy_device *phy_attach(struct net_device *dev, const char *bus_id, | |||
| 953 | phydev = to_phy_device(d); | 954 | phydev = to_phy_device(d); |
| 954 | 955 | ||
| 955 | rc = phy_attach_direct(dev, phydev, phydev->dev_flags, interface); | 956 | rc = phy_attach_direct(dev, phydev, phydev->dev_flags, interface); |
| 957 | put_device(d); | ||
| 956 | if (rc) | 958 | if (rc) |
| 957 | return ERR_PTR(rc); | 959 | return ERR_PTR(rc); |
| 958 | 960 | ||
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index e6338c16081a..8a6675d92b98 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c | |||
| @@ -1656,6 +1656,19 @@ static const struct driver_info ax88178a_info = { | |||
| 1656 | .tx_fixup = ax88179_tx_fixup, | 1656 | .tx_fixup = ax88179_tx_fixup, |
| 1657 | }; | 1657 | }; |
| 1658 | 1658 | ||
| 1659 | static const struct driver_info cypress_GX3_info = { | ||
| 1660 | .description = "Cypress GX3 SuperSpeed to Gigabit Ethernet Controller", | ||
| 1661 | .bind = ax88179_bind, | ||
| 1662 | .unbind = ax88179_unbind, | ||
| 1663 | .status = ax88179_status, | ||
| 1664 | .link_reset = ax88179_link_reset, | ||
| 1665 | .reset = ax88179_reset, | ||
| 1666 | .stop = ax88179_stop, | ||
| 1667 | .flags = FLAG_ETHER | FLAG_FRAMING_AX, | ||
| 1668 | .rx_fixup = ax88179_rx_fixup, | ||
| 1669 | .tx_fixup = ax88179_tx_fixup, | ||
| 1670 | }; | ||
| 1671 | |||
| 1659 | static const struct driver_info dlink_dub1312_info = { | 1672 | static const struct driver_info dlink_dub1312_info = { |
| 1660 | .description = "D-Link DUB-1312 USB 3.0 to Gigabit Ethernet Adapter", | 1673 | .description = "D-Link DUB-1312 USB 3.0 to Gigabit Ethernet Adapter", |
| 1661 | .bind = ax88179_bind, | 1674 | .bind = ax88179_bind, |
| @@ -1718,6 +1731,10 @@ static const struct usb_device_id products[] = { | |||
| 1718 | USB_DEVICE(0x0b95, 0x178a), | 1731 | USB_DEVICE(0x0b95, 0x178a), |
| 1719 | .driver_info = (unsigned long)&ax88178a_info, | 1732 | .driver_info = (unsigned long)&ax88178a_info, |
| 1720 | }, { | 1733 | }, { |
| 1734 | /* Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller */ | ||
| 1735 | USB_DEVICE(0x04b4, 0x3610), | ||
| 1736 | .driver_info = (unsigned long)&cypress_GX3_info, | ||
| 1737 | }, { | ||
| 1721 | /* D-Link DUB-1312 USB 3.0 to Gigabit Ethernet Adapter */ | 1738 | /* D-Link DUB-1312 USB 3.0 to Gigabit Ethernet Adapter */ |
| 1722 | USB_DEVICE(0x2001, 0x4a00), | 1739 | USB_DEVICE(0x2001, 0x4a00), |
| 1723 | .driver_info = (unsigned long)&dlink_dub1312_info, | 1740 | .driver_info = (unsigned long)&dlink_dub1312_info, |
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 44d439f50961..efb84f092492 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c | |||
| @@ -1730,7 +1730,7 @@ static u8 r8152_rx_csum(struct r8152 *tp, struct rx_desc *rx_desc) | |||
| 1730 | u8 checksum = CHECKSUM_NONE; | 1730 | u8 checksum = CHECKSUM_NONE; |
| 1731 | u32 opts2, opts3; | 1731 | u32 opts2, opts3; |
| 1732 | 1732 | ||
| 1733 | if (tp->version == RTL_VER_01) | 1733 | if (tp->version == RTL_VER_01 || tp->version == RTL_VER_02) |
| 1734 | goto return_result; | 1734 | goto return_result; |
| 1735 | 1735 | ||
| 1736 | opts2 = le32_to_cpu(rx_desc->opts2); | 1736 | opts2 = le32_to_cpu(rx_desc->opts2); |
| @@ -1745,7 +1745,7 @@ static u8 r8152_rx_csum(struct r8152 *tp, struct rx_desc *rx_desc) | |||
| 1745 | checksum = CHECKSUM_NONE; | 1745 | checksum = CHECKSUM_NONE; |
| 1746 | else | 1746 | else |
| 1747 | checksum = CHECKSUM_UNNECESSARY; | 1747 | checksum = CHECKSUM_UNNECESSARY; |
| 1748 | } else if (RD_IPV6_CS) { | 1748 | } else if (opts2 & RD_IPV6_CS) { |
| 1749 | if ((opts2 & RD_UDP_CS) && !(opts3 & UDPF)) | 1749 | if ((opts2 & RD_UDP_CS) && !(opts3 & UDPF)) |
| 1750 | checksum = CHECKSUM_UNNECESSARY; | 1750 | checksum = CHECKSUM_UNNECESSARY; |
| 1751 | else if ((opts2 & RD_TCP_CS) && !(opts3 & TCPF)) | 1751 | else if ((opts2 & RD_TCP_CS) && !(opts3 & TCPF)) |
| @@ -3266,10 +3266,8 @@ static int rtl8152_open(struct net_device *netdev) | |||
| 3266 | goto out; | 3266 | goto out; |
| 3267 | 3267 | ||
| 3268 | res = usb_autopm_get_interface(tp->intf); | 3268 | res = usb_autopm_get_interface(tp->intf); |
| 3269 | if (res < 0) { | 3269 | if (res < 0) |
| 3270 | free_all_mem(tp); | 3270 | goto out_free; |
| 3271 | goto out; | ||
| 3272 | } | ||
| 3273 | 3271 | ||
| 3274 | mutex_lock(&tp->control); | 3272 | mutex_lock(&tp->control); |
| 3275 | 3273 | ||
| @@ -3285,10 +3283,9 @@ static int rtl8152_open(struct net_device *netdev) | |||
| 3285 | netif_device_detach(tp->netdev); | 3283 | netif_device_detach(tp->netdev); |
| 3286 | netif_warn(tp, ifup, netdev, "intr_urb submit failed: %d\n", | 3284 | netif_warn(tp, ifup, netdev, "intr_urb submit failed: %d\n", |
| 3287 | res); | 3285 | res); |
| 3288 | free_all_mem(tp); | 3286 | goto out_unlock; |
| 3289 | } else { | ||
| 3290 | napi_enable(&tp->napi); | ||
| 3291 | } | 3287 | } |
| 3288 | napi_enable(&tp->napi); | ||
| 3292 | 3289 | ||
| 3293 | mutex_unlock(&tp->control); | 3290 | mutex_unlock(&tp->control); |
| 3294 | 3291 | ||
| @@ -3297,7 +3294,13 @@ static int rtl8152_open(struct net_device *netdev) | |||
| 3297 | tp->pm_notifier.notifier_call = rtl_notifier; | 3294 | tp->pm_notifier.notifier_call = rtl_notifier; |
| 3298 | register_pm_notifier(&tp->pm_notifier); | 3295 | register_pm_notifier(&tp->pm_notifier); |
| 3299 | #endif | 3296 | #endif |
| 3297 | return 0; | ||
| 3300 | 3298 | ||
| 3299 | out_unlock: | ||
| 3300 | mutex_unlock(&tp->control); | ||
| 3301 | usb_autopm_put_interface(tp->intf); | ||
| 3302 | out_free: | ||
| 3303 | free_all_mem(tp); | ||
| 3301 | out: | 3304 | out: |
| 3302 | return res; | 3305 | return res; |
| 3303 | } | 3306 | } |
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index fad84f3f4109..fd8b1e62301f 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c | |||
| @@ -2038,23 +2038,33 @@ static struct virtio_device_id id_table[] = { | |||
| 2038 | { 0 }, | 2038 | { 0 }, |
| 2039 | }; | 2039 | }; |
| 2040 | 2040 | ||
| 2041 | #define VIRTNET_FEATURES \ | ||
| 2042 | VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, \ | ||
| 2043 | VIRTIO_NET_F_MAC, \ | ||
| 2044 | VIRTIO_NET_F_HOST_TSO4, VIRTIO_NET_F_HOST_UFO, VIRTIO_NET_F_HOST_TSO6, \ | ||
| 2045 | VIRTIO_NET_F_HOST_ECN, VIRTIO_NET_F_GUEST_TSO4, VIRTIO_NET_F_GUEST_TSO6, \ | ||
| 2046 | VIRTIO_NET_F_GUEST_ECN, VIRTIO_NET_F_GUEST_UFO, \ | ||
| 2047 | VIRTIO_NET_F_MRG_RXBUF, VIRTIO_NET_F_STATUS, VIRTIO_NET_F_CTRL_VQ, \ | ||
| 2048 | VIRTIO_NET_F_CTRL_RX, VIRTIO_NET_F_CTRL_VLAN, \ | ||
| 2049 | VIRTIO_NET_F_GUEST_ANNOUNCE, VIRTIO_NET_F_MQ, \ | ||
| 2050 | VIRTIO_NET_F_CTRL_MAC_ADDR, \ | ||
| 2051 | VIRTIO_NET_F_MTU | ||
| 2052 | |||
| 2041 | static unsigned int features[] = { | 2053 | static unsigned int features[] = { |
| 2042 | VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, | 2054 | VIRTNET_FEATURES, |
| 2043 | VIRTIO_NET_F_GSO, VIRTIO_NET_F_MAC, | 2055 | }; |
| 2044 | VIRTIO_NET_F_HOST_TSO4, VIRTIO_NET_F_HOST_UFO, VIRTIO_NET_F_HOST_TSO6, | 2056 | |
| 2045 | VIRTIO_NET_F_HOST_ECN, VIRTIO_NET_F_GUEST_TSO4, VIRTIO_NET_F_GUEST_TSO6, | 2057 | static unsigned int features_legacy[] = { |
| 2046 | VIRTIO_NET_F_GUEST_ECN, VIRTIO_NET_F_GUEST_UFO, | 2058 | VIRTNET_FEATURES, |
| 2047 | VIRTIO_NET_F_MRG_RXBUF, VIRTIO_NET_F_STATUS, VIRTIO_NET_F_CTRL_VQ, | 2059 | VIRTIO_NET_F_GSO, |
| 2048 | VIRTIO_NET_F_CTRL_RX, VIRTIO_NET_F_CTRL_VLAN, | ||
| 2049 | VIRTIO_NET_F_GUEST_ANNOUNCE, VIRTIO_NET_F_MQ, | ||
| 2050 | VIRTIO_NET_F_CTRL_MAC_ADDR, | ||
| 2051 | VIRTIO_F_ANY_LAYOUT, | 2060 | VIRTIO_F_ANY_LAYOUT, |
| 2052 | VIRTIO_NET_F_MTU, | ||
| 2053 | }; | 2061 | }; |
| 2054 | 2062 | ||
| 2055 | static struct virtio_driver virtio_net_driver = { | 2063 | static struct virtio_driver virtio_net_driver = { |
| 2056 | .feature_table = features, | 2064 | .feature_table = features, |
| 2057 | .feature_table_size = ARRAY_SIZE(features), | 2065 | .feature_table_size = ARRAY_SIZE(features), |
| 2066 | .feature_table_legacy = features_legacy, | ||
| 2067 | .feature_table_size_legacy = ARRAY_SIZE(features_legacy), | ||
| 2058 | .driver.name = KBUILD_MODNAME, | 2068 | .driver.name = KBUILD_MODNAME, |
| 2059 | .driver.owner = THIS_MODULE, | 2069 | .driver.owner = THIS_MODULE, |
| 2060 | .id_table = id_table, | 2070 | .id_table = id_table, |
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index f3c2fa3ab0d5..24532cdebb00 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c | |||
| @@ -944,7 +944,9 @@ static bool vxlan_group_used(struct vxlan_net *vn, struct vxlan_dev *dev) | |||
| 944 | { | 944 | { |
| 945 | struct vxlan_dev *vxlan; | 945 | struct vxlan_dev *vxlan; |
| 946 | struct vxlan_sock *sock4; | 946 | struct vxlan_sock *sock4; |
| 947 | struct vxlan_sock *sock6 = NULL; | 947 | #if IS_ENABLED(CONFIG_IPV6) |
| 948 | struct vxlan_sock *sock6; | ||
| 949 | #endif | ||
| 948 | unsigned short family = dev->default_dst.remote_ip.sa.sa_family; | 950 | unsigned short family = dev->default_dst.remote_ip.sa.sa_family; |
| 949 | 951 | ||
| 950 | sock4 = rtnl_dereference(dev->vn4_sock); | 952 | sock4 = rtnl_dereference(dev->vn4_sock); |
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c index b777e1b2f87a..78d9966a3957 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | |||
| @@ -4516,7 +4516,7 @@ brcmf_cfg80211_start_ap(struct wiphy *wiphy, struct net_device *ndev, | |||
| 4516 | /* store current 11d setting */ | 4516 | /* store current 11d setting */ |
| 4517 | if (brcmf_fil_cmd_int_get(ifp, BRCMF_C_GET_REGULATORY, | 4517 | if (brcmf_fil_cmd_int_get(ifp, BRCMF_C_GET_REGULATORY, |
| 4518 | &ifp->vif->is_11d)) { | 4518 | &ifp->vif->is_11d)) { |
| 4519 | supports_11d = false; | 4519 | is_11d = supports_11d = false; |
| 4520 | } else { | 4520 | } else { |
| 4521 | country_ie = brcmf_parse_tlvs((u8 *)settings->beacon.tail, | 4521 | country_ie = brcmf_parse_tlvs((u8 *)settings->beacon.tail, |
| 4522 | settings->beacon.tail_len, | 4522 | settings->beacon.tail_len, |
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c index 4fdc3dad3e85..b88e2048ae0b 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c | |||
| @@ -1087,6 +1087,15 @@ iwl_mvm_netdetect_config(struct iwl_mvm *mvm, | |||
| 1087 | ret = iwl_mvm_switch_to_d3(mvm); | 1087 | ret = iwl_mvm_switch_to_d3(mvm); |
| 1088 | if (ret) | 1088 | if (ret) |
| 1089 | return ret; | 1089 | return ret; |
| 1090 | } else { | ||
| 1091 | /* In theory, we wouldn't have to stop a running sched | ||
| 1092 | * scan in order to start another one (for | ||
| 1093 | * net-detect). But in practice this doesn't seem to | ||
| 1094 | * work properly, so stop any running sched_scan now. | ||
| 1095 | */ | ||
| 1096 | ret = iwl_mvm_scan_stop(mvm, IWL_MVM_SCAN_SCHED, true); | ||
| 1097 | if (ret) | ||
| 1098 | return ret; | ||
| 1090 | } | 1099 | } |
| 1091 | 1100 | ||
| 1092 | /* rfkill release can be either for wowlan or netdetect */ | 1101 | /* rfkill release can be either for wowlan or netdetect */ |
| @@ -1254,7 +1263,10 @@ static int __iwl_mvm_suspend(struct ieee80211_hw *hw, | |||
| 1254 | out: | 1263 | out: |
| 1255 | if (ret < 0) { | 1264 | if (ret < 0) { |
| 1256 | iwl_mvm_ref(mvm, IWL_MVM_REF_UCODE_DOWN); | 1265 | iwl_mvm_ref(mvm, IWL_MVM_REF_UCODE_DOWN); |
| 1257 | ieee80211_restart_hw(mvm->hw); | 1266 | if (mvm->restart_fw > 0) { |
| 1267 | mvm->restart_fw--; | ||
| 1268 | ieee80211_restart_hw(mvm->hw); | ||
| 1269 | } | ||
| 1258 | iwl_mvm_free_nd(mvm); | 1270 | iwl_mvm_free_nd(mvm); |
| 1259 | } | 1271 | } |
| 1260 | out_noreset: | 1272 | out_noreset: |
| @@ -2088,6 +2100,16 @@ static int __iwl_mvm_resume(struct iwl_mvm *mvm, bool test) | |||
| 2088 | iwl_mvm_update_changed_regdom(mvm); | 2100 | iwl_mvm_update_changed_regdom(mvm); |
| 2089 | 2101 | ||
| 2090 | if (mvm->net_detect) { | 2102 | if (mvm->net_detect) { |
| 2103 | /* If this is a non-unified image, we restart the FW, | ||
| 2104 | * so no need to stop the netdetect scan. If that | ||
| 2105 | * fails, continue and try to get the wake-up reasons, | ||
| 2106 | * but trigger a HW restart by keeping a failure code | ||
| 2107 | * in ret. | ||
| 2108 | */ | ||
| 2109 | if (unified_image) | ||
| 2110 | ret = iwl_mvm_scan_stop(mvm, IWL_MVM_SCAN_NETDETECT, | ||
| 2111 | false); | ||
| 2112 | |||
| 2091 | iwl_mvm_query_netdetect_reasons(mvm, vif); | 2113 | iwl_mvm_query_netdetect_reasons(mvm, vif); |
| 2092 | /* has unlocked the mutex, so skip that */ | 2114 | /* has unlocked the mutex, so skip that */ |
| 2093 | goto out; | 2115 | goto out; |
| @@ -2271,7 +2293,8 @@ static void iwl_mvm_d3_test_disconn_work_iter(void *_data, u8 *mac, | |||
| 2271 | static int iwl_mvm_d3_test_release(struct inode *inode, struct file *file) | 2293 | static int iwl_mvm_d3_test_release(struct inode *inode, struct file *file) |
| 2272 | { | 2294 | { |
| 2273 | struct iwl_mvm *mvm = inode->i_private; | 2295 | struct iwl_mvm *mvm = inode->i_private; |
| 2274 | int remaining_time = 10; | 2296 | bool unified_image = fw_has_capa(&mvm->fw->ucode_capa, |
| 2297 | IWL_UCODE_TLV_CAPA_CNSLDTD_D3_D0_IMG); | ||
| 2275 | 2298 | ||
| 2276 | mvm->d3_test_active = false; | 2299 | mvm->d3_test_active = false; |
| 2277 | 2300 | ||
| @@ -2282,17 +2305,21 @@ static int iwl_mvm_d3_test_release(struct inode *inode, struct file *file) | |||
| 2282 | mvm->trans->system_pm_mode = IWL_PLAT_PM_MODE_DISABLED; | 2305 | mvm->trans->system_pm_mode = IWL_PLAT_PM_MODE_DISABLED; |
| 2283 | 2306 | ||
| 2284 | iwl_abort_notification_waits(&mvm->notif_wait); | 2307 | iwl_abort_notification_waits(&mvm->notif_wait); |
| 2285 | ieee80211_restart_hw(mvm->hw); | 2308 | if (!unified_image) { |
| 2309 | int remaining_time = 10; | ||
| 2286 | 2310 | ||
| 2287 | /* wait for restart and disconnect all interfaces */ | 2311 | ieee80211_restart_hw(mvm->hw); |
| 2288 | while (test_bit(IWL_MVM_STATUS_IN_HW_RESTART, &mvm->status) && | 2312 | |
| 2289 | remaining_time > 0) { | 2313 | /* wait for restart and disconnect all interfaces */ |
| 2290 | remaining_time--; | 2314 | while (test_bit(IWL_MVM_STATUS_IN_HW_RESTART, &mvm->status) && |
| 2291 | msleep(1000); | 2315 | remaining_time > 0) { |
| 2292 | } | 2316 | remaining_time--; |
| 2317 | msleep(1000); | ||
| 2318 | } | ||
| 2293 | 2319 | ||
| 2294 | if (remaining_time == 0) | 2320 | if (remaining_time == 0) |
| 2295 | IWL_ERR(mvm, "Timed out waiting for HW restart to finish!\n"); | 2321 | IWL_ERR(mvm, "Timed out waiting for HW restart!\n"); |
| 2322 | } | ||
| 2296 | 2323 | ||
| 2297 | ieee80211_iterate_active_interfaces_atomic( | 2324 | ieee80211_iterate_active_interfaces_atomic( |
| 2298 | mvm->hw, IEEE80211_IFACE_ITER_NORMAL, | 2325 | mvm->hw, IEEE80211_IFACE_ITER_NORMAL, |
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c index 07da4efe8458..7b7d2a146e30 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c | |||
| @@ -1529,8 +1529,8 @@ static ssize_t iwl_dbgfs_mem_read(struct file *file, char __user *user_buf, | |||
| 1529 | .data = { &cmd, }, | 1529 | .data = { &cmd, }, |
| 1530 | .len = { sizeof(cmd) }, | 1530 | .len = { sizeof(cmd) }, |
| 1531 | }; | 1531 | }; |
| 1532 | size_t delta, len; | 1532 | size_t delta; |
| 1533 | ssize_t ret; | 1533 | ssize_t ret, len; |
| 1534 | 1534 | ||
| 1535 | hcmd.id = iwl_cmd_id(*ppos >> 24 ? UMAC_RD_WR : LMAC_RD_WR, | 1535 | hcmd.id = iwl_cmd_id(*ppos >> 24 ? UMAC_RD_WR : LMAC_RD_WR, |
| 1536 | DEBUG_GROUP, 0); | 1536 | DEBUG_GROUP, 0); |
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c index 318efd814037..1db1dc13e988 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | |||
| @@ -4121,7 +4121,6 @@ void iwl_mvm_sync_rx_queues_internal(struct iwl_mvm *mvm, | |||
| 4121 | struct iwl_mvm_internal_rxq_notif *notif, | 4121 | struct iwl_mvm_internal_rxq_notif *notif, |
| 4122 | u32 size) | 4122 | u32 size) |
| 4123 | { | 4123 | { |
| 4124 | DECLARE_WAIT_QUEUE_HEAD_ONSTACK(notif_waitq); | ||
| 4125 | u32 qmask = BIT(mvm->trans->num_rx_queues) - 1; | 4124 | u32 qmask = BIT(mvm->trans->num_rx_queues) - 1; |
| 4126 | int ret; | 4125 | int ret; |
| 4127 | 4126 | ||
| @@ -4143,7 +4142,7 @@ void iwl_mvm_sync_rx_queues_internal(struct iwl_mvm *mvm, | |||
| 4143 | } | 4142 | } |
| 4144 | 4143 | ||
| 4145 | if (notif->sync) | 4144 | if (notif->sync) |
| 4146 | ret = wait_event_timeout(notif_waitq, | 4145 | ret = wait_event_timeout(mvm->rx_sync_waitq, |
| 4147 | atomic_read(&mvm->queue_sync_counter) == 0, | 4146 | atomic_read(&mvm->queue_sync_counter) == 0, |
| 4148 | HZ); | 4147 | HZ); |
| 4149 | WARN_ON_ONCE(!ret); | 4148 | WARN_ON_ONCE(!ret); |
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h index d17cbf603f7c..c60703e0c246 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | |||
| @@ -937,6 +937,7 @@ struct iwl_mvm { | |||
| 937 | /* sync d0i3_tx queue and IWL_MVM_STATUS_IN_D0I3 status flag */ | 937 | /* sync d0i3_tx queue and IWL_MVM_STATUS_IN_D0I3 status flag */ |
| 938 | spinlock_t d0i3_tx_lock; | 938 | spinlock_t d0i3_tx_lock; |
| 939 | wait_queue_head_t d0i3_exit_waitq; | 939 | wait_queue_head_t d0i3_exit_waitq; |
| 940 | wait_queue_head_t rx_sync_waitq; | ||
| 940 | 941 | ||
| 941 | /* BT-Coex */ | 942 | /* BT-Coex */ |
| 942 | struct iwl_bt_coex_profile_notif last_bt_notif; | 943 | struct iwl_bt_coex_profile_notif last_bt_notif; |
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c index 05fe6dd1a2c8..4d35deb628bc 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c | |||
| @@ -619,6 +619,7 @@ iwl_op_mode_mvm_start(struct iwl_trans *trans, const struct iwl_cfg *cfg, | |||
| 619 | spin_lock_init(&mvm->refs_lock); | 619 | spin_lock_init(&mvm->refs_lock); |
| 620 | skb_queue_head_init(&mvm->d0i3_tx); | 620 | skb_queue_head_init(&mvm->d0i3_tx); |
| 621 | init_waitqueue_head(&mvm->d0i3_exit_waitq); | 621 | init_waitqueue_head(&mvm->d0i3_exit_waitq); |
| 622 | init_waitqueue_head(&mvm->rx_sync_waitq); | ||
| 622 | 623 | ||
| 623 | atomic_set(&mvm->queue_sync_counter, 0); | 624 | atomic_set(&mvm->queue_sync_counter, 0); |
| 624 | 625 | ||
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c b/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c index a57c6ef5bc14..6c802cee900c 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | |||
| @@ -547,7 +547,8 @@ void iwl_mvm_rx_queue_notif(struct iwl_mvm *mvm, struct iwl_rx_cmd_buffer *rxb, | |||
| 547 | "Received expired RX queue sync message\n"); | 547 | "Received expired RX queue sync message\n"); |
| 548 | return; | 548 | return; |
| 549 | } | 549 | } |
| 550 | atomic_dec(&mvm->queue_sync_counter); | 550 | if (!atomic_dec_return(&mvm->queue_sync_counter)) |
| 551 | wake_up(&mvm->rx_sync_waitq); | ||
| 551 | } | 552 | } |
| 552 | 553 | ||
| 553 | switch (internal_notif->type) { | 554 | switch (internal_notif->type) { |
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c index f279fdd6eb44..fa9743205491 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c | |||
| @@ -1199,6 +1199,9 @@ static int iwl_mvm_num_scans(struct iwl_mvm *mvm) | |||
| 1199 | 1199 | ||
| 1200 | static int iwl_mvm_check_running_scans(struct iwl_mvm *mvm, int type) | 1200 | static int iwl_mvm_check_running_scans(struct iwl_mvm *mvm, int type) |
| 1201 | { | 1201 | { |
| 1202 | bool unified_image = fw_has_capa(&mvm->fw->ucode_capa, | ||
| 1203 | IWL_UCODE_TLV_CAPA_CNSLDTD_D3_D0_IMG); | ||
| 1204 | |||
| 1202 | /* This looks a bit arbitrary, but the idea is that if we run | 1205 | /* This looks a bit arbitrary, but the idea is that if we run |
| 1203 | * out of possible simultaneous scans and the userspace is | 1206 | * out of possible simultaneous scans and the userspace is |
| 1204 | * trying to run a scan type that is already running, we | 1207 | * trying to run a scan type that is already running, we |
| @@ -1225,12 +1228,30 @@ static int iwl_mvm_check_running_scans(struct iwl_mvm *mvm, int type) | |||
| 1225 | return -EBUSY; | 1228 | return -EBUSY; |
| 1226 | return iwl_mvm_scan_stop(mvm, IWL_MVM_SCAN_REGULAR, true); | 1229 | return iwl_mvm_scan_stop(mvm, IWL_MVM_SCAN_REGULAR, true); |
| 1227 | case IWL_MVM_SCAN_NETDETECT: | 1230 | case IWL_MVM_SCAN_NETDETECT: |
| 1228 | /* No need to stop anything for net-detect since the | 1231 | /* For non-unified images, there's no need to stop |
| 1229 | * firmware is restarted anyway. This way, any sched | 1232 | * anything for net-detect since the firmware is |
| 1230 | * scans that were running will be restarted when we | 1233 | * restarted anyway. This way, any sched scans that |
| 1231 | * resume. | 1234 | * were running will be restarted when we resume. |
| 1232 | */ | 1235 | */ |
| 1233 | return 0; | 1236 | if (!unified_image) |
| 1237 | return 0; | ||
| 1238 | |||
| 1239 | /* If this is a unified image and we ran out of scans, | ||
| 1240 | * we need to stop something. Prefer stopping regular | ||
| 1241 | * scans, because the results are useless at this | ||
| 1242 | * point, and we should be able to keep running | ||
| 1243 | * another scheduled scan while suspended. | ||
| 1244 | */ | ||
| 1245 | if (mvm->scan_status & IWL_MVM_SCAN_REGULAR_MASK) | ||
| 1246 | return iwl_mvm_scan_stop(mvm, IWL_MVM_SCAN_REGULAR, | ||
| 1247 | true); | ||
| 1248 | if (mvm->scan_status & IWL_MVM_SCAN_SCHED_MASK) | ||
| 1249 | return iwl_mvm_scan_stop(mvm, IWL_MVM_SCAN_SCHED, | ||
| 1250 | true); | ||
| 1251 | |||
| 1252 | /* fall through, something is wrong if no scan was | ||
| 1253 | * running but we ran out of scans. | ||
| 1254 | */ | ||
| 1234 | default: | 1255 | default: |
| 1235 | WARN_ON(1); | 1256 | WARN_ON(1); |
| 1236 | break; | 1257 | break; |
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c index 001be406a3d3..2f8134b2a504 100644 --- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c +++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c | |||
| @@ -541,48 +541,64 @@ static const struct pci_device_id iwl_hw_card_ids[] = { | |||
| 541 | MODULE_DEVICE_TABLE(pci, iwl_hw_card_ids); | 541 | MODULE_DEVICE_TABLE(pci, iwl_hw_card_ids); |
| 542 | 542 | ||
| 543 | #ifdef CONFIG_ACPI | 543 | #ifdef CONFIG_ACPI |
| 544 | #define SPL_METHOD "SPLC" | 544 | #define ACPI_SPLC_METHOD "SPLC" |
| 545 | #define SPL_DOMAINTYPE_MODULE BIT(0) | 545 | #define ACPI_SPLC_DOMAIN_WIFI (0x07) |
| 546 | #define SPL_DOMAINTYPE_WIFI BIT(1) | ||
| 547 | #define SPL_DOMAINTYPE_WIGIG BIT(2) | ||
| 548 | #define SPL_DOMAINTYPE_RFEM BIT(3) | ||
| 549 | 546 | ||
| 550 | static u64 splx_get_pwr_limit(struct iwl_trans *trans, union acpi_object *splx) | 547 | static u64 splc_get_pwr_limit(struct iwl_trans *trans, union acpi_object *splc) |
| 551 | { | 548 | { |
| 552 | union acpi_object *limits, *domain_type, *power_limit; | 549 | union acpi_object *data_pkg, *dflt_pwr_limit; |
| 553 | 550 | int i; | |
| 554 | if (splx->type != ACPI_TYPE_PACKAGE || | 551 | |
| 555 | splx->package.count != 2 || | 552 | /* We need at least two elements, one for the revision and one |
| 556 | splx->package.elements[0].type != ACPI_TYPE_INTEGER || | 553 | * for the data itself. Also check that the revision is |
| 557 | splx->package.elements[0].integer.value != 0) { | 554 | * supported (currently only revision 0). |
| 558 | IWL_ERR(trans, "Unsupported splx structure\n"); | 555 | */ |
| 556 | if (splc->type != ACPI_TYPE_PACKAGE || | ||
| 557 | splc->package.count < 2 || | ||
| 558 | splc->package.elements[0].type != ACPI_TYPE_INTEGER || | ||
| 559 | splc->package.elements[0].integer.value != 0) { | ||
| 560 | IWL_DEBUG_INFO(trans, | ||
| 561 | "Unsupported structure returned by the SPLC method. Ignoring.\n"); | ||
| 559 | return 0; | 562 | return 0; |
| 560 | } | 563 | } |
| 561 | 564 | ||
| 562 | limits = &splx->package.elements[1]; | 565 | /* loop through all the packages to find the one for WiFi */ |
| 563 | if (limits->type != ACPI_TYPE_PACKAGE || | 566 | for (i = 1; i < splc->package.count; i++) { |
| 564 | limits->package.count < 2 || | 567 | union acpi_object *domain; |
| 565 | limits->package.elements[0].type != ACPI_TYPE_INTEGER || | 568 | |
| 566 | limits->package.elements[1].type != ACPI_TYPE_INTEGER) { | 569 | data_pkg = &splc->package.elements[i]; |
| 567 | IWL_ERR(trans, "Invalid limits element\n"); | 570 | |
| 568 | return 0; | 571 | /* Skip anything that is not a package with the right |
| 572 | * amount of elements (i.e. at least 2 integers). | ||
| 573 | */ | ||
| 574 | if (data_pkg->type != ACPI_TYPE_PACKAGE || | ||
| 575 | data_pkg->package.count < 2 || | ||
| 576 | data_pkg->package.elements[0].type != ACPI_TYPE_INTEGER || | ||
| 577 | data_pkg->package.elements[1].type != ACPI_TYPE_INTEGER) | ||
| 578 | continue; | ||
| 579 | |||
| 580 | domain = &data_pkg->package.elements[0]; | ||
| 581 | if (domain->integer.value == ACPI_SPLC_DOMAIN_WIFI) | ||
| 582 | break; | ||
| 583 | |||
| 584 | data_pkg = NULL; | ||
| 569 | } | 585 | } |
| 570 | 586 | ||
| 571 | domain_type = &limits->package.elements[0]; | 587 | if (!data_pkg) { |
| 572 | power_limit = &limits->package.elements[1]; | 588 | IWL_DEBUG_INFO(trans, |
| 573 | if (!(domain_type->integer.value & SPL_DOMAINTYPE_WIFI)) { | 589 | "No element for the WiFi domain returned by the SPLC method.\n"); |
| 574 | IWL_DEBUG_INFO(trans, "WiFi power is not limited\n"); | ||
| 575 | return 0; | 590 | return 0; |
| 576 | } | 591 | } |
| 577 | 592 | ||
| 578 | return power_limit->integer.value; | 593 | dflt_pwr_limit = &data_pkg->package.elements[1]; |
| 594 | return dflt_pwr_limit->integer.value; | ||
| 579 | } | 595 | } |
| 580 | 596 | ||
| 581 | static void set_dflt_pwr_limit(struct iwl_trans *trans, struct pci_dev *pdev) | 597 | static void set_dflt_pwr_limit(struct iwl_trans *trans, struct pci_dev *pdev) |
| 582 | { | 598 | { |
| 583 | acpi_handle pxsx_handle; | 599 | acpi_handle pxsx_handle; |
| 584 | acpi_handle handle; | 600 | acpi_handle handle; |
| 585 | struct acpi_buffer splx = {ACPI_ALLOCATE_BUFFER, NULL}; | 601 | struct acpi_buffer splc = {ACPI_ALLOCATE_BUFFER, NULL}; |
| 586 | acpi_status status; | 602 | acpi_status status; |
| 587 | 603 | ||
| 588 | pxsx_handle = ACPI_HANDLE(&pdev->dev); | 604 | pxsx_handle = ACPI_HANDLE(&pdev->dev); |
| @@ -593,23 +609,24 @@ static void set_dflt_pwr_limit(struct iwl_trans *trans, struct pci_dev *pdev) | |||
| 593 | } | 609 | } |
| 594 | 610 | ||
| 595 | /* Get the method's handle */ | 611 | /* Get the method's handle */ |
| 596 | status = acpi_get_handle(pxsx_handle, (acpi_string)SPL_METHOD, &handle); | 612 | status = acpi_get_handle(pxsx_handle, (acpi_string)ACPI_SPLC_METHOD, |
| 613 | &handle); | ||
| 597 | if (ACPI_FAILURE(status)) { | 614 | if (ACPI_FAILURE(status)) { |
| 598 | IWL_DEBUG_INFO(trans, "SPL method not found\n"); | 615 | IWL_DEBUG_INFO(trans, "SPLC method not found\n"); |
| 599 | return; | 616 | return; |
| 600 | } | 617 | } |
| 601 | 618 | ||
| 602 | /* Call SPLC with no arguments */ | 619 | /* Call SPLC with no arguments */ |
| 603 | status = acpi_evaluate_object(handle, NULL, NULL, &splx); | 620 | status = acpi_evaluate_object(handle, NULL, NULL, &splc); |
| 604 | if (ACPI_FAILURE(status)) { | 621 | if (ACPI_FAILURE(status)) { |
| 605 | IWL_ERR(trans, "SPLC invocation failed (0x%x)\n", status); | 622 | IWL_ERR(trans, "SPLC invocation failed (0x%x)\n", status); |
| 606 | return; | 623 | return; |
| 607 | } | 624 | } |
| 608 | 625 | ||
| 609 | trans->dflt_pwr_limit = splx_get_pwr_limit(trans, splx.pointer); | 626 | trans->dflt_pwr_limit = splc_get_pwr_limit(trans, splc.pointer); |
| 610 | IWL_DEBUG_INFO(trans, "Default power limit set to %lld\n", | 627 | IWL_DEBUG_INFO(trans, "Default power limit set to %lld\n", |
| 611 | trans->dflt_pwr_limit); | 628 | trans->dflt_pwr_limit); |
| 612 | kfree(splx.pointer); | 629 | kfree(splc.pointer); |
| 613 | } | 630 | } |
| 614 | 631 | ||
| 615 | #else /* CONFIG_ACPI */ | 632 | #else /* CONFIG_ACPI */ |
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/tx.c b/drivers/net/wireless/intel/iwlwifi/pcie/tx.c index e9a278b60dfd..5f840f16f40b 100644 --- a/drivers/net/wireless/intel/iwlwifi/pcie/tx.c +++ b/drivers/net/wireless/intel/iwlwifi/pcie/tx.c | |||
| @@ -592,6 +592,7 @@ error: | |||
| 592 | static int iwl_pcie_txq_init(struct iwl_trans *trans, struct iwl_txq *txq, | 592 | static int iwl_pcie_txq_init(struct iwl_trans *trans, struct iwl_txq *txq, |
| 593 | int slots_num, u32 txq_id) | 593 | int slots_num, u32 txq_id) |
| 594 | { | 594 | { |
| 595 | struct iwl_trans_pcie *trans_pcie = IWL_TRANS_GET_PCIE_TRANS(trans); | ||
| 595 | int ret; | 596 | int ret; |
| 596 | 597 | ||
| 597 | txq->need_update = false; | 598 | txq->need_update = false; |
| @@ -606,6 +607,13 @@ static int iwl_pcie_txq_init(struct iwl_trans *trans, struct iwl_txq *txq, | |||
| 606 | return ret; | 607 | return ret; |
| 607 | 608 | ||
| 608 | spin_lock_init(&txq->lock); | 609 | spin_lock_init(&txq->lock); |
| 610 | |||
| 611 | if (txq_id == trans_pcie->cmd_queue) { | ||
| 612 | static struct lock_class_key iwl_pcie_cmd_queue_lock_class; | ||
| 613 | |||
| 614 | lockdep_set_class(&txq->lock, &iwl_pcie_cmd_queue_lock_class); | ||
| 615 | } | ||
| 616 | |||
| 609 | __skb_queue_head_init(&txq->overflow_q); | 617 | __skb_queue_head_init(&txq->overflow_q); |
| 610 | 618 | ||
| 611 | /* | 619 | /* |
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index e17879dd5d5a..bf2744e1e3db 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c | |||
| @@ -304,7 +304,7 @@ static void xennet_alloc_rx_buffers(struct netfront_queue *queue) | |||
| 304 | queue->rx_skbs[id] = skb; | 304 | queue->rx_skbs[id] = skb; |
| 305 | 305 | ||
| 306 | ref = gnttab_claim_grant_reference(&queue->gref_rx_head); | 306 | ref = gnttab_claim_grant_reference(&queue->gref_rx_head); |
| 307 | BUG_ON((signed short)ref < 0); | 307 | WARN_ON_ONCE(IS_ERR_VALUE((unsigned long)(int)ref)); |
| 308 | queue->grant_rx_ref[id] = ref; | 308 | queue->grant_rx_ref[id] = ref; |
| 309 | 309 | ||
| 310 | page = skb_frag_page(&skb_shinfo(skb)->frags[0]); | 310 | page = skb_frag_page(&skb_shinfo(skb)->frags[0]); |
| @@ -428,7 +428,7 @@ static void xennet_tx_setup_grant(unsigned long gfn, unsigned int offset, | |||
| 428 | id = get_id_from_freelist(&queue->tx_skb_freelist, queue->tx_skbs); | 428 | id = get_id_from_freelist(&queue->tx_skb_freelist, queue->tx_skbs); |
| 429 | tx = RING_GET_REQUEST(&queue->tx, queue->tx.req_prod_pvt++); | 429 | tx = RING_GET_REQUEST(&queue->tx, queue->tx.req_prod_pvt++); |
| 430 | ref = gnttab_claim_grant_reference(&queue->gref_tx_head); | 430 | ref = gnttab_claim_grant_reference(&queue->gref_tx_head); |
| 431 | BUG_ON((signed short)ref < 0); | 431 | WARN_ON_ONCE(IS_ERR_VALUE((unsigned long)(int)ref)); |
| 432 | 432 | ||
| 433 | gnttab_grant_foreign_access_ref(ref, queue->info->xbdev->otherend_id, | 433 | gnttab_grant_foreign_access_ref(ref, queue->info->xbdev->otherend_id, |
| 434 | gfn, GNTMAP_readonly); | 434 | gfn, GNTMAP_readonly); |
diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c b/drivers/ntb/hw/intel/ntb_hw_intel.c index 0d5c29ae51de..7310a261c858 100644 --- a/drivers/ntb/hw/intel/ntb_hw_intel.c +++ b/drivers/ntb/hw/intel/ntb_hw_intel.c | |||
| @@ -112,17 +112,17 @@ MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64, | |||
| 112 | 112 | ||
| 113 | module_param_named(xeon_b2b_usd_bar4_addr64, | 113 | module_param_named(xeon_b2b_usd_bar4_addr64, |
| 114 | xeon_b2b_usd_addr.bar4_addr64, ullong, 0644); | 114 | xeon_b2b_usd_addr.bar4_addr64, ullong, 0644); |
| 115 | MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64, | 115 | MODULE_PARM_DESC(xeon_b2b_usd_bar4_addr64, |
| 116 | "XEON B2B USD BAR 4 64-bit address"); | 116 | "XEON B2B USD BAR 4 64-bit address"); |
| 117 | 117 | ||
| 118 | module_param_named(xeon_b2b_usd_bar4_addr32, | 118 | module_param_named(xeon_b2b_usd_bar4_addr32, |
| 119 | xeon_b2b_usd_addr.bar4_addr32, ullong, 0644); | 119 | xeon_b2b_usd_addr.bar4_addr32, ullong, 0644); |
| 120 | MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64, | 120 | MODULE_PARM_DESC(xeon_b2b_usd_bar4_addr32, |
| 121 | "XEON B2B USD split-BAR 4 32-bit address"); | 121 | "XEON B2B USD split-BAR 4 32-bit address"); |
| 122 | 122 | ||
| 123 | module_param_named(xeon_b2b_usd_bar5_addr32, | 123 | module_param_named(xeon_b2b_usd_bar5_addr32, |
| 124 | xeon_b2b_usd_addr.bar5_addr32, ullong, 0644); | 124 | xeon_b2b_usd_addr.bar5_addr32, ullong, 0644); |
| 125 | MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64, | 125 | MODULE_PARM_DESC(xeon_b2b_usd_bar5_addr32, |
| 126 | "XEON B2B USD split-BAR 5 32-bit address"); | 126 | "XEON B2B USD split-BAR 5 32-bit address"); |
| 127 | 127 | ||
| 128 | module_param_named(xeon_b2b_dsd_bar2_addr64, | 128 | module_param_named(xeon_b2b_dsd_bar2_addr64, |
| @@ -132,17 +132,17 @@ MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64, | |||
| 132 | 132 | ||
| 133 | module_param_named(xeon_b2b_dsd_bar4_addr64, | 133 | module_param_named(xeon_b2b_dsd_bar4_addr64, |
| 134 | xeon_b2b_dsd_addr.bar4_addr64, ullong, 0644); | 134 | xeon_b2b_dsd_addr.bar4_addr64, ullong, 0644); |
| 135 | MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64, | 135 | MODULE_PARM_DESC(xeon_b2b_dsd_bar4_addr64, |
| 136 | "XEON B2B DSD BAR 4 64-bit address"); | 136 | "XEON B2B DSD BAR 4 64-bit address"); |
| 137 | 137 | ||
| 138 | module_param_named(xeon_b2b_dsd_bar4_addr32, | 138 | module_param_named(xeon_b2b_dsd_bar4_addr32, |
| 139 | xeon_b2b_dsd_addr.bar4_addr32, ullong, 0644); | 139 | xeon_b2b_dsd_addr.bar4_addr32, ullong, 0644); |
| 140 | MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64, | 140 | MODULE_PARM_DESC(xeon_b2b_dsd_bar4_addr32, |
| 141 | "XEON B2B DSD split-BAR 4 32-bit address"); | 141 | "XEON B2B DSD split-BAR 4 32-bit address"); |
| 142 | 142 | ||
| 143 | module_param_named(xeon_b2b_dsd_bar5_addr32, | 143 | module_param_named(xeon_b2b_dsd_bar5_addr32, |
| 144 | xeon_b2b_dsd_addr.bar5_addr32, ullong, 0644); | 144 | xeon_b2b_dsd_addr.bar5_addr32, ullong, 0644); |
| 145 | MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64, | 145 | MODULE_PARM_DESC(xeon_b2b_dsd_bar5_addr32, |
| 146 | "XEON B2B DSD split-BAR 5 32-bit address"); | 146 | "XEON B2B DSD split-BAR 5 32-bit address"); |
| 147 | 147 | ||
| 148 | #ifndef ioread64 | 148 | #ifndef ioread64 |
| @@ -1755,6 +1755,8 @@ static int xeon_setup_b2b_mw(struct intel_ntb_dev *ndev, | |||
| 1755 | XEON_B2B_MIN_SIZE); | 1755 | XEON_B2B_MIN_SIZE); |
| 1756 | if (!ndev->peer_mmio) | 1756 | if (!ndev->peer_mmio) |
| 1757 | return -EIO; | 1757 | return -EIO; |
| 1758 | |||
| 1759 | ndev->peer_addr = pci_resource_start(pdev, b2b_bar); | ||
| 1758 | } | 1760 | } |
| 1759 | 1761 | ||
| 1760 | return 0; | 1762 | return 0; |
| @@ -2019,6 +2021,7 @@ static int intel_ntb_init_pci(struct intel_ntb_dev *ndev, struct pci_dev *pdev) | |||
| 2019 | goto err_mmio; | 2021 | goto err_mmio; |
| 2020 | } | 2022 | } |
| 2021 | ndev->peer_mmio = ndev->self_mmio; | 2023 | ndev->peer_mmio = ndev->self_mmio; |
| 2024 | ndev->peer_addr = pci_resource_start(pdev, 0); | ||
| 2022 | 2025 | ||
| 2023 | return 0; | 2026 | return 0; |
| 2024 | 2027 | ||
diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c index 8601c10acf74..4eb8adb34508 100644 --- a/drivers/ntb/ntb_transport.c +++ b/drivers/ntb/ntb_transport.c | |||
| @@ -257,7 +257,7 @@ enum { | |||
| 257 | #define NTB_QP_DEF_NUM_ENTRIES 100 | 257 | #define NTB_QP_DEF_NUM_ENTRIES 100 |
| 258 | #define NTB_LINK_DOWN_TIMEOUT 10 | 258 | #define NTB_LINK_DOWN_TIMEOUT 10 |
| 259 | #define DMA_RETRIES 20 | 259 | #define DMA_RETRIES 20 |
| 260 | #define DMA_OUT_RESOURCE_TO 50 | 260 | #define DMA_OUT_RESOURCE_TO msecs_to_jiffies(50) |
| 261 | 261 | ||
| 262 | static void ntb_transport_rxc_db(unsigned long data); | 262 | static void ntb_transport_rxc_db(unsigned long data); |
| 263 | static const struct ntb_ctx_ops ntb_transport_ops; | 263 | static const struct ntb_ctx_ops ntb_transport_ops; |
diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c index 6a50f20bf1cd..e75d4fdc0866 100644 --- a/drivers/ntb/test/ntb_perf.c +++ b/drivers/ntb/test/ntb_perf.c | |||
| @@ -72,7 +72,7 @@ | |||
| 72 | #define MAX_THREADS 32 | 72 | #define MAX_THREADS 32 |
| 73 | #define MAX_TEST_SIZE SZ_1M | 73 | #define MAX_TEST_SIZE SZ_1M |
| 74 | #define MAX_SRCS 32 | 74 | #define MAX_SRCS 32 |
| 75 | #define DMA_OUT_RESOURCE_TO 50 | 75 | #define DMA_OUT_RESOURCE_TO msecs_to_jiffies(50) |
| 76 | #define DMA_RETRIES 20 | 76 | #define DMA_RETRIES 20 |
| 77 | #define SZ_4G (1ULL << 32) | 77 | #define SZ_4G (1ULL << 32) |
| 78 | #define MAX_SEG_ORDER 20 /* no larger than 1M for kmalloc buffer */ | 78 | #define MAX_SEG_ORDER 20 /* no larger than 1M for kmalloc buffer */ |
| @@ -589,7 +589,7 @@ static ssize_t debugfs_run_read(struct file *filp, char __user *ubuf, | |||
| 589 | return -ENOMEM; | 589 | return -ENOMEM; |
| 590 | 590 | ||
| 591 | if (mutex_is_locked(&perf->run_mutex)) { | 591 | if (mutex_is_locked(&perf->run_mutex)) { |
| 592 | out_off = snprintf(buf, 64, "running\n"); | 592 | out_off = scnprintf(buf, 64, "running\n"); |
| 593 | goto read_from_buf; | 593 | goto read_from_buf; |
| 594 | } | 594 | } |
| 595 | 595 | ||
| @@ -600,14 +600,14 @@ static ssize_t debugfs_run_read(struct file *filp, char __user *ubuf, | |||
| 600 | break; | 600 | break; |
| 601 | 601 | ||
| 602 | if (pctx->status) { | 602 | if (pctx->status) { |
| 603 | out_off += snprintf(buf + out_off, 1024 - out_off, | 603 | out_off += scnprintf(buf + out_off, 1024 - out_off, |
| 604 | "%d: error %d\n", i, | 604 | "%d: error %d\n", i, |
| 605 | pctx->status); | 605 | pctx->status); |
| 606 | continue; | 606 | continue; |
| 607 | } | 607 | } |
| 608 | 608 | ||
| 609 | rate = div64_u64(pctx->copied, pctx->diff_us); | 609 | rate = div64_u64(pctx->copied, pctx->diff_us); |
| 610 | out_off += snprintf(buf + out_off, 1024 - out_off, | 610 | out_off += scnprintf(buf + out_off, 1024 - out_off, |
| 611 | "%d: copied %llu bytes in %llu usecs, %llu MBytes/s\n", | 611 | "%d: copied %llu bytes in %llu usecs, %llu MBytes/s\n", |
| 612 | i, pctx->copied, pctx->diff_us, rate); | 612 | i, pctx->copied, pctx->diff_us, rate); |
| 613 | } | 613 | } |
diff --git a/drivers/ntb/test/ntb_pingpong.c b/drivers/ntb/test/ntb_pingpong.c index 7d311799fca1..435861189d97 100644 --- a/drivers/ntb/test/ntb_pingpong.c +++ b/drivers/ntb/test/ntb_pingpong.c | |||
| @@ -88,7 +88,7 @@ MODULE_PARM_DESC(delay_ms, "Milliseconds to delay the response to peer"); | |||
| 88 | 88 | ||
| 89 | static unsigned long db_init = 0x7; | 89 | static unsigned long db_init = 0x7; |
| 90 | module_param(db_init, ulong, 0644); | 90 | module_param(db_init, ulong, 0644); |
| 91 | MODULE_PARM_DESC(delay_ms, "Initial doorbell bits to ring on the peer"); | 91 | MODULE_PARM_DESC(db_init, "Initial doorbell bits to ring on the peer"); |
| 92 | 92 | ||
| 93 | struct pp_ctx { | 93 | struct pp_ctx { |
| 94 | struct ntb_dev *ntb; | 94 | struct ntb_dev *ntb; |
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 0248d0e21fee..5e52034ab010 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c | |||
| @@ -1242,20 +1242,16 @@ static int nvme_configure_admin_queue(struct nvme_dev *dev) | |||
| 1242 | 1242 | ||
| 1243 | result = nvme_enable_ctrl(&dev->ctrl, cap); | 1243 | result = nvme_enable_ctrl(&dev->ctrl, cap); |
| 1244 | if (result) | 1244 | if (result) |
| 1245 | goto free_nvmeq; | 1245 | return result; |
| 1246 | 1246 | ||
| 1247 | nvmeq->cq_vector = 0; | 1247 | nvmeq->cq_vector = 0; |
| 1248 | result = queue_request_irq(nvmeq); | 1248 | result = queue_request_irq(nvmeq); |
| 1249 | if (result) { | 1249 | if (result) { |
| 1250 | nvmeq->cq_vector = -1; | 1250 | nvmeq->cq_vector = -1; |
| 1251 | goto free_nvmeq; | 1251 | return result; |
| 1252 | } | 1252 | } |
| 1253 | 1253 | ||
| 1254 | return result; | 1254 | return result; |
| 1255 | |||
| 1256 | free_nvmeq: | ||
| 1257 | nvme_free_queues(dev, 0); | ||
| 1258 | return result; | ||
| 1259 | } | 1255 | } |
| 1260 | 1256 | ||
| 1261 | static bool nvme_should_reset(struct nvme_dev *dev, u32 csts) | 1257 | static bool nvme_should_reset(struct nvme_dev *dev, u32 csts) |
| @@ -1317,10 +1313,8 @@ static int nvme_create_io_queues(struct nvme_dev *dev) | |||
| 1317 | max = min(dev->max_qid, dev->queue_count - 1); | 1313 | max = min(dev->max_qid, dev->queue_count - 1); |
| 1318 | for (i = dev->online_queues; i <= max; i++) { | 1314 | for (i = dev->online_queues; i <= max; i++) { |
| 1319 | ret = nvme_create_queue(dev->queues[i], i); | 1315 | ret = nvme_create_queue(dev->queues[i], i); |
| 1320 | if (ret) { | 1316 | if (ret) |
| 1321 | nvme_free_queues(dev, i); | ||
| 1322 | break; | 1317 | break; |
| 1323 | } | ||
| 1324 | } | 1318 | } |
| 1325 | 1319 | ||
| 1326 | /* | 1320 | /* |
| @@ -1460,13 +1454,9 @@ static int nvme_setup_io_queues(struct nvme_dev *dev) | |||
| 1460 | result = queue_request_irq(adminq); | 1454 | result = queue_request_irq(adminq); |
| 1461 | if (result) { | 1455 | if (result) { |
| 1462 | adminq->cq_vector = -1; | 1456 | adminq->cq_vector = -1; |
| 1463 | goto free_queues; | 1457 | return result; |
| 1464 | } | 1458 | } |
| 1465 | return nvme_create_io_queues(dev); | 1459 | return nvme_create_io_queues(dev); |
| 1466 | |||
| 1467 | free_queues: | ||
| 1468 | nvme_free_queues(dev, 1); | ||
| 1469 | return result; | ||
| 1470 | } | 1460 | } |
| 1471 | 1461 | ||
| 1472 | static void nvme_del_queue_end(struct request *req, int error) | 1462 | static void nvme_del_queue_end(struct request *req, int error) |
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c index 5a8388177959..3d25add36d91 100644 --- a/drivers/nvme/host/rdma.c +++ b/drivers/nvme/host/rdma.c | |||
| @@ -83,6 +83,7 @@ enum nvme_rdma_queue_flags { | |||
| 83 | NVME_RDMA_Q_CONNECTED = (1 << 0), | 83 | NVME_RDMA_Q_CONNECTED = (1 << 0), |
| 84 | NVME_RDMA_IB_QUEUE_ALLOCATED = (1 << 1), | 84 | NVME_RDMA_IB_QUEUE_ALLOCATED = (1 << 1), |
| 85 | NVME_RDMA_Q_DELETING = (1 << 2), | 85 | NVME_RDMA_Q_DELETING = (1 << 2), |
| 86 | NVME_RDMA_Q_LIVE = (1 << 3), | ||
| 86 | }; | 87 | }; |
| 87 | 88 | ||
| 88 | struct nvme_rdma_queue { | 89 | struct nvme_rdma_queue { |
| @@ -624,10 +625,18 @@ static int nvme_rdma_connect_io_queues(struct nvme_rdma_ctrl *ctrl) | |||
| 624 | 625 | ||
| 625 | for (i = 1; i < ctrl->queue_count; i++) { | 626 | for (i = 1; i < ctrl->queue_count; i++) { |
| 626 | ret = nvmf_connect_io_queue(&ctrl->ctrl, i); | 627 | ret = nvmf_connect_io_queue(&ctrl->ctrl, i); |
| 627 | if (ret) | 628 | if (ret) { |
| 628 | break; | 629 | dev_info(ctrl->ctrl.device, |
| 630 | "failed to connect i/o queue: %d\n", ret); | ||
| 631 | goto out_free_queues; | ||
| 632 | } | ||
| 633 | set_bit(NVME_RDMA_Q_LIVE, &ctrl->queues[i].flags); | ||
| 629 | } | 634 | } |
| 630 | 635 | ||
| 636 | return 0; | ||
| 637 | |||
| 638 | out_free_queues: | ||
| 639 | nvme_rdma_free_io_queues(ctrl); | ||
| 631 | return ret; | 640 | return ret; |
| 632 | } | 641 | } |
| 633 | 642 | ||
| @@ -712,6 +721,8 @@ static void nvme_rdma_reconnect_ctrl_work(struct work_struct *work) | |||
| 712 | if (ret) | 721 | if (ret) |
| 713 | goto stop_admin_q; | 722 | goto stop_admin_q; |
| 714 | 723 | ||
| 724 | set_bit(NVME_RDMA_Q_LIVE, &ctrl->queues[0].flags); | ||
| 725 | |||
| 715 | ret = nvme_enable_ctrl(&ctrl->ctrl, ctrl->cap); | 726 | ret = nvme_enable_ctrl(&ctrl->ctrl, ctrl->cap); |
| 716 | if (ret) | 727 | if (ret) |
| 717 | goto stop_admin_q; | 728 | goto stop_admin_q; |
| @@ -761,8 +772,10 @@ static void nvme_rdma_error_recovery_work(struct work_struct *work) | |||
| 761 | 772 | ||
| 762 | nvme_stop_keep_alive(&ctrl->ctrl); | 773 | nvme_stop_keep_alive(&ctrl->ctrl); |
| 763 | 774 | ||
| 764 | for (i = 0; i < ctrl->queue_count; i++) | 775 | for (i = 0; i < ctrl->queue_count; i++) { |
| 765 | clear_bit(NVME_RDMA_Q_CONNECTED, &ctrl->queues[i].flags); | 776 | clear_bit(NVME_RDMA_Q_CONNECTED, &ctrl->queues[i].flags); |
| 777 | clear_bit(NVME_RDMA_Q_LIVE, &ctrl->queues[i].flags); | ||
| 778 | } | ||
| 766 | 779 | ||
| 767 | if (ctrl->queue_count > 1) | 780 | if (ctrl->queue_count > 1) |
| 768 | nvme_stop_queues(&ctrl->ctrl); | 781 | nvme_stop_queues(&ctrl->ctrl); |
| @@ -1378,6 +1391,24 @@ nvme_rdma_timeout(struct request *rq, bool reserved) | |||
| 1378 | return BLK_EH_HANDLED; | 1391 | return BLK_EH_HANDLED; |
| 1379 | } | 1392 | } |
| 1380 | 1393 | ||
| 1394 | /* | ||
| 1395 | * We cannot accept any other command until the Connect command has completed. | ||
| 1396 | */ | ||
| 1397 | static inline bool nvme_rdma_queue_is_ready(struct nvme_rdma_queue *queue, | ||
| 1398 | struct request *rq) | ||
| 1399 | { | ||
| 1400 | if (unlikely(!test_bit(NVME_RDMA_Q_LIVE, &queue->flags))) { | ||
| 1401 | struct nvme_command *cmd = (struct nvme_command *)rq->cmd; | ||
| 1402 | |||
| 1403 | if (rq->cmd_type != REQ_TYPE_DRV_PRIV || | ||
| 1404 | cmd->common.opcode != nvme_fabrics_command || | ||
| 1405 | cmd->fabrics.fctype != nvme_fabrics_type_connect) | ||
| 1406 | return false; | ||
| 1407 | } | ||
| 1408 | |||
| 1409 | return true; | ||
| 1410 | } | ||
| 1411 | |||
| 1381 | static int nvme_rdma_queue_rq(struct blk_mq_hw_ctx *hctx, | 1412 | static int nvme_rdma_queue_rq(struct blk_mq_hw_ctx *hctx, |
| 1382 | const struct blk_mq_queue_data *bd) | 1413 | const struct blk_mq_queue_data *bd) |
| 1383 | { | 1414 | { |
| @@ -1394,6 +1425,9 @@ static int nvme_rdma_queue_rq(struct blk_mq_hw_ctx *hctx, | |||
| 1394 | 1425 | ||
| 1395 | WARN_ON_ONCE(rq->tag < 0); | 1426 | WARN_ON_ONCE(rq->tag < 0); |
| 1396 | 1427 | ||
| 1428 | if (!nvme_rdma_queue_is_ready(queue, rq)) | ||
| 1429 | return BLK_MQ_RQ_QUEUE_BUSY; | ||
| 1430 | |||
| 1397 | dev = queue->device->dev; | 1431 | dev = queue->device->dev; |
| 1398 | ib_dma_sync_single_for_cpu(dev, sqe->dma, | 1432 | ib_dma_sync_single_for_cpu(dev, sqe->dma, |
| 1399 | sizeof(struct nvme_command), DMA_TO_DEVICE); | 1433 | sizeof(struct nvme_command), DMA_TO_DEVICE); |
| @@ -1544,6 +1578,8 @@ static int nvme_rdma_configure_admin_queue(struct nvme_rdma_ctrl *ctrl) | |||
| 1544 | if (error) | 1578 | if (error) |
| 1545 | goto out_cleanup_queue; | 1579 | goto out_cleanup_queue; |
| 1546 | 1580 | ||
| 1581 | set_bit(NVME_RDMA_Q_LIVE, &ctrl->queues[0].flags); | ||
| 1582 | |||
| 1547 | error = nvmf_reg_read64(&ctrl->ctrl, NVME_REG_CAP, &ctrl->cap); | 1583 | error = nvmf_reg_read64(&ctrl->ctrl, NVME_REG_CAP, &ctrl->cap); |
| 1548 | if (error) { | 1584 | if (error) { |
| 1549 | dev_err(ctrl->ctrl.device, | 1585 | dev_err(ctrl->ctrl.device, |
diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index b4cacb6f0258..a21437a33adb 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c | |||
| @@ -838,9 +838,13 @@ static void nvmet_fatal_error_handler(struct work_struct *work) | |||
| 838 | 838 | ||
| 839 | void nvmet_ctrl_fatal_error(struct nvmet_ctrl *ctrl) | 839 | void nvmet_ctrl_fatal_error(struct nvmet_ctrl *ctrl) |
| 840 | { | 840 | { |
| 841 | ctrl->csts |= NVME_CSTS_CFS; | 841 | mutex_lock(&ctrl->lock); |
| 842 | INIT_WORK(&ctrl->fatal_err_work, nvmet_fatal_error_handler); | 842 | if (!(ctrl->csts & NVME_CSTS_CFS)) { |
| 843 | schedule_work(&ctrl->fatal_err_work); | 843 | ctrl->csts |= NVME_CSTS_CFS; |
| 844 | INIT_WORK(&ctrl->fatal_err_work, nvmet_fatal_error_handler); | ||
| 845 | schedule_work(&ctrl->fatal_err_work); | ||
| 846 | } | ||
| 847 | mutex_unlock(&ctrl->lock); | ||
| 844 | } | 848 | } |
| 845 | EXPORT_SYMBOL_GPL(nvmet_ctrl_fatal_error); | 849 | EXPORT_SYMBOL_GPL(nvmet_ctrl_fatal_error); |
| 846 | 850 | ||
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c index f8d23999e0f2..005ef5d17a19 100644 --- a/drivers/nvme/target/rdma.c +++ b/drivers/nvme/target/rdma.c | |||
| @@ -951,6 +951,7 @@ err_destroy_cq: | |||
| 951 | 951 | ||
| 952 | static void nvmet_rdma_destroy_queue_ib(struct nvmet_rdma_queue *queue) | 952 | static void nvmet_rdma_destroy_queue_ib(struct nvmet_rdma_queue *queue) |
| 953 | { | 953 | { |
| 954 | ib_drain_qp(queue->cm_id->qp); | ||
| 954 | rdma_destroy_qp(queue->cm_id); | 955 | rdma_destroy_qp(queue->cm_id); |
| 955 | ib_free_cq(queue->cq); | 956 | ib_free_cq(queue->cq); |
| 956 | } | 957 | } |
| @@ -1066,6 +1067,7 @@ nvmet_rdma_alloc_queue(struct nvmet_rdma_device *ndev, | |||
| 1066 | spin_lock_init(&queue->rsp_wr_wait_lock); | 1067 | spin_lock_init(&queue->rsp_wr_wait_lock); |
| 1067 | INIT_LIST_HEAD(&queue->free_rsps); | 1068 | INIT_LIST_HEAD(&queue->free_rsps); |
| 1068 | spin_lock_init(&queue->rsps_lock); | 1069 | spin_lock_init(&queue->rsps_lock); |
| 1070 | INIT_LIST_HEAD(&queue->queue_list); | ||
| 1069 | 1071 | ||
| 1070 | queue->idx = ida_simple_get(&nvmet_rdma_queue_ida, 0, 0, GFP_KERNEL); | 1072 | queue->idx = ida_simple_get(&nvmet_rdma_queue_ida, 0, 0, GFP_KERNEL); |
| 1071 | if (queue->idx < 0) { | 1073 | if (queue->idx < 0) { |
| @@ -1244,7 +1246,6 @@ static void __nvmet_rdma_queue_disconnect(struct nvmet_rdma_queue *queue) | |||
| 1244 | 1246 | ||
| 1245 | if (disconnect) { | 1247 | if (disconnect) { |
| 1246 | rdma_disconnect(queue->cm_id); | 1248 | rdma_disconnect(queue->cm_id); |
| 1247 | ib_drain_qp(queue->cm_id->qp); | ||
| 1248 | schedule_work(&queue->release_work); | 1249 | schedule_work(&queue->release_work); |
| 1249 | } | 1250 | } |
| 1250 | } | 1251 | } |
| @@ -1269,7 +1270,12 @@ static void nvmet_rdma_queue_connect_fail(struct rdma_cm_id *cm_id, | |||
| 1269 | { | 1270 | { |
| 1270 | WARN_ON_ONCE(queue->state != NVMET_RDMA_Q_CONNECTING); | 1271 | WARN_ON_ONCE(queue->state != NVMET_RDMA_Q_CONNECTING); |
| 1271 | 1272 | ||
| 1272 | pr_err("failed to connect queue\n"); | 1273 | mutex_lock(&nvmet_rdma_queue_mutex); |
| 1274 | if (!list_empty(&queue->queue_list)) | ||
| 1275 | list_del_init(&queue->queue_list); | ||
| 1276 | mutex_unlock(&nvmet_rdma_queue_mutex); | ||
| 1277 | |||
| 1278 | pr_err("failed to connect queue %d\n", queue->idx); | ||
| 1273 | schedule_work(&queue->release_work); | 1279 | schedule_work(&queue->release_work); |
| 1274 | } | 1280 | } |
| 1275 | 1281 | ||
| @@ -1352,7 +1358,13 @@ static int nvmet_rdma_cm_handler(struct rdma_cm_id *cm_id, | |||
| 1352 | case RDMA_CM_EVENT_ADDR_CHANGE: | 1358 | case RDMA_CM_EVENT_ADDR_CHANGE: |
| 1353 | case RDMA_CM_EVENT_DISCONNECTED: | 1359 | case RDMA_CM_EVENT_DISCONNECTED: |
| 1354 | case RDMA_CM_EVENT_TIMEWAIT_EXIT: | 1360 | case RDMA_CM_EVENT_TIMEWAIT_EXIT: |
| 1355 | nvmet_rdma_queue_disconnect(queue); | 1361 | /* |
| 1362 | * We might end up here when we already freed the qp | ||
| 1363 | * which means queue release sequence is in progress, | ||
| 1364 | * so don't get in the way... | ||
| 1365 | */ | ||
| 1366 | if (queue) | ||
| 1367 | nvmet_rdma_queue_disconnect(queue); | ||
| 1356 | break; | 1368 | break; |
| 1357 | case RDMA_CM_EVENT_DEVICE_REMOVAL: | 1369 | case RDMA_CM_EVENT_DEVICE_REMOVAL: |
| 1358 | ret = nvmet_rdma_device_removal(cm_id, queue); | 1370 | ret = nvmet_rdma_device_removal(cm_id, queue); |
diff --git a/drivers/pci/pci-mid.c b/drivers/pci/pci-mid.c index 55f453de562e..c7f3408e3148 100644 --- a/drivers/pci/pci-mid.c +++ b/drivers/pci/pci-mid.c | |||
| @@ -29,6 +29,11 @@ static int mid_pci_set_power_state(struct pci_dev *pdev, pci_power_t state) | |||
| 29 | return intel_mid_pci_set_power_state(pdev, state); | 29 | return intel_mid_pci_set_power_state(pdev, state); |
| 30 | } | 30 | } |
| 31 | 31 | ||
| 32 | static pci_power_t mid_pci_get_power_state(struct pci_dev *pdev) | ||
| 33 | { | ||
| 34 | return intel_mid_pci_get_power_state(pdev); | ||
| 35 | } | ||
| 36 | |||
| 32 | static pci_power_t mid_pci_choose_state(struct pci_dev *pdev) | 37 | static pci_power_t mid_pci_choose_state(struct pci_dev *pdev) |
| 33 | { | 38 | { |
| 34 | return PCI_D3hot; | 39 | return PCI_D3hot; |
| @@ -52,6 +57,7 @@ static bool mid_pci_need_resume(struct pci_dev *dev) | |||
| 52 | static struct pci_platform_pm_ops mid_pci_platform_pm = { | 57 | static struct pci_platform_pm_ops mid_pci_platform_pm = { |
| 53 | .is_manageable = mid_pci_power_manageable, | 58 | .is_manageable = mid_pci_power_manageable, |
| 54 | .set_state = mid_pci_set_power_state, | 59 | .set_state = mid_pci_set_power_state, |
| 60 | .get_state = mid_pci_get_power_state, | ||
| 55 | .choose_state = mid_pci_choose_state, | 61 | .choose_state = mid_pci_choose_state, |
| 56 | .sleep_wake = mid_pci_sleep_wake, | 62 | .sleep_wake = mid_pci_sleep_wake, |
| 57 | .run_wake = mid_pci_run_wake, | 63 | .run_wake = mid_pci_run_wake, |
diff --git a/drivers/rtc/rtc-asm9260.c b/drivers/rtc/rtc-asm9260.c index 18a93d3e3f93..d36534965635 100644 --- a/drivers/rtc/rtc-asm9260.c +++ b/drivers/rtc/rtc-asm9260.c | |||
| @@ -327,6 +327,7 @@ static const struct of_device_id asm9260_dt_ids[] = { | |||
| 327 | { .compatible = "alphascale,asm9260-rtc", }, | 327 | { .compatible = "alphascale,asm9260-rtc", }, |
| 328 | {} | 328 | {} |
| 329 | }; | 329 | }; |
| 330 | MODULE_DEVICE_TABLE(of, asm9260_dt_ids); | ||
| 330 | 331 | ||
| 331 | static struct platform_driver asm9260_rtc_driver = { | 332 | static struct platform_driver asm9260_rtc_driver = { |
| 332 | .probe = asm9260_rtc_probe, | 333 | .probe = asm9260_rtc_probe, |
diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c index dd3d59806ffa..7030d7cd3861 100644 --- a/drivers/rtc/rtc-cmos.c +++ b/drivers/rtc/rtc-cmos.c | |||
| @@ -776,7 +776,7 @@ static void cmos_do_shutdown(int rtc_irq) | |||
| 776 | spin_unlock_irq(&rtc_lock); | 776 | spin_unlock_irq(&rtc_lock); |
| 777 | } | 777 | } |
| 778 | 778 | ||
| 779 | static void __exit cmos_do_remove(struct device *dev) | 779 | static void cmos_do_remove(struct device *dev) |
| 780 | { | 780 | { |
| 781 | struct cmos_rtc *cmos = dev_get_drvdata(dev); | 781 | struct cmos_rtc *cmos = dev_get_drvdata(dev); |
| 782 | struct resource *ports; | 782 | struct resource *ports; |
| @@ -996,8 +996,9 @@ static u32 rtc_handler(void *context) | |||
| 996 | struct cmos_rtc *cmos = dev_get_drvdata(dev); | 996 | struct cmos_rtc *cmos = dev_get_drvdata(dev); |
| 997 | unsigned char rtc_control = 0; | 997 | unsigned char rtc_control = 0; |
| 998 | unsigned char rtc_intr; | 998 | unsigned char rtc_intr; |
| 999 | unsigned long flags; | ||
| 999 | 1000 | ||
| 1000 | spin_lock_irq(&rtc_lock); | 1001 | spin_lock_irqsave(&rtc_lock, flags); |
| 1001 | if (cmos_rtc.suspend_ctrl) | 1002 | if (cmos_rtc.suspend_ctrl) |
| 1002 | rtc_control = CMOS_READ(RTC_CONTROL); | 1003 | rtc_control = CMOS_READ(RTC_CONTROL); |
| 1003 | if (rtc_control & RTC_AIE) { | 1004 | if (rtc_control & RTC_AIE) { |
| @@ -1006,7 +1007,7 @@ static u32 rtc_handler(void *context) | |||
| 1006 | rtc_intr = CMOS_READ(RTC_INTR_FLAGS); | 1007 | rtc_intr = CMOS_READ(RTC_INTR_FLAGS); |
| 1007 | rtc_update_irq(cmos->rtc, 1, rtc_intr); | 1008 | rtc_update_irq(cmos->rtc, 1, rtc_intr); |
| 1008 | } | 1009 | } |
| 1009 | spin_unlock_irq(&rtc_lock); | 1010 | spin_unlock_irqrestore(&rtc_lock, flags); |
| 1010 | 1011 | ||
| 1011 | pm_wakeup_event(dev, 0); | 1012 | pm_wakeup_event(dev, 0); |
| 1012 | acpi_clear_event(ACPI_EVENT_RTC); | 1013 | acpi_clear_event(ACPI_EVENT_RTC); |
| @@ -1129,7 +1130,7 @@ static int cmos_pnp_probe(struct pnp_dev *pnp, const struct pnp_device_id *id) | |||
| 1129 | pnp_irq(pnp, 0)); | 1130 | pnp_irq(pnp, 0)); |
| 1130 | } | 1131 | } |
| 1131 | 1132 | ||
| 1132 | static void __exit cmos_pnp_remove(struct pnp_dev *pnp) | 1133 | static void cmos_pnp_remove(struct pnp_dev *pnp) |
| 1133 | { | 1134 | { |
| 1134 | cmos_do_remove(&pnp->dev); | 1135 | cmos_do_remove(&pnp->dev); |
| 1135 | } | 1136 | } |
| @@ -1161,7 +1162,7 @@ static struct pnp_driver cmos_pnp_driver = { | |||
| 1161 | .name = (char *) driver_name, | 1162 | .name = (char *) driver_name, |
| 1162 | .id_table = rtc_ids, | 1163 | .id_table = rtc_ids, |
| 1163 | .probe = cmos_pnp_probe, | 1164 | .probe = cmos_pnp_probe, |
| 1164 | .remove = __exit_p(cmos_pnp_remove), | 1165 | .remove = cmos_pnp_remove, |
| 1165 | .shutdown = cmos_pnp_shutdown, | 1166 | .shutdown = cmos_pnp_shutdown, |
| 1166 | 1167 | ||
| 1167 | /* flag ensures resume() gets called, and stops syslog spam */ | 1168 | /* flag ensures resume() gets called, and stops syslog spam */ |
| @@ -1238,7 +1239,7 @@ static int __init cmos_platform_probe(struct platform_device *pdev) | |||
| 1238 | return cmos_do_probe(&pdev->dev, resource, irq); | 1239 | return cmos_do_probe(&pdev->dev, resource, irq); |
| 1239 | } | 1240 | } |
| 1240 | 1241 | ||
| 1241 | static int __exit cmos_platform_remove(struct platform_device *pdev) | 1242 | static int cmos_platform_remove(struct platform_device *pdev) |
| 1242 | { | 1243 | { |
| 1243 | cmos_do_remove(&pdev->dev); | 1244 | cmos_do_remove(&pdev->dev); |
| 1244 | return 0; | 1245 | return 0; |
| @@ -1263,7 +1264,7 @@ static void cmos_platform_shutdown(struct platform_device *pdev) | |||
| 1263 | MODULE_ALIAS("platform:rtc_cmos"); | 1264 | MODULE_ALIAS("platform:rtc_cmos"); |
| 1264 | 1265 | ||
| 1265 | static struct platform_driver cmos_platform_driver = { | 1266 | static struct platform_driver cmos_platform_driver = { |
| 1266 | .remove = __exit_p(cmos_platform_remove), | 1267 | .remove = cmos_platform_remove, |
| 1267 | .shutdown = cmos_platform_shutdown, | 1268 | .shutdown = cmos_platform_shutdown, |
| 1268 | .driver = { | 1269 | .driver = { |
| 1269 | .name = driver_name, | 1270 | .name = driver_name, |
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index b04ea9b5ae67..51e52446eacb 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers/rtc/rtc-omap.c | |||
| @@ -113,6 +113,7 @@ | |||
| 113 | /* OMAP_RTC_OSC_REG bit fields: */ | 113 | /* OMAP_RTC_OSC_REG bit fields: */ |
| 114 | #define OMAP_RTC_OSC_32KCLK_EN BIT(6) | 114 | #define OMAP_RTC_OSC_32KCLK_EN BIT(6) |
| 115 | #define OMAP_RTC_OSC_SEL_32KCLK_SRC BIT(3) | 115 | #define OMAP_RTC_OSC_SEL_32KCLK_SRC BIT(3) |
| 116 | #define OMAP_RTC_OSC_OSC32K_GZ_DISABLE BIT(4) | ||
| 116 | 117 | ||
| 117 | /* OMAP_RTC_IRQWAKEEN bit fields: */ | 118 | /* OMAP_RTC_IRQWAKEEN bit fields: */ |
| 118 | #define OMAP_RTC_IRQWAKEEN_ALARM_WAKEEN BIT(1) | 119 | #define OMAP_RTC_IRQWAKEEN_ALARM_WAKEEN BIT(1) |
| @@ -146,6 +147,7 @@ struct omap_rtc { | |||
| 146 | u8 interrupts_reg; | 147 | u8 interrupts_reg; |
| 147 | bool is_pmic_controller; | 148 | bool is_pmic_controller; |
| 148 | bool has_ext_clk; | 149 | bool has_ext_clk; |
| 150 | bool is_suspending; | ||
| 149 | const struct omap_rtc_device_type *type; | 151 | const struct omap_rtc_device_type *type; |
| 150 | struct pinctrl_dev *pctldev; | 152 | struct pinctrl_dev *pctldev; |
| 151 | }; | 153 | }; |
| @@ -786,8 +788,9 @@ static int omap_rtc_probe(struct platform_device *pdev) | |||
| 786 | */ | 788 | */ |
| 787 | if (rtc->has_ext_clk) { | 789 | if (rtc->has_ext_clk) { |
| 788 | reg = rtc_read(rtc, OMAP_RTC_OSC_REG); | 790 | reg = rtc_read(rtc, OMAP_RTC_OSC_REG); |
| 789 | rtc_write(rtc, OMAP_RTC_OSC_REG, | 791 | reg &= ~OMAP_RTC_OSC_OSC32K_GZ_DISABLE; |
| 790 | reg | OMAP_RTC_OSC_SEL_32KCLK_SRC); | 792 | reg |= OMAP_RTC_OSC_32KCLK_EN | OMAP_RTC_OSC_SEL_32KCLK_SRC; |
| 793 | rtc_writel(rtc, OMAP_RTC_OSC_REG, reg); | ||
| 791 | } | 794 | } |
| 792 | 795 | ||
| 793 | rtc->type->lock(rtc); | 796 | rtc->type->lock(rtc); |
| @@ -898,8 +901,7 @@ static int omap_rtc_suspend(struct device *dev) | |||
| 898 | rtc_write(rtc, OMAP_RTC_INTERRUPTS_REG, 0); | 901 | rtc_write(rtc, OMAP_RTC_INTERRUPTS_REG, 0); |
| 899 | rtc->type->lock(rtc); | 902 | rtc->type->lock(rtc); |
| 900 | 903 | ||
| 901 | /* Disable the clock/module */ | 904 | rtc->is_suspending = true; |
| 902 | pm_runtime_put_sync(dev); | ||
| 903 | 905 | ||
| 904 | return 0; | 906 | return 0; |
| 905 | } | 907 | } |
| @@ -908,9 +910,6 @@ static int omap_rtc_resume(struct device *dev) | |||
| 908 | { | 910 | { |
| 909 | struct omap_rtc *rtc = dev_get_drvdata(dev); | 911 | struct omap_rtc *rtc = dev_get_drvdata(dev); |
| 910 | 912 | ||
| 911 | /* Enable the clock/module so that we can access the registers */ | ||
| 912 | pm_runtime_get_sync(dev); | ||
| 913 | |||
| 914 | rtc->type->unlock(rtc); | 913 | rtc->type->unlock(rtc); |
| 915 | if (device_may_wakeup(dev)) | 914 | if (device_may_wakeup(dev)) |
| 916 | disable_irq_wake(rtc->irq_alarm); | 915 | disable_irq_wake(rtc->irq_alarm); |
| @@ -918,11 +917,34 @@ static int omap_rtc_resume(struct device *dev) | |||
| 918 | rtc_write(rtc, OMAP_RTC_INTERRUPTS_REG, rtc->interrupts_reg); | 917 | rtc_write(rtc, OMAP_RTC_INTERRUPTS_REG, rtc->interrupts_reg); |
| 919 | rtc->type->lock(rtc); | 918 | rtc->type->lock(rtc); |
| 920 | 919 | ||
| 920 | rtc->is_suspending = false; | ||
| 921 | |||
| 921 | return 0; | 922 | return 0; |
| 922 | } | 923 | } |
| 923 | #endif | 924 | #endif |
| 924 | 925 | ||
| 925 | static SIMPLE_DEV_PM_OPS(omap_rtc_pm_ops, omap_rtc_suspend, omap_rtc_resume); | 926 | #ifdef CONFIG_PM |
| 927 | static int omap_rtc_runtime_suspend(struct device *dev) | ||
| 928 | { | ||
| 929 | struct omap_rtc *rtc = dev_get_drvdata(dev); | ||
| 930 | |||
| 931 | if (rtc->is_suspending && !rtc->has_ext_clk) | ||
| 932 | return -EBUSY; | ||
| 933 | |||
| 934 | return 0; | ||
| 935 | } | ||
| 936 | |||
| 937 | static int omap_rtc_runtime_resume(struct device *dev) | ||
| 938 | { | ||
| 939 | return 0; | ||
| 940 | } | ||
| 941 | #endif | ||
| 942 | |||
| 943 | static const struct dev_pm_ops omap_rtc_pm_ops = { | ||
| 944 | SET_SYSTEM_SLEEP_PM_OPS(omap_rtc_suspend, omap_rtc_resume) | ||
| 945 | SET_RUNTIME_PM_OPS(omap_rtc_runtime_suspend, | ||
| 946 | omap_rtc_runtime_resume, NULL) | ||
| 947 | }; | ||
| 926 | 948 | ||
| 927 | static void omap_rtc_shutdown(struct platform_device *pdev) | 949 | static void omap_rtc_shutdown(struct platform_device *pdev) |
| 928 | { | 950 | { |
diff --git a/drivers/video/fbdev/amba-clcd-versatile.c b/drivers/video/fbdev/amba-clcd-versatile.c index 19ad8645d93c..e5d9bfc1703a 100644 --- a/drivers/video/fbdev/amba-clcd-versatile.c +++ b/drivers/video/fbdev/amba-clcd-versatile.c | |||
| @@ -526,8 +526,8 @@ int versatile_clcd_init_panel(struct clcd_fb *fb, | |||
| 526 | np = of_find_matching_node_and_match(NULL, versatile_clcd_of_match, | 526 | np = of_find_matching_node_and_match(NULL, versatile_clcd_of_match, |
| 527 | &clcd_id); | 527 | &clcd_id); |
| 528 | if (!np) { | 528 | if (!np) { |
| 529 | dev_err(dev, "no Versatile syscon node\n"); | 529 | /* Vexpress does not have this */ |
| 530 | return -ENODEV; | 530 | return 0; |
| 531 | } | 531 | } |
| 532 | versatile_clcd_type = (enum versatile_clcd)clcd_id->data; | 532 | versatile_clcd_type = (enum versatile_clcd)clcd_id->data; |
| 533 | 533 | ||
diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c index 6a4d0e5418a1..b3ebe512d64c 100644 --- a/fs/fuse/dir.c +++ b/fs/fuse/dir.c | |||
| @@ -286,6 +286,11 @@ const struct dentry_operations fuse_dentry_operations = { | |||
| 286 | .d_release = fuse_dentry_release, | 286 | .d_release = fuse_dentry_release, |
| 287 | }; | 287 | }; |
| 288 | 288 | ||
| 289 | const struct dentry_operations fuse_root_dentry_operations = { | ||
| 290 | .d_init = fuse_dentry_init, | ||
| 291 | .d_release = fuse_dentry_release, | ||
| 292 | }; | ||
| 293 | |||
| 289 | int fuse_valid_type(int m) | 294 | int fuse_valid_type(int m) |
| 290 | { | 295 | { |
| 291 | return S_ISREG(m) || S_ISDIR(m) || S_ISLNK(m) || S_ISCHR(m) || | 296 | return S_ISREG(m) || S_ISDIR(m) || S_ISLNK(m) || S_ISCHR(m) || |
diff --git a/fs/fuse/file.c b/fs/fuse/file.c index abc66a6237fd..2401c5dabb2a 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c | |||
| @@ -1985,6 +1985,10 @@ static int fuse_write_end(struct file *file, struct address_space *mapping, | |||
| 1985 | { | 1985 | { |
| 1986 | struct inode *inode = page->mapping->host; | 1986 | struct inode *inode = page->mapping->host; |
| 1987 | 1987 | ||
| 1988 | /* Haven't copied anything? Skip zeroing, size extending, dirtying. */ | ||
| 1989 | if (!copied) | ||
| 1990 | goto unlock; | ||
| 1991 | |||
| 1988 | if (!PageUptodate(page)) { | 1992 | if (!PageUptodate(page)) { |
| 1989 | /* Zero any unwritten bytes at the end of the page */ | 1993 | /* Zero any unwritten bytes at the end of the page */ |
| 1990 | size_t endoff = (pos + copied) & ~PAGE_MASK; | 1994 | size_t endoff = (pos + copied) & ~PAGE_MASK; |
| @@ -1995,6 +1999,8 @@ static int fuse_write_end(struct file *file, struct address_space *mapping, | |||
| 1995 | 1999 | ||
| 1996 | fuse_write_update_size(inode, pos + copied); | 2000 | fuse_write_update_size(inode, pos + copied); |
| 1997 | set_page_dirty(page); | 2001 | set_page_dirty(page); |
| 2002 | |||
| 2003 | unlock: | ||
| 1998 | unlock_page(page); | 2004 | unlock_page(page); |
| 1999 | put_page(page); | 2005 | put_page(page); |
| 2000 | 2006 | ||
diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h index 0dfbb136e59a..91307940c8ac 100644 --- a/fs/fuse/fuse_i.h +++ b/fs/fuse/fuse_i.h | |||
| @@ -692,6 +692,7 @@ static inline u64 get_node_id(struct inode *inode) | |||
| 692 | extern const struct file_operations fuse_dev_operations; | 692 | extern const struct file_operations fuse_dev_operations; |
| 693 | 693 | ||
| 694 | extern const struct dentry_operations fuse_dentry_operations; | 694 | extern const struct dentry_operations fuse_dentry_operations; |
| 695 | extern const struct dentry_operations fuse_root_dentry_operations; | ||
| 695 | 696 | ||
| 696 | /** | 697 | /** |
| 697 | * Inode to nodeid comparison. | 698 | * Inode to nodeid comparison. |
diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c index 17141099f2e7..6fe6a88ecb4a 100644 --- a/fs/fuse/inode.c +++ b/fs/fuse/inode.c | |||
| @@ -1131,10 +1131,11 @@ static int fuse_fill_super(struct super_block *sb, void *data, int silent) | |||
| 1131 | 1131 | ||
| 1132 | err = -ENOMEM; | 1132 | err = -ENOMEM; |
| 1133 | root = fuse_get_root_inode(sb, d.rootmode); | 1133 | root = fuse_get_root_inode(sb, d.rootmode); |
| 1134 | sb->s_d_op = &fuse_root_dentry_operations; | ||
| 1134 | root_dentry = d_make_root(root); | 1135 | root_dentry = d_make_root(root); |
| 1135 | if (!root_dentry) | 1136 | if (!root_dentry) |
| 1136 | goto err_dev_free; | 1137 | goto err_dev_free; |
| 1137 | /* only now - we want root dentry with NULL ->d_op */ | 1138 | /* Root dentry doesn't have .d_revalidate */ |
| 1138 | sb->s_d_op = &fuse_dentry_operations; | 1139 | sb->s_d_op = &fuse_dentry_operations; |
| 1139 | 1140 | ||
| 1140 | init_req = fuse_request_alloc(0); | 1141 | init_req = fuse_request_alloc(0); |
diff --git a/fs/orangefs/orangefs-debugfs.c b/fs/orangefs/orangefs-debugfs.c index d484068ca716..38887cc5577f 100644 --- a/fs/orangefs/orangefs-debugfs.c +++ b/fs/orangefs/orangefs-debugfs.c | |||
| @@ -114,6 +114,7 @@ static const struct seq_operations help_debug_ops = { | |||
| 114 | }; | 114 | }; |
| 115 | 115 | ||
| 116 | const struct file_operations debug_help_fops = { | 116 | const struct file_operations debug_help_fops = { |
| 117 | .owner = THIS_MODULE, | ||
| 117 | .open = orangefs_debug_help_open, | 118 | .open = orangefs_debug_help_open, |
| 118 | .read = seq_read, | 119 | .read = seq_read, |
| 119 | .release = seq_release, | 120 | .release = seq_release, |
| @@ -121,6 +122,7 @@ const struct file_operations debug_help_fops = { | |||
| 121 | }; | 122 | }; |
| 122 | 123 | ||
| 123 | static const struct file_operations kernel_debug_fops = { | 124 | static const struct file_operations kernel_debug_fops = { |
| 125 | .owner = THIS_MODULE, | ||
| 124 | .open = orangefs_debug_open, | 126 | .open = orangefs_debug_open, |
| 125 | .read = orangefs_debug_read, | 127 | .read = orangefs_debug_read, |
| 126 | .write = orangefs_debug_write, | 128 | .write = orangefs_debug_write, |
diff --git a/fs/xattr.c b/fs/xattr.c index 3368659c471e..2d13b4e62fae 100644 --- a/fs/xattr.c +++ b/fs/xattr.c | |||
| @@ -170,7 +170,7 @@ int __vfs_setxattr_noperm(struct dentry *dentry, const char *name, | |||
| 170 | const void *value, size_t size, int flags) | 170 | const void *value, size_t size, int flags) |
| 171 | { | 171 | { |
| 172 | struct inode *inode = dentry->d_inode; | 172 | struct inode *inode = dentry->d_inode; |
| 173 | int error = -EOPNOTSUPP; | 173 | int error = -EAGAIN; |
| 174 | int issec = !strncmp(name, XATTR_SECURITY_PREFIX, | 174 | int issec = !strncmp(name, XATTR_SECURITY_PREFIX, |
| 175 | XATTR_SECURITY_PREFIX_LEN); | 175 | XATTR_SECURITY_PREFIX_LEN); |
| 176 | 176 | ||
| @@ -183,15 +183,21 @@ int __vfs_setxattr_noperm(struct dentry *dentry, const char *name, | |||
| 183 | security_inode_post_setxattr(dentry, name, value, | 183 | security_inode_post_setxattr(dentry, name, value, |
| 184 | size, flags); | 184 | size, flags); |
| 185 | } | 185 | } |
| 186 | } else if (issec) { | 186 | } else { |
| 187 | const char *suffix = name + XATTR_SECURITY_PREFIX_LEN; | ||
| 188 | |||
| 189 | if (unlikely(is_bad_inode(inode))) | 187 | if (unlikely(is_bad_inode(inode))) |
| 190 | return -EIO; | 188 | return -EIO; |
| 191 | error = security_inode_setsecurity(inode, suffix, value, | 189 | } |
| 192 | size, flags); | 190 | if (error == -EAGAIN) { |
| 193 | if (!error) | 191 | error = -EOPNOTSUPP; |
| 194 | fsnotify_xattr(dentry); | 192 | |
| 193 | if (issec) { | ||
| 194 | const char *suffix = name + XATTR_SECURITY_PREFIX_LEN; | ||
| 195 | |||
| 196 | error = security_inode_setsecurity(inode, suffix, value, | ||
| 197 | size, flags); | ||
| 198 | if (!error) | ||
| 199 | fsnotify_xattr(dentry); | ||
| 200 | } | ||
| 195 | } | 201 | } |
| 196 | 202 | ||
| 197 | return error; | 203 | return error; |
diff --git a/include/acpi/actbl.h b/include/acpi/actbl.h index 1b949e08015c..c19700e2a2fe 100644 --- a/include/acpi/actbl.h +++ b/include/acpi/actbl.h | |||
| @@ -230,72 +230,62 @@ struct acpi_table_facs { | |||
| 230 | /* Fields common to all versions of the FADT */ | 230 | /* Fields common to all versions of the FADT */ |
| 231 | 231 | ||
| 232 | struct acpi_table_fadt { | 232 | struct acpi_table_fadt { |
| 233 | struct acpi_table_header header; /* [V1] Common ACPI table header */ | 233 | struct acpi_table_header header; /* Common ACPI table header */ |
| 234 | u32 facs; /* [V1] 32-bit physical address of FACS */ | 234 | u32 facs; /* 32-bit physical address of FACS */ |
| 235 | u32 dsdt; /* [V1] 32-bit physical address of DSDT */ | 235 | u32 dsdt; /* 32-bit physical address of DSDT */ |
| 236 | u8 model; /* [V1] System Interrupt Model (ACPI 1.0) - not used in ACPI 2.0+ */ | 236 | u8 model; /* System Interrupt Model (ACPI 1.0) - not used in ACPI 2.0+ */ |
| 237 | u8 preferred_profile; /* [V1] Conveys preferred power management profile to OSPM. */ | 237 | u8 preferred_profile; /* Conveys preferred power management profile to OSPM. */ |
| 238 | u16 sci_interrupt; /* [V1] System vector of SCI interrupt */ | 238 | u16 sci_interrupt; /* System vector of SCI interrupt */ |
| 239 | u32 smi_command; /* [V1] 32-bit Port address of SMI command port */ | 239 | u32 smi_command; /* 32-bit Port address of SMI command port */ |
| 240 | u8 acpi_enable; /* [V1] Value to write to SMI_CMD to enable ACPI */ | 240 | u8 acpi_enable; /* Value to write to SMI_CMD to enable ACPI */ |
| 241 | u8 acpi_disable; /* [V1] Value to write to SMI_CMD to disable ACPI */ | 241 | u8 acpi_disable; /* Value to write to SMI_CMD to disable ACPI */ |
| 242 | u8 s4_bios_request; /* [V1] Value to write to SMI_CMD to enter S4BIOS state */ | 242 | u8 s4_bios_request; /* Value to write to SMI_CMD to enter S4BIOS state */ |
| 243 | u8 pstate_control; /* [V1] Processor performance state control */ | 243 | u8 pstate_control; /* Processor performance state control */ |
| 244 | u32 pm1a_event_block; /* [V1] 32-bit port address of Power Mgt 1a Event Reg Blk */ | 244 | u32 pm1a_event_block; /* 32-bit port address of Power Mgt 1a Event Reg Blk */ |
| 245 | u32 pm1b_event_block; /* [V1] 32-bit port address of Power Mgt 1b Event Reg Blk */ | 245 | u32 pm1b_event_block; /* 32-bit port address of Power Mgt 1b Event Reg Blk */ |
| 246 | u32 pm1a_control_block; /* [V1] 32-bit port address of Power Mgt 1a Control Reg Blk */ | 246 | u32 pm1a_control_block; /* 32-bit port address of Power Mgt 1a Control Reg Blk */ |
| 247 | u32 pm1b_control_block; /* [V1] 32-bit port address of Power Mgt 1b Control Reg Blk */ | 247 | u32 pm1b_control_block; /* 32-bit port address of Power Mgt 1b Control Reg Blk */ |
| 248 | u32 pm2_control_block; /* [V1] 32-bit port address of Power Mgt 2 Control Reg Blk */ | 248 | u32 pm2_control_block; /* 32-bit port address of Power Mgt 2 Control Reg Blk */ |
| 249 | u32 pm_timer_block; /* [V1] 32-bit port address of Power Mgt Timer Ctrl Reg Blk */ | 249 | u32 pm_timer_block; /* 32-bit port address of Power Mgt Timer Ctrl Reg Blk */ |
| 250 | u32 gpe0_block; /* [V1] 32-bit port address of General Purpose Event 0 Reg Blk */ | 250 | u32 gpe0_block; /* 32-bit port address of General Purpose Event 0 Reg Blk */ |
| 251 | u32 gpe1_block; /* [V1] 32-bit port address of General Purpose Event 1 Reg Blk */ | 251 | u32 gpe1_block; /* 32-bit port address of General Purpose Event 1 Reg Blk */ |
| 252 | u8 pm1_event_length; /* [V1] Byte Length of ports at pm1x_event_block */ | 252 | u8 pm1_event_length; /* Byte Length of ports at pm1x_event_block */ |
| 253 | u8 pm1_control_length; /* [V1] Byte Length of ports at pm1x_control_block */ | 253 | u8 pm1_control_length; /* Byte Length of ports at pm1x_control_block */ |
| 254 | u8 pm2_control_length; /* [V1] Byte Length of ports at pm2_control_block */ | 254 | u8 pm2_control_length; /* Byte Length of ports at pm2_control_block */ |
| 255 | u8 pm_timer_length; /* [V1] Byte Length of ports at pm_timer_block */ | 255 | u8 pm_timer_length; /* Byte Length of ports at pm_timer_block */ |
| 256 | u8 gpe0_block_length; /* [V1] Byte Length of ports at gpe0_block */ | 256 | u8 gpe0_block_length; /* Byte Length of ports at gpe0_block */ |
| 257 | u8 gpe1_block_length; /* [V1] Byte Length of ports at gpe1_block */ | 257 | u8 gpe1_block_length; /* Byte Length of ports at gpe1_block */ |
| 258 | u8 gpe1_base; /* [V1] Offset in GPE number space where GPE1 events start */ | 258 | u8 gpe1_base; /* Offset in GPE number space where GPE1 events start */ |
| 259 | u8 cst_control; /* [V1] Support for the _CST object and C-States change notification */ | 259 | u8 cst_control; /* Support for the _CST object and C-States change notification */ |
| 260 | u16 c2_latency; /* [V1] Worst case HW latency to enter/exit C2 state */ | 260 | u16 c2_latency; /* Worst case HW latency to enter/exit C2 state */ |
| 261 | u16 c3_latency; /* [V1] Worst case HW latency to enter/exit C3 state */ | 261 | u16 c3_latency; /* Worst case HW latency to enter/exit C3 state */ |
| 262 | u16 flush_size; /* [V1] Processor memory cache line width, in bytes */ | 262 | u16 flush_size; /* Processor memory cache line width, in bytes */ |
| 263 | u16 flush_stride; /* [V1] Number of flush strides that need to be read */ | 263 | u16 flush_stride; /* Number of flush strides that need to be read */ |
| 264 | u8 duty_offset; /* [V1] Processor duty cycle index in processor P_CNT reg */ | 264 | u8 duty_offset; /* Processor duty cycle index in processor P_CNT reg */ |
| 265 | u8 duty_width; /* [V1] Processor duty cycle value bit width in P_CNT register */ | 265 | u8 duty_width; /* Processor duty cycle value bit width in P_CNT register */ |
| 266 | u8 day_alarm; /* [V1] Index to day-of-month alarm in RTC CMOS RAM */ | 266 | u8 day_alarm; /* Index to day-of-month alarm in RTC CMOS RAM */ |
| 267 | u8 month_alarm; /* [V1] Index to month-of-year alarm in RTC CMOS RAM */ | 267 | u8 month_alarm; /* Index to month-of-year alarm in RTC CMOS RAM */ |
| 268 | u8 century; /* [V1] Index to century in RTC CMOS RAM */ | 268 | u8 century; /* Index to century in RTC CMOS RAM */ |
| 269 | u16 boot_flags; /* [V3] IA-PC Boot Architecture Flags (see below for individual flags) */ | 269 | u16 boot_flags; /* IA-PC Boot Architecture Flags (see below for individual flags) */ |
| 270 | u8 reserved; /* [V1] Reserved, must be zero */ | 270 | u8 reserved; /* Reserved, must be zero */ |
| 271 | u32 flags; /* [V1] Miscellaneous flag bits (see below for individual flags) */ | 271 | u32 flags; /* Miscellaneous flag bits (see below for individual flags) */ |
| 272 | /* End of Version 1 FADT fields (ACPI 1.0) */ | 272 | struct acpi_generic_address reset_register; /* 64-bit address of the Reset register */ |
| 273 | 273 | u8 reset_value; /* Value to write to the reset_register port to reset the system */ | |
| 274 | struct acpi_generic_address reset_register; /* [V3] 64-bit address of the Reset register */ | 274 | u16 arm_boot_flags; /* ARM-Specific Boot Flags (see below for individual flags) (ACPI 5.1) */ |
| 275 | u8 reset_value; /* [V3] Value to write to the reset_register port to reset the system */ | 275 | u8 minor_revision; /* FADT Minor Revision (ACPI 5.1) */ |
| 276 | u16 arm_boot_flags; /* [V5] ARM-Specific Boot Flags (see below for individual flags) (ACPI 5.1) */ | 276 | u64 Xfacs; /* 64-bit physical address of FACS */ |
| 277 | u8 minor_revision; /* [V5] FADT Minor Revision (ACPI 5.1) */ | 277 | u64 Xdsdt; /* 64-bit physical address of DSDT */ |
| 278 | u64 Xfacs; /* [V3] 64-bit physical address of FACS */ | 278 | struct acpi_generic_address xpm1a_event_block; /* 64-bit Extended Power Mgt 1a Event Reg Blk address */ |
| 279 | u64 Xdsdt; /* [V3] 64-bit physical address of DSDT */ | 279 | struct acpi_generic_address xpm1b_event_block; /* 64-bit Extended Power Mgt 1b Event Reg Blk address */ |
| 280 | struct acpi_generic_address xpm1a_event_block; /* [V3] 64-bit Extended Power Mgt 1a Event Reg Blk address */ | 280 | struct acpi_generic_address xpm1a_control_block; /* 64-bit Extended Power Mgt 1a Control Reg Blk address */ |
| 281 | struct acpi_generic_address xpm1b_event_block; /* [V3] 64-bit Extended Power Mgt 1b Event Reg Blk address */ | 281 | struct acpi_generic_address xpm1b_control_block; /* 64-bit Extended Power Mgt 1b Control Reg Blk address */ |
| 282 | struct acpi_generic_address xpm1a_control_block; /* [V3] 64-bit Extended Power Mgt 1a Control Reg Blk address */ | 282 | struct acpi_generic_address xpm2_control_block; /* 64-bit Extended Power Mgt 2 Control Reg Blk address */ |
| 283 | struct acpi_generic_address xpm1b_control_block; /* [V3] 64-bit Extended Power Mgt 1b Control Reg Blk address */ | 283 | struct acpi_generic_address xpm_timer_block; /* 64-bit Extended Power Mgt Timer Ctrl Reg Blk address */ |
| 284 | struct acpi_generic_address xpm2_control_block; /* [V3] 64-bit Extended Power Mgt 2 Control Reg Blk address */ | 284 | struct acpi_generic_address xgpe0_block; /* 64-bit Extended General Purpose Event 0 Reg Blk address */ |
| 285 | struct acpi_generic_address xpm_timer_block; /* [V3] 64-bit Extended Power Mgt Timer Ctrl Reg Blk address */ | 285 | struct acpi_generic_address xgpe1_block; /* 64-bit Extended General Purpose Event 1 Reg Blk address */ |
| 286 | struct acpi_generic_address xgpe0_block; /* [V3] 64-bit Extended General Purpose Event 0 Reg Blk address */ | 286 | struct acpi_generic_address sleep_control; /* 64-bit Sleep Control register (ACPI 5.0) */ |
| 287 | struct acpi_generic_address xgpe1_block; /* [V3] 64-bit Extended General Purpose Event 1 Reg Blk address */ | 287 | struct acpi_generic_address sleep_status; /* 64-bit Sleep Status register (ACPI 5.0) */ |
| 288 | /* End of Version 3 FADT fields (ACPI 2.0) */ | 288 | u64 hypervisor_id; /* Hypervisor Vendor ID (ACPI 6.0) */ |
| 289 | |||
| 290 | struct acpi_generic_address sleep_control; /* [V4] 64-bit Sleep Control register (ACPI 5.0) */ | ||
| 291 | /* End of Version 4 FADT fields (ACPI 3.0 and ACPI 4.0) (Field was originally reserved in ACPI 3.0) */ | ||
| 292 | |||
| 293 | struct acpi_generic_address sleep_status; /* [V5] 64-bit Sleep Status register (ACPI 5.0) */ | ||
| 294 | /* End of Version 5 FADT fields (ACPI 5.0) */ | ||
| 295 | |||
| 296 | u64 hypervisor_id; /* [V6] Hypervisor Vendor ID (ACPI 6.0) */ | ||
| 297 | /* End of Version 6 FADT fields (ACPI 6.0) */ | ||
| 298 | |||
| 299 | }; | 289 | }; |
| 300 | 290 | ||
| 301 | /* Masks for FADT IA-PC Boot Architecture Flags (boot_flags) [Vx]=Introduced in this FADT revision */ | 291 | /* Masks for FADT IA-PC Boot Architecture Flags (boot_flags) [Vx]=Introduced in this FADT revision */ |
| @@ -311,8 +301,8 @@ struct acpi_table_fadt { | |||
| 311 | 301 | ||
| 312 | /* Masks for FADT ARM Boot Architecture Flags (arm_boot_flags) ACPI 5.1 */ | 302 | /* Masks for FADT ARM Boot Architecture Flags (arm_boot_flags) ACPI 5.1 */ |
| 313 | 303 | ||
| 314 | #define ACPI_FADT_PSCI_COMPLIANT (1) /* 00: [V5] PSCI 0.2+ is implemented */ | 304 | #define ACPI_FADT_PSCI_COMPLIANT (1) /* 00: [V5+] PSCI 0.2+ is implemented */ |
| 315 | #define ACPI_FADT_PSCI_USE_HVC (1<<1) /* 01: [V5] HVC must be used instead of SMC as the PSCI conduit */ | 305 | #define ACPI_FADT_PSCI_USE_HVC (1<<1) /* 01: [V5+] HVC must be used instead of SMC as the PSCI conduit */ |
| 316 | 306 | ||
| 317 | /* Masks for FADT flags */ | 307 | /* Masks for FADT flags */ |
| 318 | 308 | ||
| @@ -409,34 +399,20 @@ struct acpi_table_desc { | |||
| 409 | * match the expected length. In other words, the length of the | 399 | * match the expected length. In other words, the length of the |
| 410 | * FADT is the bottom line as to what the version really is. | 400 | * FADT is the bottom line as to what the version really is. |
| 411 | * | 401 | * |
| 412 | * NOTE: There is no officialy released V2 of the FADT. This | 402 | * For reference, the values below are as follows: |
| 413 | * version was used only for prototyping and testing during the | 403 | * FADT V1 size: 0x074 |
| 414 | * 32-bit to 64-bit transition. V3 was the first official 64-bit | 404 | * FADT V2 size: 0x084 |
| 415 | * version of the FADT. | 405 | * FADT V3 size: 0x0F4 |
| 416 | * | 406 | * FADT V4 size: 0x0F4 |
| 417 | * Update this list of defines when a new version of the FADT is | 407 | * FADT V5 size: 0x10C |
| 418 | * added to the ACPI specification. Note that the FADT version is | 408 | * FADT V6 size: 0x114 |
| 419 | * only incremented when new fields are appended to the existing | ||
| 420 | * version. Therefore, the FADT version is competely independent | ||
| 421 | * from the version of the ACPI specification where it is | ||
| 422 | * defined. | ||
| 423 | * | ||
| 424 | * For reference, the various FADT lengths are as follows: | ||
| 425 | * FADT V1 size: 0x074 ACPI 1.0 | ||
| 426 | * FADT V3 size: 0x0F4 ACPI 2.0 | ||
| 427 | * FADT V4 size: 0x100 ACPI 3.0 and ACPI 4.0 | ||
| 428 | * FADT V5 size: 0x10C ACPI 5.0 | ||
| 429 | * FADT V6 size: 0x114 ACPI 6.0 | ||
| 430 | */ | 409 | */ |
| 431 | #define ACPI_FADT_V1_SIZE (u32) (ACPI_FADT_OFFSET (flags) + 4) /* ACPI 1.0 */ | 410 | #define ACPI_FADT_V1_SIZE (u32) (ACPI_FADT_OFFSET (flags) + 4) |
| 432 | #define ACPI_FADT_V3_SIZE (u32) (ACPI_FADT_OFFSET (sleep_control)) /* ACPI 2.0 */ | 411 | #define ACPI_FADT_V2_SIZE (u32) (ACPI_FADT_OFFSET (minor_revision) + 1) |
| 433 | #define ACPI_FADT_V4_SIZE (u32) (ACPI_FADT_OFFSET (sleep_status)) /* ACPI 3.0 and ACPI 4.0 */ | 412 | #define ACPI_FADT_V3_SIZE (u32) (ACPI_FADT_OFFSET (sleep_control)) |
| 434 | #define ACPI_FADT_V5_SIZE (u32) (ACPI_FADT_OFFSET (hypervisor_id)) /* ACPI 5.0 */ | 413 | #define ACPI_FADT_V5_SIZE (u32) (ACPI_FADT_OFFSET (hypervisor_id)) |
| 435 | #define ACPI_FADT_V6_SIZE (u32) (sizeof (struct acpi_table_fadt)) /* ACPI 6.0 */ | 414 | #define ACPI_FADT_V6_SIZE (u32) (sizeof (struct acpi_table_fadt)) |
| 436 | |||
| 437 | /* Update these when new FADT versions are added */ | ||
| 438 | 415 | ||
| 439 | #define ACPI_FADT_MAX_VERSION 6 | ||
| 440 | #define ACPI_FADT_CONFORMANCE "ACPI 6.1 (FADT version 6)" | 416 | #define ACPI_FADT_CONFORMANCE "ACPI 6.1 (FADT version 6)" |
| 441 | 417 | ||
| 442 | #endif /* __ACTBL_H__ */ | 418 | #endif /* __ACTBL_H__ */ |
diff --git a/include/acpi/platform/aclinux.h b/include/acpi/platform/aclinux.h index a5d98d171866..e861a24f06f2 100644 --- a/include/acpi/platform/aclinux.h +++ b/include/acpi/platform/aclinux.h | |||
| @@ -191,6 +191,9 @@ | |||
| 191 | #ifndef __init | 191 | #ifndef __init |
| 192 | #define __init | 192 | #define __init |
| 193 | #endif | 193 | #endif |
| 194 | #ifndef __iomem | ||
| 195 | #define __iomem | ||
| 196 | #endif | ||
| 194 | 197 | ||
| 195 | /* Host-dependent types and defines for user-space ACPICA */ | 198 | /* Host-dependent types and defines for user-space ACPICA */ |
| 196 | 199 | ||
diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index 9b9f65d99873..e35e6de633b9 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h | |||
| @@ -22,7 +22,7 @@ extern int mincore_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd, | |||
| 22 | unsigned char *vec); | 22 | unsigned char *vec); |
| 23 | extern bool move_huge_pmd(struct vm_area_struct *vma, unsigned long old_addr, | 23 | extern bool move_huge_pmd(struct vm_area_struct *vma, unsigned long old_addr, |
| 24 | unsigned long new_addr, unsigned long old_end, | 24 | unsigned long new_addr, unsigned long old_end, |
| 25 | pmd_t *old_pmd, pmd_t *new_pmd); | 25 | pmd_t *old_pmd, pmd_t *new_pmd, bool *need_flush); |
| 26 | extern int change_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd, | 26 | extern int change_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd, |
| 27 | unsigned long addr, pgprot_t newprot, | 27 | unsigned long addr, pgprot_t newprot, |
| 28 | int prot_numa); | 28 | int prot_numa); |
diff --git a/include/linux/ipv6.h b/include/linux/ipv6.h index ca1ad9ebbc92..a0649973ee5b 100644 --- a/include/linux/ipv6.h +++ b/include/linux/ipv6.h | |||
| @@ -149,7 +149,7 @@ static inline bool inet6_exact_dif_match(struct net *net, struct sk_buff *skb) | |||
| 149 | { | 149 | { |
| 150 | #if defined(CONFIG_NET_L3_MASTER_DEV) | 150 | #if defined(CONFIG_NET_L3_MASTER_DEV) |
| 151 | if (!net->ipv4.sysctl_tcp_l3mdev_accept && | 151 | if (!net->ipv4.sysctl_tcp_l3mdev_accept && |
| 152 | ipv6_l3mdev_skb(IP6CB(skb)->flags)) | 152 | skb && ipv6_l3mdev_skb(IP6CB(skb)->flags)) |
| 153 | return true; | 153 | return true; |
| 154 | #endif | 154 | #endif |
| 155 | return false; | 155 | return false; |
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 91ee3643ccc8..bf04a46f6d5b 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h | |||
| @@ -3354,6 +3354,21 @@ int dev_forward_skb(struct net_device *dev, struct sk_buff *skb); | |||
| 3354 | bool is_skb_forwardable(const struct net_device *dev, | 3354 | bool is_skb_forwardable(const struct net_device *dev, |
| 3355 | const struct sk_buff *skb); | 3355 | const struct sk_buff *skb); |
| 3356 | 3356 | ||
| 3357 | static __always_inline int ____dev_forward_skb(struct net_device *dev, | ||
| 3358 | struct sk_buff *skb) | ||
| 3359 | { | ||
| 3360 | if (skb_orphan_frags(skb, GFP_ATOMIC) || | ||
| 3361 | unlikely(!is_skb_forwardable(dev, skb))) { | ||
| 3362 | atomic_long_inc(&dev->rx_dropped); | ||
| 3363 | kfree_skb(skb); | ||
| 3364 | return NET_RX_DROP; | ||
| 3365 | } | ||
| 3366 | |||
| 3367 | skb_scrub_packet(skb, true); | ||
| 3368 | skb->priority = 0; | ||
| 3369 | return 0; | ||
| 3370 | } | ||
| 3371 | |||
| 3357 | void dev_queue_xmit_nit(struct sk_buff *skb, struct net_device *dev); | 3372 | void dev_queue_xmit_nit(struct sk_buff *skb, struct net_device *dev); |
| 3358 | 3373 | ||
| 3359 | extern int netdev_budget; | 3374 | extern int netdev_budget; |
diff --git a/include/linux/sunrpc/svc_xprt.h b/include/linux/sunrpc/svc_xprt.h index ab02a457da1f..e5d193440374 100644 --- a/include/linux/sunrpc/svc_xprt.h +++ b/include/linux/sunrpc/svc_xprt.h | |||
| @@ -25,6 +25,7 @@ struct svc_xprt_ops { | |||
| 25 | void (*xpo_detach)(struct svc_xprt *); | 25 | void (*xpo_detach)(struct svc_xprt *); |
| 26 | void (*xpo_free)(struct svc_xprt *); | 26 | void (*xpo_free)(struct svc_xprt *); |
| 27 | int (*xpo_secure_port)(struct svc_rqst *); | 27 | int (*xpo_secure_port)(struct svc_rqst *); |
| 28 | void (*xpo_kill_temp_xprt)(struct svc_xprt *); | ||
| 28 | }; | 29 | }; |
| 29 | 30 | ||
| 30 | struct svc_xprt_class { | 31 | struct svc_xprt_class { |
diff --git a/include/net/ip.h b/include/net/ip.h index 5413883ac47f..d3a107850a41 100644 --- a/include/net/ip.h +++ b/include/net/ip.h | |||
| @@ -47,8 +47,7 @@ struct inet_skb_parm { | |||
| 47 | #define IPSKB_REROUTED BIT(4) | 47 | #define IPSKB_REROUTED BIT(4) |
| 48 | #define IPSKB_DOREDIRECT BIT(5) | 48 | #define IPSKB_DOREDIRECT BIT(5) |
| 49 | #define IPSKB_FRAG_PMTU BIT(6) | 49 | #define IPSKB_FRAG_PMTU BIT(6) |
| 50 | #define IPSKB_FRAG_SEGS BIT(7) | 50 | #define IPSKB_L3SLAVE BIT(7) |
| 51 | #define IPSKB_L3SLAVE BIT(8) | ||
| 52 | 51 | ||
| 53 | u16 frag_max_size; | 52 | u16 frag_max_size; |
| 54 | }; | 53 | }; |
diff --git a/include/net/ip6_tunnel.h b/include/net/ip6_tunnel.h index 20ed9699fcd4..1b1cf33cbfb0 100644 --- a/include/net/ip6_tunnel.h +++ b/include/net/ip6_tunnel.h | |||
| @@ -146,6 +146,7 @@ static inline void ip6tunnel_xmit(struct sock *sk, struct sk_buff *skb, | |||
| 146 | { | 146 | { |
| 147 | int pkt_len, err; | 147 | int pkt_len, err; |
| 148 | 148 | ||
| 149 | memset(skb->cb, 0, sizeof(struct inet6_skb_parm)); | ||
| 149 | pkt_len = skb->len - skb_inner_network_offset(skb); | 150 | pkt_len = skb->len - skb_inner_network_offset(skb); |
| 150 | err = ip6_local_out(dev_net(skb_dst(skb)->dev), sk, skb); | 151 | err = ip6_local_out(dev_net(skb_dst(skb)->dev), sk, skb); |
| 151 | if (unlikely(net_xmit_eval(err))) | 152 | if (unlikely(net_xmit_eval(err))) |
diff --git a/include/net/netfilter/nf_conntrack_labels.h b/include/net/netfilter/nf_conntrack_labels.h index 498814626e28..1723a67c0b0a 100644 --- a/include/net/netfilter/nf_conntrack_labels.h +++ b/include/net/netfilter/nf_conntrack_labels.h | |||
| @@ -30,8 +30,7 @@ static inline struct nf_conn_labels *nf_ct_labels_ext_add(struct nf_conn *ct) | |||
| 30 | if (net->ct.labels_used == 0) | 30 | if (net->ct.labels_used == 0) |
| 31 | return NULL; | 31 | return NULL; |
| 32 | 32 | ||
| 33 | return nf_ct_ext_add_length(ct, NF_CT_EXT_LABELS, | 33 | return nf_ct_ext_add(ct, NF_CT_EXT_LABELS, GFP_ATOMIC); |
| 34 | sizeof(struct nf_conn_labels), GFP_ATOMIC); | ||
| 35 | #else | 34 | #else |
| 36 | return NULL; | 35 | return NULL; |
| 37 | #endif | 36 | #endif |
diff --git a/include/net/netfilter/nf_tables.h b/include/net/netfilter/nf_tables.h index 5031e072567b..d79d1e9b9546 100644 --- a/include/net/netfilter/nf_tables.h +++ b/include/net/netfilter/nf_tables.h | |||
| @@ -145,7 +145,7 @@ static inline enum nft_registers nft_type_to_reg(enum nft_data_types type) | |||
| 145 | return type == NFT_DATA_VERDICT ? NFT_REG_VERDICT : NFT_REG_1 * NFT_REG_SIZE / NFT_REG32_SIZE; | 145 | return type == NFT_DATA_VERDICT ? NFT_REG_VERDICT : NFT_REG_1 * NFT_REG_SIZE / NFT_REG32_SIZE; |
| 146 | } | 146 | } |
| 147 | 147 | ||
| 148 | unsigned int nft_parse_u32_check(const struct nlattr *attr, int max, u32 *dest); | 148 | int nft_parse_u32_check(const struct nlattr *attr, int max, u32 *dest); |
| 149 | unsigned int nft_parse_register(const struct nlattr *attr); | 149 | unsigned int nft_parse_register(const struct nlattr *attr); |
| 150 | int nft_dump_register(struct sk_buff *skb, unsigned int attr, unsigned int reg); | 150 | int nft_dump_register(struct sk_buff *skb, unsigned int attr, unsigned int reg); |
| 151 | 151 | ||
| @@ -542,7 +542,8 @@ void *nft_set_elem_init(const struct nft_set *set, | |||
| 542 | const struct nft_set_ext_tmpl *tmpl, | 542 | const struct nft_set_ext_tmpl *tmpl, |
| 543 | const u32 *key, const u32 *data, | 543 | const u32 *key, const u32 *data, |
| 544 | u64 timeout, gfp_t gfp); | 544 | u64 timeout, gfp_t gfp); |
| 545 | void nft_set_elem_destroy(const struct nft_set *set, void *elem); | 545 | void nft_set_elem_destroy(const struct nft_set *set, void *elem, |
| 546 | bool destroy_expr); | ||
| 546 | 547 | ||
| 547 | /** | 548 | /** |
| 548 | * struct nft_set_gc_batch_head - nf_tables set garbage collection batch | 549 | * struct nft_set_gc_batch_head - nf_tables set garbage collection batch |
| @@ -693,7 +694,6 @@ static inline int nft_expr_clone(struct nft_expr *dst, struct nft_expr *src) | |||
| 693 | { | 694 | { |
| 694 | int err; | 695 | int err; |
| 695 | 696 | ||
| 696 | __module_get(src->ops->type->owner); | ||
| 697 | if (src->ops->clone) { | 697 | if (src->ops->clone) { |
| 698 | dst->ops = src->ops; | 698 | dst->ops = src->ops; |
| 699 | err = src->ops->clone(dst, src); | 699 | err = src->ops->clone(dst, src); |
| @@ -702,6 +702,8 @@ static inline int nft_expr_clone(struct nft_expr *dst, struct nft_expr *src) | |||
| 702 | } else { | 702 | } else { |
| 703 | memcpy(dst, src, src->ops->size); | 703 | memcpy(dst, src, src->ops->size); |
| 704 | } | 704 | } |
| 705 | |||
| 706 | __module_get(src->ops->type->owner); | ||
| 705 | return 0; | 707 | return 0; |
| 706 | } | 708 | } |
| 707 | 709 | ||
diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h index 87a7f42e7639..31acc3f4f132 100644 --- a/include/net/sctp/sctp.h +++ b/include/net/sctp/sctp.h | |||
| @@ -152,7 +152,7 @@ void sctp_unhash_endpoint(struct sctp_endpoint *); | |||
| 152 | struct sock *sctp_err_lookup(struct net *net, int family, struct sk_buff *, | 152 | struct sock *sctp_err_lookup(struct net *net, int family, struct sk_buff *, |
| 153 | struct sctphdr *, struct sctp_association **, | 153 | struct sctphdr *, struct sctp_association **, |
| 154 | struct sctp_transport **); | 154 | struct sctp_transport **); |
| 155 | void sctp_err_finish(struct sock *, struct sctp_association *); | 155 | void sctp_err_finish(struct sock *, struct sctp_transport *); |
| 156 | void sctp_icmp_frag_needed(struct sock *, struct sctp_association *, | 156 | void sctp_icmp_frag_needed(struct sock *, struct sctp_association *, |
| 157 | struct sctp_transport *t, __u32 pmtu); | 157 | struct sctp_transport *t, __u32 pmtu); |
| 158 | void sctp_icmp_redirect(struct sock *, struct sctp_transport *, | 158 | void sctp_icmp_redirect(struct sock *, struct sctp_transport *, |
diff --git a/include/net/sock.h b/include/net/sock.h index 73c6b008f1b7..92b269709b9a 100644 --- a/include/net/sock.h +++ b/include/net/sock.h | |||
| @@ -1596,11 +1596,11 @@ static inline void sock_put(struct sock *sk) | |||
| 1596 | void sock_gen_put(struct sock *sk); | 1596 | void sock_gen_put(struct sock *sk); |
| 1597 | 1597 | ||
| 1598 | int __sk_receive_skb(struct sock *sk, struct sk_buff *skb, const int nested, | 1598 | int __sk_receive_skb(struct sock *sk, struct sk_buff *skb, const int nested, |
| 1599 | unsigned int trim_cap); | 1599 | unsigned int trim_cap, bool refcounted); |
| 1600 | static inline int sk_receive_skb(struct sock *sk, struct sk_buff *skb, | 1600 | static inline int sk_receive_skb(struct sock *sk, struct sk_buff *skb, |
| 1601 | const int nested) | 1601 | const int nested) |
| 1602 | { | 1602 | { |
| 1603 | return __sk_receive_skb(sk, skb, nested, 1); | 1603 | return __sk_receive_skb(sk, skb, nested, 1, true); |
| 1604 | } | 1604 | } |
| 1605 | 1605 | ||
| 1606 | static inline void sk_tx_queue_set(struct sock *sk, int tx_queue) | 1606 | static inline void sk_tx_queue_set(struct sock *sk, int tx_queue) |
diff --git a/include/net/tcp.h b/include/net/tcp.h index 5b82d4d94834..123979fe12bf 100644 --- a/include/net/tcp.h +++ b/include/net/tcp.h | |||
| @@ -805,7 +805,7 @@ static inline bool inet_exact_dif_match(struct net *net, struct sk_buff *skb) | |||
| 805 | { | 805 | { |
| 806 | #if IS_ENABLED(CONFIG_NET_L3_MASTER_DEV) | 806 | #if IS_ENABLED(CONFIG_NET_L3_MASTER_DEV) |
| 807 | if (!net->ipv4.sysctl_tcp_l3mdev_accept && | 807 | if (!net->ipv4.sysctl_tcp_l3mdev_accept && |
| 808 | ipv4_l3mdev_skb(TCP_SKB_CB(skb)->header.h4.flags)) | 808 | skb && ipv4_l3mdev_skb(TCP_SKB_CB(skb)->header.h4.flags)) |
| 809 | return true; | 809 | return true; |
| 810 | #endif | 810 | #endif |
| 811 | return false; | 811 | return false; |
| @@ -1220,6 +1220,7 @@ static inline void tcp_prequeue_init(struct tcp_sock *tp) | |||
| 1220 | 1220 | ||
| 1221 | bool tcp_prequeue(struct sock *sk, struct sk_buff *skb); | 1221 | bool tcp_prequeue(struct sock *sk, struct sk_buff *skb); |
| 1222 | bool tcp_add_backlog(struct sock *sk, struct sk_buff *skb); | 1222 | bool tcp_add_backlog(struct sock *sk, struct sk_buff *skb); |
| 1223 | int tcp_filter(struct sock *sk, struct sk_buff *skb); | ||
| 1223 | 1224 | ||
| 1224 | #undef STATE_TRACE | 1225 | #undef STATE_TRACE |
| 1225 | 1226 | ||
diff --git a/include/uapi/linux/atm_zatm.h b/include/uapi/linux/atm_zatm.h index 5cd4d4d2dd1d..9c9c6ad55f14 100644 --- a/include/uapi/linux/atm_zatm.h +++ b/include/uapi/linux/atm_zatm.h | |||
| @@ -14,7 +14,6 @@ | |||
| 14 | 14 | ||
| 15 | #include <linux/atmapi.h> | 15 | #include <linux/atmapi.h> |
| 16 | #include <linux/atmioc.h> | 16 | #include <linux/atmioc.h> |
| 17 | #include <linux/time.h> | ||
| 18 | 17 | ||
| 19 | #define ZATM_GETPOOL _IOW('a',ATMIOC_SARPRV+1,struct atmif_sioc) | 18 | #define ZATM_GETPOOL _IOW('a',ATMIOC_SARPRV+1,struct atmif_sioc) |
| 20 | /* get pool statistics */ | 19 | /* get pool statistics */ |
diff --git a/include/uapi/linux/bpqether.h b/include/uapi/linux/bpqether.h index a6c35e1a89ad..05865edaefda 100644 --- a/include/uapi/linux/bpqether.h +++ b/include/uapi/linux/bpqether.h | |||
| @@ -5,9 +5,7 @@ | |||
| 5 | * Defines for the BPQETHER pseudo device driver | 5 | * Defines for the BPQETHER pseudo device driver |
| 6 | */ | 6 | */ |
| 7 | 7 | ||
| 8 | #ifndef __LINUX_IF_ETHER_H | ||
| 9 | #include <linux/if_ether.h> | 8 | #include <linux/if_ether.h> |
| 10 | #endif | ||
| 11 | 9 | ||
| 12 | #define SIOCSBPQETHOPT (SIOCDEVPRIVATE+0) /* reserved */ | 10 | #define SIOCSBPQETHOPT (SIOCDEVPRIVATE+0) /* reserved */ |
| 13 | #define SIOCSBPQETHADDR (SIOCDEVPRIVATE+1) | 11 | #define SIOCSBPQETHADDR (SIOCDEVPRIVATE+1) |
diff --git a/kernel/bpf/hashtab.c b/kernel/bpf/hashtab.c index 570eeca7bdfa..ad1bc67aff1b 100644 --- a/kernel/bpf/hashtab.c +++ b/kernel/bpf/hashtab.c | |||
| @@ -687,7 +687,8 @@ static void delete_all_elements(struct bpf_htab *htab) | |||
| 687 | 687 | ||
| 688 | hlist_for_each_entry_safe(l, n, head, hash_node) { | 688 | hlist_for_each_entry_safe(l, n, head, hash_node) { |
| 689 | hlist_del_rcu(&l->hash_node); | 689 | hlist_del_rcu(&l->hash_node); |
| 690 | htab_elem_free(htab, l); | 690 | if (l->state != HTAB_EXTRA_ELEM_USED) |
| 691 | htab_elem_free(htab, l); | ||
| 691 | } | 692 | } |
| 692 | } | 693 | } |
| 693 | } | 694 | } |
diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c index 228f962447a5..237f3d6a7ddc 100644 --- a/kernel/bpf/syscall.c +++ b/kernel/bpf/syscall.c | |||
| @@ -194,7 +194,7 @@ static int map_create(union bpf_attr *attr) | |||
| 194 | 194 | ||
| 195 | err = bpf_map_charge_memlock(map); | 195 | err = bpf_map_charge_memlock(map); |
| 196 | if (err) | 196 | if (err) |
| 197 | goto free_map; | 197 | goto free_map_nouncharge; |
| 198 | 198 | ||
| 199 | err = bpf_map_new_fd(map); | 199 | err = bpf_map_new_fd(map); |
| 200 | if (err < 0) | 200 | if (err < 0) |
| @@ -204,6 +204,8 @@ static int map_create(union bpf_attr *attr) | |||
| 204 | return err; | 204 | return err; |
| 205 | 205 | ||
| 206 | free_map: | 206 | free_map: |
| 207 | bpf_map_uncharge_memlock(map); | ||
| 208 | free_map_nouncharge: | ||
| 207 | map->ops->map_free(map); | 209 | map->ops->map_free(map); |
| 208 | return err; | 210 | return err; |
| 209 | } | 211 | } |
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 9c4d30483264..6b669593e7eb 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c | |||
| @@ -1341,12 +1341,12 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) | |||
| 1341 | 1341 | ||
| 1342 | } else if (new->flags & IRQF_TRIGGER_MASK) { | 1342 | } else if (new->flags & IRQF_TRIGGER_MASK) { |
| 1343 | unsigned int nmsk = new->flags & IRQF_TRIGGER_MASK; | 1343 | unsigned int nmsk = new->flags & IRQF_TRIGGER_MASK; |
| 1344 | unsigned int omsk = irq_settings_get_trigger_mask(desc); | 1344 | unsigned int omsk = irqd_get_trigger_type(&desc->irq_data); |
| 1345 | 1345 | ||
| 1346 | if (nmsk != omsk) | 1346 | if (nmsk != omsk) |
| 1347 | /* hope the handler works with current trigger mode */ | 1347 | /* hope the handler works with current trigger mode */ |
| 1348 | pr_warn("irq %d uses trigger mode %u; requested %u\n", | 1348 | pr_warn("irq %d uses trigger mode %u; requested %u\n", |
| 1349 | irq, nmsk, omsk); | 1349 | irq, omsk, nmsk); |
| 1350 | } | 1350 | } |
| 1351 | 1351 | ||
| 1352 | *old_ptr = new; | 1352 | *old_ptr = new; |
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 5028f4fd504a..f7a55e9ff2f7 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c | |||
| @@ -783,8 +783,6 @@ static ssize_t devkmsg_write(struct kiocb *iocb, struct iov_iter *from) | |||
| 783 | return ret; | 783 | return ret; |
| 784 | } | 784 | } |
| 785 | 785 | ||
| 786 | static void cont_flush(void); | ||
| 787 | |||
| 788 | static ssize_t devkmsg_read(struct file *file, char __user *buf, | 786 | static ssize_t devkmsg_read(struct file *file, char __user *buf, |
| 789 | size_t count, loff_t *ppos) | 787 | size_t count, loff_t *ppos) |
| 790 | { | 788 | { |
| @@ -800,7 +798,6 @@ static ssize_t devkmsg_read(struct file *file, char __user *buf, | |||
| 800 | if (ret) | 798 | if (ret) |
| 801 | return ret; | 799 | return ret; |
| 802 | raw_spin_lock_irq(&logbuf_lock); | 800 | raw_spin_lock_irq(&logbuf_lock); |
| 803 | cont_flush(); | ||
| 804 | while (user->seq == log_next_seq) { | 801 | while (user->seq == log_next_seq) { |
| 805 | if (file->f_flags & O_NONBLOCK) { | 802 | if (file->f_flags & O_NONBLOCK) { |
| 806 | ret = -EAGAIN; | 803 | ret = -EAGAIN; |
| @@ -863,7 +860,6 @@ static loff_t devkmsg_llseek(struct file *file, loff_t offset, int whence) | |||
| 863 | return -ESPIPE; | 860 | return -ESPIPE; |
| 864 | 861 | ||
| 865 | raw_spin_lock_irq(&logbuf_lock); | 862 | raw_spin_lock_irq(&logbuf_lock); |
| 866 | cont_flush(); | ||
| 867 | switch (whence) { | 863 | switch (whence) { |
| 868 | case SEEK_SET: | 864 | case SEEK_SET: |
| 869 | /* the first record */ | 865 | /* the first record */ |
| @@ -902,7 +898,6 @@ static unsigned int devkmsg_poll(struct file *file, poll_table *wait) | |||
| 902 | poll_wait(file, &log_wait, wait); | 898 | poll_wait(file, &log_wait, wait); |
| 903 | 899 | ||
| 904 | raw_spin_lock_irq(&logbuf_lock); | 900 | raw_spin_lock_irq(&logbuf_lock); |
| 905 | cont_flush(); | ||
| 906 | if (user->seq < log_next_seq) { | 901 | if (user->seq < log_next_seq) { |
| 907 | /* return error when data has vanished underneath us */ | 902 | /* return error when data has vanished underneath us */ |
| 908 | if (user->seq < log_first_seq) | 903 | if (user->seq < log_first_seq) |
| @@ -1289,7 +1284,6 @@ static int syslog_print(char __user *buf, int size) | |||
| 1289 | size_t skip; | 1284 | size_t skip; |
| 1290 | 1285 | ||
| 1291 | raw_spin_lock_irq(&logbuf_lock); | 1286 | raw_spin_lock_irq(&logbuf_lock); |
| 1292 | cont_flush(); | ||
| 1293 | if (syslog_seq < log_first_seq) { | 1287 | if (syslog_seq < log_first_seq) { |
| 1294 | /* messages are gone, move to first one */ | 1288 | /* messages are gone, move to first one */ |
| 1295 | syslog_seq = log_first_seq; | 1289 | syslog_seq = log_first_seq; |
| @@ -1349,7 +1343,6 @@ static int syslog_print_all(char __user *buf, int size, bool clear) | |||
| 1349 | return -ENOMEM; | 1343 | return -ENOMEM; |
| 1350 | 1344 | ||
| 1351 | raw_spin_lock_irq(&logbuf_lock); | 1345 | raw_spin_lock_irq(&logbuf_lock); |
| 1352 | cont_flush(); | ||
| 1353 | if (buf) { | 1346 | if (buf) { |
| 1354 | u64 next_seq; | 1347 | u64 next_seq; |
| 1355 | u64 seq; | 1348 | u64 seq; |
| @@ -1511,7 +1504,6 @@ int do_syslog(int type, char __user *buf, int len, int source) | |||
| 1511 | /* Number of chars in the log buffer */ | 1504 | /* Number of chars in the log buffer */ |
| 1512 | case SYSLOG_ACTION_SIZE_UNREAD: | 1505 | case SYSLOG_ACTION_SIZE_UNREAD: |
| 1513 | raw_spin_lock_irq(&logbuf_lock); | 1506 | raw_spin_lock_irq(&logbuf_lock); |
| 1514 | cont_flush(); | ||
| 1515 | if (syslog_seq < log_first_seq) { | 1507 | if (syslog_seq < log_first_seq) { |
| 1516 | /* messages are gone, move to first one */ | 1508 | /* messages are gone, move to first one */ |
| 1517 | syslog_seq = log_first_seq; | 1509 | syslog_seq = log_first_seq; |
| @@ -3028,7 +3020,6 @@ void kmsg_dump(enum kmsg_dump_reason reason) | |||
| 3028 | dumper->active = true; | 3020 | dumper->active = true; |
| 3029 | 3021 | ||
| 3030 | raw_spin_lock_irqsave(&logbuf_lock, flags); | 3022 | raw_spin_lock_irqsave(&logbuf_lock, flags); |
| 3031 | cont_flush(); | ||
| 3032 | dumper->cur_seq = clear_seq; | 3023 | dumper->cur_seq = clear_seq; |
| 3033 | dumper->cur_idx = clear_idx; | 3024 | dumper->cur_idx = clear_idx; |
| 3034 | dumper->next_seq = log_next_seq; | 3025 | dumper->next_seq = log_next_seq; |
| @@ -3119,7 +3110,6 @@ bool kmsg_dump_get_line(struct kmsg_dumper *dumper, bool syslog, | |||
| 3119 | bool ret; | 3110 | bool ret; |
| 3120 | 3111 | ||
| 3121 | raw_spin_lock_irqsave(&logbuf_lock, flags); | 3112 | raw_spin_lock_irqsave(&logbuf_lock, flags); |
| 3122 | cont_flush(); | ||
| 3123 | ret = kmsg_dump_get_line_nolock(dumper, syslog, line, size, len); | 3113 | ret = kmsg_dump_get_line_nolock(dumper, syslog, line, size, len); |
| 3124 | raw_spin_unlock_irqrestore(&logbuf_lock, flags); | 3114 | raw_spin_unlock_irqrestore(&logbuf_lock, flags); |
| 3125 | 3115 | ||
| @@ -3162,7 +3152,6 @@ bool kmsg_dump_get_buffer(struct kmsg_dumper *dumper, bool syslog, | |||
| 3162 | goto out; | 3152 | goto out; |
| 3163 | 3153 | ||
| 3164 | raw_spin_lock_irqsave(&logbuf_lock, flags); | 3154 | raw_spin_lock_irqsave(&logbuf_lock, flags); |
| 3165 | cont_flush(); | ||
| 3166 | if (dumper->cur_seq < log_first_seq) { | 3155 | if (dumper->cur_seq < log_first_seq) { |
| 3167 | /* messages are gone, move to first available one */ | 3156 | /* messages are gone, move to first available one */ |
| 3168 | dumper->cur_seq = log_first_seq; | 3157 | dumper->cur_seq = log_first_seq; |
diff --git a/kernel/taskstats.c b/kernel/taskstats.c index b3f05ee20d18..cbb387a265db 100644 --- a/kernel/taskstats.c +++ b/kernel/taskstats.c | |||
| @@ -54,7 +54,11 @@ static const struct nla_policy taskstats_cmd_get_policy[TASKSTATS_CMD_ATTR_MAX+1 | |||
| 54 | [TASKSTATS_CMD_ATTR_REGISTER_CPUMASK] = { .type = NLA_STRING }, | 54 | [TASKSTATS_CMD_ATTR_REGISTER_CPUMASK] = { .type = NLA_STRING }, |
| 55 | [TASKSTATS_CMD_ATTR_DEREGISTER_CPUMASK] = { .type = NLA_STRING },}; | 55 | [TASKSTATS_CMD_ATTR_DEREGISTER_CPUMASK] = { .type = NLA_STRING },}; |
| 56 | 56 | ||
| 57 | static const struct nla_policy cgroupstats_cmd_get_policy[CGROUPSTATS_CMD_ATTR_MAX+1] = { | 57 | /* |
| 58 | * We have to use TASKSTATS_CMD_ATTR_MAX here, it is the maxattr in the family. | ||
| 59 | * Make sure they are always aligned. | ||
| 60 | */ | ||
| 61 | static const struct nla_policy cgroupstats_cmd_get_policy[TASKSTATS_CMD_ATTR_MAX+1] = { | ||
| 58 | [CGROUPSTATS_CMD_ATTR_FD] = { .type = NLA_U32 }, | 62 | [CGROUPSTATS_CMD_ATTR_FD] = { .type = NLA_U32 }, |
| 59 | }; | 63 | }; |
| 60 | 64 | ||
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 2050a7652a86..da87b3cba5b3 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c | |||
| @@ -1862,6 +1862,10 @@ static int __ftrace_hash_update_ipmodify(struct ftrace_ops *ops, | |||
| 1862 | 1862 | ||
| 1863 | /* Update rec->flags */ | 1863 | /* Update rec->flags */ |
| 1864 | do_for_each_ftrace_rec(pg, rec) { | 1864 | do_for_each_ftrace_rec(pg, rec) { |
| 1865 | |||
| 1866 | if (rec->flags & FTRACE_FL_DISABLED) | ||
| 1867 | continue; | ||
| 1868 | |||
| 1865 | /* We need to update only differences of filter_hash */ | 1869 | /* We need to update only differences of filter_hash */ |
| 1866 | in_old = !!ftrace_lookup_ip(old_hash, rec->ip); | 1870 | in_old = !!ftrace_lookup_ip(old_hash, rec->ip); |
| 1867 | in_new = !!ftrace_lookup_ip(new_hash, rec->ip); | 1871 | in_new = !!ftrace_lookup_ip(new_hash, rec->ip); |
| @@ -1884,6 +1888,10 @@ rollback: | |||
| 1884 | 1888 | ||
| 1885 | /* Roll back what we did above */ | 1889 | /* Roll back what we did above */ |
| 1886 | do_for_each_ftrace_rec(pg, rec) { | 1890 | do_for_each_ftrace_rec(pg, rec) { |
| 1891 | |||
| 1892 | if (rec->flags & FTRACE_FL_DISABLED) | ||
| 1893 | continue; | ||
| 1894 | |||
| 1887 | if (rec == end) | 1895 | if (rec == end) |
| 1888 | goto err_out; | 1896 | goto err_out; |
| 1889 | 1897 | ||
| @@ -2397,6 +2405,10 @@ void __weak ftrace_replace_code(int enable) | |||
| 2397 | return; | 2405 | return; |
| 2398 | 2406 | ||
| 2399 | do_for_each_ftrace_rec(pg, rec) { | 2407 | do_for_each_ftrace_rec(pg, rec) { |
| 2408 | |||
| 2409 | if (rec->flags & FTRACE_FL_DISABLED) | ||
| 2410 | continue; | ||
| 2411 | |||
| 2400 | failed = __ftrace_replace_code(rec, enable); | 2412 | failed = __ftrace_replace_code(rec, enable); |
| 2401 | if (failed) { | 2413 | if (failed) { |
| 2402 | ftrace_bug(failed, rec); | 2414 | ftrace_bug(failed, rec); |
| @@ -2763,7 +2775,7 @@ static int ftrace_shutdown(struct ftrace_ops *ops, int command) | |||
| 2763 | struct dyn_ftrace *rec; | 2775 | struct dyn_ftrace *rec; |
| 2764 | 2776 | ||
| 2765 | do_for_each_ftrace_rec(pg, rec) { | 2777 | do_for_each_ftrace_rec(pg, rec) { |
| 2766 | if (FTRACE_WARN_ON_ONCE(rec->flags)) | 2778 | if (FTRACE_WARN_ON_ONCE(rec->flags & ~FTRACE_FL_DISABLED)) |
| 2767 | pr_warn(" %pS flags:%lx\n", | 2779 | pr_warn(" %pS flags:%lx\n", |
| 2768 | (void *)rec->ip, rec->flags); | 2780 | (void *)rec->ip, rec->flags); |
| 2769 | } while_for_each_ftrace_rec(); | 2781 | } while_for_each_ftrace_rec(); |
| @@ -3598,6 +3610,10 @@ match_records(struct ftrace_hash *hash, char *func, int len, char *mod) | |||
| 3598 | goto out_unlock; | 3610 | goto out_unlock; |
| 3599 | 3611 | ||
| 3600 | do_for_each_ftrace_rec(pg, rec) { | 3612 | do_for_each_ftrace_rec(pg, rec) { |
| 3613 | |||
| 3614 | if (rec->flags & FTRACE_FL_DISABLED) | ||
| 3615 | continue; | ||
| 3616 | |||
| 3601 | if (ftrace_match_record(rec, &func_g, mod_match, exclude_mod)) { | 3617 | if (ftrace_match_record(rec, &func_g, mod_match, exclude_mod)) { |
| 3602 | ret = enter_record(hash, rec, clear_filter); | 3618 | ret = enter_record(hash, rec, clear_filter); |
| 3603 | if (ret < 0) { | 3619 | if (ret < 0) { |
| @@ -3793,6 +3809,9 @@ register_ftrace_function_probe(char *glob, struct ftrace_probe_ops *ops, | |||
| 3793 | 3809 | ||
| 3794 | do_for_each_ftrace_rec(pg, rec) { | 3810 | do_for_each_ftrace_rec(pg, rec) { |
| 3795 | 3811 | ||
| 3812 | if (rec->flags & FTRACE_FL_DISABLED) | ||
| 3813 | continue; | ||
| 3814 | |||
| 3796 | if (!ftrace_match_record(rec, &func_g, NULL, 0)) | 3815 | if (!ftrace_match_record(rec, &func_g, NULL, 0)) |
| 3797 | continue; | 3816 | continue; |
| 3798 | 3817 | ||
| @@ -4685,6 +4704,9 @@ ftrace_set_func(unsigned long *array, int *idx, int size, char *buffer) | |||
| 4685 | 4704 | ||
| 4686 | do_for_each_ftrace_rec(pg, rec) { | 4705 | do_for_each_ftrace_rec(pg, rec) { |
| 4687 | 4706 | ||
| 4707 | if (rec->flags & FTRACE_FL_DISABLED) | ||
| 4708 | continue; | ||
| 4709 | |||
| 4688 | if (ftrace_match_record(rec, &func_g, NULL, 0)) { | 4710 | if (ftrace_match_record(rec, &func_g, NULL, 0)) { |
| 4689 | /* if it is in the array */ | 4711 | /* if it is in the array */ |
| 4690 | exists = false; | 4712 | exists = false; |
diff --git a/lib/iov_iter.c b/lib/iov_iter.c index f0c7f1481bae..f2bd21b93dfc 100644 --- a/lib/iov_iter.c +++ b/lib/iov_iter.c | |||
| @@ -683,10 +683,11 @@ static void pipe_advance(struct iov_iter *i, size_t size) | |||
| 683 | struct pipe_inode_info *pipe = i->pipe; | 683 | struct pipe_inode_info *pipe = i->pipe; |
| 684 | struct pipe_buffer *buf; | 684 | struct pipe_buffer *buf; |
| 685 | int idx = i->idx; | 685 | int idx = i->idx; |
| 686 | size_t off = i->iov_offset; | 686 | size_t off = i->iov_offset, orig_sz; |
| 687 | 687 | ||
| 688 | if (unlikely(i->count < size)) | 688 | if (unlikely(i->count < size)) |
| 689 | size = i->count; | 689 | size = i->count; |
| 690 | orig_sz = size; | ||
| 690 | 691 | ||
| 691 | if (size) { | 692 | if (size) { |
| 692 | if (off) /* make it relative to the beginning of buffer */ | 693 | if (off) /* make it relative to the beginning of buffer */ |
| @@ -713,6 +714,7 @@ static void pipe_advance(struct iov_iter *i, size_t size) | |||
| 713 | pipe->nrbufs--; | 714 | pipe->nrbufs--; |
| 714 | } | 715 | } |
| 715 | } | 716 | } |
| 717 | i->count -= orig_sz; | ||
| 716 | } | 718 | } |
| 717 | 719 | ||
| 718 | void iov_iter_advance(struct iov_iter *i, size_t size) | 720 | void iov_iter_advance(struct iov_iter *i, size_t size) |
diff --git a/mm/huge_memory.c b/mm/huge_memory.c index cdcd25cb30fe..eff3de359d50 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c | |||
| @@ -1426,11 +1426,12 @@ int zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, | |||
| 1426 | 1426 | ||
| 1427 | bool move_huge_pmd(struct vm_area_struct *vma, unsigned long old_addr, | 1427 | bool move_huge_pmd(struct vm_area_struct *vma, unsigned long old_addr, |
| 1428 | unsigned long new_addr, unsigned long old_end, | 1428 | unsigned long new_addr, unsigned long old_end, |
| 1429 | pmd_t *old_pmd, pmd_t *new_pmd) | 1429 | pmd_t *old_pmd, pmd_t *new_pmd, bool *need_flush) |
| 1430 | { | 1430 | { |
| 1431 | spinlock_t *old_ptl, *new_ptl; | 1431 | spinlock_t *old_ptl, *new_ptl; |
| 1432 | pmd_t pmd; | 1432 | pmd_t pmd; |
| 1433 | struct mm_struct *mm = vma->vm_mm; | 1433 | struct mm_struct *mm = vma->vm_mm; |
| 1434 | bool force_flush = false; | ||
| 1434 | 1435 | ||
| 1435 | if ((old_addr & ~HPAGE_PMD_MASK) || | 1436 | if ((old_addr & ~HPAGE_PMD_MASK) || |
| 1436 | (new_addr & ~HPAGE_PMD_MASK) || | 1437 | (new_addr & ~HPAGE_PMD_MASK) || |
| @@ -1455,6 +1456,8 @@ bool move_huge_pmd(struct vm_area_struct *vma, unsigned long old_addr, | |||
| 1455 | new_ptl = pmd_lockptr(mm, new_pmd); | 1456 | new_ptl = pmd_lockptr(mm, new_pmd); |
| 1456 | if (new_ptl != old_ptl) | 1457 | if (new_ptl != old_ptl) |
| 1457 | spin_lock_nested(new_ptl, SINGLE_DEPTH_NESTING); | 1458 | spin_lock_nested(new_ptl, SINGLE_DEPTH_NESTING); |
| 1459 | if (pmd_present(*old_pmd) && pmd_dirty(*old_pmd)) | ||
| 1460 | force_flush = true; | ||
| 1458 | pmd = pmdp_huge_get_and_clear(mm, old_addr, old_pmd); | 1461 | pmd = pmdp_huge_get_and_clear(mm, old_addr, old_pmd); |
| 1459 | VM_BUG_ON(!pmd_none(*new_pmd)); | 1462 | VM_BUG_ON(!pmd_none(*new_pmd)); |
| 1460 | 1463 | ||
| @@ -1467,6 +1470,10 @@ bool move_huge_pmd(struct vm_area_struct *vma, unsigned long old_addr, | |||
| 1467 | set_pmd_at(mm, new_addr, new_pmd, pmd_mksoft_dirty(pmd)); | 1470 | set_pmd_at(mm, new_addr, new_pmd, pmd_mksoft_dirty(pmd)); |
| 1468 | if (new_ptl != old_ptl) | 1471 | if (new_ptl != old_ptl) |
| 1469 | spin_unlock(new_ptl); | 1472 | spin_unlock(new_ptl); |
| 1473 | if (force_flush) | ||
| 1474 | flush_tlb_range(vma, old_addr, old_addr + PMD_SIZE); | ||
| 1475 | else | ||
| 1476 | *need_flush = true; | ||
| 1470 | spin_unlock(old_ptl); | 1477 | spin_unlock(old_ptl); |
| 1471 | return true; | 1478 | return true; |
| 1472 | } | 1479 | } |
diff --git a/mm/mremap.c b/mm/mremap.c index da22ad2a5678..6ccecc03f56a 100644 --- a/mm/mremap.c +++ b/mm/mremap.c | |||
| @@ -104,11 +104,13 @@ static pte_t move_soft_dirty_pte(pte_t pte) | |||
| 104 | static void move_ptes(struct vm_area_struct *vma, pmd_t *old_pmd, | 104 | static void move_ptes(struct vm_area_struct *vma, pmd_t *old_pmd, |
| 105 | unsigned long old_addr, unsigned long old_end, | 105 | unsigned long old_addr, unsigned long old_end, |
| 106 | struct vm_area_struct *new_vma, pmd_t *new_pmd, | 106 | struct vm_area_struct *new_vma, pmd_t *new_pmd, |
| 107 | unsigned long new_addr, bool need_rmap_locks) | 107 | unsigned long new_addr, bool need_rmap_locks, bool *need_flush) |
| 108 | { | 108 | { |
| 109 | struct mm_struct *mm = vma->vm_mm; | 109 | struct mm_struct *mm = vma->vm_mm; |
| 110 | pte_t *old_pte, *new_pte, pte; | 110 | pte_t *old_pte, *new_pte, pte; |
| 111 | spinlock_t *old_ptl, *new_ptl; | 111 | spinlock_t *old_ptl, *new_ptl; |
| 112 | bool force_flush = false; | ||
| 113 | unsigned long len = old_end - old_addr; | ||
| 112 | 114 | ||
| 113 | /* | 115 | /* |
| 114 | * When need_rmap_locks is true, we take the i_mmap_rwsem and anon_vma | 116 | * When need_rmap_locks is true, we take the i_mmap_rwsem and anon_vma |
| @@ -146,6 +148,14 @@ static void move_ptes(struct vm_area_struct *vma, pmd_t *old_pmd, | |||
| 146 | new_pte++, new_addr += PAGE_SIZE) { | 148 | new_pte++, new_addr += PAGE_SIZE) { |
| 147 | if (pte_none(*old_pte)) | 149 | if (pte_none(*old_pte)) |
| 148 | continue; | 150 | continue; |
| 151 | |||
| 152 | /* | ||
| 153 | * We are remapping a dirty PTE, make sure to | ||
| 154 | * flush TLB before we drop the PTL for the | ||
| 155 | * old PTE or we may race with page_mkclean(). | ||
| 156 | */ | ||
| 157 | if (pte_present(*old_pte) && pte_dirty(*old_pte)) | ||
| 158 | force_flush = true; | ||
| 149 | pte = ptep_get_and_clear(mm, old_addr, old_pte); | 159 | pte = ptep_get_and_clear(mm, old_addr, old_pte); |
| 150 | pte = move_pte(pte, new_vma->vm_page_prot, old_addr, new_addr); | 160 | pte = move_pte(pte, new_vma->vm_page_prot, old_addr, new_addr); |
| 151 | pte = move_soft_dirty_pte(pte); | 161 | pte = move_soft_dirty_pte(pte); |
| @@ -156,6 +166,10 @@ static void move_ptes(struct vm_area_struct *vma, pmd_t *old_pmd, | |||
| 156 | if (new_ptl != old_ptl) | 166 | if (new_ptl != old_ptl) |
| 157 | spin_unlock(new_ptl); | 167 | spin_unlock(new_ptl); |
| 158 | pte_unmap(new_pte - 1); | 168 | pte_unmap(new_pte - 1); |
| 169 | if (force_flush) | ||
| 170 | flush_tlb_range(vma, old_end - len, old_end); | ||
| 171 | else | ||
| 172 | *need_flush = true; | ||
| 159 | pte_unmap_unlock(old_pte - 1, old_ptl); | 173 | pte_unmap_unlock(old_pte - 1, old_ptl); |
| 160 | if (need_rmap_locks) | 174 | if (need_rmap_locks) |
| 161 | drop_rmap_locks(vma); | 175 | drop_rmap_locks(vma); |
| @@ -201,13 +215,12 @@ unsigned long move_page_tables(struct vm_area_struct *vma, | |||
| 201 | if (need_rmap_locks) | 215 | if (need_rmap_locks) |
| 202 | take_rmap_locks(vma); | 216 | take_rmap_locks(vma); |
| 203 | moved = move_huge_pmd(vma, old_addr, new_addr, | 217 | moved = move_huge_pmd(vma, old_addr, new_addr, |
| 204 | old_end, old_pmd, new_pmd); | 218 | old_end, old_pmd, new_pmd, |
| 219 | &need_flush); | ||
| 205 | if (need_rmap_locks) | 220 | if (need_rmap_locks) |
| 206 | drop_rmap_locks(vma); | 221 | drop_rmap_locks(vma); |
| 207 | if (moved) { | 222 | if (moved) |
| 208 | need_flush = true; | ||
| 209 | continue; | 223 | continue; |
| 210 | } | ||
| 211 | } | 224 | } |
| 212 | split_huge_pmd(vma, old_pmd, old_addr); | 225 | split_huge_pmd(vma, old_pmd, old_addr); |
| 213 | if (pmd_trans_unstable(old_pmd)) | 226 | if (pmd_trans_unstable(old_pmd)) |
| @@ -220,11 +233,10 @@ unsigned long move_page_tables(struct vm_area_struct *vma, | |||
| 220 | extent = next - new_addr; | 233 | extent = next - new_addr; |
| 221 | if (extent > LATENCY_LIMIT) | 234 | if (extent > LATENCY_LIMIT) |
| 222 | extent = LATENCY_LIMIT; | 235 | extent = LATENCY_LIMIT; |
| 223 | move_ptes(vma, old_pmd, old_addr, old_addr + extent, | 236 | move_ptes(vma, old_pmd, old_addr, old_addr + extent, new_vma, |
| 224 | new_vma, new_pmd, new_addr, need_rmap_locks); | 237 | new_pmd, new_addr, need_rmap_locks, &need_flush); |
| 225 | need_flush = true; | ||
| 226 | } | 238 | } |
| 227 | if (likely(need_flush)) | 239 | if (need_flush) |
| 228 | flush_tlb_range(vma, old_end-len, old_addr); | 240 | flush_tlb_range(vma, old_end-len, old_addr); |
| 229 | 241 | ||
| 230 | mmu_notifier_invalidate_range_end(vma->vm_mm, mmun_start, mmun_end); | 242 | mmu_notifier_invalidate_range_end(vma->vm_mm, mmun_start, mmun_end); |
diff --git a/net/can/bcm.c b/net/can/bcm.c index 8e999ffdf28b..8af9d25ff988 100644 --- a/net/can/bcm.c +++ b/net/can/bcm.c | |||
| @@ -1549,24 +1549,31 @@ static int bcm_connect(struct socket *sock, struct sockaddr *uaddr, int len, | |||
| 1549 | struct sockaddr_can *addr = (struct sockaddr_can *)uaddr; | 1549 | struct sockaddr_can *addr = (struct sockaddr_can *)uaddr; |
| 1550 | struct sock *sk = sock->sk; | 1550 | struct sock *sk = sock->sk; |
| 1551 | struct bcm_sock *bo = bcm_sk(sk); | 1551 | struct bcm_sock *bo = bcm_sk(sk); |
| 1552 | int ret = 0; | ||
| 1552 | 1553 | ||
| 1553 | if (len < sizeof(*addr)) | 1554 | if (len < sizeof(*addr)) |
| 1554 | return -EINVAL; | 1555 | return -EINVAL; |
| 1555 | 1556 | ||
| 1556 | if (bo->bound) | 1557 | lock_sock(sk); |
| 1557 | return -EISCONN; | 1558 | |
| 1559 | if (bo->bound) { | ||
| 1560 | ret = -EISCONN; | ||
| 1561 | goto fail; | ||
| 1562 | } | ||
| 1558 | 1563 | ||
| 1559 | /* bind a device to this socket */ | 1564 | /* bind a device to this socket */ |
| 1560 | if (addr->can_ifindex) { | 1565 | if (addr->can_ifindex) { |
| 1561 | struct net_device *dev; | 1566 | struct net_device *dev; |
| 1562 | 1567 | ||
| 1563 | dev = dev_get_by_index(&init_net, addr->can_ifindex); | 1568 | dev = dev_get_by_index(&init_net, addr->can_ifindex); |
| 1564 | if (!dev) | 1569 | if (!dev) { |
| 1565 | return -ENODEV; | 1570 | ret = -ENODEV; |
| 1566 | 1571 | goto fail; | |
| 1572 | } | ||
| 1567 | if (dev->type != ARPHRD_CAN) { | 1573 | if (dev->type != ARPHRD_CAN) { |
| 1568 | dev_put(dev); | 1574 | dev_put(dev); |
| 1569 | return -ENODEV; | 1575 | ret = -ENODEV; |
| 1576 | goto fail; | ||
| 1570 | } | 1577 | } |
| 1571 | 1578 | ||
| 1572 | bo->ifindex = dev->ifindex; | 1579 | bo->ifindex = dev->ifindex; |
| @@ -1577,17 +1584,24 @@ static int bcm_connect(struct socket *sock, struct sockaddr *uaddr, int len, | |||
| 1577 | bo->ifindex = 0; | 1584 | bo->ifindex = 0; |
| 1578 | } | 1585 | } |
| 1579 | 1586 | ||
| 1580 | bo->bound = 1; | ||
| 1581 | |||
| 1582 | if (proc_dir) { | 1587 | if (proc_dir) { |
| 1583 | /* unique socket address as filename */ | 1588 | /* unique socket address as filename */ |
| 1584 | sprintf(bo->procname, "%lu", sock_i_ino(sk)); | 1589 | sprintf(bo->procname, "%lu", sock_i_ino(sk)); |
| 1585 | bo->bcm_proc_read = proc_create_data(bo->procname, 0644, | 1590 | bo->bcm_proc_read = proc_create_data(bo->procname, 0644, |
| 1586 | proc_dir, | 1591 | proc_dir, |
| 1587 | &bcm_proc_fops, sk); | 1592 | &bcm_proc_fops, sk); |
| 1593 | if (!bo->bcm_proc_read) { | ||
| 1594 | ret = -ENOMEM; | ||
| 1595 | goto fail; | ||
| 1596 | } | ||
| 1588 | } | 1597 | } |
| 1589 | 1598 | ||
| 1590 | return 0; | 1599 | bo->bound = 1; |
| 1600 | |||
| 1601 | fail: | ||
| 1602 | release_sock(sk); | ||
| 1603 | |||
| 1604 | return ret; | ||
| 1591 | } | 1605 | } |
| 1592 | 1606 | ||
| 1593 | static int bcm_recvmsg(struct socket *sock, struct msghdr *msg, size_t size, | 1607 | static int bcm_recvmsg(struct socket *sock, struct msghdr *msg, size_t size, |
diff --git a/net/core/dev.c b/net/core/dev.c index 820bac239738..6666b28b6815 100644 --- a/net/core/dev.c +++ b/net/core/dev.c | |||
| @@ -1766,19 +1766,14 @@ EXPORT_SYMBOL_GPL(is_skb_forwardable); | |||
| 1766 | 1766 | ||
| 1767 | int __dev_forward_skb(struct net_device *dev, struct sk_buff *skb) | 1767 | int __dev_forward_skb(struct net_device *dev, struct sk_buff *skb) |
| 1768 | { | 1768 | { |
| 1769 | if (skb_orphan_frags(skb, GFP_ATOMIC) || | 1769 | int ret = ____dev_forward_skb(dev, skb); |
| 1770 | unlikely(!is_skb_forwardable(dev, skb))) { | ||
| 1771 | atomic_long_inc(&dev->rx_dropped); | ||
| 1772 | kfree_skb(skb); | ||
| 1773 | return NET_RX_DROP; | ||
| 1774 | } | ||
| 1775 | 1770 | ||
| 1776 | skb_scrub_packet(skb, true); | 1771 | if (likely(!ret)) { |
| 1777 | skb->priority = 0; | 1772 | skb->protocol = eth_type_trans(skb, dev); |
| 1778 | skb->protocol = eth_type_trans(skb, dev); | 1773 | skb_postpull_rcsum(skb, eth_hdr(skb), ETH_HLEN); |
| 1779 | skb_postpull_rcsum(skb, eth_hdr(skb), ETH_HLEN); | 1774 | } |
| 1780 | 1775 | ||
| 1781 | return 0; | 1776 | return ret; |
| 1782 | } | 1777 | } |
| 1783 | EXPORT_SYMBOL_GPL(__dev_forward_skb); | 1778 | EXPORT_SYMBOL_GPL(__dev_forward_skb); |
| 1784 | 1779 | ||
| @@ -2484,7 +2479,7 @@ int skb_checksum_help(struct sk_buff *skb) | |||
| 2484 | goto out; | 2479 | goto out; |
| 2485 | } | 2480 | } |
| 2486 | 2481 | ||
| 2487 | *(__sum16 *)(skb->data + offset) = csum_fold(csum); | 2482 | *(__sum16 *)(skb->data + offset) = csum_fold(csum) ?: CSUM_MANGLED_0; |
| 2488 | out_set_summed: | 2483 | out_set_summed: |
| 2489 | skb->ip_summed = CHECKSUM_NONE; | 2484 | skb->ip_summed = CHECKSUM_NONE; |
| 2490 | out: | 2485 | out: |
diff --git a/net/core/filter.c b/net/core/filter.c index 00351cdf7d0c..b391209838ef 100644 --- a/net/core/filter.c +++ b/net/core/filter.c | |||
| @@ -1628,6 +1628,19 @@ static inline int __bpf_rx_skb(struct net_device *dev, struct sk_buff *skb) | |||
| 1628 | return dev_forward_skb(dev, skb); | 1628 | return dev_forward_skb(dev, skb); |
| 1629 | } | 1629 | } |
| 1630 | 1630 | ||
| 1631 | static inline int __bpf_rx_skb_no_mac(struct net_device *dev, | ||
| 1632 | struct sk_buff *skb) | ||
| 1633 | { | ||
| 1634 | int ret = ____dev_forward_skb(dev, skb); | ||
| 1635 | |||
| 1636 | if (likely(!ret)) { | ||
| 1637 | skb->dev = dev; | ||
| 1638 | ret = netif_rx(skb); | ||
| 1639 | } | ||
| 1640 | |||
| 1641 | return ret; | ||
| 1642 | } | ||
| 1643 | |||
| 1631 | static inline int __bpf_tx_skb(struct net_device *dev, struct sk_buff *skb) | 1644 | static inline int __bpf_tx_skb(struct net_device *dev, struct sk_buff *skb) |
| 1632 | { | 1645 | { |
| 1633 | int ret; | 1646 | int ret; |
| @@ -1647,6 +1660,51 @@ static inline int __bpf_tx_skb(struct net_device *dev, struct sk_buff *skb) | |||
| 1647 | return ret; | 1660 | return ret; |
| 1648 | } | 1661 | } |
| 1649 | 1662 | ||
| 1663 | static int __bpf_redirect_no_mac(struct sk_buff *skb, struct net_device *dev, | ||
| 1664 | u32 flags) | ||
| 1665 | { | ||
| 1666 | /* skb->mac_len is not set on normal egress */ | ||
| 1667 | unsigned int mlen = skb->network_header - skb->mac_header; | ||
| 1668 | |||
| 1669 | __skb_pull(skb, mlen); | ||
| 1670 | |||
| 1671 | /* At ingress, the mac header has already been pulled once. | ||
| 1672 | * At egress, skb_pospull_rcsum has to be done in case that | ||
| 1673 | * the skb is originated from ingress (i.e. a forwarded skb) | ||
| 1674 | * to ensure that rcsum starts at net header. | ||
| 1675 | */ | ||
| 1676 | if (!skb_at_tc_ingress(skb)) | ||
| 1677 | skb_postpull_rcsum(skb, skb_mac_header(skb), mlen); | ||
| 1678 | skb_pop_mac_header(skb); | ||
| 1679 | skb_reset_mac_len(skb); | ||
| 1680 | return flags & BPF_F_INGRESS ? | ||
| 1681 | __bpf_rx_skb_no_mac(dev, skb) : __bpf_tx_skb(dev, skb); | ||
| 1682 | } | ||
| 1683 | |||
| 1684 | static int __bpf_redirect_common(struct sk_buff *skb, struct net_device *dev, | ||
| 1685 | u32 flags) | ||
| 1686 | { | ||
| 1687 | bpf_push_mac_rcsum(skb); | ||
| 1688 | return flags & BPF_F_INGRESS ? | ||
| 1689 | __bpf_rx_skb(dev, skb) : __bpf_tx_skb(dev, skb); | ||
| 1690 | } | ||
| 1691 | |||
| 1692 | static int __bpf_redirect(struct sk_buff *skb, struct net_device *dev, | ||
| 1693 | u32 flags) | ||
| 1694 | { | ||
| 1695 | switch (dev->type) { | ||
| 1696 | case ARPHRD_TUNNEL: | ||
| 1697 | case ARPHRD_TUNNEL6: | ||
| 1698 | case ARPHRD_SIT: | ||
| 1699 | case ARPHRD_IPGRE: | ||
| 1700 | case ARPHRD_VOID: | ||
| 1701 | case ARPHRD_NONE: | ||
| 1702 | return __bpf_redirect_no_mac(skb, dev, flags); | ||
| 1703 | default: | ||
| 1704 | return __bpf_redirect_common(skb, dev, flags); | ||
| 1705 | } | ||
| 1706 | } | ||
| 1707 | |||
| 1650 | BPF_CALL_3(bpf_clone_redirect, struct sk_buff *, skb, u32, ifindex, u64, flags) | 1708 | BPF_CALL_3(bpf_clone_redirect, struct sk_buff *, skb, u32, ifindex, u64, flags) |
| 1651 | { | 1709 | { |
| 1652 | struct net_device *dev; | 1710 | struct net_device *dev; |
| @@ -1675,10 +1733,7 @@ BPF_CALL_3(bpf_clone_redirect, struct sk_buff *, skb, u32, ifindex, u64, flags) | |||
| 1675 | return -ENOMEM; | 1733 | return -ENOMEM; |
| 1676 | } | 1734 | } |
| 1677 | 1735 | ||
| 1678 | bpf_push_mac_rcsum(clone); | 1736 | return __bpf_redirect(clone, dev, flags); |
| 1679 | |||
| 1680 | return flags & BPF_F_INGRESS ? | ||
| 1681 | __bpf_rx_skb(dev, clone) : __bpf_tx_skb(dev, clone); | ||
| 1682 | } | 1737 | } |
| 1683 | 1738 | ||
| 1684 | static const struct bpf_func_proto bpf_clone_redirect_proto = { | 1739 | static const struct bpf_func_proto bpf_clone_redirect_proto = { |
| @@ -1722,10 +1777,7 @@ int skb_do_redirect(struct sk_buff *skb) | |||
| 1722 | return -EINVAL; | 1777 | return -EINVAL; |
| 1723 | } | 1778 | } |
| 1724 | 1779 | ||
| 1725 | bpf_push_mac_rcsum(skb); | 1780 | return __bpf_redirect(skb, dev, ri->flags); |
| 1726 | |||
| 1727 | return ri->flags & BPF_F_INGRESS ? | ||
| 1728 | __bpf_rx_skb(dev, skb) : __bpf_tx_skb(dev, skb); | ||
| 1729 | } | 1781 | } |
| 1730 | 1782 | ||
| 1731 | static const struct bpf_func_proto bpf_redirect_proto = { | 1783 | static const struct bpf_func_proto bpf_redirect_proto = { |
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index ab193e5def07..69e4463a4b1b 100644 --- a/net/core/flow_dissector.c +++ b/net/core/flow_dissector.c | |||
| @@ -122,7 +122,7 @@ bool __skb_flow_dissect(const struct sk_buff *skb, | |||
| 122 | struct flow_dissector_key_keyid *key_keyid; | 122 | struct flow_dissector_key_keyid *key_keyid; |
| 123 | bool skip_vlan = false; | 123 | bool skip_vlan = false; |
| 124 | u8 ip_proto = 0; | 124 | u8 ip_proto = 0; |
| 125 | bool ret = false; | 125 | bool ret; |
| 126 | 126 | ||
| 127 | if (!data) { | 127 | if (!data) { |
| 128 | data = skb->data; | 128 | data = skb->data; |
| @@ -549,12 +549,17 @@ ip_proto_again: | |||
| 549 | out_good: | 549 | out_good: |
| 550 | ret = true; | 550 | ret = true; |
| 551 | 551 | ||
| 552 | out_bad: | 552 | key_control->thoff = (u16)nhoff; |
| 553 | out: | ||
| 553 | key_basic->n_proto = proto; | 554 | key_basic->n_proto = proto; |
| 554 | key_basic->ip_proto = ip_proto; | 555 | key_basic->ip_proto = ip_proto; |
| 555 | key_control->thoff = (u16)nhoff; | ||
| 556 | 556 | ||
| 557 | return ret; | 557 | return ret; |
| 558 | |||
| 559 | out_bad: | ||
| 560 | ret = false; | ||
| 561 | key_control->thoff = min_t(u16, nhoff, skb ? skb->len : hlen); | ||
| 562 | goto out; | ||
| 558 | } | 563 | } |
| 559 | EXPORT_SYMBOL(__skb_flow_dissect); | 564 | EXPORT_SYMBOL(__skb_flow_dissect); |
| 560 | 565 | ||
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index fb7348f13501..db313ec7af32 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c | |||
| @@ -275,6 +275,7 @@ int rtnl_unregister(int protocol, int msgtype) | |||
| 275 | 275 | ||
| 276 | rtnl_msg_handlers[protocol][msgindex].doit = NULL; | 276 | rtnl_msg_handlers[protocol][msgindex].doit = NULL; |
| 277 | rtnl_msg_handlers[protocol][msgindex].dumpit = NULL; | 277 | rtnl_msg_handlers[protocol][msgindex].dumpit = NULL; |
| 278 | rtnl_msg_handlers[protocol][msgindex].calcit = NULL; | ||
| 278 | 279 | ||
| 279 | return 0; | 280 | return 0; |
| 280 | } | 281 | } |
diff --git a/net/core/sock.c b/net/core/sock.c index c73e28fc9c2a..5e3ca414357e 100644 --- a/net/core/sock.c +++ b/net/core/sock.c | |||
| @@ -453,7 +453,7 @@ int sock_queue_rcv_skb(struct sock *sk, struct sk_buff *skb) | |||
| 453 | EXPORT_SYMBOL(sock_queue_rcv_skb); | 453 | EXPORT_SYMBOL(sock_queue_rcv_skb); |
| 454 | 454 | ||
| 455 | int __sk_receive_skb(struct sock *sk, struct sk_buff *skb, | 455 | int __sk_receive_skb(struct sock *sk, struct sk_buff *skb, |
| 456 | const int nested, unsigned int trim_cap) | 456 | const int nested, unsigned int trim_cap, bool refcounted) |
| 457 | { | 457 | { |
| 458 | int rc = NET_RX_SUCCESS; | 458 | int rc = NET_RX_SUCCESS; |
| 459 | 459 | ||
| @@ -487,7 +487,8 @@ int __sk_receive_skb(struct sock *sk, struct sk_buff *skb, | |||
| 487 | 487 | ||
| 488 | bh_unlock_sock(sk); | 488 | bh_unlock_sock(sk); |
| 489 | out: | 489 | out: |
| 490 | sock_put(sk); | 490 | if (refcounted) |
| 491 | sock_put(sk); | ||
| 491 | return rc; | 492 | return rc; |
| 492 | discard_and_relse: | 493 | discard_and_relse: |
| 493 | kfree_skb(skb); | 494 | kfree_skb(skb); |
| @@ -1543,6 +1544,7 @@ struct sock *sk_clone_lock(const struct sock *sk, const gfp_t priority) | |||
| 1543 | RCU_INIT_POINTER(newsk->sk_reuseport_cb, NULL); | 1544 | RCU_INIT_POINTER(newsk->sk_reuseport_cb, NULL); |
| 1544 | 1545 | ||
| 1545 | newsk->sk_err = 0; | 1546 | newsk->sk_err = 0; |
| 1547 | newsk->sk_err_soft = 0; | ||
| 1546 | newsk->sk_priority = 0; | 1548 | newsk->sk_priority = 0; |
| 1547 | newsk->sk_incoming_cpu = raw_smp_processor_id(); | 1549 | newsk->sk_incoming_cpu = raw_smp_processor_id(); |
| 1548 | atomic64_set(&newsk->sk_cookie, 0); | 1550 | atomic64_set(&newsk->sk_cookie, 0); |
diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c index 345a3aeb8c7e..b567c8725aea 100644 --- a/net/dccp/ipv4.c +++ b/net/dccp/ipv4.c | |||
| @@ -235,7 +235,7 @@ static void dccp_v4_err(struct sk_buff *skb, u32 info) | |||
| 235 | { | 235 | { |
| 236 | const struct iphdr *iph = (struct iphdr *)skb->data; | 236 | const struct iphdr *iph = (struct iphdr *)skb->data; |
| 237 | const u8 offset = iph->ihl << 2; | 237 | const u8 offset = iph->ihl << 2; |
| 238 | const struct dccp_hdr *dh = (struct dccp_hdr *)(skb->data + offset); | 238 | const struct dccp_hdr *dh; |
| 239 | struct dccp_sock *dp; | 239 | struct dccp_sock *dp; |
| 240 | struct inet_sock *inet; | 240 | struct inet_sock *inet; |
| 241 | const int type = icmp_hdr(skb)->type; | 241 | const int type = icmp_hdr(skb)->type; |
| @@ -245,11 +245,13 @@ static void dccp_v4_err(struct sk_buff *skb, u32 info) | |||
| 245 | int err; | 245 | int err; |
| 246 | struct net *net = dev_net(skb->dev); | 246 | struct net *net = dev_net(skb->dev); |
| 247 | 247 | ||
| 248 | if (skb->len < offset + sizeof(*dh) || | 248 | /* Only need dccph_dport & dccph_sport which are the first |
| 249 | skb->len < offset + __dccp_basic_hdr_len(dh)) { | 249 | * 4 bytes in dccp header. |
| 250 | __ICMP_INC_STATS(net, ICMP_MIB_INERRORS); | 250 | * Our caller (icmp_socket_deliver()) already pulled 8 bytes for us. |
| 251 | return; | 251 | */ |
| 252 | } | 252 | BUILD_BUG_ON(offsetofend(struct dccp_hdr, dccph_sport) > 8); |
| 253 | BUILD_BUG_ON(offsetofend(struct dccp_hdr, dccph_dport) > 8); | ||
| 254 | dh = (struct dccp_hdr *)(skb->data + offset); | ||
| 253 | 255 | ||
| 254 | sk = __inet_lookup_established(net, &dccp_hashinfo, | 256 | sk = __inet_lookup_established(net, &dccp_hashinfo, |
| 255 | iph->daddr, dh->dccph_dport, | 257 | iph->daddr, dh->dccph_dport, |
| @@ -868,7 +870,7 @@ lookup: | |||
| 868 | goto discard_and_relse; | 870 | goto discard_and_relse; |
| 869 | nf_reset(skb); | 871 | nf_reset(skb); |
| 870 | 872 | ||
| 871 | return __sk_receive_skb(sk, skb, 1, dh->dccph_doff * 4); | 873 | return __sk_receive_skb(sk, skb, 1, dh->dccph_doff * 4, refcounted); |
| 872 | 874 | ||
| 873 | no_dccp_socket: | 875 | no_dccp_socket: |
| 874 | if (!xfrm4_policy_check(NULL, XFRM_POLICY_IN, skb)) | 876 | if (!xfrm4_policy_check(NULL, XFRM_POLICY_IN, skb)) |
diff --git a/net/dccp/ipv6.c b/net/dccp/ipv6.c index 3828f94b234c..715e5d1dc107 100644 --- a/net/dccp/ipv6.c +++ b/net/dccp/ipv6.c | |||
| @@ -70,7 +70,7 @@ static void dccp_v6_err(struct sk_buff *skb, struct inet6_skb_parm *opt, | |||
| 70 | u8 type, u8 code, int offset, __be32 info) | 70 | u8 type, u8 code, int offset, __be32 info) |
| 71 | { | 71 | { |
| 72 | const struct ipv6hdr *hdr = (const struct ipv6hdr *)skb->data; | 72 | const struct ipv6hdr *hdr = (const struct ipv6hdr *)skb->data; |
| 73 | const struct dccp_hdr *dh = (struct dccp_hdr *)(skb->data + offset); | 73 | const struct dccp_hdr *dh; |
| 74 | struct dccp_sock *dp; | 74 | struct dccp_sock *dp; |
| 75 | struct ipv6_pinfo *np; | 75 | struct ipv6_pinfo *np; |
| 76 | struct sock *sk; | 76 | struct sock *sk; |
| @@ -78,12 +78,13 @@ static void dccp_v6_err(struct sk_buff *skb, struct inet6_skb_parm *opt, | |||
| 78 | __u64 seq; | 78 | __u64 seq; |
| 79 | struct net *net = dev_net(skb->dev); | 79 | struct net *net = dev_net(skb->dev); |
| 80 | 80 | ||
| 81 | if (skb->len < offset + sizeof(*dh) || | 81 | /* Only need dccph_dport & dccph_sport which are the first |
| 82 | skb->len < offset + __dccp_basic_hdr_len(dh)) { | 82 | * 4 bytes in dccp header. |
| 83 | __ICMP6_INC_STATS(net, __in6_dev_get(skb->dev), | 83 | * Our caller (icmpv6_notify()) already pulled 8 bytes for us. |
| 84 | ICMP6_MIB_INERRORS); | 84 | */ |
| 85 | return; | 85 | BUILD_BUG_ON(offsetofend(struct dccp_hdr, dccph_sport) > 8); |
| 86 | } | 86 | BUILD_BUG_ON(offsetofend(struct dccp_hdr, dccph_dport) > 8); |
| 87 | dh = (struct dccp_hdr *)(skb->data + offset); | ||
| 87 | 88 | ||
| 88 | sk = __inet6_lookup_established(net, &dccp_hashinfo, | 89 | sk = __inet6_lookup_established(net, &dccp_hashinfo, |
| 89 | &hdr->daddr, dh->dccph_dport, | 90 | &hdr->daddr, dh->dccph_dport, |
| @@ -738,7 +739,8 @@ lookup: | |||
| 738 | if (!xfrm6_policy_check(sk, XFRM_POLICY_IN, skb)) | 739 | if (!xfrm6_policy_check(sk, XFRM_POLICY_IN, skb)) |
| 739 | goto discard_and_relse; | 740 | goto discard_and_relse; |
| 740 | 741 | ||
| 741 | return __sk_receive_skb(sk, skb, 1, dh->dccph_doff * 4) ? -1 : 0; | 742 | return __sk_receive_skb(sk, skb, 1, dh->dccph_doff * 4, |
| 743 | refcounted) ? -1 : 0; | ||
| 742 | 744 | ||
| 743 | no_dccp_socket: | 745 | no_dccp_socket: |
| 744 | if (!xfrm6_policy_check(NULL, XFRM_POLICY_IN, skb)) | 746 | if (!xfrm6_policy_check(NULL, XFRM_POLICY_IN, skb)) |
| @@ -956,6 +958,7 @@ static const struct inet_connection_sock_af_ops dccp_ipv6_mapped = { | |||
| 956 | .getsockopt = ipv6_getsockopt, | 958 | .getsockopt = ipv6_getsockopt, |
| 957 | .addr2sockaddr = inet6_csk_addr2sockaddr, | 959 | .addr2sockaddr = inet6_csk_addr2sockaddr, |
| 958 | .sockaddr_len = sizeof(struct sockaddr_in6), | 960 | .sockaddr_len = sizeof(struct sockaddr_in6), |
| 961 | .bind_conflict = inet6_csk_bind_conflict, | ||
| 959 | #ifdef CONFIG_COMPAT | 962 | #ifdef CONFIG_COMPAT |
| 960 | .compat_setsockopt = compat_ipv6_setsockopt, | 963 | .compat_setsockopt = compat_ipv6_setsockopt, |
| 961 | .compat_getsockopt = compat_ipv6_getsockopt, | 964 | .compat_getsockopt = compat_ipv6_getsockopt, |
diff --git a/net/dccp/proto.c b/net/dccp/proto.c index 41e65804ddf5..9fe25bf63296 100644 --- a/net/dccp/proto.c +++ b/net/dccp/proto.c | |||
| @@ -1009,6 +1009,10 @@ void dccp_close(struct sock *sk, long timeout) | |||
| 1009 | __kfree_skb(skb); | 1009 | __kfree_skb(skb); |
| 1010 | } | 1010 | } |
| 1011 | 1011 | ||
| 1012 | /* If socket has been already reset kill it. */ | ||
| 1013 | if (sk->sk_state == DCCP_CLOSED) | ||
| 1014 | goto adjudge_to_death; | ||
| 1015 | |||
| 1012 | if (data_was_unread) { | 1016 | if (data_was_unread) { |
| 1013 | /* Unread data was tossed, send an appropriate Reset Code */ | 1017 | /* Unread data was tossed, send an appropriate Reset Code */ |
| 1014 | DCCP_WARN("ABORT with %u bytes unread\n", data_was_unread); | 1018 | DCCP_WARN("ABORT with %u bytes unread\n", data_was_unread); |
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index 9648c97e541f..5ddf5cda07f4 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c | |||
| @@ -533,9 +533,9 @@ EXPORT_SYMBOL(inet_dgram_connect); | |||
| 533 | 533 | ||
| 534 | static long inet_wait_for_connect(struct sock *sk, long timeo, int writebias) | 534 | static long inet_wait_for_connect(struct sock *sk, long timeo, int writebias) |
| 535 | { | 535 | { |
| 536 | DEFINE_WAIT(wait); | 536 | DEFINE_WAIT_FUNC(wait, woken_wake_function); |
| 537 | 537 | ||
| 538 | prepare_to_wait(sk_sleep(sk), &wait, TASK_INTERRUPTIBLE); | 538 | add_wait_queue(sk_sleep(sk), &wait); |
| 539 | sk->sk_write_pending += writebias; | 539 | sk->sk_write_pending += writebias; |
| 540 | 540 | ||
| 541 | /* Basic assumption: if someone sets sk->sk_err, he _must_ | 541 | /* Basic assumption: if someone sets sk->sk_err, he _must_ |
| @@ -545,13 +545,12 @@ static long inet_wait_for_connect(struct sock *sk, long timeo, int writebias) | |||
| 545 | */ | 545 | */ |
| 546 | while ((1 << sk->sk_state) & (TCPF_SYN_SENT | TCPF_SYN_RECV)) { | 546 | while ((1 << sk->sk_state) & (TCPF_SYN_SENT | TCPF_SYN_RECV)) { |
| 547 | release_sock(sk); | 547 | release_sock(sk); |
| 548 | timeo = schedule_timeout(timeo); | 548 | timeo = wait_woken(&wait, TASK_INTERRUPTIBLE, timeo); |
| 549 | lock_sock(sk); | 549 | lock_sock(sk); |
| 550 | if (signal_pending(current) || !timeo) | 550 | if (signal_pending(current) || !timeo) |
| 551 | break; | 551 | break; |
| 552 | prepare_to_wait(sk_sleep(sk), &wait, TASK_INTERRUPTIBLE); | ||
| 553 | } | 552 | } |
| 554 | finish_wait(sk_sleep(sk), &wait); | 553 | remove_wait_queue(sk_sleep(sk), &wait); |
| 555 | sk->sk_write_pending -= writebias; | 554 | sk->sk_write_pending -= writebias; |
| 556 | return timeo; | 555 | return timeo; |
| 557 | } | 556 | } |
diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c index 31cef3602585..4cff74d4133f 100644 --- a/net/ipv4/fib_trie.c +++ b/net/ipv4/fib_trie.c | |||
| @@ -2413,22 +2413,19 @@ static struct key_vector *fib_route_get_idx(struct fib_route_iter *iter, | |||
| 2413 | struct key_vector *l, **tp = &iter->tnode; | 2413 | struct key_vector *l, **tp = &iter->tnode; |
| 2414 | t_key key; | 2414 | t_key key; |
| 2415 | 2415 | ||
| 2416 | /* use cache location of next-to-find key */ | 2416 | /* use cached location of previously found key */ |
| 2417 | if (iter->pos > 0 && pos >= iter->pos) { | 2417 | if (iter->pos > 0 && pos >= iter->pos) { |
| 2418 | pos -= iter->pos; | ||
| 2419 | key = iter->key; | 2418 | key = iter->key; |
| 2420 | } else { | 2419 | } else { |
| 2421 | iter->pos = 0; | 2420 | iter->pos = 1; |
| 2422 | key = 0; | 2421 | key = 0; |
| 2423 | } | 2422 | } |
| 2424 | 2423 | ||
| 2425 | while ((l = leaf_walk_rcu(tp, key)) != NULL) { | 2424 | pos -= iter->pos; |
| 2425 | |||
| 2426 | while ((l = leaf_walk_rcu(tp, key)) && (pos-- > 0)) { | ||
| 2426 | key = l->key + 1; | 2427 | key = l->key + 1; |
| 2427 | iter->pos++; | 2428 | iter->pos++; |
| 2428 | |||
| 2429 | if (--pos <= 0) | ||
| 2430 | break; | ||
| 2431 | |||
| 2432 | l = NULL; | 2429 | l = NULL; |
| 2433 | 2430 | ||
| 2434 | /* handle unlikely case of a key wrap */ | 2431 | /* handle unlikely case of a key wrap */ |
| @@ -2437,7 +2434,7 @@ static struct key_vector *fib_route_get_idx(struct fib_route_iter *iter, | |||
| 2437 | } | 2434 | } |
| 2438 | 2435 | ||
| 2439 | if (l) | 2436 | if (l) |
| 2440 | iter->key = key; /* remember it */ | 2437 | iter->key = l->key; /* remember it */ |
| 2441 | else | 2438 | else |
| 2442 | iter->pos = 0; /* forget it */ | 2439 | iter->pos = 0; /* forget it */ |
| 2443 | 2440 | ||
| @@ -2465,7 +2462,7 @@ static void *fib_route_seq_start(struct seq_file *seq, loff_t *pos) | |||
| 2465 | return fib_route_get_idx(iter, *pos); | 2462 | return fib_route_get_idx(iter, *pos); |
| 2466 | 2463 | ||
| 2467 | iter->pos = 0; | 2464 | iter->pos = 0; |
| 2468 | iter->key = 0; | 2465 | iter->key = KEY_MAX; |
| 2469 | 2466 | ||
| 2470 | return SEQ_START_TOKEN; | 2467 | return SEQ_START_TOKEN; |
| 2471 | } | 2468 | } |
| @@ -2474,7 +2471,7 @@ static void *fib_route_seq_next(struct seq_file *seq, void *v, loff_t *pos) | |||
| 2474 | { | 2471 | { |
| 2475 | struct fib_route_iter *iter = seq->private; | 2472 | struct fib_route_iter *iter = seq->private; |
| 2476 | struct key_vector *l = NULL; | 2473 | struct key_vector *l = NULL; |
| 2477 | t_key key = iter->key; | 2474 | t_key key = iter->key + 1; |
| 2478 | 2475 | ||
| 2479 | ++*pos; | 2476 | ++*pos; |
| 2480 | 2477 | ||
| @@ -2483,7 +2480,7 @@ static void *fib_route_seq_next(struct seq_file *seq, void *v, loff_t *pos) | |||
| 2483 | l = leaf_walk_rcu(&iter->tnode, key); | 2480 | l = leaf_walk_rcu(&iter->tnode, key); |
| 2484 | 2481 | ||
| 2485 | if (l) { | 2482 | if (l) { |
| 2486 | iter->key = l->key + 1; | 2483 | iter->key = l->key; |
| 2487 | iter->pos++; | 2484 | iter->pos++; |
| 2488 | } else { | 2485 | } else { |
| 2489 | iter->pos = 0; | 2486 | iter->pos = 0; |
diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c index 38abe70e595f..48734ee6293f 100644 --- a/net/ipv4/icmp.c +++ b/net/ipv4/icmp.c | |||
| @@ -477,7 +477,7 @@ static struct rtable *icmp_route_lookup(struct net *net, | |||
| 477 | fl4->flowi4_proto = IPPROTO_ICMP; | 477 | fl4->flowi4_proto = IPPROTO_ICMP; |
| 478 | fl4->fl4_icmp_type = type; | 478 | fl4->fl4_icmp_type = type; |
| 479 | fl4->fl4_icmp_code = code; | 479 | fl4->fl4_icmp_code = code; |
| 480 | fl4->flowi4_oif = l3mdev_master_ifindex(skb_in->dev); | 480 | fl4->flowi4_oif = l3mdev_master_ifindex(skb_dst(skb_in)->dev); |
| 481 | 481 | ||
| 482 | security_skb_classify_flow(skb_in, flowi4_to_flowi(fl4)); | 482 | security_skb_classify_flow(skb_in, flowi4_to_flowi(fl4)); |
| 483 | rt = __ip_route_output_key_hash(net, fl4, | 483 | rt = __ip_route_output_key_hash(net, fl4, |
| @@ -502,7 +502,7 @@ static struct rtable *icmp_route_lookup(struct net *net, | |||
| 502 | if (err) | 502 | if (err) |
| 503 | goto relookup_failed; | 503 | goto relookup_failed; |
| 504 | 504 | ||
| 505 | if (inet_addr_type_dev_table(net, skb_in->dev, | 505 | if (inet_addr_type_dev_table(net, skb_dst(skb_in)->dev, |
| 506 | fl4_dec.saddr) == RTN_LOCAL) { | 506 | fl4_dec.saddr) == RTN_LOCAL) { |
| 507 | rt2 = __ip_route_output_key(net, &fl4_dec); | 507 | rt2 = __ip_route_output_key(net, &fl4_dec); |
| 508 | if (IS_ERR(rt2)) | 508 | if (IS_ERR(rt2)) |
diff --git a/net/ipv4/ip_forward.c b/net/ipv4/ip_forward.c index 8b4ffd216839..9f0a7b96646f 100644 --- a/net/ipv4/ip_forward.c +++ b/net/ipv4/ip_forward.c | |||
| @@ -117,7 +117,7 @@ int ip_forward(struct sk_buff *skb) | |||
| 117 | if (opt->is_strictroute && rt->rt_uses_gateway) | 117 | if (opt->is_strictroute && rt->rt_uses_gateway) |
| 118 | goto sr_failed; | 118 | goto sr_failed; |
| 119 | 119 | ||
| 120 | IPCB(skb)->flags |= IPSKB_FORWARDED | IPSKB_FRAG_SEGS; | 120 | IPCB(skb)->flags |= IPSKB_FORWARDED; |
| 121 | mtu = ip_dst_mtu_maybe_forward(&rt->dst, true); | 121 | mtu = ip_dst_mtu_maybe_forward(&rt->dst, true); |
| 122 | if (ip_exceeds_mtu(skb, mtu)) { | 122 | if (ip_exceeds_mtu(skb, mtu)) { |
| 123 | IP_INC_STATS(net, IPSTATS_MIB_FRAGFAILS); | 123 | IP_INC_STATS(net, IPSTATS_MIB_FRAGFAILS); |
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index 03e7f7310423..105908d841a3 100644 --- a/net/ipv4/ip_output.c +++ b/net/ipv4/ip_output.c | |||
| @@ -239,19 +239,23 @@ static int ip_finish_output_gso(struct net *net, struct sock *sk, | |||
| 239 | struct sk_buff *segs; | 239 | struct sk_buff *segs; |
| 240 | int ret = 0; | 240 | int ret = 0; |
| 241 | 241 | ||
| 242 | /* common case: fragmentation of segments is not allowed, | 242 | /* common case: seglen is <= mtu |
| 243 | * or seglen is <= mtu | ||
| 244 | */ | 243 | */ |
| 245 | if (((IPCB(skb)->flags & IPSKB_FRAG_SEGS) == 0) || | 244 | if (skb_gso_validate_mtu(skb, mtu)) |
| 246 | skb_gso_validate_mtu(skb, mtu)) | ||
| 247 | return ip_finish_output2(net, sk, skb); | 245 | return ip_finish_output2(net, sk, skb); |
| 248 | 246 | ||
| 249 | /* Slowpath - GSO segment length is exceeding the dst MTU. | 247 | /* Slowpath - GSO segment length exceeds the egress MTU. |
| 250 | * | 248 | * |
| 251 | * This can happen in two cases: | 249 | * This can happen in several cases: |
| 252 | * 1) TCP GRO packet, DF bit not set | 250 | * - Forwarding of a TCP GRO skb, when DF flag is not set. |
| 253 | * 2) skb arrived via virtio-net, we thus get TSO/GSO skbs directly | 251 | * - Forwarding of an skb that arrived on a virtualization interface |
| 254 | * from host network stack. | 252 | * (virtio-net/vhost/tap) with TSO/GSO size set by other network |
| 253 | * stack. | ||
| 254 | * - Local GSO skb transmitted on an NETIF_F_TSO tunnel stacked over an | ||
| 255 | * interface with a smaller MTU. | ||
| 256 | * - Arriving GRO skb (or GSO skb in a virtualized environment) that is | ||
| 257 | * bridged to a NETIF_F_TSO tunnel stacked over an interface with an | ||
| 258 | * insufficent MTU. | ||
| 255 | */ | 259 | */ |
| 256 | features = netif_skb_features(skb); | 260 | features = netif_skb_features(skb); |
| 257 | BUILD_BUG_ON(sizeof(*IPCB(skb)) > SKB_SGO_CB_OFFSET); | 261 | BUILD_BUG_ON(sizeof(*IPCB(skb)) > SKB_SGO_CB_OFFSET); |
| @@ -1579,7 +1583,8 @@ void ip_send_unicast_reply(struct sock *sk, struct sk_buff *skb, | |||
| 1579 | } | 1583 | } |
| 1580 | 1584 | ||
| 1581 | oif = arg->bound_dev_if; | 1585 | oif = arg->bound_dev_if; |
| 1582 | oif = oif ? : skb->skb_iif; | 1586 | if (!oif && netif_index_is_l3_master(net, skb->skb_iif)) |
| 1587 | oif = skb->skb_iif; | ||
| 1583 | 1588 | ||
| 1584 | flowi4_init_output(&fl4, oif, | 1589 | flowi4_init_output(&fl4, oif, |
| 1585 | IP4_REPLY_MARK(net, skb->mark), | 1590 | IP4_REPLY_MARK(net, skb->mark), |
diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c index 777bc1883870..fed3d29f9eb3 100644 --- a/net/ipv4/ip_tunnel_core.c +++ b/net/ipv4/ip_tunnel_core.c | |||
| @@ -63,7 +63,6 @@ void iptunnel_xmit(struct sock *sk, struct rtable *rt, struct sk_buff *skb, | |||
| 63 | int pkt_len = skb->len - skb_inner_network_offset(skb); | 63 | int pkt_len = skb->len - skb_inner_network_offset(skb); |
| 64 | struct net *net = dev_net(rt->dst.dev); | 64 | struct net *net = dev_net(rt->dst.dev); |
| 65 | struct net_device *dev = skb->dev; | 65 | struct net_device *dev = skb->dev; |
| 66 | int skb_iif = skb->skb_iif; | ||
| 67 | struct iphdr *iph; | 66 | struct iphdr *iph; |
| 68 | int err; | 67 | int err; |
| 69 | 68 | ||
| @@ -73,16 +72,6 @@ void iptunnel_xmit(struct sock *sk, struct rtable *rt, struct sk_buff *skb, | |||
| 73 | skb_dst_set(skb, &rt->dst); | 72 | skb_dst_set(skb, &rt->dst); |
| 74 | memset(IPCB(skb), 0, sizeof(*IPCB(skb))); | 73 | memset(IPCB(skb), 0, sizeof(*IPCB(skb))); |
| 75 | 74 | ||
| 76 | if (skb_iif && !(df & htons(IP_DF))) { | ||
| 77 | /* Arrived from an ingress interface, got encapsulated, with | ||
| 78 | * fragmentation of encapulating frames allowed. | ||
| 79 | * If skb is gso, the resulting encapsulated network segments | ||
| 80 | * may exceed dst mtu. | ||
| 81 | * Allow IP Fragmentation of segments. | ||
| 82 | */ | ||
| 83 | IPCB(skb)->flags |= IPSKB_FRAG_SEGS; | ||
| 84 | } | ||
| 85 | |||
| 86 | /* Push down and install the IP header. */ | 75 | /* Push down and install the IP header. */ |
| 87 | skb_push(skb, sizeof(struct iphdr)); | 76 | skb_push(skb, sizeof(struct iphdr)); |
| 88 | skb_reset_network_header(skb); | 77 | skb_reset_network_header(skb); |
diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index 5f006e13de56..27089f5ebbb1 100644 --- a/net/ipv4/ipmr.c +++ b/net/ipv4/ipmr.c | |||
| @@ -1749,7 +1749,7 @@ static void ipmr_queue_xmit(struct net *net, struct mr_table *mrt, | |||
| 1749 | vif->dev->stats.tx_bytes += skb->len; | 1749 | vif->dev->stats.tx_bytes += skb->len; |
| 1750 | } | 1750 | } |
| 1751 | 1751 | ||
| 1752 | IPCB(skb)->flags |= IPSKB_FORWARDED | IPSKB_FRAG_SEGS; | 1752 | IPCB(skb)->flags |= IPSKB_FORWARDED; |
| 1753 | 1753 | ||
| 1754 | /* RFC1584 teaches, that DVMRP/PIM router must deliver packets locally | 1754 | /* RFC1584 teaches, that DVMRP/PIM router must deliver packets locally |
| 1755 | * not only before forwarding, but after forwarding on all output | 1755 | * not only before forwarding, but after forwarding on all output |
diff --git a/net/ipv4/netfilter/nft_dup_ipv4.c b/net/ipv4/netfilter/nft_dup_ipv4.c index bf855e64fc45..0c01a270bf9f 100644 --- a/net/ipv4/netfilter/nft_dup_ipv4.c +++ b/net/ipv4/netfilter/nft_dup_ipv4.c | |||
| @@ -28,7 +28,7 @@ static void nft_dup_ipv4_eval(const struct nft_expr *expr, | |||
| 28 | struct in_addr gw = { | 28 | struct in_addr gw = { |
| 29 | .s_addr = (__force __be32)regs->data[priv->sreg_addr], | 29 | .s_addr = (__force __be32)regs->data[priv->sreg_addr], |
| 30 | }; | 30 | }; |
| 31 | int oif = regs->data[priv->sreg_dev]; | 31 | int oif = priv->sreg_dev ? regs->data[priv->sreg_dev] : -1; |
| 32 | 32 | ||
| 33 | nf_dup_ipv4(pkt->net, pkt->skb, pkt->hook, &gw, oif); | 33 | nf_dup_ipv4(pkt->net, pkt->skb, pkt->hook, &gw, oif); |
| 34 | } | 34 | } |
| @@ -59,7 +59,9 @@ static int nft_dup_ipv4_dump(struct sk_buff *skb, const struct nft_expr *expr) | |||
| 59 | { | 59 | { |
| 60 | struct nft_dup_ipv4 *priv = nft_expr_priv(expr); | 60 | struct nft_dup_ipv4 *priv = nft_expr_priv(expr); |
| 61 | 61 | ||
| 62 | if (nft_dump_register(skb, NFTA_DUP_SREG_ADDR, priv->sreg_addr) || | 62 | if (nft_dump_register(skb, NFTA_DUP_SREG_ADDR, priv->sreg_addr)) |
| 63 | goto nla_put_failure; | ||
| 64 | if (priv->sreg_dev && | ||
| 63 | nft_dump_register(skb, NFTA_DUP_SREG_DEV, priv->sreg_dev)) | 65 | nft_dump_register(skb, NFTA_DUP_SREG_DEV, priv->sreg_dev)) |
| 64 | goto nla_put_failure; | 66 | goto nla_put_failure; |
| 65 | 67 | ||
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 62d4d90c1389..2a57566e6e91 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c | |||
| @@ -753,7 +753,9 @@ static void __ip_do_redirect(struct rtable *rt, struct sk_buff *skb, struct flow | |||
| 753 | goto reject_redirect; | 753 | goto reject_redirect; |
| 754 | } | 754 | } |
| 755 | 755 | ||
| 756 | n = ipv4_neigh_lookup(&rt->dst, NULL, &new_gw); | 756 | n = __ipv4_neigh_lookup(rt->dst.dev, new_gw); |
| 757 | if (!n) | ||
| 758 | n = neigh_create(&arp_tbl, &new_gw, rt->dst.dev); | ||
| 757 | if (!IS_ERR(n)) { | 759 | if (!IS_ERR(n)) { |
| 758 | if (!(n->nud_state & NUD_VALID)) { | 760 | if (!(n->nud_state & NUD_VALID)) { |
| 759 | neigh_event_send(n, NULL); | 761 | neigh_event_send(n, NULL); |
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 3251fe71f39f..814af89c1bd3 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c | |||
| @@ -1164,7 +1164,7 @@ restart: | |||
| 1164 | 1164 | ||
| 1165 | err = -EPIPE; | 1165 | err = -EPIPE; |
| 1166 | if (sk->sk_err || (sk->sk_shutdown & SEND_SHUTDOWN)) | 1166 | if (sk->sk_err || (sk->sk_shutdown & SEND_SHUTDOWN)) |
| 1167 | goto out_err; | 1167 | goto do_error; |
| 1168 | 1168 | ||
| 1169 | sg = !!(sk->sk_route_caps & NETIF_F_SG); | 1169 | sg = !!(sk->sk_route_caps & NETIF_F_SG); |
| 1170 | 1170 | ||
| @@ -1241,7 +1241,7 @@ new_segment: | |||
| 1241 | 1241 | ||
| 1242 | if (!skb_can_coalesce(skb, i, pfrag->page, | 1242 | if (!skb_can_coalesce(skb, i, pfrag->page, |
| 1243 | pfrag->offset)) { | 1243 | pfrag->offset)) { |
| 1244 | if (i == sysctl_max_skb_frags || !sg) { | 1244 | if (i >= sysctl_max_skb_frags || !sg) { |
| 1245 | tcp_mark_push(tp, skb); | 1245 | tcp_mark_push(tp, skb); |
| 1246 | goto new_segment; | 1246 | goto new_segment; |
| 1247 | } | 1247 | } |
diff --git a/net/ipv4/tcp_dctcp.c b/net/ipv4/tcp_dctcp.c index 10d728b6804c..ab37c6775630 100644 --- a/net/ipv4/tcp_dctcp.c +++ b/net/ipv4/tcp_dctcp.c | |||
| @@ -56,6 +56,7 @@ struct dctcp { | |||
| 56 | u32 next_seq; | 56 | u32 next_seq; |
| 57 | u32 ce_state; | 57 | u32 ce_state; |
| 58 | u32 delayed_ack_reserved; | 58 | u32 delayed_ack_reserved; |
| 59 | u32 loss_cwnd; | ||
| 59 | }; | 60 | }; |
| 60 | 61 | ||
| 61 | static unsigned int dctcp_shift_g __read_mostly = 4; /* g = 1/2^4 */ | 62 | static unsigned int dctcp_shift_g __read_mostly = 4; /* g = 1/2^4 */ |
| @@ -96,6 +97,7 @@ static void dctcp_init(struct sock *sk) | |||
| 96 | ca->dctcp_alpha = min(dctcp_alpha_on_init, DCTCP_MAX_ALPHA); | 97 | ca->dctcp_alpha = min(dctcp_alpha_on_init, DCTCP_MAX_ALPHA); |
| 97 | 98 | ||
| 98 | ca->delayed_ack_reserved = 0; | 99 | ca->delayed_ack_reserved = 0; |
| 100 | ca->loss_cwnd = 0; | ||
| 99 | ca->ce_state = 0; | 101 | ca->ce_state = 0; |
| 100 | 102 | ||
| 101 | dctcp_reset(tp, ca); | 103 | dctcp_reset(tp, ca); |
| @@ -111,9 +113,10 @@ static void dctcp_init(struct sock *sk) | |||
| 111 | 113 | ||
| 112 | static u32 dctcp_ssthresh(struct sock *sk) | 114 | static u32 dctcp_ssthresh(struct sock *sk) |
| 113 | { | 115 | { |
| 114 | const struct dctcp *ca = inet_csk_ca(sk); | 116 | struct dctcp *ca = inet_csk_ca(sk); |
| 115 | struct tcp_sock *tp = tcp_sk(sk); | 117 | struct tcp_sock *tp = tcp_sk(sk); |
| 116 | 118 | ||
| 119 | ca->loss_cwnd = tp->snd_cwnd; | ||
| 117 | return max(tp->snd_cwnd - ((tp->snd_cwnd * ca->dctcp_alpha) >> 11U), 2U); | 120 | return max(tp->snd_cwnd - ((tp->snd_cwnd * ca->dctcp_alpha) >> 11U), 2U); |
| 118 | } | 121 | } |
| 119 | 122 | ||
| @@ -308,12 +311,20 @@ static size_t dctcp_get_info(struct sock *sk, u32 ext, int *attr, | |||
| 308 | return 0; | 311 | return 0; |
| 309 | } | 312 | } |
| 310 | 313 | ||
| 314 | static u32 dctcp_cwnd_undo(struct sock *sk) | ||
| 315 | { | ||
| 316 | const struct dctcp *ca = inet_csk_ca(sk); | ||
| 317 | |||
| 318 | return max(tcp_sk(sk)->snd_cwnd, ca->loss_cwnd); | ||
| 319 | } | ||
| 320 | |||
| 311 | static struct tcp_congestion_ops dctcp __read_mostly = { | 321 | static struct tcp_congestion_ops dctcp __read_mostly = { |
| 312 | .init = dctcp_init, | 322 | .init = dctcp_init, |
| 313 | .in_ack_event = dctcp_update_alpha, | 323 | .in_ack_event = dctcp_update_alpha, |
| 314 | .cwnd_event = dctcp_cwnd_event, | 324 | .cwnd_event = dctcp_cwnd_event, |
| 315 | .ssthresh = dctcp_ssthresh, | 325 | .ssthresh = dctcp_ssthresh, |
| 316 | .cong_avoid = tcp_reno_cong_avoid, | 326 | .cong_avoid = tcp_reno_cong_avoid, |
| 327 | .undo_cwnd = dctcp_cwnd_undo, | ||
| 317 | .set_state = dctcp_state, | 328 | .set_state = dctcp_state, |
| 318 | .get_info = dctcp_get_info, | 329 | .get_info = dctcp_get_info, |
| 319 | .flags = TCP_CONG_NEEDS_ECN, | 330 | .flags = TCP_CONG_NEEDS_ECN, |
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index 61b7be303eec..2259114c7242 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c | |||
| @@ -1564,6 +1564,21 @@ bool tcp_add_backlog(struct sock *sk, struct sk_buff *skb) | |||
| 1564 | } | 1564 | } |
| 1565 | EXPORT_SYMBOL(tcp_add_backlog); | 1565 | EXPORT_SYMBOL(tcp_add_backlog); |
| 1566 | 1566 | ||
| 1567 | int tcp_filter(struct sock *sk, struct sk_buff *skb) | ||
| 1568 | { | ||
| 1569 | struct tcphdr *th = (struct tcphdr *)skb->data; | ||
| 1570 | unsigned int eaten = skb->len; | ||
| 1571 | int err; | ||
| 1572 | |||
| 1573 | err = sk_filter_trim_cap(sk, skb, th->doff * 4); | ||
| 1574 | if (!err) { | ||
| 1575 | eaten -= skb->len; | ||
| 1576 | TCP_SKB_CB(skb)->end_seq -= eaten; | ||
| 1577 | } | ||
| 1578 | return err; | ||
| 1579 | } | ||
| 1580 | EXPORT_SYMBOL(tcp_filter); | ||
| 1581 | |||
| 1567 | /* | 1582 | /* |
| 1568 | * From tcp_input.c | 1583 | * From tcp_input.c |
| 1569 | */ | 1584 | */ |
| @@ -1676,8 +1691,10 @@ process: | |||
| 1676 | 1691 | ||
| 1677 | nf_reset(skb); | 1692 | nf_reset(skb); |
| 1678 | 1693 | ||
| 1679 | if (sk_filter(sk, skb)) | 1694 | if (tcp_filter(sk, skb)) |
| 1680 | goto discard_and_relse; | 1695 | goto discard_and_relse; |
| 1696 | th = (const struct tcphdr *)skb->data; | ||
| 1697 | iph = ip_hdr(skb); | ||
| 1681 | 1698 | ||
| 1682 | skb->dev = NULL; | 1699 | skb->dev = NULL; |
| 1683 | 1700 | ||
diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c index bd59c343d35f..7370ad2e693a 100644 --- a/net/ipv6/icmp.c +++ b/net/ipv6/icmp.c | |||
| @@ -448,7 +448,7 @@ static void icmp6_send(struct sk_buff *skb, u8 type, u8 code, __u32 info, | |||
| 448 | if (__ipv6_addr_needs_scope_id(addr_type)) | 448 | if (__ipv6_addr_needs_scope_id(addr_type)) |
| 449 | iif = skb->dev->ifindex; | 449 | iif = skb->dev->ifindex; |
| 450 | else | 450 | else |
| 451 | iif = l3mdev_master_ifindex(skb->dev); | 451 | iif = l3mdev_master_ifindex(skb_dst(skb)->dev); |
| 452 | 452 | ||
| 453 | /* | 453 | /* |
| 454 | * Must not send error if the source does not uniquely | 454 | * Must not send error if the source does not uniquely |
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 6001e781164e..59eb4ed99ce8 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c | |||
| @@ -1366,7 +1366,7 @@ emsgsize: | |||
| 1366 | if (((length > mtu) || | 1366 | if (((length > mtu) || |
| 1367 | (skb && skb_is_gso(skb))) && | 1367 | (skb && skb_is_gso(skb))) && |
| 1368 | (sk->sk_protocol == IPPROTO_UDP) && | 1368 | (sk->sk_protocol == IPPROTO_UDP) && |
| 1369 | (rt->dst.dev->features & NETIF_F_UFO) && | 1369 | (rt->dst.dev->features & NETIF_F_UFO) && !rt->dst.header_len && |
| 1370 | (sk->sk_type == SOCK_DGRAM) && !udp_get_no_check6_tx(sk)) { | 1370 | (sk->sk_type == SOCK_DGRAM) && !udp_get_no_check6_tx(sk)) { |
| 1371 | err = ip6_ufo_append_data(sk, queue, getfrag, from, length, | 1371 | err = ip6_ufo_append_data(sk, queue, getfrag, from, length, |
| 1372 | hh_len, fragheaderlen, exthdrlen, | 1372 | hh_len, fragheaderlen, exthdrlen, |
diff --git a/net/ipv6/ip6_udp_tunnel.c b/net/ipv6/ip6_udp_tunnel.c index a7520528ecd2..b283f293ee4a 100644 --- a/net/ipv6/ip6_udp_tunnel.c +++ b/net/ipv6/ip6_udp_tunnel.c | |||
| @@ -88,9 +88,6 @@ int udp_tunnel6_xmit_skb(struct dst_entry *dst, struct sock *sk, | |||
| 88 | 88 | ||
| 89 | uh->len = htons(skb->len); | 89 | uh->len = htons(skb->len); |
| 90 | 90 | ||
| 91 | memset(&(IPCB(skb)->opt), 0, sizeof(IPCB(skb)->opt)); | ||
| 92 | IPCB(skb)->flags &= ~(IPSKB_XFRM_TUNNEL_SIZE | IPSKB_XFRM_TRANSFORMED | ||
| 93 | | IPSKB_REROUTED); | ||
| 94 | skb_dst_set(skb, dst); | 91 | skb_dst_set(skb, dst); |
| 95 | 92 | ||
| 96 | udp6_set_csum(nocheck, skb, saddr, daddr, skb->len); | 93 | udp6_set_csum(nocheck, skb, saddr, daddr, skb->len); |
diff --git a/net/ipv6/netfilter/nft_dup_ipv6.c b/net/ipv6/netfilter/nft_dup_ipv6.c index 8bfd470cbe72..831f86e1ec08 100644 --- a/net/ipv6/netfilter/nft_dup_ipv6.c +++ b/net/ipv6/netfilter/nft_dup_ipv6.c | |||
| @@ -26,7 +26,7 @@ static void nft_dup_ipv6_eval(const struct nft_expr *expr, | |||
| 26 | { | 26 | { |
| 27 | struct nft_dup_ipv6 *priv = nft_expr_priv(expr); | 27 | struct nft_dup_ipv6 *priv = nft_expr_priv(expr); |
| 28 | struct in6_addr *gw = (struct in6_addr *)®s->data[priv->sreg_addr]; | 28 | struct in6_addr *gw = (struct in6_addr *)®s->data[priv->sreg_addr]; |
| 29 | int oif = regs->data[priv->sreg_dev]; | 29 | int oif = priv->sreg_dev ? regs->data[priv->sreg_dev] : -1; |
| 30 | 30 | ||
| 31 | nf_dup_ipv6(pkt->net, pkt->skb, pkt->hook, gw, oif); | 31 | nf_dup_ipv6(pkt->net, pkt->skb, pkt->hook, gw, oif); |
| 32 | } | 32 | } |
| @@ -57,7 +57,9 @@ static int nft_dup_ipv6_dump(struct sk_buff *skb, const struct nft_expr *expr) | |||
| 57 | { | 57 | { |
| 58 | struct nft_dup_ipv6 *priv = nft_expr_priv(expr); | 58 | struct nft_dup_ipv6 *priv = nft_expr_priv(expr); |
| 59 | 59 | ||
| 60 | if (nft_dump_register(skb, NFTA_DUP_SREG_ADDR, priv->sreg_addr) || | 60 | if (nft_dump_register(skb, NFTA_DUP_SREG_ADDR, priv->sreg_addr)) |
| 61 | goto nla_put_failure; | ||
| 62 | if (priv->sreg_dev && | ||
| 61 | nft_dump_register(skb, NFTA_DUP_SREG_DEV, priv->sreg_dev)) | 63 | nft_dump_register(skb, NFTA_DUP_SREG_DEV, priv->sreg_dev)) |
| 62 | goto nla_put_failure; | 64 | goto nla_put_failure; |
| 63 | 65 | ||
diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 947ed1ded026..1b57e11e6e0d 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c | |||
| @@ -1364,6 +1364,9 @@ static void __ip6_rt_update_pmtu(struct dst_entry *dst, const struct sock *sk, | |||
| 1364 | if (rt6->rt6i_flags & RTF_LOCAL) | 1364 | if (rt6->rt6i_flags & RTF_LOCAL) |
| 1365 | return; | 1365 | return; |
| 1366 | 1366 | ||
| 1367 | if (dst_metric_locked(dst, RTAX_MTU)) | ||
| 1368 | return; | ||
| 1369 | |||
| 1367 | dst_confirm(dst); | 1370 | dst_confirm(dst); |
| 1368 | mtu = max_t(u32, mtu, IPV6_MIN_MTU); | 1371 | mtu = max_t(u32, mtu, IPV6_MIN_MTU); |
| 1369 | if (mtu >= dst_mtu(dst)) | 1372 | if (mtu >= dst_mtu(dst)) |
| @@ -2758,6 +2761,7 @@ static int rt6_mtu_change_route(struct rt6_info *rt, void *p_arg) | |||
| 2758 | PMTU discouvery. | 2761 | PMTU discouvery. |
| 2759 | */ | 2762 | */ |
| 2760 | if (rt->dst.dev == arg->dev && | 2763 | if (rt->dst.dev == arg->dev && |
| 2764 | dst_metric_raw(&rt->dst, RTAX_MTU) && | ||
| 2761 | !dst_metric_locked(&rt->dst, RTAX_MTU)) { | 2765 | !dst_metric_locked(&rt->dst, RTAX_MTU)) { |
| 2762 | if (rt->rt6i_flags & RTF_CACHE) { | 2766 | if (rt->rt6i_flags & RTF_CACHE) { |
| 2763 | /* For RTF_CACHE with rt6i_pmtu == 0 | 2767 | /* For RTF_CACHE with rt6i_pmtu == 0 |
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index 5a27ab4eab39..b9f1fee9a886 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c | |||
| @@ -818,8 +818,12 @@ static void tcp_v6_send_response(const struct sock *sk, struct sk_buff *skb, u32 | |||
| 818 | fl6.flowi6_proto = IPPROTO_TCP; | 818 | fl6.flowi6_proto = IPPROTO_TCP; |
| 819 | if (rt6_need_strict(&fl6.daddr) && !oif) | 819 | if (rt6_need_strict(&fl6.daddr) && !oif) |
| 820 | fl6.flowi6_oif = tcp_v6_iif(skb); | 820 | fl6.flowi6_oif = tcp_v6_iif(skb); |
| 821 | else | 821 | else { |
| 822 | fl6.flowi6_oif = oif ? : skb->skb_iif; | 822 | if (!oif && netif_index_is_l3_master(net, skb->skb_iif)) |
| 823 | oif = skb->skb_iif; | ||
| 824 | |||
| 825 | fl6.flowi6_oif = oif; | ||
| 826 | } | ||
| 823 | 827 | ||
| 824 | fl6.flowi6_mark = IP6_REPLY_MARK(net, skb->mark); | 828 | fl6.flowi6_mark = IP6_REPLY_MARK(net, skb->mark); |
| 825 | fl6.fl6_dport = t1->dest; | 829 | fl6.fl6_dport = t1->dest; |
| @@ -1225,7 +1229,7 @@ static int tcp_v6_do_rcv(struct sock *sk, struct sk_buff *skb) | |||
| 1225 | if (skb->protocol == htons(ETH_P_IP)) | 1229 | if (skb->protocol == htons(ETH_P_IP)) |
| 1226 | return tcp_v4_do_rcv(sk, skb); | 1230 | return tcp_v4_do_rcv(sk, skb); |
| 1227 | 1231 | ||
| 1228 | if (sk_filter(sk, skb)) | 1232 | if (tcp_filter(sk, skb)) |
| 1229 | goto discard; | 1233 | goto discard; |
| 1230 | 1234 | ||
| 1231 | /* | 1235 | /* |
| @@ -1453,8 +1457,10 @@ process: | |||
| 1453 | if (tcp_v6_inbound_md5_hash(sk, skb)) | 1457 | if (tcp_v6_inbound_md5_hash(sk, skb)) |
| 1454 | goto discard_and_relse; | 1458 | goto discard_and_relse; |
| 1455 | 1459 | ||
| 1456 | if (sk_filter(sk, skb)) | 1460 | if (tcp_filter(sk, skb)) |
| 1457 | goto discard_and_relse; | 1461 | goto discard_and_relse; |
| 1462 | th = (const struct tcphdr *)skb->data; | ||
| 1463 | hdr = ipv6_hdr(skb); | ||
| 1458 | 1464 | ||
| 1459 | skb->dev = NULL; | 1465 | skb->dev = NULL; |
| 1460 | 1466 | ||
diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c index c3c809b2e712..a6e44ef2ec9a 100644 --- a/net/netfilter/ipvs/ip_vs_ctl.c +++ b/net/netfilter/ipvs/ip_vs_ctl.c | |||
| @@ -2845,7 +2845,7 @@ static struct genl_family ip_vs_genl_family = { | |||
| 2845 | .hdrsize = 0, | 2845 | .hdrsize = 0, |
| 2846 | .name = IPVS_GENL_NAME, | 2846 | .name = IPVS_GENL_NAME, |
| 2847 | .version = IPVS_GENL_VERSION, | 2847 | .version = IPVS_GENL_VERSION, |
| 2848 | .maxattr = IPVS_CMD_MAX, | 2848 | .maxattr = IPVS_CMD_ATTR_MAX, |
| 2849 | .netnsok = true, /* Make ipvsadm to work on netns */ | 2849 | .netnsok = true, /* Make ipvsadm to work on netns */ |
| 2850 | }; | 2850 | }; |
| 2851 | 2851 | ||
diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c index 1b07578bedf3..9350530c16c1 100644 --- a/net/netfilter/ipvs/ip_vs_sync.c +++ b/net/netfilter/ipvs/ip_vs_sync.c | |||
| @@ -283,6 +283,7 @@ struct ip_vs_sync_buff { | |||
| 283 | */ | 283 | */ |
| 284 | static void ntoh_seq(struct ip_vs_seq *no, struct ip_vs_seq *ho) | 284 | static void ntoh_seq(struct ip_vs_seq *no, struct ip_vs_seq *ho) |
| 285 | { | 285 | { |
| 286 | memset(ho, 0, sizeof(*ho)); | ||
| 286 | ho->init_seq = get_unaligned_be32(&no->init_seq); | 287 | ho->init_seq = get_unaligned_be32(&no->init_seq); |
| 287 | ho->delta = get_unaligned_be32(&no->delta); | 288 | ho->delta = get_unaligned_be32(&no->delta); |
| 288 | ho->previous_delta = get_unaligned_be32(&no->previous_delta); | 289 | ho->previous_delta = get_unaligned_be32(&no->previous_delta); |
| @@ -917,8 +918,10 @@ static void ip_vs_proc_conn(struct netns_ipvs *ipvs, struct ip_vs_conn_param *pa | |||
| 917 | kfree(param->pe_data); | 918 | kfree(param->pe_data); |
| 918 | } | 919 | } |
| 919 | 920 | ||
| 920 | if (opt) | 921 | if (opt) { |
| 921 | memcpy(&cp->in_seq, opt, sizeof(*opt)); | 922 | cp->in_seq = opt->in_seq; |
| 923 | cp->out_seq = opt->out_seq; | ||
| 924 | } | ||
| 922 | atomic_set(&cp->in_pkts, sysctl_sync_threshold(ipvs)); | 925 | atomic_set(&cp->in_pkts, sysctl_sync_threshold(ipvs)); |
| 923 | cp->state = state; | 926 | cp->state = state; |
| 924 | cp->old_state = cp->state; | 927 | cp->old_state = cp->state; |
diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c index df2f5a3901df..0f87e5d21be7 100644 --- a/net/netfilter/nf_conntrack_core.c +++ b/net/netfilter/nf_conntrack_core.c | |||
| @@ -76,6 +76,7 @@ struct conntrack_gc_work { | |||
| 76 | struct delayed_work dwork; | 76 | struct delayed_work dwork; |
| 77 | u32 last_bucket; | 77 | u32 last_bucket; |
| 78 | bool exiting; | 78 | bool exiting; |
| 79 | long next_gc_run; | ||
| 79 | }; | 80 | }; |
| 80 | 81 | ||
| 81 | static __read_mostly struct kmem_cache *nf_conntrack_cachep; | 82 | static __read_mostly struct kmem_cache *nf_conntrack_cachep; |
| @@ -83,9 +84,11 @@ static __read_mostly spinlock_t nf_conntrack_locks_all_lock; | |||
| 83 | static __read_mostly DEFINE_SPINLOCK(nf_conntrack_locks_all_lock); | 84 | static __read_mostly DEFINE_SPINLOCK(nf_conntrack_locks_all_lock); |
| 84 | static __read_mostly bool nf_conntrack_locks_all; | 85 | static __read_mostly bool nf_conntrack_locks_all; |
| 85 | 86 | ||
| 87 | /* every gc cycle scans at most 1/GC_MAX_BUCKETS_DIV part of table */ | ||
| 86 | #define GC_MAX_BUCKETS_DIV 64u | 88 | #define GC_MAX_BUCKETS_DIV 64u |
| 87 | #define GC_MAX_BUCKETS 8192u | 89 | /* upper bound of scan intervals */ |
| 88 | #define GC_INTERVAL (5 * HZ) | 90 | #define GC_INTERVAL_MAX (2 * HZ) |
| 91 | /* maximum conntracks to evict per gc run */ | ||
| 89 | #define GC_MAX_EVICTS 256u | 92 | #define GC_MAX_EVICTS 256u |
| 90 | 93 | ||
| 91 | static struct conntrack_gc_work conntrack_gc_work; | 94 | static struct conntrack_gc_work conntrack_gc_work; |
| @@ -936,13 +939,13 @@ static noinline int early_drop(struct net *net, unsigned int _hash) | |||
| 936 | static void gc_worker(struct work_struct *work) | 939 | static void gc_worker(struct work_struct *work) |
| 937 | { | 940 | { |
| 938 | unsigned int i, goal, buckets = 0, expired_count = 0; | 941 | unsigned int i, goal, buckets = 0, expired_count = 0; |
| 939 | unsigned long next_run = GC_INTERVAL; | ||
| 940 | unsigned int ratio, scanned = 0; | ||
| 941 | struct conntrack_gc_work *gc_work; | 942 | struct conntrack_gc_work *gc_work; |
| 943 | unsigned int ratio, scanned = 0; | ||
| 944 | unsigned long next_run; | ||
| 942 | 945 | ||
| 943 | gc_work = container_of(work, struct conntrack_gc_work, dwork.work); | 946 | gc_work = container_of(work, struct conntrack_gc_work, dwork.work); |
| 944 | 947 | ||
| 945 | goal = min(nf_conntrack_htable_size / GC_MAX_BUCKETS_DIV, GC_MAX_BUCKETS); | 948 | goal = nf_conntrack_htable_size / GC_MAX_BUCKETS_DIV; |
| 946 | i = gc_work->last_bucket; | 949 | i = gc_work->last_bucket; |
| 947 | 950 | ||
| 948 | do { | 951 | do { |
| @@ -982,17 +985,47 @@ static void gc_worker(struct work_struct *work) | |||
| 982 | if (gc_work->exiting) | 985 | if (gc_work->exiting) |
| 983 | return; | 986 | return; |
| 984 | 987 | ||
| 988 | /* | ||
| 989 | * Eviction will normally happen from the packet path, and not | ||
| 990 | * from this gc worker. | ||
| 991 | * | ||
| 992 | * This worker is only here to reap expired entries when system went | ||
| 993 | * idle after a busy period. | ||
| 994 | * | ||
| 995 | * The heuristics below are supposed to balance conflicting goals: | ||
| 996 | * | ||
| 997 | * 1. Minimize time until we notice a stale entry | ||
| 998 | * 2. Maximize scan intervals to not waste cycles | ||
| 999 | * | ||
| 1000 | * Normally, expired_count will be 0, this increases the next_run time | ||
| 1001 | * to priorize 2) above. | ||
| 1002 | * | ||
| 1003 | * As soon as a timed-out entry is found, move towards 1) and increase | ||
| 1004 | * the scan frequency. | ||
| 1005 | * In case we have lots of evictions next scan is done immediately. | ||
| 1006 | */ | ||
| 985 | ratio = scanned ? expired_count * 100 / scanned : 0; | 1007 | ratio = scanned ? expired_count * 100 / scanned : 0; |
| 986 | if (ratio >= 90 || expired_count == GC_MAX_EVICTS) | 1008 | if (ratio >= 90 || expired_count == GC_MAX_EVICTS) { |
| 1009 | gc_work->next_gc_run = 0; | ||
| 987 | next_run = 0; | 1010 | next_run = 0; |
| 1011 | } else if (expired_count) { | ||
| 1012 | gc_work->next_gc_run /= 2U; | ||
| 1013 | next_run = msecs_to_jiffies(1); | ||
| 1014 | } else { | ||
| 1015 | if (gc_work->next_gc_run < GC_INTERVAL_MAX) | ||
| 1016 | gc_work->next_gc_run += msecs_to_jiffies(1); | ||
| 1017 | |||
| 1018 | next_run = gc_work->next_gc_run; | ||
| 1019 | } | ||
| 988 | 1020 | ||
| 989 | gc_work->last_bucket = i; | 1021 | gc_work->last_bucket = i; |
| 990 | schedule_delayed_work(&gc_work->dwork, next_run); | 1022 | queue_delayed_work(system_long_wq, &gc_work->dwork, next_run); |
| 991 | } | 1023 | } |
| 992 | 1024 | ||
| 993 | static void conntrack_gc_work_init(struct conntrack_gc_work *gc_work) | 1025 | static void conntrack_gc_work_init(struct conntrack_gc_work *gc_work) |
| 994 | { | 1026 | { |
| 995 | INIT_DELAYED_WORK(&gc_work->dwork, gc_worker); | 1027 | INIT_DELAYED_WORK(&gc_work->dwork, gc_worker); |
| 1028 | gc_work->next_gc_run = GC_INTERVAL_MAX; | ||
| 996 | gc_work->exiting = false; | 1029 | gc_work->exiting = false; |
| 997 | } | 1030 | } |
| 998 | 1031 | ||
| @@ -1885,7 +1918,7 @@ int nf_conntrack_init_start(void) | |||
| 1885 | nf_ct_untracked_status_or(IPS_CONFIRMED | IPS_UNTRACKED); | 1918 | nf_ct_untracked_status_or(IPS_CONFIRMED | IPS_UNTRACKED); |
| 1886 | 1919 | ||
| 1887 | conntrack_gc_work_init(&conntrack_gc_work); | 1920 | conntrack_gc_work_init(&conntrack_gc_work); |
| 1888 | schedule_delayed_work(&conntrack_gc_work.dwork, GC_INTERVAL); | 1921 | queue_delayed_work(system_long_wq, &conntrack_gc_work.dwork, GC_INTERVAL_MAX); |
| 1889 | 1922 | ||
| 1890 | return 0; | 1923 | return 0; |
| 1891 | 1924 | ||
diff --git a/net/netfilter/nf_conntrack_helper.c b/net/netfilter/nf_conntrack_helper.c index 336e21559e01..7341adf7059d 100644 --- a/net/netfilter/nf_conntrack_helper.c +++ b/net/netfilter/nf_conntrack_helper.c | |||
| @@ -138,9 +138,14 @@ __nf_conntrack_helper_find(const char *name, u16 l3num, u8 protonum) | |||
| 138 | 138 | ||
| 139 | for (i = 0; i < nf_ct_helper_hsize; i++) { | 139 | for (i = 0; i < nf_ct_helper_hsize; i++) { |
| 140 | hlist_for_each_entry_rcu(h, &nf_ct_helper_hash[i], hnode) { | 140 | hlist_for_each_entry_rcu(h, &nf_ct_helper_hash[i], hnode) { |
| 141 | if (!strcmp(h->name, name) && | 141 | if (strcmp(h->name, name)) |
| 142 | h->tuple.src.l3num == l3num && | 142 | continue; |
| 143 | h->tuple.dst.protonum == protonum) | 143 | |
| 144 | if (h->tuple.src.l3num != NFPROTO_UNSPEC && | ||
| 145 | h->tuple.src.l3num != l3num) | ||
| 146 | continue; | ||
| 147 | |||
| 148 | if (h->tuple.dst.protonum == protonum) | ||
| 144 | return h; | 149 | return h; |
| 145 | } | 150 | } |
| 146 | } | 151 | } |
diff --git a/net/netfilter/nf_conntrack_sip.c b/net/netfilter/nf_conntrack_sip.c index 621b81c7bddc..c3fc14e021ec 100644 --- a/net/netfilter/nf_conntrack_sip.c +++ b/net/netfilter/nf_conntrack_sip.c | |||
| @@ -1436,9 +1436,12 @@ static int process_sip_request(struct sk_buff *skb, unsigned int protoff, | |||
| 1436 | handler = &sip_handlers[i]; | 1436 | handler = &sip_handlers[i]; |
| 1437 | if (handler->request == NULL) | 1437 | if (handler->request == NULL) |
| 1438 | continue; | 1438 | continue; |
| 1439 | if (*datalen < handler->len || | 1439 | if (*datalen < handler->len + 2 || |
| 1440 | strncasecmp(*dptr, handler->method, handler->len)) | 1440 | strncasecmp(*dptr, handler->method, handler->len)) |
| 1441 | continue; | 1441 | continue; |
| 1442 | if ((*dptr)[handler->len] != ' ' || | ||
| 1443 | !isalpha((*dptr)[handler->len+1])) | ||
| 1444 | continue; | ||
| 1442 | 1445 | ||
| 1443 | if (ct_sip_get_header(ct, *dptr, 0, *datalen, SIP_HDR_CSEQ, | 1446 | if (ct_sip_get_header(ct, *dptr, 0, *datalen, SIP_HDR_CSEQ, |
| 1444 | &matchoff, &matchlen) <= 0) { | 1447 | &matchoff, &matchlen) <= 0) { |
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 24db22257586..026581b04ea8 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c | |||
| @@ -2956,12 +2956,14 @@ static int nf_tables_newset(struct net *net, struct sock *nlsk, | |||
| 2956 | 2956 | ||
| 2957 | err = nft_trans_set_add(&ctx, NFT_MSG_NEWSET, set); | 2957 | err = nft_trans_set_add(&ctx, NFT_MSG_NEWSET, set); |
| 2958 | if (err < 0) | 2958 | if (err < 0) |
| 2959 | goto err2; | 2959 | goto err3; |
| 2960 | 2960 | ||
| 2961 | list_add_tail_rcu(&set->list, &table->sets); | 2961 | list_add_tail_rcu(&set->list, &table->sets); |
| 2962 | table->use++; | 2962 | table->use++; |
| 2963 | return 0; | 2963 | return 0; |
| 2964 | 2964 | ||
| 2965 | err3: | ||
| 2966 | ops->destroy(set); | ||
| 2965 | err2: | 2967 | err2: |
| 2966 | kfree(set); | 2968 | kfree(set); |
| 2967 | err1: | 2969 | err1: |
| @@ -3452,14 +3454,15 @@ void *nft_set_elem_init(const struct nft_set *set, | |||
| 3452 | return elem; | 3454 | return elem; |
| 3453 | } | 3455 | } |
| 3454 | 3456 | ||
| 3455 | void nft_set_elem_destroy(const struct nft_set *set, void *elem) | 3457 | void nft_set_elem_destroy(const struct nft_set *set, void *elem, |
| 3458 | bool destroy_expr) | ||
| 3456 | { | 3459 | { |
| 3457 | struct nft_set_ext *ext = nft_set_elem_ext(set, elem); | 3460 | struct nft_set_ext *ext = nft_set_elem_ext(set, elem); |
| 3458 | 3461 | ||
| 3459 | nft_data_uninit(nft_set_ext_key(ext), NFT_DATA_VALUE); | 3462 | nft_data_uninit(nft_set_ext_key(ext), NFT_DATA_VALUE); |
| 3460 | if (nft_set_ext_exists(ext, NFT_SET_EXT_DATA)) | 3463 | if (nft_set_ext_exists(ext, NFT_SET_EXT_DATA)) |
| 3461 | nft_data_uninit(nft_set_ext_data(ext), set->dtype); | 3464 | nft_data_uninit(nft_set_ext_data(ext), set->dtype); |
| 3462 | if (nft_set_ext_exists(ext, NFT_SET_EXT_EXPR)) | 3465 | if (destroy_expr && nft_set_ext_exists(ext, NFT_SET_EXT_EXPR)) |
| 3463 | nf_tables_expr_destroy(NULL, nft_set_ext_expr(ext)); | 3466 | nf_tables_expr_destroy(NULL, nft_set_ext_expr(ext)); |
| 3464 | 3467 | ||
| 3465 | kfree(elem); | 3468 | kfree(elem); |
| @@ -3565,6 +3568,7 @@ static int nft_add_set_elem(struct nft_ctx *ctx, struct nft_set *set, | |||
| 3565 | dreg = nft_type_to_reg(set->dtype); | 3568 | dreg = nft_type_to_reg(set->dtype); |
| 3566 | list_for_each_entry(binding, &set->bindings, list) { | 3569 | list_for_each_entry(binding, &set->bindings, list) { |
| 3567 | struct nft_ctx bind_ctx = { | 3570 | struct nft_ctx bind_ctx = { |
| 3571 | .net = ctx->net, | ||
| 3568 | .afi = ctx->afi, | 3572 | .afi = ctx->afi, |
| 3569 | .table = ctx->table, | 3573 | .table = ctx->table, |
| 3570 | .chain = (struct nft_chain *)binding->chain, | 3574 | .chain = (struct nft_chain *)binding->chain, |
| @@ -3812,7 +3816,7 @@ void nft_set_gc_batch_release(struct rcu_head *rcu) | |||
| 3812 | 3816 | ||
| 3813 | gcb = container_of(rcu, struct nft_set_gc_batch, head.rcu); | 3817 | gcb = container_of(rcu, struct nft_set_gc_batch, head.rcu); |
| 3814 | for (i = 0; i < gcb->head.cnt; i++) | 3818 | for (i = 0; i < gcb->head.cnt; i++) |
| 3815 | nft_set_elem_destroy(gcb->head.set, gcb->elems[i]); | 3819 | nft_set_elem_destroy(gcb->head.set, gcb->elems[i], true); |
| 3816 | kfree(gcb); | 3820 | kfree(gcb); |
| 3817 | } | 3821 | } |
| 3818 | EXPORT_SYMBOL_GPL(nft_set_gc_batch_release); | 3822 | EXPORT_SYMBOL_GPL(nft_set_gc_batch_release); |
| @@ -4030,7 +4034,7 @@ static void nf_tables_commit_release(struct nft_trans *trans) | |||
| 4030 | break; | 4034 | break; |
| 4031 | case NFT_MSG_DELSETELEM: | 4035 | case NFT_MSG_DELSETELEM: |
| 4032 | nft_set_elem_destroy(nft_trans_elem_set(trans), | 4036 | nft_set_elem_destroy(nft_trans_elem_set(trans), |
| 4033 | nft_trans_elem(trans).priv); | 4037 | nft_trans_elem(trans).priv, true); |
| 4034 | break; | 4038 | break; |
| 4035 | } | 4039 | } |
| 4036 | kfree(trans); | 4040 | kfree(trans); |
| @@ -4171,7 +4175,7 @@ static void nf_tables_abort_release(struct nft_trans *trans) | |||
| 4171 | break; | 4175 | break; |
| 4172 | case NFT_MSG_NEWSETELEM: | 4176 | case NFT_MSG_NEWSETELEM: |
| 4173 | nft_set_elem_destroy(nft_trans_elem_set(trans), | 4177 | nft_set_elem_destroy(nft_trans_elem_set(trans), |
| 4174 | nft_trans_elem(trans).priv); | 4178 | nft_trans_elem(trans).priv, true); |
| 4175 | break; | 4179 | break; |
| 4176 | } | 4180 | } |
| 4177 | kfree(trans); | 4181 | kfree(trans); |
| @@ -4421,7 +4425,7 @@ static int nf_tables_check_loops(const struct nft_ctx *ctx, | |||
| 4421 | * Otherwise a 0 is returned and the attribute value is stored in the | 4425 | * Otherwise a 0 is returned and the attribute value is stored in the |
| 4422 | * destination variable. | 4426 | * destination variable. |
| 4423 | */ | 4427 | */ |
| 4424 | unsigned int nft_parse_u32_check(const struct nlattr *attr, int max, u32 *dest) | 4428 | int nft_parse_u32_check(const struct nlattr *attr, int max, u32 *dest) |
| 4425 | { | 4429 | { |
| 4426 | u32 val; | 4430 | u32 val; |
| 4427 | 4431 | ||
diff --git a/net/netfilter/nft_dynset.c b/net/netfilter/nft_dynset.c index 517f08767a3c..31ca94793aa9 100644 --- a/net/netfilter/nft_dynset.c +++ b/net/netfilter/nft_dynset.c | |||
| @@ -44,18 +44,22 @@ static void *nft_dynset_new(struct nft_set *set, const struct nft_expr *expr, | |||
| 44 | ®s->data[priv->sreg_key], | 44 | ®s->data[priv->sreg_key], |
| 45 | ®s->data[priv->sreg_data], | 45 | ®s->data[priv->sreg_data], |
| 46 | timeout, GFP_ATOMIC); | 46 | timeout, GFP_ATOMIC); |
| 47 | if (elem == NULL) { | 47 | if (elem == NULL) |
| 48 | if (set->size) | 48 | goto err1; |
| 49 | atomic_dec(&set->nelems); | ||
| 50 | return NULL; | ||
| 51 | } | ||
| 52 | 49 | ||
| 53 | ext = nft_set_elem_ext(set, elem); | 50 | ext = nft_set_elem_ext(set, elem); |
| 54 | if (priv->expr != NULL && | 51 | if (priv->expr != NULL && |
| 55 | nft_expr_clone(nft_set_ext_expr(ext), priv->expr) < 0) | 52 | nft_expr_clone(nft_set_ext_expr(ext), priv->expr) < 0) |
| 56 | return NULL; | 53 | goto err2; |
| 57 | 54 | ||
| 58 | return elem; | 55 | return elem; |
| 56 | |||
| 57 | err2: | ||
| 58 | nft_set_elem_destroy(set, elem, false); | ||
| 59 | err1: | ||
| 60 | if (set->size) | ||
| 61 | atomic_dec(&set->nelems); | ||
| 62 | return NULL; | ||
| 59 | } | 63 | } |
| 60 | 64 | ||
| 61 | static void nft_dynset_eval(const struct nft_expr *expr, | 65 | static void nft_dynset_eval(const struct nft_expr *expr, |
| @@ -139,6 +143,9 @@ static int nft_dynset_init(const struct nft_ctx *ctx, | |||
| 139 | return PTR_ERR(set); | 143 | return PTR_ERR(set); |
| 140 | } | 144 | } |
| 141 | 145 | ||
| 146 | if (set->ops->update == NULL) | ||
| 147 | return -EOPNOTSUPP; | ||
| 148 | |||
| 142 | if (set->flags & NFT_SET_CONSTANT) | 149 | if (set->flags & NFT_SET_CONSTANT) |
| 143 | return -EBUSY; | 150 | return -EBUSY; |
| 144 | 151 | ||
diff --git a/net/netfilter/nft_set_hash.c b/net/netfilter/nft_set_hash.c index 3794cb2fc788..a3dface3e6e6 100644 --- a/net/netfilter/nft_set_hash.c +++ b/net/netfilter/nft_set_hash.c | |||
| @@ -98,7 +98,7 @@ static bool nft_hash_update(struct nft_set *set, const u32 *key, | |||
| 98 | const struct nft_set_ext **ext) | 98 | const struct nft_set_ext **ext) |
| 99 | { | 99 | { |
| 100 | struct nft_hash *priv = nft_set_priv(set); | 100 | struct nft_hash *priv = nft_set_priv(set); |
| 101 | struct nft_hash_elem *he; | 101 | struct nft_hash_elem *he, *prev; |
| 102 | struct nft_hash_cmp_arg arg = { | 102 | struct nft_hash_cmp_arg arg = { |
| 103 | .genmask = NFT_GENMASK_ANY, | 103 | .genmask = NFT_GENMASK_ANY, |
| 104 | .set = set, | 104 | .set = set, |
| @@ -112,15 +112,24 @@ static bool nft_hash_update(struct nft_set *set, const u32 *key, | |||
| 112 | he = new(set, expr, regs); | 112 | he = new(set, expr, regs); |
| 113 | if (he == NULL) | 113 | if (he == NULL) |
| 114 | goto err1; | 114 | goto err1; |
| 115 | if (rhashtable_lookup_insert_key(&priv->ht, &arg, &he->node, | 115 | |
| 116 | nft_hash_params)) | 116 | prev = rhashtable_lookup_get_insert_key(&priv->ht, &arg, &he->node, |
| 117 | nft_hash_params); | ||
| 118 | if (IS_ERR(prev)) | ||
| 117 | goto err2; | 119 | goto err2; |
| 120 | |||
| 121 | /* Another cpu may race to insert the element with the same key */ | ||
| 122 | if (prev) { | ||
| 123 | nft_set_elem_destroy(set, he, true); | ||
| 124 | he = prev; | ||
| 125 | } | ||
| 126 | |||
| 118 | out: | 127 | out: |
| 119 | *ext = &he->ext; | 128 | *ext = &he->ext; |
| 120 | return true; | 129 | return true; |
| 121 | 130 | ||
| 122 | err2: | 131 | err2: |
| 123 | nft_set_elem_destroy(set, he); | 132 | nft_set_elem_destroy(set, he, true); |
| 124 | err1: | 133 | err1: |
| 125 | return false; | 134 | return false; |
| 126 | } | 135 | } |
| @@ -332,7 +341,7 @@ static int nft_hash_init(const struct nft_set *set, | |||
| 332 | 341 | ||
| 333 | static void nft_hash_elem_destroy(void *ptr, void *arg) | 342 | static void nft_hash_elem_destroy(void *ptr, void *arg) |
| 334 | { | 343 | { |
| 335 | nft_set_elem_destroy((const struct nft_set *)arg, ptr); | 344 | nft_set_elem_destroy((const struct nft_set *)arg, ptr, true); |
| 336 | } | 345 | } |
| 337 | 346 | ||
| 338 | static void nft_hash_destroy(const struct nft_set *set) | 347 | static void nft_hash_destroy(const struct nft_set *set) |
diff --git a/net/netfilter/nft_set_rbtree.c b/net/netfilter/nft_set_rbtree.c index 38b5bda242f8..36493a7cae88 100644 --- a/net/netfilter/nft_set_rbtree.c +++ b/net/netfilter/nft_set_rbtree.c | |||
| @@ -266,7 +266,7 @@ static void nft_rbtree_destroy(const struct nft_set *set) | |||
| 266 | while ((node = priv->root.rb_node) != NULL) { | 266 | while ((node = priv->root.rb_node) != NULL) { |
| 267 | rb_erase(node, &priv->root); | 267 | rb_erase(node, &priv->root); |
| 268 | rbe = rb_entry(node, struct nft_rbtree_elem, node); | 268 | rbe = rb_entry(node, struct nft_rbtree_elem, node); |
| 269 | nft_set_elem_destroy(set, rbe); | 269 | nft_set_elem_destroy(set, rbe, true); |
| 270 | } | 270 | } |
| 271 | } | 271 | } |
| 272 | 272 | ||
diff --git a/net/netfilter/xt_connmark.c b/net/netfilter/xt_connmark.c index 69f78e96fdb4..b83e158e116a 100644 --- a/net/netfilter/xt_connmark.c +++ b/net/netfilter/xt_connmark.c | |||
| @@ -44,7 +44,7 @@ connmark_tg(struct sk_buff *skb, const struct xt_action_param *par) | |||
| 44 | u_int32_t newmark; | 44 | u_int32_t newmark; |
| 45 | 45 | ||
| 46 | ct = nf_ct_get(skb, &ctinfo); | 46 | ct = nf_ct_get(skb, &ctinfo); |
| 47 | if (ct == NULL) | 47 | if (ct == NULL || nf_ct_is_untracked(ct)) |
| 48 | return XT_CONTINUE; | 48 | return XT_CONTINUE; |
| 49 | 49 | ||
| 50 | switch (info->mode) { | 50 | switch (info->mode) { |
| @@ -97,7 +97,7 @@ connmark_mt(const struct sk_buff *skb, struct xt_action_param *par) | |||
| 97 | const struct nf_conn *ct; | 97 | const struct nf_conn *ct; |
| 98 | 98 | ||
| 99 | ct = nf_ct_get(skb, &ctinfo); | 99 | ct = nf_ct_get(skb, &ctinfo); |
| 100 | if (ct == NULL) | 100 | if (ct == NULL || nf_ct_is_untracked(ct)) |
| 101 | return false; | 101 | return false; |
| 102 | 102 | ||
| 103 | return ((ct->mark & info->mask) == info->mark) ^ info->invert; | 103 | return ((ct->mark & info->mask) == info->mark) ^ info->invert; |
diff --git a/net/netlink/diag.c b/net/netlink/diag.c index b2f0e986a6f4..a5546249fb10 100644 --- a/net/netlink/diag.c +++ b/net/netlink/diag.c | |||
| @@ -178,11 +178,8 @@ static int netlink_diag_dump(struct sk_buff *skb, struct netlink_callback *cb) | |||
| 178 | } | 178 | } |
| 179 | cb->args[1] = i; | 179 | cb->args[1] = i; |
| 180 | } else { | 180 | } else { |
| 181 | if (req->sdiag_protocol >= MAX_LINKS) { | 181 | if (req->sdiag_protocol >= MAX_LINKS) |
| 182 | read_unlock(&nl_table_lock); | ||
| 183 | rcu_read_unlock(); | ||
| 184 | return -ENOENT; | 182 | return -ENOENT; |
| 185 | } | ||
| 186 | 183 | ||
| 187 | err = __netlink_diag_dump(skb, cb, req->sdiag_protocol, s_num); | 184 | err = __netlink_diag_dump(skb, cb, req->sdiag_protocol, s_num); |
| 188 | } | 185 | } |
diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c index 23cc12639ba7..49c28e8ef01b 100644 --- a/net/netlink/genetlink.c +++ b/net/netlink/genetlink.c | |||
| @@ -404,7 +404,7 @@ int __genl_register_family(struct genl_family *family) | |||
| 404 | 404 | ||
| 405 | err = genl_validate_assign_mc_groups(family); | 405 | err = genl_validate_assign_mc_groups(family); |
| 406 | if (err) | 406 | if (err) |
| 407 | goto errout_locked; | 407 | goto errout_free; |
| 408 | 408 | ||
| 409 | list_add_tail(&family->family_list, genl_family_chain(family->id)); | 409 | list_add_tail(&family->family_list, genl_family_chain(family->id)); |
| 410 | genl_unlock_all(); | 410 | genl_unlock_all(); |
| @@ -417,6 +417,8 @@ int __genl_register_family(struct genl_family *family) | |||
| 417 | 417 | ||
| 418 | return 0; | 418 | return 0; |
| 419 | 419 | ||
| 420 | errout_free: | ||
| 421 | kfree(family->attrbuf); | ||
| 420 | errout_locked: | 422 | errout_locked: |
| 421 | genl_unlock_all(); | 423 | genl_unlock_all(); |
| 422 | errout: | 424 | errout: |
diff --git a/net/sctp/input.c b/net/sctp/input.c index a2ea1d1cc06a..a01a56ec8b8c 100644 --- a/net/sctp/input.c +++ b/net/sctp/input.c | |||
| @@ -181,9 +181,10 @@ int sctp_rcv(struct sk_buff *skb) | |||
| 181 | * bound to another interface, via SO_BINDTODEVICE, treat it as OOTB | 181 | * bound to another interface, via SO_BINDTODEVICE, treat it as OOTB |
| 182 | */ | 182 | */ |
| 183 | if (sk->sk_bound_dev_if && (sk->sk_bound_dev_if != af->skb_iif(skb))) { | 183 | if (sk->sk_bound_dev_if && (sk->sk_bound_dev_if != af->skb_iif(skb))) { |
| 184 | if (asoc) { | 184 | if (transport) { |
| 185 | sctp_association_put(asoc); | 185 | sctp_transport_put(transport); |
| 186 | asoc = NULL; | 186 | asoc = NULL; |
| 187 | transport = NULL; | ||
| 187 | } else { | 188 | } else { |
| 188 | sctp_endpoint_put(ep); | 189 | sctp_endpoint_put(ep); |
| 189 | ep = NULL; | 190 | ep = NULL; |
| @@ -269,8 +270,8 @@ int sctp_rcv(struct sk_buff *skb) | |||
| 269 | bh_unlock_sock(sk); | 270 | bh_unlock_sock(sk); |
| 270 | 271 | ||
| 271 | /* Release the asoc/ep ref we took in the lookup calls. */ | 272 | /* Release the asoc/ep ref we took in the lookup calls. */ |
| 272 | if (asoc) | 273 | if (transport) |
| 273 | sctp_association_put(asoc); | 274 | sctp_transport_put(transport); |
| 274 | else | 275 | else |
| 275 | sctp_endpoint_put(ep); | 276 | sctp_endpoint_put(ep); |
| 276 | 277 | ||
| @@ -283,8 +284,8 @@ discard_it: | |||
| 283 | 284 | ||
| 284 | discard_release: | 285 | discard_release: |
| 285 | /* Release the asoc/ep ref we took in the lookup calls. */ | 286 | /* Release the asoc/ep ref we took in the lookup calls. */ |
| 286 | if (asoc) | 287 | if (transport) |
| 287 | sctp_association_put(asoc); | 288 | sctp_transport_put(transport); |
| 288 | else | 289 | else |
| 289 | sctp_endpoint_put(ep); | 290 | sctp_endpoint_put(ep); |
| 290 | 291 | ||
| @@ -300,6 +301,7 @@ int sctp_backlog_rcv(struct sock *sk, struct sk_buff *skb) | |||
| 300 | { | 301 | { |
| 301 | struct sctp_chunk *chunk = SCTP_INPUT_CB(skb)->chunk; | 302 | struct sctp_chunk *chunk = SCTP_INPUT_CB(skb)->chunk; |
| 302 | struct sctp_inq *inqueue = &chunk->rcvr->inqueue; | 303 | struct sctp_inq *inqueue = &chunk->rcvr->inqueue; |
| 304 | struct sctp_transport *t = chunk->transport; | ||
| 303 | struct sctp_ep_common *rcvr = NULL; | 305 | struct sctp_ep_common *rcvr = NULL; |
| 304 | int backloged = 0; | 306 | int backloged = 0; |
| 305 | 307 | ||
| @@ -351,7 +353,7 @@ int sctp_backlog_rcv(struct sock *sk, struct sk_buff *skb) | |||
| 351 | done: | 353 | done: |
| 352 | /* Release the refs we took in sctp_add_backlog */ | 354 | /* Release the refs we took in sctp_add_backlog */ |
| 353 | if (SCTP_EP_TYPE_ASSOCIATION == rcvr->type) | 355 | if (SCTP_EP_TYPE_ASSOCIATION == rcvr->type) |
| 354 | sctp_association_put(sctp_assoc(rcvr)); | 356 | sctp_transport_put(t); |
| 355 | else if (SCTP_EP_TYPE_SOCKET == rcvr->type) | 357 | else if (SCTP_EP_TYPE_SOCKET == rcvr->type) |
| 356 | sctp_endpoint_put(sctp_ep(rcvr)); | 358 | sctp_endpoint_put(sctp_ep(rcvr)); |
| 357 | else | 359 | else |
| @@ -363,6 +365,7 @@ done: | |||
| 363 | static int sctp_add_backlog(struct sock *sk, struct sk_buff *skb) | 365 | static int sctp_add_backlog(struct sock *sk, struct sk_buff *skb) |
| 364 | { | 366 | { |
| 365 | struct sctp_chunk *chunk = SCTP_INPUT_CB(skb)->chunk; | 367 | struct sctp_chunk *chunk = SCTP_INPUT_CB(skb)->chunk; |
| 368 | struct sctp_transport *t = chunk->transport; | ||
| 366 | struct sctp_ep_common *rcvr = chunk->rcvr; | 369 | struct sctp_ep_common *rcvr = chunk->rcvr; |
| 367 | int ret; | 370 | int ret; |
| 368 | 371 | ||
| @@ -373,7 +376,7 @@ static int sctp_add_backlog(struct sock *sk, struct sk_buff *skb) | |||
| 373 | * from us | 376 | * from us |
| 374 | */ | 377 | */ |
| 375 | if (SCTP_EP_TYPE_ASSOCIATION == rcvr->type) | 378 | if (SCTP_EP_TYPE_ASSOCIATION == rcvr->type) |
| 376 | sctp_association_hold(sctp_assoc(rcvr)); | 379 | sctp_transport_hold(t); |
| 377 | else if (SCTP_EP_TYPE_SOCKET == rcvr->type) | 380 | else if (SCTP_EP_TYPE_SOCKET == rcvr->type) |
| 378 | sctp_endpoint_hold(sctp_ep(rcvr)); | 381 | sctp_endpoint_hold(sctp_ep(rcvr)); |
| 379 | else | 382 | else |
| @@ -537,15 +540,15 @@ struct sock *sctp_err_lookup(struct net *net, int family, struct sk_buff *skb, | |||
| 537 | return sk; | 540 | return sk; |
| 538 | 541 | ||
| 539 | out: | 542 | out: |
| 540 | sctp_association_put(asoc); | 543 | sctp_transport_put(transport); |
| 541 | return NULL; | 544 | return NULL; |
| 542 | } | 545 | } |
| 543 | 546 | ||
| 544 | /* Common cleanup code for icmp/icmpv6 error handler. */ | 547 | /* Common cleanup code for icmp/icmpv6 error handler. */ |
| 545 | void sctp_err_finish(struct sock *sk, struct sctp_association *asoc) | 548 | void sctp_err_finish(struct sock *sk, struct sctp_transport *t) |
| 546 | { | 549 | { |
| 547 | bh_unlock_sock(sk); | 550 | bh_unlock_sock(sk); |
| 548 | sctp_association_put(asoc); | 551 | sctp_transport_put(t); |
| 549 | } | 552 | } |
| 550 | 553 | ||
| 551 | /* | 554 | /* |
| @@ -641,7 +644,7 @@ void sctp_v4_err(struct sk_buff *skb, __u32 info) | |||
| 641 | } | 644 | } |
| 642 | 645 | ||
| 643 | out_unlock: | 646 | out_unlock: |
| 644 | sctp_err_finish(sk, asoc); | 647 | sctp_err_finish(sk, transport); |
| 645 | } | 648 | } |
| 646 | 649 | ||
| 647 | /* | 650 | /* |
| @@ -952,11 +955,8 @@ static struct sctp_association *__sctp_lookup_association( | |||
| 952 | goto out; | 955 | goto out; |
| 953 | 956 | ||
| 954 | asoc = t->asoc; | 957 | asoc = t->asoc; |
| 955 | sctp_association_hold(asoc); | ||
| 956 | *pt = t; | 958 | *pt = t; |
| 957 | 959 | ||
| 958 | sctp_transport_put(t); | ||
| 959 | |||
| 960 | out: | 960 | out: |
| 961 | return asoc; | 961 | return asoc; |
| 962 | } | 962 | } |
| @@ -986,7 +986,7 @@ int sctp_has_association(struct net *net, | |||
| 986 | struct sctp_transport *transport; | 986 | struct sctp_transport *transport; |
| 987 | 987 | ||
| 988 | if ((asoc = sctp_lookup_association(net, laddr, paddr, &transport))) { | 988 | if ((asoc = sctp_lookup_association(net, laddr, paddr, &transport))) { |
| 989 | sctp_association_put(asoc); | 989 | sctp_transport_put(transport); |
| 990 | return 1; | 990 | return 1; |
| 991 | } | 991 | } |
| 992 | 992 | ||
| @@ -1021,7 +1021,6 @@ static struct sctp_association *__sctp_rcv_init_lookup(struct net *net, | |||
| 1021 | struct sctphdr *sh = sctp_hdr(skb); | 1021 | struct sctphdr *sh = sctp_hdr(skb); |
| 1022 | union sctp_params params; | 1022 | union sctp_params params; |
| 1023 | sctp_init_chunk_t *init; | 1023 | sctp_init_chunk_t *init; |
| 1024 | struct sctp_transport *transport; | ||
| 1025 | struct sctp_af *af; | 1024 | struct sctp_af *af; |
| 1026 | 1025 | ||
| 1027 | /* | 1026 | /* |
| @@ -1052,7 +1051,7 @@ static struct sctp_association *__sctp_rcv_init_lookup(struct net *net, | |||
| 1052 | 1051 | ||
| 1053 | af->from_addr_param(paddr, params.addr, sh->source, 0); | 1052 | af->from_addr_param(paddr, params.addr, sh->source, 0); |
| 1054 | 1053 | ||
| 1055 | asoc = __sctp_lookup_association(net, laddr, paddr, &transport); | 1054 | asoc = __sctp_lookup_association(net, laddr, paddr, transportp); |
| 1056 | if (asoc) | 1055 | if (asoc) |
| 1057 | return asoc; | 1056 | return asoc; |
| 1058 | } | 1057 | } |
diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c index f473779e8b1c..176af3080a2b 100644 --- a/net/sctp/ipv6.c +++ b/net/sctp/ipv6.c | |||
| @@ -198,7 +198,7 @@ static void sctp_v6_err(struct sk_buff *skb, struct inet6_skb_parm *opt, | |||
| 198 | } | 198 | } |
| 199 | 199 | ||
| 200 | out_unlock: | 200 | out_unlock: |
| 201 | sctp_err_finish(sk, asoc); | 201 | sctp_err_finish(sk, transport); |
| 202 | out: | 202 | out: |
| 203 | if (likely(idev != NULL)) | 203 | if (likely(idev != NULL)) |
| 204 | in6_dev_put(idev); | 204 | in6_dev_put(idev); |
diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 9fbb6feb8c27..f23ad913dc7a 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c | |||
| @@ -1214,9 +1214,12 @@ static int __sctp_connect(struct sock *sk, | |||
| 1214 | 1214 | ||
| 1215 | timeo = sock_sndtimeo(sk, f_flags & O_NONBLOCK); | 1215 | timeo = sock_sndtimeo(sk, f_flags & O_NONBLOCK); |
| 1216 | 1216 | ||
| 1217 | err = sctp_wait_for_connect(asoc, &timeo); | 1217 | if (assoc_id) |
| 1218 | if ((err == 0 || err == -EINPROGRESS) && assoc_id) | ||
| 1219 | *assoc_id = asoc->assoc_id; | 1218 | *assoc_id = asoc->assoc_id; |
| 1219 | err = sctp_wait_for_connect(asoc, &timeo); | ||
| 1220 | /* Note: the asoc may be freed after the return of | ||
| 1221 | * sctp_wait_for_connect. | ||
| 1222 | */ | ||
| 1220 | 1223 | ||
| 1221 | /* Don't free association on exit. */ | 1224 | /* Don't free association on exit. */ |
| 1222 | asoc = NULL; | 1225 | asoc = NULL; |
| @@ -4282,19 +4285,18 @@ static void sctp_shutdown(struct sock *sk, int how) | |||
| 4282 | { | 4285 | { |
| 4283 | struct net *net = sock_net(sk); | 4286 | struct net *net = sock_net(sk); |
| 4284 | struct sctp_endpoint *ep; | 4287 | struct sctp_endpoint *ep; |
| 4285 | struct sctp_association *asoc; | ||
| 4286 | 4288 | ||
| 4287 | if (!sctp_style(sk, TCP)) | 4289 | if (!sctp_style(sk, TCP)) |
| 4288 | return; | 4290 | return; |
| 4289 | 4291 | ||
| 4290 | if (how & SEND_SHUTDOWN) { | 4292 | ep = sctp_sk(sk)->ep; |
| 4293 | if (how & SEND_SHUTDOWN && !list_empty(&ep->asocs)) { | ||
| 4294 | struct sctp_association *asoc; | ||
| 4295 | |||
| 4291 | sk->sk_state = SCTP_SS_CLOSING; | 4296 | sk->sk_state = SCTP_SS_CLOSING; |
| 4292 | ep = sctp_sk(sk)->ep; | 4297 | asoc = list_entry(ep->asocs.next, |
| 4293 | if (!list_empty(&ep->asocs)) { | 4298 | struct sctp_association, asocs); |
| 4294 | asoc = list_entry(ep->asocs.next, | 4299 | sctp_primitive_SHUTDOWN(net, asoc, NULL); |
| 4295 | struct sctp_association, asocs); | ||
| 4296 | sctp_primitive_SHUTDOWN(net, asoc, NULL); | ||
| 4297 | } | ||
| 4298 | } | 4300 | } |
| 4299 | } | 4301 | } |
| 4300 | 4302 | ||
| @@ -4480,12 +4482,9 @@ int sctp_transport_lookup_process(int (*cb)(struct sctp_transport *, void *), | |||
| 4480 | if (!transport || !sctp_transport_hold(transport)) | 4482 | if (!transport || !sctp_transport_hold(transport)) |
| 4481 | goto out; | 4483 | goto out; |
| 4482 | 4484 | ||
| 4483 | sctp_association_hold(transport->asoc); | ||
| 4484 | sctp_transport_put(transport); | ||
| 4485 | |||
| 4486 | rcu_read_unlock(); | 4485 | rcu_read_unlock(); |
| 4487 | err = cb(transport, p); | 4486 | err = cb(transport, p); |
| 4488 | sctp_association_put(transport->asoc); | 4487 | sctp_transport_put(transport); |
| 4489 | 4488 | ||
| 4490 | out: | 4489 | out: |
| 4491 | return err; | 4490 | return err; |
diff --git a/net/socket.c b/net/socket.c index 5a9bf5ee2464..73dc69f9681e 100644 --- a/net/socket.c +++ b/net/socket.c | |||
| @@ -341,8 +341,23 @@ static const struct xattr_handler sockfs_xattr_handler = { | |||
| 341 | .get = sockfs_xattr_get, | 341 | .get = sockfs_xattr_get, |
| 342 | }; | 342 | }; |
| 343 | 343 | ||
| 344 | static int sockfs_security_xattr_set(const struct xattr_handler *handler, | ||
| 345 | struct dentry *dentry, struct inode *inode, | ||
| 346 | const char *suffix, const void *value, | ||
| 347 | size_t size, int flags) | ||
| 348 | { | ||
| 349 | /* Handled by LSM. */ | ||
| 350 | return -EAGAIN; | ||
| 351 | } | ||
| 352 | |||
| 353 | static const struct xattr_handler sockfs_security_xattr_handler = { | ||
| 354 | .prefix = XATTR_SECURITY_PREFIX, | ||
| 355 | .set = sockfs_security_xattr_set, | ||
| 356 | }; | ||
| 357 | |||
| 344 | static const struct xattr_handler *sockfs_xattr_handlers[] = { | 358 | static const struct xattr_handler *sockfs_xattr_handlers[] = { |
| 345 | &sockfs_xattr_handler, | 359 | &sockfs_xattr_handler, |
| 360 | &sockfs_security_xattr_handler, | ||
| 346 | NULL | 361 | NULL |
| 347 | }; | 362 | }; |
| 348 | 363 | ||
| @@ -2038,6 +2053,8 @@ int __sys_sendmmsg(int fd, struct mmsghdr __user *mmsg, unsigned int vlen, | |||
| 2038 | if (err) | 2053 | if (err) |
| 2039 | break; | 2054 | break; |
| 2040 | ++datagrams; | 2055 | ++datagrams; |
| 2056 | if (msg_data_left(&msg_sys)) | ||
| 2057 | break; | ||
| 2041 | cond_resched(); | 2058 | cond_resched(); |
| 2042 | } | 2059 | } |
| 2043 | 2060 | ||
diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c index c3f652395a80..3bc1d61694cb 100644 --- a/net/sunrpc/svc_xprt.c +++ b/net/sunrpc/svc_xprt.c | |||
| @@ -1002,14 +1002,8 @@ static void svc_age_temp_xprts(unsigned long closure) | |||
| 1002 | void svc_age_temp_xprts_now(struct svc_serv *serv, struct sockaddr *server_addr) | 1002 | void svc_age_temp_xprts_now(struct svc_serv *serv, struct sockaddr *server_addr) |
| 1003 | { | 1003 | { |
| 1004 | struct svc_xprt *xprt; | 1004 | struct svc_xprt *xprt; |
| 1005 | struct svc_sock *svsk; | ||
| 1006 | struct socket *sock; | ||
| 1007 | struct list_head *le, *next; | 1005 | struct list_head *le, *next; |
| 1008 | LIST_HEAD(to_be_closed); | 1006 | LIST_HEAD(to_be_closed); |
| 1009 | struct linger no_linger = { | ||
| 1010 | .l_onoff = 1, | ||
| 1011 | .l_linger = 0, | ||
| 1012 | }; | ||
| 1013 | 1007 | ||
| 1014 | spin_lock_bh(&serv->sv_lock); | 1008 | spin_lock_bh(&serv->sv_lock); |
| 1015 | list_for_each_safe(le, next, &serv->sv_tempsocks) { | 1009 | list_for_each_safe(le, next, &serv->sv_tempsocks) { |
| @@ -1027,10 +1021,7 @@ void svc_age_temp_xprts_now(struct svc_serv *serv, struct sockaddr *server_addr) | |||
| 1027 | list_del_init(le); | 1021 | list_del_init(le); |
| 1028 | xprt = list_entry(le, struct svc_xprt, xpt_list); | 1022 | xprt = list_entry(le, struct svc_xprt, xpt_list); |
| 1029 | dprintk("svc_age_temp_xprts_now: closing %p\n", xprt); | 1023 | dprintk("svc_age_temp_xprts_now: closing %p\n", xprt); |
| 1030 | svsk = container_of(xprt, struct svc_sock, sk_xprt); | 1024 | xprt->xpt_ops->xpo_kill_temp_xprt(xprt); |
| 1031 | sock = svsk->sk_sock; | ||
| 1032 | kernel_setsockopt(sock, SOL_SOCKET, SO_LINGER, | ||
| 1033 | (char *)&no_linger, sizeof(no_linger)); | ||
| 1034 | svc_close_xprt(xprt); | 1025 | svc_close_xprt(xprt); |
| 1035 | } | 1026 | } |
| 1036 | } | 1027 | } |
diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c index 57625f64efd5..a4bc98265d88 100644 --- a/net/sunrpc/svcsock.c +++ b/net/sunrpc/svcsock.c | |||
| @@ -438,6 +438,21 @@ static int svc_tcp_has_wspace(struct svc_xprt *xprt) | |||
| 438 | return !test_bit(SOCK_NOSPACE, &svsk->sk_sock->flags); | 438 | return !test_bit(SOCK_NOSPACE, &svsk->sk_sock->flags); |
| 439 | } | 439 | } |
| 440 | 440 | ||
| 441 | static void svc_tcp_kill_temp_xprt(struct svc_xprt *xprt) | ||
| 442 | { | ||
| 443 | struct svc_sock *svsk; | ||
| 444 | struct socket *sock; | ||
| 445 | struct linger no_linger = { | ||
| 446 | .l_onoff = 1, | ||
| 447 | .l_linger = 0, | ||
| 448 | }; | ||
| 449 | |||
| 450 | svsk = container_of(xprt, struct svc_sock, sk_xprt); | ||
| 451 | sock = svsk->sk_sock; | ||
| 452 | kernel_setsockopt(sock, SOL_SOCKET, SO_LINGER, | ||
| 453 | (char *)&no_linger, sizeof(no_linger)); | ||
| 454 | } | ||
| 455 | |||
| 441 | /* | 456 | /* |
| 442 | * See net/ipv6/ip_sockglue.c : ip_cmsg_recv_pktinfo | 457 | * See net/ipv6/ip_sockglue.c : ip_cmsg_recv_pktinfo |
| 443 | */ | 458 | */ |
| @@ -648,6 +663,10 @@ static struct svc_xprt *svc_udp_accept(struct svc_xprt *xprt) | |||
| 648 | return NULL; | 663 | return NULL; |
| 649 | } | 664 | } |
| 650 | 665 | ||
| 666 | static void svc_udp_kill_temp_xprt(struct svc_xprt *xprt) | ||
| 667 | { | ||
| 668 | } | ||
| 669 | |||
| 651 | static struct svc_xprt *svc_udp_create(struct svc_serv *serv, | 670 | static struct svc_xprt *svc_udp_create(struct svc_serv *serv, |
| 652 | struct net *net, | 671 | struct net *net, |
| 653 | struct sockaddr *sa, int salen, | 672 | struct sockaddr *sa, int salen, |
| @@ -667,6 +686,7 @@ static struct svc_xprt_ops svc_udp_ops = { | |||
| 667 | .xpo_has_wspace = svc_udp_has_wspace, | 686 | .xpo_has_wspace = svc_udp_has_wspace, |
| 668 | .xpo_accept = svc_udp_accept, | 687 | .xpo_accept = svc_udp_accept, |
| 669 | .xpo_secure_port = svc_sock_secure_port, | 688 | .xpo_secure_port = svc_sock_secure_port, |
| 689 | .xpo_kill_temp_xprt = svc_udp_kill_temp_xprt, | ||
| 670 | }; | 690 | }; |
| 671 | 691 | ||
| 672 | static struct svc_xprt_class svc_udp_class = { | 692 | static struct svc_xprt_class svc_udp_class = { |
| @@ -1242,6 +1262,7 @@ static struct svc_xprt_ops svc_tcp_ops = { | |||
| 1242 | .xpo_has_wspace = svc_tcp_has_wspace, | 1262 | .xpo_has_wspace = svc_tcp_has_wspace, |
| 1243 | .xpo_accept = svc_tcp_accept, | 1263 | .xpo_accept = svc_tcp_accept, |
| 1244 | .xpo_secure_port = svc_sock_secure_port, | 1264 | .xpo_secure_port = svc_sock_secure_port, |
| 1265 | .xpo_kill_temp_xprt = svc_tcp_kill_temp_xprt, | ||
| 1245 | }; | 1266 | }; |
| 1246 | 1267 | ||
| 1247 | static struct svc_xprt_class svc_tcp_class = { | 1268 | static struct svc_xprt_class svc_tcp_class = { |
diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c index 6864fb967038..1334de2715c2 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c | |||
| @@ -67,6 +67,7 @@ static void svc_rdma_detach(struct svc_xprt *xprt); | |||
| 67 | static void svc_rdma_free(struct svc_xprt *xprt); | 67 | static void svc_rdma_free(struct svc_xprt *xprt); |
| 68 | static int svc_rdma_has_wspace(struct svc_xprt *xprt); | 68 | static int svc_rdma_has_wspace(struct svc_xprt *xprt); |
| 69 | static int svc_rdma_secure_port(struct svc_rqst *); | 69 | static int svc_rdma_secure_port(struct svc_rqst *); |
| 70 | static void svc_rdma_kill_temp_xprt(struct svc_xprt *); | ||
| 70 | 71 | ||
| 71 | static struct svc_xprt_ops svc_rdma_ops = { | 72 | static struct svc_xprt_ops svc_rdma_ops = { |
| 72 | .xpo_create = svc_rdma_create, | 73 | .xpo_create = svc_rdma_create, |
| @@ -79,6 +80,7 @@ static struct svc_xprt_ops svc_rdma_ops = { | |||
| 79 | .xpo_has_wspace = svc_rdma_has_wspace, | 80 | .xpo_has_wspace = svc_rdma_has_wspace, |
| 80 | .xpo_accept = svc_rdma_accept, | 81 | .xpo_accept = svc_rdma_accept, |
| 81 | .xpo_secure_port = svc_rdma_secure_port, | 82 | .xpo_secure_port = svc_rdma_secure_port, |
| 83 | .xpo_kill_temp_xprt = svc_rdma_kill_temp_xprt, | ||
| 82 | }; | 84 | }; |
| 83 | 85 | ||
| 84 | struct svc_xprt_class svc_rdma_class = { | 86 | struct svc_xprt_class svc_rdma_class = { |
| @@ -1317,6 +1319,10 @@ static int svc_rdma_secure_port(struct svc_rqst *rqstp) | |||
| 1317 | return 1; | 1319 | return 1; |
| 1318 | } | 1320 | } |
| 1319 | 1321 | ||
| 1322 | static void svc_rdma_kill_temp_xprt(struct svc_xprt *xprt) | ||
| 1323 | { | ||
| 1324 | } | ||
| 1325 | |||
| 1320 | int svc_rdma_send(struct svcxprt_rdma *xprt, struct ib_send_wr *wr) | 1326 | int svc_rdma_send(struct svcxprt_rdma *xprt, struct ib_send_wr *wr) |
| 1321 | { | 1327 | { |
| 1322 | struct ib_send_wr *bad_wr, *n_wr; | 1328 | struct ib_send_wr *bad_wr, *n_wr; |
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 145082e2ba36..5d1c14a2f268 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c | |||
| @@ -2812,7 +2812,8 @@ static int unix_seq_show(struct seq_file *seq, void *v) | |||
| 2812 | i++; | 2812 | i++; |
| 2813 | } | 2813 | } |
| 2814 | for ( ; i < len; i++) | 2814 | for ( ; i < len; i++) |
| 2815 | seq_putc(seq, u->addr->name->sun_path[i]); | 2815 | seq_putc(seq, u->addr->name->sun_path[i] ?: |
| 2816 | '@'); | ||
| 2816 | } | 2817 | } |
| 2817 | unix_state_unlock(s); | 2818 | unix_state_unlock(s); |
| 2818 | seq_putc(seq, '\n'); | 2819 | seq_putc(seq, '\n'); |
diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile index 12b7304d55dc..72c58675973e 100644 --- a/samples/bpf/Makefile +++ b/samples/bpf/Makefile | |||
| @@ -27,6 +27,7 @@ hostprogs-y += xdp2 | |||
| 27 | hostprogs-y += test_current_task_under_cgroup | 27 | hostprogs-y += test_current_task_under_cgroup |
| 28 | hostprogs-y += trace_event | 28 | hostprogs-y += trace_event |
| 29 | hostprogs-y += sampleip | 29 | hostprogs-y += sampleip |
| 30 | hostprogs-y += tc_l2_redirect | ||
| 30 | 31 | ||
| 31 | test_verifier-objs := test_verifier.o libbpf.o | 32 | test_verifier-objs := test_verifier.o libbpf.o |
| 32 | test_maps-objs := test_maps.o libbpf.o | 33 | test_maps-objs := test_maps.o libbpf.o |
| @@ -56,6 +57,7 @@ test_current_task_under_cgroup-objs := bpf_load.o libbpf.o \ | |||
| 56 | test_current_task_under_cgroup_user.o | 57 | test_current_task_under_cgroup_user.o |
| 57 | trace_event-objs := bpf_load.o libbpf.o trace_event_user.o | 58 | trace_event-objs := bpf_load.o libbpf.o trace_event_user.o |
| 58 | sampleip-objs := bpf_load.o libbpf.o sampleip_user.o | 59 | sampleip-objs := bpf_load.o libbpf.o sampleip_user.o |
| 60 | tc_l2_redirect-objs := bpf_load.o libbpf.o tc_l2_redirect_user.o | ||
| 59 | 61 | ||
| 60 | # Tell kbuild to always build the programs | 62 | # Tell kbuild to always build the programs |
| 61 | always := $(hostprogs-y) | 63 | always := $(hostprogs-y) |
| @@ -72,6 +74,7 @@ always += test_probe_write_user_kern.o | |||
| 72 | always += trace_output_kern.o | 74 | always += trace_output_kern.o |
| 73 | always += tcbpf1_kern.o | 75 | always += tcbpf1_kern.o |
| 74 | always += tcbpf2_kern.o | 76 | always += tcbpf2_kern.o |
| 77 | always += tc_l2_redirect_kern.o | ||
| 75 | always += lathist_kern.o | 78 | always += lathist_kern.o |
| 76 | always += offwaketime_kern.o | 79 | always += offwaketime_kern.o |
| 77 | always += spintest_kern.o | 80 | always += spintest_kern.o |
| @@ -111,6 +114,7 @@ HOSTLOADLIBES_xdp2 += -lelf | |||
| 111 | HOSTLOADLIBES_test_current_task_under_cgroup += -lelf | 114 | HOSTLOADLIBES_test_current_task_under_cgroup += -lelf |
| 112 | HOSTLOADLIBES_trace_event += -lelf | 115 | HOSTLOADLIBES_trace_event += -lelf |
| 113 | HOSTLOADLIBES_sampleip += -lelf | 116 | HOSTLOADLIBES_sampleip += -lelf |
| 117 | HOSTLOADLIBES_tc_l2_redirect += -l elf | ||
| 114 | 118 | ||
| 115 | # Allows pointing LLC/CLANG to a LLVM backend with bpf support, redefine on cmdline: | 119 | # Allows pointing LLC/CLANG to a LLVM backend with bpf support, redefine on cmdline: |
| 116 | # make samples/bpf/ LLC=~/git/llvm/build/bin/llc CLANG=~/git/llvm/build/bin/clang | 120 | # make samples/bpf/ LLC=~/git/llvm/build/bin/llc CLANG=~/git/llvm/build/bin/clang |
diff --git a/samples/bpf/tc_l2_redirect.sh b/samples/bpf/tc_l2_redirect.sh new file mode 100755 index 000000000000..80a05591a140 --- /dev/null +++ b/samples/bpf/tc_l2_redirect.sh | |||
| @@ -0,0 +1,173 @@ | |||
| 1 | #!/bin/bash | ||
| 2 | |||
| 3 | [[ -z $TC ]] && TC='tc' | ||
| 4 | [[ -z $IP ]] && IP='ip' | ||
| 5 | |||
| 6 | REDIRECT_USER='./tc_l2_redirect' | ||
| 7 | REDIRECT_BPF='./tc_l2_redirect_kern.o' | ||
| 8 | |||
| 9 | RP_FILTER=$(< /proc/sys/net/ipv4/conf/all/rp_filter) | ||
| 10 | IPV6_FORWARDING=$(< /proc/sys/net/ipv6/conf/all/forwarding) | ||
| 11 | |||
| 12 | function config_common { | ||
| 13 | local tun_type=$1 | ||
| 14 | |||
| 15 | $IP netns add ns1 | ||
| 16 | $IP netns add ns2 | ||
| 17 | $IP link add ve1 type veth peer name vens1 | ||
| 18 | $IP link add ve2 type veth peer name vens2 | ||
| 19 | $IP link set dev ve1 up | ||
| 20 | $IP link set dev ve2 up | ||
| 21 | $IP link set dev ve1 mtu 1500 | ||
| 22 | $IP link set dev ve2 mtu 1500 | ||
| 23 | $IP link set dev vens1 netns ns1 | ||
| 24 | $IP link set dev vens2 netns ns2 | ||
| 25 | |||
| 26 | $IP -n ns1 link set dev lo up | ||
| 27 | $IP -n ns1 link set dev vens1 up | ||
| 28 | $IP -n ns1 addr add 10.1.1.101/24 dev vens1 | ||
| 29 | $IP -n ns1 addr add 2401:db01::65/64 dev vens1 nodad | ||
| 30 | $IP -n ns1 route add default via 10.1.1.1 dev vens1 | ||
| 31 | $IP -n ns1 route add default via 2401:db01::1 dev vens1 | ||
| 32 | |||
| 33 | $IP -n ns2 link set dev lo up | ||
| 34 | $IP -n ns2 link set dev vens2 up | ||
| 35 | $IP -n ns2 addr add 10.2.1.102/24 dev vens2 | ||
| 36 | $IP -n ns2 addr add 2401:db02::66/64 dev vens2 nodad | ||
| 37 | $IP -n ns2 addr add 10.10.1.102 dev lo | ||
| 38 | $IP -n ns2 addr add 2401:face::66/64 dev lo nodad | ||
| 39 | $IP -n ns2 link add ipt2 type ipip local 10.2.1.102 remote 10.2.1.1 | ||
| 40 | $IP -n ns2 link add ip6t2 type ip6tnl mode any local 2401:db02::66 remote 2401:db02::1 | ||
| 41 | $IP -n ns2 link set dev ipt2 up | ||
| 42 | $IP -n ns2 link set dev ip6t2 up | ||
| 43 | $IP netns exec ns2 $TC qdisc add dev vens2 clsact | ||
| 44 | $IP netns exec ns2 $TC filter add dev vens2 ingress bpf da obj $REDIRECT_BPF sec drop_non_tun_vip | ||
| 45 | if [[ $tun_type == "ipip" ]]; then | ||
| 46 | $IP -n ns2 route add 10.1.1.0/24 dev ipt2 | ||
| 47 | $IP netns exec ns2 sysctl -q -w net.ipv4.conf.all.rp_filter=0 | ||
| 48 | $IP netns exec ns2 sysctl -q -w net.ipv4.conf.ipt2.rp_filter=0 | ||
| 49 | else | ||
| 50 | $IP -n ns2 route add 10.1.1.0/24 dev ip6t2 | ||
| 51 | $IP -n ns2 route add 2401:db01::/64 dev ip6t2 | ||
| 52 | $IP netns exec ns2 sysctl -q -w net.ipv4.conf.all.rp_filter=0 | ||
| 53 | $IP netns exec ns2 sysctl -q -w net.ipv4.conf.ip6t2.rp_filter=0 | ||
| 54 | fi | ||
| 55 | |||
| 56 | $IP addr add 10.1.1.1/24 dev ve1 | ||
| 57 | $IP addr add 2401:db01::1/64 dev ve1 nodad | ||
| 58 | $IP addr add 10.2.1.1/24 dev ve2 | ||
| 59 | $IP addr add 2401:db02::1/64 dev ve2 nodad | ||
| 60 | |||
| 61 | $TC qdisc add dev ve2 clsact | ||
| 62 | $TC filter add dev ve2 ingress bpf da obj $REDIRECT_BPF sec l2_to_iptun_ingress_forward | ||
| 63 | |||
| 64 | sysctl -q -w net.ipv4.conf.all.rp_filter=0 | ||
| 65 | sysctl -q -w net.ipv6.conf.all.forwarding=1 | ||
| 66 | } | ||
| 67 | |||
| 68 | function cleanup { | ||
| 69 | set +e | ||
| 70 | [[ -z $DEBUG ]] || set +x | ||
| 71 | $IP netns delete ns1 >& /dev/null | ||
| 72 | $IP netns delete ns2 >& /dev/null | ||
| 73 | $IP link del ve1 >& /dev/null | ||
| 74 | $IP link del ve2 >& /dev/null | ||
| 75 | $IP link del ipt >& /dev/null | ||
| 76 | $IP link del ip6t >& /dev/null | ||
| 77 | sysctl -q -w net.ipv4.conf.all.rp_filter=$RP_FILTER | ||
| 78 | sysctl -q -w net.ipv6.conf.all.forwarding=$IPV6_FORWARDING | ||
| 79 | rm -f /sys/fs/bpf/tc/globals/tun_iface | ||
| 80 | [[ -z $DEBUG ]] || set -x | ||
| 81 | set -e | ||
| 82 | } | ||
| 83 | |||
| 84 | function l2_to_ipip { | ||
| 85 | echo -n "l2_to_ipip $1: " | ||
| 86 | |||
| 87 | local dir=$1 | ||
| 88 | |||
| 89 | config_common ipip | ||
| 90 | |||
| 91 | $IP link add ipt type ipip external | ||
| 92 | $IP link set dev ipt up | ||
| 93 | sysctl -q -w net.ipv4.conf.ipt.rp_filter=0 | ||
| 94 | sysctl -q -w net.ipv4.conf.ipt.forwarding=1 | ||
| 95 | |||
| 96 | if [[ $dir == "egress" ]]; then | ||
| 97 | $IP route add 10.10.1.0/24 via 10.2.1.102 dev ve2 | ||
| 98 | $TC filter add dev ve2 egress bpf da obj $REDIRECT_BPF sec l2_to_iptun_ingress_redirect | ||
| 99 | sysctl -q -w net.ipv4.conf.ve1.forwarding=1 | ||
| 100 | else | ||
| 101 | $TC qdisc add dev ve1 clsact | ||
| 102 | $TC filter add dev ve1 ingress bpf da obj $REDIRECT_BPF sec l2_to_iptun_ingress_redirect | ||
| 103 | fi | ||
| 104 | |||
| 105 | $REDIRECT_USER -U /sys/fs/bpf/tc/globals/tun_iface -i $(< /sys/class/net/ipt/ifindex) | ||
| 106 | |||
| 107 | $IP netns exec ns1 ping -c1 10.10.1.102 >& /dev/null | ||
| 108 | |||
| 109 | if [[ $dir == "egress" ]]; then | ||
| 110 | # test direct egress to ve2 (i.e. not forwarding from | ||
| 111 | # ve1 to ve2). | ||
| 112 | ping -c1 10.10.1.102 >& /dev/null | ||
| 113 | fi | ||
| 114 | |||
| 115 | cleanup | ||
| 116 | |||
| 117 | echo "OK" | ||
| 118 | } | ||
| 119 | |||
| 120 | function l2_to_ip6tnl { | ||
| 121 | echo -n "l2_to_ip6tnl $1: " | ||
| 122 | |||
| 123 | local dir=$1 | ||
| 124 | |||
| 125 | config_common ip6tnl | ||
| 126 | |||
| 127 | $IP link add ip6t type ip6tnl mode any external | ||
| 128 | $IP link set dev ip6t up | ||
| 129 | sysctl -q -w net.ipv4.conf.ip6t.rp_filter=0 | ||
| 130 | sysctl -q -w net.ipv4.conf.ip6t.forwarding=1 | ||
| 131 | |||
| 132 | if [[ $dir == "egress" ]]; then | ||
| 133 | $IP route add 10.10.1.0/24 via 10.2.1.102 dev ve2 | ||
| 134 | $IP route add 2401:face::/64 via 2401:db02::66 dev ve2 | ||
| 135 | $TC filter add dev ve2 egress bpf da obj $REDIRECT_BPF sec l2_to_ip6tun_ingress_redirect | ||
| 136 | sysctl -q -w net.ipv4.conf.ve1.forwarding=1 | ||
| 137 | else | ||
| 138 | $TC qdisc add dev ve1 clsact | ||
| 139 | $TC filter add dev ve1 ingress bpf da obj $REDIRECT_BPF sec l2_to_ip6tun_ingress_redirect | ||
| 140 | fi | ||
| 141 | |||
| 142 | $REDIRECT_USER -U /sys/fs/bpf/tc/globals/tun_iface -i $(< /sys/class/net/ip6t/ifindex) | ||
| 143 | |||
| 144 | $IP netns exec ns1 ping -c1 10.10.1.102 >& /dev/null | ||
| 145 | $IP netns exec ns1 ping -6 -c1 2401:face::66 >& /dev/null | ||
| 146 | |||
| 147 | if [[ $dir == "egress" ]]; then | ||
| 148 | # test direct egress to ve2 (i.e. not forwarding from | ||
| 149 | # ve1 to ve2). | ||
| 150 | ping -c1 10.10.1.102 >& /dev/null | ||
| 151 | ping -6 -c1 2401:face::66 >& /dev/null | ||
| 152 | fi | ||
| 153 | |||
| 154 | cleanup | ||
| 155 | |||
| 156 | echo "OK" | ||
| 157 | } | ||
| 158 | |||
| 159 | cleanup | ||
| 160 | test_names="l2_to_ipip l2_to_ip6tnl" | ||
| 161 | test_dirs="ingress egress" | ||
| 162 | if [[ $# -ge 2 ]]; then | ||
| 163 | test_names=$1 | ||
| 164 | test_dirs=$2 | ||
| 165 | elif [[ $# -ge 1 ]]; then | ||
| 166 | test_names=$1 | ||
| 167 | fi | ||
| 168 | |||
| 169 | for t in $test_names; do | ||
| 170 | for d in $test_dirs; do | ||
| 171 | $t $d | ||
| 172 | done | ||
| 173 | done | ||
diff --git a/samples/bpf/tc_l2_redirect_kern.c b/samples/bpf/tc_l2_redirect_kern.c new file mode 100644 index 000000000000..92a44729dbe4 --- /dev/null +++ b/samples/bpf/tc_l2_redirect_kern.c | |||
| @@ -0,0 +1,236 @@ | |||
| 1 | /* Copyright (c) 2016 Facebook | ||
| 2 | * | ||
| 3 | * This program is free software; you can redistribute it and/or | ||
| 4 | * modify it under the terms of version 2 of the GNU General Public | ||
| 5 | * License as published by the Free Software Foundation. | ||
| 6 | */ | ||
| 7 | #include <uapi/linux/bpf.h> | ||
| 8 | #include <uapi/linux/if_ether.h> | ||
| 9 | #include <uapi/linux/if_packet.h> | ||
| 10 | #include <uapi/linux/ip.h> | ||
| 11 | #include <uapi/linux/ipv6.h> | ||
| 12 | #include <uapi/linux/in.h> | ||
| 13 | #include <uapi/linux/tcp.h> | ||
| 14 | #include <uapi/linux/filter.h> | ||
| 15 | #include <uapi/linux/pkt_cls.h> | ||
| 16 | #include <net/ipv6.h> | ||
| 17 | #include "bpf_helpers.h" | ||
| 18 | |||
| 19 | #define _htonl __builtin_bswap32 | ||
| 20 | |||
| 21 | #define PIN_GLOBAL_NS 2 | ||
| 22 | struct bpf_elf_map { | ||
| 23 | __u32 type; | ||
| 24 | __u32 size_key; | ||
| 25 | __u32 size_value; | ||
| 26 | __u32 max_elem; | ||
| 27 | __u32 flags; | ||
| 28 | __u32 id; | ||
| 29 | __u32 pinning; | ||
| 30 | }; | ||
| 31 | |||
| 32 | /* copy of 'struct ethhdr' without __packed */ | ||
| 33 | struct eth_hdr { | ||
| 34 | unsigned char h_dest[ETH_ALEN]; | ||
| 35 | unsigned char h_source[ETH_ALEN]; | ||
| 36 | unsigned short h_proto; | ||
| 37 | }; | ||
| 38 | |||
| 39 | struct bpf_elf_map SEC("maps") tun_iface = { | ||
| 40 | .type = BPF_MAP_TYPE_ARRAY, | ||
| 41 | .size_key = sizeof(int), | ||
| 42 | .size_value = sizeof(int), | ||
| 43 | .pinning = PIN_GLOBAL_NS, | ||
| 44 | .max_elem = 1, | ||
| 45 | }; | ||
| 46 | |||
| 47 | static __always_inline bool is_vip_addr(__be16 eth_proto, __be32 daddr) | ||
| 48 | { | ||
| 49 | if (eth_proto == htons(ETH_P_IP)) | ||
| 50 | return (_htonl(0xffffff00) & daddr) == _htonl(0x0a0a0100); | ||
| 51 | else if (eth_proto == htons(ETH_P_IPV6)) | ||
| 52 | return (daddr == _htonl(0x2401face)); | ||
| 53 | |||
| 54 | return false; | ||
| 55 | } | ||
| 56 | |||
| 57 | SEC("l2_to_iptun_ingress_forward") | ||
| 58 | int _l2_to_iptun_ingress_forward(struct __sk_buff *skb) | ||
| 59 | { | ||
| 60 | struct bpf_tunnel_key tkey = {}; | ||
| 61 | void *data = (void *)(long)skb->data; | ||
| 62 | struct eth_hdr *eth = data; | ||
| 63 | void *data_end = (void *)(long)skb->data_end; | ||
| 64 | int key = 0, *ifindex; | ||
| 65 | |||
| 66 | int ret; | ||
| 67 | |||
| 68 | if (data + sizeof(*eth) > data_end) | ||
| 69 | return TC_ACT_OK; | ||
| 70 | |||
| 71 | ifindex = bpf_map_lookup_elem(&tun_iface, &key); | ||
| 72 | if (!ifindex) | ||
| 73 | return TC_ACT_OK; | ||
| 74 | |||
| 75 | if (eth->h_proto == htons(ETH_P_IP)) { | ||
| 76 | char fmt4[] = "ingress forward to ifindex:%d daddr4:%x\n"; | ||
| 77 | struct iphdr *iph = data + sizeof(*eth); | ||
| 78 | |||
| 79 | if (data + sizeof(*eth) + sizeof(*iph) > data_end) | ||
| 80 | return TC_ACT_OK; | ||
| 81 | |||
| 82 | if (iph->protocol != IPPROTO_IPIP) | ||
| 83 | return TC_ACT_OK; | ||
| 84 | |||
| 85 | bpf_trace_printk(fmt4, sizeof(fmt4), *ifindex, | ||
| 86 | _htonl(iph->daddr)); | ||
| 87 | return bpf_redirect(*ifindex, BPF_F_INGRESS); | ||
| 88 | } else if (eth->h_proto == htons(ETH_P_IPV6)) { | ||
| 89 | char fmt6[] = "ingress forward to ifindex:%d daddr6:%x::%x\n"; | ||
| 90 | struct ipv6hdr *ip6h = data + sizeof(*eth); | ||
| 91 | |||
| 92 | if (data + sizeof(*eth) + sizeof(*ip6h) > data_end) | ||
| 93 | return TC_ACT_OK; | ||
| 94 | |||
| 95 | if (ip6h->nexthdr != IPPROTO_IPIP && | ||
| 96 | ip6h->nexthdr != IPPROTO_IPV6) | ||
| 97 | return TC_ACT_OK; | ||
| 98 | |||
| 99 | bpf_trace_printk(fmt6, sizeof(fmt6), *ifindex, | ||
| 100 | _htonl(ip6h->daddr.s6_addr32[0]), | ||
| 101 | _htonl(ip6h->daddr.s6_addr32[3])); | ||
| 102 | return bpf_redirect(*ifindex, BPF_F_INGRESS); | ||
| 103 | } | ||
| 104 | |||
| 105 | return TC_ACT_OK; | ||
| 106 | } | ||
| 107 | |||
| 108 | SEC("l2_to_iptun_ingress_redirect") | ||
| 109 | int _l2_to_iptun_ingress_redirect(struct __sk_buff *skb) | ||
| 110 | { | ||
| 111 | struct bpf_tunnel_key tkey = {}; | ||
| 112 | void *data = (void *)(long)skb->data; | ||
| 113 | struct eth_hdr *eth = data; | ||
| 114 | void *data_end = (void *)(long)skb->data_end; | ||
| 115 | int key = 0, *ifindex; | ||
| 116 | |||
| 117 | int ret; | ||
| 118 | |||
| 119 | if (data + sizeof(*eth) > data_end) | ||
| 120 | return TC_ACT_OK; | ||
| 121 | |||
| 122 | ifindex = bpf_map_lookup_elem(&tun_iface, &key); | ||
| 123 | if (!ifindex) | ||
| 124 | return TC_ACT_OK; | ||
| 125 | |||
| 126 | if (eth->h_proto == htons(ETH_P_IP)) { | ||
| 127 | char fmt4[] = "e/ingress redirect daddr4:%x to ifindex:%d\n"; | ||
| 128 | struct iphdr *iph = data + sizeof(*eth); | ||
| 129 | __be32 daddr = iph->daddr; | ||
| 130 | |||
| 131 | if (data + sizeof(*eth) + sizeof(*iph) > data_end) | ||
| 132 | return TC_ACT_OK; | ||
| 133 | |||
| 134 | if (!is_vip_addr(eth->h_proto, daddr)) | ||
| 135 | return TC_ACT_OK; | ||
| 136 | |||
| 137 | bpf_trace_printk(fmt4, sizeof(fmt4), _htonl(daddr), *ifindex); | ||
| 138 | } else { | ||
| 139 | return TC_ACT_OK; | ||
| 140 | } | ||
| 141 | |||
| 142 | tkey.tunnel_id = 10000; | ||
| 143 | tkey.tunnel_ttl = 64; | ||
| 144 | tkey.remote_ipv4 = 0x0a020166; /* 10.2.1.102 */ | ||
| 145 | bpf_skb_set_tunnel_key(skb, &tkey, sizeof(tkey), 0); | ||
| 146 | return bpf_redirect(*ifindex, 0); | ||
| 147 | } | ||
| 148 | |||
| 149 | SEC("l2_to_ip6tun_ingress_redirect") | ||
| 150 | int _l2_to_ip6tun_ingress_redirect(struct __sk_buff *skb) | ||
| 151 | { | ||
| 152 | struct bpf_tunnel_key tkey = {}; | ||
| 153 | void *data = (void *)(long)skb->data; | ||
| 154 | struct eth_hdr *eth = data; | ||
| 155 | void *data_end = (void *)(long)skb->data_end; | ||
| 156 | int key = 0, *ifindex; | ||
| 157 | |||
| 158 | if (data + sizeof(*eth) > data_end) | ||
| 159 | return TC_ACT_OK; | ||
| 160 | |||
| 161 | ifindex = bpf_map_lookup_elem(&tun_iface, &key); | ||
| 162 | if (!ifindex) | ||
| 163 | return TC_ACT_OK; | ||
| 164 | |||
| 165 | if (eth->h_proto == htons(ETH_P_IP)) { | ||
| 166 | char fmt4[] = "e/ingress redirect daddr4:%x to ifindex:%d\n"; | ||
| 167 | struct iphdr *iph = data + sizeof(*eth); | ||
| 168 | |||
| 169 | if (data + sizeof(*eth) + sizeof(*iph) > data_end) | ||
| 170 | return TC_ACT_OK; | ||
| 171 | |||
| 172 | if (!is_vip_addr(eth->h_proto, iph->daddr)) | ||
| 173 | return TC_ACT_OK; | ||
| 174 | |||
| 175 | bpf_trace_printk(fmt4, sizeof(fmt4), _htonl(iph->daddr), | ||
| 176 | *ifindex); | ||
| 177 | } else if (eth->h_proto == htons(ETH_P_IPV6)) { | ||
| 178 | char fmt6[] = "e/ingress redirect daddr6:%x to ifindex:%d\n"; | ||
| 179 | struct ipv6hdr *ip6h = data + sizeof(*eth); | ||
| 180 | |||
| 181 | if (data + sizeof(*eth) + sizeof(*ip6h) > data_end) | ||
| 182 | return TC_ACT_OK; | ||
| 183 | |||
| 184 | if (!is_vip_addr(eth->h_proto, ip6h->daddr.s6_addr32[0])) | ||
| 185 | return TC_ACT_OK; | ||
| 186 | |||
| 187 | bpf_trace_printk(fmt6, sizeof(fmt6), | ||
| 188 | _htonl(ip6h->daddr.s6_addr32[0]), *ifindex); | ||
| 189 | } else { | ||
| 190 | return TC_ACT_OK; | ||
| 191 | } | ||
| 192 | |||
| 193 | tkey.tunnel_id = 10000; | ||
| 194 | tkey.tunnel_ttl = 64; | ||
| 195 | /* 2401:db02:0:0:0:0:0:66 */ | ||
| 196 | tkey.remote_ipv6[0] = _htonl(0x2401db02); | ||
| 197 | tkey.remote_ipv6[1] = 0; | ||
| 198 | tkey.remote_ipv6[2] = 0; | ||
| 199 | tkey.remote_ipv6[3] = _htonl(0x00000066); | ||
| 200 | bpf_skb_set_tunnel_key(skb, &tkey, sizeof(tkey), BPF_F_TUNINFO_IPV6); | ||
| 201 | return bpf_redirect(*ifindex, 0); | ||
| 202 | } | ||
| 203 | |||
| 204 | SEC("drop_non_tun_vip") | ||
| 205 | int _drop_non_tun_vip(struct __sk_buff *skb) | ||
| 206 | { | ||
| 207 | struct bpf_tunnel_key tkey = {}; | ||
| 208 | void *data = (void *)(long)skb->data; | ||
| 209 | struct eth_hdr *eth = data; | ||
| 210 | void *data_end = (void *)(long)skb->data_end; | ||
| 211 | |||
| 212 | if (data + sizeof(*eth) > data_end) | ||
| 213 | return TC_ACT_OK; | ||
| 214 | |||
| 215 | if (eth->h_proto == htons(ETH_P_IP)) { | ||
| 216 | struct iphdr *iph = data + sizeof(*eth); | ||
| 217 | |||
| 218 | if (data + sizeof(*eth) + sizeof(*iph) > data_end) | ||
| 219 | return TC_ACT_OK; | ||
| 220 | |||
| 221 | if (is_vip_addr(eth->h_proto, iph->daddr)) | ||
| 222 | return TC_ACT_SHOT; | ||
| 223 | } else if (eth->h_proto == htons(ETH_P_IPV6)) { | ||
| 224 | struct ipv6hdr *ip6h = data + sizeof(*eth); | ||
| 225 | |||
| 226 | if (data + sizeof(*eth) + sizeof(*ip6h) > data_end) | ||
| 227 | return TC_ACT_OK; | ||
| 228 | |||
| 229 | if (is_vip_addr(eth->h_proto, ip6h->daddr.s6_addr32[0])) | ||
| 230 | return TC_ACT_SHOT; | ||
| 231 | } | ||
| 232 | |||
| 233 | return TC_ACT_OK; | ||
| 234 | } | ||
| 235 | |||
| 236 | char _license[] SEC("license") = "GPL"; | ||
diff --git a/samples/bpf/tc_l2_redirect_user.c b/samples/bpf/tc_l2_redirect_user.c new file mode 100644 index 000000000000..4013c5337b91 --- /dev/null +++ b/samples/bpf/tc_l2_redirect_user.c | |||
| @@ -0,0 +1,73 @@ | |||
| 1 | /* Copyright (c) 2016 Facebook | ||
| 2 | * | ||
| 3 | * This program is free software; you can redistribute it and/or | ||
| 4 | * modify it under the terms of version 2 of the GNU General Public | ||
| 5 | * License as published by the Free Software Foundation. | ||
| 6 | */ | ||
| 7 | #include <linux/unistd.h> | ||
| 8 | #include <linux/bpf.h> | ||
| 9 | |||
| 10 | #include <stdlib.h> | ||
| 11 | #include <stdio.h> | ||
| 12 | #include <unistd.h> | ||
| 13 | #include <string.h> | ||
| 14 | #include <errno.h> | ||
| 15 | |||
| 16 | #include "libbpf.h" | ||
| 17 | |||
| 18 | static void usage(void) | ||
| 19 | { | ||
| 20 | printf("Usage: tc_l2_ipip_redirect [...]\n"); | ||
| 21 | printf(" -U <file> Update an already pinned BPF array\n"); | ||
| 22 | printf(" -i <ifindex> Interface index\n"); | ||
| 23 | printf(" -h Display this help\n"); | ||
| 24 | } | ||
| 25 | |||
| 26 | int main(int argc, char **argv) | ||
| 27 | { | ||
| 28 | const char *pinned_file = NULL; | ||
| 29 | int ifindex = -1; | ||
| 30 | int array_key = 0; | ||
| 31 | int array_fd = -1; | ||
| 32 | int ret = -1; | ||
| 33 | int opt; | ||
| 34 | |||
| 35 | while ((opt = getopt(argc, argv, "F:U:i:")) != -1) { | ||
| 36 | switch (opt) { | ||
| 37 | /* General args */ | ||
| 38 | case 'U': | ||
| 39 | pinned_file = optarg; | ||
| 40 | break; | ||
| 41 | case 'i': | ||
| 42 | ifindex = atoi(optarg); | ||
| 43 | break; | ||
| 44 | default: | ||
| 45 | usage(); | ||
| 46 | goto out; | ||
| 47 | } | ||
| 48 | } | ||
| 49 | |||
| 50 | if (ifindex < 0 || !pinned_file) { | ||
| 51 | usage(); | ||
| 52 | goto out; | ||
| 53 | } | ||
| 54 | |||
| 55 | array_fd = bpf_obj_get(pinned_file); | ||
| 56 | if (array_fd < 0) { | ||
| 57 | fprintf(stderr, "bpf_obj_get(%s): %s(%d)\n", | ||
| 58 | pinned_file, strerror(errno), errno); | ||
| 59 | goto out; | ||
| 60 | } | ||
| 61 | |||
| 62 | /* bpf_tunnel_key.remote_ipv4 expects host byte orders */ | ||
| 63 | ret = bpf_update_elem(array_fd, &array_key, &ifindex, 0); | ||
| 64 | if (ret) { | ||
| 65 | perror("bpf_update_elem"); | ||
| 66 | goto out; | ||
| 67 | } | ||
| 68 | |||
| 69 | out: | ||
| 70 | if (array_fd != -1) | ||
| 71 | close(array_fd); | ||
| 72 | return ret; | ||
| 73 | } | ||
diff --git a/scripts/Makefile.build b/scripts/Makefile.build index de46ab03f063..7675d11ee65e 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build | |||
| @@ -159,7 +159,8 @@ cmd_cpp_i_c = $(CPP) $(c_flags) -o $@ $< | |||
| 159 | $(obj)/%.i: $(src)/%.c FORCE | 159 | $(obj)/%.i: $(src)/%.c FORCE |
| 160 | $(call if_changed_dep,cpp_i_c) | 160 | $(call if_changed_dep,cpp_i_c) |
| 161 | 161 | ||
| 162 | cmd_gensymtypes = \ | 162 | # These mirror gensymtypes_S and co below, keep them in synch. |
| 163 | cmd_gensymtypes_c = \ | ||
| 163 | $(CPP) -D__GENKSYMS__ $(c_flags) $< | \ | 164 | $(CPP) -D__GENKSYMS__ $(c_flags) $< | \ |
| 164 | $(GENKSYMS) $(if $(1), -T $(2)) \ | 165 | $(GENKSYMS) $(if $(1), -T $(2)) \ |
| 165 | $(patsubst y,-s _,$(CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX)) \ | 166 | $(patsubst y,-s _,$(CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX)) \ |
| @@ -169,7 +170,7 @@ cmd_gensymtypes = \ | |||
| 169 | quiet_cmd_cc_symtypes_c = SYM $(quiet_modtag) $@ | 170 | quiet_cmd_cc_symtypes_c = SYM $(quiet_modtag) $@ |
| 170 | cmd_cc_symtypes_c = \ | 171 | cmd_cc_symtypes_c = \ |
| 171 | set -e; \ | 172 | set -e; \ |
| 172 | $(call cmd_gensymtypes,true,$@) >/dev/null; \ | 173 | $(call cmd_gensymtypes_c,true,$@) >/dev/null; \ |
| 173 | test -s $@ || rm -f $@ | 174 | test -s $@ || rm -f $@ |
| 174 | 175 | ||
| 175 | $(obj)/%.symtypes : $(src)/%.c FORCE | 176 | $(obj)/%.symtypes : $(src)/%.c FORCE |
| @@ -198,9 +199,10 @@ else | |||
| 198 | # the actual value of the checksum generated by genksyms | 199 | # the actual value of the checksum generated by genksyms |
| 199 | 200 | ||
| 200 | cmd_cc_o_c = $(CC) $(c_flags) -c -o $(@D)/.tmp_$(@F) $< | 201 | cmd_cc_o_c = $(CC) $(c_flags) -c -o $(@D)/.tmp_$(@F) $< |
| 201 | cmd_modversions = \ | 202 | |
| 203 | cmd_modversions_c = \ | ||
| 202 | if $(OBJDUMP) -h $(@D)/.tmp_$(@F) | grep -q __ksymtab; then \ | 204 | if $(OBJDUMP) -h $(@D)/.tmp_$(@F) | grep -q __ksymtab; then \ |
| 203 | $(call cmd_gensymtypes,$(KBUILD_SYMTYPES),$(@:.o=.symtypes)) \ | 205 | $(call cmd_gensymtypes_c,$(KBUILD_SYMTYPES),$(@:.o=.symtypes)) \ |
| 204 | > $(@D)/.tmp_$(@F:.o=.ver); \ | 206 | > $(@D)/.tmp_$(@F:.o=.ver); \ |
| 205 | \ | 207 | \ |
| 206 | $(LD) $(LDFLAGS) -r -o $@ $(@D)/.tmp_$(@F) \ | 208 | $(LD) $(LDFLAGS) -r -o $@ $(@D)/.tmp_$(@F) \ |
| @@ -268,13 +270,14 @@ endif # CONFIG_STACK_VALIDATION | |||
| 268 | define rule_cc_o_c | 270 | define rule_cc_o_c |
| 269 | $(call echo-cmd,checksrc) $(cmd_checksrc) \ | 271 | $(call echo-cmd,checksrc) $(cmd_checksrc) \ |
| 270 | $(call cmd_and_fixdep,cc_o_c) \ | 272 | $(call cmd_and_fixdep,cc_o_c) \ |
| 271 | $(cmd_modversions) \ | 273 | $(cmd_modversions_c) \ |
| 272 | $(cmd_objtool) \ | 274 | $(cmd_objtool) \ |
| 273 | $(call echo-cmd,record_mcount) $(cmd_record_mcount) | 275 | $(call echo-cmd,record_mcount) $(cmd_record_mcount) |
| 274 | endef | 276 | endef |
| 275 | 277 | ||
| 276 | define rule_as_o_S | 278 | define rule_as_o_S |
| 277 | $(call cmd_and_fixdep,as_o_S) \ | 279 | $(call cmd_and_fixdep,as_o_S) \ |
| 280 | $(cmd_modversions_S) \ | ||
| 278 | $(cmd_objtool) | 281 | $(cmd_objtool) |
| 279 | endef | 282 | endef |
| 280 | 283 | ||
| @@ -314,6 +317,39 @@ modkern_aflags := $(KBUILD_AFLAGS_KERNEL) $(AFLAGS_KERNEL) | |||
| 314 | $(real-objs-m) : modkern_aflags := $(KBUILD_AFLAGS_MODULE) $(AFLAGS_MODULE) | 317 | $(real-objs-m) : modkern_aflags := $(KBUILD_AFLAGS_MODULE) $(AFLAGS_MODULE) |
| 315 | $(real-objs-m:.o=.s): modkern_aflags := $(KBUILD_AFLAGS_MODULE) $(AFLAGS_MODULE) | 318 | $(real-objs-m:.o=.s): modkern_aflags := $(KBUILD_AFLAGS_MODULE) $(AFLAGS_MODULE) |
| 316 | 319 | ||
| 320 | # .S file exports must have their C prototypes defined in asm/asm-prototypes.h | ||
| 321 | # or a file that it includes, in order to get versioned symbols. We build a | ||
| 322 | # dummy C file that includes asm-prototypes and the EXPORT_SYMBOL lines from | ||
| 323 | # the .S file (with trailing ';'), and run genksyms on that, to extract vers. | ||
| 324 | # | ||
| 325 | # This is convoluted. The .S file must first be preprocessed to run guards and | ||
| 326 | # expand names, then the resulting exports must be constructed into plain | ||
| 327 | # EXPORT_SYMBOL(symbol); to build our dummy C file, and that gets preprocessed | ||
| 328 | # to make the genksyms input. | ||
| 329 | # | ||
| 330 | # These mirror gensymtypes_c and co above, keep them in synch. | ||
| 331 | cmd_gensymtypes_S = \ | ||
| 332 | (echo "\#include <linux/kernel.h>" ; \ | ||
| 333 | echo "\#include <asm/asm-prototypes.h>" ; \ | ||
| 334 | $(CPP) $(a_flags) $< | \ | ||
| 335 | grep "\<___EXPORT_SYMBOL\>" | \ | ||
| 336 | sed 's/.*___EXPORT_SYMBOL[[:space:]]*\([a-zA-Z0-9_]*\)[[:space:]]*,.*/EXPORT_SYMBOL(\1);/' ) | \ | ||
| 337 | $(CPP) -D__GENKSYMS__ $(c_flags) -xc - | \ | ||
| 338 | $(GENKSYMS) $(if $(1), -T $(2)) \ | ||
| 339 | $(patsubst y,-s _,$(CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX)) \ | ||
| 340 | $(if $(KBUILD_PRESERVE),-p) \ | ||
| 341 | -r $(firstword $(wildcard $(2:.symtypes=.symref) /dev/null)) | ||
| 342 | |||
| 343 | quiet_cmd_cc_symtypes_S = SYM $(quiet_modtag) $@ | ||
| 344 | cmd_cc_symtypes_S = \ | ||
| 345 | set -e; \ | ||
| 346 | $(call cmd_gensymtypes_S,true,$@) >/dev/null; \ | ||
| 347 | test -s $@ || rm -f $@ | ||
| 348 | |||
| 349 | $(obj)/%.symtypes : $(src)/%.S FORCE | ||
| 350 | $(call cmd,cc_symtypes_S) | ||
| 351 | |||
| 352 | |||
| 317 | quiet_cmd_cpp_s_S = CPP $(quiet_modtag) $@ | 353 | quiet_cmd_cpp_s_S = CPP $(quiet_modtag) $@ |
| 318 | cmd_cpp_s_S = $(CPP) $(a_flags) -o $@ $< | 354 | cmd_cpp_s_S = $(CPP) $(a_flags) -o $@ $< |
| 319 | 355 | ||
| @@ -321,7 +357,37 @@ $(obj)/%.s: $(src)/%.S FORCE | |||
| 321 | $(call if_changed_dep,cpp_s_S) | 357 | $(call if_changed_dep,cpp_s_S) |
| 322 | 358 | ||
| 323 | quiet_cmd_as_o_S = AS $(quiet_modtag) $@ | 359 | quiet_cmd_as_o_S = AS $(quiet_modtag) $@ |
| 324 | cmd_as_o_S = $(CC) $(a_flags) -c -o $@ $< | 360 | |
| 361 | ifndef CONFIG_MODVERSIONS | ||
| 362 | cmd_as_o_S = $(CC) $(a_flags) -c -o $@ $< | ||
| 363 | |||
| 364 | else | ||
| 365 | |||
| 366 | ASM_PROTOTYPES := $(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/asm-prototypes.h) | ||
| 367 | |||
| 368 | ifeq ($(ASM_PROTOTYPES),) | ||
| 369 | cmd_as_o_S = $(CC) $(a_flags) -c -o $@ $< | ||
| 370 | |||
| 371 | else | ||
| 372 | |||
| 373 | # versioning matches the C process described above, with difference that | ||
| 374 | # we parse asm-prototypes.h C header to get function definitions. | ||
| 375 | |||
| 376 | cmd_as_o_S = $(CC) $(a_flags) -c -o $(@D)/.tmp_$(@F) $< | ||
| 377 | |||
| 378 | cmd_modversions_S = \ | ||
| 379 | if $(OBJDUMP) -h $(@D)/.tmp_$(@F) | grep -q __ksymtab; then \ | ||
| 380 | $(call cmd_gensymtypes_S,$(KBUILD_SYMTYPES),$(@:.o=.symtypes)) \ | ||
| 381 | > $(@D)/.tmp_$(@F:.o=.ver); \ | ||
| 382 | \ | ||
| 383 | $(LD) $(LDFLAGS) -r -o $@ $(@D)/.tmp_$(@F) \ | ||
| 384 | -T $(@D)/.tmp_$(@F:.o=.ver); \ | ||
| 385 | rm -f $(@D)/.tmp_$(@F) $(@D)/.tmp_$(@F:.o=.ver); \ | ||
| 386 | else \ | ||
| 387 | mv -f $(@D)/.tmp_$(@F) $@; \ | ||
| 388 | fi; | ||
| 389 | endif | ||
| 390 | endif | ||
| 325 | 391 | ||
| 326 | $(obj)/%.o: $(src)/%.S $(objtool_obj) FORCE | 392 | $(obj)/%.o: $(src)/%.S $(objtool_obj) FORCE |
| 327 | $(call if_changed_rule,as_o_S) | 393 | $(call if_changed_rule,as_o_S) |
| @@ -430,6 +496,9 @@ cmd_export_list = $(OBJDUMP) -h $< | \ | |||
| 430 | 496 | ||
| 431 | $(obj)/lib-ksyms.o: $(lib-target) FORCE | 497 | $(obj)/lib-ksyms.o: $(lib-target) FORCE |
| 432 | $(call if_changed,export_list) | 498 | $(call if_changed,export_list) |
| 499 | |||
| 500 | targets += $(obj)/lib-ksyms.o | ||
| 501 | |||
| 433 | endif | 502 | endif |
| 434 | 503 | ||
| 435 | # | 504 | # |
diff --git a/scripts/gcc-x86_64-has-stack-protector.sh b/scripts/gcc-x86_64-has-stack-protector.sh index 973e8c141567..17867e723a51 100755 --- a/scripts/gcc-x86_64-has-stack-protector.sh +++ b/scripts/gcc-x86_64-has-stack-protector.sh | |||
| @@ -1,6 +1,6 @@ | |||
| 1 | #!/bin/sh | 1 | #!/bin/sh |
| 2 | 2 | ||
| 3 | echo "int foo(void) { char X[200]; return 3; }" | $* -S -x c -c -O0 -mcmodel=kernel -fstack-protector - -o - 2> /dev/null | grep -q "%gs" | 3 | echo "int foo(void) { char X[200]; return 3; }" | $* -S -x c -c -O0 -mcmodel=kernel -fno-PIE -fstack-protector - -o - 2> /dev/null | grep -q "%gs" |
| 4 | if [ "$?" -eq "0" ] ; then | 4 | if [ "$?" -eq "0" ] ; then |
| 5 | echo y | 5 | echo y |
| 6 | else | 6 | else |
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 2f909dd8b7b8..ea81c08ddc7a 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c | |||
| @@ -6907,8 +6907,6 @@ static const struct hda_fixup alc662_fixups[] = { | |||
| 6907 | .v.pins = (const struct hda_pintbl[]) { | 6907 | .v.pins = (const struct hda_pintbl[]) { |
| 6908 | { 0x15, 0x40f000f0 }, /* disabled */ | 6908 | { 0x15, 0x40f000f0 }, /* disabled */ |
| 6909 | { 0x16, 0x40f000f0 }, /* disabled */ | 6909 | { 0x16, 0x40f000f0 }, /* disabled */ |
| 6910 | { 0x18, 0x01014011 }, /* LO */ | ||
| 6911 | { 0x1a, 0x01014012 }, /* LO */ | ||
| 6912 | { } | 6910 | { } |
| 6913 | } | 6911 | } |
| 6914 | }, | 6912 | }, |
diff --git a/sound/pci/hda/thinkpad_helper.c b/sound/pci/hda/thinkpad_helper.c index 6a23302297c9..4d9d320a7971 100644 --- a/sound/pci/hda/thinkpad_helper.c +++ b/sound/pci/hda/thinkpad_helper.c | |||
| @@ -13,7 +13,8 @@ static void (*old_vmaster_hook)(void *, int); | |||
| 13 | static bool is_thinkpad(struct hda_codec *codec) | 13 | static bool is_thinkpad(struct hda_codec *codec) |
| 14 | { | 14 | { |
| 15 | return (codec->core.subsystem_id >> 16 == 0x17aa) && | 15 | return (codec->core.subsystem_id >> 16 == 0x17aa) && |
| 16 | (acpi_dev_found("LEN0068") || acpi_dev_found("IBM0068")); | 16 | (acpi_dev_found("LEN0068") || acpi_dev_found("LEN0268") || |
| 17 | acpi_dev_found("IBM0068")); | ||
| 17 | } | 18 | } |
| 18 | 19 | ||
| 19 | static void update_tpacpi_mute_led(void *private_data, int enabled) | 20 | static void update_tpacpi_mute_led(void *private_data, int enabled) |
diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platform.c index 07000f53db44..b392e51de94d 100644 --- a/sound/soc/qcom/lpass-platform.c +++ b/sound/soc/qcom/lpass-platform.c | |||
| @@ -75,6 +75,7 @@ static int lpass_platform_pcmops_open(struct snd_pcm_substream *substream) | |||
| 75 | data->i2s_port = cpu_dai->driver->id; | 75 | data->i2s_port = cpu_dai->driver->id; |
| 76 | runtime->private_data = data; | 76 | runtime->private_data = data; |
| 77 | 77 | ||
| 78 | dma_ch = 0; | ||
| 78 | if (v->alloc_dma_channel) | 79 | if (v->alloc_dma_channel) |
| 79 | dma_ch = v->alloc_dma_channel(drvdata, dir); | 80 | dma_ch = v->alloc_dma_channel(drvdata, dir); |
| 80 | if (dma_ch < 0) | 81 | if (dma_ch < 0) |
diff --git a/sound/usb/card.c b/sound/usb/card.c index 9e5276d6dda0..2ddc034673a8 100644 --- a/sound/usb/card.c +++ b/sound/usb/card.c | |||
| @@ -315,7 +315,8 @@ static int snd_usb_audio_free(struct snd_usb_audio *chip) | |||
| 315 | snd_usb_endpoint_free(ep); | 315 | snd_usb_endpoint_free(ep); |
| 316 | 316 | ||
| 317 | mutex_destroy(&chip->mutex); | 317 | mutex_destroy(&chip->mutex); |
| 318 | dev_set_drvdata(&chip->dev->dev, NULL); | 318 | if (!atomic_read(&chip->shutdown)) |
| 319 | dev_set_drvdata(&chip->dev->dev, NULL); | ||
| 319 | kfree(chip); | 320 | kfree(chip); |
| 320 | return 0; | 321 | return 0; |
| 321 | } | 322 | } |
diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index 4ffff7be9299..a53fef0c673b 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c | |||
| @@ -1337,8 +1337,8 @@ static int hist_browser__show_hierarchy_entry(struct hist_browser *browser, | |||
| 1337 | } | 1337 | } |
| 1338 | 1338 | ||
| 1339 | if (first) { | 1339 | if (first) { |
| 1340 | ui_browser__printf(&browser->b, "%c", folded_sign); | 1340 | ui_browser__printf(&browser->b, "%c ", folded_sign); |
| 1341 | width--; | 1341 | width -= 2; |
| 1342 | first = false; | 1342 | first = false; |
| 1343 | } else { | 1343 | } else { |
| 1344 | ui_browser__printf(&browser->b, " "); | 1344 | ui_browser__printf(&browser->b, " "); |
| @@ -1361,8 +1361,10 @@ static int hist_browser__show_hierarchy_entry(struct hist_browser *browser, | |||
| 1361 | width -= hpp.buf - s; | 1361 | width -= hpp.buf - s; |
| 1362 | } | 1362 | } |
| 1363 | 1363 | ||
| 1364 | ui_browser__write_nstring(&browser->b, "", hierarchy_indent); | 1364 | if (!first) { |
| 1365 | width -= hierarchy_indent; | 1365 | ui_browser__write_nstring(&browser->b, "", hierarchy_indent); |
| 1366 | width -= hierarchy_indent; | ||
| 1367 | } | ||
| 1366 | 1368 | ||
| 1367 | if (column >= browser->b.horiz_scroll) { | 1369 | if (column >= browser->b.horiz_scroll) { |
| 1368 | char s[2048]; | 1370 | char s[2048]; |
| @@ -1381,7 +1383,13 @@ static int hist_browser__show_hierarchy_entry(struct hist_browser *browser, | |||
| 1381 | } | 1383 | } |
| 1382 | 1384 | ||
| 1383 | perf_hpp_list__for_each_format(entry->hpp_list, fmt) { | 1385 | perf_hpp_list__for_each_format(entry->hpp_list, fmt) { |
| 1384 | ui_browser__write_nstring(&browser->b, "", 2); | 1386 | if (first) { |
| 1387 | ui_browser__printf(&browser->b, "%c ", folded_sign); | ||
| 1388 | first = false; | ||
| 1389 | } else { | ||
| 1390 | ui_browser__write_nstring(&browser->b, "", 2); | ||
| 1391 | } | ||
| 1392 | |||
| 1385 | width -= 2; | 1393 | width -= 2; |
| 1386 | 1394 | ||
| 1387 | /* | 1395 | /* |
| @@ -1555,10 +1563,11 @@ static int hists_browser__scnprintf_hierarchy_headers(struct hist_browser *brows | |||
| 1555 | int indent = hists->nr_hpp_node - 2; | 1563 | int indent = hists->nr_hpp_node - 2; |
| 1556 | bool first_node, first_col; | 1564 | bool first_node, first_col; |
| 1557 | 1565 | ||
| 1558 | ret = scnprintf(buf, size, " "); | 1566 | ret = scnprintf(buf, size, " "); |
| 1559 | if (advance_hpp_check(&dummy_hpp, ret)) | 1567 | if (advance_hpp_check(&dummy_hpp, ret)) |
| 1560 | return ret; | 1568 | return ret; |
| 1561 | 1569 | ||
| 1570 | first_node = true; | ||
| 1562 | /* the first hpp_list_node is for overhead columns */ | 1571 | /* the first hpp_list_node is for overhead columns */ |
| 1563 | fmt_node = list_first_entry(&hists->hpp_formats, | 1572 | fmt_node = list_first_entry(&hists->hpp_formats, |
| 1564 | struct perf_hpp_list_node, list); | 1573 | struct perf_hpp_list_node, list); |
| @@ -1573,12 +1582,16 @@ static int hists_browser__scnprintf_hierarchy_headers(struct hist_browser *brows | |||
| 1573 | ret = scnprintf(dummy_hpp.buf, dummy_hpp.size, " "); | 1582 | ret = scnprintf(dummy_hpp.buf, dummy_hpp.size, " "); |
| 1574 | if (advance_hpp_check(&dummy_hpp, ret)) | 1583 | if (advance_hpp_check(&dummy_hpp, ret)) |
| 1575 | break; | 1584 | break; |
| 1585 | |||
| 1586 | first_node = false; | ||
| 1576 | } | 1587 | } |
| 1577 | 1588 | ||
| 1578 | ret = scnprintf(dummy_hpp.buf, dummy_hpp.size, "%*s", | 1589 | if (!first_node) { |
| 1579 | indent * HIERARCHY_INDENT, ""); | 1590 | ret = scnprintf(dummy_hpp.buf, dummy_hpp.size, "%*s", |
| 1580 | if (advance_hpp_check(&dummy_hpp, ret)) | 1591 | indent * HIERARCHY_INDENT, ""); |
| 1581 | return ret; | 1592 | if (advance_hpp_check(&dummy_hpp, ret)) |
| 1593 | return ret; | ||
| 1594 | } | ||
| 1582 | 1595 | ||
| 1583 | first_node = true; | 1596 | first_node = true; |
| 1584 | list_for_each_entry_continue(fmt_node, &hists->hpp_formats, list) { | 1597 | list_for_each_entry_continue(fmt_node, &hists->hpp_formats, list) { |
| @@ -2076,8 +2089,21 @@ void hist_browser__init(struct hist_browser *browser, | |||
| 2076 | browser->b.use_navkeypressed = true; | 2089 | browser->b.use_navkeypressed = true; |
| 2077 | browser->show_headers = symbol_conf.show_hist_headers; | 2090 | browser->show_headers = symbol_conf.show_hist_headers; |
| 2078 | 2091 | ||
| 2079 | hists__for_each_format(hists, fmt) | 2092 | if (symbol_conf.report_hierarchy) { |
| 2093 | struct perf_hpp_list_node *fmt_node; | ||
| 2094 | |||
| 2095 | /* count overhead columns (in the first node) */ | ||
| 2096 | fmt_node = list_first_entry(&hists->hpp_formats, | ||
| 2097 | struct perf_hpp_list_node, list); | ||
| 2098 | perf_hpp_list__for_each_format(&fmt_node->hpp, fmt) | ||
| 2099 | ++browser->b.columns; | ||
| 2100 | |||
| 2101 | /* add a single column for whole hierarchy sort keys*/ | ||
| 2080 | ++browser->b.columns; | 2102 | ++browser->b.columns; |
| 2103 | } else { | ||
| 2104 | hists__for_each_format(hists, fmt) | ||
| 2105 | ++browser->b.columns; | ||
| 2106 | } | ||
| 2081 | 2107 | ||
| 2082 | hists__reset_column_width(hists); | 2108 | hists__reset_column_width(hists); |
| 2083 | } | 2109 | } |
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c index b02992efb513..a69f027368ef 100644 --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c | |||
| @@ -1600,18 +1600,18 @@ static void hists__hierarchy_output_resort(struct hists *hists, | |||
| 1600 | if (prog) | 1600 | if (prog) |
| 1601 | ui_progress__update(prog, 1); | 1601 | ui_progress__update(prog, 1); |
| 1602 | 1602 | ||
| 1603 | hists->nr_entries++; | ||
| 1604 | if (!he->filtered) { | ||
| 1605 | hists->nr_non_filtered_entries++; | ||
| 1606 | hists__calc_col_len(hists, he); | ||
| 1607 | } | ||
| 1608 | |||
| 1603 | if (!he->leaf) { | 1609 | if (!he->leaf) { |
| 1604 | hists__hierarchy_output_resort(hists, prog, | 1610 | hists__hierarchy_output_resort(hists, prog, |
| 1605 | &he->hroot_in, | 1611 | &he->hroot_in, |
| 1606 | &he->hroot_out, | 1612 | &he->hroot_out, |
| 1607 | min_callchain_hits, | 1613 | min_callchain_hits, |
| 1608 | use_callchain); | 1614 | use_callchain); |
| 1609 | hists->nr_entries++; | ||
| 1610 | if (!he->filtered) { | ||
| 1611 | hists->nr_non_filtered_entries++; | ||
| 1612 | hists__calc_col_len(hists, he); | ||
| 1613 | } | ||
| 1614 | |||
| 1615 | continue; | 1615 | continue; |
| 1616 | } | 1616 | } |
| 1617 | 1617 | ||
diff --git a/tools/power/acpi/Makefile.config b/tools/power/acpi/Makefile.config index a538ff44b108..a1883bbb0144 100644 --- a/tools/power/acpi/Makefile.config +++ b/tools/power/acpi/Makefile.config | |||
| @@ -8,18 +8,19 @@ | |||
| 8 | # as published by the Free Software Foundation; version 2 | 8 | # as published by the Free Software Foundation; version 2 |
| 9 | # of the License. | 9 | # of the License. |
| 10 | 10 | ||
| 11 | include ../../../../scripts/Makefile.include | 11 | ifeq ($(srctree),) |
| 12 | 12 | srctree := $(patsubst %/,%,$(dir $(shell pwd))) | |
| 13 | OUTPUT=./ | 13 | srctree := $(patsubst %/,%,$(dir $(srctree))) |
| 14 | ifeq ("$(origin O)", "command line") | 14 | #$(info Determined 'srctree' to be $(srctree)) |
| 15 | OUTPUT := $(O)/ | ||
| 16 | endif | 15 | endif |
| 17 | 16 | ||
| 18 | ifneq ($(OUTPUT),) | 17 | include $(srctree)/../../scripts/Makefile.include |
| 19 | # check that the output directory actually exists | 18 | |
| 20 | OUTDIR := $(shell cd $(OUTPUT) && /bin/pwd) | 19 | OUTPUT=$(srctree)/ |
| 21 | $(if $(OUTDIR),, $(error output directory "$(OUTPUT)" does not exist)) | 20 | ifeq ("$(origin O)", "command line") |
| 21 | OUTPUT := $(O)/power/acpi/ | ||
| 22 | endif | 22 | endif |
| 23 | #$(info Determined 'OUTPUT' to be $(OUTPUT)) | ||
| 23 | 24 | ||
| 24 | # --- CONFIGURATION BEGIN --- | 25 | # --- CONFIGURATION BEGIN --- |
| 25 | 26 | ||
| @@ -70,8 +71,8 @@ WARNINGS := -Wall | |||
| 70 | WARNINGS += $(call cc-supports,-Wstrict-prototypes) | 71 | WARNINGS += $(call cc-supports,-Wstrict-prototypes) |
| 71 | WARNINGS += $(call cc-supports,-Wdeclaration-after-statement) | 72 | WARNINGS += $(call cc-supports,-Wdeclaration-after-statement) |
| 72 | 73 | ||
| 73 | KERNEL_INCLUDE := ../../../include | 74 | KERNEL_INCLUDE := $(OUTPUT)include |
| 74 | ACPICA_INCLUDE := ../../../drivers/acpi/acpica | 75 | ACPICA_INCLUDE := $(srctree)/../../../drivers/acpi/acpica |
| 75 | CFLAGS += -D_LINUX -I$(KERNEL_INCLUDE) -I$(ACPICA_INCLUDE) | 76 | CFLAGS += -D_LINUX -I$(KERNEL_INCLUDE) -I$(ACPICA_INCLUDE) |
| 76 | CFLAGS += $(WARNINGS) | 77 | CFLAGS += $(WARNINGS) |
| 77 | 78 | ||
diff --git a/tools/power/acpi/Makefile.rules b/tools/power/acpi/Makefile.rules index ec87a9e562c0..373738338f51 100644 --- a/tools/power/acpi/Makefile.rules +++ b/tools/power/acpi/Makefile.rules | |||
| @@ -8,28 +8,42 @@ | |||
| 8 | # as published by the Free Software Foundation; version 2 | 8 | # as published by the Free Software Foundation; version 2 |
| 9 | # of the License. | 9 | # of the License. |
| 10 | 10 | ||
| 11 | $(OUTPUT)$(TOOL): $(TOOL_OBJS) FORCE | 11 | objdir := $(OUTPUT)tools/$(TOOL)/ |
| 12 | $(ECHO) " LD " $@ | 12 | toolobjs := $(addprefix $(objdir),$(TOOL_OBJS)) |
| 13 | $(QUIET) $(LD) $(CFLAGS) $(LDFLAGS) $(TOOL_OBJS) -L$(OUTPUT) -o $@ | 13 | $(OUTPUT)$(TOOL): $(toolobjs) FORCE |
| 14 | $(ECHO) " LD " $(subst $(OUTPUT),,$@) | ||
| 15 | $(QUIET) $(LD) $(CFLAGS) $(LDFLAGS) $(toolobjs) -L$(OUTPUT) -o $@ | ||
| 16 | $(ECHO) " STRIP " $(subst $(OUTPUT),,$@) | ||
| 14 | $(QUIET) $(STRIPCMD) $@ | 17 | $(QUIET) $(STRIPCMD) $@ |
| 15 | 18 | ||
| 16 | $(OUTPUT)%.o: %.c | 19 | $(KERNEL_INCLUDE): |
| 17 | $(ECHO) " CC " $@ | 20 | $(ECHO) " MKDIR " $(subst $(OUTPUT),,$@) |
| 21 | $(QUIET) mkdir -p $(KERNEL_INCLUDE) | ||
| 22 | $(ECHO) " CP " $(subst $(OUTPUT),,$@) | ||
| 23 | $(QUIET) cp -rf $(srctree)/../../../include/acpi $(KERNEL_INCLUDE)/ | ||
| 24 | |||
| 25 | $(objdir)%.o: %.c $(KERNEL_INCLUDE) | ||
| 26 | $(ECHO) " CC " $(subst $(OUTPUT),,$@) | ||
| 18 | $(QUIET) $(CC) -c $(CFLAGS) -o $@ $< | 27 | $(QUIET) $(CC) -c $(CFLAGS) -o $@ $< |
| 19 | 28 | ||
| 20 | all: $(OUTPUT)$(TOOL) | 29 | all: $(OUTPUT)$(TOOL) |
| 21 | clean: | 30 | clean: |
| 22 | -find $(OUTPUT) \( -not -type d \) \ | 31 | $(ECHO) " RMOBJ " $(subst $(OUTPUT),,$(objdir)) |
| 23 | -and \( -name '*~' -o -name '*.[oas]' \) \ | 32 | $(QUIET) find $(objdir) \( -not -type d \)\ |
| 24 | -type f -print \ | 33 | -and \( -name '*~' -o -name '*.[oas]' \)\ |
| 25 | | xargs rm -f | 34 | -type f -print | xargs rm -f |
| 26 | -rm -f $(OUTPUT)$(TOOL) | 35 | $(ECHO) " RM " $(TOOL) |
| 36 | $(QUIET) rm -f $(OUTPUT)$(TOOL) | ||
| 37 | $(ECHO) " RMINC " $(subst $(OUTPUT),,$(KERNEL_INCLUDE)) | ||
| 38 | $(QUIET) rm -rf $(KERNEL_INCLUDE) | ||
| 27 | 39 | ||
| 28 | install-tools: | 40 | install-tools: |
| 29 | $(INSTALL) -d $(DESTDIR)${sbindir} | 41 | $(ECHO) " INST " $(TOOL) |
| 30 | $(INSTALL_PROGRAM) $(OUTPUT)$(TOOL) $(DESTDIR)${sbindir} | 42 | $(QUIET) $(INSTALL) -d $(DESTDIR)$(sbindir) |
| 43 | $(QUIET) $(INSTALL_PROGRAM) $(OUTPUT)$(TOOL) $(DESTDIR)$(sbindir) | ||
| 31 | uninstall-tools: | 44 | uninstall-tools: |
| 32 | - rm -f $(DESTDIR)${sbindir}/$(TOOL) | 45 | $(ECHO) " UNINST " $(TOOL) |
| 46 | $(QUIET) rm -f $(DESTDIR)$(sbindir)/$(TOOL) | ||
| 33 | 47 | ||
| 34 | install: all install-tools $(EXTRA_INSTALL) | 48 | install: all install-tools $(EXTRA_INSTALL) |
| 35 | uninstall: uninstall-tools $(EXTRA_UNINSTALL) | 49 | uninstall: uninstall-tools $(EXTRA_UNINSTALL) |
diff --git a/tools/power/acpi/tools/acpidbg/Makefile b/tools/power/acpi/tools/acpidbg/Makefile index 352df4b41ae9..f2d06e773eb4 100644 --- a/tools/power/acpi/tools/acpidbg/Makefile +++ b/tools/power/acpi/tools/acpidbg/Makefile | |||
| @@ -17,9 +17,7 @@ vpath %.c \ | |||
| 17 | ../../os_specific/service_layers\ | 17 | ../../os_specific/service_layers\ |
| 18 | . | 18 | . |
| 19 | CFLAGS += -DACPI_APPLICATION -DACPI_SINGLE_THREAD -DACPI_DEBUGGER\ | 19 | CFLAGS += -DACPI_APPLICATION -DACPI_SINGLE_THREAD -DACPI_DEBUGGER\ |
| 20 | -I.\ | 20 | -I. |
| 21 | -I../../../../../drivers/acpi/acpica\ | ||
| 22 | -I../../../../../include | ||
| 23 | LDFLAGS += -lpthread | 21 | LDFLAGS += -lpthread |
| 24 | TOOL_OBJS = \ | 22 | TOOL_OBJS = \ |
| 25 | acpidbg.o | 23 | acpidbg.o |
diff --git a/tools/power/acpi/tools/acpidbg/acpidbg.c b/tools/power/acpi/tools/acpidbg/acpidbg.c index a88ac45b7756..4308362d7068 100644 --- a/tools/power/acpi/tools/acpidbg/acpidbg.c +++ b/tools/power/acpi/tools/acpidbg/acpidbg.c | |||
| @@ -12,10 +12,16 @@ | |||
| 12 | #include <acpi/acpi.h> | 12 | #include <acpi/acpi.h> |
| 13 | 13 | ||
| 14 | /* Headers not included by include/acpi/platform/aclinux.h */ | 14 | /* Headers not included by include/acpi/platform/aclinux.h */ |
| 15 | #include <unistd.h> | ||
| 16 | #include <stdio.h> | ||
| 17 | #include <stdlib.h> | ||
| 18 | #include <string.h> | ||
| 19 | #include <error.h> | ||
| 15 | #include <stdbool.h> | 20 | #include <stdbool.h> |
| 16 | #include <fcntl.h> | 21 | #include <fcntl.h> |
| 17 | #include <assert.h> | 22 | #include <assert.h> |
| 18 | #include <linux/circ_buf.h> | 23 | #include <sys/select.h> |
| 24 | #include "../../../../../include/linux/circ_buf.h" | ||
| 19 | 25 | ||
| 20 | #define ACPI_AML_FILE "/sys/kernel/debug/acpi/acpidbg" | 26 | #define ACPI_AML_FILE "/sys/kernel/debug/acpi/acpidbg" |
| 21 | #define ACPI_AML_SEC_TICK 1 | 27 | #define ACPI_AML_SEC_TICK 1 |
diff --git a/tools/power/acpi/tools/acpidump/Makefile b/tools/power/acpi/tools/acpidump/Makefile index 04b5db7c7c0b..f7c7af1f9258 100644 --- a/tools/power/acpi/tools/acpidump/Makefile +++ b/tools/power/acpi/tools/acpidump/Makefile | |||
| @@ -19,9 +19,7 @@ vpath %.c \ | |||
| 19 | ./\ | 19 | ./\ |
| 20 | ../../common\ | 20 | ../../common\ |
| 21 | ../../os_specific/service_layers | 21 | ../../os_specific/service_layers |
| 22 | CFLAGS += -DACPI_DUMP_APP -I.\ | 22 | CFLAGS += -DACPI_DUMP_APP -I. |
| 23 | -I../../../../../drivers/acpi/acpica\ | ||
| 24 | -I../../../../../include | ||
| 25 | TOOL_OBJS = \ | 23 | TOOL_OBJS = \ |
| 26 | apdump.o\ | 24 | apdump.o\ |
| 27 | apfiles.o\ | 25 | apfiles.o\ |
| @@ -49,7 +47,9 @@ TOOL_OBJS = \ | |||
| 49 | 47 | ||
| 50 | include ../../Makefile.rules | 48 | include ../../Makefile.rules |
| 51 | 49 | ||
| 52 | install-man: ../../man/acpidump.8 | 50 | install-man: $(srctree)/man/acpidump.8 |
| 53 | $(INSTALL_DATA) -D $< $(DESTDIR)${mandir}/man8/acpidump.8 | 51 | $(ECHO) " INST " acpidump.8 |
| 52 | $(QUIET) $(INSTALL_DATA) -D $< $(DESTDIR)$(mandir)/man8/acpidump.8 | ||
| 54 | uninstall-man: | 53 | uninstall-man: |
| 55 | - rm -f $(DESTDIR)${mandir}/man8/acpidump.8 | 54 | $(ECHO) " UNINST " acpidump.8 |
| 55 | $(QUIET) rm -f $(DESTDIR)$(mandir)/man8/acpidump.8 | ||
