diff options
| -rw-r--r-- | fs/btrfs/ioctl.c | 28 |
1 files changed, 26 insertions, 2 deletions
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 775640475e35..6e09fc1c1c18 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c | |||
| @@ -1990,8 +1990,20 @@ static noinline int copy_to_sk(struct btrfs_root *root, | |||
| 1990 | if (!key_in_sk(key, sk)) | 1990 | if (!key_in_sk(key, sk)) |
| 1991 | continue; | 1991 | continue; |
| 1992 | 1992 | ||
| 1993 | if (sizeof(sh) + item_len > buf_size) | 1993 | if (sizeof(sh) + item_len > buf_size) { |
| 1994 | if (*num_found) { | ||
| 1995 | ret = 1; | ||
| 1996 | goto out; | ||
| 1997 | } | ||
| 1998 | |||
| 1999 | /* | ||
| 2000 | * return one empty item back for v1, which does not | ||
| 2001 | * handle -EOVERFLOW | ||
| 2002 | */ | ||
| 2003 | |||
| 1994 | item_len = 0; | 2004 | item_len = 0; |
| 2005 | ret = -EOVERFLOW; | ||
| 2006 | } | ||
| 1995 | 2007 | ||
| 1996 | if (sizeof(sh) + item_len + *sk_offset > buf_size) { | 2008 | if (sizeof(sh) + item_len + *sk_offset > buf_size) { |
| 1997 | ret = 1; | 2009 | ret = 1; |
| @@ -2017,6 +2029,9 @@ static noinline int copy_to_sk(struct btrfs_root *root, | |||
| 2017 | } | 2029 | } |
| 2018 | (*num_found)++; | 2030 | (*num_found)++; |
| 2019 | 2031 | ||
| 2032 | if (ret) /* -EOVERFLOW from above */ | ||
| 2033 | goto out; | ||
| 2034 | |||
| 2020 | if (*num_found >= sk->nr_items) { | 2035 | if (*num_found >= sk->nr_items) { |
| 2021 | ret = 1; | 2036 | ret = 1; |
| 2022 | goto out; | 2037 | goto out; |
| @@ -2095,7 +2110,8 @@ static noinline int search_ioctl(struct inode *inode, | |||
| 2095 | break; | 2110 | break; |
| 2096 | 2111 | ||
| 2097 | } | 2112 | } |
| 2098 | ret = 0; | 2113 | if (ret > 0) |
| 2114 | ret = 0; | ||
| 2099 | err: | 2115 | err: |
| 2100 | sk->nr_items = num_found; | 2116 | sk->nr_items = num_found; |
| 2101 | btrfs_free_path(path); | 2117 | btrfs_free_path(path); |
| @@ -2118,6 +2134,14 @@ static noinline int btrfs_ioctl_tree_search(struct file *file, | |||
| 2118 | 2134 | ||
| 2119 | inode = file_inode(file); | 2135 | inode = file_inode(file); |
| 2120 | ret = search_ioctl(inode, &args->key, sizeof(args->buf), args->buf); | 2136 | ret = search_ioctl(inode, &args->key, sizeof(args->buf), args->buf); |
| 2137 | |||
| 2138 | /* | ||
| 2139 | * In the origin implementation an overflow is handled by returning a | ||
| 2140 | * search header with a len of zero, so reset ret. | ||
| 2141 | */ | ||
| 2142 | if (ret == -EOVERFLOW) | ||
| 2143 | ret = 0; | ||
| 2144 | |||
| 2121 | if (ret == 0 && copy_to_user(argp, args, sizeof(*args))) | 2145 | if (ret == 0 && copy_to_user(argp, args, sizeof(*args))) |
| 2122 | ret = -EFAULT; | 2146 | ret = -EFAULT; |
| 2123 | kfree(args); | 2147 | kfree(args); |
