2 files changed, 11 insertions, 5 deletions

diff --git a/drivers/gpu/drm/i915/intel_bios.h b/drivers/gpu/drm/i915/intel_bios.h
index 8405b5a367d7..7e3545f65257 100644
--- a/drivers/gpu/drm/i915/intel_bios.h
+++ b/drivers/gpu/drm/i915/intel_bios.h
@@ -46,14 +46,20 @@ struct edp_power_seq {
         u16 t11_t12;
 } __packed;
 
-/* MIPI Sequence Block definitions */
+/*
+ * MIPI Sequence Block definitions
+ *
+ * Note the VBT spec has AssertReset / DeassertReset swapped from their
+ * usual naming, we use the proper names here to avoid confusion when
+ * reading the code.
+ */
 enum mipi_seq {
         MIPI_SEQ_END = 0,
-        MIPI_SEQ_ASSERT_RESET,
+        MIPI_SEQ_DEASSERT_RESET,        /* Spec says MipiAssertResetPin */
         MIPI_SEQ_INIT_OTP,
         MIPI_SEQ_DISPLAY_ON,
         MIPI_SEQ_DISPLAY_OFF,
-        MIPI_SEQ_DEASSERT_RESET,
+        MIPI_SEQ_ASSERT_RESET,          /* Spec says MipiDeassertResetPin */
         MIPI_SEQ_BACKLIGHT_ON,          /* sequence block v2+ */
         MIPI_SEQ_BACKLIGHT_OFF,         /* sequence block v2+ */
         MIPI_SEQ_TEAR_ON,               /* sequence block v2+ */
diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
index 0d8ff0034b88..579d2f570717 100644
--- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
+++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
@@ -376,11 +376,11 @@ static const fn_mipi_elem_exec exec_elem[] = {
  */
 
 static const char * const seq_name[] = {
-        [MIPI_SEQ_ASSERT_RESET] = "MIPI_SEQ_ASSERT_RESET",
+        [MIPI_SEQ_DEASSERT_RESET] = "MIPI_SEQ_DEASSERT_RESET",
         [MIPI_SEQ_INIT_OTP] = "MIPI_SEQ_INIT_OTP",
         [MIPI_SEQ_DISPLAY_ON] = "MIPI_SEQ_DISPLAY_ON",
         [MIPI_SEQ_DISPLAY_OFF]  = "MIPI_SEQ_DISPLAY_OFF",
-        [MIPI_SEQ_DEASSERT_RESET] = "MIPI_SEQ_DEASSERT_RESET",
+        [MIPI_SEQ_ASSERT_RESET] = "MIPI_SEQ_ASSERT_RESET",
         [MIPI_SEQ_BACKLIGHT_ON] = "MIPI_SEQ_BACKLIGHT_ON",
         [MIPI_SEQ_BACKLIGHT_OFF] = "MIPI_SEQ_BACKLIGHT_OFF",
         [MIPI_SEQ_TEAR_ON] = "MIPI_SEQ_TEAR_ON",