diff options
| -rw-r--r-- | drivers/char/ipmi/ipmi_msghandler.c | 1 | ||||
| -rw-r--r-- | drivers/char/ipmi/ipmi_powernv.c | 4 | ||||
| -rw-r--r-- | drivers/char/ipmi/ipmi_si_intf.c | 1 | ||||
| -rw-r--r-- | drivers/char/ipmi/ipmi_ssif.c | 19 | ||||
| -rw-r--r-- | include/linux/ipmi_smi.h | 1 |
5 files changed, 1 insertions, 25 deletions
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index 9157a9e17c36..ee108be13348 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c | |||
| @@ -3112,7 +3112,6 @@ EXPORT_SYMBOL(ipmi_poll_interface); | |||
| 3112 | 3112 | ||
| 3113 | int ipmi_register_smi(const struct ipmi_smi_handlers *handlers, | 3113 | int ipmi_register_smi(const struct ipmi_smi_handlers *handlers, |
| 3114 | void *send_info, | 3114 | void *send_info, |
| 3115 | struct ipmi_device_id *device_id, | ||
| 3116 | struct device *si_dev, | 3115 | struct device *si_dev, |
| 3117 | unsigned char slave_addr) | 3116 | unsigned char slave_addr) |
| 3118 | { | 3117 | { |
diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c index b338a4becbf8..07fddbefefe4 100644 --- a/drivers/char/ipmi/ipmi_powernv.c +++ b/drivers/char/ipmi/ipmi_powernv.c | |||
| @@ -23,7 +23,6 @@ | |||
| 23 | 23 | ||
| 24 | struct ipmi_smi_powernv { | 24 | struct ipmi_smi_powernv { |
| 25 | u64 interface_id; | 25 | u64 interface_id; |
| 26 | struct ipmi_device_id ipmi_id; | ||
| 27 | ipmi_smi_t intf; | 26 | ipmi_smi_t intf; |
| 28 | unsigned int irq; | 27 | unsigned int irq; |
| 29 | 28 | ||
| @@ -266,8 +265,7 @@ static int ipmi_powernv_probe(struct platform_device *pdev) | |||
| 266 | } | 265 | } |
| 267 | 266 | ||
| 268 | /* todo: query actual ipmi_device_id */ | 267 | /* todo: query actual ipmi_device_id */ |
| 269 | rc = ipmi_register_smi(&ipmi_powernv_smi_handlers, ipmi, | 268 | rc = ipmi_register_smi(&ipmi_powernv_smi_handlers, ipmi, dev, 0); |
| 270 | &ipmi->ipmi_id, dev, 0); | ||
| 271 | if (rc) { | 269 | if (rc) { |
| 272 | dev_warn(dev, "IPMI SMI registration failed (%d)\n", rc); | 270 | dev_warn(dev, "IPMI SMI registration failed (%d)\n", rc); |
| 273 | goto err_free_msg; | 271 | goto err_free_msg; |
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index bc99369fca49..4caa793a6765 100644 --- a/drivers/char/ipmi/ipmi_si_intf.c +++ b/drivers/char/ipmi/ipmi_si_intf.c | |||
| @@ -3631,7 +3631,6 @@ static int try_smi_init(struct smi_info *new_smi) | |||
| 3631 | 3631 | ||
| 3632 | rv = ipmi_register_smi(&handlers, | 3632 | rv = ipmi_register_smi(&handlers, |
| 3633 | new_smi, | 3633 | new_smi, |
| 3634 | &new_smi->device_id, | ||
| 3635 | new_smi->dev, | 3634 | new_smi->dev, |
| 3636 | new_smi->slave_addr); | 3635 | new_smi->slave_addr); |
| 3637 | if (rv) { | 3636 | if (rv) { |
diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c index 20ab098cd661..dd716d06ce73 100644 --- a/drivers/char/ipmi/ipmi_ssif.c +++ b/drivers/char/ipmi/ipmi_ssif.c | |||
| @@ -267,9 +267,6 @@ struct ssif_info { | |||
| 267 | unsigned char *i2c_data; | 267 | unsigned char *i2c_data; |
| 268 | unsigned int i2c_size; | 268 | unsigned int i2c_size; |
| 269 | 269 | ||
| 270 | /* From the device id response. */ | ||
| 271 | struct ipmi_device_id device_id; | ||
| 272 | |||
| 273 | struct timer_list retry_timer; | 270 | struct timer_list retry_timer; |
| 274 | int retries_left; | 271 | int retries_left; |
| 275 | 272 | ||
| @@ -1481,21 +1478,6 @@ static int ssif_probe(struct i2c_client *client, const struct i2c_device_id *id) | |||
| 1481 | ipmi_addr_src_to_str(ssif_info->addr_source), | 1478 | ipmi_addr_src_to_str(ssif_info->addr_source), |
| 1482 | client->addr, client->adapter->name, slave_addr); | 1479 | client->addr, client->adapter->name, slave_addr); |
| 1483 | 1480 | ||
| 1484 | /* | ||
| 1485 | * Do a Get Device ID command, since it comes back with some | ||
| 1486 | * useful info. | ||
| 1487 | */ | ||
| 1488 | msg[0] = IPMI_NETFN_APP_REQUEST << 2; | ||
| 1489 | msg[1] = IPMI_GET_DEVICE_ID_CMD; | ||
| 1490 | rv = do_cmd(client, 2, msg, &len, resp); | ||
| 1491 | if (rv) | ||
| 1492 | goto out; | ||
| 1493 | |||
| 1494 | rv = ipmi_demangle_device_id(resp[0] >> 2, resp[1], | ||
| 1495 | resp + 2, len - 2, &ssif_info->device_id); | ||
| 1496 | if (rv) | ||
| 1497 | goto out; | ||
| 1498 | |||
| 1499 | ssif_info->client = client; | 1481 | ssif_info->client = client; |
| 1500 | i2c_set_clientdata(client, ssif_info); | 1482 | i2c_set_clientdata(client, ssif_info); |
| 1501 | 1483 | ||
| @@ -1685,7 +1667,6 @@ static int ssif_probe(struct i2c_client *client, const struct i2c_device_id *id) | |||
| 1685 | 1667 | ||
| 1686 | rv = ipmi_register_smi(&ssif_info->handlers, | 1668 | rv = ipmi_register_smi(&ssif_info->handlers, |
| 1687 | ssif_info, | 1669 | ssif_info, |
| 1688 | &ssif_info->device_id, | ||
| 1689 | &ssif_info->client->dev, | 1670 | &ssif_info->client->dev, |
| 1690 | slave_addr); | 1671 | slave_addr); |
| 1691 | if (rv) { | 1672 | if (rv) { |
diff --git a/include/linux/ipmi_smi.h b/include/linux/ipmi_smi.h index 75542c837c07..97771e36b7f0 100644 --- a/include/linux/ipmi_smi.h +++ b/include/linux/ipmi_smi.h | |||
| @@ -214,7 +214,6 @@ static inline int ipmi_demangle_device_id(uint8_t netfn, uint8_t cmd, | |||
| 214 | call. */ | 214 | call. */ |
| 215 | int ipmi_register_smi(const struct ipmi_smi_handlers *handlers, | 215 | int ipmi_register_smi(const struct ipmi_smi_handlers *handlers, |
| 216 | void *send_info, | 216 | void *send_info, |
| 217 | struct ipmi_device_id *device_id, | ||
| 218 | struct device *dev, | 217 | struct device *dev, |
| 219 | unsigned char slave_addr); | 218 | unsigned char slave_addr); |
| 220 | 219 | ||
