diff options
-rw-r--r-- | drivers/staging/unisys/include/timskmod.h | 2 | ||||
-rw-r--r-- | drivers/staging/unisys/uislib/uisqueue.c | 1 | ||||
-rw-r--r-- | drivers/staging/unisys/visorchipset/parser.c | 4 | ||||
-rw-r--r-- | drivers/staging/unisys/visorchipset/visorchipset_main.c | 12 |
4 files changed, 6 insertions, 13 deletions
diff --git a/drivers/staging/unisys/include/timskmod.h b/drivers/staging/unisys/include/timskmod.h index 41cbcde7c15c..1101ecd85fc6 100644 --- a/drivers/staging/unisys/include/timskmod.h +++ b/drivers/staging/unisys/include/timskmod.h | |||
@@ -122,8 +122,6 @@ typedef long VMMIO32;/**< #VMMIO pointing to 32-bit data */ | |||
122 | #define RETTRACE(x) | 122 | #define RETTRACE(x) |
123 | #endif | 123 | #endif |
124 | 124 | ||
125 | /** return from a void function, using a common exit point "Away" */ | ||
126 | #define RETVOID do { RETTRACE(0); goto Away; } while (0) | ||
127 | /** return from an int function, using a common exit point "Away" | 125 | /** return from an int function, using a common exit point "Away" |
128 | * @param x the value to return | 126 | * @param x the value to return |
129 | */ | 127 | */ |
diff --git a/drivers/staging/unisys/uislib/uisqueue.c b/drivers/staging/unisys/uislib/uisqueue.c index 7bd05f7fe5ef..91b03ed829ef 100644 --- a/drivers/staging/unisys/uislib/uisqueue.c +++ b/drivers/staging/unisys/uislib/uisqueue.c | |||
@@ -28,7 +28,6 @@ | |||
28 | #define CURRENT_FILE_PC UISLIB_PC_uisqueue_c | 28 | #define CURRENT_FILE_PC UISLIB_PC_uisqueue_c |
29 | #define __MYFILE__ "uisqueue.c" | 29 | #define __MYFILE__ "uisqueue.c" |
30 | 30 | ||
31 | #define RETVOID do { goto Away; } while (0) | ||
32 | #define RETINT(x) do { rc = (x); goto Away; } while (0) | 31 | #define RETINT(x) do { rc = (x); goto Away; } while (0) |
33 | 32 | ||
34 | #define CHECK_CACHE_ALIGN 0 | 33 | #define CHECK_CACHE_ALIGN 0 |
diff --git a/drivers/staging/unisys/visorchipset/parser.c b/drivers/staging/unisys/visorchipset/parser.c index 6904dcce312b..b408d415bd8c 100644 --- a/drivers/staging/unisys/visorchipset/parser.c +++ b/drivers/staging/unisys/visorchipset/parser.c | |||
@@ -213,7 +213,7 @@ parser_param_start(PARSER_CONTEXT *ctx, PARSER_WHICH_STRING which_string) | |||
213 | if (ctx == NULL) { | 213 | if (ctx == NULL) { |
214 | ERRDRV("%s (%s:%d) - no context", | 214 | ERRDRV("%s (%s:%d) - no context", |
215 | __func__, __FILE__, __LINE__); | 215 | __func__, __FILE__, __LINE__); |
216 | RETVOID; | 216 | goto Away; |
217 | } | 217 | } |
218 | phdr = (ULTRA_CONTROLVM_PARAMETERS_HEADER *) (ctx->data); | 218 | phdr = (ULTRA_CONTROLVM_PARAMETERS_HEADER *) (ctx->data); |
219 | switch (which_string) { | 219 | switch (which_string) { |
@@ -235,10 +235,8 @@ parser_param_start(PARSER_CONTEXT *ctx, PARSER_WHICH_STRING which_string) | |||
235 | break; | 235 | break; |
236 | default: | 236 | default: |
237 | ERRDRV("%s - bad which_string %d", __func__, which_string); | 237 | ERRDRV("%s - bad which_string %d", __func__, which_string); |
238 | RETVOID; | ||
239 | break; | 238 | break; |
240 | } | 239 | } |
241 | RETVOID; | ||
242 | 240 | ||
243 | Away: | 241 | Away: |
244 | return; | 242 | return; |
diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/visorchipset/visorchipset_main.c index b769257d3aa8..b2355d930488 100644 --- a/drivers/staging/unisys/visorchipset/visorchipset_main.c +++ b/drivers/staging/unisys/visorchipset/visorchipset_main.c | |||
@@ -1927,12 +1927,12 @@ controlvm_periodic_work(struct work_struct *work) | |||
1927 | 1927 | ||
1928 | /* make sure visorbus server is registered for controlvm callbacks */ | 1928 | /* make sure visorbus server is registered for controlvm callbacks */ |
1929 | if (visorchipset_serverregwait && !serverregistered) | 1929 | if (visorchipset_serverregwait && !serverregistered) |
1930 | RETVOID; | 1930 | goto Away; |
1931 | /* make sure visorclientbus server is regsitered for controlvm | 1931 | /* make sure visorclientbus server is regsitered for controlvm |
1932 | * callbacks | 1932 | * callbacks |
1933 | */ | 1933 | */ |
1934 | if (visorchipset_clientregwait && !clientregistered) | 1934 | if (visorchipset_clientregwait && !clientregistered) |
1935 | RETVOID; | 1935 | goto Away; |
1936 | 1936 | ||
1937 | memset(&chanInfo, 0, sizeof(VISORCHIPSET_CHANNEL_INFO)); | 1937 | memset(&chanInfo, 0, sizeof(VISORCHIPSET_CHANNEL_INFO)); |
1938 | if (!ControlVm_channel) { | 1938 | if (!ControlVm_channel) { |
@@ -1963,7 +1963,7 @@ controlvm_periodic_work(struct work_struct *work) | |||
1963 | if ((ControlVm_channel != NULL) || (Poll_Count >= 250)) | 1963 | if ((ControlVm_channel != NULL) || (Poll_Count >= 250)) |
1964 | ; /* keep going */ | 1964 | ; /* keep going */ |
1965 | else | 1965 | else |
1966 | RETVOID; | 1966 | goto Away; |
1967 | 1967 | ||
1968 | /* Check events to determine if response to CHIPSET_READY | 1968 | /* Check events to determine if response to CHIPSET_READY |
1969 | * should be sent | 1969 | * should be sent |
@@ -2033,8 +2033,6 @@ controlvm_periodic_work(struct work_struct *work) | |||
2033 | /* parahotplug_worker */ | 2033 | /* parahotplug_worker */ |
2034 | parahotplug_process_list(); | 2034 | parahotplug_process_list(); |
2035 | 2035 | ||
2036 | RETVOID; | ||
2037 | |||
2038 | Away: | 2036 | Away: |
2039 | 2037 | ||
2040 | if (time_after(jiffies, | 2038 | if (time_after(jiffies, |
@@ -2071,13 +2069,13 @@ setup_crash_devices_work_queue(struct work_struct *work) | |||
2071 | 2069 | ||
2072 | /* make sure visorbus server is registered for controlvm callbacks */ | 2070 | /* make sure visorbus server is registered for controlvm callbacks */ |
2073 | if (visorchipset_serverregwait && !serverregistered) | 2071 | if (visorchipset_serverregwait && !serverregistered) |
2074 | RETVOID; | 2072 | goto Away; |
2075 | 2073 | ||
2076 | /* make sure visorclientbus server is regsitered for controlvm | 2074 | /* make sure visorclientbus server is regsitered for controlvm |
2077 | * callbacks | 2075 | * callbacks |
2078 | */ | 2076 | */ |
2079 | if (visorchipset_clientregwait && !clientregistered) | 2077 | if (visorchipset_clientregwait && !clientregistered) |
2080 | RETVOID; | 2078 | goto Away; |
2081 | 2079 | ||
2082 | POSTCODE_LINUX_2(CRASH_DEV_ENTRY_PC, POSTCODE_SEVERITY_INFO); | 2080 | POSTCODE_LINUX_2(CRASH_DEV_ENTRY_PC, POSTCODE_SEVERITY_INFO); |
2083 | 2081 | ||