diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2018-05-28 13:24:45 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2018-06-04 09:28:53 -0400 |
commit | f178fd2d498eccbf6592ace72b9f235f0e58c77d (patch) | |
tree | 7a603c7fd487ee73c2d0dcd8c4b7d36fcad0b10c /tools/perf/builtin-annotate.c | |
parent | cd0cccbae9f654479a1c5abcd876c7fc4356b882 (diff) |
perf annotate: Move objdump_path to struct annotation_options
One more step in grouping annotation options.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: https://lkml.kernel.org/n/tip-sogzdhugoavm6fyw60jnb0vs@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-annotate.c')
-rw-r--r-- | tools/perf/builtin-annotate.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c index 2339ae719e1d..5eb22cc56363 100644 --- a/tools/perf/builtin-annotate.c +++ b/tools/perf/builtin-annotate.c | |||
@@ -388,8 +388,9 @@ static int __cmd_annotate(struct perf_annotate *ann) | |||
388 | goto out; | 388 | goto out; |
389 | } | 389 | } |
390 | 390 | ||
391 | if (!objdump_path) { | 391 | if (!ann->opts.objdump_path) { |
392 | ret = perf_env__lookup_objdump(&session->header.env); | 392 | ret = perf_env__lookup_objdump(&session->header.env, |
393 | &ann->opts.objdump_path); | ||
393 | if (ret) | 394 | if (ret) |
394 | goto out; | 395 | goto out; |
395 | } | 396 | } |
@@ -521,7 +522,7 @@ int cmd_annotate(int argc, const char **argv) | |||
521 | "Display raw encoding of assembly instructions (default)"), | 522 | "Display raw encoding of assembly instructions (default)"), |
522 | OPT_STRING('M', "disassembler-style", &annotate.opts.disassembler_style, "disassembler style", | 523 | OPT_STRING('M', "disassembler-style", &annotate.opts.disassembler_style, "disassembler style", |
523 | "Specify disassembler style (e.g. -M intel for intel syntax)"), | 524 | "Specify disassembler style (e.g. -M intel for intel syntax)"), |
524 | OPT_STRING(0, "objdump", &objdump_path, "path", | 525 | OPT_STRING(0, "objdump", &annotate.opts.objdump_path, "path", |
525 | "objdump binary to use for disassembly and annotations"), | 526 | "objdump binary to use for disassembly and annotations"), |
526 | OPT_BOOLEAN(0, "group", &symbol_conf.event_group, | 527 | OPT_BOOLEAN(0, "group", &symbol_conf.event_group, |
527 | "Show event group information together"), | 528 | "Show event group information together"), |