diff options
| author | Josh Poimboeuf <jpoimboe@redhat.com> | 2019-08-29 19:28:49 -0400 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2019-09-10 02:49:52 -0400 |
| commit | f73b3cc39c84220e6dccd463b5c8279b03514646 (patch) | |
| tree | 4f7143f630b50732245e9efead38ae9920e7dbe6 /tools/objtool | |
| parent | f74c2bb98776e2de508f4d607cd519873065118e (diff) | |
objtool: Clobber user CFLAGS variable
If the build user has the CFLAGS variable set in their environment,
objtool blindly appends to it, which can cause unexpected behavior.
Clobber CFLAGS to ensure consistent objtool compilation behavior.
Reported-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Tested-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/83a276df209962e6058fcb6c615eef9d401c21bc.1567121311.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'tools/objtool')
| -rw-r--r-- | tools/objtool/Makefile | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile index 88158239622b..20f67fcf378d 100644 --- a/tools/objtool/Makefile +++ b/tools/objtool/Makefile | |||
| @@ -35,7 +35,7 @@ INCLUDES := -I$(srctree)/tools/include \ | |||
| 35 | -I$(srctree)/tools/arch/$(HOSTARCH)/include/uapi \ | 35 | -I$(srctree)/tools/arch/$(HOSTARCH)/include/uapi \ |
| 36 | -I$(srctree)/tools/objtool/arch/$(ARCH)/include | 36 | -I$(srctree)/tools/objtool/arch/$(ARCH)/include |
| 37 | WARNINGS := $(EXTRA_WARNINGS) -Wno-switch-default -Wno-switch-enum -Wno-packed | 37 | WARNINGS := $(EXTRA_WARNINGS) -Wno-switch-default -Wno-switch-enum -Wno-packed |
| 38 | CFLAGS += -Werror $(WARNINGS) $(KBUILD_HOSTCFLAGS) -g $(INCLUDES) $(LIBELF_FLAGS) | 38 | CFLAGS := -Werror $(WARNINGS) $(KBUILD_HOSTCFLAGS) -g $(INCLUDES) $(LIBELF_FLAGS) |
| 39 | LDFLAGS += $(LIBELF_LIBS) $(LIBSUBCMD) $(KBUILD_HOSTLDFLAGS) | 39 | LDFLAGS += $(LIBELF_LIBS) $(LIBSUBCMD) $(KBUILD_HOSTLDFLAGS) |
| 40 | 40 | ||
| 41 | # Allow old libelf to be used: | 41 | # Allow old libelf to be used: |