bpf: libbpf: Provide basic API support to specify BPF obj name

This patch extends the libbpf to provide API support to
allow specifying BPF object name.

In tools/lib/bpf/libbpf, the C symbol of the function
and the map is used.  Regarding section name, all maps are
under the same section named "maps".  Hence, section name
is not a good choice for map's name.  To be consistent with
map, bpf_prog also follows and uses its function symbol as
the prog's name.

This patch adds logic to collect function's symbols in libbpf.
There is existing codes to collect the map's symbols and no change
is needed.

The bpf_load_program_name() and bpf_map_create_name() are
added to take the name argument.  For the other bpf_map_create_xxx()
variants, a name argument is directly added to them.

In samples/bpf, bpf_load.c in particular, the symbol is also
used as the map's name and the map symbols has already been
collected in the existing code.  For bpf_prog, bpf_load.c does
not collect the function symbol name.  We can consider to collect
them later if there is a need to continue supporting the bpf_load.c.

Signed-off-by: Martin KaFai Lau <kafai@fb.com>
Acked-by: Alexei Starovoitov <ast@fb.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 44 insertions, 13 deletions

diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c
index 1d6907d379c9..daf624e4c720 100644
--- a/tools/lib/bpf/bpf.c
+++ b/tools/lib/bpf/bpf.c
@@ -46,6 +46,8 @@
 # endif
 #endif
 
+#define min(x, y) ((x) < (y) ? (x) : (y))
+
 static inline __u64 ptr_to_u64(const void *ptr)
 {
         return (__u64) (unsigned long) ptr;
@@ -57,10 +59,11 @@ static inline int sys_bpf(enum bpf_cmd cmd, union bpf_attr *attr,
         return syscall(__NR_bpf, cmd, attr, size);
 }
 
-int bpf_create_map_node(enum bpf_map_type map_type, int key_size,
-                        int value_size, int max_entries, __u32 map_flags,
-                        int node)
+int bpf_create_map_node(enum bpf_map_type map_type, const char *name,
+                        int key_size, int value_size, int max_entries,
+                        __u32 map_flags, int node)
 {
+        __u32 name_len = name ? strlen(name) : 0;
         union bpf_attr attr;
 
         memset(&attr, '\0', sizeof(attr));
@@ -70,6 +73,8 @@ int bpf_create_map_node(enum bpf_map_type map_type, int key_size,
         attr.value_size = value_size;
         attr.max_entries = max_entries;
         attr.map_flags = map_flags;
+        memcpy(attr.map_name, name, min(name_len, BPF_OBJ_NAME_LEN - 1));
+
         if (node >= 0) {
                 attr.map_flags |= BPF_F_NUMA_NODE;
                 attr.numa_node = node;
@@ -81,14 +86,23 @@ int bpf_create_map_node(enum bpf_map_type map_type, int key_size,
 int bpf_create_map(enum bpf_map_type map_type, int key_size,
                    int value_size, int max_entries, __u32 map_flags)
 {
-        return bpf_create_map_node(map_type, key_size, value_size,
+        return bpf_create_map_node(map_type, NULL, key_size, value_size,
                                    max_entries, map_flags, -1);
 }
 
-int bpf_create_map_in_map_node(enum bpf_map_type map_type, int key_size,
-                               int inner_map_fd, int max_entries,
+int bpf_create_map_name(enum bpf_map_type map_type, const char *name,
+                        int key_size, int value_size, int max_entries,
+                        __u32 map_flags)
+{
+        return bpf_create_map_node(map_type, name, key_size, value_size,
+                                   max_entries, map_flags, -1);
+}
+
+int bpf_create_map_in_map_node(enum bpf_map_type map_type, const char *name,
+                               int key_size, int inner_map_fd, int max_entries,
                                __u32 map_flags, int node)
 {
+        __u32 name_len = name ? strlen(name) : 0;
         union bpf_attr attr;
 
         memset(&attr, '\0', sizeof(attr));
@@ -99,6 +113,8 @@ int bpf_create_map_in_map_node(enum bpf_map_type map_type, int key_size,
         attr.inner_map_fd = inner_map_fd;
         attr.max_entries = max_entries;
         attr.map_flags = map_flags;
+        memcpy(attr.map_name, name, min(name_len, BPF_OBJ_NAME_LEN - 1));
+
         if (node >= 0) {
                 attr.map_flags |= BPF_F_NUMA_NODE;
                 attr.numa_node = node;
@@ -107,19 +123,24 @@ int bpf_create_map_in_map_node(enum bpf_map_type map_type, int key_size,
         return sys_bpf(BPF_MAP_CREATE, &attr, sizeof(attr));
 }
 
-int bpf_create_map_in_map(enum bpf_map_type map_type, int key_size,
-                          int inner_map_fd, int max_entries, __u32 map_flags)
+int bpf_create_map_in_map(enum bpf_map_type map_type, const char *name,
+                          int key_size, int inner_map_fd, int max_entries,
+                          __u32 map_flags)
 {
-        return bpf_create_map_in_map_node(map_type, key_size, inner_map_fd,
-                                          max_entries, map_flags, -1);
+        return bpf_create_map_in_map_node(map_type, name, key_size,
+                                          inner_map_fd, max_entries, map_flags,
+                                          -1);
 }
 
-int bpf_load_program(enum bpf_prog_type type, const struct bpf_insn *insns,
-                     size_t insns_cnt, const char *license,
-                     __u32 kern_version, char *log_buf, size_t log_buf_sz)
+int bpf_load_program_name(enum bpf_prog_type type, const char *name,
+                          const struct bpf_insn *insns,
+                          size_t insns_cnt, const char *license,
+                          __u32 kern_version, char *log_buf,
+                          size_t log_buf_sz)
 {
         int fd;
         union bpf_attr attr;
+        __u32 name_len = name ? strlen(name) : 0;
 
         bzero(&attr, sizeof(attr));
         attr.prog_type = type;
@@ -130,6 +151,7 @@ int bpf_load_program(enum bpf_prog_type type, const struct bpf_insn *insns,
         attr.log_size = 0;
         attr.log_level = 0;
         attr.kern_version = kern_version;
+        memcpy(attr.prog_name, name, min(name_len, BPF_OBJ_NAME_LEN - 1));
 
         fd = sys_bpf(BPF_PROG_LOAD, &attr, sizeof(attr));
         if (fd >= 0 || !log_buf || !log_buf_sz)
@@ -143,6 +165,15 @@ int bpf_load_program(enum bpf_prog_type type, const struct bpf_insn *insns,
         return sys_bpf(BPF_PROG_LOAD, &attr, sizeof(attr));
 }
 
+int bpf_load_program(enum bpf_prog_type type, const struct bpf_insn *insns,
+                     size_t insns_cnt, const char *license,
+                     __u32 kern_version, char *log_buf,
+                     size_t log_buf_sz)
+{
+        return bpf_load_program_name(type, NULL, insns, insns_cnt, license,
+                                     kern_version, log_buf, log_buf_sz);
+}
+
 int bpf_verify_program(enum bpf_prog_type type, const struct bpf_insn *insns,
                        size_t insns_cnt, int strict_alignment,
                        const char *license, __u32 kern_version,