diff options
author | Joe Perches <joe@perches.com> | 2018-05-23 15:20:59 -0400 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2018-05-28 05:27:20 -0400 |
commit | 6a73cf46ce9d1b382ea14d74ce4bc9aa0c52337a (patch) | |
tree | 801677ceb97963e89f337795fbeafb8a8869d38c /sound/drivers | |
parent | 84eaaef2ae196ccdac0154a9a9daac95b9b367fd (diff) |
sound: Use octal not symbolic permissions
Convert the S_<FOO> symbolic permissions to their octal equivalents as
using octal and not symbolic permissions is preferred by many as more
readable.
see: https://lkml.org/lkml/2016/8/2/1945
Done with automated conversion via:
$ ./scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace <files...>
Miscellanea:
o Wrapped one multi-line call to a single line
Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/drivers')
-rw-r--r-- | sound/drivers/dummy.c | 2 | ||||
-rw-r--r-- | sound/drivers/mts64.c | 6 | ||||
-rw-r--r-- | sound/drivers/opl4/opl4_proc.c | 2 | ||||
-rw-r--r-- | sound/drivers/portman2x4.c | 6 |
4 files changed, 8 insertions, 8 deletions
diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c index 8fb9a54fe8ba..9af154db530a 100644 --- a/sound/drivers/dummy.c +++ b/sound/drivers/dummy.c | |||
@@ -1042,7 +1042,7 @@ static void dummy_proc_init(struct snd_dummy *chip) | |||
1042 | if (!snd_card_proc_new(chip->card, "dummy_pcm", &entry)) { | 1042 | if (!snd_card_proc_new(chip->card, "dummy_pcm", &entry)) { |
1043 | snd_info_set_text_ops(entry, chip, dummy_proc_read); | 1043 | snd_info_set_text_ops(entry, chip, dummy_proc_read); |
1044 | entry->c.text.write = dummy_proc_write; | 1044 | entry->c.text.write = dummy_proc_write; |
1045 | entry->mode |= S_IWUSR; | 1045 | entry->mode |= 0200; |
1046 | entry->private_data = chip; | 1046 | entry->private_data = chip; |
1047 | } | 1047 | } |
1048 | } | 1048 | } |
diff --git a/sound/drivers/mts64.c b/sound/drivers/mts64.c index f32e81342247..b68e71ca7abd 100644 --- a/sound/drivers/mts64.c +++ b/sound/drivers/mts64.c | |||
@@ -41,11 +41,11 @@ static bool enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP; | |||
41 | static struct platform_device *platform_devices[SNDRV_CARDS]; | 41 | static struct platform_device *platform_devices[SNDRV_CARDS]; |
42 | static int device_count; | 42 | static int device_count; |
43 | 43 | ||
44 | module_param_array(index, int, NULL, S_IRUGO); | 44 | module_param_array(index, int, NULL, 0444); |
45 | MODULE_PARM_DESC(index, "Index value for " CARD_NAME " soundcard."); | 45 | MODULE_PARM_DESC(index, "Index value for " CARD_NAME " soundcard."); |
46 | module_param_array(id, charp, NULL, S_IRUGO); | 46 | module_param_array(id, charp, NULL, 0444); |
47 | MODULE_PARM_DESC(id, "ID string for " CARD_NAME " soundcard."); | 47 | MODULE_PARM_DESC(id, "ID string for " CARD_NAME " soundcard."); |
48 | module_param_array(enable, bool, NULL, S_IRUGO); | 48 | module_param_array(enable, bool, NULL, 0444); |
49 | MODULE_PARM_DESC(enable, "Enable " CARD_NAME " soundcard."); | 49 | MODULE_PARM_DESC(enable, "Enable " CARD_NAME " soundcard."); |
50 | 50 | ||
51 | MODULE_AUTHOR("Matthias Koenig <mk@phasorlab.de>"); | 51 | MODULE_AUTHOR("Matthias Koenig <mk@phasorlab.de>"); |
diff --git a/sound/drivers/opl4/opl4_proc.c b/sound/drivers/opl4/opl4_proc.c index cd2c07fa2ef4..16b24091d799 100644 --- a/sound/drivers/opl4/opl4_proc.c +++ b/sound/drivers/opl4/opl4_proc.c | |||
@@ -104,7 +104,7 @@ int snd_opl4_create_proc(struct snd_opl4 *opl4) | |||
104 | if (entry) { | 104 | if (entry) { |
105 | if (opl4->hardware < OPL3_HW_OPL4_ML) { | 105 | if (opl4->hardware < OPL3_HW_OPL4_ML) { |
106 | /* OPL4 can access 4 MB external ROM/SRAM */ | 106 | /* OPL4 can access 4 MB external ROM/SRAM */ |
107 | entry->mode |= S_IWUSR; | 107 | entry->mode |= 0200; |
108 | entry->size = 4 * 1024 * 1024; | 108 | entry->size = 4 * 1024 * 1024; |
109 | } else { | 109 | } else { |
110 | /* OPL4-ML has 1 MB internal ROM */ | 110 | /* OPL4-ML has 1 MB internal ROM */ |
diff --git a/sound/drivers/portman2x4.c b/sound/drivers/portman2x4.c index ec8a94325ef6..3cdf0a88d71b 100644 --- a/sound/drivers/portman2x4.c +++ b/sound/drivers/portman2x4.c | |||
@@ -60,11 +60,11 @@ static bool enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP; | |||
60 | static struct platform_device *platform_devices[SNDRV_CARDS]; | 60 | static struct platform_device *platform_devices[SNDRV_CARDS]; |
61 | static int device_count; | 61 | static int device_count; |
62 | 62 | ||
63 | module_param_array(index, int, NULL, S_IRUGO); | 63 | module_param_array(index, int, NULL, 0444); |
64 | MODULE_PARM_DESC(index, "Index value for " CARD_NAME " soundcard."); | 64 | MODULE_PARM_DESC(index, "Index value for " CARD_NAME " soundcard."); |
65 | module_param_array(id, charp, NULL, S_IRUGO); | 65 | module_param_array(id, charp, NULL, 0444); |
66 | MODULE_PARM_DESC(id, "ID string for " CARD_NAME " soundcard."); | 66 | MODULE_PARM_DESC(id, "ID string for " CARD_NAME " soundcard."); |
67 | module_param_array(enable, bool, NULL, S_IRUGO); | 67 | module_param_array(enable, bool, NULL, 0444); |
68 | MODULE_PARM_DESC(enable, "Enable " CARD_NAME " soundcard."); | 68 | MODULE_PARM_DESC(enable, "Enable " CARD_NAME " soundcard."); |
69 | 69 | ||
70 | MODULE_AUTHOR("Levent Guendogdu, Tobias Gehrig, Matthias Koenig"); | 70 | MODULE_AUTHOR("Levent Guendogdu, Tobias Gehrig, Matthias Koenig"); |